From 74f50d821124d5f4baf7e0d2f19f57562e82d194 Mon Sep 17 00:00:00 2001 From: Ann Paul Date: Fri, 23 Oct 2015 08:56:32 -0700 Subject: [PATCH] Iterate over ip addresses only once --- axes/decorators.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/axes/decorators.py b/axes/decorators.py index df2daf6..da246bd 100644 --- a/axes/decorators.py +++ b/axes/decorators.py @@ -106,8 +106,8 @@ def get_ip_address_from_request(request): if not x_forwarded_for.startswith(PRIVATE_IPS_PREFIX) and is_valid_ip(x_forwarded_for): ip_address = x_forwarded_for.strip() else: - ips = [ip.strip() for ip in x_forwarded_for.split(',')] - for ip in ips: + for ip_raw in x_forwarded_for.split(','): + ip = ip_raw.strip() if ip.startswith(PRIVATE_IPS_PREFIX): continue elif not is_valid_ip(ip):