From 416898d2a5f1663706f9d764f8d5278b4b4e35a9 Mon Sep 17 00:00:00 2001 From: Corey Oordt Date: Wed, 4 Jan 2012 23:53:50 -0500 Subject: [PATCH] Changed behavior of (de)activating an item within the change form: Instead of changing all descendants' active status to the current item's, it will only change the descendants' active status if the item is False. As it makes sense to have an item active, but its children inactive, it doesn't make sense that an item is inactive, but its descendants are active. This doesn't change the activate/deactivate admin actions. They will always affect an item and its descendants. --- categories/models.py | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/categories/models.py b/categories/models.py index a39cb29..ed62c52 100644 --- a/categories/models.py +++ b/categories/models.py @@ -107,10 +107,14 @@ class Category(MPTTModel): super(Category, self).save(*args, **kwargs) - for item in self.get_descendants(): - if item.active != self.active: - item.active = self.active - item.save() + # While you can activate an item without activating its descendants, + # It doesn't make sense that you can deactivate an item and have its + # decendants remain active. + if not self.active: + for item in self.get_descendants(): + if item.active != self.active: + item.active = self.active + item.save() class Meta: verbose_name_plural = 'categories'