diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3356e1d..b64f9df 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,7 +47,11 @@ jobs: tox --verbose - name: Upload coverage - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v4 with: - name: Python ${{ matrix.python-version }} + name: coverage-data-${{ matrix.python-version }} + path: ".coverage.*" + include-hidden-files: true + merge-multiple: true fail_ci_if_error: true + token: ${{ secrets.CODECOV_TOKEN }} diff --git a/tests/test_values.py b/tests/test_values.py index 9d7ad39..841635f 100644 --- a/tests/test_values.py +++ b/tests/test_values.py @@ -373,17 +373,23 @@ class ValueTests(TestCase): value = DatabaseURLValue() self.assertEqual(value.default, {}) with env(DATABASE_URL='sqlite://'): - self.assertEqual(value.setup('DATABASE_URL'), { - 'default': { + settings_value = value.setup('DATABASE_URL') + # Compare the embedded dicts in the "default" entry so that the difference can be seen if + # it fails ... DatabaseURLValue(|) uses an external app that can add additional entries + self.assertDictEqual( + { 'CONN_HEALTH_CHECKS': False, 'CONN_MAX_AGE': 0, + 'DISABLE_SERVER_SIDE_CURSORS': False, 'ENGINE': 'django.db.backends.sqlite3', 'HOST': '', 'NAME': ':memory:', 'PASSWORD': '', 'PORT': '', 'USER': '', - }}) + }, + settings_value['default'] + ) def test_database_url_additional_args(self):