From 395efc992f5b2fcc2b6789a61436e9c60c14eb00 Mon Sep 17 00:00:00 2001 From: Camilo Nova Date: Wed, 14 Sep 2016 14:50:39 -0500 Subject: [PATCH] :sunny: Moved the signal to its own file to avoid import errors --- constance/__init__.py | 3 --- constance/backends/database/__init__.py | 5 ++--- constance/backends/redisd.py | 5 ++--- constance/signals.py | 3 +++ docs/index.rst | 2 +- 5 files changed, 8 insertions(+), 10 deletions(-) create mode 100644 constance/signals.py diff --git a/constance/__init__.py b/constance/__init__.py index 5bc18be..a41ca47 100644 --- a/constance/__init__.py +++ b/constance/__init__.py @@ -1,4 +1,3 @@ -import django.dispatch from django.utils.functional import LazyObject __version__ = '1.3' @@ -13,5 +12,3 @@ class LazyConfig(LazyObject): config = LazyConfig() - -updated_signal = django.dispatch.Signal(providing_args=['key', 'value']) diff --git a/constance/backends/database/__init__.py b/constance/backends/database/__init__.py index 6cb5a96..c751a67 100644 --- a/constance/backends/database/__init__.py +++ b/constance/backends/database/__init__.py @@ -4,8 +4,7 @@ from django.core.exceptions import ImproperlyConfigured from django.db.models.signals import post_save from .. import Backend -from ... import settings -from ... import updated_signal +from ... import settings, signals class DatabaseBackend(Backend): @@ -87,7 +86,7 @@ class DatabaseBackend(Backend): if self._cache: self._cache.set(key, value) - updated_signal.send(sender='constance', key=key, value=value) + signals.updated_signal.send(sender='constance', key=key, value=value) def clear(self, sender, instance, created, **kwargs): if self._cache and not created: diff --git a/constance/backends/redisd.py b/constance/backends/redisd.py index 3b24398..f307adf 100644 --- a/constance/backends/redisd.py +++ b/constance/backends/redisd.py @@ -3,8 +3,7 @@ from django.utils import six from django.utils.six.moves import zip from . import Backend -from .. import settings, utils -from .. import updated_signal +from .. import settings, utils, signals try: from cPickle import loads, dumps @@ -50,4 +49,4 @@ class RedisBackend(Backend): def set(self, key, value): self._rd.set(self.add_prefix(key), dumps(value)) - updated_signal.send(sender='constance', key=key, value=value) + signals.updated_signal.send(sender='constance', key=key, value=value) diff --git a/constance/signals.py b/constance/signals.py new file mode 100644 index 0000000..114ceec --- /dev/null +++ b/constance/signals.py @@ -0,0 +1,3 @@ +import django.dispatch + +updated_signal = django.dispatch.Signal(providing_args=['key', 'value']) diff --git a/docs/index.rst b/docs/index.rst index 0a4e25f..c7fde73 100644 --- a/docs/index.rst +++ b/docs/index.rst @@ -78,7 +78,7 @@ You can use it as: .. code-block:: python - from constance import updated_signal + from constance.signals import updated_signal @receiver(updated_signal) def constance_updated(sender, key, value, **kwargs):