Please the PEP8 gods.

This commit is contained in:
Jannis Leidel 2013-04-12 17:39:10 +02:00
parent 36a9c23500
commit 90da7981e5
10 changed files with 32 additions and 17 deletions

View file

@ -22,7 +22,10 @@ from constance import config, settings
NUMERIC_WIDGET = forms.TextInput(attrs={'size': 10})
INTEGER_LIKE = (fields.IntegerField, {'widget': NUMERIC_WIDGET})
STRING_LIKE = (fields.CharField, {'widget': forms.Textarea(attrs={'rows': 3}), 'required': False})
STRING_LIKE = (fields.CharField, {
'widget': forms.Textarea(attrs={'rows': 3}),
'required': False,
})
FIELDS = {
bool: (fields.BooleanField, {'required': False}),
@ -109,10 +112,11 @@ class ConstanceAdmin(admin.ModelAdmin):
'help_text': _(help_text),
'value': localize(value),
'modified': value != default,
'form_field': form[name]
'form_field': form[name],
})
context['config'].sort(key=itemgetter('name'))
context_instance = RequestContext(request, current_app=self.admin_site.name)
context_instance = RequestContext(request,
current_app=self.admin_site.name)
return render_to_response('admin/constance/change_list.html',
context, context_instance=context_instance)
@ -125,8 +129,7 @@ class ConstanceAdmin(admin.ModelAdmin):
def has_change_permission(self, request, obj=None):
if settings.SUPERUSER_ONLY:
return request.user.is_superuser
else:
return super(ConstanceAdmin, self).has_change_permission(request, obj)
return super(ConstanceAdmin, self).has_change_permission(request, obj)
class Config(object):

View file

@ -2,6 +2,7 @@
Defines the base constance backend
"""
class Backend(object):
def get(self, key):

View file

@ -1,5 +1,3 @@
import itertools
from django.core.exceptions import ImproperlyConfigured
from django.db.models.signals import post_save
from django.core.cache import get_cache

View file

@ -8,7 +8,8 @@ class Migration(SchemaMigration):
def forwards(self, orm):
# Adding model 'Constance'
db.create_table('constance_config', (
('id', self.gf('django.db.models.fields.AutoField')(primary_key=True)),
('id', self.gf('django.db.models.fields.AutoField')(
primary_key=True)),
('key', self.gf('django.db.models.fields.TextField')()),
('value', self.gf('picklefield.fields.PickledObjectField')()),
))
@ -20,8 +21,10 @@ class Migration(SchemaMigration):
models = {
'database.constance': {
'Meta': {'object_name': 'Constance', 'db_table': "'constance_config'"},
'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
'Meta': {'object_name': 'Constance',
'db_table': "'constance_config'"},
'id': ('django.db.models.fields.AutoField', [],
{'primary_key': 'True'}),
'key': ('django.db.models.fields.TextField', [], {}),
'value': ('picklefield.fields.PickledObjectField', [], {})
}

View file

@ -7,7 +7,9 @@ class Migration(SchemaMigration):
def forwards(self, orm):
# Changing field 'Constance.key'
db.alter_column('constance_config', 'key', self.gf('django.db.models.fields.CharField')(unique=True, max_length=255))
db.alter_column('constance_config', 'key',
self.gf('django.db.models.fields.CharField')(
unique=True, max_length=255))
# Adding unique constraint on 'Constance', fields ['key']
db.create_unique('constance_config', ['key'])
@ -16,13 +18,17 @@ class Migration(SchemaMigration):
db.delete_unique('constance_config', ['key'])
# Changing field 'Constance.key'
db.alter_column('constance_config', 'key', self.gf('django.db.models.fields.TextField')())
db.alter_column('constance_config', 'key',
self.gf('django.db.models.fields.TextField')())
models = {
'database.constance': {
'Meta': {'object_name': 'Constance', 'db_table': "'constance_config'"},
'id': ('django.db.models.fields.AutoField', [], {'primary_key': 'True'}),
'key': ('django.db.models.fields.CharField', [], {'unique': 'True', 'max_length': '255'}),
'Meta': {'object_name': 'Constance',
'db_table': "'constance_config'"},
'id': ('django.db.models.fields.AutoField', [],
{'primary_key': 'True'}),
'key': ('django.db.models.fields.CharField', [],
{'unique': 'True', 'max_length': '255'}),
'value': ('picklefield.fields.PickledObjectField', [], {})
}
}

View file

@ -1,5 +1,6 @@
from constance import settings, utils
class Config(object):
"""
The global config wrapper that handles the backend.

View file

@ -1,5 +1,6 @@
import constance
def config(request):
"""
Simple context processor that puts the config into every

View file

@ -1,4 +1,4 @@
from django.db.models import get_models, signals
from django.db.models import signals
def create_perm(app, created_models, verbosity, db, **kwargs):

View file

@ -8,7 +8,8 @@ settings = import_module_attr(
REDIS_PREFIX = getattr(settings, 'CONSTANCE_REDIS_PREFIX',
getattr(settings, 'CONSTANCE_PREFIX', 'constance:'))
BACKEND = getattr(settings, 'CONSTANCE_BACKEND', 'constance.backends.redisd.RedisBackend')
BACKEND = getattr(settings, 'CONSTANCE_BACKEND',
'constance.backends.redisd.RedisBackend')
CONFIG = getattr(settings, 'CONSTANCE_CONFIG', {})

View file

@ -1,5 +1,6 @@
from django.utils.importlib import import_module
def import_module_attr(path):
package, module = path.rsplit('.', 1)
return getattr(import_module(package), module)