changes for get_inconsistent_fieldnames(): fields_list can be a dictionary, when a fieldset is defined as collapsible (#433)

Co-authored-by: dalay <ussria@gmail.com>
This commit is contained in:
mandalay-rp 2020-11-18 19:10:31 +03:00 committed by GitHub
parent 4e5573ed95
commit ce37f630f1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -2,7 +2,6 @@ from django.core import checks
from django.utils.translation import ugettext_lazy as _
@checks.register("constance")
def check_fieldsets(*args, **kwargs):
"""
@ -38,8 +37,11 @@ def get_inconsistent_fieldnames():
field_name_list = []
for fieldset_title, fields_list in settings.CONFIG_FIELDSETS.items():
for field_name in fields_list:
field_name_list.append(field_name)
# fields_list can be a dictionary, when a fieldset is defined as collapsible
# https://django-constance.readthedocs.io/en/latest/#fieldsets-collapsing
if isinstance(fields_list, dict) and 'fields' in fields_list:
fields_list = fields_list['fields']
field_name_list += list(fields_list)
if not field_name_list:
return {}
return set(set(settings.CONFIG.keys()) - set(field_name_list))