diff --git a/README.md b/README.md index 379f59e..0eec7e2 100644 --- a/README.md +++ b/README.md @@ -310,7 +310,7 @@ record is created for the failed logins. [Default: ``3``] [Default: ``False``] * ``DEFENDER_LOCK_OUT_BY_IP_AND_USERNAME``: Boolean: Locks a user out based on a combination of IP and Username. This stops a user denying access to the application for all other users accessing the app from behind the same IP address. [Default: ``False``] * ``DEFENDER_DISABLE_IP_LOCKOUT``: Boolean: If this is True, it will not lockout the users IP address, it will only lockout the username. [Default: False] -* ``DISABLE_USERNAME_LOCKOUT``: Boolean: If this is True, it will not lockout usernames, it will only lockout IP addresess. [Default: False] +* ``DEFENDER_DISABLE_USERNAME_LOCKOUT``: Boolean: If this is True, it will not lockout usernames, it will only lockout IP addresess. [Default: False] * ``DEFENDER_COOLOFF_TIME``: Int: If set, defines a period of inactivity after which old failed login attempts will be forgotten. An integer, will be interpreted as a number of seconds. If ``0``, the locks will not expire. [Default: ``300``] diff --git a/defender/tests.py b/defender/tests.py index 27e8e3c..f64206b 100644 --- a/defender/tests.py +++ b/defender/tests.py @@ -666,6 +666,54 @@ class AccessAttemptTest(DefenderTestCase): data_out = utils.get_blocked_ips() self.assertEqual(data_out, []) + @patch('defender.config.DISABLE_USERNAME_LOCKOUT', True) + def test_disable_username_lockout(self): + """Check lockouting still works when we disable username lockout""" + + username = 'testy' + + # try logging in with the same username, but different IPs. + # we shouldn't be locked. + for i in range(0, config.FAILURE_LIMIT+10): + ip = '74.125.126.{0}'.format(i) + response = self._login(username=username, remote_addr=ip) + # Check if we are in the same login page + self.assertContains(response, LOGIN_FORM_KEY) + + # same ip and same username + ip = '74.125.127.1' + for i in range(0, config.FAILURE_LIMIT): + response = self._login(username=username, remote_addr=ip) + # Check if we are in the same login page + self.assertContains(response, LOGIN_FORM_KEY) + + # But we should get one now + # same username and Ip, over the limit. + response = self._login(username=username, remote_addr=ip) + self.assertContains(response, self.LOCKED_MESSAGE) + + # We shouldn't get a lockout message when attempting to use no username + response = self.client.get(ADMIN_LOGIN_URL) + self.assertContains(response, LOGIN_FORM_KEY) + + # We shouldn't get a lockout message when attempting to use a different ip address + # to be sure that username is not blocked. + second_ip = '74.125.127.2' + response = self._login(username=username, remote_addr=second_ip) + # Check if we are in the same login page + self.assertContains(response, LOGIN_FORM_KEY) + + # we should have no usernames are blocked + data_out = utils.get_blocked_usernames() + self.assertEqual(data_out, []) + + # even if we try to manually block one it still won't be in there. + utils.block_username(username) + + # we should still have no ip's blocked + data_out = utils.get_blocked_usernames() + self.assertEqual(data_out, []) + class DefenderTestCaseTest(DefenderTestCase): """Make sure that we're cleaning the cache between tests"""