Hopiu/django-defender
1
0
Fork 0
mirror of https://github.com/jazzband/django-defender.git synced 2026-03-16 22:10:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Only use the username if it is actually provided (#112)

Browse source 
* Only use the username if it is actually provided

* Test that unspecified usernames cannot be blocked

* Added test to prevent Coveralls from complaining about a coverage regression.
This commit is contained in:
Cobus Carstens 2018-02-01 13:30:26 +02:00 committed by Ken Cochrane
parent 2b6374f1da
commit 5aa69bac96
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
defender/tests.py
View file

@ -226,6 +226,23 @@ class AccessAttemptTest(DefenderTestCase):
self.assertNotIn(UPPER_USERNAME, utils.get_blocked_usernames()) self.assertNotIn(UPPER_USERNAME, utils.get_blocked_usernames())
self.assertIn(UPPER_USERNAME.lower(), utils.get_blocked_usernames()) self.assertIn(UPPER_USERNAME.lower(), utils.get_blocked_usernames())
def test_empty_username_cannot_be_blocked(self):
"""
Test that an empty username, or one that is None, cannot be blocked.
"""
for username in ["", None]:
for i in range(0, config.FAILURE_LIMIT + 2):
ip = '74.125.239.{0}.'.format(i)
self._login(username=username, remote_addr=ip)
self.assertNotIn(username, utils.get_blocked_usernames())
def test_lowercase(self):
"""
Test that the lowercase(None) returns None.
"""
self.assertEquals(utils.lower_username(None), None)
def test_cooling_off(self): def test_cooling_off(self):
""" Tests if the cooling time allows a user to login """ Tests if the cooling time allows a user to login
""" """

2
defender/utils.py
View file

@ -202,7 +202,7 @@ def record_failed_attempt(ip_address, username):
ip_block = True ip_block = True
user_block = False user_block = False
if not config.DISABLE_USERNAME_LOCKOUT: if username and not config.DISABLE_USERNAME_LOCKOUT:
user_count = increment_key(get_username_attempt_cache_key(username)) user_count = increment_key(get_username_attempt_cache_key(username))
# if over the limit, add to block # if over the limit, add to block
if user_count > config.FAILURE_LIMIT: if user_count > config.FAILURE_LIMIT: