Hopiu/django-defender
1
0
Fork 0
mirror of https://github.com/jazzband/django-defender.git synced 2026-03-16 22:10:32 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Replace datetime.now with timezone.now (#232)

Browse source 
Use `timezone.now` instead of `datetime.now` when constructing datetime objects. `timezone.now` ensures the timezone-awareness to be consistent with `settings.USE_TZ`
This commit is contained in:
Shen Li 2023-07-13 16:58:47 -04:00 committed by GitHub
parent 2a0469669a
commit 8d4c6840e9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
defender/data.py
View file

@ -1,8 +1,9 @@
from datetime import datetime, timedelta from datetime import timedelta
from defender import config from defender import config
from .models import AccessAttempt from .models import AccessAttempt
from django.db.models import Q from django.db.models import Q
from django.utils import timezone
def store_login_attempt( def store_login_attempt(
@ -39,7 +40,7 @@ def get_approx_account_lockouts_from_login_attempts(ip_address=None, username=No
# None we should return 0. # None we should return 0.
return 0 return 0
q = Q(attempt_time__gte=datetime.now() - timedelta(hours=config.ACCESS_ATTEMPT_EXPIRATION)) q = Q(attempt_time__gte=timezone.now() - timedelta(hours=config.ACCESS_ATTEMPT_EXPIRATION))
failure_limit = config.FAILURE_LIMIT failure_limit = config.FAILURE_LIMIT
if (ip_address and username and config.LOCKOUT_BY_IP_USERNAME \ if (ip_address and username and config.LOCKOUT_BY_IP_USERNAME \
and not config.DISABLE_IP_LOCKOUT and not config.DISABLE_USERNAME_LOCKOUT and not config.DISABLE_IP_LOCKOUT and not config.DISABLE_USERNAME_LOCKOUT
@ -56,4 +57,4 @@ def get_approx_account_lockouts_from_login_attempts(ip_address=None, username=No
# conditions, we're in an inappropriate context. # conditions, we're in an inappropriate context.
raise Exception("Invalid state requested") raise Exception("Invalid state requested")
return AccessAttempt.objects.filter(q).count() // failure_limit return AccessAttempt.objects.filter(q).count() // failure_limit