Hopiu/django-downloadview
1
0
Fork 0
mirror of https://github.com/jazzband/django-downloadview.git synced 2026-05-18 20:41:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Reduced memory usage when serving files: return an iterator of chunks, don't load the whole file into memory.

Browse source
This commit is contained in:
Benoit Bryon 2012-08-28 10:46:02 +02:00
parent ab75aa6e08
commit 5a2a174b3e
1 changed files with 12 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
django_downloadview/views.py
View file

@ -1,5 +1,6 @@
from os.path import abspath, basename
import os
import shutil
from wsgiref.util import FileWrapper
from django.core.files import File
from django.http import HttpResponse
@ -20,16 +21,19 @@ class DownloadMixin(object):
mime_type = self.get_mime_type()
if isinstance(self.file, File):
absolute_filename = self.file.path
wrapper = FileWrapper(self.file.file)
size = self.file.size
else:
absolute_filename = abspath(self.file)
filename = basename(absolute_filename)
response = self.response_class(mimetype=mime_type)
# Open file as read binary.
with open(absolute_filename, 'rb') as f:
shutil.copyfileobj(f, response)
absolute_filename = os.path.abspath(self.file)
wrapper = FileWrapper(file(absolute_filename))
size = os.path.getsize(absolute_filename)
basename = os.path.basename(absolute_filename)
response = self.response_class(wrapper, content_type=mime_type,
mimetype=mime_type)
response['Content-Length'] = size
# Do not call fsock.close() as HttpResponse needs it open
# Garbage collector will close it
response['Content-Disposition'] = 'attachment; filename=%s' % filename
response['Content-Disposition'] = 'attachment; filename=%s' % basename
return response