Hopiu/django-downloadview
1
0
Fork 0
mirror of https://github.com/jazzband/django-downloadview.git synced 2026-03-16 22:40:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Avoid calling get_path() twice inside get_file

Browse source 
Overridden PathDownloadView.get_path() may contain database lookups and logging which should not be called twice if not necessary, as it was in my case.
Because the acquired filename does not change inside get_file(), I replaced the duplicate call.
This commit is contained in:
René Leonhardt 2015-07-14 12:03:52 +02:00
parent 142d8de7fa
commit 75b51ce214
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
django_downloadview/views/path.py
View file

@ -36,4 +36,4 @@ class PathDownloadView(BaseDownloadView):
filename = self.get_path()
if not os.path.isfile(filename):
raise FileNotFound('File "{0}" does not exists'.format(filename))
return File(open(self.get_path(), 'rb'))
return File(open(filename, 'rb'))