From bfb9c3cedbb328bc2a5d9572b57c8803bb899583 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20HUBSCHER?= Date: Mon, 13 Jan 2020 10:46:14 +0100 Subject: [PATCH] Fix flake8 errors. --- django_downloadview/decorators.py | 5 +++-- tests/signature.py | 9 +++++---- tests/views.py | 2 -- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/django_downloadview/decorators.py b/django_downloadview/decorators.py index 7f1f77c..7f014da 100644 --- a/django_downloadview/decorators.py +++ b/django_downloadview/decorators.py @@ -9,7 +9,7 @@ from functools import wraps from django.conf import settings from django.core.exceptions import PermissionDenied -from django.core.signing import TimestampSigner, SignatureExpired, BadSignature +from django.core.signing import BadSignature, SignatureExpired, TimestampSigner class DownloadDecorator(object): @@ -42,7 +42,8 @@ class DownloadDecorator(object): def _signature_is_valid(request): """ - Validator that raises a PermissionDenied error on invalid and mismatching signatures. + Validator that raises a PermissionDenied error on invalid and + mismatching signatures. """ signer = TimestampSigner() diff --git a/tests/signature.py b/tests/signature.py index d60e3aa..e485805 100644 --- a/tests/signature.py +++ b/tests/signature.py @@ -3,7 +3,6 @@ Test signature generation and validation. """ import unittest -from unittest import mock from django.core.exceptions import PermissionDenied from django.core.signing import TimestampSigner @@ -24,7 +23,7 @@ class SignedTestStorage(SignedURLMixin, TestStorage): class SignatureGeneratorTestCase(unittest.TestCase): def test_signed_storage(self): """ - django_downloadview.storage.SignedURLMixin adds X-Signature to URLs + django_downloadview.storage.SignedURLMixin adds X-Signature to URLs. """ storage = SignedTestStorage() @@ -35,7 +34,8 @@ class SignatureGeneratorTestCase(unittest.TestCase): class SignatureValidatorTestCase(unittest.TestCase): def test_verify_signature(self): """ - django_downloadview.decorators._signature_is_valid returns True on valid signatures + django_downloadview.decorators._signature_is_valid returns True on + valid signatures. """ signer = TimestampSigner() @@ -48,7 +48,8 @@ class SignatureValidatorTestCase(unittest.TestCase): def test_verify_signature_invalid(self): """ - django_downloadview.decorators._signature_is_valid raises PermissionDenied on invalid signatures + django_downloadview.decorators._signature_is_valid raises PermissionDenied + on invalid signatures. """ request = unittest.mock.MagicMock() diff --git a/tests/views.py b/tests/views.py index fce3371..e511c48 100644 --- a/tests/views.py +++ b/tests/views.py @@ -5,14 +5,12 @@ import os import unittest from unittest import mock -from django.core.exceptions import PermissionDenied from django.core.files import File from django.http import Http404 from django.http.response import HttpResponseNotModified import django.test from django_downloadview import exceptions, views -from django_downloadview.decorators import signature_required from django_downloadview.test import setup_view