fixes https://github.com/jazzband/django-eav2/issues/163 (#164)

* fixes https://github.com/jazzband/django-eav2/issues/163

* chore: revert content to master

* fix: don't expand relational fields

* chore: ignore .vscode

* chore: update changelog

* chore: remove stale code

Co-authored-by: Mike <mike@zivix.com>
Co-authored-by: Mike <22396211+Dresdn@users.noreply.github.com>

.gitignore

@@ -126,3 +126,8 @@ tags
 
 ## Mac
 .DS_Store
+
+
+## IDE
+.idea
+.vscode

CHANGELOG.md

@@ -8,6 +8,8 @@ We follow [Semantic Versions](https://semver.org/) starting at the `0.14.0` rele
 
 ### Bug Fixes
 
+- Fixes FieldError when filtering on foreign keys [#163](https://github.com/jazzband/django-eav2/issues/163)
+
 ### Misc
 
 ## 1.2.0 (2021-12-18)

eav/queryset.py

@@ -248,17 +248,8 @@ def expand_eav_filter(model_cls, key, value):
 
         return '%s__in' % gr_name, value
 
-    try:
+    # Not an eav field, so keep as is
-        field = model_cls._meta.get_field(fields[0])
+    return key, value
-    except FieldDoesNotExist:
-        return key, value
-
-    if not field.auto_created or field.concrete:
-        return key, value
-    else:
-        sub_key = '__'.join(fields[1:])
-        key, value = expand_eav_filter(field.model, sub_key, value)
-        return '{}__{}'.format(fields[0], key), value
 
 
 class EavQuerySet(QuerySet):

tests/test_queries.py

@@ -6,7 +6,7 @@ from django.test import TestCase
 import eav
 from eav.models import Attribute, EnumGroup, EnumValue, Value
 from eav.registry import EavConfig
-from test_project.models import Encounter, Patient
+from test_project.models import Encounter, Patient, ExampleModel
 
 
 class Queries(TestCase):
@@ -292,3 +292,9 @@ class Queries(TestCase):
         eav.unregister(Patient)
         eav.register(Patient, config_cls=CustomConfig)
         self.assert_order_by_results(eav_attr='data')
+
+    def test_fk_filter(self):
+        e = ExampleModel.objects.create(name='test1')
+        p = Patient.objects.get_or_create(name='Beth', example=e)[0]
+        c = ExampleModel.objects.filter(patient=p)
+        self.assertEqual(c.count(), 1)