Hopiu/django-eav2
1
0
Fork 0
mirror of https://github.com/jazzband/django-eav2.git synced 2026-03-16 22:40:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

refactor(admin): optimize EAV field handling in admin forms

Browse source
This commit is contained in:
Mike 2024-03-06 10:26:34 -07:00 committed by Mike
parent 4d2c080857
commit d6af6a004a
1 changed files with 8 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
eav/admin.py
View file

@ -46,11 +46,13 @@ class BaseEntityAdmin(ModelAdmin):
HttpResponse object representing the rendered change form.
"""
form = context['adminform'].form
media = context['media']
# Identify EAV fields based on the form instance's configuration.
config_cls = form.instance._eav_config_cls
eav_fields = self._get_eav_fields(form.instance) if config_cls else []
eav_fields = self._get_eav_fields(form.instance)
# # Fallback to default if no EAV fields exist
if not eav_fields:
return super().render_change_form(request, context, *args, **kwargs)
# Get the non-EAV fieldsets and then append our own
fieldsets = list(self.get_fieldsets(request, kwargs['obj']))
@ -69,7 +71,7 @@ class BaseEntityAdmin(ModelAdmin):
readonly_fields=self.readonly_fields,
model_admin=self,
)
media = mark_safe(media + adminform.media)
media = mark_safe(context['media'] + adminform.media)
context.update(adminform=adminform, media=media)
return super().render_change_form(request, context, *args, **kwargs)
@ -83,10 +85,8 @@ class BaseEntityAdmin(ModelAdmin):
Returns:
A list of strings representing the slugs of EAV fields.
"""
entity = getattr(instance, instance._eav_config_cls.eav_attr, None)
if entity:
return list(entity.get_all_attributes().values_list('slug', flat=True))
return []
entity = getattr(instance, instance._eav_config_cls.eav_attr)
return list(entity.get_all_attributes().values_list('slug', flat=True))
def _get_eav_fieldset(self, eav_fields) -> _FIELDSET_TYPE:
"""Constructs an EAV Attributes fieldset for inclusion in admin form fieldsets.
@ -100,9 +100,6 @@ class BaseEntityAdmin(ModelAdmin):
eav_fields (List[str]): A list of slugs representing the EAV fields to be included
in the EAV Attributes fieldset.
"""
if not eav_fields:
return []
return [
self.eav_fieldset_title,
{'fields': eav_fields, 'description': self.eav_fieldset_description},