From 3c88819aa892ab9bcdc5722bf0dfd55373cfe2e2 Mon Sep 17 00:00:00 2001 From: Juda Kaleta Date: Sat, 22 Feb 2014 10:11:30 +0100 Subject: [PATCH] Fix template tag without specified size --- CHANGES.rst | 3 +++ embed_video/templatetags/embed_video_tags.py | 3 ++- embed_video/tests/tests_tags.py | 8 ++++++++ 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/CHANGES.rst b/CHANGES.rst index 4d1c2d3..fe6a4c6 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -9,6 +9,9 @@ Release 0.8 (dev) - If ``EMBED_VIDEO_TIMEOUT`` timeout is reached in templates, no exception is raised, error is just logged. +- Fix default size in template tag. + (`See more... `_) + Release 0.7 (Dec. 21, 2013) --------------------------- diff --git a/embed_video/templatetags/embed_video_tags.py b/embed_video/templatetags/embed_video_tags.py index e721cf3..bfa9a2b 100644 --- a/embed_video/templatetags/embed_video_tags.py +++ b/embed_video/templatetags/embed_video_tags.py @@ -82,7 +82,8 @@ class VideoNode(Node): return self.__render_block(url, context) def __render_embed(self, url, context): - size = self.size.resolve(context) + size = self.size.resolve(context) \ + if hasattr(self.size, 'resolve') else self.size return self.embed(url, size, context=context) def __render_block(self, url, context): diff --git a/embed_video/tests/tests_tags.py b/embed_video/tests/tests_tags.py index d7bfc03..6010510 100644 --- a/embed_video/tests/tests_tags.py +++ b/embed_video/tests/tests_tags.py @@ -46,6 +46,14 @@ class EmbedVideoNodeTestCase(TestCase): rendered = u'' self.assertEqual(template.render(self._grc()).strip(), rendered) + def test_direct_embed_tag_with_default_size(self): + template = Template(""" + {% load embed_video_tags %} + {% video "http://www.youtube.com/watch?v=jsrRJyHBvzw" %} + """) + rendered = u'' + self.assertEqual(template.render(self._grc()).strip(), rendered) + def test_user_size(self): template = Template(""" {% load embed_video_tags %}