From bd5e7feb96909a9292c45aff3ce6b00b4ccf9411 Mon Sep 17 00:00:00 2001 From: Kal Sze Date: Thu, 4 Jan 2018 17:58:19 +0800 Subject: [PATCH] Change the git remote URL of the wagtail demo submodule to use HTTPS instead of SSH. Otherwise automatic deployments (e.g. via `pip install https://github.com/barseghyanartur/django-fobi.git@0.12.12#django-fobi`) would fail to clone this submodule, unless an account-wide read/write SSH key is available to the system account running the deployment. This is undesirable from a security perspective. Users could work around this by creating a dummy GitHub account that has no write access to any repo, and add an account-wide SSH key to it, but it's still annoying and means one more thing to maintain. This change means that you don't get the convenience of pushing changes to the wagtail demo using SSH key, but I think it's better than making automatic deployments complicated. --- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitmodules b/.gitmodules index 21aa2e8a..016409cb 100644 --- a/.gitmodules +++ b/.gitmodules @@ -1,3 +1,3 @@ [submodule "examples/wagtaildemo"] path = examples/wagtaildemo - url = git@github.com:barseghyanartur/wagtaildemo.git + url = https://github.com/barseghyanartur/wagtaildemo.git