From 404fed58eca018b74bc846cbf4f71a03f93f4712 Mon Sep 17 00:00:00 2001 From: Matthew Tretter Date: Sat, 25 May 2013 00:07:58 -0400 Subject: [PATCH] Add failing test for source_save signal w/o source This is like the test contributed by @saulshanabrook in #214, but catches the bug closer to its source. (A more unit-y unit test.) --- tests/test_sourcegroups.py | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tests/test_sourcegroups.py b/tests/test_sourcegroups.py index f0ffe2a..12eed3b 100644 --- a/tests/test_sourcegroups.py +++ b/tests/test_sourcegroups.py @@ -27,6 +27,21 @@ def test_source_saved_signal(): eq_(receiver.count, 1) +def test_no_source_saved_signal(): + """ + Creating a new instance without an image shouldn't cause the source_saved + signal to be dispatched. + + https://github.com/jdriscoll/django-imagekit/issues/214 + + """ + source_group = ImageFieldSourceGroup(ImageModel, 'image') + receiver = make_counting_receiver(source_group) + source_saved.connect(receiver) + ImageModel.objects.create() + eq_(receiver.count, 0) + + def test_abstract_model_signals(): """ Source groups created for abstract models must cause signals to be