From ac92b777096ffcfffcaf4948ce724433ea0d6681 Mon Sep 17 00:00:00 2001 From: Matthew Tretter Date: Thu, 14 Mar 2013 23:04:30 -0400 Subject: [PATCH] Fix loopy existence check Sometimes two wrongs do make a right I guess. But better to have two rights. --- imagekit/cachefiles/backends.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/imagekit/cachefiles/backends.py b/imagekit/cachefiles/backends.py index b43232c..e09cce8 100644 --- a/imagekit/cachefiles/backends.py +++ b/imagekit/cachefiles/backends.py @@ -38,7 +38,7 @@ class CachedFileBackend(object): return exists def ensure_exists(self, file): - if self.exists(file): + if not self.exists(file): self.create(file) self.cache.set(self.get_key(file), True) @@ -51,10 +51,7 @@ class Simple(CachedFileBackend): """ def _exists(self, file): - if not getattr(file, '_file', None): - # No file on object. Have to check storage. - return not file.storage.exists(file.name) - return False + return getattr(file, '_file', None) or file.storage.exists(file.name) def create(self, file): """