From d1325d1d5bd6bbc21bf3490c7051d091c987a813 Mon Sep 17 00:00:00 2001 From: Maarten ter Huurne Date: Mon, 20 Mar 2023 17:38:55 +0100 Subject: [PATCH] Modernize property definitions in `SplitText` --- model_utils/fields.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/model_utils/fields.py b/model_utils/fields.py index e04ada2..f48eb9f 100644 --- a/model_utils/fields.py +++ b/model_utils/fields.py @@ -196,7 +196,6 @@ class SplitText: self.field_name = field_name self.excerpt_field_name = excerpt_field_name - # content is read/write @property def content(self): return self.instance.__dict__[self.field_name] @@ -205,15 +204,13 @@ class SplitText: def content(self, val): setattr(self.instance, self.field_name, val) - # excerpt is a read only property - def _get_excerpt(self): + @property + def excerpt(self): return getattr(self.instance, self.excerpt_field_name) - excerpt = property(_get_excerpt) - # has_more is a boolean property - def _get_has_more(self): + @property + def has_more(self): return self.excerpt.strip() != self.content.strip() - has_more = property(_get_has_more) def __str__(self): return self.content