Hopiu/django-model-utils
1
0
Fork 0
mirror of https://github.com/Hopiu/django-model-utils.git synced 2026-03-16 20:00:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use keyword-only arguments to simplify a few __init__() methods

Browse source 
Keyword-only arguments can be used now that Python 2 is no longer
supported.
This commit is contained in:
Maarten ter Huurne 2023-03-20 17:47:13 +01:00
parent 994d6c1c42
commit 6c920508c1
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
model_utils/fields.py
View file

@ -70,10 +70,10 @@ class StatusField(models.CharField):
South can handle this field when it freezes a model.
"""
def __init__(self, *args, **kwargs):
def __init__(self, *args, no_check_for_status=False, choices_name=DEFAULT_CHOICES_NAME, **kwargs):
kwargs.setdefault('max_length', 100)
self.check_for_status = not kwargs.pop('no_check_for_status', False)
self.choices_name = kwargs.pop('choices_name', DEFAULT_CHOICES_NAME)
self.check_for_status = not no_check_for_status
self.choices_name = choices_name
super().__init__(*args, **kwargs)
def prepare_class(self, sender, **kwargs):
@ -107,7 +107,7 @@ class MonitorField(models.DateTimeField):
"""
def __init__(self, *args, **kwargs):
def __init__(self, *args, monitor, when=None, **kwargs):
if kwargs.get("null") and kwargs.get("default") is None:
warning_message = (
"{}.default is set to 'django.utils.timezone.now' - when nullable"
@ -119,12 +119,7 @@ class MonitorField(models.DateTimeField):
warnings.warn(warning_message, DeprecationWarning)
kwargs.setdefault('default', now)
monitor = kwargs.pop('monitor', None)
if not monitor:
raise TypeError(
'%s requires a "monitor" argument' % self.__class__.__name__)
self.monitor = monitor
when = kwargs.pop('when', None)
if when is not None:
when = set(when)
self.when = when
@ -241,12 +236,12 @@ class SplitDescriptor:
class SplitField(models.TextField):
def __init__(self, *args, **kwargs):
def __init__(self, *args, no_excerpt_field=False, **kwargs):
# for South FakeORM compatibility: the frozen version of a
# SplitField can't try to add an _excerpt field, because the
# _excerpt field itself is frozen as well. See introspection
# rules below.
self.add_excerpt_field = not kwargs.pop('no_excerpt_field', False)
self.add_excerpt_field = not no_excerpt_field
super().__init__(*args, **kwargs)
def contribute_to_class(self, cls, name):