Hopiu/django-model-utils
1
0
Fork 0
mirror of https://github.com/Hopiu/django-model-utils.git synced 2026-05-24 01:33:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Increase coverage: verify that accessing the descriptor from the class yields the descriptor object.

Browse source
This commit is contained in:
Lucas Wiman 2018-06-28 17:04:57 -07:00
parent ca2fbb4ccd
commit 7d6b45f0c1
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
model_utils/tracker.py
View file

@ -71,8 +71,7 @@ class DescriptorWrapper(object):
@staticmethod @staticmethod
def cls_for_descriptor(descriptor): def cls_for_descriptor(descriptor):
has_del = hasattr(descriptor, '__delete__') if hasattr(descriptor, '__delete__'):
if has_del:
return FullDescriptorWrapper return FullDescriptorWrapper
else: else:
return DescriptorWrapper return DescriptorWrapper

2
tests/test_fields/test_field_tracker.py
View file

@ -7,6 +7,7 @@ from django.core.exceptions import FieldError
from django.test import TestCase from django.test import TestCase
from model_utils import FieldTracker from model_utils import FieldTracker
from model_utils.tracker import DescriptorWrapper
from tests.models import ( from tests.models import (
Tracked, TrackedFK, InheritedTrackedFK, TrackedNotDefault, TrackedNonFieldAttr, TrackedMultiple, Tracked, TrackedFK, InheritedTrackedFK, TrackedNotDefault, TrackedNonFieldAttr, TrackedMultiple,
InheritedTracked, TrackedFileField, InheritedTracked, TrackedFileField,
@ -191,6 +192,7 @@ class FieldTrackerTests(FieldTrackerTestCase, FieldTrackerCommonTests):
if self.tracked_class == Tracked: if self.tracked_class == Tracked:
self.assertFalse(item.tracker.has_changed('number')) self.assertFalse(item.tracker.has_changed('number'))
if django.VERSION >= (1, 10): if django.VERSION >= (1, 10):
self.assertIsInstance(item.__class__.number, DescriptorWrapper)
self.assertTrue('number' in item.get_deferred_fields()) self.assertTrue('number' in item.get_deferred_fields())
else: else:
self.assertTrue('number' in item._deferred_fields) self.assertTrue('number' in item._deferred_fields)