From a6b0a2aff7df8d53292b0f46340ae9e2a782e9e4 Mon Sep 17 00:00:00 2001 From: Maarten ter Huurne Date: Wed, 12 Jun 2024 16:36:14 +0200 Subject: [PATCH] Fix and re-enable `AbstractModelTrackerTests` There used to be a [bug in Django](https://code.djangoproject.com/ticket/30427) that caused these tests to fail, according to the discussion of #370. That bug was fixed in Django 4.0. However, because the test model was using a `FieldTracker` rather than a `ModelTracker`, all model-specific test cases in `ModelTrackerTests` continued to fail. --- tests/models.py | 2 +- tests/test_fields/test_field_tracker.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/models.py b/tests/models.py index ac65931..8b49654 100644 --- a/tests/models.py +++ b/tests/models.py @@ -249,7 +249,7 @@ class TrackedAbstract(AbstractTracked): number = models.IntegerField() mutable = MutableField(default=None) - tracker = FieldTracker() + tracker = ModelTracker() class TrackedNotDefault(models.Model): diff --git a/tests/test_fields/test_field_tracker.py b/tests/test_fields/test_field_tracker.py index 42bd66b..f239bd3 100644 --- a/tests/test_fields/test_field_tracker.py +++ b/tests/test_fields/test_field_tracker.py @@ -1,7 +1,5 @@ from __future__ import annotations -from unittest import skip - from django.core.cache import cache from django.core.exceptions import FieldError from django.db import models @@ -877,7 +875,6 @@ class InheritedModelTrackerTests(ModelTrackerTests): self.assertTrue(self.tracker.has_changed('name2')) -@skip("has known failures") class AbstractModelTrackerTests(ModelTrackerTests): tracked_class = TrackedAbstract