From d8e71ef9010b06f10c21a1c425123ca30f222dd8 Mon Sep 17 00:00:00 2001 From: Alvaro Leonel Date: Thu, 31 May 2018 01:05:28 -0300 Subject: [PATCH] Improve code quality of notifications_tag.py --- .../templatetags/notifications_tags.py | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/notifications/templatetags/notifications_tags.py b/notifications/templatetags/notifications_tags.py index 0d0a59e..9eb8cf3 100644 --- a/notifications/templatetags/notifications_tags.py +++ b/notifications/templatetags/notifications_tags.py @@ -1,12 +1,15 @@ +''' Django notifications template tags file ''' # -*- coding: utf-8 -*- +from distutils.version import StrictVersion # pylint: disable=no-name-in-module,import-error + from django import get_version -from distutils.version import StrictVersion +from django.template import Library +from django.utils.html import format_html + try: from django.urls import reverse except ImportError: - from django.core.urlresolvers import reverse -from django.template import Library -from django.utils.html import format_html + from django.core.urlresolvers import reverse # pylint: disable=no-name-in-module,import-error register = Library() @@ -19,14 +22,14 @@ def notifications_unread(context): if StrictVersion(get_version()) >= StrictVersion('2.0'): - notifications_unread = register.simple_tag(takes_context=True)(notifications_unread) + notifications_unread = register.simple_tag(takes_context=True)(notifications_unread) # pylint: disable=invalid-name else: - notifications_unread = register.assignment_tag(takes_context=True)(notifications_unread) + notifications_unread = register.assignment_tag(takes_context=True)(notifications_unread) # pylint: disable=invalid-name # Requires vanilla-js framework - http://vanilla-js.com/ @register.simple_tag -def register_notify_callbacks(badge_class='live_notify_badge', +def register_notify_callbacks(badge_class='live_notify_badge', # pylint: disable=too-many-arguments,missing-docstring menu_class='live_notify_list', refresh_period=15, callbacks='',