From 6589aeeaf58b90b1313722791334fb09abb2dc03 Mon Sep 17 00:00:00 2001 From: blag Date: Fri, 30 Dec 2022 14:45:01 -0700 Subject: [PATCH 1/3] Fix signal handler --- tos/signal_handlers.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tos/signal_handlers.py b/tos/signal_handlers.py index c29398c..800a0a5 100644 --- a/tos/signal_handlers.py +++ b/tos/signal_handlers.py @@ -6,7 +6,7 @@ from django.core.cache import caches cache = caches[getattr(settings, 'TOS_CACHE_NAME', 'default')] -def invalidate_cached_agreements(TermsOfService, instance, **kwargs): +def invalidate_cached_agreements(sender, **kwargs): if kwargs.get('raw', False): return From 2c1ecc32a5dea526c9f8d98969875e288c4c952f Mon Sep 17 00:00:00 2001 From: blag Date: Fri, 30 Dec 2022 15:18:05 -0700 Subject: [PATCH 2/3] Update tests --- tos/tests/test_middleware.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tos/tests/test_middleware.py b/tos/tests/test_middleware.py index bacbd2e..4d25fde 100644 --- a/tos/tests/test_middleware.py +++ b/tos/tests/test_middleware.py @@ -167,14 +167,14 @@ class BumpCoverage(TestCase): def test_invalidate_cached_agreements(self): cache = caches[getattr(settings, 'TOS_CACHE_NAME', 'default')] - invalidate_cached_agreements(TermsOfService, {}) + invalidate_cached_agreements(TermsOfService) key_version = cache.get('django:tos:key_version') - invalidate_cached_agreements(TermsOfService, {}) + invalidate_cached_agreements(TermsOfService) self.assertEqual(cache.get('django:tos:key_version'), key_version+1) - invalidate_cached_agreements(TermsOfService, {}, raw=True) + invalidate_cached_agreements(TermsOfService, raw=True) self.assertEqual(cache.get('django:tos:key_version'), key_version+1) From d2713361cd5bf224faf7be47273c2227ae271d5b Mon Sep 17 00:00:00 2001 From: blag Date: Fri, 30 Dec 2022 18:23:33 -0700 Subject: [PATCH 3/3] Fix one last call --- tos/apps.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tos/apps.py b/tos/apps.py index ac86781..789a0bd 100644 --- a/tos/apps.py +++ b/tos/apps.py @@ -19,4 +19,4 @@ class TOSConfig(AppConfig): dispatch_uid='invalidate_cached_agreements') # Create the TOS key version immediately - invalidate_cached_agreements(TermsOfService, None) + invalidate_cached_agreements(TermsOfService)