From e0998a460ac15464bcdb048ebc52eae0bb1cbd38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois=20Freitag?= Date: Sat, 2 May 2020 19:51:26 +0200 Subject: [PATCH] Optimized collectstatic when verbosity is 0. Avoid the dict lookup and length computation when command is not run in verbose mode. --- .../staticfiles/management/commands/collectstatic.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/django/contrib/staticfiles/management/commands/collectstatic.py b/django/contrib/staticfiles/management/commands/collectstatic.py index 252b83987f..9c90fb09b4 100644 --- a/django/contrib/staticfiles/management/commands/collectstatic.py +++ b/django/contrib/staticfiles/management/commands/collectstatic.py @@ -185,12 +185,12 @@ class Command(BaseCommand): raise CommandError("Collecting static files cancelled.") collected = self.collect() - modified_count = len(collected['modified']) - unmodified_count = len(collected['unmodified']) - post_processed_count = len(collected['post_processed']) if self.verbosity >= 1: - summary = ( + modified_count = len(collected['modified']) + unmodified_count = len(collected['unmodified']) + post_processed_count = len(collected['post_processed']) + return ( "\n%(modified_count)s %(identifier)s %(action)s" "%(destination)s%(unmodified)s%(post_processed)s." ) % { @@ -203,7 +203,6 @@ class Command(BaseCommand): ', %s post-processed' % post_processed_count or ''), } - return summary def log(self, msg, level=2): """