Hopiu/django
1
0
Fork 0
mirror of https://github.com/Hopiu/django.git synced 2026-03-28 03:40:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
20984 commits 1 branch 0 tags 216 MiB
Commit graph

6970 commits

Author SHA1 Message Date
Aymeric Augustin
5891990b6e Refactored INSTALLED_APPS overrides. 
* Introduced [un]set_installed_apps to handle changes to the
  INSTALLED_APPS setting.
* Refactored [un]set_available_apps to share its implementation
  with [un]set_installed_apps.
* Implemented a receiver to clear some app-related caches.
* Removed test_missing_app as it is basically impossible to reproduce
  this situation with public methods of the new app cache.
 2013-12-23 20:15:08 +01:00
Aymeric Augustin
3a30b9c575 Fixed a flaky test. 2013-12-22 20:22:56 +01:00
Aymeric Augustin
046a8eb9c4 Made apps available for loading traslations in a test. 2013-12-22 19:04:08 +01:00
Aymeric Augustin
865603780b Moved a test that didn't require Selenium. 2013-12-22 18:50:49 +01:00
Aymeric Augustin
690d1cb8d0 Made AppConfig importable from django.apps. 
It is a public API.
 2013-12-22 11:39:55 +01:00
Aymeric Augustin
2fef9e5375 Moved apps back in the toplevel django namespace. 
Reverted 4a56a93cc4.
 2013-12-22 11:39:55 +01:00
Aymeric Augustin
99bd39ef6e Added the ability to supply custom app configs. 2013-12-22 11:39:18 +01:00
Aymeric Augustin
517c24bcfa Complained on override_settings(INSTALLED_APPS=...). 
Currently such overrides aren't reflected in the app cache.

It would  be possible to handle them. But that doesn't look like a very
good API. It makes it complicated to express "add this app" and "remove
this app", which are the most common operations on INSTALLED_APPS.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
16aae35ca8 Improved set_available_apps() in several ways. 
- Tested consistency the current app_configs instead of INSTALLED_APPS.
- Considered applications added with _with_app as available.
- Added docstrings.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
2239081ff1 Expurged INSTALLED_APPS from code and tests. 
Except the app cache code and a few specific tests, of course.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
9cdf1f6d54 Stop testing for inclusion in INSTALLED_APPS. 
Removed some exception masking in the comments app that was harmful and
couldn't be preserved easily.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
65cd74be8e Stopped iterating on INSTALLED_APPS. 
Used the app cache's get_app_configs() method instead.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
f25fa9d859 Deprecated load_app(). 
Adjusted several tests that used it to add apps to the app cache and
then attempted to remove them by manipulating attributes directly.

Also renamed invalid_models to invalid_models_tests to avoid clashing
application labels between the outer and the inner invalid_models
applications.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
86804ab063 Terminated AppCache._populate() with extreme prejudice. 
It was called _populate() before I renamed it to populate(). Since it
has been superseded by populate_models() there's no reason to keep it.

Removed the can_postpone argument of load_app() as it was only used by
populate(). It's a private API and there's no replacement. Simplified
load_app() accordingly. Then new version behaves exactly like the old
one even though it's much shorter.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
2b56d69102 Implemented two-stage app-cache population. 
First stage imports app modules. It doesn't catch import errors. This
matches the previous behavior and keeps the code simple.

Second stage import models modules. It catches import errors and retries
them after walking through the entire list once. This matches the
previous behavior and seems useful.

populate_models() is intended to be equivalent to populate(). It isn't
wired yet. That is coming in the next commit.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
9b3389b726 Removed the app_config.installed flag. 
Since applications that aren't installed no longer have an application
configuration, it is now always True in practice.

Provided an abstraction to temporarily add or remove applications as
several tests messed with app_config.installed to achieve this effect.
For now this API is _-prefixed because it looks dangerous.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
972babc3b4 Removed the only_installed argument of get_app_config[s]. 
It wasn't used anywhere and couldn't be implemented any more since
non-installed apps no longer have a configuration.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
742ed9878e Refactored registration of models. 
Got rid of AppConfig._stub. As a side effect, app_cache.app_configs now
only contains entries for applications that are in INSTALLED_APPS, which
is a good thing and will allow dramatic simplifications (which I will
perform in the next commit). That required adjusting all methods that
iterate on app_configs without checking the "installed" flag, hence the
large changes in get_model[s].

Introduced AppCache.all_models to store models:
- while the app cache is being populated and a suitable app config
  object to register models isn't available yet;
- for applications that aren't in INSTALLED_APPS since they don't have
  an app config any longer.

Replaced get_model(seed_cache=False) by registered_model() which can be
kept simple and safe to call at any time, and removed the seed_cache
argument to get_model[s]. There's no replacement for that private API.

Allowed non-master app caches to go through populate() as it is now
safe to do so. They were introduced in 1.7 so backwards compatibility
isn't a concern as long as the migrations framework keeps working.
 2013-12-22 11:39:17 +01:00
Alexey Voronov
7f2485b4d1 Fixed #21643 -- repeated execution of qs with F() + timedelta 
Thanks Tim Graham for review.
 2013-12-22 00:03:17 +02:00
Aymeric Augustin
eabc3b6c8d Set stacklevel for the override_settings warning. 
Refs #19031.
 2013-12-20 11:09:06 +01:00
Alex Hill
832ab0dbaa Fixed #21639 -- Implemented RenderContext.__getitem__ 
It's now consistent with RenderContext.get.
 2013-12-20 01:02:50 +01:00
Bouke Haarsma
a39d672ec7 Fixed #21386 -- Removed admindocs dependence on sites framework 
* Removed ADMIN_FOR setting and warn warning
* Group view functions by namespace instead of site
* Added a test verifying namespaces are listed

Thanks to Claude Paroz for reviewing and ideas for improvement.
 2013-12-18 19:44:04 +01:00
Baptiste Mispelon
f1b3ab9c21 Fixed #11629 -- Deprecated callable arguments to queryset methods. 
Callable arguments were an untested and undocumented feature.
 2013-12-18 18:40:00 +01:00
Denis Moskalets
d4e578d0f6 Fixed #21552 -- Allowed the use of None for the iexact lookup. 
Thanks Anubhav Joshi for the documentation.
 2013-12-18 09:34:53 -05:00
Loic Bistuer
2fd7fc134c Refs #17413 -- Added isinstance backward compatibility on ErrorList. 2013-12-18 08:59:53 -05:00
Aymeric Augustin
2bc89f83b3 Removed forgotten reference to the borg pattern. 2013-12-17 22:21:40 +01:00
Aymeric Augustin
0242c56fd8 Deborgified the app cache. 
Improved Andrew's hack to create temporary app caches to handle
migrations. Now the main app cache has a "master" flag set to True
(which is a non-default keyword argument, thus unlikely to be used by
mistake). Other app cache instances have "master" set to False.

The only sanctioned way to access the app cache is by importing
django.core.apps.app_cache.

If you were instanciating an app cache and relying on the Borg pattern,
you'll have to refactor your code.
 2013-12-17 21:53:18 +01:00
Aymeric Augustin
6e895f9e06 Removed superfluous models.py files. 
Added comments in the three empty models.py files that are still needed.

Adjusted the test runner to add applications corresponding to test
labels to INSTALLED_APPS even when they don't have a models module.
 2013-12-17 11:16:48 +01:00
Aymeric Augustin
4a56a93cc4 Moved the new app cache inside core. 2013-12-17 10:17:46 +01:00
Aymeric Augustin
30bdad1c47 Refactored old test runner to handle apps without a models module. 2013-12-17 10:17:45 +01:00
Aymeric Augustin
5ba743e262 Made it possible to create apps without a models module. 
This commit reverts f44c4a5d0f and 39bbd165.

django.test.simple will be updated in a separate commit as it requires
invasive changes.
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
69039becde Deprecated get_app(). 2013-12-17 10:17:45 +01:00
Aymeric Augustin
2732edc5f2 Deprecated get_apps(). 2013-12-17 10:17:45 +01:00
Aymeric Augustin
d44de9b933 Removed the _-prefix for populate(). 
Several parts of Django call get_apps() with a comment along this lines
of "this has the side effect of calling _populate()". I fail to see how
this is better than just calling populate()!
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
ebda5800ae Simplified register_models. 
Since it's never called with more than one model at a time the current
signature is needlessly complicated.
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
a4cb140004 Added get_app_config() to look up app configs by label. 
Refactored get_app() to rely on that method.

get_app() starts by calling _populate(), which goes through
INSTALLED_APPS and, for each app, imports the app module and attempts to
import the models module. At this point, no further imports are
necessary to return the models module for a  given app. Therefore, the
implementation of get_app() can be simplified and the safeguards for
race conditions can be removed.

Besides, the emptyOK parameter isn't used anywhere in Django. It was
introduced in d6c95e93 but not actually used nor documented, and it has
just been carried around since then. Since it's an obscure private API,
it's acceptable to stop supporting it without a deprecation path. This
branch aims at providing first-class support for applications without a
models module eventually.

For backwards-compatibility, get_app() still raises ImproperlyConfigured
when an app isn't found, even though LookupError is technically more
correct. I haven't gone as far as to preserve the exact error messages.
I've adjusted a few tests instead.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
b55282b98b Moved list of models inside AppConfig instances. 
This commit is a refactoring with no change of functionality, according
to the following invariants:

- An app_label that was in app_configs and app_models stays in
  app_config and has its 'installed' attribute set to True.

- An app_label that was in app_models but not in app_configs is added to
  app_configs and has its 'installed' attribute set to True.

As a consequence, all the code that iterated on app_configs is modified
to check for the 'installed' attribute. Code that iterated on app_models
is rewritten in terms of app_configs.

Many tests that stored and restored the state of the app cache were
updated.

In the long term, we should reconsider the usefulness of allowing
importing models from non-installed applications. This doesn't sound
particularly useful, can be a trap in some circumstances, and causes
significant complexity in sensitive areas of Django.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
0e9d3472d7 Stored AppConfig objects instead of models modules in the app cache. 
This is a step towards allowing applications without a models module.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
8662654d6d Removed module-level functions for the app cache. 
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.

They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.

This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
9217b89da3 Removed BaseAppCache.app_store. 
It was only storing redundant information. This is part of the effort to
allow applications without a models module.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
860c2c8bc5 Moved django.db.models.loading to django.apps.cache. 
This commit doesn't contain any code changes; it's purely a refactoring.
 2013-12-17 10:17:43 +01:00
Loic Bistuer
3ce9829b61 Fixed #17413 -- Serialization of form errors along with all metadata. 2013-12-16 16:33:28 -05:00
Baptiste Mispelon
e2f142030b Fixed #21564 -- Use local request object when possible in generic views. 
Thanks to trac user adepue for the report and original patch.
 2013-12-16 16:58:08 +01:00
Peter Harley
cdd6617da6 Fixed #21619 -- Made SingleObjectMixin.get_object catch a more precise exception. 
Thanks to Keryn Knight for the report.
 2013-12-15 21:49:52 +01:00
Loic Bistuer
6685713869 Fixed E127 pep8 warnings. 2013-12-14 11:59:15 -05:00
Baptiste Mispelon
2c837233f5 Fixed #21574 -- Handle bytes consistently in utils.text.normalize_newlines. 
All input is now coerced to text before being normalized.
This changes nothing under Python 2 but it allows bytes
to be passed to the function without a TypeError under Python3
(bytes are assumed to be utf-8 encoded text).

Thanks to trac user vajrasky for the report.
 2013-12-12 16:09:12 +01:00
Ludwik Trammer
9922ed46e2 Fixed #21473 -- Limited language preservation to logout 
Current language is no longer saved to session by LocaleMiddleware
on  every response (the behavior introduced in #14825).
Instead language stored in session is reintroduced into new session
after logout.

Forward port of c558a43fd6 to master.
 2013-12-12 10:24:43 +01:00
Dominic Rodger
5cd6477fd6 Fixed #21462 -- Made assertNumQueries print executed queries on failure. 2013-12-11 15:24:17 -05:00
Simon Charette
75924cfa6d Fixed #21563 -- Single related object descriptors should work with hasattr. 
Thanks to Aymeric Augustin for the review and Trac alias monkut for the report.
 2013-12-11 12:49:28 -05:00
Claude Paroz
c7c647419c Fixed #21510 -- Readded search reset link in changelist search bar 
Thanks moritz.pfeiffer at alp-phone.ch for the report and
Tim Graham for the initial patch.
 2013-12-11 15:30:20 +01:00
Andrew Godwin
5db028affb Fix altering of SERIAL columns and InnoDB being picky about FK changes 2013-12-11 14:19:05 +00:00
Loic Bistuer
a2814846ca Fixed E124 pep8 warnings. 2013-12-10 15:12:48 -05:00
Tim Graham
e7dcd40da2 Added extra newline for flake8. 2013-12-07 07:06:28 -05:00
Loic Bistuer
a8f4553aae Fixed #21555 -- Made ValidationError pickable. 
Thanks trac username zanuxzan for the report and original patch.
 2013-12-07 18:58:37 +07:00
Claude Paroz
41ebc4838d Fixed #21551 -- Reenabled loading fixtures from subdirectory 
This was a regression in Django 1.6 that was only partially
restored in 839940f27f.
Thanks Jonas Haag for the report.
 2013-12-07 10:47:34 +01:00
Claude Paroz
8a9c8bb907 Fixed #21568 -- Added missing ModelMultipleChoiceField to_python method 
Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.
 2013-12-07 10:14:22 +01:00
Vajrasky Kok
a1a26690b9 Fixed #21572 -- Added unit test for django.utils.text.normalize_newlines. 2013-12-07 16:28:22 +08:00
Baptiste Mispelon
a020dd0a99 Fixed #21530 -- Prevent AttributeError in default URLconf detection code. 
Thanks to @dmyerscoug for the report and original patch
and to @alasdairnicol for the added tests.
 2013-12-07 03:21:58 +01:00
Roger Hu
bbc73e6a12 Fixed #21566 -- Fixed AttributeError when using bulk_create with ForeignObject. 2013-12-06 20:20:16 +01:00
pegler
38e24d680d Fixed #21554 -- Incorrect SQL generated when using multiple inheritance. 2013-12-06 14:12:38 -05:00
Baptiste Mispelon
621c25c419 Added missing deconstruct() methods. 2013-12-06 15:23:34 +01:00
Baptiste Mispelon
19e4374971 Fixed ModelState breaking when unique_together has unhashable elements. 2013-12-06 15:22:52 +01:00
Baptiste Mispelon
aba75b0d71 Fixed TypeError when rendering ModelState with multiple bases. 2013-12-06 00:55:31 +01:00
Alex Gaynor
cbf8e8aa12 Fixed a flake8 error 2013-12-05 08:08:34 -06:00
Andrew Godwin
3b8e46cbc7 Migration VCS conflict detection and --merge for makemigrations 2013-12-04 16:01:49 +00:00
Andrew Godwin
ce05b8a69e Don't make a second migration if there was a force-null-default addcol. 2013-12-04 13:56:22 +00:00
Bouke Haarsma
91c38ce4b2 Fixed 21406 -- Made blocktrans 'trimmed' option preserve line numbers. 
Thanks Bouke Haarsma for report, fix and initial patch.
 2013-12-04 08:36:20 -03:00
Alasdair Nicol
c75dd664cf Fixed #21538 -- Added numpy to test/requirements/base.txt 
Thanks Tim Graham for the report
 2013-12-02 13:37:59 -05:00
Tim Graham
3b60ffa334 Fixed incorrect type for max_length. 2013-12-01 14:21:57 -05:00
Unai Zalakain
2688462f91 Refs #21230 -- removed direct settings manipulation from template tests 2013-11-30 13:47:16 -05:00
Claude Paroz
50a8ab7cd1 Enabled makemessages to support several translation directories 
Thanks Rémy Hubscher, Ramiro Morales, Unai Zalakain and
Tim Graham for the reviews.
Also fixes #16084.
 2013-11-30 11:00:23 +01:00
Loic Bistuer
f563c339ca Fixed #20867 -- Added the Form.add_error() method. 
Refs #20199 #16986.

Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
 2013-11-30 01:00:53 +07:00
Vajrasky Kok
7e2d61a972 Fixed #21380 -- Added a way to set different permission for static directories. 
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
 2013-11-29 08:01:30 -05:00
Christopher Medrela
7477a4ffde Fixed E125 pep8 warnings 2013-11-28 08:50:11 -05:00
Vajrasky Kok
d1df395f3a Fixed #21517 -- Added unit test for non-autoincrement primary key with value 0. 2013-11-28 08:48:38 -05:00
Anssi Kääriäinen
01e8ac47b3 PEP-8 cleanup 
Refs #21169
 2013-11-27 19:45:47 +02:00
Loic Bistuer
f450bc9f44 Added a bulk option to RelatedManager remove() and clear() methods 
Refs #21169
 2013-11-27 19:45:22 +02:00
Loic Bistuer
17c3997f68 Fixed #21169 -- Reworked RelatedManager methods use default filtering 
The `remove()` and `clear()` methods of the related managers created by
`ForeignKey`, `GenericForeignKey`, and `ManyToManyField` suffered from a
number of issues. Some operations ran multiple data modifying queries without
wrapping them in a transaction, and some operations didn't respect default
filtering when it was present (i.e. when the default manager on the related
model implemented a custom `get_queryset()`).

Fixing the issues introduced some backward incompatible changes:

- The implementation of `remove()` for `ForeignKey` related managers changed
  from a series of `Model.save()` calls to a single `QuerySet.update()` call.
  The change means that `pre_save` and `post_save` signals aren't called anymore.

- The `remove()` and `clear()` methods for `GenericForeignKey` related
  managers now perform bulk delete so `Model.delete()` isn't called anymore.

- The `remove()` and `clear()` methods for `ManyToManyField` related
  managers perform nested queries when filtering is involved, which may
  or may not be an issue depending on the database and the data itself.

Refs. #3871, #21174.

Thanks Anssi Kääriäinen and Tim Graham for the reviews.
 2013-11-27 19:44:18 +02:00
Andrew Godwin
5e63977c0e Fixed #21438: makemigrations now detects ManyToManyFields 2013-11-27 15:28:33 +00:00
Claude Paroz
384816fccb Fixed #21448 -- Fixed test client logout with cookie-based sessions 
Thanks Gunnar Scherf for the report and the suggested patch.
 2013-11-26 20:41:51 +01:00
Vajrasky Kok
16d73d7416 Fixed #21512 -- Added more complete information about Pillow and PIL in model_fields and model_forms tests. 2013-11-26 10:18:54 +01:00
Jay Leadbetter
c74504c2dd Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation. 
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.

Thanks to meshy for report, and EvilDMP and timo for review.
 2013-11-25 20:01:16 -05:00
Alex Gaynor
7349a22d29 flake8 fix 2013-11-25 09:21:25 -06:00
Shai Berger
3411af3cd1 Fixed #21403: Corrected test code 
A test for annotations incorrectly assumed that the first instance
(in the test) of a model using AutoField for PK will always get pk=1.
The test was changed to compare against actual instance id instead.
 2013-11-25 16:16:04 +02:00
Shai Berger
de220fb85e Fixed test failure on Oracle 
Failure was introduced with test in [19e5cd77f0]
 2013-11-25 15:11:50 +02:00
Alex Gaynor
83ab04c6d6 flake8 fixes 2013-11-24 21:07:21 -06:00
Simon Charette
eb38257e51 Fixed #21391 -- Allow model signals to lazily reference their senders. 2013-11-24 17:51:22 -05:00
Joel Bohman
19e5cd77f0 Fixed #21497 -- Forced conversion to bytes for very long index names 2013-11-24 13:15:50 -05:00
Antonis Christofides
f88e760869 Added more tests for ContentTypeManager.get_for_model. 2013-11-24 18:59:46 +01:00
Baptiste Mispelon
e681b2861d Fixed #21500 -- Removed imports of deprecated utils.importlib 2013-11-24 16:45:01 +01:00
Florian Apolloner
d47f794f8f Properly closed cache connections at the end of the request. 
This only affects the new cache api and not the deprecated get_cache.

Refs #21012
 2013-11-24 16:23:28 +01:00
Alex Gaynor
8adbfdfcc4 Fixed flake8 error (5 space identation!!!) 2013-11-24 08:33:22 -06:00
Florian Apolloner
87ea38cc9e Don't fail if there is no memcached backend active. 2013-11-24 12:08:41 +01:00
Florian Apolloner
3ea65d1f68 Fixed regression from ffc37e2343. 
This (hopefully) ensures that the cache are created the same way as before
the offending commit.
 2013-11-24 11:51:37 +01:00
Vajrasky Kok
7169722d5c Fixed #21505 -- Added unit test for django.utils.text.get_valid_filename. 2013-11-24 11:10:34 +01:00
Florian Apolloner
101da92ebd Randomized KEY_PREFIX in caches test to prevent failures during parallel testruns. 2013-11-24 10:15:43 +01:00
Baptiste Mispelon
a739573e17 Fixed test breakage under python 3 introduced by a480f8320a. 2013-11-23 19:50:20 +01:00
Florian Apolloner
9e87444552 Don't fail if cPickle doesn't exist. 
Today is not my day :(
 2013-11-23 19:05:13 +01:00
Florian Apolloner
cf7ddc5765 Follow up to e112654fc8 
Actually comitted the code now :þ
 2013-11-23 18:55:28 +01:00
Florian Apolloner
e112654fc8 Fixed #21200 -- Consistantly raise errors across all cache backends. 
Thanks to tchaumeny for the patch.
 2013-11-23 17:50:28 +01:00
Alex Gaynor
0ec712dd11 A handful of flake8 fixes 2013-11-23 08:26:11 -08:00
Aymeric Augustin
a480f8320a Simplified iteration in HTTP response objects. 
Fixed #20187 -- Allowed repeated iteration of HttpResponse.

All this became possible when support for old-style streaming responses was
finally removed.
 2013-11-23 17:03:43 +01:00
Aymeric Augustin
1124e16340 Allowed running the test suite without memcached (!) 2013-11-23 16:49:14 +01:00
Ramiro Morales
62b393c5ae Fixed #21488 -- Multiple locales treatment in i18n commands. 
Removed multiple locales separated by commas variation (that wasn't
working as documented) in favor of simply allowing use of the
``--locale``/``-l`` options more than once for ``makemessages`` and
``compilemessages``.

Thanks Romain Beylerian for the report and Claude, Simon for their help.

8750296918072c97a51f6809d19828ce3f1b8d40 from stable/1.6.x.
 2013-11-23 11:53:47 -03:00
Curtis Maloney
ffc37e2343 Fixed #21012 -- New API to access cache backends. 
Thanks Curtis Malony and Florian Apolloner.

Squashed commit of the following:

commit 3380495e93f5e81b80a251b03ddb0a80b17685f5
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:18:07 2013 +0100

    Looked up the template_fragments cache at runtime.

commit 905a74f52b24a198f802520ff06290a94dedc687
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:19:48 2013 +0100

    Removed all uses of create_cache.

    Refactored the cache tests significantly.

    Made it safe to override the CACHES setting.

commit 35e289fe9285feffed3c60657af9279a6a2cfccc
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:23:57 2013 +0100

    Removed create_cache function.

commit 8e274f747a1f1c0c0e6c37873e29067f7fa022e8
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:04:52 2013 +0100

    Updated docs to describe a simplified cache backend API.

commit ee7eb0f73e6d4699edcf5d357dce715224525cf6
Author: Curtis Maloney <curtis@tinbrain.net>
Date:   Sat Oct 19 09:49:24 2013 +1100

    Fixed #21012 -- Thread-local caches, like databases.
 2013-11-23 15:06:59 +01:00
Bouke Haarsma
18185724e6 Fixed #21443 -- Cannot show debug info on PY3's importlib 
Thanks productions@zaziork.co.uk for the review.
 2013-11-22 20:36:33 +01:00
Alex Gaynor
b9d908da54 Fixed some flake8 issues 2013-11-22 09:10:18 -08:00
Bouke Haarsma
48ce09f2f6 Fixed missing admindocs' site_header 2013-11-22 13:30:50 +01:00
Pablo Martín
3ac823fc5b Fixed #21460 -- Reenabled proper template precedence in find_template 
Refs #20806. Thanks Unai Zalakain for the review.
 2013-11-22 11:09:51 +01:00
Claude Paroz
d6cc37d601 Updated admindocs to use class-based views 
Thanks Bouke Haarsma for the review.
 2013-11-21 22:50:59 +01:00
Claude Paroz
1718b5256c Fixed #21405 -- Prevented queryset overwrite in BaseModelAdmin 
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
 2013-11-21 22:18:52 +01:00
Claude Paroz
e6d5f7ae49 Made minor optimizations to admin_ordering tests 2013-11-21 20:58:28 +01:00
Unai Zalakain
2b4bed6dbd Fixed #21476 -- Cache tests make an incorrect use of HttpRequest 
Using `django.test.client.RequestFactory` solves the problem and cleans up all
the `get_request` mess.
 2013-11-21 18:51:08 +01:00
Anssi Kääriäinen
752d3d70da Fixed #21431 -- GenRel->FK list_filter regression in admin 
Report, analysis and tests from stephenmcd.
 2013-11-21 14:52:00 +02:00
Loic Bistuer
8e670a0e50 Refs #8261 -- Fixed regression introduced by fd219fa. 
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
 2013-11-21 16:26:49 +07:00
Claude Paroz
fafb6cf049 Fixed #21472 -- Fixed inline formsets display when parent pk is 0 
Thanks agale031176@gmail.com for the report.
 2013-11-20 21:36:20 +01:00
Baptiste Mispelon
8f5a688d00 Fixed #21458 -- Made check_for_language more resistant to malformed input. 
Thanks to Sergey Sorokin for the report and to Bouke Haarsma for the review.
 2013-11-20 17:51:53 +01:00
Baptiste Mispelon
331d79a77d Fixed #21469 -- Allow set objects in Meta.unique_together. 
Thanks to Tim for the review.
 2013-11-20 17:26:26 +01:00
Vajrasky Kok
68b540c977 Fixed #21361 -- allowed access self.value() from SimpleListFilter lookup 
Reviewed by Chris Medrela.
 2013-11-19 09:14:22 +02:00
Unai Zalakain
4fdd51b732 Fixed #15179 -- middlewares not applied for test client login() 
Requests made with django.test.Client.login() and logout() respect
defaults defined in django.test.Client instantiation and are processed
through middleware.

Thanks to Loic for the reviews.
 2013-11-19 09:04:20 +02:00
Loic Bistuer
3f19b63f8b Fixed some Signal.disconnect calls from 058e434. 
This would go unnoticed by the test suite because receivers are removed
automatically when they are garbage collected.

Changed all Signal.connect calls to hold strong references to ensure we
clean up after ourselves.
 2013-11-18 14:38:28 -05:00
Claude Paroz
97ac22ebfc Fixed #21457 -- Allowed fixture file name to contain dots 
Thanks Keryn Knight for the report.
 2013-11-18 20:32:13 +01:00
Loic Bistuer
058e434064 Merged the signals and signals_regress test packages. 
This patch also made the tests less likely to pollute the global state
in case of failure.
 2013-11-18 12:42:51 -05:00
Claude Paroz
a0f3eeccf3 Fixed #21397 -- Re-added flexibility to TypedChoiceField coercion 
Thanks Elec for the report and Simon Charette for the review.
 2013-11-18 18:24:56 +01:00
Anssi Kääriäinen
0e079e4331 Fixed #21428 -- editable GenericRelation regression 
The GenericRelation refactoring removed GenericRelations from
model._meta.many_to_many. This had the side effect of disallowing
editable GenericRelations in ModelForms. Editable GenericRelations
aren't officially supported, but if we don't fix this we don't offer any
upgrade path for those who used the ability to set editable=True
in GenericRelation subclass.

Thanks to Trac alias joshcartme for the report and stephencmd and Loic
for working on this issue.
 2013-11-16 20:07:35 +02:00
Baptiste Mispelon
ceecc962ad Fixed #21447 -- Restored code erroneously removed in 20472aa827. 
Also added some tests for HttpRequest.__repr__.
Note that the added tests don't actually catch the accidental code
removal (see ticket) but they do cover a codepath that wasn't tested
before.

Thanks to Tom Christie for the report and the original patch.
 2013-11-16 01:09:35 +01:00
Alex Gaynor
10a09b8e60 Fixed the use of the -ise suffix, where -ize is prefered 2013-11-15 05:23:14 -08:00
Loic Bistuer
17ed99f3a3 Fixed #21432 -- DateTimeQuery now copies tzinfo when cloning. 
Thanks Enrique Martínez for the report and @bmispelon for the tests.
 2013-11-14 21:36:55 +01:00
Loic Bistuer
cb83448891 Fixed #21410 -- prefetch_related() for ForeignKeys with related_name='+' 
Regression introduced by commit 9777442.

Thanks to trac username troygrosfield for the report and test case.
 2013-11-13 07:35:34 +02:00
Alex Gaynor
bc742ca110 Flake8 fixes -- including not runnign flake8 over a backported file 2013-11-11 14:05:14 -08:00
Bouke Haarsma
2397daab4a Fixed #9523 -- Restart runserver after compiling apps translations 
Django also uses locales provided by apps, which also might change. Also when
i18n is disabled, there is no need for watching translation files.
 2013-11-11 11:43:09 +01:00
Bouke Haarsma
9b7455e918 Fixed #21351 -- Replaced memoize with Python's lru_cache. 
Replaced the custom, untested memoize with a similar decorator from Python's
3.2 stdlib. Although some minor performance degradation (see ticket), it is
expected that in the long run lru_cache will outperform memoize once it is
implemented in C.

Thanks to EvilDMP for the report and Baptiste Mispelon for the idea of
replacing memoize with lru_cache.
 2013-11-11 08:53:09 +01:00
Claude Paroz
e6dd70b4db Fixed #21383 -- Added request details in SuspiciousOperation messages 2013-11-09 12:11:58 +01:00
Alex Gaynor
ccd11c09c3 Flake8 fix -- correct number of newlines between top level definitions 2013-11-08 09:03:59 -08:00
Unai Zalakain
72f63bd24d Fixed #17529 -- get_template_from_string default arguments break 
``get_template_from_string`` default arguments were breaking
``assertTemplateUsed``. The solution has been to return only the names of the
templates with a ``name`` attribute distinct of ``None``. The default ``name``
kwarg of ``Template`` has been changed to ``None``, more pythonic than ``'<Unknown
Template>'``.
 2013-11-08 17:10:37 +01:00
Claude Paroz
bc21e9c0d9 Fixed #13970 -- Made SelectDateWidget use the standard widget is_required attribute 
Thanks mitar for the report and Tim Graham for the review.
 2013-11-08 16:58:17 +01:00
Tim Graham
536c447820 Fixed a couple flake8 warnings. 2013-11-07 20:10:25 -05:00
Bouke Haarsma
7a7c789d5a Fixed #5849 -- Strip whitespace from blocktrans 
Add the trimmed option to the blocktrans tag to trim any newlines and
whitespace from its content.

This allows the developer to indent the blocktrans tag without adding
new lines and whitespace to the msgid in the PO file.

Thanks to mpessas for the initial patch and Dmitri Fedortchenko for the
report.
 2013-11-08 00:52:17 +02:00
Anssi Kääriäinen
30203a0dea Merge pull request #1850 from unaizalakain/ticket_13725 
Fixed #13725 -- take url scheme into account in assertRedirects

Thanks to Loic for review.
 2013-11-07 14:30:04 -08:00
Unai Zalakain
9c5f6cd565 Fixed #13725 -- take url scheme into account in assertRedirects 
Scheme is handled correctly when making comparisons between two URLs. If
there isn't any scheme specified in the location where we are redirected to,
the original request's scheme is used. If present, the scheme in
``expected_url`` is the one used to make the comparations to.
 2013-11-07 19:06:32 +01:00
Jaap Roes
7be638390e Fixed #20536 -- rewrite of the file based cache backend 
* Safer for use in multiprocess environments
 * Better random culling
 * Cache files use less disk space
 * Safer delete behavior

Also fixed #15806, fixed #15825.
 2013-11-07 16:12:15 +02:00
Loic Bistuer
f51c1f5900 Fixed #17001 -- Custom querysets for prefetch_related. 
This patch introduces the Prefetch object which allows customizing prefetch
operations.

This enables things like filtering prefetched relations, calling select_related
from a prefetched relation, or prefetching the same relation multiple times
with different querysets.

When a Prefetch instance specifies a to_attr argument, the result is stored
in a list rather than a QuerySet. This has the fortunate consequence of being
significantly faster. The preformance improvement is due to the fact that we
save the costly creation of a QuerySet instance.

Thanks @akaariai for the original patch and @bmispelon and @timgraham
for the reviews.
 2013-11-07 14:49:49 +02:00
Anssi Kääriäinen
b1b04df065 Fixed #20600 -- ordered distinct(*fields) in subqueries 2013-11-07 14:29:50 +02:00
Anssi Kääriäinen
e7b61e5717 Fixed #11320 -- exclude() too aggressive in join promotion 2013-11-07 12:57:02 +02:00
Anssi Kääriäinen
6fe2b001db Fixed #21376 -- New implementation for query join promotion logic 
This commit introduced a new class JoinPromoter that can be used to
abstract away join promotion problems for complex filter conditions.
Query._add_q() and Query.combine() now use the new class.

Also, added a lot of comments about why join promotion is done the way
it is.

Thanks to Tim Graham for original report and testing the changes, and
for Loic Bistuer for review.
 2013-11-07 12:53:26 +02:00
Alex Gaynor
e5b7045422 flake8 fixes 2013-11-06 20:00:48 -08:00
Andrew Godwin
106b019dc9 Massive migration optimiser improvements + RenameModel opn 2013-11-06 13:47:58 +00:00
Baptiste Mispelon
b914991b37 Added more tests and documentation for dictsort. 
It's possible to use something like {{ foo|dictsort:'bar.baz' }}
but this wasn't tested or documented.
 2013-11-06 00:26:58 +01:00
Bouke Haarsma
e5e044da87 Fixed #18419 -- Full backwards compatibility for old language codes 
Improved documentation about zh-* deprecation and upgrade path.

Thanks to Baptiste Mispelon for the code reviews.
 2013-11-05 19:26:58 +01:00
Anssi Kääriäinen
76da053641 Fixed #10461 -- bug in generic relation + annotate() case 
This issue was fixed when the contenttype restriction was moved from
where clause to the join clause. So, this is tests only addition.
 2013-11-05 20:02:24 +02:00
Bouke Haarsma
c0a2388a1c Fixed #18149 -- Changed language codes for Chinese 
Language codes for Chinese are zh_Hans (Simplified) and zh_Hant (Traditional).
Added support for browsers that still send the deprecated language codes.

Thanks to Olli Wang for the report.
 2013-11-04 23:03:28 +01:00
Aymeric Augustin
cb2c3ce154 Merge pull request #1821 from Bouke/tickets/14170 
#14170 -- Reset i18n cache when settings changed
 2013-11-04 13:50:21 -08:00
Bouke Haarsma
9b95fa7777 Fixed #21322 -- Error message when CSRF cookie is missing 
Thanks to Henrik Levkowetz and olau for their reports and initial patches.
 2013-11-03 20:05:10 +01:00
Alex Gaynor
f67e18f39e Fixed all E251 violations 2013-11-03 10:17:58 -08:00
Alex Gaynor
c347f78cc1 Fixed all E226 violations 2013-11-03 10:08:55 -08:00
Alex Gaynor
7288e1b02b Merge pull request #1852 from jasonamyers/cleanup/PEP8 
Cleanup/pep8 tests
 2013-11-03 09:51:49 -08:00
Jason Myers
4f151da1e5 Merging in master 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-03 07:19:25 -06:00
Florian Apolloner
08e2ecee3b Fixed some testfailures on jenkins. 
Depending on the order of the tests beeing run, 10 can be a valid pk,
0 can never be a valid pk and as such we will get the wanted ValidationError.
 2013-11-03 14:16:48 +01:00
Jim Bailey
539e3693d4 Fixed #20849 -- ModelForms do not work well with prefetch_related. 
model_to_dict() (used when rendering forms) queries the database
to get the list of primary keys for ManyToMany fields. This is
unnecessary if the field queryset has been prefetched, all the
keys are already in memory and can be obtained with a simple
iteration.
 2013-11-03 12:27:54 +02:00
Bouke Haarsma
d0669843d0 Fixed #14170 -- Reset i18n cache when settings change 2013-11-03 09:36:09 +01:00
Aymeric Augustin
881851f3bb Merge pull request #1853 from loic/dst 
Fixed failing test around DST change.
 2013-11-03 01:14:17 -07:00
Jason Myers
7a61c68c50 PEP8 cleanup 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:49 -05:00
Jason Myers
3f115776e1 PEP8 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:38 -05:00
coagulant
8eec2d93b6 Fixed all E261 warnings 2013-11-02 23:50:33 -05:00
Jason Myers
c3791463a5 Fixing E302 Errors 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:48:47 -05:00
Loic Bistuer
757945b47d Fixed failing test around DST change. 
The timezone arithmetic done in JS can be off by one hour around DST
change. We work around this issue by adding one extra hour to the test
error margin when we detect a DST change is near.

Refs #20663.
 2013-11-02 18:57:35 -05:00
coagulant
3bc0d46a84 Fixed all E261 warnings 2013-11-02 18:20:39 -04:00
Anssi Kääriäinen
2a03a9a9a1 Fixed syntax error in queries/tests.py 2013-11-02 22:42:42 +02:00
Anssi Kääriäinen
bec0b2a8c6 Fixed #14511 -- bug in .exclude() query 2013-11-02 22:35:45 +02:00
Boryslav Larin
e737c009b8 Fixed flake8 E241 2013-11-02 21:45:40 +02:00
Tim Graham
36ded01527 Fixed #21302 -- Fixed unused imports and import *. 2013-11-02 15:24:56 -04:00
Anssi Kääriäinen
9f76ea1eaa Fixed #21375 -- related_name='+' clashed with other '+' names 2013-11-02 21:18:35 +02:00
Anssi Kääriäinen
b44d42be6d Fixed #21366 -- regression in join promotion logic 
The regression was caused by ecaba36028
and affected OR connected filters.
 2013-11-02 20:44:19 +02:00
Unai Zalakain
99b681e227 Fixed #21341 -- Eased https requests with the test client 
All request methods of ``django.test.client.Client`` receive a ``secure``
argument that defaults to ``False`` indicating whether or not to make the
request through https.
Thanks Aymeric Augustin for the review.
 2013-11-02 19:03:13 +01:00
Aymeric Augustin
8b3d9d96ed Merge pull request #1799 from Bouke/tickets/9523 
Fixed #9523 -- Restart runserver after translation MO files change
 2013-11-02 06:57:50 -07:00
Bouke Haarsma
6107435386 Fixed #21324 -- Translate CSRF failure view 
Thanks to Claude Paroz for the original patch.
 2013-11-02 11:22:30 +01:00
Bouke Haarsma
c3936c0d79 Fixed #9523 -- Restart runserver after translation MO files change 
Thanks to Krzysztof Kulewski for the initial patch.
 2013-11-02 10:29:07 +01:00
Ole Laursen
f4f01fb03c Fixed #18508 -- tests for repeated deletion bug in ModelFormSet 
The ticket's issue was already fixed by patch for #14877.
 2013-10-31 19:39:10 +02:00
Anssi Kääriäinen
efb0100ee6 Fixed #14877 -- repeated deletion using formsets 
When a formset contained deletion for an existing instance, and the
instance was already deleted, django threw an exception. A common cause for
this was resubmit of the formset.

Original patch by Trac alias olau.

In addition this commit cleaned some code in _construct_form(). This
was needed as the primary key value the user submitted wasn't converted
correctly to python value in case the primary key field was also a
related field.
 2013-10-30 22:40:15 +02:00
Alex Gaynor
8faaf03b86 Fixed some flake8 issues 2013-10-30 10:42:35 -07:00
Andrew Godwin
e9cb333bc3 Auto-apply initial migrations if their tables exist already. 2013-10-30 15:17:49 +00:00
Baptiste Mispelon
5733764a2c Added some more tests for the debug page. 
* Missing tests for ticket #12744
* Tests for the cleanse_setting feature (leaving out sensitive
  settings from the debug page)
 2013-10-30 07:55:07 +01:00
Baptiste Mispelon
3c5cdaf47a Fixed #21345: Don't evaluate callable settings in the debug page. 
Thanks to crass for the report.
 2013-10-30 07:53:20 +01:00
Simon Charette
8f73559823 Fixed a F811 warning introduced by 35db9d58d6. 2013-10-29 17:22:45 -04:00
Unai Zalakain
fd219fa24c Fixed #8261 -- ModelAdmin hook for customising the "show on site" button 
``ModelAdmin.view_on_site`` defines wether to show a link to the object on the
admin detail page. If ``True``, cleverness (i.e. ``Model.get_absolute_url``) is
used to get the url. If it's a callable, the callable is called with the object
as the only parameter. If ``False``, not link is displayed.

With the aim of maitaining backwards compatibility, ``True`` is the default.
 2013-10-29 17:10:12 -04:00
Claude Paroz
0336d0d95e Rearranged some i18n tests 
Compilation/extraction tests are now properly skipped when gettext
commands are unavailable.
 2013-10-28 14:17:48 +01:00
Claude Paroz
35db9d58d6 Rearranged some file-related tests 
Just moving around some tests to be more logically grouped.
 2013-10-27 21:28:08 +01:00
Ramiro Morales
88f03db05f Fixed test that reads a migration file from disk. 
We need to make sure content read from the file is decoded from UTF-8
right from the start so Python doesn't try to use another encoding
(read: ASCII/CP1252 under Windows.)
 2013-10-27 14:54:56 -03:00
Alex Gaynor
b35ff0d920 Fixed all the E203 violations 2013-10-26 18:27:42 -07:00
Alex Gaynor
9d740eb8b1 Fix all violators of E231 2013-10-26 12:15:03 -07:00
Claude Paroz
3afde36d03 Undelete the login() call inadvertantly removed in 4e0a2fe59c 
Refs #21271.
 2013-10-25 11:23:19 +02:00
SusanTan
4e0a2fe59c Fixed #21271 -- Added timeout parameter to SMTP EmailBackend. 
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
 2013-10-24 20:38:00 -04:00
Vajrasky Kok
9eecb91695 Fixed #21219 -- Added a way to set different permission for static files. 
Previously, when collecting static files, the files would receive permission
from FILE_UPLOAD_PERMISSIONS. Now, there's an option to give different
permission from uploaded files permission by subclassing any of the static
files storage classes and setting the file_permissions_mode parameter.

Thanks dblack at atlassian.com for the suggestion.
 2013-10-24 17:40:01 -04:00
Claude Paroz
c052699be3 Fixed #20338 -- Stripped ending dot during host validation 
Thanks manfre for the report and Timo Graham for the review.
 2013-10-24 21:24:04 +02:00
Kevin Christopher Henry
08c9ab5a0f Fixed #21227 -- Added workaround for selenium test failures 
Added a refresh() before quit() in the selenium tests, since this
solves the problem of spurious test failures in some environments.
 2013-10-24 15:07:41 -04:00
Renato Oliveira
43569647ab Fixed #21299 - Changed filters from title to capfirst on admin inline formsets. 
Previously there was a mixture of the two which resulted in inconsistent
casing.
 2013-10-24 14:44:07 -04:00
Alex Gaynor
9bf5610890 Start attacking E231 violations 2013-10-24 10:30:03 -07:00
Curtis Maloney
8688f03eef Fixed #20945 -- Allowed cache tag to use a specific cache. 2013-10-23 19:27:08 -04:00
Tim Graham
c573d6de17 Fixed #19941 -- Removed sys.path hack when running the test suite. 
Thanks jezdez for the suggestion.
 2013-10-23 18:27:06 -04:00
Andrew Godwin
5ab8b5d72c Fix migration planner to fully understand squashed migrations. And test. 2013-10-23 22:56:54 +01:00
Tim Graham
4cfbde71a3 Fixed #12027 -- Fixed EmailValidator to reject a trailing dot. 
Thanks Klas H for the report and claudep for the patch.
 2013-10-23 12:22:14 -04:00
Alasdair Nicol
c3aa2948c6 Fixed #21298 -- Fixed E301 pep8 warnings 2013-10-23 13:45:03 +01:00
Ramiro Morales
aefc1d4e65 Workaround admin scripts test failures on Windows+Python 3. 
Change strategy used to examine instrumented output to acommodate the
fact that on Windows, where the path separator is '\', repr() of Python
modules has changed in Python 3 to use escaped backslashes in the FS
path section (e.g.
'C:\\python3x\\Lib\\site-packages\\django\\contrib\\auth\\models.py')
without having to special-case based on platform.
 2013-10-23 08:19:42 -03:00
Tim Graham
ae48d77ef8 Fixed E225 pep8 warnings. 2013-10-23 06:09:29 -04:00
Ramiro Morales
51d2e1fb23 Fixed #21307 -- Moved TransRealMixin to django.test.utils. 2013-10-22 22:19:56 -03:00
Florian Hahn
5240b83462 Fixed #17027 -- Added support for the power operator in F expressions. 
Thanks dan at dlo.me for the initial patch.

- Added __pow__ and __rpow__ to ExpressionNode
- Added oracle and mysql specific power expressions
- Added used-defined power function for sqlite
 2013-10-22 10:29:57 -04:00
Tim Graham
1597503a01 Fixed E221 pep8 warnings. 2013-10-22 09:51:39 -04:00
Bouke Haarsma
0d0f4f020a Fixed #5789 -- Changed LocaleMiddleware session variable to '_language'. 
The old 'django_language' variable will still be read from in order
to migrate users. The backwards-compatability shim will be removed in
Django 1.8.

Thanks to jdunck for the report and stugots for the initial patch.
 2013-10-22 09:24:42 -04:00
Tim Graham
8e2029f8dd Removed import * in tests. 
Thanks to flake8 path/to/file.py | awk -F ' ' '{ print $5 }' | sort | uniq
 2013-10-22 08:32:01 -04:00
Ramiro Morales
b5f52647fe Decode from UTF-8 explicitly when reading a text file in makemessages. 
This shows itself with Python 3 under Windows where UTF-8 usually isn't
the default file I/O encoding and caused one failure and three errors
in our test suite under that platform setup.
 2013-10-22 06:09:21 -03:00
Claude Paroz
a098bee1b9 Fixed #19724 -- Output note when showing only core management commands 
When listing available management commands, only core commands are
listed if settings have any error. This commit adds a note in this
case so errors are not totally silently skipped.
Thanks Peter Davis for the report.
 2013-10-21 21:26:48 +02:00
Loic Bistuer
e565e1332d Fixed #21275 -- Fixed a serializer error when generating migrations for contrib.auth. 
The migration serializer now looks for a deconstruct method on any object.
 2013-10-21 14:54:52 -04:00
Bouke Haarsma
3565efaa45 Removed some direct settings manipulations in tests; refs #21230. 2013-10-21 11:31:05 -04:00
Tim Graham
499cd912ca Fixed E227 pep8 warnings 2013-10-21 08:52:21 -04:00
Alasdair Nicol
b289fcf1bf Fixed #21288 -- Fixed E126 pep8 warnings 2013-10-21 08:31:30 -04:00
Ramiro Morales
a3690168cb Fixed an I18N test class tearDown method. 2013-10-21 01:18:44 -03:00
Loic Bistuer
8d6953d55c Added support for serializing class methods. - Refs #21290. 
The new handling allows us to do away with the whitelisting that was
required to support date and datetime objects.
 2013-10-19 12:10:18 -04:00
Loic Bistuer
584110417f Fixed #21283 -- Added support for migrations if models is a package. 
Thanks Markus Holtermann for the report.
 2013-10-19 09:48:57 -04:00
Tim Graham
96d1d4e292 Removed unused local variables in tests. 2013-10-19 08:31:38 -04:00
Alasdair Nicol
a800036981 Fixed #21287 -- Fixed E123 pep8 warnings 2013-10-18 10:07:39 +01:00
Alasdair Nicol
bab9123daa Fixed #21268 -- Fixed E303 pep8 warnings 2013-10-18 01:46:24 +01:00
Alasdair Nicol
65d1d65d52 Fixed #21267 -- Fixed E502 pep8 warnings 2013-10-18 01:28:32 +01:00
Alasdair Nicol
dfb4cb9970 Fixed #21285 -- Fixed E121,E122 pep8 warnings 2013-10-17 20:20:11 -04:00
Claude Paroz
3514bcb251 Fixed #21284 -- Prevented KeyError swallowing in fetch_command 
Thanks wildfire for the report.
 2013-10-17 18:57:44 +02:00
Claude Paroz
a14f087233 Fixed #21282 -- Made HttpResponse.serialize_headers accept latin-1 
Thanks Raphaël Barrois for the report and the initial patch and
Aymeric Augustin for the review.
 2013-10-17 18:14:35 +02:00
Loic Bistuer
5008706345 Added test for a921f06 - refs #21280. 
This commit also lays the groundwork for future tests for the
makemigrations command.
 2013-10-17 12:08:17 -04:00
Bouke Haarsma
2fb5a51fa3 Fixed #18659 -- Deprecated request.REQUEST and MergeDict 
Thanks Aymeric Augustin for the suggestion.
 2013-10-17 09:42:28 -04:00
Alasdair Nicol
eb214452c3 Fixed #21270 -- Fixed E701 pep8 warnings 2013-10-17 12:12:40 +01:00
Claude Paroz
2992f42861 Fixed #19657 -- Made sql commands honor allow_migrate 
Thanks Manel Clos for the report and the initial patch, and
Marc Tamlyn and Tim Graham for the review.
 2013-10-16 18:02:32 +02:00
Bouke Haarsma
3918eeb9fd Fixed #7551 -- Made GFK allow None init argument. 
Thanks SamBull for the report.
 2013-10-16 07:03:46 -04:00
Andrew Godwin
42f8666f6a Improve migration optimizer to be able to optimize through other ops 2013-10-16 11:09:33 +01:00
Alex Gaynor
694d7da6c5 Merge pull request #1744 from unaizalakain/ticket_7261 
Fixed #7261 -- support for __html__ for library interoperability
 2013-10-15 14:43:35 -07:00
Loic Bistuer
776b6470c1 Fixed DeprecationWarning caused by assertEquals. 2013-10-16 02:28:04 +07:00
Marc Tamlyn
349c12d3f5 Fixed #16855 -- select_related() chains as expected. 
select_related('foo').select_related('bar') is now equivalent to
select_related('foo', 'bar').

Also reworded docs to recommend select_related(*fields) over select_related()
 2013-10-15 15:59:36 +01:00
Claude Paroz
949076eb11 Fixed #21263 -- Fixed issue with override_settings in inherited classes 
When both parent and child classes are decorated with override_settings,
child class settings should take precedence.
Thanks Sephi for the report and Marc Tamlyn for the review.
 2013-10-15 15:38:27 +02:00
Marc Tamlyn
ce823d3710 Merge pull request #1382 from loic/ticket19617 
Fixed #19617 -- Refactored form metaclasses to support more inheritance scenarios.
 2013-10-15 04:22:34 -07:00
Unai Zalakain
af64429b99 Fixed #7261 -- support for __html__ for library interoperability 
The idea is that if an object implements __html__ which returns a string this is
used as HTML representation (eg: on escaping). If the object is a str or unicode
subclass and returns itself the object is a safe string type.

This is an updated patch based on jbalogh and ivank patches.
 2013-10-15 00:42:42 +02:00
Larry O'Neill
83b9bfea44 Fixed #21266 -- Fixed E201,E202 pep8 warnings. 2013-10-14 18:12:00 -04:00
Claude Paroz
42a67ec1cd Fixed #21269 -- Don't crash when CommandError contains non-ascii 
Thanks kontakt@eikefoken.de for the report.
 2013-10-14 21:21:07 +02:00
Ramiro Morales
8ab5f1fe47 Close file after tests added in 945e033a69. 
Avoids failures on Windows. Refs #8918.
 2013-10-14 15:34:43 -03:00
Loic Bistuer
b16dd1fe01 Fixed #8620 -- Updated the Form metaclass to support excluding fields by shadowing them. 2013-10-14 22:42:33 +07:00
Loic Bistuer
ac5ec7b8bc Fixed #19617 -- Refactored Form metaclasses to support more inheritance scenarios. 
Thanks apollo13, funkybob and mjtamlyn for the reviews.
 2013-10-14 21:59:30 +07:00
Claude Paroz
1e8eadc94e Fixed #15888 -- Made tablename argument of createcachetable optional 
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
 2013-10-14 13:24:40 +02:00
Aymeric Augustin
589dc49e12 Fixed #21198 -- Prevented invalid use of @python_2_unicode_compatible. 
Thanks jpic for the report and chmodas for working on a patch.

Reverts 2ea80b94. Refs #19362.
 2013-10-13 18:14:04 +02:00
Aymeric Augustin
570d9c2678 Fixed #19560 -- Identified field in warning for naive datetime. 
Thanks gcc for the report and vajrasky for the patch.
 2013-10-13 11:54:11 +02:00
Claude Paroz
00a73c1c69 Fixed #21173 -- Stopped fixing format for date-based widgets at init time 
Thanks Marc Tamlyn for the review.
 2013-10-12 18:31:19 +02:00
Tim Graham
ad17d6a85f Fixed errors in 848101bf17 2013-10-11 17:58:07 -04:00
Sascha Peilicke
848101bf17 Added tests for URLValidator schemes. 2013-10-11 13:41:38 -04:00
Tai Lee
e527c0b6d8 Fixed #13252 -- Added ability to serialize with natural primary keys. 
Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.

Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.

Thanks SmileyChris for the suggestion.
 2013-10-11 12:52:57 -04:00
Tim Graham
945e033a69 Fixed #8918 -- Made FileField.upload_to optional. 
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
 2013-10-11 08:07:25 -04:00
Tim Graham
b67ab75e82 Fixed assorted flake8 errors. 2013-10-11 07:25:14 -04:00
Tim Graham
1dae4ac177 Whitespace cleanup. 
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
 2013-10-10 16:49:20 -04:00
Tim Graham
ca874b2fe6 Fixed an undefined variable and clarified the purpose of a test. 
refs #4459.
 2013-10-10 13:01:12 -04:00
Tim Graham
adedc31072 Fixed "redefinition of unused 'foo' from line X" pyflakes warnings. 2013-10-10 11:09:42 -04:00
Tim Graham
cec11a3336 Used "is" for comparisons with None. 2013-10-10 09:35:56 -04:00
Tim Graham
ff9e8eccf8 Removed unnecessary semicolons. 2013-10-10 08:50:32 -04:00
Russell Keith-Magee
a971d19bab Fixed #21243 -- Corrected exception message in multiple database tests. 
Thanks to vajrasky for the report and patch.
 2013-10-09 09:06:23 +08:00
Jaap Roes
40b95a24ae Fixed #20568 -- truncatewords_html no longer splits words containing HTML entities. 
Thanks yann0 at hotmail.com for the report.
 2013-10-08 08:24:58 -04:00
Tim Graham
58d555caf5 Fixed #16822 -- Added RawPostDataException 
Thanks jaylett for the patch.
 2013-10-08 08:05:39 -04:00
Russell Keith-Magee
8ff4303946 Refs #21197 -- Clarified upgrade check message. 
Thanks to Carl and Shai for the discussion.
 2013-10-08 10:00:39 +08:00
Simon Charette
a8df8e34f9 Revert "Fixed #21241 -- Avoid extraneous JOINs in admin changelist search." 
This reverts commit 698dd82eee.

The patch introduced a backward incompatible change.
 2013-10-07 13:45:52 -04:00
Chris Adams
698dd82eee Fixed #21241 -- Avoid extraneous JOINs in admin changelist search. 2013-10-07 13:10:52 -04:00
Tim Graham
617aceb1b4 Fixed #18263 -- Corrrected handling of hidden fields in tabular admin inlines. 
Thanks hvdklauw for the report and patch.
 2013-10-07 12:30:02 -04:00
Javed Khan
4dbd95ad65 Fixed #21236 -- Allowed migrations to work with unique_together tuples. 
Thanks hjwp for the report.
 2013-10-07 09:39:14 -04:00
Anssi Kääriäinen
1df3c49a1a Fixed #21174 -- transaction control in related manager methods 2013-10-05 23:07:52 +03:00
Anssi Kääriäinen
93cc6dcdac Fixed #18414 -- qs.exists() for sliced distinct queries 2013-10-05 21:40:36 +03:00
Anssi Kääriäinen
068b1e045f Simplified a test by using CapturedQueriesContext 2013-10-05 21:16:09 +03:00
Aymeric Augustin
671757b507 Fixed #21161 -- Timezone-related tests on Windows. 
Thanks Xelnor for the patch.
 2013-10-05 18:50:20 +02:00
Anssi Kääriäinen
ecaba36028 Improved Query join promotion logic 
There were multiple cases where join promotion was a bit too aggressive.
This resulted in using outer joins where not necessary.

Refs #21150.
 2013-10-05 14:52:17 +03:00
Anssi Kääriäinen
ed0d720b78 Fixed #21150 -- select_related + annotate join promotion failure 
Added tests for a .annotate().select_related() join promotion failure.
This happened to work on master but was currently untested.
 2013-10-05 14:52:17 +03:00
Simon Charette
948d209ada Fixed #21217 -- Avoid connecting (pre|post)_init signals to abstract senders. 2013-10-04 16:23:06 -04:00
Christopher Medrela
dc3d2ac98c Fixed #11277 -- Hid labels of fields with HiddenInput widget in admin forms. 
Thanks bartTC for the report.
 2013-10-04 14:08:06 -04:00
Tai Lee
bcd4c3f27d Fixed #6681 -- Don't break docutils when rendering reStructuredText. 
Don't set a global default interpreted role function for reStructuredText.
Instead, use the `default-role` directive to change the default only within
the `parse_rst()` function.

Thanks Malcolm Tredinnick for the report.
 2013-10-04 13:27:08 -04:00
Emil Stenström
7a97df190c Fixed #19277 -- Added LocaleMiddleware.response_redirect_class 
Thanks ppetrid at yawd.eu for the suggestion.
 2013-10-03 16:15:29 -04:00
Simon Charette
fa2e1371cd Fixed #21216 -- Allow OneToOneField reverse accessor to be hidden. 2013-10-03 13:20:05 -04:00
Anentropic
c4db7f075e Fixed #19182 -- Fixed ModelAdmin.lookup_allowed to work with ('fieldname', SimpleListFilter) syntax. 
Thanks gauss for the report.
 2013-10-03 09:37:49 -04:00
Ramiro Morales
62dfd79f8b Fixed #21165 -- Fix test for syndication feed timestamp field on Windows. 
Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936.
 2013-10-02 23:29:48 -03:00
Andrew Godwin
a80d9ab0fe Initial version of MigrationOptimizer and tests 2013-10-02 17:34:22 +01:00
Kevin Christopher Henry
978e1351a6 Fixed #21122 -- Improved clean up of test temp directory on Windows 
- Fixed test that didn't close the files it opened
- Caught and handled exception when temp directory cannot be removed
 2013-10-02 09:12:58 -04:00
tschilling
5381317fe3 Fixed #21129 -- Prevented admin filter params modifications from throwing an exception. 
Thanks Tuttle for the report.
 2013-10-02 08:16:09 -04:00
Ramiro Morales
651bed0918 Made test for issue 19552 compatible with Windows. 
Take in account platform path separator. Refs #19552.
 2013-10-02 07:29:40 -03:00
Ramiro Morales
0f46ec315e Made skipping of symlink-related makemessages test smarter. 
os.symlink() is available starting with Windows Vista but can fail at
runtime.
 2013-10-02 07:17:08 -03:00
Ramiro Morales
43959d1057 Fixed tests breakage from last commit. 2013-10-01 21:02:42 -03:00
Ramiro Morales
4b715fc05a Fixed #21209 -- .po file path comments on Windows. 
Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.

Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.

Refs #16903.
 2013-10-01 20:37:43 -03:00
Ramiro Morales
1d0fc61b1c Fixed #15185 -- Allowed ModelAdmin.list_display_links=None to disable change list links. 
Thanks rm_ for the suggestion.
 2013-10-01 14:25:54 -04:00
Anssi Kääriäinen
8c27247397 Added default value for a BooleanField in test models 
Test models introduced for #10733 didn't contain default value for
a BooleanField(). Check command didn't like that -> check tests failed.
 2013-10-01 20:36:06 +03:00
Anssi Kääriäinen
bf13c75c0d Fixed #21203 -- resolve_columns fields misalignment 
In queries using .defer() together with .select_related() the values
and fields arguments didn't align properly for resolve_columns().
 2013-10-01 20:29:23 +03:00
Anssi Kääriäinen
8d4b1629d4 Fixed #10733 -- select_related().only() failure 
The bug was reported pre 1.1, and somewhere along the way it has been
fixed. So, this is tests only addition.
 2013-10-01 19:29:48 +03:00
Claude Paroz
c1c44b2506 Factorized requires_tz_support decorator in test utils 
Thanks Aymeric Augustin for the suggestion. Refs #21165.
 2013-10-01 13:20:41 +02:00
Loic Bistuer
d847ddfe1d Fixed #3871 -- Fixed regression introduced by 04a2a6b. 
Added do_not_call_in_templates=True attribute to RelatedManagers
to prevent them from being called.

Thanks jbg@ for the report.
 2013-09-30 15:43:44 -04:00
Tim Graham
f93896344a Fixed Python 3.2 syntax errors; refs #13724. 2013-09-30 10:28:01 -04:00
Aymeric Augustin
728548e483 Fixed #21134 -- Prevented queries in broken transactions. 
Squashed commit of the following:

commit 63ddb271a44df389b2c302e421fc17b7f0529755
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 29 22:51:00 2013 +0200

    Clarified interactions between atomic and exceptions.

commit 2899ec299228217c876ba3aa4024e523a41c8504
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 22 22:45:32 2013 +0200

    Fixed TransactionManagementError in tests.

    Previous commit introduced an additional check to prevent running
    queries in transactions that will be rolled back, which triggered a few
    failures in the tests. In practice using transaction.atomic instead of
    the low-level savepoint APIs was enough to fix the problems.

commit 4a639b059ea80aeb78f7f160a7d4b9f609b9c238
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Tue Sep 24 22:24:17 2013 +0200

    Allowed nesting constraint_checks_disabled inside atomic.

    Since MySQL handles transactions loosely, this isn't a problem.

commit 2a4ab1cb6e83391ff7e25d08479e230ca564bfef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Sep 21 18:43:12 2013 +0200

    Prevented running queries in transactions that will be rolled back.

    This avoids a counter-intuitive behavior in an edge case on databases
    with non-atomic transaction semantics.

    It prevents using savepoint_rollback() inside an atomic block without
    calling set_rollback(False) first, which is backwards-incompatible in
    tests.

    Refs #21134.

commit 8e3db393853c7ac64a445b66e57f3620a3fde7b0
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 22 22:14:17 2013 +0200

    Replaced manual savepoints by atomic blocks.

    This ensures the rollback flag is handled consistently in internal APIs.
 2013-09-30 09:42:27 +02:00
Russell Keith-Magee
9595183d03 Fixed #13724: Corrected routing of write queries involving managers. 
Previously, if a database request spanned a related object manager, the
first manager encountered would cause a request to the router, and this
would bind all subsequent queries to the same database returned by the
router. Unfortunately, the first router query would be performed using
a read request to the router, resulting in bad routing information being
used if the subsequent query was actually a write.

This change defers the call to the router until the final query is acutally
made.

It includes a small *BACKWARDS INCOMPATIBILITY* on an edge case - see the
release notes for details.

Thanks to Paul Collins (@paulcollinsiii) for the excellent debugging
work and patch.
 2013-09-30 13:05:43 +08:00
Ramiro Morales
12ca312e1b Modified test added in 3afb5916b2 so it doesn't fail on Windows. 
Refs #18091.
 2013-09-29 22:44:55 -03:00
Simon Charette
c4fdd859ec Fixed #15786 -- Added a regression test for o2o excludes using F(). 
The issue was reported against 1.3.x but has been fixed since.
 2013-09-29 16:45:03 -04:00
Michael Manfre
b0e06c3662 Fixed #21167 - Improved queries.tests.SubqueryTests 
Improve tests to cover slicing scenarios that could be handled in unique
ways by 3rd party database backends.
 2013-09-29 17:35:42 +03:00
Christopher Babiak
a834bc84d8 Fixed #20931 -- Fixed select widgets nested choice rendering 
ChoiceFieldRenderer was not rendering nested choices. Added recursion
to ChoiceFieldRenderer to take nested choices and render them as
<ul>'s.
 2013-09-28 17:25:32 -07:00
Anssi Kääriäinen
47e79bfcfb Fixed #21187 -- Import CursorWrapper from django.db.backend.utils 
The import was done from util instead of utils leading to
PendingDeprecationWarning.
 2013-09-28 14:18:37 +03:00
Erik Romijn
1a63092981 Fixed #20439 -- Started deprecation of IPAddressField 2013-09-28 10:55:32 +02:00
Baptiste Mispelon
8f51ba669a Fixed #21186: Fixed regression when using date fields in the admin's list_filter. 
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
 2013-09-28 00:40:43 +02:00
Baptiste Mispelon
3754f4ad41 Fix #21185: Added tests for unescape_entities. 
Also fixed a py3 incompatibility.
Thanks to brutasse for the report.
 2013-09-27 17:00:42 +02:00
Simon Charette
209de62d22 Fix Python 3.2 compatiblity by removing unicode literals. 2013-09-26 00:03:57 -04:00
Giles Richard Greenway
6c06adad1d Fixed #20364 -- Changed urlize regexes to include quotation marks as punctation. 
Thanks to EmilStenstrom for raising this, and to Chris Piwoński for all of the fixes and most of the tests.
 2013-09-25 22:17:22 +02:00
Michael Manfre
99c87f1410 Fixed #17671 - Cursors are now context managers. 2013-09-25 21:47:26 +03:00
Loic Bistuer
04a2a6b0f9 Fixed #3871 -- Custom managers when traversing reverse relations. 2013-09-25 21:15:59 +03:00
Anssi Kääriäinen
83554b018e Fixed #21126 -- QuerySet value conversion failure 
A .annotate().select_related() query resulted in misaligned rows vs
columns for compiler.resolve_columns() method.

Report & patch by Michael Manfre.
 2013-09-25 20:47:57 +03:00
Andrew Godwin
f671fb9d11 Remove most errors when running migration tests twice 2013-09-25 16:11:05 +01:00
Andrew Godwin
fe9f342d8c Allow callables as the argument to RunPython 2013-09-25 16:10:43 +01:00
Andrew Godwin
3b810c5656 Add RunPython migration operation and tests 2013-09-25 13:58:07 +01:00
Andrew Godwin
05656f2388 Add equality support for Project/ModelState 2013-09-25 13:47:46 +01:00
Michael Manfre
9a041807fc Fixed #18333 - Quoted annotated column names 2013-09-24 10:10:08 -04:00
Andrew Godwin
6ede1db331 Fixed #21151 -- Bad cleanup in schema M2M repoint test 2013-09-24 11:00:00 +01:00
Florian Apolloner
16ceb05b47 Isolated select_for_update tests a bit more. 
This change prevents including the multiple_database test models without
duplicating the router code (we probably should do this at one point).

Refs #21148
 2013-09-24 10:29:21 +02:00
Simon Charette
ab643cd634 Fixed test suite bisection on Python 3. 
Thanks to @marfire for spotting this.
 2013-09-23 17:05:36 -04:00
Simon Charette
4ec6d281cd Fixed #21001 -- Added a regression test for empty string exclusion on Oracle. 
The issue was present in 1.4.x but has been reported to be fixed in master.

Thanks to @timgraham for the patch.
 2013-09-23 14:18:03 -04:00
Helen ST
41167645b1 Fixed #14028 - Added validation for clashing db_columns. 
Thanks akaariai for the suggestion.
 2013-09-23 11:51:58 -04:00
Florian Apolloner
4fcc1e4ad8 Stopped a test from executing queries at the module level. 
Currently module level queries are executed against the real database
(specified in NAME) instead of the test database; since it is to late
to fix this for 1.6, we at least ensures stable builds. Refs #21443.
 2013-09-22 23:02:35 +02:00
Aymeric Augustin
e6c0020d19 Translated a test to English for consistency. 
Also fixed a typo.
 2013-09-22 22:48:22 +02:00
Florian Apolloner
2ca00faa91 Fixed "Address already in use" from liveserver. 
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".

Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
 2013-09-22 22:02:59 +02:00
Aymeric Augustin
a5b062576b Removed a few trailing backslashes. 
We have always been at war with trailing backslashes.
 2013-09-22 14:04:10 +02:00
Aymeric Augustin
ee0ef1b094 Partial revert of 165f44aa. 
That commit didn't always improve readability.

See discussion on django-developers for details.
 2013-09-22 14:04:10 +02:00
Aymeric Augustin
5444a9c683 Fixed #21074 -- Added tests for localized datetime fields. 
Fields must render values in the current time zone.

This commit only contains tests because this ticket was just a symptom of
a regression from #18777 that was fixed separately.
 2013-09-21 23:10:14 +02:00
Aymeric Augustin
68b10fa177 Ensured that explicit time zones are rejected by forms. 
Refs #19371.
 2013-09-21 21:09:25 +02:00
tschilling
0d1ba84d13 Fixed #20702 -- Deprecated get_formsets in favor of get_formsets_with_inlines. 
Thanks stanislas.guerra at gmail.com for the report.
 2013-09-20 07:47:24 -04:00
yokomizor
df27803a55 Fixed #9532 -- Added min_num and validate_min on formsets. 
Thanks gsf for the suggestion.
 2013-09-19 13:11:49 -04:00
Curtis Maloney
4e9f800742 Fixed #21125 -- Removed support for cache URI syntax 2013-09-19 10:01:39 -04:00
Tim Graham
7fec5a2240 Fixed #7557 -- Added type checking to Variable initialization. 
Thanks tobias for the suggestion and boblefrag and saz for work on the
patch.
 2013-09-19 09:27:19 -04:00
Tim Graham
e23de9e350 Fixed typo in exception message; refs #19414 
Thanks Alexey Boriskin for the report.
 2013-09-19 06:24:12 -04:00
Brian Holdefehr
98514849dc Fixed #19414 -- Added admin registration decorator 
Thanks stavros for the suggestion.
 2013-09-18 11:44:10 -04:00
Tim Graham
2daada800f Fixed #21098 -- Applied sensitive_post_parameters to MultiValueDict 
Thanks simonpercivall for the report and bmispelon for the review.
 2013-09-18 09:48:36 -04:00
Tim Graham
4f40b97d97 Fixed #21118 -- Isolated a test that uses the database. 
Thanks rmboggs for the report.
 2013-09-18 09:42:47 -04:00
Berker Peksag
2f0566fa61 Fixed #4278 -- Added a dirs parameter to a few functions to override TEMPLATE_DIRS. 
* django.template.loader.get_template()
* django.template.loader.select_template()
* django.shortcuts.render()
* django.shortcuts.render_to_response()

Thanks amcnabb for the suggestion.
 2013-09-18 07:37:08 -04:00
Tim Graham
893198509e Fixed #15625 -- Made message in MultiValueDictKeyError less verbose. 
Thanks margieroginski for the suggestion.
 2013-09-18 06:44:38 -04:00
Anssi Kääriäinen
50633e7353 Fixed #12568 -- no error when accessing custom field's descriptor 
The SubfieldBase's descriptor caused an AttributeError when accessed
from the class. Introspection didn't like that.

Patch by Trac alias supervacuo.
 2013-09-18 10:03:52 +03:00
Markus Holtermann
a772ea8117 Fixed #21115 -- Fixed NameError in migrate --list command 2013-09-17 12:53:59 -04:00
Markus Holtermann
5a424c2393 Fixed #21114 -- Migrations must not have a dependency to themselves. 2013-09-17 11:47:19 -04:00
Tim Graham
1234225068 Fixed test failures introduced in previous commit. 2013-09-16 13:12:50 -04:00
Tim Graham
18ffdb1772 Fixed #17627 -- Renamed util.py files to utils.py 
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
 2013-09-16 12:52:05 -04:00
Florian Apolloner
351a061497 Fixed a timing edge case in the RelatedFieldWidgetSeleniumFirefoxTests. 
By settings an implicit wait timeout for the find_* methods we can wait
till the javascript code add the new option to the DOM.

See http://ci.djangoproject.com/job/Django/database=mysql_gis,python=python3.3/3174/testReport/junit/admin_widgets.tests/RelatedFieldWidgetSeleniumFirefoxTests/test_foreign_key_using_to_field/

Stacktrace:
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/Django/workspace/database/mysql_gis/python/python3.3/tests/admin_widgets/tests.py", line 1060, in test_foreign_key_using_to_field
      self.assertEqual(username_value, new_option.get_attribute('value'))
      AssertionError: 'newuser' != 'testser'
      - newuser
      + testser
 2013-09-15 01:11:07 +02:00
Tim Graham
886bb9d878 Revert "Fixed #12288 -- Validated that app names in INSTALLED_APPS are unique" 
This reverts commit c1ec08998d.

There are backwards compatability concerns with this.
 2013-09-14 07:19:32 -04:00
Anssi Kääriäinen
74b91b3888 Added tests for double-pickling a QuerySet 
Refs #21102.
 2013-09-14 10:33:15 +03:00
Michael Manfre
c89d80e2cc Fixed #21097 - Added DatabaseFeature.can_introspect_autofield 2013-09-14 09:48:59 +03:00
Juan Catalano
6feb75129f Fixed #21060 -- Refactored admin's autodiscover method to make it reusable. 
We want to be able to use it for instance for discovering `tasks.py` modules
inside the INSTALLED_APPS.

This commit therefore moves the logic to `autodiscover_modules` method in
django.utils.module_loading.
 2013-09-13 20:09:41 -04:00
e0ne
c1ec08998d Fixed #12288 -- Validated that app names in INSTALLED_APPS are unique 2013-09-13 08:09:21 -04:00
Michael Manfre
018037736f Fixed #21099 - Skip DistinctOnTests unless backend can_distinct_on_fields 2013-09-12 14:32:23 -04:00
Michael Manfre
e61cc87129 Fixed #21090 -- Allowed backends to provide dotted field path to inspectdb. 2013-09-11 13:35:26 -04:00
Baptiste Mispelon
abb10db06f Fixed #21089 -- Allow TransactionTestcase subclasses to define an empty list of fixtures. 
Thanks to lgs for the report and initial patch.
 2013-09-11 15:28:04 +02:00
Keryn Knight
170f721367 Fixed #21056 -- AdminSite.app_index no longer blindly accepts any app-labelish input. 2013-09-11 08:48:32 -04:00
Tim Graham
7fe5b656c9 Prevented arbitrary file inclusion with {% ssi %} tag and relative paths. 
Thanks Rainer Koirikivi for the report and draft patch.

This is a security fix; disclosure to follow shortly.
 2013-09-10 21:02:48 -04:00
Tim Graham
4e96dac450 Fixed #19298 -- Added MultiValueField.__deepcopy__ 
Thanks nick.phillips at otago.ac.nz for the report.
 2013-09-10 13:56:49 -04:00
Florian Apolloner
d5d0e03ec8 Fixed test errors from 053de6131a on py3.2. 2013-09-10 19:17:01 +02:00
e0ne
053de6131a Fixed #5749 -- Added field_name as a key in the _html_output dict 
Thanks SmileyChris for the suggestion.
 2013-09-10 13:00:10 -04:00
Juan Catalano
4840fd9cbc Fixed #20919 -- Extended assertRedirects to be able to avoid fetching redirect's response. 
Thanks mjtamlyn for the suggestion.
 2013-09-10 12:22:55 -04:00
Aymeric Augustin
79ccd1a101 Fixed test that fails when pytz is installed. 
pytz' localize() method is the bane of my life.
 2013-09-10 18:07:29 +02:00
Gregor MacGregor
b2b763448f Fixed #20841 -- Added messages to NotImplementedErrors 
Thanks joseph at vertstudios.com for the suggestion.
 2013-09-10 11:09:59 -04:00
Loic Bistuer
d59f1993f1 Made MigrationWriter look for a "deconstruct" attribute on functions. 
Refs #20978.
 2013-09-10 10:12:23 -04:00
Tim Graham
4ba373840a Fixed #16534 -- Improved ability to customize DiscoverRunner 
Added DiscoverRunner.test_suite and .test_runner attributes.

Thanks tomchristie for the suggestion and jcd for the patch.
 2013-09-10 09:49:39 -04:00
Roberto Aguilar
af67ce5e18 Fixed #4574 -- Added CSS classes to the admin calendar widget for better control over styling. 2013-09-10 08:07:17 -05:00
e0ne
f2a4452882 Fixed #18403 -- Initialized bad_cookies in SimpleCookie 
Thanks Stefano Crosta for the report.
 2013-09-10 08:26:54 -04:00
homm
7008ed61c5 Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters 2013-09-10 01:55:16 +02:00
Florian Apolloner
df2fd4e09b Removed unneeded imports in tests's __init__.py and unified them. 2013-09-09 23:01:07 +02:00
Aymeric Augustin
d9413d33b2 Refactored code and tests that relied on django.utils.tzinfo. 
Refs #17262.
 2013-09-09 22:32:52 +02:00
Aymeric Augustin
ec2778b445 Fixed #17262 -- Refactored tzinfo implementations. 
This commit deprecates django.utils.tzinfo in favor of the more recent
django.utils.timezone which was introduced when Django gained support
for time zones.
 2013-09-09 22:32:51 +02:00
Kevin Christopher Henry
9d700322b3 Fixed #19885 -- cleaned up the django.test namespace 
* override_settings may now be imported from django.test
* removed Approximate from django.test
* updated documentation for things importable from django.test

Thanks akaariai for the suggestion.
 2013-09-09 16:03:13 -04:00
Josh Mize
a52cc1c088 Fixed #21078 -- Handled additional bad Accept-Language header 2013-09-09 15:19:09 -04:00
Keryn Knight
0d74f9553c Fixed #21063 -- AdminSite app_index should be fail early if the user has no permissions. 2013-09-09 12:51:03 -04:00
Tim Graham
789d8f0748 Fixed syntax error on Python 3.2; refs #20889. 2013-09-09 09:54:08 -04:00
Curtis Maloney
7c6f2ddcd9 Simplify FilterExpression.args_check 2013-09-09 09:03:50 -04:00
Daniel Boeve
6dca603abb Fixed #20889 -- Prevented email.Header from inserting newlines 
Passed large maxlinelen to email.Header to prevent newlines from being
inserted into value returned by _convert_to_charset

Thanks mjl at laubach.at for the report.
 2013-09-09 08:47:41 -04:00
Tim Graham
aeed2cf3b2 Added a test to show that the user.is_staff check in admin base.html is necessary. 
refs #21067
 2013-09-09 07:59:35 -04:00
Baptiste Mispelon
28a571348b Fix #20745: Don't silence TypeError raised inside templates. 
Thanks to robin for the report and claudep for the review.
 2013-09-08 22:05:35 +02:00
Alex Gaynor
9d11522599 Removed some more unused local vars 2013-09-08 12:20:01 -07:00
Aymeric Augustin
c687bf0620 Further hardening. Refs #18766. 2013-09-08 20:43:04 +02:00
Aymeric Augustin
1a1e14786a Hardened the test introduced in ded11aa6. Refs #18766. 
Inputs acceptable to time.mktime are platform-dependent.
 2013-09-08 19:40:42 +02:00
Alex Gaynor
96fd5557f9 Removed a ton of unused local vars 2013-09-08 08:05:16 -07:00
Aymeric Augustin
ded11aa620 Fixed #18766 -- Pointed to pytz when LocalTimezone fails. 
Thanks void for the report.
 2013-09-08 02:04:43 -05:00
Pablo Mouzo
b11564fd36 Fixed #16869 -- BaseGenericInlineFormSet.save_new should use form's save() method 
Thanks mattaustin for the report and Pablo Recio (pyriku) for the patch.
 2013-09-07 20:00:38 -04:00
Alex Gaynor
c348550d35 Fixed some flake8 warnings 2013-09-07 15:36:00 -07:00
Juan Catalano
04415bf81b Fixed #21013 -- Ensure that ModelAdmin.get_queryset is considered for the admin history view. 2013-09-07 14:53:29 -05:00
Julien Phalip
8ef060e0e6 Fixed a test failure introduced in 55a11683f7. 2013-09-07 12:41:33 -05:00
Julien Phalip
55a11683f7 Fixed #20836 -- Ensure that the ForeignKey's to_field attribute is properly considered by the admin's interface when creating related objects. 
Many thanks to Collin Anderson for the report and patch and to Peter Sheats for the test.
 2013-09-07 12:14:07 -05:00
Aymeric Augustin
65b6eff322 Fixed #20530 -- Properly decoded non-ASCII query strings on Python 3. 
Thanks mitsuhiko for the report.

This commit just adds a test since the problem was fixed in 8aaca651.
 2013-09-07 11:47:38 -05:00
Andrew Godwin
bacbbb481d RunSQL migration operation and alpha SeparateDatabaseAndState op'n. 2013-09-07 11:03:38 -05:00
Aymeric Augustin
f5add4712f Fixed tests introduced in previous commit on Python 2. Refs #20557. 2013-09-07 10:43:44 -05:00
Aymeric Augustin
8aaca651cf Fixed #20557 -- Properly decoded non-ASCII cookies on Python 3. 
Thanks mitsuhiko for the report.

Non-ASCII values are supported. Non-ASCII keys still aren't, because the
current parser mangles them. That's another bug.
 2013-09-07 10:25:43 -05:00
Alex Gaynor
97a626d898 Fixed this syntax error on py32 2013-09-06 21:56:57 -07:00
Aymeric Augustin
a9589dd280 Fixed #21032 -- pip 1.4 can't install pytz. 2013-09-06 22:11:55 -05:00
Eric Boersma
ded40142a9 Fixed #20007 -- Configured psycopg2 to return UnicodeArrays 
Thanks hogbait for the report.
 2013-09-06 20:43:58 -04:00
Russell Keith-Magee
926bc421d9 Merge pull request #1566 from adamsc64/ticket_11857 
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
 2013-09-06 17:38:37 -07:00
Tim Graham
b7451b72ed Fixed deprecation warning on Python 3 2013-09-06 20:36:17 -04:00
Loic Bistuer
adc0ab3386 Fixed #21037 -- Made MigrationWriter raise a ValueError when serializing lambda functions. 2013-09-06 20:13:01 -04:00
Tim Graham
67863b3bfe Fixed test failure introduced in efd1e6096e (sqlmigrate) 2013-09-06 19:59:25 -04:00
Russell Keith-Magee
4f5faa1916 Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message 
Fixed #12756: Improved error message when yaml module is missing.
 2013-09-06 16:05:02 -07:00
Roberto Aguilar
01a5359477 Cleanup commit after peer review. 2013-09-06 22:45:31 +00:00
Russell Keith-Magee
9b2dc12b83 Merge pull request #1580 from ianawilson/ticket_16502 
Fixed #16502 -- Fixed a TemplateDoesNotExist error that should be an ImproperlyConfigured.

Assistance on the patch from #jambronrose.
 2013-09-06 15:31:25 -07:00
Roberto Aguilar
9587d4eea0 Fixed existing tests to handle BadSerializer. 
When a BadSerializer instance is stubbed in for the yaml serializer,
make sure tests do not fail.
 2013-09-06 22:26:13 +00:00
Roberto Aguilar
ca3ac4a3e3 Updated NoYamlSerializerTestCase to run with yaml. 
In order to verify the behavior of using the yaml serializer when yaml
is on the system, fake the ImportError when the serializer is being
registered.
 2013-09-06 22:26:13 +00:00
Ian Wilson
d005130845 fixed test name from an old, overly specific iteration of the test 2013-09-06 17:20:43 -05:00
Aymeric Augustin
b4cd8169de Fixed #11811 -- Data-loss bug in queryset.update. 
It's now forbidden to call queryset.update(field=instance) when instance
hasn't been saved to the database ie. instance.pk is None.
 2013-09-06 17:15:23 -05:00
Russell Keith-Magee
122020fdb9 Merge pull request #1579 from ianawilson/ticket_21058 
Fixed #21058 -- Fixed debug view blowing up when no template is provided to the template rendering functions.

Assistance on this commit from @jambonrose.
 2013-09-06 15:06:57 -07:00
Ian Wilson
e12de0ac04 Removed unnecessary, leftover imports 2013-09-06 22:04:58 +00:00
Adrian Holovaty
e844e10b4f Moved a settings usage up the stack in utils/formats.py #unsettings 2013-09-06 17:01:36 -05:00
Ian Wilson
b79df0b358 adds fix for SingleObjectTemplateResponseMixin raising a TemplateDoesNotExist when it should have raised an ImproperlyConfigured. fixes 16502. by @ianawilson, @jambonrose 2013-09-06 16:27:34 -05:00
Julien Phalip
d5df914fe1 Merge pull request #1578 from rmutter/ticket_20821 
Fixed #20821 -- Added tooltips to Admin SelectBox widget
 2013-09-06 14:03:58 -07:00
Ian Wilson
9b7f4aab32 adds fix and test for when a template is not specified at all to render(). fixes #21058. by jambonrose and ianawilson 2013-09-06 15:50:18 -05:00
Rudy Mutter
c438cc2a36 Fixed #20821 -- Added tooltips to Admin SelectBox widget 
The Admin widget, which can be used to filter multiple selects
can sometimes be too narrow and hide information such as
user permissions. This commit adds tooltips to the select
options so that a user can hover over and see the hidden text.
 2013-09-06 15:46:38 -05:00
Andrew Godwin
efd1e6096e Adding 'sqlmigrate' command and quote_parameter to support it. 2013-09-06 15:28:12 -05:00
Roberto Aguilar
d8d61d8260 Added tests for missing pyyaml. 
This test makes sure an YAML import errors are communicated to the
caller rather than stating the serializer does not exist.
 2013-09-06 20:23:27 +00:00
Dan Johnson
df462cf760 Fixed #21043 -- Made resolve() handle reverse_lazy objects. 
Thanks Keryn Knight for the report.
 2013-09-06 15:46:43 -04:00
Florian Apolloner
85359ec9a4 Merge branch 't20812' 2013-09-06 21:03:46 +02:00
Daniel Langer
cc957cb16c Fixed #4287 -- Fixed NaN and +/- Infinity handling in FloatField 
NaN, +Inf, and -Inf are no longer valid values for FloatFields.
 2013-09-06 14:56:37 -04:00
Christopher Adams
b2f5ac1656 Fixed #11857 -- Added missing 'closed' property on TemporaryFile class. 
- TemporaryFile now minimally mocks the API of the Python standard
  library class tempfile.NamedTemporaryFile to avoid AttributeError
  exceptions.
- The symbol django.core.files.NamedTemporaryFile is actually assigned
  as a different class on different operating systems.
- The bug only occurred if Django is running on Windows, hence why it
  was hard to diagnose.
 2013-09-06 14:32:46 -04:00
Andrew Godwin
05e14e8eaf Migration autodetector now corerctly deals with proxy models 2013-09-06 12:39:46 -05:00
Florian Apolloner
2326dedde8 Fixed #20812 -- Error out if __unicode__/__str__ doesn't return a text type. 2013-09-06 19:24:18 +02:00
Andrew Godwin
be983ee403 Also test failure case of ProjectState dependency resolution 2013-09-06 12:18:24 -05:00
Andrew Godwin
cdeff3acc2 Project/ModelState now correctly serialize multi-model inheritance 2013-09-06 12:16:03 -05:00
Andrew Godwin
6f7977bb63 Fixed #21029: Test for previously-commited SchemaEditor.__exit__ bug. 2013-09-06 12:16:03 -05:00
Chris Wilson
eade315da1 Fixed #10164 -- Made AutoField increase monotonically on SQLite 
Thanks malte for the report.
 2013-09-06 12:31:17 -04:00
Aymeric Augustin
e492ab8e7e Fixed #18719 -- Made force_bytes more consistent with force_text. 2013-09-06 10:28:28 -05:00
Markus Holtermann
bd8e1a354c Fixed #20977 -- Fixed writing migrations to disk on Python 3 2013-09-06 09:51:58 -04:00
Preston Timmons
8625c7aab3 Fixed #16096 -- Added origin attribute to template instances. 
Thanks jdunck for the suggestion.
 2013-09-06 09:14:52 -04:00
Loic Bistuer
e1266e50b2 Fixed #21015 -- Fixed MigrationLoader when importlib.import_module returns a file module or an empty directory. 2013-09-06 08:30:19 -04:00
Loic Bistuer
82bbb9fe81 Fixed #21014 -- Fixed gobbled ImportError in MigrationLoader. 2013-09-06 08:30:18 -04:00
Eric Boersma
4d13cc56de Fixed #21035 -- Changed docs to treat the acronym SQL phonetically. 
The documentation and comments now all use 'an' to
refer to the word SQL and not 'a'.
 2013-09-05 20:14:58 -04:00
Aymeric Augustin
6a6428a36f Took advantage of django.utils.six.moves.urllib.*. 2013-09-05 14:39:23 -05:00
Tim Graham
bab039d74c Fixed #21041 -- Removed a duplicate form in tests. 
Thanks tuxcanfly.
 2013-09-05 05:49:10 -04:00
Loic Bistuer
34d52fd32e Fixed #21010 -- Changed ModelState to only copy _meta.local_fields. 2013-09-04 14:05:59 -04:00
Tim Graham
5649c0af9d Fixed "indentation is not a multiple of four" pep8 issues. 2013-09-03 14:22:21 -04:00
Tim Graham
cb98ffe8f4 Fixed a couple unclosed file warnings in tests 2013-09-03 13:37:27 -04:00
Tim Graham
3db66b1d65 Updated syncdb -> migrate in tests. 2013-09-03 11:51:34 -04:00
Tim Graham
86964a7b4f Silenced deprecation warning regarding old SQL location; refs #14300 2013-09-03 11:10:43 -04:00
Tim Graham
2fd03b39ab Removed references to django.utils.unittest which is PendingDeprecation 2013-09-03 09:55:21 -04:00
Tim Graham
ec784c486b Silenced deprecation warnings in SortedDict tests; refs [07876cf02b] 2013-09-03 09:48:46 -04:00
Aymeric Augustin
365c3e8b73 Replaced "not PY3" by "PY2", new in six 1.4.0. 2013-09-02 12:11:02 +02:00
Ramiro Morales
41feab3654 Converted tests for admin first form widget auto-focus to Selenium. 
Refs #1707 and 1c0c879be3.
 2013-09-01 15:07:08 -03:00
Ramiro Morales
c01cd4c423 Change test added in 3e34005b1b to be more stable. 
It could fail when actual serialization JSON field ordering was
different from the hard-coded one. Refs #13182.
 2013-09-01 10:47:35 -03:00
Loic Bistuer
ff9e116198 Fixed #21008 -- Made MigrationWriter handle Promise objects. 2013-08-31 20:26:44 -04:00
Ramiro Morales
e909ceae9b Made django.test.testcases not depend on staticfiles contrib app. 
Do this by introducing a django.contrib.staticfiles.testing.StaticLiveServerCase
unittest TestCase subclass.

Fixes #20739.
 2013-08-31 11:02:32 -03:00
Claude Paroz
e0643cb676 Properly skipped yaml tests when not installed 2013-08-31 15:23:56 +02:00
Claude Paroz
3e34005b1b Fixed #13182 -- Prevented trailing spaces in indented json output 
Thanks Stéphane Raimbault for the report and the initial patch.
 2013-08-31 15:18:01 +02:00
Carl Meyer
7211741fc5 Fixed #20999 - Allow overriding formfield class with choices, without subclass restrictions. 
Refs #18162. Thanks claudep and mjtamlyn for review.
 2013-08-30 17:43:10 -06:00
Claude Paroz
b04f8ddbaa Fixed #21005 -- Made schema tests language-independent 
Thanks Simon Charette for the review.
 2013-08-30 21:28:21 +02:00
Simon Charette
11cd7388f7 Fixed #20989 -- Removed useless explicit list comprehensions. 2013-08-30 10:57:51 -04:00
Curtis Maloney
e2f06226ea Improved {% include %} implementation 
Merged BaseIncludeNode, ConstantIncludeNode and Include node.

This avoids raising TemplateDoesNotExist at parsing time, allows recursion
when passing a literal template name, and should make TEMPLATE_DEBUG behavior
consistant.

Thanks loic84 for help with the tests.

Fixed #3544, fixed #12064, fixed #16147
 2013-08-30 10:36:36 +03:00
Anssi Kääriäinen
e973ee6a98 Fixed #20988 -- Added model meta option select_on_save 
The option can be used to force pre 1.6 style SELECT on save behaviour.
This is needed in case the database returns zero updated rows even if
there is a matching row in the DB. One such case is PostgreSQL update
trigger that returns NULL.

Reviewed by Tim Graham.

Refs #16649
 2013-08-30 09:41:07 +03:00
Simon Charette
36bbe3b7c5 Altered test introduced in f19a3669b8 for the sake of readability. refs #14786 2013-08-29 14:50:55 -04:00
Tim Graham
f19a3669b8 Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False. 
Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.
 2013-08-29 11:13:34 -04:00
Tim Graham
af953c45cc Fixed #16433 -- Fixed a help_text/read only field interaction that caused an admin crash. 
Thanks chris at cogdon.org for the report and admackin for the patch.
 2013-08-29 09:39:31 -04:00
Tim Graham
cf8d6e9108 Fixed #20881 -- Removed contrib.auth.models.AbstractUser.get_absolute_url() 
The definition is arbitrary and creates a broken "view on site"
link in the admin if a project doesn't define such a URL.
 2013-08-29 06:36:35 -04:00
Curtis Maloney
8d473b2c54 Fixed #7116 -- Optimize RequestContext construction 2013-08-29 10:25:56 +03:00
Curtis Maloney
5cdacbda03 Fixed #17356 -- Allowed {% include %} to render compiled templates 
Reviewed by Loic Bistuer and Tim Graham.
 2013-08-29 10:22:24 +03:00
Loic Bistuer
da800be6dd Fixed #20986 -- Enabled SelectDateWidget to use custom months 
Reviewed by Trac alias MarkusH.
 2013-08-28 16:39:26 +03:00
Warren Smith
dd3a883894 Fixed #20693 -- Add timezone support to built-in time filter. 
Modified django.utils.dateformat module, moving __init__() method and
timezone-related format methods from DateFormat class to TimeFormat
base class. Modified timezone-related format methods to return an
empty string when timezone is inappropriate for input value.
 2013-08-26 16:15:53 -05:00
Ramiro Morales
b785a80d19 Added further fixes, tests for #19949/f33db5a09a. 
Thanks Susan Tan. Refs #19949.
 2013-08-26 08:47:24 -03:00
Ramiro Morales
51a9a5980a Made coverage ignore files without associated source code. 
This only affests reporting not data collection and allows coverage.py
to succesfully finish the generation of e.g. the HTML report.

Cases of code whose execution data is collected during the run phase but
for which no associated source code files can be found at the reporting
phase include tests with egg files and Python module files created at
test execution-time.
 2013-08-25 22:29:43 -03:00
Ramiro Morales
72712755c4 Ignore coverage HTML report output dir in tests. 
Added it to the list of dirs ignored by tests/runtests.py.
 2013-08-25 19:09:03 -03:00
Christopher Medrela
32a962bdbf Fixed #20814 -- Improved model field accessor clash error messages 
Thanks shai for the suggestion.
 2013-08-24 18:00:23 -04:00
Claude Paroz
f4e9804567 Fixed #20961 -- Fixed HttpResponse default empty content 
Thanks epandurski at gmail.com for the report.
 2013-08-24 18:10:12 +02:00
SusanTan
f33db5a09a Fixed 19949 -- Cached template loader now caches TemplateDoesNotExist 
Thanks @timgraham and @jdunck for the code reviews and Kronuz for bug
report and initial patch.
 2013-08-24 09:19:55 -04:00
Alex Gaynor
8363406dad Removed usage of u"" string prefix, which doesn't work on python3.2 2013-08-23 04:56:37 -07:00
Andrew Godwin
5569b0b92f Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/oracle/base.py
	django/db/backends/postgresql_psycopg2/base.py
	django/db/models/signals.py
	tests/queries/tests.py
 2013-08-23 12:36:53 +01:00
Andrew Godwin
ac45f9c9c5 Fix some small errors in the tests 2013-08-23 12:07:43 +01:00
Tim Graham
b0ce6fe656 Fixed #20922 -- Allowed customizing the serializer used by contrib.sessions 
Added settings.SESSION_SERIALIZER which is the import path of a serializer
to use for sessions.

Thanks apollo13, carljm, shaib, akaariai, charettes, and dstufft for reviews.
 2013-08-22 13:58:26 -04:00
Lukasz Balcerzak
9d1987d767 Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices 2013-08-22 11:50:52 -04:00
Rainer Koirikivi
65cf82bd08 Fixed #20934 -- Avoided NoReverseMatch in ModelAdmin.changelist_view 
The view tried to display links to a ModelAdmin's change_view, which
resulted in NoReverseMatches if get_urls was overridden to remove the
corresponding url.
 2013-08-22 10:08:54 -04:00
Anssi Kääriäinen
6af05e7a0f Fixed model.__eq__ and __hash__ for no pk value cases 
The __eq__ method now considers two instances without primary key value
equal only when they have same id(). The __hash__ method raises
TypeError for no primary key case.

Fixed #18864, fixed #18250

Thanks to Tim Graham for docs review.
 2013-08-22 17:24:07 +03:00
Anssi Kääriäinen
8d65b6082c Fixed #20955 -- select_related regression 
In cases where the same connection (from model A to model B along the
same field) was needed multiple times in a select_related query, the
join setup code mistakenly reused an existing join.
 2013-08-22 10:51:07 +03:00
Tim Graham
3f416f6379 Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c7364a11f6 Switched mail tests to SimpleTestCase. 2013-08-21 22:32:04 +01:00
Ramiro Morales
8e571e5f8f Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
244e2b71f5 Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c5fbd16362 Import test case classes from their public API module. 2013-08-21 22:32:04 +01:00
Ramiro Morales
01223840f3 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-21 22:32:04 +01:00
Florian Apolloner
839940f27f Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
3a8ae71ab5 Fixed invalid testing fixture 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
f5552571dc Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
ced3e6b17d Fixed test failure caused by different NULL ordering between backends 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
cea7204504 Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-21 22:30:46 +01:00
Anssi Kääriäinen
b773ef8fa0 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-21 22:30:45 +01:00
Simon Charette
63378163f9 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-21 22:30:45 +01:00
Simon Charette
77478d84ad Fixed an aggregation test failure on MySQL. 2013-08-21 22:30:02 +01:00
Andrew Godwin
2e7f45a372 Change autodetector changes API to be just one method 2013-08-21 22:25:15 +01:00
Tim Graham
f7290581fe Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 08:30:21 -04:00
Ramiro Morales
a5cf5da50d Switched mail tests to SimpleTestCase. 2013-08-21 07:48:16 -03:00
Ramiro Morales
ececbe77ff Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 07:44:20 -03:00
Anssi Kääriäinen
b065aeb17f Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 08:32:19 +03:00
Ramiro Morales
deebb1a977 Import test case classes from their public API module. 2013-08-20 22:23:41 -03:00
Ramiro Morales
f9d1d5dc13 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-20 22:17:26 -03:00
Florian Apolloner
96346ed5ad Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-20 21:25:57 +02:00
Anssi Kääriäinen
86f4459f9e Fixed invalid testing fixture 2013-08-20 17:48:02 +03:00
Anssi Kääriäinen
1ed77e7782 Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-20 16:54:05 +03:00
Anssi Kääriäinen
8dc76c4b91 Fixed test failure caused by different NULL ordering between backends 2013-08-20 11:33:44 +03:00
Anssi Kääriäinen
905409855c Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-20 10:55:00 +03:00
Anssi Kääriäinen
b53ed351b3 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-20 09:50:37 +03:00
Simon Charette
e55ca60903 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-20 01:53:58 -04:00
Simon Charette
fdbf492946 Fixed an aggregation test failure on MySQL. 2013-08-19 20:39:30 -04:00
Andrew Godwin
b6a957f0ba Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	docs/ref/django-admin.txt
 2013-08-19 18:30:48 +01:00
Rainer Koirikivi
3c03004050 Fixed #20640 -- Avoided NoReverseMatch in get_deleted_objects 
The default delete action resulted in a NoReverseMatch if it were to
list any Model with a ModelAdmin with `get_urls` overridden to remove
the change url.  Catching the error and not displaying the link in that
case, as was already done for models with no registered admins.

Thanks Keryn Knight for the report.
 2013-08-19 12:01:33 -04:00
Anssi Kääriäinen
58c6d0209d Fixed #12807 -- EmptyResultSet ORed condition 
The EmptyResultSet wasn't treated correctly so the end results was
incorrect, too. The bug had been already fixed in master so only tests
added.
 2013-08-19 16:24:45 +03:00
Anssi Kääriäinen
7bc57a6d71 Fixed #11881 -- removed junk from aggregation subqueries 
There were clauses that weren't needed in the subqueries. These were
ORDER BY, SELECT FOR UPDATE and related selections.
 2013-08-19 16:15:09 +03:00
Anssi Kääriäinen
7737305a4f Fixed #12886 -- aggregation over sliced queryset 2013-08-19 16:00:17 +03:00
Andrew Godwin
52edc16086 Add more stringent M2M tests and fix the bug they exposed 2013-08-19 13:50:26 +01:00
Anssi Kääriäinen
7d28bed13b PEP 8 cleanup 2013-08-19 14:16:10 +03:00
Anssi Kääriäinen
630b9df42f Fixed #12567 -- Incorrect SQL in model inheritance case 
An isnull lookup produced incorrect SQL. This was already fixed
earlier, so only tests added.
 2013-08-19 14:10:03 +03:00
Anssi Kääriäinen
3844089edc Fixed #20777 -- Admin proxy model deletion regression 
Added proxy_models tests by Harm Geerts <github@geertswei.nl>.
 2013-08-19 09:51:41 +03:00
Anssi Kääriäinen
4668c142dc Made Model.__eq__ consider proxy models equivalent 
Fixed #11892, fixed #16458, fixed #14492.
 2013-08-19 09:51:28 +03:00
Alex Gaynor
aa01c99f55 Merge pull request #1479 from nickbruun/ticket_20924 
Proxy __len__ and __contains__ for LazyObject
 2013-08-18 09:41:43 -07:00
Claude Paroz
165f44aaaa Combine consecutive with statements 
Python 2.7 allows to combine several 'with' instructions.
 2013-08-16 20:12:10 +02:00
Alasdair Nicol
22c6497f99 Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value 
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
 2013-08-15 19:47:26 -04:00
Nick Bruun
b9ef96e73c Regression test and patch for ticket #20924. 2013-08-15 20:59:58 +02:00
Jonathan Slenders
ff410565bf Fixed #20709 -- Allowed {% widthratio %} to accept an "as" parameter. 
Thanks clay.evil@ for the suggestion.
 2013-08-14 12:40:19 -04:00
Florian Apolloner
4e50e40654 Removed unneeded conditional_escapes from the testsuite. 2013-08-13 22:22:46 +02:00
Andrew Godwin
157604a87f Oracle schema backend, passes most tests and is pretty complete. 2013-08-13 20:54:57 +01:00
Matt Johnson
907ef9d0d1 Fixed #20555 -- Make subwidget id attribute available 
In `BoundField.__iter__`, the widget's id attribute is now passed to
each subwidget. A new id_for_label property was added to ChoiceInput.
 2013-08-13 13:23:05 -04:00
Jacob Kaplan-Moss
cbe6d5568f Apply autoescaping to AdminURLFieldWidget. 
This is a security fix; disclosure to follow shortly.
 2013-08-13 11:06:41 -05:00
Anssi Kääriäinen
09a5f5aabe Fixed test failure on MySQL 
The fix for #20874 caused a MySQL specific failure.
 2013-08-13 15:37:08 +03:00
Loic Bistuer
163a34ce4b Fixed #20883 -- Made model inheritance find parent links in abstract parents 2013-08-13 15:14:11 +03:00
Anssi Kääriäinen
dcdc579d16 Fixed #20874 -- bump_prefix() in nested subqueries 
Also made some cleanup to build_filter() code by introducing submethods
solve_lookup_type() and prepare_lookup_value().
 2013-08-13 14:11:52 +03:00
Ramiro Morales
6c12cd15e9 Unlocalize line numbers and ids in debug 500 view. 
While using USE_L10N, line numbers and IDs were printed as comma (or
locale equivalent) separated values.

Thanks Kronuz for the report and intial patch.

Fixes #20861.
 2013-08-12 21:59:27 -03:00
Tim Graham
71b5617c24 Fixed #17778 -- Prevented class attributes on context from resolving as template variables. 
Thanks KyleMac for the report, regebro for the patch, and Aymeric for the test.
 2013-08-12 12:41:39 -04:00
Mel Collins
6bdb3b1135 Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting 
This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.

Thanks jacob@ for the suggestion.
 2013-08-12 07:15:59 -04:00
Andrew Godwin
b61b634628 Fix weird planning issues when already fully migrated. 2013-08-11 15:28:51 +01:00
Andrew Godwin
ae19315b4d Support index_together during model creation 2013-08-11 14:23:31 +01:00
Ramiro Morales
22af1394c6 Expand testing of Test LiveServerTestCase static files serving. 2013-08-10 16:32:07 -03:00
Ramiro Morales
cb92e3391b Test that django.views.static.serve() generates 404 status codes. 
Also, change tests to be based on SimpleTestCase.
 2013-08-10 16:00:22 -03:00
Bojan Mihelac
0cac4fbf69 Fixed #18356 -- Gave the test client signals.template_rendered call a unique dispatch_uid 
This prevents the test client context from being lost when the client
is used in a nested fashion.
 2013-08-09 12:22:42 -04:00
Andrew Godwin
588b523233 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/options.py
 2013-08-09 14:37:37 +01:00
Andrew Godwin
de64c4d6e9 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/core/management/commands/flush.py
	django/core/management/commands/syncdb.py
	django/db/models/loading.py
	docs/internals/deprecation.txt
	docs/ref/django-admin.txt
	docs/releases/1.7.txt
 2013-08-09 14:17:30 +01:00
Tim Graham
9c711ee3a6 Fixed test failures on Python 3 - refs #12288 2013-08-09 09:12:15 -04:00
Tim Graham
b575d690bb Fixed test failures introduced by #12288 2013-08-09 08:34:37 -04:00
SusanTan
2ac89012d8 Fixed #12288 -- Added unique validation for INSTALLED_APPS 2013-08-09 08:08:34 -04:00
Marc Tamlyn
1c4a9bd9ad Revert change to the default Form.clean() 
This means it doesn't break for people who are doing
`cleaned_data = super(FooForm, self).clean()`.
 2013-08-08 14:27:48 +01:00
Marc Tamlyn
fb1dd6b13a Form.clean() does not need to return cleaned_data. 
If it does, that will be used as the cleaned_data. The default
implementation has been changed to match this change.
 2013-08-08 14:05:55 +01:00
Anssi Kääriäinen
c7739e30b2 Fixed #17424 -- annotate() + exclude() bug 
The bug was already fixed by 01b9c3d519,
so only tests added.

At the same time promote_joins()'s uncoditional flag is gone, it isn't
needed for anything any more.
 2013-08-07 12:53:33 +03:00
Collin Anderson
d53e574676 Fixed #20865 -- Fixed raw_id_fields to work with callable limit_choices_to. 2013-08-06 13:41:52 -04:00
Alex Cucu
1c64a0f29e Fixed #19918 -- Modified select_for_update to run on the write database. 2013-08-06 09:50:59 -04:00
Tai Lee
1280675834 Fixed #15511 -- Allow optional fields on `MultiValueField subclasses. 
The `MultiValueField` class gets a new ``require_all_fields`` argument that
defaults to ``True``. If set to ``False``, individual fields can be made
optional, and a new ``incomplete`` validation error will be raised if any
required fields have empty values.

The ``incomplete`` error message can be defined on a `MultiValueField`
subclass or on each individual field. Skip duplicate errors.
 2013-08-06 08:50:47 -04:00
Marc Tamlyn
0b771fcf29 Merge pull request #1441 from loic/ticket16986 
Fixed #16986 -- Model.clean() can report errors on individual fields.
 2013-08-06 02:10:45 -07:00
Anssi Kääriäinen
263b873599 Fixed ordering related test failure 
Also PEP8 + python_2_unicode_compatible cleanup done.
 2013-08-06 10:07:52 +03:00
Loic Bistuer
71093d22b6 Fixed #16986 -- Model.clean() can report errors on individual fields. 
This commit provides the tests for this issue but the actual problem was solved
by the ValidationError refactor in f34cfec and ee77d4b.

Refs #20199.
 2013-08-06 02:26:51 +07:00
Tim Graham
04489c7dbf Fixed #17667 -- Prevented app loading from skipping nonexistent apps after the first try 
Thanks ea2100@ for the report and akaariai for the patch.
 2013-08-05 13:34:35 -04:00
Tim Heap
75c87e2d38 Fixed #20850 -- Added MultiWidget.needs_multipart_form 2013-08-05 10:02:28 -04:00
Julien Phalip
f067887a4f Fixed some intermittent Selenium test failures. 2013-08-04 22:03:53 -07:00
Julien Phalip
995ffbb2a6 Added some Selenium tests for the admin raw id widget. 2013-08-04 16:08:45 -07:00
Loic Bistuer
ebb3e50243 Introduced ModelAdmin.get_fields() and refactored get_fieldsets() to use it. 
Refs #18681.

This also starts the deprecation of ModelAdmin.declared_fieldsets
 2013-08-04 09:14:18 -04:00
Curtis Maloney
07876cf02b Deprecated SortedDict (replaced with collections.OrderedDict) 
Thanks Loic Bistuer for the review.
 2013-08-04 07:09:39 -04:00
Aymeric Augustin
784377544e Fixed #20822 -- Set content type of default error pages to 'text/html'. 
Thanks Jimmy Song for the patch.
 2013-08-04 11:04:37 +02:00
Loic Bistuer
0bcdcc7eb9 Added ModelAdmin.get_search_fields. 2013-08-03 20:02:43 -04:00
Petr Dlouhý
1b47508ac8 Fixed LogEntry.get_admin_url() for non-existent models. 
Regression introduced by [369b6fa]; refs #18169.
 2013-08-02 12:51:10 -04:00
Loic Bistuer
a0ed2f9260 Fixed #18681 -- GenericInlineModelAdmin.get_formset() no longer bypasses get_fieldsets(). 
Refs 23e1b59 which already fixed this issue for ModelAdmin and InlineModelAdmin.
 2013-08-02 10:41:29 -04:00
Aleksandra Sendecka
893d8de6f5 Fixed #18777 -- Localized form fields with as_text/as_hidden 
Thanks croldan for the report.
 2013-08-02 08:41:54 -04:00
Tim Graham
aa830009de Fixed #17519 -- Fixed missing SQL constraints to proxy models. 
Thanks thibaultj for the report, jenh for the patch,
and charettes for the tests.
 2013-08-02 07:41:56 -04:00
Alex Couper
1123f45511 Fixed #20649 -- Allowed blank field display to be defined in the initial list of choices. 2013-07-31 14:12:03 -04:00
Will Hardy
1c3c21b38d Fixed #19987 -- Disabled host validation when DEBUG=True. 
The documentation promises that host validation is disabled when
DEBUG=True, that all hostnames are accepted. Domains not compliant with
RFC 1034/1035 were however being validated, this validation has now been
removed when DEBUG=True.

Additionally, when DEBUG=False a more detailed SuspiciousOperation
exception message is provided when host validation fails because the
hostname is not RFC 1034/1035 compliant.
 2013-07-31 10:38:59 -04:00
Loic Bistuer
acd1d439fd Fixed #20826 -- Moved Manager.raw() and Manager._insert() to the QuerySet class. 2013-07-31 09:54:00 -04:00
Florian Hahn
e888a9b30d Fixed #15624 -- Made sure aggregations are present in SELECT 2013-07-31 16:27:58 +03:00
Anssi Kääriäinen
e01b5a5823 Fixed #11521 -- usage of field.attname in .update() 
Fixed already by previous patch, only test added.
 2013-07-31 16:02:36 +03:00
Anssi Kääriäinen
c21e86ab9e Added field.attname to Options.name_map 
The change also removed allow_explicit_fk from sql/query.py.
 2013-07-31 16:02:36 +03:00
Tai Lee
31e6d58d46 Fixed #20348 -- Consistently handle Promise objects in model fields. 
All Promise objects were passed to force_text() deep in ORM query code.
Not only does this make it difficult or impossible for developers to
prevent or alter this behaviour, but it is also wrong for non-text
fields.

This commit changes `Field.get_prep_value()` from a no-op to one that
resolved Promise objects. All subclasses now call super() method first
to ensure that they have a real value to work with.
 2013-07-31 15:54:17 +03:00
SusanTan
ccf8f1e18f Added a test for AdminSite.app_index_template; refs #8498. 2013-07-31 06:59:15 -04:00
Tai Lee
4c6ffcf721 Fixed #20819 -- Return 404 instead of 500 error when `staticfiles` view is used in production. 2013-07-31 18:58:50 +10:00
Baptiste Mispelon
3c45fb8589 Fixed #10491 -- Allowed passing lazy objects to HttpResponseRedirect. 
Thanks liangent for the report.
 2013-07-30 13:39:44 -04:00
Tim Graham
8550df869b Removed part of a test that doesn't work on Jenkins; refs #19877. 2013-07-30 11:59:04 -04:00
Tim Graham
dffda2ba4e Fixed a test that depended on the DB backend; refs #19877. Thanks Loic. 2013-07-30 11:30:20 -04:00
Jose L. Patino
7b57e575c9 Fixed #19877 -- Added --no-color option to BaseCommand to avoid using output styles. 2013-07-30 09:26:18 -04:00
Andrew Godwin
fddc5957c5 Implement allow_migrate for migration operations 2013-07-30 12:34:31 +01:00
Andrew Godwin
12e9804d16 Rename allow_syncdb to allow_migrate 2013-07-30 12:08:59 +01:00
Julien Phalip
e351dbf6ee Fixed #19082 -- Enabled admin field pre-population for existing objects. 
Thanks to msaelices and d1ffuz0r for the initial patch and tests.
 2013-07-30 00:21:08 -07:00
Claude Paroz
5c1143910e Removed most of absolute_import imports 
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
 2013-07-29 20:28:13 +02:00
Claude Paroz
e4937b6dde Add utf-8 preamble to admin_scripts temp settings file 
As some settings are copied from current user settings, we cannot
be sure the characters are pure ascii.
 2013-07-29 17:10:23 +02:00
Claude Paroz
fdd7a355bf Deprecated django.utils.importlib 
This was a shim for pre-Python 2.7 support.
 2013-07-29 17:10:22 +02:00
Justin Michalicek
ac09558760 Fixed #20817 -- Added html_message parameter to django.core.mail.send_mail() 2013-07-29 09:53:47 -04:00
Przemek Lewandowski
382c53d7d8 Fixed #18213 -- Allowed empty fixtures (emit a warning rather than raising an exception). 2013-07-29 08:03:51 -04:00
Florian Apolloner
b70c371fc1 Simplified smart_urlquote and added some basic tests. 2013-07-28 10:05:39 +02:00
Julien Phalip
4e0ff35146 Fixed #11195 -- Added CSS classes to the changelist cells to allow style customizations. Thanks to akaihola, Ramiro Morales and vdboor for their work on the patch. 2013-07-27 19:50:02 -07:00
Julien Phalip
47c755327b Fixed a number of minor misspellings. 2013-07-27 18:46:03 -07:00
Florian Hahn
ca39c0a6be Fixed #18404 -- Added test for AppStaticStorage with non ascii path 
(bug was already fixed in #19357)
 2013-07-27 20:18:32 -04:00
Tim Graham
8676318d2d Fixed #20805 -- Removed an extra colon beside checkboxes in the admin. 
Thanks CollinAnderson for the report.
 2013-07-26 14:45:38 -04:00
Tim Graham
2a979d2a7b Updated contrib.admin to use Email/URLInputs; refs #16630 2013-07-26 07:22:30 -04:00
Anssi Kääriäinen
7cca8d56d2 Fixed related model lookup regression 
It has been possible to use models of wrong type in related field
lookups. For example pigs__in=[a_duck] has worked. Changes to
ForeignObject broke that.

It might be a good idea to restrict the model types usable in lookups.
This should be done intentionally, not accidentally and without any
consideration for deprecation path.
 2013-07-26 13:13:27 +03:00
Loic Bistuer
31fadc1202 Fixed #20625 -- Chainable Manager/QuerySet methods. 
Additionally this patch solves the orthogonal problem that specialized
`QuerySet` like `ValuesQuerySet` didn't inherit from the current `QuerySet`
type. This wasn't an issue until now because we didn't officially support
custom `QuerySet` but it became necessary with the introduction of this new
feature.

Thanks aaugustin, akaariai, carljm, charettes, mjtamlyn, shaib and timgraham
for the reviews.
 2013-07-26 12:41:27 +03:00
Carl Meyer
8f3aefdec3 Fixed handling of template loader tests. 
Previously, the CachedLoaderTests were never run at all.
 2013-07-25 17:19:17 -05:00
Andrew Godwin
a758c9c186 Add test for creating M2Ms 2013-07-25 16:36:58 +01:00
Anssi Kääriäinen
92476e880c Fixed ._meta.pk_index() virtual field failure 2013-07-25 16:25:23 +03:00
Andrew Godwin
00276e0414 Add tests for the migrate command and fix a bug they exposed 2013-07-25 13:52:35 +01:00
Anssi Kääriäinen
b2314d9e1e Fixed #19941 -- Modified runtests.py to make running the tests easier. 
1. Automatically use tests/../django as the Django version.
2. If settings aren't provided through --settings or DJANGO_SETTINGS_MODULE)
   then use test_sqlite.
 2013-07-24 07:33:03 -04:00
Tim Graham
31c13a99bb Fixed #14300 -- Fixed initial SQL location if models is a package. 
Thanks al_the_x for the report and fheinz for the draft patch.
 2013-07-24 06:56:33 -04:00
Tim Graham
65e03a424e Fixed #10284 -- ModelFormSet.save(commit=False) no longer deletes objects 
Thanks laureline.guerin@ and Wedg.
 2013-07-23 16:21:23 -04:00
Anssi Kääriäinen
c00a8525c6 Fixed #20788 -- exclude() generated subquery failure 
"Fixed" by adding a test case, the original problem was already fixed
by earlier ORM changes. Thanks to david@judicata.com for the report
and test case.
 2013-07-23 13:40:50 +03:00
Anssi Kääriäinen
4bd5554721 Fixed #20782 -- qs.values().aggregate() failure 
In the combination of .values().aggregate() the aggregate_select_mask
didn't include the aggregates added. This resulted in bogus query.

Thanks to Trac alias debanshuk for report.
 2013-07-23 11:38:38 +03:00
Andrew Godwin
162f7b938f Make migrate command recognise prefixes and 'zero'. 2013-07-22 19:43:58 +01:00
Andrew Godwin
52eb19b545 Make multi-app-cache tests work again 2013-07-22 19:36:03 +01:00
Andrew Godwin
03ec3219a0 Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/mysql/introspection.py
	django/db/backends/oracle/creation.py
	django/db/backends/postgresql_psycopg2/creation.py
	django/db/models/base.py
	django/db/models/loading.py
 2013-07-22 19:04:25 +01:00
Claude Paroz
02b0106d43 Fixed #20781 -- Fixed _has_changed regression with MultiValueField 
Thanks Tim Graham for the report.
 2013-07-22 09:06:07 +02:00
Thomas Sorrel
bb145e2c47 Fixed #13629 -- Added CSS classes to the <body> tag of some admin templates to allow style customizations per app or per model. 2013-07-21 20:17:14 +00:00
Claude Paroz
11b7b9ad00 Fixed an email validation regression 
Thanks Vincent Wagelaar for the report.
 2013-07-21 21:11:32 +02:00
Karen Tracey
3aad955ea8 Fixed #13696 -- ensured inline pk field is rendered 2013-07-21 13:06:11 -04:00
Simon Charette
415a36947c Fixed #20765 -- Set small values of step using exponential notation. 
Browsers parse small factors of 10 as 0 under decimal notation.

Thanks to Trac alias matklad for the report and Claude Paroz for the review.
 2013-07-19 23:31:15 -04:00
Claude Paroz
6d52844b9b Fixed #18551 -- Enabled skipIfDBFeature/skipUnlessDBFeature to decorate a class 
Thanks Tim Graham for the review and improved patch.
 2013-07-19 20:30:14 +02:00
Matt Deacalion Stevens
a269ea4fe0 Fixed #14656 -- Added Atom1Feed published element 
Some feed aggregators make use of the `published` element as well as
the `updated` element (within the Atom standard -- http://bit.ly/2YySb).

The standard allows for these two elements to be present in the same
entry. `Atom1Feed` had implemented the `updated` element which was
incorrectly taking the date from `pubdate`.
 2013-07-19 10:38:34 -04:00
Loic Bistuer
2fc6c9472c Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs. 
Thanks Collin Anderson for the report.
 2013-07-18 18:18:30 -04:00
Curtis Maloney
a3e7d73ed7 Allowed Context.push to behave as a context mananger. 
Thanks Loic Bistuer for the review.
 2013-07-17 13:32:32 -04:00
Tim Graham
2333c9662b Fixed #14007 -- Added model discovery in models module without the need to specify app_label. 
Thanks mark@ and Aramgutang for work on the patch.
 2013-07-16 19:32:30 -04:00
Tim Graham
2456ffa42c Fixed #20746 -- Removed Python 2.6 specific code/docs 2013-07-14 13:02:55 -04:00
Tim Graham
d9c580306c Fixed #20681 -- Prevented teardown_databases from attempting to tear down aliases 
Thanks simonpercivall.
 2013-07-13 17:46:05 -04:00
Tim Graham
9b471a8fe3 Fixed a deprecation warning in a selenium test. 2013-07-13 13:15:28 -04:00
Claude Paroz
73f86f4441 Isolated host validation tests in own test case 2013-07-13 10:16:52 +02:00
Tim Graham
f2cb94f1c0 Fixed #20740 -- GenericIPAddressField should pass protocol to formfield() 
Thanks Jeff250.
 2013-07-12 16:05:14 -04:00
Karol Sikora
6272d2f155 Fixed #20429 -- Added QuerySet.update_or_create 
Thanks tunixman for the suggestion and Loic Bistuer for the review.
 2013-07-12 08:26:35 -04:00
Joeri Bekker
66f3d57b79 Fixed #19031 -- Added a warning when using override_settings with 'DATABASES' 2013-07-12 07:10:18 -04:00
Claude Paroz
59ebe39812 Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend 
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
 2013-07-11 22:00:08 +02:00
Benjamin Kagia
b0953dc913 Fixed #13721 -- Added UploadedFile.content_type_extra. 
Thanks Waldemar Kornewald and mvschaik for work on the patch.
 2013-07-11 09:11:59 -04:00
Tim Graham
4d92a0bd86 Fixed #19196 -- Added test/requirements 2013-07-10 09:24:05 -04:00
Loic Bistuer
7e6d852bac Fixed #20663 -- "Today" and "now" admin shortcuts. 
Changed the shortcuts next to date and time intput widgets
to account for the current timezone.

Refs #7717, #14253 and #18768.
 2013-07-09 23:04:33 +02:00
Aymeric Augustin
404870ee1f Fixed #20724 -- Test failure on SQLite. 
This test failure happened if the connection's NAME was set to a file
system path, and its TEST_NAME wasn't.

Thanks Claude for the report.
 2013-07-09 21:41:30 +02:00
Aymeric Augustin
38bc581bc0 Avoided transaction.set_autocommit in tests. 
It doesn't work as one might expect on a certain database backend where
autocommits_when_autocommit_is_off = True. That backend happens to be
popular for running tests.
 2013-07-09 21:41:30 +02:00
Claude Paroz
57f190ed3b Only import gis test apps for geo-enabled DBs 2013-07-09 15:58:56 +02:00
Claude Paroz
bd563f0f57 Trusted test skipping about gis tests running or not 
With the new test discovery system, gis tests are discovered as
other tests. They should be properly skipped now when dependencies
are missing. So let's stop special casing their inclusion.
 2013-07-09 15:17:26 +02:00
Tim Graham
da79ccca1d Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows. 
Thanks Patryk Zawadzki.
 2013-07-08 08:33:40 -04:00
Alex Gaynor
626fa28878 Fixed #13813 -- Comparison of DatabaseWrappers doesn't raise errors. 
Patch from Lukasz Balcerzak.
 2013-07-08 09:35:08 +10:00
Tim Graham
2cbd579efe Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db. 
Thanks simonpercivall.
 2013-07-04 19:58:58 -04:00
Andrew Godwin
3a6580e485 Make get_constraints return columns in order 2013-07-02 18:02:20 +01:00
Andrew Godwin
61ff46cf8b Add AlterIndexTogether operation 2013-07-02 18:02:01 +01:00
Andrew Godwin
2202e3f7d3 Fix index_together test 2013-07-02 12:06:26 +01:00
Andrew Godwin
9ef715d256 Fix some bad test running under PostgreSQL 2013-07-02 11:51:38 +01:00
Andrew Godwin
6a8cfbf07b Support for index_together in schema backends 2013-07-02 11:43:44 +01:00
Andrew Godwin
3b20af3e96 Autodetection of unique_together changes 2013-07-02 11:25:18 +01:00
Andrew Godwin
67dcea711e Add unique_together altering operation 2013-07-02 11:19:02 +01:00
Andrew Godwin
310cdf492d Fix M2M interaction with transactions 2013-07-02 11:08:16 +01:00
Andrew Godwin
b1e0ec06f0 Merge branch 'master' into schema-alteration 2013-07-02 10:49:53 +01:00
Aymeric Augustin
e021b87c00 Fixed a few more imports of django.utils.unittest. 
One import per line please! Refs #20680.
 2013-07-01 22:49:07 +02:00
Aymeric Augustin
909433fa50 Removed tests for django.utils.unittest vs. unittest. 
Silenced warnings caused by the deprecation of django.utils.unittest.

Thanks Preston Timmons and Carl Meyer for their advice.

Fixed #20680.
 2013-07-01 21:49:11 +02:00
Tim Graham
a521d10322 Fixed a couple form/formset deprecation warnings in tests. 2013-07-01 09:36:31 -04:00
Tim Graham
a6a905c619 Updated tests for deprecation of Option.get_(add|change|delete)_permission. 
refs #20642.
 2013-07-01 09:19:55 -04:00
Aymeric Augustin
cfcf4b3605 Stopped using django.utils.unittest in the test suite. 
Refs #20680.
 2013-07-01 14:29:33 +02:00
Aymeric Augustin
2c40681805 Stopped calling loaddata with commit=False. 
This was a stealth option only used by the tests, and it isn't useful
any more since `atomic` provides nested transactions.
 2013-06-30 14:17:33 +02:00
Aymeric Augustin
acd7b34aaf Advanced deprecation warnings for Django 1.7. 2013-06-29 18:49:37 +02:00
Aymeric Augustin
8b9b8d3bda Removed compatibility code for streaming responses. 
This code provided a deprecation path for old-style streaming responses.

Refs #6527, #7581.
 2013-06-29 18:49:36 +02:00
Claude Paroz
59b0c48ce2 Fixed #18592 -- Prevented crash when accessing MySQL _last_executed 
Thanks reames at asymmetricventures.com for the report.
 2013-06-29 18:44:41 +02:00
Claude Paroz
7fbab3ebaf Do not allow FileSystemStorage.delete to receive an empty name 
Refs #20660.
 2013-06-29 18:09:31 +02:00
Claude Paroz
ea3fe78a9d Fixed #20660 -- Do not try to delete an unset FieldFile 
Thanks stanislas.guerra at gmail.com for the report and
Baptiste Mispelon for the review.
 2013-06-29 18:08:39 +02:00
Claude Paroz
6118d6d1c9 More import removals 
Following the series of commits removing deprecated features in
Django 1.7, here are some more unneeded imports removed and other
minor cleanups.
 2013-06-29 11:58:36 +02:00
Ramiro Morales
7379d9acea Removed insert(), value_for_insert() SortedDict methods deprecated in Django 1.5. 2013-06-28 22:38:13 -03:00
Ramiro Morales
6ba69c8456 Removed 'depth' .select_related() argument as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
c196564132 Removed custom profile model functionality as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
4f6be9a0c4 Removed warnings level handling code as per deprecation TL. 2013-06-28 21:48:15 -03:00
Andrew Godwin
7a47ba6f6a Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/models/fields/related.py
	tests/field_deconstruction/tests.py
 2013-06-28 17:32:57 +01:00
Andrew Godwin
48dd1e63bb Ported over Field.deconstruct() from my schema alteration branch. 
This is to help other ongoing branches which would benefit from
this functionality.
 2013-06-28 17:27:52 +01:00
Shai Berger
d097417025 Support 'pyformat' style parameters in raw queries, Refs #10070 
Add support for Oracle, fix an issue with the repr of RawQuerySet,
add tests and documentations. Also added a 'supports_paramstyle_pyformat'
database feature, True by default, False for SQLite.

Thanks Donald Stufft for review of documentation.
 2013-06-28 06:59:10 +03:00
Tim Graham
7c0b72a826 Prevented running some admin_view tests twice. 2013-06-27 20:13:42 -04:00
Tim Graham
534ced5aad Fixed #20664 -- Fixed a bug with raw_id_fields on Python 3. 
Thanks jefftriplett for the report.
 2013-06-27 19:39:20 -04:00
Aymeric Augustin
c1284c3d3c Fixed #20571 -- Added an API to control connection.needs_rollback. 
This is useful:
- to force a rollback on the exit of an atomic block without having to
  raise and catch an exception;
- to prevent a rollback after handling an exception manually.
 2013-06-27 22:19:54 +02:00
Andrew Godwin
99b467f272 Add related_query_name to ForeignKey/M2M. Refs #20244 2013-06-27 14:44:21 +01:00
Loic Bistuer
a9ea7d8c70 Fixed #20462 - Replaced the str() cast introduced in 273dc55 by force_text() 2013-06-26 21:30:58 +07:00
Andrew Clark
273dc550a4 Fixed #20462 -- null/non-string regex lookups are now consistent 
Thanks to noirbizarre for the report and initial patch.
 2013-06-26 08:13:26 -04:00
Baptiste Mispelon
ec371ace00 Fixed #20650 -- Fixed {% filter %} incorrectly accepting 'escape' as argument 
Thanks to grzesiof for the report and to loic84 and Alex Gaynor
for the review.
 2013-06-25 20:28:35 +02:00
Javier Mansilla
f819bef3dc Fixed #19773 - Added admin/popup_response.html template. 
Thanks jimmylam@ for the suggestion.
 2013-06-25 11:20:41 -04:00
Russell Keith-Magee
0346563939 Fixed #20653 -- Renamed checksetup management command. 
This is to allow future compatibility with work that is ongoing in the 2013 GSoC.
 2013-06-25 09:37:54 +08:00
Ramiro Morales
1559f84d8b Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers. 
Thanks naktinis for the report and initial patch.
 2013-06-22 18:45:41 -03:00
Andrew Godwin
e2d7e83256 Autodetect ForeignKeys and add dependencies/split on circulars 2013-06-22 17:15:51 +01:00
Gilberto Gonçalves
680b512fc1 Fixed #20587 -- Made convert_values handle None values 2013-06-22 14:05:12 +01:00
Gilberto Gonçalves
ef37b23050 Fixed #18872 -- Added prefix to FormMixin 
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
 2013-06-22 12:12:43 +01:00
Claude Paroz
ef79582e86 Fixed 17478 -- Allowed queryset overriding in BaseModelFormSet init 
BaseModelFormSet.forms is now a cached property instead of being
populated in the __init__ method. This behaviour also matches an
example in the documentation.
Thanks Thomasz Swiderski for the report and Simon Charette for the
review.
 2013-06-22 09:29:37 +02:00
Oliver Beattie
552a90b444 Fixed #20290 -- Allow override_settings to be nested 
Refactored override_settings to store the underlying settings._wrapped
value seen at runtime, not instantiation time.
 2013-06-21 16:57:47 +02:00
Andrew Godwin
cca40703df Prompt about renames rather than doing them automatically 2013-06-21 15:32:15 +01:00
Andrew Godwin
92a10f5552 Autodetect field renames. HAHAHA. AHAHAHAHA. YES. 2013-06-20 16:02:43 +01:00
Simon Charette
04628e2016 Fixed #20630 -- Removed maxlength attribute from NumberInput. 
This attribute is only allowed on inputs of type "text", "search", "url",
"tel", "email", or "password".

Thanks to yoyoma for the report and @bmispelon for the review.
 2013-06-20 10:59:41 -04:00
Andrew Godwin
47e4b86ddf Autodetect field alters 2013-06-20 15:19:30 +01:00
Andrew Godwin
80bdf68d6b Add AlterField and RenameField operations 2013-06-20 15:12:59 +01:00
Andrew Godwin
6f667999e1 Add operation that renames tables 2013-06-20 14:54:11 +01:00
Russell Keith-Magee
18e79f1425 Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists. 
Thanks to kux for the report, and Russ Webber for the patch.
 2013-06-20 18:55:27 +08:00
Andrew Godwin
ab5cbae9b7 First stab at some migration creation commands 2013-06-19 15:36:22 +01:00
Andrew Godwin
2ae8a8a77d Fix test running with new apps stuff/migrate actually running migrations 2013-06-19 15:36:02 +01:00
Andrew Godwin
9daf81b94e Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/loading.py
 2013-06-19 12:05:23 +01:00
Aymeric Augustin
d9a43545be Merge pull request #1282 from loic/ticket6903 
Fixed failing test on MySQL since c86a9b6
 2013-06-19 03:04:04 -07:00
Loic Bistuer
7d0c3b9b26 Fixed MySQL failing test introduced by c86a9b6 2013-06-19 16:13:43 +07:00
Florian Hahn
2f35c6f10f Fixed #14930 -- values_list() failure on qs ordered by extra column 
Thanks lsaffre for the report and simon29, vicould, and Florian Hahn
for the patch.

Some changes done by committer.
 2013-06-18 23:56:51 +03:00
Aymeric Augustin
9da9b3eb04 Merge pull request #1281 from loic/ticket6903 
Fixed #6903 - Preserved admin changelist filters.
 2013-06-18 13:07:28 -07:00
Loic Bistuer
c86a9b6398 Fixed #6903 - Preserve admin changelist filters after saving or deleting an object 2013-06-19 02:41:36 +07:00
Erik Romijn
aeb1389442 Fixed #20079 -- Improve security of password reset tokens 2013-06-18 20:02:00 +02:00
Baptiste Mispelon
3128f3d38d Fixed #20618 -- Fixed regression in BoundField.label_tag. 2013-06-18 17:49:53 +02:00
Loic Bistuer
ee77d4b253 Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields 2013-06-18 08:01:17 -04:00
Loic Bistuer
f34cfec0fa Refactored ValidationError to allow persisting error params and error codes as the exception bubbles up 2013-06-18 08:01:17 -04:00
Baptiste Mispelon
1b7634a0d0 Fixed #20464 -- Added a total_error_count method on formsets. 
Thanks to frog32 for the report and to Tim Graham for the review.
 2013-06-16 15:49:30 -04:00
Aymeric Augustin
c3df866619 Fixed #20603 -- Made the test suite faster. 
By avoiding to run syncdb with the full set of test models.

Thanks Anssi for the idea.
 2013-06-14 23:16:15 +02:00
Marc Tamlyn
46789e76c6 Fixed #20548 -- Removed all PendingDeprecationWarnings from django test suite 2013-06-14 15:37:39 +01:00
Anssi Kääriäinen
5459795ef2 Fixed #20289 -- pickling of dynamic models 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
855d1305c5 Added cache to available_apps in cache tests 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
89bf7a4525 Fixed #20528 -- regression in select_related join promotion 
The join used by select_related was incorrectly INNER when the query
had an ORed filter for nullable join that was trimmed away. Fixed this
by forcing the join type to LOUTER even when a join was trimmed away
in ORed queries.
 2013-06-14 16:29:06 +03:00
Marc Tamlyn
b7bd7087e6 Fixed #15273 -- Extend RedirectView to allow reversal by name. 
Thanks to @DrMeers for the report and @ludwigkraatz for the initial patch.
 2013-06-14 11:59:26 +01:00
Wilfred Hughes
8365ed08b8 Fixed #17076 -- When reversing a URL fails, inform the user which patterns were tried. 2013-06-14 10:26:30 +01:00
Daniel Lindsley
91f317c76d Added a `checksetup` management command for verifying Django compatibility. 2013-06-13 18:39:02 -07:00
Loic Bistuer
9e50833e22 Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages 2013-06-13 15:06:25 -04:00
Baptiste Mispelon
dc9c359546 Fixed #20594 -- Add validation to models.SlugField. 
Thanks carbonXT for the report.
 2013-06-13 13:31:57 -04:00
Tim Graham
92c49d6f01 Revert "Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields." 
This reverts commit 64041f0e6e.

lookup.tests.LookupTests.test_regex_non_string fails under Postgres.
We should also try to rewrite the test using an existing model.
 2013-06-11 17:55:19 -04:00
Axel Haustant
64041f0e6e Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields. 2013-06-11 14:13:40 -04:00
Gabe Jackson
584bd14dcf Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix 
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.

This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
 2013-06-10 14:23:15 -04:00
Florian Apolloner
af70dfcf31 Reverted the introduction of shared_models. 
The recent improvements should make shared_models obsolete.

This reverts commit 1059da8de6, reversing
changes made to 4fa7f3cdd9.
 2013-06-10 12:34:47 +02:00
Florian Apolloner
f5d4849cbe Revert "Began implementing a shared set of test models to speed up tests." 
This reverts commit 22b7870e40.
 2013-06-10 12:22:40 +02:00
Aymeric Augustin
dfcce4288a Fixed available_apps for selenium tests. 
Refs #20483.
 2013-06-10 12:11:46 +02:00
Aymeric Augustin
c6e6d4eeb7 Defined available_apps in relevant tests. 
Fixed #20483.
 2013-06-10 11:30:01 +02:00
Aymeric Augustin
7a65c95d42 Refactored file_storage tests to avoid depending on servers tests. 2013-06-10 11:16:15 +02:00
Tim Graham
96c71d423d Added runserver validation to detect if DEBUG=False and ALLOWED_HOSTS is empty. 
Refs #19875.
 2013-06-09 15:08:29 -04:00
Andrew Godwin
91c470def5 Auto-naming for migrations and some writer fixes 2013-06-07 17:56:43 +01:00
Andrew Godwin
cd809619a2 Autodetector tests 2013-06-07 15:49:48 +01:00
Andrew Godwin
c7aa4b5338 Field encoding 2013-06-07 15:36:31 +01:00
Andrew Godwin
4492f06408 A bit of an autodetector and a bit of a writer 2013-06-07 15:28:38 +01:00
Andrew Godwin
3c296382b8 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/fields/related.py
 2013-06-07 11:15:34 +01:00
Stephen Burrows
e2518fdf46 Fixed #12337 - Honor ModelForm.Meta.exclude when saving ManyToManyFields. 
Thanks margieroginski for the report.
 2013-06-06 10:01:48 -04:00
Claude Paroz
b67f2ac8e6 Fixed #20502 (again) -- More i18n cache flush in tests 
Thanks Timo Graham for noticing the failures.
 2013-06-06 14:28:58 +02:00
Marc Tamlyn
9ed971f4f1 Merge pull request #1245 from oinopion/list_select_related 
Fixed #19080 -- Fine-grained control over select_related in admin
 2013-06-06 01:27:05 -07:00
Anssi Kääriäinen
31fd64ad8a Fixed #20564 -- Generic relations exclude() regression 
The patch for #19385 caused a regression in certain generic relations
.exclude() filters if a subquery was needed. The fix contains a
refactoring to how Query.split_exclude() and Query.trim_start()
interact.

Thanks to Trac alias nferrari for the report.
 2013-06-06 01:54:46 +03:00
Tomek Paczkowski
0fd9f7c95f Fixed #19080 -- Fine-grained control over select_related in admin 2013-06-05 23:08:00 +02:00
Anssi Kääriäinen
8c5b805ca1 PEP 8 cleanup 2013-06-05 21:18:56 +03:00
Bojan Mihelac
b00c6371af Fixed #17927 -- Added initial values support for BaseGenericInlineFormSet 
Thanks Fak3 for the suggestion.
 2013-06-05 07:59:59 -04:00
Tim Graham
a35ed20241 Fixed #18924 -- Made test.Client.logout send user_logged_out signal. 
Thanks awsum for the suggestion and Pavel Ponomarev and
Florian Hahn for the patch.
 2013-06-04 12:39:09 -04:00
Ramiro Morales
e71b63e280 Added i18n-related URL mapper test for a mailing list report. 2013-06-04 11:19:27 -03:00
Aymeric Augustin
51aa000378 Fixed #20485 -- Refactored loaddata for speed. 
Thanks Anssi for reporting this performance bottleneck.
 2013-06-02 20:39:45 +02:00
Tim Graham
61524b09cf Fixed #18388 - Added InlineModelAdmin.get_max_num hook. 
Thanks d.willy.c.c@ for the suggestion and Melevir and Areski Belaid for work
on the patch.
 2013-06-01 18:20:54 -04:00
Tim Graham
fffb55860e Changed assertEquals -> assertEqual. 2013-06-01 06:31:25 -04:00
Claude Paroz
de66b56790 Fixed #18481 -- Wrapped request.FILES read error in UnreadablePostError 
Thanks KyleMac for the report, André Cruz for the initial patch and
Hiroki Kiyohara for the tests.
 2013-06-01 10:26:46 +02:00
Anssi Kääriäinen
369b6fab25 Fixed #18169 -- NoReverseMatch not silenced if from block.super 2013-06-01 00:59:04 +03:00
Anssi Kääriäinen
84909377f2 Fixed #18785 -- Added Test join trimming regression 
The regression was caused by patch to ticket #15316 and was fixed by a
patch to #10790.
 2013-06-01 00:28:44 +03:00
Chris Wilson
fa7cb4ef3c Fixed #20404 -- Added a keys() method to ContextList. 
It's useful to be able to list all the (flattened) keys of a
ContextList, to help you figure out why the variable that's supposed
to be there is not.

No .values() or .items() added as the definition for those aren't clear.

The patch is Chris Wilson's patch from pull request 1065 with some
modifications by committer.
 2013-06-01 00:04:06 +03:00
Loic Bistuer
23e1b59cf2 Fixed #18681 -- BaseModelAdmin.get_form and InlineModelAdmin.get_formset no longer bypass get_fieldsets 
Thanks msopacua for the report.
 2013-05-31 12:48:51 -04:00
Anssi Kääriäinen
728d3fe1ba Fixed #16436 -- Oracle defer_regress test failure 
Oracle doesn't like grouping by TextField, so use CharFields instead in
models.
 2013-05-31 10:11:15 +03:00
Claude Paroz
9d06c6ccc9 Fixed #20502 -- Flushed i18n caches for a defaultfilter test 
Thanks Chris Wilson for the report and initial patch.
 2013-05-30 20:23:14 +02:00
Tim Graham
36aecb12b8 Fixed #19425 - Added InlineModelAdmin.get_extra hook. 
Thanks dave@ for the suggestion and Rohan Jain for the patch.
 2013-05-30 13:48:10 -04:00
Andrew Godwin
e6f7f4533c Add an Executor for end-to-end running 2013-05-30 18:08:58 +01:00
Andrew Godwin
7f9a0b7061 Fix graph tests 2013-05-30 17:56:53 +01:00
Andrew Godwin
05929ee89b Add the start of some operation tests 2013-05-30 17:55:59 +01:00
Tim Graham
7902fd74f1 Merge pull request #1027 from intgr/debug_no_exc_message 
Clearer explanation when exception has no message
 2013-05-30 09:53:07 -07:00
Tim Graham
5074c75a37 Fixed #16856 - Added a way to clear select_related. 
Thanks Carl for the suggestion and David Cramer for the patch.
 2013-05-30 11:06:05 -04:00
Tim Graham
59235816bd Fixed #20509 - Proper parsing for dumpdata --pks option. 
Thanks weipin for the report and Baptiste Mispelon for the patch.
 2013-05-30 10:19:13 -04:00
Tai Lee
69f7db153d Fixed #16436 -- defer + annotate + select_related crash 
Correctly calculate the ``aggregate_start`` offset from loaded fields,
if any are deferred, instead of ``self.query.select`` which includes all
fields on the model.

Also made some PEP 8 fixes.
 2013-05-30 08:46:31 +03:00
Anssi Kääriäinen
bb80d2976b Made an app-cache test not dependent on all models in defer_regress 2013-05-30 08:46:31 +03:00
Simon Charette
dcd915fcab Fixed a failure on Python 3 introduced by 5939864616. 
Refs #15653.
 2013-05-29 15:38:52 -04:00
Andrew Godwin
52d2a8b311 Add test for new __ne__ method on Promise. 2013-05-29 17:52:17 +01:00
Andrew Godwin
d0ecefc2c9 Start adding operations that work and tests for them 2013-05-29 17:47:10 +01:00
Tim Graham
d727518ad6 Fixed #20331 -- Allowed admin actions to serve StreamingHttpResponses 
Thanks Edwin.
 2013-05-29 11:25:42 -04:00
Claude Paroz
8010289ea2 Fixed #15697 -- Made sqlindexes aware of auto-created tables 
Thanks mbertheau for the report and Ash Christopher for the
initial patch.
 2013-05-29 15:50:26 +02:00
Tim Graham
5939864616 Fixed #15653 - Error in admin pagination tag. 
Thanks jcumbo@ for the report and adamzap
and nott for the patch.
 2013-05-29 09:23:08 -04:00
Tim Graham
7426e72302 Fixed #20250 - Added a regression test for negated Q + annotate 
Thanks nott.
 2013-05-29 08:49:42 -04:00
Tim Graham
ded95ccdce Fixed #20484 -- Added model validation for GenericIPAddressField 
GenericIPAddressField must not allow blank for NOT NULL fields

Thanks Erik Romijn.
 2013-05-28 15:12:47 -04:00
Tim Graham
a2967d5204 Fixed #20242 - Added a regression test for prefetch_related. 
Issue was fixed by removal of chunked reads from
QuerySet iteration in 70679243d1.

Thanks Simeon Visser for the patch.
 2013-05-28 13:37:44 -04:00
Tim Graham
d321d1acf0 Fixed #20228 - Documented unique_for_date and exclude behavior. 
Thanks Deepak Thukral for the patch.
 2013-05-28 10:04:07 -04:00
Anssi Kääriäinen
33dd8f5442 Fixed random aggregation_regress test_more_more_more() failure 
The cause was assuming that an unordered queryset returns the values
always in the same order.
 2013-05-28 08:55:04 +03:00
Tim Graham
0268aba96b Fixed #20182 - admin lookup should treat 0 as False for __isnull 
Thanks Benjie Chen.
 2013-05-27 13:29:53 -04:00
Tim Graham
d194714c0a Fixed #11603 - Added django.test.SimpleTestCase.assertFormsetError 
Thank-you Martin Green for the patch.
 2013-05-27 12:25:35 -04:00
Shai Berger
1e29428db2 Fixed #20013 -- A test for sqlall fails under Oracle 2013-05-27 18:34:31 +03:00
Tim Graham
90af278203 Fixed #16137 - Removed kwargs requirement for QuerySet.get_or_create 
Thanks wilfred@, poirier, and charettes for work
on the patch.
 2013-05-27 10:01:14 -04:00
Tim Graham
6f8627dd7f Fixed #17582 - Added message to DoesNotExist exceptions. 
Thanks simon@ for the suggestion and JordanPowell
for the initial patch.
 2013-05-27 07:57:06 -04:00
Anssi Kääriäinen
d467e11785 Fixed #20507 -- SubqueryConstraint alias relabeling 
The SubqueryConstraint defined relabeled_clone(), but that was never
called. Instead there is now clone() and relabel_aliases() methods for
SubqueryConstraint.

A related problem was that SubqueryConstraint didn't correctly use
quote_name_unless_alias() of the outer query. This resulted in failures
when running under PostgreSQL.
 2013-05-27 12:25:29 +03:00
Ramiro Morales
0fa8d43e74 Replaced and...or... constructs with PEP 308 conditional expressions. 2013-05-26 23:47:50 -03:00
Preston Holmes
d228c1192e Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation. 
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.

Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
 2013-05-25 16:27:34 -07:00
Shai Berger
36d47f72e3 Fixed get_or_create...test_savepoint_rollback test for Python3 
The test was always skipped on Python3 because string literals are unicode
 2013-05-26 01:53:24 +03:00
Shai Berger
cf159e5c93 Fix get_or_create test failure under Oracle 
Test expected that when given invalid utf-8, the backend should raise
a DatabaseError, but the Oracle backend raises a UnicodeDecodeError.
 2013-05-26 01:39:34 +03:00
Andrew Jesaitis
31f6421b13 Fixed #19938 -- Consumed iterator only once in paginator's Page 
Thanks Joshua Fialkoff for the report.
 2013-05-25 16:27:26 +02:00
Baptiste Mispelon
2ee447fb5f Fixed #20296 -- Allowed SafeData and EscapeData to be lazy 2013-05-25 16:06:44 +02:00
Claude Paroz
be0bab1bb8 Fixed #11725 -- Made possible to create widget label tag without "for" 
Thanks Denis Martinez for the report and initial patch, and
Sergey Kolosov for bringing the patch up to date.
 2013-05-25 15:31:07 +02:00
Claude Paroz
f940e564e4 Fixed #20099 -- Eased subclassing of BrokenLinkEmailsMiddleware 
Thanks Ram Rachum for the report and the initial patch, and Simon
Charette for the review.
 2013-05-25 12:10:53 +02:00
Vlastimil Zíma
6de81d65f4 Fixed #14825 -- LocaleMiddleware keeps language 
* LocaleMiddleware stores language into session if it is not present there.
 2013-05-25 10:52:54 +02:00
Claude Paroz
7e95d7a930 Fixed a regression in router initialization 
Regression was introduced in 6a6bb168b. Thanks Bas Peschier for the
report.
 2013-05-24 20:48:02 +02:00
Luke Plant
4fd94969d8 Fixed #19607 - prefetch_related crash 
Thanks to av@rdf.ru and flarno11@yahoo.de for the report.
 2013-05-24 11:10:48 +01:00
Gavin Wahl
48424adaba Fixed #17648 -- Add for_concrete_model to GenericForeignKey. 
Allows a `GenericForeignKey` to reference proxy models. The default
for `for_concrete_model` is `True` to keep backwards compatibility.

Also added the analog `for_concrete_model` kwarg to
`generic_inlineformset_factory` to provide an API at the form level.
 2013-05-23 19:03:14 -04:00
Donald Stufft
8dda8a5ecc Removed noise from pre_syncdb signal tests 
Only make assertions that actually test the functionality of the
change and not unrelated pieces.
 2013-05-23 15:58:08 -04:00
Claude Paroz
499a745ae1 Fixed #20474 -- Proxied and deprecated django.db.backend 2013-05-23 15:19:12 +02:00
Claude Paroz
b664cb818d Fixed #19237 (again) - Made strip_tags consistent between Python versions 2013-05-23 14:01:27 +02:00
Ramiro Morales
8c2fd050f8 Made fix for #9321 less buggy and more effective. 
Don't try to be smart about building a good-looking help string
because it evaluates translations too early, simply use the same old
strategy as before. Thanks Donald Stufft for the report.

Also, actually fix the case reported by the OP by special-casing
CheckboxSelectMultiple.

Added tests.

Refs #9321.
 2013-05-23 07:49:29 -03:00
Donald Stufft
3de1288042 Fixed #11398 - Added a pre_syncdb signal 2013-05-23 01:09:22 -04:00
Russell Keith-Magee
11b06532f7 Merge pull request #1198 from KrzysiekJ/http-patch-method 
Fixed #20478 – Added support for HTTP PATCH method in generic views.
 2013-05-22 17:19:43 -07:00
Claude Paroz
51998dffe7 Removed check for 0.15 version of gettext tools 
gettext 0.15 has been released in July 2006.
 2013-05-22 18:21:33 +02:00
Claude Paroz
dc51ec8bc2 Fixed #19237 -- Used HTML parser to strip tags 
The regex method used until now for the strip_tags utility is fast,
but subject to flaws and security issues. Consensus and good
practice lead use to use a slower but safer method.
 2013-05-22 17:34:02 +02:00
Krzysztof Jurewicz
ee8b810b97 Fixed #20478 – Added support for HTTP PATCH method in generic views. 2013-05-22 14:48:11 +02:00
Aymeric Augustin
0e51d8eb66 Fixed #20463 -- Made get_or_create more robust. 
When an exception other than IntegrityError was raised, get_or_create
could fail and leave the database connection in an unusable state.

Thanks UloPe for the report.
 2013-05-22 10:56:06 +02:00
Marc Tamlyn
adeec00979 Merge pull request #246 from dekkers/ticket_18709 
Fixed #18709 -- Check if initial_value is a callable
 2013-05-22 00:45:07 -07:00
Anssi Kääriäinen
904084611d Fixed #19895 -- Second iterator over invalid qs raises errors 
The fix was already in the patch for #18702, so only test added for
ticket #19895.
 2013-05-22 08:30:41 +03:00
Jeroen Dekkers
d0788c2770 Fixed #18709 -- Check if initial_value is a callable 
In _get_changed_data, check if initial_value is a callable and call it
if it is.
 2013-05-22 01:05:22 +02:00
Anssi Kääriäinen
70679243d1 Fixed #18702 -- Removed chunked reads from QuerySet iteration 2013-05-21 19:51:59 +03:00
Selwin Ong
ea9a0857d4 Fixed #19326 -- Added first() and last() methods to QuerySet 2013-05-21 18:52:28 +03:00
Mathijs de Bruin
61a8de6f4f Fixed #6412 -- More details if a template file cannot be loaded 
Report more details about template files in loader postmortem.
 2013-05-21 16:59:40 +02:00
Florian Apolloner
800513e7f3 Merge pull request #1194 from ambv/python26_is_fun 
Fixed a Python 2.6 regression (GzipFile can't act as a context manager)
 2013-05-21 04:20:35 -07:00
Wiktor Kolodziej
cec9558fba Fixed #17308 -- Enabled the use of short_description on properties in the admin. 2013-05-21 13:19:18 +02:00
Łukasz Langa
c28281f9d6 Fixed a Python 2.6 regression (GzipFile can't act as a context manager) 2013-05-21 13:18:53 +02:00
Florian Apolloner
b1ac241ddc Fixed test failures from 09f8652765. 2013-05-21 13:03:25 +02:00
Marc Tamlyn
09f8652765 Use assertIsInstance in tests. 
Gives much nicer errors when it fails.
 2013-05-21 10:42:15 +01:00
Aymeric Augustin
18856f866c Merge pull request #1191 from ambv/content_is_bytes 
Fixed #20472: response.content should be bytes on both Python 2 and 3
 2013-05-21 01:26:35 -07:00
Daniel Lindsley
e24d486fbc Fixed #20212 - __reduce__ should only be defined for Py3+. 2013-05-21 00:49:21 -07:00
Łukasz Langa
0594fed9ff Fixed #20472: response.content should be bytes on both Python 2 and 3 2013-05-21 01:28:16 +02:00
Jorge Bastida
888c86dcf3 Fixed #20445 -- Raised original exception after command error 2013-05-20 18:59:37 +02:00
Ryan Kaskel
4280217f31 Fixed #20403 -- Ignore forms marked for deletion when validating max_num. 2013-05-20 12:13:21 -04:00
Anssi Kääriäinen
266c0bb23e Fixed #20278 -- ensured .get() exceptions do not recurse infinitely 
A regression caused by d5b93d3281 made .get() error
reporting recurse infinitely on certain rare conditions. Fixed this by
not trying to print the given lookup kwargs.
 2013-05-20 18:50:40 +03:00
Anssi Kääriäinen
c9a96075fa Fixed #20378 -- regression in GenericRelation on abstract model 
When a GenericRelation was defined on abstract model, queries on childs
of the abstract model didn't work. The problem was in the way fields and
in particular field.rel was copied from models to their children.

The regression was likely caused by #19385. Thanks to Gavin Wahl for
spotting the regression.
 2013-05-20 18:02:10 +03:00
Anssi Kääriäinen
f53059b411 Fixed qs.values() regression when used in subquery 2013-05-20 15:38:47 +03:00
Marc Tamlyn
6d81d5d82e Merge pull request #1181 from aaugustin/better-api-to-disable-atomic-requests 
Changed API to disable ATOMIC_REQUESTS per view.
 2013-05-20 00:26:06 -07:00
Carl Meyer
a7dc13ec23 Fixed #20437 - marked a test-runner test as expected-fail under certain conditions. 2013-05-20 01:56:23 -04:00
Tomasz Jaskowski
022de7e139 Fixed #20449 - Corrected test sensitivity to current working dir. 2013-05-19 23:58:06 -04:00
Alex Gaynor
7c56212c71 Lower the max length for a test field so that it works on MySQL. 2013-05-19 13:58:58 -07:00
Anssi Kääriäinen
190771d003 Fixed fixtures testing failure 
The failure was caused by generating the same warning from two tests.
The second time the same warning was raised it was swallowed by the
"once" simplefilter of warnings.
 2013-05-19 20:53:49 +03:00
Aymeric Augustin
6633eeb886 Changed API to disable ATOMIC_REQUESTS per view. 
A decorator is easier to apply to CBVs. Backwards compatibility isn't an
issue here, except for people running on a recent clone of master.

Fixed a few minor problems in the transactions docs while I was there.
 2013-05-19 19:53:16 +02:00
Preston Holmes
6786920fd8 Fixed #16330 -- added --pks option in dumpdata command 
Thanks to guettli for the initial ticket and patch, with additional work
from mehmetakyuz and Kevin Brolly.
 2013-05-19 09:10:40 -07:00
Bozidar Benko
2d309a7043 Fixed #15961 -- Modified ModelAdmin to allow for custom search methods. 
This adds a get_search_results method that users can override to
provide custom search strategies.

Thanks to Daniele Procida for help with the docs.
 2013-05-19 16:45:00 +02:00
Aymeric Augustin
b06f6c1618 Fixed test failure introduced in 1927bf7c91. 2013-05-19 16:23:14 +02:00
Pablo Recio
65f9e0affd Fixes #18896. Add tests verifying that you can get IntegrityErrors using get_or_create through relations like M2M, and it also adds a note into the documentation warning about it 2013-05-19 14:16:12 +02:00
Aymeric Augustin
d34b1c29e2 Merge pull request #1161 from erikr/urlize-additional-test 
Fixed #19070 -- Additional test for urlize and brackets
 2013-05-19 04:59:15 -07:00
Aymeric Augustin
f7467181aa Merge pull request #1160 from erikr/host-inet-postgres2 
Fixed #11442 -- Postgresql backend casts all inet types to text
 2013-05-19 04:57:10 -07:00
Erik Romijn
1927bf7c91 Fix #19070 -- Additional test for urlize and brackets 2013-05-19 13:39:21 +02:00
Erik Romijn
60d94c2a80 Fixed #11442 -- Postgresql backend casts all inet types to text 2013-05-19 13:28:09 +02:00
Łukasz Langa
660762681c Fixed #20126 -- XViewMiddleware moved to django.contrib.admindocs.middleware 2013-05-19 13:18:35 +02:00
Aymeric Augustin
cb86f707a0 Fixed #12747 -- Made reason phrases customizable. 2013-05-19 13:14:54 +02:00
Aymeric Augustin
3129d19071 Merge pull request #1152 from ambv/issue11915 
Fixed #11915: generic Accept-Language matches country-specific variants
 2013-05-19 04:01:20 -07:00
Andrew Godwin
04e0fc029f Merge pull request #1094 from senko/ticket_11160 
Fixed #11160: Formset non_form_errors returns ErrorList() if is_valid is not called
 2013-05-19 03:56:14 -07:00
Andrew Godwin
7a99d1e167 Merge pull request #1134 from senko/ticket_18990 
Fixed #18990: Loaddata now complains if fixture doesn't exist
 2013-05-19 03:54:29 -07:00
Łukasz Langa
26e3e7ecb5 Fixed #11915: generic Accept-Language matches country-specific variants 2013-05-19 12:50:09 +02:00
Senko Rasic
65c557115f fix warnings imports in fixtures tests 2013-05-19 12:49:03 +02:00
Honza Kral
4ad1eb1c14 Fixed #12674 -- provide a way to override admin validation 
Moved admin validation code to classes and have those be class
attributes to the ModelAdmin classes.
 2013-05-19 12:42:52 +02:00
Andrew Godwin
264f8650e3 ModelState now freezes options and bases 2013-05-19 12:35:17 +02:00
Łukasz Langa
e80636b668 Added TransRealMixin to fix i18n global state pollution in the test suite 2013-05-19 12:05:57 +02:00
Senko Rasic
c44a2c40fe Fixed #18990 -- Loaddata now complains if fixture doesn't exist 
If the fixture doesn't exist, loaddata will output a warning.

The fixture named "initial_data" is exceptional though; if it
doesn't exist, the warning is not emitted. This allows syncdb and
flush management commands to attempt to load it without causing
spurious warnings.

Thanks to Derega, ptone, dirigeant and d1ffuz0r for contributions
to the ticket.
 2013-05-19 11:31:27 +02:00
Senko Rasic
cc3b3ba93a Fixed #18990: Loaddata now complains if fixture doesn't exist 
The fixture named "initial_data" is exceptional though; if it
doesn't exist, the error is not raised. This allows syncdb and
flush management commands to attempt to load it without causing
an error if it doesn't exist.
 2013-05-19 10:56:09 +02:00
Andrea Crotti
5124ab7620 add comment to explain why it's necessary to do an explicit check for 
Python2 and how metaclasses are defined
 2013-05-19 10:36:04 +02:00
Marc Tamlyn
c70ca4879e Merge pull request #1116 from elektrrrus/ticket_20234_20236 
Ticket 20234 20236
 2013-05-19 01:32:41 -07:00
Emil Stenström
7d77e9786a Fixed #20246 -- Added non-breaking spaces between values an units 2013-05-18 23:01:48 +02:00
Tome Cvitan
caf56ad174 Fixed #20440 -- Ensured CharField's max_length/min_length are integers 2013-05-18 22:30:24 +02:00
Karol Sikora
3eba8c7f7f Fixed #20234 and #20236 -- SingleObjectMixin fixes 
Added object on SingleObjectMixin returned context,
some code clanup.
 2013-05-18 21:13:27 +02:00
Aymeric Augustin
0038296135 Fixed ff881aef on Python 3. 2013-05-18 20:48:47 +02:00
Andrew Godwin
38a8cf1cdc Fix state tests a little 2013-05-18 18:30:34 +02:00
Shai Berger
ff881aef53 Fixed #13958 -- problem reporting exception from \r-line-ended file 
Thanks petrvanblokland for reporting and saz for the patch
 2013-05-18 19:30:03 +03:00
Łukasz Langa
f763227c7d Fixes a Python 3.x regression introduced in a19e9d80 2013-05-18 18:06:31 +02:00
Florian Apolloner
dc8814bf7d Merge branch 'master' of github.com:django/django 2013-05-18 17:39:14 +02:00
Łukasz Langa
bd97f7d0cb Fixed #15201: Marked CACHE_MIDDLEWARE_ANONYMOUS_ONLY as deprecated 2013-05-18 17:38:32 +02:00
Florian Apolloner
acd0bb39df Fixed #14894 -- Ensure that activating a translation doesn't run into threading issues. 
Thanks to maxbublis for the report and sergeykolosov for the patch.
 2013-05-18 17:36:31 +02:00
Donald Stufft
398841d6d3 Merge branch 'allow-any-iterable-for-choices' 2013-05-18 11:31:16 -04:00
Donald Stufft
a19e9d80ff Fixed #20430 - Enable iterable of iterables for model choices 
Allows for any iterable, not just lists or tuples, to be used as
the inner item for a list of choices in a model.
 2013-05-18 11:14:05 -04:00
Aymeric Augustin
e73cb6391d Merge pull request #1122 from ambv/issue13285 
Fixed #13285: populate_xheaders breaks caching
 2013-05-18 08:05:48 -07:00
Łukasz Langa
64e11a68f1 Fixed #13285: populate_xheaders breaks caching 2013-05-18 17:03:43 +02:00
Aymeric Augustin
3634948c88 Moved IgnorePendingDeprecationWarningsMixin in django.test.utils. 
This mixin is useful whenever deprecating a large part of Django.
 2013-05-18 16:49:15 +02:00
Olivier Sels
63a9555d57 Fixed #19436 -- Don't log warnings in ensure_csrf_cookie. 2013-05-18 16:17:46 +02:00
Aymeric Augustin
7d050e8e9c Merge pull request #1113 from denibertovic/master 
Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
 2013-05-18 07:11:11 -07:00
Deni Bertovic
186ec21a3d Added stripping of whitespace for SlugField and URLField 2013-05-18 16:06:08 +02:00
Jacob Burch
89955cc35f Fixed #9595 -- Allow non-expiring cache timeouts. 
Also, streamline the use of 0 and None between cache backends.
 2013-05-18 15:39:42 +02:00
Łukasz Langa
92ebb29c53 Fixes #19919: get_language_from_request() disregards "en-us" and "en" languages 
when matching Accept-Language
 2013-05-18 14:37:04 +02:00
Florian Apolloner
16683f29ea Merge pull request #1084 from erikr/master 
Fixed #13546 -- Easier handling of localize field options in ModelForm
 2013-05-18 05:15:15 -07:00
Marc Tamlyn
ef73a8eefd Merge pull request #1083 from Markush2010/ticket20235 
Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
 2013-05-18 05:14:28 -07:00
Erik Romijn
756b81dbd1 Fixed #13546 -- Easier handling of localize field options in ModelForm 2013-05-18 14:13:00 +02:00
Matthew Somerville
1c921cfac3 Fixed #20235 -- Use self.object_list if object_list not present in get_context_data kwargs. 
This is so MultipleObjectMixin can be used in the same way as
SingleObjectMixin.
 2013-05-18 14:10:40 +02:00
Andrew Godwin
7d041b9394 Split up test and make the State classes a bit better. 2013-05-18 13:49:56 +02:00
Andrew Godwin
028bbd15ca Add a deconstruct() method to Fields. 
This allows the field's initial argument to be obtained so it can be
serialised to, and re-created from, a textual format.
 2013-05-18 13:48:57 +02:00
Senko Rasic
493aca453a Fixed #11160 - Ensure full_clean is called from non_form_errors 
Updated FormSet.non_form_errors() to ensure full_clean() has
been called before returning the errors.
 2013-05-18 13:44:27 +02:00
Aymeric Augustin
4bed64c417 Made test introduced in 566e284c pass on Python 3. 2013-05-18 13:34:52 +02:00
Senko Rasic
566e284c56 Added test for multipart, non form-data POST. 
Closes #9054. The bug itself is no longer present.
 2013-05-18 12:50:28 +02:00
Claude Paroz
8fd44b2551 Fixed #20356 -- Prevented crash when HTTP_REFERER contains non-ascii 
Thanks srusskih for the report and Aymeric Augustin for the review.
 2013-05-18 12:39:11 +02:00
Florian Apolloner
051cb1f4c6 Fixed #20411 -- Don't let invalid referers blow up CSRF same origin checks. 
Thanks to edevil for the report and saz for the patch.
 2013-05-18 12:32:47 +02:00
Andrew Godwin
331546f6ee More conversion to a ContextManager schema_editor 2013-05-18 11:48:46 +02:00
Baptiste Mispelon
9012a9e200 Fixed #20422 -- Applied makemessage's --ignore patterns to full path 
Fix makemessage's --ignore patterns being applied to the full path
instead of the file name. Thanks to nnseva for the report and the
original patch.
 2013-05-18 10:40:16 +02:00
Andrew Godwin
b31eea069c Merge branch 'master' into schema-alteration 2013-05-18 10:21:31 +02:00
Shai Berger
9ef4d177d1 Fixed #20388 -- Test failures under Oracle. 
Add "FROM DUAL" to SQL selecting constants in tests for Oracle.
 2013-05-16 15:00:16 +02:00
Daniel Lindsley
33793f7c3e Fixed #19934 - Use of Pillow is now preferred over PIL. 
This starts the deprecation period for PIL (support to end in 1.8).
 2013-05-14 19:32:04 -07:00
Florian Apolloner
e23a5f9a47 Fixed a regression in the test runner loading of runtests.py. 
Refs #17365, #17366, #18727.
 2013-05-11 15:47:40 +02:00
Carl Meyer
9012833af8 Fixed #17365, #17366, #18727 -- Switched to discovery test runner. 
Thanks to Preston Timmons for the bulk of the work on the patch, especially
updating Django's own test suite to comply with the requirements of the new
runner. Thanks also to Jannis Leidel and Mahdi Yusuf for earlier work on the
patch and the discovery runner.

Refs #11077, #17032, and #18670.
 2013-05-10 23:08:45 -04:00
Anssi Kääriäinen
c0d8932a6d Fixed #19939 -- generic relations + split_exclude regression 
Added a test, the issue was already fixed (likely by the patch
for #19385).
 2013-05-11 03:48:58 +03:00
Alex Gaynor
327e362ff3 Fixed an obvious typo. 2013-05-10 08:56:39 -07:00
Andrew Godwin
eb5e50215a Do some basic testing of the recorder 2013-05-10 16:18:19 +01:00
Andrew Godwin
8a1f017777 Add root_node and leaf_node functions to MigrationGraph 2013-05-10 16:09:57 +01:00
Andrew Godwin
9ce8354672 First phase of loading migrations from disk 2013-05-10 16:00:55 +01:00
Aymeric Augustin
a4dec43b52 Fixed two admin_views tests under Oracle. 
Thanks Anssi for the review.
 2013-05-10 16:56:42 +02:00
Andrew Godwin
cb4b0de49e Merge branch 'master' into schema-alteration 2013-05-10 12:55:30 +01:00
Andrew Godwin
f6801a234f Adding a dependency graph class and tests 2013-05-10 12:52:04 +01:00
Aymeric Augustin
9a3708cec8 Fixed a test that fails under Python 3. 2013-05-09 19:33:02 +02:00
Luke Plant
f026a519ae Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut 
This also updates all dependent functionality, including modelform_factory
 and modelformset_factory, and the generic views `ModelFormMixin`,
 `CreateView` and `UpdateView` which gain a new `fields` attribute.
 2013-05-09 16:44:36 +01:00
Luke Plant
1e37cb37ce Further removal of static admin validation that can fail erroneously 2013-05-09 16:44:36 +01:00
Andrew Godwin
75bf394d86 Rest of the _meta.app_cache stuff. Schema tests work now. 2013-05-09 15:59:26 +01:00
Andrew Godwin
104ad0504b Split out a BaseAppCache, make AppCache borg again, add _meta.app_cache 2013-05-09 15:16:43 +01:00
Alex Gaynor
6634cb7b53 Removed a test that didn't make sense; code could never be called the way the test was written. 2013-05-09 06:55:25 -07:00
Luke Plant
2f8f2ad1d7 Removed some failing tests missed in 1556b1c3b7 2013-05-09 01:45:34 +01:00
Luke Plant
1556b1c3b7 Removed fragile admin validation of fields on ModelForm 
Refs #19445
 2013-05-09 00:49:05 +01:00
Aymeric Augustin
832b4a5722 Marked a test as an expected failure on MySQL and Python 3.2. 
This test hits a bug in current ports of MySQLdb.
 2013-05-08 23:12:46 +02:00
Aymeric Augustin
7476d96f83 Marked tests of BinaryFields as expected failures on MySQL and Python 3. 
Current ports of MySQLdb are very buggy in this area.
 2013-05-08 15:48:39 +02:00
Tai Lee
99a6f0e77c Fixed #20354 -- makemessages no longer crashes with UnicodeDecodeError 
Handle the `UnicodeDecodeError` exception, send a warning to `stdout` with the
file name and location, and continue processing other files.
 2013-05-07 21:22:05 +02:00
Florian Apolloner
da85c8cf32 Fixed a regression introduced in 9f7a01ef2b. 2013-05-05 15:27:14 +02:00
Florian Apolloner
780fa48f5f Fixed test failures introduced in a5becad909. 2013-05-01 16:40:49 +02:00
Aymeric Augustin
3a4276ffc3 Tested that get_or_create raises IntegrityError. 
It used to raise "DatabaseError: no such savepoint" with the old
transaction management. Closes #15117.
 2013-04-28 17:15:41 +02:00
Aymeric Augustin
90fe9141de Fixed #18986 -- Improved error message for missing files 
in CachedStaticFilesStorage. Thanks zyegfryed for his work on the patch.
 2013-04-28 16:45:05 +02:00
Claude Paroz
4769db6b5f Fixed #20321 -- Added missing key name in MergeDict KeyError message 
Thanks mark.harviston et gmail.com for the report.
 2013-04-26 08:59:34 +02:00
Marti Raudsepp
172b50b722 Clearer explanation when exception has no message 
"No exception supplied" is misleading; actually there is an exception,
but there's no message string.
 2013-04-23 21:18:17 +03:00
Alex Gaynor
714161c864 Fix != operations on lazy objects. 2013-04-19 10:58:29 -07:00
Anton Baklanov
59d127e45f Fixed #20276 -- Implemented __bool__ for MergeDict 
MergeDict evaluates now to False if all contained dicts are empty.
Thanks til for the report and the initial patch.
 2013-04-19 10:08:16 +02:00
Andrew Godwin
6e21a59402 Fix schema editor interaction with new transactions 2013-04-19 09:01:45 +01:00
Andrew Godwin
7f3678dc4c Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/backends/mysql/base.py
	django/db/backends/oracle/base.py
	django/db/backends/oracle/creation.py
	django/db/backends/postgresql_psycopg2/base.py
	django/db/backends/sqlite3/base.py
	django/db/models/fields/related.py
 2013-04-18 17:16:39 +01:00
Carl Meyer
a98465c040 Refs #14567 -- Fixed failing test that wasn't being run. 2013-04-16 13:34:06 -06:00
Matthew Tretter
a506b6981b Fixed #18231 -- Made JavaScript i18n not pollute global JS namespace. 
Also, use Django templating for the dynamic generated JS code and use
more idiomatic coding techniques.

Thanks Matthew Tretter for the report and the patch.
 2013-04-14 17:45:01 -03:00
Claude Paroz
be9ae693c4 Fixed #17840 -- Generalized named placeholders in form error messages 
Also fixed plural messages for DecimalField.
 2013-04-13 18:55:50 +02:00
Baptiste Mispelon
9ac4dbd7b5 Fixed #4592: Made CheckboxSelectMultiple more like RadioSelect 
I refactored RadioSelect and CheckboxSelectMultiple to
make them inherit from a base class, allowing them to share
the behavior of being able to iterate over their subwidgets.

Thanks to Matt McClanahan for the initial patch and to
Claude Paroz for the review.
 2013-04-13 16:37:27 +02:00
Baptiste Mispelon
c4186c2fec Fixed #4117: Apply id attribute to the outer <ul> of RadioSelect 2013-04-13 12:23:25 +02:00
Claude Paroz
f56b703b27 Used a Python 3 compatible StringIO in test_utils 2013-04-13 11:38:13 +02:00
Baptiste Mispelon
844fbc85c1 Fixed #19874: Apply id attribute to the outer <ul> of CheckboxSelectMultiple 2013-04-13 11:09:47 +02:00
Claude Paroz
3f05c70be0 Updated a renamed test file 2013-04-13 11:09:47 +02:00
Preston Timmons
6d96831769 Fixed template_tests so discovery doesn't directly find tests that require setuptools. 2013-04-12 15:42:58 -06:00
Preston Timmons
56e777eba3 Modified view_tests for unittest2 discovery. 2013-04-12 15:42:07 -06:00
Preston Timmons
e8446be560 Modified validation to work with unittest2 discovery. 2013-04-12 15:33:22 -06:00
Preston Timmons
612ef3e5c9 Modified utils_tests for unittest2 discovery. 2013-04-12 15:31:58 -06:00
Preston Timmons
3810dc3070 Modified template_tests for unittest2 discovery. 2013-04-12 15:13:59 -06:00
Preston Timmons
44293c5c05 Modified model_fields for unittest2 discovery. 2013-04-12 15:11:12 -06:00
Preston Timmons
3ca3d2206c Modified generic_views for unittest2 discovery. 2013-04-12 15:10:04 -06:00
Preston Timmons
5e84abec14 Modified comment_tests for unittest2 discovery. 2013-04-12 15:07:24 -06:00
Preston Timmons
6f3e139739 Modified test_client_override to work with unittest2 discovery. 2013-04-12 15:05:34 -06:00
Preston Timmons
751b007c98 Modified test_utils to work with unittest2 discovery. 2013-04-12 15:00:48 -06:00
Preston Timmons
cdf520ee86 Modified forms_tests to work with unittest2 discovery. 2013-04-12 15:00:17 -06:00
Claude Paroz
b04fd579d5 Fixed #20237 (again) Allowed binary parameter to assertContains 2013-04-12 20:12:42 +02:00
Baptiste Mispelon
ab686022f8 Fixed #20211: Document backwards-incompatible change in BoundField.label_tag 
Also cleaned up label escaping and consolidated the test suite regarding
label_tag.
 2013-04-12 10:17:17 +02:00
Claude Paroz
fe01404bb9 Fixed #20237 -- Reenabled assertContains with binary parameter 
Thanks Baptiste Mispelon for the review.
 2013-04-11 10:38:24 +02:00
Baptiste Mispelon
e7b9c11c3f Fixed #20231 -- Don't use allow_lazy on smart_split 2013-04-10 13:05:29 +02:00
Claude Paroz
118faa0893 Made usage of assertTemplateUsed in admin_views tests 
Thanks Baptiste Mispelon for the suggestion.
 2013-04-10 10:16:15 +02:00
Baptiste Mispelon
f69396665c Fix admin_views tests after commit 3be368c73e. 2013-04-08 22:02:18 +02:00
Tobias McNulty
161c4da588 Fixed #14019 -- Initialize SQLInsertCompiler.return_id attribute. 2013-04-08 13:41:36 -06:00
Baptiste Mispelon
f9dc1379b8 Fix #15126: Better error message when passing invalid options to ModelForm.Meta. 2013-04-07 19:08:53 +02:00
Simon Charette
216580e034 Fixed #20207 -- Handle ManyToManyField with a unicode name correctly. 2013-04-05 15:09:53 -04:00
Baptiste Mispelon
c250f9c99b Fixed #20038 -- Better error message for host validation. 2013-04-03 14:27:20 -06:00
Preston Timmons
8ce46375ae Move last remaining tests out of models.py files; prep for test discovery. 2013-04-02 19:00:55 -06:00
Claude Paroz
edc782b7b5 Relaxed time frame check in test_strip_tags 2013-04-01 22:53:04 +02:00
Julien Phalip
2f81a0ca65 Fixed #20169 -- Ensured that the WSGI request's path is correctly based on the SCRIPT_NAME environment parameter or the FORCE_SCRIPT_NAME setting, regardless of whether or not those have a trailing slash. Thanks to bmispelon for the review. 2013-04-01 12:04:44 -07:00
Claude Paroz
8c41bd93c2 Fixed #16737 -- Support non-ascii column names in inspectdb 
Thanks moof at metamoof.net for the report.
 2013-04-01 19:59:57 +02:00
Claude Paroz
2817a29d90 Imported unittest from django.utils in util_tests 
Without this, the 'new' assertion methods are not present with
Python 2.6.
 2013-04-01 19:59:57 +02:00
Claude Paroz
dcf563071f Fixed #5014 -- Guessed max_digits and decimal_places for SQLite 
Decimal is treated as float on SQLite, hence inspectdb can only
guess max_digits and decimal_places arguments.
 2013-04-01 18:32:57 +02:00
Claude Paroz
51028f50b6 Fixed getting max_digits for MySQL decimal fields 
Refs #5014.
 2013-04-01 18:17:00 +02:00
Claude Paroz
a01361b5ae Added more tests for strip_tags utility 
Refs #19237.
 2013-04-01 16:48:47 +02:00
Claude Paroz
b474ffe63a Fixed #20172 -- Ensured urlize supports IPv4/IPv6 addresses 
Thanks Marc Aymerich for the report and the initial patch.
 2013-04-01 15:37:37 +02:00
Joe Friedl
2d0db67813 Fixed #20167 -- Preserve the traceback of ImportErrors in import_by_path. 
Thanks @carljm for the review.
 2013-03-31 23:00:06 -04:00
Claude Paroz
3ff3212713 Fixed #19220 -- Prevented decimals to be displayed in scientific notation 
Thanks nebstrebor for the report and antofik for the patch.
 2013-03-31 22:39:01 +02:00
Baptiste Mispelon
5080311998 Fixed #20130 -- Regression in {% cache %} template tag. 2013-03-30 12:13:08 +01:00
Christoph Sieghart
465b01f065 Fixed #19998 -- Fixed --ignorenonexistent support for XML based fixtures. 2013-03-30 11:59:50 +01:00
Baptiste Mispelon
a40746b1cb Fix #20158: invalid code in queryset_pickle test models. 2013-03-29 13:32:21 +01:00
Claude Paroz
86b1c31689 Fixed #19954 -- Fixed MySQL _last_executed decoding 
Queries can contain binary data undecodable with utf-8. In this
case, using the 'replace' errors mode when decoding seems like
an acceptable representation of the query.
Thanks Marcel Ryser for the report.
 2013-03-28 20:08:37 +01:00
Jacob Kaplan-Moss
4befef91f1 Correctly restore warning capture after logging tests. 
This is a fix to the wrong behavior that 15c3906eeb introduced.
 2013-03-27 17:01:11 -05:00
Jacob Kaplan-Moss
654d8e96ae Fixed logging-related test failure introduced by e79b857. 2013-03-27 12:05:31 -05:00
Jacob Kaplan-Moss
f6989e559c Merge remote-tracking branch 'ptone/18985-fix' 2013-03-27 10:34:28 -05:00
Claude Paroz
34a50e99e8 Added regression test for custom SQL containing percents 
Refs #3485.
 2013-03-26 23:19:32 +01:00
Anssi Kääriäinen
e17fa9e877 Fixed #20091 -- Oracle null promotion for empty strings 2013-03-26 14:19:54 +02:00
Adam Wentz
a4b8a4b632 Fixed #20121 -- Removed LogEntry.get_admin_url's hard-coded path. 
Updated LogEntry.get_admin_url to use 'reverse' instead
of a hard-coded path.
 2013-03-25 23:45:27 -04:00
Claude Paroz
066bf42675 Removed forced typecasting of help_text/label Field arguments 
In any case, setting those variables to non-ascii utf-8 bytestrings
is now considered a programming error.
 2013-03-25 21:38:21 +01:00
Preston Holmes
e79b857a07 Fixed #18985 -- ensure module level deprecations are displayed 
Also don't compete with -W CLI option.

Thanks to Aymeric Augustin for the catch, and Claude Paroz for the patch.
 2013-03-24 22:06:02 -07:00
Loic Bistuer
521765f63d Fixed #19541 -- Fixed BaseHandler to enable reversing URLs in response middlewares 
and streamed responses with respect to per-request urlconf.
 2013-03-25 03:19:19 +07:00
Anssi Kääriäinen
266de5f9ae Fixed 19385 -- Added ORM support for multicolumn joins 
This patch iproved two major parts in Django. First, the fields.related
was refactored. The main addition there was ForeignObject. Second, the
ORM now handles multicolumn joins in most cases, though there are still
cases that do not work correcly (split_exclude() for example).

In addition there were extesive changes to how GenericRelation works.
Before it was a fake m2m field, now it is a pure virtual fields and is
based on ForeignObject.

There is still much room for improvement. The related fields code is
still somewhat confusing, and how fields are represented in model._meta
should also be revisited.

This patch was written mostly by Jeremy Tillman with some final polish
by the committer.
 2013-03-24 18:08:01 +02:00
Aymeric Augustin
bc35b95274 Fixed test failures introduced in e16c48e001. 2013-03-24 15:27:50 +01:00
Aymeric Augustin
e16c48e001 Fixed #15124 -- Changed the default for BooleanField. 
Thanks to the many contributors who updated and improved the patch over
the life of this ticket.
 2013-03-24 13:47:01 +01:00
Claude Paroz
76aecfbc4b Fixed #9055 -- Standardized behaviour of parameter escaping in db cursors 
Previously, depending on the database backend or the cursor type,
you'd need to double the percent signs in the query before passing
it to cursor.execute. Now cursor.execute consistently need percent
doubling whenever params argument is not None (placeholder substitution
will happen).
Thanks Thomas Güttler for the report and Walter Doekes for his work
on the patch.
 2013-03-23 17:11:10 +01:00
Claude Paroz
164528acc8 Fixed #20108 -- Fixed filepath_to_uri decoding error 
This was a regression due to unicode_literals usage. Thanks Ivan
Virabyan for the report and the initial patch.
 2013-03-22 17:55:12 +01:00
Marc Tamlyn
829dc3c5a6 Fixed #20094 - Be more careful when checking for Iterator 
Python 2.6 has some different behaviour when checking
isinstance(foo, collections.Iterator).
 2013-03-22 17:31:29 +01:00
Andrew Gorcester
f9ab543720 Fixed #20084 -- Provided option to validate formset max_num on server. 
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.

This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.

Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.

Thanks to Preston for discussion of the design choices.
 2013-03-21 01:27:24 -07:00
Carny Cheng
aaec4f2bd8 Fixed #18839 - Field.__init__() now calls super(). 2013-03-20 16:20:57 -07:00
Matthew Wood
a7960bcb35 Fixed #18972 -- Refactored bundled wsgi server's chunking algorithm. 
Thanks to amosonn at yahoo.com for the report, @doda for the initial patch and
@datagrok for the revamped logic and test case.
 2013-03-20 18:46:26 -04:00
Anssi Kääriäinen
80e68ee2ff Added tests for already fixed #20101 
The ticket dealt with a case where one query had .exclude() that
produced a subquery, the other query had a join to the same model that
was subqueried in the first query. This was already fixed in master, so
only test added.
 2013-03-21 00:43:26 +02:00
Claude Paroz
23490a2394 Revert "Fixed 19895 -- Made second iteration over invalid queryset raise an exception too" 
This reverts commit 2cd0edaa47.
This commit was the cause of a memory leak. See ticket for more details.
Thanks Anssi Kääriäinen for identifying the source of the bug.
 2013-03-20 10:41:53 +01:00
Paul Collins
9a85ad89c2 Fixed #16319 -- added SuccessMessageMixin to contrib.messages 
Thanks martinogden for the initial patch and d1ffuz0r for tests.
 2013-03-19 21:02:55 -07:00
Simon Charette
5938e7013e Fixed a python 3.2 syntax error and python 3 warning introduced by 054ce2aa02. 2013-03-19 22:16:48 -04:00
konarkmodi
483e1b807e Refs #18586 -- Split out long custom_columns lookup test into multiple tests. 2013-03-19 15:58:54 -07:00
Juan Catalano
054ce2aa02 Fixed #20088 -- Changed get_admin_log not to depend on User id field 
Before this change, the get_admin_log method would expect User model's
FK to be named `id`. When changing that FK name, admin/index.html
rendering would fail.

This includes:
 * Changed the use of id for the use of pk property.
 * Added a regression test that fails without the patch.

This commit refs #20088.
 2013-03-19 19:30:43 -03:00
Deric Crago
9d6ecc6bc6 Fixed #19327 -- Added handling of double login attempts in admin. 
Thanks to Krzysztof Jurewicz for initial patch and
adupin for tests.
 2013-03-18 17:11:07 -07:00
Aymeric Augustin
31b5275235 Fixed #13260 -- Quoted arguments interpolated in URLs in reverse. 2013-03-18 23:58:22 +01:00
Aymeric Augustin
9dc5702932 Fixed #19456 -- Avoid infinite recursion when tracing LazyObject.__init__. 
Thanks blaze33 for the patch.
 2013-03-18 11:22:43 +01:00
Aymeric Augustin
0efafa4c54 Fixed #18447 -- Made LazyObject unwrap on dict access. 
Thanks Roman Gladkov and Zbigniew Siciarz.
 2013-03-18 11:10:19 +01:00
Aymeric Augustin
20a91cce04 Fixed #17037 -- Added a --all option to diffsettings. 2013-03-18 00:03:58 +01:00
Anssi Kääriäinen
46f4b19920 Removed debug code 2013-03-17 11:31:15 +02:00
Baptiste Mispelon
d5683bd06b Fix #20058: Make compilemessages use stdout instead of stderr. 2013-03-16 19:48:40 +01:00
Anssi Kääriäinen
2a2708e1b2 Fixed #17502 -- Made joining in inheritance cases consistent 
The original problem was that when filtering two levels up in
inheritance chain, Django optimized the join generation so that the
middle model was skipped. But then Django generated joins from top
to middle to bottom for SELECT clause, and thus there was one extra
join (top->middle->bottom + top -> bottom).

This case is fixed in master as the filtering optimization is gone.
This has the side effect that in some cases there is still extra join
if the SELECT clause doesn't contain anything from middle or bottom.
 2013-03-15 11:06:26 +02:00
Aymeric Augustin
3f2befc931 Deprecated django.views.defaults.shortcut. 2013-03-14 20:30:23 +01:00
Claude Paroz
2f121dfe63 Fixed #17051 -- Removed some 'invalid' field error messages 
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
 2013-03-14 17:03:43 +01:00
Claude Paroz
34d098665d Add a specific error message for URLValidator 2013-03-14 15:26:30 +01:00
Claude Paroz
9883551d50 Fixed #20039 -- Fixed has_changed form detection for required TypedChoiceFields 
Thanks Florian Apolloner for the report and the review.
Also fixes #19643.
 2013-03-14 14:49:07 +01:00
Anssi Kääriäinen
6b4834952d Fixed #16649 -- Refactored save_base logic 
Model.save() will use UPDATE - if not updated - INSERT instead of
SELECT - if found UPDATE else INSERT. This should save a query when
updating, but will cost a little when inserting model with PK set.

Also fixed #17341 -- made sure .save() commits transactions only after
the whole model has been saved. This wasn't the case in model
inheritance situations.

The save_base implementation was refactored into multiple methods.
A typical chain for inherited save is:
save_base()
    _save_parents(self)
        for each parent:
            _save_parents(parent)
            _save_table(parent)
    _save_table(self)
 2013-03-14 11:01:47 +02:00
Florian Apolloner
22b7870e40 Began implementing a shared set of test models to speed up tests. 2013-03-13 23:25:26 +01:00
Jacob Kaplan-Moss
1059da8de6 Merge pull request #900 from bmispelon/ticket-20022 
Fix #20022: Correctly handle prefixes with url-unsafe characters in reverse()
 2013-03-13 22:39:25 +01:00
Baptiste Mispelon
4fa7f3cdd9 Fix #20022: Correctly handle prefixes with url-unsafe characters in reverse(). 2013-03-13 18:19:29 +01:00
Aymeric Augustin
83a416f5e7 Made atomic usable when autocommit is off. 
Thanks Anssi for haggling until I implemented this.

This change alleviates the need for atomic_if_autocommit. When
autocommit is disabled for a database, atomic will simply create and
release savepoints, and not commit anything. This honors the contract of
not doing any transaction management.

This change also makes the hack to allow using atomic within the legacy
transaction management redundant.

None of the above will work with SQLite, because of a flaw in the design
of the sqlite3 library. This is a known limitation that cannot be lifted
without unacceptable side effects eg. triggering arbitrary commits.
 2013-03-13 15:17:40 +01:00
Anssi Kääriäinen
bd0cba58aa Fixed failing aggregation tests on MySQL 2013-03-13 12:44:24 +02:00
Anssi Kääriäinen
d3f00bd570 Refactored qs.add_q() and utils/tree.py 
The sql/query.py add_q method did a lot of where/having tree hacking to
get complex queries to work correctly. The logic was refactored so that
it should be simpler to understand. The new logic should also produce
leaner WHERE conditions.

The changes cascade somewhat, as some other parts of Django (like
add_filter() and WhereNode) expect boolean trees in certain format or
they fail to work. So to fix the add_q() one must fix utils/tree.py,
some things in add_filter(), WhereNode and so on.

This commit also fixed add_filter to see negate clauses up the path.
A query like .exclude(Q(reversefk__in=a_list)) didn't work similarly to
.filter(~Q(reversefk__in=a_list)). The reason for this is that only
the immediate parent negate clauses were seen by add_filter, and thus a
tree like AND: (NOT AND: (AND: condition)) will not be handled
correctly, as there is one intermediary AND node in the tree. The
example tree is generated by .exclude(~Q(reversefk__in=a_list)).

Still, aggregation lost connectors in OR cases, and F() objects and
aggregates in same filter clause caused GROUP BY problems on some
databases.

Fixed #17600, fixed #13198, fixed #17025, fixed #17000, fixed #11293.
 2013-03-13 10:44:49 +02:00
Anssi Kääriäinen
d744c550d5 Fixed #19964 -- Removed relabel_aliases from some structs 
Before there was need to have both .relabel_aliases() and .clone() for
many structs. Now there is only relabeled_clone() for those structs
where alias is the only mutable attribute.
 2013-03-12 21:33:47 +02:00
Aymeric Augustin
885d98d24a Fixed #20028 -- Made atomic usable on callable instances. 
Thanks Anssi for the report.
 2013-03-12 10:52:16 +01:00
Aymeric Augustin
f8a634afa2 Fixed tests that relied on MANAGERS not being empty. 
Regression in d0561242.
 2013-03-11 23:30:02 +01:00
Jacob Kaplan-Moss
d056124269 Remove a special case for comment tests from runtests.py. 2013-03-11 15:38:53 -05:00
Aymeric Augustin
b746f8a9e3 Adjusted query counts to account for new savepoints. 2013-03-11 21:07:19 +01:00
Aymeric Augustin
55a9be8ecf Ran a test that closes the database connection outside of a transaction. 2013-03-11 19:42:59 +01:00
Claude Paroz
9b74a8391d Removed forced settings in runtests 
Tests that require USE_I18N, LOGIN_URL or certain MIDDLEWARE_CLASSES
should be decorated appropriately.
 2013-03-11 17:46:56 +01:00
Aymeric Augustin
e654180ce2 Improved the API of set_autocommit. 2013-03-11 15:10:58 +01:00
Aymeric Augustin
86fd920f67 Removed a test that no longer makes any sense. 
Since unmanaged == autocommit, there's nothing to commit or roll back.
 2013-03-11 15:05:04 +01:00
Aymeric Augustin
0cee3c0e43 Updated a test that doesn't make sense with autocommit. 2013-03-11 15:05:04 +01:00
Aymeric Augustin
107d9b1d97 Added an option to disable the creation of savepoints in atomic. 2013-03-11 15:05:04 +01:00
Aymeric Augustin
ac37ed21b3 Deprecated TransactionMiddleware and TRANSACTIONS_MANAGED. 
Replaced them with per-database options, for proper multi-db support.

Also toned down the recommendation to tie transactions to HTTP requests.
Thanks Jeremy for sharing his experience.
 2013-03-11 15:04:05 +01:00
Aymeric Augustin
7c46c8d5f2 Added some assertions to enforce the atomicity of atomic. 2013-03-11 14:48:55 +01:00
Aymeric Augustin
d7bc4fbc94 Implemented an 'atomic' decorator and context manager. 
Currently it only works in autocommit mode.

Based on @xact by Christophe Pettus.
 2013-03-11 14:48:55 +01:00
Aymeric Augustin
4b31a6a9e6 Added support for savepoints in SQLite. 
Technically speaking they aren't usable yet.
 2013-03-11 14:48:55 +01:00
Aymeric Augustin
3bdc7a6a70 Deprecated transaction.is_managed(). 
It's synchronized with the autocommit flag.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
ba5138b1c0 Deprecated transaction.commit/rollback_unless_managed. 
Since "unless managed" now means "if database-level autocommit",
committing or rolling back doesn't have any effect.

Restored transactional integrity in a few places that relied on
automatically-started transactions with a transitory API.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
af9e9386eb Enabled autocommit for PostgreSQL. 
For users who didn't activate autocommit in their database options, this
is backwards-incompatible in "non-managed" aka "auto" transaction state.
This state now uses database-level autocommit instead of ORM-level
autocommit.

Also removed the uses_autocommit feature which lost its purpose.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
8717b0668c Separated autocommit and isolation level handling for PostgreSQL. 
Autocommit cannot be manipulated independently from an open connection.
This commit introduces a minor change in behavior: entering transaction
management forces opening a databasse connection. This shouldn't be
backwards incompatible in any practical use case.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
7aacde84f2 Made transaction.managed a no-op and deprecated it. 
enter_transaction_management() was nearly always followed by managed().

In three places it wasn't, but they will all be refactored eventually.
The "forced" keyword argument avoids introducing behavior changes until
then.

This is mostly backwards-compatible, except, of course, for managed
itself. There's a minor difference in _enter_transaction_management:
the top self.transaction_state now contains the new 'managed' state
rather than the previous one. Django doesn't access
self.transaction_state in _enter_transaction_management.
 2013-03-11 14:48:53 +01:00
Aymeric Augustin
ce76fbfc5a Fixed #20019 -- Ensured HttpRequest.resolver_match always exists. 
Obviously it isn't set until the URL is resolved.
 2013-03-10 23:28:19 +01:00
Ramiro Morales
7fca4416c7 Made (make|compile)messages check for availability of gettext commands. 
Refs #19584.
 2013-03-10 17:31:11 -03:00
Claude Paroz
6a91b63842 Fixed #19923 -- Display tracebacks for non-CommandError exceptions 
By default, show tracebacks for management command errors when the
exception is not a CommandError.
Thanks Jacob Radford for the report.
 2013-03-09 12:38:45 +01:00
Claude Paroz
cbfb8ed53b Fixed a regression in forms changed_data 
Thanks Loic Bistuer for spotting the regression and the initial
patch. Refs #16612.
 2013-03-08 18:19:24 +01:00
Loic Bistuer
6983a1a540 Fixed #15363 -- Renamed and normalized to get_queryset the methods that return a QuerySet. 2013-03-08 10:11:45 -05:00
Aymeric Augustin
477d737e1e Merge pull request #850 from bmispelon/ticket-19916 
Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments
 2013-03-07 12:12:29 -08:00
Alex Gaynor
bbbd698c7a Added a ManyToManyField(db_constraint=False) option, this allows not creating constraints on the intermediary models. 2013-03-07 11:24:51 -08:00
Baptiste Mispelon
81804ae474 Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments. 2013-03-07 19:30:38 +01:00
Claude Paroz
4cccb85e29 Fixed #19997 -- Added custom EMPTY_VALUES to form fields 
Thanks Loic Bistuer for the report and the patch.
 2013-03-07 15:22:03 +01:00
Igor Támara
e2ee02c5bd Fixed #19951 -- Admin: Invalid model PK values shouldn't cause 500 status. 
Avoid ValueError in admin when passing a string as PK for an inherited
model with an integer PK field.

Thanks ikks for the patch. See also #11191.
 2013-03-06 21:38:44 -03:00
Ramiro Morales
c31a9793c6 Merge pull request #882 from loic/testfix 
Fixed minor warnings in tests.
 2013-03-06 16:22:06 -08:00
Preston Holmes
876fc39128 PEP8 cleanup of functional.py 2013-03-06 16:14:46 -08:00
Preston Holmes
0ea5bf88dd Fixed #19543 -- implemented SimpleLazyObject.__repr__ 
Thanks to Florian Hahn for the patch
 2013-03-06 16:13:12 -08:00
Aymeric Augustin
b3aa853ec5 Used more precise test assertions. 2013-03-06 15:33:35 +01:00
Loic Bistuer
9ba0e4e4ee Fixed minor warnings in tests. 2013-03-06 01:13:36 +07:00
Juan Pedro Fisanotti
d9330d5be2 Fixed #6585 -- Admin relationship widgets: Respect ordering defined by target model's ModelAdmin. 
Thanks Gary Wilson for the report and Juan Pedro Fisanotti, Carlos
Matías de la Torre for the fix.
 2013-03-04 18:08:53 -03:00
Javier Mansilla
3ea0c7d35a Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs. 
Thanks rafadev for the report and Javier Mansilla for the fix.
 2013-03-04 13:30:59 -03:00
Ramiro Morales
60dd4eabe7 Removed mentions of modeltests. 2013-03-03 18:44:06 -03:00
matiasb
804366327d Fixed #19915 - Made blocktrans tag honor TEMPLATE_STRING_IF_INVALID. 
Thanks Natalia Bidart for the report and Matías Bordese for the fix.
 2013-03-03 16:10:11 -03:00
Claude Paroz
384c180e41 Fixed #19917 -- Added microseconds in default TIME_INPUT_FORMATS 
Thanks minddust for the report.
 2013-03-02 18:11:10 +01:00
Aymeric Augustin
e0449316eb Fixed #18130 -- Made the isolation level configurable on PostgreSQL. 
Thanks limscoder for the report and niwi for the draft patch.
 2013-03-02 15:05:49 +01:00
Claude Paroz
c5a25c2771 Add introspection support for BinaryField 2013-03-02 10:29:03 +01:00
Claude Paroz
d680a3f447 Added support for serializing BinaryField 2013-03-02 10:29:02 +01:00
Claude Paroz
8ee1eddb7e Add a BinaryField model field 
Thanks Michael Jung, Charl Botha and Florian Apolloner for review
and help on the patch.
 2013-03-02 10:29:02 +01:00
Simon Charette
0f306cad84 Import CaptureQueriesContext from its original module. 2013-03-02 03:45:42 -05:00
Simon Charette
fb3d85bd14 Fixed #10399 -- Tested that o2o field updates are not constrained by an inner query. 2013-03-02 03:24:08 -05:00
Simon Charette
952ba5237e Added a context manager to capture queries while testing. 
Also made some import cleanups while I was there.

Refs #10399.
 2013-03-02 02:41:14 -05:00
Claude Paroz
3318595c0b Fixed #18898 -- Added tests with a fix for ModelMultipleChoiceField 2013-03-01 09:35:18 +01:00
Claude Paroz
892bc91cb0 Fixed #16612 -- Improved has_changed detection for localized field values 
Thanks Simon Charette for the review.
 2013-03-01 09:35:04 +01:00
Aymeric Augustin
cf30469164 Fixed tests broken in 2ee21d9. 2013-02-28 17:08:16 +01:00
Aymeric Augustin
2ee21d9f0d Implemented persistent database connections. 
Thanks Anssi Kääriäinen and Karen Tracey for their inputs.
 2013-02-28 15:28:13 +01:00
Aymeric Augustin
aa089b106b Fixed #5241 -- Kept active transalation in LocaleMiddleware.process_response. 2013-02-28 14:21:48 +01:00
Anssi Kääriäinen
06de130dae Fixed #12823 -- Was already fixed in master, tests added 
Also added a little improvement to sql/query.py to get rid of
non-necessary IS NOT NULL check.
 2013-02-28 15:05:48 +02:00
Łukasz Langa
af3321a1e8 use the real path to fix OS X /var/folders vs. /private/var/folders mismatch 2013-02-27 23:33:47 +01:00
Anssi Kääriäinen
21189cb80b Made dateformat tests reactivate original language 2013-02-27 23:48:17 +02:00
Aymeric Augustin
7aaa8a7779 Fixed a test that relied on database exceptions not being wrapped. 2013-02-27 21:12:48 +01:00
Aymeric Augustin
b2c697b029 Fixed a PendingDeprecationWarning in template_tests. 2013-02-27 21:09:27 +01:00
Anssi Kääriäinen
50328f0a61 Fixed #19861 -- Transaction ._dirty flag improvement 
There were a couple of errors in ._dirty flag handling:
  * It started as None, but was never reset to None.
  * The _dirty flag was sometimes used to indicate if the connection
    was inside transaction management, but this was not done
    consistently. This also meant the flag had three separate values.
  * The None value had a special meaning, causing for example inability
    to commit() on new connection unless enter/leave tx management was
    done.
  * The _dirty was tracking "connection in transaction" state, but only
    in managed transactions.
  * Some tests never reset the transaction state of the used connection.
  * And some additional less important changes.

This commit has some potential for regressions, but as the above list
shows, the current situation isn't perfect either.
 2013-02-27 17:54:27 +02:00
Łukasz Langa
40b9f4fb8b [py3] Always fed hashlib with bytes. 2013-02-27 10:02:07 +01:00
Ramiro Morales
a28e2e7c4d Removed a .mo file incorrectly put under Git control. 2013-02-26 22:45:08 -03:00
Ramiro Morales
f0bd553922 Simplified compilemessages tests a bit. 2013-02-26 22:30:49 -03:00
Ramiro Morales
dfa9324966 Don't use os.system() in compilemessages. 
Fixes #19584.

This implies stop storing file path command line arguments in envvars as
a security measure to start relying on with Popen's shell=False instead,
and addition of an 'utils' module.

Thanks kmichel_wgs for the report.
 2013-02-26 21:31:53 -03:00
Claude Paroz
58a2fc820e Fixed i18n test to match changed translation 
Forward port of ab6ff2e0ac from stable/1.5
 2013-02-26 21:51:06 +01:00
Florian Apolloner
33234aa8f7 Fixed discovery of the Django installation during tests. 
If Django was symlinked into site-packages the previous approach to discover
the tests subdirectory would fail. The revised version now always points to
the location of the source and not the import path.
 2013-02-26 21:04:32 +01:00
Florian Apolloner
0fe11fca40 Changed test_runner tests to use full python path for settings files. 2013-02-26 16:02:24 +01:00
Florian Apolloner
1535fcfdba fixed admin_scripts tests on python 3.3 2013-02-26 15:38:11 +01:00
Florian Apolloner
0dc7ff6b7a Ensured that we have an absolute path to RUNTESTS_DIR. 
This is needed to make 'python runtests.py' work, otherwise only
'python ./runtests.py' would work.
 2013-02-26 15:20:37 +01:00
Florian Apolloner
4d9f39f307 Renamed a template to be found by the loaders. 2013-02-26 14:36:58 +01:00
Florian Apolloner
33836cf88d Renamed some tests and removed references to modeltests/regressiontests. 2013-02-26 14:36:57 +01:00
Florian Apolloner
737a5d71f0 Adjusted coveragerc 2013-02-26 14:36:57 +01:00
Florian Apolloner
fc074db29c Adjusted runtests to the new layout. 2013-02-26 14:36:57 +01:00
Florian Apolloner
89f40e3624 Merged regressiontests and modeltests into the test root. 2013-02-26 14:36:57 +01:00
Florian Apolloner
b3d2ccb5bf Removed __init__.py files. 2013-02-26 14:36:57 +01:00
Florian Apolloner
41d7a9a907 Moved test_templates to templates to prevent issues with regressiontests/templates later on. 2013-02-26 14:36:57 +01:00
Aymeric Augustin
8dd8400f7e Updated an inaccurate comment. 
Tests can run nearly as fast under PostgreSQL and MySQL as under SQLite
with a bit of configuration and the speedup is always a good thing.
 2013-02-26 10:00:14 +01:00
Carl Meyer
6a8f95d812 Fixed a caching test on Python 3. 2013-02-25 18:12:55 -07:00
Łukasz Langa
6a057e1595 Fixed #18191 -- Don't consider Accept-Language redundantly in cache key. 
Thanks to choongmin for the original patch.
 2013-02-25 16:10:57 -07:00
Aymeric Augustin
e76147a83a Fixed #19634 -- Added proper __hash__ methods. 
Classes overriding __eq__ need a __hash__ such that equal objects have
the same hash.

Thanks akaariai for the report and regebro for the patch.
 2013-02-25 23:05:20 +01:00
Carl Meyer
509798ae06 Use built-in fixture support rather than calling loaddata in setUp(). 2013-02-25 12:13:10 -07:00
Aymeric Augustin
86b96038f2 Merge pull request #847 from fhahn/ticket_18176 
Fixed #18176 -- Added test for year lookups with year < 1000
 2013-02-25 09:26:56 -08:00
Carl Meyer
906dc8522a Fixed #19854 -- Turn Django's own Selenium tests off by default. 2013-02-25 10:14:42 -07:00
Florian Hahn
f28c301a47 Fixed #18176 -- Added test for year lookups with year < 1000 
Thanks Tomas Ehrlich for the initial test
 2013-02-25 17:13:27 +01:00
Claude Paroz
6d52bcbb7c Fixed #19903 -- Fixed unbalanced setUp/tearDown calls in LiveServerAddress test 2013-02-25 08:58:11 +01:00
Aymeric Augustin
7b49da1c38 Changed testing strategy used in 6b03179e. 
Avoid polluting the app cache as it causes unrelated test failures.

Refs #19688.
 2013-02-25 00:09:13 +01:00
Julien Phalip
ae2a8bb456 Fixed a test that was failing in Python 3. 
The issue was that as of Python 3, the generators' `next()`
method becomes `__next()`. Thanks Alex Gaynor for noticing that.
Refs #19890.
 2013-02-24 13:47:14 -08:00
Julien Phalip
a8449d4362 Merge pull request #824 from ambv/languagecode 2013-02-24 12:56:14 -08:00
Simon Charette
6b03179e12 Fixed #19688 -- Allow model subclassing with a custom metaclass using six.with_metaclass 2013-02-24 17:32:34 +01:00
Christopher Medrela
636c45fc58 Fixed #19890 -- ifchanged templatetag rendered its content twice 
The content of ifchanged template tag was rendered twice: first time, to
compare it with the previous value and the second time, to return the
rendered output.
 2013-02-24 16:49:28 +01:00
Diederik van der Boor
8503120c10 Fixed #15849 -- Made IfChanged node thread safe. 
Previously, the ifchanged node stored state on `self._last_seen`,
thereby giving undesired results when the node is reused by another
thread at the same time (e.g. globally caching a Template object).

Thanks to akaihola for the report and Diederik van der Boor and
Bas Peschier for the patch.
 2013-02-24 16:06:55 +01:00
Zbigniew Siciarz
0a8402eb05 Test case and docs for custom context data in feeds 
Thanks Paul Winkler for the initial patch. (Ref #18112).
 2013-02-24 08:33:20 -06:00
Florian Apolloner
4506ae0497 Merge pull request #717 from slurms/ticket_19746 
Fixed #19746 -- Allow deserialization of pk-less data
 2013-02-24 06:31:14 -08:00
Łukasz Langa
8c8f94fe9d Fixes #19763 - LocaleMiddleware should check for supported languages in settings.LANGUAGE_CODE 2013-02-24 14:43:45 +01:00
Tomek Paczkowski
99edbe0e27 Fixed #19253 -- Extracted template cache key building logic 
Introduced a public function
django.core.cache.utils.make_template_fragment_key
Thanks @chrismedrela for fruitful cooperation.
 2013-02-24 14:32:45 +01:00
Aymeric Augustin
7106a1e594 Merge pull request #819 from erikr/master 
Fixed #16302 -- Ensured contrib.comments is IPv6 capable.
 2013-02-24 05:02:00 -08:00
Erik Romijn
ade992c61e Fixed #16302 -- Ensure contrib.comments is IPv6 capable 
Changed the ip_address field for Comment to GenericIPAddressField. Added
instructions to the release notes on how to update the schema of existing
databases.
 2013-02-24 13:58:38 +01:00
Bas Peschier
5a9b2bce24 Fixed #19810 -- MemcachedCache now uses pickle.HIGHEST_PROTOCOL 2013-02-24 13:56:15 +01:00
Wiktor Kolodziej
f07a5f0a21 Fixed #11295: If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call 
Original patch rewritten, added tests and get_filters_params method for ChangeList class.
Thanks Alex for the report.
 2013-02-24 13:23:23 +01:00
Florian Apolloner
e4ee3d8fca Fixed a few ResourceWarnings. 2013-02-24 13:11:19 +01:00
Honza Král
e4e1287590 Merge pull request #817 from rybaktomasz/ticket_5568 
Fixes #5568 -- DROP INDEX subcommand
 2013-02-24 04:02:26 -08:00
Honza Kral
cbb9f629b8 Revert "fixes #19263" - Fails if not SQLite 
This reverts commit 2b76f19f2b.
 2013-02-24 12:38:32 +01:00
Tomasz Rybak
d7429defe6 Add sqldropindexes to manage 
Change patch from https://code.djangoproject.com/ticket/5568
to work on modern Django.
Add special case for MySQL which has different syntax for DROP INDEX.
Add unit tests for the new functionality.
 2013-02-24 12:38:28 +01:00
Honza Kral
5a6a4249f3 Removing unneeded tearDown code. 2013-02-24 12:31:00 +01:00
George Song
44164c5c30 Fixed #19896 -- Committed after clearing cache in the database. 2013-02-24 12:15:02 +01:00
Florian Apolloner
f56ca3f0e6 Fixed the usage of the deprecated assertEquals. 2013-02-24 11:15:17 +01:00
Aymeric Augustin
c10ed58746 Caught warnings in the templates tests. Refs #17906. 
This was missing from f49e9a517f.
 2013-02-24 10:28:05 +01:00
Honza Král
fc38d6a92b Merge pull request #813 from HiddenData/ticket-19263 
fixes #19263 - EmptyResultSet in subquery causes incorrect SQL
 2013-02-23 15:05:24 -08:00
Marcin Biernat
2b76f19f2b fixes #19263 2013-02-23 23:53:46 +01:00
Honza Král
692902b227 Merge pull request #778 from viciu/19609 
Fixed #19609: admin Inlines doesn't display help_text for readonly fields
 2013-02-23 14:34:57 -08:00
Honza Kral
ef1e6ef1eb Merge branch 'ticket19872' of https://github.com/oinopion/django 2013-02-23 23:32:09 +01:00
Honza Kral
2b48fcc607 Fixed #18491 -- deleting a proxy doesn't show warning about cascade deletes 2013-02-23 23:20:34 +01:00
Tomek Paczkowski
b88abd6840 Fixed #19872 
Made cached_property to behave as property when accessed via class.
 2013-02-23 23:20:00 +01:00
Aleksandra Sendecka
32a7ab2148 Fixed #19526 
CSS specifications governs that syntax is case insensitive.
This modifies CachedFilesMixin to support that.
 2013-02-23 23:05:22 +01:00
Klaas van Schelven
1c11ee6345 Fixed #18829 -- Fixed ModelChoiceIterator length 
Thanks facundo.olano at gmail.com for the report and thikonom for
the initial patch.
 2013-02-23 22:27:07 +01:00
Alex Gaynor
150e202172 Some style fixes for stuff that was clearly brough tover from doctests. 2013-02-23 13:04:08 -08:00
Honza Král
10026c2ad0 Merge pull request #804 from oinopion/ticket18162 
Fixes #18162 --  Specifying choices to Field overrides any form_class argument
 2013-02-23 12:45:39 -08:00
Grzegorz Nosek
2cd0edaa47 Fixed 19895 -- Made second iteration over invalid queryset raise an exception too 
When iteration over a queryset raised an exception, the result cache
remained initialized with an empty list, so subsequent iterations returned
an empty list instead of raising an exception
 2013-02-23 14:35:27 -06:00
Łukasz Langa
539900f117 Fixes #17866: Vary: Accept-Language header when language prefix used 2013-02-23 19:41:33 +01:00
Honza Kral
bfd4a71d41 One last final fix for 0ad76843. Tested on py3 and py2 2013-02-23 19:27:37 +01:00
Honza Král
0a341ab40d Merge pull request #791 from khalas/ticket_19811 
Changed %r to %s in get_language_info error message
 2013-02-23 10:16:23 -08:00
Tomek Paczkowski
b6f4a92ff4 Proposed fix for #18162. 2013-02-23 19:01:38 +01:00
Konrad Hałas
48dc0cbf2a Changed %r to %s in get_language_info error message. 2013-02-23 18:54:54 +01:00
Florian Apolloner
f368c25f10 Fixed errors introduced in 664855b74e 2013-02-23 18:47:36 +01:00
Florian Apolloner
5ae0c933a8 Fixed errors introduced in 21f333bcef. Refs #17751 2013-02-23 18:43:34 +01:00
Claude Paroz
cc53d9b30b Fixed #15877 -- Improved exception when ModelForm has no model class 
Thanks theaspect at gmail.com for the report and volrath for the
patch.
 2013-02-23 18:32:29 +01:00
Wiktor Kolodziej
67dd54dc84 Fixed #19609: admin Inlines doesn't display help_text for readonly fields 
Refactoring: field was renamed to field_name, since flatten_fieldsets returns field name, not field.

Original patch from Marc Aymerich Gubern
 2013-02-23 18:24:32 +01:00
Honza Král
a05ab448f7 Merge pull request #781 from zsiciarz/ticket_19854 
Fixed #19854 -- Added test runner option to skip Selenium tests
 2013-02-23 08:55:34 -08:00
Zbigniew Siciarz
1cd2f51eb4 Added test runner option to skip Selenium tests (#19854). 2013-02-23 17:45:26 +01:00
Claude Paroz
335a060fa6 Minor cleanups in templates test imports 2013-02-23 17:45:05 +01:00
Lennart Regebro
687d2e967d Fixed #19827 -- Kept stacktrace in defaulttags exception reraising 
Thanks Kronuz for the report and the initial patch.
 2013-02-23 17:43:17 +01:00
Honza Král
0ad76843b5 Merge pull request #777 from khalas/ticket_19811 
Fixed #19811 - Added language code fallback in get_language_info
 2013-02-23 08:30:27 -08:00
Honza Král
129d2e8f85 Merge pull request #775 from HiddenData/ticket-18899 
Fixed #18899 -- FileSystemStorage.save should support any file-like objects
 2013-02-23 08:04:41 -08:00
Konrad Hałas
6bd6a56896 Fixed #19811 - Added language code fallback in get_language_info. 2013-02-23 17:02:07 +01:00
Aymeric Augustin
5278776a88 Merge pull request #751 from bmispelon/ticket-6271 2013-02-23 07:47:58 -08:00
Marcin Biernat
664855b74e #18899 FileSystemStorage.save should support any file-like objects 2013-02-23 16:40:50 +01:00
Vladimir A Filonov
f49e9a517f Fixed #17906 - Autoescaping {% cycle %} and {% firstof %} templatetags. 
This commit adds "future" version of these two tags with auto-escaping
enabled.
 2013-02-23 16:16:39 +01:00
Tomek Paczkowski
3dddbc0f23 Fixed #19816: pre-evaluate queryset on m2m set 
In ReverseManyRelatedObjectsDescriptor.__set__, evaluate possible
queryset to avoid problems when clear() would touch data this queryset
returns.
 2013-02-23 15:50:33 +01:00
Baptiste Mispelon
069280a689 Used token.split_contents() for tokenisation in template tags accepting variables. 
Fixed #6271, #18260.
 2013-02-23 15:15:30 +01:00
Erik Romijn
21f333bcef Fix #17751: Added stripping of whitespace for IPAddressField/GenericIPAddressField 2013-02-23 14:44:57 +01:00
Claude Paroz
7ec2a21be1 Fixed #19686 -- Added HTML5 number input type 
Thanks Simon Charette for his help on the patch. Refs #16630.
 2013-02-23 10:18:08 +01:00
Anssi Kääriäinen
dcf651c27e Fixed Oracle specific failures in commands_sql tests 2013-02-23 01:08:48 +02:00
Anssi Kääriäinen
f565c6f999 Marked a test as expected failure. Refs #19884 2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
88c726bea0 Skipped a test on Oracle 2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
09fcb70c80 Fixed empty strings + to_field regression on Oracle 
Querying the reverse side of nullable to_field relation, where both
sides can contain null values resulted in incorrect results. The reason
was not detecting '' as NULL.

Refs #17541
 2013-02-23 00:05:31 +02:00
Baptiste Mispelon
f13bfbec70 Fixed #19882 -- Smarter tokenizing of {% for %} tag arguments. 2013-02-22 19:19:33 +01:00
Anssi Kääriäinen
3c6318e831 Fixed #19870 -- Regression in select_related in inheritance cases 
There was a regression in case two models inherited the same parent,
and one contained a foreign key to other. When select_related travelled
the foreign key the other model reused the parent join made by the
first model. This was likely caused by Query.join_parent_model()
addition in commit 68985db482.

Thanks to Trac alias loic84 for report & tests.
 2013-02-21 12:01:23 +02:00
Anssi Kääriäinen
50677b29af Made a couple of selenium tests wait for page loaded 
The admin_widgets tests were issuing click() to the browser but
didn't wait for the effects of those clicks. This caused the resulting
request to be processed concurrently with the test case. When using
in-memory SQLite this caused weird failures.

Also added wait_page_loaded() to admin selenium tests for code
reuse.

Fixed #19856
 2013-02-20 23:56:57 +02:00
Anssi Kääriäinen
e8fc3f3783 Added a test for negated Q object querying 
The added test is from the patch in ticket #19672 (written by Ian
Kelly). Fixed #19672, refs #19849.
 2013-02-20 21:45:36 +02:00
Anssi Kääriäinen
edf93127bf Removed join() promote kwarg 
The join promote=True was over-aggressive in select_related handling.
After that was removed, the only other user was query.combine(). That
use case is very easy to handle locally, so there is no more need for
the join(promote=True) flag.

Refs #19849.
 2013-02-20 21:43:44 +02:00
Anssi Kääriäinen
3fef304ff2 Refactored negated IS NULL handling 
This one cleaned up add_filter() negated filter generation. As a side
effect split_exclude() was cleaned up, too.

Refs #19849
 2013-02-20 21:34:01 +02:00
Alex Gaynor
b55cde054e Added a db_constraint option to ForeignKeys. 
This controls whether or not a database level cosntraint is created. This is useful in a few specialized circumstances, but in general should not be used!
 2013-02-20 11:27:32 -08:00
Claude Paroz
ae2d04f726 Add test for collapsible fieldset functionality in admin 2013-02-20 13:48:49 +01:00
Aymeric Augustin
35c991aa06 Added a default limit to the maximum number of forms in a formset. 
This is a security fix. Disclosure and advisory coming shortly.
 2013-02-19 11:23:30 -07:00
Carl Meyer
1f39eafd60 Checked object permissions on admin history view. 
This is a security fix. Disclosure and advisory coming shortly.

Patch by Russell Keith-Magee.
 2013-02-19 11:23:30 -07:00
Carl Meyer
c6d69c12ea Restrict the XML deserializer to prevent network and entity-expansion DoS attacks. 
This is a security fix. Disclosure and advisory coming shortly.
 2013-02-19 11:23:30 -07:00
Carl Meyer
d51fb74360 Added a new required ALLOWED_HOSTS setting for HTTP host header validation. 
This is a security fix; disclosure and advisory coming shortly.
 2013-02-19 11:23:29 -07:00
Anssi Kääriäinen
4b9fa49bc0 Avoided related_name conflicts in tests 2013-02-19 03:13:13 +02:00
Anssi Kääriäinen
607772b942 Removed accidentally committed file 2013-02-19 01:55:40 +02:00
Florian Hahn
3e71368423 Fixed #10870 -- Added aggreation + generic reverse relation test 2013-02-19 01:42:02 +02:00
Anssi Kääriäinen
b4492a8ca4 Fixed #19837 -- Refactored split_exclude() join generation 
The refactoring mainly concentrates on making sure the inner and outer
query agree about the split position. The split position is where the
multijoin happens, and thus the split position also determines the
columns used in the "WHERE col1 IN (SELECT col2 from ...)" condition.

This commit fixes a regression caused by #10790 and commit
69597e5bcc. The regression was caused
by wrong cols in the split position.
 2013-02-19 01:10:49 +02:00
Aymeric Augustin
aea98e8c53 Simplified MySQL version checking. 
Django used to check the version of MySQL before handling the first
request, which required:
- opening a connection
- closing it, to avoid holding it idle until the first request.

This code isn't necessary any longer since Django dropped support for
some versions of MySQL, and other database backends don't implement a
similar dance. For consistency and maintenability, remove it.

Reverts 4423757c0c.

Closes #18135.
 2013-02-18 21:46:26 +01:00
Aymeric Augustin
92837ae569 Avoided firing the request_finished signal in tests. 
* Avoided calling BaseHttpResponse.close(). The test client take care of
  that since acc5396e.
* Disconnected the request_finished signal when this method must be
  called. The test client has a similar implementation since bacb097a.
 2013-02-18 14:32:45 +01:00
Claude Paroz
632361611c Fixed #19833 -- Fixed import parameter encoding in get_runner 
Thanks Danilo Bargen for the report.
 2013-02-16 13:31:13 +01:00
Aymeric Augustin
e74e207cce Fixed #17260 -- Added time zone aware aggregation and lookups. 
Thanks Carl Meyer for the review.

Squashed commit of the following:

commit 4f290bdb60b7d8534abf4ca901bd0844612dcbda
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 21:21:30 2013 +0100

    Used '0:00' instead of 'UTC' which doesn't always exist in Oracle.

    Thanks Ian Kelly for the suggestion.

commit 01b6366f3ce67d57a58ca8f25e5be77911748638
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 13:38:43 2013 +0100

    Made tzname a parameter of datetime_extract/trunc_sql.

    This is required to work around a bug in Oracle.

commit 924a144ef8a80ba4daeeafbe9efaa826566e9d02
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 14:47:44 2013 +0100

    Added support for parameters in SELECT clauses.

commit b4351d2890cd1090d3ff2d203fe148937324c935
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 22:30:22 2013 +0100

    Documented backwards incompatibilities in the two previous commits.

commit 91ef84713c81bd455f559dacf790e586d08cacb9
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 09:42:31 2013 +0100

    Used QuerySet.datetimes for the admin's date_hierarchy.

commit 0d0de288a5210fa106cd4350961eb2006535cc5c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 09:29:38 2013 +0100

    Used QuerySet.datetimes in date-based generic views.

commit 9c0859ff7c0b00734afe7fc15609d43d83215072
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:25 2013 +0100

    Implemented QuerySet.datetimes on Oracle.

commit 68ab511a4ffbd2b811bf5da174d47e4dd90f28fc
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:14 2013 +0100

    Implemented QuerySet.datetimes on MySQL.

commit 22d52681d347a8cdf568dc31ed032cbc61d049ef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:42:29 2013 +0100

    Implemented QuerySet.datetimes on SQLite.

commit f6800fd04c93722b45f9236976389e0b2fe436f5
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:03 2013 +0100

    Implemented QuerySet.datetimes on PostgreSQL.

commit 0c829c23f4cf4d6804cadcc93032dd4c26b8c65e
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:41:08 2013 +0100

    Added datetime-handling infrastructure in the ORM layers.

commit 104d82a7778cf3f0f5d03dfa53709c26df45daad
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 10:05:55 2013 +0100

    Updated null_queries tests to avoid clashing with the __second lookup.

commit c01bbb32358201b3ac8cb4291ef87b7612a2b8e6
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 23:07:41 2013 +0100

    Updated tests of .dates().

    Replaced .dates() by .datetimes() for DateTimeFields.
    Replaced dates with datetimes in the expected output for DateFields.

commit 50fb7a52462fecf0127b38e7f3df322aeb287c43
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:40:09 2013 +0100

    Updated and added tests for QuerySet.datetimes.

commit a8451a5004c437190e264667b1e6fb8acc3c1eeb
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 22:34:46 2013 +0100

    Documented the new time lookups and updated the date lookups.

commit 29413eab2bd1d5e004598900c0dadc0521bbf4d3
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 16:15:49 2013 +0100

    Documented QuerySet.datetimes and updated QuerySet.dates.
 2013-02-16 09:19:04 +01:00
Claude Paroz
b19d83fc12 Improved input sanitizing with thousand separators 
For languages with non-breaking space as thousand separator,
standard space input should also be allowed, as few people know
how to enter non-breaking space on keyboards. Refs #17217.
Thanks Alexey Boriskin for the report and initial patch.
 2013-02-15 16:37:52 +01:00
Claude Paroz
dcf8cd30ae Updated FormattingTests test case to use settings contexts 2013-02-15 09:37:12 +01:00
Julien Phalip
7d5e35cdb4 Fixed #19829 -- Fixed index lookups for NumPy arrays in templates. 2013-02-14 23:29:15 -08:00
Michael van Tellingen
138de533ff Fixed #19819 - Improved template filter errors handling. 
Wrap the Parser.compile_filter method call with a try/except and call the
newly added Parser.compile_filter_error(). Overwrite this method in the
DebugParser to throw the correct error.

Since this error was otherwise catched by the compile_function try/except
block the debugger highlighted the wrong line.
 2013-02-14 10:22:59 +01:00
Claude Paroz
ac4faa6dc3 Fixed #19693 -- Made truncatewords_html handle self-closing tags 
Thanks sneawo for the report and Jonathan Loy for the patch.
 2013-02-13 18:24:49 +01:00
Hiroki Kiyohara
e94f405d94 Fixed #18558 -- Added url property to HttpResponseRedirect* 
Thanks coolRR for the report.
 2013-02-13 10:29:32 +01:00
Anssi Kääriäinen
fafee74306 Removed try-except in django.db.close_connection() 
The reason was that the except clause needed to remove a connection
from the django.db.connections dict, but other parts of Django do not
expect this to happen. In addition the except clause was silently
swallowing the exception messages.

Refs #19707, special thanks to Carl Meyer for pointing out that this
approach should be taken.
 2013-02-13 00:25:09 +02:00
Nick Sandford
278dad5b41 Fixed #19746 -- Allow deserialization of pk-less data 2013-02-12 17:10:42 +08:00
Simon Charette
a10f390804 Fixed #19044 -- Made DeletionMixin interpolate its success_url. 
Thanks to nxvl and slurms for the initial patch, ptone for the review
and timo for the documentation tweaks.
 2013-02-11 02:39:14 -05:00
Anssi Kääriäinen
604d8763dc Fixed #19112 -- Reduced the amount of query params in a test 2013-02-10 21:08:19 +02:00
Anssi Kääriäinen
8ef3235034 Fixed #19720 -- Oracle ordering related delete regression 
When a query had a complex where condition (a condition targeting more
than the base table) a subquery was used for deletion. However, the
query had default ordering from the model's meta and Oracle doesn't
work with ordered subqueries.

The regression was caused by fast-path deletion code introduced in
1cd6e04cd4 for fixing #18676.

Thanks to Dylan Klomparens for the report.
 2013-02-10 19:54:02 +02:00
Anssi Kääriäinen
a4e97cf315 Fixed #19707 -- Reset transaction state after requests 2013-02-10 13:55:54 +02:00
Claude Paroz
718afcafc2 Added tests for some sql_* management commands 2013-02-09 16:34:22 +01:00
Claude Paroz
f44922c795 Fixed #18906 -- Ignored to-be-deleted forms in formset validate_unique 
Thanks c.pollock at bangor.ac.uk for the report.
 2013-02-08 21:35:19 +01:00
Julien Phalip
db09a2de6e Cleaned up some lingering signals in the test suite that were causing spurious failures with Pypy and Postgres. 2013-02-08 12:12:03 -08:00
Ramiro Morales
b5391515cd Changed test assertion strategy used in 04d9730. 2013-02-07 16:51:27 -03:00
Ramiro Morales
04d9730b12 Fixed #13085 -- Don't fail on creation of model with GFK to a model with __len__() returning zero. 
Also, according to the comments on the ticket and its duplicates, added
tests execising saving an instance of a model with a GFK to:

* An unsaved object -- This actually doesn't generate the same failure
  but another ORM-level exception. The test verifies it's the case.

* An instance of a model with a __nonzero__() method thant returns False
  for it. This doesn't fail because that code path isn't executed.

* An instance of a model with a CharField PK and an empty value for it.
  This doesn't fail.
 2013-02-07 16:05:54 -03:00
Aymeric Augustin
720888a146 Fixed #15808 -- Added optional HttpOnly flag to the CSRF Cookie. 
Thanks Samuel Lavitt for the report and Sascha Peilicke for the patch.
 2013-02-07 09:48:08 +01:00
Julien Phalip
6afc85af47 Fixed a typo in the test suite that was causing some spurious failures with pypy. 2013-02-06 22:10:13 -08:00
Alexey Boriskin
d18f796a48 Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places 2013-02-06 22:01:55 +01:00
Claude Paroz
d7504a3d7b Improved regex in strip_tags 
Thanks Pablo Recio for the report. Refs #19237.
 2013-02-06 21:20:43 +01:00
Simon Charette
5449240c54 Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item. 
Thanks @rtnpro for the patch!
 2013-02-06 05:28:05 -05:00
Simon Charette
a097ee32d8 Fixed #17683 -- Make sure BaseModelFormSet respects defined widgets. 2013-02-05 05:39:35 -05:00
Simon Charette
ec469ade2b Fixed #19689 -- Renamed Model._meta.module_name to model_name. 2013-02-05 04:16:07 -05:00
Claude Paroz
40260bc30b Fixed error message test assertions under Python 3.3 
Thanks Florian Apolloner for testing.
 2013-02-04 18:00:19 +01:00
Claude Paroz
7c5b244826 Fixed #17061 -- Factored out importing object from a dotted path 
Thanks Carl Meyer for the report.
 2013-02-04 16:38:25 +01:00
Ramiro Morales
869c9ba306 Fixed #19730 -- Don't validate importability of settings by using i18n in management commands. 
They are handled independently now and the latter can be influenced by
the new BaseCommand.leave_locale_alone internal option.

Thanks chrischambers for the report, Claude, lpiatek, neaf and gabooo for
their work on a patch, originally on refs. #17379.
 2013-02-03 23:40:38 -03:00
Anssi Kääriäinen
f556df90be Fixed #19645 -- Added tests for TransactionMiddleware 2013-02-03 16:26:46 +02:00
Julien Phalip
bc7a219b1e Fixed Python 3.2 compatibility for a test. 2013-02-02 20:57:38 -08:00
Julien Phalip
293f7a2114 Fixed #17797 -- Enabled support for PATCH requests in the dummy test client. Thanks to pfarmer for the suggestion and initial patch. 2013-02-02 18:22:40 -08:00
Ramiro Morales
08dc90bccf Fixed #14305 -- Switched inspectdb to create unmanaged models. 
Thanks Ian Kelly for the report and initial patch.
 2013-02-02 21:11:32 -03:00
Nick Sandford
0694d2196f Fixed #19445 -- Skip admin fieldsets validation when the ModelAdmin.get_form() method is overridden. 2013-02-02 14:53:46 -08:00
Aymeric Augustin
ace9d4efc3 Made ungettext_lazy usable for messages that do not contain the count. 
Fixed #19160 (again). Thanks Alexey Boriskin.
 2013-02-02 10:58:31 +01:00
Aymeric Augustin
db5049c9f7 Fixed the test introduced in 2ca37af6 under Python 3. 2013-02-02 10:42:01 +01:00
Ramiro Morales
2ca37af621 Added test to demonstrate issue 11387 isn't there anymore. 
Thanks adurdin for the report and patch. Fixes #11387.
 2013-02-01 23:30:50 -03:00
Ramiro Morales
c4b6659269 Added test to demonstrate issue 11263 isn't there anymore. 
Thanks veena for the report and jaklaassen for the patch. Fixes #11263.
 2013-02-01 23:30:50 -03:00
Claude Paroz
04141c525d Fixed #19663 -- Allowed None in colorize() text parameter 
Thanks Jonathan Liuti for the report and the initial patch, and
Simon Charette for the review.
 2013-02-01 22:53:18 +01:00
Matt Robenolt
393c268e72 Fixed #19715 -- Simplified findstatic output when verbosity set to 0 2013-02-01 11:55:05 +01:00
Simon Charette
339944491c Renamed inspectdb field names for clarity 2013-02-01 09:16:29 +01:00
Claude Paroz
7bbd17bf20 Fixed #19341 -- Detected NullBooleanField when introspecting models 
Thanks Tim Bowden for the report.
 2013-01-31 20:55:00 +01:00
Claude Paroz
3c0a81aaf0 Fixed #19709 -- Fixed TimeField introspection on MySQL 
Thanks Eugene Grachev for the report.
 2013-01-31 20:41:57 +01:00
Claude Paroz
eb03fe1642 Added introspection tests for most of Django model fields 2013-01-31 20:41:57 +01:00
Ramiro Morales
7947c9e3a6 Deprecated undocumented warnings manipulation testing tools. 2013-01-31 14:57:45 -03:00
Aymeric Augustin
9a4a1ce323 Fixed #19708 -- Exception in timezone.override(None). 
Thanks rafales.
 2013-01-31 16:01:50 +01:00
Aymeric Augustin
89cb771be7 Fixed #19692 -- Completed deprecation of mimetype in favor of content_type. 
Thanks Tim for the report and initial patch.
 2013-01-31 13:54:40 +01:00
Aymeric Augustin
3895ebc734 Added file forgotten in 23e319d7. 2013-01-30 22:11:53 +01:00
Aymeric Augustin
23e319d729 Fixed #19076 -- Added content_type attribute to TemplateView. 
Thanks Gavin Wahl.
 2013-01-30 21:26:17 +01:00
Aymeric Augustin
3f1a0c0040 Fixed #19160 -- Made lazy plural translations usable. 
Many thanks to Alexey Boriskin, Claude Paroz and Julien Phalip.
 2013-01-30 20:28:16 +01:00
Ramiro Morales
47ddd6a408 Fixed #19552 -- Enhanced makemessages handling of `{# #}`-style template comments. 
They are simply ignored now. This allows for a more correct behavior when
they are placed before translatable constructs on the same line.

Previously, the latter were wrongly ignored because the former were
preserved when converting template code to the internal Python-syntax
form later fed to xgettext but Python has no ``/* ... */``-style
comments.

Also, special comments directed to translators are now only taken in
account when they are located at the end of a line. e.g.::

  {# Translators: ignored #}{% trans "Literal A" %}{# Translators: valid, associated with "Literal B" below #}
  {% trans "Literal B" %}

Behavior of ``{% comment %}...{% endcomment %}``tags remains unchanged.

Thanks juneih at redpill-linpro dot com for the report and Claude for
his work on the issue.
 2013-01-29 19:13:23 -03:00
Tim Graham
ee26797cff Fixed typos in docs and comments 2013-01-29 10:55:55 -07:00
Claude Paroz
f7394d2c32 Added HTML5 url input type 
Refs #16630.
 2013-01-28 22:11:00 +01:00
Claude Paroz
4f16376274 Added HTML5 email input type 
Refs #16630.
 2013-01-28 22:10:50 +01:00
Aymeric Augustin
c47fa3b481 Fixed #19676 -- Supported 'self' foreign keys in inspectdb. 
Thanks Georgy Kutsurua for the report and Simon Charette for the patch.
 2013-01-28 10:21:07 +01:00
Aymeric Augustin
f46d7314b5 Fixed #19677 -- Introspection of recursive foreign keys under SQLite. 
Thanks Simon Charette.
 2013-01-28 10:17:56 +01:00
Claude Paroz
4b3f7110ae Fixed #16123 -- Ensured strptime receive proper string type 
strptime generates an UnicodeEncodeError when using a non-ascii
unicode string on Python 2.
 2013-01-26 20:53:09 +01:00
Aymeric Augustin
6605ac331a Fixed #17158 -- Used a non-ambiguous representation of SQL queries 
when a correct representation cannot be obtained.
 2013-01-26 17:51:44 +01:00
Aymeric Augustin
55416e235d Fixed #19589 -- assertRegexpMatches is deprecated in Python 3.3. 2013-01-26 13:47:11 +01:00
Aymeric Augustin
424eb67867 Fixed validation of email addresses when the local part contains an @. 
See also BaseUserManager.normalize_email -- it uses rsplit.

Refs #4833.
 2013-01-26 12:20:57 +01:00
Claude Paroz
ebb504db69 Moved has_changed logic from widget to form field 
Refs #16612. Thanks Aymeric Augustin for the suggestion.
 2013-01-25 20:50:46 +01:00
Ramiro Morales
ce27fb198d Revert "Patch by Claude for #16084." 
This reverts commit 2babab0bb3.
 2013-01-25 13:58:37 -03:00
Ramiro Morales
2babab0bb3 Patch by Claude for #16084. 2013-01-25 13:23:33 -03:00
Claude Paroz
b9c8bbf372 Fixed #19665 -- Ensured proper stderr output for Command.run_from_argv 
Thanks Stefan Koegl for the report and Simon Charette for the review.
 2013-01-25 14:56:41 +01:00
Ramiro Morales
57d439e2d4 More i18n makemessages tests tweaks. 2013-01-24 07:51:14 -03:00
Claude Paroz
9893fa12b7 Fixed #19125 -- The startproject command should validate the name earlier 
Thanks Łukasz Rekucki for the report and the patch.
 2013-01-24 09:26:13 +01:00
Nick Sandford
93e79b45bc Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory 2013-01-24 08:58:17 +01:00
Ramiro Morales
456f9b9847 Simplified a i18n test. 2013-01-21 23:22:18 -03:00
Claude Paroz
8ce1e392fa Fixed error introduced when testing patch for 013db6ba85 
Shame on me.
 2013-01-21 22:42:47 +01:00
Claude Paroz
013db6ba85 Fixed #18051 -- Allowed admin fieldsets to contain lists 
Thanks Ricardo di Virgilio for the report, Mateus Gondim for the
patch and Nick Sandford for the review.
 2013-01-21 22:34:36 +01:00
Claude Paroz
c6e0dedbdb Fixed #19637 -- Ensured AdminEmailHandler fails silently 
Thanks lsaffre for the report. Refs #19325.
 2013-01-21 20:32:36 +01:00
Anssi Kääriäinen
7aa538357c Cleaned up testing models.py added for earliest() 
The main cleanup was removal of non-necessary __unicode__ method. The
tests didn't break on py3 as the string representation was never used
in the tests.

Refs #17813. Thanks to Simon Charette for spotting this issue.
 2013-01-20 08:53:45 +02:00
Nick Sandford
fe54377dae Fixed #17813 -- Added a .earliest() method to QuerySet 
Thanks a lot to everybody participating in developing this feature.
The patch was developed by multiple people, at least Trac aliases
tonnzor, jimmysong, Fandekasp and slurms.

Stylistic changes added by committer.
 2013-01-20 06:39:35 +02:00
Craig Blaszczyk
6158c79dbe Made (make|compile)messages commands accept multiple locales at once. 
Thanks Craig Blaszczyk for the initial patch. Refs #17181.
 2013-01-17 00:53:17 -03:00
Ramiro Morales
295650bd01 Simplified i18n commands tests. 2013-01-17 00:35:46 -03:00
Ramiro Morales
248aee1606 Modified makemessages so it creates .pot files once per invocation. 
It creates a `locale/django.pot` file once instead of one
`locale/<locale_code>/django.pot` file for every locale involved.

Thanks Michal Čihař for the report and patch.
 2013-01-16 20:48:06 -03:00
Ramiro Morales
eee865257a Fixed #17008 -- Added makemessages option to not remove .pot files. 
Thanks airstrike for the report and initial patch, Julien for an
enhanced patch and Jannis for reviewing.
 2013-01-16 20:29:06 -03:00
Aymeric Augustin
50a985b09b Fixed #19099 -- Split broken link emails out of common middleware. 2013-01-15 17:41:45 +01:00
Alex Gaynor
984e91e28f Removed some uses of the deprecated assertEquals 2013-01-15 07:51:33 -08:00
David Cramer
a7ed09d13d Improve test to ensure that post_delete was actually called 2013-01-14 13:34:55 -08:00
David Cramer
6045efa029 Move signal disconnect into finally block 2013-01-14 13:15:47 -08:00
David Cramer
272de9eb6b Send post_delete signals immediately 
In a normal relational construct, if you're listening for an event
that signals a child was deleted, you dont expect that the parent
was deleted already.

This change ensures that post_delete signals are fired immediately
after objects are deleted in the graph.
 2013-01-14 13:15:47 -08:00
Claude Paroz
0171ba65db Fixed #17574 -- Implemented missing get_key_columns in PostgreSQL backend 2013-01-12 21:46:08 +01:00
Claude Paroz
bcdb4898ca Fixed #19488 -- Made i18n_patterns redirect work with non-slash-ending paths 
Thanks Daniel Gerzo for the report and the initial patch.
 2013-01-11 21:27:51 +01:00
Claude Paroz
f08e739bc2 Fixed #19585 -- Fixed loading cookie value as a dict 
This regression was introduced by the 'unicode_literals' patch.
 2013-01-11 21:09:33 +01:00
Claude Paroz
4e2e8f39d1 Fixed #4833 -- Validate email addresses with localhost as domain 2013-01-11 20:45:46 +01:00
Nick Sandford
eb6c107624 Fixed #19360 -- Raised an explicit exception for aggregates on date/time fields in sqlite3 
Thanks lsaffre for the report and Chris Medrela for the initial
patch.
 2013-01-11 18:10:28 +01:00
Claude Paroz
2e55cf580e Adapted test assertion against yaml dump 
Fixes #12914 (again).
 2013-01-11 17:52:53 +01:00
Loic Raucy
62f842e2e5 Fixed #19581 -- ensure unique html ids with CheckboxSelectMultiple widgets 
ID check is now done the same way as MultipleHiddenInput.
 2013-01-09 16:06:56 -08:00
Florian Apolloner
ce580dd8ea Fixed lockups in jenkins, refs #19546. 2013-01-09 23:32:51 +01:00
Claude Paroz
e6949373b0 Skipped deprecation warning test on Python 2.6 
Refs #19546. On Python 2.6, DeprecationWarnings are visible by
default.
 2013-01-09 20:02:09 +01:00
Preston Holmes
cfa70d0c94 Fixed #19546 - ensure that deprecation warnings are shown during tests 
refs #18985
 2013-01-09 08:19:22 -08:00
Anssi Kääriäinen
55da775ce1 Fixed #17541 -- Fixed non-saved/nullable fk querying 2013-01-08 21:02:38 +02:00
Claude Paroz
34ee7d9875 Updated deprecated test assertions 2013-01-08 19:08:15 +01:00
Anssi Kääriäinen
23ca3a0194 Fixed #16759 -- Remove use of __deepcopy__ in qs.clone() 
The original problem was that queryset cloning was really expensive
when filtering with F() clauses. The __deepcopy__ went too deep copying
_meta attributes of the models used. To fix this the use of
__deepcopy__ in qs cloning was removed.

This commit results in some speed improvements across the djangobench
benchmark suite. Most query_* tests are 20-30% faster, save() is 50%
faster and finally complex filtering situations can see 2x to order
of magnitude improvments.

Thanks to Suor, Alex and lrekucki for valuable feedback.
 2013-01-08 19:17:13 +02:00
Claude Paroz
c698c55966 Created special PostgreSQL text indexes when unique is True 
Refs #19441.
 2013-01-07 17:54:30 +01:00
Anssi Kääriäinen
69a46c5ca7 Tests for various emptyqs tickets 
The tickets are either about different signature between qs.none() and
qs or problems with subclass types (either EmptyQS overrided the custom
qs class, or EmptyQS was overridden by another class - values() did
this).

Fixed #15959, fixed #17271, fixed #17712, fixed #19426
 2013-01-06 19:18:29 +02:00
Anssi Kääriäinen
a2396a4c8f Fixed #19173 -- Made EmptyQuerySet a marker class only 
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.

Thanks to Simon Charette for reviewing and valuable suggestions.
 2013-01-06 19:18:28 +02:00
Claude Paroz
b740da3504 Fixed #19192 -- Allowed running tests with dummy db backend 
Thanks Simon Charette for the initial patch, and Jan Bednařík for
his work on the ticket.
 2013-01-04 13:55:20 +01:00
Claude Paroz
ffa50ca352 Fixed #19382 -- Stopped smtp backend raising exception when already closed 
Thanks Sebastian Noack for the report and the initial patch.
 2013-01-03 20:41:45 +01:00
Claude Paroz
1b3f832ab7 Fixed #19134 -- Allowed closing smtp backend when the server is stopped 
Thanks Sebastian Noack for the report and the initial patch.
 2013-01-03 18:49:00 +01:00
Simon Charette
3fc43c964e Fixed #19545 -- Make sure media/is_multipart work with empty formsets 2013-01-03 15:16:23 +01:00
Aymeric Augustin
a7b7efe78d Minor fixes in the known_related_objects tests. 
* Fixed JSON indentation.
* Avoided relying on implicit ordering.
 2013-01-02 22:21:46 +01:00
Aymeric Augustin
07fbc6ae0e Fixed #19547 -- Caching of related instances. 
When &'ing or |'ing querysets, wrong values could be cached, and crashes
could happen.

Thanks Marc Tamlyn for figuring out the problem and writing the patch.
 2013-01-02 22:21:46 +01:00
Aymeric Augustin
feb41c3246 Modernized middleware tests. 
* Used override_settings consistently -- changes to DEBUG could leak.
* Took advantage of assertRaisesRegexp.
* Fixed indentation -- some code was indented at 2 spaces.
 2013-01-01 23:00:34 +01:00
Anton Baklanov
3aa4b8165d Fixed #19457 -- ImageField size detection failed for some files. 
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
 2013-01-01 11:54:56 +01:00
Aymeric Augustin
bacb097ac3 Fixed #19519 again -- Regression in LiveServerTestCase after fd1279a4. 2013-01-01 10:14:11 +01:00
Julien Phalip
9180146d21 Fixed #19453 -- Ensured that the decorated function's arguments are obfuscated in the @sensitive_variables decorator's frame, in case the variables associated with those arguments were meant to be obfuscated from the decorated function's frame. 
Thanks to vzima for the report.
 2012-12-31 09:34:08 -08:00
Aymeric Augustin
acc5396e6d Fixed #19519 -- Fired request_finished in the WSGI iterable's close(). 2012-12-31 12:47:34 +01:00
Claude Paroz
d11038acb2 Fixed #19537 -- Made CheckboxInput._has_changed handle 'False' string 
Thanks dibrovsd@gmail.com for the report.
 2012-12-31 10:18:59 +01:00
Julien Phalip
cee40c7d79 Added further flexibility to ModelAdmin for controlling post-save redirections. 
Refs #19505.
 2012-12-30 21:33:21 -08:00
Aymeric Augustin
4e5369a596 Silenced warnings in the tests of deprecated features. 2012-12-29 22:32:07 +01:00
Aymeric Augustin
ef017a5f00 Advanced pending deprecation warnings. 
Also added stacklevel argument, fixed #18127.
 2012-12-29 21:59:07 +01:00
Aymeric Augustin
2ecf56ea3f Removed legacy ways of calling cache_page. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
9f9a4cdecd Removed truncate_words and truncate_html_words. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
4a6490a4a0 Removed HttpRequest.raw_post_data. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
d1c72d9e01 Removed django.core.management.setup_environ and execute_manager. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
f27a4ee327 Removed django.contrib.localflavor. 
Each localflavor lives on as a separate app.
 2012-12-29 21:59:06 +01:00
Aymeric Augustin
052271168b Removed django.contrib.databrowse. 
RIP -- you served us well.
 2012-12-29 21:58:12 +01:00
Aymeric Augustin
02f3daadd6 Removed interpolation of post_url_continue in the admin. 2012-12-29 21:58:12 +01:00
Aymeric Augustin
fb9f1b9bfb Removed backwards-compatibility shim for #16288. 
Also unit-tested django.utils.log.RequireDebugTrue for consistency.
 2012-12-29 21:58:12 +01:00
Anssi Kääriäinen
13a2b11425 Avoided having an indexed TextField installed unless using postgres 
An index on TextField results in a warning message when running tests
on MySQL or SQLite, and the test using the TextField was PostgreSQL
only in any case.
 2012-12-29 16:30:17 +02:00
Anssi Kääriäinen
ba4331f177 Fixed autopk issue in tests 2012-12-29 16:25:24 +02:00
Aymeric Augustin
e9c24bef74 Fix #19524 -- Incorrect caching of parents of unsaved model instances. 
Thanks qcwxezdas for the report. Refs #13839.
 2012-12-28 23:34:54 +01:00
Aymeric Augustin
db278c3bf9 Fixed #19525 -- Reverted dcd4383107 and 05d333ba3b. 
Refs #9893, #18515.

Thanks Russell for the report.
 2012-12-27 09:37:57 +01:00
Ramiro Morales
ad769efa85 Expanded tests added when fixing #14529. 
To make sure changes in 35d1cd0 don't break anything. Refs #19505.
 2012-12-24 17:48:48 -03:00
Aymeric Augustin
1c8be95a86 Prevented caching of streaming responses. 
The test introduced in 4b278131 accidentally passed because of a
limitation of Python < 3.3.

Refs #17758, #7581.
 2012-12-24 20:28:07 +01:00
Julien Phalip
35d1cd0b28 Fixed #19505 -- A more flexible implementation for customizable admin redirect urls. 
Work by Julien Phalip.

Refs #8001, #18310, #19505. See also 0b908b92a2.
 2012-12-24 15:44:19 -03:00
Aymeric Augustin
e8f07f0378 Fixed a randomly failing test under Python 3. 
Refs #17758.
 2012-12-24 11:25:58 +01:00
Luke Plant
1ae64e96c1 Fixed a dependence on set-ordering in tests 2012-12-24 01:33:44 +00:00
Luke Plant
c31c2c92b8 Made admin generated changelist URLs independent of dict ordering 2012-12-24 01:33:24 +00:00
Ian Clelland
b9fc70141a Don't rely on dictionary ordering in tests 2012-12-24 00:45:58 +00:00
Ian Clelland
585aa11d23 Use HTML parser to compare html snippets 2012-12-24 00:26:09 +00:00
Ian Clelland
8d35fd4c32 Use new TestCase methods for equality comparisons 2012-12-24 00:24:14 +00:00
Aymeric Augustin
1e4a27d087 Fixed #19468 -- Decoded request.path correctly on Python 3. 
Thanks aliva for the report and claudep for the feedback.
 2012-12-22 13:32:39 +01:00
Anssi Kääriäinen
d407164c04 Fixed #18854 -- Join promotion in disjunction cases 
The added promotion logic is based on promoting any joins used in only
some of the childs of an OR clause unless the join existed before the
OR clause addition.
 2012-12-20 21:45:15 +02:00
Anssi Kääriäinen
3dcd435a0e Fixed #19500 -- Solved a regression in join reuse 
The ORM didn't reuse joins for direct foreign key traversals when using
chained filters. For example:
    qs.filter(fk__somefield=1).filter(fk__somefield=2))
produced two joins.

As a bonus, reverse onetoone filters can now reuse joins correctly

The regression was caused by the join() method refactor in commit
68847135bc

Thanks for Simon Charette for spotting some issues with the first draft
of the patch.
 2012-12-20 21:27:00 +02:00
Russell Keith-Magee
c04c03daa3 Fixed #19401 -- Ensure that swappable model references are case insensitive. 
This is necessary because get_model() checks are case insensitive, and if the swapable check isn't, the
swappable logic gets tied up in knots with models that are partially swapped out.

Thanks to chris@cogdon.org for the report and extensive analysis, and Preston for his work on the draft patch.
 2012-12-20 16:10:19 +08:00
Patryk Zawadzki
3989ce52ef Fixed #18172 -- Made models with __iter__ usable in ModelMultipleChoiceField 
Thanks to Patryk Zawadzki for the patch.
 2012-12-19 22:51:12 +02:00
Andrew Godwin
b62e82365a Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/loading.py
	django/db/models/options.py
 2012-12-18 09:02:07 +00:00
Claude Paroz
55972ee5c7 Fixed #19441 -- Created PostgreSQL varchar index when unique=True 
Thanks Dylan Verheul for the report and Anssi Kääriäinen for the
review.
 2012-12-18 09:56:30 +01:00
Anssi Kääriäinen
85712a5355 Made sure connections are actually closed in backends tests 2012-12-16 23:26:16 +02:00
Claude Paroz
ed711c4bd5 Fixed #19483 -- Improved import error message in contrib.comments 
Thanks Valentin Lorentz for the report and the suggested fix.
 2012-12-16 21:12:45 +01:00
Anssi Kääriäinen
69597e5bcc Fixed #10790 -- Refactored sql.Query.setup_joins() 
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.

As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.

To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.

The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
 2012-12-16 17:23:26 +02:00
Russell Keith-Magee
9facca28b6 Corrected tests depending on the error message on the AuthenticationForm. 
Refs #19368, and the fix introduced in 27f8129d64.
 2012-12-16 07:18:45 +08:00
Anssi Kääriäinen
7eba5fbc02 Fixed a couple of stale tests caused by patch for #19462 
Commit was 088d3bc2f8
 2012-12-13 15:02:08 +02:00
Anssi Kääriäinen
088d3bc2f8 Fixed #19462 -- Made assertQuerysetEqual detect undefined ordering 
If there are more than one values to compare against and the qs isn't
ordered then assertQuerysetEqual will raise a ValueError.
 2012-12-13 13:33:11 +02:00
Claude Paroz
6ed6a18a03 Fixed #19432 -- Provided better error message for get_object_or_404 
Thanks Kit Sunde for the report and Brian Holdefehr for the initial
patch.
 2012-12-12 22:05:00 +01:00
Florian Apolloner
7e97f4f510 Fixed an order dependant test failure. 2012-12-11 16:25:47 +01:00
Florian Apolloner
1eb0da1c5b Fixed a test failure in the comment tests. 2012-12-10 23:34:51 +01:00
Florian Apolloner
27560924ec Fixed a security issue in get_host. 
Full disclosure and new release forthcoming.
 2012-12-10 22:11:40 +01:00
Florian Apolloner
a2f2a39956 Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users. 2012-12-10 22:11:39 +01:00
Claude Paroz
0cdfa76e68 Amended an SQL test fixture to not include an id value 
Some backends might need special handling for auto-increment values.
This was introduced in 5fa5621f57. Thanks Michael Manfre for spotting
the issue.
 2012-12-10 17:49:04 +01:00
Aymeric Augustin
49519328b4 Fixed #19392 -- Improved error for old-style url tags with dashes. 
Thanks dloewenherz for the report.
 2012-12-09 16:17:56 +01:00
Claude Paroz
8248d14029 Removed US localflavor-specific tests from core 
Also fixes #9045.
 2012-12-08 21:07:59 +01:00
Claude Paroz
04e6542b5a Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides 
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
 2012-12-08 12:41:11 +01:00
Claude Paroz
c91667338a Fixed #19357 -- Allow non-ASCII chars in filesystem paths 
Thanks kujiu for the report and Aymeric Augustin for the review.
 2012-12-08 11:13:52 +01:00
Andreas Hug
66dfcc10b3 Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid 
Thanks Simon Charette for the report and the initial patch.
 2012-12-06 20:00:56 +01:00
Claude Paroz
34dcf51e06 Fixed #19367 -- Fixed saving ContentFile in filesystem storage 
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
 2012-12-06 17:14:44 +01:00
Marc Aymerich
553838a285 Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines 
Applied to inlines what ec9d6b1122 did for main fieldsets.
 2012-12-06 09:52:02 +01:00
Anssi Kääriäinen
632cf32b43 Fixed #19391 -- Oracle specific failure in tests 
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
IntegerField.
 2012-12-04 22:49:02 +02:00
Julien Phalip
c196e01100 Fixed the admin_filters tests for Postgres. 2012-12-04 10:36:56 -08:00
Claude Paroz
795ac7deda Fixed #19378 -- Ensured get_success_url returns a non-lazy URL 2012-12-04 13:22:42 +01:00
Andrew Godwin
501c7a221c Merge pull request #573 from tominsam/master 
Fixed #19070: urlize template filter raises exception in some cases
 2012-12-04 02:18:10 -08:00
Ramiro Morales
b64d30405a Fixed #18697 -- Made values accepted for two customizable admin templates consistent. 
Thanks and at cloverfastfood dot com for the report.
 2012-12-04 01:13:01 -03:00
Sebastián Magrí
88e1715639 Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string. 2012-12-03 11:53:15 -08:00
Claude Paroz
5fa5621f57 Fixed #19416 -- Fixed multi-line commands in initial SQL files 
Thanks Aymeric Augustin for detecting this regression.
 2012-12-03 20:47:08 +01:00
Tom Insam
161cafb6f6 another failing test case for square brackets. 2012-12-03 12:11:32 +00:00
Aymeric Augustin
baae4b8187 Fixed #19397 -- Crash on binary files in project templates. 
Thanks gw 2012 at tnode com for the report.
 2012-12-03 10:45:18 +01:00
Julien Phalip
2e2c4968f6 Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch. 2012-12-02 20:54:34 -08:00
Claude Paroz
349c4c37f8 Fixed #19015 -- Add ISO input formats to all formats 2012-12-01 14:05:52 +01:00
Claude Paroz
0eeae15056 Fixed #19354 -- Do not assume usermodel.pk == usermodel.id 
Thanks markteisman at hotmail.com for the report.
 2012-11-29 21:45:43 +01:00
Anssi Kääriäinen
163b471e9e Converted a couple of assertEquals -> assertEqual 2012-11-28 23:44:50 +02:00
Tai Lee
6ebf115206 Fixed #14694 -- Made `defer()` work with reverse relations 
Reverse o2o fields are now usable with defer.
 2012-11-28 18:17:10 +02:00
Danilo Bargen
c10aaa70a4 Fixed #19370 -- Made date filter properly handle midnight value 2012-11-27 21:24:16 +01:00
Anssi Kääriäinen
64f6e0370a Made some tests behave nicer re connection handling 2012-11-27 19:47:20 +02:00
Aymeric Augustin
2ea80b94d7 Fixed #19362 -- Detected invalid use of @python_2_unicode_compatible. 
Thanks m3wolf for the report and akaariai for reproducing the problem.
 2012-11-27 09:45:37 +01:00
Edward Tjörnhammar
29d59a879e Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None. 2012-11-25 23:13:30 +01:00
Julien Phalip
ae206d78f6 Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch. 2012-11-25 20:39:23 +01:00
Claude Paroz
f26b956e80 Fixed test failure following capitalization fix in 2f035a972 2012-11-25 19:54:38 +01:00
Aymeric Augustin
7644800070 Change exception type to reduce confusion. 
TemplateSyntaxError is expected at compile time, not at run time.

Refs #19280.
 2012-11-25 19:51:42 +01:00
Aymeric Augustin
f89901dc05 Fixed two typos. 2012-11-25 19:31:53 +01:00
Claude Paroz
a5d47415f4 Enabled SimpleTestCase to be decorated by override_settings 
Refs #18417. Also fixed some test case classes which subclassed
the wrong parent.
 2012-11-25 19:06:17 +01:00
Claude Paroz
9f7cefd505 Fixed #18417 -- Raised exception when unittest.TestCase is decorated with override_settings 2012-11-25 19:06:17 +01:00
Aymeric Augustin
d266919584 Fixed #19280 -- Raised an explicit exception for the old {% url %} syntax. 2012-11-24 22:10:51 +01:00
Aymeric Augustin
690cac3a34 Used a django.test.TestCase for compatibility with @override_settings. 
These tests were silently skipped.
 2012-11-24 22:10:51 +01:00
Anssi Kääriäinen
dc569c8801 Fixed ordering-related failure in m2m_through_regress tests 2012-11-24 16:03:21 +02:00
Chris Khoo
bf1871d874 Fixed #19237 -- Improved strip_tags utility 
The previous pattern didn't properly addressed cases where '>'
was present inside quoted tag content.
 2012-11-24 12:16:52 +01:00
Russell Keith-Magee
18d7c1ea3a Simplified the deletions performed by the swappable_models test. 
This is required to allow the test to run without error under SQLite in the CI environment.
 2012-11-24 15:07:50 +08:00
Russell Keith-Magee
c8985a8a73 Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models. 
Thanks to rizumu for the report.
 2012-11-24 13:43:20 +08:00
Anssi Kääriäinen
0a0a0d66b3 Fixed #19351 -- SQLite bulk_insert of more than 500 single-field objs 2012-11-24 01:13:12 +02:00
Anssi Kääriäinen
a27582484c Fixed SQLite's collapsing of same-valued instances in bulk_create 
SQLite used INSERT INTO tbl SELECT %s UNION SELECT %s, the problem
was that there should have been UNION ALL instead of UNION.

Refs #19351
 2012-11-24 01:12:17 +02:00
Anssi Kääriäinen
90b86291d0 Fixed #18375 -- Removed dict-ordering dependency for F-expressions 
F() expressions reuse joins like any lookup in a .filter() call -
reuse multijoins generated in the same .filter() call else generate
new joins. Also, lookups can now reuse joins generated by F().

This change is backwards incompatible, but it is required to prevent
dict randomization from generating different queries depending on
.filter() kwarg ordering. The new way is also more consistent in how
joins are reused.
 2012-11-23 19:53:04 +02:00
Aymeric Augustin
2875b5dcab Tweak a test to avoid hitting a limit with SQLite. 
Django cannot delete more than 999 objects at a time with SQLite.

Refs #16426, #16039.
 2012-11-23 10:02:18 +01:00
Tim Graham
0e3690d230 Fixed #18974 - Warned against using models.permalink 
Thanks dstufft for the draft patch.
 2012-11-22 16:08:51 -05:00
Aymeric Augustin
a026e480da Fixed #16039 -- Made post_syncdb handlers multi-db aware. 
Also reverted 8fb7a90026. Refs #17055.
 2012-11-22 20:53:59 +01:00
George Hickman
ea6b95dbec Fixed #19316 -- Set View args/kwargs/request before dispatch 2012-11-22 20:13:01 +01:00
Jannis Leidel
3fb83729b9 Merge branch 'ticket_19325' of https://github.com/hannesstruss/django into hannesstruss-ticket_19325 2012-11-22 10:05:08 +01:00
Julien Phalip
693b8a65ad Modified a staticfiles test to use a unicode character that has just one single representation. The previously used character (ş) has two different representations (u'\u015f' and u's\u0327'), which caused spurious failures when the tests were run across multiple platforms (e.g. on a Linux VM hosted on a Mac). 2012-11-21 09:52:09 +01:00
Claude Paroz
b781354ad1 Updated assertions in pagination test 
assertEquals is a deprecated assertion alias.
 2012-11-21 09:06:21 +01:00
Chris Beaven
48e8b5e944 Add orphans support to MultipleObjectMixin 
Fixes #7005
 2012-11-21 16:50:23 +13:00
Chris Beaven
fbfa654a15 Paginator._get_page hook 
This allows for Paginator subclasses to easily override the Page class
that gets used.

Took the opportunity to also do some non-invasive PEP8 tidying of the
paginator module.
 2012-11-21 15:19:44 +13:00
Hannes Struss
f9891f2087 Fixed #19325 - Made email backend of AdminEmailHandler configurable 2012-11-20 11:23:12 +01:00
Preston Holmes
edf7ad36fa Fixed #18658 -- Improved ModelAdmin.message_user API 
Thanks to Lowe Thiderman for the patch and tests
 2012-11-19 16:03:09 -08:00
Jannis Leidel
778b8bdcf4 Merge pull request #467 from tomchristie/page-kwarg 
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
 2012-11-17 12:27:01 -08:00
Claude Paroz
e0363c688d Fixed #19114 -- Fixed LogEntry unicode representation 
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
 2012-11-17 19:19:59 +01:00
Claude Paroz
2a67374b51 Fixed #19036 -- Fixed base64 uploads decoding 
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
 2012-11-17 17:25:21 +01:00
Claude Paroz
ec9d6b1122 Fixed #19226 -- Applied linebreaksbr to read-only fields in admin 
Thanks shadow for the report, and Melevir and thiderman for the
patch.
 2012-11-17 17:06:24 +01:00
Jannis Leidel
f79013843d Fixed typo introduced in 4a5e8087ac. 2012-11-17 16:00:19 +01:00
Jannis Leidel
233f86443c Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars 
Fixed #18210 -- Escaped special characters in reverse prefixes.
 2012-11-17 06:49:18 -08:00
Jannis Leidel
4a5e8087ac Fixed #19136 -- Properly escape gettext context prefixes in the i18n JavaScript view template. 2012-11-17 15:37:30 +01:00
Preston Holmes
44046e8a38 Fixed #18985 -- made DeprecationWarnings loud 
Capture warnings in Python >= 2.7 and route through
console handler, which is subject to DEBUG==True

Thanks to dstufft for the idea, and claudep for initial patch
 2012-11-16 17:07:38 -08:00
Anssi Kääriäinen
71e14cf3aa Fixed #18347 -- Removed autofield raw SQL inserts from tests 2012-11-15 17:31:08 +02:00
Anssi Kääriäinen
f51e409a5f Fixed #13781 -- Improved select_related in inheritance situations 
The select_related code got confused when it needed to travel a
reverse relation to a model which had different parent than the
originally travelled relation.

Thanks to Trac aliases shauncutts for report and ungenio for original
patch (committed patch is somewhat modified version of that).
 2012-11-15 17:15:21 +02:00
Claude Paroz
550ddc66b4 Fixed #19272 -- Fixed gettext_lazy returned type on Python 2 
Thanks tyrion for the report.
 2012-11-14 10:50:15 +01:00
Claude Paroz
1620c27936 Fixed #19186 -- Fixed sending mail with unicode content on Python 3 
Thanks alex_po for the report and Luke Plant for the analysis.
 2012-11-14 10:43:33 +01:00
Aymeric Augustin
4c5cea7073 Merge pull request #218 from mgrouchy/ticket_18582 
Fixed #18582 -- Added a no-op close to BaseCache
 2012-11-11 07:18:45 -08:00
Claude Paroz
34162698cc Fixed #14264 -- Ensured settings.configure configures logging 
Thanks Matt McDonald for the patch.
 2012-11-10 12:05:58 +01:00
Sean Breant
4d817b3887 Fixed #19262 -- Support cookie pickling in SimpleTemplateResponse 
Refs #15863.
 2012-11-09 21:07:53 +01:00
Claude Paroz
1b307d6c8f Fixed #19261 -- Delayed Queryset evaluation in paginators 
Thanks trbs for the report and the patch.
 2012-11-09 19:41:57 +01:00
Claude Paroz
45802e1248 Merged pagination tests 
It is simpler/cleaner to have all pagination tests in a single file.
Refs #16122.
 2012-11-08 11:07:16 +01:00
Anssi Kääriäinen
cafb266954 Fixed #17144 -- MySQL again groups by PK only 
Thanks to Christian Oudard for the report and tests.
 2012-11-08 00:56:32 +02:00
Claude Paroz
79dd751b0b Fixed #14315 -- Made memcached backend handle negative incr/decr values 
Thanks Michael Manfre for the report and initial patch and
Tobias McNulty for the review.
 2012-11-06 12:22:42 +01:00
Claude Paroz
78f66691ee Fixed #8627 -- Prevented textareas to swallow first newline content 
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
 2012-11-05 20:27:06 +01:00
Preston Holmes
6bd61194d4 Fixed py3 compatibility for 5a00a57aa5 2012-11-04 23:38:41 -08:00
Anton I. Sipos
fdea2621cd Fixed #18949 -- Fix broken test interactions in ModelForms tests 
A test in Model Forms test was specifically referring to a fixed
primary key, which was now being used up in a newly committed.
This has been worked around by specifying a higher primary
key.
 2012-11-04 18:43:11 -08:00
Alex Gaynor
4d766b3c9a Merge pull request #495 from aisipos/ticket_18949 
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
 2012-11-04 15:57:45 -08:00
Anton I. Sipos
e44ab5bb4f Fixed #18949 -- Improve performance of model_to_dict with many-to-many 
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many

Thanks to brian for the original report and suggested fix.
 2012-11-04 15:52:05 -08:00
Preston Holmes
5a00a57aa5 Fixed #19240 -- include pagination error details in ListView 404 
Thanks to seawolf for the patch
 2012-11-04 15:52:00 -08:00
Mike Johnson
fcd3d4c68f model_split: Fixed #19236 - fixed error for abstract models with a split method 2012-11-04 13:43:54 -08:00
Alex Gaynor
4285571c5a Fixed #5805 -- it is now possible to specify multi-column indexes. Thanks to jgelens for the original patch. 2012-11-04 10:16:06 -08:00
Aymeric Augustin
973f539ab8 Fixed #15152 -- Avoided crash of CommonMiddleware on broken querystring 2012-11-03 21:28:33 +01:00
Gabriel Hurley
90e530978d Fixed #18210 -- Escaped special characters in reverse prefixes. 
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.

Thanks to toofishes for the error report.
 2012-11-03 13:06:57 -07:00
Aymeric Augustin
095eca8dd8 Fixed #19101 -- Decoding of non-ASCII POST data on Python 3. 
Thanks Claude Paroz.
 2012-11-03 13:03:15 +01:00
Ulrich Petri
ac2052ebc8 Fixed #17549 -- Added a clickable link for URLFields in admin change list. 2012-11-03 11:57:33 +01:00
Tim Graham
feaf9f279a Fixed #15361 - Documented performance considerations for QuerySet.get() 
Thanks mmcnickle for the patch.
 2012-11-02 17:58:24 -04:00
Andrew Godwin
7f75460fd6 Fixed #19070 -- urlize filter no longer raises exceptions on 2.7 
Thanks to claudep for the patch.
 2012-10-31 10:58:14 +00:00
Anssi Kääriäinen
68847135bc Removed dupe_avoidance from sql/query and sql/compiler.py 
The dupe avoidance logic was removed as it doesn't seem to do anything,
it is complicated, and it has nearly zero documentation.

The removal of dupe_avoidance allowed for refactoring of both the
implementation and signature of Query.join(). This refactoring cascades
again to some other parts. The most significant of them is the changes
in qs.combine(), and compiler.select_related_descent().
 2012-10-31 08:19:44 +02:00
Claude Paroz
73245b3285 Prevented file_upload tests to leave files behind 
Refs #19206.
 2012-10-30 22:27:55 +01:00
Claude Paroz
9a02851340 Fixed #17744 -- Reset default file storage with setting_changed signal 2012-10-30 22:23:28 +01:00
Claude Paroz
6de6988f99 Fixed #5076 -- Properly decode POSTs with non-utf-8 payload encoding 
Thanks daniel at blogg.se for the report and Aymeric Augustin for
his assistance on the patch.
 2012-10-30 09:00:32 +01:00
Claude Paroz
d30516e163 Prevented leftover files and dirs in admin_scripts tests 2012-10-29 19:08:07 +01:00
Luke Plant
4c4d08502c Fixed #17991 - prefetch_related fails with GenericRelation and varchar ID field 
Thanks to okke@formsma.nl for the report, and carmandrew@gmail.com for the tests.
 2012-10-29 14:31:54 +00:00
Claude Paroz
f1cc2be0c5 Fixed #18575 -- Empty DATABASES should default to dummy backend 
Thanks delormemarco@gmail.com for the report.
 2012-10-28 23:44:03 +01:00
Aymeric Augustin
b4420d9602 Fixed #18964 -- floatformat test passes under py3k 
Thanks Russell for the report.
 2012-10-28 19:57:03 +01:00
Anssi Kääriäinen
611c4d6f1c Fixed #18823 -- Ensured m2m.clear() works when using through+to_field 
There was a potential data-loss issue involved -- when clearing
instance's m2m assignments it was possible some other instance's
m2m data was deleted instead.

This commit also improved None handling for to_field cases.
 2012-10-28 17:31:35 +02:00
Anssi Kääriäinen
a5152bb646 Marked a test as expectedFailure on Oracle 2012-10-27 18:34:18 +03:00
Anssi Kääriäinen
2249bd275c Fixed Oracle failure for "%" in table name 2012-10-27 05:26:42 +03:00
Aymeric Augustin
789ea3342d Fixed comment_test tests under hash randomization. 
Thanks clelland for the patch.
 2012-10-26 22:47:45 +02:00
Aymeric Augustin
46d27a6b8d Fixed feedgenerator tests under hash randomization 2012-10-26 22:40:35 +02:00
Aymeric Augustin
195bc37f1d Fixed httpwrappers tests under hash randomization 2012-10-26 22:09:48 +02:00
Claude Paroz
be29329ccd Fixed #16820 -- Treated '0' value as True for checkbox inputs 
Thanks Dan Fairs for the report and the initial patch.
 2012-10-26 20:44:00 +02:00
Andrew Godwin
6a632e0457 Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/models/fields/related.py
	django/db/models/options.py
 2012-10-26 08:41:13 +01:00
Luke Plant
fabe9c9e5f Fixed test failure under Python 2.x introduced in 3e10d22df5 2012-10-26 02:45:15 +01:00
Luke Plant
3e10d22df5 Fixed test failures on Python 3.3 due to dict ordering assumptions. 
Refs #19038
 2012-10-26 02:13:09 +01:00
Luke Plant
c8508943a2 Fixed some test failures on Python 3.3 related to QueryDict 
Refs #19038.
 2012-10-26 01:55:55 +01:00
Ian Clelland
bdcd2f6b10 Avoid dependence on exact Python exception messages 2012-10-26 01:40:33 +01:00
Ian Clelland
02dda22832 Don't use : as an invalid cookie character 
Since http://bugs.python.org/issue2193 has been resolved in favour of
the colon in cookie names, we need to test invalid cookie removal using
a different character. "@" is still considered invalid by all sources.
 2012-10-26 01:40:32 +01:00
Luke Plant
71734dfa72 Fixed #19039 - Python 3.3 fails unit test for duplicate bad cookies 
Thanks to clelland for the report.
 2012-10-26 00:50:25 +01:00
Luke Plant
f3a2bcdee9 Fixed #15040 - Boolean fields return 0 and 1 when loaded through select_related 
Thanks to homm for the report and ramiro for the patch.
 2012-10-26 00:25:59 +01:00
Aymeric Augustin
1d6b7f302a Fixed timezone tests when dict randomization is on 
Refs #17758.
 2012-10-25 23:14:17 +02:00
Anssi Kääriäinen
7de439f32d Fixed #19187 -- Raise consistent error from qs.values().delete() 2012-10-25 17:16:56 +03:00
Anssi Kääriäinen
f64a5ef404 Fixed #19102 -- Fixed fast-path delete for modified SELECT clause cases 
There was a bug introduced in #18676 which caused fast-path deletes
implemented as "DELETE WHERE pk IN <subquery>" to fail if the SELECT
clause contained additional stuff (for example extra() and annotate()).

Thanks to Trac alias pressureman for spotting this regression.
 2012-10-25 17:16:44 +03:00
Tom Christie
f824a95177 Test for ListView.page_kwarg 2012-10-25 13:19:53 +01:00
Aymeric Augustin
da56e1bac6 Fixed #18796 -- Refactored conversion to bytes in HttpResponse 
Thanks mrmachine for the review.
 2012-10-25 08:49:51 +02:00
Aymeric Augustin
82b3e6ffcb Fixed #13222 -- Made HttpResponse iterable once 
response.content can be accessed many times as desired, and always
returns the same result.

iter(response) works only once and consumes the iterator.
 2012-10-24 17:19:56 +02:00
Aymeric Augustin
495a8b8107 Fixed #6527 -- Provided repeatable content access 
in HttpResponses instantiated with iterators.
 2012-10-24 17:08:37 +02:00
Aymeric Augustin
83041ca802 Fixed a DeprecationWarning under Python 3. 2012-10-24 16:52:21 +02:00
Claude Paroz
9fd2f9c5f3 Fixed #19088 -- Always escape % inside blocktrans tag 
Thanks vlinhart for the report and Łukasz Rekucki for the patch.
 2012-10-23 18:49:22 +02:00
Carl Meyer
3541a10d49 Fixed #19164 -- Fixed diffsettings command broken in fix for #18545. 
Thanks Mario César for the report and draft patch.
 2012-10-22 18:49:08 -06:00
Aymeric Augustin
ea57112d53 Reverted 6a64822bf4. 
This commit caused every test that does two or more assertContains to
fail, because of #6527. It also made HttpResponse non-pickleable.

Refs #13222.
 2012-10-23 00:11:17 +02:00
Aymeric Augustin
6a64822bf4 Fixed #13222 -- Repeated iteration of HttpResponse 
Thanks teepark for the report and grahamd for his insights.
 2012-10-22 22:52:36 +02:00
Claude Paroz
e70170c2cb Cleaned up i18n regression tests 2012-10-22 14:45:41 +02:00
Aymeric Augustin
5e629a015e Added tests for conditional_content_removal. 
Refs #7581. Thanks mrmachine.
 2012-10-21 22:40:31 +02:00
Claude Paroz
22471a41ba Merge pull request #457 from JanBednarik/ticket_19142 
Fixed #19142 -- Language codes can include numbers (RFC 3066)
 2012-10-21 10:35:01 -07:00
Alex Gaynor
6b3d2bc981 Merge pull request #444 from mitar/patch-2 
Allow reversed iteration over SortedDict.
 2012-10-20 20:39:49 -07:00
Jan Bednařík
e6b34193c5 Fixed #19142 -- Language codes can include numbers (RFC 3066). 2012-10-21 01:25:35 +02:00
Jan Bednařík
b87e2f46c8 Fixed #19151 -- Added missing methods to EmptyQuerySet. 
Added values() and values_list() methods to EmptyQuerySet.
 2012-10-21 00:19:38 +02:00
Aymeric Augustin
d7c6a57d60 Used @override_settings in several tests. 2012-10-20 23:22:46 +02:00
Aymeric Augustin
4b27813198 Fixed #7581 -- Added streaming responses. 
Thanks mrmachine and everyone else involved on this long-standing ticket.
 2012-10-20 20:05:11 +02:00
Claude Paroz
cfb3eb2e3d Used FakePayload in requests tests 2012-10-20 15:54:26 +02:00
Claude Paroz
dcbf08cce5 Fixed #19094 -- Improved FakePayload to support write, len and string input 
Thanks Ondrej Slinták for the suggestion.
 2012-10-20 15:36:24 +02:00
Claude Paroz
dfd4a71751 Fixed #5611 -- Restricted accepted content types in parsing POST data 
Thanks paulegan for the report and Preston Holmes for the review.
 2012-10-20 14:56:16 +02:00
Claude Paroz
681550ca6d Removed custom WSGIRequestHandler.get_environ 
We probably historically customized it for good reasons, but
currently, the differences with upstream Python are not
significant any longer.
Also fixes #19075 for which a test has been added.
 2012-10-20 13:55:13 +02:00
Ramiro Morales
0b908b92a2 Fixed #8001 -- Made redirections after add/edit in admin customizable. 
Also fixes #18310.
 2012-10-18 20:58:52 -03:00
Preston Holmes
4fb510fde4 Added missed poisoned host header tests 2012-10-18 11:10:46 -07:00
Claude Paroz
6b0a836c9c Fixed assertXMLEqual when first node was a comment 2012-10-15 23:05:40 +02:00
Mitar
2811e543c6 Added tests for reversed iteration over SortedDict. 2012-10-15 12:12:10 -07:00
Ludovic Delaveau
7a44dc555a Fixed #16479 - Forms generated from formsets use ErrorList instead of supplied error_class 
Patch with tests from charettes, updated.
 2012-10-13 15:28:20 +01:00
Adrian Holovaty
ffbc599f77 Removed country-specific localflavor tests. 
They now live in separate django-contrib-XX packages.
 2012-10-12 16:21:51 -05:00
Tim Graham
06f5da3d78 Fixed #16817 - Added a guide of code coverage to contributing docs. 
Thanks Pedro Lima for the draft patch.
 2012-10-11 06:11:52 -04:00
Anssi Kääriäinen
041ef9ed68 Removed some uses of F() expression & and | 
Refs #16211
 2012-10-10 03:31:11 +03:00
Michael Manfre
32ac067a6d Fixed #18927 -- Fixed bulk_create tests when no has_bulk_insert 2012-10-10 01:39:43 +03:00
Anssi Kääriäinen
b625e8272b Moved F() '&' and '|' to .bitand() and .bitor() 
Done for consistency with Q() expressions and QuerySet combining. This
will allow usage of '&' and '|' as boolean logical operators in the
future. Refs #16211.
 2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
a8b1861fc4 Revert "Fixed #16211 -- Added comparison and negation ops to F() expressions" 
This reverts commit 28abf5f0eb.

Conflicts:

	docs/releases/1.5.txt
 2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
7f4dbdc036 Revert "Splitted expressions tests into smaller methods" 
This reverts commit c2532825db.
 2012-10-10 01:15:29 +03:00
Claude Paroz
252cd271e8 Fixed test failure after IDN domain validation fix 
Refs #17867.
The address in test_email_regexp_for_performance used to take forever
(security issue), then was supposed to fail after the fix (commit 9f8287a3f).
Now we are less strict with domain validation, due to new IDN domains,
hence the validation of this address pass now.
 2012-10-09 22:44:43 +02:00
Aymeric Augustin
3190abcd75 Fixed #18153 -- Reverse OneToOne lookups on unsaved instances. 
Thanks David Hatch and Anssi Kääriäinen for their inputs.
 2012-10-09 21:36:35 +02:00
Aymeric Augustin
c9b4e9ac3a Fixed #19095 -- invalid code in multidb tests. 2012-10-09 21:23:02 +02:00
Claude Paroz
273b96ef9d Fixed #17867 -- Made email validation pass with IDN domains 
Thanks Pierre Matri for the report and the initial patch.
 2012-10-09 15:08:32 +02:00
Claude Paroz
8cb9968a91 Moved some email validation tests to validators tests 2012-10-09 15:08:32 +02:00
Claude Paroz
a8f888feb4 Improved assertion error messages in validators tests 2012-10-09 15:08:22 +02:00
Anssi Kääriäinen
a62d53c032 Fixed #19087 -- Ensured query's base table is never LOUTER joined 
This fixes a regression created by join promotion logic refactoring:
01b9c3d519

Thanks to Ivan Virabyan for the report.
 2012-10-08 18:40:09 +03:00
Claude Paroz
4797ad80da [py3] Decoded the parsed source file encoding in debug view 2012-10-08 10:06:56 +02:00
Ramiro Morales
35e8dc5169 Removed ad-hoc support for usage of short names of built-in DB backends. 
This non-standard naming was deprecated in Django 1.2.
 2012-10-06 23:27:08 -03:00
Claude Paroz
117e99511e Added assertXML[Not]Equal assertions 
This is especially needed to compare XML when hash randomization
is on, as attribute order may vary. Refs #17758, #19038.
Thanks Taylor Mitchell for the initial patch, and Ian Clelland for
review and cleanup.
 2012-10-06 13:14:50 +02:00
Russell Keith-Magee
cc337a74f1 Fixed #19069 -- Improved the error message when trying to query a swapped model. 
Thanks to Preston Holmes for the suggestion.
 2012-10-06 14:21:57 +08:00
Stephen Burrows
218abcc9e5 Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty value 2012-10-03 20:47:35 +03:00
Russell Keith-Magee
3b6f980bed Fixed #19049 -- Ensure that swapped models aren't included in reverse field caches. 
Thanks to Ivan Virabyan for the report.
 2012-10-02 22:52:45 +08:00
Preston Holmes
55fa86a97f Fixed postgres rollback issue with fixture test 2012-10-01 11:36:16 -07:00
Preston Holmes
e7723683dc Fixed #9279 -- Added ignorenonexistent option to loaddata 
Thanks to Roman Gladkov for the initial patch and Simon Charette for review.
 2012-09-30 23:40:27 -07:00
Claude Paroz
8bd7b598b6 Fixed #18807 -- Made 404.html and 500.html optional 
Thanks Aymeric Augustin for the report and Jannis Leidel for the
review.
 2012-09-30 23:16:19 +02:00
Claude Paroz
08d675a98f Fixed #7936 -- Added Last-Modified header to feeds 
Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.
 2012-09-30 22:40:25 +02:00
Anssi Kääriäinen
c2532825db Splitted expressions tests into smaller methods 2012-09-30 17:51:11 +03:00
Anssi Kääriäinen
28abf5f0eb Fixed #16211 -- Added comparison and negation ops to F() expressions 
Work done by Walter Doekes and Trac alias knoeb. Reviewed by Simon
Charette.
 2012-09-30 17:51:06 +03:00
Claude Paroz
f0f327bbfe Fixed #18993 -- 'django' logger logs to console when DEBUG=True 
Thanks Preston Holmes for the review.
 2012-09-29 22:56:18 +02:00
Florian Apolloner
6a6f589bfe Merge branch 'ticket15695' 2012-09-29 21:57:50 +02:00
Anssi Kääriäinen
1cd6e04cd4 Fixed #18676 -- Allow fast-path deletion of objects 
Objects can be fast-path deleted if there are no signals, and there are
no further cascades. If fast-path is taken, the objects do not need to
be loaded into memory before deletion.

Thanks to Jeremy Dunck, Simon Charette and Alex Gaynor for reviewing
the patch.
 2012-09-28 18:16:08 +03:00
Anssi Kääriäinen
3fcca0e947 Added a way to check if a signal has listeners 2012-09-28 18:10:52 +03:00
Claude Paroz
07ffe78143 Used get_current_site in comments feed class 2012-09-28 14:35:26 +02:00
Julien Phalip
b8244c654c Fixed #18881 -- Made the context option in {% trans %} and {% blocktrans %} accept literals wrapped in single quotes. Thanks to lanyjie for the report. 2012-09-27 20:34:45 -07:00
Eduardo Cereto Carvalho
c9c9a56425 Added complementary regression test for commit c1729510 
Also fixed #18660.
 2012-09-27 15:57:28 +02:00
Florian Apolloner
b946db5241 Fixed #15695 -- Added ResolverMatch to the request object. 2012-09-27 15:06:58 +02:00
Claude Paroz
3cbe686af6 Fixed #18675 -- Fixed was_modified_since with floating-point mtime 
Thanks Simon Charette for the patch.
 2012-09-26 21:12:56 +02:00
Claude Paroz
b3ee80a0cf Fixed parse_http_date docstring and moved related tests 
Refs #18675.
 2012-09-26 21:10:17 +02:00
Claude Paroz
bb7da7844f Fixed #18845 -- Do not swallow AttributeErrors when running commands 2012-09-26 15:07:11 +02:00
Adrien Lemaire
2c8267bf3d Fixed #17899 -- Rewrote [Ee]-mail to [Ee]mail 2012-09-26 14:14:51 +02:00
Russell Keith-Magee
70a0de37d1 Fixed #3011 -- Added swappable auth.User models. 
Thanks to the many people that contributed to the development and review of
this patch, including (but not limited to) Jacob Kaplan-Moss, Anssi
Kääriäinen, Ramiro Morales, Preston Holmes, Josh Ourisman, Thomas Sutton,
and Roger Barnes, as well as the many, many people who have contributed to
the design discussion around this ticket over many years.

Squashed commit of the following:

commit d84749a0f034a0a6906d20df047086b1219040d0
Merge: 531e771 7c11b1a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Wed Sep 26 18:37:04 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 531e7715da545f930c49919a19e954d41c59b446
Merge: 29d1abb 1f84b04
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Wed Sep 26 07:09:23 2012 +0800

    Merged recent trunk changes.

commit 29d1abbe351fd5da855fe5ce09e24227d90ddc91
Merge: 8a527dd 54c81a1
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 24 07:49:46 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 8a527dda13c9bec955b1f7e8db5822d1d9b32a01
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 24 07:48:05 2012 +0800

    Ensure sequences are reset correctly in the presence of swapped models.

commit e2b6e22f298eb986d74d28b8d9906f37f5ff8eb8
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 17:53:05 2012 +0800

    Modifications to the handling and docs for auth forms.

commit 98aba856b534620aea9091f824b442b47d2fdb3c
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 15:28:57 2012 +0800

    Improved error handling and docs for get_user_model()

commit 0229209c844f06dfeb33b0b8eeec000c127695b6
Merge: 6494bf9 8599f64
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 14:50:11 2012 +0800

    Merged recent Django trunk changes.

commit 6494bf91f2ddaaabec3ec017f2e3131937c35517
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 17 21:38:44 2012 +0800

    Improved validation of swappable model settings.

commit 5a04cde342cc860384eb844cfda5af55204564ad
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 17 07:15:14 2012 +0800

    Removed some unused imports.

commit ffd535e4136dc54f084b6ac467e81444696e1c8a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 20:31:28 2012 +0800

    Corrected attribute access on for get_by_natural_key

commit 913e1ac84c3d9c7c58a9b3bdbbb15ebccd8a8c0a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 20:12:34 2012 +0800

    Added test for proxy model safeguards on swappable models.

commit 280bf19e94d0d534d0e51bae485c1842558f4ff4
Merge: dbb3900 935a863
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 18:16:49 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit dbb3900775a99df8b6cb1d7063cf364eab55621a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 18:09:27 2012 +0800

    Fixes for Python 3 compatibility.

commit dfd72131d8664615e245aa0f95b82604ba6b3821
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 15:54:30 2012 +0800

    Added protection against proxying swapped models.

commit abcb027190e53613e7f1734e77ee185b2587de31
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 15:11:10 2012 +0800

    Cleanup and documentation of AbstractUser base class.

commit a9491a87763e307f0eb0dc246f54ac865a6ffb34
Merge: fd8bb4e 08bcb4a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 14:46:49 2012 +0800

    Merge commit '08bcb4aec1ed154cefc631b8510ee13e9af0c19d' into t3011

commit fd8bb4e3e498a92d7a8b340f0684d5f088aa4c92
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 14:20:14 2012 +0800

    Documentation improvements coming from community review.

commit b550a6d06d016ab6a0198c4cb2dffe9cceabe8a5
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:52:47 2012 +0800

    Refactored skipIfCustomUser into the contrib.auth tests.

commit 52a02f11107c3f0d711742b8ca65b75175b79d6a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:46:10 2012 +0800

    Refactored common 'get' pattern into manager method.

commit b441a6bbc7d6065175715cb09316b9f13268171b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:41:33 2012 +0800

    Added note about backwards incompatible change to admin login messages.

commit 08bcb4aec1ed154cefc631b8510ee13e9af0c19d
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Sep 15 18:30:33 2012 +0300

    Splitted User to AbstractUser and User

commit d9f5e5addbad5e1a01f67e7358e4f5091c3cad81
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Sep 15 18:30:02 2012 +0300

    Reworked REQUIRED_FIELDS + create_user() interaction

commit 579f152e4a6e06671e1ac1e59e2b43cf4d764bf4
Merge: 9184972 93e6733
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:18:37 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 918497218c58227f5032873ff97261627b2ceab2
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:18:19 2012 +0800

    Deprecate AUTH_PROFILE_MODULE and get_profile().

commit 334cdfc1bb6a6794791497cdefda843bca2ea57a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:00:12 2012 +0800

    Added release notes for new swappable User feature.

commit 5d7bb22e8d913b51aba1c3360e7af8b01b6c0ab6
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 19:59:49 2012 +0800

    Ensure swapped models can't be queried.

commit 57ac6e3d32605a67581e875b37ec5b2284711a32
Merge: f2ec915 abfba3b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 14:31:54 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit f2ec915b20f81c8afeaa3df25f80689712f720f8
Merge: 1952656 5e99a3d
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 08:29:51 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 19526563b54fa300785c49cfb625c0c6158ced67
Merge: 2c5e833 c4aa26a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 08:22:26 2012 +0800

    Merge recent changes from master.

commit 2c5e833a30bef4305d55eacc0703533152f5c427
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 07:53:46 2012 +0800

    Corrected admin_views tests following removal of the email fallback on admin logins.

commit 20d1892491839d6ef21f37db4ca136935c2076bf
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 01:00:37 2012 +0800

    Added conditional skips for all tests dependent on the default User model

commit 40ea8b888284775481fc1eaadeff267dbd7e3dfa
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 8 23:47:02 2012 +0800

    Added documentation for REQUIRED_FIELDS in custom auth.

commit e6aaf659708cf6491f5485d3edfa616cb9214cc0
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 8 23:20:02 2012 +0800

    Added first draft of custom User docs.

    Thanks to Greg Turner for the initial text.

commit 75118bd242eec87649da2859e8c50a199a8a1dca
Author: Thomas Sutton <me@thomas-sutton.id.au>
Date:   Mon Aug 20 11:17:26 2012 +0800

    Admin app should not allow username discovery

    The admin app login form should not allow users to discover the username
    associated with an email address.

commit d088b3af58dad7449fc58493193a327725c57c22
Author: Thomas Sutton <me@thomas-sutton.id.au>
Date:   Mon Aug 20 10:32:13 2012 +0800

    Admin app login form should use swapped user model

commit 7e82e83d67ee0871a72e1a3a723afdd214fcefc3
Merge: e29c010 39aa890
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Fri Sep 7 23:45:03 2012 +0800

    Merged master changes.

commit e29c010beb96ca07697c4e3e0c0d5d3ffdc4c0a3
Merge: 8e3fd70 30bdf22
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Aug 20 13:12:57 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 8e3fd703d02c31a4c3ac9f51f5011d03c0bd47f6
Merge: 507bb50 26e0ba0
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Aug 20 13:09:09 2012 +0800

    Merged recent changes from trunk.

commit 507bb50a9291bfcdcfa1198f9fea21d4e3b1e762
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 20:41:37 2012 +0800

    Modified auth app so that login with alternate auth app is possible.

commit dabe3628362ab7a4a6c9686dd874803baa997eaa
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 20:10:51 2012 +0800

    Modified auth management commands to handle custom user definitions.

commit 7cc0baf89d490c92ef3f1dc909b8090191a1294b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 14:17:28 2012 +0800

    Added model Meta option for swappable models, and made auth.User a swappable model
 2012-09-26 18:48:09 +08:00
Ramiro Morales
f51eab796d Fixed #18072 -- Made more admin links use reverse() instead of hard-coded relative URLs. 
Thanks kmike for the report and initial patch for the changelist->edit
object view link URL.

Other affected links include the delete object one and object history
one (in this case the change had been implemented in commit 5a9e127, this
commit adds admin-quoting of the object PK in a way similar to a222d6e.)

Refs #15294.
 2012-09-24 22:02:59 -03:00
Claude Paroz
515fd6a5de Called parent __init__ in test logging handler 2012-09-24 22:42:58 +02:00
Claude Paroz
fc69fff9ab Fixed #14861 -- Moved logging config outside of Settings.__init__ 
Thanks donspaulding for the report and simonpercivall for the
initial patch.
 2012-09-24 22:12:45 +02:00
Claude Paroz
e72e22e518 Replaced a deprecated assertEquals 2012-09-24 16:07:58 +02:00
Andrew Godwin
a589fdff81 Fix PostgreSQL failing on a test 2012-09-24 13:55:37 +01:00
Andrew Godwin
15c1920964 Only swallow table-does-not-exist errors in tests 2012-09-24 13:30:17 +01:00
Andrew Godwin
0354cecbfd Fix nullability changing code 2012-09-24 12:56:17 +01:00
Aymeric Augustin
3174b5f2f5 Fixed #18982 - Caught TypeError in DateField.clean 
Thanks gwahl at fusionbox com.
 2012-09-23 13:27:01 +02:00
Claude Paroz
8599f64e54 Fixed #18861 -- Triggered message validation with locmem email backend 
Thanks Bruno Renié for the report and the initial patch.
 2012-09-22 15:17:13 +02:00
Aymeric Augustin
822cfce3df Fixed #18951 -- Formatting of microseconds. 
Thanks olofom at gmail com for the report.
 2012-09-22 12:02:21 +02:00
Aymeric Augustin
baa33cd8fa Fixed #16218 -- date_list order in generic CBVs. 
Thanks nnrcschmdt for the report and bpeschier for the initial
version of the patch.
 2012-09-22 11:47:34 +02:00
Andrew Godwin
49d1e6b0e2 Remove AppCache state handling, replace with swappable caches 2012-09-22 00:47:04 +01:00
Claude Paroz
26ff2be787 Imported getLogger directly from logging module 
This was a remainder of some 2.4 compatibility code.
 2012-09-20 21:03:24 +02:00
Carl Meyer
4e9a74b81d Revert "Fixed #16865 -- Made get_or_create use read database for initial get query." 
Thanks to Jeremy Dunck for pointing out the problem with this change. If in a
single transaction, the master deletes a record and then get_or_creates a
similar record, under the new behavior the get_or_create would find the record
in the slave db and fail to re-create it, leaving the record nonexistent, which
violates the contract of get_or_create that the record should always exist
afterwards. We need to do everything against the master here in order to ensure
correctness.

This reverts commit 901af86550.
 2012-09-19 11:15:12 -06:00
Carl Meyer
901af86550 Fixed #16865 -- Made get_or_create use read database for initial get query. 
Thanks Rick van Hattem for the report and trbs for the patch.
 2012-09-19 10:06:53 -06:00
Jeremy Dunck
40e62a5ccd Fixed #18980 -- Fixed assertContains regression when passed an object 2012-09-18 21:05:41 +02:00
Florian Apolloner
319e135519 Fixed #18800 -- Support numbers bigger than max float in numberformat. 
Thanks to jbvsmo for the patch and Brad Pitcher for the tests.
 2012-09-18 19:43:50 +02:00
Andrew Godwin
7e8c64d8e6 Dropping pointless self.fail calls 2012-09-18 10:59:03 +01:00
Andrew Godwin
06227fbb83 Python 3 compatability. 2.6 was a while back, I should learn ' as '. 2012-09-17 23:51:48 +01:00
Florian Apolloner
23d0136314 Merge branch 'lotheac-fix_uploaded_file_exec' 2012-09-17 22:54:26 +02:00
Florian Apolloner
e8c6aff3bf Fixed #18947 -- Don't make uploaded files executeable by default. 
Thanks to Lauri Tirkkonen for the patch.
 2012-09-17 22:53:10 +02:00
Andrew Godwin
d0b3536964 More schema test fixing 2012-09-17 21:16:36 +01:00
Andrew Godwin
9313dea700 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/mysql/base.py
	django/db/backends/postgresql_psycopg2/base.py
 2012-09-17 20:00:14 +01:00
Andrew Godwin
dbf8b93c52 Fix app loading/test interaction 2012-09-17 19:57:23 +01:00
Florian Apolloner
a630d08483 Merge pull request #360 from calebsmith/add-permalink-wraps-test 
Ticket #12836 - Added a test to assure permalink wraps method attributes
 2012-09-16 14:00:51 -07:00
Anssi Kääriäinen
f399a804c9 Fixed #17485 regression -- only + select_related interaction 
When doing deeper than one level select_related() + only queries(), the
code introduced in b6c356b7bb errored
incorrectly.

Thanks to mrmachine for report & test case.
 2012-09-16 22:58:40 +03:00
Julien Phalip
c555741aa7 Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report. 2012-09-15 16:20:56 -07:00
Claude Paroz
b1fb6f4820 Modernized views.DebugViewTests 2012-09-15 21:07:42 +02:00
Claude Paroz
859aa2a6c4 Fixed #18790 -- Encoded database password on Python 2 
Thanks thcourbon@gmail.com for the report.
 2012-09-12 10:16:49 +02:00
Claude Paroz
f1bdfbd24b Document and test 'type' usage in Widget attrs 
Refs #16630.
 2012-09-10 19:31:11 +02:00
Karen Tracey
2e92858386 Fixed a couple of test failures on Windows. 2012-09-09 15:07:04 -04:00
Carl Meyer
a3b2136b28 Remove an outdated import inadvertently introduced in tests. 2012-09-08 18:22:03 -06:00
Carl Meyer
a78dd109e6 Fixed #15552 -- LOGIN_URL and LOGIN_REDIRECT_URL can take URLpattern names. 
Thanks UloPe and Eric Florenzano for the patch, and Malcolm Tredinnick for
review.
 2012-09-08 16:58:35 -06:00
Carl Meyer
307706d082 Fixed #18545 -- Make the 'no DJANGO_SETTINGS_MODULE' error message more useful.Thanks Nick Coghlan for the report, and Malcolm Tredinnick for review. 2012-09-08 14:26:33 -06:00
Travis Swicegood
4754f122dd Moved the admin inline JS to new JS files for cleanliness. 2012-09-08 15:09:37 -04:00
Caleb Smith
210fd7c658 refs #12836 - Added a test to assure permalink wraps method attributes 2012-09-08 11:58:48 -04:00
Travis Swicegood
ccd1bb0d81 Remove Admin's swallowing of AttributeError (#16655, #18593, #18747) 
During the new-admin changes, catching of AttributeError was added to
the admin.  This patch removes that as it's no longer possible to add a
value to a ModelAdmin that is not available.  Adding an attribute that
can not be called causes an ImproperlyConfigured exception to be raised.
 2012-09-08 11:20:05 -04:00
Aymeric Augustin
9b07b5edeb Fixed #18916 -- Allowed non-ASCII headers. 
Thanks Malcolm Tredinnick for the review.
 2012-09-07 19:08:57 -04:00
Alex Gaynor
b865009d41 Fixed #12397 -- allow safe_join to work with the root file system path, which means you can have your root template or file upload path at this location. You almost certainly don't want to do this, except in *very* limited sandboxed situations. 2012-09-07 16:49:22 -04:00
Andrew Godwin
828d691f62 Merge branch 'master' into schema-alteration 2012-09-07 15:43:28 -04:00
Andrew Godwin
ca9c3cd39f Add check constraint support - needed a few Field changes 2012-09-07 15:40:59 -04:00
Alex Gaynor
5999eb42eb Removed another usage of the bear "except:" (rawr!). 2012-09-07 15:34:48 -04:00
Alex Gaynor
335a9f9cf1 Removed many uses of bare "except:", which were either going to a) silence real issues, or b) were impossible to hit. 2012-09-07 15:08:07 -04:00
Andrew Godwin
375178fc19 Add M2M repointing 2012-09-07 14:39:22 -04:00
Alex Gaynor
6a5a12ea3e Fixed #17888 -- no longer silence exceptions inside of check_test. Thanks to brutasse for the patch. 2012-09-07 14:37:21 -04:00
Alex Gaynor
a92b81b0e8 Fixed tests that I broke a few commits ago. 2012-09-07 14:01:46 -04:00
Alex Gaynor
f47af9df1d Cleaned up several test cases, to better isolate state. 2012-09-07 13:47:12 -04:00
Andrew Godwin
a92bae0f06 Repoint ForeignKeys when their to= changes. 2012-09-07 13:31:05 -04:00
Alex Gaynor
292322f977 [py3k] Silence many warnings while running the tests. 2012-09-07 13:17:34 -04:00
Andrew Godwin
d683263f97 Added SQLite backend which passes all current tests 2012-09-07 12:51:11 -04:00
Alex Gaynor
0e296131bb Cleaned up some small bits of the ORM, including removing an import *. 2012-09-07 10:58:17 -04:00
Aymeric Augustin
5262a288df Fixed #18687: Removed test_performance_scalability 
Even after repeated adjustment of the constants, this test still fails
randomly. It has educated us to ignore messages from Jenkins, to a
point where we missed some actual failures. In addition, it accounts
for a non-negligible percentage of the run time of the test suite
just by itself. Since no one has proposed a convincing patch in months,
I'm going to remove the patch. We can't keep a randomly failing test
forever.
 2012-09-05 23:02:33 -04:00
Andrew Godwin
b546e7eb63 Merge branch 'master' into schema-alteration 2012-09-05 09:39:03 -04:00
Andrew Godwin
cd583d6dbd Implement primary key changing 2012-09-04 12:53:31 -04:00
Claude Paroz
22f85b9057 Fixed #18824 -- Allow deleting a setting from overriden settings 2012-09-04 09:41:12 +02:00
Claude Paroz
cc9b767fc6 Fixed #18902 -- Made force_bytes properly handle exception input 
Thanks Aymeric Augustin for the report and the initial patch.
 2012-09-04 09:27:28 +02:00
Claude Paroz
28fd876bae Fixed #17892 -- Do not include whole RegexURLPattern lists in RegexURLResolver repr 
Thanks milosu for the report and the initial patch.
 2012-09-01 22:20:46 +02:00
Claude Paroz
306d34873c Fixed #18212 -- Standardized arguments of GenericIPAddressField 
Unlike other model fields, the newly introduced (1.4)
GenericIPAddressField did not accept verbose_name and name as the
first positional arguments. This commit fixes it.
Thanks Dan McGee for the report and the patch.
 2012-09-01 18:38:55 +02:00
Andrew Godwin
d865503389 db_index alteration mostly working 2012-08-30 23:11:56 +01:00
Claude Paroz
879b245baa Fixed #5725 -- Fixed varchar column size introspection for MySQL 
Thanks ferdonline for the initial patch and Karen Tracey for the
related post on django-users.
 2012-08-30 19:28:13 +02:00
Claude Paroz
4e70ad11d2 Made FileSystemStorage accept both text and byte streams 
Thanks Alexey Boriskin for his help on the patch.
 2012-08-29 16:37:37 +02:00
Claude Paroz
b5240d25c1 Removed unnecessary bytes prefix for ContentFile 2012-08-29 11:32:18 +02:00
Claude Paroz
361d6738f8 Fixed #11739 -- Made ContentFile support Unicode input 2012-08-29 11:21:33 +02:00
Claude Paroz
ebc773ada3 Replaced many smart_bytes by force_bytes 
In all those occurrences, we didn't care about preserving the
lazy status of the strings, but we really wanted to obtain a
real bytestring.
 2012-08-29 11:20:32 +02:00
Florian Apolloner
9eafb6592e [py3] Fixed test failures introduced in 3afb5916b2. 2012-08-29 00:04:34 +02:00
Florian Apolloner
3afb5916b2 Fixed #18091 -- Non-ASCII templates break django-admin.py startproject --template=TEMPLATE. 
Thanks to Claude Huchet and Tomáš Ehrlich for the patch.
 2012-08-28 23:23:07 +02:00
Ramiro Morales
5a9e127efc Made model instance history admin view link not hard-coded. Refs #15294. 2012-08-26 17:54:49 -03:00
Aymeric Augustin
28ea4d4b07 Fixed #18852 -- Restored backwards compatibility 
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec918].
 2012-08-25 22:22:32 +02:00
Anssi Kääriäinen
01b9c3d519 Fixed #16715 -- Fixed join promotion logic for nested nullable FKs 
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.

The basic structure for this problem was:
  A -[nullable]-> B -[nonnull]-> C

And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.

The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
   a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.

Sebastian reported this problem and did also major portions of the
patch.
 2012-08-25 14:14:45 +03:00
Claude Paroz
f5ea730dac Fixed #18843 -- Replaced more special chars in column names (inspectdb) 
Thanks airstrike for the report.
 2012-08-23 22:59:45 +02:00
Claude Paroz
395c6083af Fixed #12460 -- Improved inspectdb handling of special field names 
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
 2012-08-23 21:46:57 +02:00
Alexey Boriskin
10d32072af Fixed #18798 -- Renamed conflicting test methods in i18n tests 2012-08-23 11:27:56 +02:00
Claude Paroz
44c09de555 Fixed #18678 -- HttpResponse init arguments allowed for subclasses 
Thanks hp1337@gmail.com for the report.
 2012-08-23 10:59:22 +02:00
Claude Paroz
7cfe8e8fce Fixed #11340 -- Prevented HttpResponseNotModified to have content/content-type 
The HTTP 1.1 spec tells that the 304 response MUST NOT contain a
message body.
Thanks aparajita for the report.
 2012-08-22 20:55:24 +02:00
Simon Meers
dfe63a52ef Revert "Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2" 
This reverts commit 3fce0d2a91.
 2012-08-22 11:48:47 +10:00
Claude Paroz
4353a6163c Fixed #18196 -- Improved loaddata error messages. 2012-08-21 21:52:25 +02:00
Anssi Kääriäinen
a193372753 Fixed #17886 -- Fixed join promotion in ORed nullable queries 
The ORM generated a query with INNER JOIN instead of LEFT OUTER JOIN
in a somewhat complicated case. The main issue was that there was a
chain of nullable FK -> non-nullble FK, and the join promotion logic
didn't see the need to promote the non-nullable FK even if the
previous nullable FK was already promoted to LOUTER JOIN. This resulted
in a query like a LOUTER b INNER c, which incorrectly prunes results.
 2012-08-21 21:23:57 +03:00
Aymeric Augustin
e89bc39935 Reverted type check added in 62954ba04c. 
Refs #17040.
 2012-08-21 09:00:55 +02:00
Aymeric Augustin
62954ba04c [py3] Fixed #17040 -- ported django.utils.crypto.constant_time_compare. 
This is a private API; adding a type check is acceptable.
 2012-08-20 22:50:49 +02:00
Simon Meers
3fce0d2a91 Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2 
Thanks guettli and mrmachine.
 2012-08-20 16:47:30 +10:00
Aymeric Augustin
9729f77326 Reordered import statements for clarity. 2012-08-19 21:50:07 +02:00
Aymeric Augustin
2f59e94a41 Fixed #18728 -- Made colon optional in tzinfo 
Made two-digit hours and minutes mandatory in tzinfo (the code used
to crash if a one-digit representation was provided).

Added standalone tests for django.utils.dateparse.
 2012-08-19 21:47:41 +02:00
Aymeric Augustin
536b030363 [py3] Supported integers in HttpResponse 
Fixed #18764.
 2012-08-19 16:38:21 +02:00
Karen Tracey
e945842042 Merge pull request #291 from uruz/ticket18793 
Fixed #18793: Removed duplicate test_head_no_get in generic_views.base

Thanks uruz.
 2012-08-18 17:12:54 -07:00
Alexey Boriskin
f29032eac6 Fixed #18793: Duplicate test test_head_no_get in generic_views.base 2012-08-19 01:04:08 +04:00
Andrew Godwin
5b09fc8ad2 Merge pull request #288 from mjtamlyn/date-list-period 
Fixed #3542 -- Add support for changing granularity on ArchiveView.
 2012-08-18 09:10:52 -07:00
Marc Tamlyn
8d5c11caad Fixed #3542 -- Add support for changing granularity on ArchiveView. 
Resolving the concept from a very old ticket in a more class-based-view
manner.
 2012-08-18 17:03:57 +01:00
Aymeric Augustin
afc1bd7ab8 [py3] Made 212b9826bd Python 3-friendly 2012-08-18 17:51:16 +02:00
Marc Tamlyn
f04bb6d798 Fixed #17228 -- params context variable is inconsistent 
Remove the params variable from the context and just put the variables
in directly.

This had not been committed previously as the original pattern was used
in the functional generic views and we wanted consistency between them,
but django.views.generic.simple.direct_to_template is now gone so we can
do it 'right'.
 2012-08-18 15:07:21 +01:00
Marc Tamlyn
212b9826bd Fixed #14516 -- Extract methods from removetags and slugify template filters 
Patch by @jphalip updated to apply, documentation and release notes
added.

I've documented strip_tags as well as remove_tags as the difference
between the two wouldn't be immediately obvious.
 2012-08-18 15:07:21 +01:00
Marc Tamlyn
58683e9c82 Fixed #16744 -- Class based view should have the view object in the context 
Updated the most recent patch from @claudep to apply again and updated
the documentation location.
 2012-08-18 15:07:21 +01:00
Aymeric Augustin
547b181046 [py3] Ported django.utils.safestring. 
Backwards compatibility aliases were created under Python 2.
 2012-08-18 16:04:06 +02:00
Andrew Godwin
d3d1e59921 Add a SQlite backend. One test passes! 2012-08-18 14:16:52 +01:00
Andrew Godwin
0b01395108 Test that unique constraints get ported with column rename 2012-08-18 14:00:42 +01:00
Andrew Godwin
f7955c703d All tests passing on MySQL 2012-08-18 13:48:54 +01:00
Andrew Godwin
cab044c66c First stab at MySQL support 2012-08-18 12:29:31 +01:00
Marc Tamlyn
bfa9fc69bf Fixed #18779 -- URLValidator can't validate url with ipv6. 
Validation is reasonably 'soft', as for the ipv4. False positives don't
matter too much here.
 2012-08-18 12:08:44 +01:00
Aymeric Augustin
85e7a5e140 [py3] Stopped attempting to translate bytes. 
That goes actively against the goal of cleaning string handling.
 2012-08-18 11:36:09 +02:00
Aymeric Augustin
c03cf0b096 Cleaned up a test slightly. 
We should catch all exceptions in the thread to ensure it doesn't die
with an unhandled exception. The type of the exception is already
checked further in the test.
 2012-08-18 11:02:28 +02:00
Aymeric Augustin
6cb76cb140 [py3] Fixed templates tests. 2012-08-18 10:18:24 +02:00
Aymeric Augustin
ad11dbf670 [py3] Fixed __unicode__ methods missed in d4a0b278 
due to non-standard syntax (a stray comma). Thanks dmishe for the report.
 2012-08-17 14:11:23 +02:00
Alex Gaynor
37a894b48c [py3k] Fixed pagination_regress tests. 2012-08-16 10:54:45 -04:00
Aymeric Augustin
fcc8de0598 [py3] Ported django.core.servers. 2012-08-16 13:01:16 +02:00
Aymeric Augustin
8c356acf2e [py3] Fixed test_utils tests of doctests. 2012-08-16 10:26:18 +02:00
Aymeric Augustin
e98cb05edf [py3] Fixed the str tests. 
These tests don't look very meaningful. They were ported from
doctests...
 2012-08-16 09:44:42 +02:00
Alex Gaynor
befa1dd7a5 Fixed the generic_inline_admin tests for python3. 2012-08-15 23:12:08 -04:00
Alex Gaynor
0c257f5a23 Fixed the admin_changelist tests for python3. 2012-08-15 23:09:01 -04:00
Claude Paroz
24de85c419 [py3] Fixed more encoding issues in cache tests 2012-08-15 22:48:09 +02:00
Claude Paroz
37e05357cd Used settings config for memcached tests. 
By using settings config, we take advantage of custom settings like
KEY_PREFIX which allows for example to run tests in parallel.
 2012-08-15 22:48:09 +02:00
Aymeric Augustin
f7c2e82d76 [py3] Fixed middleware tests. 
Removed several inappropriate .encode('utf-8') calls in the process.
 2012-08-15 22:42:18 +02:00
Claude Paroz
60f5e10230 [py3] Fixed dispatch tests 2012-08-15 18:19:21 +02:00
Claude Paroz
27192564c3 Run memcache tests if any cache is configured 2012-08-15 18:07:03 +02:00
Claude Paroz
a9facb455f [py3] Fix some more encoding issues in tests 2012-08-15 17:41:38 +02:00
Claude Paroz
607665a396 [py3] Fixed bad unicode test 2012-08-15 16:40:12 +02:00
Florian Apolloner
0ab570217a [py3] Fixed paginator tests. 2012-08-15 14:58:43 +02:00
Florian Apolloner
c1584890b1 [py3] Properly encode hashlib.md5 and zip.compress args in the tests. 2012-08-15 14:29:40 +02:00
Anssi Kääriäinen
5d01f3caea [py3] Removed map() calls used for side-effects only 2012-08-15 13:23:41 +03:00
Alex Gaynor
814fde32d9 Made the validation tests python3 friendly. 2012-08-15 03:02:32 -07:00
Alex Gaynor
ea1e8b38b3 Ensured that the archive module consistantly explicitly closed all files. 2012-08-15 02:53:40 -07:00
Alex Gaynor
ca6015ca71 Close files in the module_loading tests always. 2012-08-15 02:47:02 -07:00
Alex Gaynor
fc99f127d8 Explicitly close a file during the email tests. 2012-08-15 02:16:28 -07:00
Alex Gaynor
dfbcbf2124 Always close files in the file_storage tests. 2012-08-15 02:05:03 -07:00
Claude Paroz
e0d67f3440 [py3] Fixed test_client_regress tests 2012-08-15 10:58:26 +02:00
Alex Gaynor
cca01c96d1 Converted the modeladmin tests to run on python 2 and 3. 2012-08-15 01:46:31 -07:00
Alex Gaynor
54afdbf378 Fixed usage of several deprecated aliases in unittest. 2012-08-15 01:38:04 -07:00
Alex Gaynor
2048bbee8c Explicitly close files in the staticfiles tests. 2012-08-15 01:25:01 -07:00
Alex Gaynor
c7734491f8 Use a name that exists in both python2 and 3, 2012-08-15 01:13:09 -07:00
Aymeric Augustin
e0ec7507ac [py3] Fixed jsi18n test. 
Also refactored said test to avoid leaking state (ie. active
translation) when an error occurs.
 2012-08-15 09:45:28 +02:00
Aymeric Augustin
478a69314e [py3] Fixed uses of __metaclass__ in tests. 2012-08-15 00:31:29 +02:00
Chris Lawlor
450c0df653 [py3] Fixed modeltests.model_forms tests. 2012-08-14 23:46:23 +02:00
Claude Paroz
928baee747 [py3] Fixed conditional_processing tests 2012-08-14 23:35:12 +02:00
Claude Paroz
0120985095 [py3] Fixed file_uploads tests 2012-08-14 23:35:12 +02:00
Florian Apolloner
367bfaa522 Don't swallow AttributeError in core.urlresolvers.get_callable. 2012-08-14 21:23:25 +02:00
Claude Paroz
f2fe7a3e36 [py3] Fixed serializers tests 2012-08-14 19:54:53 +02:00
Claude Paroz
7d48e077b5 [py3] Fixed staticfiles tests 2012-08-14 17:24:31 +02:00
Claude Paroz
c2d59e5564 [py3] Fixed admin_views tests 
Also changed several occurrences of 'request' to 'response'.
 2012-08-14 14:45:28 +02:00
Aymeric Augustin
d6b8b125fb [py3] Fixed admin_custom_urls tests. 2012-08-14 14:38:23 +02:00
Anssi Kääriäinen
5b27e6f64b [py3] Fixed comparison of list and range() 
A test compared list directly against a range(). This is py3
incompatible. Fixed by using list(range()).
 2012-08-14 15:28:55 +03:00
Anssi Kääriäinen
8fe03865f7 [py3] Fixed invalid use of dict.items() 
An ordering test had two problems related to dict.items() usage:
  - It assumed the order of the dict was non-randomized
  - It indexed to the dict.items() which is py3 incompatible.

I fixed the test by using dict['rank'] directly, where rank is the
column tested on the values queryset.
 2012-08-14 15:24:43 +03:00
Aymeric Augustin
dcf72835e3 [py3] Ensured the template tests run. 2012-08-14 12:29:53 +02:00
Aymeric Augustin
faf570df18 [py3] Compared response.content with bytes. 2012-08-14 12:29:53 +02:00
Aymeric Augustin
e04230e2e4 [py3] Ported django.http according to PEP 3333. 
Perfomed some style cleanup while I was in the area.
 2012-08-14 10:32:16 +02:00
Claude Paroz
45baaabafb [py3] Fixed encoding issues in cache key generation 2012-08-13 12:56:59 +02:00
Claude Paroz
d774ad752d [py3] Made csrf context processor return Unicode 2012-08-13 11:54:21 +02:00
Claude Paroz
73f0f18c8f [py3] Fixed admin_scripts tests 2012-08-13 10:58:21 +02:00
Claude Paroz
6d68022a27 [py3] Removed filename encoding in file_uploads test 2012-08-13 09:56:14 +02:00
Andrei Antoukh
99321e30ce Fixed #18306 -- Made deferred models issue update_fields on save 
Deferred models now automatically update only the fields which are
loaded from the db (with .only() or .defer()). In addition, any field
set manually after the load is updated on save.
 2012-08-12 22:39:27 +03:00
Anssi Kääriäinen
59a655988e Fixed #13844 -- Avoid converting unknown db values to float 
This patch removes an unconditional float(value) conversion from db
backend default convert_values() method. This can cause problems when
aggregating over character fields for example. In addition, Oracle
and SQLite already return the bare value from their convert_values().

In the long term the converting should be done by fields, and the
fields should then call database backend specific converters when
needed. The current setup is inflexible for 3rd party fields.

Thanks to Merlijn van Deen for the original patch.
 2012-08-12 21:52:52 +03:00
Karen Tracey
49bb72c403 [py3] Made exception examination py3-compatible. 2012-08-12 12:08:58 -04:00
Aymeric Augustin
d4a0b27838 [py3] Refactored __unicode__ to __str__. 
* Renamed the __unicode__ methods
* Applied the python_2_unicode_compatible decorator
* Removed the StrAndUnicode mix-in that is superseded by
  python_2_unicode_compatible
* Kept the __unicode__ methods in classes that specifically
  test it under Python 2
 2012-08-12 14:44:40 +02:00
Aymeric Augustin
e7e08fd48b [py3] Replaced some __str__ methods by __unicode__ 
These methods actually return unicode.
 2012-08-12 14:44:40 +02:00
Aymeric Augustin
2bb2eecb63 [py3] Removed redundant __str__ methods. 
These classes already have an identical __unicode__ method, which
will be used after an upcoming refactoring.
 2012-08-12 14:44:40 +02:00
Karen Tracey
759ae3c2da Fixed #18739 -- witdthratio behavior on None args 
Made behavior given None consistent with how non-numerics were handled.
Thanks to ja.geb@me.com for the report.
 2012-08-11 19:24:18 -04:00
Karen Tracey
be7f1099c6 Decorated some tests that require tz support. 
This allows the test suite to run without errors on Windows.
 2012-08-11 17:32:24 -04:00
Claude Paroz
6602103338 [py3] Various minor syntax fixes in the test suite 2012-08-11 23:23:31 +02:00
Claude Paroz
3eb28d0119 [py3] Used six.StringIO to simulate stdout buffer in tests 2012-08-11 18:56:14 +02:00
Claude Paroz
97fe70d30b [py3] Used BytesIO to test request streams 2012-08-11 11:11:20 +02:00
Claude Paroz
92b2dec918 [py3] Made signing infrastructure pass tests with Python 3 2012-08-10 18:07:46 +02:00
Andrew Godwin
60873ea2ad Add db_table and db_tablespace handling 2012-08-10 15:03:18 +01:00
Andrew Godwin
184cf9ab79 Merge branch 'master' into schema-alteration 2012-08-10 12:40:37 +01:00
Andrew Godwin
c4b2a3262c Add support for unique_together 2012-08-10 12:38:18 +01:00
Claude Paroz
751774c29f [py3] Fixed mail tests with Python 3 2012-08-09 20:13:29 +02:00
Claude Paroz
96a6912ec5 [py3] Fixed compilemessages tests 2012-08-08 23:40:20 +02:00
Alex Gaynor
0955d16a16 Switched to using the standard method for comparing querysets in teh templates. 2012-08-08 07:50:59 -07:00
Aymeric Augustin
396357741b [py3] Used compatible imports of StringIO. 2012-08-08 14:50:01 +02:00
Alex Gaynor
46cc530fad Fix a test that relied on an exception outliving the except block, which doesn't happen on py3k. 2012-08-07 07:22:25 -07:00
Aymeric Augustin
fe8484efda [py3] Ported django.utils.functional. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
02e6b6409b [py3] Ported django.utils.decorators. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
127b461b11 [py3] Ported django.utils.crypto. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
b55e07771f [py3] Ported django.utils.baseconv. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
c5ef65bcf3 [py3] Ported django.utils.encoding. 
* Renamed smart_unicode to smart_text (but kept the old name under
  Python 2 for backwards compatibility).
* Renamed smart_str to smart_bytes.
* Re-introduced smart_str as an alias for smart_text under Python 3
  and smart_bytes under Python 2 (which is backwards compatible).
  Thus smart_str always returns a str objects.
* Used the new smart_str in a few places where both Python 2 and 3
  want a str.
 2012-08-07 12:00:22 +02:00
Aymeric Augustin
ee191715ea [py3] Fixed access to dict keys/values/items. 2012-08-07 12:00:22 +02:00
Brendan MacDonell
ad237fb72f Fixed #18724 -- Fixed IntegerField validation with value 0 2012-08-06 10:42:21 +02:00
Claude Paroz
121fd109de Fixed #5524 -- Do not remove cleaned_data when a form fails validation 
cleaned_data is no longer deleted when form validation fails but only
contains the data that did validate.
Thanks to the various contributors to this patch (see ticket).
 2012-08-04 14:22:23 +02:00
Simon Meers
10f979fd92 Fixed #18700 -- Added URL reversal for i18n set_language view. 2012-08-04 20:57:12 +10:00
Aymeric Augustin
d01eaf7104 [py3] Removed uses of sys.maxint under Python 3. 
Also fixed #18706: improved exceptions raised by int_to_base36.
 2012-08-03 18:51:28 +02:00
Andrew Godwin
b139315f1c Add M2M tests and some unique support 2012-08-02 15:08:39 +01:00
Florian Apolloner
4129201c3e Fixed a security issue in http redirects. Disclosure and new release forthcoming. 2012-07-30 22:01:50 +02:00
Andrew Godwin
4a2e80fff4 Merge branch 'master' of github.com:django/django into schema-alteration 
Conflicts:
	django/db/backends/postgresql_psycopg2/base.py
 2012-07-26 18:58:10 +01:00
Aymeric Augustin
ab6cd1c839 [py3] Updated dict-like data structures for Python 3. 
The keys/items/values methods return iterators in Python 3, and the
iterkeys/items/values methods don't exist in Python 3. The behavior
under Python 2 is unchanged.
 2012-07-25 22:58:48 +02:00
Marc Tamlyn
a875f612e0 Fixed #18634 -- Don't escape variables in the context for startproject/startapp. 
The & symbols which can come up in the secret key were
being escaped to &amp;.
 2012-07-25 22:24:41 +02:00
Florian Apolloner
59d99772f0 Merge pull request #216 from ljosa/ticket_18644 
Fixed #18644 -- Made urlize trim trailing period followed by parenthesis
 2012-07-25 13:22:49 -07:00
Florian Apolloner
82292141a0 Made staticfiles tests independent of test execution order. 2012-07-25 10:00:23 +02:00
Ramiro Morales
f758bdab5e Fixed #18271 -- Changed stage at which TransactionTestCase flushes DB tables. 
Previously, the flush was done before the test case execution and now
it is performed after it.

Other changes to the testing infrastructure include:

* TransactionTestCase now doesn't reset autoincrement sequences either
  (previous behavior can achieved by using `reset_sequences`.)
  With this, no implicit such reset is performed by any of the provided
  TestCase classes.

* New ordering of test cases: All unittest tes cases are run first and
  doctests are run at the end.

THse changes could be backward-incompatible with test cases that relied
on some kind of state being preserved between tests. Please read the
relevant sections of the release notes and testing documentation for
further details.

Thanks Andreas Pelme for the initial patch. Karen Tracey and Anssi
Kääriäinen for the feedback and Anssi for reviewing.

This also fixes #12408.
 2012-07-24 17:24:16 -03:00
Alex Gaynor
38ce709fe4 Added tests for deprecation warnings and fixed the argument order for the warnings. 2012-07-24 07:01:57 -07:00
Aymeric Augustin
a84d79f572 [py3] Added Python 3 compatibility for xrange. 2012-07-22 09:29:56 +02:00
Aymeric Augustin
0d914d08a0 [py3] Updated urllib/urllib2/urlparse imports. 
Lots of functions were moved. Use explicit imports in all cases
to keey it easy to identify where the functions come from.
 2012-07-22 09:29:55 +02:00
Aymeric Augustin
bdca5ea345 [py3] Replaced unicode/str by six.text_type/bytes. 2012-07-22 09:29:54 +02:00
Aymeric Augustin
3cb2457f46 [py3] Replaced basestring by six.string_types. 2012-07-22 09:29:54 +02:00
Aymeric Augustin
cacd845996 [py3] Fixed remaining Python 3 syntax errors. 
django.utils.unittest.* weren't touched -- they're only imported on Python 2.6.
 2012-07-22 09:29:53 +02:00
Aymeric Augustin
56dbe924a6 [py3] Removed longs. 2012-07-22 09:29:53 +02:00
Julien Phalip
01c392623d Fixed #10057 -- Ensured that the 'show_delete' context variable in the admin's change view actually controls the display of the delete button. Thanks to rajeesh for the report, to patcoll for the patch, and to David Gouldin for the test. 2012-07-21 18:10:24 -07:00
Julien Phalip
1af0271d7c Fixed #6170 -- Ensured that a useful exception is raised when a regex is invalid in the URLConf. 
Thanks to abrahamson.j for the report, to guettli for initial work on the patch, and to David Gouldin for the new patch and test.
 2012-07-21 13:30:34 -07:00
Claude Paroz
9ecd978e26 Re-added Windows line ending stripped in previous commit 
Thanks Aymeric Augustin for noticing the issue.
 2012-07-21 15:38:28 +02:00
Claude Paroz
423244bc6b Fixed #4680 -- Improved initial_sql parsing 
In particular, allow the '--' sequence to be present in string
values without being interpreted as comment marker.
Thanks Tim Chase for the report and shaleh for the initial patch.
 2012-07-21 14:24:29 +02:00
Aymeric Augustin
324d48d0a7 Switched to Python 3-compatible octal notation. 2012-07-20 13:28:36 +02:00
Aymeric Augustin
85cd458944 Removed u prefixes on unicode strings. 
They break Python 3.
 2012-07-20 12:29:22 +02:00
Claude Paroz
c54905b359 Fixed #18479 -- Stopped makemessages raising error on gettext warnings 
Thanks Niels Busch for the initial patch.
 2012-07-18 20:43:35 +02:00
Mike Grouchy
a2e927b7ed BaseCache now has a no-op close method as per ticket #18582 
Also removed the hasattr check when firing request_finished signal for
caches with a 'close' method. Should be safe to call `cache.close`
everywhere now
 2012-07-18 14:16:55 -04:00
Claude Paroz
23f94f0741 Fixed #18561 -- Made HttpResponse.tell() support non-ascii chars 2012-07-17 22:00:54 +02:00
Vebjorn Ljosa
d5012d6371 Fixed #18644 -- Made urlize trim trailing period followed by parenthesis 2012-07-17 12:44:02 -04:00
Anssi Kääriäinen
29132ebdef Fixed #17788 -- Added batch_size argument to qs.bulk_create() 
The qs.bulk_create() method did not work with large batches together
with SQLite3. This commit adds a way to split the bulk into smaller
batches. The default batch size is unlimited except for SQLite3 where
the batch size is limited to 999 SQL parameters per batch.

Thanks to everybody who participated in the discussions at Trac.
 2012-07-17 15:24:41 +03:00
Anssi Kääriäinen
fcad6c48f0 Fixed #17497 -- Corrected FieldError message in add_fields() 
The erroneous message was user visible in values_list() calls.

Thanks to ojii for report and review, and to antoviaque for the patch.
 2012-07-17 12:49:46 +03:00
Nuno Maltez
bebbbb7af0 Fixed #18056 - Cleared aggregations on DateQuery.add_date_select 
Cleared aggregations on add_date_select method so only distinct dates
are returned when dealing with a QuerySet that contained aggregations.
That would cause the query set to return repeated dates because it
would look for distinct (date kind, aggregation) pairs.
 2012-07-16 19:52:31 +03:00
Anssi Kääriäinen
34340517fc Avoid using a column named "date" in tests 
Oracle can have problems with such columns. Fixed #17932 again.
Thanks to Vinay Sajip for the report.
 2012-07-15 12:30:27 +03:00
Alex Gaynor
c57abd3c29 Remove DotExpandedDict, which was undocumented and unused. 2012-07-14 19:04:37 -07:00
Alex Gaynor
8f002867b2 Cleaned up the QueryDict implementation. 
- Use super().
- Don't poke at internals.
- Don't override methods for no reason.
 2012-07-14 14:07:11 -07:00
Claude Paroz
d9db1d3373 Added supplementary check for CUIT number of ar localflavor 
Thanks Kevin Schaul for the initial patch.
 2012-07-09 14:10:54 +02:00
Claude Paroz
1d2982362d Fixed #18537 -- Fixed CUIT calculation in ar localflavor 
Thanks mmoya at 8ksoft.com.ar for the report and Kevin Shaul for the
initial patch.
 2012-07-09 14:10:54 +02:00
Jannis Leidel
1aa0d8ac4d Fixed #18487 -- Made sure that protocol-relative URLs aren't processed by the cached staticfiles storage. Thanks to LukaszBalcerzak for the patch. 2012-07-08 18:25:12 +02:00
Jannis Leidel
3047981517 Fixed #18050 -- Fixed a rather glaring bug in the handling of @import statements when using the cached staticfiles storage. 2012-07-08 18:17:53 +02:00
Jannis Leidel
3727f6d096 Fixed #18430 -- Use the FILE_CHARSET setting when reading from a file during post processing with the cached staticfiles storage. Thanks to Brant Young for initial debugging. 2012-07-08 12:56:49 +02:00
Jannis Leidel
0a68a2994b Fixed #18254 -- Added ability to the static template tags to store the result in a contextt variable. Many thanks to Andrei Antoukh for the initial patch. 2012-07-07 15:30:25 +02:00
Claude Paroz
86eb606b88 Used skipIf decorator to skip image tests when PIL is not available 2012-07-06 11:20:07 +02:00
Andrei Antoukh
0f49b2bce2 Fixed #18362 - Made model.save() update_fields accept attnames 2012-07-05 16:43:28 +03:00
Luke Plant
b0eee0ba4b Removed various unnecessary instances of mark_safe applied to URLs 
Also fixed some test breakages introduced in last commit
 2012-07-03 22:20:12 +01:00
Luke Plant
bee498f3a2 Added 'format_html' utility for formatting HTML fragments safely 2012-07-03 22:20:12 +01:00
Claude Paroz
cf731a543e Fixed widget parent class in generic_relations test 2012-07-03 11:57:15 +02:00
Anssi Kääriäinen
925a6936b9 Stylistic cleanup of Postgres autocommit tests 
Cleaned up tests introduced in f572ee0c65.

Thanks to Claude Paroz for suggesting the changes.
 2012-07-03 10:22:13 +03:00
Julien Phalip
2cd4cf58d3 Fixed #18550 -- Ensured that the admin history view works with escaped primary keys. 
Thanks to josh.oosterman for the report and patch.
 2012-07-01 18:40:50 -07:00
Anssi Kääriäinen
e74787391e Fixed a regression introduced in where.as_sql() refactor 
At least Oracle needs parentheses in negated where conditions, even if
there is only single condition negated. Fixed this by reverting to old
logic in that part of as_sql() and adding a comment about this.

I did not investigate why the parentheses are needed. The original
offending commit was bd283aa844.
 2012-07-01 22:52:35 +03:00
Anssi Kääriäinen
f572ee0c65 Fixed #16047 -- Restore autocommit state correctly on psycopg2 
When the postgresql_psycopg2 backend was used with DB-level autocommit
mode enabled, after entering transaction management and then leaving
it, the isolation level was never set back to autocommit mode.

Thanks brodie for report and working on this issue.
 2012-07-01 19:36:43 +03:00
Anssi Kääriäinen
da573fbb41 Fixed some locations to work with autocommit=True 
- backends: supports_transactions()
 - select_for_update tests
 2012-07-01 19:27:36 +03:00
Anssi Kääriäinen
bd283aa844 Refactored the empty/full result logic in WhereNode.as_sql() 
Made sure the WhereNode.as_sql() handles various EmptyResultSet and
FullResultSet conditions correctly. Also, got rid of the FullResultSet
exception class. It is now represented by '', [] return value in the
as_sql() methods.
 2012-07-01 17:21:34 +03:00
Claude Paroz
deed192dda Removed usage of mimetype kwarg of HttpResponse 
Refs #16519.
 2012-06-30 21:19:07 +02:00
Claude Paroz
47da7b7a9a Fixed #18102 -- Defined min/max_length on French localflavor form fields 
Thanks mothsART for the report and the initial patch.
 2012-06-30 13:18:07 +02:00
Claude Paroz
26cb227cfe Fixed #15197 -- Fixed yaml serialization into HttpResponse 
Thanks fourga38 for the report and hirokiky at gmail.com for the
initial patch.
 2012-06-28 16:29:29 +02:00
Josh Smeaton
fa182e8ae8 Fixed #18465 -- Set date formats correctly on Oracle 
Correctly configure NLS_SESSION_PARAMETERS to format Date and DateTime
on Oracle backend.

Thanks to Josh Smeaton for report & patch.
 2012-06-26 19:39:14 +03:00
Claude Paroz
05d333ba3b Fixed #18515 -- Conditionally regenerated filename in FileField validation 
When a FileField value has been saved, a new validation should not
regenerate a new filename when checking the length. Refs #9893.
 2012-06-26 18:18:44 +02:00
Anssi Kääriäinen
b6c356b7bb Fixed #17485 -- Made defer work with select_related 
This commit tackles a couple of issues. First, in certain cases there
were some mixups if field.attname or field.name should be deferred.
Field.attname is now always used.

Another issue tackled is a case where field is both deferred by
.only(), and selected by select_related. This case is now an error.

A lot of thanks to koniiiik (Michal Petrucha) for the patch, and
to Andrei Antoukh for review.
 2012-06-26 18:08:42 +03:00
Claude Paroz
4b722b31e1 Fixed #16317 -- Fixed dumpdata for self-referencing models and natural keys 
Thanks aldaran for the patch.
 2012-06-24 19:54:56 +02:00
Alex Gaynor
e0fce8706d Switch to using context managers for acquiring and releasing locks. 2012-06-23 08:11:15 -07:00
Dmitry Medvinsky
d4da08375b Fixed #18454 -- Added ability to pass a list of signals to receiver. 
Added ability to use receiver decorator in the following way:

    @receiver([post_save, post_delete], sender=MyModel)
    def signals_receiver(sender, **kwargs):
        ...
 2012-06-23 16:31:16 +02:00
Luke Plant
a54a8bab0c Fixed #17776 - DoesNotExist is not picklable 
Thanks to ambv for the report
 2012-06-22 13:28:15 +01:00
Claude Paroz
f08fa5b555 Removed unneeded u prefixes 2012-06-19 17:37:28 +02:00
Andrew Godwin
959a3f9791 Add some field schema alteration methods and tests. 2012-06-19 13:25:22 +01:00
Chris Beaven
c57ba67331 Fixed #14502 again -- saner verbatim closing token 
Previously, the closing token for the verbatim tag was specified as the
first argument of the opening token. As pointed out by Jannis, this is
a rather major departure from the core tag standard.

The new method reflects how you can give a specific closing name to
{% block %} tags.
 2012-06-19 10:49:33 +12:00
Andrew Godwin
8ba5bf3198 Very start of schema alteration port. Create/delete model and some tests. 2012-06-18 17:34:36 +01:00
Claude Paroz
fe873e2765 Fixed #12140 -- Fixed http.urlencode result for empty lists 
Thanks aneil for the report and the initial patch.
 2012-06-14 11:32:40 +02:00
Claude Paroz
a2022dae7f Removed escaping test of query content 
As the content of last_executed_query() is not under Django's control
for most backends, it is useless to test too specific aspects of it.
 2012-06-13 13:37:22 +02:00
Anssi Kääriäinen
86c20e39eb Fixed connection.queries encoding handling on Oracle 
In addition, removed a possibly problematic .filter() call from
backends.test_query_encoding test. It is possible the .filter could
cause collation problems on MySQL, and as it wasn't absolutely needed
for the test it seemed better to get rid of the call.

Refs #18461.
 2012-06-13 14:16:34 +03:00
Claude Paroz
e9ef9776d1 Fixed #18461 -- Ensured that last_executed_query returns Unicode 
Thanks Anssi Kääriäinen for the review.
 2012-06-13 12:04:46 +02:00
Claude Paroz
a7ef802fa4 Added missing encoding prefix in localflavor test 2012-06-12 14:25:51 +02:00
Claude Paroz
35f9c2c07a Cleaned up locale-related encoding issues 2012-06-12 14:23:41 +02:00
Claude Paroz
3dd5d726d1 Fixed #18463 -- Forced type() argument to be a byte string 2012-06-11 22:14:06 +02:00
Claude Paroz
fc40a6504b Fixed #17159 -- Validated returned number of next|previous_page_number 
Thanks mehta.apurva at gmail.com for the report and the initial patch
and neaf for the complete patch.
 2012-06-09 17:55:24 +02:00
Claude Paroz
ef906b1632 Removed test of connection features before setting up databases 2012-06-09 17:22:24 +02:00
Claude Paroz
ad47364dd3 Reverted 905e33f, now that DatabaseFeatures does not need confirm 
Connection.features does not need to be confirmed any more, after
commit aa42357, rendering obsolete the workaround when using
TEST_MIRROR (Refs #16885, #17760).
 2012-06-09 17:05:54 +02:00
Claude Paroz
aa423575e7 Fixed #17760 -- Implemented callable database features as cached properties 
This does remove the requirement to call features.confirm() method
before checking the properties.
Thanks cdestiger and Ramiro Morales for their work on the patch.
 2012-06-09 15:59:52 +02:00
Anssi Kääriäinen
484fcd34a4 Fixed #16418 -- Made generic views work with ModelForms 
Generic views assumed any object's _meta will be model Options. This
is not true for ModelForms for example. Took isinstance(obj, Model)
in use instead.
 2012-06-09 01:12:14 +03:00
Aymeric Augustin
23d230f058 Merge pull request #123 from apollo13/ticket18381 
Fixed #18381 -- Stopped escaping object ids

when passing them to the contenttypes.shortcut view.

Thanks apollo13 for the patch and dhepper for the review.
 2012-06-08 01:48:41 -07:00
Daniel Hepper
0ae727beda Fixed #18433 -- Fixed "View on Site" link in inline admin for models with custom PK 2012-06-07 21:08:36 +02:00
Jann Kleen
1a412dda62 Fixed #18432 -- Prevented the ForeignKey field from creating an invalid query when chained. Thanks, Jann Kleen. 2012-06-07 18:49:19 +02:00
Claude Paroz
4a103086d5 Fixed #18269 -- Applied unicode_literals for Python 3 compatibility. 
Thanks Vinay Sajip for the support of his django3 branch and
Jannis Leidel for the review.
 2012-06-07 18:08:47 +02:00
Florian Apolloner
e1643e3535 Don't escape object ids when passing to the contenttypes.shortcut view. 
This commit also changes the string pk to string_pk instead of id, to test
if the admin uses .pk throughout the codebase.
 2012-06-07 17:52:12 +02:00
Claude Paroz
6492e8e5e6 Added more precise assertions on two fixture tests. 2012-06-07 14:37:37 +02:00
Claude Paroz
6fd1950a4e Fixed #10200 -- Raised CommandError when errors happen in loaddata. 2012-06-07 10:32:10 +02:00
Aymeric Augustin
4464bbba15 Fixed #14502 -- Added a verbatim template tag. 
Thanks SmileyChris for the patch.
 2012-06-07 09:59:14 +02:00
Claude Paroz
2c57809a56 Prevented TestNoInitialDataLoading to pollute other tests (Refs #15926) 
Tests were still failing with MySQL. It seems a rollback is solving
the issue.
 2012-06-06 15:47:48 +02:00
Luke Plant
4fea46a030 Fixed #18309 - Prefetch related does not work for fkey to multitable inherited model 
Thanks to milosu for the report, tests and initial patch.
 2012-06-06 14:17:32 +01:00
Claude Paroz
f0664dc8ae Made TestNoInitialDataLoading pass with MySQL (Refs #15926) 2012-06-06 13:54:40 +02:00
Honza Kral
fedac99c85 Fixed #15926 -- Added option --no-initial-data to syncdb and flush. 
Thanks msiedlarek, jpaugh64 and vlinhart!
 2012-06-05 16:46:15 +02:00
Julien Phalip
f699641161 Fixed #17138 -- Made the sensitive_variables decorator work with object methods. 2012-06-03 23:44:13 -07:00
Honza Kral
a89034a2d8 Changed FilePathField tests to use it's own directory with test files. 
In previous version it used /django/forms/ which was fragile - for some
users .pyc files were not generated and this tests failed.
 2012-06-03 22:54:34 +02:00
Honza Kral
71d9a2a7fe Unittest2 style assertTrue instead of assert_ 2012-06-03 22:31:49 +02:00
Honza Kral
f823ae3b3e Fixed incorrect assert in test_filepathfield_folders 2012-06-03 21:46:14 +02:00
Claude Paroz
566ac30eb9 Fixed override_settings usage in test_client_regress 2012-06-02 19:50:24 +02:00
Claude Paroz
ade44b8d40 Fixed settings override in mail regression tests 
self.settings_override from test subclasses were overwriting parent
attribute.
 2012-06-02 19:44:15 +02:00
Ramiro Morales
d4648a3446 Removed debugging code added in last commit. 2012-06-01 21:50:06 -03:00
Ramiro Morales
72130385bf Made inspectdb tests deal with a smaller generated models.py file. 
Implemented this by adding a stealth table_name_filter option for the
command.
 2012-06-01 21:46:07 -03:00
Julien Phalip
f6fc83c975 Fixed #18409 -- Made RegexField work with unicode characters. 2012-05-31 11:45:35 -07:00
Claude Paroz
ea4e0aad9e Cleaned up test_client_regress tests 2012-05-31 17:43:21 +02:00
Claude Paroz
4553f51155 Moved test_client_regress tests from models.py to tests.py 2012-05-31 17:21:13 +02:00
Claude Paroz
0dc904979d Fixed #18407 -- Made model field's to_python methods fully accept unicode. 
When generating error message in to_python, any unicode string
containing non-ascii characters triggered a UnicodeEncodeError for
most field types.
 2012-05-31 16:46:07 +02:00
Claude Paroz
473c272246 Rewrote test_error_messages with helper test utility. 2012-05-31 16:24:37 +02:00
Claude Paroz
2626ea4a74 Fixed #14681 -- Do not set mode to None on file-like objects. 
gzip.GzipFile does not support files with mode set to None.
 2012-05-31 10:02:35 +02:00
Julien Phalip
432339a72c Fixed #18393 -- Prevented blocktrans to crash when a variable name is badly formatted. 2012-05-28 11:03:34 -07:00
Claude Paroz
a535040bfa Used call_command stdout parameter to capture output in staticfiles tests. 2012-05-28 11:55:38 +02:00
Claude Paroz
c3b56c7cdd Used call_command in i18n compilation tests. 
Now that call_command does not raise SystemExit any more, we can
use call_command again for testing compilemessages.
 2012-05-27 23:11:27 +02:00
Claude Paroz
cc4b4d9fd3 Used CommandError in createcachetable command. 
Raising CommandError whenever a management command meets an error
condition is the standard way to handle errors in commands.
 2012-05-27 23:03:21 +02:00
Claude Paroz
f2b6763ad7 Fixed #18387 -- Do not call sys.exit during call_command. 
Moved sys.exit(1) so as failing management commands reach it
only when running from command line.
 2012-05-27 20:38:47 +02:00
Michael Newman
4423757c0c Fixed #18135 -- Close connection used for db version checking 
On MySQL when checking the server version, a new connection could be
created but never closed. This could result in open connections on
server startup.
 2012-05-27 18:45:08 +03:00
Anssi Kääriäinen
a8a81aae20 Fixed #18343 -- Cleaned up deferred model implementation 
Generic cleanup and dead code removal in deferred model field loading
and model.__reduce__().

Also fixed an issue where if an inherited model with a parent field
chain parent_ptr_id -> id would be deferred loaded, then accessing
the id field caused caused a database query, even if the id field's
value is already loaded in the parent_ptr_id field.
 2012-05-27 18:11:13 +03:00
Claude Paroz
7a4233b69c Removed a duplicate test in fixtures_regress. 
test_abort_loaddata_on_error was exactly the same test as
test_empty (error is tested in test_error_message).
 2012-05-26 16:42:28 +02:00
Claude Paroz
3b5083bee5 Fixed #5423 -- Made dumpdata output one row at a time. 
This should prevent storing all rows in memory when big sets of
data are dumped.
See ticket for heroic contributors.
 2012-05-26 11:43:37 +02:00
Claude Paroz
edfa95c22f Specified when open should use binary mode. 
Thanks Vinaj Sajip for the help of his django3 branch.
 2012-05-25 20:43:43 +02:00
Aymeric Augustin
e73838b6dd Fixed #17371 -- Made the test client more flexible 
The OPTIONS, PUT and DELETE methods no longer apply arbitrary
data encoding (in the query string or in the request body).
 2012-05-25 19:03:15 +02:00
Anssi Kääriäinen
323b414441 Added tests for nested exclude/negate queries 2012-05-25 14:10:45 +03:00
Anssi Kääriäinen
8c72aa2379 Fixed qs.order_by() join promotion for already existing joins 
When order_by causes new joins to be added to the query, the joins must
be LEFT OUTER joins for nullable relations, otherwise the order_by
could cause the results to be altered. This commit fixes the logic to
only promote new joins, previously all joins in the order_by lookup
path were promoted.

Thanks to Bruno Desthuilliers for spotting this corner case.
 2012-05-24 18:42:06 +03:00
Aymeric Augustin
1e6c3368f2 Fixed #18177 -- Cached known related instances. 
This was recently fixed for one-to-one relations; this patch adds
support for foreign keys. Thanks kaiser.yann for the report and
the initial version of the patch.
 2012-05-24 13:25:01 +02:00
Aymeric Augustin
3b2993ed04 Fixed #18353 -- Inconsistency in date-based CBVs. 2012-05-24 13:02:19 +02:00
Anssi Kääriäinen
0df4593f0e Fixed #18319 -- Added 'supports_sequence_reset' DB feature 
Added a new feature to allow 3rd party backends to skip tests which
test sequence resetting.

Thanks to manfre for report and patch.
 2012-05-22 23:51:05 +03:00
Anssi Kääriäinen
8ee1a664f9 Fixed #18318 -- Changed some tests to be 3rd party DB friendly 
Thanks to manfre for report and patch.
 2012-05-22 23:33:42 +03:00
Anssi Kääriäinen
459c3b67b7 Fixed #18317 -- Removed db specific raw SQL function from tests 
A test in model_fields used LEN() in raw SQL. This function is not
available on some 3rd party backends. I removed this function and
ensured that the test works correctly (breaks pre e9bbdb39de) with
the change.
 2012-05-22 23:16:24 +03:00
Anssi Kääriäinen
d5c7f9efc3 Fixed #18304 -- Optimized save() when update_can_self_select=False 
Databases with update_can_self_select = False (MySQL for example)
generated non-necessary queries when saving a multitable inherited
model, and when the save resulted in update.
 2012-05-22 20:59:33 +03:00
Aymeric Augustin
03f86a5adb Fixed #18354 -- Performance issue in CBV. 
Prevented repeating a query twice when the model isn't ordered by
-date_field (in Meta), allow_empty is False and pagination isn't
enabled.
 2012-05-20 13:18:42 +02:00
Claude Paroz
38408f8007 Marked bytestrings with b prefix. Refs #18269 
This is a preparation for unicode literals general usage in
Django (Python 3 compatibility).
 2012-05-19 17:43:34 +02:00
Claude Paroz
822d6d6dab Fixed #18325 -- Wrapped self.stdout/stderr in OutputWrapper class 2012-05-19 13:51:54 +02:00
Claude Paroz
45f55a9fcc Fixed broken ES localflavor test after 4774875. 2012-05-18 13:45:42 +02:00
Claude Paroz
7549de841c Fixed #18334 -- Fixed detection of supports_stddev backend feature. 
Thanks to Michael Manfre for the report and Anssi Kääriäinen for the
review.
 2012-05-18 12:12:45 +02:00
Aymeric Augustin
ab268e1848 Added a test for DayArchiveView. Refs #17192. 2012-05-17 17:53:19 +02:00
Aymeric Augustin
dcd4383107 Fixed #9893 -- Validated the length of file names 
after the full file name is generated by the storage class.

Thanks Refefer for the report, carsongee for the patch, and
everyone else involved in the discussion.
 2012-05-17 16:02:05 +02:00
Aymeric Augustin
c4996df16c Fixed #17449 -- Added OPTIONS to generic views. 
Thanks estebistec for the report and patch.
 2012-05-17 13:54:51 +02:00
Aymeric Augustin
009e237cf0 Fixed #17535 -- Optimized list generic views. 
When allow_empty is False, prevented the view from loading
the entire queryset in memory when pagination is enabled.
 2012-05-17 13:34:53 +02:00
Claude Paroz
006c2b8fc1 Fixed #18326 -- Stripped ending chars in LiveServerViews tests. 
Ending chars might be different depending on git crlf setting.
Thanks Michael Manfre for the report and the patch.
 2012-05-17 11:10:48 +02:00
Jannis Leidel
5f75ac91df Fixed #17896 -- Added file_hash method to CachedStaticFilesStorage to be able to customize the way the hashed name of a file is created. Thanks to mkai for the initial patch. 2012-05-16 13:21:50 +02:00
Aymeric Augustin
fcb09b5746 Fixed #10890: added prev/next_week in the context 
of per-week date-based generic views. Thanks ee_lars for the report.
 2012-05-14 22:40:45 +02:00
Claude Paroz
bbb12581db Replaced im_func and im_self by __func__ and __self__. 
The new names are Python 3 compatible.
 2012-05-12 22:35:21 +02:00
Claude Paroz
33ffd28d76 Added missing relative imports in test files. 2012-05-12 19:58:32 +02:00
Anssi Kääriäinen
de79d23ce0 Avoided test failure on MySQL by skipping a failing test 
MySQL generates an extra query in inheritance cases when doing an update.
This results in a test failure when checking for number of queries in
update_only_fields tests. Added a skip temporarily to avoid this test
failure. Refs #18304.
 2012-05-12 12:03:46 +03:00
Andrei Antoukh
365853da01 Fixed #4102 -- Allow update of specific fields in model.save() 
Added the ability to update only part of the model's fields in
model.save() by introducing a new kwarg "update_fields". Thanks
to all the numerous reviewers and commenters in the ticket
 2012-05-12 10:29:41 +03:00
Aymeric Augustin
46648b641d Fixed #17798 -- Tweaked the CA localflavor. 
Thanks shelldweller.
 2012-05-10 22:19:01 +02:00
Claude Paroz
169b1a404c Replaced foo.next() by next(foo). 
This new syntax for next() has been introduced in Python 2.6 and is
compatible with Python 3.
 2012-05-10 20:15:49 +02:00
Anssi Kääriäinen
c2e1ecb4b1 Fix proxy model Query.remove_inherited_models() 
Fixed #18248 -- proxy models were added to included_inherited_models
in sql.query.Query. The variable is meant to be used for multitable
inheritance only. This mistake caused problems in situations where
proxy model's query was reused.
 2012-05-09 20:33:31 +03:00
Simon Charette
5cbfb48b92 Made model fields comparable to other objects 
Fixed #17851 -- Added __lt__ and @total_ordering to models.Field,
made sure these work correctly on other objects than Field, too.
 2012-05-07 20:08:20 +03:00
Claude Paroz
d7dfab59ea Replaced cStringIO.StringIO by io.BytesIO. 
Also replaced StringIO.StringIO by BytesIO in some other appropriate
places. StringIO is not available in Python 3.
 2012-05-05 21:41:44 +02:00
Claude Paroz
208e26b39c Commented on a line that inadvertantly slipped in commit 865cd35c 
Ignoring __pycache__ directories fixes #17393 and prepare testing
with Python 3.
 2012-05-05 16:45:02 +02:00
Claude Paroz
865cd35c9b Made more extensive usage of context managers with open. 2012-05-05 14:06:36 +02:00
Claude Paroz
11a5355517 Inserted more simplefilter calls to be sure warnings are emitted. 
Thanks to Florian Apolloner for suggesting the patch.
 2012-05-03 21:31:23 +02:00
Claude Paroz
00c0d3c44e Made warning assertions work with or without -Wall python switch 2012-05-03 20:18:05 +02:00
Claude Paroz
10cf3c6427 Used catch_warnings instead of save/restore methods. Refs #17049. 2012-05-03 18:30:07 +02:00
Ramiro Morales
ea28bc2688 Removed unused file from i18n regression tests. 2012-05-03 12:00:36 -03:00
Claude Paroz
b52672d778 Replaced deprecated TestCase methods. Refs #17049. 2012-05-03 16:39:16 +02:00
Aymeric Augustin
e84f79f051 Fixed #18042 -- Advanced deprecation warnings. 
Thanks Ramiro for the patch.
 2012-05-03 15:27:01 +02:00
Karen Tracey
b86a00187d Merge pull request #28 from akaariai/ticket_18163 
Ticket 18163 - use faster password hasher in tests.
 2012-05-02 16:06:00 -07:00
Aymeric Augustin
435081fd22 Fixed tests for date-based generic views. 2012-05-01 22:23:17 +02:00
Aymeric Augustin
46b082e05c Fixed #17742 -- Handled aware datetimes in DateField 
Converted aware datetimes to the default time zone before using them
in the context of a DateField.
 2012-05-01 11:29:55 +02:00
Anssi Kääriäinen
0819957eda Use faster password hasher in sqlite tests 
Fixed #18163
 2012-04-30 22:10:27 +03:00
Anssi Kääriäinen
8fad77da95 Ensured tests pass using custom PASSWORD_HASHERS. 2012-04-30 22:10:27 +03:00
Aymeric Augustin
ddfc7c2530 Fixed #4746 -- Allowed spaces around filter separator. 2012-04-30 21:01:06 +02:00
Aymeric Augustin
78ba9670af Fixed #18217 -- Time zone support in generic views 
Introduced a distinct implementation depending on the type of the
date field (DateField or DateTimeField), and applied appropriate
conversions is the latter case, when time zone support is enabled.
 2012-04-30 20:48:19 +02:00
Claude Paroz
596cb9c7e2 Replaced print statement by print function (forward compatibility syntax). 2012-04-30 20:45:03 +02:00
Anssi Kääriäinen
4b11762f7d Fixed SortedDict.__copy__() 
Fixed #18175 -- Calling SortedDict.__copy__() resulted in changes to
the original dictionary. The reason was likely related to subclassing
dict.

Thanks to linovia for report and patch.
 2012-04-30 17:19:55 +03:00
Anssi Kääriäinen
a18e43c5bb Made get_indexes() consistent across backends. 
Fixed #15933, #18082 -- the get_indexes() method introspection was
done inconsitently depending on the backend. For example SQLite
included all the columns in the table in the returned dictionary,
while MySQL introspected also multicolumn indexes.

All backends return now consistenly only single-column indexes.

Thanks to andi for the MySQL report, and ikelly for comments on
Oracle's get_indexes() changes.
 2012-04-30 14:30:29 +03:00
Claude Paroz
3904b74a3f Fixed #18013 -- Use the new 'as' syntax for exceptions. 
Thanks Clueless for the initial patch.
Note that unittest has been purposely left out (external package only used by Python 2.6).
 2012-04-29 20:57:15 +02:00
Aymeric Augustin
cec6bd5a59 Fixed #18023 -- Removed bundled simplejson. 
And started the deprecation path for django.utils.simplejson.

Thanks Alex Ogier, Clueless, and other contributors for their
work on the patch.
 2012-04-29 19:58:00 +02:00
Anssi Kääriäinen
ee0a7c741e Fixed an Oracle-specific test case failure 
Made a test checking ORM-generated query string case-insensitive.
 2012-04-29 19:48:43 +03:00
Anssi Kääriäinen
584e2c0337 Prevent Oracle from changing field.null to True 
Fixed #17957 -- when using Oracle and character fields, the fields
were set null = True to ease the handling of empty strings. This
caused problems when using multiple databases from different vendors,
or when the character field happened to be also a primary key.

The handling was changed so that NOT NULL is not emitted on Oracle
even if field.null = False, and field.null is not touched otherwise.

Thanks to bhuztez for the report, ramiro for triaging & comments,
ikelly for the patch and alex for reviewing.
 2012-04-29 19:25:46 +03:00
Alex Gaynor
e75bd7e51c Merge pull request #22 from aviraldg/test_17967 
Added regression test for #17967.  Thanks to aviraldg for the patch!
 2012-04-29 09:08:12 -07:00
Aviral Dasgupta
0525f6d8bd Fixed some style issues in previous commit. 2012-04-29 21:31:09 +05:30
Aymeric Augustin
a15cfb2e45 Simplified timezones tests with settings_changed. 
All relevant state is now properly reset whenever TIME_ZONE or USE_TZ
are changed in tests.
 2012-04-29 16:03:46 +02:00
Aymeric Augustin
3e8b40f479 Fixed #17992 -- Added a public API for localtime. 
Thanks Bradley Ayers for the report.
 2012-04-29 15:37:23 +02:00
Anssi Kääriäinen
5aa51fa999 Simplified QuerySet field.null handling 
QuerySet had previously some complex logic for dealing with nullable
fields in negated add_filter() calls. It seems the logic is leftover
from a time where the WhereNode wasn't as intelligent in handling
field__in=[] conditions.

Thanks to aaugustin for comments on the patch.
 2012-04-29 16:27:25 +03:00
Aymeric Augustin
9350d1d59c Fixed #17976 -- Made forms.BooleanField pickleable. 
This was a regression in Django 1.4.
Thanks bronger for the report and claudep for the patch.
 2012-04-29 14:25:06 +02:00
Aviral Dasgupta
d12d55ec26 Added regression test for #17967. 2012-04-29 17:26:22 +05:30
Aymeric Augustin
02a5b41db4 Fixed #18224 -- Changed the dev version number. 
Following the move from SVN to git.
 2012-04-29 13:40:10 +02:00
Aymeric Augustin
905bd7fb44 Fixed #13196 -- Formatting in admin changelists. 
Handled values returned by functions more like field values.
In particular, localized dates, times and datetimes properly,
and converted datetimes to the current timezone.
 2012-04-29 11:51:12 +02:00
Anssi Kääriäinen
527cce80dc Made table_names() output sorted. 
Fixed #18218 -- previously Django's introspection table_names() and
get_table_list() methods did not sort the output consistently. This
resulted in random order of inspected models.

This commit also removed all external usages of get_table_list().
table_names() should be used instead.

Thanks to claudep for patch and report.
 2012-04-29 02:11:55 +03:00
Aymeric Augustin
10cade8fac Removed a svn-specific hack from a test. 2012-04-28 15:19:04 +02:00
Claude Paroz
ddc5d59c6a Fixed #15076 -- Quoted ForeignKey target class names in inspectdb when class is defined below. 
Thanks saschwarz for the report, jeff@deserettechnology.com for the initial patch and Ramiro Morales for the review. 


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17942 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-27 06:56:31 +00:00
Claude Paroz
8aca3d1cc2 Removed unneeded deprecation warning silencing in test suite. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17940 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-26 18:06:17 +00:00
Claude Paroz
a6b2a15348 Removed deprecated gender check in cz localflavor. Refs #14593. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17939 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-26 17:48:50 +00:00
Claude Paroz
1858e47672 Fixed #18033 -- Removed function-based generic views, as per official deprecation timeline. Rest in peace! Thanks Anssi Kääriäinen for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17937 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-25 19:17:47 +00:00
Claude Paroz
921d7f08b9 Removed some leftover references to old-syntax ssi template tag tests. Refs #18037. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17935 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-24 21:08:13 +00:00
Claude Paroz
eb351ac9cb Fixed #18037 -- Changed behaviour of url and ssi template tags to the new syntax, as per official deprecation timeline. Thanks Ramiro Morales and Jannis Leidel for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17934 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-24 19:55:52 +00:00
Anssi Kääriäinen
c4e62eff90 Fixed #17653 -- Changed MySQL backend to raise a ValueError if zero is used as an AutoField value. 
Thanks to Sylvain Lebon for the report, krzysiumed for the patch and charettes and claudep for reviews.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17933 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-24 18:03:14 +00:00
Anssi Kääriäinen
612247b3a0 Fixed #16961 -- Skipped resetting AUTO_INCREMENT fields for MySQL if the server version is greater than 5.0.12. This allows for much faster testing. 
Thanks to aigarius for the report and claudep and ramiro for review.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17932 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-24 16:47:31 +00:00
Claude Paroz
03a442c8ad Fixed #17954 -- Fixed dependency checking for test databases. Thanks Łukasz Rekucki for the report and the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17931 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-24 16:05:47 +00:00
Alex Gaynor
e7d648d8cb Ignore .svn directories in the folders test from [17925]. This is what happens when you use git-svn. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17926 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-22 15:07:36 +00:00
Alex Gaynor
3c5ff9d703 Fixed #5893 -- Added a flag to FilePathField to allow listing folders, in addition to regular files. Thank you to Brian Rosner, for encouraging me to first contribute to Django 4 years ago. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17925 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-22 14:44:08 +00:00
Anssi Kääriäinen
53fb45c6d8 Fixed #17615 -- Corrected unique field validation when using multitable inheritance. The validation used wrong pk value if the parent and child model had different pk fields. Thanks ungenio for the report and patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17920 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-20 17:34:29 +00:00
Anssi Kääriäinen
d5b93d3281 Fixed #10494 -- Added kwargs to QuerySet.get() error message in the case no objects were found. 
Thanks brondsem for the report, Szymon Pyzalski for the patch and oinopion for review.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17917 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-20 11:09:32 +00:00
Claude Paroz
0e01023897 Converted more test assertions to assert[Not]Contains. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17910 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-14 13:35:25 +00:00
Claude Paroz
2cd516002d Fixed #18002 -- Fixed typo in attribute name in ReverseSingleRelatedObjectDescriptor. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17904 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-12 20:23:41 +00:00
Claude Paroz
5a4d7e63ce Fixed #18027 -- Removed an HTMLParser test that doesn't raise any more in recent Python versions. Thanks Arfever and Anssi Kaariainen for the report and the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17900 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-11 21:25:22 +00:00
Aymeric Augustin
632b6a1a73 Fixed #17439 -- Prevented spurious queries for missing objects after prefetch_related has run. 
That affects nullable foreign key, nullable one-to-one, and reverse one-to-one relations.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17899 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-11 21:11:22 +00:00
Claude Paroz
e2548ec2a9 Fixed #18071 -- Ignored case sensitivity in urlize utility. Thanks luke@creaturecreative.com and adamzap for the report and the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17898 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-11 17:49:22 +00:00
Aymeric Augustin
93240b7d90 Fixed #17229 -- Allow 'True', 'False' and 'None' to resolve to the corresponding Python objects in templates. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17894 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-10 20:49:45 +00:00
Aymeric Augustin
28e5b66518 Fixed #18087 -- Prevented date-based generic views from loading entire tables in memory when pagination is enabled. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17893 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-10 20:05:46 +00:00
Aymeric Augustin
b90d4e5b74 Made the caching of related and reverse related objects consistent in OneToOneFields. Fixed #13839. Refs #17439. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17890 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-10 12:29:25 +00:00
Aymeric Augustin
1f11069aa5 Fixed #18090 -- Applied filters when running prefetch_related backwards through a one-to-one relation. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17888 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-10 06:04:53 +00:00
Carl Meyer
f195f1ed24 Fixed #18083 -- Fixed cascade deletion with proxy model of concrete subclass. Thanks Simon Charette for report and patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17887 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-09 22:41:20 +00:00
Julien Phalip
6f7aa51b2c Fixed #17864 -- Added Hong Kong localflavor. Thanks to mrkschan and Adrien Lemaire. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17886 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-09 17:25:02 +00:00
Claude Paroz
883c38c499 Fixed #17848 -- Added setting_changed signal for cases when TEMPLATE_CONTEXT_PROCESSORS is overriden in tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17885 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-09 13:24:57 +00:00
Julien Phalip
a0b55f30a8 Fixed #18086 -- Restored '-pk' as the default order in the admin changelist. This rectifies a slight change in behavior introduced in Django 1.4 and r17635. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17881 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-09 04:28:32 +00:00
Julien Phalip
93d1fdb130 Fixed #17877 -- Ensured that extra WHERE clauses get correctly ANDed when they contain OR operations. Thanks to Marek Brzóska for the report, to eleather for the test case and to Adrien Lemaire for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17880 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-09 00:43:08 +00:00
Claude Paroz
5c53e30607 Fixed #18035 -- Removed deprecated AdminMediaHandler, as per official deprecation timeline. Thanks Jannis Leidel and Ramiro Morales for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17879 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-08 21:13:32 +00:00
Claude Paroz
8dd04fd84b Fixed #15683 -- Prevented escaped string to be needlessly marked safe twice in force_escape filter. Thanks tyrion for the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17876 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-07 15:16:11 +00:00
Claude Paroz
8663bc1103 Fixed #16074 -- Added ContextMixin to class-based generic views to handle get_context_data. Thanks emyller, Luke Plant, Preston Holmes for working on the ticket and patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17875 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-06 21:24:33 +00:00
Claude Paroz
5c954136ea Fixed #15644 -- Improved Django File wrapper to support more file-like objects. Thanks nickname123 and Michael Palumbo for working on the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17871 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-05 15:44:04 +00:00
Claude Paroz
38115ea742 Fixed #17938 -- Made explicit object ordering in LiveServerDatabase test assertion. Thanks Nate Bragg for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17869 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-04-05 14:06:06 +00:00
Ramiro Morales
b41ebcf1b9 Fixed #18040 -- Removed so-called project-level locale trees from the list of paths the translation loading process takes in account. 
Deprecated in Django 1.3. Removed completely for Django 1.5.

Thanks Claude for the review.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17861 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 22:24:24 +00:00
Claude Paroz
2d01c9de69 Removed some more useless code related to the verify_exists removal. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17856 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 18:27:17 +00:00
Julien Phalip
c39e1cff99 Fixed #17972 -- Ensured that admin filters on a foreign key respect the to_field attribute. This fixes a regression introduced in [14674] and Django 1.3. Thanks to graveyboat and Karen Tracey for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17854 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 18:22:12 +00:00
Claude Paroz
6d9227bb0f Removed some more imports/warnings useless after recent removals. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17850 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 15:20:57 +00:00
Aymeric Augustin
37c8bc89f2 Removed deprecated tests missed in r17839. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17848 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 13:58:03 +00:00
Aymeric Augustin
9ed6e08ff9 Removed deprecated URLField.verify_exists. 
The deprecation schedule was slightly accelerated because of possible security ramifications.



git-svn-id: http://code.djangoproject.com/svn/django/trunk@17847 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 13:55:03 +00:00
Aymeric Augustin
800e3941c5 Extended TrailingSlashURLTests to cover STATIC_URL as well as MEDIA_URL. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17846 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 13:11:02 +00:00
Aymeric Augustin
fbfaa35fb0 Required that the MEDIA_URL and STATIC_URL settings end with a slash, per the deprecation timeline. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17845 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 13:01:59 +00:00
Aymeric Augustin
d38690796c Removed the deprecated reset and sqlreset management commands. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17842 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 12:38:11 +00:00
Aymeric Augustin
c7229c681e Removed deprecated DjangoTestRunner. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17840 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 12:22:52 +00:00
Claude Paroz
a1ffb02107 Fixed #18029 -- Removed mod_python as of deprecation process. Thanks Aymeric Augustin for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17835 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 10:34:11 +00:00
Claude Paroz
23d3459761 Fixed #17965 -- Definitely dropped support for Python 2.5. Thanks jonash for the initial patch and Aymeric Augustin for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17834 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-31 08:24:29 +00:00
Aymeric Augustin
4fe87c370d Removed some Python < 2.6 compatibility code. Refs #17965. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17830 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-30 09:20:04 +00:00
Aymeric Augustin
eb163f37cb Use the class decorator syntax available in Python >= 2.6. Refs #17965. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17829 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-30 09:08:29 +00:00
Claude Paroz
9383a2761c Removed with_statement imports, useless in Python >= 2.6. Refs #17965. Thanks jonash for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17828 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-30 08:02:08 +00:00
Claude Paroz
159d1be656 Fixed #11150 -- Removed dependency on cStringIO in ImageField validation. Thanks vvd for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17825 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-29 16:49:59 +00:00
Aymeric Augustin
e78d6b406b Reverted parts of r16963 to fix a regression on the creation of permissions on proxy models. Refs #17904. Thanks koenb for the report and claudep for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17776 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-22 08:49:48 +00:00
Aymeric Augustin
1e28567e0d Fixed #17937 -- Avoided an error in the timeuntil filter when it receives a date object. Thanks Dmitry Guyvoronsky for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17774 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-22 07:29:39 +00:00
Jannis Leidel
4219e2b7f8 Fixed #17920 -- Actually pass the full path of a newly created project or app in the template context as mentioned in the startproject docs. Many thanks to Preston Holmes for the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17773 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-21 22:29:32 +00:00
Aymeric Augustin
358c5a1c2a Fixed #17932 -- Tweaked the admin_changelist tests because Oracle doesn't like columns named 'number'. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17767 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-19 12:52:15 +00:00
Aymeric Augustin
c8e2f7591d Fixed #17931 -- Accepted aware datetimes to set cookies expiry dates. Thanks jaddison for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17766 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-18 20:58:22 +00:00
Claude Paroz
c7cc4cfb9e Fixed #16138 -- Made FormMixin get_initial return a copy of the 'initial' class variable. Thanks hanson2010, wilfred@potatolondon.com and agriffis for their work on the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17765 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-17 22:31:03 +00:00
Julien Phalip
1ff9be1144 Fixed #17828 -- Ensured that when a list filter's queryset() method fails, it does so loudly instead of getting swallowed by a IncorrectLookupParameters exception. This also properly fixes #16705, which hadn't been addressed correctly in [16705]. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17763 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-17 21:45:36 +00:00
Claude Paroz
f0b9bb2ef9 Do not unconditionally add extra_tests when testing geodjango. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17761 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-17 17:44:42 +00:00
Carl Meyer
e57bedee78 Fixed #17909 - ensure GeoDjango tests have the templates they need. Thanks Nate Bragg for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17757 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-17 04:39:23 +00:00
Carl Meyer
ddd53dafb5 Fixed #17918 - Handle proxy models correctly when sorting deletions for databases without deferred constraints. Thanks Nate Bragg for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17756 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-17 01:24:39 +00:00
Carl Meyer
edcaf8b7ff Reorganized proxy-delete tests for easier addition of new tests. Refs #16128. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17755 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-16 23:27:40 +00:00
Julien Phalip
a395e531de Ensured that some staticfiles tests get properly cleaned up on teardown. Thanks to Claude Paroz for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17747 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-16 00:29:11 +00:00
Julien Phalip
ea9d96739f Added a with_statement import to a test for Python 2.5 compatibility. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17746 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-15 18:55:08 +00:00
Luke Plant
b018128ea5 Fixed #17838 - prefetch_related fails for GenericForeignKeys when related object id is not a CharField/TextField 
Thanks to mkai for the report and debugging, and tmitchell and Przemek
Lewandowski for their work on the patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17744 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-15 15:06:57 +00:00
Ramiro Morales
a935e83443 Reverted r16386 because it replaced a brittle method with another not less 
arbitrary method when the test client checks for the presence of the bundled
session backends+session middleware combination.

We will revisit the issue soon, probably to make these checks even less strict.

Refs #7836, #16605

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17739 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-15 02:46:07 +00:00
Ramiro Morales
eb9eaa6d71 Tweaked tests from r17702 to run only when using sqlite3 DB(s). 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17733 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-14 10:58:23 +00:00
Aymeric Augustin
43cb17bbe5 Added cleanup code to the proxy_model_inheritance tests. Refs #12286, #16329. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17712 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-14 08:40:35 +00:00
Aymeric Augustin
4b14546215 Fixed #17895 -- Made override_settings send the setting_changed signal both when a setting is overridden and when it's restored. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17708 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 23:02:31 +00:00
Ramiro Morales
69b96f824d Fixed #16329 -- Fixed detection of transaction-handling capabilities when all test databases are sqlite3, in-memory. 
Thanks canassa for the report and agriffis (#17762) and lrekucki (in #17758) for their contribution to the fix.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17702 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 17:52:48 +00:00
Claude Paroz
dd13596944 Fixed #17768 -- Add a comment about an expected failure in generic_views tests 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17700 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 16:33:56 +00:00
Aymeric Augustin
aa900c39a8 Fixed #17882 -- Reopened the database connection when a test changes time zone settings. Thanks brodie for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17699 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 06:59:04 +00:00
Jannis Leidel
f7daa38a00 Fixed #10498 (again) -- Made sure the improvements done in r17641 have a smaller impact on speed. Thanks to Anssi Kääriäinen for the patch and Jonas Obrist for reviewing. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17698 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 03:48:20 +00:00
Jannis Leidel
0ee801e360 Fixed #17857 -- Stopped CachedStaticFilesStorage from creating absolute URLs unnecessarily. Thanks, tgecho. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17697 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 03:48:11 +00:00
Jannis Leidel
7487c74020 Fixed #17865 -- Strip whitespaces from the paths when using the CachedStaticFilesStorage backend. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17696 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 03:48:03 +00:00
Karen Tracey
d174216587 Refs #17876: enhanced new test to actually test underlying function, not just ensure trying to use it does not raise an exception. Thanks Przemek Lewandowski. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17695 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-13 01:01:22 +00:00
Karen Tracey
9d98b9eb4b Fix #17876: Corrected an exception (regression) raised where select_realted and only is used on a proxy model. Thanks milosu and charettes. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17692 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-12 22:33:18 +00:00
Jannis Leidel
3a5f9cd1ae Fixed #17861 -- Took care of special characters when creating the staticfiles storage cache keys. Many thanks to Preston Holmes. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17688 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-12 20:28:09 +00:00
Adrian Holovaty
dd246a62c7 Edited some docs and docstrings until [17685] 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17686 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-12 20:05:48 +00:00
Karen Tracey
20c69c5e51 Fix #17879: Corrected regression in python (inherited by yaml and json) serializer that prevented serializing model instances with null FK ref to a model when serializing with natural keys. Thanks danfairs and tmitchell. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17685 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-12 19:41:31 +00:00
Ramiro Morales
4cd9b4bb50 Fixed #17327 (again) -- Moved createsuperuser tests added in r17665. 
In their new location they won't cause multi-db-related errors when
users run contrib.auh tests together with their application tests.

Thanks brianriley for the patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17676 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-10 17:36:41 +00:00
Ramiro Morales
ecc8208f88 Removed executable bits from some files that don't need them. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17673 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-09 12:13:31 +00:00
Aymeric Augustin
bf0abe0ea6 Fixed #17830 -- Modified list_filter on DateTimeFields to account for the new time zone support. Thanks Glenn Washburn for the report and Jannis Leidel for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17670 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-05 12:27:19 +00:00
Aymeric Augustin
f95141abcc Added change forgotten in r17668. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17669 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-05 10:30:00 +00:00
Julien Phalip
399aa72330 Enabled the existing admin Selenium tests to be run with Internet Explorer. Note that some tweaks had to be made, in particular as IE7 has limited capabilities regarding CSS selectors. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17666 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-05 08:13:09 +00:00
Carl Meyer
7e92ad8506 Fixed #16128 - Correctly cascade-delete proxy models as if they were the concrete model class. Thanks xkennyx for the report, and Aymeric Augustin, Claude Paroz, Adam Nelson, jaap3, and Anssi Kääriäinen for work on the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17664 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-05 03:41:01 +00:00
Karen Tracey
20b021e506 Fix staticfiles_tests.TestCollectionCachedStorage.test_post_processing so it passes on Windows. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17652 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-04 16:47:28 +00:00
Julien Phalip
794fe19e19 Made the Selenium tests for the admin horizontal/vertical filter widgets a bit more thorough. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17649 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-04 04:50:58 +00:00
Julien Phalip
4dca9d166a Added more thorough Selenium tests for the admin horizontal/vertical filter widgets. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17648 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-04 01:20:03 +00:00
Jannis Leidel
dd441701ce Fixed #17717 (again) -- Used the new API for concrete models added in r17573. Many thanks to Simon Charette and Anssi Kääriäinen. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17643 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 21:34:51 +00:00
Jannis Leidel
c988397279 Fixed #10498 -- Fixed using ugettext_lazy values when creating model instances. Thanks to Claude Paroz and Jonas Obrist. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17641 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 19:02:49 +00:00
Jannis Leidel
dc49e6143a Fixed #17717 -- Fixed serialization of proxy models. Thanks, Anssi Kääriäinen. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17640 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 17:50:18 +00:00
Aymeric Augustin
48840cc9d1 Fixed a typo in r17638. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17639 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 17:41:32 +00:00
Ramiro Morales
3b2c53ac69 Modified a test added in r17508 to not run under Oracle. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17638 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 17:16:43 +00:00
Julien Phalip
d636150e53 Fixed #17198 -- Ensured that a deterministic order is used across all database backends for displaying the admin change list's results. Many thanks to Luke Plant for the report and general approach, to everyone involved in the design discussions, and to Carl Meyer for the patch review. Refs #16819. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17635 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-03 02:13:35 +00:00
Jannis Leidel
126d9e1b49 Fixed #17817 -- Modified LocalMiddleware to use full URLs when redirecting to i18n URLs. Thanks to Paul for keeping an eye on the standards. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17633 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 22:35:26 +00:00
Adrian Holovaty
2ade1e916f Edited stuff from [17543] to [17629] 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17630 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 17:16:52 +00:00
Jannis Leidel
4887a8de17 Fixed #16842 -- Modified the RedirectView to correctly handle query strings with percent symbols. Thanks, accuser, jamey@minilop.net and Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17625 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 16:55:56 +00:00
Jannis Leidel
e88a65660f Fixed #17806 -- Fixed off-by-n error in the CachedStaticFilesStorage that prevented it from finding files in nested directories. Many thanks to lpetre. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17622 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 11:29:14 +00:00
Jannis Leidel
746987f916 Fixed #17734 -- Made sure to only redirect translated URLs if they can actually be resolved to prevent unwanted redirects. Many thanks to Orne Brocaar and Anssi Kääriäinen for input. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17621 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 11:07:36 +00:00
Paul McMillan
fe7ccdc5be Fixed test cases that generate their own settings file. 
Now they include SECRET_KEY.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17615 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 03:42:20 +00:00
Jannis Leidel
df1e505d9f Added a default SECRET_KEY setting to the default test sesttings (refs #17800). 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17614 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-02 00:05:13 +00:00
Jannis Leidel
1c33c0a02a Fixed #17737 -- Stopped the collectstatic management command from copying the wrong file in repeated runs. Thanks, pigletto. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17612 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-01 23:02:38 +00:00
Luke Plant
3db5b0e485 Fixed #17696 - Queryset prefetch_related() ignores using() 
Thanks to simon29 for the report.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17605 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-03-01 00:57:01 +00:00
Luke Plant
de9942a667 Fixed #17668 - prefetch_related does not work in in_bulk 
Thanks to gurets for the report, and akaariai for the initial patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17600 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-28 19:34:04 +00:00
Aymeric Augustin
ce88b57b9a Fixed #17755 -- Ensured datetime objects that bypass the model layer (for instance, in raw SQL queries) are converted to UTC before sending them to the database when time zone support is enabled. Thanks Anssi for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17596 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-27 21:15:25 +00:00
Ramiro Morales
4bbacd2663 Modified tests introduced in r15452 to not run 31 test cases twice. Thanks Julien for discovering this. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17592 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-27 13:29:56 +00:00
Julien Phalip
f2de5f4cab Added some Selenium tests for the admin's filter_horizontal and filter_vertical widgets. Ref #13614, #15220. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17579 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-23 08:07:07 +00:00
Aymeric Augustin
8b53616198 Fixed #17728 -- When filtering an annotation, ensured the values used in the filter are properly converted to their database representation. This bug was particularly visible with timezone-aware DateTimeFields. Thanks gg for the report and Carl for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17576 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-22 19:40:27 +00:00
Julien Phalip
a65eed3942 Enabled the admin selenium tests to run on Chrome. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17574 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-22 07:14:10 +00:00
Carl Meyer
354c84d277 Fixed #17678 -- Corrected setup of _meta.proxy_for_model and added _meta.concrete_model. Thanks Anssi Kääriäinen. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17573 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-22 05:26:50 +00:00
Chris Beaven
3ac0961e1e Don't let ALLOWED_INCLUDE_ROOTS be accidentally set to a string rather than a tuple. Thanks to Florian Apolloner for pointing this out. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17571 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-22 00:42:19 +00:00
Chris Beaven
0e54c23caf Fixed #17660 -- Standardize extends tag token parsing 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17568 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-21 02:59:05 +00:00
Julien Phalip
f0c2228709 Fixed #13068 (again) -- Corrected the admin stacked inline template to allow prepopulated fields to work (Thanks Stanislas Guerra for the report). Also fixed a regression introduced in [16953] where prepopulated fields wouldn't be recognized any more due to the additional "field-" CSS class name prefix. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17562 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-19 16:42:12 +00:00
Jannis Leidel
7dd0ceba2e Fixed #17720 -- Stopped the LocaleMiddleware from overeagerly using the request path for language activation if it's actually not wanted. Thanks to Anssi Kääriäinen for the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17547 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-18 13:37:30 +00:00
Aymeric Augustin
52b06e29c7 Prevented the generic views from automatically creating a HEAD method when there is no GET. Reverts r16105, refs #17449. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17545 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-18 09:50:03 +00:00
Jannis Leidel
758a0cd0f1 Fixed #17689 -- Stopped the CachedStaticFilesStorage from trying to hash paths that aren't files. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17535 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-16 14:40:32 +00:00
Alex Gaynor
b9b3e9f0ef Use Python's changed comparisons, which makes this a bit more readable. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17526 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-16 01:10:21 +00:00
Paul McMillan
6072e108e2 Fixed #17693. Input validation and tests for base36 conversion utils. Thanks Keryn Knight for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17525 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-16 00:58:49 +00:00
Aymeric Augustin
2000f375cd Fixed #17675 -- Changed the implementation of the {% regroup %} template tag to use the context properly when resolving expressions. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17522 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-14 21:29:50 +00:00
Jannis Leidel
4f1ac8f5f1 Minor bugfixing of the staticfiles app following upstream development in django-staticfiles. 
- Create the files to ignore during the tests dynamically (.hidden and backup~)
- Refactored the post_processing method of the CachedFilesMixin storage mixin to be less time consuming.
- Refactored handling of fragments in the post_process method.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17519 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-13 10:51:17 +00:00
Jannis Leidel
1c9c29b5b2 Fixed AdminEmailHandler to format the subject message correctly when arguments are passed. 
This bug was hidden before r17480 as it basically didn't take the arguments into account. Refs #14973.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17512 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-12 12:19:02 +00:00
Ramiro Morales
98b4572ef7 Fixed #15216 -- Made return type of an internal DB introspection method consistent. 
Thanks arthur AT milliways DOT fr for the report and patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17510 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 22:12:49 +00:00
Ramiro Morales
a411242e94 Fixed #17676 -- Fixed introspection of column names that start with digit(s). 
Thanks Gandalfar for the report and patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17509 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 20:53:48 +00:00
Ramiro Morales
ccc0e122d4 Fixed #7783 -- Made introspection of nullable columns more robust with Postgres. 
Thanks bthomas AT ncorcle DOT com for the report and initial patch, and
Claude Paroz for the final, complete patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17508 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 20:05:50 +00:00
Julien Phalip
130e7ab617 Fixed #17256 -- Ensured that content types get cached when retrieved by natural key. Thanks, defaultwombat and charettes. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17502 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 09:55:54 +00:00
Julien Phalip
995f7a16a8 Fixed #17281 -- Prevented AdminErrorHandler from silently failing if the log message contains newlines. Thanks to Russell Keith-Magee for the report and to Bartolome Sanchez Salado and Marcin Wróbel for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17501 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 09:31:18 +00:00
Paul McMillan
a77679dfaa Fixes #16827. Adds a length check to CSRF tokens before applying the santizing regex. Thanks to jedie for the report and zsiciarz for the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17500 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 04:18:15 +00:00
Paul McMillan
4768f39c95 Fix the other test for #15237. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17495 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-11 00:05:57 +00:00
Paul McMillan
114b655247 Fixed #15237 (again). RSS feeds now include proper character encoding in the mimetype. Thanks shadow for the report and Michal Rzechonek for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17494 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 23:45:22 +00:00
Carl Meyer
0ce6636102 Fixed #17277 - Wrap IOErrors raised due to client disconnect in a specific IOError subclass so they can be distinguished from more serious errors. Thanks David Lowe. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17493 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 22:51:07 +00:00
Aymeric Augustin
8be356ea99 Fixed #17640 -- Avoided a DeprecationWarning in the test suite. Thanks zsiciarz and claudep. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17492 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 11:31:47 +00:00
Jannis Leidel
e41647a522 Fixed a SyntaxError in the middleware tests introduced in r17471. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17488 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 01:13:45 +00:00
Jannis Leidel
7019123d21 Fixed the exception handling when deserializing via generators on Python 2.5 that was introduced in r17469. Also only test the YAML serializer if PyYAML is installed. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17487 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 01:13:38 +00:00
Jannis Leidel
c1acda6d8f Updated a few localization formats to stop the changes done in r17473 from breaking the tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17486 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 01:13:29 +00:00
Jannis Leidel
8ae02fde2b Added missing file forgotten in r17479. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17485 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-10 01:13:09 +00:00
Jannis Leidel
4dbeb4bca4 Fixed #17515 -- Added ability to override the template of custom admin FilterSpec classes. Thanks, saxix and Julien Phalip. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17483 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:59:05 +00:00
Jannis Leidel
f0a1633425 Fixed #17358 -- Updated logging calls to use official syntax for arguments instead of string interpolation. Thanks, spulec. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17480 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:58:36 +00:00
Jannis Leidel
c609b792f7 Fixed #17286 -- Made sure all cache backends are set up to connect to the signal handler that closes the cache connection when the request has been processed. Thanks, gnosek. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17479 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:58:25 +00:00
Jannis Leidel
d6f9c1e774 Fixed #17139 -- Corrected the French department names to contain accents. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17477 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:58:03 +00:00
Jannis Leidel
bc8875e37c Fixed #16958 -- Correctly use the queryset method in the auth app's UserAdmin class. Thanks, mpaolini. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17474 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:57:40 +00:00
Jannis Leidel
a6b6c6e171 Fixed #16416 -- Added two new date formatting options for timezones and ISO week numbers. Thanks, poirier. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17473 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:57:31 +00:00
Jannis Leidel
b926765a7c Fixed #16035 -- Appended the Etag response header if the GZipMiddleware is in use to follow RFC2616 better. Thanks, ext and dracos2. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17471 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:57:13 +00:00
Jannis Leidel
4b71c9998e Fixed #15840 -- Wrapped inner function of the condition decorator with functools.wraps to follow best practices. Thanks, zsiciarz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17470 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:57:06 +00:00
Jannis Leidel
49288f8388 Fixed #11970 -- Wrapped the exception happening during deserialization in DeserializationError exceptions. Thanks, Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17469 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:56:58 +00:00
Jannis Leidel
538257b4ae Fixed #10080 -- Slightly extended the fix made in r10401 by also taking command line options into account that don't have have a default set. Thanks, Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17467 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:56:41 +00:00
Jannis Leidel
b46d90c63a Fixed #7758 and #17189 -- Allowed to override the form_url context var in the admin change view and the user admin's password change view. Thanks, michal and krzysztof.szczesny. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17466 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:56:32 +00:00
Jannis Leidel
03eeb020a0 Fixed #159 -- Prevent the AdminSite from logging users out when they try to log in form the logout page. Many thanks, ashchristopher. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17465 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:56:23 +00:00
Aymeric Augustin
bd58612514 Fixed #17634 -- Optimized the performance of MultiValueDict by using append instead of copy and by minimizing the number of dict lookups. Refs #736. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17464 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-09 18:41:20 +00:00
Aymeric Augustin
175e6d77df Fixed #11745 -- Grouped commands by application in the output of manage.py help. Made 'version' consistent with 'help' while I was in the area, and added tests. Thanks Jannis for the feedback and review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17462 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-07 18:46:29 +00:00
Julien Phalip
0f6cf4aba1 Improved on r17454 to ensure that collapse.js only gets minified when DEBUG is False. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17455 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-05 10:26:05 +00:00
Julien Phalip
a90aad3511 Fixed #17521 -- Made the minified JS files be used in the admin only when DEBUG is False. Thanks to Travis Swicegood for the suggestion and patch, and to viciu for the tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17454 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-05 08:35:08 +00:00
Julien Phalip
ad8ebb7006 Fixed #8317 -- Corrected the inspectdb management command to properly set primary_key=True and unique=True on foreign keys. Thanks to bthomas for the report and patch, and to David Gouldin for the tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17451 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-05 07:51:37 +00:00
Julien Phalip
d02ba7f4ee Fixed #11670 -- Prevented genuine model fields named 'year', 'month', 'gt', 'lt' etc. from being mistaken for lookup types in lookups across relations. Thanks to andy for the report, to jpwatts for the initial patch and to Anssi Kääriäinen and Alex Gaynor for the reviews. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17450 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-05 07:11:53 +00:00
Julien Phalip
d3154d1896 Fixed #8291 -- Allowed 'pk' to be used as an ordering option in Model.Meta. Thanks to peterd12 for the report and to evan_schulz, gruszczy, frog32 and David Gouldin for their work on the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17445 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 19:56:40 +00:00
Jannis Leidel
ef4d84d11a Fixed #17555 -- Added support for a missing trailing slash when redirecting based on the browser language. Thanks, neaf. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17443 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 18:43:20 +00:00
Jannis Leidel
878cc62bd4 Added with_statement import forgotten in r17434. Thanks to Julien for noticing. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17442 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 18:27:32 +00:00
Jannis Leidel
c6065545ef Fixed #17628 -- Extended makemessages command to also ignore directories when walking, not only when looking for files. Thanks, Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17441 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 18:27:24 +00:00
Jannis Leidel
62efdcb037 Fixed #17602 -- Stopped the XML serializer from doing unneeded queries. Thanks, gnosek. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17439 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 18:27:07 +00:00
Jannis Leidel
2b0c1ea641 Fixed #17527 -- Improved exception message when adding the wrong type of object to a ManyToManyField. Thanks, guettli and cClaude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17437 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 16:06:09 +00:00
Jannis Leidel
56d787df99 Fixed #17542 -- Gracefully handle errors when checking if the values of a SelectDateWidget has changed if it's not required. Thanks, pigletto. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17436 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 16:05:58 +00:00
Jannis Leidel
e734477bd7 Fixed #17592 -- Handle URLs starting with a dot when using urlize. Thanks, Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17435 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 16:05:48 +00:00
Jannis Leidel
4d8a0f8902 Fixed #17594 -- Stopped ModelFormset.save from running a SELECT query by relying on the fact that the initial form is already set. Thanks, tswicegood. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17434 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 16:05:39 +00:00
Jannis Leidel
faeee611d6 Fixed #17517 -- Added --name option to startproject and startapp management commands to be able to render files without a file extension. Thanks, Florian Apolloner. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17432 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 13:01:30 +00:00
Jannis Leidel
bb6921ce88 Fixed #17596 -- Stopped the AdminField class from double quoting its label. Thanks, guettli and claudep. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17431 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 12:48:21 +00:00
Jannis Leidel
9c045d00dc Fixed #14184 -- Enabled running the validators in MultiValueFields. Thanks, paulcollins. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17430 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-04 12:48:12 +00:00
Adrian Holovaty
6ecadcbdd2 Made a bunch more edits up until [17418] 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17428 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-03 20:45:45 +00:00
Paul McMillan
1030d66a14 Fixed #17481. pbkdf2 hashes no longer ommit leading zeros. 
Some existing user passwords may need to be reset or converted 
after this change. See the 1.4-beta release notes for more details.

Thanks bhuztez for the report and initial patch, claudep for the test.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17418 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-02-02 04:44:17 +00:00
Carl Meyer
844a24bbb9 Fixed #16921 -- Added assertHTMLEqual and assertHTMLNotEqual assertions, and converted Django tests to use them where appropriate. Thanks Greg Müllegger. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17414 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-31 20:36:11 +00:00
Aymeric Augustin
c82f1dcf95 Skipped the test introduced at r17403 on Python 2.5, because it requires warnings.catch_warnings. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17413 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-31 19:47:40 +00:00
Carl Meyer
a678e9ea65 Fixed #17604 - Added context-manager capability to assertTemplateUsed and assertTemplateNotUsed. Thanks Greg Müllegger. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17412 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-31 19:23:09 +00:00
Aymeric Augustin
d9061c01a9 Fixed #5964 -- Added unicode-aware versions of urlunquote and urlunquote_plus. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17407 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-29 09:00:12 +00:00
Aymeric Augustin
1cc800783c Fixed #5968 -- Allowed (un-)registering with databrowse several models at once. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17405 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-28 20:54:48 +00:00
Aymeric Augustin
58bcb7d161 Caught (and tested) the warning added at r17393 in the corresponding test. Refs #17580. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17403 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-28 20:34:02 +00:00
Jannis Leidel
8f168976d6 Fixed #17580 -- Made sure datetime.date instances are correctly handled when being passed to a DateTimeField fields and the timezone support is enabled by making it aware using the default timezone. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17392 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-24 10:00:39 +00:00
Julien Phalip
6ae393d74d Fixed #15092 -- Made {% now %} work with single-quoted string arguments. Thanks to ninja_otoko for the report and to steveire, Aymeric Augustin and Claude Paroz for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17391 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-24 08:02:34 +00:00
Aymeric Augustin
7beb0db79b Fixed #10320 -- Made it possible to use executemany with iterators. Thanks MockSoul for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17387 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-22 16:41:20 +00:00
Aymeric Augustin
905e33f84a Fixed #16885 -- Confirmed features of mirror databases when setting up test databases. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17382 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-20 23:15:22 +00:00
Jannis Leidel
aef0283f89 Fixed #17468 -- Made sure the project/app template management command tests correctly handle an existing directory on Windows. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17377 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-15 16:06:56 +00:00
Ramiro Morales
665ec600a4 Made email attachment handling code accept non-ASCII filenames. 
Thanks to Anton Chaporgin for the report and to Claude Paroz for the patch.

Fixes #14964.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17375 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-15 02:33:31 +00:00
Ramiro Morales
c5dcba4159 Made dictsort and dictsort reversed template filters fail silently 
when passed list of things that aren't dictionaries.

Thanks Harris Lapiroff for the report and Daniel Barreto for the patch.

Fixes #15652.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17374 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-15 02:01:21 +00:00
Ramiro Morales
e308cfc0e1 Added support for specifying initial values to model formsets and inline formsets. 
This make them consistent with the similar capability of regular
formsets. Thanks to simon29 form the report and to Claude Paroz for the
patch.

Fixes #14574.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17373 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-15 01:36:14 +00:00
Luke Plant
4e29b70b9d Fixed #17530 - Fixture loading with deferred constraints broken for Postgres for fixtures from multiple dirs/files 
Thanks to claudep for the review.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17372 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-14 17:26:32 +00:00
Aymeric Augustin
30c846bf3d Fixed #6669 -- Ensured database connections are marked as dirty by CursorDebugWrapper.execute/executemany. Refs #9964. Thanks james at 10gic net for the report and Claude Paroz for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17368 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-12 21:55:19 +00:00
Aymeric Augustin
4288c8831b Fixed #10762, #17514 -- Prevented the GZip middleware from returning a response longer than the original content, allowed compression of non-200 responses, and added tests (there were none). Thanks cannona for the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17365 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-09 21:42:03 +00:00
Aymeric Augustin
62766f4248 Reverted parts of r17359 that could cause false positives in URL detection, especially on file names. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17364 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 21:36:22 +00:00
Aymeric Augustin
19c544ff42 Fixed #17300 -- Prevented createcachetable from crashing when the cache table already exists. Thanks Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17363 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 20:00:30 +00:00
Aymeric Augustin
15d10a5210 Fixed #11911 -- Made the urlize filter smarter with closing punctuation. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17362 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 19:42:14 +00:00
Aymeric Augustin
78c92c4167 Tested that spaces are properly escaped in files URLs. Refs #5160. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17361 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 19:23:57 +00:00
Aymeric Augustin
05a3ecbf96 Fixed #16656 -- Changed the urlize filter to accept more top-level domains. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17359 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 16:08:43 +00:00
Aymeric Augustin
27508918fb Fixed #16395 -- Prevented urlize from highlighting some malformed URLs. Thanks BernhardEssl for the report and initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17358 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 15:43:32 +00:00
Aymeric Augustin
40f0ecc56a Implemented PEP386-compatible version numbers. Thanks Jannis for the guidance. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17357 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 15:05:15 +00:00
Aymeric Augustin
aa4e152296 Fixed #12183 -- Made the urlize filter insert the nofollow attribute properly when an http: URL occurs after a mailto: URL. Thanks eronen for the report. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17356 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-08 09:51:36 +00:00
Aymeric Augustin
ca187fea88 Fixed #17513 -- Prevented the MySQL backend from leaking MySQLdb-specific exceptions. Thanks Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17352 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 19:53:20 +00:00
Aymeric Augustin
aa5d307da6 Fixed #17100 -- Typo in the regex for EmailValidator. Thanks reames AT asymmetricventures com for the report and Claude Paroz for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17349 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 18:43:46 +00:00
Aymeric Augustin
f21a9da485 Fixed #13704 -- Handled IDN properly in the urlize template filter. Thanks Claude Paroz for the initial version of the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17348 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 18:39:14 +00:00
Aymeric Augustin
e3a7bfccbb Fixed #9655 -- Prevented the urlize template filter from double-quoting URLs. Thanks Claude Paroz for writing the tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17347 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 18:15:28 +00:00
Aymeric Augustin
c3697a091b Fixed #10756 -- Error in the formats accepted by PLNIPField. Thanks remik for the report, michalm for the patch and claudep for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17346 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 11:17:44 +00:00
Aymeric Augustin
56b37bf1cf Fixed #17499 -- Ensured assertFieldOutput works for fields that customize the "required" error message. Thanks dpifke for the report and patch, and claudep for the tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17345 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-07 10:26:29 +00:00
Ramiro Morales
8312b85c97 Added support for savepoints to the MySQL DB backend. 
MySQL provides the savepoint functionality starting with version 5.0.3
when using the MyISAM storage engine.

Thanks lamby for the report and patch.

Fixes #15507.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17341 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-05 00:45:31 +00:00
Carl Meyer
bc63ba700a Fixed #17503 -- A destination directory passed to startproject or startapp as optional second argument is now reused as the project/app directory, rather than a new project/app directory created within it. Refs #17042. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17340 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-04 23:55:34 +00:00
Chris Beaven
e52c52ea13 Fixed #17492 -- Allow reversal of named backreferences. Thanks nate_b 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17336 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-03 22:49:13 +00:00
Aymeric Augustin
e5719b203c Fixed #17496 -- Regression in the floatformat template filter, introduced by the fix for #15789. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17335 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-03 13:09:12 +00:00
Julien Phalip
c93933441e Fixed #17429 -- Ensured that Meta.ordering=None works the same if it were an empty list. Thanks to self[at]dicos[dot]ru for the report and to bigkevmcd for the patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17334 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-03 09:06:19 +00:00
Julien Phalip
31b1cbc623 Fixed #16340 -- Made get_or_create() re-raise any IntegrityError with its original traceback. Thanks to d0ugal and Jonas Obrist. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17333 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-02 21:30:47 +00:00
Aymeric Augustin
fc9e0606d5 Fixed a stupid bug in the implementation of timezone.make_aware. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17332 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-02 20:45:09 +00:00
Julien Phalip
1572a3d4b2 Fixed #10931 -- Made Truncator handle newlines properly. Thanks to gsong and Claude Paroz. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17329 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-02 18:47:18 +00:00
Alex Gaynor
1aaa0dd098 Fix the dispatch test GC code under PyPy, and make the comment for Jython better. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17322 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-01 21:11:05 +00:00
Aymeric Augustin
b9910bddd2 Fixed #17488 -- This test passed in 2011 only because 2012-01-01 is a Sunday. Thanks Florian Apolloner for the report and patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17321 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-01 20:59:09 +00:00
Ramiro Morales
f250ef3573 Made sure startproject can handle template URLs with trailing slashes. 
Thanks Issac Kelly that reported this via IRC.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17320 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2012-01-01 17:45:40 +00:00
Paul McMillan
143fa9193c Improved comment formatting to appease Gaynor. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17311 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-30 20:43:01 +00:00
Paul McMillan
1fed65224f Increased pbkdf2 scaling test vectors to lower chance of false test failures. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17308 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-30 20:35:44 +00:00
Aymeric Augustin
c458700382 Fixed #16590 -- Accepted a 'name' argument in the constructor of ContentFile, for consistency with File. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17298 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-30 14:51:05 +00:00
Aymeric Augustin
27444618f6 Fixed #15789 -- Set the decimal precisio to avoid an exception in the floatformat filter, and added a few more tests. Thanks akaihola for the report, igalarzab for the patch and ptone for the review. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17297 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-30 14:35:29 +00:00
Aymeric Augustin
5e75678c8b Fixed #17444 -- Made it possible to customize the 'To' header in emails. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17293 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-30 12:44:35 +00:00
Julien Phalip
0bf2d33770 Added the ability to specify multiple ports available for the LiveServerTestCase WSGI server. This allows multiple processes to run the tests simultaneously and is particularly useful in a continuous integration context. Many thanks to Aymeric Augustin for the suggestions and feedback. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17289 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-29 20:22:13 +00:00
Ramiro Morales
a82204fa9a Moved validation of project names to an earlier spot so no directory with invalid name is created. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17288 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-29 19:06:57 +00:00
Ramiro Morales
f185024fc4 Made sure the new project template functionality works when the template 
path specified has a trailing path separator.

Thanks Alex for the report.

Fixes #17475.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17287 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-29 17:03:38 +00:00
Aymeric Augustin
3367913c3d Fixed #17476 -- Ensure timezone-dependant cache keys only use ASCII characters, especially on Windows. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17286 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-29 13:57:32 +00:00
Ramiro Morales
953a471a21 Made sure manage.py help test works. 
Thanks shige DOT abe AT nasa DOT gov for the report.

Fixes #17477. Refs r16352.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17284 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-29 01:18:30 +00:00
Julien Phalip
a343a84ce6 Added the wait_until() and wait_loaded_tag() methods to AdminSeleniumWebDriverTestCase to prevent some concurrency issues with in-memory SQLite database access in the admin Selenium tests. Thanks to Florian Apolloner, Anssi Kääriäinen and Aymeric Augustin for their help debugging this problem. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17283 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-28 22:20:30 +00:00
Jannis Leidel
46c12d1293 Fixed #17455 -- Extended CachedStaticFilesStorage slightly to handle some URLs better that are used to add support for webfonts to IE 6-8. Also ignore data: URLs and fragment-only URLs (e.g. #default#VML). 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17282 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 22:49:24 +00:00
Aymeric Augustin
ae0ce4373f Moved calls to addCleanup before assertions in admin_scripts tests, so that cleanup occurs even when tests fails. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17281 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 15:35:41 +00:00
Aymeric Augustin
12206bdf0f Fixed a test that was failing under Windows. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17280 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 15:04:05 +00:00
Aymeric Augustin
cac7818e5e Removed Python 2.3 compatibility code from the admin_scripts tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17279 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 14:54:00 +00:00
Aymeric Augustin
a62ce30661 Fixed #17463 -- Conditionally skipped tests that Windows isn't able to run. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17278 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 09:28:50 +00:00
Aymeric Augustin
e8a6fee6e6 Fixed a CacheKeyWarning under Windows. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17277 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-27 08:22:55 +00:00
Karen Tracey
5df784ab42 Fixed deletion of the runtests temp tree to work on Windows even when the tree contains non-ASCII filenames. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17275 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-25 18:53:29 +00:00
Jannis Leidel
db2b1458b1 Fixed #17047 -- Improved django.db.utils.load_backend to raise a better exception when using a unqualified database backend name. Thanks, Jonas Obrist. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17274 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-25 13:24:39 +00:00
Jannis Leidel
ff1f423d29 Fixed a few tests to run on Python 2.5. Thanks, Florian Apolloner. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17273 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-25 12:47:13 +00:00
Aymeric Augustin
91f5970bb4 Added a lower level test for numberformat when grouping is 0 and force_grouping is True. Thanks Claude Paroz. Refs #17414. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17268 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-24 11:15:26 +00:00
Paul McMillan
90e05aaeac Renovated password hashing, including the forgotten files in r17253. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17254 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-23 03:53:56 +00:00
Paul McMillan
dce820ff70 Renovated password hashing. Many thanks to Justine Tunney for help with the initial patch. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17253 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-23 03:46:06 +00:00
Gabriel Hurley
a0721a3017 Fixed #15900 -- Calls to reverse with nested namespaced urls are escaped properly and capture parameters as expected. 
Thanks to teolicy for the report, and dmclain for the patch.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@17251 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-22 23:03:48 +00:00
Jannis Leidel
a9a0f0b03f Fixed #17042 -- Extended startproject and startapp management commands to better handle custom app and project templates. Many thanks to Preston Holmes for his initial patch and Alex Gaynor, Carl Meyer, Donald Stufft, Jacob Kaplan-Moss and Julien Phalip for code reviewing. 
* Added ability to pass the project or app directory path as the second argument
* Added ``--template`` option for specifying custom project and app templates
* Cleaned up admin_scripts tests a little while I was there

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17246 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-22 22:38:02 +00:00
Ramiro Morales
287565779d Added support for modifying the effect of `DISTINCT` clauses so they 
only consider some fields (PostgreSQL only).

For this, the ``distinct()`` QuerySet method now accepts an optional
list of model fields names and generates ``DISTINCT ON`` clauses on
these cases. Thanks Jeffrey Gelens and Anssi Kääriäinen for their work.

Fixes #6422.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@17244 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-22 20:42:40 +00:00
Jannis Leidel
03eb2907d5 Re-enabled the cleanup of STATIC_ROOT in the staticfiles tests. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17243 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-22 20:29:18 +00:00
Julien Phalip
2f02a05ffb Fixed #2879 -- Added support for the integration with Selenium and other in-browser testing frameworks. Also added the first Selenium tests for contrib.admin. Many thanks to everyone for their contributions and feedback: Mikeal Rogers, Dirk Datzert, mir, Simon G., Almad, Russell Keith-Magee, Denis Golomazov, devin, robertrv, andrewbadr, Idan Gazit, voidspace, Tom Christie, hjwp2, Adam Nelson, Jannis Leidel, Anssi Kääriäinen, Preston Holmes, Bruno Renié and Jacob Kaplan-Moss. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17241 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-22 08:33:58 +00:00
Julien Phalip
45e3dff5ac Ensured that makemessages doesn't leave any temporary file over if the parsing of a template file fails. Refs #8536. 
git-svn-id: http://code.djangoproject.com/svn/django/trunk@17240 bcc190cf-cafb-0310-a4f2-bffc1f526a37
 2011-12-21 15:35:58 +00:00