Hopiu/django
1
0
Fork 0
mirror of https://github.com/Hopiu/django.git synced 2026-05-11 17:13:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
18254 commits 1 branch 0 tags 216 MiB
Commit graph

5667 commits

Author SHA1 Message Date
Ramiro Morales
b785a80d19 Added further fixes, tests for #19949/f33db5a09a. 
Thanks Susan Tan. Refs #19949.
 2013-08-26 08:47:24 -03:00
Ramiro Morales
51a9a5980a Made coverage ignore files without associated source code. 
This only affests reporting not data collection and allows coverage.py
to succesfully finish the generation of e.g. the HTML report.

Cases of code whose execution data is collected during the run phase but
for which no associated source code files can be found at the reporting
phase include tests with egg files and Python module files created at
test execution-time.
 2013-08-25 22:29:43 -03:00
Ramiro Morales
72712755c4 Ignore coverage HTML report output dir in tests. 
Added it to the list of dirs ignored by tests/runtests.py.
 2013-08-25 19:09:03 -03:00
Christopher Medrela
32a962bdbf Fixed #20814 -- Improved model field accessor clash error messages 
Thanks shai for the suggestion.
 2013-08-24 18:00:23 -04:00
Claude Paroz
f4e9804567 Fixed #20961 -- Fixed HttpResponse default empty content 
Thanks epandurski at gmail.com for the report.
 2013-08-24 18:10:12 +02:00
SusanTan
f33db5a09a Fixed 19949 -- Cached template loader now caches TemplateDoesNotExist 
Thanks @timgraham and @jdunck for the code reviews and Kronuz for bug
report and initial patch.
 2013-08-24 09:19:55 -04:00
Alex Gaynor
8363406dad Removed usage of u"" string prefix, which doesn't work on python3.2 2013-08-23 04:56:37 -07:00
Andrew Godwin
5569b0b92f Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/oracle/base.py
	django/db/backends/postgresql_psycopg2/base.py
	django/db/models/signals.py
	tests/queries/tests.py
 2013-08-23 12:36:53 +01:00
Andrew Godwin
ac45f9c9c5 Fix some small errors in the tests 2013-08-23 12:07:43 +01:00
Tim Graham
b0ce6fe656 Fixed #20922 -- Allowed customizing the serializer used by contrib.sessions 
Added settings.SESSION_SERIALIZER which is the import path of a serializer
to use for sessions.

Thanks apollo13, carljm, shaib, akaariai, charettes, and dstufft for reviews.
 2013-08-22 13:58:26 -04:00
Lukasz Balcerzak
9d1987d767 Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices 2013-08-22 11:50:52 -04:00
Rainer Koirikivi
65cf82bd08 Fixed #20934 -- Avoided NoReverseMatch in ModelAdmin.changelist_view 
The view tried to display links to a ModelAdmin's change_view, which
resulted in NoReverseMatches if get_urls was overridden to remove the
corresponding url.
 2013-08-22 10:08:54 -04:00
Anssi Kääriäinen
6af05e7a0f Fixed model.__eq__ and __hash__ for no pk value cases 
The __eq__ method now considers two instances without primary key value
equal only when they have same id(). The __hash__ method raises
TypeError for no primary key case.

Fixed #18864, fixed #18250

Thanks to Tim Graham for docs review.
 2013-08-22 17:24:07 +03:00
Anssi Kääriäinen
8d65b6082c Fixed #20955 -- select_related regression 
In cases where the same connection (from model A to model B along the
same field) was needed multiple times in a select_related query, the
join setup code mistakenly reused an existing join.
 2013-08-22 10:51:07 +03:00
Tim Graham
3f416f6379 Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c7364a11f6 Switched mail tests to SimpleTestCase. 2013-08-21 22:32:04 +01:00
Ramiro Morales
8e571e5f8f Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
244e2b71f5 Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c5fbd16362 Import test case classes from their public API module. 2013-08-21 22:32:04 +01:00
Ramiro Morales
01223840f3 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-21 22:32:04 +01:00
Florian Apolloner
839940f27f Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
3a8ae71ab5 Fixed invalid testing fixture 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
f5552571dc Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
ced3e6b17d Fixed test failure caused by different NULL ordering between backends 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
cea7204504 Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-21 22:30:46 +01:00
Anssi Kääriäinen
b773ef8fa0 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-21 22:30:45 +01:00
Simon Charette
63378163f9 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-21 22:30:45 +01:00
Simon Charette
77478d84ad Fixed an aggregation test failure on MySQL. 2013-08-21 22:30:02 +01:00
Andrew Godwin
2e7f45a372 Change autodetector changes API to be just one method 2013-08-21 22:25:15 +01:00
Tim Graham
f7290581fe Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 08:30:21 -04:00
Ramiro Morales
a5cf5da50d Switched mail tests to SimpleTestCase. 2013-08-21 07:48:16 -03:00
Ramiro Morales
ececbe77ff Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 07:44:20 -03:00
Anssi Kääriäinen
b065aeb17f Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 08:32:19 +03:00
Ramiro Morales
deebb1a977 Import test case classes from their public API module. 2013-08-20 22:23:41 -03:00
Ramiro Morales
f9d1d5dc13 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-20 22:17:26 -03:00
Florian Apolloner
96346ed5ad Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-20 21:25:57 +02:00
Anssi Kääriäinen
86f4459f9e Fixed invalid testing fixture 2013-08-20 17:48:02 +03:00
Anssi Kääriäinen
1ed77e7782 Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-20 16:54:05 +03:00
Anssi Kääriäinen
8dc76c4b91 Fixed test failure caused by different NULL ordering between backends 2013-08-20 11:33:44 +03:00
Anssi Kääriäinen
905409855c Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-20 10:55:00 +03:00
Anssi Kääriäinen
b53ed351b3 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-20 09:50:37 +03:00
Simon Charette
e55ca60903 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-20 01:53:58 -04:00
Simon Charette
fdbf492946 Fixed an aggregation test failure on MySQL. 2013-08-19 20:39:30 -04:00
Andrew Godwin
b6a957f0ba Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	docs/ref/django-admin.txt
 2013-08-19 18:30:48 +01:00
Rainer Koirikivi
3c03004050 Fixed #20640 -- Avoided NoReverseMatch in get_deleted_objects 
The default delete action resulted in a NoReverseMatch if it were to
list any Model with a ModelAdmin with `get_urls` overridden to remove
the change url.  Catching the error and not displaying the link in that
case, as was already done for models with no registered admins.

Thanks Keryn Knight for the report.
 2013-08-19 12:01:33 -04:00
Anssi Kääriäinen
58c6d0209d Fixed #12807 -- EmptyResultSet ORed condition 
The EmptyResultSet wasn't treated correctly so the end results was
incorrect, too. The bug had been already fixed in master so only tests
added.
 2013-08-19 16:24:45 +03:00
Anssi Kääriäinen
7bc57a6d71 Fixed #11881 -- removed junk from aggregation subqueries 
There were clauses that weren't needed in the subqueries. These were
ORDER BY, SELECT FOR UPDATE and related selections.
 2013-08-19 16:15:09 +03:00
Anssi Kääriäinen
7737305a4f Fixed #12886 -- aggregation over sliced queryset 2013-08-19 16:00:17 +03:00
Andrew Godwin
52edc16086 Add more stringent M2M tests and fix the bug they exposed 2013-08-19 13:50:26 +01:00
Anssi Kääriäinen
7d28bed13b PEP 8 cleanup 2013-08-19 14:16:10 +03:00
Anssi Kääriäinen
630b9df42f Fixed #12567 -- Incorrect SQL in model inheritance case 
An isnull lookup produced incorrect SQL. This was already fixed
earlier, so only tests added.
 2013-08-19 14:10:03 +03:00
Anssi Kääriäinen
3844089edc Fixed #20777 -- Admin proxy model deletion regression 
Added proxy_models tests by Harm Geerts <github@geertswei.nl>.
 2013-08-19 09:51:41 +03:00
Anssi Kääriäinen
4668c142dc Made Model.__eq__ consider proxy models equivalent 
Fixed #11892, fixed #16458, fixed #14492.
 2013-08-19 09:51:28 +03:00
Alex Gaynor
aa01c99f55 Merge pull request #1479 from nickbruun/ticket_20924 
Proxy __len__ and __contains__ for LazyObject
 2013-08-18 09:41:43 -07:00
Claude Paroz
165f44aaaa Combine consecutive with statements 
Python 2.7 allows to combine several 'with' instructions.
 2013-08-16 20:12:10 +02:00
Alasdair Nicol
22c6497f99 Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value 
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
 2013-08-15 19:47:26 -04:00
Nick Bruun
b9ef96e73c Regression test and patch for ticket #20924. 2013-08-15 20:59:58 +02:00
Jonathan Slenders
ff410565bf Fixed #20709 -- Allowed {% widthratio %} to accept an "as" parameter. 
Thanks clay.evil@ for the suggestion.
 2013-08-14 12:40:19 -04:00
Florian Apolloner
4e50e40654 Removed unneeded conditional_escapes from the testsuite. 2013-08-13 22:22:46 +02:00
Andrew Godwin
157604a87f Oracle schema backend, passes most tests and is pretty complete. 2013-08-13 20:54:57 +01:00
Matt Johnson
907ef9d0d1 Fixed #20555 -- Make subwidget id attribute available 
In `BoundField.__iter__`, the widget's id attribute is now passed to
each subwidget. A new id_for_label property was added to ChoiceInput.
 2013-08-13 13:23:05 -04:00
Jacob Kaplan-Moss
cbe6d5568f Apply autoescaping to AdminURLFieldWidget. 
This is a security fix; disclosure to follow shortly.
 2013-08-13 11:06:41 -05:00
Anssi Kääriäinen
09a5f5aabe Fixed test failure on MySQL 
The fix for #20874 caused a MySQL specific failure.
 2013-08-13 15:37:08 +03:00
Loic Bistuer
163a34ce4b Fixed #20883 -- Made model inheritance find parent links in abstract parents 2013-08-13 15:14:11 +03:00
Anssi Kääriäinen
dcdc579d16 Fixed #20874 -- bump_prefix() in nested subqueries 
Also made some cleanup to build_filter() code by introducing submethods
solve_lookup_type() and prepare_lookup_value().
 2013-08-13 14:11:52 +03:00
Ramiro Morales
6c12cd15e9 Unlocalize line numbers and ids in debug 500 view. 
While using USE_L10N, line numbers and IDs were printed as comma (or
locale equivalent) separated values.

Thanks Kronuz for the report and intial patch.

Fixes #20861.
 2013-08-12 21:59:27 -03:00
Tim Graham
71b5617c24 Fixed #17778 -- Prevented class attributes on context from resolving as template variables. 
Thanks KyleMac for the report, regebro for the patch, and Aymeric for the test.
 2013-08-12 12:41:39 -04:00
Mel Collins
6bdb3b1135 Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting 
This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.

Thanks jacob@ for the suggestion.
 2013-08-12 07:15:59 -04:00
Andrew Godwin
b61b634628 Fix weird planning issues when already fully migrated. 2013-08-11 15:28:51 +01:00
Andrew Godwin
ae19315b4d Support index_together during model creation 2013-08-11 14:23:31 +01:00
Ramiro Morales
22af1394c6 Expand testing of Test LiveServerTestCase static files serving. 2013-08-10 16:32:07 -03:00
Ramiro Morales
cb92e3391b Test that django.views.static.serve() generates 404 status codes. 
Also, change tests to be based on SimpleTestCase.
 2013-08-10 16:00:22 -03:00
Bojan Mihelac
0cac4fbf69 Fixed #18356 -- Gave the test client signals.template_rendered call a unique dispatch_uid 
This prevents the test client context from being lost when the client
is used in a nested fashion.
 2013-08-09 12:22:42 -04:00
Andrew Godwin
588b523233 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/options.py
 2013-08-09 14:37:37 +01:00
Andrew Godwin
de64c4d6e9 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/core/management/commands/flush.py
	django/core/management/commands/syncdb.py
	django/db/models/loading.py
	docs/internals/deprecation.txt
	docs/ref/django-admin.txt
	docs/releases/1.7.txt
 2013-08-09 14:17:30 +01:00
Tim Graham
9c711ee3a6 Fixed test failures on Python 3 - refs #12288 2013-08-09 09:12:15 -04:00
Tim Graham
b575d690bb Fixed test failures introduced by #12288 2013-08-09 08:34:37 -04:00
SusanTan
2ac89012d8 Fixed #12288 -- Added unique validation for INSTALLED_APPS 2013-08-09 08:08:34 -04:00
Marc Tamlyn
1c4a9bd9ad Revert change to the default Form.clean() 
This means it doesn't break for people who are doing
`cleaned_data = super(FooForm, self).clean()`.
 2013-08-08 14:27:48 +01:00
Marc Tamlyn
fb1dd6b13a Form.clean() does not need to return cleaned_data. 
If it does, that will be used as the cleaned_data. The default
implementation has been changed to match this change.
 2013-08-08 14:05:55 +01:00
Anssi Kääriäinen
c7739e30b2 Fixed #17424 -- annotate() + exclude() bug 
The bug was already fixed by 01b9c3d519,
so only tests added.

At the same time promote_joins()'s uncoditional flag is gone, it isn't
needed for anything any more.
 2013-08-07 12:53:33 +03:00
Collin Anderson
d53e574676 Fixed #20865 -- Fixed raw_id_fields to work with callable limit_choices_to. 2013-08-06 13:41:52 -04:00
Alex Cucu
1c64a0f29e Fixed #19918 -- Modified select_for_update to run on the write database. 2013-08-06 09:50:59 -04:00
Tai Lee
1280675834 Fixed #15511 -- Allow optional fields on `MultiValueField subclasses. 
The `MultiValueField` class gets a new ``require_all_fields`` argument that
defaults to ``True``. If set to ``False``, individual fields can be made
optional, and a new ``incomplete`` validation error will be raised if any
required fields have empty values.

The ``incomplete`` error message can be defined on a `MultiValueField`
subclass or on each individual field. Skip duplicate errors.
 2013-08-06 08:50:47 -04:00
Marc Tamlyn
0b771fcf29 Merge pull request #1441 from loic/ticket16986 
Fixed #16986 -- Model.clean() can report errors on individual fields.
 2013-08-06 02:10:45 -07:00
Anssi Kääriäinen
263b873599 Fixed ordering related test failure 
Also PEP8 + python_2_unicode_compatible cleanup done.
 2013-08-06 10:07:52 +03:00
Loic Bistuer
71093d22b6 Fixed #16986 -- Model.clean() can report errors on individual fields. 
This commit provides the tests for this issue but the actual problem was solved
by the ValidationError refactor in f34cfec and ee77d4b.

Refs #20199.
 2013-08-06 02:26:51 +07:00
Tim Graham
04489c7dbf Fixed #17667 -- Prevented app loading from skipping nonexistent apps after the first try 
Thanks ea2100@ for the report and akaariai for the patch.
 2013-08-05 13:34:35 -04:00
Tim Heap
75c87e2d38 Fixed #20850 -- Added MultiWidget.needs_multipart_form 2013-08-05 10:02:28 -04:00
Julien Phalip
f067887a4f Fixed some intermittent Selenium test failures. 2013-08-04 22:03:53 -07:00
Julien Phalip
995ffbb2a6 Added some Selenium tests for the admin raw id widget. 2013-08-04 16:08:45 -07:00
Loic Bistuer
ebb3e50243 Introduced ModelAdmin.get_fields() and refactored get_fieldsets() to use it. 
Refs #18681.

This also starts the deprecation of ModelAdmin.declared_fieldsets
 2013-08-04 09:14:18 -04:00
Curtis Maloney
07876cf02b Deprecated SortedDict (replaced with collections.OrderedDict) 
Thanks Loic Bistuer for the review.
 2013-08-04 07:09:39 -04:00
Aymeric Augustin
784377544e Fixed #20822 -- Set content type of default error pages to 'text/html'. 
Thanks Jimmy Song for the patch.
 2013-08-04 11:04:37 +02:00
Loic Bistuer
0bcdcc7eb9 Added ModelAdmin.get_search_fields. 2013-08-03 20:02:43 -04:00
Petr Dlouhý
1b47508ac8 Fixed LogEntry.get_admin_url() for non-existent models. 
Regression introduced by [369b6fa]; refs #18169.
 2013-08-02 12:51:10 -04:00
Loic Bistuer
a0ed2f9260 Fixed #18681 -- GenericInlineModelAdmin.get_formset() no longer bypasses get_fieldsets(). 
Refs 23e1b59 which already fixed this issue for ModelAdmin and InlineModelAdmin.
 2013-08-02 10:41:29 -04:00
Aleksandra Sendecka
893d8de6f5 Fixed #18777 -- Localized form fields with as_text/as_hidden 
Thanks croldan for the report.
 2013-08-02 08:41:54 -04:00
Tim Graham
aa830009de Fixed #17519 -- Fixed missing SQL constraints to proxy models. 
Thanks thibaultj for the report, jenh for the patch,
and charettes for the tests.
 2013-08-02 07:41:56 -04:00
Alex Couper
1123f45511 Fixed #20649 -- Allowed blank field display to be defined in the initial list of choices. 2013-07-31 14:12:03 -04:00
Will Hardy
1c3c21b38d Fixed #19987 -- Disabled host validation when DEBUG=True. 
The documentation promises that host validation is disabled when
DEBUG=True, that all hostnames are accepted. Domains not compliant with
RFC 1034/1035 were however being validated, this validation has now been
removed when DEBUG=True.

Additionally, when DEBUG=False a more detailed SuspiciousOperation
exception message is provided when host validation fails because the
hostname is not RFC 1034/1035 compliant.
 2013-07-31 10:38:59 -04:00
Loic Bistuer
acd1d439fd Fixed #20826 -- Moved Manager.raw() and Manager._insert() to the QuerySet class. 2013-07-31 09:54:00 -04:00
Florian Hahn
e888a9b30d Fixed #15624 -- Made sure aggregations are present in SELECT 2013-07-31 16:27:58 +03:00
Anssi Kääriäinen
e01b5a5823 Fixed #11521 -- usage of field.attname in .update() 
Fixed already by previous patch, only test added.
 2013-07-31 16:02:36 +03:00
Anssi Kääriäinen
c21e86ab9e Added field.attname to Options.name_map 
The change also removed allow_explicit_fk from sql/query.py.
 2013-07-31 16:02:36 +03:00
Tai Lee
31e6d58d46 Fixed #20348 -- Consistently handle Promise objects in model fields. 
All Promise objects were passed to force_text() deep in ORM query code.
Not only does this make it difficult or impossible for developers to
prevent or alter this behaviour, but it is also wrong for non-text
fields.

This commit changes `Field.get_prep_value()` from a no-op to one that
resolved Promise objects. All subclasses now call super() method first
to ensure that they have a real value to work with.
 2013-07-31 15:54:17 +03:00
SusanTan
ccf8f1e18f Added a test for AdminSite.app_index_template; refs #8498. 2013-07-31 06:59:15 -04:00
Tai Lee
4c6ffcf721 Fixed #20819 -- Return 404 instead of 500 error when `staticfiles` view is used in production. 2013-07-31 18:58:50 +10:00
Baptiste Mispelon
3c45fb8589 Fixed #10491 -- Allowed passing lazy objects to HttpResponseRedirect. 
Thanks liangent for the report.
 2013-07-30 13:39:44 -04:00
Tim Graham
8550df869b Removed part of a test that doesn't work on Jenkins; refs #19877. 2013-07-30 11:59:04 -04:00
Tim Graham
dffda2ba4e Fixed a test that depended on the DB backend; refs #19877. Thanks Loic. 2013-07-30 11:30:20 -04:00
Jose L. Patino
7b57e575c9 Fixed #19877 -- Added --no-color option to BaseCommand to avoid using output styles. 2013-07-30 09:26:18 -04:00
Andrew Godwin
fddc5957c5 Implement allow_migrate for migration operations 2013-07-30 12:34:31 +01:00
Andrew Godwin
12e9804d16 Rename allow_syncdb to allow_migrate 2013-07-30 12:08:59 +01:00
Julien Phalip
e351dbf6ee Fixed #19082 -- Enabled admin field pre-population for existing objects. 
Thanks to msaelices and d1ffuz0r for the initial patch and tests.
 2013-07-30 00:21:08 -07:00
Claude Paroz
5c1143910e Removed most of absolute_import imports 
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
 2013-07-29 20:28:13 +02:00
Claude Paroz
e4937b6dde Add utf-8 preamble to admin_scripts temp settings file 
As some settings are copied from current user settings, we cannot
be sure the characters are pure ascii.
 2013-07-29 17:10:23 +02:00
Claude Paroz
fdd7a355bf Deprecated django.utils.importlib 
This was a shim for pre-Python 2.7 support.
 2013-07-29 17:10:22 +02:00
Justin Michalicek
ac09558760 Fixed #20817 -- Added html_message parameter to django.core.mail.send_mail() 2013-07-29 09:53:47 -04:00
Przemek Lewandowski
382c53d7d8 Fixed #18213 -- Allowed empty fixtures (emit a warning rather than raising an exception). 2013-07-29 08:03:51 -04:00
Florian Apolloner
b70c371fc1 Simplified smart_urlquote and added some basic tests. 2013-07-28 10:05:39 +02:00
Julien Phalip
4e0ff35146 Fixed #11195 -- Added CSS classes to the changelist cells to allow style customizations. Thanks to akaihola, Ramiro Morales and vdboor for their work on the patch. 2013-07-27 19:50:02 -07:00
Julien Phalip
47c755327b Fixed a number of minor misspellings. 2013-07-27 18:46:03 -07:00
Florian Hahn
ca39c0a6be Fixed #18404 -- Added test for AppStaticStorage with non ascii path 
(bug was already fixed in #19357)
 2013-07-27 20:18:32 -04:00
Tim Graham
8676318d2d Fixed #20805 -- Removed an extra colon beside checkboxes in the admin. 
Thanks CollinAnderson for the report.
 2013-07-26 14:45:38 -04:00
Tim Graham
2a979d2a7b Updated contrib.admin to use Email/URLInputs; refs #16630 2013-07-26 07:22:30 -04:00
Anssi Kääriäinen
7cca8d56d2 Fixed related model lookup regression 
It has been possible to use models of wrong type in related field
lookups. For example pigs__in=[a_duck] has worked. Changes to
ForeignObject broke that.

It might be a good idea to restrict the model types usable in lookups.
This should be done intentionally, not accidentally and without any
consideration for deprecation path.
 2013-07-26 13:13:27 +03:00
Loic Bistuer
31fadc1202 Fixed #20625 -- Chainable Manager/QuerySet methods. 
Additionally this patch solves the orthogonal problem that specialized
`QuerySet` like `ValuesQuerySet` didn't inherit from the current `QuerySet`
type. This wasn't an issue until now because we didn't officially support
custom `QuerySet` but it became necessary with the introduction of this new
feature.

Thanks aaugustin, akaariai, carljm, charettes, mjtamlyn, shaib and timgraham
for the reviews.
 2013-07-26 12:41:27 +03:00
Carl Meyer
8f3aefdec3 Fixed handling of template loader tests. 
Previously, the CachedLoaderTests were never run at all.
 2013-07-25 17:19:17 -05:00
Andrew Godwin
a758c9c186 Add test for creating M2Ms 2013-07-25 16:36:58 +01:00
Anssi Kääriäinen
92476e880c Fixed ._meta.pk_index() virtual field failure 2013-07-25 16:25:23 +03:00
Andrew Godwin
00276e0414 Add tests for the migrate command and fix a bug they exposed 2013-07-25 13:52:35 +01:00
Anssi Kääriäinen
b2314d9e1e Fixed #19941 -- Modified runtests.py to make running the tests easier. 
1. Automatically use tests/../django as the Django version.
2. If settings aren't provided through --settings or DJANGO_SETTINGS_MODULE)
   then use test_sqlite.
 2013-07-24 07:33:03 -04:00
Tim Graham
31c13a99bb Fixed #14300 -- Fixed initial SQL location if models is a package. 
Thanks al_the_x for the report and fheinz for the draft patch.
 2013-07-24 06:56:33 -04:00
Tim Graham
65e03a424e Fixed #10284 -- ModelFormSet.save(commit=False) no longer deletes objects 
Thanks laureline.guerin@ and Wedg.
 2013-07-23 16:21:23 -04:00
Anssi Kääriäinen
c00a8525c6 Fixed #20788 -- exclude() generated subquery failure 
"Fixed" by adding a test case, the original problem was already fixed
by earlier ORM changes. Thanks to david@judicata.com for the report
and test case.
 2013-07-23 13:40:50 +03:00
Anssi Kääriäinen
4bd5554721 Fixed #20782 -- qs.values().aggregate() failure 
In the combination of .values().aggregate() the aggregate_select_mask
didn't include the aggregates added. This resulted in bogus query.

Thanks to Trac alias debanshuk for report.
 2013-07-23 11:38:38 +03:00
Andrew Godwin
162f7b938f Make migrate command recognise prefixes and 'zero'. 2013-07-22 19:43:58 +01:00
Andrew Godwin
52eb19b545 Make multi-app-cache tests work again 2013-07-22 19:36:03 +01:00
Andrew Godwin
03ec3219a0 Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/mysql/introspection.py
	django/db/backends/oracle/creation.py
	django/db/backends/postgresql_psycopg2/creation.py
	django/db/models/base.py
	django/db/models/loading.py
 2013-07-22 19:04:25 +01:00
Claude Paroz
02b0106d43 Fixed #20781 -- Fixed _has_changed regression with MultiValueField 
Thanks Tim Graham for the report.
 2013-07-22 09:06:07 +02:00
Thomas Sorrel
bb145e2c47 Fixed #13629 -- Added CSS classes to the <body> tag of some admin templates to allow style customizations per app or per model. 2013-07-21 20:17:14 +00:00
Claude Paroz
11b7b9ad00 Fixed an email validation regression 
Thanks Vincent Wagelaar for the report.
 2013-07-21 21:11:32 +02:00
Karen Tracey
3aad955ea8 Fixed #13696 -- ensured inline pk field is rendered 2013-07-21 13:06:11 -04:00
Simon Charette
415a36947c Fixed #20765 -- Set small values of step using exponential notation. 
Browsers parse small factors of 10 as 0 under decimal notation.

Thanks to Trac alias matklad for the report and Claude Paroz for the review.
 2013-07-19 23:31:15 -04:00
Claude Paroz
6d52844b9b Fixed #18551 -- Enabled skipIfDBFeature/skipUnlessDBFeature to decorate a class 
Thanks Tim Graham for the review and improved patch.
 2013-07-19 20:30:14 +02:00
Matt Deacalion Stevens
a269ea4fe0 Fixed #14656 -- Added Atom1Feed published element 
Some feed aggregators make use of the `published` element as well as
the `updated` element (within the Atom standard -- http://bit.ly/2YySb).

The standard allows for these two elements to be present in the same
entry. `Atom1Feed` had implemented the `updated` element which was
incorrectly taking the date from `pubdate`.
 2013-07-19 10:38:34 -04:00
Loic Bistuer
2fc6c9472c Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs. 
Thanks Collin Anderson for the report.
 2013-07-18 18:18:30 -04:00
Curtis Maloney
a3e7d73ed7 Allowed Context.push to behave as a context mananger. 
Thanks Loic Bistuer for the review.
 2013-07-17 13:32:32 -04:00
Tim Graham
2333c9662b Fixed #14007 -- Added model discovery in models module without the need to specify app_label. 
Thanks mark@ and Aramgutang for work on the patch.
 2013-07-16 19:32:30 -04:00
Tim Graham
2456ffa42c Fixed #20746 -- Removed Python 2.6 specific code/docs 2013-07-14 13:02:55 -04:00
Tim Graham
d9c580306c Fixed #20681 -- Prevented teardown_databases from attempting to tear down aliases 
Thanks simonpercivall.
 2013-07-13 17:46:05 -04:00
Tim Graham
9b471a8fe3 Fixed a deprecation warning in a selenium test. 2013-07-13 13:15:28 -04:00
Claude Paroz
73f86f4441 Isolated host validation tests in own test case 2013-07-13 10:16:52 +02:00
Tim Graham
f2cb94f1c0 Fixed #20740 -- GenericIPAddressField should pass protocol to formfield() 
Thanks Jeff250.
 2013-07-12 16:05:14 -04:00
Karol Sikora
6272d2f155 Fixed #20429 -- Added QuerySet.update_or_create 
Thanks tunixman for the suggestion and Loic Bistuer for the review.
 2013-07-12 08:26:35 -04:00
Joeri Bekker
66f3d57b79 Fixed #19031 -- Added a warning when using override_settings with 'DATABASES' 2013-07-12 07:10:18 -04:00
Claude Paroz
59ebe39812 Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend 
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
 2013-07-11 22:00:08 +02:00
Benjamin Kagia
b0953dc913 Fixed #13721 -- Added UploadedFile.content_type_extra. 
Thanks Waldemar Kornewald and mvschaik for work on the patch.
 2013-07-11 09:11:59 -04:00
Tim Graham
4d92a0bd86 Fixed #19196 -- Added test/requirements 2013-07-10 09:24:05 -04:00
Loic Bistuer
7e6d852bac Fixed #20663 -- "Today" and "now" admin shortcuts. 
Changed the shortcuts next to date and time intput widgets
to account for the current timezone.

Refs #7717, #14253 and #18768.
 2013-07-09 23:04:33 +02:00
Aymeric Augustin
404870ee1f Fixed #20724 -- Test failure on SQLite. 
This test failure happened if the connection's NAME was set to a file
system path, and its TEST_NAME wasn't.

Thanks Claude for the report.
 2013-07-09 21:41:30 +02:00
Aymeric Augustin
38bc581bc0 Avoided transaction.set_autocommit in tests. 
It doesn't work as one might expect on a certain database backend where
autocommits_when_autocommit_is_off = True. That backend happens to be
popular for running tests.
 2013-07-09 21:41:30 +02:00
Claude Paroz
57f190ed3b Only import gis test apps for geo-enabled DBs 2013-07-09 15:58:56 +02:00
Claude Paroz
bd563f0f57 Trusted test skipping about gis tests running or not 
With the new test discovery system, gis tests are discovered as
other tests. They should be properly skipped now when dependencies
are missing. So let's stop special casing their inclusion.
 2013-07-09 15:17:26 +02:00
Tim Graham
da79ccca1d Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows. 
Thanks Patryk Zawadzki.
 2013-07-08 08:33:40 -04:00
Alex Gaynor
626fa28878 Fixed #13813 -- Comparison of DatabaseWrappers doesn't raise errors. 
Patch from Lukasz Balcerzak.
 2013-07-08 09:35:08 +10:00
Tim Graham
2cbd579efe Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db. 
Thanks simonpercivall.
 2013-07-04 19:58:58 -04:00
Andrew Godwin
3a6580e485 Make get_constraints return columns in order 2013-07-02 18:02:20 +01:00
Andrew Godwin
61ff46cf8b Add AlterIndexTogether operation 2013-07-02 18:02:01 +01:00
Andrew Godwin
2202e3f7d3 Fix index_together test 2013-07-02 12:06:26 +01:00
Andrew Godwin
9ef715d256 Fix some bad test running under PostgreSQL 2013-07-02 11:51:38 +01:00
Andrew Godwin
6a8cfbf07b Support for index_together in schema backends 2013-07-02 11:43:44 +01:00
Andrew Godwin
3b20af3e96 Autodetection of unique_together changes 2013-07-02 11:25:18 +01:00
Andrew Godwin
67dcea711e Add unique_together altering operation 2013-07-02 11:19:02 +01:00
Andrew Godwin
310cdf492d Fix M2M interaction with transactions 2013-07-02 11:08:16 +01:00
Andrew Godwin
b1e0ec06f0 Merge branch 'master' into schema-alteration 2013-07-02 10:49:53 +01:00
Aymeric Augustin
e021b87c00 Fixed a few more imports of django.utils.unittest. 
One import per line please! Refs #20680.
 2013-07-01 22:49:07 +02:00
Aymeric Augustin
909433fa50 Removed tests for django.utils.unittest vs. unittest. 
Silenced warnings caused by the deprecation of django.utils.unittest.

Thanks Preston Timmons and Carl Meyer for their advice.

Fixed #20680.
 2013-07-01 21:49:11 +02:00
Tim Graham
a521d10322 Fixed a couple form/formset deprecation warnings in tests. 2013-07-01 09:36:31 -04:00
Tim Graham
a6a905c619 Updated tests for deprecation of Option.get_(add|change|delete)_permission. 
refs #20642.
 2013-07-01 09:19:55 -04:00
Aymeric Augustin
cfcf4b3605 Stopped using django.utils.unittest in the test suite. 
Refs #20680.
 2013-07-01 14:29:33 +02:00
Aymeric Augustin
2c40681805 Stopped calling loaddata with commit=False. 
This was a stealth option only used by the tests, and it isn't useful
any more since `atomic` provides nested transactions.
 2013-06-30 14:17:33 +02:00
Aymeric Augustin
acd7b34aaf Advanced deprecation warnings for Django 1.7. 2013-06-29 18:49:37 +02:00
Aymeric Augustin
8b9b8d3bda Removed compatibility code for streaming responses. 
This code provided a deprecation path for old-style streaming responses.

Refs #6527, #7581.
 2013-06-29 18:49:36 +02:00
Claude Paroz
59b0c48ce2 Fixed #18592 -- Prevented crash when accessing MySQL _last_executed 
Thanks reames at asymmetricventures.com for the report.
 2013-06-29 18:44:41 +02:00
Claude Paroz
7fbab3ebaf Do not allow FileSystemStorage.delete to receive an empty name 
Refs #20660.
 2013-06-29 18:09:31 +02:00
Claude Paroz
ea3fe78a9d Fixed #20660 -- Do not try to delete an unset FieldFile 
Thanks stanislas.guerra at gmail.com for the report and
Baptiste Mispelon for the review.
 2013-06-29 18:08:39 +02:00
Claude Paroz
6118d6d1c9 More import removals 
Following the series of commits removing deprecated features in
Django 1.7, here are some more unneeded imports removed and other
minor cleanups.
 2013-06-29 11:58:36 +02:00
Ramiro Morales
7379d9acea Removed insert(), value_for_insert() SortedDict methods deprecated in Django 1.5. 2013-06-28 22:38:13 -03:00
Ramiro Morales
6ba69c8456 Removed 'depth' .select_related() argument as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
c196564132 Removed custom profile model functionality as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
4f6be9a0c4 Removed warnings level handling code as per deprecation TL. 2013-06-28 21:48:15 -03:00
Andrew Godwin
7a47ba6f6a Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/models/fields/related.py
	tests/field_deconstruction/tests.py
 2013-06-28 17:32:57 +01:00
Andrew Godwin
48dd1e63bb Ported over Field.deconstruct() from my schema alteration branch. 
This is to help other ongoing branches which would benefit from
this functionality.
 2013-06-28 17:27:52 +01:00
Shai Berger
d097417025 Support 'pyformat' style parameters in raw queries, Refs #10070 
Add support for Oracle, fix an issue with the repr of RawQuerySet,
add tests and documentations. Also added a 'supports_paramstyle_pyformat'
database feature, True by default, False for SQLite.

Thanks Donald Stufft for review of documentation.
 2013-06-28 06:59:10 +03:00
Tim Graham
7c0b72a826 Prevented running some admin_view tests twice. 2013-06-27 20:13:42 -04:00
Tim Graham
534ced5aad Fixed #20664 -- Fixed a bug with raw_id_fields on Python 3. 
Thanks jefftriplett for the report.
 2013-06-27 19:39:20 -04:00
Aymeric Augustin
c1284c3d3c Fixed #20571 -- Added an API to control connection.needs_rollback. 
This is useful:
- to force a rollback on the exit of an atomic block without having to
  raise and catch an exception;
- to prevent a rollback after handling an exception manually.
 2013-06-27 22:19:54 +02:00
Andrew Godwin
99b467f272 Add related_query_name to ForeignKey/M2M. Refs #20244 2013-06-27 14:44:21 +01:00
Loic Bistuer
a9ea7d8c70 Fixed #20462 - Replaced the str() cast introduced in 273dc55 by force_text() 2013-06-26 21:30:58 +07:00
Andrew Clark
273dc550a4 Fixed #20462 -- null/non-string regex lookups are now consistent 
Thanks to noirbizarre for the report and initial patch.
 2013-06-26 08:13:26 -04:00
Baptiste Mispelon
ec371ace00 Fixed #20650 -- Fixed {% filter %} incorrectly accepting 'escape' as argument 
Thanks to grzesiof for the report and to loic84 and Alex Gaynor
for the review.
 2013-06-25 20:28:35 +02:00
Javier Mansilla
f819bef3dc Fixed #19773 - Added admin/popup_response.html template. 
Thanks jimmylam@ for the suggestion.
 2013-06-25 11:20:41 -04:00
Russell Keith-Magee
0346563939 Fixed #20653 -- Renamed checksetup management command. 
This is to allow future compatibility with work that is ongoing in the 2013 GSoC.
 2013-06-25 09:37:54 +08:00
Ramiro Morales
1559f84d8b Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers. 
Thanks naktinis for the report and initial patch.
 2013-06-22 18:45:41 -03:00
Andrew Godwin
e2d7e83256 Autodetect ForeignKeys and add dependencies/split on circulars 2013-06-22 17:15:51 +01:00
Gilberto Gonçalves
680b512fc1 Fixed #20587 -- Made convert_values handle None values 2013-06-22 14:05:12 +01:00
Gilberto Gonçalves
ef37b23050 Fixed #18872 -- Added prefix to FormMixin 
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
 2013-06-22 12:12:43 +01:00
Claude Paroz
ef79582e86 Fixed 17478 -- Allowed queryset overriding in BaseModelFormSet init 
BaseModelFormSet.forms is now a cached property instead of being
populated in the __init__ method. This behaviour also matches an
example in the documentation.
Thanks Thomasz Swiderski for the report and Simon Charette for the
review.
 2013-06-22 09:29:37 +02:00
Oliver Beattie
552a90b444 Fixed #20290 -- Allow override_settings to be nested 
Refactored override_settings to store the underlying settings._wrapped
value seen at runtime, not instantiation time.
 2013-06-21 16:57:47 +02:00
Andrew Godwin
cca40703df Prompt about renames rather than doing them automatically 2013-06-21 15:32:15 +01:00
Andrew Godwin
92a10f5552 Autodetect field renames. HAHAHA. AHAHAHAHA. YES. 2013-06-20 16:02:43 +01:00
Simon Charette
04628e2016 Fixed #20630 -- Removed maxlength attribute from NumberInput. 
This attribute is only allowed on inputs of type "text", "search", "url",
"tel", "email", or "password".

Thanks to yoyoma for the report and @bmispelon for the review.
 2013-06-20 10:59:41 -04:00
Andrew Godwin
47e4b86ddf Autodetect field alters 2013-06-20 15:19:30 +01:00
Andrew Godwin
80bdf68d6b Add AlterField and RenameField operations 2013-06-20 15:12:59 +01:00
Andrew Godwin
6f667999e1 Add operation that renames tables 2013-06-20 14:54:11 +01:00
Russell Keith-Magee
18e79f1425 Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists. 
Thanks to kux for the report, and Russ Webber for the patch.
 2013-06-20 18:55:27 +08:00
Andrew Godwin
ab5cbae9b7 First stab at some migration creation commands 2013-06-19 15:36:22 +01:00
Andrew Godwin
2ae8a8a77d Fix test running with new apps stuff/migrate actually running migrations 2013-06-19 15:36:02 +01:00
Andrew Godwin
9daf81b94e Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/loading.py
 2013-06-19 12:05:23 +01:00
Aymeric Augustin
d9a43545be Merge pull request #1282 from loic/ticket6903 
Fixed failing test on MySQL since c86a9b6
 2013-06-19 03:04:04 -07:00
Loic Bistuer
7d0c3b9b26 Fixed MySQL failing test introduced by c86a9b6 2013-06-19 16:13:43 +07:00
Florian Hahn
2f35c6f10f Fixed #14930 -- values_list() failure on qs ordered by extra column 
Thanks lsaffre for the report and simon29, vicould, and Florian Hahn
for the patch.

Some changes done by committer.
 2013-06-18 23:56:51 +03:00
Aymeric Augustin
9da9b3eb04 Merge pull request #1281 from loic/ticket6903 
Fixed #6903 - Preserved admin changelist filters.
 2013-06-18 13:07:28 -07:00
Loic Bistuer
c86a9b6398 Fixed #6903 - Preserve admin changelist filters after saving or deleting an object 2013-06-19 02:41:36 +07:00
Erik Romijn
aeb1389442 Fixed #20079 -- Improve security of password reset tokens 2013-06-18 20:02:00 +02:00
Baptiste Mispelon
3128f3d38d Fixed #20618 -- Fixed regression in BoundField.label_tag. 2013-06-18 17:49:53 +02:00
Loic Bistuer
ee77d4b253 Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields 2013-06-18 08:01:17 -04:00
Loic Bistuer
f34cfec0fa Refactored ValidationError to allow persisting error params and error codes as the exception bubbles up 2013-06-18 08:01:17 -04:00
Baptiste Mispelon
1b7634a0d0 Fixed #20464 -- Added a total_error_count method on formsets. 
Thanks to frog32 for the report and to Tim Graham for the review.
 2013-06-16 15:49:30 -04:00
Aymeric Augustin
c3df866619 Fixed #20603 -- Made the test suite faster. 
By avoiding to run syncdb with the full set of test models.

Thanks Anssi for the idea.
 2013-06-14 23:16:15 +02:00
Marc Tamlyn
46789e76c6 Fixed #20548 -- Removed all PendingDeprecationWarnings from django test suite 2013-06-14 15:37:39 +01:00
Anssi Kääriäinen
5459795ef2 Fixed #20289 -- pickling of dynamic models 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
855d1305c5 Added cache to available_apps in cache tests 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
89bf7a4525 Fixed #20528 -- regression in select_related join promotion 
The join used by select_related was incorrectly INNER when the query
had an ORed filter for nullable join that was trimmed away. Fixed this
by forcing the join type to LOUTER even when a join was trimmed away
in ORed queries.
 2013-06-14 16:29:06 +03:00
Marc Tamlyn
b7bd7087e6 Fixed #15273 -- Extend RedirectView to allow reversal by name. 
Thanks to @DrMeers for the report and @ludwigkraatz for the initial patch.
 2013-06-14 11:59:26 +01:00
Wilfred Hughes
8365ed08b8 Fixed #17076 -- When reversing a URL fails, inform the user which patterns were tried. 2013-06-14 10:26:30 +01:00
Daniel Lindsley
91f317c76d Added a `checksetup` management command for verifying Django compatibility. 2013-06-13 18:39:02 -07:00
Loic Bistuer
9e50833e22 Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages 2013-06-13 15:06:25 -04:00
Baptiste Mispelon
dc9c359546 Fixed #20594 -- Add validation to models.SlugField. 
Thanks carbonXT for the report.
 2013-06-13 13:31:57 -04:00
Tim Graham
92c49d6f01 Revert "Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields." 
This reverts commit 64041f0e6e.

lookup.tests.LookupTests.test_regex_non_string fails under Postgres.
We should also try to rewrite the test using an existing model.
 2013-06-11 17:55:19 -04:00
Axel Haustant
64041f0e6e Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields. 2013-06-11 14:13:40 -04:00
Gabe Jackson
584bd14dcf Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix 
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.

This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
 2013-06-10 14:23:15 -04:00
Florian Apolloner
af70dfcf31 Reverted the introduction of shared_models. 
The recent improvements should make shared_models obsolete.

This reverts commit 1059da8de6, reversing
changes made to 4fa7f3cdd9.
 2013-06-10 12:34:47 +02:00
Florian Apolloner
f5d4849cbe Revert "Began implementing a shared set of test models to speed up tests." 
This reverts commit 22b7870e40.
 2013-06-10 12:22:40 +02:00
Aymeric Augustin
dfcce4288a Fixed available_apps for selenium tests. 
Refs #20483.
 2013-06-10 12:11:46 +02:00
Aymeric Augustin
c6e6d4eeb7 Defined available_apps in relevant tests. 
Fixed #20483.
 2013-06-10 11:30:01 +02:00
Aymeric Augustin
7a65c95d42 Refactored file_storage tests to avoid depending on servers tests. 2013-06-10 11:16:15 +02:00
Tim Graham
96c71d423d Added runserver validation to detect if DEBUG=False and ALLOWED_HOSTS is empty. 
Refs #19875.
 2013-06-09 15:08:29 -04:00
Andrew Godwin
91c470def5 Auto-naming for migrations and some writer fixes 2013-06-07 17:56:43 +01:00
Andrew Godwin
cd809619a2 Autodetector tests 2013-06-07 15:49:48 +01:00
Andrew Godwin
c7aa4b5338 Field encoding 2013-06-07 15:36:31 +01:00
Andrew Godwin
4492f06408 A bit of an autodetector and a bit of a writer 2013-06-07 15:28:38 +01:00
Andrew Godwin
3c296382b8 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/fields/related.py
 2013-06-07 11:15:34 +01:00
Stephen Burrows
e2518fdf46 Fixed #12337 - Honor ModelForm.Meta.exclude when saving ManyToManyFields. 
Thanks margieroginski for the report.
 2013-06-06 10:01:48 -04:00
Claude Paroz
b67f2ac8e6 Fixed #20502 (again) -- More i18n cache flush in tests 
Thanks Timo Graham for noticing the failures.
 2013-06-06 14:28:58 +02:00
Marc Tamlyn
9ed971f4f1 Merge pull request #1245 from oinopion/list_select_related 
Fixed #19080 -- Fine-grained control over select_related in admin
 2013-06-06 01:27:05 -07:00
Anssi Kääriäinen
31fd64ad8a Fixed #20564 -- Generic relations exclude() regression 
The patch for #19385 caused a regression in certain generic relations
.exclude() filters if a subquery was needed. The fix contains a
refactoring to how Query.split_exclude() and Query.trim_start()
interact.

Thanks to Trac alias nferrari for the report.
 2013-06-06 01:54:46 +03:00
Tomek Paczkowski
0fd9f7c95f Fixed #19080 -- Fine-grained control over select_related in admin 2013-06-05 23:08:00 +02:00
Anssi Kääriäinen
8c5b805ca1 PEP 8 cleanup 2013-06-05 21:18:56 +03:00
Bojan Mihelac
b00c6371af Fixed #17927 -- Added initial values support for BaseGenericInlineFormSet 
Thanks Fak3 for the suggestion.
 2013-06-05 07:59:59 -04:00
Tim Graham
a35ed20241 Fixed #18924 -- Made test.Client.logout send user_logged_out signal. 
Thanks awsum for the suggestion and Pavel Ponomarev and
Florian Hahn for the patch.
 2013-06-04 12:39:09 -04:00
Ramiro Morales
e71b63e280 Added i18n-related URL mapper test for a mailing list report. 2013-06-04 11:19:27 -03:00
Aymeric Augustin
51aa000378 Fixed #20485 -- Refactored loaddata for speed. 
Thanks Anssi for reporting this performance bottleneck.
 2013-06-02 20:39:45 +02:00
Tim Graham
61524b09cf Fixed #18388 - Added InlineModelAdmin.get_max_num hook. 
Thanks d.willy.c.c@ for the suggestion and Melevir and Areski Belaid for work
on the patch.
 2013-06-01 18:20:54 -04:00
Tim Graham
fffb55860e Changed assertEquals -> assertEqual. 2013-06-01 06:31:25 -04:00
Claude Paroz
de66b56790 Fixed #18481 -- Wrapped request.FILES read error in UnreadablePostError 
Thanks KyleMac for the report, André Cruz for the initial patch and
Hiroki Kiyohara for the tests.
 2013-06-01 10:26:46 +02:00
Anssi Kääriäinen
369b6fab25 Fixed #18169 -- NoReverseMatch not silenced if from block.super 2013-06-01 00:59:04 +03:00
Anssi Kääriäinen
84909377f2 Fixed #18785 -- Added Test join trimming regression 
The regression was caused by patch to ticket #15316 and was fixed by a
patch to #10790.
 2013-06-01 00:28:44 +03:00
Chris Wilson
fa7cb4ef3c Fixed #20404 -- Added a keys() method to ContextList. 
It's useful to be able to list all the (flattened) keys of a
ContextList, to help you figure out why the variable that's supposed
to be there is not.

No .values() or .items() added as the definition for those aren't clear.

The patch is Chris Wilson's patch from pull request 1065 with some
modifications by committer.
 2013-06-01 00:04:06 +03:00
Loic Bistuer
23e1b59cf2 Fixed #18681 -- BaseModelAdmin.get_form and InlineModelAdmin.get_formset no longer bypass get_fieldsets 
Thanks msopacua for the report.
 2013-05-31 12:48:51 -04:00
Anssi Kääriäinen
728d3fe1ba Fixed #16436 -- Oracle defer_regress test failure 
Oracle doesn't like grouping by TextField, so use CharFields instead in
models.
 2013-05-31 10:11:15 +03:00
Claude Paroz
9d06c6ccc9 Fixed #20502 -- Flushed i18n caches for a defaultfilter test 
Thanks Chris Wilson for the report and initial patch.
 2013-05-30 20:23:14 +02:00
Tim Graham
36aecb12b8 Fixed #19425 - Added InlineModelAdmin.get_extra hook. 
Thanks dave@ for the suggestion and Rohan Jain for the patch.
 2013-05-30 13:48:10 -04:00
Andrew Godwin
e6f7f4533c Add an Executor for end-to-end running 2013-05-30 18:08:58 +01:00
Andrew Godwin
7f9a0b7061 Fix graph tests 2013-05-30 17:56:53 +01:00
Andrew Godwin
05929ee89b Add the start of some operation tests 2013-05-30 17:55:59 +01:00
Tim Graham
7902fd74f1 Merge pull request #1027 from intgr/debug_no_exc_message 
Clearer explanation when exception has no message
 2013-05-30 09:53:07 -07:00
Tim Graham
5074c75a37 Fixed #16856 - Added a way to clear select_related. 
Thanks Carl for the suggestion and David Cramer for the patch.
 2013-05-30 11:06:05 -04:00
Tim Graham
59235816bd Fixed #20509 - Proper parsing for dumpdata --pks option. 
Thanks weipin for the report and Baptiste Mispelon for the patch.
 2013-05-30 10:19:13 -04:00
Tai Lee
69f7db153d Fixed #16436 -- defer + annotate + select_related crash 
Correctly calculate the ``aggregate_start`` offset from loaded fields,
if any are deferred, instead of ``self.query.select`` which includes all
fields on the model.

Also made some PEP 8 fixes.
 2013-05-30 08:46:31 +03:00
Anssi Kääriäinen
bb80d2976b Made an app-cache test not dependent on all models in defer_regress 2013-05-30 08:46:31 +03:00
Simon Charette
dcd915fcab Fixed a failure on Python 3 introduced by 5939864616. 
Refs #15653.
 2013-05-29 15:38:52 -04:00
Andrew Godwin
52d2a8b311 Add test for new __ne__ method on Promise. 2013-05-29 17:52:17 +01:00
Andrew Godwin
d0ecefc2c9 Start adding operations that work and tests for them 2013-05-29 17:47:10 +01:00
Tim Graham
d727518ad6 Fixed #20331 -- Allowed admin actions to serve StreamingHttpResponses 
Thanks Edwin.
 2013-05-29 11:25:42 -04:00
Claude Paroz
8010289ea2 Fixed #15697 -- Made sqlindexes aware of auto-created tables 
Thanks mbertheau for the report and Ash Christopher for the
initial patch.
 2013-05-29 15:50:26 +02:00
Tim Graham
5939864616 Fixed #15653 - Error in admin pagination tag. 
Thanks jcumbo@ for the report and adamzap
and nott for the patch.
 2013-05-29 09:23:08 -04:00
Tim Graham
7426e72302 Fixed #20250 - Added a regression test for negated Q + annotate 
Thanks nott.
 2013-05-29 08:49:42 -04:00
Tim Graham
ded95ccdce Fixed #20484 -- Added model validation for GenericIPAddressField 
GenericIPAddressField must not allow blank for NOT NULL fields

Thanks Erik Romijn.
 2013-05-28 15:12:47 -04:00
Tim Graham
a2967d5204 Fixed #20242 - Added a regression test for prefetch_related. 
Issue was fixed by removal of chunked reads from
QuerySet iteration in 70679243d1.

Thanks Simeon Visser for the patch.
 2013-05-28 13:37:44 -04:00
Tim Graham
d321d1acf0 Fixed #20228 - Documented unique_for_date and exclude behavior. 
Thanks Deepak Thukral for the patch.
 2013-05-28 10:04:07 -04:00
Anssi Kääriäinen
33dd8f5442 Fixed random aggregation_regress test_more_more_more() failure 
The cause was assuming that an unordered queryset returns the values
always in the same order.
 2013-05-28 08:55:04 +03:00
Tim Graham
0268aba96b Fixed #20182 - admin lookup should treat 0 as False for __isnull 
Thanks Benjie Chen.
 2013-05-27 13:29:53 -04:00
Tim Graham
d194714c0a Fixed #11603 - Added django.test.SimpleTestCase.assertFormsetError 
Thank-you Martin Green for the patch.
 2013-05-27 12:25:35 -04:00
Shai Berger
1e29428db2 Fixed #20013 -- A test for sqlall fails under Oracle 2013-05-27 18:34:31 +03:00
Tim Graham
90af278203 Fixed #16137 - Removed kwargs requirement for QuerySet.get_or_create 
Thanks wilfred@, poirier, and charettes for work
on the patch.
 2013-05-27 10:01:14 -04:00
Tim Graham
6f8627dd7f Fixed #17582 - Added message to DoesNotExist exceptions. 
Thanks simon@ for the suggestion and JordanPowell
for the initial patch.
 2013-05-27 07:57:06 -04:00
Anssi Kääriäinen
d467e11785 Fixed #20507 -- SubqueryConstraint alias relabeling 
The SubqueryConstraint defined relabeled_clone(), but that was never
called. Instead there is now clone() and relabel_aliases() methods for
SubqueryConstraint.

A related problem was that SubqueryConstraint didn't correctly use
quote_name_unless_alias() of the outer query. This resulted in failures
when running under PostgreSQL.
 2013-05-27 12:25:29 +03:00
Ramiro Morales
0fa8d43e74 Replaced and...or... constructs with PEP 308 conditional expressions. 2013-05-26 23:47:50 -03:00
Preston Holmes
d228c1192e Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation. 
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.

Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
 2013-05-25 16:27:34 -07:00
Shai Berger
36d47f72e3 Fixed get_or_create...test_savepoint_rollback test for Python3 
The test was always skipped on Python3 because string literals are unicode
 2013-05-26 01:53:24 +03:00
Shai Berger
cf159e5c93 Fix get_or_create test failure under Oracle 
Test expected that when given invalid utf-8, the backend should raise
a DatabaseError, but the Oracle backend raises a UnicodeDecodeError.
 2013-05-26 01:39:34 +03:00
Andrew Jesaitis
31f6421b13 Fixed #19938 -- Consumed iterator only once in paginator's Page 
Thanks Joshua Fialkoff for the report.
 2013-05-25 16:27:26 +02:00
Baptiste Mispelon
2ee447fb5f Fixed #20296 -- Allowed SafeData and EscapeData to be lazy 2013-05-25 16:06:44 +02:00
Claude Paroz
be0bab1bb8 Fixed #11725 -- Made possible to create widget label tag without "for" 
Thanks Denis Martinez for the report and initial patch, and
Sergey Kolosov for bringing the patch up to date.
 2013-05-25 15:31:07 +02:00
Claude Paroz
f940e564e4 Fixed #20099 -- Eased subclassing of BrokenLinkEmailsMiddleware 
Thanks Ram Rachum for the report and the initial patch, and Simon
Charette for the review.
 2013-05-25 12:10:53 +02:00
Vlastimil Zíma
6de81d65f4 Fixed #14825 -- LocaleMiddleware keeps language 
* LocaleMiddleware stores language into session if it is not present there.
 2013-05-25 10:52:54 +02:00
Claude Paroz
7e95d7a930 Fixed a regression in router initialization 
Regression was introduced in 6a6bb168b. Thanks Bas Peschier for the
report.
 2013-05-24 20:48:02 +02:00
Luke Plant
4fd94969d8 Fixed #19607 - prefetch_related crash 
Thanks to av@rdf.ru and flarno11@yahoo.de for the report.
 2013-05-24 11:10:48 +01:00
Gavin Wahl
48424adaba Fixed #17648 -- Add for_concrete_model to GenericForeignKey. 
Allows a `GenericForeignKey` to reference proxy models. The default
for `for_concrete_model` is `True` to keep backwards compatibility.

Also added the analog `for_concrete_model` kwarg to
`generic_inlineformset_factory` to provide an API at the form level.
 2013-05-23 19:03:14 -04:00
Donald Stufft
8dda8a5ecc Removed noise from pre_syncdb signal tests 
Only make assertions that actually test the functionality of the
change and not unrelated pieces.
 2013-05-23 15:58:08 -04:00
Claude Paroz
499a745ae1 Fixed #20474 -- Proxied and deprecated django.db.backend 2013-05-23 15:19:12 +02:00
Claude Paroz
b664cb818d Fixed #19237 (again) - Made strip_tags consistent between Python versions 2013-05-23 14:01:27 +02:00
Ramiro Morales
8c2fd050f8 Made fix for #9321 less buggy and more effective. 
Don't try to be smart about building a good-looking help string
because it evaluates translations too early, simply use the same old
strategy as before. Thanks Donald Stufft for the report.

Also, actually fix the case reported by the OP by special-casing
CheckboxSelectMultiple.

Added tests.

Refs #9321.
 2013-05-23 07:49:29 -03:00
Donald Stufft
3de1288042 Fixed #11398 - Added a pre_syncdb signal 2013-05-23 01:09:22 -04:00
Russell Keith-Magee
11b06532f7 Merge pull request #1198 from KrzysiekJ/http-patch-method 
Fixed #20478 – Added support for HTTP PATCH method in generic views.
 2013-05-22 17:19:43 -07:00
Claude Paroz
51998dffe7 Removed check for 0.15 version of gettext tools 
gettext 0.15 has been released in July 2006.
 2013-05-22 18:21:33 +02:00
Claude Paroz
dc51ec8bc2 Fixed #19237 -- Used HTML parser to strip tags 
The regex method used until now for the strip_tags utility is fast,
but subject to flaws and security issues. Consensus and good
practice lead use to use a slower but safer method.
 2013-05-22 17:34:02 +02:00
Krzysztof Jurewicz
ee8b810b97 Fixed #20478 – Added support for HTTP PATCH method in generic views. 2013-05-22 14:48:11 +02:00
Aymeric Augustin
0e51d8eb66 Fixed #20463 -- Made get_or_create more robust. 
When an exception other than IntegrityError was raised, get_or_create
could fail and leave the database connection in an unusable state.

Thanks UloPe for the report.
 2013-05-22 10:56:06 +02:00
Marc Tamlyn
adeec00979 Merge pull request #246 from dekkers/ticket_18709 
Fixed #18709 -- Check if initial_value is a callable
 2013-05-22 00:45:07 -07:00
Anssi Kääriäinen
904084611d Fixed #19895 -- Second iterator over invalid qs raises errors 
The fix was already in the patch for #18702, so only test added for
ticket #19895.
 2013-05-22 08:30:41 +03:00
Jeroen Dekkers
d0788c2770 Fixed #18709 -- Check if initial_value is a callable 
In _get_changed_data, check if initial_value is a callable and call it
if it is.
 2013-05-22 01:05:22 +02:00
Anssi Kääriäinen
70679243d1 Fixed #18702 -- Removed chunked reads from QuerySet iteration 2013-05-21 19:51:59 +03:00
Selwin Ong
ea9a0857d4 Fixed #19326 -- Added first() and last() methods to QuerySet 2013-05-21 18:52:28 +03:00
Mathijs de Bruin
61a8de6f4f Fixed #6412 -- More details if a template file cannot be loaded 
Report more details about template files in loader postmortem.
 2013-05-21 16:59:40 +02:00
Florian Apolloner
800513e7f3 Merge pull request #1194 from ambv/python26_is_fun 
Fixed a Python 2.6 regression (GzipFile can't act as a context manager)
 2013-05-21 04:20:35 -07:00
Wiktor Kolodziej
cec9558fba Fixed #17308 -- Enabled the use of short_description on properties in the admin. 2013-05-21 13:19:18 +02:00
Łukasz Langa
c28281f9d6 Fixed a Python 2.6 regression (GzipFile can't act as a context manager) 2013-05-21 13:18:53 +02:00
Florian Apolloner
b1ac241ddc Fixed test failures from 09f8652765. 2013-05-21 13:03:25 +02:00
Marc Tamlyn
09f8652765 Use assertIsInstance in tests. 
Gives much nicer errors when it fails.
 2013-05-21 10:42:15 +01:00
Aymeric Augustin
18856f866c Merge pull request #1191 from ambv/content_is_bytes 
Fixed #20472: response.content should be bytes on both Python 2 and 3
 2013-05-21 01:26:35 -07:00
Daniel Lindsley
e24d486fbc Fixed #20212 - __reduce__ should only be defined for Py3+. 2013-05-21 00:49:21 -07:00
Łukasz Langa
0594fed9ff Fixed #20472: response.content should be bytes on both Python 2 and 3 2013-05-21 01:28:16 +02:00
Jorge Bastida
888c86dcf3 Fixed #20445 -- Raised original exception after command error 2013-05-20 18:59:37 +02:00
Ryan Kaskel
4280217f31 Fixed #20403 -- Ignore forms marked for deletion when validating max_num. 2013-05-20 12:13:21 -04:00
Anssi Kääriäinen
266c0bb23e Fixed #20278 -- ensured .get() exceptions do not recurse infinitely 
A regression caused by d5b93d3281 made .get() error
reporting recurse infinitely on certain rare conditions. Fixed this by
not trying to print the given lookup kwargs.
 2013-05-20 18:50:40 +03:00
Anssi Kääriäinen
c9a96075fa Fixed #20378 -- regression in GenericRelation on abstract model 
When a GenericRelation was defined on abstract model, queries on childs
of the abstract model didn't work. The problem was in the way fields and
in particular field.rel was copied from models to their children.

The regression was likely caused by #19385. Thanks to Gavin Wahl for
spotting the regression.
 2013-05-20 18:02:10 +03:00
Anssi Kääriäinen
f53059b411 Fixed qs.values() regression when used in subquery 2013-05-20 15:38:47 +03:00
Marc Tamlyn
6d81d5d82e Merge pull request #1181 from aaugustin/better-api-to-disable-atomic-requests 
Changed API to disable ATOMIC_REQUESTS per view.
 2013-05-20 00:26:06 -07:00
Carl Meyer
a7dc13ec23 Fixed #20437 - marked a test-runner test as expected-fail under certain conditions. 2013-05-20 01:56:23 -04:00
Tomasz Jaskowski
022de7e139 Fixed #20449 - Corrected test sensitivity to current working dir. 2013-05-19 23:58:06 -04:00
Alex Gaynor
7c56212c71 Lower the max length for a test field so that it works on MySQL. 2013-05-19 13:58:58 -07:00
Anssi Kääriäinen
190771d003 Fixed fixtures testing failure 
The failure was caused by generating the same warning from two tests.
The second time the same warning was raised it was swallowed by the
"once" simplefilter of warnings.
 2013-05-19 20:53:49 +03:00
Aymeric Augustin
6633eeb886 Changed API to disable ATOMIC_REQUESTS per view. 
A decorator is easier to apply to CBVs. Backwards compatibility isn't an
issue here, except for people running on a recent clone of master.

Fixed a few minor problems in the transactions docs while I was there.
 2013-05-19 19:53:16 +02:00
Preston Holmes
6786920fd8 Fixed #16330 -- added --pks option in dumpdata command 
Thanks to guettli for the initial ticket and patch, with additional work
from mehmetakyuz and Kevin Brolly.
 2013-05-19 09:10:40 -07:00
Bozidar Benko
2d309a7043 Fixed #15961 -- Modified ModelAdmin to allow for custom search methods. 
This adds a get_search_results method that users can override to
provide custom search strategies.

Thanks to Daniele Procida for help with the docs.
 2013-05-19 16:45:00 +02:00
Aymeric Augustin
b06f6c1618 Fixed test failure introduced in 1927bf7c91. 2013-05-19 16:23:14 +02:00
Pablo Recio
65f9e0affd Fixes #18896. Add tests verifying that you can get IntegrityErrors using get_or_create through relations like M2M, and it also adds a note into the documentation warning about it 2013-05-19 14:16:12 +02:00
Aymeric Augustin
d34b1c29e2 Merge pull request #1161 from erikr/urlize-additional-test 
Fixed #19070 -- Additional test for urlize and brackets
 2013-05-19 04:59:15 -07:00
Aymeric Augustin
f7467181aa Merge pull request #1160 from erikr/host-inet-postgres2 
Fixed #11442 -- Postgresql backend casts all inet types to text
 2013-05-19 04:57:10 -07:00
Erik Romijn
1927bf7c91 Fix #19070 -- Additional test for urlize and brackets 2013-05-19 13:39:21 +02:00
Erik Romijn
60d94c2a80 Fixed #11442 -- Postgresql backend casts all inet types to text 2013-05-19 13:28:09 +02:00
Łukasz Langa
660762681c Fixed #20126 -- XViewMiddleware moved to django.contrib.admindocs.middleware 2013-05-19 13:18:35 +02:00
Aymeric Augustin
cb86f707a0 Fixed #12747 -- Made reason phrases customizable. 2013-05-19 13:14:54 +02:00
Aymeric Augustin
3129d19071 Merge pull request #1152 from ambv/issue11915 
Fixed #11915: generic Accept-Language matches country-specific variants
 2013-05-19 04:01:20 -07:00
Andrew Godwin
04e0fc029f Merge pull request #1094 from senko/ticket_11160 
Fixed #11160: Formset non_form_errors returns ErrorList() if is_valid is not called
 2013-05-19 03:56:14 -07:00
Andrew Godwin
7a99d1e167 Merge pull request #1134 from senko/ticket_18990 
Fixed #18990: Loaddata now complains if fixture doesn't exist
 2013-05-19 03:54:29 -07:00
Łukasz Langa
26e3e7ecb5 Fixed #11915: generic Accept-Language matches country-specific variants 2013-05-19 12:50:09 +02:00
Senko Rasic
65c557115f fix warnings imports in fixtures tests 2013-05-19 12:49:03 +02:00
Honza Kral
4ad1eb1c14 Fixed #12674 -- provide a way to override admin validation 
Moved admin validation code to classes and have those be class
attributes to the ModelAdmin classes.
 2013-05-19 12:42:52 +02:00
Andrew Godwin
264f8650e3 ModelState now freezes options and bases 2013-05-19 12:35:17 +02:00
Łukasz Langa
e80636b668 Added TransRealMixin to fix i18n global state pollution in the test suite 2013-05-19 12:05:57 +02:00
Senko Rasic
c44a2c40fe Fixed #18990 -- Loaddata now complains if fixture doesn't exist 
If the fixture doesn't exist, loaddata will output a warning.

The fixture named "initial_data" is exceptional though; if it
doesn't exist, the warning is not emitted. This allows syncdb and
flush management commands to attempt to load it without causing
spurious warnings.

Thanks to Derega, ptone, dirigeant and d1ffuz0r for contributions
to the ticket.
 2013-05-19 11:31:27 +02:00
Senko Rasic
cc3b3ba93a Fixed #18990: Loaddata now complains if fixture doesn't exist 
The fixture named "initial_data" is exceptional though; if it
doesn't exist, the error is not raised. This allows syncdb and
flush management commands to attempt to load it without causing
an error if it doesn't exist.
 2013-05-19 10:56:09 +02:00
Andrea Crotti
5124ab7620 add comment to explain why it's necessary to do an explicit check for 
Python2 and how metaclasses are defined
 2013-05-19 10:36:04 +02:00
Marc Tamlyn
c70ca4879e Merge pull request #1116 from elektrrrus/ticket_20234_20236 
Ticket 20234 20236
 2013-05-19 01:32:41 -07:00
Emil Stenström
7d77e9786a Fixed #20246 -- Added non-breaking spaces between values an units 2013-05-18 23:01:48 +02:00
Tome Cvitan
caf56ad174 Fixed #20440 -- Ensured CharField's max_length/min_length are integers 2013-05-18 22:30:24 +02:00
Karol Sikora
3eba8c7f7f Fixed #20234 and #20236 -- SingleObjectMixin fixes 
Added object on SingleObjectMixin returned context,
some code clanup.
 2013-05-18 21:13:27 +02:00
Aymeric Augustin
0038296135 Fixed ff881aef on Python 3. 2013-05-18 20:48:47 +02:00
Andrew Godwin
38a8cf1cdc Fix state tests a little 2013-05-18 18:30:34 +02:00
Shai Berger
ff881aef53 Fixed #13958 -- problem reporting exception from \r-line-ended file 
Thanks petrvanblokland for reporting and saz for the patch
 2013-05-18 19:30:03 +03:00
Łukasz Langa
f763227c7d Fixes a Python 3.x regression introduced in a19e9d80 2013-05-18 18:06:31 +02:00
Florian Apolloner
dc8814bf7d Merge branch 'master' of github.com:django/django 2013-05-18 17:39:14 +02:00
Łukasz Langa
bd97f7d0cb Fixed #15201: Marked CACHE_MIDDLEWARE_ANONYMOUS_ONLY as deprecated 2013-05-18 17:38:32 +02:00
Florian Apolloner
acd0bb39df Fixed #14894 -- Ensure that activating a translation doesn't run into threading issues. 
Thanks to maxbublis for the report and sergeykolosov for the patch.
 2013-05-18 17:36:31 +02:00
Donald Stufft
398841d6d3 Merge branch 'allow-any-iterable-for-choices' 2013-05-18 11:31:16 -04:00
Donald Stufft
a19e9d80ff Fixed #20430 - Enable iterable of iterables for model choices 
Allows for any iterable, not just lists or tuples, to be used as
the inner item for a list of choices in a model.
 2013-05-18 11:14:05 -04:00
Aymeric Augustin
e73cb6391d Merge pull request #1122 from ambv/issue13285 
Fixed #13285: populate_xheaders breaks caching
 2013-05-18 08:05:48 -07:00
Łukasz Langa
64e11a68f1 Fixed #13285: populate_xheaders breaks caching 2013-05-18 17:03:43 +02:00
Aymeric Augustin
3634948c88 Moved IgnorePendingDeprecationWarningsMixin in django.test.utils. 
This mixin is useful whenever deprecating a large part of Django.
 2013-05-18 16:49:15 +02:00
Olivier Sels
63a9555d57 Fixed #19436 -- Don't log warnings in ensure_csrf_cookie. 2013-05-18 16:17:46 +02:00
Aymeric Augustin
7d050e8e9c Merge pull request #1113 from denibertovic/master 
Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
 2013-05-18 07:11:11 -07:00
Deni Bertovic
186ec21a3d Added stripping of whitespace for SlugField and URLField 2013-05-18 16:06:08 +02:00
Jacob Burch
89955cc35f Fixed #9595 -- Allow non-expiring cache timeouts. 
Also, streamline the use of 0 and None between cache backends.
 2013-05-18 15:39:42 +02:00
Łukasz Langa
92ebb29c53 Fixes #19919: get_language_from_request() disregards "en-us" and "en" languages 
when matching Accept-Language
 2013-05-18 14:37:04 +02:00
Florian Apolloner
16683f29ea Merge pull request #1084 from erikr/master 
Fixed #13546 -- Easier handling of localize field options in ModelForm
 2013-05-18 05:15:15 -07:00
Marc Tamlyn
ef73a8eefd Merge pull request #1083 from Markush2010/ticket20235 
Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
 2013-05-18 05:14:28 -07:00
Erik Romijn
756b81dbd1 Fixed #13546 -- Easier handling of localize field options in ModelForm 2013-05-18 14:13:00 +02:00
Matthew Somerville
1c921cfac3 Fixed #20235 -- Use self.object_list if object_list not present in get_context_data kwargs. 
This is so MultipleObjectMixin can be used in the same way as
SingleObjectMixin.
 2013-05-18 14:10:40 +02:00
Andrew Godwin
7d041b9394 Split up test and make the State classes a bit better. 2013-05-18 13:49:56 +02:00
Andrew Godwin
028bbd15ca Add a deconstruct() method to Fields. 
This allows the field's initial argument to be obtained so it can be
serialised to, and re-created from, a textual format.
 2013-05-18 13:48:57 +02:00
Senko Rasic
493aca453a Fixed #11160 - Ensure full_clean is called from non_form_errors 
Updated FormSet.non_form_errors() to ensure full_clean() has
been called before returning the errors.
 2013-05-18 13:44:27 +02:00
Aymeric Augustin
4bed64c417 Made test introduced in 566e284c pass on Python 3. 2013-05-18 13:34:52 +02:00
Senko Rasic
566e284c56 Added test for multipart, non form-data POST. 
Closes #9054. The bug itself is no longer present.
 2013-05-18 12:50:28 +02:00
Claude Paroz
8fd44b2551 Fixed #20356 -- Prevented crash when HTTP_REFERER contains non-ascii 
Thanks srusskih for the report and Aymeric Augustin for the review.
 2013-05-18 12:39:11 +02:00
Florian Apolloner
051cb1f4c6 Fixed #20411 -- Don't let invalid referers blow up CSRF same origin checks. 
Thanks to edevil for the report and saz for the patch.
 2013-05-18 12:32:47 +02:00
Andrew Godwin
331546f6ee More conversion to a ContextManager schema_editor 2013-05-18 11:48:46 +02:00
Baptiste Mispelon
9012a9e200 Fixed #20422 -- Applied makemessage's --ignore patterns to full path 
Fix makemessage's --ignore patterns being applied to the full path
instead of the file name. Thanks to nnseva for the report and the
original patch.
 2013-05-18 10:40:16 +02:00
Andrew Godwin
b31eea069c Merge branch 'master' into schema-alteration 2013-05-18 10:21:31 +02:00
Shai Berger
9ef4d177d1 Fixed #20388 -- Test failures under Oracle. 
Add "FROM DUAL" to SQL selecting constants in tests for Oracle.
 2013-05-16 15:00:16 +02:00
Daniel Lindsley
33793f7c3e Fixed #19934 - Use of Pillow is now preferred over PIL. 
This starts the deprecation period for PIL (support to end in 1.8).
 2013-05-14 19:32:04 -07:00
Florian Apolloner
e23a5f9a47 Fixed a regression in the test runner loading of runtests.py. 
Refs #17365, #17366, #18727.
 2013-05-11 15:47:40 +02:00
Carl Meyer
9012833af8 Fixed #17365, #17366, #18727 -- Switched to discovery test runner. 
Thanks to Preston Timmons for the bulk of the work on the patch, especially
updating Django's own test suite to comply with the requirements of the new
runner. Thanks also to Jannis Leidel and Mahdi Yusuf for earlier work on the
patch and the discovery runner.

Refs #11077, #17032, and #18670.
 2013-05-10 23:08:45 -04:00
Anssi Kääriäinen
c0d8932a6d Fixed #19939 -- generic relations + split_exclude regression 
Added a test, the issue was already fixed (likely by the patch
for #19385).
 2013-05-11 03:48:58 +03:00
Alex Gaynor
327e362ff3 Fixed an obvious typo. 2013-05-10 08:56:39 -07:00
Andrew Godwin
eb5e50215a Do some basic testing of the recorder 2013-05-10 16:18:19 +01:00
Andrew Godwin
8a1f017777 Add root_node and leaf_node functions to MigrationGraph 2013-05-10 16:09:57 +01:00
Andrew Godwin
9ce8354672 First phase of loading migrations from disk 2013-05-10 16:00:55 +01:00
Aymeric Augustin
a4dec43b52 Fixed two admin_views tests under Oracle. 
Thanks Anssi for the review.
 2013-05-10 16:56:42 +02:00
Andrew Godwin
cb4b0de49e Merge branch 'master' into schema-alteration 2013-05-10 12:55:30 +01:00
Andrew Godwin
f6801a234f Adding a dependency graph class and tests 2013-05-10 12:52:04 +01:00
Aymeric Augustin
9a3708cec8 Fixed a test that fails under Python 3. 2013-05-09 19:33:02 +02:00
Luke Plant
f026a519ae Fixed #19733 - deprecated ModelForms without 'fields' or 'exclude', and added '__all__' shortcut 
This also updates all dependent functionality, including modelform_factory
 and modelformset_factory, and the generic views `ModelFormMixin`,
 `CreateView` and `UpdateView` which gain a new `fields` attribute.
 2013-05-09 16:44:36 +01:00
Luke Plant
1e37cb37ce Further removal of static admin validation that can fail erroneously 2013-05-09 16:44:36 +01:00
Andrew Godwin
75bf394d86 Rest of the _meta.app_cache stuff. Schema tests work now. 2013-05-09 15:59:26 +01:00
Andrew Godwin
104ad0504b Split out a BaseAppCache, make AppCache borg again, add _meta.app_cache 2013-05-09 15:16:43 +01:00
Alex Gaynor
6634cb7b53 Removed a test that didn't make sense; code could never be called the way the test was written. 2013-05-09 06:55:25 -07:00
Luke Plant
2f8f2ad1d7 Removed some failing tests missed in 1556b1c3b7 2013-05-09 01:45:34 +01:00
Luke Plant
1556b1c3b7 Removed fragile admin validation of fields on ModelForm 
Refs #19445
 2013-05-09 00:49:05 +01:00
Aymeric Augustin
832b4a5722 Marked a test as an expected failure on MySQL and Python 3.2. 
This test hits a bug in current ports of MySQLdb.
 2013-05-08 23:12:46 +02:00
Aymeric Augustin
7476d96f83 Marked tests of BinaryFields as expected failures on MySQL and Python 3. 
Current ports of MySQLdb are very buggy in this area.
 2013-05-08 15:48:39 +02:00
Tai Lee
99a6f0e77c Fixed #20354 -- makemessages no longer crashes with UnicodeDecodeError 
Handle the `UnicodeDecodeError` exception, send a warning to `stdout` with the
file name and location, and continue processing other files.
 2013-05-07 21:22:05 +02:00
Florian Apolloner
da85c8cf32 Fixed a regression introduced in 9f7a01ef2b. 2013-05-05 15:27:14 +02:00
Florian Apolloner
780fa48f5f Fixed test failures introduced in a5becad909. 2013-05-01 16:40:49 +02:00
Aymeric Augustin
3a4276ffc3 Tested that get_or_create raises IntegrityError. 
It used to raise "DatabaseError: no such savepoint" with the old
transaction management. Closes #15117.
 2013-04-28 17:15:41 +02:00
Aymeric Augustin
90fe9141de Fixed #18986 -- Improved error message for missing files 
in CachedStaticFilesStorage. Thanks zyegfryed for his work on the patch.
 2013-04-28 16:45:05 +02:00
Claude Paroz
4769db6b5f Fixed #20321 -- Added missing key name in MergeDict KeyError message 
Thanks mark.harviston et gmail.com for the report.
 2013-04-26 08:59:34 +02:00
Marti Raudsepp
172b50b722 Clearer explanation when exception has no message 
"No exception supplied" is misleading; actually there is an exception,
but there's no message string.
 2013-04-23 21:18:17 +03:00
Alex Gaynor
714161c864 Fix != operations on lazy objects. 2013-04-19 10:58:29 -07:00
Anton Baklanov
59d127e45f Fixed #20276 -- Implemented __bool__ for MergeDict 
MergeDict evaluates now to False if all contained dicts are empty.
Thanks til for the report and the initial patch.
 2013-04-19 10:08:16 +02:00
Andrew Godwin
6e21a59402 Fix schema editor interaction with new transactions 2013-04-19 09:01:45 +01:00
Andrew Godwin
7f3678dc4c Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/backends/mysql/base.py
	django/db/backends/oracle/base.py
	django/db/backends/oracle/creation.py
	django/db/backends/postgresql_psycopg2/base.py
	django/db/backends/sqlite3/base.py
	django/db/models/fields/related.py
 2013-04-18 17:16:39 +01:00
Carl Meyer
a98465c040 Refs #14567 -- Fixed failing test that wasn't being run. 2013-04-16 13:34:06 -06:00
Matthew Tretter
a506b6981b Fixed #18231 -- Made JavaScript i18n not pollute global JS namespace. 
Also, use Django templating for the dynamic generated JS code and use
more idiomatic coding techniques.

Thanks Matthew Tretter for the report and the patch.
 2013-04-14 17:45:01 -03:00
Claude Paroz
be9ae693c4 Fixed #17840 -- Generalized named placeholders in form error messages 
Also fixed plural messages for DecimalField.
 2013-04-13 18:55:50 +02:00
Baptiste Mispelon
9ac4dbd7b5 Fixed #4592: Made CheckboxSelectMultiple more like RadioSelect 
I refactored RadioSelect and CheckboxSelectMultiple to
make them inherit from a base class, allowing them to share
the behavior of being able to iterate over their subwidgets.

Thanks to Matt McClanahan for the initial patch and to
Claude Paroz for the review.
 2013-04-13 16:37:27 +02:00
Baptiste Mispelon
c4186c2fec Fixed #4117: Apply id attribute to the outer <ul> of RadioSelect 2013-04-13 12:23:25 +02:00
Claude Paroz
f56b703b27 Used a Python 3 compatible StringIO in test_utils 2013-04-13 11:38:13 +02:00
Baptiste Mispelon
844fbc85c1 Fixed #19874: Apply id attribute to the outer <ul> of CheckboxSelectMultiple 2013-04-13 11:09:47 +02:00
Claude Paroz
3f05c70be0 Updated a renamed test file 2013-04-13 11:09:47 +02:00
Preston Timmons
6d96831769 Fixed template_tests so discovery doesn't directly find tests that require setuptools. 2013-04-12 15:42:58 -06:00
Preston Timmons
56e777eba3 Modified view_tests for unittest2 discovery. 2013-04-12 15:42:07 -06:00
Preston Timmons
e8446be560 Modified validation to work with unittest2 discovery. 2013-04-12 15:33:22 -06:00
Preston Timmons
612ef3e5c9 Modified utils_tests for unittest2 discovery. 2013-04-12 15:31:58 -06:00
Preston Timmons
3810dc3070 Modified template_tests for unittest2 discovery. 2013-04-12 15:13:59 -06:00
Preston Timmons
44293c5c05 Modified model_fields for unittest2 discovery. 2013-04-12 15:11:12 -06:00
Preston Timmons
3ca3d2206c Modified generic_views for unittest2 discovery. 2013-04-12 15:10:04 -06:00
Preston Timmons
5e84abec14 Modified comment_tests for unittest2 discovery. 2013-04-12 15:07:24 -06:00
Preston Timmons
6f3e139739 Modified test_client_override to work with unittest2 discovery. 2013-04-12 15:05:34 -06:00
Preston Timmons
751b007c98 Modified test_utils to work with unittest2 discovery. 2013-04-12 15:00:48 -06:00
Preston Timmons
cdf520ee86 Modified forms_tests to work with unittest2 discovery. 2013-04-12 15:00:17 -06:00
Claude Paroz
b04fd579d5 Fixed #20237 (again) Allowed binary parameter to assertContains 2013-04-12 20:12:42 +02:00
Baptiste Mispelon
ab686022f8 Fixed #20211: Document backwards-incompatible change in BoundField.label_tag 
Also cleaned up label escaping and consolidated the test suite regarding
label_tag.
 2013-04-12 10:17:17 +02:00
Claude Paroz
fe01404bb9 Fixed #20237 -- Reenabled assertContains with binary parameter 
Thanks Baptiste Mispelon for the review.
 2013-04-11 10:38:24 +02:00
Baptiste Mispelon
e7b9c11c3f Fixed #20231 -- Don't use allow_lazy on smart_split 2013-04-10 13:05:29 +02:00
Claude Paroz
118faa0893 Made usage of assertTemplateUsed in admin_views tests 
Thanks Baptiste Mispelon for the suggestion.
 2013-04-10 10:16:15 +02:00
Baptiste Mispelon
f69396665c Fix admin_views tests after commit 3be368c73e. 2013-04-08 22:02:18 +02:00
Tobias McNulty
161c4da588 Fixed #14019 -- Initialize SQLInsertCompiler.return_id attribute. 2013-04-08 13:41:36 -06:00
Baptiste Mispelon
f9dc1379b8 Fix #15126: Better error message when passing invalid options to ModelForm.Meta. 2013-04-07 19:08:53 +02:00
Simon Charette
216580e034 Fixed #20207 -- Handle ManyToManyField with a unicode name correctly. 2013-04-05 15:09:53 -04:00
Baptiste Mispelon
c250f9c99b Fixed #20038 -- Better error message for host validation. 2013-04-03 14:27:20 -06:00
Preston Timmons
8ce46375ae Move last remaining tests out of models.py files; prep for test discovery. 2013-04-02 19:00:55 -06:00
Claude Paroz
edc782b7b5 Relaxed time frame check in test_strip_tags 2013-04-01 22:53:04 +02:00
Julien Phalip
2f81a0ca65 Fixed #20169 -- Ensured that the WSGI request's path is correctly based on the SCRIPT_NAME environment parameter or the FORCE_SCRIPT_NAME setting, regardless of whether or not those have a trailing slash. Thanks to bmispelon for the review. 2013-04-01 12:04:44 -07:00
Claude Paroz
8c41bd93c2 Fixed #16737 -- Support non-ascii column names in inspectdb 
Thanks moof at metamoof.net for the report.
 2013-04-01 19:59:57 +02:00
Claude Paroz
2817a29d90 Imported unittest from django.utils in util_tests 
Without this, the 'new' assertion methods are not present with
Python 2.6.
 2013-04-01 19:59:57 +02:00
Claude Paroz
dcf563071f Fixed #5014 -- Guessed max_digits and decimal_places for SQLite 
Decimal is treated as float on SQLite, hence inspectdb can only
guess max_digits and decimal_places arguments.
 2013-04-01 18:32:57 +02:00
Claude Paroz
51028f50b6 Fixed getting max_digits for MySQL decimal fields 
Refs #5014.
 2013-04-01 18:17:00 +02:00
Claude Paroz
a01361b5ae Added more tests for strip_tags utility 
Refs #19237.
 2013-04-01 16:48:47 +02:00
Claude Paroz
b474ffe63a Fixed #20172 -- Ensured urlize supports IPv4/IPv6 addresses 
Thanks Marc Aymerich for the report and the initial patch.
 2013-04-01 15:37:37 +02:00
Joe Friedl
2d0db67813 Fixed #20167 -- Preserve the traceback of ImportErrors in import_by_path. 
Thanks @carljm for the review.
 2013-03-31 23:00:06 -04:00
Claude Paroz
3ff3212713 Fixed #19220 -- Prevented decimals to be displayed in scientific notation 
Thanks nebstrebor for the report and antofik for the patch.
 2013-03-31 22:39:01 +02:00
Baptiste Mispelon
5080311998 Fixed #20130 -- Regression in {% cache %} template tag. 2013-03-30 12:13:08 +01:00
Christoph Sieghart
465b01f065 Fixed #19998 -- Fixed --ignorenonexistent support for XML based fixtures. 2013-03-30 11:59:50 +01:00
Baptiste Mispelon
a40746b1cb Fix #20158: invalid code in queryset_pickle test models. 2013-03-29 13:32:21 +01:00
Claude Paroz
86b1c31689 Fixed #19954 -- Fixed MySQL _last_executed decoding 
Queries can contain binary data undecodable with utf-8. In this
case, using the 'replace' errors mode when decoding seems like
an acceptable representation of the query.
Thanks Marcel Ryser for the report.
 2013-03-28 20:08:37 +01:00
Jacob Kaplan-Moss
4befef91f1 Correctly restore warning capture after logging tests. 
This is a fix to the wrong behavior that 15c3906eeb introduced.
 2013-03-27 17:01:11 -05:00
Jacob Kaplan-Moss
654d8e96ae Fixed logging-related test failure introduced by e79b857. 2013-03-27 12:05:31 -05:00
Jacob Kaplan-Moss
f6989e559c Merge remote-tracking branch 'ptone/18985-fix' 2013-03-27 10:34:28 -05:00
Claude Paroz
34a50e99e8 Added regression test for custom SQL containing percents 
Refs #3485.
 2013-03-26 23:19:32 +01:00
Anssi Kääriäinen
e17fa9e877 Fixed #20091 -- Oracle null promotion for empty strings 2013-03-26 14:19:54 +02:00
Adam Wentz
a4b8a4b632 Fixed #20121 -- Removed LogEntry.get_admin_url's hard-coded path. 
Updated LogEntry.get_admin_url to use 'reverse' instead
of a hard-coded path.
 2013-03-25 23:45:27 -04:00
Claude Paroz
066bf42675 Removed forced typecasting of help_text/label Field arguments 
In any case, setting those variables to non-ascii utf-8 bytestrings
is now considered a programming error.
 2013-03-25 21:38:21 +01:00
Preston Holmes
e79b857a07 Fixed #18985 -- ensure module level deprecations are displayed 
Also don't compete with -W CLI option.

Thanks to Aymeric Augustin for the catch, and Claude Paroz for the patch.
 2013-03-24 22:06:02 -07:00
Loic Bistuer
521765f63d Fixed #19541 -- Fixed BaseHandler to enable reversing URLs in response middlewares 
and streamed responses with respect to per-request urlconf.
 2013-03-25 03:19:19 +07:00
Anssi Kääriäinen
266de5f9ae Fixed 19385 -- Added ORM support for multicolumn joins 
This patch iproved two major parts in Django. First, the fields.related
was refactored. The main addition there was ForeignObject. Second, the
ORM now handles multicolumn joins in most cases, though there are still
cases that do not work correcly (split_exclude() for example).

In addition there were extesive changes to how GenericRelation works.
Before it was a fake m2m field, now it is a pure virtual fields and is
based on ForeignObject.

There is still much room for improvement. The related fields code is
still somewhat confusing, and how fields are represented in model._meta
should also be revisited.

This patch was written mostly by Jeremy Tillman with some final polish
by the committer.
 2013-03-24 18:08:01 +02:00
Aymeric Augustin
bc35b95274 Fixed test failures introduced in e16c48e001. 2013-03-24 15:27:50 +01:00
Aymeric Augustin
e16c48e001 Fixed #15124 -- Changed the default for BooleanField. 
Thanks to the many contributors who updated and improved the patch over
the life of this ticket.
 2013-03-24 13:47:01 +01:00
Claude Paroz
76aecfbc4b Fixed #9055 -- Standardized behaviour of parameter escaping in db cursors 
Previously, depending on the database backend or the cursor type,
you'd need to double the percent signs in the query before passing
it to cursor.execute. Now cursor.execute consistently need percent
doubling whenever params argument is not None (placeholder substitution
will happen).
Thanks Thomas Güttler for the report and Walter Doekes for his work
on the patch.
 2013-03-23 17:11:10 +01:00
Claude Paroz
164528acc8 Fixed #20108 -- Fixed filepath_to_uri decoding error 
This was a regression due to unicode_literals usage. Thanks Ivan
Virabyan for the report and the initial patch.
 2013-03-22 17:55:12 +01:00
Marc Tamlyn
829dc3c5a6 Fixed #20094 - Be more careful when checking for Iterator 
Python 2.6 has some different behaviour when checking
isinstance(foo, collections.Iterator).
 2013-03-22 17:31:29 +01:00
Andrew Gorcester
f9ab543720 Fixed #20084 -- Provided option to validate formset max_num on server. 
This is provided as a new "validate_max" formset_factory option defaulting to
False, since the non-validating behavior of max_num is longstanding, and there
is certainly code relying on it. (In fact, even the Django admin relies on it
for the case where there are more existing inlines than the given max_num). It
may be that at some point we want to deprecate validate_max=False and
eventually remove the option, but this commit takes no steps in that direction.

This also fixes the DoS-prevention absolute_max enforcement so that it causes a
form validation error rather than an IndexError, and ensures that absolute_max
is always 1000 more than max_num, to prevent surprising changes in behavior
with max_num close to absolute_max.

Lastly, this commit fixes the previous inconsistency between a regular formset
and a model formset in the precedence of max_num and initial data. Previously
in a regular formset, if the provided initial data was longer than max_num, it
was truncated; in a model formset, all initial forms would be displayed
regardless of max_num. Now regular formsets are the same as model formsets; all
initial forms are displayed, even if more than max_num. (But if validate_max is
True, submitting these forms will result in a "too many forms" validation
error!) This combination of behaviors was chosen to keep the max_num validation
simple and consistent, and avoid silent data loss due to truncation of initial
data.

Thanks to Preston for discussion of the design choices.
 2013-03-21 01:27:24 -07:00
Carny Cheng
aaec4f2bd8 Fixed #18839 - Field.__init__() now calls super(). 2013-03-20 16:20:57 -07:00
Matthew Wood
a7960bcb35 Fixed #18972 -- Refactored bundled wsgi server's chunking algorithm. 
Thanks to amosonn at yahoo.com for the report, @doda for the initial patch and
@datagrok for the revamped logic and test case.
 2013-03-20 18:46:26 -04:00
Anssi Kääriäinen
80e68ee2ff Added tests for already fixed #20101 
The ticket dealt with a case where one query had .exclude() that
produced a subquery, the other query had a join to the same model that
was subqueried in the first query. This was already fixed in master, so
only test added.
 2013-03-21 00:43:26 +02:00
Claude Paroz
23490a2394 Revert "Fixed 19895 -- Made second iteration over invalid queryset raise an exception too" 
This reverts commit 2cd0edaa47.
This commit was the cause of a memory leak. See ticket for more details.
Thanks Anssi Kääriäinen for identifying the source of the bug.
 2013-03-20 10:41:53 +01:00
Paul Collins
9a85ad89c2 Fixed #16319 -- added SuccessMessageMixin to contrib.messages 
Thanks martinogden for the initial patch and d1ffuz0r for tests.
 2013-03-19 21:02:55 -07:00
Simon Charette
5938e7013e Fixed a python 3.2 syntax error and python 3 warning introduced by 054ce2aa02. 2013-03-19 22:16:48 -04:00
konarkmodi
483e1b807e Refs #18586 -- Split out long custom_columns lookup test into multiple tests. 2013-03-19 15:58:54 -07:00
Juan Catalano
054ce2aa02 Fixed #20088 -- Changed get_admin_log not to depend on User id field 
Before this change, the get_admin_log method would expect User model's
FK to be named `id`. When changing that FK name, admin/index.html
rendering would fail.

This includes:
 * Changed the use of id for the use of pk property.
 * Added a regression test that fails without the patch.

This commit refs #20088.
 2013-03-19 19:30:43 -03:00
Deric Crago
9d6ecc6bc6 Fixed #19327 -- Added handling of double login attempts in admin. 
Thanks to Krzysztof Jurewicz for initial patch and
adupin for tests.
 2013-03-18 17:11:07 -07:00
Aymeric Augustin
31b5275235 Fixed #13260 -- Quoted arguments interpolated in URLs in reverse. 2013-03-18 23:58:22 +01:00
Aymeric Augustin
9dc5702932 Fixed #19456 -- Avoid infinite recursion when tracing LazyObject.__init__. 
Thanks blaze33 for the patch.
 2013-03-18 11:22:43 +01:00
Aymeric Augustin
0efafa4c54 Fixed #18447 -- Made LazyObject unwrap on dict access. 
Thanks Roman Gladkov and Zbigniew Siciarz.
 2013-03-18 11:10:19 +01:00
Aymeric Augustin
20a91cce04 Fixed #17037 -- Added a --all option to diffsettings. 2013-03-18 00:03:58 +01:00
Anssi Kääriäinen
46f4b19920 Removed debug code 2013-03-17 11:31:15 +02:00
Baptiste Mispelon
d5683bd06b Fix #20058: Make compilemessages use stdout instead of stderr. 2013-03-16 19:48:40 +01:00
Anssi Kääriäinen
2a2708e1b2 Fixed #17502 -- Made joining in inheritance cases consistent 
The original problem was that when filtering two levels up in
inheritance chain, Django optimized the join generation so that the
middle model was skipped. But then Django generated joins from top
to middle to bottom for SELECT clause, and thus there was one extra
join (top->middle->bottom + top -> bottom).

This case is fixed in master as the filtering optimization is gone.
This has the side effect that in some cases there is still extra join
if the SELECT clause doesn't contain anything from middle or bottom.
 2013-03-15 11:06:26 +02:00
Aymeric Augustin
3f2befc931 Deprecated django.views.defaults.shortcut. 2013-03-14 20:30:23 +01:00
Claude Paroz
2f121dfe63 Fixed #17051 -- Removed some 'invalid' field error messages 
When the 'invalid' error message is set at field level, it masks
the error message raised by the validator, if any.
 2013-03-14 17:03:43 +01:00
Claude Paroz
34d098665d Add a specific error message for URLValidator 2013-03-14 15:26:30 +01:00
Claude Paroz
9883551d50 Fixed #20039 -- Fixed has_changed form detection for required TypedChoiceFields 
Thanks Florian Apolloner for the report and the review.
Also fixes #19643.
 2013-03-14 14:49:07 +01:00
Anssi Kääriäinen
6b4834952d Fixed #16649 -- Refactored save_base logic 
Model.save() will use UPDATE - if not updated - INSERT instead of
SELECT - if found UPDATE else INSERT. This should save a query when
updating, but will cost a little when inserting model with PK set.

Also fixed #17341 -- made sure .save() commits transactions only after
the whole model has been saved. This wasn't the case in model
inheritance situations.

The save_base implementation was refactored into multiple methods.
A typical chain for inherited save is:
save_base()
    _save_parents(self)
        for each parent:
            _save_parents(parent)
            _save_table(parent)
    _save_table(self)
 2013-03-14 11:01:47 +02:00
Florian Apolloner
22b7870e40 Began implementing a shared set of test models to speed up tests. 2013-03-13 23:25:26 +01:00
Jacob Kaplan-Moss
1059da8de6 Merge pull request #900 from bmispelon/ticket-20022 
Fix #20022: Correctly handle prefixes with url-unsafe characters in reverse()
 2013-03-13 22:39:25 +01:00
Baptiste Mispelon
4fa7f3cdd9 Fix #20022: Correctly handle prefixes with url-unsafe characters in reverse(). 2013-03-13 18:19:29 +01:00
Aymeric Augustin
83a416f5e7 Made atomic usable when autocommit is off. 
Thanks Anssi for haggling until I implemented this.

This change alleviates the need for atomic_if_autocommit. When
autocommit is disabled for a database, atomic will simply create and
release savepoints, and not commit anything. This honors the contract of
not doing any transaction management.

This change also makes the hack to allow using atomic within the legacy
transaction management redundant.

None of the above will work with SQLite, because of a flaw in the design
of the sqlite3 library. This is a known limitation that cannot be lifted
without unacceptable side effects eg. triggering arbitrary commits.
 2013-03-13 15:17:40 +01:00
Anssi Kääriäinen
bd0cba58aa Fixed failing aggregation tests on MySQL 2013-03-13 12:44:24 +02:00
Anssi Kääriäinen
d3f00bd570 Refactored qs.add_q() and utils/tree.py 
The sql/query.py add_q method did a lot of where/having tree hacking to
get complex queries to work correctly. The logic was refactored so that
it should be simpler to understand. The new logic should also produce
leaner WHERE conditions.

The changes cascade somewhat, as some other parts of Django (like
add_filter() and WhereNode) expect boolean trees in certain format or
they fail to work. So to fix the add_q() one must fix utils/tree.py,
some things in add_filter(), WhereNode and so on.

This commit also fixed add_filter to see negate clauses up the path.
A query like .exclude(Q(reversefk__in=a_list)) didn't work similarly to
.filter(~Q(reversefk__in=a_list)). The reason for this is that only
the immediate parent negate clauses were seen by add_filter, and thus a
tree like AND: (NOT AND: (AND: condition)) will not be handled
correctly, as there is one intermediary AND node in the tree. The
example tree is generated by .exclude(~Q(reversefk__in=a_list)).

Still, aggregation lost connectors in OR cases, and F() objects and
aggregates in same filter clause caused GROUP BY problems on some
databases.

Fixed #17600, fixed #13198, fixed #17025, fixed #17000, fixed #11293.
 2013-03-13 10:44:49 +02:00
Anssi Kääriäinen
d744c550d5 Fixed #19964 -- Removed relabel_aliases from some structs 
Before there was need to have both .relabel_aliases() and .clone() for
many structs. Now there is only relabeled_clone() for those structs
where alias is the only mutable attribute.
 2013-03-12 21:33:47 +02:00
Aymeric Augustin
885d98d24a Fixed #20028 -- Made atomic usable on callable instances. 
Thanks Anssi for the report.
 2013-03-12 10:52:16 +01:00
Aymeric Augustin
f8a634afa2 Fixed tests that relied on MANAGERS not being empty. 
Regression in d0561242.
 2013-03-11 23:30:02 +01:00
Jacob Kaplan-Moss
d056124269 Remove a special case for comment tests from runtests.py. 2013-03-11 15:38:53 -05:00
Aymeric Augustin
b746f8a9e3 Adjusted query counts to account for new savepoints. 2013-03-11 21:07:19 +01:00
Aymeric Augustin
55a9be8ecf Ran a test that closes the database connection outside of a transaction. 2013-03-11 19:42:59 +01:00
Claude Paroz
9b74a8391d Removed forced settings in runtests 
Tests that require USE_I18N, LOGIN_URL or certain MIDDLEWARE_CLASSES
should be decorated appropriately.
 2013-03-11 17:46:56 +01:00
Aymeric Augustin
e654180ce2 Improved the API of set_autocommit. 2013-03-11 15:10:58 +01:00
Aymeric Augustin
86fd920f67 Removed a test that no longer makes any sense. 
Since unmanaged == autocommit, there's nothing to commit or roll back.
 2013-03-11 15:05:04 +01:00
Aymeric Augustin
0cee3c0e43 Updated a test that doesn't make sense with autocommit. 2013-03-11 15:05:04 +01:00
Aymeric Augustin
107d9b1d97 Added an option to disable the creation of savepoints in atomic. 2013-03-11 15:05:04 +01:00
Aymeric Augustin
ac37ed21b3 Deprecated TransactionMiddleware and TRANSACTIONS_MANAGED. 
Replaced them with per-database options, for proper multi-db support.

Also toned down the recommendation to tie transactions to HTTP requests.
Thanks Jeremy for sharing his experience.
 2013-03-11 15:04:05 +01:00
Aymeric Augustin
7c46c8d5f2 Added some assertions to enforce the atomicity of atomic. 2013-03-11 14:48:55 +01:00
Aymeric Augustin
d7bc4fbc94 Implemented an 'atomic' decorator and context manager. 
Currently it only works in autocommit mode.

Based on @xact by Christophe Pettus.
 2013-03-11 14:48:55 +01:00
Aymeric Augustin
4b31a6a9e6 Added support for savepoints in SQLite. 
Technically speaking they aren't usable yet.
 2013-03-11 14:48:55 +01:00
Aymeric Augustin
3bdc7a6a70 Deprecated transaction.is_managed(). 
It's synchronized with the autocommit flag.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
ba5138b1c0 Deprecated transaction.commit/rollback_unless_managed. 
Since "unless managed" now means "if database-level autocommit",
committing or rolling back doesn't have any effect.

Restored transactional integrity in a few places that relied on
automatically-started transactions with a transitory API.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
af9e9386eb Enabled autocommit for PostgreSQL. 
For users who didn't activate autocommit in their database options, this
is backwards-incompatible in "non-managed" aka "auto" transaction state.
This state now uses database-level autocommit instead of ORM-level
autocommit.

Also removed the uses_autocommit feature which lost its purpose.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
8717b0668c Separated autocommit and isolation level handling for PostgreSQL. 
Autocommit cannot be manipulated independently from an open connection.
This commit introduces a minor change in behavior: entering transaction
management forces opening a databasse connection. This shouldn't be
backwards incompatible in any practical use case.
 2013-03-11 14:48:54 +01:00
Aymeric Augustin
7aacde84f2 Made transaction.managed a no-op and deprecated it. 
enter_transaction_management() was nearly always followed by managed().

In three places it wasn't, but they will all be refactored eventually.
The "forced" keyword argument avoids introducing behavior changes until
then.

This is mostly backwards-compatible, except, of course, for managed
itself. There's a minor difference in _enter_transaction_management:
the top self.transaction_state now contains the new 'managed' state
rather than the previous one. Django doesn't access
self.transaction_state in _enter_transaction_management.
 2013-03-11 14:48:53 +01:00
Aymeric Augustin
ce76fbfc5a Fixed #20019 -- Ensured HttpRequest.resolver_match always exists. 
Obviously it isn't set until the URL is resolved.
 2013-03-10 23:28:19 +01:00
Ramiro Morales
7fca4416c7 Made (make|compile)messages check for availability of gettext commands. 
Refs #19584.
 2013-03-10 17:31:11 -03:00
Claude Paroz
6a91b63842 Fixed #19923 -- Display tracebacks for non-CommandError exceptions 
By default, show tracebacks for management command errors when the
exception is not a CommandError.
Thanks Jacob Radford for the report.
 2013-03-09 12:38:45 +01:00
Claude Paroz
cbfb8ed53b Fixed a regression in forms changed_data 
Thanks Loic Bistuer for spotting the regression and the initial
patch. Refs #16612.
 2013-03-08 18:19:24 +01:00
Loic Bistuer
6983a1a540 Fixed #15363 -- Renamed and normalized to get_queryset the methods that return a QuerySet. 2013-03-08 10:11:45 -05:00
Aymeric Augustin
477d737e1e Merge pull request #850 from bmispelon/ticket-19916 
Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments
 2013-03-07 12:12:29 -08:00
Alex Gaynor
bbbd698c7a Added a ManyToManyField(db_constraint=False) option, this allows not creating constraints on the intermediary models. 2013-03-07 11:24:51 -08:00
Baptiste Mispelon
81804ae474 Fix 19916. Smarter tokenizing of contrib.comment's templatetags arguments. 2013-03-07 19:30:38 +01:00
Claude Paroz
4cccb85e29 Fixed #19997 -- Added custom EMPTY_VALUES to form fields 
Thanks Loic Bistuer for the report and the patch.
 2013-03-07 15:22:03 +01:00
Igor Támara
e2ee02c5bd Fixed #19951 -- Admin: Invalid model PK values shouldn't cause 500 status. 
Avoid ValueError in admin when passing a string as PK for an inherited
model with an integer PK field.

Thanks ikks for the patch. See also #11191.
 2013-03-06 21:38:44 -03:00
Ramiro Morales
c31a9793c6 Merge pull request #882 from loic/testfix 
Fixed minor warnings in tests.
 2013-03-06 16:22:06 -08:00
Preston Holmes
876fc39128 PEP8 cleanup of functional.py 2013-03-06 16:14:46 -08:00
Preston Holmes
0ea5bf88dd Fixed #19543 -- implemented SimpleLazyObject.__repr__ 
Thanks to Florian Hahn for the patch
 2013-03-06 16:13:12 -08:00
Aymeric Augustin
b3aa853ec5 Used more precise test assertions. 2013-03-06 15:33:35 +01:00
Loic Bistuer
9ba0e4e4ee Fixed minor warnings in tests. 2013-03-06 01:13:36 +07:00
Juan Pedro Fisanotti
d9330d5be2 Fixed #6585 -- Admin relationship widgets: Respect ordering defined by target model's ModelAdmin. 
Thanks Gary Wilson for the report and Juan Pedro Fisanotti, Carlos
Matías de la Torre for the fix.
 2013-03-04 18:08:53 -03:00
Javier Mansilla
3ea0c7d35a Fixed #19838 -- Admin: Don't leak a 500 HTTP status when trying to delete protected FKs. 
Thanks rafadev for the report and Javier Mansilla for the fix.
 2013-03-04 13:30:59 -03:00
Ramiro Morales
60dd4eabe7 Removed mentions of modeltests. 2013-03-03 18:44:06 -03:00
matiasb
804366327d Fixed #19915 - Made blocktrans tag honor TEMPLATE_STRING_IF_INVALID. 
Thanks Natalia Bidart for the report and Matías Bordese for the fix.
 2013-03-03 16:10:11 -03:00
Claude Paroz
384c180e41 Fixed #19917 -- Added microseconds in default TIME_INPUT_FORMATS 
Thanks minddust for the report.
 2013-03-02 18:11:10 +01:00
Aymeric Augustin
e0449316eb Fixed #18130 -- Made the isolation level configurable on PostgreSQL. 
Thanks limscoder for the report and niwi for the draft patch.
 2013-03-02 15:05:49 +01:00
Claude Paroz
c5a25c2771 Add introspection support for BinaryField 2013-03-02 10:29:03 +01:00
Claude Paroz
d680a3f447 Added support for serializing BinaryField 2013-03-02 10:29:02 +01:00
Claude Paroz
8ee1eddb7e Add a BinaryField model field 
Thanks Michael Jung, Charl Botha and Florian Apolloner for review
and help on the patch.
 2013-03-02 10:29:02 +01:00
Simon Charette
0f306cad84 Import CaptureQueriesContext from its original module. 2013-03-02 03:45:42 -05:00
Simon Charette
fb3d85bd14 Fixed #10399 -- Tested that o2o field updates are not constrained by an inner query. 2013-03-02 03:24:08 -05:00
Simon Charette
952ba5237e Added a context manager to capture queries while testing. 
Also made some import cleanups while I was there.

Refs #10399.
 2013-03-02 02:41:14 -05:00
Claude Paroz
3318595c0b Fixed #18898 -- Added tests with a fix for ModelMultipleChoiceField 2013-03-01 09:35:18 +01:00
Claude Paroz
892bc91cb0 Fixed #16612 -- Improved has_changed detection for localized field values 
Thanks Simon Charette for the review.
 2013-03-01 09:35:04 +01:00
Aymeric Augustin
cf30469164 Fixed tests broken in 2ee21d9. 2013-02-28 17:08:16 +01:00
Aymeric Augustin
2ee21d9f0d Implemented persistent database connections. 
Thanks Anssi Kääriäinen and Karen Tracey for their inputs.
 2013-02-28 15:28:13 +01:00
Aymeric Augustin
aa089b106b Fixed #5241 -- Kept active transalation in LocaleMiddleware.process_response. 2013-02-28 14:21:48 +01:00
Anssi Kääriäinen
06de130dae Fixed #12823 -- Was already fixed in master, tests added 
Also added a little improvement to sql/query.py to get rid of
non-necessary IS NOT NULL check.
 2013-02-28 15:05:48 +02:00
Łukasz Langa
af3321a1e8 use the real path to fix OS X /var/folders vs. /private/var/folders mismatch 2013-02-27 23:33:47 +01:00
Anssi Kääriäinen
21189cb80b Made dateformat tests reactivate original language 2013-02-27 23:48:17 +02:00
Aymeric Augustin
7aaa8a7779 Fixed a test that relied on database exceptions not being wrapped. 2013-02-27 21:12:48 +01:00
Aymeric Augustin
b2c697b029 Fixed a PendingDeprecationWarning in template_tests. 2013-02-27 21:09:27 +01:00
Anssi Kääriäinen
50328f0a61 Fixed #19861 -- Transaction ._dirty flag improvement 
There were a couple of errors in ._dirty flag handling:
  * It started as None, but was never reset to None.
  * The _dirty flag was sometimes used to indicate if the connection
    was inside transaction management, but this was not done
    consistently. This also meant the flag had three separate values.
  * The None value had a special meaning, causing for example inability
    to commit() on new connection unless enter/leave tx management was
    done.
  * The _dirty was tracking "connection in transaction" state, but only
    in managed transactions.
  * Some tests never reset the transaction state of the used connection.
  * And some additional less important changes.

This commit has some potential for regressions, but as the above list
shows, the current situation isn't perfect either.
 2013-02-27 17:54:27 +02:00
Łukasz Langa
40b9f4fb8b [py3] Always fed hashlib with bytes. 2013-02-27 10:02:07 +01:00
Ramiro Morales
a28e2e7c4d Removed a .mo file incorrectly put under Git control. 2013-02-26 22:45:08 -03:00
Ramiro Morales
f0bd553922 Simplified compilemessages tests a bit. 2013-02-26 22:30:49 -03:00
Ramiro Morales
dfa9324966 Don't use os.system() in compilemessages. 
Fixes #19584.

This implies stop storing file path command line arguments in envvars as
a security measure to start relying on with Popen's shell=False instead,
and addition of an 'utils' module.

Thanks kmichel_wgs for the report.
 2013-02-26 21:31:53 -03:00
Claude Paroz
58a2fc820e Fixed i18n test to match changed translation 
Forward port of ab6ff2e0ac from stable/1.5
 2013-02-26 21:51:06 +01:00
Florian Apolloner
33234aa8f7 Fixed discovery of the Django installation during tests. 
If Django was symlinked into site-packages the previous approach to discover
the tests subdirectory would fail. The revised version now always points to
the location of the source and not the import path.
 2013-02-26 21:04:32 +01:00
Florian Apolloner
0fe11fca40 Changed test_runner tests to use full python path for settings files. 2013-02-26 16:02:24 +01:00
Florian Apolloner
1535fcfdba fixed admin_scripts tests on python 3.3 2013-02-26 15:38:11 +01:00
Florian Apolloner
0dc7ff6b7a Ensured that we have an absolute path to RUNTESTS_DIR. 
This is needed to make 'python runtests.py' work, otherwise only
'python ./runtests.py' would work.
 2013-02-26 15:20:37 +01:00
Florian Apolloner
4d9f39f307 Renamed a template to be found by the loaders. 2013-02-26 14:36:58 +01:00
Florian Apolloner
33836cf88d Renamed some tests and removed references to modeltests/regressiontests. 2013-02-26 14:36:57 +01:00
Florian Apolloner
737a5d71f0 Adjusted coveragerc 2013-02-26 14:36:57 +01:00
Florian Apolloner
fc074db29c Adjusted runtests to the new layout. 2013-02-26 14:36:57 +01:00
Florian Apolloner
89f40e3624 Merged regressiontests and modeltests into the test root. 2013-02-26 14:36:57 +01:00
Florian Apolloner
b3d2ccb5bf Removed __init__.py files. 2013-02-26 14:36:57 +01:00
Florian Apolloner
41d7a9a907 Moved test_templates to templates to prevent issues with regressiontests/templates later on. 2013-02-26 14:36:57 +01:00
Aymeric Augustin
8dd8400f7e Updated an inaccurate comment. 
Tests can run nearly as fast under PostgreSQL and MySQL as under SQLite
with a bit of configuration and the speedup is always a good thing.
 2013-02-26 10:00:14 +01:00
Carl Meyer
6a8f95d812 Fixed a caching test on Python 3. 2013-02-25 18:12:55 -07:00
Łukasz Langa
6a057e1595 Fixed #18191 -- Don't consider Accept-Language redundantly in cache key. 
Thanks to choongmin for the original patch.
 2013-02-25 16:10:57 -07:00
Aymeric Augustin
e76147a83a Fixed #19634 -- Added proper __hash__ methods. 
Classes overriding __eq__ need a __hash__ such that equal objects have
the same hash.

Thanks akaariai for the report and regebro for the patch.
 2013-02-25 23:05:20 +01:00
Carl Meyer
509798ae06 Use built-in fixture support rather than calling loaddata in setUp(). 2013-02-25 12:13:10 -07:00
Aymeric Augustin
86b96038f2 Merge pull request #847 from fhahn/ticket_18176 
Fixed #18176 -- Added test for year lookups with year < 1000
 2013-02-25 09:26:56 -08:00
Carl Meyer
906dc8522a Fixed #19854 -- Turn Django's own Selenium tests off by default. 2013-02-25 10:14:42 -07:00
Florian Hahn
f28c301a47 Fixed #18176 -- Added test for year lookups with year < 1000 
Thanks Tomas Ehrlich for the initial test
 2013-02-25 17:13:27 +01:00
Claude Paroz
6d52bcbb7c Fixed #19903 -- Fixed unbalanced setUp/tearDown calls in LiveServerAddress test 2013-02-25 08:58:11 +01:00
Aymeric Augustin
7b49da1c38 Changed testing strategy used in 6b03179e. 
Avoid polluting the app cache as it causes unrelated test failures.

Refs #19688.
 2013-02-25 00:09:13 +01:00
Julien Phalip
ae2a8bb456 Fixed a test that was failing in Python 3. 
The issue was that as of Python 3, the generators' `next()`
method becomes `__next()`. Thanks Alex Gaynor for noticing that.
Refs #19890.
 2013-02-24 13:47:14 -08:00
Julien Phalip
a8449d4362 Merge pull request #824 from ambv/languagecode 2013-02-24 12:56:14 -08:00
Simon Charette
6b03179e12 Fixed #19688 -- Allow model subclassing with a custom metaclass using six.with_metaclass 2013-02-24 17:32:34 +01:00
Christopher Medrela
636c45fc58 Fixed #19890 -- ifchanged templatetag rendered its content twice 
The content of ifchanged template tag was rendered twice: first time, to
compare it with the previous value and the second time, to return the
rendered output.
 2013-02-24 16:49:28 +01:00
Diederik van der Boor
8503120c10 Fixed #15849 -- Made IfChanged node thread safe. 
Previously, the ifchanged node stored state on `self._last_seen`,
thereby giving undesired results when the node is reused by another
thread at the same time (e.g. globally caching a Template object).

Thanks to akaihola for the report and Diederik van der Boor and
Bas Peschier for the patch.
 2013-02-24 16:06:55 +01:00
Zbigniew Siciarz
0a8402eb05 Test case and docs for custom context data in feeds 
Thanks Paul Winkler for the initial patch. (Ref #18112).
 2013-02-24 08:33:20 -06:00
Florian Apolloner
4506ae0497 Merge pull request #717 from slurms/ticket_19746 
Fixed #19746 -- Allow deserialization of pk-less data
 2013-02-24 06:31:14 -08:00
Łukasz Langa
8c8f94fe9d Fixes #19763 - LocaleMiddleware should check for supported languages in settings.LANGUAGE_CODE 2013-02-24 14:43:45 +01:00
Tomek Paczkowski
99edbe0e27 Fixed #19253 -- Extracted template cache key building logic 
Introduced a public function
django.core.cache.utils.make_template_fragment_key
Thanks @chrismedrela for fruitful cooperation.
 2013-02-24 14:32:45 +01:00
Aymeric Augustin
7106a1e594 Merge pull request #819 from erikr/master 
Fixed #16302 -- Ensured contrib.comments is IPv6 capable.
 2013-02-24 05:02:00 -08:00
Erik Romijn
ade992c61e Fixed #16302 -- Ensure contrib.comments is IPv6 capable 
Changed the ip_address field for Comment to GenericIPAddressField. Added
instructions to the release notes on how to update the schema of existing
databases.
 2013-02-24 13:58:38 +01:00
Bas Peschier
5a9b2bce24 Fixed #19810 -- MemcachedCache now uses pickle.HIGHEST_PROTOCOL 2013-02-24 13:56:15 +01:00
Wiktor Kolodziej
f07a5f0a21 Fixed #11295: If ModelAdmin.queryset returns a filtered QS don't require a 2nd count call 
Original patch rewritten, added tests and get_filters_params method for ChangeList class.
Thanks Alex for the report.
 2013-02-24 13:23:23 +01:00
Florian Apolloner
e4ee3d8fca Fixed a few ResourceWarnings. 2013-02-24 13:11:19 +01:00
Honza Král
e4e1287590 Merge pull request #817 from rybaktomasz/ticket_5568 
Fixes #5568 -- DROP INDEX subcommand
 2013-02-24 04:02:26 -08:00
Honza Kral
cbb9f629b8 Revert "fixes #19263" - Fails if not SQLite 
This reverts commit 2b76f19f2b.
 2013-02-24 12:38:32 +01:00
Tomasz Rybak
d7429defe6 Add sqldropindexes to manage 
Change patch from https://code.djangoproject.com/ticket/5568
to work on modern Django.
Add special case for MySQL which has different syntax for DROP INDEX.
Add unit tests for the new functionality.
 2013-02-24 12:38:28 +01:00
Honza Kral
5a6a4249f3 Removing unneeded tearDown code. 2013-02-24 12:31:00 +01:00
George Song
44164c5c30 Fixed #19896 -- Committed after clearing cache in the database. 2013-02-24 12:15:02 +01:00
Florian Apolloner
f56ca3f0e6 Fixed the usage of the deprecated assertEquals. 2013-02-24 11:15:17 +01:00
Aymeric Augustin
c10ed58746 Caught warnings in the templates tests. Refs #17906. 
This was missing from f49e9a517f.
 2013-02-24 10:28:05 +01:00
Honza Král
fc38d6a92b Merge pull request #813 from HiddenData/ticket-19263 
fixes #19263 - EmptyResultSet in subquery causes incorrect SQL
 2013-02-23 15:05:24 -08:00
Marcin Biernat
2b76f19f2b fixes #19263 2013-02-23 23:53:46 +01:00
Honza Král
692902b227 Merge pull request #778 from viciu/19609 
Fixed #19609: admin Inlines doesn't display help_text for readonly fields
 2013-02-23 14:34:57 -08:00
Honza Kral
ef1e6ef1eb Merge branch 'ticket19872' of https://github.com/oinopion/django 2013-02-23 23:32:09 +01:00
Honza Kral
2b48fcc607 Fixed #18491 -- deleting a proxy doesn't show warning about cascade deletes 2013-02-23 23:20:34 +01:00
Tomek Paczkowski
b88abd6840 Fixed #19872 
Made cached_property to behave as property when accessed via class.
 2013-02-23 23:20:00 +01:00
Aleksandra Sendecka
32a7ab2148 Fixed #19526 
CSS specifications governs that syntax is case insensitive.
This modifies CachedFilesMixin to support that.
 2013-02-23 23:05:22 +01:00
Klaas van Schelven
1c11ee6345 Fixed #18829 -- Fixed ModelChoiceIterator length 
Thanks facundo.olano at gmail.com for the report and thikonom for
the initial patch.
 2013-02-23 22:27:07 +01:00
Alex Gaynor
150e202172 Some style fixes for stuff that was clearly brough tover from doctests. 2013-02-23 13:04:08 -08:00
Honza Král
10026c2ad0 Merge pull request #804 from oinopion/ticket18162 
Fixes #18162 --  Specifying choices to Field overrides any form_class argument
 2013-02-23 12:45:39 -08:00
Grzegorz Nosek
2cd0edaa47 Fixed 19895 -- Made second iteration over invalid queryset raise an exception too 
When iteration over a queryset raised an exception, the result cache
remained initialized with an empty list, so subsequent iterations returned
an empty list instead of raising an exception
 2013-02-23 14:35:27 -06:00
Łukasz Langa
539900f117 Fixes #17866: Vary: Accept-Language header when language prefix used 2013-02-23 19:41:33 +01:00
Honza Kral
bfd4a71d41 One last final fix for 0ad76843. Tested on py3 and py2 2013-02-23 19:27:37 +01:00
Honza Král
0a341ab40d Merge pull request #791 from khalas/ticket_19811 
Changed %r to %s in get_language_info error message
 2013-02-23 10:16:23 -08:00
Tomek Paczkowski
b6f4a92ff4 Proposed fix for #18162. 2013-02-23 19:01:38 +01:00
Konrad Hałas
48dc0cbf2a Changed %r to %s in get_language_info error message. 2013-02-23 18:54:54 +01:00
Florian Apolloner
f368c25f10 Fixed errors introduced in 664855b74e 2013-02-23 18:47:36 +01:00
Florian Apolloner
5ae0c933a8 Fixed errors introduced in 21f333bcef. Refs #17751 2013-02-23 18:43:34 +01:00
Claude Paroz
cc53d9b30b Fixed #15877 -- Improved exception when ModelForm has no model class 
Thanks theaspect at gmail.com for the report and volrath for the
patch.
 2013-02-23 18:32:29 +01:00
Wiktor Kolodziej
67dd54dc84 Fixed #19609: admin Inlines doesn't display help_text for readonly fields 
Refactoring: field was renamed to field_name, since flatten_fieldsets returns field name, not field.

Original patch from Marc Aymerich Gubern
 2013-02-23 18:24:32 +01:00
Honza Král
a05ab448f7 Merge pull request #781 from zsiciarz/ticket_19854 
Fixed #19854 -- Added test runner option to skip Selenium tests
 2013-02-23 08:55:34 -08:00
Zbigniew Siciarz
1cd2f51eb4 Added test runner option to skip Selenium tests (#19854). 2013-02-23 17:45:26 +01:00
Claude Paroz
335a060fa6 Minor cleanups in templates test imports 2013-02-23 17:45:05 +01:00
Lennart Regebro
687d2e967d Fixed #19827 -- Kept stacktrace in defaulttags exception reraising 
Thanks Kronuz for the report and the initial patch.
 2013-02-23 17:43:17 +01:00
Honza Král
0ad76843b5 Merge pull request #777 from khalas/ticket_19811 
Fixed #19811 - Added language code fallback in get_language_info
 2013-02-23 08:30:27 -08:00
Honza Král
129d2e8f85 Merge pull request #775 from HiddenData/ticket-18899 
Fixed #18899 -- FileSystemStorage.save should support any file-like objects
 2013-02-23 08:04:41 -08:00
Konrad Hałas
6bd6a56896 Fixed #19811 - Added language code fallback in get_language_info. 2013-02-23 17:02:07 +01:00
Aymeric Augustin
5278776a88 Merge pull request #751 from bmispelon/ticket-6271 2013-02-23 07:47:58 -08:00
Marcin Biernat
664855b74e #18899 FileSystemStorage.save should support any file-like objects 2013-02-23 16:40:50 +01:00
Vladimir A Filonov
f49e9a517f Fixed #17906 - Autoescaping {% cycle %} and {% firstof %} templatetags. 
This commit adds "future" version of these two tags with auto-escaping
enabled.
 2013-02-23 16:16:39 +01:00
Tomek Paczkowski
3dddbc0f23 Fixed #19816: pre-evaluate queryset on m2m set 
In ReverseManyRelatedObjectsDescriptor.__set__, evaluate possible
queryset to avoid problems when clear() would touch data this queryset
returns.
 2013-02-23 15:50:33 +01:00
Baptiste Mispelon
069280a689 Used token.split_contents() for tokenisation in template tags accepting variables. 
Fixed #6271, #18260.
 2013-02-23 15:15:30 +01:00
Erik Romijn
21f333bcef Fix #17751: Added stripping of whitespace for IPAddressField/GenericIPAddressField 2013-02-23 14:44:57 +01:00
Claude Paroz
7ec2a21be1 Fixed #19686 -- Added HTML5 number input type 
Thanks Simon Charette for his help on the patch. Refs #16630.
 2013-02-23 10:18:08 +01:00
Anssi Kääriäinen
dcf651c27e Fixed Oracle specific failures in commands_sql tests 2013-02-23 01:08:48 +02:00
Anssi Kääriäinen
f565c6f999 Marked a test as expected failure. Refs #19884 2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
88c726bea0 Skipped a test on Oracle 2013-02-23 00:33:02 +02:00
Anssi Kääriäinen
09fcb70c80 Fixed empty strings + to_field regression on Oracle 
Querying the reverse side of nullable to_field relation, where both
sides can contain null values resulted in incorrect results. The reason
was not detecting '' as NULL.

Refs #17541
 2013-02-23 00:05:31 +02:00
Baptiste Mispelon
f13bfbec70 Fixed #19882 -- Smarter tokenizing of {% for %} tag arguments. 2013-02-22 19:19:33 +01:00
Anssi Kääriäinen
3c6318e831 Fixed #19870 -- Regression in select_related in inheritance cases 
There was a regression in case two models inherited the same parent,
and one contained a foreign key to other. When select_related travelled
the foreign key the other model reused the parent join made by the
first model. This was likely caused by Query.join_parent_model()
addition in commit 68985db482.

Thanks to Trac alias loic84 for report & tests.
 2013-02-21 12:01:23 +02:00
Anssi Kääriäinen
50677b29af Made a couple of selenium tests wait for page loaded 
The admin_widgets tests were issuing click() to the browser but
didn't wait for the effects of those clicks. This caused the resulting
request to be processed concurrently with the test case. When using
in-memory SQLite this caused weird failures.

Also added wait_page_loaded() to admin selenium tests for code
reuse.

Fixed #19856
 2013-02-20 23:56:57 +02:00
Anssi Kääriäinen
e8fc3f3783 Added a test for negated Q object querying 
The added test is from the patch in ticket #19672 (written by Ian
Kelly). Fixed #19672, refs #19849.
 2013-02-20 21:45:36 +02:00
Anssi Kääriäinen
edf93127bf Removed join() promote kwarg 
The join promote=True was over-aggressive in select_related handling.
After that was removed, the only other user was query.combine(). That
use case is very easy to handle locally, so there is no more need for
the join(promote=True) flag.

Refs #19849.
 2013-02-20 21:43:44 +02:00
Anssi Kääriäinen
3fef304ff2 Refactored negated IS NULL handling 
This one cleaned up add_filter() negated filter generation. As a side
effect split_exclude() was cleaned up, too.

Refs #19849
 2013-02-20 21:34:01 +02:00
Alex Gaynor
b55cde054e Added a db_constraint option to ForeignKeys. 
This controls whether or not a database level cosntraint is created. This is useful in a few specialized circumstances, but in general should not be used!
 2013-02-20 11:27:32 -08:00
Claude Paroz
ae2d04f726 Add test for collapsible fieldset functionality in admin 2013-02-20 13:48:49 +01:00
Aymeric Augustin
35c991aa06 Added a default limit to the maximum number of forms in a formset. 
This is a security fix. Disclosure and advisory coming shortly.
 2013-02-19 11:23:30 -07:00
Carl Meyer
1f39eafd60 Checked object permissions on admin history view. 
This is a security fix. Disclosure and advisory coming shortly.

Patch by Russell Keith-Magee.
 2013-02-19 11:23:30 -07:00
Carl Meyer
c6d69c12ea Restrict the XML deserializer to prevent network and entity-expansion DoS attacks. 
This is a security fix. Disclosure and advisory coming shortly.
 2013-02-19 11:23:30 -07:00
Carl Meyer
d51fb74360 Added a new required ALLOWED_HOSTS setting for HTTP host header validation. 
This is a security fix; disclosure and advisory coming shortly.
 2013-02-19 11:23:29 -07:00
Anssi Kääriäinen
4b9fa49bc0 Avoided related_name conflicts in tests 2013-02-19 03:13:13 +02:00
Anssi Kääriäinen
607772b942 Removed accidentally committed file 2013-02-19 01:55:40 +02:00
Florian Hahn
3e71368423 Fixed #10870 -- Added aggreation + generic reverse relation test 2013-02-19 01:42:02 +02:00
Anssi Kääriäinen
b4492a8ca4 Fixed #19837 -- Refactored split_exclude() join generation 
The refactoring mainly concentrates on making sure the inner and outer
query agree about the split position. The split position is where the
multijoin happens, and thus the split position also determines the
columns used in the "WHERE col1 IN (SELECT col2 from ...)" condition.

This commit fixes a regression caused by #10790 and commit
69597e5bcc. The regression was caused
by wrong cols in the split position.
 2013-02-19 01:10:49 +02:00
Aymeric Augustin
aea98e8c53 Simplified MySQL version checking. 
Django used to check the version of MySQL before handling the first
request, which required:
- opening a connection
- closing it, to avoid holding it idle until the first request.

This code isn't necessary any longer since Django dropped support for
some versions of MySQL, and other database backends don't implement a
similar dance. For consistency and maintenability, remove it.

Reverts 4423757c0c.

Closes #18135.
 2013-02-18 21:46:26 +01:00
Aymeric Augustin
92837ae569 Avoided firing the request_finished signal in tests. 
* Avoided calling BaseHttpResponse.close(). The test client take care of
  that since acc5396e.
* Disconnected the request_finished signal when this method must be
  called. The test client has a similar implementation since bacb097a.
 2013-02-18 14:32:45 +01:00
Claude Paroz
632361611c Fixed #19833 -- Fixed import parameter encoding in get_runner 
Thanks Danilo Bargen for the report.
 2013-02-16 13:31:13 +01:00
Aymeric Augustin
e74e207cce Fixed #17260 -- Added time zone aware aggregation and lookups. 
Thanks Carl Meyer for the review.

Squashed commit of the following:

commit 4f290bdb60b7d8534abf4ca901bd0844612dcbda
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 21:21:30 2013 +0100

    Used '0:00' instead of 'UTC' which doesn't always exist in Oracle.

    Thanks Ian Kelly for the suggestion.

commit 01b6366f3ce67d57a58ca8f25e5be77911748638
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 13:38:43 2013 +0100

    Made tzname a parameter of datetime_extract/trunc_sql.

    This is required to work around a bug in Oracle.

commit 924a144ef8a80ba4daeeafbe9efaa826566e9d02
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Wed Feb 13 14:47:44 2013 +0100

    Added support for parameters in SELECT clauses.

commit b4351d2890cd1090d3ff2d203fe148937324c935
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 22:30:22 2013 +0100

    Documented backwards incompatibilities in the two previous commits.

commit 91ef84713c81bd455f559dacf790e586d08cacb9
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 09:42:31 2013 +0100

    Used QuerySet.datetimes for the admin's date_hierarchy.

commit 0d0de288a5210fa106cd4350961eb2006535cc5c
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 09:29:38 2013 +0100

    Used QuerySet.datetimes in date-based generic views.

commit 9c0859ff7c0b00734afe7fc15609d43d83215072
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:25 2013 +0100

    Implemented QuerySet.datetimes on Oracle.

commit 68ab511a4ffbd2b811bf5da174d47e4dd90f28fc
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:14 2013 +0100

    Implemented QuerySet.datetimes on MySQL.

commit 22d52681d347a8cdf568dc31ed032cbc61d049ef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:42:29 2013 +0100

    Implemented QuerySet.datetimes on SQLite.

commit f6800fd04c93722b45f9236976389e0b2fe436f5
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:43:03 2013 +0100

    Implemented QuerySet.datetimes on PostgreSQL.

commit 0c829c23f4cf4d6804cadcc93032dd4c26b8c65e
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:41:08 2013 +0100

    Added datetime-handling infrastructure in the ORM layers.

commit 104d82a7778cf3f0f5d03dfa53709c26df45daad
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Mon Feb 11 10:05:55 2013 +0100

    Updated null_queries tests to avoid clashing with the __second lookup.

commit c01bbb32358201b3ac8cb4291ef87b7612a2b8e6
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 23:07:41 2013 +0100

    Updated tests of .dates().

    Replaced .dates() by .datetimes() for DateTimeFields.
    Replaced dates with datetimes in the expected output for DateFields.

commit 50fb7a52462fecf0127b38e7f3df322aeb287c43
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 21:40:09 2013 +0100

    Updated and added tests for QuerySet.datetimes.

commit a8451a5004c437190e264667b1e6fb8acc3c1eeb
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 22:34:46 2013 +0100

    Documented the new time lookups and updated the date lookups.

commit 29413eab2bd1d5e004598900c0dadc0521bbf4d3
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Feb 10 16:15:49 2013 +0100

    Documented QuerySet.datetimes and updated QuerySet.dates.
 2013-02-16 09:19:04 +01:00
Claude Paroz
b19d83fc12 Improved input sanitizing with thousand separators 
For languages with non-breaking space as thousand separator,
standard space input should also be allowed, as few people know
how to enter non-breaking space on keyboards. Refs #17217.
Thanks Alexey Boriskin for the report and initial patch.
 2013-02-15 16:37:52 +01:00
Claude Paroz
dcf8cd30ae Updated FormattingTests test case to use settings contexts 2013-02-15 09:37:12 +01:00
Julien Phalip
7d5e35cdb4 Fixed #19829 -- Fixed index lookups for NumPy arrays in templates. 2013-02-14 23:29:15 -08:00
Michael van Tellingen
138de533ff Fixed #19819 - Improved template filter errors handling. 
Wrap the Parser.compile_filter method call with a try/except and call the
newly added Parser.compile_filter_error(). Overwrite this method in the
DebugParser to throw the correct error.

Since this error was otherwise catched by the compile_function try/except
block the debugger highlighted the wrong line.
 2013-02-14 10:22:59 +01:00
Claude Paroz
ac4faa6dc3 Fixed #19693 -- Made truncatewords_html handle self-closing tags 
Thanks sneawo for the report and Jonathan Loy for the patch.
 2013-02-13 18:24:49 +01:00
Hiroki Kiyohara
e94f405d94 Fixed #18558 -- Added url property to HttpResponseRedirect* 
Thanks coolRR for the report.
 2013-02-13 10:29:32 +01:00
Anssi Kääriäinen
fafee74306 Removed try-except in django.db.close_connection() 
The reason was that the except clause needed to remove a connection
from the django.db.connections dict, but other parts of Django do not
expect this to happen. In addition the except clause was silently
swallowing the exception messages.

Refs #19707, special thanks to Carl Meyer for pointing out that this
approach should be taken.
 2013-02-13 00:25:09 +02:00
Nick Sandford
278dad5b41 Fixed #19746 -- Allow deserialization of pk-less data 2013-02-12 17:10:42 +08:00
Simon Charette
a10f390804 Fixed #19044 -- Made DeletionMixin interpolate its success_url. 
Thanks to nxvl and slurms for the initial patch, ptone for the review
and timo for the documentation tweaks.
 2013-02-11 02:39:14 -05:00
Anssi Kääriäinen
604d8763dc Fixed #19112 -- Reduced the amount of query params in a test 2013-02-10 21:08:19 +02:00
Anssi Kääriäinen
8ef3235034 Fixed #19720 -- Oracle ordering related delete regression 
When a query had a complex where condition (a condition targeting more
than the base table) a subquery was used for deletion. However, the
query had default ordering from the model's meta and Oracle doesn't
work with ordered subqueries.

The regression was caused by fast-path deletion code introduced in
1cd6e04cd4 for fixing #18676.

Thanks to Dylan Klomparens for the report.
 2013-02-10 19:54:02 +02:00
Anssi Kääriäinen
a4e97cf315 Fixed #19707 -- Reset transaction state after requests 2013-02-10 13:55:54 +02:00
Claude Paroz
718afcafc2 Added tests for some sql_* management commands 2013-02-09 16:34:22 +01:00
Claude Paroz
f44922c795 Fixed #18906 -- Ignored to-be-deleted forms in formset validate_unique 
Thanks c.pollock at bangor.ac.uk for the report.
 2013-02-08 21:35:19 +01:00
Julien Phalip
db09a2de6e Cleaned up some lingering signals in the test suite that were causing spurious failures with Pypy and Postgres. 2013-02-08 12:12:03 -08:00
Ramiro Morales
b5391515cd Changed test assertion strategy used in 04d9730. 2013-02-07 16:51:27 -03:00
Ramiro Morales
04d9730b12 Fixed #13085 -- Don't fail on creation of model with GFK to a model with __len__() returning zero. 
Also, according to the comments on the ticket and its duplicates, added
tests execising saving an instance of a model with a GFK to:

* An unsaved object -- This actually doesn't generate the same failure
  but another ORM-level exception. The test verifies it's the case.

* An instance of a model with a __nonzero__() method thant returns False
  for it. This doesn't fail because that code path isn't executed.

* An instance of a model with a CharField PK and an empty value for it.
  This doesn't fail.
 2013-02-07 16:05:54 -03:00
Aymeric Augustin
720888a146 Fixed #15808 -- Added optional HttpOnly flag to the CSRF Cookie. 
Thanks Samuel Lavitt for the report and Sascha Peilicke for the patch.
 2013-02-07 09:48:08 +01:00
Julien Phalip
6afc85af47 Fixed a typo in the test suite that was causing some spurious failures with pypy. 2013-02-06 22:10:13 -08:00
Alexey Boriskin
d18f796a48 Fixed #19704 -- Make use of new ungettext_lazy function at appropriate places 2013-02-06 22:01:55 +01:00
Claude Paroz
d7504a3d7b Improved regex in strip_tags 
Thanks Pablo Recio for the report. Refs #19237.
 2013-02-06 21:20:43 +01:00
Simon Charette
5449240c54 Fixed #9800 -- Allow "isPermaLink" attribute in <guid> element of an RSS item. 
Thanks @rtnpro for the patch!
 2013-02-06 05:28:05 -05:00
Simon Charette
a097ee32d8 Fixed #17683 -- Make sure BaseModelFormSet respects defined widgets. 2013-02-05 05:39:35 -05:00
Simon Charette
ec469ade2b Fixed #19689 -- Renamed Model._meta.module_name to model_name. 2013-02-05 04:16:07 -05:00
Claude Paroz
40260bc30b Fixed error message test assertions under Python 3.3 
Thanks Florian Apolloner for testing.
 2013-02-04 18:00:19 +01:00
Claude Paroz
7c5b244826 Fixed #17061 -- Factored out importing object from a dotted path 
Thanks Carl Meyer for the report.
 2013-02-04 16:38:25 +01:00
Ramiro Morales
869c9ba306 Fixed #19730 -- Don't validate importability of settings by using i18n in management commands. 
They are handled independently now and the latter can be influenced by
the new BaseCommand.leave_locale_alone internal option.

Thanks chrischambers for the report, Claude, lpiatek, neaf and gabooo for
their work on a patch, originally on refs. #17379.
 2013-02-03 23:40:38 -03:00
Anssi Kääriäinen
f556df90be Fixed #19645 -- Added tests for TransactionMiddleware 2013-02-03 16:26:46 +02:00
Julien Phalip
bc7a219b1e Fixed Python 3.2 compatibility for a test. 2013-02-02 20:57:38 -08:00
Julien Phalip
293f7a2114 Fixed #17797 -- Enabled support for PATCH requests in the dummy test client. Thanks to pfarmer for the suggestion and initial patch. 2013-02-02 18:22:40 -08:00
Ramiro Morales
08dc90bccf Fixed #14305 -- Switched inspectdb to create unmanaged models. 
Thanks Ian Kelly for the report and initial patch.
 2013-02-02 21:11:32 -03:00
Nick Sandford
0694d2196f Fixed #19445 -- Skip admin fieldsets validation when the ModelAdmin.get_form() method is overridden. 2013-02-02 14:53:46 -08:00
Aymeric Augustin
ace9d4efc3 Made ungettext_lazy usable for messages that do not contain the count. 
Fixed #19160 (again). Thanks Alexey Boriskin.
 2013-02-02 10:58:31 +01:00
Aymeric Augustin
db5049c9f7 Fixed the test introduced in 2ca37af6 under Python 3. 2013-02-02 10:42:01 +01:00
Ramiro Morales
2ca37af621 Added test to demonstrate issue 11387 isn't there anymore. 
Thanks adurdin for the report and patch. Fixes #11387.
 2013-02-01 23:30:50 -03:00
Ramiro Morales
c4b6659269 Added test to demonstrate issue 11263 isn't there anymore. 
Thanks veena for the report and jaklaassen for the patch. Fixes #11263.
 2013-02-01 23:30:50 -03:00
Claude Paroz
04141c525d Fixed #19663 -- Allowed None in colorize() text parameter 
Thanks Jonathan Liuti for the report and the initial patch, and
Simon Charette for the review.
 2013-02-01 22:53:18 +01:00
Matt Robenolt
393c268e72 Fixed #19715 -- Simplified findstatic output when verbosity set to 0 2013-02-01 11:55:05 +01:00
Simon Charette
339944491c Renamed inspectdb field names for clarity 2013-02-01 09:16:29 +01:00
Claude Paroz
7bbd17bf20 Fixed #19341 -- Detected NullBooleanField when introspecting models 
Thanks Tim Bowden for the report.
 2013-01-31 20:55:00 +01:00
Claude Paroz
3c0a81aaf0 Fixed #19709 -- Fixed TimeField introspection on MySQL 
Thanks Eugene Grachev for the report.
 2013-01-31 20:41:57 +01:00
Claude Paroz
eb03fe1642 Added introspection tests for most of Django model fields 2013-01-31 20:41:57 +01:00
Ramiro Morales
7947c9e3a6 Deprecated undocumented warnings manipulation testing tools. 2013-01-31 14:57:45 -03:00
Aymeric Augustin
9a4a1ce323 Fixed #19708 -- Exception in timezone.override(None). 
Thanks rafales.
 2013-01-31 16:01:50 +01:00
Aymeric Augustin
89cb771be7 Fixed #19692 -- Completed deprecation of mimetype in favor of content_type. 
Thanks Tim for the report and initial patch.
 2013-01-31 13:54:40 +01:00
Aymeric Augustin
3895ebc734 Added file forgotten in 23e319d7. 2013-01-30 22:11:53 +01:00
Aymeric Augustin
23e319d729 Fixed #19076 -- Added content_type attribute to TemplateView. 
Thanks Gavin Wahl.
 2013-01-30 21:26:17 +01:00
Aymeric Augustin
3f1a0c0040 Fixed #19160 -- Made lazy plural translations usable. 
Many thanks to Alexey Boriskin, Claude Paroz and Julien Phalip.
 2013-01-30 20:28:16 +01:00
Ramiro Morales
47ddd6a408 Fixed #19552 -- Enhanced makemessages handling of `{# #}`-style template comments. 
They are simply ignored now. This allows for a more correct behavior when
they are placed before translatable constructs on the same line.

Previously, the latter were wrongly ignored because the former were
preserved when converting template code to the internal Python-syntax
form later fed to xgettext but Python has no ``/* ... */``-style
comments.

Also, special comments directed to translators are now only taken in
account when they are located at the end of a line. e.g.::

  {# Translators: ignored #}{% trans "Literal A" %}{# Translators: valid, associated with "Literal B" below #}
  {% trans "Literal B" %}

Behavior of ``{% comment %}...{% endcomment %}``tags remains unchanged.

Thanks juneih at redpill-linpro dot com for the report and Claude for
his work on the issue.
 2013-01-29 19:13:23 -03:00
Tim Graham
ee26797cff Fixed typos in docs and comments 2013-01-29 10:55:55 -07:00
Claude Paroz
f7394d2c32 Added HTML5 url input type 
Refs #16630.
 2013-01-28 22:11:00 +01:00
Claude Paroz
4f16376274 Added HTML5 email input type 
Refs #16630.
 2013-01-28 22:10:50 +01:00
Aymeric Augustin
c47fa3b481 Fixed #19676 -- Supported 'self' foreign keys in inspectdb. 
Thanks Georgy Kutsurua for the report and Simon Charette for the patch.
 2013-01-28 10:21:07 +01:00
Aymeric Augustin
f46d7314b5 Fixed #19677 -- Introspection of recursive foreign keys under SQLite. 
Thanks Simon Charette.
 2013-01-28 10:17:56 +01:00
Claude Paroz
4b3f7110ae Fixed #16123 -- Ensured strptime receive proper string type 
strptime generates an UnicodeEncodeError when using a non-ascii
unicode string on Python 2.
 2013-01-26 20:53:09 +01:00
Aymeric Augustin
6605ac331a Fixed #17158 -- Used a non-ambiguous representation of SQL queries 
when a correct representation cannot be obtained.
 2013-01-26 17:51:44 +01:00
Aymeric Augustin
55416e235d Fixed #19589 -- assertRegexpMatches is deprecated in Python 3.3. 2013-01-26 13:47:11 +01:00
Aymeric Augustin
424eb67867 Fixed validation of email addresses when the local part contains an @. 
See also BaseUserManager.normalize_email -- it uses rsplit.

Refs #4833.
 2013-01-26 12:20:57 +01:00
Claude Paroz
ebb504db69 Moved has_changed logic from widget to form field 
Refs #16612. Thanks Aymeric Augustin for the suggestion.
 2013-01-25 20:50:46 +01:00
Ramiro Morales
ce27fb198d Revert "Patch by Claude for #16084." 
This reverts commit 2babab0bb3.
 2013-01-25 13:58:37 -03:00
Ramiro Morales
2babab0bb3 Patch by Claude for #16084. 2013-01-25 13:23:33 -03:00
Claude Paroz
b9c8bbf372 Fixed #19665 -- Ensured proper stderr output for Command.run_from_argv 
Thanks Stefan Koegl for the report and Simon Charette for the review.
 2013-01-25 14:56:41 +01:00
Ramiro Morales
57d439e2d4 More i18n makemessages tests tweaks. 2013-01-24 07:51:14 -03:00
Claude Paroz
9893fa12b7 Fixed #19125 -- The startproject command should validate the name earlier 
Thanks Łukasz Rekucki for the report and the patch.
 2013-01-24 09:26:13 +01:00
Nick Sandford
93e79b45bc Fixed #17416 -- Added widgets argument to inlineformset_factory and modelformset_factory 2013-01-24 08:58:17 +01:00
Ramiro Morales
456f9b9847 Simplified a i18n test. 2013-01-21 23:22:18 -03:00
Claude Paroz
8ce1e392fa Fixed error introduced when testing patch for 013db6ba85 
Shame on me.
 2013-01-21 22:42:47 +01:00
Claude Paroz
013db6ba85 Fixed #18051 -- Allowed admin fieldsets to contain lists 
Thanks Ricardo di Virgilio for the report, Mateus Gondim for the
patch and Nick Sandford for the review.
 2013-01-21 22:34:36 +01:00
Claude Paroz
c6e0dedbdb Fixed #19637 -- Ensured AdminEmailHandler fails silently 
Thanks lsaffre for the report. Refs #19325.
 2013-01-21 20:32:36 +01:00
Anssi Kääriäinen
7aa538357c Cleaned up testing models.py added for earliest() 
The main cleanup was removal of non-necessary __unicode__ method. The
tests didn't break on py3 as the string representation was never used
in the tests.

Refs #17813. Thanks to Simon Charette for spotting this issue.
 2013-01-20 08:53:45 +02:00
Nick Sandford
fe54377dae Fixed #17813 -- Added a .earliest() method to QuerySet 
Thanks a lot to everybody participating in developing this feature.
The patch was developed by multiple people, at least Trac aliases
tonnzor, jimmysong, Fandekasp and slurms.

Stylistic changes added by committer.
 2013-01-20 06:39:35 +02:00
Craig Blaszczyk
6158c79dbe Made (make|compile)messages commands accept multiple locales at once. 
Thanks Craig Blaszczyk for the initial patch. Refs #17181.
 2013-01-17 00:53:17 -03:00
Ramiro Morales
295650bd01 Simplified i18n commands tests. 2013-01-17 00:35:46 -03:00
Ramiro Morales
248aee1606 Modified makemessages so it creates .pot files once per invocation. 
It creates a `locale/django.pot` file once instead of one
`locale/<locale_code>/django.pot` file for every locale involved.

Thanks Michal Čihař for the report and patch.
 2013-01-16 20:48:06 -03:00
Ramiro Morales
eee865257a Fixed #17008 -- Added makemessages option to not remove .pot files. 
Thanks airstrike for the report and initial patch, Julien for an
enhanced patch and Jannis for reviewing.
 2013-01-16 20:29:06 -03:00
Aymeric Augustin
50a985b09b Fixed #19099 -- Split broken link emails out of common middleware. 2013-01-15 17:41:45 +01:00
Alex Gaynor
984e91e28f Removed some uses of the deprecated assertEquals 2013-01-15 07:51:33 -08:00
David Cramer
a7ed09d13d Improve test to ensure that post_delete was actually called 2013-01-14 13:34:55 -08:00
David Cramer
6045efa029 Move signal disconnect into finally block 2013-01-14 13:15:47 -08:00
David Cramer
272de9eb6b Send post_delete signals immediately 
In a normal relational construct, if you're listening for an event
that signals a child was deleted, you dont expect that the parent
was deleted already.

This change ensures that post_delete signals are fired immediately
after objects are deleted in the graph.
 2013-01-14 13:15:47 -08:00
Claude Paroz
0171ba65db Fixed #17574 -- Implemented missing get_key_columns in PostgreSQL backend 2013-01-12 21:46:08 +01:00
Claude Paroz
bcdb4898ca Fixed #19488 -- Made i18n_patterns redirect work with non-slash-ending paths 
Thanks Daniel Gerzo for the report and the initial patch.
 2013-01-11 21:27:51 +01:00
Claude Paroz
f08e739bc2 Fixed #19585 -- Fixed loading cookie value as a dict 
This regression was introduced by the 'unicode_literals' patch.
 2013-01-11 21:09:33 +01:00
Claude Paroz
4e2e8f39d1 Fixed #4833 -- Validate email addresses with localhost as domain 2013-01-11 20:45:46 +01:00
Nick Sandford
eb6c107624 Fixed #19360 -- Raised an explicit exception for aggregates on date/time fields in sqlite3 
Thanks lsaffre for the report and Chris Medrela for the initial
patch.
 2013-01-11 18:10:28 +01:00
Claude Paroz
2e55cf580e Adapted test assertion against yaml dump 
Fixes #12914 (again).
 2013-01-11 17:52:53 +01:00
Loic Raucy
62f842e2e5 Fixed #19581 -- ensure unique html ids with CheckboxSelectMultiple widgets 
ID check is now done the same way as MultipleHiddenInput.
 2013-01-09 16:06:56 -08:00
Florian Apolloner
ce580dd8ea Fixed lockups in jenkins, refs #19546. 2013-01-09 23:32:51 +01:00
Claude Paroz
e6949373b0 Skipped deprecation warning test on Python 2.6 
Refs #19546. On Python 2.6, DeprecationWarnings are visible by
default.
 2013-01-09 20:02:09 +01:00
Preston Holmes
cfa70d0c94 Fixed #19546 - ensure that deprecation warnings are shown during tests 
refs #18985
 2013-01-09 08:19:22 -08:00
Anssi Kääriäinen
55da775ce1 Fixed #17541 -- Fixed non-saved/nullable fk querying 2013-01-08 21:02:38 +02:00
Claude Paroz
34ee7d9875 Updated deprecated test assertions 2013-01-08 19:08:15 +01:00
Anssi Kääriäinen
23ca3a0194 Fixed #16759 -- Remove use of __deepcopy__ in qs.clone() 
The original problem was that queryset cloning was really expensive
when filtering with F() clauses. The __deepcopy__ went too deep copying
_meta attributes of the models used. To fix this the use of
__deepcopy__ in qs cloning was removed.

This commit results in some speed improvements across the djangobench
benchmark suite. Most query_* tests are 20-30% faster, save() is 50%
faster and finally complex filtering situations can see 2x to order
of magnitude improvments.

Thanks to Suor, Alex and lrekucki for valuable feedback.
 2013-01-08 19:17:13 +02:00
Claude Paroz
c698c55966 Created special PostgreSQL text indexes when unique is True 
Refs #19441.
 2013-01-07 17:54:30 +01:00
Anssi Kääriäinen
69a46c5ca7 Tests for various emptyqs tickets 
The tickets are either about different signature between qs.none() and
qs or problems with subclass types (either EmptyQS overrided the custom
qs class, or EmptyQS was overridden by another class - values() did
this).

Fixed #15959, fixed #17271, fixed #17712, fixed #19426
 2013-01-06 19:18:29 +02:00
Anssi Kääriäinen
a2396a4c8f Fixed #19173 -- Made EmptyQuerySet a marker class only 
The guarantee that no queries will be made when accessing results is
done by new EmptyWhere class which is used for query.where and having.

Thanks to Simon Charette for reviewing and valuable suggestions.
 2013-01-06 19:18:28 +02:00
Claude Paroz
b740da3504 Fixed #19192 -- Allowed running tests with dummy db backend 
Thanks Simon Charette for the initial patch, and Jan Bednařík for
his work on the ticket.
 2013-01-04 13:55:20 +01:00
Claude Paroz
ffa50ca352 Fixed #19382 -- Stopped smtp backend raising exception when already closed 
Thanks Sebastian Noack for the report and the initial patch.
 2013-01-03 20:41:45 +01:00
Claude Paroz
1b3f832ab7 Fixed #19134 -- Allowed closing smtp backend when the server is stopped 
Thanks Sebastian Noack for the report and the initial patch.
 2013-01-03 18:49:00 +01:00
Simon Charette
3fc43c964e Fixed #19545 -- Make sure media/is_multipart work with empty formsets 2013-01-03 15:16:23 +01:00
Aymeric Augustin
a7b7efe78d Minor fixes in the known_related_objects tests. 
* Fixed JSON indentation.
* Avoided relying on implicit ordering.
 2013-01-02 22:21:46 +01:00
Aymeric Augustin
07fbc6ae0e Fixed #19547 -- Caching of related instances. 
When &'ing or |'ing querysets, wrong values could be cached, and crashes
could happen.

Thanks Marc Tamlyn for figuring out the problem and writing the patch.
 2013-01-02 22:21:46 +01:00
Aymeric Augustin
feb41c3246 Modernized middleware tests. 
* Used override_settings consistently -- changes to DEBUG could leak.
* Took advantage of assertRaisesRegexp.
* Fixed indentation -- some code was indented at 2 spaces.
 2013-01-01 23:00:34 +01:00
Anton Baklanov
3aa4b8165d Fixed #19457 -- ImageField size detection failed for some files. 
This was caused by PIL raising a zlib truncated stream error since we fed
the parser with chunks instead of the whole image.
 2013-01-01 11:54:56 +01:00
Aymeric Augustin
bacb097ac3 Fixed #19519 again -- Regression in LiveServerTestCase after fd1279a4. 2013-01-01 10:14:11 +01:00
Julien Phalip
9180146d21 Fixed #19453 -- Ensured that the decorated function's arguments are obfuscated in the @sensitive_variables decorator's frame, in case the variables associated with those arguments were meant to be obfuscated from the decorated function's frame. 
Thanks to vzima for the report.
 2012-12-31 09:34:08 -08:00
Aymeric Augustin
acc5396e6d Fixed #19519 -- Fired request_finished in the WSGI iterable's close(). 2012-12-31 12:47:34 +01:00
Claude Paroz
d11038acb2 Fixed #19537 -- Made CheckboxInput._has_changed handle 'False' string 
Thanks dibrovsd@gmail.com for the report.
 2012-12-31 10:18:59 +01:00
Julien Phalip
cee40c7d79 Added further flexibility to ModelAdmin for controlling post-save redirections. 
Refs #19505.
 2012-12-30 21:33:21 -08:00
Aymeric Augustin
4e5369a596 Silenced warnings in the tests of deprecated features. 2012-12-29 22:32:07 +01:00
Aymeric Augustin
ef017a5f00 Advanced pending deprecation warnings. 
Also added stacklevel argument, fixed #18127.
 2012-12-29 21:59:07 +01:00
Aymeric Augustin
2ecf56ea3f Removed legacy ways of calling cache_page. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
9f9a4cdecd Removed truncate_words and truncate_html_words. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
4a6490a4a0 Removed HttpRequest.raw_post_data. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
d1c72d9e01 Removed django.core.management.setup_environ and execute_manager. 2012-12-29 21:59:07 +01:00
Aymeric Augustin
f27a4ee327 Removed django.contrib.localflavor. 
Each localflavor lives on as a separate app.
 2012-12-29 21:59:06 +01:00
Aymeric Augustin
052271168b Removed django.contrib.databrowse. 
RIP -- you served us well.
 2012-12-29 21:58:12 +01:00
Aymeric Augustin
02f3daadd6 Removed interpolation of post_url_continue in the admin. 2012-12-29 21:58:12 +01:00
Aymeric Augustin
fb9f1b9bfb Removed backwards-compatibility shim for #16288. 
Also unit-tested django.utils.log.RequireDebugTrue for consistency.
 2012-12-29 21:58:12 +01:00
Anssi Kääriäinen
13a2b11425 Avoided having an indexed TextField installed unless using postgres 
An index on TextField results in a warning message when running tests
on MySQL or SQLite, and the test using the TextField was PostgreSQL
only in any case.
 2012-12-29 16:30:17 +02:00
Anssi Kääriäinen
ba4331f177 Fixed autopk issue in tests 2012-12-29 16:25:24 +02:00
Aymeric Augustin
e9c24bef74 Fix #19524 -- Incorrect caching of parents of unsaved model instances. 
Thanks qcwxezdas for the report. Refs #13839.
 2012-12-28 23:34:54 +01:00
Aymeric Augustin
db278c3bf9 Fixed #19525 -- Reverted dcd4383107 and 05d333ba3b. 
Refs #9893, #18515.

Thanks Russell for the report.
 2012-12-27 09:37:57 +01:00
Ramiro Morales
ad769efa85 Expanded tests added when fixing #14529. 
To make sure changes in 35d1cd0 don't break anything. Refs #19505.
 2012-12-24 17:48:48 -03:00
Aymeric Augustin
1c8be95a86 Prevented caching of streaming responses. 
The test introduced in 4b278131 accidentally passed because of a
limitation of Python < 3.3.

Refs #17758, #7581.
 2012-12-24 20:28:07 +01:00
Julien Phalip
35d1cd0b28 Fixed #19505 -- A more flexible implementation for customizable admin redirect urls. 
Work by Julien Phalip.

Refs #8001, #18310, #19505. See also 0b908b92a2.
 2012-12-24 15:44:19 -03:00
Aymeric Augustin
e8f07f0378 Fixed a randomly failing test under Python 3. 
Refs #17758.
 2012-12-24 11:25:58 +01:00
Luke Plant
1ae64e96c1 Fixed a dependence on set-ordering in tests 2012-12-24 01:33:44 +00:00
Luke Plant
c31c2c92b8 Made admin generated changelist URLs independent of dict ordering 2012-12-24 01:33:24 +00:00
Ian Clelland
b9fc70141a Don't rely on dictionary ordering in tests 2012-12-24 00:45:58 +00:00
Ian Clelland
585aa11d23 Use HTML parser to compare html snippets 2012-12-24 00:26:09 +00:00
Ian Clelland
8d35fd4c32 Use new TestCase methods for equality comparisons 2012-12-24 00:24:14 +00:00
Aymeric Augustin
1e4a27d087 Fixed #19468 -- Decoded request.path correctly on Python 3. 
Thanks aliva for the report and claudep for the feedback.
 2012-12-22 13:32:39 +01:00
Anssi Kääriäinen
d407164c04 Fixed #18854 -- Join promotion in disjunction cases 
The added promotion logic is based on promoting any joins used in only
some of the childs of an OR clause unless the join existed before the
OR clause addition.
 2012-12-20 21:45:15 +02:00
Anssi Kääriäinen
3dcd435a0e Fixed #19500 -- Solved a regression in join reuse 
The ORM didn't reuse joins for direct foreign key traversals when using
chained filters. For example:
    qs.filter(fk__somefield=1).filter(fk__somefield=2))
produced two joins.

As a bonus, reverse onetoone filters can now reuse joins correctly

The regression was caused by the join() method refactor in commit
68847135bc

Thanks for Simon Charette for spotting some issues with the first draft
of the patch.
 2012-12-20 21:27:00 +02:00
Russell Keith-Magee
c04c03daa3 Fixed #19401 -- Ensure that swappable model references are case insensitive. 
This is necessary because get_model() checks are case insensitive, and if the swapable check isn't, the
swappable logic gets tied up in knots with models that are partially swapped out.

Thanks to chris@cogdon.org for the report and extensive analysis, and Preston for his work on the draft patch.
 2012-12-20 16:10:19 +08:00
Patryk Zawadzki
3989ce52ef Fixed #18172 -- Made models with __iter__ usable in ModelMultipleChoiceField 
Thanks to Patryk Zawadzki for the patch.
 2012-12-19 22:51:12 +02:00
Andrew Godwin
b62e82365a Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/loading.py
	django/db/models/options.py
 2012-12-18 09:02:07 +00:00
Claude Paroz
55972ee5c7 Fixed #19441 -- Created PostgreSQL varchar index when unique=True 
Thanks Dylan Verheul for the report and Anssi Kääriäinen for the
review.
 2012-12-18 09:56:30 +01:00
Anssi Kääriäinen
85712a5355 Made sure connections are actually closed in backends tests 2012-12-16 23:26:16 +02:00
Claude Paroz
ed711c4bd5 Fixed #19483 -- Improved import error message in contrib.comments 
Thanks Valentin Lorentz for the report and the suggested fix.
 2012-12-16 21:12:45 +01:00
Anssi Kääriäinen
69597e5bcc Fixed #10790 -- Refactored sql.Query.setup_joins() 
This is a rather large refactoring. The "lookup traversal" code was
splitted out from the setup_joins. There is now names_to_path() method
which does the lookup traveling, the actual work of setup_joins() is
calling names_to_path() and then adding the joins found into the query.

As a side effect it was possible to remove the "process_extra"
functionality used by genric relations. This never worked for left
joins. Now the extra restriction is appended directly to the join
condition instead of the where clause.

To generate the extra condition we need to have the join field
available in the compiler. This has the side-effect that we need more
ugly code in Query.__getstate__ and __setstate__ as Field objects
aren't pickleable.

The join trimming code got a big change - now we trim all direct joins
and never trim reverse joins. This also fixes the problem in #10790
which was join trimming in null filter cases.
 2012-12-16 17:23:26 +02:00
Russell Keith-Magee
9facca28b6 Corrected tests depending on the error message on the AuthenticationForm. 
Refs #19368, and the fix introduced in 27f8129d64.
 2012-12-16 07:18:45 +08:00
Anssi Kääriäinen
7eba5fbc02 Fixed a couple of stale tests caused by patch for #19462 
Commit was 088d3bc2f8
 2012-12-13 15:02:08 +02:00
Anssi Kääriäinen
088d3bc2f8 Fixed #19462 -- Made assertQuerysetEqual detect undefined ordering 
If there are more than one values to compare against and the qs isn't
ordered then assertQuerysetEqual will raise a ValueError.
 2012-12-13 13:33:11 +02:00
Claude Paroz
6ed6a18a03 Fixed #19432 -- Provided better error message for get_object_or_404 
Thanks Kit Sunde for the report and Brian Holdefehr for the initial
patch.
 2012-12-12 22:05:00 +01:00
Florian Apolloner
7e97f4f510 Fixed an order dependant test failure. 2012-12-11 16:25:47 +01:00
Florian Apolloner
1eb0da1c5b Fixed a test failure in the comment tests. 2012-12-10 23:34:51 +01:00
Florian Apolloner
27560924ec Fixed a security issue in get_host. 
Full disclosure and new release forthcoming.
 2012-12-10 22:11:40 +01:00
Florian Apolloner
a2f2a39956 Fixed #18856 -- Ensured that redirects can't be poisoned by malicious users. 2012-12-10 22:11:39 +01:00
Claude Paroz
0cdfa76e68 Amended an SQL test fixture to not include an id value 
Some backends might need special handling for auto-increment values.
This was introduced in 5fa5621f57. Thanks Michael Manfre for spotting
the issue.
 2012-12-10 17:49:04 +01:00
Aymeric Augustin
49519328b4 Fixed #19392 -- Improved error for old-style url tags with dashes. 
Thanks dloewenherz for the report.
 2012-12-09 16:17:56 +01:00
Claude Paroz
8248d14029 Removed US localflavor-specific tests from core 
Also fixes #9045.
 2012-12-08 21:07:59 +01:00
Claude Paroz
04e6542b5a Fixed #19423 -- Prevented ModelAdmin sharing widgets due to formfield_overrides 
Thanks joebuyer at manycycles.com for the report and Simon Charette
for the review.
 2012-12-08 12:41:11 +01:00
Claude Paroz
c91667338a Fixed #19357 -- Allow non-ASCII chars in filesystem paths 
Thanks kujiu for the report and Aymeric Augustin for the review.
 2012-12-08 11:13:52 +01:00
Andreas Hug
66dfcc10b3 Fixed #18574 -- Make BaseFormSet.is_valid call its underlying forms' is_valid 
Thanks Simon Charette for the report and the initial patch.
 2012-12-06 20:00:56 +01:00
Claude Paroz
34dcf51e06 Fixed #19367 -- Fixed saving ContentFile in filesystem storage 
This was not working properly when ContentFile was initialized with
an unicode string.
Thanks Alexey Boriskin for the report and the test.
 2012-12-06 17:14:44 +01:00
Marc Aymerich
553838a285 Fixed #19429 -- Applied linebreaksbr to read-only fields in inlines 
Applied to inlines what ec9d6b1122 did for main fieldsets.
 2012-12-06 09:52:02 +01:00
Anssi Kääriäinen
632cf32b43 Fixed #19391 -- Oracle specific failure in tests 
The failure was caused by using None as a choice for a CharField. To
avoid Oracle's "" <-> NULL handling the field type was changed to
IntegerField.
 2012-12-04 22:49:02 +02:00
Julien Phalip
c196e01100 Fixed the admin_filters tests for Postgres. 2012-12-04 10:36:56 -08:00
Claude Paroz
795ac7deda Fixed #19378 -- Ensured get_success_url returns a non-lazy URL 2012-12-04 13:22:42 +01:00
Andrew Godwin
501c7a221c Merge pull request #573 from tominsam/master 
Fixed #19070: urlize template filter raises exception in some cases
 2012-12-04 02:18:10 -08:00
Ramiro Morales
b64d30405a Fixed #18697 -- Made values accepted for two customizable admin templates consistent. 
Thanks and at cloverfastfood dot com for the report.
 2012-12-04 01:13:01 -03:00
Sebastián Magrí
88e1715639 Fixed #19318 -- Ensured that the admin's SimpleListFilter options can be displayed as selected even if the lookup's first element is not a string. 2012-12-03 11:53:15 -08:00
Claude Paroz
5fa5621f57 Fixed #19416 -- Fixed multi-line commands in initial SQL files 
Thanks Aymeric Augustin for detecting this regression.
 2012-12-03 20:47:08 +01:00
Tom Insam
161cafb6f6 another failing test case for square brackets. 2012-12-03 12:11:32 +00:00
Aymeric Augustin
baae4b8187 Fixed #19397 -- Crash on binary files in project templates. 
Thanks gw 2012 at tnode com for the report.
 2012-12-03 10:45:18 +01:00
Julien Phalip
2e2c4968f6 Fixed #17050 -- Added some CSS class names to the admin index pages to facilitate per-app or per-model style customizations. Thanks to scytale for the report and to H0ff1 and thiderman for their work on the patch. 2012-12-02 20:54:34 -08:00
Claude Paroz
349c4c37f8 Fixed #19015 -- Add ISO input formats to all formats 2012-12-01 14:05:52 +01:00
Claude Paroz
0eeae15056 Fixed #19354 -- Do not assume usermodel.pk == usermodel.id 
Thanks markteisman at hotmail.com for the report.
 2012-11-29 21:45:43 +01:00
Anssi Kääriäinen
163b471e9e Converted a couple of assertEquals -> assertEqual 2012-11-28 23:44:50 +02:00
Tai Lee
6ebf115206 Fixed #14694 -- Made `defer()` work with reverse relations 
Reverse o2o fields are now usable with defer.
 2012-11-28 18:17:10 +02:00
Danilo Bargen
c10aaa70a4 Fixed #19370 -- Made date filter properly handle midnight value 2012-11-27 21:24:16 +01:00
Anssi Kääriäinen
64f6e0370a Made some tests behave nicer re connection handling 2012-11-27 19:47:20 +02:00
Aymeric Augustin
2ea80b94d7 Fixed #19362 -- Detected invalid use of @python_2_unicode_compatible. 
Thanks m3wolf for the report and akaariai for reproducing the problem.
 2012-11-27 09:45:37 +01:00
Edward Tjörnhammar
29d59a879e Fixed #17911 -- Ensure that admin readonly fields' display values are shown in change forms when the raw value is None. 2012-11-25 23:13:30 +01:00
Julien Phalip
ae206d78f6 Fixed #17646 -- Added a get_list_filter() method to ModelAdmin. Thanks to rasca for the suggestion and to mateusgondim for the patch. 2012-11-25 20:39:23 +01:00
Claude Paroz
f26b956e80 Fixed test failure following capitalization fix in 2f035a972 2012-11-25 19:54:38 +01:00
Aymeric Augustin
7644800070 Change exception type to reduce confusion. 
TemplateSyntaxError is expected at compile time, not at run time.

Refs #19280.
 2012-11-25 19:51:42 +01:00
Aymeric Augustin
f89901dc05 Fixed two typos. 2012-11-25 19:31:53 +01:00
Claude Paroz
a5d47415f4 Enabled SimpleTestCase to be decorated by override_settings 
Refs #18417. Also fixed some test case classes which subclassed
the wrong parent.
 2012-11-25 19:06:17 +01:00
Claude Paroz
9f7cefd505 Fixed #18417 -- Raised exception when unittest.TestCase is decorated with override_settings 2012-11-25 19:06:17 +01:00
Aymeric Augustin
d266919584 Fixed #19280 -- Raised an explicit exception for the old {% url %} syntax. 2012-11-24 22:10:51 +01:00
Aymeric Augustin
690cac3a34 Used a django.test.TestCase for compatibility with @override_settings. 
These tests were silently skipped.
 2012-11-24 22:10:51 +01:00
Anssi Kääriäinen
dc569c8801 Fixed ordering-related failure in m2m_through_regress tests 2012-11-24 16:03:21 +02:00
Chris Khoo
bf1871d874 Fixed #19237 -- Improved strip_tags utility 
The previous pattern didn't properly addressed cases where '>'
was present inside quoted tag content.
 2012-11-24 12:16:52 +01:00
Russell Keith-Magee
18d7c1ea3a Simplified the deletions performed by the swappable_models test. 
This is required to allow the test to run without error under SQLite in the CI environment.
 2012-11-24 15:07:50 +08:00
Russell Keith-Magee
c8985a8a73 Fixed #19806 -- Ensure that content types and permissions aren't created for swapped models. 
Thanks to rizumu for the report.
 2012-11-24 13:43:20 +08:00
Anssi Kääriäinen
0a0a0d66b3 Fixed #19351 -- SQLite bulk_insert of more than 500 single-field objs 2012-11-24 01:13:12 +02:00
Anssi Kääriäinen
a27582484c Fixed SQLite's collapsing of same-valued instances in bulk_create 
SQLite used INSERT INTO tbl SELECT %s UNION SELECT %s, the problem
was that there should have been UNION ALL instead of UNION.

Refs #19351
 2012-11-24 01:12:17 +02:00
Anssi Kääriäinen
90b86291d0 Fixed #18375 -- Removed dict-ordering dependency for F-expressions 
F() expressions reuse joins like any lookup in a .filter() call -
reuse multijoins generated in the same .filter() call else generate
new joins. Also, lookups can now reuse joins generated by F().

This change is backwards incompatible, but it is required to prevent
dict randomization from generating different queries depending on
.filter() kwarg ordering. The new way is also more consistent in how
joins are reused.
 2012-11-23 19:53:04 +02:00
Aymeric Augustin
2875b5dcab Tweak a test to avoid hitting a limit with SQLite. 
Django cannot delete more than 999 objects at a time with SQLite.

Refs #16426, #16039.
 2012-11-23 10:02:18 +01:00
Tim Graham
0e3690d230 Fixed #18974 - Warned against using models.permalink 
Thanks dstufft for the draft patch.
 2012-11-22 16:08:51 -05:00
Aymeric Augustin
a026e480da Fixed #16039 -- Made post_syncdb handlers multi-db aware. 
Also reverted 8fb7a90026. Refs #17055.
 2012-11-22 20:53:59 +01:00
George Hickman
ea6b95dbec Fixed #19316 -- Set View args/kwargs/request before dispatch 2012-11-22 20:13:01 +01:00
Jannis Leidel
3fb83729b9 Merge branch 'ticket_19325' of https://github.com/hannesstruss/django into hannesstruss-ticket_19325 2012-11-22 10:05:08 +01:00
Julien Phalip
693b8a65ad Modified a staticfiles test to use a unicode character that has just one single representation. The previously used character (ş) has two different representations (u'\u015f' and u's\u0327'), which caused spurious failures when the tests were run across multiple platforms (e.g. on a Linux VM hosted on a Mac). 2012-11-21 09:52:09 +01:00
Claude Paroz
b781354ad1 Updated assertions in pagination test 
assertEquals is a deprecated assertion alias.
 2012-11-21 09:06:21 +01:00
Chris Beaven
48e8b5e944 Add orphans support to MultipleObjectMixin 
Fixes #7005
 2012-11-21 16:50:23 +13:00
Chris Beaven
fbfa654a15 Paginator._get_page hook 
This allows for Paginator subclasses to easily override the Page class
that gets used.

Took the opportunity to also do some non-invasive PEP8 tidying of the
paginator module.
 2012-11-21 15:19:44 +13:00
Hannes Struss
f9891f2087 Fixed #19325 - Made email backend of AdminEmailHandler configurable 2012-11-20 11:23:12 +01:00
Preston Holmes
edf7ad36fa Fixed #18658 -- Improved ModelAdmin.message_user API 
Thanks to Lowe Thiderman for the patch and tests
 2012-11-19 16:03:09 -08:00
Jannis Leidel
778b8bdcf4 Merge pull request #467 from tomchristie/page-kwarg 
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
 2012-11-17 12:27:01 -08:00
Claude Paroz
e0363c688d Fixed #19114 -- Fixed LogEntry unicode representation 
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
 2012-11-17 19:19:59 +01:00
Claude Paroz
2a67374b51 Fixed #19036 -- Fixed base64 uploads decoding 
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
 2012-11-17 17:25:21 +01:00
Claude Paroz
ec9d6b1122 Fixed #19226 -- Applied linebreaksbr to read-only fields in admin 
Thanks shadow for the report, and Melevir and thiderman for the
patch.
 2012-11-17 17:06:24 +01:00
Jannis Leidel
f79013843d Fixed typo introduced in 4a5e8087ac. 2012-11-17 16:00:19 +01:00
Jannis Leidel
233f86443c Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars 
Fixed #18210 -- Escaped special characters in reverse prefixes.
 2012-11-17 06:49:18 -08:00
Jannis Leidel
4a5e8087ac Fixed #19136 -- Properly escape gettext context prefixes in the i18n JavaScript view template. 2012-11-17 15:37:30 +01:00
Preston Holmes
44046e8a38 Fixed #18985 -- made DeprecationWarnings loud 
Capture warnings in Python >= 2.7 and route through
console handler, which is subject to DEBUG==True

Thanks to dstufft for the idea, and claudep for initial patch
 2012-11-16 17:07:38 -08:00
Anssi Kääriäinen
71e14cf3aa Fixed #18347 -- Removed autofield raw SQL inserts from tests 2012-11-15 17:31:08 +02:00
Anssi Kääriäinen
f51e409a5f Fixed #13781 -- Improved select_related in inheritance situations 
The select_related code got confused when it needed to travel a
reverse relation to a model which had different parent than the
originally travelled relation.

Thanks to Trac aliases shauncutts for report and ungenio for original
patch (committed patch is somewhat modified version of that).
 2012-11-15 17:15:21 +02:00
Claude Paroz
550ddc66b4 Fixed #19272 -- Fixed gettext_lazy returned type on Python 2 
Thanks tyrion for the report.
 2012-11-14 10:50:15 +01:00
Claude Paroz
1620c27936 Fixed #19186 -- Fixed sending mail with unicode content on Python 3 
Thanks alex_po for the report and Luke Plant for the analysis.
 2012-11-14 10:43:33 +01:00
Aymeric Augustin
4c5cea7073 Merge pull request #218 from mgrouchy/ticket_18582 
Fixed #18582 -- Added a no-op close to BaseCache
 2012-11-11 07:18:45 -08:00
Claude Paroz
34162698cc Fixed #14264 -- Ensured settings.configure configures logging 
Thanks Matt McDonald for the patch.
 2012-11-10 12:05:58 +01:00
Sean Breant
4d817b3887 Fixed #19262 -- Support cookie pickling in SimpleTemplateResponse 
Refs #15863.
 2012-11-09 21:07:53 +01:00
Claude Paroz
1b307d6c8f Fixed #19261 -- Delayed Queryset evaluation in paginators 
Thanks trbs for the report and the patch.
 2012-11-09 19:41:57 +01:00
Claude Paroz
45802e1248 Merged pagination tests 
It is simpler/cleaner to have all pagination tests in a single file.
Refs #16122.
 2012-11-08 11:07:16 +01:00
Anssi Kääriäinen
cafb266954 Fixed #17144 -- MySQL again groups by PK only 
Thanks to Christian Oudard for the report and tests.
 2012-11-08 00:56:32 +02:00
Claude Paroz
79dd751b0b Fixed #14315 -- Made memcached backend handle negative incr/decr values 
Thanks Michael Manfre for the report and initial patch and
Tobias McNulty for the review.
 2012-11-06 12:22:42 +01:00
Claude Paroz
78f66691ee Fixed #8627 -- Prevented textareas to swallow first newline content 
Browsers consider the first newline in textareas as some display
artifact, not real content. Hence they are not sending it back to
the server. If we want to keep initial newlines, we have to add one
when we render the textarea.
Thanks bastih for the report and initial patch.
 2012-11-05 20:27:06 +01:00
Preston Holmes
6bd61194d4 Fixed py3 compatibility for 5a00a57aa5 2012-11-04 23:38:41 -08:00
Anton I. Sipos
fdea2621cd Fixed #18949 -- Fix broken test interactions in ModelForms tests 
A test in Model Forms test was specifically referring to a fixed
primary key, which was now being used up in a newly committed.
This has been worked around by specifying a higher primary
key.
 2012-11-04 18:43:11 -08:00
Alex Gaynor
4d766b3c9a Merge pull request #495 from aisipos/ticket_18949 
Fixed #18949 -- Improve performance of model_to_dict with many-to-many
 2012-11-04 15:57:45 -08:00
Anton I. Sipos
e44ab5bb4f Fixed #18949 -- Improve performance of model_to_dict with many-to-many 
When calling model_to_dict, improve performance of the generated SQL by
using values_list to determine primary keys of many to many objects. Add
a specific test for this function, test_model_to_dict_many_to_many

Thanks to brian for the original report and suggested fix.
 2012-11-04 15:52:05 -08:00
Preston Holmes
5a00a57aa5 Fixed #19240 -- include pagination error details in ListView 404 
Thanks to seawolf for the patch
 2012-11-04 15:52:00 -08:00
Mike Johnson
fcd3d4c68f model_split: Fixed #19236 - fixed error for abstract models with a split method 2012-11-04 13:43:54 -08:00
Alex Gaynor
4285571c5a Fixed #5805 -- it is now possible to specify multi-column indexes. Thanks to jgelens for the original patch. 2012-11-04 10:16:06 -08:00
Aymeric Augustin
973f539ab8 Fixed #15152 -- Avoided crash of CommonMiddleware on broken querystring 2012-11-03 21:28:33 +01:00
Gabriel Hurley
90e530978d Fixed #18210 -- Escaped special characters in reverse prefixes. 
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.

Thanks to toofishes for the error report.
 2012-11-03 13:06:57 -07:00
Aymeric Augustin
095eca8dd8 Fixed #19101 -- Decoding of non-ASCII POST data on Python 3. 
Thanks Claude Paroz.
 2012-11-03 13:03:15 +01:00
Ulrich Petri
ac2052ebc8 Fixed #17549 -- Added a clickable link for URLFields in admin change list. 2012-11-03 11:57:33 +01:00
Tim Graham
feaf9f279a Fixed #15361 - Documented performance considerations for QuerySet.get() 
Thanks mmcnickle for the patch.
 2012-11-02 17:58:24 -04:00
Andrew Godwin
7f75460fd6 Fixed #19070 -- urlize filter no longer raises exceptions on 2.7 
Thanks to claudep for the patch.
 2012-10-31 10:58:14 +00:00
Anssi Kääriäinen
68847135bc Removed dupe_avoidance from sql/query and sql/compiler.py 
The dupe avoidance logic was removed as it doesn't seem to do anything,
it is complicated, and it has nearly zero documentation.

The removal of dupe_avoidance allowed for refactoring of both the
implementation and signature of Query.join(). This refactoring cascades
again to some other parts. The most significant of them is the changes
in qs.combine(), and compiler.select_related_descent().
 2012-10-31 08:19:44 +02:00
Claude Paroz
73245b3285 Prevented file_upload tests to leave files behind 
Refs #19206.
 2012-10-30 22:27:55 +01:00
Claude Paroz
9a02851340 Fixed #17744 -- Reset default file storage with setting_changed signal 2012-10-30 22:23:28 +01:00
Claude Paroz
6de6988f99 Fixed #5076 -- Properly decode POSTs with non-utf-8 payload encoding 
Thanks daniel at blogg.se for the report and Aymeric Augustin for
his assistance on the patch.
 2012-10-30 09:00:32 +01:00
Claude Paroz
d30516e163 Prevented leftover files and dirs in admin_scripts tests 2012-10-29 19:08:07 +01:00
Luke Plant
4c4d08502c Fixed #17991 - prefetch_related fails with GenericRelation and varchar ID field 
Thanks to okke@formsma.nl for the report, and carmandrew@gmail.com for the tests.
 2012-10-29 14:31:54 +00:00
Claude Paroz
f1cc2be0c5 Fixed #18575 -- Empty DATABASES should default to dummy backend 
Thanks delormemarco@gmail.com for the report.
 2012-10-28 23:44:03 +01:00
Aymeric Augustin
b4420d9602 Fixed #18964 -- floatformat test passes under py3k 
Thanks Russell for the report.
 2012-10-28 19:57:03 +01:00
Anssi Kääriäinen
611c4d6f1c Fixed #18823 -- Ensured m2m.clear() works when using through+to_field 
There was a potential data-loss issue involved -- when clearing
instance's m2m assignments it was possible some other instance's
m2m data was deleted instead.

This commit also improved None handling for to_field cases.
 2012-10-28 17:31:35 +02:00
Anssi Kääriäinen
a5152bb646 Marked a test as expectedFailure on Oracle 2012-10-27 18:34:18 +03:00
Anssi Kääriäinen
2249bd275c Fixed Oracle failure for "%" in table name 2012-10-27 05:26:42 +03:00
Aymeric Augustin
789ea3342d Fixed comment_test tests under hash randomization. 
Thanks clelland for the patch.
 2012-10-26 22:47:45 +02:00
Aymeric Augustin
46d27a6b8d Fixed feedgenerator tests under hash randomization 2012-10-26 22:40:35 +02:00
Aymeric Augustin
195bc37f1d Fixed httpwrappers tests under hash randomization 2012-10-26 22:09:48 +02:00
Claude Paroz
be29329ccd Fixed #16820 -- Treated '0' value as True for checkbox inputs 
Thanks Dan Fairs for the report and the initial patch.
 2012-10-26 20:44:00 +02:00
Andrew Godwin
6a632e0457 Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/models/fields/related.py
	django/db/models/options.py
 2012-10-26 08:41:13 +01:00
Luke Plant
fabe9c9e5f Fixed test failure under Python 2.x introduced in 3e10d22df5 2012-10-26 02:45:15 +01:00
Luke Plant
3e10d22df5 Fixed test failures on Python 3.3 due to dict ordering assumptions. 
Refs #19038
 2012-10-26 02:13:09 +01:00
Luke Plant
c8508943a2 Fixed some test failures on Python 3.3 related to QueryDict 
Refs #19038.
 2012-10-26 01:55:55 +01:00
Ian Clelland
bdcd2f6b10 Avoid dependence on exact Python exception messages 2012-10-26 01:40:33 +01:00
Ian Clelland
02dda22832 Don't use : as an invalid cookie character 
Since http://bugs.python.org/issue2193 has been resolved in favour of
the colon in cookie names, we need to test invalid cookie removal using
a different character. "@" is still considered invalid by all sources.
 2012-10-26 01:40:32 +01:00
Luke Plant
71734dfa72 Fixed #19039 - Python 3.3 fails unit test for duplicate bad cookies 
Thanks to clelland for the report.
 2012-10-26 00:50:25 +01:00
Luke Plant
f3a2bcdee9 Fixed #15040 - Boolean fields return 0 and 1 when loaded through select_related 
Thanks to homm for the report and ramiro for the patch.
 2012-10-26 00:25:59 +01:00
Aymeric Augustin
1d6b7f302a Fixed timezone tests when dict randomization is on 
Refs #17758.
 2012-10-25 23:14:17 +02:00
Anssi Kääriäinen
7de439f32d Fixed #19187 -- Raise consistent error from qs.values().delete() 2012-10-25 17:16:56 +03:00
Anssi Kääriäinen
f64a5ef404 Fixed #19102 -- Fixed fast-path delete for modified SELECT clause cases 
There was a bug introduced in #18676 which caused fast-path deletes
implemented as "DELETE WHERE pk IN <subquery>" to fail if the SELECT
clause contained additional stuff (for example extra() and annotate()).

Thanks to Trac alias pressureman for spotting this regression.
 2012-10-25 17:16:44 +03:00
Tom Christie
f824a95177 Test for ListView.page_kwarg 2012-10-25 13:19:53 +01:00
Aymeric Augustin
da56e1bac6 Fixed #18796 -- Refactored conversion to bytes in HttpResponse 
Thanks mrmachine for the review.
 2012-10-25 08:49:51 +02:00
Aymeric Augustin
82b3e6ffcb Fixed #13222 -- Made HttpResponse iterable once 
response.content can be accessed many times as desired, and always
returns the same result.

iter(response) works only once and consumes the iterator.
 2012-10-24 17:19:56 +02:00
Aymeric Augustin
495a8b8107 Fixed #6527 -- Provided repeatable content access 
in HttpResponses instantiated with iterators.
 2012-10-24 17:08:37 +02:00
Aymeric Augustin
83041ca802 Fixed a DeprecationWarning under Python 3. 2012-10-24 16:52:21 +02:00
Claude Paroz
9fd2f9c5f3 Fixed #19088 -- Always escape % inside blocktrans tag 
Thanks vlinhart for the report and Łukasz Rekucki for the patch.
 2012-10-23 18:49:22 +02:00
Carl Meyer
3541a10d49 Fixed #19164 -- Fixed diffsettings command broken in fix for #18545. 
Thanks Mario César for the report and draft patch.
 2012-10-22 18:49:08 -06:00
Aymeric Augustin
ea57112d53 Reverted 6a64822bf4. 
This commit caused every test that does two or more assertContains to
fail, because of #6527. It also made HttpResponse non-pickleable.

Refs #13222.
 2012-10-23 00:11:17 +02:00
Aymeric Augustin
6a64822bf4 Fixed #13222 -- Repeated iteration of HttpResponse 
Thanks teepark for the report and grahamd for his insights.
 2012-10-22 22:52:36 +02:00
Claude Paroz
e70170c2cb Cleaned up i18n regression tests 2012-10-22 14:45:41 +02:00
Aymeric Augustin
5e629a015e Added tests for conditional_content_removal. 
Refs #7581. Thanks mrmachine.
 2012-10-21 22:40:31 +02:00
Claude Paroz
22471a41ba Merge pull request #457 from JanBednarik/ticket_19142 
Fixed #19142 -- Language codes can include numbers (RFC 3066)
 2012-10-21 10:35:01 -07:00
Alex Gaynor
6b3d2bc981 Merge pull request #444 from mitar/patch-2 
Allow reversed iteration over SortedDict.
 2012-10-20 20:39:49 -07:00
Jan Bednařík
e6b34193c5 Fixed #19142 -- Language codes can include numbers (RFC 3066). 2012-10-21 01:25:35 +02:00
Jan Bednařík
b87e2f46c8 Fixed #19151 -- Added missing methods to EmptyQuerySet. 
Added values() and values_list() methods to EmptyQuerySet.
 2012-10-21 00:19:38 +02:00
Aymeric Augustin
d7c6a57d60 Used @override_settings in several tests. 2012-10-20 23:22:46 +02:00
Aymeric Augustin
4b27813198 Fixed #7581 -- Added streaming responses. 
Thanks mrmachine and everyone else involved on this long-standing ticket.
 2012-10-20 20:05:11 +02:00
Claude Paroz
cfb3eb2e3d Used FakePayload in requests tests 2012-10-20 15:54:26 +02:00
Claude Paroz
dcbf08cce5 Fixed #19094 -- Improved FakePayload to support write, len and string input 
Thanks Ondrej Slinták for the suggestion.
 2012-10-20 15:36:24 +02:00
Claude Paroz
dfd4a71751 Fixed #5611 -- Restricted accepted content types in parsing POST data 
Thanks paulegan for the report and Preston Holmes for the review.
 2012-10-20 14:56:16 +02:00
Claude Paroz
681550ca6d Removed custom WSGIRequestHandler.get_environ 
We probably historically customized it for good reasons, but
currently, the differences with upstream Python are not
significant any longer.
Also fixes #19075 for which a test has been added.
 2012-10-20 13:55:13 +02:00
Ramiro Morales
0b908b92a2 Fixed #8001 -- Made redirections after add/edit in admin customizable. 
Also fixes #18310.
 2012-10-18 20:58:52 -03:00
Preston Holmes
4fb510fde4 Added missed poisoned host header tests 2012-10-18 11:10:46 -07:00
Claude Paroz
6b0a836c9c Fixed assertXMLEqual when first node was a comment 2012-10-15 23:05:40 +02:00
Mitar
2811e543c6 Added tests for reversed iteration over SortedDict. 2012-10-15 12:12:10 -07:00
Ludovic Delaveau
7a44dc555a Fixed #16479 - Forms generated from formsets use ErrorList instead of supplied error_class 
Patch with tests from charettes, updated.
 2012-10-13 15:28:20 +01:00
Adrian Holovaty
ffbc599f77 Removed country-specific localflavor tests. 
They now live in separate django-contrib-XX packages.
 2012-10-12 16:21:51 -05:00
Tim Graham
06f5da3d78 Fixed #16817 - Added a guide of code coverage to contributing docs. 
Thanks Pedro Lima for the draft patch.
 2012-10-11 06:11:52 -04:00
Anssi Kääriäinen
041ef9ed68 Removed some uses of F() expression & and | 
Refs #16211
 2012-10-10 03:31:11 +03:00
Michael Manfre
32ac067a6d Fixed #18927 -- Fixed bulk_create tests when no has_bulk_insert 2012-10-10 01:39:43 +03:00
Anssi Kääriäinen
b625e8272b Moved F() '&' and '|' to .bitand() and .bitor() 
Done for consistency with Q() expressions and QuerySet combining. This
will allow usage of '&' and '|' as boolean logical operators in the
future. Refs #16211.
 2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
a8b1861fc4 Revert "Fixed #16211 -- Added comparison and negation ops to F() expressions" 
This reverts commit 28abf5f0eb.

Conflicts:

	docs/releases/1.5.txt
 2012-10-10 01:15:29 +03:00
Anssi Kääriäinen
7f4dbdc036 Revert "Splitted expressions tests into smaller methods" 
This reverts commit c2532825db.
 2012-10-10 01:15:29 +03:00
Claude Paroz
252cd271e8 Fixed test failure after IDN domain validation fix 
Refs #17867.
The address in test_email_regexp_for_performance used to take forever
(security issue), then was supposed to fail after the fix (commit 9f8287a3f).
Now we are less strict with domain validation, due to new IDN domains,
hence the validation of this address pass now.
 2012-10-09 22:44:43 +02:00
Aymeric Augustin
3190abcd75 Fixed #18153 -- Reverse OneToOne lookups on unsaved instances. 
Thanks David Hatch and Anssi Kääriäinen for their inputs.
 2012-10-09 21:36:35 +02:00
Aymeric Augustin
c9b4e9ac3a Fixed #19095 -- invalid code in multidb tests. 2012-10-09 21:23:02 +02:00
Claude Paroz
273b96ef9d Fixed #17867 -- Made email validation pass with IDN domains 
Thanks Pierre Matri for the report and the initial patch.
 2012-10-09 15:08:32 +02:00
Claude Paroz
8cb9968a91 Moved some email validation tests to validators tests 2012-10-09 15:08:32 +02:00
Claude Paroz
a8f888feb4 Improved assertion error messages in validators tests 2012-10-09 15:08:22 +02:00
Anssi Kääriäinen
a62d53c032 Fixed #19087 -- Ensured query's base table is never LOUTER joined 
This fixes a regression created by join promotion logic refactoring:
01b9c3d519

Thanks to Ivan Virabyan for the report.
 2012-10-08 18:40:09 +03:00
Claude Paroz
4797ad80da [py3] Decoded the parsed source file encoding in debug view 2012-10-08 10:06:56 +02:00
Ramiro Morales
35e8dc5169 Removed ad-hoc support for usage of short names of built-in DB backends. 
This non-standard naming was deprecated in Django 1.2.
 2012-10-06 23:27:08 -03:00
Claude Paroz
117e99511e Added assertXML[Not]Equal assertions 
This is especially needed to compare XML when hash randomization
is on, as attribute order may vary. Refs #17758, #19038.
Thanks Taylor Mitchell for the initial patch, and Ian Clelland for
review and cleanup.
 2012-10-06 13:14:50 +02:00
Russell Keith-Magee
cc337a74f1 Fixed #19069 -- Improved the error message when trying to query a swapped model. 
Thanks to Preston Holmes for the suggestion.
 2012-10-06 14:21:57 +08:00
Stephen Burrows
218abcc9e5 Fixed #14567 -- Made ModelMultipleChoiceField return EmptyQuerySet as empty value 2012-10-03 20:47:35 +03:00
Russell Keith-Magee
3b6f980bed Fixed #19049 -- Ensure that swapped models aren't included in reverse field caches. 
Thanks to Ivan Virabyan for the report.
 2012-10-02 22:52:45 +08:00
Preston Holmes
55fa86a97f Fixed postgres rollback issue with fixture test 2012-10-01 11:36:16 -07:00
Preston Holmes
e7723683dc Fixed #9279 -- Added ignorenonexistent option to loaddata 
Thanks to Roman Gladkov for the initial patch and Simon Charette for review.
 2012-09-30 23:40:27 -07:00
Claude Paroz
8bd7b598b6 Fixed #18807 -- Made 404.html and 500.html optional 
Thanks Aymeric Augustin for the report and Jannis Leidel for the
review.
 2012-09-30 23:16:19 +02:00
Claude Paroz
08d675a98f Fixed #7936 -- Added Last-Modified header to feeds 
Thanks julianb for the report and the initial patch, and Roman
Gladkov for working on tests.
 2012-09-30 22:40:25 +02:00
Anssi Kääriäinen
c2532825db Splitted expressions tests into smaller methods 2012-09-30 17:51:11 +03:00
Anssi Kääriäinen
28abf5f0eb Fixed #16211 -- Added comparison and negation ops to F() expressions 
Work done by Walter Doekes and Trac alias knoeb. Reviewed by Simon
Charette.
 2012-09-30 17:51:06 +03:00
Claude Paroz
f0f327bbfe Fixed #18993 -- 'django' logger logs to console when DEBUG=True 
Thanks Preston Holmes for the review.
 2012-09-29 22:56:18 +02:00
Florian Apolloner
6a6f589bfe Merge branch 'ticket15695' 2012-09-29 21:57:50 +02:00
Anssi Kääriäinen
1cd6e04cd4 Fixed #18676 -- Allow fast-path deletion of objects 
Objects can be fast-path deleted if there are no signals, and there are
no further cascades. If fast-path is taken, the objects do not need to
be loaded into memory before deletion.

Thanks to Jeremy Dunck, Simon Charette and Alex Gaynor for reviewing
the patch.
 2012-09-28 18:16:08 +03:00
Anssi Kääriäinen
3fcca0e947 Added a way to check if a signal has listeners 2012-09-28 18:10:52 +03:00
Claude Paroz
07ffe78143 Used get_current_site in comments feed class 2012-09-28 14:35:26 +02:00
Julien Phalip
b8244c654c Fixed #18881 -- Made the context option in {% trans %} and {% blocktrans %} accept literals wrapped in single quotes. Thanks to lanyjie for the report. 2012-09-27 20:34:45 -07:00
Eduardo Cereto Carvalho
c9c9a56425 Added complementary regression test for commit c1729510 
Also fixed #18660.
 2012-09-27 15:57:28 +02:00
Florian Apolloner
b946db5241 Fixed #15695 -- Added ResolverMatch to the request object. 2012-09-27 15:06:58 +02:00
Claude Paroz
3cbe686af6 Fixed #18675 -- Fixed was_modified_since with floating-point mtime 
Thanks Simon Charette for the patch.
 2012-09-26 21:12:56 +02:00
Claude Paroz
b3ee80a0cf Fixed parse_http_date docstring and moved related tests 
Refs #18675.
 2012-09-26 21:10:17 +02:00
Claude Paroz
bb7da7844f Fixed #18845 -- Do not swallow AttributeErrors when running commands 2012-09-26 15:07:11 +02:00
Adrien Lemaire
2c8267bf3d Fixed #17899 -- Rewrote [Ee]-mail to [Ee]mail 2012-09-26 14:14:51 +02:00
Russell Keith-Magee
70a0de37d1 Fixed #3011 -- Added swappable auth.User models. 
Thanks to the many people that contributed to the development and review of
this patch, including (but not limited to) Jacob Kaplan-Moss, Anssi
Kääriäinen, Ramiro Morales, Preston Holmes, Josh Ourisman, Thomas Sutton,
and Roger Barnes, as well as the many, many people who have contributed to
the design discussion around this ticket over many years.

Squashed commit of the following:

commit d84749a0f034a0a6906d20df047086b1219040d0
Merge: 531e771 7c11b1a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Wed Sep 26 18:37:04 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 531e7715da545f930c49919a19e954d41c59b446
Merge: 29d1abb 1f84b04
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Wed Sep 26 07:09:23 2012 +0800

    Merged recent trunk changes.

commit 29d1abbe351fd5da855fe5ce09e24227d90ddc91
Merge: 8a527dd 54c81a1
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 24 07:49:46 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 8a527dda13c9bec955b1f7e8db5822d1d9b32a01
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 24 07:48:05 2012 +0800

    Ensure sequences are reset correctly in the presence of swapped models.

commit e2b6e22f298eb986d74d28b8d9906f37f5ff8eb8
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 17:53:05 2012 +0800

    Modifications to the handling and docs for auth forms.

commit 98aba856b534620aea9091f824b442b47d2fdb3c
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 15:28:57 2012 +0800

    Improved error handling and docs for get_user_model()

commit 0229209c844f06dfeb33b0b8eeec000c127695b6
Merge: 6494bf9 8599f64
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 23 14:50:11 2012 +0800

    Merged recent Django trunk changes.

commit 6494bf91f2ddaaabec3ec017f2e3131937c35517
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 17 21:38:44 2012 +0800

    Improved validation of swappable model settings.

commit 5a04cde342cc860384eb844cfda5af55204564ad
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Sep 17 07:15:14 2012 +0800

    Removed some unused imports.

commit ffd535e4136dc54f084b6ac467e81444696e1c8a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 20:31:28 2012 +0800

    Corrected attribute access on for get_by_natural_key

commit 913e1ac84c3d9c7c58a9b3bdbbb15ebccd8a8c0a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 20:12:34 2012 +0800

    Added test for proxy model safeguards on swappable models.

commit 280bf19e94d0d534d0e51bae485c1842558f4ff4
Merge: dbb3900 935a863
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 18:16:49 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit dbb3900775a99df8b6cb1d7063cf364eab55621a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 18:09:27 2012 +0800

    Fixes for Python 3 compatibility.

commit dfd72131d8664615e245aa0f95b82604ba6b3821
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 15:54:30 2012 +0800

    Added protection against proxying swapped models.

commit abcb027190e53613e7f1734e77ee185b2587de31
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 15:11:10 2012 +0800

    Cleanup and documentation of AbstractUser base class.

commit a9491a87763e307f0eb0dc246f54ac865a6ffb34
Merge: fd8bb4e 08bcb4a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 14:46:49 2012 +0800

    Merge commit '08bcb4aec1ed154cefc631b8510ee13e9af0c19d' into t3011

commit fd8bb4e3e498a92d7a8b340f0684d5f088aa4c92
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 14:20:14 2012 +0800

    Documentation improvements coming from community review.

commit b550a6d06d016ab6a0198c4cb2dffe9cceabe8a5
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:52:47 2012 +0800

    Refactored skipIfCustomUser into the contrib.auth tests.

commit 52a02f11107c3f0d711742b8ca65b75175b79d6a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:46:10 2012 +0800

    Refactored common 'get' pattern into manager method.

commit b441a6bbc7d6065175715cb09316b9f13268171b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 16 13:41:33 2012 +0800

    Added note about backwards incompatible change to admin login messages.

commit 08bcb4aec1ed154cefc631b8510ee13e9af0c19d
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Sep 15 18:30:33 2012 +0300

    Splitted User to AbstractUser and User

commit d9f5e5addbad5e1a01f67e7358e4f5091c3cad81
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Sep 15 18:30:02 2012 +0300

    Reworked REQUIRED_FIELDS + create_user() interaction

commit 579f152e4a6e06671e1ac1e59e2b43cf4d764bf4
Merge: 9184972 93e6733
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:18:37 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 918497218c58227f5032873ff97261627b2ceab2
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:18:19 2012 +0800

    Deprecate AUTH_PROFILE_MODULE and get_profile().

commit 334cdfc1bb6a6794791497cdefda843bca2ea57a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 20:00:12 2012 +0800

    Added release notes for new swappable User feature.

commit 5d7bb22e8d913b51aba1c3360e7af8b01b6c0ab6
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 19:59:49 2012 +0800

    Ensure swapped models can't be queried.

commit 57ac6e3d32605a67581e875b37ec5b2284711a32
Merge: f2ec915 abfba3b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 15 14:31:54 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit f2ec915b20f81c8afeaa3df25f80689712f720f8
Merge: 1952656 5e99a3d
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 08:29:51 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 19526563b54fa300785c49cfb625c0c6158ced67
Merge: 2c5e833 c4aa26a
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 08:22:26 2012 +0800

    Merge recent changes from master.

commit 2c5e833a30bef4305d55eacc0703533152f5c427
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 07:53:46 2012 +0800

    Corrected admin_views tests following removal of the email fallback on admin logins.

commit 20d1892491839d6ef21f37db4ca136935c2076bf
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sun Sep 9 01:00:37 2012 +0800

    Added conditional skips for all tests dependent on the default User model

commit 40ea8b888284775481fc1eaadeff267dbd7e3dfa
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 8 23:47:02 2012 +0800

    Added documentation for REQUIRED_FIELDS in custom auth.

commit e6aaf659708cf6491f5485d3edfa616cb9214cc0
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Sat Sep 8 23:20:02 2012 +0800

    Added first draft of custom User docs.

    Thanks to Greg Turner for the initial text.

commit 75118bd242eec87649da2859e8c50a199a8a1dca
Author: Thomas Sutton <me@thomas-sutton.id.au>
Date:   Mon Aug 20 11:17:26 2012 +0800

    Admin app should not allow username discovery

    The admin app login form should not allow users to discover the username
    associated with an email address.

commit d088b3af58dad7449fc58493193a327725c57c22
Author: Thomas Sutton <me@thomas-sutton.id.au>
Date:   Mon Aug 20 10:32:13 2012 +0800

    Admin app login form should use swapped user model

commit 7e82e83d67ee0871a72e1a3a723afdd214fcefc3
Merge: e29c010 39aa890
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Fri Sep 7 23:45:03 2012 +0800

    Merged master changes.

commit e29c010beb96ca07697c4e3e0c0d5d3ffdc4c0a3
Merge: 8e3fd70 30bdf22
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Aug 20 13:12:57 2012 +0800

    Merge remote-tracking branch 'django/master' into t3011

commit 8e3fd703d02c31a4c3ac9f51f5011d03c0bd47f6
Merge: 507bb50 26e0ba0
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Aug 20 13:09:09 2012 +0800

    Merged recent changes from trunk.

commit 507bb50a9291bfcdcfa1198f9fea21d4e3b1e762
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 20:41:37 2012 +0800

    Modified auth app so that login with alternate auth app is possible.

commit dabe3628362ab7a4a6c9686dd874803baa997eaa
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 20:10:51 2012 +0800

    Modified auth management commands to handle custom user definitions.

commit 7cc0baf89d490c92ef3f1dc909b8090191a1294b
Author: Russell Keith-Magee <russell@keith-magee.com>
Date:   Mon Jun 4 14:17:28 2012 +0800

    Added model Meta option for swappable models, and made auth.User a swappable model
 2012-09-26 18:48:09 +08:00
Ramiro Morales
f51eab796d Fixed #18072 -- Made more admin links use reverse() instead of hard-coded relative URLs. 
Thanks kmike for the report and initial patch for the changelist->edit
object view link URL.

Other affected links include the delete object one and object history
one (in this case the change had been implemented in commit 5a9e127, this
commit adds admin-quoting of the object PK in a way similar to a222d6e.)

Refs #15294.
 2012-09-24 22:02:59 -03:00
Claude Paroz
515fd6a5de Called parent __init__ in test logging handler 2012-09-24 22:42:58 +02:00
Claude Paroz
fc69fff9ab Fixed #14861 -- Moved logging config outside of Settings.__init__ 
Thanks donspaulding for the report and simonpercivall for the
initial patch.
 2012-09-24 22:12:45 +02:00
Claude Paroz
e72e22e518 Replaced a deprecated assertEquals 2012-09-24 16:07:58 +02:00
Andrew Godwin
a589fdff81 Fix PostgreSQL failing on a test 2012-09-24 13:55:37 +01:00
Andrew Godwin
15c1920964 Only swallow table-does-not-exist errors in tests 2012-09-24 13:30:17 +01:00
Andrew Godwin
0354cecbfd Fix nullability changing code 2012-09-24 12:56:17 +01:00
Aymeric Augustin
3174b5f2f5 Fixed #18982 - Caught TypeError in DateField.clean 
Thanks gwahl at fusionbox com.
 2012-09-23 13:27:01 +02:00
Claude Paroz
8599f64e54 Fixed #18861 -- Triggered message validation with locmem email backend 
Thanks Bruno Renié for the report and the initial patch.
 2012-09-22 15:17:13 +02:00
Aymeric Augustin
822cfce3df Fixed #18951 -- Formatting of microseconds. 
Thanks olofom at gmail com for the report.
 2012-09-22 12:02:21 +02:00
Aymeric Augustin
baa33cd8fa Fixed #16218 -- date_list order in generic CBVs. 
Thanks nnrcschmdt for the report and bpeschier for the initial
version of the patch.
 2012-09-22 11:47:34 +02:00
Andrew Godwin
49d1e6b0e2 Remove AppCache state handling, replace with swappable caches 2012-09-22 00:47:04 +01:00
Claude Paroz
26ff2be787 Imported getLogger directly from logging module 
This was a remainder of some 2.4 compatibility code.
 2012-09-20 21:03:24 +02:00
Carl Meyer
4e9a74b81d Revert "Fixed #16865 -- Made get_or_create use read database for initial get query." 
Thanks to Jeremy Dunck for pointing out the problem with this change. If in a
single transaction, the master deletes a record and then get_or_creates a
similar record, under the new behavior the get_or_create would find the record
in the slave db and fail to re-create it, leaving the record nonexistent, which
violates the contract of get_or_create that the record should always exist
afterwards. We need to do everything against the master here in order to ensure
correctness.

This reverts commit 901af86550.
 2012-09-19 11:15:12 -06:00
Carl Meyer
901af86550 Fixed #16865 -- Made get_or_create use read database for initial get query. 
Thanks Rick van Hattem for the report and trbs for the patch.
 2012-09-19 10:06:53 -06:00
Jeremy Dunck
40e62a5ccd Fixed #18980 -- Fixed assertContains regression when passed an object 2012-09-18 21:05:41 +02:00
Florian Apolloner
319e135519 Fixed #18800 -- Support numbers bigger than max float in numberformat. 
Thanks to jbvsmo for the patch and Brad Pitcher for the tests.
 2012-09-18 19:43:50 +02:00
Andrew Godwin
7e8c64d8e6 Dropping pointless self.fail calls 2012-09-18 10:59:03 +01:00
Andrew Godwin
06227fbb83 Python 3 compatability. 2.6 was a while back, I should learn ' as '. 2012-09-17 23:51:48 +01:00
Florian Apolloner
23d0136314 Merge branch 'lotheac-fix_uploaded_file_exec' 2012-09-17 22:54:26 +02:00
Florian Apolloner
e8c6aff3bf Fixed #18947 -- Don't make uploaded files executeable by default. 
Thanks to Lauri Tirkkonen for the patch.
 2012-09-17 22:53:10 +02:00
Andrew Godwin
d0b3536964 More schema test fixing 2012-09-17 21:16:36 +01:00
Andrew Godwin
9313dea700 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/mysql/base.py
	django/db/backends/postgresql_psycopg2/base.py
 2012-09-17 20:00:14 +01:00
Andrew Godwin
dbf8b93c52 Fix app loading/test interaction 2012-09-17 19:57:23 +01:00
Florian Apolloner
a630d08483 Merge pull request #360 from calebsmith/add-permalink-wraps-test 
Ticket #12836 - Added a test to assure permalink wraps method attributes
 2012-09-16 14:00:51 -07:00
Anssi Kääriäinen
f399a804c9 Fixed #17485 regression -- only + select_related interaction 
When doing deeper than one level select_related() + only queries(), the
code introduced in b6c356b7bb errored
incorrectly.

Thanks to mrmachine for report & test case.
 2012-09-16 22:58:40 +03:00
Julien Phalip
c555741aa7 Fixed #18530 -- Fixed a small regression in the admin filters where wrongly formatted dates passed as url parameters caused an unhandled ValidationError. Thanks to david for the report. 2012-09-15 16:20:56 -07:00
Claude Paroz
b1fb6f4820 Modernized views.DebugViewTests 2012-09-15 21:07:42 +02:00
Claude Paroz
859aa2a6c4 Fixed #18790 -- Encoded database password on Python 2 
Thanks thcourbon@gmail.com for the report.
 2012-09-12 10:16:49 +02:00
Claude Paroz
f1bdfbd24b Document and test 'type' usage in Widget attrs 
Refs #16630.
 2012-09-10 19:31:11 +02:00
Karen Tracey
2e92858386 Fixed a couple of test failures on Windows. 2012-09-09 15:07:04 -04:00
Carl Meyer
a3b2136b28 Remove an outdated import inadvertently introduced in tests. 2012-09-08 18:22:03 -06:00
Carl Meyer
a78dd109e6 Fixed #15552 -- LOGIN_URL and LOGIN_REDIRECT_URL can take URLpattern names. 
Thanks UloPe and Eric Florenzano for the patch, and Malcolm Tredinnick for
review.
 2012-09-08 16:58:35 -06:00
Carl Meyer
307706d082 Fixed #18545 -- Make the 'no DJANGO_SETTINGS_MODULE' error message more useful.Thanks Nick Coghlan for the report, and Malcolm Tredinnick for review. 2012-09-08 14:26:33 -06:00
Travis Swicegood
4754f122dd Moved the admin inline JS to new JS files for cleanliness. 2012-09-08 15:09:37 -04:00
Caleb Smith
210fd7c658 refs #12836 - Added a test to assure permalink wraps method attributes 2012-09-08 11:58:48 -04:00
Travis Swicegood
ccd1bb0d81 Remove Admin's swallowing of AttributeError (#16655, #18593, #18747) 
During the new-admin changes, catching of AttributeError was added to
the admin.  This patch removes that as it's no longer possible to add a
value to a ModelAdmin that is not available.  Adding an attribute that
can not be called causes an ImproperlyConfigured exception to be raised.
 2012-09-08 11:20:05 -04:00
Aymeric Augustin
9b07b5edeb Fixed #18916 -- Allowed non-ASCII headers. 
Thanks Malcolm Tredinnick for the review.
 2012-09-07 19:08:57 -04:00
Alex Gaynor
b865009d41 Fixed #12397 -- allow safe_join to work with the root file system path, which means you can have your root template or file upload path at this location. You almost certainly don't want to do this, except in *very* limited sandboxed situations. 2012-09-07 16:49:22 -04:00
Andrew Godwin
828d691f62 Merge branch 'master' into schema-alteration 2012-09-07 15:43:28 -04:00
Andrew Godwin
ca9c3cd39f Add check constraint support - needed a few Field changes 2012-09-07 15:40:59 -04:00
Alex Gaynor
5999eb42eb Removed another usage of the bear "except:" (rawr!). 2012-09-07 15:34:48 -04:00
Alex Gaynor
335a9f9cf1 Removed many uses of bare "except:", which were either going to a) silence real issues, or b) were impossible to hit. 2012-09-07 15:08:07 -04:00
Andrew Godwin
375178fc19 Add M2M repointing 2012-09-07 14:39:22 -04:00
Alex Gaynor
6a5a12ea3e Fixed #17888 -- no longer silence exceptions inside of check_test. Thanks to brutasse for the patch. 2012-09-07 14:37:21 -04:00
Alex Gaynor
a92b81b0e8 Fixed tests that I broke a few commits ago. 2012-09-07 14:01:46 -04:00
Alex Gaynor
f47af9df1d Cleaned up several test cases, to better isolate state. 2012-09-07 13:47:12 -04:00
Andrew Godwin
a92bae0f06 Repoint ForeignKeys when their to= changes. 2012-09-07 13:31:05 -04:00
Alex Gaynor
292322f977 [py3k] Silence many warnings while running the tests. 2012-09-07 13:17:34 -04:00
Andrew Godwin
d683263f97 Added SQLite backend which passes all current tests 2012-09-07 12:51:11 -04:00
Alex Gaynor
0e296131bb Cleaned up some small bits of the ORM, including removing an import *. 2012-09-07 10:58:17 -04:00
Aymeric Augustin
5262a288df Fixed #18687: Removed test_performance_scalability 
Even after repeated adjustment of the constants, this test still fails
randomly. It has educated us to ignore messages from Jenkins, to a
point where we missed some actual failures. In addition, it accounts
for a non-negligible percentage of the run time of the test suite
just by itself. Since no one has proposed a convincing patch in months,
I'm going to remove the patch. We can't keep a randomly failing test
forever.
 2012-09-05 23:02:33 -04:00
Andrew Godwin
b546e7eb63 Merge branch 'master' into schema-alteration 2012-09-05 09:39:03 -04:00
Andrew Godwin
cd583d6dbd Implement primary key changing 2012-09-04 12:53:31 -04:00
Claude Paroz
22f85b9057 Fixed #18824 -- Allow deleting a setting from overriden settings 2012-09-04 09:41:12 +02:00
Claude Paroz
cc9b767fc6 Fixed #18902 -- Made force_bytes properly handle exception input 
Thanks Aymeric Augustin for the report and the initial patch.
 2012-09-04 09:27:28 +02:00
Claude Paroz
28fd876bae Fixed #17892 -- Do not include whole RegexURLPattern lists in RegexURLResolver repr 
Thanks milosu for the report and the initial patch.
 2012-09-01 22:20:46 +02:00
Claude Paroz
306d34873c Fixed #18212 -- Standardized arguments of GenericIPAddressField 
Unlike other model fields, the newly introduced (1.4)
GenericIPAddressField did not accept verbose_name and name as the
first positional arguments. This commit fixes it.
Thanks Dan McGee for the report and the patch.
 2012-09-01 18:38:55 +02:00
Andrew Godwin
d865503389 db_index alteration mostly working 2012-08-30 23:11:56 +01:00
Claude Paroz
879b245baa Fixed #5725 -- Fixed varchar column size introspection for MySQL 
Thanks ferdonline for the initial patch and Karen Tracey for the
related post on django-users.
 2012-08-30 19:28:13 +02:00
Claude Paroz
4e70ad11d2 Made FileSystemStorage accept both text and byte streams 
Thanks Alexey Boriskin for his help on the patch.
 2012-08-29 16:37:37 +02:00
Claude Paroz
b5240d25c1 Removed unnecessary bytes prefix for ContentFile 2012-08-29 11:32:18 +02:00
Claude Paroz
361d6738f8 Fixed #11739 -- Made ContentFile support Unicode input 2012-08-29 11:21:33 +02:00
Claude Paroz
ebc773ada3 Replaced many smart_bytes by force_bytes 
In all those occurrences, we didn't care about preserving the
lazy status of the strings, but we really wanted to obtain a
real bytestring.
 2012-08-29 11:20:32 +02:00
Florian Apolloner
9eafb6592e [py3] Fixed test failures introduced in 3afb5916b2. 2012-08-29 00:04:34 +02:00
Florian Apolloner
3afb5916b2 Fixed #18091 -- Non-ASCII templates break django-admin.py startproject --template=TEMPLATE. 
Thanks to Claude Huchet and Tomáš Ehrlich for the patch.
 2012-08-28 23:23:07 +02:00
Ramiro Morales
5a9e127efc Made model instance history admin view link not hard-coded. Refs #15294. 2012-08-26 17:54:49 -03:00
Aymeric Augustin
28ea4d4b07 Fixed #18852 -- Restored backwards compatibility 
in django.core.signing. Specifically, kept the same return types
(str/unicode) under Python 2. Related to [92b2dec918].
 2012-08-25 22:22:32 +02:00
Anssi Kääriäinen
01b9c3d519 Fixed #16715 -- Fixed join promotion logic for nested nullable FKs 
The joins for nested nullable foreign keys were often created as INNER
when they should have been OUTER joins. The reason was that only the
first join in the chain was promoted correctly. There were also issues
with select_related etc.

The basic structure for this problem was:
  A -[nullable]-> B -[nonnull]-> C

And the basic problem was that the A->B join was correctly LOUTER,
the B->C join not.

The major change taken in this patch is that now if we promote a join
A->B, we will automatically promote joins B->X for all X in the query.
Also, we now make sure there aren't ever join chains like:
   a LOUTER b INNER c
If the a -> b needs to be LOUTER, then the INNER at the end of the
chain will cancel the LOUTER join and we have a broken query.

Sebastian reported this problem and did also major portions of the
patch.
 2012-08-25 14:14:45 +03:00
Claude Paroz
f5ea730dac Fixed #18843 -- Replaced more special chars in column names (inspectdb) 
Thanks airstrike for the report.
 2012-08-23 22:59:45 +02:00
Claude Paroz
395c6083af Fixed #12460 -- Improved inspectdb handling of special field names 
Thanks mihail lukin for the report and elijahr and kgibula for their
work on the patch.
 2012-08-23 21:46:57 +02:00
Alexey Boriskin
10d32072af Fixed #18798 -- Renamed conflicting test methods in i18n tests 2012-08-23 11:27:56 +02:00
Claude Paroz
44c09de555 Fixed #18678 -- HttpResponse init arguments allowed for subclasses 
Thanks hp1337@gmail.com for the report.
 2012-08-23 10:59:22 +02:00
Claude Paroz
7cfe8e8fce Fixed #11340 -- Prevented HttpResponseNotModified to have content/content-type 
The HTTP 1.1 spec tells that the 304 response MUST NOT contain a
message body.
Thanks aparajita for the report.
 2012-08-22 20:55:24 +02:00
Simon Meers
dfe63a52ef Revert "Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2" 
This reverts commit 3fce0d2a91.
 2012-08-22 11:48:47 +10:00
Claude Paroz
4353a6163c Fixed #18196 -- Improved loaddata error messages. 2012-08-21 21:52:25 +02:00
Anssi Kääriäinen
a193372753 Fixed #17886 -- Fixed join promotion in ORed nullable queries 
The ORM generated a query with INNER JOIN instead of LEFT OUTER JOIN
in a somewhat complicated case. The main issue was that there was a
chain of nullable FK -> non-nullble FK, and the join promotion logic
didn't see the need to promote the non-nullable FK even if the
previous nullable FK was already promoted to LOUTER JOIN. This resulted
in a query like a LOUTER b INNER c, which incorrectly prunes results.
 2012-08-21 21:23:57 +03:00
Aymeric Augustin
e89bc39935 Reverted type check added in 62954ba04c. 
Refs #17040.
 2012-08-21 09:00:55 +02:00
Aymeric Augustin
62954ba04c [py3] Fixed #17040 -- ported django.utils.crypto.constant_time_compare. 
This is a private API; adding a type check is acceptable.
 2012-08-20 22:50:49 +02:00
Simon Meers
3fce0d2a91 Fixed #18063 -- Avoid unicode in Model.__repr__ in python 2 
Thanks guettli and mrmachine.
 2012-08-20 16:47:30 +10:00
Aymeric Augustin
9729f77326 Reordered import statements for clarity. 2012-08-19 21:50:07 +02:00
Aymeric Augustin
2f59e94a41 Fixed #18728 -- Made colon optional in tzinfo 
Made two-digit hours and minutes mandatory in tzinfo (the code used
to crash if a one-digit representation was provided).

Added standalone tests for django.utils.dateparse.
 2012-08-19 21:47:41 +02:00
Aymeric Augustin
536b030363 [py3] Supported integers in HttpResponse 
Fixed #18764.
 2012-08-19 16:38:21 +02:00
Karen Tracey
e945842042 Merge pull request #291 from uruz/ticket18793 
Fixed #18793: Removed duplicate test_head_no_get in generic_views.base

Thanks uruz.
 2012-08-18 17:12:54 -07:00
Alexey Boriskin
f29032eac6 Fixed #18793: Duplicate test test_head_no_get in generic_views.base 2012-08-19 01:04:08 +04:00
Andrew Godwin
5b09fc8ad2 Merge pull request #288 from mjtamlyn/date-list-period 
Fixed #3542 -- Add support for changing granularity on ArchiveView.
 2012-08-18 09:10:52 -07:00
Marc Tamlyn
8d5c11caad Fixed #3542 -- Add support for changing granularity on ArchiveView. 
Resolving the concept from a very old ticket in a more class-based-view
manner.
 2012-08-18 17:03:57 +01:00
Aymeric Augustin
afc1bd7ab8 [py3] Made 212b9826bd Python 3-friendly 2012-08-18 17:51:16 +02:00
Marc Tamlyn
f04bb6d798 Fixed #17228 -- params context variable is inconsistent 
Remove the params variable from the context and just put the variables
in directly.

This had not been committed previously as the original pattern was used
in the functional generic views and we wanted consistency between them,
but django.views.generic.simple.direct_to_template is now gone so we can
do it 'right'.
 2012-08-18 15:07:21 +01:00
Marc Tamlyn
212b9826bd Fixed #14516 -- Extract methods from removetags and slugify template filters 
Patch by @jphalip updated to apply, documentation and release notes
added.

I've documented strip_tags as well as remove_tags as the difference
between the two wouldn't be immediately obvious.
 2012-08-18 15:07:21 +01:00
Marc Tamlyn
58683e9c82 Fixed #16744 -- Class based view should have the view object in the context 
Updated the most recent patch from @claudep to apply again and updated
the documentation location.
 2012-08-18 15:07:21 +01:00
Aymeric Augustin
547b181046 [py3] Ported django.utils.safestring. 
Backwards compatibility aliases were created under Python 2.
 2012-08-18 16:04:06 +02:00
Andrew Godwin
d3d1e59921 Add a SQlite backend. One test passes! 2012-08-18 14:16:52 +01:00
Andrew Godwin
0b01395108 Test that unique constraints get ported with column rename 2012-08-18 14:00:42 +01:00
Andrew Godwin
f7955c703d All tests passing on MySQL 2012-08-18 13:48:54 +01:00
Andrew Godwin
cab044c66c First stab at MySQL support 2012-08-18 12:29:31 +01:00
Marc Tamlyn
bfa9fc69bf Fixed #18779 -- URLValidator can't validate url with ipv6. 
Validation is reasonably 'soft', as for the ipv4. False positives don't
matter too much here.
 2012-08-18 12:08:44 +01:00
Aymeric Augustin
85e7a5e140 [py3] Stopped attempting to translate bytes. 
That goes actively against the goal of cleaning string handling.
 2012-08-18 11:36:09 +02:00
Aymeric Augustin
c03cf0b096 Cleaned up a test slightly. 
We should catch all exceptions in the thread to ensure it doesn't die
with an unhandled exception. The type of the exception is already
checked further in the test.
 2012-08-18 11:02:28 +02:00
Aymeric Augustin
6cb76cb140 [py3] Fixed templates tests. 2012-08-18 10:18:24 +02:00
Aymeric Augustin
ad11dbf670 [py3] Fixed __unicode__ methods missed in d4a0b278 
due to non-standard syntax (a stray comma). Thanks dmishe for the report.
 2012-08-17 14:11:23 +02:00
Alex Gaynor
37a894b48c [py3k] Fixed pagination_regress tests. 2012-08-16 10:54:45 -04:00
Aymeric Augustin
fcc8de0598 [py3] Ported django.core.servers. 2012-08-16 13:01:16 +02:00
Aymeric Augustin
8c356acf2e [py3] Fixed test_utils tests of doctests. 2012-08-16 10:26:18 +02:00
Aymeric Augustin
e98cb05edf [py3] Fixed the str tests. 
These tests don't look very meaningful. They were ported from
doctests...
 2012-08-16 09:44:42 +02:00
Alex Gaynor
befa1dd7a5 Fixed the generic_inline_admin tests for python3. 2012-08-15 23:12:08 -04:00
Alex Gaynor
0c257f5a23 Fixed the admin_changelist tests for python3. 2012-08-15 23:09:01 -04:00
Claude Paroz
24de85c419 [py3] Fixed more encoding issues in cache tests 2012-08-15 22:48:09 +02:00
Claude Paroz
37e05357cd Used settings config for memcached tests. 
By using settings config, we take advantage of custom settings like
KEY_PREFIX which allows for example to run tests in parallel.
 2012-08-15 22:48:09 +02:00
Aymeric Augustin
f7c2e82d76 [py3] Fixed middleware tests. 
Removed several inappropriate .encode('utf-8') calls in the process.
 2012-08-15 22:42:18 +02:00
Claude Paroz
60f5e10230 [py3] Fixed dispatch tests 2012-08-15 18:19:21 +02:00
Claude Paroz
27192564c3 Run memcache tests if any cache is configured 2012-08-15 18:07:03 +02:00
Claude Paroz
a9facb455f [py3] Fix some more encoding issues in tests 2012-08-15 17:41:38 +02:00
Claude Paroz
607665a396 [py3] Fixed bad unicode test 2012-08-15 16:40:12 +02:00
Florian Apolloner
0ab570217a [py3] Fixed paginator tests. 2012-08-15 14:58:43 +02:00
Florian Apolloner
c1584890b1 [py3] Properly encode hashlib.md5 and zip.compress args in the tests. 2012-08-15 14:29:40 +02:00
Anssi Kääriäinen
5d01f3caea [py3] Removed map() calls used for side-effects only 2012-08-15 13:23:41 +03:00
Alex Gaynor
814fde32d9 Made the validation tests python3 friendly. 2012-08-15 03:02:32 -07:00
Alex Gaynor
ea1e8b38b3 Ensured that the archive module consistantly explicitly closed all files. 2012-08-15 02:53:40 -07:00
Alex Gaynor
ca6015ca71 Close files in the module_loading tests always. 2012-08-15 02:47:02 -07:00
Alex Gaynor
fc99f127d8 Explicitly close a file during the email tests. 2012-08-15 02:16:28 -07:00
Alex Gaynor
dfbcbf2124 Always close files in the file_storage tests. 2012-08-15 02:05:03 -07:00
Claude Paroz
e0d67f3440 [py3] Fixed test_client_regress tests 2012-08-15 10:58:26 +02:00
Alex Gaynor
cca01c96d1 Converted the modeladmin tests to run on python 2 and 3. 2012-08-15 01:46:31 -07:00
Alex Gaynor
54afdbf378 Fixed usage of several deprecated aliases in unittest. 2012-08-15 01:38:04 -07:00
Alex Gaynor
2048bbee8c Explicitly close files in the staticfiles tests. 2012-08-15 01:25:01 -07:00
Alex Gaynor
c7734491f8 Use a name that exists in both python2 and 3, 2012-08-15 01:13:09 -07:00
Aymeric Augustin
e0ec7507ac [py3] Fixed jsi18n test. 
Also refactored said test to avoid leaking state (ie. active
translation) when an error occurs.
 2012-08-15 09:45:28 +02:00
Aymeric Augustin
478a69314e [py3] Fixed uses of __metaclass__ in tests. 2012-08-15 00:31:29 +02:00
Chris Lawlor
450c0df653 [py3] Fixed modeltests.model_forms tests. 2012-08-14 23:46:23 +02:00
Claude Paroz
928baee747 [py3] Fixed conditional_processing tests 2012-08-14 23:35:12 +02:00
Claude Paroz
0120985095 [py3] Fixed file_uploads tests 2012-08-14 23:35:12 +02:00
Florian Apolloner
367bfaa522 Don't swallow AttributeError in core.urlresolvers.get_callable. 2012-08-14 21:23:25 +02:00
Claude Paroz
f2fe7a3e36 [py3] Fixed serializers tests 2012-08-14 19:54:53 +02:00
Claude Paroz
7d48e077b5 [py3] Fixed staticfiles tests 2012-08-14 17:24:31 +02:00
Claude Paroz
c2d59e5564 [py3] Fixed admin_views tests 
Also changed several occurrences of 'request' to 'response'.
 2012-08-14 14:45:28 +02:00
Aymeric Augustin
d6b8b125fb [py3] Fixed admin_custom_urls tests. 2012-08-14 14:38:23 +02:00
Anssi Kääriäinen
5b27e6f64b [py3] Fixed comparison of list and range() 
A test compared list directly against a range(). This is py3
incompatible. Fixed by using list(range()).
 2012-08-14 15:28:55 +03:00
Anssi Kääriäinen
8fe03865f7 [py3] Fixed invalid use of dict.items() 
An ordering test had two problems related to dict.items() usage:
  - It assumed the order of the dict was non-randomized
  - It indexed to the dict.items() which is py3 incompatible.

I fixed the test by using dict['rank'] directly, where rank is the
column tested on the values queryset.
 2012-08-14 15:24:43 +03:00
Aymeric Augustin
dcf72835e3 [py3] Ensured the template tests run. 2012-08-14 12:29:53 +02:00
Aymeric Augustin
faf570df18 [py3] Compared response.content with bytes. 2012-08-14 12:29:53 +02:00
Aymeric Augustin
e04230e2e4 [py3] Ported django.http according to PEP 3333. 
Perfomed some style cleanup while I was in the area.
 2012-08-14 10:32:16 +02:00
Claude Paroz
45baaabafb [py3] Fixed encoding issues in cache key generation 2012-08-13 12:56:59 +02:00
Claude Paroz
d774ad752d [py3] Made csrf context processor return Unicode 2012-08-13 11:54:21 +02:00
Claude Paroz
73f0f18c8f [py3] Fixed admin_scripts tests 2012-08-13 10:58:21 +02:00
Claude Paroz
6d68022a27 [py3] Removed filename encoding in file_uploads test 2012-08-13 09:56:14 +02:00
Andrei Antoukh
99321e30ce Fixed #18306 -- Made deferred models issue update_fields on save 
Deferred models now automatically update only the fields which are
loaded from the db (with .only() or .defer()). In addition, any field
set manually after the load is updated on save.
 2012-08-12 22:39:27 +03:00
Anssi Kääriäinen
59a655988e Fixed #13844 -- Avoid converting unknown db values to float 
This patch removes an unconditional float(value) conversion from db
backend default convert_values() method. This can cause problems when
aggregating over character fields for example. In addition, Oracle
and SQLite already return the bare value from their convert_values().

In the long term the converting should be done by fields, and the
fields should then call database backend specific converters when
needed. The current setup is inflexible for 3rd party fields.

Thanks to Merlijn van Deen for the original patch.
 2012-08-12 21:52:52 +03:00
Karen Tracey
49bb72c403 [py3] Made exception examination py3-compatible. 2012-08-12 12:08:58 -04:00
Aymeric Augustin
d4a0b27838 [py3] Refactored __unicode__ to __str__. 
* Renamed the __unicode__ methods
* Applied the python_2_unicode_compatible decorator
* Removed the StrAndUnicode mix-in that is superseded by
  python_2_unicode_compatible
* Kept the __unicode__ methods in classes that specifically
  test it under Python 2
 2012-08-12 14:44:40 +02:00
Aymeric Augustin
e7e08fd48b [py3] Replaced some __str__ methods by __unicode__ 
These methods actually return unicode.
 2012-08-12 14:44:40 +02:00
Aymeric Augustin
2bb2eecb63 [py3] Removed redundant __str__ methods. 
These classes already have an identical __unicode__ method, which
will be used after an upcoming refactoring.
 2012-08-12 14:44:40 +02:00
Karen Tracey
759ae3c2da Fixed #18739 -- witdthratio behavior on None args 
Made behavior given None consistent with how non-numerics were handled.
Thanks to ja.geb@me.com for the report.
 2012-08-11 19:24:18 -04:00
Karen Tracey
be7f1099c6 Decorated some tests that require tz support. 
This allows the test suite to run without errors on Windows.
 2012-08-11 17:32:24 -04:00
Claude Paroz
6602103338 [py3] Various minor syntax fixes in the test suite 2012-08-11 23:23:31 +02:00
Claude Paroz
3eb28d0119 [py3] Used six.StringIO to simulate stdout buffer in tests 2012-08-11 18:56:14 +02:00
Claude Paroz
97fe70d30b [py3] Used BytesIO to test request streams 2012-08-11 11:11:20 +02:00
Claude Paroz
92b2dec918 [py3] Made signing infrastructure pass tests with Python 3 2012-08-10 18:07:46 +02:00
Andrew Godwin
60873ea2ad Add db_table and db_tablespace handling 2012-08-10 15:03:18 +01:00
Andrew Godwin
184cf9ab79 Merge branch 'master' into schema-alteration 2012-08-10 12:40:37 +01:00
Andrew Godwin
c4b2a3262c Add support for unique_together 2012-08-10 12:38:18 +01:00
Claude Paroz
751774c29f [py3] Fixed mail tests with Python 3 2012-08-09 20:13:29 +02:00
Claude Paroz
96a6912ec5 [py3] Fixed compilemessages tests 2012-08-08 23:40:20 +02:00
Alex Gaynor
0955d16a16 Switched to using the standard method for comparing querysets in teh templates. 2012-08-08 07:50:59 -07:00
Aymeric Augustin
396357741b [py3] Used compatible imports of StringIO. 2012-08-08 14:50:01 +02:00
Alex Gaynor
46cc530fad Fix a test that relied on an exception outliving the except block, which doesn't happen on py3k. 2012-08-07 07:22:25 -07:00
Aymeric Augustin
fe8484efda [py3] Ported django.utils.functional. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
02e6b6409b [py3] Ported django.utils.decorators. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
127b461b11 [py3] Ported django.utils.crypto. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
b55e07771f [py3] Ported django.utils.baseconv. 2012-08-07 12:00:23 +02:00
Aymeric Augustin
c5ef65bcf3 [py3] Ported django.utils.encoding. 
* Renamed smart_unicode to smart_text (but kept the old name under
  Python 2 for backwards compatibility).
* Renamed smart_str to smart_bytes.
* Re-introduced smart_str as an alias for smart_text under Python 3
  and smart_bytes under Python 2 (which is backwards compatible).
  Thus smart_str always returns a str objects.
* Used the new smart_str in a few places where both Python 2 and 3
  want a str.
 2012-08-07 12:00:22 +02:00
Aymeric Augustin
ee191715ea [py3] Fixed access to dict keys/values/items. 2012-08-07 12:00:22 +02:00
Brendan MacDonell
ad237fb72f Fixed #18724 -- Fixed IntegerField validation with value 0 2012-08-06 10:42:21 +02:00
Claude Paroz
121fd109de Fixed #5524 -- Do not remove cleaned_data when a form fails validation 
cleaned_data is no longer deleted when form validation fails but only
contains the data that did validate.
Thanks to the various contributors to this patch (see ticket).
 2012-08-04 14:22:23 +02:00
Simon Meers
10f979fd92 Fixed #18700 -- Added URL reversal for i18n set_language view. 2012-08-04 20:57:12 +10:00
Aymeric Augustin
d01eaf7104 [py3] Removed uses of sys.maxint under Python 3. 
Also fixed #18706: improved exceptions raised by int_to_base36.
 2012-08-03 18:51:28 +02:00
Andrew Godwin
b139315f1c Add M2M tests and some unique support 2012-08-02 15:08:39 +01:00
Florian Apolloner
4129201c3e Fixed a security issue in http redirects. Disclosure and new release forthcoming. 2012-07-30 22:01:50 +02:00
Andrew Godwin
4a2e80fff4 Merge branch 'master' of github.com:django/django into schema-alteration 
Conflicts:
	django/db/backends/postgresql_psycopg2/base.py
 2012-07-26 18:58:10 +01:00
Aymeric Augustin
ab6cd1c839 [py3] Updated dict-like data structures for Python 3. 
The keys/items/values methods return iterators in Python 3, and the
iterkeys/items/values methods don't exist in Python 3. The behavior
under Python 2 is unchanged.
 2012-07-25 22:58:48 +02:00
Marc Tamlyn
a875f612e0 Fixed #18634 -- Don't escape variables in the context for startproject/startapp. 
The & symbols which can come up in the secret key were
being escaped to &amp;.
 2012-07-25 22:24:41 +02:00
Florian Apolloner
59d99772f0 Merge pull request #216 from ljosa/ticket_18644 
Fixed #18644 -- Made urlize trim trailing period followed by parenthesis
 2012-07-25 13:22:49 -07:00
Florian Apolloner
82292141a0 Made staticfiles tests independent of test execution order. 2012-07-25 10:00:23 +02:00
Ramiro Morales
f758bdab5e Fixed #18271 -- Changed stage at which TransactionTestCase flushes DB tables. 
Previously, the flush was done before the test case execution and now
it is performed after it.

Other changes to the testing infrastructure include:

* TransactionTestCase now doesn't reset autoincrement sequences either
  (previous behavior can achieved by using `reset_sequences`.)
  With this, no implicit such reset is performed by any of the provided
  TestCase classes.

* New ordering of test cases: All unittest tes cases are run first and
  doctests are run at the end.

THse changes could be backward-incompatible with test cases that relied
on some kind of state being preserved between tests. Please read the
relevant sections of the release notes and testing documentation for
further details.

Thanks Andreas Pelme for the initial patch. Karen Tracey and Anssi
Kääriäinen for the feedback and Anssi for reviewing.

This also fixes #12408.
 2012-07-24 17:24:16 -03:00
Alex Gaynor
38ce709fe4 Added tests for deprecation warnings and fixed the argument order for the warnings. 2012-07-24 07:01:57 -07:00
Aymeric Augustin
a84d79f572 [py3] Added Python 3 compatibility for xrange. 2012-07-22 09:29:56 +02:00
Aymeric Augustin
0d914d08a0 [py3] Updated urllib/urllib2/urlparse imports. 
Lots of functions were moved. Use explicit imports in all cases
to keey it easy to identify where the functions come from.
 2012-07-22 09:29:55 +02:00
Aymeric Augustin
bdca5ea345 [py3] Replaced unicode/str by six.text_type/bytes. 2012-07-22 09:29:54 +02:00