Hopiu/django
1
0
Fork 0
mirror of https://github.com/Hopiu/django.git synced 2026-04-03 14:50:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
22363 commits 1 branch 0 tags 216 MiB
Commit graph

7671 commits

Author SHA1 Message Date
Preston Timmons
388e79e9fc Fixed #24493 -- Added BaseContext.setdefault() 2015-03-16 13:13:02 -04:00
Joeri Bekker
0ed20d5cc4 Fixed #23926 -- Improved validation error for custom permissions that are too long. 2015-03-16 12:13:49 -04:00
Thomas Tanner
28986da4ca Fixed #5986 -- Added ability to customize order of Form fields 2015-03-16 09:12:57 -04:00
Tomáš Ehrlich
8414fcf16b Fixes #23643 -- Added chained exception details to debug view. 2015-03-14 16:08:23 -04:00
Matthew Wilkes
ae87ad005f Refs #24354 -- Prevented repointing of relations on superclasses when migrating a subclass's name change 
Forwardport of test and release note from stable/1.7.x
 2015-03-14 15:37:40 -04:00
Berker Peksag
34fb909180 Fixed #12982 -- Added a get_or_set() method to the BaseCache backend. 2015-03-14 20:07:16 +02:00
medmunds
5993b52e6d Fixed #24416 -- Added support for lazy email addresses. 2015-03-13 12:33:49 -04:00
Claude Paroz
aa5ab114e3 Fixed #24122 -- Redirected to translated url after setting language 
Thanks gbdlin for the initial patch and Tim Graham for the review.
 2015-03-13 16:46:40 +01:00
Jon Dufresne
d861f95c44 Fixed #24139 -- Changed HttpResponse.reason_phrase to evaluate based on status_code. 2015-03-12 20:18:06 -04:00
Bas Peschier
a23ea398e8 Cleaned up urlpatterns_reverse tests. 2015-03-12 19:13:48 -04:00
Bas Peschier
c9f1a12925 Fixed #24013 -- Fixed escaping of reverse() prefix. 
Prefix was treated as a part of the url pattern, which it is not.
Improved tests to conform with RFC 3986 which allows certain
characters in path segments without being escaped.
 2015-03-12 19:05:17 -04:00
Tim Graham
e4a578e70e Fixed #24226 -- Changed admin EMPTY_CHANGELIST_VALUE from (None) to - 2015-03-12 09:40:56 -04:00
Bas Peschier
f0f5212624 Fixed #12943 -- Allowed unnamed arguments to be propagated in includes 
Propagated unnamed arguments as positional arguments into included
URLconfs if no named arguments are defined. Positional and keyword
arguments are never combined.
 2015-03-12 09:18:39 -04:00
Tim Graham
8a481498aa Fixed #24468 -- Made signed cookies cache backend resilient to unpickling exceptions. 2015-03-12 08:19:54 -04:00
Tim Graham
389baccac5 Fixed staticfiles test on Windows; refs #23986. 2015-03-11 14:49:15 -04:00
Tim Graham
3ed9c7bdfe Fixed #24471 -- Enhanced urlize regex to exclude quotes and angle brackets. 2015-03-10 19:24:46 -04:00
Tim Graham
7b1a67cce5 Fixed escaping regression in urlize filter. 
Now that the URL is always unescaped as of refs #22267,
we should re-escape it before inserting it into the anchor.
 2015-03-10 18:58:34 -04:00
Bas Peschier
756cee46d2 Fixed #24455 -- Fixed crash in debug view with lazy objects 2015-03-09 20:30:01 -04:00
Claude Paroz
df193b3cef Fixed #24382 -- Allowed unicode chars inside formatted numbers 
Thanks Jacob Rief for the report and Tim Graham for the review.
 2015-03-09 18:55:28 +01:00
Baptiste Mispelon
82c9169077 Refs #24461 -- Added test/release notes for XSS issue in ModelAdmin.readonly_fields 
This issue was fixed by refs #24464.
 2015-03-09 10:12:21 -04:00
Erik Romijn
fa350e2f30 Fixed #24464 -- Made built-in HTML template filter functions escape their input by default. 
This may cause some backwards compatibility issues, but may also
resolve security issues in third party projects that fail to heed warnings
in our documentation.

Thanks Markus Holtermann for help with tests and docs.
 2015-03-09 09:29:58 -04:00
Anssi Kääriäinen
fb146193c4 Fixed #24171 -- Fixed failure with complex aggregate query and expressions 
The query used a construct of qs.annotate().values().aggregate() where
the first annotate used an F-object reference and the values() and
aggregate() calls referenced that F-object.

Also made sure the inner query's select clause is as simple as possible,
and made sure .values().distinct().aggreate() works correctly.
 2015-03-09 07:49:23 -04:00
Marten Kenbeek
e272904ff7 Fixed #23407 -- Extended coverage of makemigrations --noinput option. 
Changed --noinput option in makemigrations to suppress all user prompts,
not just when combined with --merge.
 2015-03-08 19:44:14 +01:00
Bas Peschier
336512fae7 Fixed #23173 -- Fixed incorrect stripping of SCRIPT_URL 2015-03-08 15:48:27 +01:00
Rik
a5b225084f Fixed #23838 -- added missing __iter__ to LazyObject 2015-03-08 15:42:23 +01:00
Sztrovacsek
87d78241a2 Fixed #23986 -- Fixed collectstatic --clear failure if STATIC_ROOT dir doesn't exist. 2015-03-07 10:47:07 -05:00
Aymeric Augustin
90b069c33f Prevented some tests from writing in the CWD. 2015-03-07 15:56:15 +01:00
Jean-Louis Fuchs
f4f0060fea Fixed #24447 -- Made migrations add FK constraints for existing columns 
When altering from e.g. an IntegerField to a ForeignKey, Django didn't
add a constraint.
 2015-03-07 14:09:56 +01:00
Tim Graham
c36b60836b Fixed #24451 -- Deprecated comma-separated {% cycle %} syntax. 2015-03-07 07:42:39 -05:00
david
88c605e3e3 Fixed #23993 -- Added form.media to the admin login template. 2015-03-07 12:59:58 +01:00
Claude Paroz
ec808e807a Fixed urlize regression with entities in query strings 
Refs #22267.
Thanks Shai Berger for spotting the issue and Tim Graham for the
initial patch.
 2015-03-06 22:20:14 +01:00
Josh Smeaton
ceaf31adff Fixed #24420 -- Allowed ordering by case expressions 2015-03-06 13:30:02 +11:00
Tim Graham
82f7bee1d5 Fixed admin selenium tests broken by removal of fixtures. 2015-03-05 17:51:17 -05:00
Grzegorz Slusarek
668d53cd12 Fixed #21495 -- Added settings.CSRF_HEADER_NAME 2015-03-05 15:03:40 -05:00
Preston Timmons
fb7d681705 Fixed test_notafile_error to pass on Windows. 
This test failed because a different error code is raised on Windows when
opening a directory. Since the particular message isn't as important to this
test as the fact that the original IOError is reraised, this fixes the test
by making the assertion more generic.
 2015-03-05 12:14:19 -05:00
Tim Graham
d61ebc8fed Fixed #19538 -- Removed window.__admin_media_prefix__ from admin templates. 2015-03-05 06:44:16 -05:00
Claude Paroz
b4a1bb8669 Updated test to be date-independent 
Fixes commit 8714403614.
 2015-03-05 10:08:39 +01:00
Claude Paroz
8714403614 Fixed #24428 -- Fixed has_changed for fields with coercion 
Thanks Carsten Fuchs for the report.
 2015-03-05 09:00:13 +01:00
Josh Smeaton
39a7eed1bb Converted test fixtures to setUpTestData methods 2015-03-05 10:10:32 +11:00
Tim Graham
36a17be9f3 Fixed #24426 -- Displayed admin actions panel when show_full_result_count=False. 2015-03-04 12:00:12 -05:00
Markus Holtermann
a9e29fae10 Fixed #24435 -- Prevented m2m field removal and addition in migrations when changing blank 
Thanks Mark Tranchant for the report an Tim Graham for the test and
review.
 2015-03-04 14:26:49 +01:00
Preston Timmons
70123cf084 Fixed #24399 -- Made filesystem loaders use more specific exceptions. 2015-03-03 21:20:46 +01:00
Preston Timmons
358850781f Fixed #24372 - Replaced TokenParser usage with traditional parsing. 2015-03-02 18:25:28 -05:00
Shai Berger
8ca35d7c6a Fixed Oracle build failure introduced by refs #24390. 
Used shorter column names to make the generated index name
fit within Oracle's limit of 30 characters
 2015-03-03 00:01:21 +02:00
Andrei Kulakov
08572e8d12 Fixed #24294 -- Allowed staff_member_required decorator to handle args. 2015-03-02 13:15:34 -05:00
Tim Graham
4e8b167e4d Fixed MySQL build failure introduced by refs #24390. 
Added table_name back to _create_index_sql() to prevent
duplicate index names on MySQL.
 2015-03-02 13:07:34 -05:00
László Károlyi
f37c11eea3 Fixed #24390 -- Made migration index names deterministic. 2015-03-02 09:25:19 -05:00
Preston Timmons
80d6b6b863 Fixed #24409 -- Combined the app_directories and filesystem loader implementation. 
Besides the directories they look in, these two loaders are functionally
the same. This removes unnecessary code duplication between the two.
 2015-03-02 07:53:58 -05:00
Claude Paroz
4b8979e477 Fixed #17401 -- Made SelectDateWidget.render reflect wrong value 
Thanks Marcin Wrobel for the initial patch.
 2015-03-01 21:37:52 +01:00
Claude Paroz
3cf1c02695 Fixed #24413 -- Prevented translation fallback for English 
Thanks Tomasz Kontusz for the report, Baptiste Mispelon for
analysis and Tim Graham for the review.
 2015-02-28 10:07:12 +01:00
Claude Paroz
5cf96b49e4 Fixed #24418 -- Prevented crash in refresh_from_db with null fk 
Thanks Johannes Lerch for the report, Tim Graham for the test case,
and Simon Charette for the review.
 2015-02-27 20:23:07 +01:00
Claude Paroz
8a9f39d2b3 Removed binary input test line 
That line was inconveniently introduced by the committer (me) in
3b966c2b73. Sorry!
 2015-02-27 15:44:06 +01:00
Jon Dufresne
3b966c2b73 Fixed #24229 -- Changed IntegerField to clean floats representing integers 2015-02-27 12:23:21 +01:00
Michael Angeletti
65441bbdb0 Fixed #24391 -- Made BoundField.value() cache callable values. 2015-02-24 19:50:55 -05:00
Stanislas Guerra
4c2f546b55 Fixed #24395 -- Ensured inline ModelsForms have an updated related instance. 2015-02-24 11:49:00 -05:00
Preston Timmons
8e129b42ad Cleaned up template directory handling in template tests. 2015-02-24 14:00:03 +01:00
Preston Timmons
32c108a221 Combined TemplateTests and TemplateRegressionTests. 2015-02-24 14:00:03 +01:00
Preston Timmons
25a0b5cdcd Moved test_token_smart_split into ParserTests. 2015-02-24 14:00:03 +01:00
Preston Timmons
3d8fee6051 Moved ifchanged tests into syntax_tests/test_if_changed.py. 2015-02-24 14:00:02 +01:00
Preston Timmons
f6d087b628 Moved cache tests into syntax_tests/test_cache.py. 2015-02-24 14:00:02 +01:00
Preston Timmons
250a3d1993 Moved RequestContextTests into test_context. 2015-02-24 14:00:02 +01:00
Preston Timmons
ff67ce5076 Moved TemplateTagLoading cases into test_custom. 2015-02-24 14:00:02 +01:00
Preston Timmons
06ffc764a9 Moved include tests into syntax_tests/test_include.py. 2015-02-24 14:00:02 +01:00
Preston Timmons
441a47e1ef Moved ssi tests into syntax_tests/test_ssi.py. 2015-02-24 14:00:02 +01:00
Preston Timmons
1827aa9024 Cleaned up template loader tests. 2015-02-24 14:00:02 +01:00
Nik Nyby
2be6b52656 Fixed typos in flatpages_tests comments. 2015-02-24 06:30:33 -05:00
Aymeric Augustin
903d1a57ab Made migrations tests write to a temporary directory. 
This is preferrable to writing in the current working directory because
it eliminates the risk to leak unwanted files, which can result in very
weird test failures.

Also this will help if we ever try to run these tests concurrently.
 2015-02-23 22:22:58 +01:00
Aymeric Augustin
952ce778c6 Fixed a test failure under Windows and Python 2. 2015-02-23 18:36:15 +01:00
Aymeric Augustin
a8fe12417f Normalized usage of the tempfile module. 
Specifically stopped using the dir argument.
 2015-02-23 16:55:27 +01:00
Aymeric Augustin
934400759d Guaranteed removal of temporary files during tests. 
Dropped the DJANGO_TEST_TEMP_DIR environment variable.

Before this change, proper removal depended on the developer passing
dir=os.environ['DJANGO_TEST_TMP_DIR'] to tempfile functions.
 2015-02-23 16:55:26 +01:00
Tim Graham
1306cd1e8a Fixed #24377 -- Fixed model inline formsets with primary key's that have defaults. 2015-02-23 08:44:27 -05:00
Anssi Kääriäinen
f95122e541 Fixed #24381 -- removed ForeignObjectRel opts and to_opts 
These cached properies were causing problems with pickling, and in
addition they were confusingly defined: field.rel.model._meta was
not the same as field.rel.opts.

Instead users should use field.rel.related_model._meta inplace of
field.rel.opts, and field.rel.to._meta in place of field.rel.to_opts.
 2015-02-23 07:24:43 -05:00
Marten Kenbeek
78d43a5e10 Fixed #24366 -- Optimized traversal of large migration dependency graphs. 
Switched from an adjancency list and uncached, iterative depth-first
search to a Node-based design with direct parent/child links and a
cached, recursive depth-first search. With this change, calculating
a migration plan for a large graph takes several seconds instead of
several hours.

Marked test `migrations.test_graph.GraphTests.test_dfs` as an expected
failure due to reaching the maximum recursion depth.
 2015-02-23 12:38:53 +01:00
Aymeric Augustin
c688460df6 Removed rmtree_errorhandler. 
The stated reason for its introduction in d18d37ce no longer applies
since Django's code repository was switched from Subversion to git.

Furthermore it never had any effect because shutil.rmtree ignores its
onerror argument when ignore_errors is True.

The reason for its use in template management commands is unclear.
 2015-02-22 23:09:42 +01:00
Aymeric Augustin
88a5f17d25 Fixed #24389 -- Isolated the CSRF view from the TEMPLATES setting. 
Thanks uranusjr for the report and analysis.
 2015-02-22 15:46:35 +01:00
Michael Angeletti
ea3168dc6c Fixed #24376 -- added verbose_name arg to UUIDField 2015-02-21 13:27:49 -05:00
Aymeric Augustin
787dd6519a Removed obsolete reference to media directory. 2015-02-21 17:52:24 +01:00
Aymeric Augustin
bd059e3f8c Removed workaround for SVN limitations. 
In addition to simplifying the code, this reduces the number of writes.
 2015-02-21 17:52:24 +01:00
Aymeric Augustin
2bb5b0e098 Avoided collecting admin static files in tests. 
This makes the staticfiles tests 2.5 times faster.
 2015-02-21 17:46:26 +01:00
Aymeric Augustin
1d9d39fa1c Removed TestServeAdminMedia. 
It should have been removed when the ADMIN_MEDIA_PREFIX setting was deprecated.
 2015-02-21 17:46:26 +01:00
Loic Bistuer
fa5f936b48 Fixed allow_migrate signature in one of the tests. 
Refs #24351.
 2015-02-21 23:13:14 +07:00
foresmac
1d1d5d1c31 Fixed #24341 -- Added specific error messages to RangeField subclasses 2015-02-20 16:49:15 -05:00
Anssi Kääriäinen
bad5f262bf Fixed #24328 -- cleaned up Options._get_fields() implementation 2015-02-20 13:00:12 -05:00
Loic Bistuer
bed504d70b Fixed #24351, #24346 -- Changed the signature of allow_migrate(). 
The new signature enables better support for routing RunPython and
RunSQL operations, especially w.r.t. reusable and third-party apps.

This commit also takes advantage of the deprecation cycle for the old
signature to remove the backward incompatibility introduced in #22583;
RunPython and RunSQL won't call allow_migrate() when when the router
has the old signature.

Thanks Aymeric Augustin and Tim Graham for helping shape up the patch.

Refs 22583.
 2015-02-20 21:34:09 +07:00
Marc Tamlyn
c490e410af Fixed #24373 -- Added run_validators to ArrayField. 
Thanks to DavidMuller for the report.
 2015-02-20 11:51:46 +00:00
Marc Tamlyn
32d4db66b9 Update converters to take a consistent set of parameters. 
As suggested by Anssi. This has the slightly strange side effect of
passing the expression to Expression.convert_value has the expression
passed back to it, but it allows more complex patterns of expressions.
 2015-02-20 11:35:52 +00:00
Marc Tamlyn
4755f8fc25 Fixed #24343 -- Ensure db converters are used for foreign keys. 
Joint effort between myself, Josh, Anssi and Shai.
 2015-02-20 11:35:51 +00:00
Tim Graham
c8074d62f8 Fixed typo in error message in the test. 2015-02-19 19:36:20 -05:00
Aymeric Augustin
1bfcc950ab Set context.template instead of context.engine while rendering. 
This opens more possibilities, like accessing context.template.origin.

It also follows the chain of objects instead of following a shortcut.
 2015-02-19 22:08:11 +01:00
Claude Paroz
efb1f99f94 Fixed #20889 -- Prevented BadHeaderError when Python inserts newline 
Workaround for http://bugs.python.org/issue20747.
In some corner cases, Python 2 inserts a newline in a header value
despite `maxlinelen` passed in Header constructor.
Thanks Tim Graham for the review.
 2015-02-19 20:18:31 +01:00
Shai Berger
ceadc94f09 Fixed #24307: Avoided redundant column nullability modifications on Oracle 
Thanks Joris Benschop for the report, and Tim Graham for the tests.
 2015-02-19 02:39:41 +02:00
Shai Berger
f7d34fe741 Fixed #24362: Made test run each migration operation in its own schema editor 
Thanks Tim Graham for pointing out the fix.
 2015-02-18 22:47:15 +02:00
Marten Kenbeek
15dc8d1c9d Fixed #24291 - Fixed migration ModelState generation with unused swappable models 
Swapped out models don't have a _default_manager unless they have
explicitly defined managers. ModelState.from_model() now accounts for
this case and uses an empty list for managers if no explicit managers
are defined and a model is swapped out.
 2015-02-18 19:05:10 +01:00
Tim Graham
b8d6cdbcc9 Refs #24324 -- Skipped fixtures_regress tests that fail on Python 2 on a non-ASCII path. 2015-02-18 07:25:36 -05:00
Tim Graham
307c0f299a Refs #24324 -- Fixed Python 2 test failures when path to Django source contains non-ASCII characters. 2015-02-17 19:03:03 -05:00
Tim Graham
ad50b6c853 Fixed "environment can only contain strings" in model_regress test on Windows. 2015-02-17 13:54:18 -05:00
Tim Graham
d316b43d0a Refs #24324 -- Fixed UnicodeDecodeError in model_regress test on non-ASCII path. 2015-02-17 07:32:48 -05:00
Tim Graham
8b39f33d78 Fixed #24290 -- Skipped postgres_tests if not running with PostgreSQL. 2015-02-17 06:34:13 -05:00
Tim Graham
3adc5f1ee6 Fixed #24335 -- Bumped required psycopg2 version to 2.4.5 (2.5 for contrib.postgres). 2015-02-16 18:07:27 -05:00
Tim Graham
664c038f2c Moved contrib.contenttypes tests out of contrib. 2015-02-16 17:45:38 -05:00
Markus Holtermann
d538e37e1b Added tests for get_related_models_recursive 2015-02-16 19:31:52 +01:00
Markus Holtermann
273bc4b667 Refs #24282 -- Added failing test case for assigning models of wrong type to FK 
Thanks Jeff Singer for the test case.
 2015-02-16 19:31:51 +01:00
Markus Holtermann
cc22b009e0 Refs #24264 -- Added failing test case for updating a FK when changing a PK 
When the primary key column is altered, foreign keys of referencing
models must be aware of a possible data type change as well and thus
need to be re-rendered.

Thanks Tim Graham for the report.
 2015-02-16 19:31:51 +01:00
Claude Paroz
58d0dd9260 Refs #24225 -- Added failing test case for removing a previously added field in migrations 
When a related field is deleted, the related model must be updated. As
unchanged models are shared in migration states, the related model must
be re-rendered so that the change applies to a new copy of the related
model.

Thanks Henrik Heimbuerger for the report.
 2015-02-16 19:31:51 +01:00
Marten Kenbeek
f668bac9d2 Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs #11505 2015-02-16 08:42:43 -05:00
Loic Bistuer
c5a77721e2 Merged ManyRelatedObjectsDescriptor and ReverseManyRelatedObjectsDescriptor 
and made all "many" related objects descriptors inherit from
ForeignRelatedObjectsDescriptor.
 2015-02-16 20:40:04 +07:00
Aymeric Augustin
15b711b5ee Deprecated TEMPLATE_DEBUG setting. 2015-02-15 20:47:04 +01:00
Tim Graham
e0b3926026 Isolated auth_tests from contenttypes_tests; refs #11505. 2015-02-14 22:04:48 -05:00
Michael Angeletti
49647bec6e Added missing return value to DurationField.prepare_value(); refs #24339. 2015-02-14 18:38:50 -05:00
Aymeric Augustin
76356d963c Fixed #24318 -- Set the transaction isolation level with psycopg >= 2.4.2. 2015-02-14 18:51:11 +01:00
Michael Angeletti
8a21d25033 Fixed #24339 -- Fixed crash with empty DurationField form field. 2015-02-14 07:37:18 -05:00
Claude Paroz
1791a7e75a Fixed #15779 -- Allowed 'add' primary key in admin edition 
Thanks Marwan Alsabbagh for the report, and Simon Charette and
Tim Graham for the reviews.
 2015-02-14 11:19:55 +01:00
Aymeric Augustin
47ee7b48ad Fixed #24338 -- Accepted Template wrapper in {% extends %}. 
Explicitly checking for django.template.Template subclasses is
preferrable to duck-typing because both the django.template.Template and
django.template.backends.django.Template have a render() method.

Thanks spectras for the report.
 2015-02-14 10:21:06 +01:00
Loic Bistuer
18c0aaa912 Fixed #24289 -- Reversed usage of Field.many_to_one and one_to_many. 
Thanks Carl Meyer and Tim Graham for the reviews and to all involved
in the discussion.
 2015-02-14 02:28:24 +07:00
Andriy Sokolovskiy
5c995dcfc2 Fixed #24320 - Used field.value_to_string() in serialization of foreign key. 
This fixes serialization of a ForeignKey to a UUIDField as the
test indicates.
 2015-02-13 12:37:23 -05:00
Tim Graham
002425fe39 Fixed #24315 -- Fixed auth.views.password_reset_confirm() with a UUID user. 2015-02-13 09:56:31 -05:00
Tim Graham
fdf20093e0 Fixed #24334 -- Allowed admin password reset to work with non-digit custom user model primary key. 
Thanks Loic for help and Simon for review.
 2015-02-13 09:42:49 -05:00
Markus Holtermann
f287bec583 Fixed #24184 -- Prevented automatic soft-apply of migrations 
Previously Django only checked for the table name in CreateModel
operations in initial migrations and faked the migration automatically.
This led to various errors and unexpected behavior. The newly introduced
--fake-initial flag to the migrate command must be passed to get the
same behavior again. With this change Django will bail out in with a
"duplicate relation / table" error instead.

Thanks Carl Meyer and Tim Graham for the documentation update, report
and review.
 2015-02-13 14:29:59 +01:00
Markus Holtermann
b4e1090ab2 Removed explicit pointers to migration modules for contrib apps in runtest 
Thanks Tim Graham for the patch
 2015-02-13 14:29:45 +01:00
Markus Holtermann
b06935a486 Refs #22962 -- Made test case use non-conflicting table names 2015-02-13 14:01:54 +01:00
Loic Bistuer
00a889167f Fixed #24295 -- Allowed ModelForm meta to specify form field classes. 
Thanks Carl Meyer and Markus Holtermann for the reviews.
 2015-02-13 19:13:05 +07:00
Tim Graham
e8cf4f8abe Fixed #24332 -- Fixed contrib.sites create_default_site() when 'default' DATABASES is empty. 2015-02-13 07:01:28 -05:00
Josh Smeaton
bd4afef984 Refs #14030 -- Added tests for Value aggregates 2015-02-13 10:06:46 +11:00
Josh Smeaton
de0241eb98 Fixed #24319 -- Added validation for UUID model field 2015-02-13 09:45:53 +11:00
Tim Graham
d64baaef3b Fixed #24333 -- Fixed admin history view crash with non-integer slug. 2015-02-12 14:19:44 -05:00
Simon Charette
9239f1dda7 Refs #24215 -- Prevented pending lookup pollution by abstract models. 2015-02-12 13:07:09 -05:00
Tim Graham
d7509c5246 Added a test for UUIDField serialization; refs #24320. 2015-02-12 09:54:42 -05:00
Tim Graham
e4999bf671 Added missing import from last commit. 2015-02-12 08:18:10 -05:00
Tim Graham
27eeb64a96 Fixed #17716 -- Prevented include('...', app_name='...') without a namespace. 2015-02-12 08:07:58 -05:00
Tim Graham
0f7f5bc9e7 Fixed #24161 -- Stored the user primary key as a serialized value in the session. 
This allows using a UUIDField primary key along with the JSON session
serializer.

Thanks to Trac alias jamesbeith for the report and Simon Charette
for the initial patch.
 2015-02-12 07:38:16 -05:00
Lukas Klein
93b3ef9b2e Fixed #24321 -- Improved utils.http.same_origin compliance with RFC6454 2015-02-12 08:58:35 +01:00
Josh Smeaton
e2d6e14662 Refs #14030 -- Improved expression support for python values 2015-02-12 08:46:25 +11:00
Collin Anderson
07cfe1bd82 Refs #14497 -- Handled empty readonly admin FileFields 2015-02-11 13:00:56 -05:00
Tim Graham
8ec306a3a9 Moved contrib.webdesign tests out of contrib. 2015-02-11 12:30:07 -05:00
Tim Graham
7cf3a5786b Updated docs and runtests.py for removal of tests from contrib. 2015-02-11 10:29:54 -05:00
Tim Graham
ad0be620ae Moved contrib.gis tests out of contrib. 2015-02-11 10:29:54 -05:00
Tim Graham
5ab327a389 Moved non-documented auth test models to the new test location. 2015-02-11 10:29:48 -05:00
Tim Graham
2d7aca3da0 Moved contrib.auth tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
8192a164de Moved contrib.humanize tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
00da46091a Moved contrib.redirects tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
b3cd9e0d07 Moved contrib.messages tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
fac3a34cbb Moved contrib.sessions tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
fbc467c26b Moved contrib.sitemaps tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
d8341bf024 Moved contrib.sites tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
d3a725054f Moved contrib.flatpages tests out of contrib. 2015-02-11 10:19:22 -05:00
Tim Graham
197dd4b8f1 Prevented some test commands from needlessly running system checks. 
This is a performance optimization and also fixes test errors with the
upcoming merge of contrib tests into tests/. The tests failed on MySQL
because the models with GeometryField were being checked but the
non-GIS MySQL backend didn't know how to handle them.
 2015-02-11 10:14:38 -05:00
Daniel Pyrathon
19188826b4 Fixed #24146 -- Allowed model._meta.get_field() to be used after apps.models_ready 2015-02-10 19:55:06 -05:00
Aymeric Augustin
1b8af4cfa0 Disallowed importing concrete models without an application. 
Removed fragile algorithm to find which application a model belongs to.

Fixed #21680, #21719. Refs #21794.
 2015-02-10 21:41:19 +01:00
Tim Graham
c970018f41 Removed Django 1.7 MIDDLEWARE_CLASSES upgrade check. 2015-02-09 19:16:07 -05:00
Simon Charette
5b75b01939 Refactored an admin_view test case. 
Used setUpTestData, client login/logout and manager's count() method.

Thanks to Tim for the review.
 2015-02-09 15:08:05 -05:00
Simon Charette
8a590c4b7b Moved a custom admin template test to a more appropriate case. 
Thanks to Tim for the review.
 2015-02-09 15:07:49 -05:00
Claude Paroz
50aa1a790c Replaced some more hardcoded admin URLs 2015-02-09 17:29:53 +01:00
Tim Graham
2d7c27d387 Fixed #24302 -- Added DurationField.formfield() 2015-02-09 10:20:01 -05:00
Tim Graham
e144e0e237 Removed unnecessary parentheses in model check messages. 2015-02-09 08:53:58 -05:00
Aron Podrigal
4d73303ee9 Fixed #24249 -- Improved field shadowing validation in model multi-inheritance. 2015-02-09 08:37:55 -05:00
Claude Paroz
32e6a7d3a5 Replaced hardcoded URLs in admin_* tests 
Refs #15779. This will allow easier admin URL changes, when needed.
Thanks Simon Charette for the review.
 2015-02-08 20:55:09 +01:00
Tim Graham
9033003d97 Added check_apps_ready() to Apps.get_containing_app_config() 2015-02-08 14:52:19 -05:00
Varun Sharma
540ca563de Fixed #24181 -- Fixed multi-char THOUSAND_SEPARATOR insertion 
Report and original patch by Kay Cha.
 2015-02-08 20:00:57 +01:00
Claude Paroz
58afd30b59 Tested DecimalField with scientific notation 
Refs #15775.
 2015-02-06 22:30:50 +01:00
Collin Anderson
db77915c9f Fixed E265 comment style 2015-02-06 09:30:35 -05:00
Tim Graham
0ed7d15563 Sorted imports with isort; refs #23860. 2015-02-06 08:16:28 -05:00
Anssi Kääriäinen
20b74b10be Added a test for refs #24279 
This issue was fixed in afe0bb7b13.
 2015-02-06 07:43:59 -05:00
Aymeric Augustin
23a5ec0782 Added trailing comma. 
Sorry, I couldn't stand the inconsistency between the two databases anymore.
 2015-02-06 12:58:45 +01:00
Aymeric Augustin
d39073b8ae Hid Django installation message when verbosity is 0. 
This message was introduced to help people figure out quickly when they
aren't running the tests against the copy of Django they're editing.
There's no reason to display it when verbosity is set to 0. It defaults
to 1.
 2015-02-06 12:56:53 +01:00
Tim Graham
bbe28496d3 Removed old import aliases. 2015-02-05 19:37:01 -05:00
Tim Graham
0f54cf28c0 Added UUIDField.deconstruct() 2015-02-05 19:15:02 -05:00
Markus Holtermann
235124d3ea Fixed small regression caused by 0204714b0b 
Since 1.7 models need to declare an explicit app_label if they are not
in an application in INSTALLED_APPS or were imported before their
application was loaded.
 2015-02-06 00:45:07 +01:00
Markus Holtermann
0204714b0b Cleaned up schema tests 
Thanks Tim Graham for the review.
 2015-02-05 20:11:48 +01:00
Aymeric Augustin
44ad691558 Fixed #24265 -- Preserved template backend loading exceptions. 
If importing or initializing a template backend fails, attempting to
access this template backend again must raise the same exception.
 2015-02-05 20:06:18 +01:00
Aymeric Augustin
31d3a35579 Fixed #24273 -- Allowed copying RequestContext more than once. 
Thanks Collin Anderson for the report.
 2015-02-05 13:21:50 +01:00
Loic Bistuer
71ada3a8e6 Fixed #6707 -- Added RelatedManager.set() and made descriptors' __set__ use it. 
Thanks Anssi Kääriäinen, Carl Meyer, Collin Anderson, and Tim Graham for the reviews.
 2015-02-05 12:45:08 +07:00
Matthew Somerville
caa3562d5b Fixed #24242 -- Improved efficiency of utils.text.compress_sequence() 
The function no longer flushes zfile after each write as doing so can
lead to the gzipped streamed content being larger than the original
content; each flush adds a 5/6 byte type 0 block. Removing this means
buf.read() may return nothing, so only yield if that has some data.
Testing shows without the flush() the buffer is being flushed every 17k
or so and compresses the same as if it had been done as a whole string.
 2015-02-04 13:04:00 -05:00
mlavin
2730dad0d7 Fixed #24197 -- Added clearing of staticfiles caches on settings changes during tests 
Cleared caching in staticfiles_storage and get_finder when
relevant settings are changed.
 2015-02-04 10:53:04 -05:00
Preston Timmons
23c4cbc0fa Cleaned up formatting in template_tests.test_custom. 2015-02-04 09:47:24 -05:00
Anssi Kääriäinen
7145c8a62a Removed EverythingNode 
At the same time, made sure that empty nodes in where clause match
everything.
 2015-02-04 09:26:40 -05:00
Riccardo Magliocchetti
2be621e44c Fixed #14497 -- Improved admin widget for "read only" FileFields 
Based on patch by Adam J Forster, Paul Collins, and Julien.
 2015-02-04 09:05:23 -05:00
Josh Schneier
7d363ed432 Fixed typos of "select_related" in docs and tests. 2015-02-04 07:31:43 -05:00
Aron Podrigal
79f27f2b61 Fixed #15321 -- Honored ancestors unique checks. 
Thanks to Tim for the review.
 2015-02-03 18:56:53 -05:00
Tim Graham
1fc458b5a3 Removed a useless check in runtests.py 
Added in 3e97535907, this check
appears to never be triggered today.
 2015-02-03 18:32:00 -05:00
Tim Graham
c0cc8f69e7 Refactored tests that rely on an ImportError for Python 3.5 compatibility 
A change in Python test discovery [1] causes the old packages that raised
an error to be discovered; now we use a common directory that's
ignored during discovery. Refs #23763.

[1] http://bugs.python.org/issue7559
 2015-02-03 18:30:46 -05:00
Simon Charette
65e005f8cd Fixed #24266 -- Changed get_parent_list to return a list ordered by MRO. 
Thanks to Aron Podrigal for the initial patch and Tim for the review.
 2015-02-03 16:40:31 -05:00
Tim Graham
0e489c19f1 Reverted "Fixed #24146 -- Fixed a missing fields regression in admin checks." 
This reverts commit e8171daf0c.

A new solution is forthcoming.
 2015-02-03 15:23:39 -05:00
darkryder
9ec8aa5e5d Fixed #24149 -- Normalized tuple settings to lists. 2015-02-03 14:59:45 -05:00
Claude Paroz
cd0ceaa102 Fixed #24252 -- Forced lazy __str__ to utf-8 on Python 2 
Thanks Stanislas Guerra for the report and Tomas Ehrlich for
the review.
 2015-02-03 18:23:41 +01:00
Matthew Somerville
250aa7c39b Fixed #24240 -- Allowed GZipping a Unicode StreamingHttpResponse 
make_bytes() assumed that if the Content-Encoding header is set, then
everything had already been dealt with bytes-wise, but in a streaming
situation this was not necessarily the case.

make_bytes() is only called when necessary when working with a
StreamingHttpResponse iterable, but by that point the middleware has
added the Content-Encoding header and thus make_bytes() tried to call
bytes(value) (and dies). If it had been a normal HttpResponse,
make_bytes() would have been called when the content was set, well
before the middleware set the Content-Encoding header.

This commit removes the special casing when Content-Encoding is set,
allowing unicode strings to be encoded during the iteration before they
are e.g. gzipped. This behaviour was added a long time ago for #4969 and
it doesn't appear to be necessary any more, as everything is correctly
made into bytes at the appropriate places.

Two new tests, to show that supplying non-ASCII characters to a
StreamingHttpResponse works fine normally, and when passed through the
GZip middleware (the latter dies without the change to make_bytes()).
Removes the test with a nonsense Content-Encoding and Unicode input - if
this were to happen, it can still be encoded as bytes fine.
 2015-02-03 18:18:12 +01:00
Preston Timmons
cd4282816d Fixed #18651 -- Enabled optional assignments for simple_tag(). 2015-02-03 10:44:33 -05:00
Anssi Kääriäinen
8adc59038c Fixed #23617 -- Added get_pk_value_on_save() 
The method is mainly intended for use with UUIDField. For UUIDField we
want to call the field's default even when primary key value is
explicitly set to None to match the behavior of AutoField.

Thanks to Marc Tamlyn and Tim Graham for review.
 2015-02-03 09:23:44 -05:00
Tim Graham
118b11221f Fixed #24263 -- Prevented extra queries on BaseDateDetailView with a custom queryset. 
Thanks jekka-ua for the report and patch.
 2015-02-03 09:12:37 -05:00
Aymeric Augustin
2133f3157e Fixed #24168 -- Allowed selecting a template engine in a few APIs. 
Specifically in rendering shortcuts, template responses, and class-based
views that return template responses.

Also added a test for render_to_response(status=...) which was missing
from fdbfc980.

Thanks Tim and Carl for the review.
 2015-02-03 08:29:45 +01:00
Tim Graham
62df1834b8 Fixed expressions test on Python 3.5; refs #23763. 2015-01-31 19:59:17 -05:00
Tim Graham
75303b01a9 Fixed #24245 -- Added introspection for database defaults. 
Needed for tests for migrations handling of database defaults.
 2015-01-31 12:33:11 -05:00
Tim Graham
293fd5da5b Reverted "Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows." 
This reverts commit da79ccca1d.

This optimized the unsuccessful case at the expense of the successful one.
 2015-01-30 12:51:12 -05:00
Loic Bistuer
4c3bfe9053 Fixed #24211 -- Removed ValuesQuerySet() and ValuesListQuerySet(). 
Thanks Anssi Kääriäinen, Marc Tamlyn, and Tim Graham for the reviews.
 2015-01-30 22:02:58 +07:00
Samuel Colvin
5b74134f27 Fixed #24145 -- Added PUT & PATCH to CommonMiddleware APPEND_SLASH redirect error. 2015-01-29 15:23:01 -05:00
Simon Charette
eb4cdfbdd6 Fixed #23940 -- Allowed model fields to be named exact. 
An explicit `__exact` lookup in the related managers filters
was interpreted as a reference to a foreign `exact` field.

Thanks to Trac alias zhiyajun11 for the report, Josh for the investigation,
Loïc for the test name and Tim for the review.
 2015-01-29 14:40:20 -05:00
Tim Graham
18f3e79b13 Removed threading fallback imports. 
Django imports threading in many other places without fallback.
 2015-01-28 10:23:25 -05:00
Tim Graham
cd91486213 Fixed flake8 warning. 2015-01-28 07:00:52 -05:00
Jon Dufresne
24b2bc635e Fixed #24137 -- Switched to HTTP reason phrases from Python stdlib. 2015-01-28 06:59:40 -05:00
Josh Smeaton
7171bf755b Refs #14030 -- Added repr methods to all expressions 2015-01-28 10:59:30 +11:00
Josh Smeaton
f218a2ff45 Refs #24060 -- Added a test demonstrating reverse order isn't mutable 2015-01-28 10:59:30 +11:00
Raul Cumplido
ac650d02cb Fixed #24209 -- Prevented crash when parsing malformed RFC 2231 headers 
Thanks Tom Christie for the report and review.
 2015-01-27 20:12:22 +01:00
Loic Bistuer
728b6fd9ca Fixed #24219 -- Moved SelectDateWidget together with the other widgets 
and deprecated django.forms.extras.

Thanks Berker Peksag and Tim Graham for the reviews.
 2015-01-27 22:40:02 +07:00
Loic Bistuer
3a4c9e1b43 Cleaned up some forms tests. 
Thanks Berker Peksag and Tim Graham for the reviews. Refs #24219.
 2015-01-27 22:39:57 +07:00
Josh Smeaton
8196e4bdf4 Fixed #24154 -- Backends can now check support for expressions 2015-01-27 12:20:06 +11:00
Tomáš Ehrlich
511be35779 Fixed #24220 - Allowed lazy objects for success_url 2015-01-26 17:58:55 +01:00
Tim Graham
0386b97706 Fixed test_runner test failure on Python 3.5; refs #23763. 
Python change is http://bugs.python.org/issue22032
 2015-01-23 16:23:32 -05:00
Claude Paroz
f8e4e4a935 Fixed warning leak in static.serve() test 
Partial forward port of b1bf8d64fb from 1.7.x. Refs #24193.
 2015-01-23 09:09:48 +01:00
Ng Zhi An
4669b6a807 Fixed #24170 -- Implemented decompress for BaseRangeField widgets 2015-01-22 19:36:15 +00:00
Andriy Sokolovskiy
38c17871bb Fixed #24104 -- Fixed check to look on field.many_to_many instead of class instance 2015-01-22 18:41:19 +01:00
Loic Bistuer
d450af8a26 Fixed small inconsistency when handling aggregate's default_alias. 
Refs #14030.
 2015-01-22 00:44:14 +07:00
Adam Taylor
039465a6a7 Fixed typos in code comments. 2015-01-20 12:18:03 -05:00
Markus Holtermann
64ecb3f07d Refs #24163 -- Fixed failing Oracle test when migrating from ForeignKey to OneToOneField 
Thanks Tim Graham for review
 2015-01-20 16:19:11 +01:00
Marc Tamlyn
0ae94d0d31 Fixes #24169 -- More arrayfield specific lookups. 
varchar()[] cannot compare itself to text[]

Thanks to joelburton for the patch.
 2015-01-20 09:52:23 +00:00
Josh Smeaton
61c102d010 Fixed #24183 -- Fixed wrong comparisons in Substr 2015-01-20 12:09:15 +11:00
Markus Holtermann
7f20041bca Fixed #24155 -- Maintained kwargs and import order in migration writer 
Thanks Tomas Dobrovolny for the report and Tim Graham for the review.
 2015-01-20 01:24:41 +01:00
Tim Graham
b19b81b396 Fixed #24153 -- Fixed cookie test compatibility with Python 3.4.3+ 2015-01-19 15:12:57 -05:00
Tim Graham
378a0d27d6 Advanced deprecation warnings for Django 1.9. 2015-01-19 12:22:41 -05:00
Tim Graham
33457cd3b0 Removed IPAddressField per deprecation timeline; refs #20439. 2015-01-19 11:12:57 -05:00
Markus Holtermann
5792e6a88c Fixed #24163 -- Removed unique constraint after index on MySQL 
Thanks Łukasz Harasimowicz for the report.
 2015-01-19 16:52:26 +01:00
Josh Smeaton
69c6a6868f Fixed #24174 -- Fixed extra order by descending 2015-01-19 12:51:27 +11:00
Tim Graham
2fa2068406 Removed an unused import and a flake8 exclude that caused it to be missed. 2015-01-18 20:02:15 -05:00
Tim Graham
b84100e8e2 Removed usage of deprecated removetags in a template test. 2015-01-18 18:32:47 -05:00
Tim Graham
6e13c0490d Changed RedirectView.permanent to False per deprecation timeline; refs #21587. 2015-01-18 17:43:06 -05:00
Tim Graham
2b039d966f Removed obsolete SQL generation methods. 2015-01-18 15:58:06 -05:00
Tim Graham
7e8cf74dc7 Removed support for syncing apps without migrations per deprecation timeline. 
Kept support for creating models without migrations when running tests
(especially for Django's test suite).
 2015-01-18 15:58:06 -05:00
Tim Graham
67a76500a5 Removed support for admin validators per deprecation timeline; refs #16905. 2015-01-18 14:43:21 -05:00
Tim Graham
2cd00424c4 Removed support for callable QuerySet arguments per deprecation timeline; refs #11629. 2015-01-18 14:01:25 -05:00
Tim Graham
d029fafea1 Removed utils.module_loading.import_by_path() per deprecation timeline; refs #21674. 2015-01-18 12:51:15 -05:00
Tim Graham
c3336e7e4f Removed dumpdata --natural option and serializers use_natural_keys parameter. 
Per deprecation timeline; refs #13252.
 2015-01-17 20:18:34 -05:00
Tim Graham
8d959f73be Removed obsolete deprecation warning in runtests.py 2015-01-17 19:41:46 -05:00
Tim Graham
0622bca5d1 Removed the validate management command per deprecation timeline. 2015-01-17 19:12:03 -05:00
Tim Graham
714277cb4c Removed support for SplitDateTimeWidget with DateTimeField per deprecation timeline. 
refs #8898
 2015-01-17 18:49:44 -05:00
Tim Graham
2c9e95639e Removed ModelAdmin.get_formsets() per deprecation timeline; refs #20702. 2015-01-17 18:02:35 -05:00
Tim Graham
3b570dbcdb Removed BaseDatabaseValidation.validate_field() per deprecation timeline. 2015-01-17 14:58:09 -05:00
Markus Holtermann
65d55c4093 Cleaned up migration writer tests 2015-01-17 20:29:50 +01:00
Tim Graham
bd93032191 Removed ssi/url tags from future per deprecation timeline; refs #21939. 2015-01-17 13:29:52 -05:00
Tim Graham
e278407b20 Removed unused imports from previous commit. 2015-01-17 13:22:52 -05:00
Tim Graham
4a03d348c7 Removed BaseCommand.requires_model_validation per deprecation timeline. 2015-01-17 12:59:07 -05:00
Tim Graham
df3f3bbe29 Removed utils.text.javascript_quote() per deprecation timeline; refs #21725. 2015-01-17 12:41:49 -05:00
Tim Graham
f0a1df0b01 Removed deprecated Chinese language codes; refs #18149. 2015-01-17 11:23:43 -05:00
Tim Graham
4aa089a9a9 Removed support for custom SQL per deprecation timeline. 2015-01-17 10:16:06 -05:00
Collin Anderson
a420f83e7d Fixed #24055 -- Keep reference to view class for resolve() 2015-01-17 22:09:10 +07:00
Tim Graham
67235fd4ef Removed support for initial_data fixtures per deprecation timeline. 2015-01-17 09:59:25 -05:00
Tim Graham
f635d75935 Removed support for old-style test database settings per deprecation timeline. 2015-01-17 09:55:18 -05:00
Tim Graham
d038c547b5 Removed django.core.cache.get_cache() per deprecation timeline; refs #21012. 2015-01-17 09:55:18 -05:00
Tim Graham
1b0365ad34 Removed django.utils.tzinfo per deprecation timeline; refs #17262. 2015-01-17 09:32:33 -05:00
Tim Graham
fed25f1105 Removed compatibility with Python 3.2. 2015-01-17 09:00:17 -05:00
Tim Graham
c820892eed Removed django.utils.datastructures.SortedDict per deprecation timeline. 2015-01-17 08:40:23 -05:00
Tim Graham
41f0d3d3bc Removed FastCGI support per deprecation timeline; refs #20766. 2015-01-17 08:32:31 -05:00
Tim Graham
37b7776a01 Removed django.utils.datastructures.MergeDict per deprecation timeline; refs #18659. 2015-01-17 08:13:36 -05:00
Tim Graham
75f107b884 Removed request.REQUEST per deprecation timeline; refs #18659. 2015-01-17 08:05:18 -05:00
Tim Graham
61ad1ea92b Removed django.utils.functional.memoize per deprecation timeline. 
refs #21351.
 2015-01-17 07:55:32 -05:00
Tim Graham
9ce36512fa Removed backwards compatibility shims for "util" modules per deprecation timeline. 
refs #17627.
 2015-01-17 07:40:12 -05:00
Tim Graham
b952c3fc60 Removed django.utils.unittest per deprecation timeline. 2015-01-17 07:32:22 -05:00
Tim Graham
ce78b954cf Removed django.utils.importlib per deprecation timeline. 2015-01-17 07:14:21 -05:00
Tim Graham
1c8b637ed9 Removed django.utils.dictconfig per deprecation timeline. 2015-01-17 07:13:51 -05:00
Marc Tamlyn
39d95fb6ad Fixed #24092 -- Widened base field support for ArrayField. 
Several issues resolved here, following from a report that a base_field
of GenericIpAddressField was failing.

We were using get_prep_value instead of get_db_prep_value in ArrayField
which was bypassing any extra modifications to the value being made in
the base field's get_db_prep_value. Changing this broke datetime
support, so the postgres backend has gained the relevant operation
methods to send dates/times/datetimes directly to the db backend instead
of casting them to strings. Similarly, a new database feature has been
added allowing the uuid to be passed directly to the backend, as we do
with timedeltas.

On the other side, psycopg2 expects an Inet() instance for IP address
fields, so we add a value_to_db_ipaddress method to wrap the strings on
postgres. We also have to manually add a database adapter to psycopg2,
as we do not wish to use the built in adapter which would turn
everything into Inet() instances.

Thanks to smclenithan for the report.
 2015-01-16 16:15:16 -05:00
Collin Anderson
e8171daf0c Fixed #24146 -- Fixed a missing fields regression in admin checks. 
This allows using get_field() early in the app loading process.

Thanks to PirosB3 and Tim Graham.
 2015-01-16 14:47:09 -05:00
Claude Paroz
b4ac232907 Fixed #24099 -- Removed contenttype.name deprecated field 
This finsishes the work started on #16803.
Thanks Simon Charette, Tim Graham and Collin Anderson for the
reviews.
 2015-01-16 20:21:34 +01:00
Collin Anderson
5338ff4808 Fixed #24160 -- Fixed model_regress test on Windows; refs #24007. 2015-01-16 11:59:08 -05:00
Tim Graham
28db4af80a Fixed #24135 -- Made RenameModel rename many-to-many tables. 
Thanks Simon and Markus for reviews.
 2015-01-15 20:34:33 -05:00
Yang Liu
3f9ec12d9c Fixed #23712 -- Fixed KeyError with BaseForm._html_output() 2015-01-15 20:19:53 -05:00
Collin Anderson
faf0d66a80 Fixed #23850 -- Fixed a migrations test failure on Mac OS X & Python 3 2015-01-15 19:45:43 -05:00
Michał Modzelewski
39b58ad95a Fixed #24148 -- Documented a bug with case expressions in SQLite < 3.7.0 2015-01-15 19:42:05 -05:00
Collin Anderson
67dbc56ec8 Made an expressions_case test work without Pillow. 2015-01-15 14:02:58 -05:00
Tim Graham
9801d419b9 Skipped a problematic file_storage test on Windows. 2015-01-14 15:00:27 -05:00
Collin Anderson
2d5da57f48 Fixed incorrect error message in Options.get_fields() 2015-01-14 14:51:05 -05:00
Tim Graham
28308078f3 Fixed #22603 -- Reorganized classes in django.db.backends. 2015-01-14 14:16:20 -05:00
Tim Graham
a6f144fd4f Fixed a static view test on Windows. 2015-01-14 13:56:49 -05:00
Markus Holtermann
88786afbff Fixed #24147 -- Prevented managers leaking model during migrations 
Thanks Tim Graham for the review.
 2015-01-14 16:09:33 +01:00
Tim Graham
baf2542c4f Fixed DoS possibility in ModelMultipleChoiceField. 
This is a security fix. Disclosure following shortly.

Thanks Keryn Knight for the report and initial patch.
 2015-01-13 13:03:06 -05:00
Tim Graham
a3bebfdc34 Ensured views.static.serve() doesn't use large memory on large files. 
This issue was fixed in master by refs #24072.
 2015-01-13 13:03:06 -05:00
Tim Graham
69b5e66738 Fixed is_safe_url() to handle leading whitespace. 
This is a security fix. Disclosure following shortly.
 2015-01-13 13:03:06 -05:00
Carl Meyer
316b8d4974 Stripped headers containing underscores to prevent spoofing in WSGI environ. 
This is a security fix. Disclosure following shortly.

Thanks to Jedediah Smith for the report.
 2015-01-13 13:03:05 -05:00
Michał Modzelewski
65246de7b1 Fixed #24031 -- Added CASE expressions to the ORM. 2015-01-12 18:15:34 -05:00
Josh Smeaton
21b858cb67 Fixed #24060 -- Added OrderBy Expressions 2015-01-13 09:39:55 +11:00
Claude Paroz
f48e2258a9 Fixed #24133 -- Replaced formatting syntax in success_url placeholders 
Thanks Laurent Payot for the report, and Markus Holtermann, Tim Graham
for the reviews.
 2015-01-12 22:51:22 +01:00
Aymeric Augustin
5f7230e12f Fixed #24124 (again) -- Updated tests with new default context_processors. 
Thanks Collin for the review.
 2015-01-12 22:31:44 +01:00
Aymeric Augustin
6b5113ec94 Made debug views not crash when there isn't a default template engine. 2015-01-12 21:01:34 +01:00
Aymeric Augustin
79deb6a071 Accounted for multiple template engines in template responses. 2015-01-12 21:01:34 +01:00
Aymeric Augustin
a3e783fe11 Deprecated passing a Context to a generic Template.render. 
A deprecation path is required because the return type of
django.template.loader.get_template changed during the
multiple template engines refactor.

test_csrf_token_in_404 was incorrect: it tested the case when the
hardcoded template was rendered, and that template doesn't depend on the
CSRF token. This commit makes it test the case when a custom template is
rendered.
 2015-01-12 21:01:34 +01:00
Aymeric Augustin
71b7668b75 Rewrapped TemplateSyntaxError in Jinja2 backend. 
Changed import style to avoid confusion between Django's and Jinja2's
APIs.
 2015-01-12 21:01:34 +01:00
Claude Paroz
4c413e231c Fixed #17785 -- Preferred column names in get_relations introspection 
Thanks Thomas Güttler for the report and the initial patch, and
Tim Graham for the review.
 2015-01-12 19:58:47 +01:00
Muthiah Annamalai
b75c707943 Fixed #24089 -- Added check for when ModelAdmin.fieldsets[1]['fields'] isn't a list/tuple. 2015-01-12 13:47:58 -05:00
Markus Holtermann
eeb88123e7 Fixed #24129 -- Added indicator that migrations are rendering the initial state 
Thanks Tim Graham for the review.
 2015-01-12 19:23:46 +01:00
Tim Graham
9f51d0c86d Fixed test from refs #23913 when running tests in reverse. 2015-01-12 13:20:44 -05:00
Markus Holtermann
bbbed99f62 Fixed #24123 -- Used all available migrations to generate the initial migration state 
Thanks Collin Anderson for the input when creating the patch and Tim Graham for the review.
 2015-01-12 18:39:18 +01:00
Pavel Shpilev
a7c256cb54 Fixed #9893 -- Allowed using a field's max_length in the Storage. 2015-01-12 09:09:18 -05:00
Marc Tamlyn
b5c1a85b50 Fixed #24118 -- Added --debug-sql option for tests. 
Added a --debug-sql option for tests and runtests.py which outputs the
SQL logger for failing tests. When combined with --verbosity=2, it also
outputs the SQL for passing tests.

Thanks to Berker, Tim, Markus, Shai, Josh and Anssi for review and
discussion.
 2015-01-12 08:16:08 +00:00
Claude Paroz
68a439a18d Removed supports_binary_field flag as all backends support them 
It was mainly for MySQL on Python 3, but now the current
recommended MySQL driver for Python 3 (mysqlclient) does support
binary fields, it is unneeded. Refs #20377.
 2015-01-11 23:34:47 +01:00
Ola Sitarska
d563e3be68 Fixed #23913 -- Deprecated the = comparison in if template tag. 2015-01-11 15:21:01 -05:00
Claude Paroz
412066e71e Revert "Marked a test as an expected failure on MySQL and Python 3.2." 
This reverts commit 832b4a5722.
We officially don't support MySQL on Python 3.2. Refs #20380.
 2015-01-11 20:59:07 +01:00
Markus Holtermann
fdc2cc9487 Fixed #24110 -- Rewrote migration unapply to preserve intermediate states 2015-01-10 23:14:15 +01:00
Simon Charette
07988744b3 Fixed #13165 -- Added edit and delete links to admin foreign key widgets. 
Thanks to Collin Anderson for the review and suggestions and Tim for the
final review.
 2015-01-10 12:24:52 -05:00
Marc Tamlyn
48ad288679 Fixed #24001 -- Added range fields for PostgreSQL. 
Added support for PostgreSQL range types to contrib.postgres.

- 5 new model fields
- 4 new form fields
- New validators
- Uses psycopg2's range type implementation in python
 2015-01-10 16:18:19 +00:00
Claude Paroz
7289d01973 Introspected alternate SQLite FK definitions 2015-01-10 16:51:14 +01:00
Claude Paroz
ffca9b49d4 Updated introspection test to use skipUnlessDBFeature 2015-01-10 15:42:31 +01:00
Claude Paroz
d7bc37d611 Fixed #24097 -- Prevented AttributeError in redirect_to_login 
Thanks Peter Schmidt for the report and the initial patch.
Thanks to ​Oktay Sancak for writing the original failing test and
Alvin Savoy for supporting contributing back to the community.
 2015-01-10 10:05:02 +01:00
Loic Bistuer
8f4877c89d Fixed #22583 -- Allowed RunPython and RunSQL to provide hints to the db router. 
Thanks Markus Holtermann and Tim Graham for the review.
 2015-01-10 00:30:48 +07:00
Preston Timmons
665e0aa6ec Fixed #24094 -- Enabled template tests to run individually. 2015-01-09 11:43:59 -05:00
Markus Holtermann
c8bac4b556 Fixed #24098 -- Added no-op attributes to RunPython and RunSQL 
Thanks Loïc Bistuer and Tim Graham for the discussion and review.
 2015-01-09 10:31:32 -05:00
Anssi Kääriäinen
0c7633178f Fixed #24020 -- Refactored SQL compiler to use expressions 
Refactored compiler SELECT, GROUP BY and ORDER BY generation.
While there, also refactored select_related() implementation
(get_cached_row() and get_klass_info() are now gone!).

Made get_db_converters() method work on expressions instead of
internal_type. This allows the backend converters to target
specific expressions if need be.

Added query.context, this can be used to set per-query state.

Also changed the signature of database converters. They now accept
context as an argument.
 2015-01-08 14:07:54 -05:00
Tim Graham
b8abfe141b Fixed #24101 -- Fixed flaky admin_views selenium tests; refs #7361. 2015-01-08 13:17:00 -05:00
Tim Graham
5c43fd4825 Isolated some cache tests; refs #23947. 
This reverts a change made in 40c60efecc
which was incorrect and caused CacheKeyWarnings.
 2015-01-08 13:14:45 -05:00
Claude Paroz
543df07720 Fixed #24073 -- Returned None for get_language when translations are deactivated 
This fixes a regression caused by f7c287fca9. Thanks Markus Holtermann
for identifying the regression.
 2015-01-08 17:43:07 +01:00
Tim Graham
ade9859996 Fixed #24095 -- Prevented WarningLoggerTests from leaking a warnings filter. 2015-01-08 08:49:54 -05:00
Markus Holtermann
862ea825b5 Fixed #24093 -- Prevented MigrationWriter to write operation kwargs that are not explicitly deconstructed 2015-01-07 17:29:20 -07:00
Tim Graham
f487a3275e Avoided a deprecated alias on Python 3 in file_uploads test. 2015-01-07 19:12:37 -05:00
Josh Smeaton
8713ea7568 Fixed null handling in Value expression 2015-01-07 19:07:49 -05:00
Markus Holtermann
1f03d2d924 Refs #23822 -- Made MigrationOptimizer aware of model managers 2015-01-07 17:33:04 -05:00
Aymeric Augustin
127f9e073d Restored support for multiple template names in render(_to_response). 
This possibility was documented but not tested.

It had been broken during the multiple template engines refactor.
 2015-01-07 21:54:22 +01:00
Aymeric Augustin
eaa1a22341 Added a request argument to render_to_string. 
This is for consistency with Template.render.

It adds a little bit of knowledge about HTTP requests in
django.template.loader but I think consistency trumps purity.
 2015-01-07 21:54:22 +01:00
Claude Paroz
f7c287fca9 Fixed #24073 -- Deactivated translations when leave_locale_alone is False 
Thanks Tim Graham and Markus Holtermann for the reviews.
 2015-01-07 20:11:24 +01:00
Michał Modzelewski
ee86e59051 Refs #2443 -- Allowed creation of objects with NULL DurationFields 2015-01-07 08:33:26 -05:00
Josh Smeaton
5a4ac4ead9 Fixed #24078 -- Removed empty strings from GenericIPAddressField 2015-01-07 08:08:36 -05:00
Daniel Pyrathon
fb48eb0581 Fixed #12663 -- Formalized the Model._meta API for retrieving fields. 
Thanks to Russell Keith-Magee for mentoring this Google Summer of
Code 2014 project and everyone else who helped with the patch!
 2015-01-06 19:25:12 -05:00
Tim Graham
749d23251b Removed warning handling that should have been removed in refs #23891. 2015-01-06 18:33:55 -05:00
Aymeric Augustin
0cdb09d489 Made context take priority over context processors. 
This is the expected behavior, but given RequestContext's tortuous
implementation, a straightforward use of its API results in the
opposite.

This commits fixes a regression that must have happened at different
points in the multiple templates engine refactor for different features.
 2015-01-06 22:02:27 +01:00
Danilo Bargen
2e65d56156 Fixed #20003 -- Improved and extended URLValidator 
This adds support for authentication data (`user:password`) in URLs,
IPv6 addresses, and unicode domains.

The test suite has been improved by adding test URLs from
http://mathiasbynens.be/demo/url-regex (with a few adjustments,
like allowing local and reserved IPs).

The previous URL validation regex failed this test suite on 13
occasions, the validator was updated based on
https://gist.github.com/dperini/729294.
 2015-01-06 14:04:25 -05:00
Claude Paroz
011f21b4fa Used None-related assertions in CSRF tests 
Thanks Markus Holtermann for spotting this.
 2015-01-06 08:48:01 +01:00
Claude Paroz
27dd7e7271 Fixed #23815 -- Prevented UnicodeDecodeError in CSRF middleware 
Thanks codeitloadit for the report, living180 for investigations
and Tim Graham for the review.
 2015-01-06 08:42:58 +01:00
Preston Timmons
de9ebdd39c Fixed #24022 -- Deprecated the ssi tag. 2015-01-05 19:35:02 -05:00
Markus Holtermann
e08318b4ef Refs #23359 -- Removed double newline from output of migrate --list 
Thanks Berker Peksag for the review.
 2015-01-05 14:52:54 -05:00
Tim Graham
789baf9c3a Fixed test failures introduced in refs #23861. 2015-01-05 14:35:30 -05:00
Tim Graham
c87ee41954 Fixed #23861 -- Added an API to deprecate model fields. 
Thanks Markus Holterman and Berker Peksag for review.
 2015-01-05 11:35:36 -05:00
Claude Paroz
6e1c9c6568 Fixed #8280 -- Allowed management command discovery for eggs 
Thanks jdetaeye for the report, bhuztez and jdetaeye for the
initial patches, Tim Graham and Berker Peksag for the reviews.
 2015-01-05 17:19:35 +01:00
Collin Anderson
3d2cae0896 Fixed #24072 -- Added FileResponse for streaming binary files. 2015-01-05 10:51:52 -05:00
Andriy Sokolovskiy
23f1a8dad2 Added return value to Signal.disconnect(). 2015-01-02 12:00:41 -05:00
Tim Graham
937fab030d Renamed an assertion in the dispatch tests. 2015-01-02 11:29:06 -05:00
Daniel Pyrathon
8958170755 Fixed #9104 -- Moved FieldDoesNotExist to core.exceptions 2015-01-02 10:46:04 -05:00
Claude Paroz
1aa3e09c20 Fixed #23745 -- Reused states as much as possible in migrations 
Thanks Tim Graham and Markus Holtermann for the reviews.
 2015-01-02 15:37:10 +01:00
Claude Paroz
2a9c4b4901 Passed around the state between migrations 
Refs #23745.
 2015-01-02 15:37:10 +01:00
Claude Paroz
a159b1facd Replaced migration state render() by apps cached property 
Refs #23745.
 2015-01-02 15:19:36 +01:00
Tim Graham
40ccef16cb Silenced an ImportWarning in the template_backends tests. 2015-01-01 14:28:53 -05:00
Tim Graham
b9feec959b Fixed #23700 -- Fixed non-deterministic static files test failures on Windows. 
This partially reverts commit 949ee521fa
refs #21230.
 2015-01-01 13:57:52 -05:00
Tim Graham
40a8504357 Fixed #23891 -- Moved deprecation of IPAddressField to system check framework. 
Thanks Markus Holtermann for review.
 2015-01-01 13:30:52 -05:00
Thomas Tanner
46068d850d Fixed #22295 -- Replaced permission check for displaying admin user-tools 2014-12-31 16:31:59 -05:00
Andrey Maslov
7a878ca5cb Fixed #24008 -- Fixed ValidationError crash with list of dicts. 2014-12-31 14:43:13 -05:00
Markus Holtermann
a1487deebf Fixed #23359 -- Added showmigrations command to list migrations and plan. 
Thanks to Collin Anderson, Tim Graham, Gabe Jackson, and Marc Tamlyn
for their input, ideas, and review.
 2014-12-31 14:14:28 -05:00
Will Earp
8952757698 Refs #18586 -- Split up tests.defer.DeferTests.test_defer 2014-12-31 11:56:06 -05:00
Tim Graham
8a9b0c15a6 Renamed tests for util -> utils moves; refs #17627. 2014-12-31 11:26:27 -05:00
Tim Graham
837fc2d8cd Fixed a queries test on Python 2 broken after importing six.moves.range(). 2014-12-31 09:50:47 -05:00
Tim Graham
63dee96cc7 Fixed test from refs #23758. 2014-12-31 09:19:04 -05:00
Piotr Pawlaczek
41fc1c0b5e Fixed #23758 -- Allowed more than 5 levels of subqueries 
Refactored bump_prefix() to avoid infinite loop and allow more than
than 5 subquires by extending the alphabet to use multi-letters.
 2014-12-31 08:48:28 -05:00
Tim Graham
93d73dac91 Moved DatabaseCreation.data_types properties to DatabaseWrapper. 
refs #22340.
 2014-12-31 08:29:17 -05:00
Berker Peksag
32ca159c96 Ignored warnings correctly in test_get_formsets_with_inlines_returns_tuples(). 
The subclass check in ModelAdmin.get_formsets_with_inlines() wasn't
tested correctly because of the super() call in
EpisodeAdmin.get_formsets().
 2014-12-31 08:24:09 -05:00
Claude Paroz
51890ce889 Applied ignore_warnings to Django tests 2014-12-30 18:16:25 +01:00
Tim Graham
df3cc53fda Fixed #23450 -- Fixed transient failure of requests...test_far_expiration. 2014-12-30 10:23:42 -05:00
Tim Graham
c6b12bc995 Removed unused import. 2014-12-30 10:23:29 -05:00
Andriy Sokolovskiy
8c99b7920e Fixed #12118 -- Added shared cache support to SQLite in-memory testing. 2014-12-30 10:14:33 -05:00
Markus Holtermann
fca866763a Added test for an intermediate swappable model change in migration state. 
refs #22563
 2014-12-30 10:01:25 -05:00
Tim Graham
ab4f709da4 Fixed #23581 -- Prevented extraneous DROP DEFAULT statements. 
Thanks john_scott for the report and Markus Holtermann for review.
 2014-12-30 07:54:05 -05:00
Markus Holtermann
623ccdd598 Fixed #23938 -- Added migration support for m2m to concrete fields and vice versa 
Thanks to Michael D. Hoyle for the report and Tim Graham for the review.
 2014-12-29 13:41:12 -05:00
Claude Paroz
3c5d1edb39 Fixed #22279 -- Prevented dummy backend going through DatabaseErrorWrapper 
Thanks Daniel Hahler for the report and Tim Graham for the review.
 2014-12-29 19:06:28 +01:00
Claude Paroz
1d24f073e6 Fixed #21255 -- Closed connections after management command ran 
Thanks kabakov.as@gmail.com for the report, and Aymeric Augustin,
Simon Charette for the reviews.
 2014-12-29 19:02:45 +01:00
Berker Peksag
bae404dea3 Converted middleware tests to use RequestFactory. 2014-12-29 19:36:18 +02:00
Ramiro Morales
6fb9dee470 Fixed #23271 -- Don't corrupt PO files on Windows when updating them. 
Make sure PO catalog text fetched from gettext programs via standard
output isn't corrupted by mismatch between assumed (UTF-8) and real
(CP1252) encodings. This can cause mojibake to be written when creating
or updating PO files.

Also fixes #23311.

Thanks to contributor with Trac nick 'danielmenzel' for the report,
excellent research and fix.
 2014-12-29 12:24:50 -03:00
Josh Smeaton
1cdfbde4db Fixed #23753 -- Oracle failure with Coalesce 2014-12-29 19:44:13 +11:00
Aymeric Augustin
b7282db833 Raised a warning when using the legacy TEMPLATE_* settings. 
All tests now rely on TEMPLATES.
 2014-12-28 17:02:31 +01:00
Aymeric Augustin
9eb4f28e89 Deprecated TEMPLATE_CONTEXT_PROCESSORS. 2014-12-28 17:02:31 +01:00
Aymeric Augustin
d3205e3e2e Deprecated TEMPLATE_DIRS. 2014-12-28 17:02:30 +01:00
Aymeric Augustin
cf0fd65ed4 Deprecated TEMPLATE_LOADERS. 2014-12-28 17:02:30 +01:00
Aymeric Augustin
d3a982556d Deprecated TEMPLATE_STRING_IF_INVALID. 2014-12-28 17:02:30 +01:00
Aymeric Augustin
3dc01aaaaf Deprecated ALLOWED_INCLUDE_ROOTS. 2014-12-28 17:02:30 +01:00
Aymeric Augustin
cf1f36bb6e Deprecated current_app in TemplateResponse and render(_to_response). 2014-12-28 17:02:29 +01:00
Aymeric Augustin
fdbfc98003 Deprecated some arguments of django.shortcuts.render(_to_response). 
dictionary and context_instance and superseded by context.

Refactored tests that relied context_instance with more modern idioms.
 2014-12-28 17:02:29 +01:00
Aymeric Augustin
92e8f1f302 Moved context_processors from django.core to django.template. 2014-12-28 17:00:07 +01:00
Aymeric Augustin
969e082858 Added tests for django.template.loader. 
Deprecated features aren't tested.
 2014-12-28 17:00:07 +01:00
Aymeric Augustin
90805b240f Supported multiple template engines in render_to_string. 
Adjusted its API through a deprecation path according to the DEP.
 2014-12-28 16:23:02 +01:00
Aymeric Augustin
5523e4cdbb Removed private API find_template. 
It wasn't documented and it wasn't used anywhere, except in a few tests
that don't test it specifically and can be rewritten with get_template.
 2014-12-28 16:23:01 +01:00
Aymeric Augustin
4ea43ac915 Supported multiple template engines in get_template and select_template. 
This commit changes the return type of these two functions. Instead of
returning a django.template.Template they return a backend-specific
Template class that must implement render(self, context).
 2014-12-28 16:23:01 +01:00
Aymeric Augustin
92a2d049a2 Isolated template tests from Django settings. 2014-12-28 16:23:01 +01:00
Aymeric Augustin
332154e726 Added basic tests for template backends. 2014-12-28 16:23:00 +01:00
Aymeric Augustin
7eefdbf7ab Cleaned up the django.template namespace. 
Since this package is going to hold both the implementation of the Django
Template Language and the infrastructure for Multiple Template Engines,
it should be untied from the DTL as much as possible within our
backwards-compatibility policy.

Only public APIs (i.e. APIs mentioned in the documentation) were left.
 2014-12-28 14:47:31 +01:00
Aymeric Augustin
6d52f6f8e6 Fixed #23831 -- Supported strings escaped by third-party libs in Django. 
Refs #7261 -- Made strings escaped by Django usable in third-party libs.

The changes in mark_safe and mark_for_escaping are straightforward. The
more tricky part is to handle correctly objects that implement __html__.

Historically escape() has escaped SafeData. Even if that doesn't seem a
good behavior, changing it would create security concerns. Therefore
support for __html__() was only added to conditional_escape() where this
concern doesn't exist.

Then using conditional_escape() instead of escape() in the Django
template engine makes it understand data escaped by other libraries.

Template filter |escape accounts for __html__() when it's available.
|force_escape forces the use of Django's HTML escaping implementation.

Here's why the change in render_value_in_context() is safe. Before Django
1.7 conditional_escape() was implemented as follows:

    if isinstance(text, SafeData):
        return text
    else:
        return escape(text)

render_value_in_context() never called escape() on SafeData. Therefore
replacing escape() with conditional_escape() doesn't change the
autoescaping logic as it was originally intended.

This change should be backported to Django 1.7 because it corrects a
feature added in Django 1.7.

Thanks mitsuhiko for the report.
 2014-12-27 18:02:34 +01:00
Aymeric Augustin
5c5eb5fea4 Fixed an inconsistency introduced in 547b1810. 
mark_safe and mark_for_escaping should have been kept similar.

On Python 2 this change has no effect. On Python 3 it fixes the use case
shown in the regression test for mark_for_escaping, which used to raise
a TypeError. The regression test for mark_safe is just for completeness.
 2014-12-27 17:44:54 +01:00
Claude Paroz
2ceb10f3b0 Fixed #14180 -- Prevented unneeded index creation on MySQL-InnoDB 
Thanks zimnyx for the report and Simon Charette, Tim Graham for
the reviews.
 2014-12-27 12:52:44 +01:00
Josh Smeaton
4718296546 Fixed #23753 -- Added a suite of SQL Functions 
Added functions and tests
Added docs and more tests
Added TextField converter to mysql backend
Aliased Value as V in example docs and tests
Removed unicode_compatible in example
Fixed console emulation in examples
 2014-12-27 15:27:27 +11:00
Tim Graham
7c07612e90 Removed an unnecessary models file in the admin_scripts tests. 2014-12-26 19:31:54 -05:00
Tim Graham
75bbcfa332 Replaced sqlall in some bash_completion/admin_scripts tests. 
sqlall will be removed in Django 1.9, so now's a good time to remove
its usage where it's not important.
 2014-12-26 18:52:26 -05:00
Gavin Wahl
b4e76f30d1 Fixed #23346 -- Fixed lazy() to lookup methods on the real object, not resultclasses. 
Co-Authored-By: Rocky Meza <rmeza@fusionbox.com>
 2014-12-26 11:30:34 -05:00
Niclas Olofsson
3daa9d60be Fixed #10414 -- Made select_related() fail on invalid field names. 2014-12-24 14:54:30 -05:00
Thomas Tanner
b27db97b23 Fixed #22461 -- Added if-unmodified-since support to the condition decorator. 2014-12-24 12:33:57 -05:00
Claude Paroz
fae551d765 Complemented pickle test for ValuesQuerySet with related field 
Refs #14515.
 2014-12-24 14:58:32 +01:00
Claude Paroz
7ce9644d93 Added a test to ensure bad assignation to M2M doesn't clear data 
Refs #14394.
 2014-12-24 14:18:00 +01:00
Tim Graham
c5c235cd4f Fixed typo in test_utils comment. 2014-12-24 07:10:34 -05:00
Claude Paroz
b3ebcb22a9 Ignored deprecation warnings for CreationIndexesTests 2014-12-24 10:45:53 +01:00
Claude Paroz
9699d8446e Moved test correction from 5b1fb0a75 2014-12-24 10:42:24 +01:00
Tim Graham
061caa5b38 Fixed #24037 -- Prevented data loss possibility when changing Meta.managed. 
The migrations autodetector now issues AlterModelOptions operations for
Meta.managed changes instead of DeleteModel + CreateModel.

Thanks iambibhas for the report and Simon and Markus for review.
 2014-12-23 14:25:31 -05:00
Claude Paroz
30cbd5d360 Replaced DatabaseCreation sql methods by schema editor equivalents 
Also used schema editor in migrate to sync unmigrated apps (sync_apps).
Refs #22340. Thanks Tim Graham for the review.
 2014-12-23 19:35:01 +01:00
Claude Paroz
15ba0d166f Added migration for site test app depending on contrib.sites 2014-12-23 19:01:33 +01:00
Claude Paroz
750dbb1133 Removed unneeded null param to ManyToManyField 2014-12-23 19:01:03 +01:00
Claude Paroz
90720d549a Removed admin_util test dependency on contrib.sites 2014-12-23 18:43:55 +01:00
Claude Paroz
f05b03f3d7 Removed model_package test dependency on contrib.sites 2014-12-23 18:10:07 +01:00
Anssi Kääriäinen
f233bf47dd Fixed #21414 -- Removed RelatedObject and deprecated Field.related. 2014-12-23 10:54:25 -05:00
Claude Paroz
9fecb86a52 Fixed #17946 -- Fixed deserialization of self-referencing M2M fields 
Thanks Philip Mountifield for the report and excellent analysis, and
Simon Charette for the review.
 2014-12-23 16:01:39 +01:00
Thomas Chaumeny
994d6137a2 Fixed #23792 -- Added test.utils.freeze_time() context manager. 2014-12-22 07:46:40 -05:00
Oscar Ramirez
54085b0f9b Fixed #23998 -- Added datetime.time support to migrations questioner. 2014-12-22 07:24:54 -05:00
Marc Tamlyn
936e87c97b Merge pull request #3765 from wlanslovenija/ticket_24034 
Fixed #24034 -- Don't always overwrite deconstruct path.
 2014-12-22 00:41:13 +00:00
Josh Schneier
9a23470072 Fixed #24017 -- Added python_2_unicode_compatible in db/migrations 2014-12-21 16:10:43 -05:00
Jernej Kos
7c50e7eecc Fixed #24034 -- Don't always overwrite deconstruct path. 
Made deconstruct path overwriting for ArrayField conditional,
so it only occurs when the deconstructed field is an instance
of ArrayField itself and not a subclass.
 2014-12-21 17:31:50 +01:00
Marc Tamlyn
57554442fe Fixed #2443 -- Added DurationField. 
A field for storing periods of time - modeled in Python by timedelta. It
is stored in the native interval data type on PostgreSQL and as a bigint
of microseconds on other backends.

Also includes significant changes to the internals of time related maths
in expressions, including the removal of DateModifierNode.

Thanks to Tim and Josh in particular for reviews.
 2014-12-20 18:28:29 +00:00
Tim Graham
995be4a137 Fixed refs #24007 test on Windows. 2014-12-19 14:11:17 -05:00
Claude Paroz
1d9fc5caa9 Made model_regress unpickling test CWD-independent 
Refs #24007. Thanks Tim Graham for his help with the patch.
 2014-12-19 18:37:32 +01:00
Claude Paroz
5b1fb0a75d Forward-ported test and release note from f46a16614 
Refs #24015.
 2014-12-18 21:17:17 +01:00
Claude Paroz
9bcd4d812c Fixed #23788 (2) -- Improved gettext version checker 
Thanks Tim Graham for the report and initial patch.
 2014-12-18 16:06:33 +01:00
Collin Anderson
4fb38b7307 Allowed Python executable names other than python in test from refs #24007. 2014-12-17 20:09:24 -05:00
Claude Paroz
108b8bf852 Fixed #24007 -- Ensure apps registry's ready before unpickling models 
This prevents AppRegistryNotReady errors when unpickling Django
models from an external script.
 2014-12-17 18:33:32 +01:00
Mosson, Andrew
b7219c7ba5 Fixed #23497 -- Made admin system checks run for custom AdminSites. 2014-12-17 09:11:46 -05:00
Anssi Kääriäinen
1c5cbf5e5d Fixed #24002 -- GenericRelation filtering targets related model's pk 
Previously Publisher.objects.filter(book=val) would target
book.object_id if book is a GenericRelation. This is inconsistent to
filtering over reverse foreign key relations, where the target is the
related model's primary key.
 2014-12-17 10:04:52 +02:00
Tim Graham
d2ff8a7241 Fixed #23975 -- Restored pre_migrate signal if all apps have migrations. 
Thanks kmmbvnr for the report.
 2014-12-16 18:34:25 -05:00
Preston Timmons
f91d7366e0 Fixed #16028 -- Moved defaultfilters tests into template_tests. 2014-12-16 14:45:19 -05:00
Andriy Sokolovskiy
3dbbb8a89c Fixed #23983 -- Fixed a crash in migrations when adding order_with_respect_to to non-empty table. 2014-12-16 10:48:49 -05:00
Diego Guimarães
ca013e652f Fixed #23995 -- Removed unnecessary calls to self.client.logout() in tests. 2014-12-16 09:12:46 -05:00
Michael Hall
4fada6f1c9 Fixed #23893: Added tzinfo to constant datetime in unit test 
Added tzinfo to y2k constant (01/01/2000) in
custom_lookups.tests.DateTimeLookupTests.test_datetime_output_field
to fix warning message regarding naive datetimes.
 2014-12-16 02:54:59 -07:00
Diego Guimarães
c17d821fa7 Refs #23947 -- Improved migrations tests table cleanup. 
Copied technique from schema tests.
 2014-12-15 19:05:19 -05:00
Tim Graham
ac5f2a4ef7 Fixed refs #23987 test on Oracle. 2014-12-15 18:15:55 -05:00
Markus Holtermann
3ef50a772b Fixed reverse test execution for migration manager tests 
Thanks to Tim Graham for reporting the issue; refs #23822
 2014-12-15 17:54:40 -05:00
Andriy Sokolovskiy
d8f3b86a76 Fixed #23405 -- Fixed makemigrations prompt when adding Text/CharField. 
A default is no longer required.
 2014-12-15 14:41:52 -05:00
Andriy Sokolovskiy
089047331d Fixed #23987 -- Made SQLite SchemaEditor always use effective_default(). 2014-12-15 13:40:24 -05:00
Diego Guimarães
222699d224 Refs #23947 -- Fixed queries test execution order dependency. 
Specify an id to avoid conflict with objects created in setUpTestData.
 2014-12-15 12:25:55 -05:00
Tim Graham
e8223b889a Corrected test assertion from refs #21403. 2014-12-15 12:04:07 -05:00
Diego Guimarães
d8182f294a Refs #23947 -- Fixed admin_views test execution order dependency. 2014-12-15 10:48:42 -05:00
Markus Holtermann
aa5ef0d4fc Fixed #23822 -- Added support for serializing model managers in migration 
Thanks to Shai Berger, Loïc Bistuer, Simon Charette, Andrew Godwin,
Tim Graham, Carl Meyer, and others for their review and input.
 2014-12-15 08:34:15 -05:00
Aymeric Augustin
71a559e771 Removed obsolete code for running test_loaders.py. 
Running this file as a standalone script doesn't work anyway.
 2014-12-13 22:51:57 +01:00
Michael Hall
895dc880eb Fixed #23812 -- Changed django.utils.six.moves.xrange imports to range 2014-12-13 12:45:58 -05:00
Tim Graham
df9f2e41fa Refs #23943 -- Removed an invalid generic_views test. 
Using PUT as a method for the form element is no longer supported
as described in the ticket.
 2014-12-12 16:14:10 -05:00
Carl Meyer
c72eb80d11 Fixed #23455 -- Accept either bytes or text for related_name, convert to text. 2014-12-12 12:50:39 -07:00
Carl Meyer
8aaf51f94c Revert "Fixed #23455 -- Forced related_name to be a unicode string during deconstruction." 
This reverts commit 45bd7b3bd9.
 2014-12-12 12:50:39 -07:00
Tim Graham
c7a19f4203 Fixed #23857 -- Fixed admin crash with "save as new" and deleting inline. 
Thanks amarandon for the report.
 2014-12-12 10:24:39 -05:00
Josh Smeaton
267a1dcd9b Fixed #23941 -- Removed implicit decimal formatting from expressions. 2014-12-12 10:17:48 -05:00
Kevin Marsh
e2868308bf Fixed template tag braces spacing. 2014-12-12 09:34:18 -05:00
Grzegorz Slusarek
0dea81cd6d Fixed #23674 -- Fixed a crash when a MultiValueField has invalid data. 2014-12-12 08:47:21 -05:00
Shabda Raaj
43041ee48c Refs #18586 -- Refactored expressions tests. 2014-12-11 18:24:23 -05:00
Tim Graham
079ee1ff5d Readded test inadvertently removed in last commit. 2014-12-11 18:01:34 -05:00
Shabda Raaj
6db122c7ab Refs #18586 -- Split custom manager tests. 2014-12-11 17:47:36 -05:00
Shabda Raaj
f66d9a2300 Refs #18586 -- Split custom_pk test. 2014-12-11 17:13:24 -05:00
Thomas Chaumeny
3bb78c5e7a Cleanup cache in contrib.sites to prevent test interference -- refs #11505 2014-12-11 15:56:54 -05:00
Sergey Parkhomenko
059c9ab24c Fixed #23977 -- Added setdefault() method to HttpResponse 2014-12-11 13:56:56 -05:00
Markus Holtermann
44927ba817 Fixed #23956 -- Fixed migration creation for multiple table inheritance 2014-12-11 13:28:21 -05:00
Diego Guimarães
fd60e6c887 Refs #23947 -- Prevented staticfiles tests from having side effects. 2014-12-09 11:17:05 -05:00
Jon Dufresne
4468c08d70 Fixed #23968 -- Replaced list comprehension with generators and dict comprehension 2014-12-08 07:58:23 -05:00
Diego Guimarães
9f427617e4 Refs #23947 -- Worked around a bug in Python that prevents deprecation warnings from appearing in tests. 2014-12-06 14:46:01 -05:00
Aymeric Augustin
1917017b8d Moved misplaced comment. 2014-12-06 20:40:55 +01:00
Tim Graham
40c60efecc Refs #23947 -- Isolated some cache tests. 
Thanks Diego Guimarãesi and Florian Apolloner.
 2014-12-06 13:59:49 -05:00
Diego Guimarães
106dde91e4 Refs #23947 -- Fixed introspection test that had a side effect. 2014-12-06 13:00:25 -05:00
Diego Guimarães
e32a8a99d9 Refs #23947 -- Isolated a mail test. 2014-12-06 12:06:06 -05:00
Tim Graham
3bb52c5019 Refs #23890 -- Restored silencing of numpy DeprecationWarnings in template tests. 2014-12-06 11:27:15 -05:00
Preston Timmons
5c68870169 Fixed #23958 -- Rewrote filter tests as unit tests. 2014-12-06 10:57:46 -05:00
Diego Guimarães
d05709821c Refs #23947 -- Made a modeladmin test cleanup after itself. 2014-12-05 16:19:59 -05:00
Tim Graham
b6ea059b4a Fixed #23957 -- Started deprecation toward requiring session verification. 
Thanks Carl Meyer for review.
 2014-12-05 07:37:34 -05:00
Claude Paroz
8d7a48027e Fixed #23954 -- Added special text/varchar PostgreSQL indexes in migrations 
Thanks adityagupta104 for the report and Tim Graham for the review.
 2014-12-04 21:27:42 +01:00
Thomas Chaumeny
ce2eff7e48 Converted a SimpleTestCase that creates data to TestCase. 2014-12-04 13:24:41 -05:00
Helen ST
7daf00679d Refs #18586 -- Split up order_with_respect_to tests 2014-12-04 11:05:26 -05:00
Tim Graham
765fa36d57 Fixed #23920 -- Fixed MySQL crash when adding blank=True to TextField. 
Thanks wkornewald for the report and Markus Holtermann for review.
 2014-12-04 10:57:10 -05:00
Thomas Tanner
018d110ef5 Fixed #23911 -- Added support for buffer file uploads in the test client 2014-12-04 07:42:03 -05:00
Ramiro Morales
16f26defa7 Converted recently refactored templates tests to SimpleTestCase. 
These test methods don't need DB setup/teardown.

Refs #23768 and b872134b.
 2014-12-03 18:56:46 -05:00
Alexander Shchapov
2cd19f3738 Refs #18586 -- Split up model_inheritance.ModelInheritanceTest 2014-12-03 18:54:47 -05:00
Berker Peksag
560b4207b1 Removed redundant numbered parameters from str.format(). 
Since Python 2.7 and 3.1, "{0} {1}" is equivalent to "{} {}".
 2014-12-03 14:27:38 -05:00
Tim Graham
50c1d8f24b Added a test to verify headers set by default middleware; refs #23939. 2014-12-03 13:47:23 -05:00
Thomas Chaumeny
26dd518b5c Refactored some tests to take advantage of refs #20392. 2014-12-03 10:37:12 -05:00
Thomas Chaumeny
da9fe5c717 Fixed #20392 -- Added TestCase.setUpTestData() 
Each TestCase is also now wrapped in a class-wide transaction.
 2014-12-03 10:37:04 -05:00
Gavin Wahl
dee4d23f7e Fixed #23950 -- Prevented calling deconstruct on classes in MigrationWriter. 2014-12-03 08:22:29 -05:00
Eric Rouleau
9d1a69579b Fixed #23935 -- Converted decimals to fixed point in utils.numberformat.format 2014-12-03 07:49:06 -05:00
Berker Peksag
adacbd64a0 Fixed "no such test method" error in template_tests. 
Without this patch, you couldn't run an individual test
case in template_tests.

Refs #23768
 2014-12-03 13:04:23 +01:00
Preston Timmons
b872134bfc Fixed #23768 -- Rewrote template tests as unit tests. 2014-12-02 19:18:35 -05:00
Shai Berger
4a4ad27712 Marked some tests as expected failures on Oracle/cx_Oracle<=5.1.3/Python3 
Refs #23843 which is really a cx_Oracle bug
 2014-12-03 00:53:27 +02:00
Kamil Braun
0623f4dea4 Fixed #23934 -- Fixed regression in admin views obj parameter. 2014-12-02 08:42:17 -05:00
Preston Timmons
1da1fe8e16 Ensured foreign_object tests reset language properly. 2014-12-02 07:31:52 -05:00
Andriy Sokolovskiy
1739ae9edc Fixed #23807 -- Ignored non-digits in psycopg2 version 2014-12-01 18:42:08 -05:00
Tim Graham
b8cc5f3cd4 Fixed selenium test failure of JavascriptI18nTests. 
The failure was introduced in dd1ea70779.
The tests wouldn't start due to a "Dependency on unknown app" error.
 2014-12-01 16:42:48 -05:00
Tim Graham
82e4f956e3 Fixed #23289 -- Added mock as a test dependency. 2014-12-01 16:08:25 -05:00
Tim Graham
43fcf3505e Fixed admin_views test from refs #7361 (name was too long). 2014-12-01 15:47:41 -05:00
Claude Paroz
e11c6fd218 Fixed #23909 -- Prevented crash when collecting SQL for RunSQL 
Thanks James Rivett-Carnac for the report and Markus Holtermann
for the review.
 2014-12-01 20:26:40 +01:00
Alexander Shchapov
e1513a7960 Fixed #18586 -- Split up model_package.ModelPackageTests. 2014-12-01 12:49:45 -05:00
wrwrwr
b481c85697 Corrected a docstring in tests/migrations/test_operations.py. 2014-12-01 11:37:51 -05:00
wrwrwr
3a8799c8a4 Removed an incorrect docstring in tests/multiple_database/tests.py. 2014-12-01 11:37:08 -05:00
wrwrwr
fce2890e92 Removed a no-op statement in tests/multiple_database/tests.py. 2014-12-01 11:36:54 -05:00
wrwrwr
9136ceb6fb Replaced router.routers usage with override_settings(DATABASE_ROUTERS); refs #23933. 2014-12-01 11:34:15 -05:00
wrwrwr
e6f19ec322 Fixed #23933 -- Made override_settings(DATABASE_ROUTERS) affect the master router. 2014-12-01 11:30:50 -05:00
Markus Holtermann
d2202ec2d4 Fixed #23880 -- Added missing index_together handling for SQLite 2014-12-01 11:30:33 +07:00
wrwrwr
6dbe979b4d Fixed #23930 -- Added copies of captured_std* managers from CPython's test.support. 
StringIO import was adapted for compatibility with Python 2.
 2014-11-29 11:21:58 -05:00
Berker Peksag
c8dcded930 Fixed #17890 -- Added an extra_context parameter to AdminSite.password_change(). 2014-11-29 10:31:09 -05:00
Tim Graham
3131e9cef5 Fixed #23923 -- Promoted Django's deprecation warnings to errors in runtests.py 2014-11-29 10:27:04 -05:00
Tim Graham
8402909876 Silenced all admin validation warnings. 
Warnings could escape depending on the order in which tests were run.
 2014-11-28 19:00:08 -05:00
Thomas Chaumeny
17fe0bd808 Fixed #23423 -- Added unaccent lookup in django.contrib.postgres 2014-11-28 18:22:20 -05:00
Berker Peksag
47789410db Corrected deprecation warnings for RedirectView; refs #21587. 2014-11-28 17:59:55 -05:00
Tim Heap
deb607648e Fixed #23728 -- Added the --exit option to makemigrations. 
If no changes that need migrations are found, `makemigrations --exit`
exits with error code 1.
 2014-11-28 07:48:39 -05:00
Anssi Kääriäinen
ab89414f40 Fixed #23853 -- Added Join class to replace JoinInfo 
Also removed Query.join_map. This structure was used to speed up join
reuse calculation. Initial benchmarking shows that this isn't actually
needed. If there are use cases where the removal has real-world
performance implications, it should be relatively straightforward to
reintroduce it as map {alias: [Join-like objects]}.
 2014-11-28 07:30:26 -05:00
Anssi Kääriäinen
c7175fcdfe Fixed #901 -- Added Model.refresh_from_db() method 
Thanks to github aliases dbrgn, carljm, slurms, dfunckt, and timgraham
for reviews.
 2014-11-28 06:54:00 -05:00
Markus Holtermann
912ad03226 Fixed #23894 -- Made deconstruct methods favor kwargs over args 2014-11-28 06:05:56 -05:00
Martin Blech
e023ceb453 Fixed #23910 -- Added reply_to parameter to EmailMessage 
Thanks to Berker Peksag and Tim Graham for the review and suggestions.
 2014-11-28 06:00:06 -05:00
Thomas Chaumeny
6b5d82749c Fixed #16731 -- Made pattern lookups work properly with F() expressions 2014-11-28 12:50:42 +02:00
Diego Guimarães
f39b0421b4 Fixed #23338 -- Added warning when unique=True on ForeigKey 
Thanks Jonathan Lindén for the initial patch, and Tim Graham
and Gabe Jackson for the suggestions.
 2014-11-27 19:42:30 -05:00
Martin Blech
abf87333a1 Fixed #23924 -- Made EmailMessage raise TypeError for type checks 2014-11-27 18:43:45 -05:00
wrwrwr
7cd3f1c295 Fixed cache state dependence for assertNumQueries in test_group_permission_performance. 
Refs #20432 and #23746.
 2014-11-27 13:02:21 -05:00
Berker Peksag
093e6c68b9 Fixed #14664 -- Logged a warning if MiddlewareNotUsed is raised in DEBUG mode. 2014-11-27 07:55:07 -05:00
Anssi Kääriäinen
bd337184f1 Fixed #23877 -- aggregation's subquery missed target col 
Aggregation over subquery produced syntactically incorrect queries in
some cases as Django didn't ensure that source expressions of the
aggregation were present in the subquery.
 2014-11-27 06:50:08 -05:00
MattBlack85
e9d1f1182a Fixed #23801 -- Added warning when max_length is used with IntegerField 2014-11-26 18:41:54 -05:00
Anssi Kääriäinen
cbb5cdd155 Fixed #23867 -- removed DateQuerySet hacks 
The .dates() queries were implemented by using custom Query, QuerySet,
and Compiler classes. Instead implement them by using expressions and
database converters APIs.
 2014-11-26 17:49:25 -05:00
Baptiste Mispelon
c335c0fee9 Fixed #23914 -- Improved {% now %} to allow storing its result in the context. 
Thanks to Tim for the review.
 2014-11-25 22:11:35 +01:00
Simon Charette
3a9aa155e2 Fixed #23915 -- Made sure m2m fields through non-pk to_field are allowed in the admin. 
refs #23754, #23862
 2014-11-25 15:28:21 -05:00
Simon Charette
f9c4e14aec Fixed #23754 -- Always allowed reference to the primary key in the admin 
This change allows dynamically created inlines "Add related" button to work
correcly as long as their associated foreign key is pointing to the primary
key of the related model.

Thanks to amorce for the report, Julien Phalip for the initial patch,
and Collin Anderson for the review.
 2014-11-25 13:26:50 -05:00
Redouane Zait
8e7b384d89 Fixed #23898 -- Added missing context to admin's deleted_selected view. 
Thanks Redouane Zait for the report.
 2014-11-25 11:22:15 -05:00
Tim Graham
392e11945f Fixed flake8 warnings. 2014-11-25 11:20:40 -05:00
Luke Plant
ff3d746e8d Fixed bug in circular dependency algo for migration dependencies. 
Previous algo only worked if the first item was a part of the loop,
and you would get an infinite loop otherwise (see test).

To fix this, it was much easier to do a pre-pass.

A bonus is that you now get an error message that actually helps you debug
the dependency problem.
 2014-11-25 15:37:34 +00:00
wrwrwr
056a3c6c37 Fixed #23682 -- Enhanced circular redirects detection in tests. 
When the test client detects a redirect to a URL seen in the
currently followed chain it will now raise a RedirectCycleError
instead of just returning the first repeated response.

It will also complain when a single chain of redirects is longer
than 20, as this often means a redirect loop with varying URLs,
and even if it's not actually one, such long chains are likely
to be treated as loops by browsers.

Thanks Preston Timmons, Berker Peksag, and Tim Graham for reviews.
 2014-11-25 10:12:28 -05:00
Adam Alton
a973fb2d68 Fixed and restored assertions in OneToOneTests.test_foreign_key. 
These assertions had been removed in 34ba86706f and 7fe554b2a3,
seemingly because they were referencing the wrong objects, and so
they started failing when the checking of object types (as well as
PK values) was introduced.
 2014-11-25 09:47:32 -05:00
Berker Peksag
9a30acad8a Fixed #21587 -- Added a warning for changing default of RedirectView.permanent. 2014-11-25 09:22:18 -05:00
Tim Graham
d43dd03ca3 Fixed #23890 -- Silenced numpy DeprecationWarnings in template tests. 2014-11-25 09:09:13 -05:00
wrwrwr
e22c64dfc0 Fixed #23742 -- Added an option to reverse tests order. 
This is useful for debugging side effects affecting tests that
are usually executed before a given test. Full suite and pair
tests sort cases more or less deterministically, thus some test
cross-dependencies are easier to reveal by reversing the order.

Thanks Preston Timmons for the review.
 2014-11-24 19:24:11 -05:00
wrwrwr
31f85bae1e Changed test_runner imports to name objects imported from test.runner. 2014-11-24 17:31:39 -05:00
Sergey Fedoseev
1e9ac504e4 Fixed #23888 -- Fixed crash in File.__repr__() when name contains unicode. 2014-11-24 15:54:57 -05:00
Aymeric Augustin
47a131b944 Encapsulated TEMPLATE_STRING_IF_INVALID in Engine. 2014-11-23 11:53:53 +01:00
Aymeric Augustin
29a977ab14 Moved template loaders management in Engine. 
Passed the engine instance to loaders. This is a prerequisite for
looking up configuration on the engine instance instead of global
settings.

This is backwards incompatible for custom template loaders that override
__init__. However the documentation doesn't talk about __init__ and the
way to pass arguments to custom template loaders isn't specified. I'm
considering it a private API.
 2014-11-23 11:52:12 +01:00
Aymeric Augustin
17012b6936 Deprecated dirs argument to override TEMPLATE_DIRS. 
Cancels 2f0566fa. Refs #4278.
 2014-11-23 09:29:33 +01:00
Berker Peksag
da2a35cf9e Silenced a flake8 warning. 
../tests/shortcuts/views.py:45:1: E302 expected 2 blank lines, found 1
 2014-11-22 21:39:06 +02:00
Aymeric Augustin
7331788300 Avoided rewrapping Contexts in render_to_response. 
This change preserves backwards-compatibility for a very common misuse
of render_to_response which even occurred in the official documentation.

It fixes that misuse wherever it happened in the code base and docs.

Context.__init__ is documented as accepting a dict and nothing else.
Since Context is dict-like, Context(Context({})) could work to some
extent. However, things get complicated with RequestContext and that
gets in the way of refactoring the template engine. This is the real
rationale for this change.
 2014-11-22 17:58:38 +01:00
Aymeric Augustin
bf1bd0fbc9 Moved tests for render shortcuts to their own app. 2014-11-22 17:52:43 +01:00
Claude Paroz
b38637d581 Fixed #23887 -- Returned Bad Request for multipart parsing fails 
Thanks Antti Häyrynen and Tim Graham for the report, and Aymeric
Augustin for the review.
 2014-11-22 14:23:37 +01:00
Simon Charette
c7087bc777 Fixed #23862 -- Made ManyToManyRel.get_related_field() respect to_field. 2014-11-21 16:02:31 -05:00
Berker Peksag
343162410f Fixed #21753 -- Raised exception when both form_class and fields are specified. 2014-11-21 14:23:17 -05:00
Alasdair Nicol
5b26a014a8 Fixed #23865 -- documented how to assign errors to a field in Model.clean() 
Also added a unit test wit the simpler syntax which we have documented,
where the dictionary values are strings.
 2014-11-21 13:01:28 -05:00
Simon Charette
8330b50c85 Fixed #23863 -- Made runtests accept the keepdb option. 
refs #20550
 2014-11-21 11:41:13 -05:00
Andrzej Pragacz
72729f844e Fixed #23794 -- Fixed migrations crash when removing a field that's part of index/unique_together. 2014-11-21 10:55:19 -05:00
Jay
f957e2b04c Added a test for model pre/post_init signals. 2014-11-21 10:39:37 -05:00
Tim Heap
5b17dcd8ef Fixed #23883 -- Stopped flatatt modifying its argument 2014-11-21 09:45:08 +01:00
Anssi Kääriäinen
d8f00e1918 Added a comment for test of refs #20278. 2014-11-20 16:26:25 -05:00
Markus Holtermann
4c709cc0ef Fixed duplicate index error on Oracle; refs #23859. 
Refers to regression introduced in 7b4a994599
 2014-11-20 14:42:39 -05:00
Brad Walker
cfa26f29bd Reduced reduce() usage; refs #23796. 
django.core.exceptions.ValidationError.messages() and
django.db.backends.schema.BaseDatabaseSchemaEditor._alter_field():
Replaced reduce(operator.add, ...) w/uncoupled, explicit sum()
 2014-11-20 14:31:14 -05:00
Brad Walker
f273cedc76 Added test for ValidationError.messages 2014-11-20 14:31:14 -05:00
Anssi Kääriäinen
5c481db295 Fixed #23605 -- Fixed nested subquery regression 
Added relabeled_clone() method to sql.Query to fix the problem. It
manifested itself in rare cases where at least double nested subquery's
filter condition might target non-existing alias.

Thanks to Trac alias ris for reporting the problem.
 2014-11-20 13:38:08 -05:00
Patryk Zawadzki
21e21c7bc2 Fixed #23844 -- Used topological sort for migration operation dependency resolution. 
This removes the concept of equality between operations to guarantee
compatilibity with Python 3.

Python 3 requires equality to result in identical object hashes. It's
impossible to implement a unique hash that preserves equality as
operations such as field creation depend on being able to accept
arbitrary dicts that cannot be hashed reliably.

Thanks Klaas van Schelven for the original patch in
13d613f800.
 2014-11-20 12:49:49 -05:00
Berker Peksag
788fa9fffa Fixed #12098 -- Simplified HttpRequest.__repr__(). 2014-11-20 08:45:11 -05:00
Carl Meyer
51f2de1530 Added another migration-executor test to avoid regressions. 2014-11-19 19:43:12 -07:00
Carl Meyer
ab2819aa7b Fixed #23410 -- Avoided unnecessary rollbacks in related apps when migrating backwards. 2014-11-19 16:11:44 -07:00
Carl Meyer
47b7f601ee Fixed #23872 -- Removed sensitivity of migrations tests to CWD. 2014-11-19 15:03:47 -07:00
Aymeric Augustin
b69b4008d1 Removed usage of a global variable. 2014-11-19 21:35:40 +01:00
Aymeric Augustin
f88ad710fa Simplified caching of template context processors. 2014-11-19 21:35:39 +01:00
Aymeric Augustin
a97e72aaab Simplified caching of templatetags modules. 2014-11-19 21:35:39 +01:00
Markus Holtermann
2331650835 Cleaned up and reformatted autodetector tests 2014-11-19 11:09:38 -05:00
Markus Holtermann
f17acd5930 Formatted model states in autodetector tests 2014-11-19 11:09:38 -05:00
Stratos Moros
cf7a2a000e Fixed #22248 -- Made RenameModel reversible 2014-11-19 14:11:35 +02:00
Tim Graham
5617508fb9 Removed nonexistent module django.test._doctest from coveragerc. 2014-11-19 06:01:39 -05:00
Anton Baklanov
d63703f1cd Fixed #18714 -- Added 'fuzzy' compilemessages option 2014-11-18 22:44:16 +01:00
Tillmann Karras
d188101319 Fixed #23799 -- Made makemigrations respect --no-optimize. 
Thanks to yamila-moreno for the idea of a skip message.
 2014-11-18 07:37:06 +01:00
Aymeric Augustin
87f187b960 Adjusted tests for previous commit. 
The test was testing a use case that doesn't happen in real world
projects: developers don't assign settings at run time (and Django
explicitly doesn't support it).
 2014-11-17 23:26:04 +01:00
Aymeric Augustin
a37f452513 Removed superfluous newline. 2014-11-17 22:27:00 +01:00
Markus Holtermann
7b4a994599 Fixed #23859 -- Fixed a migration crash when a field is renamed that is part of an index_together 2014-11-17 19:15:07 +01:00
Ilja Maas
bb4a92d784 Fixed #23840 -- Fixed makemessages find_files method 
Changed the handling of extensions to be used for gettext. Now
obeying the --extension argument. find_files now only find the
given or default extensions and puts only these in the
TranslatableFiles. As a result there are no more confusing messages
for filetypes (extension) not handled by makemessages.
 2014-11-17 09:21:24 +01:00
Julien Phalip
580e9d0045 Fixed a test to correctly calculate a fixture's relative path. 2014-11-17 02:32:04 +01:00
Aymeric Augustin
9eeb788cfb Refactored getting the list of template loaders. 
This provides the opportunity to move utility functions specific to the
Django Template Language outside of django.template.loader.
 2014-11-16 21:41:44 +01:00
Aymeric Augustin
b503fee7ec Removed override_template_loaders and override_with_test_loader. 
They can be replaced with override_settings and that makes the
corresponding tests much more obvious.
 2014-11-16 21:40:50 +01:00
Aymeric Augustin
2577ae6a08 Moved all template loaders under django.template.loaders. 
Reformatted the code of base.Loader according to modern standards.

Turned the test template loader into a regular locmem.Loader -- but
didn't document it.

Added a normal deprecation path for BaseLoader which is a public API.

Added an accelerated deprecation path for TestTemplateLoader which is
a private API.
 2014-11-16 21:28:26 +01:00
Karen Tracey
dec93d8991 Fixed #21612 -- Made QuerySet.update() respect to_field 2014-11-16 15:44:13 +01:00
Josh Smeaton
f61256da3a Renamed qn to compiler 2014-11-16 13:19:34 +01:00
Simon Charette
68ef44c565 Removed references to the deprecated assertRaisesRegexp method. 2014-11-16 02:12:36 +01:00
Danilo Bargen
013b5eacea Added tests/README.rst 2014-11-15 19:47:05 +01:00
Berker Peksag
d2d6c0c097 Fixed #21363 -- Added datetime.timedelta support to TimestampSigner.unsign(). 2014-11-15 19:36:33 +01:00
Claude Paroz
35dac5070b Added a new GeoJSON serialization format for GeoDjango 
Thanks Reinout van Rees for the review.
 2014-11-15 18:07:18 +01:00
Andrew Godwin
c5def493d0 Fixed #23835: Changed circular dependency in DFS to be less infinite 2014-11-15 17:39:02 +01:00
Marc Tamlyn
9a5a4361c5 Merge pull request #3531 from ddaan/ticket_23834 
fixed #23834 -- added test and fix to check for default null on ArrayField
 2014-11-15 15:37:03 +00:00
Daan Vielen
a7c58eaca4 added test and fix to check for default null on ArrayField 2014-11-15 15:20:11 +00:00
Tim Graham
83d104d61a Revert "Use topological sort for migration operation dependency resolution" 
This commit broke the tests on Python 3.

This reverts commit 13d613f800.
 2014-11-15 15:28:04 +01:00
Josh Smeaton
f59fd15c49 Fixed #14030 -- Allowed annotations to accept all expressions 2014-11-15 14:00:43 +00:00
Klaas van Schelven
13d613f800 Use topological sort for migration operation dependency resolution 
rather than an ad-hoc algorithm
 2014-11-15 14:45:42 +01:00
Berker Peksag
d552da1f8d Fixed #22407 -- Added AdminEmailHandler.send_mail(). 2014-11-15 09:38:19 +01:00
Michael Manfre
a305695f28 Merge pull request #3481 from manfre/ticket-16358 
Fixed #16358 - Made memcache backend delete old value on a failure to set.
 2014-11-13 22:10:22 -05:00
Tim Graham
c24a2e6cbd Fixed #23765 -- Removed BooleanField default check which often yielded false positives. 2014-11-13 20:12:29 +01:00
Adam DePue
e118e3af37 Fixed #23761 -- Added test for MySQL validator and db_type is None. 
The issue was fixed on master in e9103402c0
so this just forwardports the test and release notes from stable/1.7.x.

Forwardport of 2d12a59938 from stable/1.7.x
 2014-11-13 11:06:59 +01:00
Tim Graham
dec7da3c4c Fixed flake8 warning. 2014-11-13 10:07:44 +01:00
Sean Wang
311feae8ba Fixed #23806 -- Added a test case for settings.DISALLOWED_USER_AGENTS. 2014-11-13 09:45:14 +01:00
Michael Manfre
bc8abe36ba Fixed #16358 - Made memcache backend delete old value on a failure to set. 
Default Memcached configuration allows for a maximum object of 1MB and
will fail to set the key if it is too large. The key will be deleted from
memcached if it fails to be set. This is needed to avoid an issue with
cache_db session backend using the old value stored in memcached, instead
of the newer value stored in the database.
 2014-11-13 00:46:03 -05:00
Baptiste Mispelon
bfb11b9562 Fixed #23795 -- Fixed a regression in custom form fields 
Custom form fields having a `queryset` attribute but no
`limit_choices_to` could no longer be used in ModelForms.

Refs #2445.

Thanks to artscoop for the report.
 2014-11-12 22:38:18 +01:00
Tim Graham
42b5e4feea Fixed #23730 -- Moved support for SimpleCookie HIGHEST_PROTOCOL pickling to http.cookie. 
This fix is necessary for Python 3.5 compatibility (refs #23763).

Thanks Berker Peksag for review.
 2014-11-12 19:04:45 +01:00
Jozef Knaperek
c56c42b5c0 Fixed #22967 -- Made Model._do_update consistent 
Made _do_update behave more strictly according to its docs,
including a corner case when specific concurent updates are
executed and select_on_save is set.
 2014-11-12 12:53:30 +02:00
Claude Paroz
5ec367ccdd Fixed #23788 -- Used new JavaScript support in recent gettext 
JavaScript string extraction support has been added in gettext
0.18.3.
Thanks Aymeric Augustin for the review.
 2014-11-11 22:52:30 +01:00
Aymeric Augustin
b8ba73cd0c Raised SuspiciousFileOperation in safe_join. 
Added a test for the condition safe_join is designed to prevent.

Previously, a generic ValueError was raised. It was impossible to tell
an intentional exception raised to implement safe_join's contract from
an unintentional exception caused by incorrect inputs or unexpected
conditions. That resulted in bizarre exception catching patterns, which
this patch removes.

Since safe_join is a private API and since the change is unlikely to
create security issues for users who use it anyway -- at worst, an
uncaught SuspiciousFileOperation exception will bubble up -- it isn't
documented.
 2014-11-11 19:05:14 +01:00
averybigant
b7a5b6ab86 Fixed #23750 -- Allowed core.checks.register to be used as a function 2014-11-11 16:29:32 +01:00
Luke Plant
b748a8bc67 Fixed #23789 -- TemplateResponse handles context differently from render 2014-11-10 14:47:45 +00:00
Markus Holtermann
c7c098cf97 Fixed #23770 -- Changed serialization strategy for floats with respect to NaN and Inf 
Thanks to w0rp for the report
 2014-11-06 15:30:30 +01:00
Berker Peksag
df0523debc Fixed #23531 -- Added CommonMiddleware.response_redirect_class. 2014-11-04 17:56:57 -05:00
Tim Graham
ca48cef3b4 Removed unused import. 2014-11-04 11:27:35 -05:00
Peter Inglesby
74e1980cf9 Fixed #13181 -- Added support for callable choices to forms.ChoiceField 
Thanks vanschelven and expleo for the initial patch.
 2014-11-04 11:23:58 -05:00
Marc Tamlyn
36f514f065 Added HStoreField. 
Thanks to `django-hstore` for inspiration in some areas, and many people
for reviews.
 2014-11-04 09:26:40 +00:00
Veres Lajos
a71a2ea756 Fixed typos using https://github.com/vlajos/misspell_fixer 2014-11-03 20:59:30 -05:00
Zan Anderle
7b42036752 Fixed #5405 -- Added admindocs support for reStructured text in model docstrings 
Thanks elvard and gkmngrgn for work on the patch and Markus H. for review.
 2014-11-03 15:30:46 -05:00
Davide Ceretti
2d06e3155a Fixed #23300 -- Made assertTemplateUsed throw an error on responses not fetched using the test client. 
Thanks zags for the report and bmispelon for the patch.
 2014-11-03 14:31:23 -05:00
Thomas Chaumeny
d89f56dc4d Fixed #21281 -- Made override_settings act at class level when used as a TestCase decorator. 2014-11-03 14:14:39 -05:00
Danilo Bargen
8b77b64f1c Refactored URLValidator tests by moving URLs to text files. 2014-11-03 13:02:11 -05:00
Michael Kelly
ebc8e79cf3 Fixed #18523 -- Added stream-like API to HttpResponse. 
Added getvalue() to HttpResponse to return the content of the response,
along with a few other methods to partially match io.IOBase.

Thanks Claude Paroz for the suggestion and Nick Sanford for review.
 2014-11-03 12:29:19 -05:00
Berker Peksag
f7969b0920 Fixed #23620 -- Used more specific assertions in the Django test suite. 2014-11-03 11:56:37 -05:00
Andy Chosak
ceb1ffcc8d Fixed #23420 - broken warning for unbound naive datetime objects 
Fixed issue with warning message displayed for unbound naive datetime
objects when USE_TZ is True. Adds unit test that demonstrates the issue
(discoverable when using a custom lookup in MySQL).
 2014-11-03 15:51:48 +02:00
Unai Zalakain
c548c8d0d1 Fixed #18456 -- Added path escaping to HttpRequest.get_full_path(). 2014-11-03 07:59:19 -05:00
Konrad Świat
934a16dc93 Fixed #23468 -- Added checks for duplicate fixtures directories in loaddata. 
If settings.FIXTURE_DIRS contains duplicates or a default fixture
directory (app_name/fixtures), ImproperlyConfigured is raised.

Thanks to Berker Peksag and Tim Graham for review.
 2014-10-31 18:21:54 -04:00
Markus Holtermann
715ccfde24 Fixed #23738 -- Allowed migrating from NULL to NOT NULL with the same default value 
Thanks to Andrey Antukh for the report.
 2014-10-31 13:30:30 -04:00
Markus Holtermann
ed2f96819c Fixed #23715 -- Prevented urlize from treating a trailing ! as part of an URL 
Thanks to 57even for the report.
 2014-10-31 08:06:40 -04:00
Markus Holtermann
98da408964 Fixed #23670 -- Prevented partial import state during module autodiscovery 
Thanks kostko for the report.
 2014-10-31 08:01:47 -04:00
Aymeric Augustin
c0c1bb9e64 Avoided using private API get_template_from_string. 2014-10-31 11:38:53 +01:00
Simon Charette
f2ddc439b1 Fixed #23656 -- Made FormMixin.get_form's form_class argument optional. 
Thanks Tim Graham for the review.
 2014-10-30 19:10:52 -04:00
twidi
fd061b6591 Fixed #23733 -- Fixed squashing migrations that depend on multiple apps. 2014-10-30 14:39:11 -04:00
Jon Dufresne
eb4f6de980 Fixed #8149 -- Made File.__iter__() support universal newlines. 
The following are recognized as ending a line: the Unix end-of-line
convention '\n', the Windows convention '\r\n', and the old
Macintosh convention '\r'.

http://www.python.org/dev/peps/pep-0278

Thanks tchaumeny for review.
 2014-10-30 11:52:59 -04:00
Markus Holtermann
85086c8158 Fixed #23556 -- Raised a more meaningful error message when migrations refer to an unavailable node 2014-10-30 00:17:29 +01:00
Markus Holtermann
5c9c1e029d Fixed #23614 -- Changed the way the migration autodetector orders unique/index_together 
Thanks to Naddiseo for the report and Tim Graham for the review
 2014-10-29 13:05:42 -04:00
Tim Graham
1e64a1e7b1 Fixed flake8 warnings. 2014-10-28 10:12:10 -04:00
Rigel Di Scala
28634394f5 Fixed #23606 -- Implemented Client and RequestFactory trace() methods. 
Thanks KevinEtienne for the suggestion.
 2014-10-28 10:11:12 -04:00
Collin Anderson
ae7cb992bc Fixed #23721 -- check_related_objects without calling __iter__ 
Refs #14334
 2014-10-28 10:13:50 +02:00
Thomas Chaumeny
00aa562884 Fixed #23493 -- Added bilateral attribute to Transform 2014-10-28 10:02:10 +02:00
Claude Paroz
528c9af543 Fixed #23717 -- Fixed makemessages crash when STATIC_ROOT=None 2014-10-27 13:56:25 +01:00
Tony Zhu
dd1ea70779 Fixed #23699 -- Prevented flush from loading initial data for apps with migrations. 2014-10-27 06:56:44 -04:00
Claude Paroz
7f089ac2e3 Fixed #23446 -- Officially recommended mysqlclient as MySQL driver 
Thanks Corey Farwell for the report and Tim Graham for the review.
Thanks also to Inada Naoki for creating and maintaining mysqlclient.
 2014-10-27 09:11:33 +01:00
Claude Paroz
45db842c9b Fixed #23652 -- Restored database name after destroying test database 
Thanks Bjarkias for the report.
 2014-10-24 17:04:43 +02:00
Claude Paroz
2c9a03d487 Fixed #23707 -- Prevented discovery of duplicated tests 2014-10-23 21:03:57 +02:00
Tim Graham
92269b7b53 Fixed #23702 -- Fixed adding an explicit id field on SQLite. 
Thanks gavinwahl for the report.
 2014-10-23 12:24:34 -04:00
a1tus
2d75515a4c Fixed #23444 -- Deprecated django.contrib.admin.helpers.InlineAdminForm.original_content_type_id 2014-10-23 09:49:24 -04:00
Claude Paroz
70428902c0 Added missing available app in migrations test case 
In some test combinations, having contrib.auth available but not
contrib.contenttypes can produce failures while creating permissions.
 2014-10-23 15:39:26 +02:00
Tim Graham
41b337efa0 Fixed #23630 -- Made AlterModelTable rename auto-created M2M tables. 
Thanks Naddiseo for the report, Andrew Godwin for guidance,
and Shai Berger for review.
 2014-10-23 08:05:39 -04:00
Claude Paroz
bc6caa5d45 Made a doctest compatible with Python 2 
That test might not always execute, but can be executed when the
parent test label is explicitely given.
 2014-10-23 11:16:17 +02:00
Tim Graham
ef9e3c5ed8 Fixed flake8 warning. 2014-10-22 21:21:02 -04:00
Tim Graham
28da093ae2 Allowed test from refs #23612 to be run from a directory other than tests. 2014-10-22 15:24:33 -04:00
Loic Bistuer
b62f72498a Improved warning message when reloading models. Refs #23621. 
Thanks dfunckt and Tim Graham.
 2014-10-23 01:46:04 +07:00
Loic Bistuer
8c4ca16c65 Fixed #23621 -- Warn for duplicate models when a module is reloaded. 
Previously a RuntimeError was raised every time two models clashed
in the app registry. This prevented reloading a module in a REPL;
while it's not recommended to do so, we decided not to forbid this
use-case by turning the error into a warning.

Thanks @dfunckt and Sergey Pashinin for the initial patches.
 2014-10-23 00:55:02 +07:00
Loic Bistuer
eb82fb0a9d Refactored color_style() and no_style() to improve testability. Refs #23663. 
This includes the following improvements:

- The type of the style object is now called 'Style' rather than 'dummy'.
- The new make_style() function allows generating a Style object directly
  from a config string. Before the only way to get a style object was
  through the environ and it also required that the terminal supported
  colors which isn't necessarily the case when testing.
- The output of no_style() is now cached with @lru_cache.
- The output of no_style() now has the same set of attributes as the
  other Style objects. Previously it allowed anything to pass through
  with __getattr__.
 2014-10-22 11:27:00 +07:00
Loic Bistuer
bdb4118b1a Fixed #23686 -- Tweak color output of the system check framework. 
Thanks Tim Graham for the review.
 2014-10-22 11:27:00 +07:00
Loic Bistuer
494ba051bb Made testing of stdout and stderr more consistent. 
Refs #23663.
 2014-10-22 09:25:50 +07:00
Loic Bistuer
533532302a Fixed #23663 -- Initialize output streams for BaseCommand in __init__(). 
This helps with testability of management commands.

Thanks to trac username daveoncode for the report and to
Tim Graham and Claude Paroz for the reviews.
 2014-10-22 09:25:50 +07:00
Tim Graham
494cd857c8 Fixed #23653 -- Fixed Windows failure of a logging test added in refs #23569. 2014-10-21 18:32:46 -04:00
Claude Paroz
bbc3505ef8 Removed unneeded override_system_checks 
Refs #23685.
 2014-10-21 20:54:32 +02:00
Claude Paroz
8b4cc9df9c Fixed #23583 -- More selectively ignored static/media roots 
Fixed a regression introduced by 28efafa24c.
Thanks Michal Čihař for the report and initial patch, and
Collin Anderson and Tim Graham for the reviews.
 2014-10-21 20:18:21 +02:00
Loic Bistuer
c34e13e17c Fixed #23107 -- Made runserver output respect --no-color. 
This commit reverts 67d7da5fb9.

The previous fix changed the environment globally, which meant
that any call to `call_command(no_color=True)` prevented further
`call_command` with color.

This fix still relies on the environment because it's currently the only
way to reach WSGIRequestHandler, but it's now limited to the `runserver`
command. This seems an acceptable compromise considering `runserver` runs
indefinitely.

Thanks Tim Graham for the review.
 2014-10-22 01:03:15 +07:00
Anton Novosyolov
9f1202c166 Fixed #23695 -- Made condition decorator work for HEAD requests without ETag. 2014-10-21 11:13:29 -04:00
Gabe Jackson
0e16c3e3cd Fixed #23396 -- Ensured ValueQuerySets are not checked by check_related_objects. 2014-10-21 10:02:51 -04:00
Claude Paroz
f0bb3c98cc Fixed #21740 -- Allowed test client data to be an empty string 
This fixes a regression introduced by 2a31d00933.
Thanks tony-zhu for the report.
 2014-10-21 09:16:57 +02:00
Michael Manfre
edcb33c92e Fix SettingsCustomLoggingTest on Windows when path contains \u 2014-10-20 21:49:44 -04:00
John-Scott Atlakson
dbf7a3df45 Fixed #23688 -- Updated cached_property to preserve docstring of original function 2014-10-20 17:59:07 -04:00
Jon Dufresne
54e695331b Fixed #20221 -- Allowed some functions that use mark_safe() to result in SafeText. 
Thanks Baptiste Mispelon for the report.
 2014-10-20 17:08:29 -04:00
Claude Paroz
4fe6824ffd Fixed #23679 -- Fixed null introspection for char/text fields 
Thanks Paul Dejean for the report.
 2014-10-20 22:37:19 +02:00
Tianyi Wang
5732424bee Fixed #23629 -- Allowed autodetector to detect changes in Meta.db_table. 
Thanks Naddiseo for reporting.
 2014-10-20 13:14:44 -04:00
Claude Paroz
6d11bb102d Revert "Fixed #23650 -- Prevented migrate from calling checks 3 times" 
This reverts commit 8d6e1afe0b.
call_command now always set skip_checks to True (tested in
user_commands).
 2014-10-20 17:26:00 +02:00
Claude Paroz
685edab9da Fixed #23685 -- Made call_command skip checks by default 
Thanks Loic Bistuer for the report/review and Tim Graham for the
review.
 2014-10-20 17:26:00 +02:00
Loic Bistuer
968510e5d7 Moved a test case that caused deprecation warnings. 
`cache.tests.TestEtagWithAdmin` loaded views from the `admin_views` test
package. This is problematic because when the `cache` test package is
run in isolation, `admin_views` isn't in INSTALLED_APPS, and therefore
loading its models isn't allowed since the app loading refactor.
 2014-10-20 00:22:48 +07:00
Nicholas Serra
6c79d32977 Fixed #23684 -- Used correct package name for Pillow in Error hint. 2014-10-19 13:46:46 +07:00
Thomas Chaumeny
825ea83858 Fixed #21196 -- Removed index on test field causing MySQL specific warning. 2014-10-19 13:44:39 +07:00
Claude Paroz
8d6e1afe0b Fixed #23650 -- Prevented migrate from calling checks 3 times 
Thanks Ilya Baryshev for the report and Tim Graham for the review.
 2014-10-17 20:20:56 +02:00
Tim Graham
7ae03204ac Fixed #23469 -- Removed test runner compatibility check which often yielded false positives. 2014-10-17 10:31:49 -04:00
Rigel Di Scala
a5c77417a6 Fixed #23615 -- Validate that a Model instance's "check" attribute is a method. 
The "check" name is a reserved word used by Django's check framework,
and cannot be redefined as something else other than a method, or the check
framework will raise an error.

This change amends the django.core.checks.model_check.check_all_models()
function, so that it verifies that a model instance's attribute "check"
is actually a method. This new check is assigned the id "models.E020".
 2014-10-16 23:49:21 +07:00
Loic Bistuer
157f9cf240 Minor cleanup in the check_framework test package. 2014-10-16 23:49:21 +07:00
Thomas Chaumeny
b962653060 Fixed #23664 -- Provided a consistent definition for OrderedSet.__bool__ 
This also defines QuerySet.__bool__ for consistency though this should not have any consequence as bool(qs) used to fallback on QuerySet.__len__ in Py3.
 2014-10-16 14:16:24 +02:00
Claude Paroz
374c14b7fd Fixed #23659 -- Kept annotate() args ordering 
Thanks Loic Bistuer and Simon Charette for the review.
 2014-10-16 09:27:20 +02:00
Simon Charette
f6c208d95c Fixed a flake8 warning. 2014-10-15 16:36:11 -04:00
Collin Anderson
a6a8268d19 Fixed #23660 -- Moved sort_dependencies to core. 2014-10-16 03:04:13 +07:00
Anubhav Joshi
10b17a22be Fixed #19508 -- Implemented uri_to_iri as per RFC. 
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
 2014-10-16 02:31:17 +07:00
Florian Apolloner
3af5af1a61 Fixed remaining test failure in jslex tests. 2014-10-15 17:36:19 +02:00
Florian Apolloner
2ccbaba1f2 Added unicode_literals to the jslexer. 
This ensure that ''.join(c) in jslex.py always returns text.
 2014-10-15 15:09:35 +02:00
Claude Paroz
7a893ee771 Fixed #23651 -- Isolated non-existent fixture tests 
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
 2014-10-15 09:17:44 +02:00
Claude Paroz
7131efa154 Adapted invalid cookie test to all Python versions 
Refs #23638. Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
 2014-10-14 09:30:26 +02:00
Claude Paroz
59d487e7fc Fixed #23638 -- Prevented crash while parsing invalid cookie content 
Thanks Philip Gatt for the report and Tim Graham for the review.
 2014-10-13 17:37:58 +02:00
Florian Apolloner
8d789449c7 Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC. 2014-10-12 22:01:24 +02:00
Konrad Świat
06b11b617e Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter. 
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
 2014-10-10 12:10:32 -04:00
Jaap Roes
115c307184 Fixed #23613 -- Deprecated django.utils.checksums 2014-10-10 09:22:20 -04:00
Collin Anderson
4ef9618e12 Avoided requiring sqlparse for a test. 
Refs #23426. Thanks Markus Holtermann for the suggestion.
 2014-10-09 14:59:33 -04:00
Brandon Taylor
16ed35fafc Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows. 2014-10-09 14:58:20 -04:00
Marc Tamlyn
92a17eaae0 Fixed #23627 -- Allowed register_lookup to work as a decorator. 2014-10-09 18:44:58 +01:00
Collin Anderson
d6a87eefd8 Skip another test if sqlparse is not available 
Refs #23426
 2014-10-09 11:54:42 -04:00
Markus Holtermann
f633ba778d Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows 
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
 2014-10-09 21:32:06 +07:00
Tim Graham
30b44cea38 Fixed flake8 warning. 2014-10-08 18:10:50 -04:00
Duncan Parkes
88b6cf4ae4 Fixed #23600 -- Made default_storage aware of more settings changes. 
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
 2014-10-08 18:10:47 -04:00
Artem Rizhov
ca61195827 Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last() 2014-10-08 14:28:38 -04:00
Loic Bistuer
0eccf8fbea Fixed misplaced test case. 2014-10-08 05:11:09 +07:00
Loic Bistuer
ed37f7e979 Fixed #23611 -- update_or_create failing from a related manager 
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
 2014-10-08 03:27:31 +07:00
Jon Dufresne
c1ef234e31 Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes 2014-10-07 13:06:39 -04:00
Browniebroke
d1e87aebf7 Refactored model lookup tests; refs #18586. 2014-10-07 12:04:56 -04:00
Tim Graham
9dff5ce7c7 Fixed #23593 -- Fixed crash in AdminEmailHandler with non-ASCII characters in request. 
Thanks edevil for the report and Simon Charette for review.
 2014-10-06 17:35:53 -04:00
Carl Meyer
6f6e7d01dc Merge pull request #3308 from aericson/ticket_22064 
Fixed #22064 -- Add check for related_name
 2014-10-06 14:06:33 -06:00
Loic Bistuer
ec2fd02bb3 Fixed #23594 -- Fixed deepcopy on ErrorList. 
Thanks Troy Grosfield for the report and Tim Graham for the tests.
 2014-10-07 00:09:55 +07:00
Markus Holtermann
2f16ff5a6c Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs. 2014-10-06 09:31:39 -04:00
Emmanuelle Delescolle
a24cf21722 Fixed #23604 -- Allowed related m2m fields to be references in the admin. 
Thanks Simon Charette for review.
 2014-10-06 08:35:16 -04:00
André Ericson
1e5e2a4707 Fixed #22064 -- Add check for related_name 
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.

Thanks Konrad Świat for the initial work.
 2014-10-04 20:47:26 -03:00
Jon Dufresne
8c581ff394 Fixed #23482 -- Added SingleObjectMixin.query_pk_and_slug 
Enabling the attribute causes get_object() to perform its lookup
using both the primary key and the slug.
 2014-10-02 15:42:30 -04:00
Markus Holtermann
85f6d89313 Fixed #23426 -- Allowed parameters in migrations.RunSQL 
Thanks tchaumeny and Loic for reviews.
 2014-10-02 11:52:40 -04:00
Seth Hill
fe2afcd318 Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG. 2014-09-30 17:13:27 -04:00
Tim Graham
c7b5883c78 Fixed flake8 warnings. 2014-09-30 13:24:20 -04:00
Nick Sandford
f5cfd09c25 Fixed #7361 -- Added cancel link to admin delete views. 2014-09-30 08:45:04 -04:00
Rudy Mutter
a407b846b4 Fixed #23365 -- Added support for timezone-aware datetimes to migrations. 2014-09-29 20:45:43 -04:00
Thomas Chaumeny
311b3ad9db Fixed #23567 -- Made assertQuerysetEqual check Counter equality when ordered=False 2014-09-29 12:00:14 -04:00
Tim Graham
4b257cf261 Fixed flake8 warnings. 2014-09-29 08:13:40 -04:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Shai Berger
c1ae0621ba Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle 
Thanks Claude Paroz for partial fix and Simon Charrette for review
 2014-09-27 09:49:50 +03:00
Claude Paroz
dbdae3a755 Fixed #22738 -- Abstracted boolean field type introspection 
Thanks maxi for the report, Shai Berger for his help with the patch
and Tim Graham for the review.
 2014-09-26 20:03:44 +02:00
Loic Bistuer
b23d47412c Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports. 
Thanks Tim Graham for the review.
 2014-09-27 00:36:28 +07:00
Matt Robenolt
ef5f9b6ae8 Fixed #23460 -- Added literal %s support to extra() QuerySets. 2014-09-26 13:01:27 -04:00
Thomas Chaumeny
17557d068c Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query. 
Thanks lidaobing for the suggestion.
 2014-09-26 12:12:40 -04:00
Markus Holtermann
45bd7b3bd9 Fixed #23455 -- Forced related_name to be a unicode string during deconstruction. 2014-09-25 17:49:44 -04:00
Davide Ceretti
d8e157d5ab Refactored m2m_through tests. Refs #18586 
Refactored old tests that were rewritten 1:1 from doctests.
 2014-09-26 01:28:32 +07:00
Markus Holtermann
215aa4f53b Fixed #23415 -- Added fields for unmanaged and proxy model migrations. 
Thanks sky-chen for the report.
 2014-09-25 10:25:03 -04:00
Marco Buttu
e077c29155 Fixed #23551 -- Fixed bash autocompletion crash on Python 3. 2014-09-25 07:44:22 -04:00
Tim Graham
d7ab2cefb7 Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations." 
This reverts commit abcf28a076.
 2014-09-24 15:49:30 -04:00
Tim Graham
a4f23eba2e Fixed #23421 -- Corrected TEST SERIALIZE setting. 
Thanks gkoller for the report.
 2014-09-24 14:46:10 -04:00
Markus Holtermann
b9a670b227 Fixed #23426 -- Don't require double percent sign in RunSQL without parameters 2014-09-24 07:20:57 -04:00
Tim Graham
0aca91cf7f Fixed flake8 warnings. 2014-09-24 06:32:42 -04:00
Justin Caratzas
cf43a1ee90 Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin. 2014-09-24 06:32:42 -04:00
Loic Bistuer
2f3a4cd573 Removed numbering from the models.py header of some test packages. 
This is a reliqua from the early days of the modeltests/regressiontests era.
 2014-09-24 17:28:56 +07:00
Shai Berger
d128eac316 Changed Oracle test-user creation to grant privileges instead of roles 
because the roles (specifically RESOURCE) are deprecated.
Also added optional support for creating views in tests, and made an
introspection test fail (rather than skip)  if a view cannot be created
due to lacking privileges.

Refs #18782

Thanks Tim Graham for review, and Josh Smeaton
 2014-09-24 04:58:33 +03:00
Loic Bistuer
e043aae9bb Fixed #23550 -- Normalized get_queryset() of RelatedObjectDescriptor 
and ReverseSingleRelatedObjectDescriptor so they actually return QuerySet
instances.

Also ensured that SingleRelatedObjectDescriptor.get_queryset() accounts
for use_for_related_fields=True.

This cleanup lays the groundwork for #23533.

Thanks Anssi Kääriäinen for the review.
 2014-09-24 02:03:12 +07:00
Loic Bistuer
1fd6e13bf2 Consolidated some many_to_one tests. 2014-09-24 02:03:12 +07:00
Claude Paroz
2a1bdf5ced Called table_names instead of get_table_list in migrations 2014-09-23 20:13:31 +02:00
Claude Paroz
ed297061a6 Fixed #18782 -- Prevented sql_flush to flush views 
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
 2014-09-23 20:13:31 +02:00
Sergey Fedoseev
463952d940 Fixed #23503 -- Fixed renaming of model with self-referential m2m field. 2014-09-23 10:03:37 -04:00
Sergey Fedoseev
83cd18633f Fixed #23065 -- Quoted constraint names in SQL generated by migrations. 2014-09-23 09:25:31 -04:00
Loic Bistuer
3c6ac0bab8 Consolidated some text utils into the utils_tests test package. 2014-09-23 19:45:59 +07:00
Loic Bistuer
0dab07e5da Merged custom_managers_regress into the custom_managers test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
d42a45de40 Merged custom_columns_regress into the custom_columns test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
7fe554b2a3 Merged one_to_one_regress into the one_to_one test package. 2014-09-23 03:56:19 +07:00
Claude Paroz
aeb48b9bc5 Fixed an i18n test with native string 
Refs commit 11f307a5a8.
 2014-09-21 17:28:37 +02:00
Yuri Kriachko
11f307a5a8 Fixed #23196 -- Short-circuited empty string translation 
Translating an empty string used to return the gettext catalog
metadata instead of the empty string.
Thanks Ned Batchelder for the suggestion, Tim Graham for the review
and Anton Berezin and Claude Paroz for contributions to the patch.
 2014-09-21 17:08:17 +02:00
Tim Graham
9d30412a5a Fixed some flake8 errors. 
Originally I added migrations to flake8 exclude because of long lines
in migration files, but there are other directories named migrations we
do want to check. We are not warning on line lengths yet anyway.
 2014-09-19 12:31:15 -04:00
Thomas Chaumeny
e008a10c2f Fixed #23443 -- Corrected erroneous FieldError message. 
Thanks Tim Graham for the review.
 2014-09-19 01:01:31 +07:00
Claude Paroz
abc11b0a33 Fixed #23514 -- Prevented queries in PostGISOperations init 
Thanks Mattia Procopio for the report.
 2014-09-18 20:00:35 +02:00
Claude Paroz
fc2b8ddcc8 Fixed #23495 -- Stopped swallowing real settings import error 
Thanks papaloizouc for the report.
 2014-09-17 17:15:44 +02:00
Baptiste Mispelon
d63ac5b595 Fixed #23492 -- Restored F.__deepcopy__. 
This reverts commit 3a66035107.
A regression test was also added.
 2014-09-16 12:19:00 +02:00
Marc Tamlyn
ed7821231b Fixed #19463 -- Added UUIDField 
Uses native support in postgres, and char(32) on other backends.
 2014-09-16 10:08:09 +01:00
valtron
abcf28a076 Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations. 2014-09-15 14:56:59 -04:00
Tim Graham
8ed7834fb2 Fixed occasional selenium test failure on Jenkins with Chrome 36+. 
Previously find_element_by_id('id_password') on the next line failed with
NoSuchElementException and selenium.page_source was
<html xmlns="http://www.w3.org/1999/xhtml"><head></head><body></body></html>.

Possibly related: https://code.google.com/p/selenium/issues/detail?id=1969.
 2014-09-14 20:31:10 -04:00
Jason Hobbs
e1424b2370 Fixed #23397 -- Stripped whitespace from base64 during chunking 
This insures the actual base64 content has a length a multiple of 4.
Also added a test case for the failure.
 2014-09-13 19:06:21 +02:00
Malte Beckmann
22bfc45146 Fixed #23466 -- Removed seconds from all locale time output formats. 2014-09-13 13:00:42 -04:00
José Padilla
5472d18e31 Fixed #23461 -- Added EMAIL_TIMEOUT setting 2014-09-13 09:33:21 -04:00
Szilveszter Farkas
5e32605ce9 Fixed #23483 -- Prevented ImproperlyConfigured with dotted app names 
Made sure the app labels stay unique for the AppConfigStubs, so
migrations wouldn't fail if two dotted app names has the same last part
(e.g. django.contrib.auth and vendor.auth)
 2014-09-12 14:58:54 -06:00
Tim Graham
52ef6a4726 Fixed #17101 -- Integrated django-secure and added check --deploy option 
Thanks Carl Meyer for django-secure and for reviewing.

Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
 2014-09-12 15:05:23 -04:00
Andi Albrecht
00535e8e6b Fixed #20743 -- Added support for keyfile/certfile in SMTP connections. 
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
 2014-09-10 11:14:20 -04:00
Markus Bertheau
61f56e239f Corrected grammar in migrations error message. 2014-09-10 10:32:33 -04:00
Markus Holtermann
6d5958c7a3 Fixed #23452 -- Prevented infinite migrations for empty unique/index_together. 
Thanks fwkroon for the report.
 2014-09-10 07:54:16 -04:00
Claude Paroz
b9d9287f59 Fixed urlize after smart_urlquote rewrite 
Refs #22267.
 2014-09-09 21:59:35 +02:00
Claude Paroz
4b8a1d2c0d Fixed #22267 -- Fixed unquote/quote in smart_urlquote 
Thanks Md. Enzam Hossain for the report and initial patch, and
Tim Graham for the review.
 2014-09-09 21:58:07 +02:00
Aymeric Augustin
9562ffea97 Avoid the word "stupid". 
There's always a better word.
 2014-09-09 20:55:57 +02:00
Flavio Curella
c53f2451a8 Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS 2014-09-09 12:29:30 -04:00
Tim Graham
c32bc1a7a7 Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that don't define get_absolute_url(). 
Thanks jukvalim for the report and initial patch,
and Preston Timmons for review.
 2014-09-09 11:05:31 -04:00
Petras Zdanavičius
f7eee04ebe Fixed #23451 -- Fixed typo in inlineformset_factory() error message. 2014-09-08 17:22:23 -04:00
Aymeric Augustin
b161c01c48 Fixed #22920 -- Avoid masking some exceptions. 
If loading an application trigger an ImportError, the details of that
error were lost in some cases. Thanks Ben Davis for the report.
 2014-09-08 23:16:50 +02:00
Tim Graham
d3543af750 Added sorting to some admin_view tests to prevent transient failures; refs #23380. 2014-09-08 17:10:58 -04:00
Markus Holtermann
16548cfc7c Fixed broken test from da160d440f; refs #23418. 2014-09-08 16:49:06 -04:00
Markus Holtermann
d28b5f13b3 Fixed #23418 -- Fail when migration deconstruct produces invalid import 2014-09-08 21:27:34 +02:00
Simon Charette
342ccbddc1 Fixed #23431 -- Allowed inline and hidden references to admin fields. 
This fixes a regression introduced by the 53ff096982 security fix.

Thanks to @a1tus for the report and Tim for the review.

refs #23329.
 2014-09-08 13:49:07 -04:00
Andrew Pinkham
4680d25df2 Fixed #22951 -- Checked for types during deep_deconstruct migration serialization process. 
Thanks Sam Hartsfield for the report.
 2014-09-08 07:39:09 -04:00
Marc Tamlyn
14c8456ffe Fixed #23416 -- Make sure DatabaseCreation respects checks. 
Migrations respected Field.db_parameters()['check'], but
DatabaseCreation was still using just Field.db_type().
 2014-09-06 19:01:06 +01:00
Baylee Feore
f7d3a6255c Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield 2014-09-05 20:05:51 -04:00
Andrew Godwin
3ab36d0046 Fix Python 3 incompatability 2014-09-05 15:47:20 -07:00
Ben Reilly
b878c73fc3 switch out recursive dfs for stack based approach, to avoid possibly hitting the recursion limit 2014-09-05 15:26:05 -07:00
Claude Paroz
885ff6845e Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting" 
This reverts commit 66757fee7e.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.
 2014-09-05 20:06:02 +02:00
Tim Graham
f8bb8436e5 Corrected deprecation warning silencing of SubfieldBase. 2014-09-05 09:12:14 -04:00
Marc Tamlyn
e9103402c0 Fixed #18757, #14462, #21565 -- Reworked database-python type conversions 
Complete rework of translating data values from database

Deprecation of SubfieldBase, removal of resolve_columns and
convert_values in favour of a more general converter based approach and
public API Field.from_db_value(). Now works seamlessly with aggregation,
.values() and raw queries.

Thanks to akaariai in particular for extensive advice and inspiration,
also to shaib, manfre and timograham for their reviews.
 2014-09-03 20:36:03 +01:00
Raffaele Salmaso
1435cfbe8d Fixed #23302 -- Added --name/-n option to makemigrations command 2014-09-02 21:09:18 -04:00
Dave Hall
e03b7940e5 Fixed #22918 -- Fixed SeparateDatabaseAndState crash 2014-09-02 08:06:44 -04:00
Thomas Chaumeny
032c091659 Fixed #23388 -- Made django.utils.timezone.override usable as a decorator 2014-08-31 09:03:53 +02:00
Alex Gaynor
8b6cb9d0dd Added a missing word in a skip message 2014-08-30 15:18:58 -07:00
Claude Paroz
5021421799 Fixed #22820 -- Treated int and long types alike in lazy_number 
Thanks kwist for the report and the initial patch.
 2014-08-30 18:51:12 +02:00
Ramiro Morales
3a297d7816 Fixed #23055 -- Made generic admin filter obey ModelAdmin queryset. 
Thanks to Trac user synasius and to Ola Sitarska for helping in
identifying the issue and helping with the test case.
 2014-08-30 10:07:00 -03:00
Aymeric Augustin
df251e033c Fixed a PEP 8 error. 2014-08-30 13:27:56 +02:00
Bas Peschier
eacf244506 Converted sql_queries into a lazily evaluated list. 
Fixed #23364. Thanks Markush2010 for the report.
 2014-08-30 13:27:56 +02:00
Akis Kesoglou
6613ea6e3f Fixed #23370 -- defer() + select_related() crashed with inherited models. 2014-08-30 07:14:44 -04:00
Claude Paroz
66757fee7e Fixed #23384 -- Allowed overriding part of a dictionary-type setting 
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
 2014-08-30 12:37:10 +02:00
Joshua "jag" Ginsberg
eb2af16c59 Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal. 2014-08-29 10:12:03 -04:00
Tim Graham
149605dfb4 Fixed flake8 warning. 2014-08-29 09:42:22 -04:00
Vlastimil Zíma
e622caaa85 Fixed #21201 -- Improved customization of ClearableFileInput. 2014-08-29 09:40:08 -04:00
Andrew Torpedov
bc06d2c11c Fixed #23313 -- Corrected repr(RawQuery) with dict parameters. 2014-08-29 07:22:08 -04:00
Simon Charette
e98c5513cb Fixed an Oracle test failure introduced by 1e404180c1. 2014-08-28 19:33:36 -04:00
Thomas Chaumeny
efcbf3e095 Fixed #23381 -- Context manager restored state should be determined in __enter__ 2014-08-28 19:18:34 -04:00
Simon Charette
1e404180c1 Fixed #23379 -- Corrected a referencing issue in sql_create. 
Thanks to Trac alias flakfizer for the report.
 2014-08-28 15:17:50 -04:00
Thomas Chaumeny
2db1ed1033 Fixed #23323 -- Made django.utils.translation.override usable as a decorator. 2014-08-28 11:58:21 -04:00
Claude Paroz
3a44e20005 Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase 
Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
 2014-08-28 08:44:26 +02:00
Simon Charette
3cbb7590cb Fixed #23329 -- Allowed inherited and m2m fields to be referenced in the admin. 
Thanks to Trac alias Markush2010 and ross for the detailed reports.
 2014-08-27 21:26:53 -04:00
Jon Dufresne
f0d3dd4f04 Fixed #23357 -- Added small int introspection support to MySQL backend. 
In the MySQL backend, updated the can_introspect_small_integer feature
flag to True. In data_types_reverse, map FIELD_TYPE.SHORT to a
SmallIntegerField. Added test to verify introspecting SmallIntegerFields
and fixed existing tests influenced by this change.
 2014-08-27 10:58:44 -04:00
areski
a81af7f49d Fixed #13749 -- Added link from admin site to front-end site. 
Thanks romankrv for the suggestion.
 2014-08-27 08:34:53 -04:00
Claude Paroz
00f8b4dfae Lowered memory consumption in debug ouput test 2014-08-26 22:42:41 +02:00
Claude Paroz
5675eb371f Allowed skipIf/UnlessDBFeature to accept several feature strings 2014-08-26 20:03:37 +02:00
Tim Graham
e0cf030194 Removed unnecessary absolute_imports. 2014-08-25 10:07:14 -04:00
Raffaele Salmaso
abd640fbdf Fixed #23341 -- Added migration name to nonexistent migration error in makemigrations. 2014-08-23 19:18:03 -04:00
Raffaele Salmaso
be4baaefe2 Fixed #23352 -- Added tests for MigrationGraph.{forwards,backwards}_plan 2014-08-23 21:35:13 +00:00
Ian Foote
03d89168a2 Fixed #23333 -- Made urlsafe_base64_decode() return proper type on Python 3. 2014-08-22 20:07:12 -04:00
Tim Graham
f9c7732e96 Tweaked docstrings from previous commit. 2014-08-22 15:57:15 -04:00
areski
a6691e5dcf Fixed #23167 -- Added BaseForm.__repr__() 
Thanks Keryn Knight for the idea.
 2014-08-22 15:55:56 -04:00
Shai Berger
56252e7f46 Fixed schema test for Oracle 11.2.0.1 which is used in Django Project's CI. 
Refs #23073 Workaround.

Refs #22738 Repeats the mysql "offense". When the issue is solved, the
Oracle special case should be made to play with the solution (that is,
Oracle should be fixed the same way that mysql and the 3rd-party backneds
are).
 2014-08-22 05:08:53 +03:00
Markus Holtermann
144cff3f51 Fixed #23322 -- Use resolved swappable model for dependency resolution during makemigrations 2014-08-20 16:04:21 -04:00
Simon Charette
53ff096982 Prevented data leakage in contrib.admin via query string manipulation. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
0d8d30b7dd Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Florian Apolloner
28e765810d Prevented reverse() from generating URLs pointing to other hosts. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
6f59d29158 Fixed flake8 warnings. 2014-08-20 14:37:33 -04:00
Tim Graham
d1299fce0e Fixed migrations tests added in refs #23315. 2014-08-20 14:00:59 -04:00
Andrew Godwin
9247da1032 Fixed #23315: Operational dependency fail with mixed create/add 2014-08-19 19:51:12 -07:00
Unai Zalakain
5f2542f12a Fixed #10190 -- Made HttpResponse charset customizable. 
Thanks to Simon Charette, Aymeric Augustin, and Tim Graham
for reviews and contributions.
 2014-08-19 17:34:38 -04:00
Claude Paroz
fa02120d36 Fixed #22996 -- Prevented crash with unencoded query string 
Thanks Jorge Carleitao for the report and Aymeric Augustin, Tim Graham
for the reviews.
 2014-08-19 22:29:31 +02:00
Lee Sanghyuck
11d9cbe2f4 Fixed #23316 -- Added datetime.time serialization in migrations. 2014-08-19 13:31:46 -04:00
Baptiste Mispelon
54164b814c Fixed broken tests on Oracle after 5853c87a45. 
Oracle doesn't have a `BEGIN` statement so the test would
fail.

Refs #23303
 2014-08-19 17:58:30 +02:00
Claude Paroz
6295ea0027 Replaced HAS_SPATIAL_DB by testing database feature 
Refs #22632. This should be the base for using more database
features to exclude specific backends in GIS tests.
Thanks Tim Graham for the review.
 2014-08-19 17:57:01 +02:00
Claude Paroz
132d0e516e Fixed #22171 -- Improved sanitize_separators cleverness 
Thanks Klaas van Schelven for the report and Tim Graham for the
review.
 2014-08-18 19:57:50 +02:00
Claude Paroz
a3d7f58151 Removed test, duplicate of admin_scripts.CommandTypes tests 2014-08-18 19:55:05 +02:00
Tim Graham
f76222e1d3 Fixed flake8 warning. 2014-08-18 13:44:10 -04:00
Gabriel Muñumel
3e241313a4 Fixed #23136 -- Added a message when sqlclear does nothing 2014-08-18 13:20:29 -04:00
Baptiste Mispelon
5853c87a45 Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate. 2014-08-18 18:55:12 +02:00
Raffaele Salmaso
e0a98e2374 Fixed #23309 -- Fixed call_command to parse args correctly 2014-08-18 17:54:24 +02:00
Collin Anderson
230393e5e8 Fixed #23295 -- Removed unnecessary fix_location_header request.get_host() check. 2014-08-15 14:59:36 -04:00
Peter Harley
2724cdbff6 Fixed #18355 -- Added ordering options to list based generic views. 
Added MultipleObjectMixin.ordering and get_ordering().

Refs #21450.
 2014-08-15 11:09:47 -04:00
Tim Graham
0ad4672c0f Fixed typo in tests/migrations/test_operations.py 2014-08-15 11:01:49 -04:00
Tim Graham
e122facbd8 Fixed #23269 -- Deprecated django.utils.remove_tags() and removetags filter. 
Also the unused, undocumented django.utils.html.strip_entities() function.
 2014-08-15 08:20:02 -04:00
Gabriel Muñumel
deed00c0d8 Fixed #23162 -- Renamed forms.Field._has_changed() to has_changed(). 2014-08-15 08:14:45 -04:00
Andrew Godwin
4d2f9c38e8 Fixed #23288: deconstruct() ignoring related_name 2014-08-14 19:47:22 -07:00
areski
3021453285 Fixed #20133 -- Added summary to admin deletion confirmation pages. 
Thanks jonash for the suggestion and initial patch.
 2014-08-14 13:56:23 -04:00
Jaap Roes
b3660d28f3 Fixed #23260: Added generator support to defaultfilters.unordered_list. 2014-08-14 10:43:44 -04:00
Tim Graham
fe38be96c1 Fixed #21579 -- Made LocaleMiddleware respect script prefix. 
Thanks buettgenbach at datacollect.com for the report and patch.
 2014-08-14 09:36:41 -04:00
Claude Paroz
b42e5ca058 Fixed #22971 -- Properly parsed RFC 2388 encoded headers 
Thanks homm for the report, Cea Stapleton for patch improvements
and Ian Cordasco, Christian Schmitt and Tim Graham for the review.
 2014-08-14 11:45:43 +02:00
Florian Apolloner
7244a8d0ae Fixed test failure on python 3.x. 2014-08-14 09:58:15 +02:00
Maxime Turcotte
25e06bca57 Fixed #18767 -- Fixed admin calendar for other locales than English. 
Refactored openCalendar function from DateTimeShortcuts.js. Now, when
entered manually in the input field, the date will show up correctly on
the calendar for locales that don't use "-" for separator.

Thanks charettes for revivew and Alexey Boriskin for some of the patch.
 2014-08-13 20:36:26 -04:00
Shai Berger
2a9f44dfbe Fixed #21603 (again) -- Made a raw query in a test Oracle-compliant 2014-08-14 03:19:22 +03:00
zsoldosp
01801edd37 Fixed #22646: Added support for the MySQL ssl-ca option to dbshell. 2014-08-13 18:29:42 -04:00
Walter Doekes
e0e28bfe71 Fixed #20368 -- Made TECHNICAL_500 more robust against bad input. 
This limits large variables and avoids non-utf-8 in the TECHNICAL_500 output.
 2014-08-13 12:56:26 -04:00
Tim Graham
d38a00332e Updated tests for added newlines in 6868643063. 2014-08-12 20:16:04 -04:00
Trey Hunner
6868643063 Added newlines to the ends of CSS, HTML, and JavaScript files missing them. 2014-08-12 19:22:09 -04:00
Collin Anderson
85c22dd4c4 Fixed #23262 -- Made SelectFilter2.js move items on enter Key press. 2014-08-12 16:17:00 -04:00
Claude Paroz
2cc8ffe258 Fixed #22985 -- Made call_command accept option name parameter 
Thanks giulettamasina for the report and Tim Graham for the review.
 2014-08-12 21:53:29 +02:00
Andrew Godwin
8f9862cd4d Fixed #23275: Unmanaged models kept by autodetector, ignored by ops 2014-08-12 12:49:20 -07:00
Tim Graham
a9fd740d22 Fixed #23276 -- Deprecated passing views as strings to url(). 2014-08-12 13:15:40 -04:00
Anssi Kääriäinen
f7dba61881 Avoided creation of deferred model from another deferred model 
Also never create deferred model when no attrs are deferred.
 2014-08-12 14:58:10 +03:00
Josh Smeaton
5b0375ec3e Fixed #23001 -- Fixed mixing defer and annotations 2014-08-12 14:58:10 +03:00
Jaap Roes
e92b057e06 Fixed #23261 -- Deprecated old style list support for unordered_list filter. 2014-08-11 07:04:33 -04:00
Anssi Kääriäinen
dfadbdac6a Fixed #16426 -- deletion of 1000+ objects with relations on SQLite 
SQLite doesn't work with more than 1000 parameters in a single query.
The deletion code could generate queries that try to get related
objects for more than 1000 objects thus breaking the limit. Django now
splits the related object fetching into batches with at most 1000
parameters.

The tests and patch include some work done by Trac alias NiGhTTraX in
ticket #21205.
 2014-08-11 12:47:37 +03:00
Anubhav Joshi
cdfdcf4b70 Fixed #23266 -- Prevented queries caused by type checking lookup values 
Small modifications done by committer.
 2014-08-11 09:51:57 +03:00
Rajiv Makhijani
f0b358880a Fixed #23259 -- Corrected insertion order of extra() select_params 
A regression caused queries to produce incorrect results for cases where
extra(select) is excluded by values() but included by extra(order_by)

The regression was caused by 2f35c6f10f.
 2014-08-11 09:33:18 +03:00
Andrew Godwin
27b6f28435 Fixed #23264: Schema backends honour db_constraint 2014-08-09 17:50:00 +10:00
Justin Hamade
8fe406864c Fixed #22336 -- Added path matching for makemessages ignore option 
This fixes a regression introduced by 9012a9e200.
 2014-08-08 22:54:30 +02:00
Tim Graham
f53b1c779b Fixed #23099 -- Removed usage of deprecated initial data in Django's test suite. 
Thanks Claude Paroz for assistance with debugging the tests.
 2014-08-08 14:01:59 -04:00
Jacob Haslehurst
f676305ece Fixed #22982 -- Added GenericRelatedObjectManager.__str__. to prevent crash. 
Thanks bendavis78 for the report.

Forwardport of 29585e9b6a from stable/1.7.x
 2014-08-07 14:44:20 -04:00
Tim Graham
57b60f9f93 Added a missing unicode_literals that caused a test failure after refs #23226. 2014-08-07 08:30:50 -04:00
Andrew Godwin
dfe86449c9 Fixed #23244: Error altering FK to non-FK in migrations 2014-08-07 11:52:31 +10:00
Alex Hill
938da36cb1 Fixed #21603 -- Fixed complex RawQuerySets queries on some versions of SQLite. 2014-08-06 08:41:34 -04:00
Tim Graham
fcd42a4819 Removed code that assumed BooleanField could be null. 
Such a field will no longer pass model validation.
 2014-08-05 07:49:53 -04:00
Shai Berger
746f2a4bed Fixed #23061: Avoided setting a limit on a query for get with select_for_update on Oracle 
Thanks Michael Miller for reporting the issue.
 2014-08-05 03:12:08 +03:00
Florian Apolloner
6d256ae248 Fixed test failures from 98e8da3709. 2014-08-04 16:54:43 +02:00
Tim Graham
b50ea73e1e Fixed two tests in previous commit; refs #16311. 2014-08-04 10:21:13 -04:00
Stanislas Guerra
98e8da3709 Fixed #16311 -- Added a RelatedOnlyFieldListFilter class in admin.filters. 2014-08-04 09:39:02 -04:00
Vincent-Vega
5e06fa1469 Fixed #22745 -- Prevented reevaluation of ModelChoiceField's queryset when accesssing BoundField's attrs. 
Thanks Christian Schmitt for review.
 2014-08-04 07:47:37 -04:00
Andrew Godwin
c06e124b5e Fixed #23091: CreateModel and AddField were clashing with deferred SQL 2014-08-04 11:59:29 +10:00
Simon Charette
1b00738f73 Fixed a MySQL test failure introduced by cbb29af1aa. 
Seems like unlike other backends MySQL get_constraints fails when dealing
with a non-existing table. refs #23160.
 2014-08-03 16:32:36 -04:00
Simon Charette
cbb29af1aa Fixed #23160 -- Correctly rename models with self referential fields. 
Thanks to whitews AT gmail for the report.
 2014-08-03 15:27:01 -04:00
Florian Apolloner
40fb6a5601 Revert "Fixed #23088 -- Used six range type in Paginator.page_range." 
This reverts commit 6508db2ff9.

Refs #23088.
 2014-08-03 21:08:24 +02:00
Tim Graham
6e77acc589 Fixed flake8 warning. 2014-08-03 14:21:45 -04:00
qingfeng
0d23450e81 Fixed #19802 -- Fixed HttpResponse.set_cookie() with unicode data on Python 2. 
Thanks django at patrickbregman.eu for the report.
 2014-08-03 12:50:25 -04:00
Tim Graham
0f2ceee025 Fixed #23151 -- Deprecated RegexField.error_message. 
Thanks Baptiste Mispelon for the suggestion.
 2014-08-03 11:21:01 -04:00
Baptiste Mispelon
7432533932 Added missing logic to TimeField.deconstruct(). 
If auto_now or auto_now_add was used then the serialized
field in the migration contained unnecessary `editable` and
`blank` arguments.
 2014-08-03 14:02:21 +02:00
Baptiste Mispelon
72f1eb48df Fixed #23156 -- Added missing BinaryField.deconstruct() method. 2014-08-03 13:02:31 +02:00
Tim Graham
d28396f526 Fixed #23144 -- Dropped support for MySQL 5.0, 5.1. 2014-08-02 10:28:40 -04:00
Tim Graham
a9bdce7e55 Fixed #23108 -- Dropped support for PostgreSQL 8.4 & PostGIS 1.3, 1.4. 
Thanks Claude Paroz for the review.
 2014-08-01 10:26:00 -04:00
Petras Zdanavičius
8b7347220f Fixed #23103 -- Annotated ImageField file with image and content_type attributes. 
Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.
 2014-08-01 09:30:58 -04:00
Niclas Olofsson
cdc25ac474 Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types.. 
Thanks Mattias Lindvall for the report and inital patch.
 2014-07-31 15:29:46 -04:00
Anubhav Joshi
0dd05c9e66 Fixed #16383 -- Raised the AttributeError raised in property of an object when used in a template. 
Thanks maraujop for the report and Hiroki and Tim Graham for review.
 2014-07-31 09:13:55 -04:00
Nick Sandford
9d9f0acd7e Fixed #13163 -- Added ability to show change links on inline objects in admin. 
Thanks DrMeers for the suggestion.
 2014-07-31 08:07:28 -04:00
Tim Graham
9a922dcad1 Fixed flake8 warnings. 2014-07-31 08:06:46 -04:00
Florian Apolloner
4453c80634 Fixed the previous commit for Python3. 2014-07-30 22:22:04 +02:00
areski
97a38de230 Fixed #23112 -- Field.get_choices tries to index an iterable 2014-07-30 21:35:02 +02:00
Tim Graham
c2ab501bab Fixed test failure on Windows. 
os.close(fd) is needed to avoid "The process cannot access the file
because it is being used by another process"
 2014-07-30 14:31:59 -04:00
Christoph Heer
d47409831f Fixed #23067 -- Updated docs to use django-admin 2014-07-30 14:14:03 -04:00
Tim Graham
34c60c42b6 Fixed flake8 errors. 2014-07-30 12:58:53 -04:00
areski
67d7da5fb9 Fixed #23107 -- Made runserver output respect --no-color. 2014-07-30 12:58:53 -04:00
Kit La Touche
17e75d03f9 Fixed #23129 -- Added 'true' and 'false' to NullBooleanField. 
JavaScript serializations of forms will sometimes render the boolean
values as the strings 'true' and 'false', in lower case. Rather than
repeat boilerplate in the JavaScript to circumvent this, it seems
reasonable to allow Django to understand the lower-case versions of the
booleans.
 2014-07-29 19:55:55 -04:00
Andrew Godwin
a338e07735 Fixed #23101: Prefer doing deletes before creates in autodetector. 
Makes declined or missed renames still work (but drop data).
 2014-07-29 09:38:51 -07:00
Marc Tamlyn
ef9f109013 Fixed #22962 -- Default values for ArrayField with migrations. 
Fields normally try to force the default value to a string. As
translatable strings are not valid default values for ArrayField, we can
remove this behaviour which was causing issues with some migrations.

Thanks to @schinckel for the report.
 2014-07-29 10:37:11 +01:00
Andrew Godwin
d6e73a876d Fixed #23121: AlterModelOptions operation not changing state right 2014-07-28 10:47:28 -07:00
Andrew Godwin
cb60d22bd9 Fixed #23100: Individual FK creation missing dependencies 2014-07-28 10:32:43 -07:00
Simon Charette
80708ac772 Fixed #23113 -- ChoiceInput.render should take specified attrs into account. 
Thanks to Tim Graham for the review.
 2014-07-28 10:01:07 -04:00
Aymeric Augustin
729e4ae4f0 Fixed #23074 -- Avoided leaking savepoints in atomic. 
Thanks Chow Loong Jin for the report and the initial patch.
 2014-07-28 14:30:41 +02:00
Florian Apolloner
2f73b527dd Fixed #23098 -- Checked that lazy choices are not evaluated too soon 
Thanks Matthieu Agopian for the report.
 2014-07-27 13:31:25 +02:00
Tushar Bhatia
11181a64f9 Fixed #22979 -- Moved bug* tests 2014-07-26 21:05:49 -04:00
Abraham Martin
e1347e9253 Fixed #23101 db_table wasn't copied in deconstruct 
Forward port of 999758fc7a2d6fcb01eb40de937d4420f884788d from
stable/1.7.x
 2014-07-26 10:00:02 -07:00
Andrew Godwin
805774df1f Fixed #22944: Bad dependency on FK alteration in autodetector 2014-07-26 09:22:19 -07:00
qingfeng
08451f17d0 Fixed #23060 -- Prevented UnicodeDecodeError in debug templatetag 2014-07-26 18:03:19 +02:00
Anubhav Joshi
5cdb8f8c1e Fixed #16617 -- Added 'value' to BaseValidator params. 
Also allowed overriding the default messages in subclasses of BaseValidator.

Thanks sperrygrove for initial patch.
 2014-07-26 10:03:00 -04:00
Hiroki KIYOHARA
d0889863de Fixed code to solve #23070 problem 
Added a class to wrap callable in settings:
* Not to call in the debug page (#21345).
* Not to break the debug page if the callable forbidding to set attributes (#23070).

Thanks @bmispelon for giving me some advice.
 2014-07-26 12:35:51 +02:00
Hiroki KIYOHARA
e569144910 Added test for the #23070 problem 2014-07-26 12:01:44 +02:00
Tim Graham
57d2b3f2a7 Fixed bad usage of rstrip() that caused test failure. 
If the temporary file name contained a p or y as its last
characters, it would be stripped. refs #23083.
 2014-07-25 15:16:47 -04:00
Tim Graham
b8cb5ba708 Fixed #23083 -- Fixed runserver reloading when deleting a file. 
Thanks Collin Anderson for the report and hirokiky for the fix.
 2014-07-25 13:23:52 -04:00
Andrew Godwin
a64bc3df77 Fixed #23093: soft application detection for swapped models 2014-07-25 09:35:38 -07:00
Andrew Godwin
ed4812692e Merge pull request #2938 from dekkers/ticket_23071 
Fixed #23071 -- Use last migration's name in dependency to other app
 2014-07-25 08:53:57 -07:00
Moayad Mardini
6508db2ff9 Fixed #23088 -- Used six range type in Paginator.page_range. 2014-07-25 11:04:58 +03:00
Tim Graham
64e75c47ef Fixed #23014 -- Infinite migration regression with unique/index_together. 2014-07-24 14:27:10 -04:00
Anubhav Joshi
b1abfb3c59 Fixed #21707 -- Added helpful error message when using {{ block.super }} in base template. 
Thanks mitar for the suggestion.
 2014-07-24 14:22:19 -04:00
Tim Graham
99cd80dc74 Silenced test warning for deprecated IPAddressField. 2014-07-24 11:27:26 -04:00
Tim Graham
66211b4b75 Silenced a Python 2 ImportWarning in a migrations test. 2014-07-24 09:24:52 -04:00
Tim Graham
577ced2aae Silenced OptionParser deprecation warning in a test. 2014-07-24 08:51:47 -04:00
Tim Graham
936fba5878 Improved patching of sys.stdout in refs #23078. 2014-07-24 08:46:29 -04:00
Tim Graham
9b1515906e Removed usage of deprecated switch_to_*() selenium methods. 2014-07-24 08:25:15 -04:00
Nick Sandford
fa3cf006b2 Fixed #23078 -- Regression in update_contenttypes() interactivity. 
Thanks raymond at adaptiv.nl for the report.
 2014-07-23 08:45:09 -04:00
Jeroen Dekkers
3582698c13 Fixed #23071 -- Use last migration's name in dependency to other app 
Changed the autodetector to lookup the name of the other app's last
migration in the graph and use that as dependency instead of using
__latest__.
 2014-07-22 01:03:02 +02:00
Andrew Godwin
e24e9e0438 Fixed #23014: Renaming not atomic with unique together 2014-07-21 11:36:34 +01:00
Andrew Godwin
7dacc6ae46 Fixed #23009: Shorten FK identifiers in add_field and make consistent 2014-07-21 10:50:21 +01:00
Andrew Godwin
dcb4ed5170 Fixed #22975: Don't call rename SQL if not needed 2014-07-21 10:14:00 +01:00
Andrew Godwin
2984b30ce8 Fixed #23039: Don't try to serialize unmanaged models in tests 2014-07-21 10:09:31 +01:00
Damien Nozay
70c54a3694 Fixed #23028: Added unique_togther support to inspectdb. 2014-07-18 16:10:59 +00:00
Andrew Godwin
145d231782 Fixed #23041: Bad base dependencies for proxy models 2014-07-16 09:59:08 -07:00
Tim Graham
5954aa6db0 Added Chrome/IE support for a selenium test. 2014-07-16 10:52:49 -04:00
Claude Paroz
c5d8e4a0d1 Added forgotten files from commit 28efafa24c 2014-07-16 13:50:53 +02:00
Anssi Kääriäinen
f8df55050c PEP8 cleanup 2014-07-16 12:48:49 +03:00
Gavin Wahl
6e2b82fdf6 Fixed #22998 -- Updated the fast_delete logic for GFKs 2014-07-16 12:28:00 +03:00
Claude Paroz
28efafa24c Ignored STATIC_ROOT and MEDIA_ROOT in makemessages 
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010).
Thanks Tim Graham for the review.
 2014-07-16 09:38:57 +02:00
Tim Graham
0154965392 Fixed #23013 -- Fixed removing unique_together/index_together constraints in migrations. 
Thanks melinath for the report.
 2014-07-15 15:20:59 -04:00
Marc Tamlyn
b65a2001e7 Fixed #22907 -- Array contains must have same type. 2014-07-15 19:41:26 +01:00
Tim Graham
9a2ab62977 Fixed #23008 -- Fixed typo causing bad migration dependencies. 
Thanks semenov for the report and Florian for investigation.
 2014-07-15 08:48:29 -04:00
Claude Paroz
4e424084e6 Fixed #22991 -- Prevented *.pyc files in autoreload monitoring 
This fixes a regression introduced in 6d302f639.
Thanks lorinkoz at gmail.com for the report, Collin Anderson
for the initial patch and Simon Charette for the review.
 2014-07-15 09:57:54 +02:00
Claude Paroz
5dcdbe95c7 Fixed #23005 -- Allowed specifying special fallback languages 
This fixes the Chinese language issues described in #23005 but
also provides for other fallback exceptions by updating the
LANG_INFO structure.
Thanks caxekis at gmail.com for the report and Tim Graham for the
review.
 2014-07-14 20:50:03 +02:00
Shai Berger
dd9b3312d0 Fixed name of database connection feature 2014-07-14 19:23:57 +03:00
Huu Nguyen
f7a78f9bba Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps. 
Thanks bendavis78 for the report and Tim Graham for the review.
 2014-07-14 11:00:49 -04:00
Anssi Kääriäinen
efe87d3e48 Fixed #22992 -- regression in .filter(generic_fk=...) error message 
Generic Foreign Keys can't be used as lhs in lookups for historical
reasons. Django 1.6 gave a FieldDoesNotExist exception when using GFKs
as lhs in lookups, but due to regression caused by lookup refactor patch
(20bab2cf9d) the exception type was
changed to AttributeError.

It might be a good idea to add support for gfk__exact and gfk__in lookups
later on.

Thanks to glicerinu@gmail.com for the report. The code in this commit
was written by Tim Graham.
 2014-07-14 10:50:41 -04:00
Anssi Kääriäinen
9cd5201abd Fixed #22994 -- regression with generic FK + admin list_view 
The reason for the regression was that the GenericForeignKey field isn't
something meta.get_field_by_name() should return. The reason is that a
couple of places in Django expects get_field_by_name() to work this way.
It could make sense to return GFKs from get_field_by_name(), but that
should likely be done as part of meta refactoring or virtual fields
refactoring patches.

Thanks to glicerinu@gmail.com for the report and to Tim for working on
the issue.
 2014-07-14 10:50:41 -04:00
Tim Graham
38e001ab6c Fixed #22789 -- Deprecated django.contrib.webdesign. 
Moved the {% lorem %} tag to built-in tags.
 2014-07-14 08:45:19 -04:00
Claude Paroz
22b2fb0ba1 Fixed #22939 -- Delayed admin_static backend detection 
Thanks generalov for the report.
 2014-07-12 18:49:43 +02:00
Andrew Godwin
9e5a37c82d Fix comment 2014-07-10 10:00:31 -07:00
Andrew Godwin
008bff92b7 Fixed #22970: Incorrect dependencies for existing migrated apps 2014-07-09 23:53:43 -07:00
Josh Smeaton
b7455b52a0 Fixed #22988 -- Adjusted an introspection test assertion. 
Also changed test to use assertNotIn.
 2014-07-10 00:47:57 -04:00
Anubhav Joshi
011abb7d96 Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField. 
Thanks Loic Bistuer and Tim Graham for help and review.
 2014-07-09 16:01:09 -04:00
Tim Graham
5e2c4a4bd1 Fixed #13794 -- Fixed to_field usage in BaseInlineFormSet. 
Thanks sebastien at clarisys.fr for the report and gautier
for the patch.
 2014-07-09 07:59:20 -04:00
Claude Paroz
e167e96cfe Fixed #22223 -- Prevented over-escaping URLs in reverse() 
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
 2014-07-09 09:54:34 +02:00
Daniel Pyrathon
865bc71783 Added a unit test to ensure models cannot be ordered by a M2M field. 2014-07-08 09:19:08 -04:00
Tim Graham
136a3ffe21 Removed unnecessary directory in dispatch tests. 2014-07-07 19:21:47 -04:00
Tim Graham
fddd95254e Fixed flake8 errors. 2014-07-07 19:12:39 -04:00
Tim Graham
89b9e6e5d6 Fixed #22909 -- Removed camelCasing in some tests. 
Thanks brylie.
 2014-07-07 19:08:42 -04:00
Claude Paroz
6d302f6396 Fixed pyinotify performance regression in 15f82c7011 
Refs #9722. Thanks Tim Graham for the review.
 2014-07-06 21:41:02 +02:00
Claude Paroz
b144bfb5ce Fixed #21079 -- Further normalized table names in inspectdb 
Thanks Michael Manfre for the report and Tim Graham for the review.
 2014-07-06 21:19:27 +02:00
Loic Bistuer
2572c07cc6 Fixed #22906 -- Added a more helpful repr to migrations' ModelState. 
Thanks Collin Anderson for the report and original patch.
 2014-07-06 14:56:18 +07:00
Tim Graham
86c74eacd6 Updated tests per previous commit. 2014-07-05 20:20:19 -04:00
Andrew Godwin
f751109cb2 Merge pull request #2881 from charettes/ticket-22943-compiled-regex-deconstruction 
Fixed #22943 -- Correctly serialize compiled regexes.
 2014-07-05 16:37:10 -07:00
Andrew Godwin
80a12f21e3 Fixed #22960: Bad handling of relations as PKs in autodetector 2014-07-05 16:33:03 -07:00
Claude Paroz
dd9a23d5cf Fixed #22950 -- Eased markup customization for choice field rendering 
Thanks Patrick Robertson for the report.
 2014-07-05 13:36:49 +02:00
Claude Paroz
9209049211 Ensured bound field renders as unicode safe data 
Refs #22950.
 2014-07-05 11:42:27 +02:00
Tim Graham
1f8bb95cc2 Corrected domain max length for EmailValidator; refs #20631. 
Thanks MarkusH for the report.
 2014-07-04 20:50:28 -04:00
Tim Graham
7fd55c3481 Fixed #20631 -- Increased the default EmailField max_length to 254. 
Thanks pmartin for the report.
 2014-07-04 14:15:00 -04:00
Simon Charette
35c2c37041 Fixed #22943 -- Correctly serialize compiled regexes. 
Thanks to antialiasis at gmail dot com for the patch.
 2014-07-04 13:34:20 -04:00
Loic Bistuer
1966054feb Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor. 
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.

Thanks Russell Keith-Magee for the report and Tim Graham for review.
 2014-07-04 17:05:31 +07:00
LarryBrid
1bb1d3168b Updated urlize regex following a93ee5112d 
Prevent urlize from turning some.organization, an.intern etc.
into urls. Refs #22941.
 2014-07-04 09:00:16 +02:00
LarryBrid
a93ee5112d Fixed #22941 - Added support for domain-only links with chars after the TLD to urlize. 
It now works with something like google.com/foo/bar
 2014-07-02 20:36:53 -04:00
Anubhav Joshi
10e83d48a3 Fixed #22935 -- Changed ForeignKey.default_error_messages['invalid'] to refer to correct field. 
Thanks Tim Graham for suggestion and review.
 2014-07-02 13:01:36 -04:00
Colin Wood
27ee608b55 Fixed #22940 -- Added missing string iterpolation parameters in migrations.writer error. 
Forwardport of f5740af868 from stable/1.7.x
 2014-07-02 12:45:02 -04:00
Tim Graham
3de4f8bab6 assertEquals -> assertEqual 2014-07-02 10:11:52 -04:00
Curtis
71461b14ab Fixed #22691 -- Added aliasing to cached_property. 2014-07-01 06:32:53 -04:00
Anubhav Joshi
34ba86706f Fixed #14334 -- Query relation lookups now check object types. 
Thanks rpbarlow for the suggestion; and loic, akaariai, and jorgecarleitao
for reviews.
 2014-07-01 06:12:58 -04:00
Julia Matsieva
29c1151a55 Fixed #22756 -- Added view name to technical 404 template if Http404 is raised. 
Thanks Keryn Knight for the suggestion.
 2014-06-30 15:34:35 -04:00
Anubhav Joshi
fd5897193f Fixed problem with refs #10811. 
When 'to_field' is specified with a FK, then we need to check the pk value
the object.
 2014-06-30 10:25:57 -04:00
Tim Graham
add78c58b5 Added spaces to message from 4c39c270af. 2014-06-30 07:39:35 -04:00
Tim Graham
70576740b0 Fixed #22917 -- Fixed typo in AlterIndexTogether.describe(). 2014-06-27 10:34:48 -04:00
Riccardo Magliocchetti
68c9a72e29 Fixed #22894 -- Made admin add related/raw ID fields widgets customizable. 
Decoupled behavior and style from the RelatedFieldWidgetWrapper and
ForeignKeyRawIdWidget.
 2014-06-26 15:02:42 -04:00
zsoldosp
7e2c804c94 Split tests.basic.ModelTests in several tests; refs #18586. 2014-06-25 15:39:56 -04:00
Tim Graham
e0cd07ec2f Fixed #22903 -- Fixed migration generation if index_together or unique_together is removed from a model. 2014-06-25 10:02:12 -04:00
Tim Graham
e769846eec Removed unused variable. 2014-06-25 08:37:12 -04:00
Lovas Bence
9385aa3198 Fixed #22050 -- Fixed defer fields on proxy related models. 2014-06-25 07:20:18 -04:00
Tim Graham
815e7a5721 Fixed #20128 -- Made CsrfViewMiddleware ignore IOError when reading POST data. 
Thanks Walter Doekes.
 2014-06-25 07:08:16 -04:00
Duncan Parkes
fd4ccd045c Fixed #22799 -- Made GET and POST on HttpRequest QueryDicts, and FILES a MultiValueDict. 
Previously, GET, POST, and FILES on an HttpRequest were created in
the __init__ method as dictionaries. This was not something you would
usually notice causing trouble in production as you'd only see a
WSGIRequest, but in testing using the test client, calling .getlist
on GET, POST, or FILES for a request with no get/post data resulted in
an AttributeError.

Changed GET and POST on an HttpRequest object to be mutable
QueryDicts (mutable because the Django tests, and probably many
third party tests, were expecting it).
 2014-06-24 22:03:22 -04:00
Duncan Parkes
d68987ae25 Fixed #22897 -- Made QueryDict query_string argument optional. 
Now QueryDict() is equivalent to QueryDict('') or QueryDict(None).
 2014-06-24 22:02:03 -04:00
Anubhav Joshi
dbbcfca476 Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True 
Thanks GDorn and gox21 for report.

Thanks Tim Graham for idea and review.
 2014-06-24 08:55:36 -04:00
Andrew Godwin
fe262c0b84 Fixed #22708: Typo in autodetector base dependency gen 2014-06-23 20:48:33 -07:00
Andrew Godwin
0b571753a8 Fixed #22889: Unneeded to_field in fk.deconstruct causing swap issues 2014-06-23 20:39:17 -07:00
Andrew Godwin
0fba4c0ed7 Fixed #22487: Don't flush out data from before normal TestCases 2014-06-23 20:25:09 -07:00
Anubhav Joshi
7f76251fb7 Refactored common code in handlers/base.py and urlresolvers.py 2014-06-23 15:27:25 -04:00
Anubhav Joshi
1c50d6ae2b Fixed problem introduced with #refs 13711. 2014-06-23 19:36:40 +03:00
Tim Graham
908160f692 Fixed test failures introduced by refs #22881. 2014-06-23 09:59:36 -04:00
Claude Paroz
809362518d Created import-time test temp dirs in known location 
Refs #17215. In the same spirit as 5de31cb8cb.
 2014-06-23 14:54:25 +02:00
Claude Paroz
1d9596025e Ensured cache tests do not leak temp dirs 
Refs #17215.
 2014-06-23 14:06:04 +02:00
Chris Beaven
21c496ea52 Fixed #22881 -- Better soft_applied migration detection 2014-06-23 13:36:22 +12:00
Andrew Godwin
b30d32ff24 Fixed #22875: Optimizer did not take through= into account. 2014-06-22 11:23:45 -07:00
Claude Paroz
c6a711d9e5 Removed some apps from ALWAYS_INSTALLED_APPS 2014-06-21 21:01:37 +02:00
Vlastimil Zíma
78c32f1caa Fixed #22514 -- Prevented indexes on virtual fields [postgres]. 2014-06-20 11:59:02 -04:00
Tim Graham
9a46836a0c Moved a line outside of try/except to prevent an error in finally. 
Thanks Ian Foote.
 2014-06-20 09:13:34 -04:00
Huu Nguyen
fbb684d95e Fixed #22862 -- Added --noinput option to makemigrations. 
Thanks artortenburger for the report.
 2014-06-20 08:55:02 -04:00
Daniel Pyrathon
d862fae5bb Refs #12663 -- Added tests for methods in db.models.options. 
Thanks Russell Keith-Magee and Tim Graham for reviews.
 2014-06-19 12:56:36 -04:00
Maxime Turcotte
9996158db4 Fixed #22835 -- Deprecated NoArgsCommand. 2014-06-19 08:54:59 -04:00
Renaud Parent
87d0a3384c Fixed #22778 -- Added a model Meta option to define default_related_name. 
Thanks jorgecarleitao and mmardini for reviews.
 2014-06-18 13:53:07 -04:00
Alex Gaynor
d015c9d11c Fixed several flake8 errors 2014-06-18 07:47:13 -07:00
Andrew Godwin
2cee1d4642 Fixed #22861: Internal migrations done first so __first__ works 
Thanks to Chris Beaven.
 2014-06-17 23:28:35 -07:00
Andrew Godwin
09b63a7cce Fix __latest__ to actually resolve to the latest migration 2014-06-17 22:12:31 -07:00
Andrew Godwin
405b9dcd8b Fix broken test 2014-06-17 21:32:23 -07:00
Andrew Godwin
8d2ac948a9 Fixed #22853: Swapped models are now ignored for migration operations. 2014-06-17 17:45:38 -07:00
Anubhav Joshi
91f1b6dcdc Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database. 
Thanks russellm for report and Tim Graham for review.
 2014-06-17 16:16:02 -04:00
Andrew Godwin
77ff4a9360 Fix previous commit on python 2 2014-06-17 09:56:22 -07:00
Andrew Godwin
66a99fa210 Merge pull request #2824 from valberg/22577 
Fixed #22577: Python 3 broke on non-module migrations directory
 2014-06-17 09:54:39 -07:00
Víðir Valberg Guðmundsson
3a6cb9f497 Fixed #22577: Python 3 broke on non-module migrations directory 2014-06-17 18:21:38 +02:00
Tim Graham
95cc0e15b4 Fixed #22819 -- Renamed output_type -> output_field in query expression API. 
Thanks jorgecarleitao for the suggestion.
 2014-06-17 11:57:16 -04:00
Andrew Godwin
61d7ae31cf Fix test breakage on MySQL 2014-06-17 00:36:27 -07:00
Andrew Godwin
b22917bd50 Fixed #22851: BinaryView wasn't getting a binary default 2014-06-16 18:44:08 -07:00
Tim Graham
82c935d44c Renamed DatabaseFeature.supports_check_constraints to supports_column_check_constraints. 
Thanks maxi for the suggestion.
 2014-06-16 19:25:13 -04:00
Tim Graham
317c480c04 Removed some u'' prefixes to fix Python 3.2. 2014-06-16 18:49:37 -04:00
Vincent-Vega
4529af9ecf Fixed #22845 -- Correctly handled memcached default timeout value. 2014-06-16 16:34:00 -04:00
Tim Graham
b341f33697 Added database migration for contrib.auth. 
refs #22170.
 2014-06-16 16:21:37 -04:00
Tim Graham
eb8600a656 Added database migration for contrib.contenttypes. 
Moved contenttypes tests to allow them to run correctly in the presence of
migrations. refs #22170.
 2014-06-16 15:03:00 -04:00
Andrew Godwin
067b9668fb Fixed #22783: Make sure swappable models come first in creation 2014-06-16 10:20:05 -07:00
Matthew Schinckel
bb39037fcb Fixed #22788 -- Ensured custom migration operations can be written. 
This inspects the migration operation, and if it is not in the
django.db.migrations module, it adds the relevant imports to the
migration writer and uses the correct class name.
 2014-06-16 12:28:52 -04:00
Tim Graham
808388c28c Removed usaged of contrib.sessions as a placeholder in migration tests. 
Without this, we're unable to add actual migrations for the app.
 2014-06-16 10:15:19 -04:00
Andrew Godwin
c8c79367a2 Fixed #22844: Duplicate SQL for SQLite FKs 2014-06-16 00:27:32 -07:00
Alex Gaynor
d17a4cb037 Fixed several flake8 errors 2014-06-15 20:45:15 -04:00
Andrew Godwin
c1276785f9 Fixed #22568: Better proxy model support in migrations 2014-06-15 16:01:49 -07:00
Andrew Godwin
a8ce5fdc28 Fixed #22470: Full migration support for order_with_respect_to 2014-06-15 14:56:51 -07:00
Andrew Godwin
a58f49d104 Persist non-schema-relevant Meta changes in migrations 2014-06-15 12:34:02 -07:00
Andrew Godwin
f717ef083a Fixed #22833: Autodetector not doing through mapping correctly 2014-06-15 12:06:48 -07:00
Claude Paroz
c24e979ece Fixed #7762 -- Hidden full script name in command error output 2014-06-14 20:01:02 +02:00
Claude Paroz
5949c2118d Restored command error behavior when called from command line 
Refs #19973.
 2014-06-14 18:53:33 +02:00
Alex Gaynor
2ca5fc55b0 Fixed several flake8 errors 2014-06-14 10:20:42 -04:00
Claude Paroz
f17b24e407 Converted remaining management commands to argparse 2014-06-14 13:43:44 +02:00
Claude Paroz
4b4524291a Converted test management command to argparse 
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
 2014-06-14 13:43:39 +02:00
Claude Paroz
8568638603 Fixed #19973 -- Replaced optparse by argparse in management commands 
Thanks Tim Graham for the review.
 2014-06-14 11:17:48 +02:00
Mark Lavin
79956d0694 Fixed #22440 -- Updated ConditionalGetMiddleware to comply with RFC 2616. 2014-06-13 20:01:35 -04:00
Shai Berger
612290400f Fixed #22816 -- Corrected Oracle feature flag and fixed introspection test 2014-06-14 00:43:49 +03:00
Xavier Fernandez
50b9313e0a Fixed #22771 -- Fixed test.Client.logout when using custom auth backend. 2014-06-13 13:03:58 -04:00
mlavin
4696cd9671 Fixed #22477 -- Removed contrib middleware from the global settings defaults. 
Also added a compatibility check for changed middleware defaults.

Forwardport of d94de802d3 from stable/1.7.x
 2014-06-13 12:45:56 -04:00
Maxime Turcotte
504c89e800 Fixed #6327 -- Added has_module_permission method to BaseModelAdmin 
Thanks chrj for the suggestion.
 2014-06-13 09:31:40 -04:00
Greg Chapple
bf743a4d57 Fixed #16087 -- Added ResolverMatch instance to test client response. 
Thanks mrmachine for the suggestion.
 2014-06-13 08:50:43 -04:00
Andrew Godwin
7b17350a1b Fixed #22823 (and partly #22563) - FKs from unmigrated apps breaking state. 
Thanks to bendavis78 for the test and diagnostic work.
 2014-06-12 10:22:43 -07:00
Tim Graham
9980f67154 Fixed a staticfiles test on Windows. 2014-06-12 13:08:27 -04:00
Richard Eames
7beaeeed2b Fixed #22814 -- Allowed ISO-8601 [+-]hh timezone format in parse_datetime 2014-06-12 10:58:50 -06:00
Tim Graham
a2cd0e12c9 Silenced deprecation warnings for refs #22811 and fixed build. 2014-06-12 09:28:36 -04:00
Tim Graham
1c58cabad7 Fixed #22811 -- Allowed setting both the old and new TEST database settings. 
An ImproperlyConfigured exception will be raised they mismatch.
 2014-06-12 08:17:49 -04:00
Shai Berger
64d94cffc7 Fixed #22487: Separated schema migration from data migration in test 
The data migration failed on Oracle, killing the entire test suite.

Thanks timo for reporting the Oracle breakage,
and andrewgodwin for suggesting the solution.
 2014-06-11 20:25:02 +03:00
Tim Graham
99f5ea9cc8 Fixed #22653 -- Added some database feature flags to tests. 
Thanks Rahul Priyadarshi.
 2014-06-11 11:45:18 -04:00
Moayad Mardini
5a3ae7e260 Created a new tests folder (model_options). 
And moved `tablespaces` option tests to it.
The new folder can be used to test models/options, like the new option
added in refs #22778.
 2014-06-11 11:37:52 -04:00
Preston Timmons
68efbfde5e Fixed #22068 -- Made runtests.py remove trailing slashes from test labels. 
When using tab-completion it's easy to accidentally run a test with
a trailing slash, which causes INSTALLED_APPS to be set incorrectly.
Normalize the test labels to avoid this common error.

Thanks MattBlack for the suggestion.
 2014-06-11 11:35:33 -04:00
Anubhav Joshi
42736ac8e8 Fixed #21430 -- Added a RuntimeWarning when unpickling Models and QuerySets from a different Django version. 
Thanks FunkyBob for the suggestion, prasoon2211 for the initial patch,
and akaariai, loic, and charettes for helping in shaping the patch.
 2014-06-11 10:03:34 -04:00
Alex Gaynor
e163a3d17b Removed an unused local variable, fixes a flake8 error 2014-06-11 00:22:30 -07:00
Florian Apolloner
e2efc8965e Fixed #22680 -- I/O operation on closed file. 
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
 2014-06-11 08:57:30 +02:00
Tim Schaffer
a1c6cd6a16 Fixed #22780 -- Checked that LOCALE_PATHS is really a tuple 2014-06-10 23:04:24 +02:00
Moayad Mardini
868ff4e37c Fixed #22798 -- pluralize() now adds plural_suffix for any 1 < d < 2 
Thanks Odd_Bloke for the report.
 2014-06-10 16:04:43 -04:00
Greg Chapple
d8f19bb3b6 Fixed #22792 -- Updated checks for list_display_links in model admin 2014-06-10 09:35:05 -04:00
Aymeric Augustin
df09d85482 Fixed #17552 -- Removed a hack for IE6 and earlier. 
It prevented the GZipMiddleware from compressing some data types even on
more recent version of IE where the corresponding bug was fixed.

Thanks Aaron Cannon for the report and Tim Graham for the review.
 2014-06-10 08:42:31 +02:00
Tim Graham
fea8ccdcc4 Removed unused import. 2014-06-09 18:41:35 -04:00
Aymeric Augustin
40bfd8561d Fixed #20420 -- Normalized query counts on Oracle. 
This is achieved by inserting a fake entry in connection.queries when
not releasing a savepoint (since Oracle doesn't support that operation.)

Also removed the can_release_savepoints feature that was recently added,
but is superseded by this solution.
 2014-06-09 21:38:10 +02:00
Andrew Godwin
f146e70cb1 Remove overzealous migration flushes from migration test suite 2014-06-09 09:52:23 -07:00
Claude Paroz
96e4b52ab2 Converted Django scripts to argparse 
Refs #19973.
 2014-06-09 10:13:37 +02:00
Andrew Godwin
7018bcfb71 Fix broken alias testing test 2014-06-08 20:07:35 -07:00
Andrew Godwin
8c12d51ea2 Fixed #22487: Optional rollback emulation for migrated apps 2014-06-08 19:30:15 -07:00
Andrew Godwin
8721adcbfb Fix router_honored test to not close connection 2014-06-08 18:57:55 -07:00
Andrew Godwin
3f91238adf Fixed #22777: Add dependency on through for autodetected M2M adds 2014-06-08 17:12:59 -07:00
Andrew Godwin
4ce7a6bc84 Fixed #22750, #22248: Model renaming now also alters field FKs 2014-06-07 18:18:02 -07:00
Tim Graham
6c27ff957a Fixed flake8 error. 2014-06-07 20:35:28 -04:00
Víðir Valberg Guðmundsson
f70f669941 Fixed #22749: Making SQL management commands migration aware. 2014-06-07 17:18:30 -07:00
Andrew Godwin
6fd455adfc Fixed #22436: More careful checking on method ref'ce serialization 2014-06-07 17:05:51 -07:00
Aymeric Augustin
1a01e24331 Tested pluralization of decimals. 
Refs #16723.
 2014-06-07 23:12:13 +02:00
Aymeric Augustin
47a9347b98 Fixed #6992 -- Improved error when middleware omits HttpResponse. 
Thanks guettli for the report.
 2014-06-07 19:48:45 +02:00
Aymeric Augustin
fc31319752 Fixed test again. Refs #12581. 2014-06-07 17:16:49 +02:00
Aymeric Augustin
58de495c54 Fixed #17427 -- Removed dubious definition of connections equality. 2014-06-07 17:04:10 +02:00
Aymeric Augustin
d98cc41a84 Made a test compatible with Python 2 and 3. 2014-06-07 15:04:06 +02:00
Unai Zalakain
11284a63d4 Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with // 
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server`` and http://test//server`` aren't the same thing
(RFC2396).

Thanks to SmileyChris for the initial patch.
 2014-06-07 08:59:02 -04:00
Aymeric Augustin
cfcca7ccce Fixed #3711, #6734, #12581 -- Bounded connection.queries. 
Prevented unlimited memory consumption when running background tasks
with DEBUG=True.

Thanks Rob, Alex, Baptiste, and others.
 2014-06-07 14:37:43 +02:00
Aymeric Augustin
1181b8a4a9 Merge pull request #2764 from gchp/ticket-20550 
Fixed #20550 -- Added keepdb argument to destroy_test_db
 2014-06-06 14:05:41 +02:00
Claude Paroz
daaeb84158 Fixed #22773 -- Forced templatize() to return unicode 2014-06-06 08:42:52 +02:00
Andrew Godwin
aa12ea05ce Rewrote migration autodetector to involve actual computer science. 
Fixes #22605, #22735; also lays the ground for some other fixes.
 2014-06-05 23:25:35 -07:00
Andrew Godwin
5826dc5282 Merge pull request #2736 from SmileyChris/migration-run_before 
Fixed #22725 - Migration.run_before does nothing
 2014-06-05 20:29:26 -07:00
Aymeric Augustin
e071f67b7f Replaced an explicit vendor check by a feature flag. 
Forward-port of c9aedce0 from stable/1.7.x.
 2014-06-06 00:32:13 +02:00
Aymeric Augustin
5c95a55330 Checked can_introspect_null feature in a test. 
Forward-port of 1238f92c from stable/1.7.x.
 2014-06-06 00:31:51 +02:00
Greg Chapple
72f055e535 Fixed #20550 -- Added keepdb argument to destroy_test_db 2014-06-05 23:17:27 +01:00
Susan Tan
484f3edf1e Fixed #18400 -- Modified length template filter to return 0 for unknown variables. 
Thanks Florian for the bug report, luyikei for the initial code patch, and
Bouke for the code review feedback.
 2014-06-05 15:41:56 -04:00
Anubhav Joshi
5643a3b51b Fixed #10811 -- Made assigning unsaved objects to FK, O2O, and GFK raise ValueError. 
This prevents silent data loss.

Thanks Aymeric Augustin for the initial patch and Loic Bistuer for the review.
 2014-06-05 13:12:01 -04:00
Aymeric Augustin
a03d38ddd4 Added a flag for the ability to introspect nullable fields. 
Previously this was conflated with another Oracle-specific behavior.
 2014-06-05 17:56:56 +02:00
Aymeric Augustin
237c229b91 Avoided using BinaryField unecessarily in tests. 
Several database backends struggle with binary data. This change
minimizes the risk of unrelated tests failures when binary fields
trigger errors.

Forward-port of 2e4bcb9b from stable/1.7.x.
 2014-06-05 17:11:10 +02:00
Aymeric Augustin
ae3fe6ccbb Reordered setUp code in prefetch_related tests. 
This allows these tests to run on databases that reject duplicate NULL
values in unique fields e.g. SQL Server.

Forward port of 4fb50a9a from stable/1.7.x.
 2014-06-05 16:33:02 +02:00
Anubhav Joshi
45e049937d Fixed #13776 -- Fixed ModelForm.is_valid() exception with non-nullable FK and blank=True. 
Thanks peterbe for the report.
 2014-06-04 07:57:19 -04:00
gyx1000
7e2c87809c Fixed #22684 -- Amended SelectDateWidget.empty_label to accept a tuple of values. 
Thanks danielsamuels for the report
 2014-06-04 07:23:25 -04:00
Claude Paroz
fb9d8f0652 Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage 
Thanks David Fischer for the report and Moayad Mardini for the
review.
 2014-06-04 08:53:17 +02:00
Alexandr Shurigin
083d285b82 Fixed #22681 -- Made TarArchive recognize leading directories properly. 2014-06-03 12:00:33 -04:00
Tim Graham
4445d36d47 Fixed #22384 -- Deprecated reversing URLs by dotted path. 2014-06-03 07:30:14 -04:00
Nick Presta
11f0899bbe Fixed #11776 -- Added CSS class for non-field/top of form errors. 
Thanks Daniel Pope for the suggestion.
 2014-06-02 15:22:15 -04:00
Craig de Stigter
ce993efda8 Fixed #22690 -- Added a check for proxy models containing fields. 
Removed the FieldError raised by ModelBase.__new__ in this case.
 2014-06-02 09:32:38 -04:00
Tim Graham
5046c110cf Revert "Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices" 
This reverts commit 9d1987d767.
 2014-06-02 07:05:38 -04:00
Vincent-Vega
d04e730224 Fixed #22711 -- Adjusted ordering checks to allow implicit relation fields. 
refs #19195.
 2014-06-01 15:36:25 -04:00
Simon Charette
7a38f88922 Fixed #22659 -- Prevent model states from sharing field instances. 
Thanks to Trac alias tbartelmess for the report and the test project.
 2014-06-01 15:10:38 -04:00
José L. Patiño
7b064e5390 Split GenericRelationsTests.test_generic_relations into several tests; refs #18586. 2014-06-01 12:36:32 -04:00
Aymeric Augustin
2a5c750ad1 Merge pull request #2726 from gchp/ticket-20550 
Fixed #20550 -- Added ability to preserve test db between runs
 2014-06-01 17:26:56 +02:00
Florian Apolloner
83e7555ffe Revert "Making SQL management commands migration aware." 
This reverts commit cb9c9a7b58.
 2014-06-01 12:00:09 +02:00
Alex Gaynor
a31d7c48b0 Removed an unused import 2014-05-31 10:50:29 -07:00
Moayad Mardini
6f4d7f41b1 Improved the test for refs #22682. 
Thanks apollo13 for the review.
 2014-05-30 11:00:13 -04:00
Andrew Godwin
9cbf7f25ef Fix additional test failures caused by migration pollution 2014-05-29 16:44:12 -07:00
Andrew Godwin
347cab4fae Merge pull request #2744 from mmardini/MIGRATION_MODULES 
Fixed #22682 -- `makemigrations` will create `MIGRATION_MODULES` package
 2014-05-29 15:38:21 -07:00
Moayad Mardini
56cfa508c7 Fixed #22682 -- makemigrations will create MIGRATION_MODULES package 
`makemigrations` will automatically create the package specified
in `MIGRATION_MODULES` if it doesn't already exist.

Thanks ovidiuc4 for the report.
 2014-05-30 01:23:09 +03:00
Víðir Valberg Guðmundsson
cb9c9a7b58 Making SQL management commands migration aware. 2014-05-29 23:03:10 +02:00
Antonis Christofides
62f9508ade Fixed #20401 -- ContentTypeManager.get_for_model reads from db_for_read. 
Thanks Simon Charette and Tim Graham for the reviews.
 2014-05-29 23:01:55 +07:00
Chris Beaven
45fa520187 Implement Migration.run_before 
This attribute (used for reverse dependencies) was previously declared
and mentioned in the code, but never actually used.
 2014-05-29 22:42:11 +12:00
Alex Gaynor
d240b29c08 Fixed a typo that Tim Graham noticed 2014-05-28 17:46:06 -07:00
Alex Gaynor
1dcc603eff Fixed several typos in Django 2014-05-28 17:39:14 -07:00
Andrew Godwin
61185bba72 Merge pull request #2734 from valberg/double_order_trouble 
Fixed #22720 -- Migrations attempt to create _order twice.
 2014-05-28 17:12:01 -07:00
Víðir Valberg Guðmundsson
bf9953cfb8 Adding test to fix of duplicate _order fields (#22720) 2014-05-29 01:38:59 +02:00
Shai Berger
69337d485c Set straight the sense of 'uppercases_column_names' feature flag 2014-05-28 21:16:24 +03:00
Guillaume Pannatier
32586b0ba4 Fixed #22684 -- Added empty_label option on django.forms.extras.widets.SelectDateWidget 
Thanks danielsamuels for the report
 2014-05-28 13:23:28 -04:00
Greg Chapple
b7aa7c4ab4 Fixed #20550 -- Added ability to preserve test db between runs 2014-05-28 16:22:46 +01:00
Aymeric Augustin
4865326f22 Fixed #22699 -- Configure default settings in some management commands. 
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.

Thanks Claude for the review.
 2014-05-27 21:43:52 +02:00
Moayad Mardini
2e613ea5c5 Fixed #22675 -- makemigrations --dry-run to output migrations to stdout. 
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
 2014-05-27 00:40:55 +03:00
Florian Apolloner
ee51ab9d23 Restored Python 2 compatibility. 2014-05-26 00:07:15 +02:00
Florian Apolloner
9d1bf8f841 Removed executeable bit from a few files. 2014-05-25 23:16:40 +02:00
Florian Apolloner
536ebaa048 Fixed a few warnings in the testsuite. 2014-05-25 23:14:50 +02:00
Loic Bistuer
417ec4a68b Fixed a ResourceWarning that wasn't properly fixed by the previous commit. 
Also removed unused import in runtests.py.
 2014-05-26 04:01:41 +07:00
Loic Bistuer
b7de5f5d3f Fixed a few ResourceWarning in the test suite. Refs #22680. 2014-05-26 03:23:17 +07:00
Moayad Mardini
63fc91b3ca Fixed #22676 -- makemigrations --dry-run should not ask for defaults 
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
 2014-05-24 09:56:18 -04:00
Marc Tamlyn
9fb0f5dddc Fixed #22510 -- Harden field removal to only None. 
Refs #8620.

If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.

Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.

Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
 2014-05-24 13:10:50 +01:00
Claude Paroz
f47e226ff7 Moved some imports in runtests.py 2014-05-24 13:29:23 +02:00
Claude Paroz
19b4908206 Made runtests.py use 'set_installed_apps' API 
This will also trigger the ready method of any tested application,
which was not run before.
 2014-05-24 11:02:58 +02:00
Baptiste Mispelon
f01d2a8f9b Fixed tuple serialization test. 
Thanks to rockallite for the report.
 2014-05-23 14:50:10 +02:00
Huu Nguyen
f851a954ac Fixed #22602 -- Improved code coverage of makemigrations command tests. 2014-05-23 08:05:46 -04:00
Preston Timmons
be88b062af Fixed #21357 -- Fixed test client session initialization. 
The test client will now create a session when it is first accessed
if no session already exists.
 2014-05-22 20:29:48 -04:00
Unai Zalakain
4dc4d12e27 Fixed #21598 -- cleaned up template loader overrides in tests 
- Template loader overriding is managed with contexts.
- The test loader is a class (function based loaders entered deprecation timeline
  in 1.4).
- Template loader overrider that overrides with test loader added.
 2014-05-22 18:35:16 -04:00
Flavio Curella
beec05686c Fixed #22667 -- Replaced leader/follower terminology with primary/replica 2014-05-22 11:59:17 -04:00
Moayad Mardini
ad994a3c5b Fixed #22679 -- Fixed empty tuple serialization in MigrationWriter. 
Thanks rockallite.wulf for the report.
 2014-05-22 16:15:09 +02:00
Marc Tamlyn
635acf42c5 Fix a test dependent on json ordering. 2014-05-22 15:05:19 +01:00
Marc Tamlyn
6ab67919ac Made nested deconstruction support both forms of deconstruct() 
Nested deconstruction should (silently) handle Field.deconstruct() as
well as other arbitrary deconstructable objects. This allows having a
field in the deconstruction of another field.
 2014-05-22 13:23:51 +01:00
Marc Tamlyn
604162604b Added array field support for PostgreSQL. 
The first part of django.contrib.postgres, including model and two form
fields for arrays of other data types.

This commit is formed of the following work:

    Add shell of postgres app and test handling.

    First draft of array fields.

    Use recursive deconstruction.

    Stop creating classes at lookup time.

    Add validation and size parameter.

    Add contained_by lookup.

    Add SimpleArrayField for forms.

    Add SplitArrayField (mainly for admin).

    Fix prepare_value for SimpleArrayField.

    Stop using MultiValueField and MultiWidget.

    They don't play nice with flexible sizes.

    Add basics of admin integration.

    Missing:
    - Tests
    - Fully working js

    Add reference document for django.contrib.postgres.fields.ArrayField.

    Various performance and style tweaks.

    Fix internal docs link, formalise code snippets.

    Remove the admin code for now.

    It needs a better way of handing JS widgets in the admin as a whole
    before it is easy to write. In particular there are serious issues
    involving DateTimePicker when used in an array.

    Add a test for nested array fields with different delimiters.

    This will be a documented pattern so having a test for it is useful.

    Add docs for SimpleArrayField.

    Add docs for SplitArrayField.

    Remove admin related code for now.

    definition -> description

    Fix typo.

    Py3 errors.

    Avoid using regexes where they're not needed.

    Allow passing tuples by the programmer.

    Add some more tests for multidimensional arrays.

    Also fix slicing as much as it can be fixed.

    Simplify SplitArrayWidget's data loading.

    If we aren't including the variable size one, we don't need to search
    like this.
 2014-05-22 09:53:26 +01:00
Ramiro Morales
fce6a29428 Merge pull request #2498 from ramiro/move-serverhandler 
Moved ServerHandler helper class to tests.
 2014-05-21 18:59:01 -03:00
Ramiro Morales
d731f48ece Merge pull request #2679 from ramiro/t22421 
Fixed #22421 -- Regression in fixtures loading.
 2014-05-21 18:57:46 -03:00
Martin Brochhaus
bb0a9a070b Fixed #20477: Allowed list of modules for FORMAT_MODULE_PATH 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path). A feature has been added to also allow a list of strings.

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-21 07:35:47 -04:00
Tim Graham
dfeef8e147 Skipped a migrations test that's not supported on MySQL + Python 3. 2014-05-21 06:54:24 -04:00
Loic Bistuer
870b0a1f86 Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups. 
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650.
 2014-05-21 10:30:48 +07:00
Loic Bistuer
bdf3473e64 Fixed #22650 -- Fixed regression on prefetch_related. 
Regression from f51c1f59 when using select_related then prefetch_related
on the reverse side of an O2O:

Author.objects.select_related('bio').prefetch_related('bio__books')

Thanks Aymeric Augustin for the report and tests. Refs #17001.
 2014-05-21 10:26:04 +07:00
Alex Gaynor
8a95b4fca7 Merge pull request #2692 from fcurella/patch-5 
#22667 replaced occurrences of master/slave terminology with leader/follower
 2014-05-20 09:37:04 -07:00
Flavio Curella
73a57b06f9 replaced occurrences of master/slave terminology with leader/follower 2014-05-20 11:35:16 -05:00
Denis Cornehl
3bec38888f Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files. 
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.

Thanks to tedtieken for the report
 2014-05-20 18:14:49 +02:00
Andrew Godwin
03900a02d5 Fixed #22432: SQLite M2M repointing now works. Thanks to xelnor. 2014-05-20 16:25:59 +01:00
Andrew Godwin
4e32e47348 Merge pull request #2634 from loic/ticket22424 
Fixed #22424 -- MySQL doesn't accept migrations' one-off default values ...
 2014-05-20 14:25:59 +01:00
Huu Nguyen
44304cf04e Fixed #22661 -- Move makemigrations tests to the proper class 2014-05-19 20:16:36 -07:00
Marc Tamlyn
3b765029f0 Fix a2dd618 for mysql. 2014-05-19 14:59:02 +01:00
Tim Graham
5abc811a40 Revert "Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules." 
This reverts commit 950b6de16a.
 2014-05-19 08:22:46 -04:00
Martin Brochhaus
950b6de16a Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules. 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path).

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-19 07:59:13 -04:00
Esau Rodriguez
ec9043ab2f Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models. 2014-05-18 15:52:07 -04:00
Huu Nguyen
949ee521fa Refs #21230 -- removed direct settings manipulation from staticfile tests 2014-05-18 14:27:35 -04:00
Loic Bistuer
5789ff7330 Failing testcases for #22649. 2014-05-18 12:46:12 +07:00
Loic Bistuer
1d3d01b4f7 Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL. 
Thanks syphar for the review and suggestions.
 2014-05-18 11:58:16 +07:00
Ramiro Morales
862e1ff234 Fixed #22421 -- Regression in fixtures loading. 
Loading fixtures were failing since the refactoring in 244e2b71f5 for
inheritance setups where the chain contains abstract models and the
root ancestor contains a M2M relation.

Thanks Stanislas Guerra for the report.

Refs #20946.
 2014-05-17 17:36:45 -03:00
Markus Amalthea Magnuson
f7845449b4 Moved wordwrap test to their own function 
The `wordwrap` tests were in the `test_wordcount()` method for some
reason. This moves them to their own method, and make consistent use of
double quotes where needed.
 2014-05-17 20:42:58 +02:00
Alex Gaynor
b6b873d2ad Fixed several flake8 errors, including one where a test wouldn't be run 2014-05-17 09:54:34 -07:00
Marc Tamlyn
a2dd618e3b Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform. 
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
 2014-05-17 12:26:15 +02:00
Florian Apolloner
11932e978f Merge pull request #2346 from Markush2010/ticket21905 
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
 2014-05-17 12:09:04 +02:00
Unai Zalakain
ebb0279f4a Fixed #16245 -- Included traceback in send_robust()'s response 
Exceptions from the (receiver, exception) tuples returned by
``send_robust()`` now have always their traceback attached as their
``__traceback__`` argument.
 2014-05-16 18:41:40 -04:00
Aymeric Augustin
1109ebd7b3 Optimized make_aware/naive by removing redundant checks. Refs #22625. 
Also added tests with pytz and removed misplaced tests.
 2014-05-16 23:12:59 +02:00
Aymeric Augustin
fa89acf1d0 Fixed #22625 -- Normalized make_aware/naive errors. 
Also added tests for is/make_aware/naive.

Thanks Tom Michaelis for the report.
 2014-05-16 22:52:10 +02:00
Shai Berger
6bb6df2943 Fix storing of binary fields and unicode textfields for Oracle/Python3 2014-05-16 20:08:52 +03:00
Markus Holtermann
9d8c73f6a1 Fixed #21905 -- Add info message if DateField or TimeField use a fixed value 2014-05-16 18:59:31 +02:00
Stas Rudakou
ebd70d4d00 Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin) 2014-05-16 18:33:17 +02:00
Vlad Starostin
1be03aff5c Fixed #18389 -- Fixed the way contribute_to_class is called 
Now this method is only called only if the object is an instance.
This allows to have field classes as model class attributes.
 2014-05-16 10:40:07 -04:00
Russell Keith-Magee
2c176eb95c Refs #21798 - Modified error number to provide room for future expansion. 2014-05-16 15:41:17 +02:00
Moayad Mardini
393ddc10a7 Fixed #22531 -- Added tree.Node.__repr__ and tests for the class. 
While Node class has a useful `__str__`, its `__repr__` is not that
useful. Added a `__repr__` that makes use of the current `__str__`.
This is especially useful since the more popular `Q` class inherits
`tree.Node`. Also created new tests that cover most of `Node` class
functionality.
 2014-05-16 09:30:25 -04:00
Alex Gaynor
fadc6cd1bd Removed an unused import 2014-05-16 09:24:41 -04:00
Nikolaus Schlemm
1ab278f39d Fixed #22490 -- removed obsolete ComplexFeed class from syndication_tests 
It was previously used in a test that was deprecated and then removed, this cruft can be removed now.
 2014-05-16 09:22:36 -04:00
Erik Romijn
424fe76349 Fixed #22579 -- Corrected validation for email to reject trailing slash 
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
 2014-05-16 15:13:11 +02:00
Stephen Burrows
d64f192df1 Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra. 
Forwardport of 79f15ab1ef from stable/1.7.x
 2014-05-16 06:38:24 -04:00
Marc Tamlyn
4a98130735 Merge pull request #2657 from nschlemm/20140516-test_testcase_ordering 
cater for running tests from another directory than tests
 2014-05-16 12:30:39 +02:00
Nikolaus Schlemm
d11e836203 cater for running tests from another directory than tests - applying existing pattern to newly added test_testcase_ordering as well 2014-05-16 12:11:35 +02:00
Claude Paroz
f5d4b45df1 Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found 
Thanks nikolay.v.golub@gmail.com for the report.
 2014-05-16 12:08:31 +02:00
Daniel Pyrathon
cb15231888 Fixed #21798 -- Added check for DateTime mutually exclusive options 
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
 2014-05-16 05:57:19 -04:00
Claude Paroz
e520a73eee Harmonized some PEP 0263 coding preambles 2014-05-15 19:58:41 +02:00
Anders Steinlein
4ef10f245a Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin. 
Thanks Stephen Burrows for work on the patch as well.

Forwardport of 2914f66983a92fcae55673c517dd8d01e8c238c4 from stable/1.7.x
 2014-05-15 07:25:35 -04:00
Erik Romijn
255449c1ee Added additional checks in is_safe_url to account for flexible parsing. 
This is a security fix. Disclosure following shortly.
 2014-05-14 10:19:48 +02:00
Aymeric Augustin
3800f63721 Dropped fix_IE_for_vary/attach. 
This is a security fix. Disclosure following shortly.
 2014-05-14 10:19:48 +02:00
Julen Ruiz Aizpuru
5eb81ce445 Fixed #22533 -- Added label_suffix parameter to form fields. 
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.

This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.

Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.

Refs #18134.
 2014-05-13 09:09:33 -04:00