Hopiu/django
1
0
Fork 0
mirror of https://github.com/Hopiu/django.git synced 2026-04-04 07:10:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
22363 commits 1 branch 0 tags 216 MiB
Commit graph

7671 commits

Author SHA1 Message Date
Collin Anderson
a6a8268d19 Fixed #23660 -- Moved sort_dependencies to core. 2014-10-16 03:04:13 +07:00
Anubhav Joshi
10b17a22be Fixed #19508 -- Implemented uri_to_iri as per RFC. 
Thanks Loic Bistuer for helping in shaping the patch and Claude Paroz
for the review.
 2014-10-16 02:31:17 +07:00
Florian Apolloner
3af5af1a61 Fixed remaining test failure in jslex tests. 2014-10-15 17:36:19 +02:00
Florian Apolloner
2ccbaba1f2 Added unicode_literals to the jslexer. 
This ensure that ''.join(c) in jslex.py always returns text.
 2014-10-15 15:09:35 +02:00
Claude Paroz
7a893ee771 Fixed #23651 -- Isolated non-existent fixture tests 
Previous versions of the tests were buggy, as initial_data.json
did exist and the test wasn't failing. It was finally failing on
Python 3.4.2.
Thanks Raphaël Hertzog for the report (and Debian bug #765117
contributors).
 2014-10-15 09:17:44 +02:00
Claude Paroz
7131efa154 Adapted invalid cookie test to all Python versions 
Refs #23638. Older Python versions are less strict when parsing
invalid cookie content. The test just has to ensure Django doesn't
crash.
 2014-10-14 09:30:26 +02:00
Claude Paroz
59d487e7fc Fixed #23638 -- Prevented crash while parsing invalid cookie content 
Thanks Philip Gatt for the report and Tim Graham for the review.
 2014-10-13 17:37:58 +02:00
Florian Apolloner
8d789449c7 Fixed #23063 -- Convert \n and \r to \r\n when using the SMTP backend as per RFC. 2014-10-12 22:01:24 +02:00
Konrad Świat
06b11b617e Fixed #23616 - Fixed generic relations in ModelAdmin.list_filter. 
Thanks ranjur for reporting bug, timgraham for review,
and collinanderson for contributing tips.
 2014-10-10 12:10:32 -04:00
Jaap Roes
115c307184 Fixed #23613 -- Deprecated django.utils.checksums 2014-10-10 09:22:20 -04:00
Collin Anderson
4ef9618e12 Avoided requiring sqlparse for a test. 
Refs #23426. Thanks Markus Holtermann for the suggestion.
 2014-10-09 14:59:33 -04:00
Brandon Taylor
16ed35fafc Fixed #23612 -- Normalized fixuture paths to allow referencing relative paths on Windows. 2014-10-09 14:58:20 -04:00
Marc Tamlyn
92a17eaae0 Fixed #23627 -- Allowed register_lookup to work as a decorator. 2014-10-09 18:44:58 +01:00
Collin Anderson
d6a87eefd8 Skip another test if sqlparse is not available 
Refs #23426
 2014-10-09 11:54:42 -04:00
Markus Holtermann
f633ba778d Fixed #23609 -- Fixed IntegrityError that prevented altering a NULL column into a NOT NULL one due to existing rows 
Thanks to Simon Charette, Loic Bistuer and Tim Graham for the review.
 2014-10-09 21:32:06 +07:00
Tim Graham
30b44cea38 Fixed flake8 warning. 2014-10-08 18:10:50 -04:00
Duncan Parkes
88b6cf4ae4 Fixed #23600 -- Made default_storage aware of more settings changes. 
Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
 2014-10-08 18:10:47 -04:00
Artem Rizhov
ca61195827 Fixed #23555 -- Avoided suppressing IndexError in QuerySet.first() and .last() 2014-10-08 14:28:38 -04:00
Loic Bistuer
0eccf8fbea Fixed misplaced test case. 2014-10-08 05:11:09 +07:00
Loic Bistuer
ed37f7e979 Fixed #23611 -- update_or_create failing from a related manager 
Added update_or_create to RelatedManager, ManyRelatedManager and
GenericRelatedObjectManager.
Added missing get_or_create to GenericRelatedObjectManager.
 2014-10-08 03:27:31 +07:00
Jon Dufresne
c1ef234e31 Fixed #23522 -- Changed reverse() to return a Unicode string; not bytes 2014-10-07 13:06:39 -04:00
Browniebroke
d1e87aebf7 Refactored model lookup tests; refs #18586. 2014-10-07 12:04:56 -04:00
Tim Graham
9dff5ce7c7 Fixed #23593 -- Fixed crash in AdminEmailHandler with non-ASCII characters in request. 
Thanks edevil for the report and Simon Charette for review.
 2014-10-06 17:35:53 -04:00
Carl Meyer
6f6e7d01dc Merge pull request #3308 from aericson/ticket_22064 
Fixed #22064 -- Add check for related_name
 2014-10-06 14:06:33 -06:00
Loic Bistuer
ec2fd02bb3 Fixed #23594 -- Fixed deepcopy on ErrorList. 
Thanks Troy Grosfield for the report and Tim Graham for the tests.
 2014-10-07 00:09:55 +07:00
Markus Holtermann
2f16ff5a6c Fixed #23601 -- Ensured view exists in URLconf before importing it in admindocs. 2014-10-06 09:31:39 -04:00
Emmanuelle Delescolle
a24cf21722 Fixed #23604 -- Allowed related m2m fields to be references in the admin. 
Thanks Simon Charette for review.
 2014-10-06 08:35:16 -04:00
André Ericson
1e5e2a4707 Fixed #22064 -- Add check for related_name 
Validates that related_name is a valid Python id or ends with a '+' and
it's not a keyword. Without a check it passed silently leading to
unpredictable problems.

Thanks Konrad Świat for the initial work.
 2014-10-04 20:47:26 -03:00
Jon Dufresne
8c581ff394 Fixed #23482 -- Added SingleObjectMixin.query_pk_and_slug 
Enabling the attribute causes get_object() to perform its lookup
using both the primary key and the slug.
 2014-10-02 15:42:30 -04:00
Markus Holtermann
85f6d89313 Fixed #23426 -- Allowed parameters in migrations.RunSQL 
Thanks tchaumeny and Loic for reviews.
 2014-10-02 11:52:40 -04:00
Seth Hill
fe2afcd318 Fixed #23569 -- Allowed using configs besides dictConfig in LOGGING_CONFIG. 2014-09-30 17:13:27 -04:00
Tim Graham
c7b5883c78 Fixed flake8 warnings. 2014-09-30 13:24:20 -04:00
Nick Sandford
f5cfd09c25 Fixed #7361 -- Added cancel link to admin delete views. 2014-09-30 08:45:04 -04:00
Rudy Mutter
a407b846b4 Fixed #23365 -- Added support for timezone-aware datetimes to migrations. 2014-09-29 20:45:43 -04:00
Thomas Chaumeny
311b3ad9db Fixed #23567 -- Made assertQuerysetEqual check Counter equality when ordered=False 2014-09-29 12:00:14 -04:00
Tim Graham
4b257cf261 Fixed flake8 warnings. 2014-09-29 08:13:40 -04:00
Thomas Chaumeny
b2aad7b836 Replaced set([foo, ...]) by {foo, ...} literals. Refs PR 3282. 
Thanks Collin Anderson for the review.
 2014-09-29 00:01:38 +07:00
Shai Berger
c1ae0621ba Fixed #22738 -- made finer distinctions for when Boolean is not detected on Oracle 
Thanks Claude Paroz for partial fix and Simon Charrette for review
 2014-09-27 09:49:50 +03:00
Claude Paroz
dbdae3a755 Fixed #22738 -- Abstracted boolean field type introspection 
Thanks maxi for the report, Shai Berger for his help with the patch
and Tim Graham for the review.
 2014-09-26 20:03:44 +02:00
Loic Bistuer
b23d47412c Fixed #23560 -- Fixed MigrationWrite to handle builtin types without imports. 
Thanks Tim Graham for the review.
 2014-09-27 00:36:28 +07:00
Matt Robenolt
ef5f9b6ae8 Fixed #23460 -- Added literal %s support to extra() QuerySets. 2014-09-26 13:01:27 -04:00
Thomas Chaumeny
17557d068c Fixed #8408 -- Added ModelAdmin.show_full_result_count to avoid COUNT() query. 
Thanks lidaobing for the suggestion.
 2014-09-26 12:12:40 -04:00
Markus Holtermann
45bd7b3bd9 Fixed #23455 -- Forced related_name to be a unicode string during deconstruction. 2014-09-25 17:49:44 -04:00
Davide Ceretti
d8e157d5ab Refactored m2m_through tests. Refs #18586 
Refactored old tests that were rewritten 1:1 from doctests.
 2014-09-26 01:28:32 +07:00
Markus Holtermann
215aa4f53b Fixed #23415 -- Added fields for unmanaged and proxy model migrations. 
Thanks sky-chen for the report.
 2014-09-25 10:25:03 -04:00
Marco Buttu
e077c29155 Fixed #23551 -- Fixed bash autocompletion crash on Python 3. 2014-09-25 07:44:22 -04:00
Tim Graham
d7ab2cefb7 Revert "Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations." 
This reverts commit abcf28a076.
 2014-09-24 15:49:30 -04:00
Tim Graham
a4f23eba2e Fixed #23421 -- Corrected TEST SERIALIZE setting. 
Thanks gkoller for the report.
 2014-09-24 14:46:10 -04:00
Markus Holtermann
b9a670b227 Fixed #23426 -- Don't require double percent sign in RunSQL without parameters 2014-09-24 07:20:57 -04:00
Tim Graham
0aca91cf7f Fixed flake8 warnings. 2014-09-24 06:32:42 -04:00
Justin Caratzas
cf43a1ee90 Fixed #23539 -- Added get_extra(), get_max_num(), and get_min_num() hooks to GenericInlineModelAdmin. 2014-09-24 06:32:42 -04:00
Loic Bistuer
2f3a4cd573 Removed numbering from the models.py header of some test packages. 
This is a reliqua from the early days of the modeltests/regressiontests era.
 2014-09-24 17:28:56 +07:00
Shai Berger
d128eac316 Changed Oracle test-user creation to grant privileges instead of roles 
because the roles (specifically RESOURCE) are deprecated.
Also added optional support for creating views in tests, and made an
introspection test fail (rather than skip)  if a view cannot be created
due to lacking privileges.

Refs #18782

Thanks Tim Graham for review, and Josh Smeaton
 2014-09-24 04:58:33 +03:00
Loic Bistuer
e043aae9bb Fixed #23550 -- Normalized get_queryset() of RelatedObjectDescriptor 
and ReverseSingleRelatedObjectDescriptor so they actually return QuerySet
instances.

Also ensured that SingleRelatedObjectDescriptor.get_queryset() accounts
for use_for_related_fields=True.

This cleanup lays the groundwork for #23533.

Thanks Anssi Kääriäinen for the review.
 2014-09-24 02:03:12 +07:00
Loic Bistuer
1fd6e13bf2 Consolidated some many_to_one tests. 2014-09-24 02:03:12 +07:00
Claude Paroz
2a1bdf5ced Called table_names instead of get_table_list in migrations 2014-09-23 20:13:31 +02:00
Claude Paroz
ed297061a6 Fixed #18782 -- Prevented sql_flush to flush views 
Thanks rodolfo_3 for the report and the initial patch, and
Josh Smeaton, Shai Berger and Tim Graham for the reviews.
 2014-09-23 20:13:31 +02:00
Sergey Fedoseev
463952d940 Fixed #23503 -- Fixed renaming of model with self-referential m2m field. 2014-09-23 10:03:37 -04:00
Sergey Fedoseev
83cd18633f Fixed #23065 -- Quoted constraint names in SQL generated by migrations. 2014-09-23 09:25:31 -04:00
Loic Bistuer
3c6ac0bab8 Consolidated some text utils into the utils_tests test package. 2014-09-23 19:45:59 +07:00
Loic Bistuer
0dab07e5da Merged custom_managers_regress into the custom_managers test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
d42a45de40 Merged custom_columns_regress into the custom_columns test package. 2014-09-23 03:56:19 +07:00
Loic Bistuer
7fe554b2a3 Merged one_to_one_regress into the one_to_one test package. 2014-09-23 03:56:19 +07:00
Claude Paroz
aeb48b9bc5 Fixed an i18n test with native string 
Refs commit 11f307a5a8.
 2014-09-21 17:28:37 +02:00
Yuri Kriachko
11f307a5a8 Fixed #23196 -- Short-circuited empty string translation 
Translating an empty string used to return the gettext catalog
metadata instead of the empty string.
Thanks Ned Batchelder for the suggestion, Tim Graham for the review
and Anton Berezin and Claude Paroz for contributions to the patch.
 2014-09-21 17:08:17 +02:00
Tim Graham
9d30412a5a Fixed some flake8 errors. 
Originally I added migrations to flake8 exclude because of long lines
in migration files, but there are other directories named migrations we
do want to check. We are not warning on line lengths yet anyway.
 2014-09-19 12:31:15 -04:00
Thomas Chaumeny
e008a10c2f Fixed #23443 -- Corrected erroneous FieldError message. 
Thanks Tim Graham for the review.
 2014-09-19 01:01:31 +07:00
Claude Paroz
abc11b0a33 Fixed #23514 -- Prevented queries in PostGISOperations init 
Thanks Mattia Procopio for the report.
 2014-09-18 20:00:35 +02:00
Claude Paroz
fc2b8ddcc8 Fixed #23495 -- Stopped swallowing real settings import error 
Thanks papaloizouc for the report.
 2014-09-17 17:15:44 +02:00
Baptiste Mispelon
d63ac5b595 Fixed #23492 -- Restored F.__deepcopy__. 
This reverts commit 3a66035107.
A regression test was also added.
 2014-09-16 12:19:00 +02:00
Marc Tamlyn
ed7821231b Fixed #19463 -- Added UUIDField 
Uses native support in postgres, and char(32) on other backends.
 2014-09-16 10:08:09 +01:00
valtron
abcf28a076 Fixed #23474 -- Prevented migrating backwards from unapplying the wrong migrations. 2014-09-15 14:56:59 -04:00
Tim Graham
8ed7834fb2 Fixed occasional selenium test failure on Jenkins with Chrome 36+. 
Previously find_element_by_id('id_password') on the next line failed with
NoSuchElementException and selenium.page_source was
<html xmlns="http://www.w3.org/1999/xhtml"><head></head><body></body></html>.

Possibly related: https://code.google.com/p/selenium/issues/detail?id=1969.
 2014-09-14 20:31:10 -04:00
Jason Hobbs
e1424b2370 Fixed #23397 -- Stripped whitespace from base64 during chunking 
This insures the actual base64 content has a length a multiple of 4.
Also added a test case for the failure.
 2014-09-13 19:06:21 +02:00
Malte Beckmann
22bfc45146 Fixed #23466 -- Removed seconds from all locale time output formats. 2014-09-13 13:00:42 -04:00
José Padilla
5472d18e31 Fixed #23461 -- Added EMAIL_TIMEOUT setting 2014-09-13 09:33:21 -04:00
Szilveszter Farkas
5e32605ce9 Fixed #23483 -- Prevented ImproperlyConfigured with dotted app names 
Made sure the app labels stay unique for the AppConfigStubs, so
migrations wouldn't fail if two dotted app names has the same last part
(e.g. django.contrib.auth and vendor.auth)
 2014-09-12 14:58:54 -06:00
Tim Graham
52ef6a4726 Fixed #17101 -- Integrated django-secure and added check --deploy option 
Thanks Carl Meyer for django-secure and for reviewing.

Thanks also to Zach Borboa, Erik Romijn, Collin Anderson, and
Jorge Carleitao for reviews.
 2014-09-12 15:05:23 -04:00
Andi Albrecht
00535e8e6b Fixed #20743 -- Added support for keyfile/certfile in SMTP connections. 
Thanks jwmayfield, serg.partizan, and Wojciech Banaś for work on the patch.
 2014-09-10 11:14:20 -04:00
Markus Bertheau
61f56e239f Corrected grammar in migrations error message. 2014-09-10 10:32:33 -04:00
Markus Holtermann
6d5958c7a3 Fixed #23452 -- Prevented infinite migrations for empty unique/index_together. 
Thanks fwkroon for the report.
 2014-09-10 07:54:16 -04:00
Claude Paroz
b9d9287f59 Fixed urlize after smart_urlquote rewrite 
Refs #22267.
 2014-09-09 21:59:35 +02:00
Claude Paroz
4b8a1d2c0d Fixed #22267 -- Fixed unquote/quote in smart_urlquote 
Thanks Md. Enzam Hossain for the report and initial patch, and
Tim Graham for the review.
 2014-09-09 21:58:07 +02:00
Aymeric Augustin
9562ffea97 Avoid the word "stupid". 
There's always a better word.
 2014-09-09 20:55:57 +02:00
Flavio Curella
c53f2451a8 Fixed #23398 -- Added helpful error message when runserver is accessed via HTTPS 2014-09-09 12:29:30 -04:00
Tim Graham
c32bc1a7a7 Fixed #11775 -- Made ABSOLUTE_URL_OVERRIDES work with models that don't define get_absolute_url(). 
Thanks jukvalim for the report and initial patch,
and Preston Timmons for review.
 2014-09-09 11:05:31 -04:00
Petras Zdanavičius
f7eee04ebe Fixed #23451 -- Fixed typo in inlineformset_factory() error message. 2014-09-08 17:22:23 -04:00
Aymeric Augustin
b161c01c48 Fixed #22920 -- Avoid masking some exceptions. 
If loading an application trigger an ImportError, the details of that
error were lost in some cases. Thanks Ben Davis for the report.
 2014-09-08 23:16:50 +02:00
Tim Graham
d3543af750 Added sorting to some admin_view tests to prevent transient failures; refs #23380. 2014-09-08 17:10:58 -04:00
Markus Holtermann
16548cfc7c Fixed broken test from da160d440f; refs #23418. 2014-09-08 16:49:06 -04:00
Markus Holtermann
d28b5f13b3 Fixed #23418 -- Fail when migration deconstruct produces invalid import 2014-09-08 21:27:34 +02:00
Simon Charette
342ccbddc1 Fixed #23431 -- Allowed inline and hidden references to admin fields. 
This fixes a regression introduced by the 53ff096982 security fix.

Thanks to @a1tus for the report and Tim for the review.

refs #23329.
 2014-09-08 13:49:07 -04:00
Andrew Pinkham
4680d25df2 Fixed #22951 -- Checked for types during deep_deconstruct migration serialization process. 
Thanks Sam Hartsfield for the report.
 2014-09-08 07:39:09 -04:00
Marc Tamlyn
14c8456ffe Fixed #23416 -- Make sure DatabaseCreation respects checks. 
Migrations respected Field.db_parameters()['check'], but
DatabaseCreation was still using just Field.db_type().
 2014-09-06 19:01:06 +01:00
Baylee Feore
f7d3a6255c Fixed #23380 -- Fixed flaky test: admin_filters.tests.ListFiltersTests.test_relatedfield 2014-09-05 20:05:51 -04:00
Andrew Godwin
3ab36d0046 Fix Python 3 incompatability 2014-09-05 15:47:20 -07:00
Ben Reilly
b878c73fc3 switch out recursive dfs for stack based approach, to avoid possibly hitting the recursion limit 2014-09-05 15:26:05 -07:00
Claude Paroz
885ff6845e Revert "Fixed #23384 -- Allowed overriding part of a dictionary-type setting" 
This reverts commit 66757fee7e.
Discussions have led to think that this functionality does not
bring significant benefits to justify the added complexity.
Read also discussions on ticket #22734.
 2014-09-05 20:06:02 +02:00
Tim Graham
f8bb8436e5 Corrected deprecation warning silencing of SubfieldBase. 2014-09-05 09:12:14 -04:00
Marc Tamlyn
e9103402c0 Fixed #18757, #14462, #21565 -- Reworked database-python type conversions 
Complete rework of translating data values from database

Deprecation of SubfieldBase, removal of resolve_columns and
convert_values in favour of a more general converter based approach and
public API Field.from_db_value(). Now works seamlessly with aggregation,
.values() and raw queries.

Thanks to akaariai in particular for extensive advice and inspiration,
also to shaib, manfre and timograham for their reviews.
 2014-09-03 20:36:03 +01:00
Raffaele Salmaso
1435cfbe8d Fixed #23302 -- Added --name/-n option to makemigrations command 2014-09-02 21:09:18 -04:00
Dave Hall
e03b7940e5 Fixed #22918 -- Fixed SeparateDatabaseAndState crash 2014-09-02 08:06:44 -04:00
Thomas Chaumeny
032c091659 Fixed #23388 -- Made django.utils.timezone.override usable as a decorator 2014-08-31 09:03:53 +02:00
Alex Gaynor
8b6cb9d0dd Added a missing word in a skip message 2014-08-30 15:18:58 -07:00
Claude Paroz
5021421799 Fixed #22820 -- Treated int and long types alike in lazy_number 
Thanks kwist for the report and the initial patch.
 2014-08-30 18:51:12 +02:00
Ramiro Morales
3a297d7816 Fixed #23055 -- Made generic admin filter obey ModelAdmin queryset. 
Thanks to Trac user synasius and to Ola Sitarska for helping in
identifying the issue and helping with the test case.
 2014-08-30 10:07:00 -03:00
Aymeric Augustin
df251e033c Fixed a PEP 8 error. 2014-08-30 13:27:56 +02:00
Bas Peschier
eacf244506 Converted sql_queries into a lazily evaluated list. 
Fixed #23364. Thanks Markush2010 for the report.
 2014-08-30 13:27:56 +02:00
Akis Kesoglou
6613ea6e3f Fixed #23370 -- defer() + select_related() crashed with inherited models. 2014-08-30 07:14:44 -04:00
Claude Paroz
66757fee7e Fixed #23384 -- Allowed overriding part of a dictionary-type setting 
This change is needed for upcoming changes where settings might be
grouped in a parent dictionary.
Thanks Tim Graham for the review.
 2014-08-30 12:37:10 +02:00
Joshua "jag" Ginsberg
eb2af16c59 Fixed #21483 -- Added WSGI environ to kwargs sent to request_started signal. 2014-08-29 10:12:03 -04:00
Tim Graham
149605dfb4 Fixed flake8 warning. 2014-08-29 09:42:22 -04:00
Vlastimil Zíma
e622caaa85 Fixed #21201 -- Improved customization of ClearableFileInput. 2014-08-29 09:40:08 -04:00
Andrew Torpedov
bc06d2c11c Fixed #23313 -- Corrected repr(RawQuery) with dict parameters. 2014-08-29 07:22:08 -04:00
Simon Charette
e98c5513cb Fixed an Oracle test failure introduced by 1e404180c1. 2014-08-28 19:33:36 -04:00
Thomas Chaumeny
efcbf3e095 Fixed #23381 -- Context manager restored state should be determined in __enter__ 2014-08-28 19:18:34 -04:00
Simon Charette
1e404180c1 Fixed #23379 -- Corrected a referencing issue in sql_create. 
Thanks to Trac alias flakfizer for the report.
 2014-08-28 15:17:50 -04:00
Thomas Chaumeny
2db1ed1033 Fixed #23323 -- Made django.utils.translation.override usable as a decorator. 2014-08-28 11:58:21 -04:00
Claude Paroz
3a44e20005 Fixed #23374 -- Renamed StaticLiveServerCase to StaticLiveServerTestCase 
Refs #20739. Thanks Raphaël Hertzog for the report and the initial
patch.
 2014-08-28 08:44:26 +02:00
Simon Charette
3cbb7590cb Fixed #23329 -- Allowed inherited and m2m fields to be referenced in the admin. 
Thanks to Trac alias Markush2010 and ross for the detailed reports.
 2014-08-27 21:26:53 -04:00
Jon Dufresne
f0d3dd4f04 Fixed #23357 -- Added small int introspection support to MySQL backend. 
In the MySQL backend, updated the can_introspect_small_integer feature
flag to True. In data_types_reverse, map FIELD_TYPE.SHORT to a
SmallIntegerField. Added test to verify introspecting SmallIntegerFields
and fixed existing tests influenced by this change.
 2014-08-27 10:58:44 -04:00
areski
a81af7f49d Fixed #13749 -- Added link from admin site to front-end site. 
Thanks romankrv for the suggestion.
 2014-08-27 08:34:53 -04:00
Claude Paroz
00f8b4dfae Lowered memory consumption in debug ouput test 2014-08-26 22:42:41 +02:00
Claude Paroz
5675eb371f Allowed skipIf/UnlessDBFeature to accept several feature strings 2014-08-26 20:03:37 +02:00
Tim Graham
e0cf030194 Removed unnecessary absolute_imports. 2014-08-25 10:07:14 -04:00
Raffaele Salmaso
abd640fbdf Fixed #23341 -- Added migration name to nonexistent migration error in makemigrations. 2014-08-23 19:18:03 -04:00
Raffaele Salmaso
be4baaefe2 Fixed #23352 -- Added tests for MigrationGraph.{forwards,backwards}_plan 2014-08-23 21:35:13 +00:00
Ian Foote
03d89168a2 Fixed #23333 -- Made urlsafe_base64_decode() return proper type on Python 3. 2014-08-22 20:07:12 -04:00
Tim Graham
f9c7732e96 Tweaked docstrings from previous commit. 2014-08-22 15:57:15 -04:00
areski
a6691e5dcf Fixed #23167 -- Added BaseForm.__repr__() 
Thanks Keryn Knight for the idea.
 2014-08-22 15:55:56 -04:00
Shai Berger
56252e7f46 Fixed schema test for Oracle 11.2.0.1 which is used in Django Project's CI. 
Refs #23073 Workaround.

Refs #22738 Repeats the mysql "offense". When the issue is solved, the
Oracle special case should be made to play with the solution (that is,
Oracle should be fixed the same way that mysql and the 3rd-party backneds
are).
 2014-08-22 05:08:53 +03:00
Markus Holtermann
144cff3f51 Fixed #23322 -- Use resolved swappable model for dependency resolution during makemigrations 2014-08-20 16:04:21 -04:00
Simon Charette
53ff096982 Prevented data leakage in contrib.admin via query string manipulation. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
0d8d30b7dd Fixed #23157 -- Removed O(n) algorithm when uploading duplicate file names. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Florian Apolloner
28e765810d Prevented reverse() from generating URLs pointing to other hosts. 
This is a security fix. Disclosure following shortly.
 2014-08-20 14:39:40 -04:00
Tim Graham
6f59d29158 Fixed flake8 warnings. 2014-08-20 14:37:33 -04:00
Tim Graham
d1299fce0e Fixed migrations tests added in refs #23315. 2014-08-20 14:00:59 -04:00
Andrew Godwin
9247da1032 Fixed #23315: Operational dependency fail with mixed create/add 2014-08-19 19:51:12 -07:00
Unai Zalakain
5f2542f12a Fixed #10190 -- Made HttpResponse charset customizable. 
Thanks to Simon Charette, Aymeric Augustin, and Tim Graham
for reviews and contributions.
 2014-08-19 17:34:38 -04:00
Claude Paroz
fa02120d36 Fixed #22996 -- Prevented crash with unencoded query string 
Thanks Jorge Carleitao for the report and Aymeric Augustin, Tim Graham
for the reviews.
 2014-08-19 22:29:31 +02:00
Lee Sanghyuck
11d9cbe2f4 Fixed #23316 -- Added datetime.time serialization in migrations. 2014-08-19 13:31:46 -04:00
Baptiste Mispelon
54164b814c Fixed broken tests on Oracle after 5853c87a45. 
Oracle doesn't have a `BEGIN` statement so the test would
fail.

Refs #23303
 2014-08-19 17:58:30 +02:00
Claude Paroz
6295ea0027 Replaced HAS_SPATIAL_DB by testing database feature 
Refs #22632. This should be the base for using more database
features to exclude specific backends in GIS tests.
Thanks Tim Graham for the review.
 2014-08-19 17:57:01 +02:00
Claude Paroz
132d0e516e Fixed #22171 -- Improved sanitize_separators cleverness 
Thanks Klaas van Schelven for the report and Tim Graham for the
review.
 2014-08-18 19:57:50 +02:00
Claude Paroz
a3d7f58151 Removed test, duplicate of admin_scripts.CommandTypes tests 2014-08-18 19:55:05 +02:00
Tim Graham
f76222e1d3 Fixed flake8 warning. 2014-08-18 13:44:10 -04:00
Gabriel Muñumel
3e241313a4 Fixed #23136 -- Added a message when sqlclear does nothing 2014-08-18 13:20:29 -04:00
Baptiste Mispelon
5853c87a45 Fixed #23303 -- Added BEGIN and COMMIT statements to the output of sqlmigrate. 2014-08-18 18:55:12 +02:00
Raffaele Salmaso
e0a98e2374 Fixed #23309 -- Fixed call_command to parse args correctly 2014-08-18 17:54:24 +02:00
Collin Anderson
230393e5e8 Fixed #23295 -- Removed unnecessary fix_location_header request.get_host() check. 2014-08-15 14:59:36 -04:00
Peter Harley
2724cdbff6 Fixed #18355 -- Added ordering options to list based generic views. 
Added MultipleObjectMixin.ordering and get_ordering().

Refs #21450.
 2014-08-15 11:09:47 -04:00
Tim Graham
0ad4672c0f Fixed typo in tests/migrations/test_operations.py 2014-08-15 11:01:49 -04:00
Tim Graham
e122facbd8 Fixed #23269 -- Deprecated django.utils.remove_tags() and removetags filter. 
Also the unused, undocumented django.utils.html.strip_entities() function.
 2014-08-15 08:20:02 -04:00
Gabriel Muñumel
deed00c0d8 Fixed #23162 -- Renamed forms.Field._has_changed() to has_changed(). 2014-08-15 08:14:45 -04:00
Andrew Godwin
4d2f9c38e8 Fixed #23288: deconstruct() ignoring related_name 2014-08-14 19:47:22 -07:00
areski
3021453285 Fixed #20133 -- Added summary to admin deletion confirmation pages. 
Thanks jonash for the suggestion and initial patch.
 2014-08-14 13:56:23 -04:00
Jaap Roes
b3660d28f3 Fixed #23260: Added generator support to defaultfilters.unordered_list. 2014-08-14 10:43:44 -04:00
Tim Graham
fe38be96c1 Fixed #21579 -- Made LocaleMiddleware respect script prefix. 
Thanks buettgenbach at datacollect.com for the report and patch.
 2014-08-14 09:36:41 -04:00
Claude Paroz
b42e5ca058 Fixed #22971 -- Properly parsed RFC 2388 encoded headers 
Thanks homm for the report, Cea Stapleton for patch improvements
and Ian Cordasco, Christian Schmitt and Tim Graham for the review.
 2014-08-14 11:45:43 +02:00
Florian Apolloner
7244a8d0ae Fixed test failure on python 3.x. 2014-08-14 09:58:15 +02:00
Maxime Turcotte
25e06bca57 Fixed #18767 -- Fixed admin calendar for other locales than English. 
Refactored openCalendar function from DateTimeShortcuts.js. Now, when
entered manually in the input field, the date will show up correctly on
the calendar for locales that don't use "-" for separator.

Thanks charettes for revivew and Alexey Boriskin for some of the patch.
 2014-08-13 20:36:26 -04:00
Shai Berger
2a9f44dfbe Fixed #21603 (again) -- Made a raw query in a test Oracle-compliant 2014-08-14 03:19:22 +03:00
zsoldosp
01801edd37 Fixed #22646: Added support for the MySQL ssl-ca option to dbshell. 2014-08-13 18:29:42 -04:00
Walter Doekes
e0e28bfe71 Fixed #20368 -- Made TECHNICAL_500 more robust against bad input. 
This limits large variables and avoids non-utf-8 in the TECHNICAL_500 output.
 2014-08-13 12:56:26 -04:00
Tim Graham
d38a00332e Updated tests for added newlines in 6868643063. 2014-08-12 20:16:04 -04:00
Trey Hunner
6868643063 Added newlines to the ends of CSS, HTML, and JavaScript files missing them. 2014-08-12 19:22:09 -04:00
Collin Anderson
85c22dd4c4 Fixed #23262 -- Made SelectFilter2.js move items on enter Key press. 2014-08-12 16:17:00 -04:00
Claude Paroz
2cc8ffe258 Fixed #22985 -- Made call_command accept option name parameter 
Thanks giulettamasina for the report and Tim Graham for the review.
 2014-08-12 21:53:29 +02:00
Andrew Godwin
8f9862cd4d Fixed #23275: Unmanaged models kept by autodetector, ignored by ops 2014-08-12 12:49:20 -07:00
Tim Graham
a9fd740d22 Fixed #23276 -- Deprecated passing views as strings to url(). 2014-08-12 13:15:40 -04:00
Anssi Kääriäinen
f7dba61881 Avoided creation of deferred model from another deferred model 
Also never create deferred model when no attrs are deferred.
 2014-08-12 14:58:10 +03:00
Josh Smeaton
5b0375ec3e Fixed #23001 -- Fixed mixing defer and annotations 2014-08-12 14:58:10 +03:00
Jaap Roes
e92b057e06 Fixed #23261 -- Deprecated old style list support for unordered_list filter. 2014-08-11 07:04:33 -04:00
Anssi Kääriäinen
dfadbdac6a Fixed #16426 -- deletion of 1000+ objects with relations on SQLite 
SQLite doesn't work with more than 1000 parameters in a single query.
The deletion code could generate queries that try to get related
objects for more than 1000 objects thus breaking the limit. Django now
splits the related object fetching into batches with at most 1000
parameters.

The tests and patch include some work done by Trac alias NiGhTTraX in
ticket #21205.
 2014-08-11 12:47:37 +03:00
Anubhav Joshi
cdfdcf4b70 Fixed #23266 -- Prevented queries caused by type checking lookup values 
Small modifications done by committer.
 2014-08-11 09:51:57 +03:00
Rajiv Makhijani
f0b358880a Fixed #23259 -- Corrected insertion order of extra() select_params 
A regression caused queries to produce incorrect results for cases where
extra(select) is excluded by values() but included by extra(order_by)

The regression was caused by 2f35c6f10f.
 2014-08-11 09:33:18 +03:00
Andrew Godwin
27b6f28435 Fixed #23264: Schema backends honour db_constraint 2014-08-09 17:50:00 +10:00
Justin Hamade
8fe406864c Fixed #22336 -- Added path matching for makemessages ignore option 
This fixes a regression introduced by 9012a9e200.
 2014-08-08 22:54:30 +02:00
Tim Graham
f53b1c779b Fixed #23099 -- Removed usage of deprecated initial data in Django's test suite. 
Thanks Claude Paroz for assistance with debugging the tests.
 2014-08-08 14:01:59 -04:00
Jacob Haslehurst
f676305ece Fixed #22982 -- Added GenericRelatedObjectManager.__str__. to prevent crash. 
Thanks bendavis78 for the report.

Forwardport of 29585e9b6a from stable/1.7.x
 2014-08-07 14:44:20 -04:00
Tim Graham
57b60f9f93 Added a missing unicode_literals that caused a test failure after refs #23226. 2014-08-07 08:30:50 -04:00
Andrew Godwin
dfe86449c9 Fixed #23244: Error altering FK to non-FK in migrations 2014-08-07 11:52:31 +10:00
Alex Hill
938da36cb1 Fixed #21603 -- Fixed complex RawQuerySets queries on some versions of SQLite. 2014-08-06 08:41:34 -04:00
Tim Graham
fcd42a4819 Removed code that assumed BooleanField could be null. 
Such a field will no longer pass model validation.
 2014-08-05 07:49:53 -04:00
Shai Berger
746f2a4bed Fixed #23061: Avoided setting a limit on a query for get with select_for_update on Oracle 
Thanks Michael Miller for reporting the issue.
 2014-08-05 03:12:08 +03:00
Florian Apolloner
6d256ae248 Fixed test failures from 98e8da3709. 2014-08-04 16:54:43 +02:00
Tim Graham
b50ea73e1e Fixed two tests in previous commit; refs #16311. 2014-08-04 10:21:13 -04:00
Stanislas Guerra
98e8da3709 Fixed #16311 -- Added a RelatedOnlyFieldListFilter class in admin.filters. 2014-08-04 09:39:02 -04:00
Vincent-Vega
5e06fa1469 Fixed #22745 -- Prevented reevaluation of ModelChoiceField's queryset when accesssing BoundField's attrs. 
Thanks Christian Schmitt for review.
 2014-08-04 07:47:37 -04:00
Andrew Godwin
c06e124b5e Fixed #23091: CreateModel and AddField were clashing with deferred SQL 2014-08-04 11:59:29 +10:00
Simon Charette
1b00738f73 Fixed a MySQL test failure introduced by cbb29af1aa. 
Seems like unlike other backends MySQL get_constraints fails when dealing
with a non-existing table. refs #23160.
 2014-08-03 16:32:36 -04:00
Simon Charette
cbb29af1aa Fixed #23160 -- Correctly rename models with self referential fields. 
Thanks to whitews AT gmail for the report.
 2014-08-03 15:27:01 -04:00
Florian Apolloner
40fb6a5601 Revert "Fixed #23088 -- Used six range type in Paginator.page_range." 
This reverts commit 6508db2ff9.

Refs #23088.
 2014-08-03 21:08:24 +02:00
Tim Graham
6e77acc589 Fixed flake8 warning. 2014-08-03 14:21:45 -04:00
qingfeng
0d23450e81 Fixed #19802 -- Fixed HttpResponse.set_cookie() with unicode data on Python 2. 
Thanks django at patrickbregman.eu for the report.
 2014-08-03 12:50:25 -04:00
Tim Graham
0f2ceee025 Fixed #23151 -- Deprecated RegexField.error_message. 
Thanks Baptiste Mispelon for the suggestion.
 2014-08-03 11:21:01 -04:00
Baptiste Mispelon
7432533932 Added missing logic to TimeField.deconstruct(). 
If auto_now or auto_now_add was used then the serialized
field in the migration contained unnecessary `editable` and
`blank` arguments.
 2014-08-03 14:02:21 +02:00
Baptiste Mispelon
72f1eb48df Fixed #23156 -- Added missing BinaryField.deconstruct() method. 2014-08-03 13:02:31 +02:00
Tim Graham
d28396f526 Fixed #23144 -- Dropped support for MySQL 5.0, 5.1. 2014-08-02 10:28:40 -04:00
Tim Graham
a9bdce7e55 Fixed #23108 -- Dropped support for PostgreSQL 8.4 & PostGIS 1.3, 1.4. 
Thanks Claude Paroz for the review.
 2014-08-01 10:26:00 -04:00
Petras Zdanavičius
8b7347220f Fixed #23103 -- Annotated ImageField file with image and content_type attributes. 
Thanks Jeremy Dunck for the suggestion and Nick Sanford for review.
 2014-08-01 09:30:58 -04:00
Niclas Olofsson
cdc25ac474 Fixed #22808 -- Made ModelMultipleChoiceField validation more robust to invalid data types.. 
Thanks Mattias Lindvall for the report and inital patch.
 2014-07-31 15:29:46 -04:00
Anubhav Joshi
0dd05c9e66 Fixed #16383 -- Raised the AttributeError raised in property of an object when used in a template. 
Thanks maraujop for the report and Hiroki and Tim Graham for review.
 2014-07-31 09:13:55 -04:00
Nick Sandford
9d9f0acd7e Fixed #13163 -- Added ability to show change links on inline objects in admin. 
Thanks DrMeers for the suggestion.
 2014-07-31 08:07:28 -04:00
Tim Graham
9a922dcad1 Fixed flake8 warnings. 2014-07-31 08:06:46 -04:00
Florian Apolloner
4453c80634 Fixed the previous commit for Python3. 2014-07-30 22:22:04 +02:00
areski
97a38de230 Fixed #23112 -- Field.get_choices tries to index an iterable 2014-07-30 21:35:02 +02:00
Tim Graham
c2ab501bab Fixed test failure on Windows. 
os.close(fd) is needed to avoid "The process cannot access the file
because it is being used by another process"
 2014-07-30 14:31:59 -04:00
Christoph Heer
d47409831f Fixed #23067 -- Updated docs to use django-admin 2014-07-30 14:14:03 -04:00
Tim Graham
34c60c42b6 Fixed flake8 errors. 2014-07-30 12:58:53 -04:00
areski
67d7da5fb9 Fixed #23107 -- Made runserver output respect --no-color. 2014-07-30 12:58:53 -04:00
Kit La Touche
17e75d03f9 Fixed #23129 -- Added 'true' and 'false' to NullBooleanField. 
JavaScript serializations of forms will sometimes render the boolean
values as the strings 'true' and 'false', in lower case. Rather than
repeat boilerplate in the JavaScript to circumvent this, it seems
reasonable to allow Django to understand the lower-case versions of the
booleans.
 2014-07-29 19:55:55 -04:00
Andrew Godwin
a338e07735 Fixed #23101: Prefer doing deletes before creates in autodetector. 
Makes declined or missed renames still work (but drop data).
 2014-07-29 09:38:51 -07:00
Marc Tamlyn
ef9f109013 Fixed #22962 -- Default values for ArrayField with migrations. 
Fields normally try to force the default value to a string. As
translatable strings are not valid default values for ArrayField, we can
remove this behaviour which was causing issues with some migrations.

Thanks to @schinckel for the report.
 2014-07-29 10:37:11 +01:00
Andrew Godwin
d6e73a876d Fixed #23121: AlterModelOptions operation not changing state right 2014-07-28 10:47:28 -07:00
Andrew Godwin
cb60d22bd9 Fixed #23100: Individual FK creation missing dependencies 2014-07-28 10:32:43 -07:00
Simon Charette
80708ac772 Fixed #23113 -- ChoiceInput.render should take specified attrs into account. 
Thanks to Tim Graham for the review.
 2014-07-28 10:01:07 -04:00
Aymeric Augustin
729e4ae4f0 Fixed #23074 -- Avoided leaking savepoints in atomic. 
Thanks Chow Loong Jin for the report and the initial patch.
 2014-07-28 14:30:41 +02:00
Florian Apolloner
2f73b527dd Fixed #23098 -- Checked that lazy choices are not evaluated too soon 
Thanks Matthieu Agopian for the report.
 2014-07-27 13:31:25 +02:00
Tushar Bhatia
11181a64f9 Fixed #22979 -- Moved bug* tests 2014-07-26 21:05:49 -04:00
Abraham Martin
e1347e9253 Fixed #23101 db_table wasn't copied in deconstruct 
Forward port of 999758fc7a2d6fcb01eb40de937d4420f884788d from
stable/1.7.x
 2014-07-26 10:00:02 -07:00
Andrew Godwin
805774df1f Fixed #22944: Bad dependency on FK alteration in autodetector 2014-07-26 09:22:19 -07:00
qingfeng
08451f17d0 Fixed #23060 -- Prevented UnicodeDecodeError in debug templatetag 2014-07-26 18:03:19 +02:00
Anubhav Joshi
5cdb8f8c1e Fixed #16617 -- Added 'value' to BaseValidator params. 
Also allowed overriding the default messages in subclasses of BaseValidator.

Thanks sperrygrove for initial patch.
 2014-07-26 10:03:00 -04:00
Hiroki KIYOHARA
d0889863de Fixed code to solve #23070 problem 
Added a class to wrap callable in settings:
* Not to call in the debug page (#21345).
* Not to break the debug page if the callable forbidding to set attributes (#23070).

Thanks @bmispelon for giving me some advice.
 2014-07-26 12:35:51 +02:00
Hiroki KIYOHARA
e569144910 Added test for the #23070 problem 2014-07-26 12:01:44 +02:00
Tim Graham
57d2b3f2a7 Fixed bad usage of rstrip() that caused test failure. 
If the temporary file name contained a p or y as its last
characters, it would be stripped. refs #23083.
 2014-07-25 15:16:47 -04:00
Tim Graham
b8cb5ba708 Fixed #23083 -- Fixed runserver reloading when deleting a file. 
Thanks Collin Anderson for the report and hirokiky for the fix.
 2014-07-25 13:23:52 -04:00
Andrew Godwin
a64bc3df77 Fixed #23093: soft application detection for swapped models 2014-07-25 09:35:38 -07:00
Andrew Godwin
ed4812692e Merge pull request #2938 from dekkers/ticket_23071 
Fixed #23071 -- Use last migration's name in dependency to other app
 2014-07-25 08:53:57 -07:00
Moayad Mardini
6508db2ff9 Fixed #23088 -- Used six range type in Paginator.page_range. 2014-07-25 11:04:58 +03:00
Tim Graham
64e75c47ef Fixed #23014 -- Infinite migration regression with unique/index_together. 2014-07-24 14:27:10 -04:00
Anubhav Joshi
b1abfb3c59 Fixed #21707 -- Added helpful error message when using {{ block.super }} in base template. 
Thanks mitar for the suggestion.
 2014-07-24 14:22:19 -04:00
Tim Graham
99cd80dc74 Silenced test warning for deprecated IPAddressField. 2014-07-24 11:27:26 -04:00
Tim Graham
66211b4b75 Silenced a Python 2 ImportWarning in a migrations test. 2014-07-24 09:24:52 -04:00
Tim Graham
577ced2aae Silenced OptionParser deprecation warning in a test. 2014-07-24 08:51:47 -04:00
Tim Graham
936fba5878 Improved patching of sys.stdout in refs #23078. 2014-07-24 08:46:29 -04:00
Tim Graham
9b1515906e Removed usage of deprecated switch_to_*() selenium methods. 2014-07-24 08:25:15 -04:00
Nick Sandford
fa3cf006b2 Fixed #23078 -- Regression in update_contenttypes() interactivity. 
Thanks raymond at adaptiv.nl for the report.
 2014-07-23 08:45:09 -04:00
Jeroen Dekkers
3582698c13 Fixed #23071 -- Use last migration's name in dependency to other app 
Changed the autodetector to lookup the name of the other app's last
migration in the graph and use that as dependency instead of using
__latest__.
 2014-07-22 01:03:02 +02:00
Andrew Godwin
e24e9e0438 Fixed #23014: Renaming not atomic with unique together 2014-07-21 11:36:34 +01:00
Andrew Godwin
7dacc6ae46 Fixed #23009: Shorten FK identifiers in add_field and make consistent 2014-07-21 10:50:21 +01:00
Andrew Godwin
dcb4ed5170 Fixed #22975: Don't call rename SQL if not needed 2014-07-21 10:14:00 +01:00
Andrew Godwin
2984b30ce8 Fixed #23039: Don't try to serialize unmanaged models in tests 2014-07-21 10:09:31 +01:00
Damien Nozay
70c54a3694 Fixed #23028: Added unique_togther support to inspectdb. 2014-07-18 16:10:59 +00:00
Andrew Godwin
145d231782 Fixed #23041: Bad base dependencies for proxy models 2014-07-16 09:59:08 -07:00
Tim Graham
5954aa6db0 Added Chrome/IE support for a selenium test. 2014-07-16 10:52:49 -04:00
Claude Paroz
c5d8e4a0d1 Added forgotten files from commit 28efafa24c 2014-07-16 13:50:53 +02:00
Anssi Kääriäinen
f8df55050c PEP8 cleanup 2014-07-16 12:48:49 +03:00
Gavin Wahl
6e2b82fdf6 Fixed #22998 -- Updated the fast_delete logic for GFKs 2014-07-16 12:28:00 +03:00
Claude Paroz
28efafa24c Ignored STATIC_ROOT and MEDIA_ROOT in makemessages 
Also alleviate issues with weird file names typically found in
MEDIA_ROOT directories (#23010).
Thanks Tim Graham for the review.
 2014-07-16 09:38:57 +02:00
Tim Graham
0154965392 Fixed #23013 -- Fixed removing unique_together/index_together constraints in migrations. 
Thanks melinath for the report.
 2014-07-15 15:20:59 -04:00
Marc Tamlyn
b65a2001e7 Fixed #22907 -- Array contains must have same type. 2014-07-15 19:41:26 +01:00
Tim Graham
9a2ab62977 Fixed #23008 -- Fixed typo causing bad migration dependencies. 
Thanks semenov for the report and Florian for investigation.
 2014-07-15 08:48:29 -04:00
Claude Paroz
4e424084e6 Fixed #22991 -- Prevented *.pyc files in autoreload monitoring 
This fixes a regression introduced in 6d302f639.
Thanks lorinkoz at gmail.com for the report, Collin Anderson
for the initial patch and Simon Charette for the review.
 2014-07-15 09:57:54 +02:00
Claude Paroz
5dcdbe95c7 Fixed #23005 -- Allowed specifying special fallback languages 
This fixes the Chinese language issues described in #23005 but
also provides for other fallback exceptions by updating the
LANG_INFO structure.
Thanks caxekis at gmail.com for the report and Tim Graham for the
review.
 2014-07-14 20:50:03 +02:00
Shai Berger
dd9b3312d0 Fixed name of database connection feature 2014-07-14 19:23:57 +03:00
Huu Nguyen
f7a78f9bba Fixed #22791 -- Invoke interactive questioner only for conflicts in specified apps. 
Thanks bendavis78 for the report and Tim Graham for the review.
 2014-07-14 11:00:49 -04:00
Anssi Kääriäinen
efe87d3e48 Fixed #22992 -- regression in .filter(generic_fk=...) error message 
Generic Foreign Keys can't be used as lhs in lookups for historical
reasons. Django 1.6 gave a FieldDoesNotExist exception when using GFKs
as lhs in lookups, but due to regression caused by lookup refactor patch
(20bab2cf9d) the exception type was
changed to AttributeError.

It might be a good idea to add support for gfk__exact and gfk__in lookups
later on.

Thanks to glicerinu@gmail.com for the report. The code in this commit
was written by Tim Graham.
 2014-07-14 10:50:41 -04:00
Anssi Kääriäinen
9cd5201abd Fixed #22994 -- regression with generic FK + admin list_view 
The reason for the regression was that the GenericForeignKey field isn't
something meta.get_field_by_name() should return. The reason is that a
couple of places in Django expects get_field_by_name() to work this way.
It could make sense to return GFKs from get_field_by_name(), but that
should likely be done as part of meta refactoring or virtual fields
refactoring patches.

Thanks to glicerinu@gmail.com for the report and to Tim for working on
the issue.
 2014-07-14 10:50:41 -04:00
Tim Graham
38e001ab6c Fixed #22789 -- Deprecated django.contrib.webdesign. 
Moved the {% lorem %} tag to built-in tags.
 2014-07-14 08:45:19 -04:00
Claude Paroz
22b2fb0ba1 Fixed #22939 -- Delayed admin_static backend detection 
Thanks generalov for the report.
 2014-07-12 18:49:43 +02:00
Andrew Godwin
9e5a37c82d Fix comment 2014-07-10 10:00:31 -07:00
Andrew Godwin
008bff92b7 Fixed #22970: Incorrect dependencies for existing migrated apps 2014-07-09 23:53:43 -07:00
Josh Smeaton
b7455b52a0 Fixed #22988 -- Adjusted an introspection test assertion. 
Also changed test to use assertNotIn.
 2014-07-10 00:47:57 -04:00
Anubhav Joshi
011abb7d96 Fixed #19671 -- Added warnings that null and validators are ignored for ManyToManyField. 
Thanks Loic Bistuer and Tim Graham for help and review.
 2014-07-09 16:01:09 -04:00
Tim Graham
5e2c4a4bd1 Fixed #13794 -- Fixed to_field usage in BaseInlineFormSet. 
Thanks sebastien at clarisys.fr for the report and gautier
for the patch.
 2014-07-09 07:59:20 -04:00
Claude Paroz
e167e96cfe Fixed #22223 -- Prevented over-escaping URLs in reverse() 
And follow more closely the class of characters defined in the
RFC 3986.
Thanks Erik van Zijst for the report and the initial patch, and
Tim Graham for the review.
 2014-07-09 09:54:34 +02:00
Daniel Pyrathon
865bc71783 Added a unit test to ensure models cannot be ordered by a M2M field. 2014-07-08 09:19:08 -04:00
Tim Graham
136a3ffe21 Removed unnecessary directory in dispatch tests. 2014-07-07 19:21:47 -04:00
Tim Graham
fddd95254e Fixed flake8 errors. 2014-07-07 19:12:39 -04:00
Tim Graham
89b9e6e5d6 Fixed #22909 -- Removed camelCasing in some tests. 
Thanks brylie.
 2014-07-07 19:08:42 -04:00
Claude Paroz
6d302f6396 Fixed pyinotify performance regression in 15f82c7011 
Refs #9722. Thanks Tim Graham for the review.
 2014-07-06 21:41:02 +02:00
Claude Paroz
b144bfb5ce Fixed #21079 -- Further normalized table names in inspectdb 
Thanks Michael Manfre for the report and Tim Graham for the review.
 2014-07-06 21:19:27 +02:00
Loic Bistuer
2572c07cc6 Fixed #22906 -- Added a more helpful repr to migrations' ModelState. 
Thanks Collin Anderson for the report and original patch.
 2014-07-06 14:56:18 +07:00
Tim Graham
86c74eacd6 Updated tests per previous commit. 2014-07-05 20:20:19 -04:00
Andrew Godwin
f751109cb2 Merge pull request #2881 from charettes/ticket-22943-compiled-regex-deconstruction 
Fixed #22943 -- Correctly serialize compiled regexes.
 2014-07-05 16:37:10 -07:00
Andrew Godwin
80a12f21e3 Fixed #22960: Bad handling of relations as PKs in autodetector 2014-07-05 16:33:03 -07:00
Claude Paroz
dd9a23d5cf Fixed #22950 -- Eased markup customization for choice field rendering 
Thanks Patrick Robertson for the report.
 2014-07-05 13:36:49 +02:00
Claude Paroz
9209049211 Ensured bound field renders as unicode safe data 
Refs #22950.
 2014-07-05 11:42:27 +02:00
Tim Graham
1f8bb95cc2 Corrected domain max length for EmailValidator; refs #20631. 
Thanks MarkusH for the report.
 2014-07-04 20:50:28 -04:00
Tim Graham
7fd55c3481 Fixed #20631 -- Increased the default EmailField max_length to 254. 
Thanks pmartin for the report.
 2014-07-04 14:15:00 -04:00
Simon Charette
35c2c37041 Fixed #22943 -- Correctly serialize compiled regexes. 
Thanks to antialiasis at gmail dot com for the patch.
 2014-07-04 13:34:20 -04:00
Loic Bistuer
1966054feb Fixed #22915 -- Document backward incompatible changes in the ValidationError constructor. 
This patch also fixes update_error_dict to better handle the use case described
in this ticket, previously the type of the provided container could be lost in
some conditions.

Thanks Russell Keith-Magee for the report and Tim Graham for review.
 2014-07-04 17:05:31 +07:00
LarryBrid
1bb1d3168b Updated urlize regex following a93ee5112d 
Prevent urlize from turning some.organization, an.intern etc.
into urls. Refs #22941.
 2014-07-04 09:00:16 +02:00
LarryBrid
a93ee5112d Fixed #22941 - Added support for domain-only links with chars after the TLD to urlize. 
It now works with something like google.com/foo/bar
 2014-07-02 20:36:53 -04:00
Anubhav Joshi
10e83d48a3 Fixed #22935 -- Changed ForeignKey.default_error_messages['invalid'] to refer to correct field. 
Thanks Tim Graham for suggestion and review.
 2014-07-02 13:01:36 -04:00
Colin Wood
27ee608b55 Fixed #22940 -- Added missing string iterpolation parameters in migrations.writer error. 
Forwardport of f5740af868 from stable/1.7.x
 2014-07-02 12:45:02 -04:00
Tim Graham
3de4f8bab6 assertEquals -> assertEqual 2014-07-02 10:11:52 -04:00
Curtis
71461b14ab Fixed #22691 -- Added aliasing to cached_property. 2014-07-01 06:32:53 -04:00
Anubhav Joshi
34ba86706f Fixed #14334 -- Query relation lookups now check object types. 
Thanks rpbarlow for the suggestion; and loic, akaariai, and jorgecarleitao
for reviews.
 2014-07-01 06:12:58 -04:00
Julia Matsieva
29c1151a55 Fixed #22756 -- Added view name to technical 404 template if Http404 is raised. 
Thanks Keryn Knight for the suggestion.
 2014-06-30 15:34:35 -04:00
Anubhav Joshi
fd5897193f Fixed problem with refs #10811. 
When 'to_field' is specified with a FK, then we need to check the pk value
the object.
 2014-06-30 10:25:57 -04:00
Tim Graham
add78c58b5 Added spaces to message from 4c39c270af. 2014-06-30 07:39:35 -04:00
Tim Graham
70576740b0 Fixed #22917 -- Fixed typo in AlterIndexTogether.describe(). 2014-06-27 10:34:48 -04:00
Riccardo Magliocchetti
68c9a72e29 Fixed #22894 -- Made admin add related/raw ID fields widgets customizable. 
Decoupled behavior and style from the RelatedFieldWidgetWrapper and
ForeignKeyRawIdWidget.
 2014-06-26 15:02:42 -04:00
zsoldosp
7e2c804c94 Split tests.basic.ModelTests in several tests; refs #18586. 2014-06-25 15:39:56 -04:00
Tim Graham
e0cd07ec2f Fixed #22903 -- Fixed migration generation if index_together or unique_together is removed from a model. 2014-06-25 10:02:12 -04:00
Tim Graham
e769846eec Removed unused variable. 2014-06-25 08:37:12 -04:00
Lovas Bence
9385aa3198 Fixed #22050 -- Fixed defer fields on proxy related models. 2014-06-25 07:20:18 -04:00
Tim Graham
815e7a5721 Fixed #20128 -- Made CsrfViewMiddleware ignore IOError when reading POST data. 
Thanks Walter Doekes.
 2014-06-25 07:08:16 -04:00
Duncan Parkes
fd4ccd045c Fixed #22799 -- Made GET and POST on HttpRequest QueryDicts, and FILES a MultiValueDict. 
Previously, GET, POST, and FILES on an HttpRequest were created in
the __init__ method as dictionaries. This was not something you would
usually notice causing trouble in production as you'd only see a
WSGIRequest, but in testing using the test client, calling .getlist
on GET, POST, or FILES for a request with no get/post data resulted in
an AttributeError.

Changed GET and POST on an HttpRequest object to be mutable
QueryDicts (mutable because the Django tests, and probably many
third party tests, were expecting it).
 2014-06-24 22:03:22 -04:00
Duncan Parkes
d68987ae25 Fixed #22897 -- Made QueryDict query_string argument optional. 
Now QueryDict() is equivalent to QueryDict('') or QueryDict(None).
 2014-06-24 22:02:03 -04:00
Anubhav Joshi
dbbcfca476 Fixed #21668 -- Return detailed error page when SuspiciousOperation is raised and DEBUG=True 
Thanks GDorn and gox21 for report.

Thanks Tim Graham for idea and review.
 2014-06-24 08:55:36 -04:00
Andrew Godwin
fe262c0b84 Fixed #22708: Typo in autodetector base dependency gen 2014-06-23 20:48:33 -07:00
Andrew Godwin
0b571753a8 Fixed #22889: Unneeded to_field in fk.deconstruct causing swap issues 2014-06-23 20:39:17 -07:00
Andrew Godwin
0fba4c0ed7 Fixed #22487: Don't flush out data from before normal TestCases 2014-06-23 20:25:09 -07:00
Anubhav Joshi
7f76251fb7 Refactored common code in handlers/base.py and urlresolvers.py 2014-06-23 15:27:25 -04:00
Anubhav Joshi
1c50d6ae2b Fixed problem introduced with #refs 13711. 2014-06-23 19:36:40 +03:00
Tim Graham
908160f692 Fixed test failures introduced by refs #22881. 2014-06-23 09:59:36 -04:00
Claude Paroz
809362518d Created import-time test temp dirs in known location 
Refs #17215. In the same spirit as 5de31cb8cb.
 2014-06-23 14:54:25 +02:00
Claude Paroz
1d9596025e Ensured cache tests do not leak temp dirs 
Refs #17215.
 2014-06-23 14:06:04 +02:00
Chris Beaven
21c496ea52 Fixed #22881 -- Better soft_applied migration detection 2014-06-23 13:36:22 +12:00
Andrew Godwin
b30d32ff24 Fixed #22875: Optimizer did not take through= into account. 2014-06-22 11:23:45 -07:00
Claude Paroz
c6a711d9e5 Removed some apps from ALWAYS_INSTALLED_APPS 2014-06-21 21:01:37 +02:00
Vlastimil Zíma
78c32f1caa Fixed #22514 -- Prevented indexes on virtual fields [postgres]. 2014-06-20 11:59:02 -04:00
Tim Graham
9a46836a0c Moved a line outside of try/except to prevent an error in finally. 
Thanks Ian Foote.
 2014-06-20 09:13:34 -04:00
Huu Nguyen
fbb684d95e Fixed #22862 -- Added --noinput option to makemigrations. 
Thanks artortenburger for the report.
 2014-06-20 08:55:02 -04:00
Daniel Pyrathon
d862fae5bb Refs #12663 -- Added tests for methods in db.models.options. 
Thanks Russell Keith-Magee and Tim Graham for reviews.
 2014-06-19 12:56:36 -04:00
Maxime Turcotte
9996158db4 Fixed #22835 -- Deprecated NoArgsCommand. 2014-06-19 08:54:59 -04:00
Renaud Parent
87d0a3384c Fixed #22778 -- Added a model Meta option to define default_related_name. 
Thanks jorgecarleitao and mmardini for reviews.
 2014-06-18 13:53:07 -04:00
Alex Gaynor
d015c9d11c Fixed several flake8 errors 2014-06-18 07:47:13 -07:00
Andrew Godwin
2cee1d4642 Fixed #22861: Internal migrations done first so __first__ works 
Thanks to Chris Beaven.
 2014-06-17 23:28:35 -07:00
Andrew Godwin
09b63a7cce Fix __latest__ to actually resolve to the latest migration 2014-06-17 22:12:31 -07:00
Andrew Godwin
405b9dcd8b Fix broken test 2014-06-17 21:32:23 -07:00
Andrew Godwin
8d2ac948a9 Fixed #22853: Swapped models are now ignored for migration operations. 2014-06-17 17:45:38 -07:00
Anubhav Joshi
91f1b6dcdc Fixed #13711 -- Model check added to ensure that auto-generated column name is within limits of the database. 
Thanks russellm for report and Tim Graham for review.
 2014-06-17 16:16:02 -04:00
Andrew Godwin
77ff4a9360 Fix previous commit on python 2 2014-06-17 09:56:22 -07:00
Andrew Godwin
66a99fa210 Merge pull request #2824 from valberg/22577 
Fixed #22577: Python 3 broke on non-module migrations directory
 2014-06-17 09:54:39 -07:00
Víðir Valberg Guðmundsson
3a6cb9f497 Fixed #22577: Python 3 broke on non-module migrations directory 2014-06-17 18:21:38 +02:00
Tim Graham
95cc0e15b4 Fixed #22819 -- Renamed output_type -> output_field in query expression API. 
Thanks jorgecarleitao for the suggestion.
 2014-06-17 11:57:16 -04:00
Andrew Godwin
61d7ae31cf Fix test breakage on MySQL 2014-06-17 00:36:27 -07:00
Andrew Godwin
b22917bd50 Fixed #22851: BinaryView wasn't getting a binary default 2014-06-16 18:44:08 -07:00
Tim Graham
82c935d44c Renamed DatabaseFeature.supports_check_constraints to supports_column_check_constraints. 
Thanks maxi for the suggestion.
 2014-06-16 19:25:13 -04:00
Tim Graham
317c480c04 Removed some u'' prefixes to fix Python 3.2. 2014-06-16 18:49:37 -04:00
Vincent-Vega
4529af9ecf Fixed #22845 -- Correctly handled memcached default timeout value. 2014-06-16 16:34:00 -04:00
Tim Graham
b341f33697 Added database migration for contrib.auth. 
refs #22170.
 2014-06-16 16:21:37 -04:00
Tim Graham
eb8600a656 Added database migration for contrib.contenttypes. 
Moved contenttypes tests to allow them to run correctly in the presence of
migrations. refs #22170.
 2014-06-16 15:03:00 -04:00
Andrew Godwin
067b9668fb Fixed #22783: Make sure swappable models come first in creation 2014-06-16 10:20:05 -07:00
Matthew Schinckel
bb39037fcb Fixed #22788 -- Ensured custom migration operations can be written. 
This inspects the migration operation, and if it is not in the
django.db.migrations module, it adds the relevant imports to the
migration writer and uses the correct class name.
 2014-06-16 12:28:52 -04:00
Tim Graham
808388c28c Removed usaged of contrib.sessions as a placeholder in migration tests. 
Without this, we're unable to add actual migrations for the app.
 2014-06-16 10:15:19 -04:00
Andrew Godwin
c8c79367a2 Fixed #22844: Duplicate SQL for SQLite FKs 2014-06-16 00:27:32 -07:00
Alex Gaynor
d17a4cb037 Fixed several flake8 errors 2014-06-15 20:45:15 -04:00
Andrew Godwin
c1276785f9 Fixed #22568: Better proxy model support in migrations 2014-06-15 16:01:49 -07:00
Andrew Godwin
a8ce5fdc28 Fixed #22470: Full migration support for order_with_respect_to 2014-06-15 14:56:51 -07:00
Andrew Godwin
a58f49d104 Persist non-schema-relevant Meta changes in migrations 2014-06-15 12:34:02 -07:00
Andrew Godwin
f717ef083a Fixed #22833: Autodetector not doing through mapping correctly 2014-06-15 12:06:48 -07:00
Claude Paroz
c24e979ece Fixed #7762 -- Hidden full script name in command error output 2014-06-14 20:01:02 +02:00
Claude Paroz
5949c2118d Restored command error behavior when called from command line 
Refs #19973.
 2014-06-14 18:53:33 +02:00
Alex Gaynor
2ca5fc55b0 Fixed several flake8 errors 2014-06-14 10:20:42 -04:00
Claude Paroz
f17b24e407 Converted remaining management commands to argparse 2014-06-14 13:43:44 +02:00
Claude Paroz
4b4524291a Converted test management command to argparse 
Keeping backwards compatibility with test_runner.option_list is
tricky and would imply transforming an optparse.Option to an
argparse.Action. I choose to introduce a backwards incompatible
change because it only affects testing, not runtime behavior.
 2014-06-14 13:43:39 +02:00
Claude Paroz
8568638603 Fixed #19973 -- Replaced optparse by argparse in management commands 
Thanks Tim Graham for the review.
 2014-06-14 11:17:48 +02:00
Mark Lavin
79956d0694 Fixed #22440 -- Updated ConditionalGetMiddleware to comply with RFC 2616. 2014-06-13 20:01:35 -04:00
Shai Berger
612290400f Fixed #22816 -- Corrected Oracle feature flag and fixed introspection test 2014-06-14 00:43:49 +03:00
Xavier Fernandez
50b9313e0a Fixed #22771 -- Fixed test.Client.logout when using custom auth backend. 2014-06-13 13:03:58 -04:00
mlavin
4696cd9671 Fixed #22477 -- Removed contrib middleware from the global settings defaults. 
Also added a compatibility check for changed middleware defaults.

Forwardport of d94de802d3 from stable/1.7.x
 2014-06-13 12:45:56 -04:00
Maxime Turcotte
504c89e800 Fixed #6327 -- Added has_module_permission method to BaseModelAdmin 
Thanks chrj for the suggestion.
 2014-06-13 09:31:40 -04:00
Greg Chapple
bf743a4d57 Fixed #16087 -- Added ResolverMatch instance to test client response. 
Thanks mrmachine for the suggestion.
 2014-06-13 08:50:43 -04:00
Andrew Godwin
7b17350a1b Fixed #22823 (and partly #22563) - FKs from unmigrated apps breaking state. 
Thanks to bendavis78 for the test and diagnostic work.
 2014-06-12 10:22:43 -07:00
Tim Graham
9980f67154 Fixed a staticfiles test on Windows. 2014-06-12 13:08:27 -04:00
Richard Eames
7beaeeed2b Fixed #22814 -- Allowed ISO-8601 [+-]hh timezone format in parse_datetime 2014-06-12 10:58:50 -06:00
Tim Graham
a2cd0e12c9 Silenced deprecation warnings for refs #22811 and fixed build. 2014-06-12 09:28:36 -04:00
Tim Graham
1c58cabad7 Fixed #22811 -- Allowed setting both the old and new TEST database settings. 
An ImproperlyConfigured exception will be raised they mismatch.
 2014-06-12 08:17:49 -04:00
Shai Berger
64d94cffc7 Fixed #22487: Separated schema migration from data migration in test 
The data migration failed on Oracle, killing the entire test suite.

Thanks timo for reporting the Oracle breakage,
and andrewgodwin for suggesting the solution.
 2014-06-11 20:25:02 +03:00
Tim Graham
99f5ea9cc8 Fixed #22653 -- Added some database feature flags to tests. 
Thanks Rahul Priyadarshi.
 2014-06-11 11:45:18 -04:00
Moayad Mardini
5a3ae7e260 Created a new tests folder (model_options). 
And moved `tablespaces` option tests to it.
The new folder can be used to test models/options, like the new option
added in refs #22778.
 2014-06-11 11:37:52 -04:00
Preston Timmons
68efbfde5e Fixed #22068 -- Made runtests.py remove trailing slashes from test labels. 
When using tab-completion it's easy to accidentally run a test with
a trailing slash, which causes INSTALLED_APPS to be set incorrectly.
Normalize the test labels to avoid this common error.

Thanks MattBlack for the suggestion.
 2014-06-11 11:35:33 -04:00
Anubhav Joshi
42736ac8e8 Fixed #21430 -- Added a RuntimeWarning when unpickling Models and QuerySets from a different Django version. 
Thanks FunkyBob for the suggestion, prasoon2211 for the initial patch,
and akaariai, loic, and charettes for helping in shaping the patch.
 2014-06-11 10:03:34 -04:00
Alex Gaynor
e163a3d17b Removed an unused local variable, fixes a flake8 error 2014-06-11 00:22:30 -07:00
Florian Apolloner
e2efc8965e Fixed #22680 -- I/O operation on closed file. 
This patch is two-fold; first it ensure that Django does close everything in
request.FILES at the end of the request and secondly the storage system should
no longer close any files during save, it's up to the caller to handle that --
or let Django close the files at the end of the request.
 2014-06-11 08:57:30 +02:00
Tim Schaffer
a1c6cd6a16 Fixed #22780 -- Checked that LOCALE_PATHS is really a tuple 2014-06-10 23:04:24 +02:00
Moayad Mardini
868ff4e37c Fixed #22798 -- pluralize() now adds plural_suffix for any 1 < d < 2 
Thanks Odd_Bloke for the report.
 2014-06-10 16:04:43 -04:00
Greg Chapple
d8f19bb3b6 Fixed #22792 -- Updated checks for list_display_links in model admin 2014-06-10 09:35:05 -04:00
Aymeric Augustin
df09d85482 Fixed #17552 -- Removed a hack for IE6 and earlier. 
It prevented the GZipMiddleware from compressing some data types even on
more recent version of IE where the corresponding bug was fixed.

Thanks Aaron Cannon for the report and Tim Graham for the review.
 2014-06-10 08:42:31 +02:00
Tim Graham
fea8ccdcc4 Removed unused import. 2014-06-09 18:41:35 -04:00
Aymeric Augustin
40bfd8561d Fixed #20420 -- Normalized query counts on Oracle. 
This is achieved by inserting a fake entry in connection.queries when
not releasing a savepoint (since Oracle doesn't support that operation.)

Also removed the can_release_savepoints feature that was recently added,
but is superseded by this solution.
 2014-06-09 21:38:10 +02:00
Andrew Godwin
f146e70cb1 Remove overzealous migration flushes from migration test suite 2014-06-09 09:52:23 -07:00
Claude Paroz
96e4b52ab2 Converted Django scripts to argparse 
Refs #19973.
 2014-06-09 10:13:37 +02:00
Andrew Godwin
7018bcfb71 Fix broken alias testing test 2014-06-08 20:07:35 -07:00
Andrew Godwin
8c12d51ea2 Fixed #22487: Optional rollback emulation for migrated apps 2014-06-08 19:30:15 -07:00
Andrew Godwin
8721adcbfb Fix router_honored test to not close connection 2014-06-08 18:57:55 -07:00
Andrew Godwin
3f91238adf Fixed #22777: Add dependency on through for autodetected M2M adds 2014-06-08 17:12:59 -07:00
Andrew Godwin
4ce7a6bc84 Fixed #22750, #22248: Model renaming now also alters field FKs 2014-06-07 18:18:02 -07:00
Tim Graham
6c27ff957a Fixed flake8 error. 2014-06-07 20:35:28 -04:00
Víðir Valberg Guðmundsson
f70f669941 Fixed #22749: Making SQL management commands migration aware. 2014-06-07 17:18:30 -07:00
Andrew Godwin
6fd455adfc Fixed #22436: More careful checking on method ref'ce serialization 2014-06-07 17:05:51 -07:00
Aymeric Augustin
1a01e24331 Tested pluralization of decimals. 
Refs #16723.
 2014-06-07 23:12:13 +02:00
Aymeric Augustin
47a9347b98 Fixed #6992 -- Improved error when middleware omits HttpResponse. 
Thanks guettli for the report.
 2014-06-07 19:48:45 +02:00
Aymeric Augustin
fc31319752 Fixed test again. Refs #12581. 2014-06-07 17:16:49 +02:00
Aymeric Augustin
58de495c54 Fixed #17427 -- Removed dubious definition of connections equality. 2014-06-07 17:04:10 +02:00
Aymeric Augustin
d98cc41a84 Made a test compatible with Python 2 and 3. 2014-06-07 15:04:06 +02:00
Unai Zalakain
11284a63d4 Fixed #18314 -- Corrected request.build_absolute_uri() handling of paths starting with // 
``HttpRequest.build_absolute_uri()`` now correctly handles paths starting with ``//``.
``WSGIRequest`` now doesn't remove all the leading slashes either,
because ``http://test/server`` and http://test//server`` aren't the same thing
(RFC2396).

Thanks to SmileyChris for the initial patch.
 2014-06-07 08:59:02 -04:00
Aymeric Augustin
cfcca7ccce Fixed #3711, #6734, #12581 -- Bounded connection.queries. 
Prevented unlimited memory consumption when running background tasks
with DEBUG=True.

Thanks Rob, Alex, Baptiste, and others.
 2014-06-07 14:37:43 +02:00
Aymeric Augustin
1181b8a4a9 Merge pull request #2764 from gchp/ticket-20550 
Fixed #20550 -- Added keepdb argument to destroy_test_db
 2014-06-06 14:05:41 +02:00
Claude Paroz
daaeb84158 Fixed #22773 -- Forced templatize() to return unicode 2014-06-06 08:42:52 +02:00
Andrew Godwin
aa12ea05ce Rewrote migration autodetector to involve actual computer science. 
Fixes #22605, #22735; also lays the ground for some other fixes.
 2014-06-05 23:25:35 -07:00
Andrew Godwin
5826dc5282 Merge pull request #2736 from SmileyChris/migration-run_before 
Fixed #22725 - Migration.run_before does nothing
 2014-06-05 20:29:26 -07:00
Aymeric Augustin
e071f67b7f Replaced an explicit vendor check by a feature flag. 
Forward-port of c9aedce0 from stable/1.7.x.
 2014-06-06 00:32:13 +02:00
Aymeric Augustin
5c95a55330 Checked can_introspect_null feature in a test. 
Forward-port of 1238f92c from stable/1.7.x.
 2014-06-06 00:31:51 +02:00
Greg Chapple
72f055e535 Fixed #20550 -- Added keepdb argument to destroy_test_db 2014-06-05 23:17:27 +01:00
Susan Tan
484f3edf1e Fixed #18400 -- Modified length template filter to return 0 for unknown variables. 
Thanks Florian for the bug report, luyikei for the initial code patch, and
Bouke for the code review feedback.
 2014-06-05 15:41:56 -04:00
Anubhav Joshi
5643a3b51b Fixed #10811 -- Made assigning unsaved objects to FK, O2O, and GFK raise ValueError. 
This prevents silent data loss.

Thanks Aymeric Augustin for the initial patch and Loic Bistuer for the review.
 2014-06-05 13:12:01 -04:00
Aymeric Augustin
a03d38ddd4 Added a flag for the ability to introspect nullable fields. 
Previously this was conflated with another Oracle-specific behavior.
 2014-06-05 17:56:56 +02:00
Aymeric Augustin
237c229b91 Avoided using BinaryField unecessarily in tests. 
Several database backends struggle with binary data. This change
minimizes the risk of unrelated tests failures when binary fields
trigger errors.

Forward-port of 2e4bcb9b from stable/1.7.x.
 2014-06-05 17:11:10 +02:00
Aymeric Augustin
ae3fe6ccbb Reordered setUp code in prefetch_related tests. 
This allows these tests to run on databases that reject duplicate NULL
values in unique fields e.g. SQL Server.

Forward port of 4fb50a9a from stable/1.7.x.
 2014-06-05 16:33:02 +02:00
Anubhav Joshi
45e049937d Fixed #13776 -- Fixed ModelForm.is_valid() exception with non-nullable FK and blank=True. 
Thanks peterbe for the report.
 2014-06-04 07:57:19 -04:00
gyx1000
7e2c87809c Fixed #22684 -- Amended SelectDateWidget.empty_label to accept a tuple of values. 
Thanks danielsamuels for the report
 2014-06-04 07:23:25 -04:00
Claude Paroz
fb9d8f0652 Fixed #22717 -- Auto-corrected missing ending slash in FileSystemStorage 
Thanks David Fischer for the report and Moayad Mardini for the
review.
 2014-06-04 08:53:17 +02:00
Alexandr Shurigin
083d285b82 Fixed #22681 -- Made TarArchive recognize leading directories properly. 2014-06-03 12:00:33 -04:00
Tim Graham
4445d36d47 Fixed #22384 -- Deprecated reversing URLs by dotted path. 2014-06-03 07:30:14 -04:00
Nick Presta
11f0899bbe Fixed #11776 -- Added CSS class for non-field/top of form errors. 
Thanks Daniel Pope for the suggestion.
 2014-06-02 15:22:15 -04:00
Craig de Stigter
ce993efda8 Fixed #22690 -- Added a check for proxy models containing fields. 
Removed the FieldError raised by ModelBase.__new__ in this case.
 2014-06-02 09:32:38 -04:00
Tim Graham
5046c110cf Revert "Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices" 
This reverts commit 9d1987d767.
 2014-06-02 07:05:38 -04:00
Vincent-Vega
d04e730224 Fixed #22711 -- Adjusted ordering checks to allow implicit relation fields. 
refs #19195.
 2014-06-01 15:36:25 -04:00
Simon Charette
7a38f88922 Fixed #22659 -- Prevent model states from sharing field instances. 
Thanks to Trac alias tbartelmess for the report and the test project.
 2014-06-01 15:10:38 -04:00
José L. Patiño
7b064e5390 Split GenericRelationsTests.test_generic_relations into several tests; refs #18586. 2014-06-01 12:36:32 -04:00
Aymeric Augustin
2a5c750ad1 Merge pull request #2726 from gchp/ticket-20550 
Fixed #20550 -- Added ability to preserve test db between runs
 2014-06-01 17:26:56 +02:00
Florian Apolloner
83e7555ffe Revert "Making SQL management commands migration aware." 
This reverts commit cb9c9a7b58.
 2014-06-01 12:00:09 +02:00
Alex Gaynor
a31d7c48b0 Removed an unused import 2014-05-31 10:50:29 -07:00
Moayad Mardini
6f4d7f41b1 Improved the test for refs #22682. 
Thanks apollo13 for the review.
 2014-05-30 11:00:13 -04:00
Andrew Godwin
9cbf7f25ef Fix additional test failures caused by migration pollution 2014-05-29 16:44:12 -07:00
Andrew Godwin
347cab4fae Merge pull request #2744 from mmardini/MIGRATION_MODULES 
Fixed #22682 -- `makemigrations` will create `MIGRATION_MODULES` package
 2014-05-29 15:38:21 -07:00
Moayad Mardini
56cfa508c7 Fixed #22682 -- makemigrations will create MIGRATION_MODULES package 
`makemigrations` will automatically create the package specified
in `MIGRATION_MODULES` if it doesn't already exist.

Thanks ovidiuc4 for the report.
 2014-05-30 01:23:09 +03:00
Víðir Valberg Guðmundsson
cb9c9a7b58 Making SQL management commands migration aware. 2014-05-29 23:03:10 +02:00
Antonis Christofides
62f9508ade Fixed #20401 -- ContentTypeManager.get_for_model reads from db_for_read. 
Thanks Simon Charette and Tim Graham for the reviews.
 2014-05-29 23:01:55 +07:00
Chris Beaven
45fa520187 Implement Migration.run_before 
This attribute (used for reverse dependencies) was previously declared
and mentioned in the code, but never actually used.
 2014-05-29 22:42:11 +12:00
Alex Gaynor
d240b29c08 Fixed a typo that Tim Graham noticed 2014-05-28 17:46:06 -07:00
Alex Gaynor
1dcc603eff Fixed several typos in Django 2014-05-28 17:39:14 -07:00
Andrew Godwin
61185bba72 Merge pull request #2734 from valberg/double_order_trouble 
Fixed #22720 -- Migrations attempt to create _order twice.
 2014-05-28 17:12:01 -07:00
Víðir Valberg Guðmundsson
bf9953cfb8 Adding test to fix of duplicate _order fields (#22720) 2014-05-29 01:38:59 +02:00
Shai Berger
69337d485c Set straight the sense of 'uppercases_column_names' feature flag 2014-05-28 21:16:24 +03:00
Guillaume Pannatier
32586b0ba4 Fixed #22684 -- Added empty_label option on django.forms.extras.widets.SelectDateWidget 
Thanks danielsamuels for the report
 2014-05-28 13:23:28 -04:00
Greg Chapple
b7aa7c4ab4 Fixed #20550 -- Added ability to preserve test db between runs 2014-05-28 16:22:46 +01:00
Aymeric Augustin
4865326f22 Fixed #22699 -- Configure default settings in some management commands. 
This makes it possible to run django.setup() in management commands that
don't need a settings module. In addition it simplifies error handling.

Thanks Claude for the review.
 2014-05-27 21:43:52 +02:00
Moayad Mardini
2e613ea5c5 Fixed #22675 -- makemigrations --dry-run to output migrations to stdout. 
`makemigrations --dry-run` will output the complete migrations file
that would be written if it's used along with `--verbosity 3`.
 2014-05-27 00:40:55 +03:00
Florian Apolloner
ee51ab9d23 Restored Python 2 compatibility. 2014-05-26 00:07:15 +02:00
Florian Apolloner
9d1bf8f841 Removed executeable bit from a few files. 2014-05-25 23:16:40 +02:00
Florian Apolloner
536ebaa048 Fixed a few warnings in the testsuite. 2014-05-25 23:14:50 +02:00
Loic Bistuer
417ec4a68b Fixed a ResourceWarning that wasn't properly fixed by the previous commit. 
Also removed unused import in runtests.py.
 2014-05-26 04:01:41 +07:00
Loic Bistuer
b7de5f5d3f Fixed a few ResourceWarning in the test suite. Refs #22680. 2014-05-26 03:23:17 +07:00
Moayad Mardini
63fc91b3ca Fixed #22676 -- makemigrations --dry-run should not ask for defaults 
Made the fix in InteractiveMigrationQuestioner class code, rather than
MigrationAutodetector, because --dry-run shouldn't affect whether
MigrationAutodetector will detect non-nullable fields, but the
questioner should skip the question and returns a None for default
(since that won't be used anyway) if --dry-run is used.
 2014-05-24 09:56:18 -04:00
Marc Tamlyn
9fb0f5dddc Fixed #22510 -- Harden field removal to only None. 
Refs #8620.

If we allow any value to remove form fields then we get name clashes
with method names, media classes etc. There was a backwards
incompatibility introduced meaning ModelForm subclasses with declared
fields called media or clean would lose those fields.

Field removal is now only permitted by using the sentinel value None.
The docs have been slightly reworded to refer to removal of fields
rather than shadowing.

Thanks to gcbirzan for the report and initial patch, and several of the
core team for opinions.
 2014-05-24 13:10:50 +01:00
Claude Paroz
f47e226ff7 Moved some imports in runtests.py 2014-05-24 13:29:23 +02:00
Claude Paroz
19b4908206 Made runtests.py use 'set_installed_apps' API 
This will also trigger the ready method of any tested application,
which was not run before.
 2014-05-24 11:02:58 +02:00
Baptiste Mispelon
f01d2a8f9b Fixed tuple serialization test. 
Thanks to rockallite for the report.
 2014-05-23 14:50:10 +02:00
Huu Nguyen
f851a954ac Fixed #22602 -- Improved code coverage of makemigrations command tests. 2014-05-23 08:05:46 -04:00
Preston Timmons
be88b062af Fixed #21357 -- Fixed test client session initialization. 
The test client will now create a session when it is first accessed
if no session already exists.
 2014-05-22 20:29:48 -04:00
Unai Zalakain
4dc4d12e27 Fixed #21598 -- cleaned up template loader overrides in tests 
- Template loader overriding is managed with contexts.
- The test loader is a class (function based loaders entered deprecation timeline
  in 1.4).
- Template loader overrider that overrides with test loader added.
 2014-05-22 18:35:16 -04:00
Flavio Curella
beec05686c Fixed #22667 -- Replaced leader/follower terminology with primary/replica 2014-05-22 11:59:17 -04:00
Moayad Mardini
ad994a3c5b Fixed #22679 -- Fixed empty tuple serialization in MigrationWriter. 
Thanks rockallite.wulf for the report.
 2014-05-22 16:15:09 +02:00
Marc Tamlyn
635acf42c5 Fix a test dependent on json ordering. 2014-05-22 15:05:19 +01:00
Marc Tamlyn
6ab67919ac Made nested deconstruction support both forms of deconstruct() 
Nested deconstruction should (silently) handle Field.deconstruct() as
well as other arbitrary deconstructable objects. This allows having a
field in the deconstruction of another field.
 2014-05-22 13:23:51 +01:00
Marc Tamlyn
604162604b Added array field support for PostgreSQL. 
The first part of django.contrib.postgres, including model and two form
fields for arrays of other data types.

This commit is formed of the following work:

    Add shell of postgres app and test handling.

    First draft of array fields.

    Use recursive deconstruction.

    Stop creating classes at lookup time.

    Add validation and size parameter.

    Add contained_by lookup.

    Add SimpleArrayField for forms.

    Add SplitArrayField (mainly for admin).

    Fix prepare_value for SimpleArrayField.

    Stop using MultiValueField and MultiWidget.

    They don't play nice with flexible sizes.

    Add basics of admin integration.

    Missing:
    - Tests
    - Fully working js

    Add reference document for django.contrib.postgres.fields.ArrayField.

    Various performance and style tweaks.

    Fix internal docs link, formalise code snippets.

    Remove the admin code for now.

    It needs a better way of handing JS widgets in the admin as a whole
    before it is easy to write. In particular there are serious issues
    involving DateTimePicker when used in an array.

    Add a test for nested array fields with different delimiters.

    This will be a documented pattern so having a test for it is useful.

    Add docs for SimpleArrayField.

    Add docs for SplitArrayField.

    Remove admin related code for now.

    definition -> description

    Fix typo.

    Py3 errors.

    Avoid using regexes where they're not needed.

    Allow passing tuples by the programmer.

    Add some more tests for multidimensional arrays.

    Also fix slicing as much as it can be fixed.

    Simplify SplitArrayWidget's data loading.

    If we aren't including the variable size one, we don't need to search
    like this.
 2014-05-22 09:53:26 +01:00
Ramiro Morales
fce6a29428 Merge pull request #2498 from ramiro/move-serverhandler 
Moved ServerHandler helper class to tests.
 2014-05-21 18:59:01 -03:00
Ramiro Morales
d731f48ece Merge pull request #2679 from ramiro/t22421 
Fixed #22421 -- Regression in fixtures loading.
 2014-05-21 18:57:46 -03:00
Martin Brochhaus
bb0a9a070b Fixed #20477: Allowed list of modules for FORMAT_MODULE_PATH 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path). A feature has been added to also allow a list of strings.

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-21 07:35:47 -04:00
Tim Graham
dfeef8e147 Skipped a migrations test that's not supported on MySQL + Python 3. 2014-05-21 06:54:24 -04:00
Loic Bistuer
870b0a1f86 Fixed the ordering of prefetch lookups so that latter lookups can refer to former lookups. 
Thanks Anssi Kääriäinen and Tim Graham for the reviews. Refs #17001 and #22650.
 2014-05-21 10:30:48 +07:00
Loic Bistuer
bdf3473e64 Fixed #22650 -- Fixed regression on prefetch_related. 
Regression from f51c1f59 when using select_related then prefetch_related
on the reverse side of an O2O:

Author.objects.select_related('bio').prefetch_related('bio__books')

Thanks Aymeric Augustin for the report and tests. Refs #17001.
 2014-05-21 10:26:04 +07:00
Alex Gaynor
8a95b4fca7 Merge pull request #2692 from fcurella/patch-5 
#22667 replaced occurrences of master/slave terminology with leader/follower
 2014-05-20 09:37:04 -07:00
Flavio Curella
73a57b06f9 replaced occurrences of master/slave terminology with leader/follower 2014-05-20 11:35:16 -05:00
Denis Cornehl
3bec38888f Fixed #22557 -- ManifestStaticFilesStorage did not cleanup deleted files. 
When using ManifestStaticFilesStorage, deleted static files would be
correctly cleaned up by "collectstatic --clear", but the manifest file
would still contain the stale entries.

Thanks to tedtieken for the report
 2014-05-20 18:14:49 +02:00
Andrew Godwin
03900a02d5 Fixed #22432: SQLite M2M repointing now works. Thanks to xelnor. 2014-05-20 16:25:59 +01:00
Andrew Godwin
4e32e47348 Merge pull request #2634 from loic/ticket22424 
Fixed #22424 -- MySQL doesn't accept migrations' one-off default values ...
 2014-05-20 14:25:59 +01:00
Huu Nguyen
44304cf04e Fixed #22661 -- Move makemigrations tests to the proper class 2014-05-19 20:16:36 -07:00
Marc Tamlyn
3b765029f0 Fix a2dd618 for mysql. 2014-05-19 14:59:02 +01:00
Tim Graham
5abc811a40 Revert "Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules." 
This reverts commit 950b6de16a.
 2014-05-19 08:22:46 -04:00
Martin Brochhaus
950b6de16a Fixed #20477: Allowed settings.FORMAT_MODULE_PATH to be a list of modules. 
Previously the FORMAT_MODULE_PATH setting only accepted one string (dotted
module path).

This is useful when using several reusable third party apps that define new
formats. We can now use them all and we can even override some of the formats
by providing a project-wide format module.
 2014-05-19 07:59:13 -04:00
Esau Rodriguez
ec9043ab2f Fixed #21799 - Modified loaddata --ignorenonexistent to ignore models. 2014-05-18 15:52:07 -04:00
Huu Nguyen
949ee521fa Refs #21230 -- removed direct settings manipulation from staticfile tests 2014-05-18 14:27:35 -04:00
Loic Bistuer
5789ff7330 Failing testcases for #22649. 2014-05-18 12:46:12 +07:00
Loic Bistuer
1d3d01b4f7 Fixed #22424 -- Fixed handling of default values for TextField/BinaryField on MySQL. 
Thanks syphar for the review and suggestions.
 2014-05-18 11:58:16 +07:00
Ramiro Morales
862e1ff234 Fixed #22421 -- Regression in fixtures loading. 
Loading fixtures were failing since the refactoring in 244e2b71f5 for
inheritance setups where the chain contains abstract models and the
root ancestor contains a M2M relation.

Thanks Stanislas Guerra for the report.

Refs #20946.
 2014-05-17 17:36:45 -03:00
Markus Amalthea Magnuson
f7845449b4 Moved wordwrap test to their own function 
The `wordwrap` tests were in the `test_wordcount()` method for some
reason. This moves them to their own method, and make consistent use of
double quotes where needed.
 2014-05-17 20:42:58 +02:00
Alex Gaynor
b6b873d2ad Fixed several flake8 errors, including one where a test wouldn't be run 2014-05-17 09:54:34 -07:00
Marc Tamlyn
a2dd618e3b Fixed #22648 -- Transform.output_type should respect overridden custom_lookup and custom_transform. 
Previously, class lookups from the output_type would be used, but any
changes to custom_lookup or custom_transform would be ignored.
 2014-05-17 12:26:15 +02:00
Florian Apolloner
11932e978f Merge pull request #2346 from Markush2010/ticket21905 
Fixed #21905 -- Add info message if DateField or TimeField use a fixed value
 2014-05-17 12:09:04 +02:00
Unai Zalakain
ebb0279f4a Fixed #16245 -- Included traceback in send_robust()'s response 
Exceptions from the (receiver, exception) tuples returned by
``send_robust()`` now have always their traceback attached as their
``__traceback__`` argument.
 2014-05-16 18:41:40 -04:00
Aymeric Augustin
1109ebd7b3 Optimized make_aware/naive by removing redundant checks. Refs #22625. 
Also added tests with pytz and removed misplaced tests.
 2014-05-16 23:12:59 +02:00
Aymeric Augustin
fa89acf1d0 Fixed #22625 -- Normalized make_aware/naive errors. 
Also added tests for is/make_aware/naive.

Thanks Tom Michaelis for the report.
 2014-05-16 22:52:10 +02:00
Shai Berger
6bb6df2943 Fix storing of binary fields and unicode textfields for Oracle/Python3 2014-05-16 20:08:52 +03:00
Markus Holtermann
9d8c73f6a1 Fixed #21905 -- Add info message if DateField or TimeField use a fixed value 2014-05-16 18:59:31 +02:00
Stas Rudakou
ebd70d4d00 Fixed #22266 - quote PK before redirecting away from add_view (django.contrib.admin) 2014-05-16 18:33:17 +02:00
Vlad Starostin
1be03aff5c Fixed #18389 -- Fixed the way contribute_to_class is called 
Now this method is only called only if the object is an instance.
This allows to have field classes as model class attributes.
 2014-05-16 10:40:07 -04:00
Russell Keith-Magee
2c176eb95c Refs #21798 - Modified error number to provide room for future expansion. 2014-05-16 15:41:17 +02:00
Moayad Mardini
393ddc10a7 Fixed #22531 -- Added tree.Node.__repr__ and tests for the class. 
While Node class has a useful `__str__`, its `__repr__` is not that
useful. Added a `__repr__` that makes use of the current `__str__`.
This is especially useful since the more popular `Q` class inherits
`tree.Node`. Also created new tests that cover most of `Node` class
functionality.
 2014-05-16 09:30:25 -04:00
Alex Gaynor
fadc6cd1bd Removed an unused import 2014-05-16 09:24:41 -04:00
Nikolaus Schlemm
1ab278f39d Fixed #22490 -- removed obsolete ComplexFeed class from syndication_tests 
It was previously used in a test that was deprecated and then removed, this cruft can be removed now.
 2014-05-16 09:22:36 -04:00
Erik Romijn
424fe76349 Fixed #22579 -- Corrected validation for email to reject trailing slash 
Thanks to Claude Paroz for the report and patch and Tomasz
Paczkowski for the review.
 2014-05-16 15:13:11 +02:00
Stephen Burrows
d64f192df1 Fixed #22628 -- Took initial forms into account when combining FormSet.min_num and FormSet.extra. 
Forwardport of 79f15ab1ef from stable/1.7.x
 2014-05-16 06:38:24 -04:00
Marc Tamlyn
4a98130735 Merge pull request #2657 from nschlemm/20140516-test_testcase_ordering 
cater for running tests from another directory than tests
 2014-05-16 12:30:39 +02:00
Nikolaus Schlemm
d11e836203 cater for running tests from another directory than tests - applying existing pattern to newly added test_testcase_ordering as well 2014-05-16 12:11:35 +02:00
Claude Paroz
f5d4b45df1 Fixed #21634 -- Prevented hiding ImproperlyConfigured when command not found 
Thanks nikolay.v.golub@gmail.com for the report.
 2014-05-16 12:08:31 +02:00
Daniel Pyrathon
cb15231888 Fixed #21798 -- Added check for DateTime mutually exclusive options 
Added DateTimeCheckMixin to avoid the use of default, auto_now, and
auto_now_add options together. Added the fields.E151 Error that is raised
if one or more of these options are used together.
 2014-05-16 05:57:19 -04:00
Claude Paroz
e520a73eee Harmonized some PEP 0263 coding preambles 2014-05-15 19:58:41 +02:00
Anders Steinlein
4ef10f245a Fixed #17642 -- Added min_num support to modelformsets, inlines, and the admin. 
Thanks Stephen Burrows for work on the patch as well.

Forwardport of 2914f66983a92fcae55673c517dd8d01e8c238c4 from stable/1.7.x
 2014-05-15 07:25:35 -04:00
Erik Romijn
255449c1ee Added additional checks in is_safe_url to account for flexible parsing. 
This is a security fix. Disclosure following shortly.
 2014-05-14 10:19:48 +02:00
Aymeric Augustin
3800f63721 Dropped fix_IE_for_vary/attach. 
This is a security fix. Disclosure following shortly.
 2014-05-14 10:19:48 +02:00
Julen Ruiz Aizpuru
5eb81ce445 Fixed #22533 -- Added label_suffix parameter to form fields. 
Fields can now receive the `label_suffix` attribute, which will override
a form's `label_suffix`.

This enhances the possibility to customize form's `label_suffix`, allowing
to use such customizations while using shortcuts such as
`{{ form.as_p }}`.

Note that the field's own customization can be overridden at runtime by
using the `label_prefix` parameter to `BoundField.label_tag()`.

Refs #18134.
 2014-05-13 09:09:33 -04:00
Tim Graham
5971630de9 Fixed flake8 error. 2014-05-12 07:09:53 -04:00
Ramiro Morales
a9b7f31bfc Completed long overdue sqlinitialdata deprecation. 2014-05-11 23:15:59 -03:00
Ramiro Morales
c1b412ebd6 Fixed some test models' natural_key() methods. 2014-05-11 23:09:12 -03:00
Ramiro Morales
9762ba2630 Unneeded, Python 3 incompatible code in a75324c6 tests. 2014-05-11 20:39:00 -03:00
Rainer Koirikivi
a75324c654 Fixed #14226 -- Dependency calculation for complex M2M relations. 
`sort_dependencies` incorrectly interpreted 'complex' M2M relations
(with explicit through models) as dependencies for a model. This caused
circular complex M2M relations to be unserializable by dumpdata.

Thanks to aneil for the report and outofculture for initial tests.
 2014-05-11 19:50:01 -03:00
Claude Paroz
4cf82e5bcf Fixed #21685 -- Displayed app verbose name in admindocs model index 2014-05-10 18:09:07 +02:00
Aymeric Augustin
edecbb551b Minor cleanup in select_related_regress tests. 2014-05-10 16:41:54 +02:00
Aymeric Augustin
f574220f09 Fixed #22508 -- Avoided overwriting select_related. 
Previously, known related objects overwrote related objects loaded
though select_related. This could cancel the effect of select_related
when it was used over more than one level.

Thanks boxm for the bug report and timo for bisecting the regression.
 2014-05-10 16:39:20 +02:00
Aymeric Augustin
fb90b7cda2 Adjusted refactoring of vendor checks. 
Thanks Shai for the thorough review.
 2014-05-10 14:40:42 +02:00
Stephen Burrows
a5de0df58b Fixed #22502 -- Fixed microseconds/default/form interaction 
Made explicit lack of microsecond handling by built-in datetime form
fields. Used that explicitness to appropriately nix microsecond
values in bound fields. Thanks Claude Paroz for the review.
 2014-05-10 10:56:39 +02:00
Claude Paroz
35e1b1efab Used more precise assertions in cache tests 2014-05-09 19:34:53 +02:00
Malcolm Box
66880e4cd1 Fixed #22606 -- Locmemcache has_key() failed for infinite cache expiry 
Refactored cache expiry logic for Locmemcache to make consistent across
all places where accessed, and correctly handle None as expiry time.
 2014-05-09 18:35:07 +02:00
Andrew Godwin
fdbd29dd27 Tests for #22325 2014-05-08 21:48:10 -07:00
David Szotten
7fe60ae64a Fixed #22588 -- Fix RegexValidator __eq__ 
Compare parameters instead of re.pattern instances, and add the other
parameters to the comparison. Also add a __ne__ to make assertNotEqual
work properly.
 2014-05-08 19:51:15 -07:00
Aymeric Augustin
99d9fa329a Added feature flags for introspection capabilities. 2014-05-08 22:11:20 +02:00
Aymeric Augustin
cff59bedc2 Split ignores_nulls_in_unique_constraints feature. 
Oracle and SQL Server don't have exactly the same limitations. It's
worth treating them differently.
 2014-05-08 22:11:20 +02:00
Aymeric Augustin
c70a61eb49 Replaced vendor checks by three feature flags. 2014-05-08 22:11:15 +02:00
Aymeric Augustin
43a80f4812 Simplified indexes tests. 2014-05-08 21:50:21 +02:00
Aymeric Augustin
d667263169 Reorganized backends tests. 
This reduces the number of explicit vendor checks.
 2014-05-08 21:50:21 +02:00
Aymeric Augustin
b1432bfc22 Appeased flake8. 2014-05-08 21:49:54 +02:00
Andrew Godwin
b25aee3b7b Fixed #22476: Couldn't alter attributes on M2Ms with through= set 2014-05-08 10:34:24 -07:00
Andrew Godwin
5a917cfef3 Fixed #22496: Data migrations get transactions again! 2014-05-07 14:28:34 -07:00
Andrew Godwin
e9a456d11b Fixed #22581: Pass default values for schema through get_db_prep_save() 2014-05-07 13:46:23 -07:00
Andrew Godwin
6944418277 Fixed #22337: FileSystemStorage marked as deconstructible and tested. 2014-05-06 22:23:23 -07:00
Claude Paroz
da9cf53cb5 Fixed #22564 -- Prevented unneeded bytestrings in migrations 
In some cases, this could lead to migrations written with Python 2
being incompatible with Python 3.
Thanks Tim Graham for the report and Loïc Bistuer for the advices.
 2014-05-06 09:13:07 +02:00
Ben Davis
df60db0e78 Fixed #22570 -- Made Form.__getitem__ KeyError more descriptive. 2014-05-05 20:01:15 -04:00
Loic Bistuer
942556df2f Fixed #22572 -- override_settings(ROOT_URLCONF) didn't clear urlresolvers._urlconfs. 
Thanks Anubhav Joshi and Tim Graham for the reviews.
 2014-05-05 19:29:27 +07:00
Anssi Kääriäinen
3b7c66a3ac Fixed #22466 -- ordering by reverse foreign key 
Ordering by reverse foreign key was broken by custom lookups patch
(commit 20bab2cf9d).

Thanks to everybody who helped solving this issue. Special thanks to
Trac alias takis for reporting this.
 2014-05-05 15:28:07 +03:00
Jakub Roztocil
7131e14d00 Fixed #22489 -- missing implemenation for search lookup 
When custom lookups were added, converting the search lookup to use
the new Lookup infrastructure wasn't done.

Some changes were needed to the added test, main change done by
committer was ensuring the test works on MySQL versions prior to 5.6.
 2014-05-05 14:36:15 +03:00
Anssi Kääriäinen
5e1f4656b9 Fixed #22429 -- Incorrect SQL when using ~Q and F 2014-05-05 13:02:11 +03:00
Tim Graham
3818d96426 Fixed #22435 -- Prevented adding a ManyToManyField from prompting for a default. 
Thanks andrewsg for the report.
 2014-05-02 20:46:47 -04:00
Claude Paroz
142c27218a Fixed #22565 -- Prevented pgettext_lazy crash with bytestring input 
Thanks ygbo for the report.
 2014-05-02 19:33:22 +02:00
Loic Bistuer
d1799233f4 Fixed clash caused by the newly introduced -e shorthand for makemessages --exclude. 
This fixes a regression caused by 0707b82. Refs #22328.
 2014-05-02 23:07:17 +07:00
Chris Beaven
a0c4b8465d Fix migration autodector to work correctly with custom deconstructed values 2014-05-02 15:08:19 +12:00
Yehonatan Daniv
e2e4cdba11 Fixed #22539 -- Copied exclude argument in Model.full_clean() to prevent side effects. 2014-05-01 09:28:11 -04:00
Tim Graham
45c2d1f5d9 flake8 fixes. 2014-04-30 18:33:46 -04:00
Andrew Godwin
e049c88603 Cleanup failing test w/contenttypes and remove useless graph load 2014-04-30 15:11:52 -07:00
Andrew Godwin
8f6dff372b Fixed #22485: Include all unmigrated apps in project state by default. 2014-04-30 12:25:12 -07:00
Simon Charette
24ec9538b7 Fixed #19195 -- Allow explicit ordering by a relation _id field. 
Thanks to chrisedgemon for the report and shaib, akaariai and
timgraham for the review.
 2014-04-30 14:23:19 -04:00
Doug Beck
a5f6cbce07 Refactored DjangoTranslation class 
Also fixes #18192 and #21055.
 2014-04-30 18:36:25 +02:00
Claude Paroz
7c54f8cced Fixed #22474 -- Made migration recorder aware of multiple databases 
Thanks Tim Graham for the review.
 2014-04-30 16:53:20 +02:00
Mike Fogel
7fd1b35ed7 Fixed #22537 -- Add tests and improved docs for field subclass with choices. 2014-04-30 07:56:52 -04:00
Simon Charette
390f888745 Fixed #22447 -- Make sure custom model bases can be migrated. 
Thanks to cdestigter for the report.
 2014-04-29 09:43:08 -04:00
Tim Graham
aabceadd7d Revert "Fixed #15179 -- middlewares not applied for test client login()" 
This reverts commit 4fdd51b732.

See the ticket for concerns with this implementation; it will be revisited.
 2014-04-28 18:41:36 -04:00
Alex Gaynor
2bcb8bfc8d Fix many many typos in comments throughout the codebase 2014-04-26 10:18:45 -07:00
Aymeric Augustin
8b5b199e20 Fixed #3214 -- Stopped parsing SQL with regex. 
Avoided introducing a new regex-based SQL splitter in the migrations
framework, before we're bound by backwards compatibility.

Adapted this change to the legacy "initial SQL data" feature, even
though it's already deprecated, in order to facilitate the transition
to migrations.

sqlparse becomes mandatory for RunSQL on some databases (all but
PostgreSQL). There's no API to provide a single statement and tell
Django not to attempt splitting. Since we have a more robust splitting
implementation, that seems like a good tradeoff. It's easier to add a
new keyword argument later if necessary than to remove one.

Many people contributed to both tickets, thank you all, and especially
Claude for the review.

Refs #22401.
 2014-04-26 17:46:23 +02:00
Ana Krivokapic
0707b824fe Fixed #22328 -- Added --exclude option to compilemessages and makemessages. 2014-04-26 17:07:44 +07:00
Tim Graham
d238c58912 Fixed #22499 -- Fixed a typo in an admin_views test that caused failure on Oracle. 2014-04-24 07:06:02 -04:00
Kevin Christopher Henry
91afc00513 Fixed #21157 -- Fixed problems with ResolverMatch 
- Fixed bug in get_callable() that caused resolve() to put a string
  in ResolverMatch.func.
- Made ResolverMatch.url_name match the actual url name (or None).
- Updated tests that used the string value in ResolverMatch.func, and
  added regression tests for this bug.
- Corrected test urls whose dummy view paths caused failures (behavior
  that was previously masked by this bug).
 2014-04-23 20:12:34 -04:00
Malcolm Box
af5f688392 Fixed #22495 -- Locmem cache.add() failed with infinite timeouts 
cache.add() incorrectly succeeded when there was an existing key
with an infinite (None) timeout.
 2014-04-23 14:49:46 +02:00
Preston Timmons
3c06b2f2a3 Fixed #22486 -- Restored the ability to reverse views created using functools.partial. 
Regression in 8b93b31487.

Thanks rcoup for the report.
 2014-04-23 07:27:52 -04:00
Erik Romijn
75c0d4ea3a Fixed queries that may return unexpected results on MySQL due to typecasting. 
This is a security fix; disclosure to follow shortly.
 2014-04-21 18:11:26 -04:00
Aymeric Augustin
c083e3815a Prevented leaking the CSRF token through caching. 
This is a security fix. Disclosure will follow shortly.
 2014-04-21 18:11:26 -04:00
Tim Graham
8b93b31487 Fixed a remote code execution vulnerabilty in URL reversing. 
Thanks Benjamin Bach for the report and initial patch.

This is a security fix; disclosure to follow shortly.
 2014-04-21 18:11:26 -04:00
Claude Paroz
ab90c4707b Fixed table cleanup in GIS migration tests 2014-04-21 23:08:00 +02:00
Aymeric Augustin
c54e7ec9ca Merge pull request #2592 from prestontimmons/remove-test-runner-cases 
Removed old test runner test cases.
 2014-04-21 18:06:19 +02:00
Florian Apolloner
a4553e0510 Fixed monkeypatching in a staticfiles test. 2014-04-21 14:51:52 +02:00
Aymeric Augustin
428c0bbe1b Appeased flake8 2.1.0. 2014-04-21 12:27:34 +02:00
Aymeric Augustin
df3b1a01c7 Consolidated expressions tests. 2014-04-21 12:15:04 +02:00
Aymeric Augustin
25b2ce896b Consolidated get_or_create tests. 2014-04-21 12:12:09 +02:00
Aymeric Augustin
3f01e82c59 Further consolidated the model_inheritance tests. 2014-04-21 11:50:53 +02:00
Aymeric Augustin
3f76339355 Fixed #22402 -- Consolidated model_inheritance tests. 
The model_inheritance_same_model_name tests couldn't be run without the
model_inheritance tests. Make the problem go away by merging them.

Thanks timo for the report.
 2014-04-21 11:43:08 +02:00
Preston Timmons
251e833c75 Removed old test runner test cases. 
These files were added as part of #12658, which pertained to the old django.test.simple test runner. No tests call them anymore.
 2014-04-20 22:00:39 -05:00
Tim Graham
471fb04a30 Fixed flake8 errors. 2014-04-20 13:08:04 -04:00
Andrew Gorcester
956bd64424 Fixed #22397 -- Issues removing M2M field with explicit through model 
Changed the migration autodetector to remove models last so that FK
and M2M fields will not be left as dangling references. Added a check
in the migration state renderer to error out in the presence of
dangling references instead of leaving them as strings. Fixed a bug
in the sqlite backend to handle the deletion of M2M fields with
"through" models properly (i.e., do nothing successfully).

Thanks to melinath for report, loic for tests and andrewgodwin and
charettes for assistance with architecture.
 2014-04-18 16:44:47 -04:00
amatellanes
8394e570ba Fixed #22465 -- New assertion assertJSONNotEqual 2014-04-18 15:11:08 +07:00
Simon Charette
9bc377d7d0 Fixed a test failure introduced by 214d1e1b0f. 2014-04-18 02:30:40 -04:00
Simon Charette
0d397e5a5b Revert "Fixed #22397 -- Issues removing M2M field with explicit through model." 
This reverts commit 00e3b9a2a9.

It's causing a regression when tested with the proxy_model_inheritance tests.
 2014-04-18 01:27:30 -04:00
Andrew Gorcester
00e3b9a2a9 Fixed #22397 -- Issues removing M2M field with explicit through model. 
Changed the migration autodetector to remove models last so that FK
and M2M fields will not be left as dangling references. Added a check
in the migration state renderer to error out in the presence of
dangling references instead of leaving them as strings. Fixed a bug
in the sqlite backend to handle the deletion of M2M fields with
"through" models properly (i.e., do nothing successfully).

Thanks to melinath for report, loic for tests and andrewgodwin and
charettes for assistance with architecture.
 2014-04-17 12:54:35 -04:00
Tim Graham
47927eb786 Revert "Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse." 
This reverts commit 071c933775.

This introduced a regression on MySQL and custom SQL is deprecated.
 2014-04-16 21:03:22 -04:00
chriscauley
66ec9ee441 Fixed #22378 -- Updated \d to [0-9]+ in urlpatterns of docs and tests. 
Thanks tomwys for the suggestion.
 2014-04-16 20:36:29 -04:00
Justin Hamade
a13df671a5 Fixed #22434 -- Retain ordering on related sliced subqueries. 
Thanks maciej.pawlisz for the report, and charettes for the review.
 2014-04-16 17:57:11 -04:00
Simon Charette
79f05616fb Fixed flake8 warnings introduced in recent commits. 2014-04-16 16:49:37 -04:00
Motiejus Jakštys
0e45669fa9 Fixed #22460 -- Explicity remove constraints when dropping a related field. 2014-04-16 15:38:31 -04:00
Julien Phalip
401be8a206 Merge pull request #2553 from liavkoren-vmfarms/ticket_18586 
Ticket 18586
 2014-04-14 18:23:01 -04:00
Liav Koren
9b29a551e4 Refs #18586 - Refactored model get_or_create test. 
Refactored get_or_create test into several smaller test functions across two
different test classes. Also converted the comments over to docstrings.
 2014-04-14 18:19:37 -04:00
Marc Egli
0bcc92c691 Fixed #22356 -- Added a check to make sure unique_together fields are local. 2014-04-14 16:49:40 -04:00
Jacob R. Rothenbuhler
17c1884456 Fixed #22369 -- Added count parameter to assertTemplateUsed 2014-04-14 15:55:10 -04:00
Simon Charette
72d3889db4 Fixed #22350 -- Consistently serialize bytes and text in migrations. 
Thanks to @treyhunner and Loïc for their suggestions and review.
 2014-04-13 18:22:26 -04:00
Loic Bistuer
b82f30785f Fixed stray comment introduced by d3b71b9. 
Thanks Claude Paroz for the report.
 2014-04-13 08:26:25 +07:00
valtron
d3b71b976d Fixed #21760 -- prefetch_related used an inefficient query for reverse FK. 
Regression introduced by commit 9777442. Refs #21410.
 2014-04-13 00:34:16 +07:00
Claude Paroz
3417ba0309 Also allowed a non-overridden setting to be deleted 
Refs #20032, #18824. Thanks ztorstri at gmail.com for the report.
 2014-04-12 15:33:22 +02:00
Claude Paroz
3e3a7372f5 Fixed #22102 -- Made SimpleTestCase tests run before unittest.TestCase ones 
Thanks aptiko for the reporti and Tim Graham for the review.
 2014-04-12 11:42:06 +02:00
Aymeric Augustin
8176150850 Fixed #21202 -- Maintained atomicity when the server disconnects. 
Thanks intgr for the report.

This commit doesn't include a test because I don't know how to emulate a
database disconnection in a cross-database compatible way.

Also simplified a 'backends' test that was constrained by this problem.
 2014-04-10 21:22:47 +02:00
Aymeric Augustin
25860096f9 Fixed #21239 -- Maintained atomicity when closing the connection. 
Refs #15802 -- Reverted #7c657b24 as BaseDatabaseWrapper.close() now
has a proper "finally" clause that may need to preserve self.connection.
 2014-04-10 20:57:43 +02:00
Tim Graham
395d75ea6b Fixed #22194 -- Added --list-tags option to check command. 
Thanks Elvard for the patch.
 2014-04-10 09:43:55 -04:00
Shai Berger
f095356ba2 Fixed #22343 -- Disallowed select_for_update in autocommit mode 
The ticket was originally about two failing tests, which are
fixed by putting their queries in transactions.

Thanks Tim Graham for the report, Aymeric Augustin for the fix,
and Simon Charette, Tim Graham & Loïc Bistuer for review.
 2014-04-10 03:04:51 +03:00
julien 'pouete' Godin
071c933775 Fixed #22401 -- Deprecated regular expression parsing of initial SQL in favor of installing sqlparse. 2014-04-09 19:25:07 -04:00
Aymeric Augustin
5f2f47fdfc Fixed #21553 -- Ensured unusable database connections get closed. 2014-04-09 22:41:33 +02:00
Aymeric Augustin
2791fbf59d Used more specific test assertions. 2014-04-09 22:20:22 +02:00
e0ne
2aaa045c61 Fixed #13408 -- Deprecated silent unpacking exception passing in for template tag. 
Thanks peterbe for the suggestion.
 2014-04-08 13:55:17 -04:00
Huu Nguyen
b9bfcd82f0 Refs #21230 -- removed direct settings manipulation from signed cookies tests 2014-04-08 12:15:08 -04:00
Alejandro Gómez
7a7f6fccae Fixed #21084 -- Used proxy model's content type for admin log entries. 2014-04-07 08:52:41 -04:00
Anubhav Joshi
cd914e31c9 Fixed #21977 -- Deprecated SimpleTestCase.urls 2014-04-06 17:33:43 -04:00
Simon Charette
074d3183d9 Fixed #22363 -- Correctly serialize django.utils.datetime_safe objects. 
Thanks to linovia for the report.
 2014-04-03 14:54:16 -04:00
Tim Graham
d73d0e071c Fixed #22218 -- Deprecated django.conf.urls.patterns. 
Thanks Carl Meyer for the suggestion and Alex Gaynor and Carl for reviews.
 2014-04-03 07:28:10 -04:00
Daniel Neuhäuser
4aa80149e7 Fixed #22327 -- Turned BaseEmailBackend into a context manager 
Changed the BaseEmailBackend to allow usage as context manager to open
and close connections.
 2014-03-31 14:08:51 -04:00
Claude Paroz
d902fd625d Added test to confirm #12583 resolution 2014-03-31 18:24:01 +02:00
Loic Bistuer
4d996b8e69 Fixed #22360 -- Fixed two non-deterministic tests in Python 3.4. 
The order of admin's changelist filters in the querystring relied on
dict ordering.
 2014-03-31 08:19:43 -04:00
Loic Bistuer
4339e9a92d Fixed #21795 -- Made add_preserved_filters account for url prefixes. 
Thanks to trac username honyczek for the report. Refs #6903.
 2014-03-31 07:19:59 -04:00
Loic Bistuer
0fd51cf0bd Fixed #22319 -- Fixed migration external dependencies when there are internal dependencies. 2014-03-31 06:50:38 -04:00
Loic Bistuer
a449e7feec Fixed #22359 -- Changing M2M field to blank=True failed on sqlite. 2014-03-31 06:13:19 -04:00
Ramiro Morales
9a982d5ccc Moved ServerHandler helper class to tests. 
It has been only used in the builtin_servers tests since Django 1.4.
 2014-03-30 20:55:40 -03:00
Alex Gaynor
778ce245dd Corrected many style guide violations that the newest version of flake8 catches 2014-03-30 12:11:05 -07:00
Alex Gaynor
92dbf34286 Ensure that a file is closed in the tests 2014-03-30 11:50:18 -07:00
Tim Graham
69a4f383f6 Fixed #22338 -- Fixed a test dependent on dictionary key iteration order. 2014-03-30 14:25:06 -04:00
Loic Bistuer
da7ab8728c Fixed mistake in tests from commit 2039908. Refs #19816. 2014-03-30 18:48:27 +07:00
Loic Bistuer
20399083f4 Fixed #19816 -- Pre-evaluate querysets used in direct relation assignments. 
Since assignments on M2M or reverse FK descriptors is composed of a `clear()`,
followed by an `add()`, `clear()` could potentially affect the value of the
assigned queryset before the `add()` step; pre-evaluating it solves the problem.

This patch fixes the issue for ForeignRelatedObjectsDescriptor,
ManyRelatedObjectsDescriptor, and ReverseGenericRelatedObjectsDescriptor.
It completes 6cb6e1 which addressed ReverseManyRelatedObjectsDescriptor.
 2014-03-30 15:36:45 +07:00
Loic Bistuer
bc9be72bdc Fixed transaction handling for a number of operations on related objects. 
Thanks Anssi and Aymeric for the reviews. Refs #21174.
 2014-03-30 12:13:00 +07:00
Loic Bistuer
975337e5c3 Cleaned up tests for multiple databases. 2014-03-30 10:51:01 +07:00
Maxime Turcotte
5e4e0b6fe9 Fixed #22306 -- Deprecated future versions of cycle and firstof template tags. 2014-03-28 18:55:06 -04:00
Tim Graham
e2ac0203d9 Skipped JavascriptI18nTests if Firefox isn't properly configured. 
Code borrowed from django.contrib.admin.tests. Without this, the class can
throw an exception with something like "The browser appears to have exited
before we could connect. The output was: Error: no display specified"
 2014-03-27 14:19:31 -04:00
Tim Graham
c19bbefca2 Fixed a deprecation warning on Python 3. 2014-03-27 06:59:54 -04:00
Tim Graham
c170c3761b Skipped a test that errors rather than marked it as an expectedFailure. 
The test throws an error which Python 3.4 doesn't seem to catch as an
expectedFailure.

refs 7476d96f83
 2014-03-27 06:11:39 -04:00
Claude Paroz
bf2b0affe4 Forgotten slash removal in d320863878 2014-03-26 19:51:17 +01:00
Claude Paroz
d320863878 Fixed #22114 -- Stopped adding trailing slashes in URLField.to_python 
Thanks coredumperror at gmail.com for the report and Tim Graham
for the review.
 2014-03-26 18:10:58 +01:00
Tim Graham
42336c84a0 Fixed #22331 -- Made MigrationAutodetector ignore unmanaged models. 
This commit reverts 69d4b1c and tackle the issue from a different angle.
Models remain present in the project state, but are now ignored by the
autodetector.
 2014-03-25 18:30:58 -04:00
Simon Charette
1506c71a95 Fixed #12030 -- Validate integer field range at the model level. 
Thanks to @timgraham for the review.
 2014-03-25 14:31:20 -04:00
Loic Bistuer
69d4b1c3ea Fixed #22331 -- Fixed migrations ProjectState to ignore unmanaged models. 2014-03-25 10:33:44 -04:00
David Evans
86dcac4634 Fixed #22315 -- str/bytes mismatch in staticfiles 
Previously, `ManifestFilesMixin.read_manifest` failed in Python 3
because `json.loads` accepts `str` not `bytes`.
 2014-03-25 09:53:24 -04:00
Ben Davis
16afffffe8 Fixed #22087 -- Made AdminReadonlyField respect ModelForm Meta overrides. 2014-03-25 09:33:13 -04:00
Stephen Burrows
35ed792cf2 Fixed #22300 -- Fixed crash in migrations when changing non-relational field to relational. 2014-03-25 07:46:15 -04:00
Marc Tamlyn
09ab447d08 Merge pull request #2465 from coder9042/ticket_22258 
Fixed #22257 -- Added file output option to dumpdata command.
 2014-03-25 11:42:03 +00:00
Anubhav Joshi
f34e8fc890 Fixed #22257 -- Added file output option to dumpdata command. 2014-03-25 13:47:03 +05:30
Daniel Hahler
1edfa155e3 Fixed #22293 -- Avoided renaming many-to-many tables to themselves. 
Fixed this for both implementations of _alter_many_to_many, instead of
in `alter_db_table` itself (more implementations).
 2014-03-24 13:24:52 -04:00
Anubhav Joshi
416a858023 Fixed #17922 -- Added required_css_class to form label. 
Thanks hanson2010 for the suggestion.
 2014-03-24 08:11:54 -04:00
Loic Bistuer
7ac8380799 Fixed #22318 -- Added Form.has_error() to easily check if a given error has happened. 2014-03-24 07:21:32 -04:00
Aymeric Augustin
58161e4e93 Fixed #22291 -- Avoided shadowing deadlock exceptions on MySQL. 
Thanks err for the report.
 2014-03-23 20:45:22 +01:00
Aymeric Augustin
b66e85342b Fixed #22308 -- Regression from 0f956085. 
Rewrote the test for #9479 according to the original ticket.
 2014-03-22 21:35:46 +01:00
Aymeric Augustin
232181d1c5 Advanced deprecation warnings for 1.8. 2014-03-22 21:12:58 +01:00
Ramiro Morales
491419b5ff Made m2m fields form help_text munging specific to admin widgets. 
Refs #9321 and follow-up to e80de93af6.
 2014-03-22 15:43:17 -03:00
Loic Bistuer
e61d99d96d Fixed #20684 -- Added support for HTML5 boolean attributes to form widgets. 2014-03-22 14:28:12 -04:00
Claude Paroz
c94bff2b26 Fixed #22241 -- Selectively added line breaks in admin read-only fields 
When content is supposed to contain HTML, we do not try to add
line breaks in read-only contents.
Thanks Alexander Todorov for the report.
 2014-03-22 17:00:50 +01:00
Patrick Michaud
acee46fc95 Fixed #22256 -- Replaced bad fallback for missing PATH 
Thanks Baptiste Mispelon for the review.
 2014-03-22 16:52:05 +01:00
Claude Paroz
bc315266c8 Fixed #22294 -- Prevented converting length filter output to string 
Thanks Steve Pike for the report.
 2014-03-22 16:39:46 +01:00
Claude Paroz
6a0291bdaf Tweaked strip_tags tests to pass on Python 3.3 2014-03-22 14:43:11 +01:00
Tim Graham
ee4edb1eda Made ModelForms raise ImproperlyConfigured if the list of fields is not specified. 
Also applies to modelform(set)_factory and generic model views.

refs #19733.
 2014-03-22 07:56:48 -04:00
Aymeric Augustin
0757e0f30d Avoided transactional DDL on castrated databases. 
Fixed a test failure that appeared after 753a22a6, although the bug
existed before that commit.

Refs #22308.
 2014-03-22 11:05:14 +01:00
Claude Paroz
6ca6c36f82 Improved strip_tags and clarified documentation 
The fact that strip_tags cannot guarantee to really strip all
non-safe HTML content was not clear enough. Also see:
https://www.djangoproject.com/weblog/2014/mar/22/strip-tags-advisory/
 2014-03-22 10:59:18 +01:00
Tim Graham
e80de93af6 Removed hard-coded help_text for ManyToManyFields that use a SelectMultiple widget 
Per deprecation timeline; refs #9321.
 2014-03-21 19:10:07 -04:00
Hans Lawrenz
918a16bc4c Fixed #22307 -- Fixed SpooledTemporaryFile bug in File class. 
Added condition to prevent checking the existence of a file name of a
file like object when the name attribute is None. This is necessary
because a SpooledTemporaryFile won't exist on the file system or have a
name until it has reached its max_size. Also added tests.
 2014-03-21 22:34:47 +01:00
Aymeric Augustin
6993f2886b Fixed typo in comments. 2014-03-21 22:16:31 +01:00
Aymeric Augustin
ad3942d325 The cycle and firstof tags no longer raise warnings. 
Refs #17906.
 2014-03-21 21:40:04 +01:00
Aymeric Augustin
ad83d37bf8 Removed useless warning silencing. 
If memory serves, the corresponding warning disappeared in Django 1.7.
 2014-03-21 21:38:24 +01:00
Aymeric Augustin
753a22a635 Fixed transaction handling in two management commands. 
Previously, when createcachetable and flush operated on non-default
databases, they weren't atomic.
 2014-03-21 21:29:51 +01:00
Aymeric Augustin
0f9560855e Removed legacy transaction management per the deprecation timeline. 2014-03-21 21:06:50 +01:00
Tim Graham
bf5430a20b Removed django.test.simple and django.test._doctest per deprecation timeline. 
refs #17365, #17366, #18727.
 2014-03-21 13:36:46 -04:00
Tim Graham
1ea44a3abd Switched {% cycle %} and {% firstof %} tags to auto-escape their variables per deprecation timeline. 
refs #17906.
 2014-03-21 13:17:10 -04:00
Tim Graham
4965a77407 Removed PIL compatability layer per deprecation timeline. 
refs #19934.
 2014-03-21 10:54:53 -04:00
Tim Graham
f567d04b24 Removed settings.CACHE_MIDDLEWARE_ANONYMOUS_ONLY per deprecation timeline. 
refs #15201.
 2014-03-21 09:46:17 -04:00
Tim Graham
8b81dee60c Removed fix_ampersands template filter per deprecation timeline. 
Also removed related utility functions:
* django.utils.html.fix_ampersands
* django.utils.html.clean_html
 2014-03-21 08:50:43 -04:00
Tim Graham
11e22129d5 Removed settings.SEND_BROKEN_LINK_EMAILS per deprecation timeline. 2014-03-21 07:15:58 -04:00
Tim Graham
aa93a1890f Removed contrib.comments per deprecation timeline. 2014-03-21 07:05:36 -04:00
Tim Graham
35f46ec7a9 Fixed flake8 warnings. 2014-03-21 06:24:45 -04:00
Dejan Noveski
4d0c5f6142 Fixed #22255 -- Added support for specifying re flags in RegexValidator 2014-03-21 11:12:36 +01:00
Alex Gaynor
0cf158cf9a Fixed a small collection of flake8 violations that had snuck in 2014-03-20 10:30:41 -07:00
Andrew Godwin
81f5408c7a Fixed #22275: unique_together broken if ForeignKey split into new file. 
Thanks to bak1an for the patch.
 2014-03-19 21:23:21 -07:00
Andrew Godwin
356f064c49 Merge pull request #2221 from bmispelon/LazyObject-refactor 
Fixed #21840 -- Moved dunder methods from SimpleLazyObject to LazyObject...
 2014-03-19 21:01:24 -07:00
Anubhav Joshi
659b5678fc Fixed #22184 -- Allowed template_tests.tests to be run isolated 2014-03-15 12:34:11 +01:00
Marc Tamlyn
d22b291890 Fixed #22001 -- Ensure db_type is respected. 
db_parameters should respect an already existing db_type method and
return that as its type string. In particular, this was causing some
fields from gis to not be generated.

Thanks to @bigsassy and @blueyed for their work on the patch.

Also fixed #22260
 2014-03-14 22:32:17 +00:00
Baptiste Mispelon
37f7f233f5 Fixed #22272 -- Fixed regression in DecimalField when using decimal_places=0. 
Thanks to trac user merb for the report.
 2014-03-14 17:21:59 +01:00
Claude Paroz
666a2ad22f Merged model_forms_regress with model_forms tests 2014-03-14 15:18:08 +01:00
Claude Paroz
72cfbdc10a Fixed #6103 -- Splitted tests in model_forms tests 2014-03-14 09:44:56 +01:00
Claude Paroz
5a976b4bec Fixed #22245 -- Avoided widget overwrite in forms.IntegerField subclasses 
Thanks Jeroen Pulles for the report and Simon Charette for the review.
 2014-03-13 16:58:14 +01:00
Baptiste Mispelon
61917aa08b Fixed #21840 -- Moved dunder methods from SimpleLazyObject to LazyObject. 
This commit also added tests for LazyObject and refactored
the testsuite of SimpleLazyObject so that it can share
test cases with LazyObject.
 2014-03-13 10:03:01 +01:00
Shai Berger
4b4c704517 Skip test for saving microseconds on backends which do not support it. 2014-03-13 00:28:05 +02:00
Shai Berger
6983201cfb Fixed #20292: Pass datetime objects (not formatted dates) as params to Oracle 
This seems worthwhile in its own right, but also works around an Oracle
bug (in versions 10 -- 11.1) where the use of Unicode would reset the
date/time formats, causing ORA-01843 errors.

Thanks Trac users CarstenF for the report, jtiai for the initial patch,
and everyone who contributed to the discussion on the ticket.
 2014-03-12 23:43:45 +02:00
Shai Berger
fc79c3fb3d Flake8 corrections 2014-03-12 20:34:05 +02:00
Shai Berger
d181384e5f Fixed test failure on Oracle: model_fields.tests.test_float_validates_object 
Failing test introduced in fix for refs #22210.
 2014-03-12 20:17:43 +02:00
Akis Kesoglou
aaad3e27ac Fixed #22217 - ManyToManyField.through_fields fixes. 
- Docs description of arguments mix up.
- Keep it from erroneously masking E332 check.
- Add checks E338 and E339, tweak message of E337.
 2014-03-11 19:33:04 -03:00
Andrew Godwin
f4d91638fc Remove failing test while we fix the underlying bug 2014-03-11 10:33:57 -07:00
Tim Graham
c4f772ed34 Fixed test failures on Windows. 
refs #21092 and 8d7e048a8b
 2014-03-11 10:46:13 -04:00
Chris Beaven
107c9f5453 Fix AlterField migrations that are related to a RenameModel migration 2014-03-11 17:13:26 +13:00
Chris Beaven
40f6ca54f8 Fix autodetector creation of RenameModel migration to capitalize model names 2014-03-11 12:23:45 +13:00
Daniel Pyrathon
819e09b848 Fixed #22210 -- Saving model instances to non-related fields. 
Previously, saving a model instance to a non-related field (in
particular a FloatField) would silently convert the model to an Integer
(the pk) and save it. This is undesirable behaviour, and likely to cause
confusion so the validatio has been hardened.

Thanks to @PirosB3 for the patch and @jarshwah for the review.
 2014-03-10 15:25:18 +00:00
Chris Beaven
7feb70eef3 Fixed #22239 -- Add auto detection of renamed models 2014-03-10 13:55:44 +13:00
Claude Paroz
c564277937 Fixed #22237 -- Removed some warnings in the test suite 
Thanks Aymeric Augustin for the report.
 2014-03-09 22:10:49 +01:00
Aymeric Augustin
3a34f71d4d Removed obsolete hack to run template tests. 2014-03-09 11:07:21 +01:00
Aymeric Augustin
06615d0d6e Avoided leaking warning filters. 2014-03-09 11:07:21 +01:00
Shai Berger
0615eaf24a Corrected a few missed references to old test settings 2014-03-09 08:33:33 +02:00
Alex Gaynor
add1584bfa 4 flake8 warning fixes 2014-03-08 16:17:54 -08:00
Andrew Godwin
abccbcf52d Fixed #21843: Remove explicit ID column setting in test 2014-03-08 16:04:21 -08:00
Andrew Godwin
6b07804474 Fixed #22183: Through M2Ms now correctly handled 2014-03-08 15:58:04 -08:00
Andrew Godwin
cdf6eba181 Merge pull request #2315 from bendavis78/issues/22073 
Fixed #22073 - Ensure CreateTable operation handles backwards migration correctly when M2M fields are present
 2014-03-08 15:44:45 -08:00
Andrew Godwin
cd7a2a077e Fixed #22199: Bad max_length deconstruction for FileField 2014-03-08 13:59:12 -08:00
Claude Paroz
8d7e048a8b Improved compatibility in admin_scripts tests 
Environment keys/values need to use native strings on some
plateforms. Thanks anubhav joshi for detecting the issue and
helping shaping the patch.
 2014-03-08 20:58:24 +01:00
Claude Paroz
b787ef2dbf Fixed #21092 -- Ensured admin_scripts tests are run with warnings off 2014-03-08 12:49:06 +01:00
Claude Paroz
56c80e8b44 Avoided modifying current environment in admin_scripts tests 2014-03-08 12:32:57 +01:00
Claude Paroz
8446a2438f Added test about error filterwarnings 
Refs #20083.
 2014-03-08 11:51:49 +01:00
Claude Paroz
0c6a339952 Avoided changing raw DeprecationWarning filter behavior 
Refs #21188. Now pure Python DeprecationWarning visibility should
be back to Python defaults.
 2014-03-08 11:13:48 +01:00
Claude Paroz
210d0489c5 Fixed #21188 -- Introduced subclasses for to-be-removed-in-django-XX warnings 
Thanks Anssi Kääriäinen for the idea and Simon Charette for the
review.
 2014-03-08 09:57:40 +01:00
Russell Keith-Magee
70ec4d776e Fixed #22034 -- Added a specific set of relation checks for GenericInlineModelAdmin. 
Thanks to jwa for the report.
 2014-03-08 11:25:23 +08:00
Anssi Kääriäinen
219d928852 Fixed #21863 -- supplemented get_lookup() with get_transform() 
Also fixed #22124 -- Expanded explanation of exactly what is going on in
as_sql() methods.
 2014-03-07 14:52:13 +00:00
Andrew Godwin
e46e15e5a1 Fixed #22204: Bad circular-dep-breaking if more than one per run 2014-03-06 13:22:42 -08:00
Roger Hu
9b729ddd8f Fixed #22185 -- Added settings.CSRF_COOKIE_AGE 
Thanks Paul McMillan for the review.
 2014-03-06 08:28:43 -05:00
Gabe Jackson
b77f26313c Fixed #22207 -- Added support for GenericRelation reverse lookups 
GenericRelation now supports an optional related_query_name argument.
Setting related_query_name adds a relation from the related object back to
the content type for filtering, ordering and other query operations.

Thanks to Loic Bistuer for spotting a couple of important issues in
his review.
 2014-03-05 22:37:53 +02:00
Akis Kesoglou
c627da0ccc Fixed #14549 - Removed restriction of single FKs on intermediary tables 
Thanks to Loic Bistuer for review. Minor changes to error messages
done by committer.
 2014-03-05 22:33:58 +02:00
Chris Wilson
95c74b9d69 Fixed #22206 -- Passed models.TextField.max_length to forms.CharField.maxlength 2014-03-05 20:09:28 +01:00
Claude Paroz
ac699cdc17 Really hidden warnings in javascript_quote tests 
Refs #21725.
 2014-03-05 09:00:55 +01:00
Baptiste Mispelon
5a5815d373 Fixed incorrect docstring in cache tests (take two) 
3e25c8ac69 was an incomplete
merge of the pull request.

Thanks to @ramast for catching this.
 2014-03-05 07:35:07 +01:00
Athena
5d568bcfa6 Fixed #7571 -- Fixed parameter matching in include()'d urlpattern 
Fixed URL resolving in the case where an outer regex includes an inner
regex and both regexes use positional parameters instead of named
groups, causing the outer regex's parameters to override the inner
regex's.

Modified the regex url resolver so that it will concatenates and then
normalizes, instead of normalizing and then concatenating.
 2014-03-05 00:35:03 +01:00
Alex Gaynor
a248c88372 Fixed three small flake8 violations. 2014-03-04 15:13:15 -08:00
ramast
3e25c8ac69 Fixed incorrect docstring in cache tests 2014-03-04 21:50:21 +01:00
Andrew Godwin
8fcc0140d0 Merge pull request #2396 from loic/ticket21893 
Fixed #21893 -- ModelState didn't account for MTI parents inherited from abstract models.
 2014-03-04 12:33:51 -08:00
Loic Bistuer
6436f1fad9 Fixed #21893 -- ModelState didn't account for MTI parents inherited from abstract models. 2014-03-05 03:25:14 +07:00
Loic Bistuer
99291f5db0 Added tests for MTI in RunPython. 2014-03-05 03:17:52 +07:00
zedr
6fe22b30e0 Fixed #22085 -- Added a feature for setting non-expiring keys as the default. 
This feature allows the default `TIMEOUT` Cache argument to be set to `None`,
so that cache instances can set a non-expiring key as the default,
instead of using the default value of 5 minutes.

Previously, this was possible only by passing `None` as an argument to
the set() method of objects of type `BaseCache` (and subtypes).
 2014-03-04 21:16:35 +01:00
Chris Wilson
24f0113fb9 Fixed spelling in model_forms test class names 2014-03-04 21:06:30 +01:00
Thomas Sorrel
53c576452e Fixed #16727 -- Added protocol-relative URL support to contenttypes.views.shortcut. 2014-03-03 22:57:06 +01:00
Loic Bistuer
7bbb6958dc Allowed custom querysets when prefetching single valued relations 
The original patch for custom prefetches didn't allow usage of custom
queryset for single valued relations (along ForeignKey or OneToOneKey).
Allowing these enables calling performance oriented queryset methods like
select_related or defer/only.

Thanks @akaariai and @timgraham for the reviews. Refs #17001.
 2014-03-03 21:35:19 +02:00
Baptiste Mispelon
0dffaf9c25 Fixed broken tests on Python 3 after 3c5fc708f1. 2014-03-03 15:45:48 +01:00
Rodolfo Carvalho
0d91225892 Fixed many typos in comments and docstrings. 
Thanks Piotr Kasprzyk for help with the patch.
 2014-03-03 07:38:09 -05:00
Greg Chapple
6acaa52386 Fixed #22135 -- Added ModelAdmin.get_changeform_initial_data(). 
Allows custom behavior for setting initial form data in ModelAdmin.
By default, initial data is set via GET params. The new method allows
this behavior to be overridden.

Thanks egasimus for the suggestion.
 2014-03-03 07:28:24 -05:00
Russell Keith-Magee
6b63742ce5 Corrected expected test output to allow for cleanups in signal and compatibility checks. 2014-03-03 19:29:50 +08:00
Russell Keith-Magee
82ac389486 Edited model and field checks for grammar and consistency. 2014-03-03 18:18:39 +08:00
Russell Keith-Magee
bc4dc6e99c Edited model check messages for grammar and consistency. 2014-03-03 15:35:42 +08:00
Russell Keith-Magee
f7587b20da Edited MySQL-specific check messages for grammar and consistency. 2014-03-03 14:31:55 +08:00
Russell Keith-Magee
55ba92a9c9 Edited contrib.sites check messages for grammar and consistency. 2014-03-03 14:27:22 +08:00
Russell Keith-Magee
57e08aa232 Cleanup of contrib.contenttypes check messages. 2014-03-03 14:19:06 +08:00
Russell Keith-Magee
3c5fc708f1 Edited contrib.admin check messages for grammar and consistency. 2014-03-03 13:27:17 +08:00
Erik Romijn
6268792e19 Fixed #22130 -- fixed template_tests/defaultfilters order dependent test failure 2014-03-02 09:02:42 +01:00
Tim Graham
f732d55dfc Added newline for flake8. 2014-03-01 15:46:23 -05:00
Anubhav Joshi
bb2ca9fe6c Fixed #22172 -- Allowed index_together to be a single list (rather than list of lists).. 
Thanks EmilStenstrom for the suggestion.
 2014-03-01 15:44:42 -05:00
Erik Romijn
775975f15d Fixed #22130 -- Deprecated fix_ampersands, removed utils.clean_html() 2014-03-01 14:07:57 +01:00
Sergey Kolosov
8c98f39624 Fixed #15318 -- Added settings for language cookie max-age, path, domain 
Introduced a number of settings to configure max-age, path, and domain
for the language cookie: LANGUAGE_COOKIE_AGE, LANGUAGE_COOKIE_PATH and
LANGUAGE_COOKIE_DOMAIN.

Thanks sahid for the suggestion.
 2014-03-01 07:52:45 -05:00
Baptiste Mispelon
c679cb7f60 Fixed #22168 -- Fixed migrations failing on sqlite when column names are SQL keywords 
Thanks to trac user fallen_flint for the report and initial patch.
 2014-03-01 13:45:45 +01:00
Claude Paroz
75d0dcbf84 Added patch_formats utility for i18n formatting tests 2014-03-01 10:25:06 +01:00
Tim Graham
8137215973 Added release note and regression test for refs #21643. 
This will be backported to stable/1.6.x along with the original fix.
 2014-02-28 20:42:56 -05:00
Tim Graham
72b080c2c8 Removed Django 1.5 upgrade hints for {% url %} tag. 
Refs #19280 and Refs #19392.
 2014-02-28 07:18:45 -05:00
vvojvoda
c23b3717be Fixed #21962 -- Added escape_html flag to ErrorDict.as_json() 2014-02-28 07:05:55 -05:00
Claude Paroz
7b4743580a Replaced deprecated assertEquals 2014-02-28 09:54:53 +01:00
Claude Paroz
4622d23ccf Fixed #22056 -- Omitted non-package directories when collecting tests 
This allows us to ignore empty dirs or other unrelated dirs.
Thanks Sebastian Pawluś for the report and the initial patch.
 2014-02-26 17:46:24 +01:00
Bouke Haarsma
2bab9d6d9e Fixed #21389 -- Accept most valid language codes 
By removing the 'supported' keyword from the detection methods and only relying
on a cached settings.LANGUAGES, the speed of said methods has been improved;
around 4x raw performance. This allows us to stop checking Python's incomplete
list of locales, and rely on a less restrictive regular expression for
accepting certain locales.

HTTP Accept-Language is defined as being case-insensitive, based on this fact
extra performance improvements have been made; it wouldn't make sense to
check for case differences.
 2014-02-26 16:58:04 +01:00
Greg Chapple
b1d10205ce Added tests for django.contrib.admindocs 
Refs #22015
 2014-02-23 21:36:25 +01:00
Alex Gaynor
a8a5c31966 Two whitespace changes to appease flake8 2014-02-23 11:07:52 -06:00
Andrew Gorcester
202bf69c2f Fixed #22095 -- Enabled backward migrations for RunPython operations 
Added reversible property to RunPython so that migrations will not
refuse to reverse migrations including RunPython operations, so long as
reverse_code is set in the RunPython constructor. Included tests to
check the reversible property on RunPython and the similar RunSQL.
 2014-02-23 09:30:02 +01:00
Baptiste Mispelon
7e1376c2b0 Fixed #21741 -- Fixed render_to_string to stop pushing empty dictionaries to its Context 
Thanks to kezabelle for the report and original patch
and to numerodix for his improved patch.
 2014-02-22 23:33:48 +01:00
Erik Romijn
8cd32f0965 Fixed #22120 -- Documented persistent activation of languages and cleaned up language session key use 2014-02-22 18:29:06 +01:00
Erik Romijn
98f13762d7 Fixed #22123 -- EmailValidator now also accepts IPv6 literals in addresses 2014-02-22 17:45:33 +01:00
Baptiste Mispelon
173aa51997 Fixed #21435 -- Improved error message when urlconf is empty. 
The new error message now hints that the most likely issue
is a circular import.

Thanks to trac user elena for the report and to
bpeschier for the original patch.
 2014-02-22 15:36:49 +01:00
Baptiste Mispelon
926e18d7d1 Deprecated django.utils.text.javascript_quote. 
Refs #21725.
 2014-02-22 13:50:12 +01:00
Baptiste Mispelon
847171b0d0 Fixed test failures when running in a narrow Python build. 2014-02-22 13:50:12 +01:00
Baptiste Mispelon
cd027aaadf Added some tests for #21725. 2014-02-22 13:50:12 +01:00
Bas Peschier
578bdb532c Added tests and minified javascript missing in 83a3add4be. 
Refs #22038.
 2014-02-22 13:26:29 +01:00
Baptiste Mispelon
3841feee86 Fixed #22107 -- Fixed django.core.files.File object iteration. 
Due to a mixup between text and bytes, iteration over
a File instance was broken under Python 3.

Thanks to trac user pdewacht for the report and patch.
 2014-02-20 19:13:25 +01:00
Claude Paroz
cb844497d0 Fixed #22097 -- Fixed change detection for TypedChoiceField 
Thanks Igor Mitrenko for the report.
 2014-02-20 13:40:42 +01:00
Tim Graham
20f455b3d6 flake8 fixes (unused imports and variables). 2014-02-18 11:33:30 -05:00
Claude Paroz
621c5cf4a5 Fixed #21732 -- Made compilemessages complain about non-writable location 
Instead of crashing with a CommandError, now a non-writable location
of mo files will only make compilemessages complain and continue.
Thanks Ramiro Morales for the review.
 2014-02-18 13:38:06 +01:00
Claude Paroz
203f55b5d5 Replaced 'test' by 'sqlall' management command in reverse_lazy test 2014-02-18 13:21:25 +01:00
Baptiste Mispelon
2a9ee49f3c Removed BaseCommand.stdin introduced in 116d39842d. 
This option is not actually very useful in the general case
because it doesn't override sys.stdin.

It's still marginally useful for testing some features of
the createsuperuser command so it was moved there.
This commit also makes the detection of a TTY in createsuperuser
a bit more robust, after a suggestion of appolo13.
 2014-02-18 11:36:06 +01:00
Claude Paroz
45edb9d235 Fixed #22057 -- Ensured reverse_lazy can be used in settings 
And without causing a circular import. Thanks Akis Kesoglou for
the report.
 2014-02-18 10:23:30 +01:00
Ben Davis
df2652c448 Fixed #22073 - Ensure CreateTable operation handles backwards migration correctly when M2M fields are present 2014-02-17 16:51:40 -06:00
Artur Frysiak
faf6a911ad Fixed #22023 -- Raised an error for values() followed by defer() or only(). 
Previously, doing so resulted in invalid data or crash.

Thanks jtiai for the report and Karol Jochelson,
Jakub Nowak, Loic Bistuer, and Baptiste Mispelon for reviews.
 2014-02-17 14:46:13 -05:00
Baptiste Mispelon
81cd3a7460 Use assertEqual instead of assertEquals. 2014-02-17 04:58:31 +01:00
Baptiste Mispelon
116d39842d Added the possibility to pass a stdin object to a management command. 
This makes testing certain features easier.

Thanks to AeroNotix for the original patch.
 2014-02-17 04:58:31 +01:00
Andrew Godwin
3c547a423f Merge pull request #2270 from bmispelon/ticket-22030 
Fixed #22030 -- Don't assume that all fields have a swappable_setting at...
 2014-02-17 01:16:49 +00:00
MattBlack85
a8ba76c2d3 Fixed #19980: Signer broken for binary keys (with non-ASCII chars). 
With this pull request, request #878 should considered closed.

Thanks to nvie for the patch.
 2014-02-16 16:50:50 +01:00
Marek Wywiał
8274fa60f8 Made the new template.Context.flatten() method a public API. 
That method was introduced in 9db4271bd1.

Refs #21765.
 2014-02-16 15:18:45 +01:00
Zbigniew Siciarz
74d4d58b62 Fixed #21939 -- Deprecated loading ssi/url tags from future. 2014-02-16 13:25:21 +01:00
Baptiste Mispelon
9db4271bd1 Fixed bad comparison logic introduced in d97bf2e9c8. 
Refs #21765.

Thanks to kezabelle for the quick report and to onjin
for providing the patch.
 2014-02-15 22:58:03 +01:00
MattBlack85
1c1dffca75 Fixed #21725 -- Fixed JavaScript quoting encoding. 
Thanks to nedbatchelder for the report.
 2014-02-15 19:39:21 +01:00
Grzegorz Nosek
0b6f9f7c6f Improved fix for #18373 -- backward compatibility 
Commit 79558c78 cleaned up the (undocumented) interface of Resolver404
exception, which breaks compatibility with code messing with .args[0]
directly. Revert the cleanup part and simply leave the fix itself.
 2014-02-15 17:51:18 +01:00
Christopher Medrela
d0133504e5 Fixed #22047 -- detecting related_name clash with inheritance 
Thanks to mondone for fruitful colaboration.
 2014-02-15 17:24:05 +01:00
Aaron France
1150053b99 Fixed #21912 -- Improved error message if a view returns None. 
Thanks brycenesbitt for the report.
 2014-02-15 11:18:16 -05:00
Marek Wywiał
d97bf2e9c8 Fixed #21765 -- Added support for comparing Context instances 2014-02-15 17:14:28 +01:00
Grzegorz Nosek
79558c787e Fixed #18373 - improved handling of Resolver404s from views 
When django.core.urlresolvers.resolve was called from a view, failed
and the exception was propagated and rendered by technical_404_response,
the URL mentioned on the page was the current URL instead of the URL
passed to resolve().

Fixed by using the path attribute from the Resolver404 exception instead
of request.path_info. Also cleaned up the exceptions to use standard
named parameters instead of stuffing a dict in args[0]
 2014-02-15 15:56:04 +01:00
Albert Wang
8bbdcc76e4 Fixed #19299 -- Fixed Nullification of Foreign Keys To CharFields 
Thanks tunixman for the report and Baptiste Mispelon and
Shai Berger for reviews.
 2014-02-15 09:47:32 -05:00
Aaron France
23b781cc3d Fixed #22018 -- Fixed checks for ModelAdmin.fields not handling sub-lists. 
Flatten a level of sublists before checking for duplicate fields.

When given sublists such as:

```python

class FooAdmin(admin.ModelAdmin):
    fields = ('one', ('one', 'two'))
```

The previous code did not correctly detect the duplicated 'one' field.

Thanks to jwa for the report.
 2014-02-15 15:01:44 +01:00
Anton Baklanov
0bd92d68ad Fixed #22035 -- reordered migration operations 
Now AddField actions appear in operations list before AlterUniqueTogether
actions.

Thanks to SmileyChris for the report.
 2014-02-14 20:00:39 -05:00
Klemens Mantzos
f683cb90be Fixed #21924 -- Added the ability to specify a reverse order for admin_order_field. 
Thanks Klemens Mantzos for the report and initial patch.
 2014-02-14 19:53:44 -05:00
Lukasz Balcerzak
0242134d32 Fixed #17942 -- Added a JsonResponse class to more easily create JSON encoded responses. 
Thanks leahculver for the suggestion and Erik Romijn,
Simon Charette, and Marc Tamlyn for the reviews.
 2014-02-14 18:25:19 -05:00
Antoine Catton
e3d0790bd0 Fixed #21177 -- Made resolve_url support relative URLs. 
This fixes redirecting to relative URLs with django.shortcuts.redirect.
 2014-02-14 17:58:03 -05:00
Baptiste Mispelon
6873eeeefb Fixed #22030 -- Don't assume that all fields have a swappable_setting attribute. 2014-02-13 17:43:21 +01:00
Jeremy
f94f466cd3 Fixed #19496 -- Added truncatechars_html filter. 
Thanks esevece for the suggestion and  Nick Sandford and Martin Warne
for the inital work on the patch.
 2014-02-13 10:27:27 -05:00
Baptiste Mispelon
c3434fed5b Removed test for migration check forgotten in 7e941ba67c. 2014-02-13 09:31:39 +01:00
Andrew Godwin
bad9456b9c Fix my slightly hasty autodetector changes 2014-02-12 17:22:50 +00:00
Loic Bistuer
7e27885c6e Reworked the detection of local storages for the collectstatic command. 
Before 4befb30 the detection was broken because we used isinstance
against a LazyObject rather than against a Storage class. That commit
fixed it by looking directly at the object wrapped by LazyObject.
This could however be a problem to anyone who subclasses the
collectstatic management Command and directly supplies a Storage class.

Refs #21581.
 2014-02-12 11:00:01 -05:00
Eli Bendersky
73f51e4113 Fixed #22025 -- Listing app followed by app.Model in dumpdata command 
When invoked as follows:

  $ python manage.py dumpdata blogapp blogapp.Tag

Django would throw a TypeError. This commit fixes the problem and provides
a test.
 2014-02-12 15:34:26 +01:00
Christopher Adams
eefc88feef Fixed #2445 -- Allowed limit_choices_to attribute to be a callable. 
ForeignKey or ManyToManyField attribute ``limit_choices_to`` can now
be a callable that returns either a ``Q`` object or a dict.

Thanks michael at actrix.gen.nz for the original suggestion.
 2014-02-11 14:05:12 -05:00
Christopher Medrela
ee9fcb1672 Fixed #17673 -- Forbid field shadowing. 
Thanks Anssi Kääriäinen for the suggestion.
 2014-02-10 10:04:19 -05:00
julien 'pouete' Godin
f5123c7291 Fixed #21371 -- Added the block.super to admin bodyclass blocks. 
Thanks Keryn Knight for the report.
 2014-02-10 09:13:29 -05:00
Si Feng
b102c27ff4 Fixed #20784 -- Added inverse_match parameter to RegexValidator. 2014-02-10 05:38:43 -05:00
Chris Bailey
0d98422b13 Refactored RecursiveM2MTests into smaller pieces, refs #18586. 2014-02-10 05:22:30 -05:00
Robert Stapenhurst
12385a5f86 Fixed #21763 -- Added an error msg for missing methods on ManyRelatedManager. 
Attempting to add() and remove() an object related by a 'through' model
now raises more descriptive AttributeErrors, in line with set and
create().
 2014-02-09 16:01:17 -05:00
Tim Graham
29345390b8 Minor edits to new findstatic functionality; refs #19879. 
Hopefully fixes a test failure on Jenkins.
 2014-02-09 15:39:04 -05:00
Ryan Kaskel
d25622000a Fixed #21382 - Added "has_original" to stacked inlines. 
Report and original patch from jrief.
 2014-02-09 12:20:09 -05:00
Jannis Leidel
f90be002d9 Fixed #20780 -- Get rid of stale symlinks when using collectstatic. 
Thanks to John Giannelos for the initial patch.
 2014-02-09 14:48:11 +00:00
Vajrasky Kok
6a9ed7d403 Fixed #19879 -- Have 'findstatic' says on which directories it searched the relative paths. 
Added searched_locations in finders module. Added verbosity flag level 2 on 'findstatic'
command that will output the directories on which it searched the relative paths.

Reported by ccurvey. Initial patch by Jonas Svensson and Vajrasky Kok.
 2014-02-09 14:22:22 +00:00
Jannis Leidel
5cc0555603 Fixed #21482 -- Uplifted restriction of collectstatic using symlink option in Windows NT 6. 
Original patch by Vajrasky Kok. Reviewed by Florian Apolloner, Aymeric Augustin.
 2014-02-09 12:39:20 +00:00
Andrew Godwin
d5df7a0515 Fixed #21969: Fix behaviour of initial_data with migrated apps 2014-02-09 12:22:59 +00:00
Ryan Kaskel
75a96f06e9 Fixed #21967: Added check for object in ModelFormMixin.get_form_kwargs. 
Thanks lagovas.lagovas at gmail.com for the report.
 2014-02-09 06:30:03 -05:00
Marc Tamlyn
80cd64ee17 Fixed #21247 -- Made method_decorator play nicely with descriptors 
When a method decorator was used in conjunction with a decorator
implemented as a descriptor, method_decorator did not correctly respect
the method binding.

Thanks for Graham Dumpleton for the report and initial patch.
 2014-02-09 11:23:09 +00:00
Andrew Godwin
97a8fd4682 Fixed #21954: Raise nice error when serializing datetimes with timezones 2014-02-09 11:17:38 +00:00
Tim Graham
4f8e8a6ec2 Removed unused imports + other flake8 fixes. 2014-02-09 06:13:10 -05:00
Andrew Godwin
98dd8dd02e Fixed #21892: RunPython no longer accepts strings 2014-02-09 10:54:02 +00:00
Andrew Godwin
38b4adc696 Merge pull request #2244 from mlavin/21856-migration-checks 
Fixed #21856: Allow Empty DATABASES Setting
 2014-02-09 10:46:57 +00:00
Marc Tamlyn
46a87214ca Merge pull request #1997 from dpwrussell/method_decorator_args_fix 
Used available_attrs in method_decorator
 2014-02-09 10:12:22 +00:00
Aymeric Augustin
07ae47f7f8 Fixed #21959 -- Handled Inf/NaN in widthratio tag. 
Thanks rmoe for the report and the patch.
 2014-02-08 21:01:55 +01:00
Berker Peksag
5d263dee30 Fixed #21674 -- Deprecated the import_by_path() function in favor of import_string(). 
Thanks Aymeric Augustin for the suggestion and review.
 2014-02-08 11:12:19 -05:00
mlavin
a3e0d7753d Adding tests for check_migrations. 2014-02-08 09:05:27 -05:00
Tim Graham
6c5a30b4e7 Added tests for LocalMemCache deadlocks. refs #20613 and refs #18541. 
Thanks Zach Smith for the patch.
 2014-02-08 05:49:27 -05:00
Claude Paroz
02add43568 Fixed #21417 -- Expanded TEMPLATE_STRING_IF_INVALID in blocktrans 
Thanks keturn for the reporti, Chris Medrela for details and
Tim Graham for the review.
Refs #19915.
 2014-02-08 11:06:54 +01:00
Loic Bistuer
8847a0c601 Fixed #16192 -- Made unique error messages in ModelForm customizable. 
Overriding the error messages now works for both unique fields, unique_together
and unique_for_date.

This patch changed the overriding logic to allow customizing NON_FIELD_ERRORS
since previously only fields' errors were customizable.

Refs #20199.

Thanks leahculver for the suggestion.
 2014-02-08 04:59:09 -05:00
Chris Wilson
65131911db Fixed #21518 -- Made override_settings(ROOT_URLCONF) clear the resolver cache. 
Thanks Aymeric Augustin and Simon Charette for reviews.
 2014-02-07 15:29:25 -05:00
Vajrasky Kok
d3cf6cfacf Fixed #17713 -- Renamed BaseDatabaseFeatures.allows_primary_key_0 to allows_auto_pk_0. 
MySQL does allow primary key with value 0. It only forbids autoincrement
primary key with value 0.

Thanks Claude Paroz for the report.
 2014-02-06 05:16:40 -05:00
Vajrasky Kok
c43c469a2e Fixed #21731 -- Made javascript_quote escapes '</'. 2014-02-06 04:02:09 -05:00
Alex Gaynor
55d19d370f Removed import which is now unused 2014-02-05 13:26:56 -08:00
Baptiste Mispelon
a878bf9b09 Revert "Fixed #20296 -- Allowed SafeData and EscapeData to be lazy" 
This reverts commit 2ee447fb5f.

That commit introduced a regression (#21882) and didn't really
do what it was supposed to: while it did delay the evaluation
of lazy objects passed to mark_safe(), they weren't actually
marked as such so they could end up being escaped twice.

Refs #21882.
 2014-02-05 21:22:40 +01:00
Anssi Kääriäinen
c29d6f7676 Fixed #21952 -- signals deadlock due to locking + weakref interaction 2014-02-05 20:57:40 +01:00
Carl Meyer
2b27224180 Fixed #21929 - Fixed test regression on Windows. 
Thanks Michael Manfre for the report.
 2014-02-04 13:14:41 -07:00
Claude Paroz
343dfff133 Removed the this_is_the_login_form hack 
Refs #21911. Now that we have a more traditional login form, we
don't need any more a special field telling us we are dealing with
the login form.
 2014-02-04 20:02:28 +01:00
Claude Paroz
be0ad62994 Fixed #21911 -- Made admin views redirect to login when needed 
Historically, the Django admin used to pass through the request
from an unauthorized access to the login view directly. Now we
are using a proper redirection, which is also preventing
inadvertantly changing data when POSTing login data to an admin
view when user is already authorized.
Thanks Marc Tamlyn and Tim Graham for the reviews.
 2014-02-04 20:02:28 +01:00
Claude Paroz
5848bea9dc Made staff_member_required redirect to login 
Refs #21911.
 2014-02-04 20:02:28 +01:00
Anssi Kääriäinen
35cecb1ebd Fixed #21748 -- join promotion for negated AND conditions 
Made sure Django treats case .filter(NOT (a AND b)) the same way as
.filter((NOT a OR NOT b)) for join promotion.
 2014-02-04 18:48:06 +02:00
Aymeric Augustin
ab922c5cd8 Fixed typo in 3ffeb931. 2014-02-02 23:40:16 +01:00
Michael Manfre
e1d839237f Make mysql's CursorWrapper a contextmanager. 2014-02-02 22:43:53 +01:00
Michael Manfre
ad913f242d Fix regress added to migrations.test_operations.test_alter_field_pk_fk 2014-02-02 15:44:01 -05:00
Michael Manfre
3ffeb93186 Ensure cursors are closed when no longer needed. 
This commit touchs various parts of the code base and test framework. Any
found usage of opening a cursor for the sake of initializing a connection
has been replaced with 'ensure_connection()'.
 2014-02-02 12:47:21 -05:00
Michael Manfre
0837eacc4e Made SQLCompiler.execute_sql(result_type) more explicit. 
Updated SQLUpdateCompiler.execute_sql to match the behavior described in
the docstring; the 'first non-empty query' will now include all queries,
not just the main and first related update.

Added CURSOR and NO_RESULTS result_type constants to make the usages more
self documenting and allow execute_sql to explicitly close the cursor when
it is no longer needed.
 2014-02-02 12:47:06 -05:00
Aymeric Augustin
4a488c1483 Silenced a spurious warning. 
Thanks Timo for the report. Regression from 2f65b8e1. Refs #21794.
 2014-02-01 19:42:41 +01:00
Tim Graham
a938fff030 Updated some tests to use the check framework and silenced a PendingDeprecationWarning. 2014-01-31 12:52:22 -05:00
Shai Berger
e9d12bae1e Made Oracle introspect FloatFields correctly 
Broke InspectDBTestCase.test_field_types in two:
- a test_number_field_types, which now passes on Oracle too
- a test_field_types, for all non-numeric fields, which is still expected to fail

Also made some pep8 fixes in the tests file. Refs #19884

Thanks Tim Graham for review.
 2014-01-30 00:41:11 +02:00
Anssi Kääriäinen
8b2c1ac06d Added tests for m2m queries with custom pk on the end models 
It seems this case was fixed somewhere between 1.5.x and 1.6.x. I added
tests as I wasn't able to find any tests for these cases. Refs #21879
 2014-01-28 21:39:15 +02:00
Tim Graham
2b6914049a Fixed #21849 -- Included the count of silenced system checks in output. 2014-01-28 08:31:02 -05:00
Loic Bistuer
3e4dc5ecf2 Fixed #21853 -- Fixed Manager.__module__ to properly return 'django.db.models.manager'. 
The combination of BaseManager.from_queryset() and RenameMethodsBase results in
Manager.__module__ having the wrong value. This can be an issue when trying to
pickle the Manager class.
 2014-01-28 08:17:01 -05:00
Carl Meyer
88a2d39159 Fixed #21874 -- Require Django applications to have a filesystem path. 
Wherever possible this filesystem path is derived automatically from the app
module's ``__path__`` and ``__file__`` attributes (this avoids any
backwards-compatibility problems).

AppConfig allows specifying an app's filesystem location explicitly, which
overrides all autodetection based on ``__path__`` and ``__file__``. This
permits Django to support any type of module as an app (namespace packages,
fake modules, modules loaded by other hypothetical non-filesystem module
loaders), as long as the app is configured with an explicit filesystem path.

Thanks Aymeric for review and discussion.
 2014-01-27 15:34:22 -07:00
Aymeric Augustin
b87bc461c8 Removed TransRealMixin. 
Fixed #21688. Refs https://github.com/django/django/pull/1147.
 2014-01-27 22:02:07 +01:00
Aymeric Augustin
b951a7fbc1 Removed superfluous uses of TransRealMixin. 
The translation.override context manager cleans up after itself. As a
consequence this mixin isn't needed any more in many cases.
 2014-01-27 22:01:22 +01:00
Simon Charette
10e3faf191 Fixed #19774 -- Deprecated the contenttypes.generic module. 
It contained models, forms and admin objects causing undesirable
import side effects. Refs #16368.

Thanks to Ramiro, Carl and Loïc for the review.
 2014-01-26 14:42:30 -05:00
Simon Charette
c3881944e8 Fixed some missing/extraneous new line warnings. 2014-01-26 14:32:01 -05:00
Aymeric Augustin
3c47786cb9 Fixed #21702 -- get_model('app_label.ModelName'). 
Also added tests for get_model.
 2014-01-26 13:01:09 +01:00
Carl Meyer
ca95f8e435 Moved sys.path-extending decorator to django.test.utils and used throughout test suite. 
Thanks Aymeric for the suggestion.
 2014-01-25 22:50:40 -07:00
Carl Meyer
966b186981 Fixed #17304 -- Allow single-path and configured-path namespace packages as apps. 
Also document the conditions under which a namespace package may or may not be
a Django app, and raise a clearer error message in those cases where it may not
be.

Thanks Aymeric for review and consultation.
 2014-01-25 19:37:05 -07:00
Simon Charette
3acdb3068a Fixed a failing schema assertion. 
BooleanFields are stored as TINYINT(1) on MySQL.
 2014-01-25 10:59:38 -05:00
Jannis Leidel
b9e0ea3cb4 Merge pull request #2211 from carljm/t21867 
Fixed #21867 -- Removed AppStaticStorage; app paths are now AppConfig's job.
 2014-01-25 03:57:29 -08:00
Aymeric Augustin
2ff93e027c Fixed #21829 -- Added default AppConfigs. 
Thanks Russell for the report, Marc for the initial patch, Carl for the
final review, and everyone who contributed to the design discussion.
 2014-01-25 10:41:56 +01:00
Carl Meyer
29ddae7436 Fixed #21871 -- Fixed Apps.is_installed() for apps with custom label. 
Thanks Aymeric for design discussion.
 2014-01-24 20:07:14 -07:00
Andrew Godwin
2a30b39f40 Fixed #21783: More SQLite default fun with nulls. 2014-01-25 00:10:25 +00:00
Carl Meyer
f56c88a8ee Fixed #21867 -- Removed AppStaticStorage; app paths are now AppConfig's job. 
AppStaticStorage only provided one thing over FileSystemStorage, which was
taking an app name (import path) and translating it into a filesystem
path. This is now something that should be done via app_config.path instead,
leaving AppStaticStorage with no reason for existence. It should be safe to
remove, as it was undocumented internal API.

There was some kind of feature in the AppDirectoriesFinder code related to a
"prefix" attribute on the storage class used by AppDirectoriesFinder. Since
this feature was undocumented, untested, and of unclear purpose, I removed it
as well.
 2014-01-24 15:32:03 -07:00
Arne Brodowski
06bd181f97 Fixed typo in error message. 2014-01-24 17:40:43 +01:00
Arne Brodowski
38be3cf5e4 Fixed #21870 -- Admin check for list_editable_item 
During the admin check for list_editable _check_list_editable_item
should return an empty list if all checks pass. Additionally the
Testcase test_readonly_and_editable was changed to test what the
name implies instead of duplicating the logic of test_readonly.
 2014-01-24 17:40:24 +01:00
Anssi Kääriäinen
78a2617703 Fixed #21787 -- regression in MTI .exclude() queries 2014-01-24 10:10:17 +02:00
Alex Gaynor
2ba09c000d Added some missing whitespace around arithmetic operators 2014-01-22 09:21:05 -06:00
Loic Bistuer
c3fdeb28ff Fixed #21846 -- Made NestedObjects handle related_name with %(app_label)s or %(class)s. 2014-01-22 09:13:15 -05:00
Markus Holtermann
047394f79c Fixed #21852 -- Make migration writer serialize iterators 2014-01-22 09:21:54 +01:00
Alex Gaynor
8482ab6633 Removed some stray newlines which caused flake8 issues 2014-01-20 22:58:05 -06:00
Carl Meyer
fb862c875e Fix a check_framework test so it doesn't fail when TEST_RUNNER is set (e.g. on CI). 2014-01-20 21:08:02 -07:00
Carl Meyer
6070a5d6a6 Fixes #21833 -- Fix UserSettingsHolder.is_overridden() and add tests. 2014-01-20 20:25:33 -07:00
Jannis Leidel
8efd20f96d Added ManifestStaticFilesStorage to staticfiles contrib app. 
It uses a static manifest file that is created when running
collectstatic in the JSON format.
 2014-01-20 19:32:07 +01:00
Alex Gaynor
ee25ea0daf Removed a stray new line which upset flake8 2014-01-20 09:57:35 -06:00
Russell Keith-Magee
53aa6c6ac1 Added warning silencers to some noisy tests. 
These warnings all emerged as the result of the introduction of the checks framework.

Thanks to Anssi Kääriäinen for the report.
 2014-01-20 20:30:29 +08:00
Shai Berger
056be4358d Fixed two test failures under Oracle 2014-01-20 13:01:14 +02:00
Anssi Kääriäinen
980eda0190 Fixed custom_lookups tests for Oracle 
Refs #21821
 2014-01-20 10:52:58 +02:00
Russell Keith-Magee
a029efca44 Removed an inactive system check for upload_to. 
Thanks to Simon Charette for the eagle eyes.
 2014-01-20 12:31:35 +08:00
Alex Gaynor
be8173af51 Fixed a small collection of flake8 violations that had snuck in 2014-01-19 21:15:31 -06:00
Russell Keith-Magee
d818e0c9b2 Fixed #16905 -- Added extensible checks (nee validation) framework 
This is the result of Christopher Medrela's 2013 Summer of Code project.

Thanks also to Preston Holmes, Tim Graham, Anssi Kääriäinen, Florian
Apolloner, and Alex Gaynor for review notes along the way.

Also: Fixes #8579, fixes #3055, fixes #19844.
 2014-01-20 10:45:21 +08:00
Andrew Godwin
51832c8aec Remove other unicode literal 2014-01-19 18:57:59 +00:00
Andrew Godwin
b1fc8c19b2 Remove unicode prefix that snuck in 2014-01-19 18:57:06 +00:00
Andrew Godwin
a68f325791 Fixed #21638: Validators are now comparable, stops infinite user mig'ns 2014-01-19 18:56:16 +00:00
Andrew Godwin
3f1a008266 Fixed #21664: Multi-table inheritance was duplicating _ptr fields 2014-01-19 18:35:49 +00:00
Andrew Godwin
af4a8478e4 Fixed #21783: (again) Found second source of bug, also squashed it. 2014-01-19 17:43:31 +00:00
Andrew Godwin
e8d4aed3b9 Merge pull request #1681 from loic/migrations.format 
Fixed #21323 -- Improved readability of serialized Operation.
 2014-01-19 09:30:27 -08:00
Loic Bistuer
374faa4721 Fixed #21323 -- Improved readability of serialized Operation. 2014-01-20 00:16:07 +07:00
Andrew Godwin
e802c97581 Fixed #21783: Use defaults for adding NOT NULL on sqlite 2014-01-19 17:10:24 +00:00
Andrew Godwin
c9de1b4a55 Implement swappable model support for migrations 2014-01-19 16:43:12 +00:00
Alex Gaynor
9d487ae2a1 Refs #21628 -- removed one usage of the imp module in the tests. It is deprecated in Python 3.4 2014-01-19 00:58:22 -06:00
Aymeric Augustin
74d8fdcfa6 Stopped assuming that INSTALLED_APPS only contains app names. 
While this assumption is true for the time being, it makes the code
needlessly brittle.
 2014-01-18 23:06:00 +01:00
Anssi Kääriäinen
20bab2cf9d Fixed #16187 -- refactored ORM lookup system 
Allowed users to specify which lookups or transforms ("nested lookus")
are available for fields. The implementation is now class based.

Squashed commit of the following:

commit fa7a7195f1952a9c8dea7f6e89ee13f81757eda7
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 18 10:53:24 2014 +0200

    Added lookup registration API docs

commit eb1c8ce164325e0d8641f14202e12486c70efdb6
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Tue Jan 14 18:59:36 2014 +0200

    Release notes and other minor docs changes

commit 11501c29c9352d17f22f3a0f59d3b805913dedcc
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Jan 12 20:53:03 2014 +0200

    Forgot to add custom_lookups tests in prev commit

commit 83173b960ea7eb2b24d573f326be59948df33536
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Jan 12 19:59:12 2014 +0200

    Renamed Extract -> Transform

commit 3b18d9f3a1bcdd93280f79654eba0efa209377bd
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Jan 12 19:51:53 2014 +0200

    Removed suggestion of temporary lookup registration from docs

commit 21d0c7631c161fc0c67911480be5d3f13f1afa68
Merge: 2509006 f2dc442
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Jan 12 09:38:23 2014 -0800

    Merge pull request #2 from mjtamlyn/lookups_3

    Reworked custom lookups docs.

commit f2dc4429a1da04c858364972eea57a35a868dab4
Author: Marc Tamlyn <marc.tamlyn@gmail.com>
Date:   Sun Jan 12 13:15:05 2014 +0000

    Reworked custom lookups docs.

    Mostly just formatting and rewording, but also replaced the example
    using ``YearExtract`` to  use an example which is unlikely to ever be
    possible directly in the ORM.

commit 250900650628d1f11beadb22814abd666029fb81
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Jan 12 13:19:13 2014 +0200

    Removed unused import

commit 4fba5dfaa022653ffa72497258ffd8f8b7476f92
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 22:34:41 2014 +0200

    Added docs to index

commit 6d53963f375c77a1f287833b19b976d23f36c30b
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 22:10:24 2014 +0200

    Dead code removal

commit f9cc0390078e21f1ea5a7bc1f15b09f8f6b0904d
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 19:00:43 2014 +0200

    A new try for docs

commit 33aa18a6e3c831930bda0028222a26f9c1d96e66
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 14:57:12 2014 +0200

    Renamed get_cols to get_group_by_cols

commit c7d5f8661b7d364962bed2e6f81161c1b4f1bcc3
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 14:45:53 2014 +0200

    Altered query string customization for backends vendors

    The new way is trying to call first method 'as_' + connection.vendor.
    If that doesn't exist, then call as_sql().

    Also altered how lookup registration is done. There is now
    RegisterLookupMixin class that is used by Field, Extract and
    sql.Aggregate. This allows one to register lookups for extracts and
    aggregates in the same way lookup registration is done for fields.

commit 90e7004ec14e15503f828cc9bde2a7dab593814d
Merge: 66649ff f7c2c0a
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 13:21:01 2014 +0200

    Merge branch 'master' into lookups_3

commit 66649ff891c7c73c7eecf6038c9a6802611b5d8a
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Jan 11 13:16:01 2014 +0200

    Some rewording in docs

commit 31b8faa62714b4b6b6057a9f5cc106c4dd73caab
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 29 15:52:29 2013 +0200

    Cleanup based on review comments

commit 1016159f34674c0df871ed891cde72be8340bb5d
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 28 18:37:04 2013 +0200

    Proof-of-concept fix for #16731

    Implemented only for SQLite and PostgreSQL, and only for startswith
    and istartswith lookups.

commit 193cd097ca8f2cc6a911e57b8e3fb726f96ee6a6
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 28 17:57:58 2013 +0200

    Fixed #11722 -- iexact=F() produced invalid SQL

commit 08ed3c3b49e100ed9019831e770c25c8f61b70f9
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 21 23:59:52 2013 +0200

    Made Lookup and Extract available from django.db.models

commit b99c8d83c972786c6fcd0e84c9e5cb08c1368300
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 21 23:06:29 2013 +0200

    Fixed review notes by Loic

commit 049eebc0703c151127f4f0265beceea7b8b39e72
Merge: ed8fab7 b80a835
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 21 22:53:10 2013 +0200

    Merge branch 'master' into lookups_3

    Conflicts:
    	django/db/models/fields/__init__.py
    	django/db/models/sql/compiler.py
    	django/db/models/sql/query.py
    	tests/null_queries/tests.py

commit ed8fab7fe8867ff3eb801c3697a426478387bb2f
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Dec 21 22:47:23 2013 +0200

    Made Extracts aware of full lookup path

commit 27a57b7aed91b2f346abc4a77da838bffa17c727
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 1 21:10:11 2013 +0200

    Removed debugger import

commit 074e0f5aca0572e368c11e6d2c73c9026e7d63d7
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 1 21:02:16 2013 +0200

    GIS lookup support added

commit 760e28e72bae475b442b026650969b0d182dbe53
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 1 20:04:31 2013 +0200

    Removed usage of Constraint, used Lookup instead

commit eac47766844b90e7d3269e7a8c012eee34ec0093
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 1 02:22:30 2013 +0200

    Minor cleanup of Lookup API

commit 2adf50428d59a783078b0da3d5d035106640c899
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sun Dec 1 02:14:19 2013 +0200

    Added documentation, polished implementation

commit 32c04357a87e3727a34f8c5e6ec0114d1fbbb303
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Nov 30 23:10:15 2013 +0200

    Avoid OrderedDict creation on lookup aggregate check

commit 7c8b3a32cc17b4dbca160921d48125f1631e0df4
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Sat Nov 30 23:04:34 2013 +0200

    Implemented nested lookups

    But there is no support of using lookups outside filtering yet.

commit 4d219d4cdef21d9c14e5d6b9299d583d1975fcba
Author: Anssi Kääriäinen <akaariai@gmail.com>
Date:   Wed Nov 27 22:07:30 2013 +0200

    Initial implementation of custom lookups
 2014-01-18 11:46:19 +02:00
JustinTArthur
298a2b577f Adjusted inspectdb management command to yield PEP 8-compliant output barring Django Coding Style exceptions. 2014-01-17 18:03:16 -05:00
Andrew Godwin
86e69bf3b6 Fixed #21785: Bad handling of both auto_now and _add on deconstruct 2014-01-17 10:46:03 +00:00
Marc Tamlyn
2607fa9016 Fixed #21774 -- Isolate all test urls from eachother. 
This (nearly) completes the work to isolate all the test modules from
each other. This is now more important as importing models from another
module will case PendingDeprecationWarnings if those modules are not in
INSTALLED_APPS. The only remaining obvious dependencies are:

- d.c.auth depends on d.c.admin (because of the is_admin flag to some
  views), but this is not so important and d.c.admin is in
  always_installed_apps
- test_client_regress depends on test_client. Eventually these should
  become a single module, as the split serves no useful purpose.
 2014-01-14 15:43:27 +00:00
Marc Tamlyn
22198e6ce5 Be more careful about closing connections in mail tests. 2014-01-12 23:39:44 +00:00
Marc Tamlyn
9d2c5b0420 Undelete the return True removed in 4e0a2fe. 
This is quite important otherwise we don't close our connections to the
SMTP server.
 2014-01-12 23:38:28 +00:00
Aymeric Augustin
d562527a16 Fixed #21477 -- Renamed db to using in pre/post_migrate signals. 2014-01-12 22:24:33 +01:00
Aymeric Augustin
225a6ed2cf Fixed a test that was failing with PostGIS. 
Fixed #21452 again.

Forward-port of 18d75e07 from stable/1.6.x.
 2014-01-12 21:40:22 +01:00
Aymeric Augustin
720c6d3a44 Restored a test broken by overzealous PEP8 cleanup 2014-01-12 21:13:32 +01:00
Simon Charette
c726598c3d Fixed flake8 issues. 2014-01-12 13:40:37 -05:00
Florian Apolloner
56ab5f52c7 Merge pull request #2163 from apollo13/signals 
Signals
 2014-01-12 09:43:41 -08:00
Aymeric Augustin
1afe748832 Fixed #21452 -- Non-autocommit connections to PostgreSQL. 
When settings.DATABASES['default']['AUTOCOMMIT'] = False, the connection
wasn't in autocommit mode but Django pretended it was.

Thanks Anssi for analysing this issue.

Refs #17062.
 2014-01-12 18:28:51 +01:00
Aymeric Augustin
1c24096f1e Fixed a test isolation issue. Refs #17062. 
This test could change settings.DATABASES['default']['TIME_ZONE'] and
didn't restore the previous value.
 2014-01-12 18:28:51 +01:00
Anssi Kääriäinen
9918c11114 Fixed #21413 -- resolve_columns fields misalignment 2014-01-12 18:07:39 +02:00
Aymeric Augustin
9cc3371a0f Fixed #21756 -- Skipped two timezone-related tests on Windows. 
Windows cannot use a time zone other than the default time zone.

Thanks manfre for the report.
 2014-01-12 09:41:57 +01:00
Claude Paroz
0179852d7f Fixed #8898 -- Obsoleted SplitDateTimeWidget usage with DateTimeField 
Thanks Tim Graham for the review.
 2014-01-11 15:50:34 +01:00
Claude Paroz
18374c1d8c Fixed #21752 -- Prevented custom widget step attribute to be overwritten 
Thanks orcein at gmail.com for the report.
 2014-01-11 14:08:04 +01:00
Aymeric Augustin
3326a412cc Deprecated importing a model before loading its application. 
Refs #21719, #21680.
 2014-01-10 23:43:10 +01:00
dpwrussell
14940fdd96 Fixed #21513 -- Added method_decorator support for argumented decorator 
Copied attributes into the decorated method and special case __name__
copy as this will not be present on a Class object. Added regression
test to decorator suite.
 2014-01-10 10:45:26 +00:00
Unai Zalakain
9eb16031ca Fixed #12571 -- Attached originating WSGIRequest to test client responses. 
Originating WSGIRequests are now attached to the ``wsgi_request`` attribute of
the ``HttpResponse`` returned by the testing client.

Thanks rvdrijst for the suggestion.
 2014-01-09 18:50:03 -05:00
Florian Apolloner
52cad43bc3 Fixed removal of signal receivers in Python 3.4 
Make use of `weakref.finalize` and `weakref.WeakMethod` on python 3.4.
Simplified the removal of receivers, the old function looked overly
complicated.

Many thanks go to Antoine Pitrou for helping me to debug and explain all
the failures I ran into while writing that patch.
 2014-01-09 09:27:54 +01:00
Andrew Godwin
9ae17d994b Make test stronger to hopefully fix odd Jenkins failure 2014-01-08 21:20:29 +00:00
Anssi Kääriäinen
fa250c2cf9 Merge pull request #2151 from manfre/ticket-21746 
Fixed #21746 - Fixed test_get_reverse_on_unsaved_object test.
 2014-01-08 08:08:02 -08:00
Michael Manfre
1dbbdb29a0 Fixed #21746 - Fixed test_get_reverse_on_unsaved_object test. 
Test will no longer attempt to insert multiple NULL rows in to a unique
field if the database doesn't support it.
 2014-01-08 10:52:13 -05:00
Michael Manfre
8845ab62f5 Fixed #21745 - Feature check UniqueTest.test_unique_null 2014-01-08 09:53:40 -05:00
Andrew Godwin
64887c644a Fixed #21142: Dependency failures on unmigrated apps. 2014-01-08 13:00:12 +00:00
Aymeric Augustin
6a320cc14a Fixed #21718 -- Renamed has_app to is_installed. 2014-01-06 22:48:41 +01:00
Aymeric Augustin
f5f7617167 Renamed a couple models to prevent duplicate names. 2014-01-05 20:52:46 +01:00
Aymeric Augustin
5d9da7597e Fixed app registry cleanup in app-loading tests. 2014-01-05 20:52:46 +01:00
Aymeric Augustin
d4b059d3eb Fixed test for models in non-installed apps. 
Models are now attached to any application they're defined in. Since
not_installed was inside app_loading, these models were mistakenly
attached to app_loading. The test that used them passed accidentally
when run after EggLoadingTest because that class' tearDown() method
replaces apps.all_models['app_loading'] by a copy of itself, while
it should remain the same as apps.app_configs['app_loading'].models.
 2014-01-05 20:52:46 +01:00
Aymeric Augustin
a7588e2e22 Removed useless model definitions. 
Surprisingly, this commit doesn't change any behavior at all. When a
model is defined with the same name as another model in the same app,
the definition of the first class is bound to the name of the class
regardless of the definition of the second class.
 2014-01-05 20:52:46 +01:00
Claude Paroz
196f0a356d Suppressed ResourceWarning in files tests 2014-01-03 13:37:14 +01:00
Florian Apolloner
3bc6b18cb9 Fixed selenium failure. 
This fixes (at least according to tests on the ci itself)
admin_widgets.tests.RelatedFieldWidgetSeleniumFirefoxTests.test_foreign_key_using_to_field

(http://ci.djangoproject.com/job/Django/database=mysql_gis,python=python2.7/3792/testReport/junit/admin_widgets.tests/RelatedFieldWidgetSeleniumFirefoxTests/test_foreign_key_using_to_field/)

The cause for this issue seems to be that wait_page_loaded was executed before click fired
and as such no profile got saved (again just an educated guess, but with this fix I can no
longer reproduce it -- fingers crossed).
 2014-01-03 11:29:37 +01:00
Florian Apolloner
7d0a519032 Revert "Fixed #21227 -- Added workaround for selenium test failures" 
This reverts commit 08c9ab5a0f.
 2014-01-03 00:44:49 +01:00
Florian Apolloner
ed2828f0a0 Fixed a few flaky selenium tests. 
Many thanks go to David Burns (@AutomatedTester) for helping me understand
css selectors and pointing me towards the correct selenium methods.
 2014-01-03 00:36:50 +01:00
Claude Paroz
b2d78939d1 Prevented calling setup() inside catch_warnings 
When django.setup() (and then configure_logging) is called inside
catch_warnings, logging setup is negatively affected (notably
warnings.showwarning definition).
 2014-01-01 22:59:12 +01:00
Aymeric Augustin
0ce945a671 Fixed #21018 -- Reversed precedence order for management commands. 2014-01-01 18:11:15 +01:00
Preston Timmons
2139e09d83 Removed unused function in test_runner tests 
This was used for python 2.6 and unittest2 compatibility. It was
forgotten when the code that used it was removed.
 2014-01-01 12:41:43 +01:00
Preston Timmons
18d962f2e6 Fixed #21206 -- Fixed test discovery without labels 
Added test to verify an empty label performs discovery on the current
working directory.
 2014-01-01 12:40:16 +01:00
Loic Bistuer
4befb3015c Fixed #21581 -- Fixed a number of issues with collectstatic. 
When STATIC_ROOT wasn't set, collectstatic --clear would delete
every files within the current directory and its descendants.

This patch makes the following changes:

Prevent collectstatic from running if STATIC_ROOT isn't set.

Fixed an issue that prevented collectstatic from displaying the
destination directory.

Changed the warning header to notify when the command is run
in dry-run mode.
 2013-12-31 14:58:49 -05:00
Claude Paroz
b8e3373f45 Fixed #21714 -- Moved logging configuration to global setup() 
Thanks Aymeric Augustin for the report and the review.
 2013-12-31 18:35:00 +01:00
Aymeric Augustin
63137a8304 Enforced unicity of app labels. 
Fixed #21679.
 2013-12-31 18:04:54 +01:00
Aymeric Augustin
c40209dcc0 Made it possible to change an application's label in its configuration. 
Fixed #21683.
 2013-12-31 17:30:58 +01:00
Aymeric Augustin
553500133c Removed an obsolete unicity check. 
It doesn't account for app configs.

Refs #21679.
 2013-12-31 17:29:04 +01:00
Claude Paroz
587b678d41 Made DeprecationDisplayTest more robust 2013-12-31 13:12:53 +01:00
Claude Paroz
1fb873cd6b Finished renaming syndication to syndication_tests 2013-12-31 11:56:41 +01:00
Claude Paroz
0b825adcf2 Renamed syndication tests 
To resolve the conflict between application names.
 2013-12-31 11:25:02 +01:00
Aymeric Augustin
bfcc686d22 Removed the only_with_models_module argument of get_model[s]. 
Now that the refactorings are complete, it isn't particularly useful any
more, nor very well named. Let's keep the API as simple as possible.

Fixed #21689.
 2013-12-30 23:59:34 +01:00
Florian Apolloner
df075c7489 Merge pull request #2126 from apollo13/email_bytes 
Many thanks to @bitdancer and @aaugustin for answering my stupid questions about (mail)encodings and pointing me in the right direction.
 2013-12-30 14:58:49 -08:00
Florian Apolloner
c988745cca Changed console and filebackend to use msg.as_bytes to output the data as it would get send via smtp. 2013-12-30 23:46:05 +01:00
Aymeric Augustin
80d74097b4 Stopped populating the app registry as a side effect. 
Since it triggers imports, it shouldn't be done lightly.

This commit adds a public API for doing it explicitly, django.setup(),
and does it automatically when using manage.py and wsgi.py.
 2013-12-30 22:11:17 +01:00
Aymeric Augustin
7ed20e0153 Populated Apps instances immediately by default. 2013-12-30 22:11:17 +01:00
Aymeric Augustin
34a215d506 Deprecated the app argument of apps.get_models. 
Use app_config.get_models() instead.
 2013-12-29 21:48:58 +01:00
Aymeric Augustin
e5bcd1d455 Changed get_validation_errors to use an app config. 2013-12-29 21:48:58 +01:00
Aymeric Augustin
1d4bcb86ea Changed sql_* to use an app config instead of a models module. 2013-12-29 21:25:28 +01:00
Aymeric Augustin
38ce41103f Used Apps.clear_cache() in tests that alter the app registry. 2013-12-29 21:25:28 +01:00
Aymeric Augustin
00110904ac Refactored the migration signals to use app configs. 
De-aliased pre/post_syncdb to pre/post_migrate to increase
backwards-compatibility.
 2013-12-29 17:53:42 +01:00
Claude Paroz
6d66ba5948 Fixed #21242 -- Allowed more IANA schemes in URLValidator 
Thanks Sascha Peilicke for the report and initial patch, and
Tim Graham for the review.
 2013-12-28 21:25:32 +01:00
Aymeric Augustin
9f13c33281 Removed the only_installed argument of Apps.get_models. 
Refs #15903, #15866, #15850.
 2013-12-28 20:54:26 +01:00
Aymeric Augustin
ba7206cd81 Changed get_model to raise an exception on errors. 
Returning None on errors required unpythonic error checking and was
inconsistent with get_app_config.

get_model was a private API until the previous commit, but given that it
was certainly used in third party software, the change is explained in
the release notes.

Applied the same change to get_registered_model, which is a new private
API introduced during the recent refactoring.
 2013-12-28 20:53:00 +01:00
Aymeric Augustin
81354b82bf Stopped calling apps.get_model with only_installed=False. 
ContentTypes are only created for installed applications, and I could
make a case for not returning a model that isn't installed any more.
The check for stale ContentTypes in update_contenttypes doesn't use
model_class.

ModelSignal actually needs get_registered_model since the lookup happens
at import time. I took this opportunity to perform a small refactoring.
 2013-12-28 20:42:58 +01:00
Aymeric Augustin
bbdf01e00a Populated non-master app registries. 
This removes the gap between the master app registry and ad-hoc app
registries created by the migration framework, specifically in terms
of behavior of the get_model[s] methods.

This commit contains a stealth feature that I'd rather not describe.
 2013-12-28 20:37:42 +01:00
Florian Apolloner
5dfd824d38 Introduced as_bytes for SafeMIMEText (and other SafeMIME-classes). 
This is to provide a consistent interface (namely bytes) for the smtp
backend which after all sends bytes over the wire; encoding with as_string
yields different results since mails as unicode are not really specified.

as_string stays for backwardscompatibilty mostly and some debug outputs.
But keep in mind that the output doesn't match as_bytes!
 2013-12-28 18:35:17 +01:00
ijl
71a03e01aa Fixed #20346 -- Made cache middleware vary on the full URL. 
Previously, only the URL path was included in the cache key.

Thanks jamey for the suggestion.
 2013-12-28 11:20:18 -05:00
Aymeric Augustin
c81fae6b95 Used app_label instead of appname. 
The last component of the dotted path to the application module is
consistently referenced as the application "label". For instance it's
AppConfig.label. appname could be confused with AppConfig.name, which is
the full dotted path.
 2013-12-28 09:53:02 +01:00
Aymeric Augustin
a7add2f296 Migrated built-in AppCommands to use handle_app_config. 2013-12-28 09:43:06 +01:00
Ramiro Morales
3518e9ec1f Amend test table name so it doesn't clash. 
Refs #21692 and 3efd1b8b93.
 2013-12-27 21:02:39 -03:00
Ramiro Morales
3efd1b8b93 Fixed #21692 -- Quote table name when creating it. 2013-12-27 18:43:52 -03:00
Aymeric Augustin
40b8767635 Fixed a couple flake8 warnings. 2013-12-27 21:06:28 +01:00
Aymeric Augustin
8779aa806e Added a test for Apps.has_app. 2013-12-26 20:39:28 +01:00
Aymeric Augustin
cfbdd587f6 Added file forgotten in previous commit, plus one more test. 2013-12-26 19:29:32 +01:00
Aymeric Augustin
e179291fa5 Added tests for invalid values of INSTALLED_APPS. 2013-12-26 19:25:09 +01:00
Aymeric Augustin
8925aaf613 Added basic tests for get_app_config[s]. 2013-12-26 19:21:02 +01:00
Preston Timmons
aef019de61 Fixed #21206 -- No longer run discovery if the test label doesn't point to a package or directory. 
Thanks thepapermen for the report and Carl Meyer for the review.
 2013-12-26 11:26:24 -05:00
Aymeric Augustin
52325b0a04 Turned apps.ready into a property. Added tests. 2013-12-26 15:04:58 +01:00
Aymeric Augustin
8f04f53dd8 Removed a few gratuitous lambdas. 2013-12-26 14:03:50 +01:00
Levi Gross
0dd9075622
Fixed unittest typo 2013-12-25 12:18:14 -05:00
Alex Gaynor
dbe2fb632d Added a missing import and removed an unneeded import 2013-12-24 08:35:13 -08:00
Aymeric Augustin
1716b7ce5a Renamed AppCache to Apps. 
Also renamed app_cache to apps and "app cache" to "app registry".

Deprecated AppCache.app_cache_ready() in favor of Apps.ready().
 2013-12-24 12:25:17 +01:00
Aymeric Augustin
82a35e24d4 Replaced ad-hoc caching of get_models with lru_cache. 
Invalidate properly the cache whenever all_models or app_configs change.
This fixes some isolation issues in the test suite.
 2013-12-24 10:56:50 +01:00
Aymeric Augustin
7577d03809 Renamed two tests so they actually run. 2013-12-23 23:54:44 +01:00
Aymeric Augustin
e32095616c Imported override_settings from its new location. 2013-12-23 21:37:56 +01:00
Aymeric Augustin
da16bb30ff Dropped AppCache._empty, _with_app and _without_app. 
It's now easier to achieve the same effect with modify_settings or
override_settings.
 2013-12-23 21:37:56 +01:00
Aymeric Augustin
5241763c81 Added modify_settings to alter settings containing lists of values. 2013-12-23 21:37:43 +01:00
Aymeric Augustin
5891990b6e Refactored INSTALLED_APPS overrides. 
* Introduced [un]set_installed_apps to handle changes to the
  INSTALLED_APPS setting.
* Refactored [un]set_available_apps to share its implementation
  with [un]set_installed_apps.
* Implemented a receiver to clear some app-related caches.
* Removed test_missing_app as it is basically impossible to reproduce
  this situation with public methods of the new app cache.
 2013-12-23 20:15:08 +01:00
Aymeric Augustin
3a30b9c575 Fixed a flaky test. 2013-12-22 20:22:56 +01:00
Aymeric Augustin
046a8eb9c4 Made apps available for loading traslations in a test. 2013-12-22 19:04:08 +01:00
Aymeric Augustin
865603780b Moved a test that didn't require Selenium. 2013-12-22 18:50:49 +01:00
Aymeric Augustin
690d1cb8d0 Made AppConfig importable from django.apps. 
It is a public API.
 2013-12-22 11:39:55 +01:00
Aymeric Augustin
2fef9e5375 Moved apps back in the toplevel django namespace. 
Reverted 4a56a93cc4.
 2013-12-22 11:39:55 +01:00
Aymeric Augustin
99bd39ef6e Added the ability to supply custom app configs. 2013-12-22 11:39:18 +01:00
Aymeric Augustin
517c24bcfa Complained on override_settings(INSTALLED_APPS=...). 
Currently such overrides aren't reflected in the app cache.

It would  be possible to handle them. But that doesn't look like a very
good API. It makes it complicated to express "add this app" and "remove
this app", which are the most common operations on INSTALLED_APPS.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
16aae35ca8 Improved set_available_apps() in several ways. 
- Tested consistency the current app_configs instead of INSTALLED_APPS.
- Considered applications added with _with_app as available.
- Added docstrings.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
2239081ff1 Expurged INSTALLED_APPS from code and tests. 
Except the app cache code and a few specific tests, of course.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
9cdf1f6d54 Stop testing for inclusion in INSTALLED_APPS. 
Removed some exception masking in the comments app that was harmful and
couldn't be preserved easily.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
65cd74be8e Stopped iterating on INSTALLED_APPS. 
Used the app cache's get_app_configs() method instead.
 2013-12-22 11:39:18 +01:00
Aymeric Augustin
f25fa9d859 Deprecated load_app(). 
Adjusted several tests that used it to add apps to the app cache and
then attempted to remove them by manipulating attributes directly.

Also renamed invalid_models to invalid_models_tests to avoid clashing
application labels between the outer and the inner invalid_models
applications.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
86804ab063 Terminated AppCache._populate() with extreme prejudice. 
It was called _populate() before I renamed it to populate(). Since it
has been superseded by populate_models() there's no reason to keep it.

Removed the can_postpone argument of load_app() as it was only used by
populate(). It's a private API and there's no replacement. Simplified
load_app() accordingly. Then new version behaves exactly like the old
one even though it's much shorter.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
2b56d69102 Implemented two-stage app-cache population. 
First stage imports app modules. It doesn't catch import errors. This
matches the previous behavior and keeps the code simple.

Second stage import models modules. It catches import errors and retries
them after walking through the entire list once. This matches the
previous behavior and seems useful.

populate_models() is intended to be equivalent to populate(). It isn't
wired yet. That is coming in the next commit.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
9b3389b726 Removed the app_config.installed flag. 
Since applications that aren't installed no longer have an application
configuration, it is now always True in practice.

Provided an abstraction to temporarily add or remove applications as
several tests messed with app_config.installed to achieve this effect.
For now this API is _-prefixed because it looks dangerous.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
972babc3b4 Removed the only_installed argument of get_app_config[s]. 
It wasn't used anywhere and couldn't be implemented any more since
non-installed apps no longer have a configuration.
 2013-12-22 11:39:17 +01:00
Aymeric Augustin
742ed9878e Refactored registration of models. 
Got rid of AppConfig._stub. As a side effect, app_cache.app_configs now
only contains entries for applications that are in INSTALLED_APPS, which
is a good thing and will allow dramatic simplifications (which I will
perform in the next commit). That required adjusting all methods that
iterate on app_configs without checking the "installed" flag, hence the
large changes in get_model[s].

Introduced AppCache.all_models to store models:
- while the app cache is being populated and a suitable app config
  object to register models isn't available yet;
- for applications that aren't in INSTALLED_APPS since they don't have
  an app config any longer.

Replaced get_model(seed_cache=False) by registered_model() which can be
kept simple and safe to call at any time, and removed the seed_cache
argument to get_model[s]. There's no replacement for that private API.

Allowed non-master app caches to go through populate() as it is now
safe to do so. They were introduced in 1.7 so backwards compatibility
isn't a concern as long as the migrations framework keeps working.
 2013-12-22 11:39:17 +01:00
Alexey Voronov
7f2485b4d1 Fixed #21643 -- repeated execution of qs with F() + timedelta 
Thanks Tim Graham for review.
 2013-12-22 00:03:17 +02:00
Aymeric Augustin
eabc3b6c8d Set stacklevel for the override_settings warning. 
Refs #19031.
 2013-12-20 11:09:06 +01:00
Alex Hill
832ab0dbaa Fixed #21639 -- Implemented RenderContext.__getitem__ 
It's now consistent with RenderContext.get.
 2013-12-20 01:02:50 +01:00
Bouke Haarsma
a39d672ec7 Fixed #21386 -- Removed admindocs dependence on sites framework 
* Removed ADMIN_FOR setting and warn warning
* Group view functions by namespace instead of site
* Added a test verifying namespaces are listed

Thanks to Claude Paroz for reviewing and ideas for improvement.
 2013-12-18 19:44:04 +01:00
Baptiste Mispelon
f1b3ab9c21 Fixed #11629 -- Deprecated callable arguments to queryset methods. 
Callable arguments were an untested and undocumented feature.
 2013-12-18 18:40:00 +01:00
Denis Moskalets
d4e578d0f6 Fixed #21552 -- Allowed the use of None for the iexact lookup. 
Thanks Anubhav Joshi for the documentation.
 2013-12-18 09:34:53 -05:00
Loic Bistuer
2fd7fc134c Refs #17413 -- Added isinstance backward compatibility on ErrorList. 2013-12-18 08:59:53 -05:00
Aymeric Augustin
2bc89f83b3 Removed forgotten reference to the borg pattern. 2013-12-17 22:21:40 +01:00
Aymeric Augustin
0242c56fd8 Deborgified the app cache. 
Improved Andrew's hack to create temporary app caches to handle
migrations. Now the main app cache has a "master" flag set to True
(which is a non-default keyword argument, thus unlikely to be used by
mistake). Other app cache instances have "master" set to False.

The only sanctioned way to access the app cache is by importing
django.core.apps.app_cache.

If you were instanciating an app cache and relying on the Borg pattern,
you'll have to refactor your code.
 2013-12-17 21:53:18 +01:00
Aymeric Augustin
6e895f9e06 Removed superfluous models.py files. 
Added comments in the three empty models.py files that are still needed.

Adjusted the test runner to add applications corresponding to test
labels to INSTALLED_APPS even when they don't have a models module.
 2013-12-17 11:16:48 +01:00
Aymeric Augustin
4a56a93cc4 Moved the new app cache inside core. 2013-12-17 10:17:46 +01:00
Aymeric Augustin
30bdad1c47 Refactored old test runner to handle apps without a models module. 2013-12-17 10:17:45 +01:00
Aymeric Augustin
5ba743e262 Made it possible to create apps without a models module. 
This commit reverts f44c4a5d0f and 39bbd165.

django.test.simple will be updated in a separate commit as it requires
invasive changes.
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
69039becde Deprecated get_app(). 2013-12-17 10:17:45 +01:00
Aymeric Augustin
2732edc5f2 Deprecated get_apps(). 2013-12-17 10:17:45 +01:00
Aymeric Augustin
d44de9b933 Removed the _-prefix for populate(). 
Several parts of Django call get_apps() with a comment along this lines
of "this has the side effect of calling _populate()". I fail to see how
this is better than just calling populate()!
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
ebda5800ae Simplified register_models. 
Since it's never called with more than one model at a time the current
signature is needlessly complicated.
 2013-12-17 10:17:45 +01:00
Aymeric Augustin
a4cb140004 Added get_app_config() to look up app configs by label. 
Refactored get_app() to rely on that method.

get_app() starts by calling _populate(), which goes through
INSTALLED_APPS and, for each app, imports the app module and attempts to
import the models module. At this point, no further imports are
necessary to return the models module for a  given app. Therefore, the
implementation of get_app() can be simplified and the safeguards for
race conditions can be removed.

Besides, the emptyOK parameter isn't used anywhere in Django. It was
introduced in d6c95e93 but not actually used nor documented, and it has
just been carried around since then. Since it's an obscure private API,
it's acceptable to stop supporting it without a deprecation path. This
branch aims at providing first-class support for applications without a
models module eventually.

For backwards-compatibility, get_app() still raises ImproperlyConfigured
when an app isn't found, even though LookupError is technically more
correct. I haven't gone as far as to preserve the exact error messages.
I've adjusted a few tests instead.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
b55282b98b Moved list of models inside AppConfig instances. 
This commit is a refactoring with no change of functionality, according
to the following invariants:

- An app_label that was in app_configs and app_models stays in
  app_config and has its 'installed' attribute set to True.

- An app_label that was in app_models but not in app_configs is added to
  app_configs and has its 'installed' attribute set to True.

As a consequence, all the code that iterated on app_configs is modified
to check for the 'installed' attribute. Code that iterated on app_models
is rewritten in terms of app_configs.

Many tests that stored and restored the state of the app cache were
updated.

In the long term, we should reconsider the usefulness of allowing
importing models from non-installed applications. This doesn't sound
particularly useful, can be a trap in some circumstances, and causes
significant complexity in sensitive areas of Django.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
0e9d3472d7 Stored AppConfig objects instead of models modules in the app cache. 
This is a step towards allowing applications without a models module.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
8662654d6d Removed module-level functions for the app cache. 
Since the original ones in django.db.models.loading were kept only for
backwards compatibility, there's no need to recreate them. However, many
internals of Django still relied on them.

They were also imported in django.db.models. They never appear in the
documentation, except a quick mention of get_models and get_app in the
1.2 release notes to document an edge case in GIS. I don't think that
makes them a public API.

This commit doesn't change the overall amount of global state but
clarifies that it's tied to the app_cache object instead of hiding it
behind half a dozen functions.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
9217b89da3 Removed BaseAppCache.app_store. 
It was only storing redundant information. This is part of the effort to
allow applications without a models module.
 2013-12-17 10:17:44 +01:00
Aymeric Augustin
860c2c8bc5 Moved django.db.models.loading to django.apps.cache. 
This commit doesn't contain any code changes; it's purely a refactoring.
 2013-12-17 10:17:43 +01:00
Loic Bistuer
3ce9829b61 Fixed #17413 -- Serialization of form errors along with all metadata. 2013-12-16 16:33:28 -05:00
Baptiste Mispelon
e2f142030b Fixed #21564 -- Use local request object when possible in generic views. 
Thanks to trac user adepue for the report and original patch.
 2013-12-16 16:58:08 +01:00
Peter Harley
cdd6617da6 Fixed #21619 -- Made SingleObjectMixin.get_object catch a more precise exception. 
Thanks to Keryn Knight for the report.
 2013-12-15 21:49:52 +01:00
Loic Bistuer
6685713869 Fixed E127 pep8 warnings. 2013-12-14 11:59:15 -05:00
Baptiste Mispelon
2c837233f5 Fixed #21574 -- Handle bytes consistently in utils.text.normalize_newlines. 
All input is now coerced to text before being normalized.
This changes nothing under Python 2 but it allows bytes
to be passed to the function without a TypeError under Python3
(bytes are assumed to be utf-8 encoded text).

Thanks to trac user vajrasky for the report.
 2013-12-12 16:09:12 +01:00
Ludwik Trammer
9922ed46e2 Fixed #21473 -- Limited language preservation to logout 
Current language is no longer saved to session by LocaleMiddleware
on  every response (the behavior introduced in #14825).
Instead language stored in session is reintroduced into new session
after logout.

Forward port of c558a43fd6 to master.
 2013-12-12 10:24:43 +01:00
Dominic Rodger
5cd6477fd6 Fixed #21462 -- Made assertNumQueries print executed queries on failure. 2013-12-11 15:24:17 -05:00
Simon Charette
75924cfa6d Fixed #21563 -- Single related object descriptors should work with hasattr. 
Thanks to Aymeric Augustin for the review and Trac alias monkut for the report.
 2013-12-11 12:49:28 -05:00
Claude Paroz
c7c647419c Fixed #21510 -- Readded search reset link in changelist search bar 
Thanks moritz.pfeiffer at alp-phone.ch for the report and
Tim Graham for the initial patch.
 2013-12-11 15:30:20 +01:00
Andrew Godwin
5db028affb Fix altering of SERIAL columns and InnoDB being picky about FK changes 2013-12-11 14:19:05 +00:00
Loic Bistuer
a2814846ca Fixed E124 pep8 warnings. 2013-12-10 15:12:48 -05:00
Tim Graham
e7dcd40da2 Added extra newline for flake8. 2013-12-07 07:06:28 -05:00
Loic Bistuer
a8f4553aae Fixed #21555 -- Made ValidationError pickable. 
Thanks trac username zanuxzan for the report and original patch.
 2013-12-07 18:58:37 +07:00
Claude Paroz
41ebc4838d Fixed #21551 -- Reenabled loading fixtures from subdirectory 
This was a regression in Django 1.6 that was only partially
restored in 839940f27f.
Thanks Jonas Haag for the report.
 2013-12-07 10:47:34 +01:00
Claude Paroz
8a9c8bb907 Fixed #21568 -- Added missing ModelMultipleChoiceField to_python method 
Thanks dibrovsd at gmail.com for the report and Simon Charette
for the review.
 2013-12-07 10:14:22 +01:00
Vajrasky Kok
a1a26690b9 Fixed #21572 -- Added unit test for django.utils.text.normalize_newlines. 2013-12-07 16:28:22 +08:00
Baptiste Mispelon
a020dd0a99 Fixed #21530 -- Prevent AttributeError in default URLconf detection code. 
Thanks to @dmyerscoug for the report and original patch
and to @alasdairnicol for the added tests.
 2013-12-07 03:21:58 +01:00
Roger Hu
bbc73e6a12 Fixed #21566 -- Fixed AttributeError when using bulk_create with ForeignObject. 2013-12-06 20:20:16 +01:00
pegler
38e24d680d Fixed #21554 -- Incorrect SQL generated when using multiple inheritance. 2013-12-06 14:12:38 -05:00
Baptiste Mispelon
621c25c419 Added missing deconstruct() methods. 2013-12-06 15:23:34 +01:00
Baptiste Mispelon
19e4374971 Fixed ModelState breaking when unique_together has unhashable elements. 2013-12-06 15:22:52 +01:00
Baptiste Mispelon
aba75b0d71 Fixed TypeError when rendering ModelState with multiple bases. 2013-12-06 00:55:31 +01:00
Alex Gaynor
cbf8e8aa12 Fixed a flake8 error 2013-12-05 08:08:34 -06:00
Andrew Godwin
3b8e46cbc7 Migration VCS conflict detection and --merge for makemigrations 2013-12-04 16:01:49 +00:00
Andrew Godwin
ce05b8a69e Don't make a second migration if there was a force-null-default addcol. 2013-12-04 13:56:22 +00:00
Bouke Haarsma
91c38ce4b2 Fixed 21406 -- Made blocktrans 'trimmed' option preserve line numbers. 
Thanks Bouke Haarsma for report, fix and initial patch.
 2013-12-04 08:36:20 -03:00
Alasdair Nicol
c75dd664cf Fixed #21538 -- Added numpy to test/requirements/base.txt 
Thanks Tim Graham for the report
 2013-12-02 13:37:59 -05:00
Tim Graham
3b60ffa334 Fixed incorrect type for max_length. 2013-12-01 14:21:57 -05:00
Unai Zalakain
2688462f91 Refs #21230 -- removed direct settings manipulation from template tests 2013-11-30 13:47:16 -05:00
Claude Paroz
50a8ab7cd1 Enabled makemessages to support several translation directories 
Thanks Rémy Hubscher, Ramiro Morales, Unai Zalakain and
Tim Graham for the reviews.
Also fixes #16084.
 2013-11-30 11:00:23 +01:00
Loic Bistuer
f563c339ca Fixed #20867 -- Added the Form.add_error() method. 
Refs #20199 #16986.

Thanks @akaariai, @bmispelon, @mjtamlyn, @timgraham for the reviews.
 2013-11-30 01:00:53 +07:00
Vajrasky Kok
7e2d61a972 Fixed #21380 -- Added a way to set different permission for static directories. 
Previously when collecting static files, the directories would receive permissions
from the global umask. Now the default permission comes from FILE_UPLOAD_DIRECTORY_PERMISSIONS
and there's an option to specify the permissions by subclassing any of the
static files storage classes and setting the directory_permissions_mode parameter.
 2013-11-29 08:01:30 -05:00
Christopher Medrela
7477a4ffde Fixed E125 pep8 warnings 2013-11-28 08:50:11 -05:00
Vajrasky Kok
d1df395f3a Fixed #21517 -- Added unit test for non-autoincrement primary key with value 0. 2013-11-28 08:48:38 -05:00
Anssi Kääriäinen
01e8ac47b3 PEP-8 cleanup 
Refs #21169
 2013-11-27 19:45:47 +02:00
Loic Bistuer
f450bc9f44 Added a bulk option to RelatedManager remove() and clear() methods 
Refs #21169
 2013-11-27 19:45:22 +02:00
Loic Bistuer
17c3997f68 Fixed #21169 -- Reworked RelatedManager methods use default filtering 
The `remove()` and `clear()` methods of the related managers created by
`ForeignKey`, `GenericForeignKey`, and `ManyToManyField` suffered from a
number of issues. Some operations ran multiple data modifying queries without
wrapping them in a transaction, and some operations didn't respect default
filtering when it was present (i.e. when the default manager on the related
model implemented a custom `get_queryset()`).

Fixing the issues introduced some backward incompatible changes:

- The implementation of `remove()` for `ForeignKey` related managers changed
  from a series of `Model.save()` calls to a single `QuerySet.update()` call.
  The change means that `pre_save` and `post_save` signals aren't called anymore.

- The `remove()` and `clear()` methods for `GenericForeignKey` related
  managers now perform bulk delete so `Model.delete()` isn't called anymore.

- The `remove()` and `clear()` methods for `ManyToManyField` related
  managers perform nested queries when filtering is involved, which may
  or may not be an issue depending on the database and the data itself.

Refs. #3871, #21174.

Thanks Anssi Kääriäinen and Tim Graham for the reviews.
 2013-11-27 19:44:18 +02:00
Andrew Godwin
5e63977c0e Fixed #21438: makemigrations now detects ManyToManyFields 2013-11-27 15:28:33 +00:00
Claude Paroz
384816fccb Fixed #21448 -- Fixed test client logout with cookie-based sessions 
Thanks Gunnar Scherf for the report and the suggested patch.
 2013-11-26 20:41:51 +01:00
Vajrasky Kok
16d73d7416 Fixed #21512 -- Added more complete information about Pillow and PIL in model_fields and model_forms tests. 2013-11-26 10:18:54 +01:00
Jay Leadbetter
c74504c2dd Fixed #20522 - Allowed use of partially validated object in ModelAdmin.add_view formset validation. 
Updated ModelAdmin to use form.instance when passing parent model to
child inlines for add_view. There is effectively no change in the
change_view since the previously passed 'obj' is the same as form.instance.

Thanks to meshy for report, and EvilDMP and timo for review.
 2013-11-25 20:01:16 -05:00
Alex Gaynor
7349a22d29 flake8 fix 2013-11-25 09:21:25 -06:00
Shai Berger
3411af3cd1 Fixed #21403: Corrected test code 
A test for annotations incorrectly assumed that the first instance
(in the test) of a model using AutoField for PK will always get pk=1.
The test was changed to compare against actual instance id instead.
 2013-11-25 16:16:04 +02:00
Shai Berger
de220fb85e Fixed test failure on Oracle 
Failure was introduced with test in [19e5cd77f0]
 2013-11-25 15:11:50 +02:00
Alex Gaynor
83ab04c6d6 flake8 fixes 2013-11-24 21:07:21 -06:00
Simon Charette
eb38257e51 Fixed #21391 -- Allow model signals to lazily reference their senders. 2013-11-24 17:51:22 -05:00
Joel Bohman
19e5cd77f0 Fixed #21497 -- Forced conversion to bytes for very long index names 2013-11-24 13:15:50 -05:00
Antonis Christofides
f88e760869 Added more tests for ContentTypeManager.get_for_model. 2013-11-24 18:59:46 +01:00
Baptiste Mispelon
e681b2861d Fixed #21500 -- Removed imports of deprecated utils.importlib 2013-11-24 16:45:01 +01:00
Florian Apolloner
d47f794f8f Properly closed cache connections at the end of the request. 
This only affects the new cache api and not the deprecated get_cache.

Refs #21012
 2013-11-24 16:23:28 +01:00
Alex Gaynor
8adbfdfcc4 Fixed flake8 error (5 space identation!!!) 2013-11-24 08:33:22 -06:00
Florian Apolloner
87ea38cc9e Don't fail if there is no memcached backend active. 2013-11-24 12:08:41 +01:00
Florian Apolloner
3ea65d1f68 Fixed regression from ffc37e2343. 
This (hopefully) ensures that the cache are created the same way as before
the offending commit.
 2013-11-24 11:51:37 +01:00
Vajrasky Kok
7169722d5c Fixed #21505 -- Added unit test for django.utils.text.get_valid_filename. 2013-11-24 11:10:34 +01:00
Florian Apolloner
101da92ebd Randomized KEY_PREFIX in caches test to prevent failures during parallel testruns. 2013-11-24 10:15:43 +01:00
Baptiste Mispelon
a739573e17 Fixed test breakage under python 3 introduced by a480f8320a. 2013-11-23 19:50:20 +01:00
Florian Apolloner
9e87444552 Don't fail if cPickle doesn't exist. 
Today is not my day :(
 2013-11-23 19:05:13 +01:00
Florian Apolloner
cf7ddc5765 Follow up to e112654fc8 
Actually comitted the code now :þ
 2013-11-23 18:55:28 +01:00
Florian Apolloner
e112654fc8 Fixed #21200 -- Consistantly raise errors across all cache backends. 
Thanks to tchaumeny for the patch.
 2013-11-23 17:50:28 +01:00
Alex Gaynor
0ec712dd11 A handful of flake8 fixes 2013-11-23 08:26:11 -08:00
Aymeric Augustin
a480f8320a Simplified iteration in HTTP response objects. 
Fixed #20187 -- Allowed repeated iteration of HttpResponse.

All this became possible when support for old-style streaming responses was
finally removed.
 2013-11-23 17:03:43 +01:00
Aymeric Augustin
1124e16340 Allowed running the test suite without memcached (!) 2013-11-23 16:49:14 +01:00
Ramiro Morales
62b393c5ae Fixed #21488 -- Multiple locales treatment in i18n commands. 
Removed multiple locales separated by commas variation (that wasn't
working as documented) in favor of simply allowing use of the
``--locale``/``-l`` options more than once for ``makemessages`` and
``compilemessages``.

Thanks Romain Beylerian for the report and Claude, Simon for their help.

8750296918072c97a51f6809d19828ce3f1b8d40 from stable/1.6.x.
 2013-11-23 11:53:47 -03:00
Curtis Maloney
ffc37e2343 Fixed #21012 -- New API to access cache backends. 
Thanks Curtis Malony and Florian Apolloner.

Squashed commit of the following:

commit 3380495e93f5e81b80a251b03ddb0a80b17685f5
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:18:07 2013 +0100

    Looked up the template_fragments cache at runtime.

commit 905a74f52b24a198f802520ff06290a94dedc687
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 14:19:48 2013 +0100

    Removed all uses of create_cache.

    Refactored the cache tests significantly.

    Made it safe to override the CACHES setting.

commit 35e289fe9285feffed3c60657af9279a6a2cfccc
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:23:57 2013 +0100

    Removed create_cache function.

commit 8e274f747a1f1c0c0e6c37873e29067f7fa022e8
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Nov 23 12:04:52 2013 +0100

    Updated docs to describe a simplified cache backend API.

commit ee7eb0f73e6d4699edcf5d357dce715224525cf6
Author: Curtis Maloney <curtis@tinbrain.net>
Date:   Sat Oct 19 09:49:24 2013 +1100

    Fixed #21012 -- Thread-local caches, like databases.
 2013-11-23 15:06:59 +01:00
Bouke Haarsma
18185724e6 Fixed #21443 -- Cannot show debug info on PY3's importlib 
Thanks productions@zaziork.co.uk for the review.
 2013-11-22 20:36:33 +01:00
Alex Gaynor
b9d908da54 Fixed some flake8 issues 2013-11-22 09:10:18 -08:00
Bouke Haarsma
48ce09f2f6 Fixed missing admindocs' site_header 2013-11-22 13:30:50 +01:00
Pablo Martín
3ac823fc5b Fixed #21460 -- Reenabled proper template precedence in find_template 
Refs #20806. Thanks Unai Zalakain for the review.
 2013-11-22 11:09:51 +01:00
Claude Paroz
d6cc37d601 Updated admindocs to use class-based views 
Thanks Bouke Haarsma for the review.
 2013-11-21 22:50:59 +01:00
Claude Paroz
1718b5256c Fixed #21405 -- Prevented queryset overwrite in BaseModelAdmin 
Thanks guido@20tab.com for the report and Tim Graham for the
analyze.
 2013-11-21 22:18:52 +01:00
Claude Paroz
e6d5f7ae49 Made minor optimizations to admin_ordering tests 2013-11-21 20:58:28 +01:00
Unai Zalakain
2b4bed6dbd Fixed #21476 -- Cache tests make an incorrect use of HttpRequest 
Using `django.test.client.RequestFactory` solves the problem and cleans up all
the `get_request` mess.
 2013-11-21 18:51:08 +01:00
Anssi Kääriäinen
752d3d70da Fixed #21431 -- GenRel->FK list_filter regression in admin 
Report, analysis and tests from stephenmcd.
 2013-11-21 14:52:00 +02:00
Loic Bistuer
8e670a0e50 Refs #8261 -- Fixed regression introduced by fd219fa. 
ModelAdmin displayed the "View on site" link even if the Model didn't
define the `get_absolute_url()` method.
 2013-11-21 16:26:49 +07:00
Claude Paroz
fafb6cf049 Fixed #21472 -- Fixed inline formsets display when parent pk is 0 
Thanks agale031176@gmail.com for the report.
 2013-11-20 21:36:20 +01:00
Baptiste Mispelon
8f5a688d00 Fixed #21458 -- Made check_for_language more resistant to malformed input. 
Thanks to Sergey Sorokin for the report and to Bouke Haarsma for the review.
 2013-11-20 17:51:53 +01:00
Baptiste Mispelon
331d79a77d Fixed #21469 -- Allow set objects in Meta.unique_together. 
Thanks to Tim for the review.
 2013-11-20 17:26:26 +01:00
Vajrasky Kok
68b540c977 Fixed #21361 -- allowed access self.value() from SimpleListFilter lookup 
Reviewed by Chris Medrela.
 2013-11-19 09:14:22 +02:00
Unai Zalakain
4fdd51b732 Fixed #15179 -- middlewares not applied for test client login() 
Requests made with django.test.Client.login() and logout() respect
defaults defined in django.test.Client instantiation and are processed
through middleware.

Thanks to Loic for the reviews.
 2013-11-19 09:04:20 +02:00
Loic Bistuer
3f19b63f8b Fixed some Signal.disconnect calls from 058e434. 
This would go unnoticed by the test suite because receivers are removed
automatically when they are garbage collected.

Changed all Signal.connect calls to hold strong references to ensure we
clean up after ourselves.
 2013-11-18 14:38:28 -05:00
Claude Paroz
97ac22ebfc Fixed #21457 -- Allowed fixture file name to contain dots 
Thanks Keryn Knight for the report.
 2013-11-18 20:32:13 +01:00
Loic Bistuer
058e434064 Merged the signals and signals_regress test packages. 
This patch also made the tests less likely to pollute the global state
in case of failure.
 2013-11-18 12:42:51 -05:00
Claude Paroz
a0f3eeccf3 Fixed #21397 -- Re-added flexibility to TypedChoiceField coercion 
Thanks Elec for the report and Simon Charette for the review.
 2013-11-18 18:24:56 +01:00
Anssi Kääriäinen
0e079e4331 Fixed #21428 -- editable GenericRelation regression 
The GenericRelation refactoring removed GenericRelations from
model._meta.many_to_many. This had the side effect of disallowing
editable GenericRelations in ModelForms. Editable GenericRelations
aren't officially supported, but if we don't fix this we don't offer any
upgrade path for those who used the ability to set editable=True
in GenericRelation subclass.

Thanks to Trac alias joshcartme for the report and stephencmd and Loic
for working on this issue.
 2013-11-16 20:07:35 +02:00
Baptiste Mispelon
ceecc962ad Fixed #21447 -- Restored code erroneously removed in 20472aa827. 
Also added some tests for HttpRequest.__repr__.
Note that the added tests don't actually catch the accidental code
removal (see ticket) but they do cover a codepath that wasn't tested
before.

Thanks to Tom Christie for the report and the original patch.
 2013-11-16 01:09:35 +01:00
Alex Gaynor
10a09b8e60 Fixed the use of the -ise suffix, where -ize is prefered 2013-11-15 05:23:14 -08:00
Loic Bistuer
17ed99f3a3 Fixed #21432 -- DateTimeQuery now copies tzinfo when cloning. 
Thanks Enrique Martínez for the report and @bmispelon for the tests.
 2013-11-14 21:36:55 +01:00
Loic Bistuer
cb83448891 Fixed #21410 -- prefetch_related() for ForeignKeys with related_name='+' 
Regression introduced by commit 9777442.

Thanks to trac username troygrosfield for the report and test case.
 2013-11-13 07:35:34 +02:00
Alex Gaynor
bc742ca110 Flake8 fixes -- including not runnign flake8 over a backported file 2013-11-11 14:05:14 -08:00
Bouke Haarsma
2397daab4a Fixed #9523 -- Restart runserver after compiling apps translations 
Django also uses locales provided by apps, which also might change. Also when
i18n is disabled, there is no need for watching translation files.
 2013-11-11 11:43:09 +01:00
Bouke Haarsma
9b7455e918 Fixed #21351 -- Replaced memoize with Python's lru_cache. 
Replaced the custom, untested memoize with a similar decorator from Python's
3.2 stdlib. Although some minor performance degradation (see ticket), it is
expected that in the long run lru_cache will outperform memoize once it is
implemented in C.

Thanks to EvilDMP for the report and Baptiste Mispelon for the idea of
replacing memoize with lru_cache.
 2013-11-11 08:53:09 +01:00
Claude Paroz
e6dd70b4db Fixed #21383 -- Added request details in SuspiciousOperation messages 2013-11-09 12:11:58 +01:00
Alex Gaynor
ccd11c09c3 Flake8 fix -- correct number of newlines between top level definitions 2013-11-08 09:03:59 -08:00
Unai Zalakain
72f63bd24d Fixed #17529 -- get_template_from_string default arguments break 
``get_template_from_string`` default arguments were breaking
``assertTemplateUsed``. The solution has been to return only the names of the
templates with a ``name`` attribute distinct of ``None``. The default ``name``
kwarg of ``Template`` has been changed to ``None``, more pythonic than ``'<Unknown
Template>'``.
 2013-11-08 17:10:37 +01:00
Claude Paroz
bc21e9c0d9 Fixed #13970 -- Made SelectDateWidget use the standard widget is_required attribute 
Thanks mitar for the report and Tim Graham for the review.
 2013-11-08 16:58:17 +01:00
Tim Graham
536c447820 Fixed a couple flake8 warnings. 2013-11-07 20:10:25 -05:00
Bouke Haarsma
7a7c789d5a Fixed #5849 -- Strip whitespace from blocktrans 
Add the trimmed option to the blocktrans tag to trim any newlines and
whitespace from its content.

This allows the developer to indent the blocktrans tag without adding
new lines and whitespace to the msgid in the PO file.

Thanks to mpessas for the initial patch and Dmitri Fedortchenko for the
report.
 2013-11-08 00:52:17 +02:00
Anssi Kääriäinen
30203a0dea Merge pull request #1850 from unaizalakain/ticket_13725 
Fixed #13725 -- take url scheme into account in assertRedirects

Thanks to Loic for review.
 2013-11-07 14:30:04 -08:00
Unai Zalakain
9c5f6cd565 Fixed #13725 -- take url scheme into account in assertRedirects 
Scheme is handled correctly when making comparisons between two URLs. If
there isn't any scheme specified in the location where we are redirected to,
the original request's scheme is used. If present, the scheme in
``expected_url`` is the one used to make the comparations to.
 2013-11-07 19:06:32 +01:00
Jaap Roes
7be638390e Fixed #20536 -- rewrite of the file based cache backend 
* Safer for use in multiprocess environments
 * Better random culling
 * Cache files use less disk space
 * Safer delete behavior

Also fixed #15806, fixed #15825.
 2013-11-07 16:12:15 +02:00
Loic Bistuer
f51c1f5900 Fixed #17001 -- Custom querysets for prefetch_related. 
This patch introduces the Prefetch object which allows customizing prefetch
operations.

This enables things like filtering prefetched relations, calling select_related
from a prefetched relation, or prefetching the same relation multiple times
with different querysets.

When a Prefetch instance specifies a to_attr argument, the result is stored
in a list rather than a QuerySet. This has the fortunate consequence of being
significantly faster. The preformance improvement is due to the fact that we
save the costly creation of a QuerySet instance.

Thanks @akaariai for the original patch and @bmispelon and @timgraham
for the reviews.
 2013-11-07 14:49:49 +02:00
Anssi Kääriäinen
b1b04df065 Fixed #20600 -- ordered distinct(*fields) in subqueries 2013-11-07 14:29:50 +02:00
Anssi Kääriäinen
e7b61e5717 Fixed #11320 -- exclude() too aggressive in join promotion 2013-11-07 12:57:02 +02:00
Anssi Kääriäinen
6fe2b001db Fixed #21376 -- New implementation for query join promotion logic 
This commit introduced a new class JoinPromoter that can be used to
abstract away join promotion problems for complex filter conditions.
Query._add_q() and Query.combine() now use the new class.

Also, added a lot of comments about why join promotion is done the way
it is.

Thanks to Tim Graham for original report and testing the changes, and
for Loic Bistuer for review.
 2013-11-07 12:53:26 +02:00
Alex Gaynor
e5b7045422 flake8 fixes 2013-11-06 20:00:48 -08:00
Andrew Godwin
106b019dc9 Massive migration optimiser improvements + RenameModel opn 2013-11-06 13:47:58 +00:00
Baptiste Mispelon
b914991b37 Added more tests and documentation for dictsort. 
It's possible to use something like {{ foo|dictsort:'bar.baz' }}
but this wasn't tested or documented.
 2013-11-06 00:26:58 +01:00
Bouke Haarsma
e5e044da87 Fixed #18419 -- Full backwards compatibility for old language codes 
Improved documentation about zh-* deprecation and upgrade path.

Thanks to Baptiste Mispelon for the code reviews.
 2013-11-05 19:26:58 +01:00
Anssi Kääriäinen
76da053641 Fixed #10461 -- bug in generic relation + annotate() case 
This issue was fixed when the contenttype restriction was moved from
where clause to the join clause. So, this is tests only addition.
 2013-11-05 20:02:24 +02:00
Bouke Haarsma
c0a2388a1c Fixed #18149 -- Changed language codes for Chinese 
Language codes for Chinese are zh_Hans (Simplified) and zh_Hant (Traditional).
Added support for browsers that still send the deprecated language codes.

Thanks to Olli Wang for the report.
 2013-11-04 23:03:28 +01:00
Aymeric Augustin
cb2c3ce154 Merge pull request #1821 from Bouke/tickets/14170 
#14170 -- Reset i18n cache when settings changed
 2013-11-04 13:50:21 -08:00
Bouke Haarsma
9b95fa7777 Fixed #21322 -- Error message when CSRF cookie is missing 
Thanks to Henrik Levkowetz and olau for their reports and initial patches.
 2013-11-03 20:05:10 +01:00
Alex Gaynor
f67e18f39e Fixed all E251 violations 2013-11-03 10:17:58 -08:00
Alex Gaynor
c347f78cc1 Fixed all E226 violations 2013-11-03 10:08:55 -08:00
Alex Gaynor
7288e1b02b Merge pull request #1852 from jasonamyers/cleanup/PEP8 
Cleanup/pep8 tests
 2013-11-03 09:51:49 -08:00
Jason Myers
4f151da1e5 Merging in master 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-03 07:19:25 -06:00
Florian Apolloner
08e2ecee3b Fixed some testfailures on jenkins. 
Depending on the order of the tests beeing run, 10 can be a valid pk,
0 can never be a valid pk and as such we will get the wanted ValidationError.
 2013-11-03 14:16:48 +01:00
Jim Bailey
539e3693d4 Fixed #20849 -- ModelForms do not work well with prefetch_related. 
model_to_dict() (used when rendering forms) queries the database
to get the list of primary keys for ManyToMany fields. This is
unnecessary if the field queryset has been prefetched, all the
keys are already in memory and can be obtained with a simple
iteration.
 2013-11-03 12:27:54 +02:00
Bouke Haarsma
d0669843d0 Fixed #14170 -- Reset i18n cache when settings change 2013-11-03 09:36:09 +01:00
Aymeric Augustin
881851f3bb Merge pull request #1853 from loic/dst 
Fixed failing test around DST change.
 2013-11-03 01:14:17 -07:00
Jason Myers
7a61c68c50 PEP8 cleanup 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:49 -05:00
Jason Myers
3f115776e1 PEP8 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:50:38 -05:00
coagulant
8eec2d93b6 Fixed all E261 warnings 2013-11-02 23:50:33 -05:00
Jason Myers
c3791463a5 Fixing E302 Errors 
Signed-off-by: Jason Myers <jason@jasonamyers.com>
 2013-11-02 23:48:47 -05:00
Loic Bistuer
757945b47d Fixed failing test around DST change. 
The timezone arithmetic done in JS can be off by one hour around DST
change. We work around this issue by adding one extra hour to the test
error margin when we detect a DST change is near.

Refs #20663.
 2013-11-02 18:57:35 -05:00
coagulant
3bc0d46a84 Fixed all E261 warnings 2013-11-02 18:20:39 -04:00
Anssi Kääriäinen
2a03a9a9a1 Fixed syntax error in queries/tests.py 2013-11-02 22:42:42 +02:00
Anssi Kääriäinen
bec0b2a8c6 Fixed #14511 -- bug in .exclude() query 2013-11-02 22:35:45 +02:00
Boryslav Larin
e737c009b8 Fixed flake8 E241 2013-11-02 21:45:40 +02:00
Tim Graham
36ded01527 Fixed #21302 -- Fixed unused imports and import *. 2013-11-02 15:24:56 -04:00
Anssi Kääriäinen
9f76ea1eaa Fixed #21375 -- related_name='+' clashed with other '+' names 2013-11-02 21:18:35 +02:00
Anssi Kääriäinen
b44d42be6d Fixed #21366 -- regression in join promotion logic 
The regression was caused by ecaba36028
and affected OR connected filters.
 2013-11-02 20:44:19 +02:00
Unai Zalakain
99b681e227 Fixed #21341 -- Eased https requests with the test client 
All request methods of ``django.test.client.Client`` receive a ``secure``
argument that defaults to ``False`` indicating whether or not to make the
request through https.
Thanks Aymeric Augustin for the review.
 2013-11-02 19:03:13 +01:00
Aymeric Augustin
8b3d9d96ed Merge pull request #1799 from Bouke/tickets/9523 
Fixed #9523 -- Restart runserver after translation MO files change
 2013-11-02 06:57:50 -07:00
Bouke Haarsma
6107435386 Fixed #21324 -- Translate CSRF failure view 
Thanks to Claude Paroz for the original patch.
 2013-11-02 11:22:30 +01:00
Bouke Haarsma
c3936c0d79 Fixed #9523 -- Restart runserver after translation MO files change 
Thanks to Krzysztof Kulewski for the initial patch.
 2013-11-02 10:29:07 +01:00
Ole Laursen
f4f01fb03c Fixed #18508 -- tests for repeated deletion bug in ModelFormSet 
The ticket's issue was already fixed by patch for #14877.
 2013-10-31 19:39:10 +02:00
Anssi Kääriäinen
efb0100ee6 Fixed #14877 -- repeated deletion using formsets 
When a formset contained deletion for an existing instance, and the
instance was already deleted, django threw an exception. A common cause for
this was resubmit of the formset.

Original patch by Trac alias olau.

In addition this commit cleaned some code in _construct_form(). This
was needed as the primary key value the user submitted wasn't converted
correctly to python value in case the primary key field was also a
related field.
 2013-10-30 22:40:15 +02:00
Alex Gaynor
8faaf03b86 Fixed some flake8 issues 2013-10-30 10:42:35 -07:00
Andrew Godwin
e9cb333bc3 Auto-apply initial migrations if their tables exist already. 2013-10-30 15:17:49 +00:00
Baptiste Mispelon
5733764a2c Added some more tests for the debug page. 
* Missing tests for ticket #12744
* Tests for the cleanse_setting feature (leaving out sensitive
  settings from the debug page)
 2013-10-30 07:55:07 +01:00
Baptiste Mispelon
3c5cdaf47a Fixed #21345: Don't evaluate callable settings in the debug page. 
Thanks to crass for the report.
 2013-10-30 07:53:20 +01:00
Simon Charette
8f73559823 Fixed a F811 warning introduced by 35db9d58d6. 2013-10-29 17:22:45 -04:00
Unai Zalakain
fd219fa24c Fixed #8261 -- ModelAdmin hook for customising the "show on site" button 
``ModelAdmin.view_on_site`` defines wether to show a link to the object on the
admin detail page. If ``True``, cleverness (i.e. ``Model.get_absolute_url``) is
used to get the url. If it's a callable, the callable is called with the object
as the only parameter. If ``False``, not link is displayed.

With the aim of maitaining backwards compatibility, ``True`` is the default.
 2013-10-29 17:10:12 -04:00
Claude Paroz
0336d0d95e Rearranged some i18n tests 
Compilation/extraction tests are now properly skipped when gettext
commands are unavailable.
 2013-10-28 14:17:48 +01:00
Claude Paroz
35db9d58d6 Rearranged some file-related tests 
Just moving around some tests to be more logically grouped.
 2013-10-27 21:28:08 +01:00
Ramiro Morales
88f03db05f Fixed test that reads a migration file from disk. 
We need to make sure content read from the file is decoded from UTF-8
right from the start so Python doesn't try to use another encoding
(read: ASCII/CP1252 under Windows.)
 2013-10-27 14:54:56 -03:00
Alex Gaynor
b35ff0d920 Fixed all the E203 violations 2013-10-26 18:27:42 -07:00
Alex Gaynor
9d740eb8b1 Fix all violators of E231 2013-10-26 12:15:03 -07:00
Claude Paroz
3afde36d03 Undelete the login() call inadvertantly removed in 4e0a2fe59c 
Refs #21271.
 2013-10-25 11:23:19 +02:00
SusanTan
4e0a2fe59c Fixed #21271 -- Added timeout parameter to SMTP EmailBackend. 
Thanks Tobias McNulty and Tim Graham for discussions and code review.
Thanks Andre Cruz the suggestion and initial patch.
 2013-10-24 20:38:00 -04:00
Vajrasky Kok
9eecb91695 Fixed #21219 -- Added a way to set different permission for static files. 
Previously, when collecting static files, the files would receive permission
from FILE_UPLOAD_PERMISSIONS. Now, there's an option to give different
permission from uploaded files permission by subclassing any of the static
files storage classes and setting the file_permissions_mode parameter.

Thanks dblack at atlassian.com for the suggestion.
 2013-10-24 17:40:01 -04:00
Claude Paroz
c052699be3 Fixed #20338 -- Stripped ending dot during host validation 
Thanks manfre for the report and Timo Graham for the review.
 2013-10-24 21:24:04 +02:00
Kevin Christopher Henry
08c9ab5a0f Fixed #21227 -- Added workaround for selenium test failures 
Added a refresh() before quit() in the selenium tests, since this
solves the problem of spurious test failures in some environments.
 2013-10-24 15:07:41 -04:00
Renato Oliveira
43569647ab Fixed #21299 - Changed filters from title to capfirst on admin inline formsets. 
Previously there was a mixture of the two which resulted in inconsistent
casing.
 2013-10-24 14:44:07 -04:00
Alex Gaynor
9bf5610890 Start attacking E231 violations 2013-10-24 10:30:03 -07:00
Curtis Maloney
8688f03eef Fixed #20945 -- Allowed cache tag to use a specific cache. 2013-10-23 19:27:08 -04:00
Tim Graham
c573d6de17 Fixed #19941 -- Removed sys.path hack when running the test suite. 
Thanks jezdez for the suggestion.
 2013-10-23 18:27:06 -04:00
Andrew Godwin
5ab8b5d72c Fix migration planner to fully understand squashed migrations. And test. 2013-10-23 22:56:54 +01:00
Tim Graham
4cfbde71a3 Fixed #12027 -- Fixed EmailValidator to reject a trailing dot. 
Thanks Klas H for the report and claudep for the patch.
 2013-10-23 12:22:14 -04:00
Alasdair Nicol
c3aa2948c6 Fixed #21298 -- Fixed E301 pep8 warnings 2013-10-23 13:45:03 +01:00
Ramiro Morales
aefc1d4e65 Workaround admin scripts test failures on Windows+Python 3. 
Change strategy used to examine instrumented output to acommodate the
fact that on Windows, where the path separator is '\', repr() of Python
modules has changed in Python 3 to use escaped backslashes in the FS
path section (e.g.
'C:\\python3x\\Lib\\site-packages\\django\\contrib\\auth\\models.py')
without having to special-case based on platform.
 2013-10-23 08:19:42 -03:00
Tim Graham
ae48d77ef8 Fixed E225 pep8 warnings. 2013-10-23 06:09:29 -04:00
Ramiro Morales
51d2e1fb23 Fixed #21307 -- Moved TransRealMixin to django.test.utils. 2013-10-22 22:19:56 -03:00
Florian Hahn
5240b83462 Fixed #17027 -- Added support for the power operator in F expressions. 
Thanks dan at dlo.me for the initial patch.

- Added __pow__ and __rpow__ to ExpressionNode
- Added oracle and mysql specific power expressions
- Added used-defined power function for sqlite
 2013-10-22 10:29:57 -04:00
Tim Graham
1597503a01 Fixed E221 pep8 warnings. 2013-10-22 09:51:39 -04:00
Bouke Haarsma
0d0f4f020a Fixed #5789 -- Changed LocaleMiddleware session variable to '_language'. 
The old 'django_language' variable will still be read from in order
to migrate users. The backwards-compatability shim will be removed in
Django 1.8.

Thanks to jdunck for the report and stugots for the initial patch.
 2013-10-22 09:24:42 -04:00
Tim Graham
8e2029f8dd Removed import * in tests. 
Thanks to flake8 path/to/file.py | awk -F ' ' '{ print $5 }' | sort | uniq
 2013-10-22 08:32:01 -04:00
Ramiro Morales
b5f52647fe Decode from UTF-8 explicitly when reading a text file in makemessages. 
This shows itself with Python 3 under Windows where UTF-8 usually isn't
the default file I/O encoding and caused one failure and three errors
in our test suite under that platform setup.
 2013-10-22 06:09:21 -03:00
Claude Paroz
a098bee1b9 Fixed #19724 -- Output note when showing only core management commands 
When listing available management commands, only core commands are
listed if settings have any error. This commit adds a note in this
case so errors are not totally silently skipped.
Thanks Peter Davis for the report.
 2013-10-21 21:26:48 +02:00
Loic Bistuer
e565e1332d Fixed #21275 -- Fixed a serializer error when generating migrations for contrib.auth. 
The migration serializer now looks for a deconstruct method on any object.
 2013-10-21 14:54:52 -04:00
Bouke Haarsma
3565efaa45 Removed some direct settings manipulations in tests; refs #21230. 2013-10-21 11:31:05 -04:00
Tim Graham
499cd912ca Fixed E227 pep8 warnings 2013-10-21 08:52:21 -04:00
Alasdair Nicol
b289fcf1bf Fixed #21288 -- Fixed E126 pep8 warnings 2013-10-21 08:31:30 -04:00
Ramiro Morales
a3690168cb Fixed an I18N test class tearDown method. 2013-10-21 01:18:44 -03:00
Loic Bistuer
8d6953d55c Added support for serializing class methods. - Refs #21290. 
The new handling allows us to do away with the whitelisting that was
required to support date and datetime objects.
 2013-10-19 12:10:18 -04:00
Loic Bistuer
584110417f Fixed #21283 -- Added support for migrations if models is a package. 
Thanks Markus Holtermann for the report.
 2013-10-19 09:48:57 -04:00
Tim Graham
96d1d4e292 Removed unused local variables in tests. 2013-10-19 08:31:38 -04:00
Alasdair Nicol
a800036981 Fixed #21287 -- Fixed E123 pep8 warnings 2013-10-18 10:07:39 +01:00
Alasdair Nicol
bab9123daa Fixed #21268 -- Fixed E303 pep8 warnings 2013-10-18 01:46:24 +01:00
Alasdair Nicol
65d1d65d52 Fixed #21267 -- Fixed E502 pep8 warnings 2013-10-18 01:28:32 +01:00
Alasdair Nicol
dfb4cb9970 Fixed #21285 -- Fixed E121,E122 pep8 warnings 2013-10-17 20:20:11 -04:00
Claude Paroz
3514bcb251 Fixed #21284 -- Prevented KeyError swallowing in fetch_command 
Thanks wildfire for the report.
 2013-10-17 18:57:44 +02:00
Claude Paroz
a14f087233 Fixed #21282 -- Made HttpResponse.serialize_headers accept latin-1 
Thanks Raphaël Barrois for the report and the initial patch and
Aymeric Augustin for the review.
 2013-10-17 18:14:35 +02:00
Loic Bistuer
5008706345 Added test for a921f06 - refs #21280. 
This commit also lays the groundwork for future tests for the
makemigrations command.
 2013-10-17 12:08:17 -04:00
Bouke Haarsma
2fb5a51fa3 Fixed #18659 -- Deprecated request.REQUEST and MergeDict 
Thanks Aymeric Augustin for the suggestion.
 2013-10-17 09:42:28 -04:00
Alasdair Nicol
eb214452c3 Fixed #21270 -- Fixed E701 pep8 warnings 2013-10-17 12:12:40 +01:00
Claude Paroz
2992f42861 Fixed #19657 -- Made sql commands honor allow_migrate 
Thanks Manel Clos for the report and the initial patch, and
Marc Tamlyn and Tim Graham for the review.
 2013-10-16 18:02:32 +02:00
Bouke Haarsma
3918eeb9fd Fixed #7551 -- Made GFK allow None init argument. 
Thanks SamBull for the report.
 2013-10-16 07:03:46 -04:00
Andrew Godwin
42f8666f6a Improve migration optimizer to be able to optimize through other ops 2013-10-16 11:09:33 +01:00
Alex Gaynor
694d7da6c5 Merge pull request #1744 from unaizalakain/ticket_7261 
Fixed #7261 -- support for __html__ for library interoperability
 2013-10-15 14:43:35 -07:00
Loic Bistuer
776b6470c1 Fixed DeprecationWarning caused by assertEquals. 2013-10-16 02:28:04 +07:00
Marc Tamlyn
349c12d3f5 Fixed #16855 -- select_related() chains as expected. 
select_related('foo').select_related('bar') is now equivalent to
select_related('foo', 'bar').

Also reworded docs to recommend select_related(*fields) over select_related()
 2013-10-15 15:59:36 +01:00
Claude Paroz
949076eb11 Fixed #21263 -- Fixed issue with override_settings in inherited classes 
When both parent and child classes are decorated with override_settings,
child class settings should take precedence.
Thanks Sephi for the report and Marc Tamlyn for the review.
 2013-10-15 15:38:27 +02:00
Marc Tamlyn
ce823d3710 Merge pull request #1382 from loic/ticket19617 
Fixed #19617 -- Refactored form metaclasses to support more inheritance scenarios.
 2013-10-15 04:22:34 -07:00
Unai Zalakain
af64429b99 Fixed #7261 -- support for __html__ for library interoperability 
The idea is that if an object implements __html__ which returns a string this is
used as HTML representation (eg: on escaping). If the object is a str or unicode
subclass and returns itself the object is a safe string type.

This is an updated patch based on jbalogh and ivank patches.
 2013-10-15 00:42:42 +02:00
Larry O'Neill
83b9bfea44 Fixed #21266 -- Fixed E201,E202 pep8 warnings. 2013-10-14 18:12:00 -04:00
Claude Paroz
42a67ec1cd Fixed #21269 -- Don't crash when CommandError contains non-ascii 
Thanks kontakt@eikefoken.de for the report.
 2013-10-14 21:21:07 +02:00
Ramiro Morales
8ab5f1fe47 Close file after tests added in 945e033a69. 
Avoids failures on Windows. Refs #8918.
 2013-10-14 15:34:43 -03:00
Loic Bistuer
b16dd1fe01 Fixed #8620 -- Updated the Form metaclass to support excluding fields by shadowing them. 2013-10-14 22:42:33 +07:00
Loic Bistuer
ac5ec7b8bc Fixed #19617 -- Refactored Form metaclasses to support more inheritance scenarios. 
Thanks apollo13, funkybob and mjtamlyn for the reviews.
 2013-10-14 21:59:30 +07:00
Claude Paroz
1e8eadc94e Fixed #15888 -- Made tablename argument of createcachetable optional 
Thanks Aymeric Augustin for the report and the documentation and
Tim Graham for the review.
 2013-10-14 13:24:40 +02:00
Aymeric Augustin
589dc49e12 Fixed #21198 -- Prevented invalid use of @python_2_unicode_compatible. 
Thanks jpic for the report and chmodas for working on a patch.

Reverts 2ea80b94. Refs #19362.
 2013-10-13 18:14:04 +02:00
Aymeric Augustin
570d9c2678 Fixed #19560 -- Identified field in warning for naive datetime. 
Thanks gcc for the report and vajrasky for the patch.
 2013-10-13 11:54:11 +02:00
Claude Paroz
00a73c1c69 Fixed #21173 -- Stopped fixing format for date-based widgets at init time 
Thanks Marc Tamlyn for the review.
 2013-10-12 18:31:19 +02:00
Tim Graham
ad17d6a85f Fixed errors in 848101bf17 2013-10-11 17:58:07 -04:00
Sascha Peilicke
848101bf17 Added tests for URLValidator schemes. 2013-10-11 13:41:38 -04:00
Tai Lee
e527c0b6d8 Fixed #13252 -- Added ability to serialize with natural primary keys. 
Added ``--natural-foreign`` and ``--natural-primary`` options and
deprecated the ``--natural`` option to the ``dumpdata`` management
command.

Added ``use_natural_foreign_keys`` and ``use_natural_primary_keys``
arguments and deprecated the ``use_natural_keys`` argument to
``django.core.serializers.Serializer.serialize()``.

Thanks SmileyChris for the suggestion.
 2013-10-11 12:52:57 -04:00
Tim Graham
945e033a69 Fixed #8918 -- Made FileField.upload_to optional. 
Thanks leahculver for the suggestion and dc and vajrasky for work
on the patch.
 2013-10-11 08:07:25 -04:00
Tim Graham
b67ab75e82 Fixed assorted flake8 errors. 2013-10-11 07:25:14 -04:00
Tim Graham
1dae4ac177 Whitespace cleanup. 
* Removed trailing whitespace.
* Added newline to EOF if missing.
* Removed blank lines at EOF.
* Removed some stray tabs.
 2013-10-10 16:49:20 -04:00
Tim Graham
ca874b2fe6 Fixed an undefined variable and clarified the purpose of a test. 
refs #4459.
 2013-10-10 13:01:12 -04:00
Tim Graham
adedc31072 Fixed "redefinition of unused 'foo' from line X" pyflakes warnings. 2013-10-10 11:09:42 -04:00
Tim Graham
cec11a3336 Used "is" for comparisons with None. 2013-10-10 09:35:56 -04:00
Tim Graham
ff9e8eccf8 Removed unnecessary semicolons. 2013-10-10 08:50:32 -04:00
Russell Keith-Magee
a971d19bab Fixed #21243 -- Corrected exception message in multiple database tests. 
Thanks to vajrasky for the report and patch.
 2013-10-09 09:06:23 +08:00
Jaap Roes
40b95a24ae Fixed #20568 -- truncatewords_html no longer splits words containing HTML entities. 
Thanks yann0 at hotmail.com for the report.
 2013-10-08 08:24:58 -04:00
Tim Graham
58d555caf5 Fixed #16822 -- Added RawPostDataException 
Thanks jaylett for the patch.
 2013-10-08 08:05:39 -04:00
Russell Keith-Magee
8ff4303946 Refs #21197 -- Clarified upgrade check message. 
Thanks to Carl and Shai for the discussion.
 2013-10-08 10:00:39 +08:00
Simon Charette
a8df8e34f9 Revert "Fixed #21241 -- Avoid extraneous JOINs in admin changelist search." 
This reverts commit 698dd82eee.

The patch introduced a backward incompatible change.
 2013-10-07 13:45:52 -04:00
Chris Adams
698dd82eee Fixed #21241 -- Avoid extraneous JOINs in admin changelist search. 2013-10-07 13:10:52 -04:00
Tim Graham
617aceb1b4 Fixed #18263 -- Corrrected handling of hidden fields in tabular admin inlines. 
Thanks hvdklauw for the report and patch.
 2013-10-07 12:30:02 -04:00
Javed Khan
4dbd95ad65 Fixed #21236 -- Allowed migrations to work with unique_together tuples. 
Thanks hjwp for the report.
 2013-10-07 09:39:14 -04:00
Anssi Kääriäinen
1df3c49a1a Fixed #21174 -- transaction control in related manager methods 2013-10-05 23:07:52 +03:00
Anssi Kääriäinen
93cc6dcdac Fixed #18414 -- qs.exists() for sliced distinct queries 2013-10-05 21:40:36 +03:00
Anssi Kääriäinen
068b1e045f Simplified a test by using CapturedQueriesContext 2013-10-05 21:16:09 +03:00
Aymeric Augustin
671757b507 Fixed #21161 -- Timezone-related tests on Windows. 
Thanks Xelnor for the patch.
 2013-10-05 18:50:20 +02:00
Anssi Kääriäinen
ecaba36028 Improved Query join promotion logic 
There were multiple cases where join promotion was a bit too aggressive.
This resulted in using outer joins where not necessary.

Refs #21150.
 2013-10-05 14:52:17 +03:00
Anssi Kääriäinen
ed0d720b78 Fixed #21150 -- select_related + annotate join promotion failure 
Added tests for a .annotate().select_related() join promotion failure.
This happened to work on master but was currently untested.
 2013-10-05 14:52:17 +03:00
Simon Charette
948d209ada Fixed #21217 -- Avoid connecting (pre|post)_init signals to abstract senders. 2013-10-04 16:23:06 -04:00
Christopher Medrela
dc3d2ac98c Fixed #11277 -- Hid labels of fields with HiddenInput widget in admin forms. 
Thanks bartTC for the report.
 2013-10-04 14:08:06 -04:00
Tai Lee
bcd4c3f27d Fixed #6681 -- Don't break docutils when rendering reStructuredText. 
Don't set a global default interpreted role function for reStructuredText.
Instead, use the `default-role` directive to change the default only within
the `parse_rst()` function.

Thanks Malcolm Tredinnick for the report.
 2013-10-04 13:27:08 -04:00
Emil Stenström
7a97df190c Fixed #19277 -- Added LocaleMiddleware.response_redirect_class 
Thanks ppetrid at yawd.eu for the suggestion.
 2013-10-03 16:15:29 -04:00
Simon Charette
fa2e1371cd Fixed #21216 -- Allow OneToOneField reverse accessor to be hidden. 2013-10-03 13:20:05 -04:00
Anentropic
c4db7f075e Fixed #19182 -- Fixed ModelAdmin.lookup_allowed to work with ('fieldname', SimpleListFilter) syntax. 
Thanks gauss for the report.
 2013-10-03 09:37:49 -04:00
Ramiro Morales
62dfd79f8b Fixed #21165 -- Fix test for syndication feed timestamp field on Windows. 
Thanks Michael Manfre for the report, Raphaël Barrois for the patch and
Claude Paroz, Aymeric Augustin for the reviews.

Refs #7936.
 2013-10-02 23:29:48 -03:00
Andrew Godwin
a80d9ab0fe Initial version of MigrationOptimizer and tests 2013-10-02 17:34:22 +01:00
Kevin Christopher Henry
978e1351a6 Fixed #21122 -- Improved clean up of test temp directory on Windows 
- Fixed test that didn't close the files it opened
- Caught and handled exception when temp directory cannot be removed
 2013-10-02 09:12:58 -04:00
tschilling
5381317fe3 Fixed #21129 -- Prevented admin filter params modifications from throwing an exception. 
Thanks Tuttle for the report.
 2013-10-02 08:16:09 -04:00
Ramiro Morales
651bed0918 Made test for issue 19552 compatible with Windows. 
Take in account platform path separator. Refs #19552.
 2013-10-02 07:29:40 -03:00
Ramiro Morales
0f46ec315e Made skipping of symlink-related makemessages test smarter. 
os.symlink() is available starting with Windows Vista but can fail at
runtime.
 2013-10-02 07:17:08 -03:00
Ramiro Morales
43959d1057 Fixed tests breakage from last commit. 2013-10-01 21:02:42 -03:00
Ramiro Morales
4b715fc05a Fixed #21209 -- .po file path comments on Windows. 
Literals from source files with Django template language syntax don't
have a '.py' suffix anymore.

Also, the '.\' prefix is preserved to respect GNU gettext behavior on
that platform.

Refs #16903.
 2013-10-01 20:37:43 -03:00
Ramiro Morales
1d0fc61b1c Fixed #15185 -- Allowed ModelAdmin.list_display_links=None to disable change list links. 
Thanks rm_ for the suggestion.
 2013-10-01 14:25:54 -04:00
Anssi Kääriäinen
8c27247397 Added default value for a BooleanField in test models 
Test models introduced for #10733 didn't contain default value for
a BooleanField(). Check command didn't like that -> check tests failed.
 2013-10-01 20:36:06 +03:00
Anssi Kääriäinen
bf13c75c0d Fixed #21203 -- resolve_columns fields misalignment 
In queries using .defer() together with .select_related() the values
and fields arguments didn't align properly for resolve_columns().
 2013-10-01 20:29:23 +03:00
Anssi Kääriäinen
8d4b1629d4 Fixed #10733 -- select_related().only() failure 
The bug was reported pre 1.1, and somewhere along the way it has been
fixed. So, this is tests only addition.
 2013-10-01 19:29:48 +03:00
Claude Paroz
c1c44b2506 Factorized requires_tz_support decorator in test utils 
Thanks Aymeric Augustin for the suggestion. Refs #21165.
 2013-10-01 13:20:41 +02:00
Loic Bistuer
d847ddfe1d Fixed #3871 -- Fixed regression introduced by 04a2a6b. 
Added do_not_call_in_templates=True attribute to RelatedManagers
to prevent them from being called.

Thanks jbg@ for the report.
 2013-09-30 15:43:44 -04:00
Tim Graham
f93896344a Fixed Python 3.2 syntax errors; refs #13724. 2013-09-30 10:28:01 -04:00
Aymeric Augustin
728548e483 Fixed #21134 -- Prevented queries in broken transactions. 
Squashed commit of the following:

commit 63ddb271a44df389b2c302e421fc17b7f0529755
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 29 22:51:00 2013 +0200

    Clarified interactions between atomic and exceptions.

commit 2899ec299228217c876ba3aa4024e523a41c8504
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 22 22:45:32 2013 +0200

    Fixed TransactionManagementError in tests.

    Previous commit introduced an additional check to prevent running
    queries in transactions that will be rolled back, which triggered a few
    failures in the tests. In practice using transaction.atomic instead of
    the low-level savepoint APIs was enough to fix the problems.

commit 4a639b059ea80aeb78f7f160a7d4b9f609b9c238
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Tue Sep 24 22:24:17 2013 +0200

    Allowed nesting constraint_checks_disabled inside atomic.

    Since MySQL handles transactions loosely, this isn't a problem.

commit 2a4ab1cb6e83391ff7e25d08479e230ca564bfef
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sat Sep 21 18:43:12 2013 +0200

    Prevented running queries in transactions that will be rolled back.

    This avoids a counter-intuitive behavior in an edge case on databases
    with non-atomic transaction semantics.

    It prevents using savepoint_rollback() inside an atomic block without
    calling set_rollback(False) first, which is backwards-incompatible in
    tests.

    Refs #21134.

commit 8e3db393853c7ac64a445b66e57f3620a3fde7b0
Author: Aymeric Augustin <aymeric.augustin@m4x.org>
Date:   Sun Sep 22 22:14:17 2013 +0200

    Replaced manual savepoints by atomic blocks.

    This ensures the rollback flag is handled consistently in internal APIs.
 2013-09-30 09:42:27 +02:00
Russell Keith-Magee
9595183d03 Fixed #13724: Corrected routing of write queries involving managers. 
Previously, if a database request spanned a related object manager, the
first manager encountered would cause a request to the router, and this
would bind all subsequent queries to the same database returned by the
router. Unfortunately, the first router query would be performed using
a read request to the router, resulting in bad routing information being
used if the subsequent query was actually a write.

This change defers the call to the router until the final query is acutally
made.

It includes a small *BACKWARDS INCOMPATIBILITY* on an edge case - see the
release notes for details.

Thanks to Paul Collins (@paulcollinsiii) for the excellent debugging
work and patch.
 2013-09-30 13:05:43 +08:00
Ramiro Morales
12ca312e1b Modified test added in 3afb5916b2 so it doesn't fail on Windows. 
Refs #18091.
 2013-09-29 22:44:55 -03:00
Simon Charette
c4fdd859ec Fixed #15786 -- Added a regression test for o2o excludes using F(). 
The issue was reported against 1.3.x but has been fixed since.
 2013-09-29 16:45:03 -04:00
Michael Manfre
b0e06c3662 Fixed #21167 - Improved queries.tests.SubqueryTests 
Improve tests to cover slicing scenarios that could be handled in unique
ways by 3rd party database backends.
 2013-09-29 17:35:42 +03:00
Christopher Babiak
a834bc84d8 Fixed #20931 -- Fixed select widgets nested choice rendering 
ChoiceFieldRenderer was not rendering nested choices. Added recursion
to ChoiceFieldRenderer to take nested choices and render them as
<ul>'s.
 2013-09-28 17:25:32 -07:00
Anssi Kääriäinen
47e79bfcfb Fixed #21187 -- Import CursorWrapper from django.db.backend.utils 
The import was done from util instead of utils leading to
PendingDeprecationWarning.
 2013-09-28 14:18:37 +03:00
Erik Romijn
1a63092981 Fixed #20439 -- Started deprecation of IPAddressField 2013-09-28 10:55:32 +02:00
Baptiste Mispelon
8f51ba669a Fixed #21186: Fixed regression when using date fields in the admin's list_filter. 
Thanks to onlygoldi2201 for the report and to ramiro and apollo13
for the reviews.
 2013-09-28 00:40:43 +02:00
Baptiste Mispelon
3754f4ad41 Fix #21185: Added tests for unescape_entities. 
Also fixed a py3 incompatibility.
Thanks to brutasse for the report.
 2013-09-27 17:00:42 +02:00
Simon Charette
209de62d22 Fix Python 3.2 compatiblity by removing unicode literals. 2013-09-26 00:03:57 -04:00
Giles Richard Greenway
6c06adad1d Fixed #20364 -- Changed urlize regexes to include quotation marks as punctation. 
Thanks to EmilStenstrom for raising this, and to Chris Piwoński for all of the fixes and most of the tests.
 2013-09-25 22:17:22 +02:00
Michael Manfre
99c87f1410 Fixed #17671 - Cursors are now context managers. 2013-09-25 21:47:26 +03:00
Loic Bistuer
04a2a6b0f9 Fixed #3871 -- Custom managers when traversing reverse relations. 2013-09-25 21:15:59 +03:00
Anssi Kääriäinen
83554b018e Fixed #21126 -- QuerySet value conversion failure 
A .annotate().select_related() query resulted in misaligned rows vs
columns for compiler.resolve_columns() method.

Report & patch by Michael Manfre.
 2013-09-25 20:47:57 +03:00
Andrew Godwin
f671fb9d11 Remove most errors when running migration tests twice 2013-09-25 16:11:05 +01:00
Andrew Godwin
fe9f342d8c Allow callables as the argument to RunPython 2013-09-25 16:10:43 +01:00
Andrew Godwin
3b810c5656 Add RunPython migration operation and tests 2013-09-25 13:58:07 +01:00
Andrew Godwin
05656f2388 Add equality support for Project/ModelState 2013-09-25 13:47:46 +01:00
Michael Manfre
9a041807fc Fixed #18333 - Quoted annotated column names 2013-09-24 10:10:08 -04:00
Andrew Godwin
6ede1db331 Fixed #21151 -- Bad cleanup in schema M2M repoint test 2013-09-24 11:00:00 +01:00
Florian Apolloner
16ceb05b47 Isolated select_for_update tests a bit more. 
This change prevents including the multiple_database test models without
duplicating the router code (we probably should do this at one point).

Refs #21148
 2013-09-24 10:29:21 +02:00
Simon Charette
ab643cd634 Fixed test suite bisection on Python 3. 
Thanks to @marfire for spotting this.
 2013-09-23 17:05:36 -04:00
Simon Charette
4ec6d281cd Fixed #21001 -- Added a regression test for empty string exclusion on Oracle. 
The issue was present in 1.4.x but has been reported to be fixed in master.

Thanks to @timgraham for the patch.
 2013-09-23 14:18:03 -04:00
Helen ST
41167645b1 Fixed #14028 - Added validation for clashing db_columns. 
Thanks akaariai for the suggestion.
 2013-09-23 11:51:58 -04:00
Florian Apolloner
4fcc1e4ad8 Stopped a test from executing queries at the module level. 
Currently module level queries are executed against the real database
(specified in NAME) instead of the test database; since it is to late
to fix this for 1.6, we at least ensures stable builds. Refs #21443.
 2013-09-22 23:02:35 +02:00
Aymeric Augustin
e6c0020d19 Translated a test to English for consistency. 
Also fixed a typo.
 2013-09-22 22:48:22 +02:00
Florian Apolloner
2ca00faa91 Fixed "Address already in use" from liveserver. 
Our WSGIServer rewrapped the socket errors from server_bind into
WSGIServerExceptions, which is used later on to provide nicer
error messages in runserver and used by the liveserver to see if
the port is already in use. But wrapping server_bind isn't enough since
it only binds to the socket, socket.listen (which is called from
server_activate) could also raise "Address already in use".

Instead of overriding server_activate too I chose to just catch socket
errors, which seems to make more sense anyways and should be more robust
against changes in wsgiref.
 2013-09-22 22:02:59 +02:00
Aymeric Augustin
a5b062576b Removed a few trailing backslashes. 
We have always been at war with trailing backslashes.
 2013-09-22 14:04:10 +02:00
Aymeric Augustin
ee0ef1b094 Partial revert of 165f44aa. 
That commit didn't always improve readability.

See discussion on django-developers for details.
 2013-09-22 14:04:10 +02:00
Aymeric Augustin
5444a9c683 Fixed #21074 -- Added tests for localized datetime fields. 
Fields must render values in the current time zone.

This commit only contains tests because this ticket was just a symptom of
a regression from #18777 that was fixed separately.
 2013-09-21 23:10:14 +02:00
Aymeric Augustin
68b10fa177 Ensured that explicit time zones are rejected by forms. 
Refs #19371.
 2013-09-21 21:09:25 +02:00
tschilling
0d1ba84d13 Fixed #20702 -- Deprecated get_formsets in favor of get_formsets_with_inlines. 
Thanks stanislas.guerra at gmail.com for the report.
 2013-09-20 07:47:24 -04:00
yokomizor
df27803a55 Fixed #9532 -- Added min_num and validate_min on formsets. 
Thanks gsf for the suggestion.
 2013-09-19 13:11:49 -04:00
Curtis Maloney
4e9f800742 Fixed #21125 -- Removed support for cache URI syntax 2013-09-19 10:01:39 -04:00
Tim Graham
7fec5a2240 Fixed #7557 -- Added type checking to Variable initialization. 
Thanks tobias for the suggestion and boblefrag and saz for work on the
patch.
 2013-09-19 09:27:19 -04:00
Tim Graham
e23de9e350 Fixed typo in exception message; refs #19414 
Thanks Alexey Boriskin for the report.
 2013-09-19 06:24:12 -04:00
Brian Holdefehr
98514849dc Fixed #19414 -- Added admin registration decorator 
Thanks stavros for the suggestion.
 2013-09-18 11:44:10 -04:00
Tim Graham
2daada800f Fixed #21098 -- Applied sensitive_post_parameters to MultiValueDict 
Thanks simonpercivall for the report and bmispelon for the review.
 2013-09-18 09:48:36 -04:00
Tim Graham
4f40b97d97 Fixed #21118 -- Isolated a test that uses the database. 
Thanks rmboggs for the report.
 2013-09-18 09:42:47 -04:00
Berker Peksag
2f0566fa61 Fixed #4278 -- Added a dirs parameter to a few functions to override TEMPLATE_DIRS. 
* django.template.loader.get_template()
* django.template.loader.select_template()
* django.shortcuts.render()
* django.shortcuts.render_to_response()

Thanks amcnabb for the suggestion.
 2013-09-18 07:37:08 -04:00
Tim Graham
893198509e Fixed #15625 -- Made message in MultiValueDictKeyError less verbose. 
Thanks margieroginski for the suggestion.
 2013-09-18 06:44:38 -04:00
Anssi Kääriäinen
50633e7353 Fixed #12568 -- no error when accessing custom field's descriptor 
The SubfieldBase's descriptor caused an AttributeError when accessed
from the class. Introspection didn't like that.

Patch by Trac alias supervacuo.
 2013-09-18 10:03:52 +03:00
Markus Holtermann
a772ea8117 Fixed #21115 -- Fixed NameError in migrate --list command 2013-09-17 12:53:59 -04:00
Markus Holtermann
5a424c2393 Fixed #21114 -- Migrations must not have a dependency to themselves. 2013-09-17 11:47:19 -04:00
Tim Graham
1234225068 Fixed test failures introduced in previous commit. 2013-09-16 13:12:50 -04:00
Tim Graham
18ffdb1772 Fixed #17627 -- Renamed util.py files to utils.py 
Thanks PaulM for the suggestion and Luke Granger-Brown and
Wiktor Kołodziej for the initial patch.
 2013-09-16 12:52:05 -04:00
Florian Apolloner
351a061497 Fixed a timing edge case in the RelatedFieldWidgetSeleniumFirefoxTests. 
By settings an implicit wait timeout for the find_* methods we can wait
till the javascript code add the new option to the DOM.

See http://ci.djangoproject.com/job/Django/database=mysql_gis,python=python3.3/3174/testReport/junit/admin_widgets.tests/RelatedFieldWidgetSeleniumFirefoxTests/test_foreign_key_using_to_field/

Stacktrace:
Traceback (most recent call last):
  File "/var/lib/jenkins/jobs/Django/workspace/database/mysql_gis/python/python3.3/tests/admin_widgets/tests.py", line 1060, in test_foreign_key_using_to_field
      self.assertEqual(username_value, new_option.get_attribute('value'))
      AssertionError: 'newuser' != 'testser'
      - newuser
      + testser
 2013-09-15 01:11:07 +02:00
Tim Graham
886bb9d878 Revert "Fixed #12288 -- Validated that app names in INSTALLED_APPS are unique" 
This reverts commit c1ec08998d.

There are backwards compatability concerns with this.
 2013-09-14 07:19:32 -04:00
Anssi Kääriäinen
74b91b3888 Added tests for double-pickling a QuerySet 
Refs #21102.
 2013-09-14 10:33:15 +03:00
Michael Manfre
c89d80e2cc Fixed #21097 - Added DatabaseFeature.can_introspect_autofield 2013-09-14 09:48:59 +03:00
Juan Catalano
6feb75129f Fixed #21060 -- Refactored admin's autodiscover method to make it reusable. 
We want to be able to use it for instance for discovering `tasks.py` modules
inside the INSTALLED_APPS.

This commit therefore moves the logic to `autodiscover_modules` method in
django.utils.module_loading.
 2013-09-13 20:09:41 -04:00
e0ne
c1ec08998d Fixed #12288 -- Validated that app names in INSTALLED_APPS are unique 2013-09-13 08:09:21 -04:00
Michael Manfre
018037736f Fixed #21099 - Skip DistinctOnTests unless backend can_distinct_on_fields 2013-09-12 14:32:23 -04:00
Michael Manfre
e61cc87129 Fixed #21090 -- Allowed backends to provide dotted field path to inspectdb. 2013-09-11 13:35:26 -04:00
Baptiste Mispelon
abb10db06f Fixed #21089 -- Allow TransactionTestcase subclasses to define an empty list of fixtures. 
Thanks to lgs for the report and initial patch.
 2013-09-11 15:28:04 +02:00
Keryn Knight
170f721367 Fixed #21056 -- AdminSite.app_index no longer blindly accepts any app-labelish input. 2013-09-11 08:48:32 -04:00
Tim Graham
7fe5b656c9 Prevented arbitrary file inclusion with {% ssi %} tag and relative paths. 
Thanks Rainer Koirikivi for the report and draft patch.

This is a security fix; disclosure to follow shortly.
 2013-09-10 21:02:48 -04:00
Tim Graham
4e96dac450 Fixed #19298 -- Added MultiValueField.__deepcopy__ 
Thanks nick.phillips at otago.ac.nz for the report.
 2013-09-10 13:56:49 -04:00
Florian Apolloner
d5d0e03ec8 Fixed test errors from 053de6131a on py3.2. 2013-09-10 19:17:01 +02:00
e0ne
053de6131a Fixed #5749 -- Added field_name as a key in the _html_output dict 
Thanks SmileyChris for the suggestion.
 2013-09-10 13:00:10 -04:00
Juan Catalano
4840fd9cbc Fixed #20919 -- Extended assertRedirects to be able to avoid fetching redirect's response. 
Thanks mjtamlyn for the suggestion.
 2013-09-10 12:22:55 -04:00
Aymeric Augustin
79ccd1a101 Fixed test that fails when pytz is installed. 
pytz' localize() method is the bane of my life.
 2013-09-10 18:07:29 +02:00
Gregor MacGregor
b2b763448f Fixed #20841 -- Added messages to NotImplementedErrors 
Thanks joseph at vertstudios.com for the suggestion.
 2013-09-10 11:09:59 -04:00
Loic Bistuer
d59f1993f1 Made MigrationWriter look for a "deconstruct" attribute on functions. 
Refs #20978.
 2013-09-10 10:12:23 -04:00
Tim Graham
4ba373840a Fixed #16534 -- Improved ability to customize DiscoverRunner 
Added DiscoverRunner.test_suite and .test_runner attributes.

Thanks tomchristie for the suggestion and jcd for the patch.
 2013-09-10 09:49:39 -04:00
Roberto Aguilar
af67ce5e18 Fixed #4574 -- Added CSS classes to the admin calendar widget for better control over styling. 2013-09-10 08:07:17 -05:00
e0ne
f2a4452882 Fixed #18403 -- Initialized bad_cookies in SimpleCookie 
Thanks Stefano Crosta for the report.
 2013-09-10 08:26:54 -04:00
homm
7008ed61c5 Fixed #21033 -- Fixed uploaded filenames not always being truncated to 255 characters 2013-09-10 01:55:16 +02:00
Florian Apolloner
df2fd4e09b Removed unneeded imports in tests's __init__.py and unified them. 2013-09-09 23:01:07 +02:00
Aymeric Augustin
d9413d33b2 Refactored code and tests that relied on django.utils.tzinfo. 
Refs #17262.
 2013-09-09 22:32:52 +02:00
Aymeric Augustin
ec2778b445 Fixed #17262 -- Refactored tzinfo implementations. 
This commit deprecates django.utils.tzinfo in favor of the more recent
django.utils.timezone which was introduced when Django gained support
for time zones.
 2013-09-09 22:32:51 +02:00
Kevin Christopher Henry
9d700322b3 Fixed #19885 -- cleaned up the django.test namespace 
* override_settings may now be imported from django.test
* removed Approximate from django.test
* updated documentation for things importable from django.test

Thanks akaariai for the suggestion.
 2013-09-09 16:03:13 -04:00
Josh Mize
a52cc1c088 Fixed #21078 -- Handled additional bad Accept-Language header 2013-09-09 15:19:09 -04:00
Keryn Knight
0d74f9553c Fixed #21063 -- AdminSite app_index should be fail early if the user has no permissions. 2013-09-09 12:51:03 -04:00
Tim Graham
789d8f0748 Fixed syntax error on Python 3.2; refs #20889. 2013-09-09 09:54:08 -04:00
Curtis Maloney
7c6f2ddcd9 Simplify FilterExpression.args_check 2013-09-09 09:03:50 -04:00
Daniel Boeve
6dca603abb Fixed #20889 -- Prevented email.Header from inserting newlines 
Passed large maxlinelen to email.Header to prevent newlines from being
inserted into value returned by _convert_to_charset

Thanks mjl at laubach.at for the report.
 2013-09-09 08:47:41 -04:00
Tim Graham
aeed2cf3b2 Added a test to show that the user.is_staff check in admin base.html is necessary. 
refs #21067
 2013-09-09 07:59:35 -04:00
Baptiste Mispelon
28a571348b Fix #20745: Don't silence TypeError raised inside templates. 
Thanks to robin for the report and claudep for the review.
 2013-09-08 22:05:35 +02:00
Alex Gaynor
9d11522599 Removed some more unused local vars 2013-09-08 12:20:01 -07:00
Aymeric Augustin
c687bf0620 Further hardening. Refs #18766. 2013-09-08 20:43:04 +02:00
Aymeric Augustin
1a1e14786a Hardened the test introduced in ded11aa6. Refs #18766. 
Inputs acceptable to time.mktime are platform-dependent.
 2013-09-08 19:40:42 +02:00
Alex Gaynor
96fd5557f9 Removed a ton of unused local vars 2013-09-08 08:05:16 -07:00
Aymeric Augustin
ded11aa620 Fixed #18766 -- Pointed to pytz when LocalTimezone fails. 
Thanks void for the report.
 2013-09-08 02:04:43 -05:00
Pablo Mouzo
b11564fd36 Fixed #16869 -- BaseGenericInlineFormSet.save_new should use form's save() method 
Thanks mattaustin for the report and Pablo Recio (pyriku) for the patch.
 2013-09-07 20:00:38 -04:00
Alex Gaynor
c348550d35 Fixed some flake8 warnings 2013-09-07 15:36:00 -07:00
Juan Catalano
04415bf81b Fixed #21013 -- Ensure that ModelAdmin.get_queryset is considered for the admin history view. 2013-09-07 14:53:29 -05:00
Julien Phalip
8ef060e0e6 Fixed a test failure introduced in 55a11683f7. 2013-09-07 12:41:33 -05:00
Julien Phalip
55a11683f7 Fixed #20836 -- Ensure that the ForeignKey's to_field attribute is properly considered by the admin's interface when creating related objects. 
Many thanks to Collin Anderson for the report and patch and to Peter Sheats for the test.
 2013-09-07 12:14:07 -05:00
Aymeric Augustin
65b6eff322 Fixed #20530 -- Properly decoded non-ASCII query strings on Python 3. 
Thanks mitsuhiko for the report.

This commit just adds a test since the problem was fixed in 8aaca651.
 2013-09-07 11:47:38 -05:00
Andrew Godwin
bacbbb481d RunSQL migration operation and alpha SeparateDatabaseAndState op'n. 2013-09-07 11:03:38 -05:00
Aymeric Augustin
f5add4712f Fixed tests introduced in previous commit on Python 2. Refs #20557. 2013-09-07 10:43:44 -05:00
Aymeric Augustin
8aaca651cf Fixed #20557 -- Properly decoded non-ASCII cookies on Python 3. 
Thanks mitsuhiko for the report.

Non-ASCII values are supported. Non-ASCII keys still aren't, because the
current parser mangles them. That's another bug.
 2013-09-07 10:25:43 -05:00
Alex Gaynor
97a626d898 Fixed this syntax error on py32 2013-09-06 21:56:57 -07:00
Aymeric Augustin
a9589dd280 Fixed #21032 -- pip 1.4 can't install pytz. 2013-09-06 22:11:55 -05:00
Eric Boersma
ded40142a9 Fixed #20007 -- Configured psycopg2 to return UnicodeArrays 
Thanks hogbait for the report.
 2013-09-06 20:43:58 -04:00
Russell Keith-Magee
926bc421d9 Merge pull request #1566 from adamsc64/ticket_11857 
Fixed #11857 -- Added missing 'closed' property on TemporaryFile class.
 2013-09-06 17:38:37 -07:00
Tim Graham
b7451b72ed Fixed deprecation warning on Python 3 2013-09-06 20:36:17 -04:00
Loic Bistuer
adc0ab3386 Fixed #21037 -- Made MigrationWriter raise a ValueError when serializing lambda functions. 2013-09-06 20:13:01 -04:00
Tim Graham
67863b3bfe Fixed test failure introduced in efd1e6096e (sqlmigrate) 2013-09-06 19:59:25 -04:00
Russell Keith-Magee
4f5faa1916 Merge pull request #1582 from rca/12756-missing-yaml-module-serializer-error-message 
Fixed #12756: Improved error message when yaml module is missing.
 2013-09-06 16:05:02 -07:00
Roberto Aguilar
01a5359477 Cleanup commit after peer review. 2013-09-06 22:45:31 +00:00
Russell Keith-Magee
9b2dc12b83 Merge pull request #1580 from ianawilson/ticket_16502 
Fixed #16502 -- Fixed a TemplateDoesNotExist error that should be an ImproperlyConfigured.

Assistance on the patch from #jambronrose.
 2013-09-06 15:31:25 -07:00
Roberto Aguilar
9587d4eea0 Fixed existing tests to handle BadSerializer. 
When a BadSerializer instance is stubbed in for the yaml serializer,
make sure tests do not fail.
 2013-09-06 22:26:13 +00:00
Roberto Aguilar
ca3ac4a3e3 Updated NoYamlSerializerTestCase to run with yaml. 
In order to verify the behavior of using the yaml serializer when yaml
is on the system, fake the ImportError when the serializer is being
registered.
 2013-09-06 22:26:13 +00:00
Ian Wilson
d005130845 fixed test name from an old, overly specific iteration of the test 2013-09-06 17:20:43 -05:00
Aymeric Augustin
b4cd8169de Fixed #11811 -- Data-loss bug in queryset.update. 
It's now forbidden to call queryset.update(field=instance) when instance
hasn't been saved to the database ie. instance.pk is None.
 2013-09-06 17:15:23 -05:00
Russell Keith-Magee
122020fdb9 Merge pull request #1579 from ianawilson/ticket_21058 
Fixed #21058 -- Fixed debug view blowing up when no template is provided to the template rendering functions.

Assistance on this commit from @jambonrose.
 2013-09-06 15:06:57 -07:00
Ian Wilson
e12de0ac04 Removed unnecessary, leftover imports 2013-09-06 22:04:58 +00:00
Adrian Holovaty
e844e10b4f Moved a settings usage up the stack in utils/formats.py #unsettings 2013-09-06 17:01:36 -05:00
Ian Wilson
b79df0b358 adds fix for SingleObjectTemplateResponseMixin raising a TemplateDoesNotExist when it should have raised an ImproperlyConfigured. fixes 16502. by @ianawilson, @jambonrose 2013-09-06 16:27:34 -05:00
Julien Phalip
d5df914fe1 Merge pull request #1578 from rmutter/ticket_20821 
Fixed #20821 -- Added tooltips to Admin SelectBox widget
 2013-09-06 14:03:58 -07:00
Ian Wilson
9b7f4aab32 adds fix and test for when a template is not specified at all to render(). fixes #21058. by jambonrose and ianawilson 2013-09-06 15:50:18 -05:00
Rudy Mutter
c438cc2a36 Fixed #20821 -- Added tooltips to Admin SelectBox widget 
The Admin widget, which can be used to filter multiple selects
can sometimes be too narrow and hide information such as
user permissions. This commit adds tooltips to the select
options so that a user can hover over and see the hidden text.
 2013-09-06 15:46:38 -05:00
Andrew Godwin
efd1e6096e Adding 'sqlmigrate' command and quote_parameter to support it. 2013-09-06 15:28:12 -05:00
Roberto Aguilar
d8d61d8260 Added tests for missing pyyaml. 
This test makes sure an YAML import errors are communicated to the
caller rather than stating the serializer does not exist.
 2013-09-06 20:23:27 +00:00
Dan Johnson
df462cf760 Fixed #21043 -- Made resolve() handle reverse_lazy objects. 
Thanks Keryn Knight for the report.
 2013-09-06 15:46:43 -04:00
Florian Apolloner
85359ec9a4 Merge branch 't20812' 2013-09-06 21:03:46 +02:00
Daniel Langer
cc957cb16c Fixed #4287 -- Fixed NaN and +/- Infinity handling in FloatField 
NaN, +Inf, and -Inf are no longer valid values for FloatFields.
 2013-09-06 14:56:37 -04:00
Christopher Adams
b2f5ac1656 Fixed #11857 -- Added missing 'closed' property on TemporaryFile class. 
- TemporaryFile now minimally mocks the API of the Python standard
  library class tempfile.NamedTemporaryFile to avoid AttributeError
  exceptions.
- The symbol django.core.files.NamedTemporaryFile is actually assigned
  as a different class on different operating systems.
- The bug only occurred if Django is running on Windows, hence why it
  was hard to diagnose.
 2013-09-06 14:32:46 -04:00
Andrew Godwin
05e14e8eaf Migration autodetector now corerctly deals with proxy models 2013-09-06 12:39:46 -05:00
Florian Apolloner
2326dedde8 Fixed #20812 -- Error out if __unicode__/__str__ doesn't return a text type. 2013-09-06 19:24:18 +02:00
Andrew Godwin
be983ee403 Also test failure case of ProjectState dependency resolution 2013-09-06 12:18:24 -05:00
Andrew Godwin
cdeff3acc2 Project/ModelState now correctly serialize multi-model inheritance 2013-09-06 12:16:03 -05:00
Andrew Godwin
6f7977bb63 Fixed #21029: Test for previously-commited SchemaEditor.__exit__ bug. 2013-09-06 12:16:03 -05:00
Chris Wilson
eade315da1 Fixed #10164 -- Made AutoField increase monotonically on SQLite 
Thanks malte for the report.
 2013-09-06 12:31:17 -04:00
Aymeric Augustin
e492ab8e7e Fixed #18719 -- Made force_bytes more consistent with force_text. 2013-09-06 10:28:28 -05:00
Markus Holtermann
bd8e1a354c Fixed #20977 -- Fixed writing migrations to disk on Python 3 2013-09-06 09:51:58 -04:00
Preston Timmons
8625c7aab3 Fixed #16096 -- Added origin attribute to template instances. 
Thanks jdunck for the suggestion.
 2013-09-06 09:14:52 -04:00
Loic Bistuer
e1266e50b2 Fixed #21015 -- Fixed MigrationLoader when importlib.import_module returns a file module or an empty directory. 2013-09-06 08:30:19 -04:00
Loic Bistuer
82bbb9fe81 Fixed #21014 -- Fixed gobbled ImportError in MigrationLoader. 2013-09-06 08:30:18 -04:00
Eric Boersma
4d13cc56de Fixed #21035 -- Changed docs to treat the acronym SQL phonetically. 
The documentation and comments now all use 'an' to
refer to the word SQL and not 'a'.
 2013-09-05 20:14:58 -04:00
Aymeric Augustin
6a6428a36f Took advantage of django.utils.six.moves.urllib.*. 2013-09-05 14:39:23 -05:00
Tim Graham
bab039d74c Fixed #21041 -- Removed a duplicate form in tests. 
Thanks tuxcanfly.
 2013-09-05 05:49:10 -04:00
Loic Bistuer
34d52fd32e Fixed #21010 -- Changed ModelState to only copy _meta.local_fields. 2013-09-04 14:05:59 -04:00
Tim Graham
5649c0af9d Fixed "indentation is not a multiple of four" pep8 issues. 2013-09-03 14:22:21 -04:00
Tim Graham
cb98ffe8f4 Fixed a couple unclosed file warnings in tests 2013-09-03 13:37:27 -04:00
Tim Graham
3db66b1d65 Updated syncdb -> migrate in tests. 2013-09-03 11:51:34 -04:00
Tim Graham
86964a7b4f Silenced deprecation warning regarding old SQL location; refs #14300 2013-09-03 11:10:43 -04:00
Tim Graham
2fd03b39ab Removed references to django.utils.unittest which is PendingDeprecation 2013-09-03 09:55:21 -04:00
Tim Graham
ec784c486b Silenced deprecation warnings in SortedDict tests; refs [07876cf02b] 2013-09-03 09:48:46 -04:00
Aymeric Augustin
365c3e8b73 Replaced "not PY3" by "PY2", new in six 1.4.0. 2013-09-02 12:11:02 +02:00
Ramiro Morales
41feab3654 Converted tests for admin first form widget auto-focus to Selenium. 
Refs #1707 and 1c0c879be3.
 2013-09-01 15:07:08 -03:00
Ramiro Morales
c01cd4c423 Change test added in 3e34005b1b to be more stable. 
It could fail when actual serialization JSON field ordering was
different from the hard-coded one. Refs #13182.
 2013-09-01 10:47:35 -03:00
Loic Bistuer
ff9e116198 Fixed #21008 -- Made MigrationWriter handle Promise objects. 2013-08-31 20:26:44 -04:00
Ramiro Morales
e909ceae9b Made django.test.testcases not depend on staticfiles contrib app. 
Do this by introducing a django.contrib.staticfiles.testing.StaticLiveServerCase
unittest TestCase subclass.

Fixes #20739.
 2013-08-31 11:02:32 -03:00
Claude Paroz
e0643cb676 Properly skipped yaml tests when not installed 2013-08-31 15:23:56 +02:00
Claude Paroz
3e34005b1b Fixed #13182 -- Prevented trailing spaces in indented json output 
Thanks Stéphane Raimbault for the report and the initial patch.
 2013-08-31 15:18:01 +02:00
Carl Meyer
7211741fc5 Fixed #20999 - Allow overriding formfield class with choices, without subclass restrictions. 
Refs #18162. Thanks claudep and mjtamlyn for review.
 2013-08-30 17:43:10 -06:00
Claude Paroz
b04f8ddbaa Fixed #21005 -- Made schema tests language-independent 
Thanks Simon Charette for the review.
 2013-08-30 21:28:21 +02:00
Simon Charette
11cd7388f7 Fixed #20989 -- Removed useless explicit list comprehensions. 2013-08-30 10:57:51 -04:00
Curtis Maloney
e2f06226ea Improved {% include %} implementation 
Merged BaseIncludeNode, ConstantIncludeNode and Include node.

This avoids raising TemplateDoesNotExist at parsing time, allows recursion
when passing a literal template name, and should make TEMPLATE_DEBUG behavior
consistant.

Thanks loic84 for help with the tests.

Fixed #3544, fixed #12064, fixed #16147
 2013-08-30 10:36:36 +03:00
Anssi Kääriäinen
e973ee6a98 Fixed #20988 -- Added model meta option select_on_save 
The option can be used to force pre 1.6 style SELECT on save behaviour.
This is needed in case the database returns zero updated rows even if
there is a matching row in the DB. One such case is PostgreSQL update
trigger that returns NULL.

Reviewed by Tim Graham.

Refs #16649
 2013-08-30 09:41:07 +03:00
Simon Charette
36bbe3b7c5 Altered test introduced in f19a3669b8 for the sake of readability. refs #14786 2013-08-29 14:50:55 -04:00
Tim Graham
f19a3669b8 Fixed #14786 -- Fixed get_db_prep_lookup calling get_prep_value twice if prepared is False. 
Thanks homm for the report and Aramgutang and lrekucki for work on
the patch.
 2013-08-29 11:13:34 -04:00
Tim Graham
af953c45cc Fixed #16433 -- Fixed a help_text/read only field interaction that caused an admin crash. 
Thanks chris at cogdon.org for the report and admackin for the patch.
 2013-08-29 09:39:31 -04:00
Tim Graham
cf8d6e9108 Fixed #20881 -- Removed contrib.auth.models.AbstractUser.get_absolute_url() 
The definition is arbitrary and creates a broken "view on site"
link in the admin if a project doesn't define such a URL.
 2013-08-29 06:36:35 -04:00
Curtis Maloney
8d473b2c54 Fixed #7116 -- Optimize RequestContext construction 2013-08-29 10:25:56 +03:00
Curtis Maloney
5cdacbda03 Fixed #17356 -- Allowed {% include %} to render compiled templates 
Reviewed by Loic Bistuer and Tim Graham.
 2013-08-29 10:22:24 +03:00
Loic Bistuer
da800be6dd Fixed #20986 -- Enabled SelectDateWidget to use custom months 
Reviewed by Trac alias MarkusH.
 2013-08-28 16:39:26 +03:00
Warren Smith
dd3a883894 Fixed #20693 -- Add timezone support to built-in time filter. 
Modified django.utils.dateformat module, moving __init__() method and
timezone-related format methods from DateFormat class to TimeFormat
base class. Modified timezone-related format methods to return an
empty string when timezone is inappropriate for input value.
 2013-08-26 16:15:53 -05:00
Ramiro Morales
b785a80d19 Added further fixes, tests for #19949/f33db5a09a. 
Thanks Susan Tan. Refs #19949.
 2013-08-26 08:47:24 -03:00
Ramiro Morales
51a9a5980a Made coverage ignore files without associated source code. 
This only affests reporting not data collection and allows coverage.py
to succesfully finish the generation of e.g. the HTML report.

Cases of code whose execution data is collected during the run phase but
for which no associated source code files can be found at the reporting
phase include tests with egg files and Python module files created at
test execution-time.
 2013-08-25 22:29:43 -03:00
Ramiro Morales
72712755c4 Ignore coverage HTML report output dir in tests. 
Added it to the list of dirs ignored by tests/runtests.py.
 2013-08-25 19:09:03 -03:00
Christopher Medrela
32a962bdbf Fixed #20814 -- Improved model field accessor clash error messages 
Thanks shai for the suggestion.
 2013-08-24 18:00:23 -04:00
Claude Paroz
f4e9804567 Fixed #20961 -- Fixed HttpResponse default empty content 
Thanks epandurski at gmail.com for the report.
 2013-08-24 18:10:12 +02:00
SusanTan
f33db5a09a Fixed 19949 -- Cached template loader now caches TemplateDoesNotExist 
Thanks @timgraham and @jdunck for the code reviews and Kronuz for bug
report and initial patch.
 2013-08-24 09:19:55 -04:00
Alex Gaynor
8363406dad Removed usage of u"" string prefix, which doesn't work on python3.2 2013-08-23 04:56:37 -07:00
Andrew Godwin
5569b0b92f Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/oracle/base.py
	django/db/backends/postgresql_psycopg2/base.py
	django/db/models/signals.py
	tests/queries/tests.py
 2013-08-23 12:36:53 +01:00
Andrew Godwin
ac45f9c9c5 Fix some small errors in the tests 2013-08-23 12:07:43 +01:00
Tim Graham
b0ce6fe656 Fixed #20922 -- Allowed customizing the serializer used by contrib.sessions 
Added settings.SESSION_SERIALIZER which is the import path of a serializer
to use for sessions.

Thanks apollo13, carljm, shaib, akaariai, charettes, and dstufft for reviews.
 2013-08-22 13:58:26 -04:00
Lukasz Balcerzak
9d1987d767 Fixed #19303 -- Fixed ModelAdmin.formfield_overrides on fields with choices 2013-08-22 11:50:52 -04:00
Rainer Koirikivi
65cf82bd08 Fixed #20934 -- Avoided NoReverseMatch in ModelAdmin.changelist_view 
The view tried to display links to a ModelAdmin's change_view, which
resulted in NoReverseMatches if get_urls was overridden to remove the
corresponding url.
 2013-08-22 10:08:54 -04:00
Anssi Kääriäinen
6af05e7a0f Fixed model.__eq__ and __hash__ for no pk value cases 
The __eq__ method now considers two instances without primary key value
equal only when they have same id(). The __hash__ method raises
TypeError for no primary key case.

Fixed #18864, fixed #18250

Thanks to Tim Graham for docs review.
 2013-08-22 17:24:07 +03:00
Anssi Kääriäinen
8d65b6082c Fixed #20955 -- select_related regression 
In cases where the same connection (from model A to model B along the
same field) was needed multiple times in a select_related query, the
join setup code mistakenly reused an existing join.
 2013-08-22 10:51:07 +03:00
Tim Graham
3f416f6379 Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c7364a11f6 Switched mail tests to SimpleTestCase. 2013-08-21 22:32:04 +01:00
Ramiro Morales
8e571e5f8f Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
244e2b71f5 Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 22:32:04 +01:00
Ramiro Morales
c5fbd16362 Import test case classes from their public API module. 2013-08-21 22:32:04 +01:00
Ramiro Morales
01223840f3 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-21 22:32:04 +01:00
Florian Apolloner
839940f27f Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-21 22:32:04 +01:00
Anssi Kääriäinen
3a8ae71ab5 Fixed invalid testing fixture 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
f5552571dc Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
ced3e6b17d Fixed test failure caused by different NULL ordering between backends 2013-08-21 22:31:50 +01:00
Anssi Kääriäinen
cea7204504 Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-21 22:30:46 +01:00
Anssi Kääriäinen
b773ef8fa0 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-21 22:30:45 +01:00
Simon Charette
63378163f9 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-21 22:30:45 +01:00
Simon Charette
77478d84ad Fixed an aggregation test failure on MySQL. 2013-08-21 22:30:02 +01:00
Andrew Godwin
2e7f45a372 Change autodetector changes API to be just one method 2013-08-21 22:25:15 +01:00
Tim Graham
f7290581fe Fixed a regression with get_or_create and virtual fields. 
refs #20429

Thanks Simon Charette for the report and review.
 2013-08-21 08:30:21 -04:00
Ramiro Morales
a5cf5da50d Switched mail tests to SimpleTestCase. 2013-08-21 07:48:16 -03:00
Ramiro Morales
ececbe77ff Fixed #12422 -- Don't override global email charset behavior for utf-8. 
Thanks simonb for the report, Claude Paroz and Susan Tan for their work
on a fix.
 2013-08-21 07:44:20 -03:00
Anssi Kääriäinen
b065aeb17f Fixed #20946 -- model inheritance + m2m failure 
Cleaned up the internal implementation of m2m fields by removing
related.py _get_fk_val(). The _get_fk_val() was doing the wrong thing
if asked for the foreign key value on foreign key to parent model's
primary key when child model had different primary key field.
 2013-08-21 08:32:19 +03:00
Ramiro Morales
deebb1a977 Import test case classes from their public API module. 2013-08-20 22:23:41 -03:00
Ramiro Morales
f9d1d5dc13 Fixed #18967 -- Don't base64-encode message/rfc822 attachments. 
Thanks Michael Farrell for the report and his work on the fix.
 2013-08-20 22:17:26 -03:00
Florian Apolloner
96346ed5ad Fixed #20933 -- Allowed loaddata to load fixtures from relative paths. 2013-08-20 21:25:57 +02:00
Anssi Kääriäinen
86f4459f9e Fixed invalid testing fixture 2013-08-20 17:48:02 +03:00
Anssi Kääriäinen
1ed77e7782 Fixed #20820 -- Model inheritance + m2m fixture loading regression 
Tests by Tim Graham, report from jeroen.pulles@redslider.net.
 2013-08-20 16:54:05 +03:00
Anssi Kääriäinen
8dc76c4b91 Fixed test failure caused by different NULL ordering between backends 2013-08-20 11:33:44 +03:00
Anssi Kääriäinen
905409855c Fixed #14056 -- Made sure LEFT JOIN aren't trimmed in ORDER BY 
If LEFT JOINs are required for correct results, then trimming the join
can lead to incorrect results. Consider case:

TBL A: ID | TBL B: ID  A_ID
       1           1   1
       2
Now A.order_by('b__a') did use a join to B, and B's a_id column. This
was seen to contain the same value as A's id, and so the join was
trimmed. But this wasn't correct as the join is LEFT JOIN, and for row
A.id = 2 the B.a_id column is NULL.
 2013-08-20 10:55:00 +03:00
Anssi Kääriäinen
b53ed351b3 Fixed #14043 -- Made sure nullable o2o delete works as expected 
There was an old complaint about nullable one-to-one field cascading
even when the o2o field was saved to None value before the deletion.
Added an test to verify this doesn't happen.

Also some PEP 8 cleanup.
 2013-08-20 09:50:37 +03:00
Simon Charette
e55ca60903 Fixed #20943 -- Weakly reference senders when caching their associated receivers 2013-08-20 01:53:58 -04:00
Simon Charette
fdbf492946 Fixed an aggregation test failure on MySQL. 2013-08-19 20:39:30 -04:00
Andrew Godwin
b6a957f0ba Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	docs/ref/django-admin.txt
 2013-08-19 18:30:48 +01:00
Rainer Koirikivi
3c03004050 Fixed #20640 -- Avoided NoReverseMatch in get_deleted_objects 
The default delete action resulted in a NoReverseMatch if it were to
list any Model with a ModelAdmin with `get_urls` overridden to remove
the change url.  Catching the error and not displaying the link in that
case, as was already done for models with no registered admins.

Thanks Keryn Knight for the report.
 2013-08-19 12:01:33 -04:00
Anssi Kääriäinen
58c6d0209d Fixed #12807 -- EmptyResultSet ORed condition 
The EmptyResultSet wasn't treated correctly so the end results was
incorrect, too. The bug had been already fixed in master so only tests
added.
 2013-08-19 16:24:45 +03:00
Anssi Kääriäinen
7bc57a6d71 Fixed #11881 -- removed junk from aggregation subqueries 
There were clauses that weren't needed in the subqueries. These were
ORDER BY, SELECT FOR UPDATE and related selections.
 2013-08-19 16:15:09 +03:00
Anssi Kääriäinen
7737305a4f Fixed #12886 -- aggregation over sliced queryset 2013-08-19 16:00:17 +03:00
Andrew Godwin
52edc16086 Add more stringent M2M tests and fix the bug they exposed 2013-08-19 13:50:26 +01:00
Anssi Kääriäinen
7d28bed13b PEP 8 cleanup 2013-08-19 14:16:10 +03:00
Anssi Kääriäinen
630b9df42f Fixed #12567 -- Incorrect SQL in model inheritance case 
An isnull lookup produced incorrect SQL. This was already fixed
earlier, so only tests added.
 2013-08-19 14:10:03 +03:00
Anssi Kääriäinen
3844089edc Fixed #20777 -- Admin proxy model deletion regression 
Added proxy_models tests by Harm Geerts <github@geertswei.nl>.
 2013-08-19 09:51:41 +03:00
Anssi Kääriäinen
4668c142dc Made Model.__eq__ consider proxy models equivalent 
Fixed #11892, fixed #16458, fixed #14492.
 2013-08-19 09:51:28 +03:00
Alex Gaynor
aa01c99f55 Merge pull request #1479 from nickbruun/ticket_20924 
Proxy __len__ and __contains__ for LazyObject
 2013-08-18 09:41:43 -07:00
Claude Paroz
165f44aaaa Combine consecutive with statements 
Python 2.7 allows to combine several 'with' instructions.
 2013-08-16 20:12:10 +02:00
Alasdair Nicol
22c6497f99 Fixed #20895 -- Made check management command warn if a BooleanField does not have a default value 
Thanks to Collin Anderson for the suggestion and Tim Graham for
reviewing the patch.
 2013-08-15 19:47:26 -04:00
Nick Bruun
b9ef96e73c Regression test and patch for ticket #20924. 2013-08-15 20:59:58 +02:00
Jonathan Slenders
ff410565bf Fixed #20709 -- Allowed {% widthratio %} to accept an "as" parameter. 
Thanks clay.evil@ for the suggestion.
 2013-08-14 12:40:19 -04:00
Florian Apolloner
4e50e40654 Removed unneeded conditional_escapes from the testsuite. 2013-08-13 22:22:46 +02:00
Andrew Godwin
157604a87f Oracle schema backend, passes most tests and is pretty complete. 2013-08-13 20:54:57 +01:00
Matt Johnson
907ef9d0d1 Fixed #20555 -- Make subwidget id attribute available 
In `BoundField.__iter__`, the widget's id attribute is now passed to
each subwidget. A new id_for_label property was added to ChoiceInput.
 2013-08-13 13:23:05 -04:00
Jacob Kaplan-Moss
cbe6d5568f Apply autoescaping to AdminURLFieldWidget. 
This is a security fix; disclosure to follow shortly.
 2013-08-13 11:06:41 -05:00
Anssi Kääriäinen
09a5f5aabe Fixed test failure on MySQL 
The fix for #20874 caused a MySQL specific failure.
 2013-08-13 15:37:08 +03:00
Loic Bistuer
163a34ce4b Fixed #20883 -- Made model inheritance find parent links in abstract parents 2013-08-13 15:14:11 +03:00
Anssi Kääriäinen
dcdc579d16 Fixed #20874 -- bump_prefix() in nested subqueries 
Also made some cleanup to build_filter() code by introducing submethods
solve_lookup_type() and prepare_lookup_value().
 2013-08-13 14:11:52 +03:00
Ramiro Morales
6c12cd15e9 Unlocalize line numbers and ids in debug 500 view. 
While using USE_L10N, line numbers and IDs were printed as comma (or
locale equivalent) separated values.

Thanks Kronuz for the report and intial patch.

Fixes #20861.
 2013-08-12 21:59:27 -03:00
Tim Graham
71b5617c24 Fixed #17778 -- Prevented class attributes on context from resolving as template variables. 
Thanks KyleMac for the report, regebro for the patch, and Aymeric for the test.
 2013-08-12 12:41:39 -04:00
Mel Collins
6bdb3b1135 Fixed #13518 -- Added FILE_UPLOAD_DIRECTORY_PERMISSIONS setting 
This setting does for new directories what FILE_UPLOAD_PERMISSIONS
does for new files.

Thanks jacob@ for the suggestion.
 2013-08-12 07:15:59 -04:00
Andrew Godwin
b61b634628 Fix weird planning issues when already fully migrated. 2013-08-11 15:28:51 +01:00
Andrew Godwin
ae19315b4d Support index_together during model creation 2013-08-11 14:23:31 +01:00
Ramiro Morales
22af1394c6 Expand testing of Test LiveServerTestCase static files serving. 2013-08-10 16:32:07 -03:00
Ramiro Morales
cb92e3391b Test that django.views.static.serve() generates 404 status codes. 
Also, change tests to be based on SimpleTestCase.
 2013-08-10 16:00:22 -03:00
Bojan Mihelac
0cac4fbf69 Fixed #18356 -- Gave the test client signals.template_rendered call a unique dispatch_uid 
This prevents the test client context from being lost when the client
is used in a nested fashion.
 2013-08-09 12:22:42 -04:00
Andrew Godwin
588b523233 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/options.py
 2013-08-09 14:37:37 +01:00
Andrew Godwin
de64c4d6e9 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/core/management/commands/flush.py
	django/core/management/commands/syncdb.py
	django/db/models/loading.py
	docs/internals/deprecation.txt
	docs/ref/django-admin.txt
	docs/releases/1.7.txt
 2013-08-09 14:17:30 +01:00
Tim Graham
9c711ee3a6 Fixed test failures on Python 3 - refs #12288 2013-08-09 09:12:15 -04:00
Tim Graham
b575d690bb Fixed test failures introduced by #12288 2013-08-09 08:34:37 -04:00
SusanTan
2ac89012d8 Fixed #12288 -- Added unique validation for INSTALLED_APPS 2013-08-09 08:08:34 -04:00
Marc Tamlyn
1c4a9bd9ad Revert change to the default Form.clean() 
This means it doesn't break for people who are doing
`cleaned_data = super(FooForm, self).clean()`.
 2013-08-08 14:27:48 +01:00
Marc Tamlyn
fb1dd6b13a Form.clean() does not need to return cleaned_data. 
If it does, that will be used as the cleaned_data. The default
implementation has been changed to match this change.
 2013-08-08 14:05:55 +01:00
Anssi Kääriäinen
c7739e30b2 Fixed #17424 -- annotate() + exclude() bug 
The bug was already fixed by 01b9c3d519,
so only tests added.

At the same time promote_joins()'s uncoditional flag is gone, it isn't
needed for anything any more.
 2013-08-07 12:53:33 +03:00
Collin Anderson
d53e574676 Fixed #20865 -- Fixed raw_id_fields to work with callable limit_choices_to. 2013-08-06 13:41:52 -04:00
Alex Cucu
1c64a0f29e Fixed #19918 -- Modified select_for_update to run on the write database. 2013-08-06 09:50:59 -04:00
Tai Lee
1280675834 Fixed #15511 -- Allow optional fields on `MultiValueField subclasses. 
The `MultiValueField` class gets a new ``require_all_fields`` argument that
defaults to ``True``. If set to ``False``, individual fields can be made
optional, and a new ``incomplete`` validation error will be raised if any
required fields have empty values.

The ``incomplete`` error message can be defined on a `MultiValueField`
subclass or on each individual field. Skip duplicate errors.
 2013-08-06 08:50:47 -04:00
Marc Tamlyn
0b771fcf29 Merge pull request #1441 from loic/ticket16986 
Fixed #16986 -- Model.clean() can report errors on individual fields.
 2013-08-06 02:10:45 -07:00
Anssi Kääriäinen
263b873599 Fixed ordering related test failure 
Also PEP8 + python_2_unicode_compatible cleanup done.
 2013-08-06 10:07:52 +03:00
Loic Bistuer
71093d22b6 Fixed #16986 -- Model.clean() can report errors on individual fields. 
This commit provides the tests for this issue but the actual problem was solved
by the ValidationError refactor in f34cfec and ee77d4b.

Refs #20199.
 2013-08-06 02:26:51 +07:00
Tim Graham
04489c7dbf Fixed #17667 -- Prevented app loading from skipping nonexistent apps after the first try 
Thanks ea2100@ for the report and akaariai for the patch.
 2013-08-05 13:34:35 -04:00
Tim Heap
75c87e2d38 Fixed #20850 -- Added MultiWidget.needs_multipart_form 2013-08-05 10:02:28 -04:00
Julien Phalip
f067887a4f Fixed some intermittent Selenium test failures. 2013-08-04 22:03:53 -07:00
Julien Phalip
995ffbb2a6 Added some Selenium tests for the admin raw id widget. 2013-08-04 16:08:45 -07:00
Loic Bistuer
ebb3e50243 Introduced ModelAdmin.get_fields() and refactored get_fieldsets() to use it. 
Refs #18681.

This also starts the deprecation of ModelAdmin.declared_fieldsets
 2013-08-04 09:14:18 -04:00
Curtis Maloney
07876cf02b Deprecated SortedDict (replaced with collections.OrderedDict) 
Thanks Loic Bistuer for the review.
 2013-08-04 07:09:39 -04:00
Aymeric Augustin
784377544e Fixed #20822 -- Set content type of default error pages to 'text/html'. 
Thanks Jimmy Song for the patch.
 2013-08-04 11:04:37 +02:00
Loic Bistuer
0bcdcc7eb9 Added ModelAdmin.get_search_fields. 2013-08-03 20:02:43 -04:00
Petr Dlouhý
1b47508ac8 Fixed LogEntry.get_admin_url() for non-existent models. 
Regression introduced by [369b6fa]; refs #18169.
 2013-08-02 12:51:10 -04:00
Loic Bistuer
a0ed2f9260 Fixed #18681 -- GenericInlineModelAdmin.get_formset() no longer bypasses get_fieldsets(). 
Refs 23e1b59 which already fixed this issue for ModelAdmin and InlineModelAdmin.
 2013-08-02 10:41:29 -04:00
Aleksandra Sendecka
893d8de6f5 Fixed #18777 -- Localized form fields with as_text/as_hidden 
Thanks croldan for the report.
 2013-08-02 08:41:54 -04:00
Tim Graham
aa830009de Fixed #17519 -- Fixed missing SQL constraints to proxy models. 
Thanks thibaultj for the report, jenh for the patch,
and charettes for the tests.
 2013-08-02 07:41:56 -04:00
Alex Couper
1123f45511 Fixed #20649 -- Allowed blank field display to be defined in the initial list of choices. 2013-07-31 14:12:03 -04:00
Will Hardy
1c3c21b38d Fixed #19987 -- Disabled host validation when DEBUG=True. 
The documentation promises that host validation is disabled when
DEBUG=True, that all hostnames are accepted. Domains not compliant with
RFC 1034/1035 were however being validated, this validation has now been
removed when DEBUG=True.

Additionally, when DEBUG=False a more detailed SuspiciousOperation
exception message is provided when host validation fails because the
hostname is not RFC 1034/1035 compliant.
 2013-07-31 10:38:59 -04:00
Loic Bistuer
acd1d439fd Fixed #20826 -- Moved Manager.raw() and Manager._insert() to the QuerySet class. 2013-07-31 09:54:00 -04:00
Florian Hahn
e888a9b30d Fixed #15624 -- Made sure aggregations are present in SELECT 2013-07-31 16:27:58 +03:00
Anssi Kääriäinen
e01b5a5823 Fixed #11521 -- usage of field.attname in .update() 
Fixed already by previous patch, only test added.
 2013-07-31 16:02:36 +03:00
Anssi Kääriäinen
c21e86ab9e Added field.attname to Options.name_map 
The change also removed allow_explicit_fk from sql/query.py.
 2013-07-31 16:02:36 +03:00
Tai Lee
31e6d58d46 Fixed #20348 -- Consistently handle Promise objects in model fields. 
All Promise objects were passed to force_text() deep in ORM query code.
Not only does this make it difficult or impossible for developers to
prevent or alter this behaviour, but it is also wrong for non-text
fields.

This commit changes `Field.get_prep_value()` from a no-op to one that
resolved Promise objects. All subclasses now call super() method first
to ensure that they have a real value to work with.
 2013-07-31 15:54:17 +03:00
SusanTan
ccf8f1e18f Added a test for AdminSite.app_index_template; refs #8498. 2013-07-31 06:59:15 -04:00
Tai Lee
4c6ffcf721 Fixed #20819 -- Return 404 instead of 500 error when `staticfiles` view is used in production. 2013-07-31 18:58:50 +10:00
Baptiste Mispelon
3c45fb8589 Fixed #10491 -- Allowed passing lazy objects to HttpResponseRedirect. 
Thanks liangent for the report.
 2013-07-30 13:39:44 -04:00
Tim Graham
8550df869b Removed part of a test that doesn't work on Jenkins; refs #19877. 2013-07-30 11:59:04 -04:00
Tim Graham
dffda2ba4e Fixed a test that depended on the DB backend; refs #19877. Thanks Loic. 2013-07-30 11:30:20 -04:00
Jose L. Patino
7b57e575c9 Fixed #19877 -- Added --no-color option to BaseCommand to avoid using output styles. 2013-07-30 09:26:18 -04:00
Andrew Godwin
fddc5957c5 Implement allow_migrate for migration operations 2013-07-30 12:34:31 +01:00
Andrew Godwin
12e9804d16 Rename allow_syncdb to allow_migrate 2013-07-30 12:08:59 +01:00
Julien Phalip
e351dbf6ee Fixed #19082 -- Enabled admin field pre-population for existing objects. 
Thanks to msaelices and d1ffuz0r for the initial patch and tests.
 2013-07-30 00:21:08 -07:00
Claude Paroz
5c1143910e Removed most of absolute_import imports 
Should be unneeded with Python 2.7 and up.
Added some unicode_literals along the way.
 2013-07-29 20:28:13 +02:00
Claude Paroz
e4937b6dde Add utf-8 preamble to admin_scripts temp settings file 
As some settings are copied from current user settings, we cannot
be sure the characters are pure ascii.
 2013-07-29 17:10:23 +02:00
Claude Paroz
fdd7a355bf Deprecated django.utils.importlib 
This was a shim for pre-Python 2.7 support.
 2013-07-29 17:10:22 +02:00
Justin Michalicek
ac09558760 Fixed #20817 -- Added html_message parameter to django.core.mail.send_mail() 2013-07-29 09:53:47 -04:00
Przemek Lewandowski
382c53d7d8 Fixed #18213 -- Allowed empty fixtures (emit a warning rather than raising an exception). 2013-07-29 08:03:51 -04:00
Florian Apolloner
b70c371fc1 Simplified smart_urlquote and added some basic tests. 2013-07-28 10:05:39 +02:00
Julien Phalip
4e0ff35146 Fixed #11195 -- Added CSS classes to the changelist cells to allow style customizations. Thanks to akaihola, Ramiro Morales and vdboor for their work on the patch. 2013-07-27 19:50:02 -07:00
Julien Phalip
47c755327b Fixed a number of minor misspellings. 2013-07-27 18:46:03 -07:00
Florian Hahn
ca39c0a6be Fixed #18404 -- Added test for AppStaticStorage with non ascii path 
(bug was already fixed in #19357)
 2013-07-27 20:18:32 -04:00
Tim Graham
8676318d2d Fixed #20805 -- Removed an extra colon beside checkboxes in the admin. 
Thanks CollinAnderson for the report.
 2013-07-26 14:45:38 -04:00
Tim Graham
2a979d2a7b Updated contrib.admin to use Email/URLInputs; refs #16630 2013-07-26 07:22:30 -04:00
Anssi Kääriäinen
7cca8d56d2 Fixed related model lookup regression 
It has been possible to use models of wrong type in related field
lookups. For example pigs__in=[a_duck] has worked. Changes to
ForeignObject broke that.

It might be a good idea to restrict the model types usable in lookups.
This should be done intentionally, not accidentally and without any
consideration for deprecation path.
 2013-07-26 13:13:27 +03:00
Loic Bistuer
31fadc1202 Fixed #20625 -- Chainable Manager/QuerySet methods. 
Additionally this patch solves the orthogonal problem that specialized
`QuerySet` like `ValuesQuerySet` didn't inherit from the current `QuerySet`
type. This wasn't an issue until now because we didn't officially support
custom `QuerySet` but it became necessary with the introduction of this new
feature.

Thanks aaugustin, akaariai, carljm, charettes, mjtamlyn, shaib and timgraham
for the reviews.
 2013-07-26 12:41:27 +03:00
Carl Meyer
8f3aefdec3 Fixed handling of template loader tests. 
Previously, the CachedLoaderTests were never run at all.
 2013-07-25 17:19:17 -05:00
Andrew Godwin
a758c9c186 Add test for creating M2Ms 2013-07-25 16:36:58 +01:00
Anssi Kääriäinen
92476e880c Fixed ._meta.pk_index() virtual field failure 2013-07-25 16:25:23 +03:00
Andrew Godwin
00276e0414 Add tests for the migrate command and fix a bug they exposed 2013-07-25 13:52:35 +01:00
Anssi Kääriäinen
b2314d9e1e Fixed #19941 -- Modified runtests.py to make running the tests easier. 
1. Automatically use tests/../django as the Django version.
2. If settings aren't provided through --settings or DJANGO_SETTINGS_MODULE)
   then use test_sqlite.
 2013-07-24 07:33:03 -04:00
Tim Graham
31c13a99bb Fixed #14300 -- Fixed initial SQL location if models is a package. 
Thanks al_the_x for the report and fheinz for the draft patch.
 2013-07-24 06:56:33 -04:00
Tim Graham
65e03a424e Fixed #10284 -- ModelFormSet.save(commit=False) no longer deletes objects 
Thanks laureline.guerin@ and Wedg.
 2013-07-23 16:21:23 -04:00
Anssi Kääriäinen
c00a8525c6 Fixed #20788 -- exclude() generated subquery failure 
"Fixed" by adding a test case, the original problem was already fixed
by earlier ORM changes. Thanks to david@judicata.com for the report
and test case.
 2013-07-23 13:40:50 +03:00
Anssi Kääriäinen
4bd5554721 Fixed #20782 -- qs.values().aggregate() failure 
In the combination of .values().aggregate() the aggregate_select_mask
didn't include the aggregates added. This resulted in bogus query.

Thanks to Trac alias debanshuk for report.
 2013-07-23 11:38:38 +03:00
Andrew Godwin
162f7b938f Make migrate command recognise prefixes and 'zero'. 2013-07-22 19:43:58 +01:00
Andrew Godwin
52eb19b545 Make multi-app-cache tests work again 2013-07-22 19:36:03 +01:00
Andrew Godwin
03ec3219a0 Merge branch 'master' into schema-alteration 
Conflicts:
	django/db/backends/mysql/introspection.py
	django/db/backends/oracle/creation.py
	django/db/backends/postgresql_psycopg2/creation.py
	django/db/models/base.py
	django/db/models/loading.py
 2013-07-22 19:04:25 +01:00
Claude Paroz
02b0106d43 Fixed #20781 -- Fixed _has_changed regression with MultiValueField 
Thanks Tim Graham for the report.
 2013-07-22 09:06:07 +02:00
Thomas Sorrel
bb145e2c47 Fixed #13629 -- Added CSS classes to the <body> tag of some admin templates to allow style customizations per app or per model. 2013-07-21 20:17:14 +00:00
Claude Paroz
11b7b9ad00 Fixed an email validation regression 
Thanks Vincent Wagelaar for the report.
 2013-07-21 21:11:32 +02:00
Karen Tracey
3aad955ea8 Fixed #13696 -- ensured inline pk field is rendered 2013-07-21 13:06:11 -04:00
Simon Charette
415a36947c Fixed #20765 -- Set small values of step using exponential notation. 
Browsers parse small factors of 10 as 0 under decimal notation.

Thanks to Trac alias matklad for the report and Claude Paroz for the review.
 2013-07-19 23:31:15 -04:00
Claude Paroz
6d52844b9b Fixed #18551 -- Enabled skipIfDBFeature/skipUnlessDBFeature to decorate a class 
Thanks Tim Graham for the review and improved patch.
 2013-07-19 20:30:14 +02:00
Matt Deacalion Stevens
a269ea4fe0 Fixed #14656 -- Added Atom1Feed published element 
Some feed aggregators make use of the `published` element as well as
the `updated` element (within the Atom standard -- http://bit.ly/2YySb).

The standard allows for these two elements to be present in the same
entry. `Atom1Feed` had implemented the `updated` element which was
incorrectly taking the date from `pubdate`.
 2013-07-19 10:38:34 -04:00
Loic Bistuer
2fc6c9472c Fixed #20767 -- Fixed ModelAdmin.preserve_filters for namespaced URLs. 
Thanks Collin Anderson for the report.
 2013-07-18 18:18:30 -04:00
Curtis Maloney
a3e7d73ed7 Allowed Context.push to behave as a context mananger. 
Thanks Loic Bistuer for the review.
 2013-07-17 13:32:32 -04:00
Tim Graham
2333c9662b Fixed #14007 -- Added model discovery in models module without the need to specify app_label. 
Thanks mark@ and Aramgutang for work on the patch.
 2013-07-16 19:32:30 -04:00
Tim Graham
2456ffa42c Fixed #20746 -- Removed Python 2.6 specific code/docs 2013-07-14 13:02:55 -04:00
Tim Graham
d9c580306c Fixed #20681 -- Prevented teardown_databases from attempting to tear down aliases 
Thanks simonpercivall.
 2013-07-13 17:46:05 -04:00
Tim Graham
9b471a8fe3 Fixed a deprecation warning in a selenium test. 2013-07-13 13:15:28 -04:00
Claude Paroz
73f86f4441 Isolated host validation tests in own test case 2013-07-13 10:16:52 +02:00
Tim Graham
f2cb94f1c0 Fixed #20740 -- GenericIPAddressField should pass protocol to formfield() 
Thanks Jeff250.
 2013-07-12 16:05:14 -04:00
Karol Sikora
6272d2f155 Fixed #20429 -- Added QuerySet.update_or_create 
Thanks tunixman for the suggestion and Loic Bistuer for the review.
 2013-07-12 08:26:35 -04:00
Joeri Bekker
66f3d57b79 Fixed #19031 -- Added a warning when using override_settings with 'DATABASES' 2013-07-12 07:10:18 -04:00
Claude Paroz
59ebe39812 Fixed #17471 -- Added smtplib.SMTP_SSL connection option for SMTP backend 
Thanks dj.facebook at gmail.com for the report and initial patch
and Areski Belaid and senko for improvements.
 2013-07-11 22:00:08 +02:00
Benjamin Kagia
b0953dc913 Fixed #13721 -- Added UploadedFile.content_type_extra. 
Thanks Waldemar Kornewald and mvschaik for work on the patch.
 2013-07-11 09:11:59 -04:00
Tim Graham
4d92a0bd86 Fixed #19196 -- Added test/requirements 2013-07-10 09:24:05 -04:00
Loic Bistuer
7e6d852bac Fixed #20663 -- "Today" and "now" admin shortcuts. 
Changed the shortcuts next to date and time intput widgets
to account for the current timezone.

Refs #7717, #14253 and #18768.
 2013-07-09 23:04:33 +02:00
Aymeric Augustin
404870ee1f Fixed #20724 -- Test failure on SQLite. 
This test failure happened if the connection's NAME was set to a file
system path, and its TEST_NAME wasn't.

Thanks Claude for the report.
 2013-07-09 21:41:30 +02:00
Aymeric Augustin
38bc581bc0 Avoided transaction.set_autocommit in tests. 
It doesn't work as one might expect on a certain database backend where
autocommits_when_autocommit_is_off = True. That backend happens to be
popular for running tests.
 2013-07-09 21:41:30 +02:00
Claude Paroz
57f190ed3b Only import gis test apps for geo-enabled DBs 2013-07-09 15:58:56 +02:00
Claude Paroz
bd563f0f57 Trusted test skipping about gis tests running or not 
With the new test discovery system, gis tests are discovered as
other tests. They should be properly skipped now when dependencies
are missing. So let's stop special casing their inclusion.
 2013-07-09 15:17:26 +02:00
Tim Graham
da79ccca1d Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows. 
Thanks Patryk Zawadzki.
 2013-07-08 08:33:40 -04:00
Alex Gaynor
626fa28878 Fixed #13813 -- Comparison of DatabaseWrappers doesn't raise errors. 
Patch from Lukasz Balcerzak.
 2013-07-08 09:35:08 +10:00
Tim Graham
2cbd579efe Fixed #19940 -- Made test.runner.setup_databases properly handle aliases for default db. 
Thanks simonpercivall.
 2013-07-04 19:58:58 -04:00
Andrew Godwin
3a6580e485 Make get_constraints return columns in order 2013-07-02 18:02:20 +01:00
Andrew Godwin
61ff46cf8b Add AlterIndexTogether operation 2013-07-02 18:02:01 +01:00
Andrew Godwin
2202e3f7d3 Fix index_together test 2013-07-02 12:06:26 +01:00
Andrew Godwin
9ef715d256 Fix some bad test running under PostgreSQL 2013-07-02 11:51:38 +01:00
Andrew Godwin
6a8cfbf07b Support for index_together in schema backends 2013-07-02 11:43:44 +01:00
Andrew Godwin
3b20af3e96 Autodetection of unique_together changes 2013-07-02 11:25:18 +01:00
Andrew Godwin
67dcea711e Add unique_together altering operation 2013-07-02 11:19:02 +01:00
Andrew Godwin
310cdf492d Fix M2M interaction with transactions 2013-07-02 11:08:16 +01:00
Andrew Godwin
b1e0ec06f0 Merge branch 'master' into schema-alteration 2013-07-02 10:49:53 +01:00
Aymeric Augustin
e021b87c00 Fixed a few more imports of django.utils.unittest. 
One import per line please! Refs #20680.
 2013-07-01 22:49:07 +02:00
Aymeric Augustin
909433fa50 Removed tests for django.utils.unittest vs. unittest. 
Silenced warnings caused by the deprecation of django.utils.unittest.

Thanks Preston Timmons and Carl Meyer for their advice.

Fixed #20680.
 2013-07-01 21:49:11 +02:00
Tim Graham
a521d10322 Fixed a couple form/formset deprecation warnings in tests. 2013-07-01 09:36:31 -04:00
Tim Graham
a6a905c619 Updated tests for deprecation of Option.get_(add|change|delete)_permission. 
refs #20642.
 2013-07-01 09:19:55 -04:00
Aymeric Augustin
cfcf4b3605 Stopped using django.utils.unittest in the test suite. 
Refs #20680.
 2013-07-01 14:29:33 +02:00
Aymeric Augustin
2c40681805 Stopped calling loaddata with commit=False. 
This was a stealth option only used by the tests, and it isn't useful
any more since `atomic` provides nested transactions.
 2013-06-30 14:17:33 +02:00
Aymeric Augustin
acd7b34aaf Advanced deprecation warnings for Django 1.7. 2013-06-29 18:49:37 +02:00
Aymeric Augustin
8b9b8d3bda Removed compatibility code for streaming responses. 
This code provided a deprecation path for old-style streaming responses.

Refs #6527, #7581.
 2013-06-29 18:49:36 +02:00
Claude Paroz
59b0c48ce2 Fixed #18592 -- Prevented crash when accessing MySQL _last_executed 
Thanks reames at asymmetricventures.com for the report.
 2013-06-29 18:44:41 +02:00
Claude Paroz
7fbab3ebaf Do not allow FileSystemStorage.delete to receive an empty name 
Refs #20660.
 2013-06-29 18:09:31 +02:00
Claude Paroz
ea3fe78a9d Fixed #20660 -- Do not try to delete an unset FieldFile 
Thanks stanislas.guerra at gmail.com for the report and
Baptiste Mispelon for the review.
 2013-06-29 18:08:39 +02:00
Claude Paroz
6118d6d1c9 More import removals 
Following the series of commits removing deprecated features in
Django 1.7, here are some more unneeded imports removed and other
minor cleanups.
 2013-06-29 11:58:36 +02:00
Ramiro Morales
7379d9acea Removed insert(), value_for_insert() SortedDict methods deprecated in Django 1.5. 2013-06-28 22:38:13 -03:00
Ramiro Morales
6ba69c8456 Removed 'depth' .select_related() argument as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
c196564132 Removed custom profile model functionality as per deprecation TL. 2013-06-28 21:48:16 -03:00
Ramiro Morales
4f6be9a0c4 Removed warnings level handling code as per deprecation TL. 2013-06-28 21:48:15 -03:00
Andrew Godwin
7a47ba6f6a Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/backends/__init__.py
	django/db/models/fields/related.py
	tests/field_deconstruction/tests.py
 2013-06-28 17:32:57 +01:00
Andrew Godwin
48dd1e63bb Ported over Field.deconstruct() from my schema alteration branch. 
This is to help other ongoing branches which would benefit from
this functionality.
 2013-06-28 17:27:52 +01:00
Shai Berger
d097417025 Support 'pyformat' style parameters in raw queries, Refs #10070 
Add support for Oracle, fix an issue with the repr of RawQuerySet,
add tests and documentations. Also added a 'supports_paramstyle_pyformat'
database feature, True by default, False for SQLite.

Thanks Donald Stufft for review of documentation.
 2013-06-28 06:59:10 +03:00
Tim Graham
7c0b72a826 Prevented running some admin_view tests twice. 2013-06-27 20:13:42 -04:00
Tim Graham
534ced5aad Fixed #20664 -- Fixed a bug with raw_id_fields on Python 3. 
Thanks jefftriplett for the report.
 2013-06-27 19:39:20 -04:00
Aymeric Augustin
c1284c3d3c Fixed #20571 -- Added an API to control connection.needs_rollback. 
This is useful:
- to force a rollback on the exit of an atomic block without having to
  raise and catch an exception;
- to prevent a rollback after handling an exception manually.
 2013-06-27 22:19:54 +02:00
Andrew Godwin
99b467f272 Add related_query_name to ForeignKey/M2M. Refs #20244 2013-06-27 14:44:21 +01:00
Loic Bistuer
a9ea7d8c70 Fixed #20462 - Replaced the str() cast introduced in 273dc55 by force_text() 2013-06-26 21:30:58 +07:00
Andrew Clark
273dc550a4 Fixed #20462 -- null/non-string regex lookups are now consistent 
Thanks to noirbizarre for the report and initial patch.
 2013-06-26 08:13:26 -04:00
Baptiste Mispelon
ec371ace00 Fixed #20650 -- Fixed {% filter %} incorrectly accepting 'escape' as argument 
Thanks to grzesiof for the report and to loic84 and Alex Gaynor
for the review.
 2013-06-25 20:28:35 +02:00
Javier Mansilla
f819bef3dc Fixed #19773 - Added admin/popup_response.html template. 
Thanks jimmylam@ for the suggestion.
 2013-06-25 11:20:41 -04:00
Russell Keith-Magee
0346563939 Fixed #20653 -- Renamed checksetup management command. 
This is to allow future compatibility with work that is ongoing in the 2013 GSoC.
 2013-06-25 09:37:54 +08:00
Ramiro Morales
1559f84d8b Fixed #20311 -- Make sure makemessages doesn't create duplicate Plural-Forms .po file headers. 
Thanks naktinis for the report and initial patch.
 2013-06-22 18:45:41 -03:00
Andrew Godwin
e2d7e83256 Autodetect ForeignKeys and add dependencies/split on circulars 2013-06-22 17:15:51 +01:00
Gilberto Gonçalves
680b512fc1 Fixed #20587 -- Made convert_values handle None values 2013-06-22 14:05:12 +01:00
Gilberto Gonçalves
ef37b23050 Fixed #18872 -- Added prefix to FormMixin 
Thanks @ibustama for the initial patch and dragonsnaker for opening the
report.
 2013-06-22 12:12:43 +01:00
Claude Paroz
ef79582e86 Fixed 17478 -- Allowed queryset overriding in BaseModelFormSet init 
BaseModelFormSet.forms is now a cached property instead of being
populated in the __init__ method. This behaviour also matches an
example in the documentation.
Thanks Thomasz Swiderski for the report and Simon Charette for the
review.
 2013-06-22 09:29:37 +02:00
Oliver Beattie
552a90b444 Fixed #20290 -- Allow override_settings to be nested 
Refactored override_settings to store the underlying settings._wrapped
value seen at runtime, not instantiation time.
 2013-06-21 16:57:47 +02:00
Andrew Godwin
cca40703df Prompt about renames rather than doing them automatically 2013-06-21 15:32:15 +01:00
Andrew Godwin
92a10f5552 Autodetect field renames. HAHAHA. AHAHAHAHA. YES. 2013-06-20 16:02:43 +01:00
Simon Charette
04628e2016 Fixed #20630 -- Removed maxlength attribute from NumberInput. 
This attribute is only allowed on inputs of type "text", "search", "url",
"tel", "email", or "password".

Thanks to yoyoma for the report and @bmispelon for the review.
 2013-06-20 10:59:41 -04:00
Andrew Godwin
47e4b86ddf Autodetect field alters 2013-06-20 15:19:30 +01:00
Andrew Godwin
80bdf68d6b Add AlterField and RenameField operations 2013-06-20 15:12:59 +01:00
Andrew Godwin
6f667999e1 Add operation that renames tables 2013-06-20 14:54:11 +01:00
Russell Keith-Magee
18e79f1425 Fixed #20486 -- Ensure that file_move_safe raises an error if the destination already exists. 
Thanks to kux for the report, and Russ Webber for the patch.
 2013-06-20 18:55:27 +08:00
Andrew Godwin
ab5cbae9b7 First stab at some migration creation commands 2013-06-19 15:36:22 +01:00
Andrew Godwin
2ae8a8a77d Fix test running with new apps stuff/migrate actually running migrations 2013-06-19 15:36:02 +01:00
Andrew Godwin
9daf81b94e Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/loading.py
 2013-06-19 12:05:23 +01:00
Aymeric Augustin
d9a43545be Merge pull request #1282 from loic/ticket6903 
Fixed failing test on MySQL since c86a9b6
 2013-06-19 03:04:04 -07:00
Loic Bistuer
7d0c3b9b26 Fixed MySQL failing test introduced by c86a9b6 2013-06-19 16:13:43 +07:00
Florian Hahn
2f35c6f10f Fixed #14930 -- values_list() failure on qs ordered by extra column 
Thanks lsaffre for the report and simon29, vicould, and Florian Hahn
for the patch.

Some changes done by committer.
 2013-06-18 23:56:51 +03:00
Aymeric Augustin
9da9b3eb04 Merge pull request #1281 from loic/ticket6903 
Fixed #6903 - Preserved admin changelist filters.
 2013-06-18 13:07:28 -07:00
Loic Bistuer
c86a9b6398 Fixed #6903 - Preserve admin changelist filters after saving or deleting an object 2013-06-19 02:41:36 +07:00
Erik Romijn
aeb1389442 Fixed #20079 -- Improve security of password reset tokens 2013-06-18 20:02:00 +02:00
Baptiste Mispelon
3128f3d38d Fixed #20618 -- Fixed regression in BoundField.label_tag. 2013-06-18 17:49:53 +02:00
Loic Bistuer
ee77d4b253 Fixed #20199 -- Allow ModelForm fields to override error_messages from model fields 2013-06-18 08:01:17 -04:00
Loic Bistuer
f34cfec0fa Refactored ValidationError to allow persisting error params and error codes as the exception bubbles up 2013-06-18 08:01:17 -04:00
Baptiste Mispelon
1b7634a0d0 Fixed #20464 -- Added a total_error_count method on formsets. 
Thanks to frog32 for the report and to Tim Graham for the review.
 2013-06-16 15:49:30 -04:00
Aymeric Augustin
c3df866619 Fixed #20603 -- Made the test suite faster. 
By avoiding to run syncdb with the full set of test models.

Thanks Anssi for the idea.
 2013-06-14 23:16:15 +02:00
Marc Tamlyn
46789e76c6 Fixed #20548 -- Removed all PendingDeprecationWarnings from django test suite 2013-06-14 15:37:39 +01:00
Anssi Kääriäinen
5459795ef2 Fixed #20289 -- pickling of dynamic models 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
855d1305c5 Added cache to available_apps in cache tests 2013-06-14 17:05:54 +03:00
Anssi Kääriäinen
89bf7a4525 Fixed #20528 -- regression in select_related join promotion 
The join used by select_related was incorrectly INNER when the query
had an ORed filter for nullable join that was trimmed away. Fixed this
by forcing the join type to LOUTER even when a join was trimmed away
in ORed queries.
 2013-06-14 16:29:06 +03:00
Marc Tamlyn
b7bd7087e6 Fixed #15273 -- Extend RedirectView to allow reversal by name. 
Thanks to @DrMeers for the report and @ludwigkraatz for the initial patch.
 2013-06-14 11:59:26 +01:00
Wilfred Hughes
8365ed08b8 Fixed #17076 -- When reversing a URL fails, inform the user which patterns were tried. 2013-06-14 10:26:30 +01:00
Daniel Lindsley
91f317c76d Added a `checksetup` management command for verifying Django compatibility. 2013-06-13 18:39:02 -07:00
Loic Bistuer
9e50833e22 Fixed #20000 -- Allowed ModelForm meta overrides for label, help_text and error_messages 2013-06-13 15:06:25 -04:00
Baptiste Mispelon
dc9c359546 Fixed #20594 -- Add validation to models.SlugField. 
Thanks carbonXT for the report.
 2013-06-13 13:31:57 -04:00
Tim Graham
92c49d6f01 Revert "Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields." 
This reverts commit 64041f0e6e.

lookup.tests.LookupTests.test_regex_non_string fails under Postgres.
We should also try to rewrite the test using an existing model.
 2013-06-11 17:55:19 -04:00
Axel Haustant
64041f0e6e Fixed #20462 - Fixed sqlite regex lookups for null values and non-string fields. 2013-06-11 14:13:40 -04:00
Gabe Jackson
584bd14dcf Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix 
There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.

This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.
 2013-06-10 14:23:15 -04:00
Florian Apolloner
af70dfcf31 Reverted the introduction of shared_models. 
The recent improvements should make shared_models obsolete.

This reverts commit 1059da8de6, reversing
changes made to 4fa7f3cdd9.
 2013-06-10 12:34:47 +02:00
Florian Apolloner
f5d4849cbe Revert "Began implementing a shared set of test models to speed up tests." 
This reverts commit 22b7870e40.
 2013-06-10 12:22:40 +02:00
Aymeric Augustin
dfcce4288a Fixed available_apps for selenium tests. 
Refs #20483.
 2013-06-10 12:11:46 +02:00
Aymeric Augustin
c6e6d4eeb7 Defined available_apps in relevant tests. 
Fixed #20483.
 2013-06-10 11:30:01 +02:00
Aymeric Augustin
7a65c95d42 Refactored file_storage tests to avoid depending on servers tests. 2013-06-10 11:16:15 +02:00
Tim Graham
96c71d423d Added runserver validation to detect if DEBUG=False and ALLOWED_HOSTS is empty. 
Refs #19875.
 2013-06-09 15:08:29 -04:00
Andrew Godwin
91c470def5 Auto-naming for migrations and some writer fixes 2013-06-07 17:56:43 +01:00
Andrew Godwin
cd809619a2 Autodetector tests 2013-06-07 15:49:48 +01:00
Andrew Godwin
c7aa4b5338 Field encoding 2013-06-07 15:36:31 +01:00
Andrew Godwin
4492f06408 A bit of an autodetector and a bit of a writer 2013-06-07 15:28:38 +01:00
Andrew Godwin
3c296382b8 Merge remote-tracking branch 'core/master' into schema-alteration 
Conflicts:
	django/db/models/fields/related.py
 2013-06-07 11:15:34 +01:00
Stephen Burrows
e2518fdf46 Fixed #12337 - Honor ModelForm.Meta.exclude when saving ManyToManyFields. 
Thanks margieroginski for the report.
 2013-06-06 10:01:48 -04:00
Claude Paroz
b67f2ac8e6 Fixed #20502 (again) -- More i18n cache flush in tests 
Thanks Timo Graham for noticing the failures.
 2013-06-06 14:28:58 +02:00
Marc Tamlyn
9ed971f4f1 Merge pull request #1245 from oinopion/list_select_related 
Fixed #19080 -- Fine-grained control over select_related in admin
 2013-06-06 01:27:05 -07:00
Anssi Kääriäinen
31fd64ad8a Fixed #20564 -- Generic relations exclude() regression 
The patch for #19385 caused a regression in certain generic relations
.exclude() filters if a subquery was needed. The fix contains a
refactoring to how Query.split_exclude() and Query.trim_start()
interact.

Thanks to Trac alias nferrari for the report.
 2013-06-06 01:54:46 +03:00
Tomek Paczkowski
0fd9f7c95f Fixed #19080 -- Fine-grained control over select_related in admin 2013-06-05 23:08:00 +02:00
Anssi Kääriäinen
8c5b805ca1 PEP 8 cleanup 2013-06-05 21:18:56 +03:00
Bojan Mihelac
b00c6371af Fixed #17927 -- Added initial values support for BaseGenericInlineFormSet 
Thanks Fak3 for the suggestion.
 2013-06-05 07:59:59 -04:00
Tim Graham
a35ed20241 Fixed #18924 -- Made test.Client.logout send user_logged_out signal. 
Thanks awsum for the suggestion and Pavel Ponomarev and
Florian Hahn for the patch.
 2013-06-04 12:39:09 -04:00
Ramiro Morales
e71b63e280 Added i18n-related URL mapper test for a mailing list report. 2013-06-04 11:19:27 -03:00
Aymeric Augustin
51aa000378 Fixed #20485 -- Refactored loaddata for speed. 
Thanks Anssi for reporting this performance bottleneck.
 2013-06-02 20:39:45 +02:00
Tim Graham
61524b09cf Fixed #18388 - Added InlineModelAdmin.get_max_num hook. 
Thanks d.willy.c.c@ for the suggestion and Melevir and Areski Belaid for work
on the patch.
 2013-06-01 18:20:54 -04:00
Tim Graham
fffb55860e Changed assertEquals -> assertEqual. 2013-06-01 06:31:25 -04:00
Claude Paroz
de66b56790 Fixed #18481 -- Wrapped request.FILES read error in UnreadablePostError 
Thanks KyleMac for the report, André Cruz for the initial patch and
Hiroki Kiyohara for the tests.
 2013-06-01 10:26:46 +02:00
Anssi Kääriäinen
369b6fab25 Fixed #18169 -- NoReverseMatch not silenced if from block.super 2013-06-01 00:59:04 +03:00
Anssi Kääriäinen
84909377f2 Fixed #18785 -- Added Test join trimming regression 
The regression was caused by patch to ticket #15316 and was fixed by a
patch to #10790.
 2013-06-01 00:28:44 +03:00
Chris Wilson
fa7cb4ef3c Fixed #20404 -- Added a keys() method to ContextList. 
It's useful to be able to list all the (flattened) keys of a
ContextList, to help you figure out why the variable that's supposed
to be there is not.

No .values() or .items() added as the definition for those aren't clear.

The patch is Chris Wilson's patch from pull request 1065 with some
modifications by committer.
 2013-06-01 00:04:06 +03:00
Loic Bistuer
23e1b59cf2 Fixed #18681 -- BaseModelAdmin.get_form and InlineModelAdmin.get_formset no longer bypass get_fieldsets 
Thanks msopacua for the report.
 2013-05-31 12:48:51 -04:00
Anssi Kääriäinen
728d3fe1ba Fixed #16436 -- Oracle defer_regress test failure 
Oracle doesn't like grouping by TextField, so use CharFields instead in
models.
 2013-05-31 10:11:15 +03:00
Claude Paroz
9d06c6ccc9 Fixed #20502 -- Flushed i18n caches for a defaultfilter test 
Thanks Chris Wilson for the report and initial patch.
 2013-05-30 20:23:14 +02:00
Tim Graham
36aecb12b8 Fixed #19425 - Added InlineModelAdmin.get_extra hook. 
Thanks dave@ for the suggestion and Rohan Jain for the patch.
 2013-05-30 13:48:10 -04:00
Andrew Godwin
e6f7f4533c Add an Executor for end-to-end running 2013-05-30 18:08:58 +01:00
Andrew Godwin
7f9a0b7061 Fix graph tests 2013-05-30 17:56:53 +01:00
Andrew Godwin
05929ee89b Add the start of some operation tests 2013-05-30 17:55:59 +01:00
Tim Graham
7902fd74f1 Merge pull request #1027 from intgr/debug_no_exc_message 
Clearer explanation when exception has no message
 2013-05-30 09:53:07 -07:00
Tim Graham
5074c75a37 Fixed #16856 - Added a way to clear select_related. 
Thanks Carl for the suggestion and David Cramer for the patch.
 2013-05-30 11:06:05 -04:00
Tim Graham
59235816bd Fixed #20509 - Proper parsing for dumpdata --pks option. 
Thanks weipin for the report and Baptiste Mispelon for the patch.
 2013-05-30 10:19:13 -04:00
Tai Lee
69f7db153d Fixed #16436 -- defer + annotate + select_related crash 
Correctly calculate the ``aggregate_start`` offset from loaded fields,
if any are deferred, instead of ``self.query.select`` which includes all
fields on the model.

Also made some PEP 8 fixes.
 2013-05-30 08:46:31 +03:00
Anssi Kääriäinen
bb80d2976b Made an app-cache test not dependent on all models in defer_regress 2013-05-30 08:46:31 +03:00
Simon Charette
dcd915fcab Fixed a failure on Python 3 introduced by 5939864616. 
Refs #15653.
 2013-05-29 15:38:52 -04:00
Andrew Godwin
52d2a8b311 Add test for new __ne__ method on Promise. 2013-05-29 17:52:17 +01:00
Andrew Godwin
d0ecefc2c9 Start adding operations that work and tests for them 2013-05-29 17:47:10 +01:00
Tim Graham
d727518ad6 Fixed #20331 -- Allowed admin actions to serve StreamingHttpResponses 
Thanks Edwin.
 2013-05-29 11:25:42 -04:00
Claude Paroz
8010289ea2 Fixed #15697 -- Made sqlindexes aware of auto-created tables 
Thanks mbertheau for the report and Ash Christopher for the
initial patch.
 2013-05-29 15:50:26 +02:00
Tim Graham
5939864616 Fixed #15653 - Error in admin pagination tag. 
Thanks jcumbo@ for the report and adamzap
and nott for the patch.
 2013-05-29 09:23:08 -04:00
Tim Graham
7426e72302 Fixed #20250 - Added a regression test for negated Q + annotate 
Thanks nott.
 2013-05-29 08:49:42 -04:00
Tim Graham
ded95ccdce Fixed #20484 -- Added model validation for GenericIPAddressField 
GenericIPAddressField must not allow blank for NOT NULL fields

Thanks Erik Romijn.
 2013-05-28 15:12:47 -04:00
Tim Graham
a2967d5204 Fixed #20242 - Added a regression test for prefetch_related. 
Issue was fixed by removal of chunked reads from
QuerySet iteration in 70679243d1.

Thanks Simeon Visser for the patch.
 2013-05-28 13:37:44 -04:00
Tim Graham
d321d1acf0 Fixed #20228 - Documented unique_for_date and exclude behavior. 
Thanks Deepak Thukral for the patch.
 2013-05-28 10:04:07 -04:00
Anssi Kääriäinen
33dd8f5442 Fixed random aggregation_regress test_more_more_more() failure 
The cause was assuming that an unordered queryset returns the values
always in the same order.
 2013-05-28 08:55:04 +03:00
Tim Graham
0268aba96b Fixed #20182 - admin lookup should treat 0 as False for __isnull 
Thanks Benjie Chen.
 2013-05-27 13:29:53 -04:00
Tim Graham
d194714c0a Fixed #11603 - Added django.test.SimpleTestCase.assertFormsetError 
Thank-you Martin Green for the patch.
 2013-05-27 12:25:35 -04:00
Shai Berger
1e29428db2 Fixed #20013 -- A test for sqlall fails under Oracle 2013-05-27 18:34:31 +03:00
Tim Graham
90af278203 Fixed #16137 - Removed kwargs requirement for QuerySet.get_or_create 
Thanks wilfred@, poirier, and charettes for work
on the patch.
 2013-05-27 10:01:14 -04:00
Tim Graham
6f8627dd7f Fixed #17582 - Added message to DoesNotExist exceptions. 
Thanks simon@ for the suggestion and JordanPowell
for the initial patch.
 2013-05-27 07:57:06 -04:00
Anssi Kääriäinen
d467e11785 Fixed #20507 -- SubqueryConstraint alias relabeling 
The SubqueryConstraint defined relabeled_clone(), but that was never
called. Instead there is now clone() and relabel_aliases() methods for
SubqueryConstraint.

A related problem was that SubqueryConstraint didn't correctly use
quote_name_unless_alias() of the outer query. This resulted in failures
when running under PostgreSQL.
 2013-05-27 12:25:29 +03:00
Ramiro Morales
0fa8d43e74 Replaced and...or... constructs with PEP 308 conditional expressions. 2013-05-26 23:47:50 -03:00
Preston Holmes
d228c1192e Fixed #19866 -- Added security logger and return 400 for SuspiciousOperation. 
SuspiciousOperations have been differentiated into subclasses, and
are now logged to a 'django.security.*' logger. SuspiciousOperations
that reach django.core.handlers.base.BaseHandler will now return a 400
instead of a 500.

Thanks to tiwoc for the report, and Carl Meyer and Donald Stufft
for review.
 2013-05-25 16:27:34 -07:00
Shai Berger
36d47f72e3 Fixed get_or_create...test_savepoint_rollback test for Python3 
The test was always skipped on Python3 because string literals are unicode
 2013-05-26 01:53:24 +03:00
Shai Berger
cf159e5c93 Fix get_or_create test failure under Oracle 
Test expected that when given invalid utf-8, the backend should raise
a DatabaseError, but the Oracle backend raises a UnicodeDecodeError.
 2013-05-26 01:39:34 +03:00
Andrew Jesaitis
31f6421b13 Fixed #19938 -- Consumed iterator only once in paginator's Page 
Thanks Joshua Fialkoff for the report.
 2013-05-25 16:27:26 +02:00
Baptiste Mispelon
2ee447fb5f Fixed #20296 -- Allowed SafeData and EscapeData to be lazy 2013-05-25 16:06:44 +02:00
Claude Paroz
be0bab1bb8 Fixed #11725 -- Made possible to create widget label tag without "for" 
Thanks Denis Martinez for the report and initial patch, and
Sergey Kolosov for bringing the patch up to date.
 2013-05-25 15:31:07 +02:00
Claude Paroz
f940e564e4 Fixed #20099 -- Eased subclassing of BrokenLinkEmailsMiddleware 
Thanks Ram Rachum for the report and the initial patch, and Simon
Charette for the review.
 2013-05-25 12:10:53 +02:00
Vlastimil Zíma
6de81d65f4 Fixed #14825 -- LocaleMiddleware keeps language 
* LocaleMiddleware stores language into session if it is not present there.
 2013-05-25 10:52:54 +02:00
Claude Paroz
7e95d7a930 Fixed a regression in router initialization 
Regression was introduced in 6a6bb168b. Thanks Bas Peschier for the
report.
 2013-05-24 20:48:02 +02:00
Luke Plant
4fd94969d8 Fixed #19607 - prefetch_related crash 
Thanks to av@rdf.ru and flarno11@yahoo.de for the report.
 2013-05-24 11:10:48 +01:00
Gavin Wahl
48424adaba Fixed #17648 -- Add for_concrete_model to GenericForeignKey. 
Allows a `GenericForeignKey` to reference proxy models. The default
for `for_concrete_model` is `True` to keep backwards compatibility.

Also added the analog `for_concrete_model` kwarg to
`generic_inlineformset_factory` to provide an API at the form level.
 2013-05-23 19:03:14 -04:00
Donald Stufft
8dda8a5ecc Removed noise from pre_syncdb signal tests 
Only make assertions that actually test the functionality of the
change and not unrelated pieces.
 2013-05-23 15:58:08 -04:00
Claude Paroz
499a745ae1 Fixed #20474 -- Proxied and deprecated django.db.backend 2013-05-23 15:19:12 +02:00
Claude Paroz
b664cb818d Fixed #19237 (again) - Made strip_tags consistent between Python versions 2013-05-23 14:01:27 +02:00
Ramiro Morales
8c2fd050f8 Made fix for #9321 less buggy and more effective. 
Don't try to be smart about building a good-looking help string
because it evaluates translations too early, simply use the same old
strategy as before. Thanks Donald Stufft for the report.

Also, actually fix the case reported by the OP by special-casing
CheckboxSelectMultiple.

Added tests.

Refs #9321.
 2013-05-23 07:49:29 -03:00
Donald Stufft
3de1288042 Fixed #11398 - Added a pre_syncdb signal 2013-05-23 01:09:22 -04:00
Russell Keith-Magee
11b06532f7 Merge pull request #1198 from KrzysiekJ/http-patch-method 
Fixed #20478 – Added support for HTTP PATCH method in generic views.
 2013-05-22 17:19:43 -07:00
Claude Paroz
51998dffe7 Removed check for 0.15 version of gettext tools 
gettext 0.15 has been released in July 2006.
 2013-05-22 18:21:33 +02:00
Claude Paroz
dc51ec8bc2 Fixed #19237 -- Used HTML parser to strip tags 
The regex method used until now for the strip_tags utility is fast,
but subject to flaws and security issues. Consensus and good
practice lead use to use a slower but safer method.
 2013-05-22 17:34:02 +02:00
Krzysztof Jurewicz
ee8b810b97 Fixed #20478 – Added support for HTTP PATCH method in generic views. 2013-05-22 14:48:11 +02:00
Aymeric Augustin
0e51d8eb66 Fixed #20463 -- Made get_or_create more robust. 
When an exception other than IntegrityError was raised, get_or_create
could fail and leave the database connection in an unusable state.

Thanks UloPe for the report.
 2013-05-22 10:56:06 +02:00
Marc Tamlyn
adeec00979 Merge pull request #246 from dekkers/ticket_18709 
Fixed #18709 -- Check if initial_value is a callable
 2013-05-22 00:45:07 -07:00
Anssi Kääriäinen
904084611d Fixed #19895 -- Second iterator over invalid qs raises errors 
The fix was already in the patch for #18702, so only test added for
ticket #19895.
 2013-05-22 08:30:41 +03:00
Jeroen Dekkers
d0788c2770 Fixed #18709 -- Check if initial_value is a callable 
In _get_changed_data, check if initial_value is a callable and call it
if it is.
 2013-05-22 01:05:22 +02:00
Anssi Kääriäinen
70679243d1 Fixed #18702 -- Removed chunked reads from QuerySet iteration 2013-05-21 19:51:59 +03:00
Selwin Ong
ea9a0857d4 Fixed #19326 -- Added first() and last() methods to QuerySet 2013-05-21 18:52:28 +03:00
Mathijs de Bruin
61a8de6f4f Fixed #6412 -- More details if a template file cannot be loaded 
Report more details about template files in loader postmortem.
 2013-05-21 16:59:40 +02:00
Florian Apolloner
800513e7f3 Merge pull request #1194 from ambv/python26_is_fun 
Fixed a Python 2.6 regression (GzipFile can't act as a context manager)
 2013-05-21 04:20:35 -07:00
Wiktor Kolodziej
cec9558fba Fixed #17308 -- Enabled the use of short_description on properties in the admin. 2013-05-21 13:19:18 +02:00
Łukasz Langa
c28281f9d6 Fixed a Python 2.6 regression (GzipFile can't act as a context manager) 2013-05-21 13:18:53 +02:00
Florian Apolloner
b1ac241ddc Fixed test failures from 09f8652765. 2013-05-21 13:03:25 +02:00
Marc Tamlyn
09f8652765 Use assertIsInstance in tests. 
Gives much nicer errors when it fails.
 2013-05-21 10:42:15 +01:00
Aymeric Augustin
18856f866c Merge pull request #1191 from ambv/content_is_bytes 
Fixed #20472: response.content should be bytes on both Python 2 and 3
 2013-05-21 01:26:35 -07:00
Daniel Lindsley
e24d486fbc Fixed #20212 - __reduce__ should only be defined for Py3+. 2013-05-21 00:49:21 -07:00
Łukasz Langa
0594fed9ff Fixed #20472: response.content should be bytes on both Python 2 and 3 2013-05-21 01:28:16 +02:00
Jorge Bastida
888c86dcf3 Fixed #20445 -- Raised original exception after command error 2013-05-20 18:59:37 +02:00
Ryan Kaskel
4280217f31 Fixed #20403 -- Ignore forms marked for deletion when validating max_num. 2013-05-20 12:13:21 -04:00
Anssi Kääriäinen
266c0bb23e Fixed #20278 -- ensured .get() exceptions do not recurse infinitely 
A regression caused by d5b93d3281 made .get() error
reporting recurse infinitely on certain rare conditions. Fixed this by
not trying to print the given lookup kwargs.
 2013-05-20 18:50:40 +03:00
Anssi Kääriäinen
c9a96075fa Fixed #20378 -- regression in GenericRelation on abstract model 
When a GenericRelation was defined on abstract model, queries on childs
of the abstract model didn't work. The problem was in the way fields and
in particular field.rel was copied from models to their children.

The regression was likely caused by #19385. Thanks to Gavin Wahl for
spotting the regression.
 2013-05-20 18:02:10 +03:00
Anssi Kääriäinen
f53059b411 Fixed qs.values() regression when used in subquery 2013-05-20 15:38:47 +03:00
Marc Tamlyn
6d81d5d82e Merge pull request #1181 from aaugustin/better-api-to-disable-atomic-requests 
Changed API to disable ATOMIC_REQUESTS per view.
 2013-05-20 00:26:06 -07:00
Carl Meyer
a7dc13ec23 Fixed #20437 - marked a test-runner test as expected-fail under certain conditions. 2013-05-20 01:56:23 -04:00
Tomasz Jaskowski
022de7e139 Fixed #20449 - Corrected test sensitivity to current working dir. 2013-05-19 23:58:06 -04:00
Alex Gaynor
7c56212c71 Lower the max length for a test field so that it works on MySQL. 2013-05-19 13:58:58 -07:00
Anssi Kääriäinen
190771d003 Fixed fixtures testing failure 
The failure was caused by generating the same warning from two tests.
The second time the same warning was raised it was swallowed by the
"once" simplefilter of warnings.
 2013-05-19 20:53:49 +03:00
Aymeric Augustin
6633eeb886 Changed API to disable ATOMIC_REQUESTS per view. 
A decorator is easier to apply to CBVs. Backwards compatibility isn't an
issue here, except for people running on a recent clone of master.

Fixed a few minor problems in the transactions docs while I was there.
 2013-05-19 19:53:16 +02:00
Preston Holmes
6786920fd8 Fixed #16330 -- added --pks option in dumpdata command 
Thanks to guettli for the initial ticket and patch, with additional work
from mehmetakyuz and Kevin Brolly.
 2013-05-19 09:10:40 -07:00
Bozidar Benko
2d309a7043 Fixed #15961 -- Modified ModelAdmin to allow for custom search methods. 
This adds a get_search_results method that users can override to
provide custom search strategies.

Thanks to Daniele Procida for help with the docs.
 2013-05-19 16:45:00 +02:00
Aymeric Augustin
b06f6c1618 Fixed test failure introduced in 1927bf7c91. 2013-05-19 16:23:14 +02:00
Pablo Recio
65f9e0affd Fixes #18896. Add tests verifying that you can get IntegrityErrors using get_or_create through relations like M2M, and it also adds a note into the documentation warning about it 2013-05-19 14:16:12 +02:00
Aymeric Augustin
d34b1c29e2 Merge pull request #1161 from erikr/urlize-additional-test 
Fixed #19070 -- Additional test for urlize and brackets
 2013-05-19 04:59:15 -07:00
Aymeric Augustin
f7467181aa Merge pull request #1160 from erikr/host-inet-postgres2 
Fixed #11442 -- Postgresql backend casts all inet types to text
 2013-05-19 04:57:10 -07:00
Erik Romijn
1927bf7c91 Fix #19070 -- Additional test for urlize and brackets 2013-05-19 13:39:21 +02:00
Erik Romijn
60d94c2a80 Fixed #11442 -- Postgresql backend casts all inet types to text 2013-05-19 13:28:09 +02:00
Łukasz Langa
660762681c Fixed #20126 -- XViewMiddleware moved to django.contrib.admindocs.middleware 2013-05-19 13:18:35 +02:00
Aymeric Augustin
cb86f707a0 Fixed #12747 -- Made reason phrases customizable. 2013-05-19 13:14:54 +02:00
Aymeric Augustin
3129d19071 Merge pull request #1152 from ambv/issue11915 
Fixed #11915: generic Accept-Language matches country-specific variants
 2013-05-19 04:01:20 -07:00
Andrew Godwin
04e0fc029f Merge pull request #1094 from senko/ticket_11160 
Fixed #11160: Formset non_form_errors returns ErrorList() if is_valid is not called
 2013-05-19 03:56:14 -07:00
Andrew Godwin
7a99d1e167 Merge pull request #1134 from senko/ticket_18990 
Fixed #18990: Loaddata now complains if fixture doesn't exist
 2013-05-19 03:54:29 -07:00
Łukasz Langa
26e3e7ecb5 Fixed #11915: generic Accept-Language matches country-specific variants 2013-05-19 12:50:09 +02:00
Senko Rasic
65c557115f fix warnings imports in fixtures tests 2013-05-19 12:49:03 +02:00
Honza Kral
4ad1eb1c14 Fixed #12674 -- provide a way to override admin validation 
Moved admin validation code to classes and have those be class
attributes to the ModelAdmin classes.
 2013-05-19 12:42:52 +02:00
Andrew Godwin
264f8650e3 ModelState now freezes options and bases 2013-05-19 12:35:17 +02:00
Łukasz Langa
e80636b668 Added TransRealMixin to fix i18n global state pollution in the test suite 2013-05-19 12:05:57 +02:00
Senko Rasic
c44a2c40fe Fixed #18990 -- Loaddata now complains if fixture doesn't exist 
If the fixture doesn't exist, loaddata will output a warning.

The fixture named "initial_data" is exceptional though; if it
doesn't exist, the warning is not emitted. This allows syncdb and
flush management commands to attempt to load it without causing
spurious warnings.

Thanks to Derega, ptone, dirigeant and d1ffuz0r for contributions
to the ticket.
 2013-05-19 11:31:27 +02:00
Senko Rasic
cc3b3ba93a Fixed #18990: Loaddata now complains if fixture doesn't exist 
The fixture named "initial_data" is exceptional though; if it
doesn't exist, the error is not raised. This allows syncdb and
flush management commands to attempt to load it without causing
an error if it doesn't exist.
 2013-05-19 10:56:09 +02:00
Andrea Crotti
5124ab7620 add comment to explain why it's necessary to do an explicit check for 
Python2 and how metaclasses are defined
 2013-05-19 10:36:04 +02:00
Marc Tamlyn
c70ca4879e Merge pull request #1116 from elektrrrus/ticket_20234_20236 
Ticket 20234 20236
 2013-05-19 01:32:41 -07:00
Emil Stenström
7d77e9786a Fixed #20246 -- Added non-breaking spaces between values an units 2013-05-18 23:01:48 +02:00
Tome Cvitan
caf56ad174 Fixed #20440 -- Ensured CharField's max_length/min_length are integers 2013-05-18 22:30:24 +02:00
Karol Sikora
3eba8c7f7f Fixed #20234 and #20236 -- SingleObjectMixin fixes 
Added object on SingleObjectMixin returned context,
some code clanup.
 2013-05-18 21:13:27 +02:00
Aymeric Augustin
0038296135 Fixed ff881aef on Python 3. 2013-05-18 20:48:47 +02:00
Andrew Godwin
38a8cf1cdc Fix state tests a little 2013-05-18 18:30:34 +02:00
Shai Berger
ff881aef53 Fixed #13958 -- problem reporting exception from \r-line-ended file 
Thanks petrvanblokland for reporting and saz for the patch
 2013-05-18 19:30:03 +03:00
Łukasz Langa
f763227c7d Fixes a Python 3.x regression introduced in a19e9d80 2013-05-18 18:06:31 +02:00
Florian Apolloner
dc8814bf7d Merge branch 'master' of github.com:django/django 2013-05-18 17:39:14 +02:00
Łukasz Langa
bd97f7d0cb Fixed #15201: Marked CACHE_MIDDLEWARE_ANONYMOUS_ONLY as deprecated 2013-05-18 17:38:32 +02:00
Florian Apolloner
acd0bb39df Fixed #14894 -- Ensure that activating a translation doesn't run into threading issues. 
Thanks to maxbublis for the report and sergeykolosov for the patch.
 2013-05-18 17:36:31 +02:00
Donald Stufft
398841d6d3 Merge branch 'allow-any-iterable-for-choices' 2013-05-18 11:31:16 -04:00
Donald Stufft
a19e9d80ff Fixed #20430 - Enable iterable of iterables for model choices 
Allows for any iterable, not just lists or tuples, to be used as
the inner item for a list of choices in a model.
 2013-05-18 11:14:05 -04:00
Aymeric Augustin
e73cb6391d Merge pull request #1122 from ambv/issue13285 
Fixed #13285: populate_xheaders breaks caching
 2013-05-18 08:05:48 -07:00
Łukasz Langa
64e11a68f1 Fixed #13285: populate_xheaders breaks caching 2013-05-18 17:03:43 +02:00
Aymeric Augustin
3634948c88 Moved IgnorePendingDeprecationWarningsMixin in django.test.utils. 
This mixin is useful whenever deprecating a large part of Django.
 2013-05-18 16:49:15 +02:00
Olivier Sels
63a9555d57 Fixed #19436 -- Don't log warnings in ensure_csrf_cookie. 2013-05-18 16:17:46 +02:00
Aymeric Augustin
7d050e8e9c Merge pull request #1113 from denibertovic/master 
Fixed #18761 -- Added whitespace stripping to URLField and SlugField.
 2013-05-18 07:11:11 -07:00
Deni Bertovic
186ec21a3d Added stripping of whitespace for SlugField and URLField 2013-05-18 16:06:08 +02:00
Jacob Burch
89955cc35f Fixed #9595 -- Allow non-expiring cache timeouts. 
Also, streamline the use of 0 and None between cache backends.
 2013-05-18 15:39:42 +02:00
Łukasz Langa
92ebb29c53 Fixes #19919: get_language_from_request() disregards "en-us" and "en" languages 
when matching Accept-Language
 2013-05-18 14:37:04 +02:00
Florian Apolloner
16683f29ea Merge pull request #1084 from erikr/master 
Fixed #13546 -- Easier handling of localize field options in ModelForm
 2013-05-18 05:15:15 -07:00
Marc Tamlyn
ef73a8eefd Merge pull request #1083 from Markush2010/ticket20235 
Fixes #20235 - MultipleObjectMixin requires object_list in kwargs
 2013-05-18 05:14:28 -07:00
Erik Romijn
756b81dbd1 Fixed #13546 -- Easier handling of localize field options in ModelForm 2013-05-18 14:13:00 +02:00
Matthew Somerville
1c921cfac3 Fixed #20235 -- Use self.object_list if object_list not present in get_context_data kwargs. 
This is so MultipleObjectMixin can be used in the same way as
SingleObjectMixin.
 2013-05-18 14:10:40 +02:00
Andrew Godwin
7d041b9394 Split up test and make the State classes a bit better. 2013-05-18 13:49:56 +02:00
Andrew Godwin
028bbd15ca Add a deconstruct() method to Fields. 
This allows the field's initial argument to be obtained so it can be
serialised to, and re-created from, a textual format.
 2013-05-18 13:48:57 +02:00
Senko Rasic
493aca453a Fixed #11160 - Ensure full_clean is called from non_form_errors 
Updated FormSet.non_form_errors() to ensure full_clean() has
been called before returning the errors.
 2013-05-18 13:44:27 +02:00