Nick Pope
6e9189c080
Refs #30897 -- Added test for SETTINGS option to Queryset.explain() on PostgreSQL 12+.
2019-10-23 14:07:18 +02:00
Nick Pope
a5c5ae7d91
Refs #28574 -- Used feature flag for PostgreSQL version check.
2019-10-23 14:07:13 +02:00
Dan Moore
bc94e3c1a2
Fixed #29919 -- Fixed RelatedOnlyFieldListFilter crash with reverse relationships.
2019-10-23 10:50:31 +02:00
Dan Moore
f3855a8d2d
Added tests for Field.get_choices()'s limit_choices_to argument.
2019-10-23 10:47:17 +02:00
Sergey Fedoseev
d4e767911f
Added tests for middlewares' checks.
2019-10-23 08:18:02 +02:00
Mariusz Felisiak
2847d2c760
Refs #29926 -- Skipped RemoteTestResultTest.test_add_failing_subtests() on Python 3.8+ and tblib <= 1.4.0.
2019-10-22 15:34:19 +02:00
Alex Aktsipetrov
681f7e2b13
Fixed #20577 -- Deferred filtering of prefetched related querysets.
...
Added internal interface to QuerySet that allows to defer next filter
call till .query is accessed. Used it to optimize prefetch_related().
Thanks Simon Charette for the review.
2019-10-21 13:21:54 +02:00
Ahmet Kucuk
09578f6dfb
Fixed #30827 -- Made batch_size arg of QuerySet.bulk_create() respect DatabaseOperations.bulk_batch_size().
...
Thanks Chetan Khanna for tests.
2019-10-21 11:46:44 +02:00
André Ericson
3120490912
Fixed #30876 -- Moved classproperty() decorator to the django.utils.functional.
2019-10-21 09:57:39 +02:00
André Ericson
31174031f1
Fixed #30841 -- Deprecated using non-boolean values for isnull lookup.
2019-10-21 08:44:20 +02:00
Jon Dufresne
2f72480fbd
Replaced deprecated assertEquals() with assertEqual().
2019-10-21 07:52:17 +02:00
Pavel Savchenko
1711c509fa
Fixed #27391 -- Implemented SimpleTestCase.debug().
...
debug() should bubbled up exceptions if occurring in test, but behave
the same as run() when no exceptions occurred.
2019-10-18 12:22:51 +02:00
Pavel Savchenko
dc8cd2fefd
Refs #27391 -- Added more tests for SimpleTestCase.
2019-10-18 11:11:34 +02:00
Patrick Jenkins
46e74a5256
Fixed #28337 -- Preserved extra headers of requests made with django.test.Client in assertRedirects().
...
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2019-10-18 08:42:51 +02:00
Daniel Musketa
3ca9df51c7
Fixed typo in tests/admin_scripts/tests.py.
2019-10-18 07:50:59 +02:00
Mariusz Felisiak
3a8af298b9
Fixed #30890 -- Added MariaDB support for the relate lookup.
2019-10-18 07:46:31 +02:00
Mariusz Felisiak
bebf61de11
Added gis_tests.utils.mariadb hook.
2019-10-18 07:46:31 +02:00
Hasan Ramezani
ef4beafa2c
Refs #28816 -- Prevented silencing data loss when decreasing CharField.max_length for ArrayField.base_field on PostgreSQL.
2019-10-17 12:50:53 +02:00
sage
6f82df69ef
Refs #12990 -- Moved CheckFieldDefaultMixin to the django.db.models.fields.mixins.
2019-10-17 12:30:29 +02:00
Mariusz Felisiak
1877ec1875
Refs #27910 -- Added __init__.py file for model_enums tests.
2019-10-15 21:27:22 +02:00
Carlton Gibson
1de9a92295
Fixed #30872 -- Improved unknown command message when settings are manually configured.
2019-10-15 13:04:32 +02:00
Mariusz Felisiak
06d34aab7c
Fixed #30870 -- Fixed showing that RunPython operations are irreversible by migrate --plan.
...
Thanks Hasan Ramezani for the initial patch and Kyle Dickerson for the
report.
2019-10-14 11:13:27 +02:00
Mariusz Felisiak
05186c03a3
Isolated migrations.test_commands.MigrateTests.test_migrate_plan.
2019-10-14 08:42:38 +02:00
Simon Charette
2839659b42
Fixed #30868 -- Prevented unnecessary AlterField when renaming a referenced pk.
...
Regression introduced by dcdd219ee1#25817 .
Thanks Carlos E. C. Leite for the report and Mariusz for the bisect.
2019-10-14 08:02:26 +02:00
Etienne Chové
e7cdb0cd7e
Fixed #30014 -- Fixed ModelChoiceField validation when initial value is a model instance.
...
Thanks Carlton Gibson for reviews.
2019-10-11 13:28:09 +02:00
Etienne Chové
a12f9cd95a
Added ModelChoiceField test for validation with to_field_name.
2019-10-11 13:28:06 +02:00
Louise Grandjonc
7d1bf29977
Fixed #30826 -- Fixed crash of many JSONField lookups when one hand side is key transform.
...
Regression in 6c3dfba892
2019-10-11 10:55:22 +02:00
Hasan Ramezani
6a75cea76a
Fixed #30854 -- Fixed QuerySet.select_related() with multiple FilteredRelations.
2019-10-11 08:10:48 +02:00
Flavio Curella
ed112fadc1
Fixed #23755 -- Added support for multiple field names in the no-cache Cache-Control directive to patch_cache_control().
...
https://tools.ietf.org/html/rfc7234#section-5.2.2.2
2019-10-10 19:30:51 +02:00
Flavio Curella
9facc90020
Refs #23755 -- Added tests for patch_cache_control() with no-cache Cache-Control directive.
2019-10-10 12:24:52 +02:00
Viktor Lomakin
ee6b17187f
Fixed #30812 -- Made ConditionalGetMiddleware set ETag only for responses with non-empty content.
2019-10-10 09:51:05 +02:00
Benjy Weinberger
3cd3bebe89
Fixed #30300 -- Allowed migrations to be loaded from directories without __init__.py file.
2019-10-10 08:31:41 +02:00
Simon Charette
26c66f4519
Fixed #30856 -- Combined fast-delete queries by model during cascade deletion.
...
Reduced the number of queries required when performing cascade deletion
for a model referenced multiple time by another one by performing an
union of reference lookups.
2019-10-09 09:49:53 +02:00
Hasan Ramezani
a28d1b38e5
Fixed #30839 -- Fixed Field.__deepcopy__() so forms don't share error messages.
2019-10-08 10:07:05 +02:00
Hasan Ramezani
6452112640
Refs #27914 -- Fixed serialization of nested enum.Enum classes in migrations.
2019-10-03 08:39:30 +02:00
Hasan Ramezani
d3030deaaa
Refs #27914 -- Moved test enum.Enum subclasses outside of WriterTests.test_serialize_enums().
2019-10-03 08:39:30 +02:00
Min ho Kim
103a6f4307
Fixed some typos in comments and docs.
...
Thanks to Mads Jenson for review.
2019-10-02 15:50:46 +02:00
Anatol Ulrich
8ed6788aa4
Fixed #30821 -- Added ExtractIsoWeekYear database function and iso_week_day lookup.
2019-10-02 10:41:34 +02:00
Tanner Stirrat
17595407ca
Fixed #14218 -- Added Paginator.__iter__().
2019-10-02 09:49:31 +02:00
ElizabethU
54ea290e5b
Fixed #30651 -- Made __eq__() methods return NotImplemented for not implemented comparisons.
...
Changed __eq__ to return NotImplemented instead of False if compared to
an object of the same type, as is recommended by the Python data model
reference. Now these models can be compared to ANY (or other objects
with __eq__ overwritten) without returning False automatically.
2019-10-01 17:58:19 +02:00
Mariusz Felisiak
6475e6318c
Refs #30651 -- Added tests for Prefetch.__eq__().
2019-10-01 17:35:55 +02:00
Mariusz Felisiak
0d4b40fe66
Refs #30651 -- Added tests for Message.__eq__().
2019-10-01 17:35:55 +02:00
Ahmet Kucuk
dc890bef5a
Fixed #30510 -- Fixed crash of QuerySet.bulk_create() with mixed-length texts on Oracle.
...
Text with more than 4000 characters must be set to as a CLOB on Oracle
what caused a mixed datatype error (ORA-01790) when shorter text
appeared in the same operation.
2019-10-01 12:38:58 +02:00
Ad Timmering
7b5f8acb9e
Fixed #28690 -- Fixed handling of two-digit years in parse_http_date().
...
Due to RFC7231 ayear that appears to be more than 50 years in the
future are interpreted as representing the past.
2019-09-30 14:42:56 +02:00
Ad Timmering
7cbd25a06e
Refs #28690 -- Added more tests for parse_http_date().
2019-09-30 14:42:51 +02:00
Hasan Ramezani
f0adf3b9b7
Fixed #30774 -- Made serialization in migrations use members names for Enums.
2019-09-30 10:28:05 +02:00
pablo
fa8fe09e4e
Fixed #30802 -- Prevented manifest creation when running collectstatic in dry run mode.
2019-09-27 23:01:41 +02:00
Hasan Ramezani
95a11578ce
Fixed #30798 -- Fixed Meta.ordering validation for pk of related fields.
...
Regression in 440505cb2c
2019-09-27 14:22:31 +02:00
Hasan Ramezani
c7944628a1
Refs #30798 -- Prevented chaining fields from the same related model multiple times in model Meta.ordering.
2019-09-27 13:57:22 +02:00
Pablo García
2fd610eb30
Fixed #30810 -- Fixed WatchmanReloaderTests.test_setting_timeout_from_environment_variable test.
...
client_timeout is an instance attribute.
2019-09-27 08:09:05 +02:00
Oleg Kainov
c574bec092
Fixed #25598 -- Added SCRIPT_NAME prefix to STATIC_URL and MEDIA_URL set to relative paths.
...
Thanks Florian Apolloner for reviews.
Co-authored-by: Joel Dunham <Joel.Dunham@technicalsafetybc.ca>
2019-09-25 19:47:03 +02:00
Mariusz Felisiak
580e644f24
Fixed #30800 -- Fixed migrations crash when altering a field with custom db_type().
...
Regression in 1378d665a1
2019-09-25 12:32:24 +02:00
Maxim Kurnikov
ff5dfbc63a
Fixed false positive tests of Paginator.count property.
2019-09-25 09:15:18 +02:00
Mads Jensen
129583a0d3
Removed some outdated backwards compatibility imports and misleading comments.
...
EmptyResultSet moved in 46509cf13d89581707558550161e53471596fc1a5c53e30607
2019-09-24 15:18:53 +02:00
Mariusz Felisiak
01104368ff
Refs #29444 -- Removed redundant DatabaseFeatures.can_return_multiple_columns_from_insert.
...
Unnecessary since b31e63879e
2019-09-24 10:37:22 +02:00
Simon Charette
37f8f29377
Fixed #30796 -- Prevented select_related() from mutating a queryset on chaining.
...
Thanks Darren Maki for the report.
2019-09-24 09:17:45 +02:00
Hasan Ramezani
f97bbad908
Fixed #13296 -- Fixed ordering by Options.order_with_respect_to after deleting objects.
...
Thanks Simon Meers for the original patch.
2019-09-23 11:20:37 +02:00
Ian Foote
d9881a025c
Fixed #29915 -- Added support for values with hyphens to pattern lookups for UUIDField on backends without UUID datatype.
...
Support hyphens in iexact, contains, icontains, startswith, istartswith,
endswith and iendswith UUIDField filters on backends without UUID
datatype.
2019-09-23 08:24:08 +02:00
Ian Foote
485f65b3c0
Refs #29915 -- Added tests for using pattern lookups with values without hyphens for UUIDField.
2019-09-23 08:24:00 +02:00
Claude Paroz
9d5a487f33
Dropped obsolete mimetype kwarg in csrf test view
2019-09-21 20:46:39 +02:00
Hasan Ramezani
226ebb1729
Fixed #28622 -- Allowed specifying password reset link expiration in seconds and deprecated PASSWORD_RESET_TIMEOUT_DAYS.
2019-09-20 13:52:04 +02:00
James Timmins
0719edcd5f
Fixed #30771 -- Fixed exact lookup against queries with selected columns.
...
Use pre-existing select fields (and thereby GROUP BY fields) from
subquery if they were specified, instead of always defaulting to pk.
Thanks Aur Saraf for the report and Simon Charette for guidance.
2019-09-20 10:42:14 +02:00
Carlton Gibson
bed4a1527b
Refs #27462 -- Added tests of pk_set in m2m_changed signal receivers for repeated add/remove calls.
2019-09-19 11:34:59 +02:00
Daniel Fairhead
5cb3ed187b
Fixed #30772 -- Optimized make_template_fragment_key().
...
Removed usage of urllib.quote(), unnecessary since cbbe60c7fc
2019-09-18 14:53:05 +02:00
Sam Reynolds
6c9778a58e
Fixed #30776 -- Restored max length validation on AuthenticationForm.UsernameField.
...
Regression in 5ceaf14686
2019-09-18 11:37:38 +02:00
Nasir Hussain
faf4b988fe
Fixed #30758 -- Made RangeFields use multiple hidden inputs for initial data.
2019-09-17 12:08:49 +02:00
Nasir Hussain
733dbb21c7
Refs #30758 -- Added more tests for postgres.forms.ranges.
2019-09-17 12:08:16 +02:00
Hasan Ramezani
b9db423d3c
Fixed #29376 -- Allowed hiding "Save and Add Another" button in admin.
2019-09-16 11:37:09 +02:00
Simon Charette
6c3dfba892
Fixed #30769 -- Fixed a crash when filtering against a subquery JSON/HStoreField annotation.
...
This was a regression introduced by 7deeabc7c7
2019-09-16 08:24:40 +02:00
Carlton Gibson
b5db65c4fb
Increased the default PBKDF2 iterations for Django 3.1.
2019-09-12 17:24:01 +02:00
Mariusz Felisiak
c8250ef361
Refs #27338 -- Added tests for altering CharField with primary_key=True to AutoField on PostgreSQL.
...
Fixed in 91b2bc3e70
2019-09-11 13:40:49 +02:00
Mariusz Felisiak
937ddaff55
Refs #30591 -- Fixed too long identifier crash in migrations.test_operations on MySQL 8.0.16+.
2019-09-11 12:20:16 +02:00
Adnan Umer
241deed259
Fixed #30591 -- Fixed recreation of foreign key constraints on MySQL when altering type of referenced unique field.
...
Thanks Mariusz Felisiak for tests and Matthijs Kooijman for
investigation and initial patch.
2019-09-11 11:21:08 +02:00
Mariusz Felisiak
9a2a12d415
Advanced deprecation warnings for Django 3.1.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
0ddb4ebf7b
Refs #14357 -- Made Meta.ordering not affect GROUP BY queries.
...
Per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
d17be88afd
Refs #30037 -- Required the RemoteUserBackend.configure_user() to have request as the first positional argument.
...
Per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
b61ea56789
Refs #28478 -- Removed support for TestCase's allow_database_queries and multi_db per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
f1894bae30
Refs #28606 -- Removed CachedStaticFilesStorage per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
81993b47ea
Refs #29703 -- Removed QuerySetPaginator alias per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
cb2be9d5d5
Refs #29546 -- Removed django.utils.timezone.FixedOffset per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
3d716467a9
Refs #29817 -- Removed settings.FILE_CHARSET per deprecation timeline.
2019-09-10 12:01:00 +02:00
Mariusz Felisiak
b47bb4c4a7
Refs #29598 -- Removed FloatRangeField per deprecation timeline.
2019-09-10 12:01:00 +02:00
Simon Charette
34decdebf1
Fixed #30754 -- Prevented inclusion of aliases in partial index conditions.
...
SQLite doesn't repoint table aliases in partial index conditions on table
rename which breaks the documented table alteration procedure.
Thanks Pēteris Caune for the report.
2019-09-10 10:03:16 +02:00
Vojtech Bocek
b1d37fea8f
Fixed #28107 -- Added DatabaseFeatures.allows_group_by_selected_pks_on_model() to allow enabling optimization for unmanaged models.
2019-09-09 14:04:46 +02:00
Nick Pope
406dba04e1
Fixed #29406 -- Added support for Referrer-Policy header.
...
Thanks to James Bennett for the initial implementation.
2019-09-09 13:35:41 +02:00
Johannes Hoppe
7254f1138d
Refs #29444 -- Allowed returning multiple fields from INSERT statements on PostgreSQL.
...
Thanks Florian Apolloner, Tim Graham, Simon Charette, Nick Pope, and
Mariusz Felisiak for reviews.
2019-09-09 10:51:14 +02:00
Nick Pope
b6251956b6
Fixed #30757 -- Added a system check to ensure max_length fits the longest choice.
2019-09-09 10:28:18 +02:00
Claude Paroz
05d0eca635
Fixed #30426 -- Changed X_FRAME_OPTIONS setting default to DENY.
2019-09-09 08:15:26 +02:00
Hasan Ramezani
6c379f1a18
Fixed #30763 -- Fixed management commands when using required mutually exclusive groups.
2019-09-06 10:55:24 +02:00
Hasan Ramezani
b93d786251
Made SchemaTests.test_alter_db_table_case run only on backends where table names are case-insensitive.
2019-09-05 08:59:48 +02:00
Shai Berger
72ebe85a26
Fixed #27910 -- Added enumeration helpers for use in Field.choices.
...
These classes can serve as a base class for user enums, supporting
translatable human-readable names, or names automatically inferred
from the enum member name.
Additional properties make it easy to access the list of names, values
and display labels.
Thanks to the following for ideas and reviews:
Carlton Gibson, Fran Hrženjak, Ian Foote, Mariusz Felisiak, Shai Berger.
Co-authored-by: Shai Berger <shai@platonix.com>
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-09-04 14:42:49 +02:00
Nasir Hussain
25706d7285
Fixed #29714 -- Allowed using ExceptionReporter subclass with AdminEmailHandler.
2019-09-04 08:40:46 +02:00
Viktor Lomakin
5931d2e96a
Fixed #30691 -- Made migrations autodetector find dependencies for foreign keys altering.
2019-09-03 14:45:49 +02:00
Carlton Gibson
4f61810751
Fixed #30747 -- Renamed is_safe_url() to url_has_allowed_host_and_scheme().
2019-09-02 15:32:23 +02:00
Simon Charette
13a8884a08
Fixed #30739 -- Fixed exclusion of multi-valued lookup against outer rhs.
...
OuterRef right hand sides have to be nested, just like F rhs have to,
during the subquery pushdown split_exclude performs to ensure they are
resolved against the outer query aliases.
2019-09-02 10:52:36 +02:00
Alan Crosswell
03fa846c6a
Fixed #30731 -- Fixed handling trailing groups in simplify_regex().
...
Previously simplify_regex() didn't handle trailing groups for regexp
without the end of string character ("$").
2019-08-30 12:43:39 +02:00
Berker Peksag
400ec5125e
Fixed #18763 -- Added ModelBackend/UserManager.with_perm() methods.
...
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2019-08-29 19:32:12 +02:00
daniel a rios
b5a5c92c72
Fixed #30066 -- Enabled super user creation without email and password
2019-08-29 12:49:16 +02:00
Carlton Gibson
57b9604451
Converted auth test to use subTest().
2019-08-29 12:49:16 +02:00
Matthew Schinckel
4137fc2efc
Fixed #25367 -- Allowed boolean expressions in QuerySet.filter() and exclude().
...
This allows using expressions that have an output_field that is a
BooleanField to be used directly in a queryset filters, or in the
When() clauses of a Case() expression.
Thanks Josh Smeaton, Tim Graham, Simon Charette, Mariusz Felisiak, and
Adam Johnson for reviews.
Co-Authored-By: NyanKiyoshi <hello@vanille.bid>
2019-08-29 09:45:29 +02:00
Mariusz Felisiak
069bee7c12
Used skipUnlessDBFeature instead of checking vendor in test_filtering_on_annotate_that_uses_q.
2019-08-29 09:40:34 +02:00
Mariusz Felisiak
c7f656435c
Added tests for raising an error when passing non-boolean expression to When().
2019-08-29 09:29:46 +02:00
Federico Jaramillo Martínez
8f6860863e
Fixed #30722 -- Added default rate-limiting requests to admin's Select2 widget.
2019-08-27 13:47:36 +02:00
Andrew Brown
691def10a0
Fixed #30727 -- Made Subquery pickle without evaluating their QuerySet.
...
Subquery expression objects, when pickled, were evaluating the QuerySet
objects saved in its _constructor_args attribute.
2019-08-27 13:05:20 +02:00
Hasan Ramezani
03dbdfd9bb
Fixed #29019 -- Added ManyToManyField support to REQUIRED_FIELDS.
2019-08-26 14:48:40 +02:00
Jon Dufresne
5dac63bb84
Refs #27804 -- Used subTest() in utils_tests/test_encoding.py.
2019-08-26 11:58:06 +02:00
Mariusz Felisiak
579909a13f
Refs #30591 -- Fixed introspection of check and unique column constraints on MariaDB.
...
Unnamed unique and check columns constraints have the same name as
a column. Ensure uniqueness by using custom names.
Thanks Adnan Umer for the report.
2019-08-26 09:15:37 +02:00
Tim Gates
6b402b28b3
Fixed typo in tests/prefetch_related/tests.py comment.
2019-08-26 08:14:29 +02:00
Simon Charette
bb9e82f274
Fixed #29955 -- Added support for distance expression to the dwithin lookup.
...
This was missed when adding support to other distance lookups in
refs #25499 .
Thanks Peter Bex for the report and Mariusz for testcases.
2019-08-23 21:28:28 +02:00
Mariusz Felisiak
92c72b68b7
Fixed broken OracleDbshellTests tests after 9386586f31.
2019-08-23 21:25:21 +02:00
Claude Paroz
9386586f31
Replaced subprocess commands by run() wherever possible.
2019-08-23 10:53:36 +02:00
Min ho Kim
7bd9633320
Fixed typos in test names and a comment.
2019-08-23 10:46:43 +02:00
Mariusz Felisiak
521308e575
Fixed #30715 -- Fixed crash of ArrayField lookups on ArrayAgg annotations over AutoField.
2019-08-23 10:43:08 +02:00
Carlton Gibson
5b4c6b58a0
Fixed #30064 -- Added form to validate admin search fields query input.
2019-08-22 14:09:49 +02:00
Mads Jensen
85ac838d9e
Fixed #21039 -- Added AddIndexConcurrently/RemoveIndexConcurrently operations for PostgreSQL.
...
Thanks to Simon Charettes for review.
Co-Authored-By: Daniel Tao <daniel.tao@gmail.com>
2019-08-21 13:10:06 +02:00
Hasan Ramezani
22394bd3a1
Fixed #29667 -- Prohibited whitespaces in path() URLs.
2019-08-20 11:53:10 +02:00
Nick Pope
21e559495b
Fixed #29979 , Refs #17337 -- Extracted AutoField field logic into a mixin and refactored AutoFields.
...
This reduces duplication by allowing AutoField, BigAutoField and
SmallAutoField to inherit from IntegerField, BigIntegerField and
SmallIntegerField respectively. Doing so also allows for enabling the
max_length warning check and minimum/maximum value validation for auto
fields, as well as providing a mixin that can be used for other possible
future auto field types such as a theoretical UUIDAutoField.
2019-08-20 09:22:25 +02:00
Mads Jensen
b10d322c41
Moved migrations.test_operations.OperationTestBase to migrations.test_base.
...
Co-Authored-By: Daniel Tao <daniel.tao@gmail.com>
2019-08-19 16:06:14 +02:00
Hasan Ramezani
85458e94e3
Fixed #29260 -- Skipped an UPDATE when adding a model instance with primary key that has a default.
2019-08-19 13:28:35 +02:00
Claude Paroz
d1c2e6dd04
Refs #28428 -- Made FileField.upload_to support pathlib.Path.
2019-08-18 20:34:58 +02:00
Claude Paroz
af69842dbd
Refs #28428 -- Added test for a callable FileField.upload_to that returns pathlib.Path.
2019-08-18 20:34:54 +02:00
Claude Paroz
0468159763
Refs #30426 -- Changed default SECURE_CONTENT_TYPE_NOSNIFF to True.
2019-08-18 13:17:49 +02:00
Simon Charette
8b4a43dda7
Fixed #29545 -- Fixed using filter lookups againts nested subquery expressions.
...
Made sql.Where resolve lhs of its child nodes. This is necessary to
allow filter lookups against nested subquery expressions to properly
resolve their OuterRefs to Cols.
Thanks Oskar Persson for the simplified test case.
2019-08-17 11:24:35 +02:00
Adnan Umer
6805c0f99f
Fixed #30701 -- Updated patch_vary_headers() to handle an asterisk according to RFC 7231.
2019-08-16 15:25:42 +02:00
Andrew Brown
8a281aa7fe
Fixed #30687 -- Fixed using of OuterRef() expressions in distance lookups.
2019-08-16 06:50:33 +02:00
zeyneloz
8289fc55ff
Refs #30449 -- Made RelatedOnlyFieldListFilter respect ModelAdmin.ordering.
2019-08-15 10:29:10 +02:00
zeyneloz
00035672a4
Fixed #30449 -- Fixed RelatedFieldListFilter/RelatedOnlyFieldListFilter to respect model's Meta.ordering.
...
Regression in 6d4e5feb79
2019-08-15 10:29:05 +02:00
Mariusz Felisiak
1f8382d34d
Fixed #30672 -- Fixed crash of JSONField/HStoreField key transforms on expressions with params.
...
Regression in 4f5b58f5cd3c57fee9972ab074f8dc6895d8f387.
Thanks Florian Apolloner for the report and helping with tests.
2019-08-14 15:25:35 +02:00
Claude Paroz
eed2e740f7
Fixed #30461 -- Made GeoIP2 and GEOIP_PATH setting accept pathlib.Path as library path.
...
Thanks Nikita Krokosh for the initial patch.
2019-08-13 19:44:10 +02:00
Claude Paroz
88c0b907e7
Refs #30461 -- Added django.utils._os.to_path().
2019-08-13 17:17:39 +02:00
Mariusz Felisiak
c19ad2da4b
Fixed #30704 -- Fixed crash of JSONField nested key and index transforms on expressions with params.
...
Thanks Florian Apolloner for the report and helping with tests.
2019-08-13 08:42:17 +02:00
Min ho Kim
4f7328ce8a
Corrected multiple typos.
2019-08-12 12:53:36 +02:00
Min ho Kim
d7673d9eda
Switched to use HTTP_X_FORWARDED_PROTO custom header in tests.
...
This is the conventional name: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Proto
2019-08-12 12:51:26 +02:00
Simon Charette
f7e9db14bb
Refs #25367 -- Added test for Exists() lookup rhs.
2019-08-12 09:39:26 +02:00
Simon Charette
8b3e1b6e9e
Refs #11964 -- Made constraint support check respect required_db_features.
...
This will notably silence the warnings issued when running the test
suite on MySQL.
2019-08-12 06:44:37 +02:00
swatantra
73ac9e3f04
Fixed #30677 -- Improved error message for urlencode() and Client when None is passed as data.
2019-08-11 20:15:23 +02:00
Ngalim Siregar
503f60ff57
Fixed #29008 -- Fixed crash of 404 debug page when URL path converter raises Http404.
2019-08-09 22:48:08 +02:00
Adnan Umer
8d3519071e
Fixed #30673 -- Relaxed system check for db_table collision when database routers are installed by turning the error into a warning.
2019-08-08 21:14:06 +02:00
Min ho Kim
65e86948b8
Corrected several typos in string literals and test names.
2019-08-07 11:23:14 +02:00
Andrew Godwin
052388aba4
Fixed #30676 -- Added --pdb option to test runner.
2019-08-07 08:16:31 +02:00
Adnan Umer
c5075360c5
Fixed #30680 -- Removed obsolete system check for SECURE_BROWSER_XSS_FILTER setting.
2019-08-05 18:44:08 +02:00
Mariusz Felisiak
0e02e496cd
Added tests for using ArrayField's IndexTransform/SliceTransform on expressions with params.
2019-08-05 14:16:25 +02:00
Diederik van der Boor
25f21bd237
Fixed #28393 -- Added helpful error messages for invalid AutoField/FloatField/IntegerField values.
...
Co-authored-by: Diederik van der Boor <vdboor@edoburu.nl>
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2019-08-05 08:41:29 +02:00
aaktsipetrov
4edad1ddf6
Fixed #30668 -- Made QuerySet.filter() raise NotSupportedError if any of source expressions is not filterable.
2019-08-02 15:06:00 +02:00
Nick Pope
194d1dfc18
Fixed #30661 -- Added models.SmallAutoField.
2019-08-02 11:39:01 +02:00
zeyneloz
955b382600
Fixed #30599 -- Prevented ManifestFilesMixin.read_manifest() from silencing errors other than FileNotFoundError.
2019-08-02 08:35:28 +02:00
zeyneloz
246689452d
Added test for handling of non-existent manifest in ManifestFilesMixin.read_manifest().
2019-08-02 08:35:25 +02:00
Mariusz Felisiak
ff111ea5e3
Refs #30664 -- Fixed migrations crash when altering AutoField/BigAutoField with quoted db_column on PostgreSQL.
2019-08-01 12:06:32 +02:00
Ngalim Siregar
e4684220af
Fixed #30664 -- Fixed migrations crash when altering table on SQLite or altering AutoField/BigAutoField on PostgreSQL for models with quoted db_table.
2019-08-01 12:06:32 +02:00
Florian Apolloner
76ed1c49f8
Fixed CVE-2019-14235 -- Fixed potential memory exhaustion in django.utils.encoding.uri_to_iri().
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
Mariusz Felisiak
7deeabc7c7
Fixed CVE-2019-14234 -- Protected JSONField/HStoreField key and index lookups against SQL injection.
...
Thanks to Sage M. Abdullah for the report and initial patch.
Thanks Florian Apolloner for reviews.
2019-08-01 09:24:54 +02:00
Florian Apolloner
4b78420d25
Fixed CVE-2019-14233 -- Prevented excessive HTMLParser recursion in strip_tags() when handling incomplete HTML entities.
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
Florian Apolloner
7f65974f82
Fixed CVE-2019-14232 -- Adjusted regex to avoid backtracking issues when truncating HTML.
...
Thanks to Guido Vranken for initial report.
2019-08-01 09:24:54 +02:00
Étienne Beaulé
5f24e7158e
Fixed #30665 -- Added support for distinct argument to Avg() and Sum().
2019-07-31 11:22:50 +02:00
Étienne Beaulé
cb3c2da128
Moved test for distinct Count() to a separate test case.
2019-07-31 10:41:17 +02:00
Nick Pope
f618e033ac
Fixed #30160 -- Added support for LZMA and XZ templates to startapp/startproject management commands.
2019-07-31 10:02:13 +02:00
Nick Pope
c95d063e77
Refs #30160 -- Simplified and improved tests for django.utils.archive.
...
The file executable should have 0o775 permission not only u=x.
The file no_permissions should have 0o644 u=r.
2019-07-31 09:46:24 +02:00
Hasan Ramezani
e3fc9af4ab
Refs #30593 -- Fixed introspection of check constraints columns on MariaDB.
2019-07-30 16:32:13 +02:00
Hasan Ramezani
b2aad9ad4d
Refs #30593 -- Added _parse_constraint_columns() hook to introspection on MariaDB.
2019-07-30 16:32:13 +02:00
Nick Pope
421c4cd2ee
Removed redundant ArchiveTest.test_extract_method() test.
...
The extract() function has the same code as used in the test method
for Archive.extract().
2019-07-30 11:33:53 +02:00
Nick Pope
0509148c24
Refs #30160 -- Made destination path a required argument of extract().
2019-07-30 11:27:56 +02:00
Jerrod Martin
c7bef16a74
Fixed #30411 -- Improved formatting of text tracebacks in technical 500 templates.
...
Co-Authored-By: Daniel Hahler <git@thequod.de>
2019-07-29 11:09:54 +02:00
Claude Paroz
3c6d32e0b2
Fixed #30552 -- Fixed loss of SRID when calling reverse() on LineString/Point.
...
Thanks Mariusz Felisiak for contributing the Point part.
2019-07-27 20:12:46 +02:00
Jon Dufresne
4122d9d3f1
Refs #28147 -- Fixed setting of OneToOne and Foreign Key fields to None when using attnames.
...
Regression in 519016e5f2
2019-07-27 12:04:56 +02:00
Jon Dufresne
619c9a4f49
Added tests for using attnames to assign OneToOne and Foreign Key fields.
2019-07-27 12:03:45 +02:00
Piotr Domanski
4b4e68a7a6
Fixed #30567 -- Made WSGIHandler pass FileResponse.block_size to wsgi.file_wrapper.
2019-07-26 07:31:51 +02:00
Hasan Ramezani
1853383969
Fixed #27995 -- Added error messages on unsupported operations following union(), intersection(), and difference().
2019-07-25 12:39:55 +02:00
Jon Dufresne
5ed20b3aa3
Fixed #30657 -- Allowed customizing Field's descriptors with a descriptor_class attribute.
...
Allows model fields to override the descriptor class used on the model
instance attribute.
2019-07-25 08:15:20 +02:00
Tom Forbes
fc75694257
Fixed #30647 -- Fixed crash of autoreloader when extra directory cannot be resolved.
2019-07-24 14:08:37 +02:00
Mariusz Felisiak
fed5e19369
Removed unused BaseReloader.watch_file().
...
Unused since its introduction in c8720e7696
2019-07-24 13:32:02 +02:00
Jon Dufresne
d89053585e
Improved error message when index in __getitem__() is invalid.
2019-07-23 20:12:08 +02:00
Tom Forbes
2ff517ccb6
Fixed #30506 -- Fixed crash of autoreloader when path contains null characters.
2019-07-23 10:03:23 +02:00
Min ho Kim
9f11939dd1
Fixed typos in comments and a test name.
2019-07-19 18:24:06 +02:00
Hasan Ramezani
1fc2c70f76
Fixed #30593 -- Added support for check constraints on MariaDB 10.2+.
2019-07-19 11:05:06 +02:00
Mads Jensen
a3417282ac
Fixed #29824 -- Added support for database exclusion constraints on PostgreSQL.
...
Thanks to Nick Pope and Mariusz Felisiak for review.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-07-16 18:04:41 +02:00
Mariusz Felisiak
cf79f92abe
Simplified tests for PostgreSQL constraints.
2019-07-16 16:56:44 +02:00
Yann Sionneau
e47b8293a7
Fixed #30636 -- Fixed options ordering when cloning test database on MySQL.
...
--defaults-file must be given before other options.
2019-07-16 07:25:43 +02:00
Hasan Ramezani
402e6d292f
Fixed #30602 -- Made Extract raise ValueError when using unsupported lookups for DurationField.
2019-07-12 08:08:35 +02:00
Mariusz Felisiak
7a42cfcfdc
Refs #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains F() expressions.
...
Thanks Can Sarıgöl for the report.
Follow up to 8c5f9906c5
2019-07-11 13:40:36 +02:00
Hasan Ramezani
8c5f9906c5
Fixed #30557 -- Fixed crash of ordering by ptr fields when Meta.ordering contains expressions.
2019-07-11 11:24:59 +02:00
can
52545e788d
Fixed #28289 -- Fixed crash of RawSQL annotations on inherited model fields.
2019-07-11 08:27:15 +02:00
atsuo ishimoto
a9c6ab0356
Fixed #30619 -- Made runserver --nothreading use single threaded WSGIServer.
...
Browsers often use multiple connections with Connection: keep-alive.
If --nothreading is specified, the WSGI server cannot accept new
connections until the old connection is closed, causing hangs.
Force Connection: close when --nothreading option is used.
2019-07-10 13:22:17 +02:00
Johannes Hoppe
00d4e6f8b5
Updated Select2 to version 4.0.7.
2019-07-10 12:31:16 +02:00
Hasan Ramezani
ed668796f6
Fixed #30543 -- Fixed checks of ModelAdmin.list_display for fields accessible only via instance.
...
Co-Authored-By: Andrew Simons <andrewsimons@bubblegroup.com>
2019-07-10 10:37:34 +02:00
Mariusz Felisiak
7991111af1
Fixed #30621 -- Fixed crash of __contains lookup for Date/DateTimeRangeField when the right hand side is the same type.
...
Thanks Tilman Koschnick for the report and initial patch.
Thanks Carlton Gibson the review.
Regression in 6b048b364c
2019-07-10 10:33:36 +02:00
Simon Charette
ee6e93ec87
Fixed #30628 -- Adjusted expression identity to differentiate bound fields.
...
Expressions referring to different bound fields should not be
considered equal.
Thanks Julien Enselme for the detailed report.
Regression in bc7e288ca9
2019-07-10 07:46:08 +02:00
can
febe136d4c
Fixed #30397 -- Added app_label/class interpolation for names of indexes and constraints.
2019-07-08 14:57:56 +02:00
Mariusz Felisiak
8233144ca0
Changed django.db.models.indexes.Index imports to django.db.models.Index.
2019-07-08 14:19:46 +02:00
Johannes Hoppe
bc91f27a86
Refs #29444 -- Added support for fetching a returned non-integer insert values on Oracle.
...
This is currently not actively used, since the ORM will ask the
SQL compiler to only return auto fields.
2019-07-08 08:53:08 +02:00
can
53209f7830
Fixed #30613 -- Moved index name validation to system checks.
2019-07-05 09:30:21 +02:00
Chason Chaffin
c238e65e29
Fixed #30596 -- Fixed SplitArrayField.has_changed() for non-string base fields.
...
Thanks to Evgeniy Krysanov for the report and the idea to use to_python.
Thanks to Mariusz Felisiak for the test case.
2019-07-03 13:35:51 +02:00
Benjamin Woodruff
54dcfbc367
Fixed #29744 -- Fixed caching of URLResolver for a default URLconf.
...
get_resolver() for a default URLconf (passing no argument) and for
settings.ROOT_URLCONF should return the same cached object.
2019-07-03 11:37:28 +02:00
Chason Chaffin
55b68de643
Fixed #30608 -- Fixed non-unicode EmailMessage crash when domain name for localhost is non-ASCII.
...
Assisted by felixxm.
2019-07-03 10:49:03 +02:00
Hasan Ramezani
a5308514fb
Fixed #27801 -- Made createsuperuser fall back to environment variables for password and required fields.
2019-07-02 12:55:09 +02:00
Min ho Kim
fbb83fefd4
Fixed typos in comments and docs.
2019-07-02 09:36:17 +02:00
Hasan Ramezani
090ca6512f
Fixed #30604 -- Made mail_admins()/mail_managers() raise ValueError if ADMINS/MANAGERS is set incorrectly.
2019-07-02 07:34:07 +02:00
Hasan Ramezani
5d03f2bc01
Fixed #30595 -- Added error message when no objects found to sql* management commands.
2019-07-01 13:47:54 +02:00
Carlton Gibson
54d0f5e62f
Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_SSL_HEADER if set.
...
An HTTP request would not be redirected to HTTPS when the
SECURE_PROXY_SSL_HEADER and SECURE_SSL_REDIRECT settings were used if
the proxy connected to Django via HTTPS.
HttpRequest.scheme will now always trust the SECURE_PROXY_SSL_HEADER if
set, rather than falling back to the request scheme when the
SECURE_PROXY_SSL_HEADER did not have the secure value.
Thanks to Gavin Wahl for the report and initial patch suggestion, and
Shai Berger for review.
2019-07-01 07:48:04 +02:00
Mariusz Felisiak
8fc8c958a5
Fixed broken selenium tests after 42b9a23267.
2019-06-30 20:35:05 +02:00
Jon Dufresne
42b9a23267
Fixed #30400 -- Improved typography of user facing strings.
...
Thanks Claude Paroz for assistance with translations.
2019-06-28 16:46:18 +02:00
Hasan Ramezani
2b03e8e9e8
Fixed #30584 -- Fixed management command when using subparsers with dest parameter.
2019-06-28 12:51:26 +02:00
can
f03b7bd114
Fixed #28408 -- Added error message when updating with annotated expressions on joined fields.
...
Co-Authored-By: Simon Charette <charette.s@gmail.com>
2019-06-28 07:55:32 +02:00
Nadège Michel
fb54aca540
Added test for serializing child model without inherited fields.
2019-06-27 15:10:22 +02:00
Nadège Michel
895b15771e
Fixed #28725 -- Prevented serializing inherited ManyToManyFields in child model.
2019-06-27 15:10:22 +02:00
Mariusz Felisiak
4305fbe8b1
Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
2019-06-27 15:09:28 +02:00
Shubham Bhagat
26d16c07fd
Fixed #30578 - Made SelectDateWidget respect a custom date format when USE_L10N is disabled.
2019-06-26 11:07:11 +02:00
nsasaki128
a289e79679
Fixed #30594 -- Added 'private' Cache-Control directive to never_cache() decorator.
2019-06-26 09:25:24 +02:00
Tom Forbes
8454f6dea4
Fixed #30588 -- Fixed crash of autoreloader when __main__ module doesn't have __file__ attribute.
2019-06-26 06:44:10 +02:00
Tim Gates
698df6a009
Fixed typos in test comments.
2019-06-25 11:12:45 +02:00
can
325d5d6445
Fixed #30477 -- Made reverse lookup use Field.get_db_prep_value() from the target field.
2019-06-25 10:20:33 +02:00
daniel a rios
76b993a117
Fixed #26431 -- Prevented django.urls.resolve() from returning missing optional parameters.
...
Previous behavior was inconsistent with django.urls.reverse() and
caused that translate_url() created an incorrect URL when an optional
parameter was missing.
2019-06-24 11:47:56 +02:00
daniel a rios
d640c71fa3
Refs #26431 -- Added tests for resolving URL and translate_url() with provided optional parameter.
2019-06-24 11:30:26 +02:00
daniel a rios
b24e763846
Added tests for terminated path with optional arguments in django.urls.reverse().
2019-06-24 11:30:26 +02:00
Mariusz Felisiak
19895e897c
Refs #30451 -- Added asgiref to the tests requirements.
2019-06-24 08:10:23 +02:00
Nadège Michel
87b1ad6e73
Fixed #30421 -- Allowed symmetrical intermediate table for self-referential ManyToManyField.
2019-06-21 15:03:17 +02:00
Mariusz Felisiak
a9179ab032
Fixed typo in BasicExpressionsTests.test_object_update_fk() test.
2019-06-21 12:00:42 +02:00
Mariusz Felisiak
7f19e37135
Refs #30451 -- Added more tests for ASGIRequest and ASGIHandler.
2019-06-20 12:29:58 +02:00
Andrew Godwin
a415ce70be
Fixed #30451 -- Added ASGI handler and coroutine-safety.
...
This adds an ASGI handler, asgi.py file for the default project layout,
a few async utilities and adds async-safety to many parts of Django.
2019-06-20 12:29:43 +02:00
Chris Jerdonek
cce47ff65a
Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object.
2019-06-20 11:48:49 +02:00
Jon Dufresne
b903bb438f
Refs #30485 -- Removed non-representative test that emitted a warning.
...
Previously, when running the Django test suite with warnings enabled,
the following was emitted:
/usr/lib64/python3.7/urllib/parse.py:915: BytesWarning: str() on a bytearray instance
v = quote_via(str(v), safe, encoding, errors)
This occurred due to the bytearray() being passed to
urllib.parse.urlencode() which eventually calls str() on it. The test
does not represent desired real world behavior. Rather than test for and
assert strange unspecified behavior that emits a warning, remove it.
This was also discussed in PR #11374 .
2019-06-19 13:03:52 +02:00
can
2cbd3967e0
Fixed #29834 -- Fixed column mismatch crash with QuerySet.values()/values_list() and order_by() on combined querysets.
2019-06-19 12:11:28 +02:00
Mariusz Felisiak
14d026cccb
Fixed #30572 -- Prevented values()/values_list() on combined queryset from mutating the list of columns in querysets.
2019-06-19 10:44:53 +02:00
Mariusz Felisiak
b08a18f17b
Fixed LiveWidgetTests.test_textarea_trailing_newlines() crash on Chrome 75+.
2019-06-18 11:38:51 +02:00
Min ho Kim
6e8303d49b
Fixed typos in FakePayload docstring and SimplifiedURLTests test name.
2019-06-17 12:38:04 +02:00
Sanyam Khurana
87f5d07eed
Fixed #12952 -- Adjusted admin log change messages to use form labels instead of field names.
2019-06-14 18:20:29 +02:00
Carlton Gibson
1564e42ad3
Refs #30512 , #15042 -- Added local-only address to sanitize_email() tests cases.
...
email.headerregistry.parser.get_mailbox() returns a token with a `token_type` attribute.
If `token_type` is `’invalid-mailbox’` then RFC violations have been detected. Emails with only the local part, and no domain, are correctly parsed but are marked as `’invalid-mailbox’`.
As per #15042 , local-only are supported, to enable sending to addresses on localhost.
sanitize_email() does not currently check `token_type`. This test is added to avoid a regression in case this is revisited in the future.
2019-06-13 17:29:58 +02:00
Joachim Jablon
2628ea9515
Fixed #30512 -- Used email.headerregistry.parser for parsing emails in sanitize_address().
2019-06-13 16:22:15 +02:00
can
fde9b7d35e
Fixed #30128 -- Fixed handling timedelta timezone in database functions.
2019-06-13 09:29:43 +02:00
Mariusz Felisiak
3dca8738cb
Simplified GISFunctionsTests.test_point_on_surface().
2019-06-12 12:59:02 +02:00
Mariusz Felisiak
b616f65855
Added missing support for PointOnSurface function on MariaDB.
2019-06-12 10:51:43 +02:00
Mariusz Felisiak
198a0adef2
Removed obsolete comment from GISFunctionsTests.test_asgeojson().
2019-06-12 09:43:03 +02:00
Mariusz Felisiak
2e00119e39
Fixed GISFunctionsTests.test_asgeojson() crash on MariaDB 10.2+.
2019-06-12 09:43:03 +02:00
Jon Dufresne
9e38ed0536
Fixed #27486 -- Fixed Python 3.7 DeprecationWarning in intword and filesizeformat filters.
...
intword and filesizeformat passed floats to ngettext() which is
deprecated in Python 3.7. The rationale for this warning is documented
in BPO-28692: https://bugs.python.org/issue28692 .
For filesizeformat, the filesize value is expected to be an int -- it
fills %d string formatting placeholders. It was likely coerced to a
float to ensure floating point division on Python 2. Python 3 always
does floating point division, so coerce to an int instead of a float to
fix the warning.
For intword, the number may contain a decimal component. In English, a
decimal component makes the noun plural. A helper function,
round_away_from_one(), was added to convert the float to an integer that
is appropriate for ngettext().
2019-06-11 20:34:59 +02:00
Jon Dufresne
53ea535f13
Refs #27486 -- Added tests for filesizeformat filter.
2019-06-11 20:18:36 +02:00
CruxBox
34f8eeea4a
Fixed #30548 -- Improved exception when expression contains mixed types.
2019-06-10 19:48:53 +02:00
Aymeric Augustin
3ee0834a46
Fixed #30556 -- Avoided useless query and hasher call in ModelBackend.authenticate() when credentials aren't provided.
...
There's no need to fetch a user instance from the database unless
a username and a password are provided as credentials.
2019-06-10 11:12:31 +02:00
Jon Dufresne
e065b29387
Refs #27804 -- Used subTest() in filesizeformat tests and HumanizeTests.
2019-06-10 08:46:11 +02:00
Hasan Ramezani
dcb8f00d06
Fixed #29379 -- Added autocomplete attribute to contrib.auth.forms fields.
...
Thank you to Nick Pope for review.
Co-authored-by: CHI Cheng <cloudream@gmail.com>
2019-06-07 12:44:39 +02:00
Alexandre Varas
c498f088c5
Fixed #30521 -- Fixed invalid HTML in default error pages.
2019-06-07 07:51:45 +02:00
Mariusz Felisiak
3fb0a1a67f
Refs #30521 -- Added tests for content of default error pages.
2019-06-07 07:49:17 +02:00
Jon Dufresne
d6ea4898c4
Fixed #30550 -- Fixed decoding of non-UTF-8 bytes objects in response.json().
2019-06-07 06:40:15 +02:00
Jon Dufresne
498092377b
Refs #27804 -- Used subTest() in BinaryFieldTests.test_set_and_retrieve.
2019-06-07 06:04:56 +02:00
Joachim Jablon
8ba20d9071
Refs #30512 -- Added tests for sanitizing email addresses with display name and two @ signs.
2019-06-06 15:05:56 +02:00
Joachim Jablon
f841a776fe
Refs #30512 -- Used subTest() in MailTests.test_sanitize_address.
2019-06-06 14:50:40 +02:00
Hasan Ramezani
661e6cc2c9
Fixed #29706 -- Made RenameContentType._rename() save to the correct database.
2019-06-06 12:09:01 +02:00
Tobias Bengfort
581a0f4545
Refs #30226 -- Added User.get_user_permissions() method.
...
Added to mirror the existing User.get_group_permissions().
2019-06-05 13:56:37 +02:00
Tobias Bengfort
75337a6050
Fixed #30226 -- Added BaseBackend for authentication.
2019-06-05 13:39:46 +02:00
Étienne Beaulé
4b6dfe1622
Fixed #30542 -- Fixed crash of numerical aggregations with filter.
...
Filters in annotations crashed when used with numerical-type
aggregations (i.e. Avg, StdDev, and Variance). This was caused as the
source expressions no not necessarily have an output_field (such as the
filter field), which lead to an AttributeError: 'WhereNode' object has
no attribute output_field.
Thanks to Chuan-Zheng Lee for the report.
Regression in c690afb873
2019-06-05 08:06:26 +02:00
Tim Graham
b916c27f9a
Fixed typo in tests/generic_views/test_base.py.
2019-06-04 20:09:07 -04:00
Jones Ambrosi
f9561144d7
Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels.
2019-06-04 10:27:12 +02:00
RobertAKARobin
aa94f7c899
Fixed #30534 -- Fixed overriding a field's default in ModelForm.cleaned_data().
2019-06-04 08:28:49 +02:00
Nathan Gaberel
b27c9c953b
Fixed #28604 -- Prevented ManifestStaticFilesStorage from leaving intermediate files.
2019-06-03 13:11:55 +02:00
Carlton Gibson
deeba6d920
Fixed CVE-2019-12308 -- Made AdminURLFieldWidget validate URL before rendering clickable link.
2019-06-03 11:36:12 +02:00
can
dffa3e1992
Fixed #30493 -- Fixed prefetch_related() for GenericRelation with different content types.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Thanks Simon Charette for the review.
2019-05-31 18:11:55 +02:00
Mariusz Felisiak
ea6e684f34
Simplified m2m_recursive.tests.
2019-05-31 16:19:11 +02:00
Mariusz Felisiak
f6075fb333
Fixed #26192 -- Fixed crash of ordering by constants on PostgreSQL.
...
Thanks Simon Charette for the review.
2019-05-31 07:38:48 +02:00
Mariusz Felisiak
cc80979f01
Refs #26192 -- Added tests for ordering by constant value.
2019-05-31 07:38:48 +02:00
Hasan Ramezani
e2de49ec2e
Fixed #28520 -- Added --start-at/--start-after options to runtests.py.
2019-05-31 07:01:12 +02:00
Hasan Ramezani
ef7e0ae53b
Refs #28520 -- Added _module_match_label() hook to runtests.py.
2019-05-30 09:29:09 +02:00
Tom Forbes
480492fe70
Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.
...
Previously we updated the file mtimes if the file has not been seen
before - i.e on the first iteration of the loop.
If the mtime has been changed we triggered the notify_file_changed()
method which in all cases except the translations will result in the
process being terminated. To be strictly correct we need to update the
mtime for either branch of the conditional.
Regression in 6754bffa2b
2019-05-29 09:41:24 +02:00
Tom Forbes
0344565179
Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
...
Regression in c8720e7696
2019-05-29 08:08:50 +02:00
Caio Ariede
a3f91891d2
Fixed #30315 -- Fixed crash of ArrayAgg and StringAgg with ordering when used in Subquery.
2019-05-28 10:05:50 +02:00
Tom Forbes
b2790f74d4
Fixed #30479 -- Fixed detecting changes in manage.py by autoreloader when using StatReloader.
...
Regression in c8720e7696
2019-05-28 08:31:33 +02:00
Ivor Bosloper
5ec44973dc
Fixed typo in RasterField test name.
2019-05-27 13:40:03 +02:00
Mattia Procopio
aff61790a3
Refs #24944 -- Added test for overriding domain in email context in PasswordResetView.
2019-05-27 11:50:30 +02:00
Johan Lübcke
0670b1b403
Fixed #30485 -- Adjusted django.utils.http.urlencode for doseq=False case.
2019-05-24 17:15:34 +02:00
Mariusz Felisiak
85195dd237
Refs #9982 -- Added test for saving OneToOneField field after saving related object.
...
Fixed in 519016e5f2
2019-05-24 10:54:05 +02:00
Jon Dufresne
45edd746cc
Used re.Pattern.findall() instead of re.findall() in inspectdb.tests.
2019-05-24 09:04:27 +02:00
Rob
58df8aa40f
Fixed #28780 -- Allowed specyfing a token parameter displayed in password reset URLs.
...
Co-authored-by: Tim Givois <tim.givois.mendez@gmail.com>
2019-05-24 08:40:25 +02:00
Caio Ariede
753b67c58d
Fixed #30497 -- Ignored document type in assertXMLEqual()/assertXMLNotEqual().
2019-05-24 07:29:42 +02:00
Mariusz Felisiak
f8b8b00f01
Fixed #30501 -- Preventing QuerySet.reverse() from mutating expressions in QuerySet.order_by and Meta.ordering.
2019-05-23 20:33:37 +02:00
Ran Benita
a2c31e12da
Fixed #30498 -- Fixed proxy class caching in lazy().
...
lazy() should prepare the proxy class only once (the first time it's
used) not on every call.
Regression in b4e76f30d1
2019-05-22 20:41:52 +02:00
Hasan Ramezani
1378d665a1
Fixed #28816 -- Prevented silencing data loss when decreasing CharField.max_length on PostgreSQL.
2019-05-21 14:15:43 +02:00
Rob
519016e5f2
Fixed #28147 -- Fixed loss of assigned parent when saving child after parent.
...
Thanks Erwin Junge for the initial patch.
2019-05-21 10:11:22 +02:00
Rob
266e7e0ecc
Refs #28147 -- Added test for saving nullable ForeignKey with to_field attribute after saving parent.
2019-05-21 10:08:09 +02:00
Hasan Ramezani
9d6f981a66
Fixed #28763 -- Allowed overriding the session cookie age with SessionStore.get_session_cookie_age().
2019-05-21 08:50:09 +02:00
Simon Charette
514104cf23
Refs #29396 , #30494 -- Reduced code duplication in year lookups.
2019-05-21 07:25:09 +02:00
Simon Charette
2b582a7b84
Fixed #29396 -- Added indirect values support to __year lookups.
...
Thanks Windson Yang for the initial patch.
2019-05-21 07:12:33 +02:00
Simon Charette
4d1420947e
Fixed #30494 -- Disabled __year lookup optimization for indirect values.
...
The previous heuristics were naively enabling the BETWEEN optimization on
successful cast of the first rhs SQL params to an integer while it was
not appropriate for a lot of database resolved expressions.
Thanks Alexey Chernov for the report.
2019-05-21 07:11:26 +02:00
Thomasina Lee
c38e7a79f4
Fixed #30488 -- Removed redundant Coalesce call in SQL generated by SearchVector.
...
Regression in 405c836336
2019-05-20 08:34:06 +02:00
ruchit2801
04042b2b44
Fixed #30463 -- Fixed crash of deprecation message when Meta.ordering contains expressions.
...
Regression in 1b1f64ee5a
2019-05-18 19:29:00 +02:00
ShingenPizza
de4832c49b
Fixed #30196 -- Made FileResponse set Content-Disposition inline if filename is available.
2019-05-17 12:07:27 +02:00
Batuhan Taşkaya
5c19274643
Fixed #30453 -- Fixed crash of simple_tag() and inclusion_tag() when function is wrapped.
...
getfullargspec() doesn't work with wrapped functions.
2019-05-17 09:53:24 +02:00
Johannes Hoppe
8d010f3986
Fixed #30220 -- Added support for headless mode in selenium tests.
2019-05-17 08:14:54 +02:00
Claude Paroz
e286987a27
Fixed #30459 -- Delegated hide/show JS toggle to parent div.
...
Co-authored-by: Carlton Gibson <carlton.gibson@noumenal.es>
2019-05-17 07:46:45 +02:00
Iain Watts
59ffafa1d2
Fixed #30482 -- Prevented unnecessary evaluation of lookup.queryset in prefetch_related_objects().
2019-05-16 21:39:55 +02:00
Jon Dufresne
8076ae68c1
Fixed #30483 -- Switched test requirement to psycopg2 package.
2019-05-16 15:42:32 +02:00
Ally Weir
bd228cb599
Fixed mis-capitalisation in comment.
2019-05-15 12:14:59 +02:00
Florian Apolloner
d329484534
Ensured that our django checkout is in the pythonpath during tests.
...
This fixes an issue with postgres_tests.test_integration.PostgresIntegrationTests
which would not find Django in a CI run.
2019-05-14 19:43:56 +02:00
Rob
c231a75112
Fixed #30436 -- Added check that on_delete is callable in ForeignKey and OneToOneField.
2019-05-13 07:25:42 +02:00
Amir Hadi
330638b89f
Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows.
...
Co-authored-by: Tim Graham <timograham@gmail.com>
Co-authored-by: Patryk Zawadzki <patrys@room-303.com>
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-05-12 07:05:24 +02:00
Jon Dufresne
7c3732a1b4
Fixed #30470 -- Added assertHTMLEqual() support for all self closing tags.
...
Support for the following tags was added: area, embed, param, track, and
wbr.
The full list of self closing tags is documented at:
https://html.spec.whatwg.org/#void-elements
2019-05-10 12:04:07 +02:00
Jon Dufresne
b7a33ee4f0
Fixed #30468 -- Fixed assertHTMLEqual() to handle all ASCII whitespace in a class attribute.
2019-05-09 17:18:18 +02:00
Jon Dufresne
de6d3afb97
Refs #27804 -- Used subTest() in HTMLEqualTests.test_self_closing_tags.
2019-05-09 17:17:42 +02:00
luzpaz
e2feea5fc4
Fixed comment typo.
2019-05-09 17:04:50 +02:00
Troon
a3a4f5c144
Fixed #30310 -- Added support for looking up HttpHeaders.headers using underscores.
2019-05-09 16:26:52 +02:00
Jon Dufresne
48235ba807
Refs #30399 -- Made assertHTMLEqual normalize character and entity references.
2019-05-09 15:55:32 +02:00
Hasan Ramezani
f038214d91
Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget.
...
placeholder is required for "select" with "required" attribute.
2019-05-08 12:46:30 +02:00
Mariusz Felisiak
ef9f2eb69c
Refs #30462 -- Added test for conditional aggregation on annotated subquery.
2019-05-08 11:29:17 +02:00
Jon Dufresne
b915b9f10f
Refs #27753 -- Deprecated django.utils.text.unescape_entities().
...
The function was undocumented and only required for compatibility with
Python 2.
Code should use Python's html.unescape() that was added in Python 3.4.
2019-05-08 08:00:59 +02:00
Rob
6b736dd074
Fixed #30349 -- Fixed QuerySet.exclude() on FilteredRelation.
...
Using annotated FilteredRelations raised a FieldError when coupled with
exclude(). This is due to not passing filtered relation fields to the
subquery created in split_exclude(). We fixed this issue by passing the
filtered relation data to the newly created subquery.
Secondly, in the case where an INNER JOIN is used in the excluded
subquery, the ORM would trim the filtered relation INNER JOIN in attempt
to simplify the query. This will also remove the ON clause filters
generated by the FilteredRelation. We added logic to not trim the INNER
JOIN if it is from FilteredRelation.
2019-05-07 14:47:50 +02:00
Chris Adkins
705ef6cfeb
Fixed #30447 -- Added 'is_in_european_union' in GeoIP2.city() dict.
2019-05-07 13:31:44 +02:00
Tobias Kunze
0e2ed4fdd1
Refs #26678 -- Added tests for using the field the relation points to with RelatedManager.add()/remove()/set().
2019-05-07 09:02:06 +02:00
Tobias Kunze
3166880301
Fixed #29352 -- Allowed specifying a Feed language.
2019-05-06 15:10:54 +02:00
Stephen Brown
86a3ad351e
Fixed #30339 -- Made Model.delete(keep_parents=True) preserves nested parent reverse relationships.
...
Thanks Simon Charette for the review.
2019-05-06 13:04:31 +02:00
Mariusz Felisiak
8c5649bfb7
Fixed NonQueryWindowTests.test_unsupported_backend() on MySQL.
2019-05-03 13:49:02 +02:00
Tobias Kunze
e683613649
Fixed #20122 -- Made pluralize template filter return '' on invalid input.
2019-05-03 11:35:20 +02:00
Tobias Kunze
a9b8898242
Refs #11929 -- Fixed ordering of test YAML dumps.
...
Thanks Nick Pope for the review.
2019-05-03 10:48:18 +02:00
Mariusz Felisiak
9006189c0e
Removed unused YamlSerializerTestCase.fwd_ref_str.
...
Unused since its introduction in febd5aeec6
2019-05-03 10:00:06 +02:00
can
567b9928a3
Fixed #29692 -- Fixed removing ordering parts for multiline RawSQL expressions.
2019-05-03 07:37:37 +02:00
Mykola Kokalko
ef082ebb84
Fixed #29529 -- Allowed models.fields.FilePathField to accept a callable path.
2019-05-02 11:11:56 +02:00
Mykola Kokalko
11971cd87c
Added tests for setting models.fields.FilePathField.path.
2019-05-02 11:11:50 +02:00
can
bceadd2788
Fixed #30396 -- Added system checks for uniqueness of indexes and constraints names.
...
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-05-02 09:13:20 +02:00
zeyneloz
6485a5f450
Fixed #30409 -- Allowed using foreign key's attnames in unique/index_together and Index's fields.
2019-05-01 11:51:27 +02:00
François Freitag
568eed9e79
Fixed #30245 -- Added -k option to DiscoverRunner.
2019-04-30 16:20:51 +02:00
can
719b746620
Fixed #30412 -- Fixed crash when adding check constraints with OR'ed condition on Oracle and SQLite.
2019-04-30 12:32:27 +02:00
Jon Dufresne
6866c91b63
Fixed #30418 -- Added --skip-checks management command option.
2019-04-30 10:48:30 +02:00
Simon Charette
a8b3f96f6a
Fixed #30408 -- Fixed crash when adding check constraints with LIKE operator on Oracle and PostgreSQL.
...
The LIKE operator wildcard generated for contains, startswith, endswith and
their case-insensitive variant lookups was conflicting with parameter
interpolation on CREATE constraint statement execution.
Ideally we'd delegate parameters interpolation in DDL statements on backends
that support it but that would require backward incompatible changes to the
Index and Constraint SQL generating methods.
Thanks David Sanders for the report.
2019-04-30 07:38:22 +02:00
kingbuzzman
673fe2e3ec
Fixed #30148 -- Logged COPY ... TO statements in connection.queries on PostgreSQL.
2019-04-29 14:20:17 +02:00
Tom Forbes
6754bffa2b
Fixed #30323 -- Fixed detecting changes by autoreloader when using StatReloader.
2019-04-29 11:41:00 +02:00
Mariusz Felisiak
ed880d92b5
Added tests for queries log in CursorDebugWrapper.executemany().
2019-04-29 10:38:17 +02:00
Jon Dufresne
0dd2308cf6
Fixed Python PendingDeprecationWarning in select_for_update.tests.
2019-04-29 08:47:33 +02:00
Jon Dufresne
5627057f63
Refs #26022 -- Used context manager version of assertRaisesMessage in tests.
...
Follow up to 253adc2b8a
2019-04-29 08:05:07 +02:00
Carlton Gibson
98296f86b3
Fixed #30351 -- Handled pre-existing permissions in proxy model permissions data migration.
...
Regression in 181fb60159
2019-04-27 20:18:22 +02:00
Daniel Hahler
08a4ee0651
Fixed typos in test names.
2019-04-27 07:47:42 +02:00
Jacob Green
ed3c59097a
Fixed #30361 -- Increased the default timeout of watchman client to 5 seconds and made it customizable.
...
Made the default timeout of watchman client customizable via
DJANGO_WATCHMAN_TIMEOUT environment variable.
2019-04-26 12:55:49 +02:00
Aarni Koskela
efeceba589
Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
2019-04-26 11:31:06 +02:00
Jon Dufresne
8d76443aba
Fixed #30399 -- Changed django.utils.html.escape()/urlize() to use html.escape()/unescape().
2019-04-25 15:09:07 +02:00
Alasdair Nicol
a5accc0368
Fixed #30318 -- Added check for importability of arguments of custom error handler views.
...
Thanks to Jon on Stack Overflow for reporting the issue.
2019-04-25 11:08:22 +02:00
oliver
fc9566d42d
Fixed #30393 -- Added validation of startapp's directory option.
2019-04-25 08:52:48 +02:00
Ville Skyttä
0f22671ecb
Fixed #30388 -- Made inspectdb generate OneToOneFields rather than ForeignKey(unique/primary_key=True).
2019-04-25 08:09:32 +02:00
Jon Dufresne
0a01ca80d7
Refs #30241 -- Fixed BytesWarning emitted in test_translation tests.
2019-04-24 15:31:03 +02:00
Martijn Jacobs
9141da1a80
Fixed #30366 -- Skipped StatReloaderTests on HFS+ filesystems.
...
When on MacOS High Sierra or below (<=10.13) it could be that a HFS+
filesystem is used. HFS+ has a time resolution of only one second
which can be too low for some of the tests.
2019-04-24 15:28:20 +02:00
Jon Dufresne
8b3f1c35dd
Removed unnecessary assignments in various code.
2019-04-24 13:09:29 +02:00
Matthias Kestenholz
80482e9249
Fixes #30342 -- Removed a system check for LANGUAGES_BIDI setting.
...
This partly reverts commit 4400d8296d
2019-04-24 10:54:03 +02:00
Carlton Gibson
607ff4efa3
Refs #30254 -- Added tests for Model.__hash__() inheritance.
2019-04-24 09:59:09 +02:00
can
c00b4dbda2
Fixed #29810 -- Fixed crash of select_related() on FilteredRelation with empty result.
2019-04-23 13:48:33 +02:00
Simon Charette
405c836336
Fixed #30385 -- Restored SearchVector(config) immutability.
...
Regression in 1a28dc3887#29582 . Thanks Andrew Brown for the report, Nick Pope for the
review.
2019-04-23 08:11:33 +02:00
Mariusz Felisiak
12b7956fc3
Refs #25507 -- Added tests for using QuerySet.count() with a RawSQL annotation.
...
Fixed in 3f32154f40
2019-04-19 11:40:04 +02:00
Dustin Neighly
49fb3f5f3e
Fixed #30341 -- Added support for the furlong unit in Distance.
2019-04-19 08:54:23 +02:00
Scott Fitsimones
a14c0fda15
Fixed #30328 -- Fixed crash of IntegerField.validators when limit_value in a custom validator is callable.
2019-04-19 07:58:27 +02:00
Ramiro Morales
aed89adad5
Fixed #30367 -- Changed "pip install" to "python -m pip install" in docs, comments and hints.
2019-04-18 14:41:15 +02:00
Tomer Chachamu
ceab25bc6d
Refs #28762 -- Added test for aggregating over a function with ArrayField parameters.
...
Fixed in d87bd29c4f
2019-04-18 12:54:19 +02:00
Mariusz Felisiak
654614b38e
Refs #28767 -- Added test for annotating Value() with empty list as an ArrayField.
...
Fixed in 3af695eda2
2019-04-18 12:06:39 +02:00
Ville Skyttä
03db5fddfd
Fixed typos in docs, comments, and exception messages.
2019-04-18 09:33:53 +02:00
Oleh Mykytiuk
177fa08339
Fixed #30370 -- Added dbshell support for client TLS certificates on PostgreSQL.
2019-04-18 08:10:31 +02:00
can
d87bd29c4f
Fixed #30335 , #29139 -- Fixed crash when ordering or aggregating over a nested JSONField key transform.
2019-04-18 07:16:50 +02:00
Simon Charette
f110de5c04
Fixed #30191 -- Selected only referenced fields during cascade deletion.
...
The non-referenced fields can only be deferred if no deletion signals
receivers are connected for their respective model as connected as these
receivers might expect all fields of the deleted model to be present.
Thanks Ed Morley for the report.
2019-04-17 13:41:23 +02:00
Hasan Ramezani
917fd9d03f
Fixed #27755 -- Added ModelAdmin.get_inlines() hook.
2019-04-17 07:16:04 +02:00
Vinny Do
a4055adf70
Fixed #30368 -- Fixed prefetch_related() for GenericForeignKey when PK is also a FK.
2019-04-16 09:49:16 +02:00
Simon Charette
0cb4062482
Refs #23758 -- Used RecursionError instead of RuntimeError to raise nested subquery errors.
...
RecursionError was introduced in Python 3.5 and subclasses RuntimeError.
2019-04-15 15:20:41 +02:00
Simon Charette
c0969ee227
Refs #27149 -- Based recursive nested subquery detection on sys.getrecursionlimit().
...
This makes sure the test_avoid_infinite_loop_on_too_many_subqueries test
doesn't fail on systems with a non-default recursion limit.
2019-04-15 15:20:41 +02:00
Tobias Kunze
9ac8520fcd
Refs #30325 -- Added tests for using count()/exists() with custom managers and reverse M2M relations.
2019-04-15 12:02:31 +02:00
Mariusz Felisiak
5f7991c42c
Fixed #30325 -- Reverted "Fixed #29725 -- Removed unnecessary join in QuerySet.count() and exists() on a many-to-many relation."
...
This reverts commit 1299421cad
2019-04-15 12:02:26 +02:00
Markus Holtermann
da0b2554ec
Renamed camelCaseTestMethods to snake_case_test_methods
2019-04-14 16:14:14 +02:00
Florian Apolloner
2e38f2015a
Fixed #30350 -- Prevented recreation of migration for operations with a range object.
...
Thanks to Mariusz Felisiak for helping with the patch.
2019-04-14 12:04:48 +02:00
Mariusz Felisiak
1afbc96a75
Fixed #30343 -- Fixed prefetch_related() for GenericForeignKey when PK of related field is UUIDField.
2019-04-14 10:02:59 +02:00
Krisjanis Vaiders
79d3b905df
Fixed #30358 -- Removed redundant assertion in FormsUtilsTestCase.test_error_dict_copy().
2019-04-13 18:42:11 +02:00
Thomas Allison
3e8b733390
Fixed #25941 -- Improved error message for runtests.py when django is not on path.
2019-04-13 16:06:27 +02:00
Sjoerd Job Postmus
e6d57c4d65
Fixed #30363 -- Do not use exponential notation for small decimal numbers.
...
In 9cc6a60040b0f64f8ea066dd215176d4bd16621d a security patch was
introduced to prevent allocating large segments of memory when a
very large or very small decimal number was to be formatted.
As a side-effect, there was a change in formatting of small decimal
numbers even when the `decimal_pos` argument was provided, which meant
that reasonable small decimal numbers (above 1e-199) would be formatted
as `0.00`, while smaller decimal numbers (under 1e-200) would be
formatted as `1e-200`.
2019-04-13 14:30:33 +02:00
Dolan Antenucci
f944cb3d3b
Fixed #30266 -- Kept a sequence owner when altering an AutoField/BigAutoField on PostgreSQL.
2019-04-08 22:24:18 +02:00
Florian Apolloner
afc708cf6d
Fixed #30330 -- Fixed setting of primary key to None during fast-delete.
...
Regression in bc7dd8490b
2019-04-08 21:14:00 +02:00
Ran Benita
19fc6376ce
Fixed #30304 -- Added support for the HttpOnly, SameSite, and Secure flags on language cookies.
2019-04-08 11:26:06 +02:00
can
cef3f2d3c6
Fixed #28373 -- Used connection timezone instead of UTC when making dates timezone-aware on MySQL, SQLite, and Oracle.
...
Thanks vtalpaert for the initial patch.
Co-Authored-By: Mariusz Felisiak <felisiak.mariusz@gmail.com>
2019-04-08 08:59:17 +02:00
Simone Pellizzari
d0315584b5
Fixed #30332 -- Fixed crash of ordering by expressions with params in ArrayAgg and StringAgg.
2019-04-06 14:23:29 +02:00
Simone Pellizzari
47a1f2a06f
Refs #26067 -- Added more tests for ordering in StringAgg.
2019-04-06 13:41:46 +02:00
Mariusz Felisiak
79065b55a7
Refs #20010 -- Unified DatabaseOperations.last_executed_query() on Oracle with other db backends.
...
Thanks Simon Charette for the review.
2019-04-05 21:35:51 +02:00
Nick Pope
6b4e57d79f
Refs #30324 -- Forced utf-8 encoding when loading templates for the technical 404 debug and congrats page.
2019-04-05 16:35:01 +02:00
Nick Pope
efb257a017
Fixed #30324 -- Forced utf-8 encoding when loading the template for the technical 500 debug page.
...
Regression in 50b8493ea542a9
2019-04-05 16:35:01 +02:00
msg
755673e1bc
Fixed #30307 -- Fixed incorrect quoting of database user password when using dbshell on Oracle.
...
Regression in acfc650f2a
2019-04-04 08:33:28 +02:00
belegnar
1ffddfc233
Fixed #30302 -- Fixed forms.model_to_dict() result if empty list of fields is passed.
2019-04-03 09:05:15 +02:00
belegnar
714cf468e1
Refs #30302 -- Added more tests for forms.model_to_dict().
2019-04-03 08:59:08 +02:00
Mariusz Felisiak
7cbcf2e2cb
Fixed #30259 -- Fixed crash of admin views when properties don't have admin_order_field attribute.
2019-04-01 15:11:54 +02:00
JangHyukJin
0027ca76c7
Used QuerySet.bulk_create() in lookup.tests.
2019-04-01 10:46:28 +02:00
Tim Graham
8335d59200
Fixed #30289 -- Prevented admin inlines for a ManyToManyField's implicit through model from being editable if the user only has the view permission.
2019-03-30 16:49:16 -04:00
oliver
03bee42a7e
Made startapp/project's overlaying error message use 'app' or 'project'.
2019-03-30 10:14:07 -04:00
can
96446c7152
Refs #29697 -- Added test for excluding m2m intermediary table.
2019-03-30 14:46:59 +01:00
pmisteli
9410db9683
Fixed #30236 -- Made UsernameField render with autocapitalize="none" HTML attribute.
...
This prevents automatic capitalization, which is the default behavior in
some browsers.
2019-03-29 15:24:44 +01:00
sage
9aa56cb0d5
Fixed #30294 -- Allowed HttpResponse to accept memoryview content.
2019-03-29 09:43:49 -04:00
Nick Pope
4400d8296d
Fixed #30241 -- Added more system checks of translation settings.
2019-03-28 20:10:50 +01:00
Nick Pope
d4783048ef
Refs #29713 -- Improved error message when LANGUAGE_CODE is invalid.
2019-03-28 20:04:24 +01:00
sage
5a92bb0725
Fixed #30295 -- Fixed max_lengths.tests.MaxLengthORMTests when run in isolation.
2019-03-28 10:18:30 +01:00
Mariusz Felisiak
9ab1d55596
Refs #18726 -- Added test for excluding circular related fields with F() expression.
...
Fixed in f19a4945e1
2019-03-28 07:10:54 +01:00
Mariusz Felisiak
2a431db0f5
Fixed #28621 -- Fixed crash of annotations with OuterRef.
2019-03-27 08:24:05 +01:00
Nathan Gaberel
624573726a
Fixed #29791 -- Made Engine.render_to_string() honor autoescape.
2019-03-25 17:59:07 -04:00
Hasan Ramezani
d4df5e1b0b
Fixed #27360 -- Added app or ModelAdmin details for AreadyRegistered exceptions.
2019-03-25 17:34:53 -04:00
Hasan Ramezani
981dd6dd71
Fixed #28431 -- Added a system check for BinaryField to prevent strings defaults.
...
Thanks Claude Paroz for the initial patch.
2019-03-25 20:04:35 +01:00
Jani Tiainen
044cc54420
Fixed #30259 -- Added support for admin_order_field attribute on properties in ModelAdmin.list_display.
2019-03-24 20:43:56 +01:00
Matthias Kestenholz
ea60b7bc74
Removed redundant model field choices tests.
2019-03-23 12:04:39 -04:00
Simon Charette
1ca825e4dc
Fixed #30246 -- Reused annotation aliases references in aggregation filters.
...
Thanks Jan Baryła for the detailed report and the reduced test case.
2019-03-23 10:11:45 -04:00
Simon Charette
3f32154f40
Refs #30188 -- Avoided GROUP BY when aggregating over non-aggregates.
2019-03-23 10:11:41 -04:00
Simon Charette
d1e9c25162
Refs #30188 -- Prevented double annotation of subquery when aggregated over.
...
Thanks Can Sarıgöl for the suggested trimming approach.
2019-03-23 09:50:42 -04:00
Simon Charette
bdc07f176e
Fixed #30188 -- Fixed a crash when aggregating over a subquery annotation.
2019-03-23 09:48:31 -04:00
Simon Charette
f19a4945e1
Fixed #21703 -- Fixed a crash when excluding a related field with a F().
2019-03-23 09:48:28 -04:00
Ryan J Schave
cbf7e71558
Fixed #30257 -- Made UsernameValidators prohibit trailing newlines.
2019-03-22 13:16:25 -04:00
Matthias Kestenholz
ea071870f9
Fixed #30280 -- Restored Model.get_FIELD_display()'s coercion of lazy strings.
...
Reverted cc79c7ee63
2019-03-22 12:30:10 -04:00
Nick Pope
d26b242443
Fixed #30271 -- Added the Sign database function.
2019-03-22 12:52:39 +01:00
Simon Charette
3543129822
Refs #27149 -- Moved subquery expression resolving to Query.
...
This makes Subquery a thin wrapper over Query and makes sure it respects
the Expression source expression API by accepting the same number of
expressions as it returns. Refs #30188 .
It also makes OuterRef usable in Query without Subquery wrapping. This
should allow Query's internals to more easily perform subquery push downs
during split_exclude(). Refs #21703 .
2019-03-21 20:36:31 -04:00
Simon Charette
e595a713cc
Refs #29542 , #30158 -- Enabled a HAVING subquery filter test on Oracle.
...
Now that subquery annotations aren't included in the GROUP BY unless
explicitly grouped against, the test works on Oracle.
2019-03-21 18:48:41 -04:00
Simon Charette
fb3f034f1c
Fixed #30158 -- Avoided unnecessary subquery group by on aggregation.
...
Subquery annotations can be omitted from the GROUP BY clause on aggregation
as long as they are not explicitly grouped against.
Thanks Jonny Fuller for the report.
2019-03-21 18:48:41 -04:00
Simon Charette
9dc367dc10
Refs #30158 -- Added alias argument to Expression.get_group_by_cols().
2019-03-21 18:47:46 -04:00
oliver
2aaabe2004
Used QuerySet.bulk_create() in a couple of postgres tests.
...
Follow up to 0ce2ad9ca4
2019-03-21 18:05:29 -04:00
birthdaysgift
dc740dde50
Fixed #29471 -- Added 'Vary: Cookie' to invalid/empty session cookie responses.
2019-03-21 18:02:49 -04:00
Carlton Gibson
d64808cacd
Used a picklable argument for a subTest.
2019-03-21 13:56:05 -04:00
Hasan Ramezani
5fc5d93512
Fixed #29956 -- Allowed overriding an order field widget in formsets.
2019-03-21 11:51:01 +01:00
Nick Pope
413d50b5ff
Corrected settings names in SecurityMiddleware tests.
2019-03-20 20:15:34 -04:00
Nick Pope
0b70985f42
Fixed #30240 -- Added SHA1, SHA224, SHA256, SHA384, and SHA512 database functions.
...
Thanks Mariusz Felisiak and Tim Graham for reviews.
2019-03-20 19:30:43 +01:00
Francisco Couzo
0193bf874f
Fixed #28738 -- Added the GeometryDistance function.
2019-03-20 12:54:42 -04:00
oliver
638d5ea375
Moved choices inside of a test model per coding style.
...
Follow up to 3a4558b84f
2019-03-20 11:05:26 -04:00
Tim Graham
55490ac746
Fixed serializers test crash if PyYAML isn't installed.
...
Follow up to a57c783dd4
2019-03-20 09:23:50 -04:00
Mariusz Felisiak
c9888bc8ec
Fixed #30264 -- Fixed crash of test_parsing_year_less_than_70() on 32-bit systems.
...
Thanks Andreas Beckmann and Chris Lamb for the report.
2019-03-20 13:44:30 +01:00
Simon Charette
386d89ab55
Fixed #30258 -- Adjusted postgres schema value quoting of ranges.
...
Thanks Tilman Koschnick for the report and patch.
2019-03-18 09:05:39 +01:00
Paveł Tyślacki
5c17c273ae
Refs #30172 -- Prevented removing a model Meta's index/unique_together from removing Meta constraints/indexes.
2019-03-17 20:50:57 -04:00
Paveł Tyślacki
4bb859e246
Refs #30172 -- Prevented removing a field's check or unique constraint from removing Meta constraints.
2019-03-17 20:50:22 -04:00
Simon Charette
218a485bf1
Refs #12663 -- Fixed reference to nonexistent field in model_fields tests.
2019-03-17 20:49:32 -04:00
Jon Dufresne
95b7699ffc
Cleaned up exception message checking in some tests.
2019-03-15 19:27:57 -04:00
Matt Westcott
58ad030d05
Fixed #30254 -- Allowed model metaclasses to access the attribute dict in __init__().
...
Regression in a68ea23101
2019-03-14 21:05:23 -04:00
Herman S
f976ab1b11
Fixed #30237 -- Made Authentication/SessionMiddleware and ModelBackend admin checks allow subclasses.
2019-03-14 20:09:57 -04:00
Mariusz Felisiak
258110d6cd
Simplified test_transform()s in db_functions.math.
2019-03-14 19:42:01 -04:00
Mariusz Felisiak
a57c783dd4
Fixed serializers tests for PyYAML 5.1+.
2019-03-14 13:16:48 -04:00
Paveł Tyślacki
782d85b6df
Fixed #30183 -- Added introspection of inline SQLite constraints.
2019-03-13 10:24:28 -04:00
Mariusz Felisiak
d77657737f
Simplified forms_tests.tests.test_formsets.
2019-03-12 15:46:39 +01:00
Nick Pope
a35bf4af72
Fixed typo in tests/check_framework/test_translation.py comment.
2019-03-09 13:17:50 +01:00
tschilling
7c68cea7ee
Fixed #30186 -- Made showmigrations --list display the applied datetimes at verbosity 2+.
2019-03-08 08:25:38 -05:00
Tim Schilling
371ddade1e
Refs #30186 -- Changed MigrationRecorder.applied_migrations() to return a dict.
2019-03-07 19:36:55 -05:00
Parth Patil
acc041984f
Fixed #30189 -- Removed transaction from sqlmigrate output if database doesn't use one.
2019-03-07 18:28:22 -05:00
ahbk
d527639804
Fixed #29754 -- Added is_dst parameter to Trunc database functions.
2019-03-07 10:02:18 -05:00
Andra Denis Ionescu
4c086d7da4
Fixed #29459 -- Initialized form data/files with empty MultiValueDicts.
2019-03-05 10:41:08 -05:00
orlnub123
163236ea0e
Fixed #30234 -- Disallowed non-upper settings in settings.configure().
2019-03-05 09:52:08 -05:00
avas9366
9681e968eb
Fixed #30232 -- Corrected expected format in invalid DurationField error message.
2019-03-04 19:25:27 -05:00
Mariusz Felisiak
b435f82939
Reverted "Fixed relative paths imports per isort 4.3.5."
...
This reverts commit 463fe11bc8
2019-03-03 19:33:48 +01:00
Tim Graham
8ec7ded370
Refs #30227 -- Added helpful message for non-ASCII Content-Type in mulitpart request.
2019-03-02 09:19:05 -05:00
Tim Graham
2ed2acf872
Fixed #30227 -- Fixed crash on request without boundary in Content-Type.
2019-03-02 09:19:05 -05:00
Jon Dufresne
8a2ec55b18
Merged isinstance() calls.
...
Follow up to 0214f367bc
2019-03-02 12:19:21 +01:00
Mariusz Felisiak
f69c7bbdce
Refs #29408 -- Cosmetic edits for validation of related fields and lookups in model Meta.ordering.
...
Follow up to 440505cb2c
2019-03-01 19:38:21 +01:00
Hasan Ramezani
440505cb2c
Fixed #29408 -- Added validation of related fields and lookups in model Meta.ordering.
2019-03-01 17:09:33 +01:00
Etienne Chové
4dcbe6eb2d
Fixed #30221 -- Made label suffix of admin's read-only fields translatable.
2019-02-28 11:12:30 -05:00
Matthias Kestenholz
231b513926
Fixed #30179 -- Fixed form Media merging when pairwise merging is insufficient.
...
Thanks gasman for the tests, and codingjoe and timgraham for the review.
2019-02-27 16:39:17 -05:00
shiningfm
99cfb28e99
Fixed #30215 -- Fixed autoreloader crash for modules without __spec__.
...
Regression in c8720e7696
2019-02-27 10:35:30 -05:00
orlnub123
2c0fda7f20
Refs #30057 -- Added more diffsettings tests.
...
The test in 573f44d62f
2019-02-26 10:30:38 -05:00
Matthias Kestenholz
e04209e181
Refs #30179 -- Moved topological sort functions to django.utils.
2019-02-25 15:44:49 -05:00
Mariusz Felisiak
463fe11bc8
Fixed relative paths imports per isort 4.3.5.
2019-02-25 11:03:30 +01:00
Seunghun Lee
99fc5dc13c
Fixed #30141 -- Fixed parse_duration() for some negative durations.
2019-02-23 18:54:09 -05:00
Tim Graham
36300ef336
Fixed a failure when running tests on systems with SQLite < 3.8.3.
2019-02-21 12:52:10 -05:00
Simon Charette
de7f6b51b2
Refs #19544 -- Added a fast path for through additions if supported.
...
The single query insertion path is taken if the backend supports inserts
that ignore conflicts and m2m_changed signals don't have to be sent.
2019-02-21 10:20:47 -05:00
Simon Charette
28712d8acf
Refs #19544 -- Ignored auto-created through additions conflicts if supported.
...
This prevents IntegrityError caused by race conditions between missing ids
retrieval and bulk insertions.
2019-02-21 10:20:47 -05:00
Tim Graham
0ac4e51b2c
Fixed typos in tests/template_tests/test_context.py.
2019-02-21 09:43:00 -05:00
Mariusz Felisiak
9ff18c08c3
Refs #28643 -- Added MD5 database function.
...
Thanks Tim Graham, Nick Pope and Simon Charette for reviews.
2019-02-21 10:52:51 +01:00
Jon Dufresne
7feddd878c
Fixed #18707 -- Added support for the test client to return 500 responses.
2019-02-20 12:16:10 +01:00
Simon Charette
7071f8f272
Fixed #30193 , Refs #28478 -- Avoided PostgreSQL connection health checks on initialization.
...
This addressed a regression introduced by a96b901932
2019-02-20 10:59:40 +01:00
Jakub Szafrański
0104b5a417
Fixed #30181 -- Made cache.get() with default work correctly on PyLibMCCache if None is cached.
2019-02-14 19:57:38 -05:00
Hasan Ramezani
741ce81a42
Fixed #29619 -- Added field names to some FieldErrors.
2019-02-14 18:58:08 -05:00
Claude Paroz
a8e2a9bac6
Refs #15902 -- Deprecated storing user's language in the session.
2019-02-14 10:23:02 -05:00
Jon Dufresne
76990cbbda
Fixed #30171 -- Fixed DatabaseError in servers tests.
...
Made DatabaseWrapper thread sharing logic reentrant. Used a reference
counting like scheme to allow nested uses.
The error appeared after 8c775391b7
2019-02-14 10:04:55 -05:00
Bernhard M. Wiedemann
5a465df70d
Made a requests test that will fail in 2028 fail 10 years later.
...
2038 is chosen for compatibility with 32-bit systems.
2019-02-14 09:44:41 -05:00
Carlton Gibson
ed7dee55a9
Fixed admin_scripts test failures on macOS.
...
Regression in 487d904bf2
2019-02-14 14:28:19 +01:00
Daniel Bowring
cf826c9a91
Fixed #30173 -- Simplified db.backends.postgresql.client.
2019-02-13 17:12:02 -05:00
Tim Graham
ddb2936852
Refs #25175 -- Renamed test file referencing the old postgresql_psycopg2 engine.
2019-02-13 17:11:33 -05:00
Dan Davis
2bd8df243a
Fixed #30184 -- Removed ellipsis characters from shell output strings.
...
Partially reverted 50b8493581#29654 )
to avoid a crash when the user shell doesn't support non-ASCII characters.
2019-02-13 13:59:44 -05:00
Claude Paroz
15715bf2a2
Fixed #22423 -- Added support for MySQL operators on real geometries.
...
Thanks Viswanathan Mahalingam for the report and initial patch, and
Nicke Pope and Tim Graham for the review.
2019-02-12 17:29:16 -05:00
Mariusz Felisiak
7d5d20212c
Simplified test_cursor_var() by using str instead of Database.STRING.
2019-02-12 20:10:02 +01:00
Semen Zhydenko
255d6a26a8
Fixed spelling mistakes in comments and tests.
2019-02-11 08:55:57 -05:00
Carlton Gibson
402c0caa85
Fixed CVE-2019-6975 -- Fixed memory exhaustion in utils.numberformat.format().
...
Thanks Sjoerd Job Postmus for the report and initial patch.
Thanks Michael Manfre, Tim Graham, and Florian Apolloner for review.
2019-02-11 11:08:45 +01:00
Sergey Fedoseev
1835563ab8
Removed unneeded list() calls in sorted() argument.
2019-02-09 19:08:22 -05:00
Jon Dufresne
a98bcfb0dd
Refs #15362 -- Removed obsolete workaround in file_uploads test view.
2019-02-09 18:44:28 -05:00
Vinay Karanam
5a36c81f58
Fixed #29391 -- Made PostgresSimpleLookup respect Field.get_db_prep_value().
2019-02-09 18:05:50 -05:00
Jon Dufresne
c492fdfd24
Removed default empty content argument from HttpResponse calls.
2019-02-09 16:27:32 -05:00
Matthias Kestenholz
959d0c078a
Fixed #30153 -- Fixed incorrect form Media asset ordering after three way merge.
...
Delaying merging assets as long as possible avoids introducing
incorrect relative orderings that cause a broken final result.
2019-02-09 09:38:52 -05:00
Sergey Fedoseev
1933e56eca
Removed uneeded generator expressions and list comprehensions.
2019-02-09 09:18:48 -05:00
Sergey Fedoseev
b1a2ad6925
Removed uneeded iter() calls with generator expression as argument.
2019-02-09 09:18:22 -05:00
Simon Charette
b8c48d06fa
Refs #26608 -- Added a database feature for fixed frame range distance support.
2019-02-09 08:47:41 -05:00
Simon Charette
64d5bafbc6
Fixed #30027 -- Errored out on Window function usage if unsupported.
2019-02-09 08:47:41 -05:00
Simon Charette
ebd2fe1861
Refs #30027 -- Enabled window function tests on SQLite 3.25+.
2019-02-09 08:47:40 -05:00
Tim Graham
ea87a85fad
Dropped support for GEOS 3.4.
2019-02-09 08:40:55 -05:00
Himanshu Lakhara
22aab8662f
Fixed #30004 -- Changed default FILE_UPLOAD_PERMISSION to 0o644.
2019-02-08 14:53:15 -05:00
Tim Graham
e7fd69d051
Fixed #30166 -- Dropped support for GDAL 1.11.
2019-02-08 14:08:05 -05:00
Jon Dufresne
6eb4996672
Fixed #30165 -- Deprecated ugettext(), ugettext_lazy(), ugettext_noop(), ungettext(), and ungettext_lazy().
2019-02-08 10:05:53 -05:00
Gregory N. Schmit
48c17807a9
Fixed #16027 -- Added app_label to ContentType.__str__().
2019-02-07 19:56:47 -05:00
Jon Dufresne
af1434329f
Removed unnecessary type() calls for class methods.
2019-02-06 22:00:32 -05:00
Tim Graham
77d25dbd0f
Refs #27753 -- Favored SafeString over SafeText.
2019-02-06 14:12:06 -05:00
Tim Graham
d55e882927
Refs #27753 -- Deprecated django.utils.encoding.force_text() and smart_text().
2019-02-06 14:12:06 -05:00
Aymeric Augustin
3bb6a4390c
Refs #27753 -- Favored force/smart_str() over force/smart_text().
2019-02-06 14:12:06 -05:00
Nick Pope
24b82cd201
Fixed #30159 -- Removed unneeded use of OrderedDict.
...
Dicts preserve order since Python 3.6.
2019-02-06 13:48:39 -05:00
Jon Dufresne
10b0fd1576
Refs #27804 -- Used subTest() in admin_scripts invalid name tests.
2019-02-06 12:59:55 -05:00
Jon Dufresne
487d904bf2
Simplified temporary directory handling in AdminScriptTestCase.
...
Use tempfile.TemporaryDirectory() in AdminScriptTestCase.setUp()
to create and destroy a temporary directory for each test. It removes
the need for individual tests to delete files.
For test classes that don't use the temporary directory, inherit from
SimpleTestCase.
2019-02-05 12:11:54 -05:00
Jon Dufresne
099c36d546
Replaced manual current directory management with subprocess's cwd argument.
2019-02-05 11:01:36 -05:00
Jon Dufresne
4d425abc84
Removed redundant os.chdir() in RunInTmpDirMixin child classes.
...
setUp() already calls os.chdir(self.test_dir).
2019-02-05 11:00:04 -05:00
Jon Dufresne
1e280f031e
Removed unused branch from SymlinkExtractorTests.test_symlink().
...
Unused since bb7bb379e8
2019-02-05 08:14:23 -05:00
Jon Dufresne
680cc417d3
Removed unused RunInTmpDirMixin.rmfile().
...
Unused since bb7bb379e8
2019-02-05 13:44:32 +01:00
Tim Graham
83c2bc52c2
Refs #27753 -- Deprecated django.utils.http urllib aliases.
2019-02-04 18:53:11 -05:00
Tim Graham
39ebdf5a3c
Fixed #30155 -- Dropped support for PostgreSQL 9.4 and PostGIS 2.1.
2019-02-04 18:07:02 -05:00
Vinay Karanam
3634560fa9
Fixed #29393 -- Prevented infinite loop in ExceptionReporter.get_traceback_frames().
2019-02-02 16:39:36 -05:00
Kathryn Killebrew
75d627888b
Fixed #30020 -- Fixed reading nulls with LayerMapping.
2019-01-31 19:50:16 -05:00
Jon Dufresne
290d8471bb
Fixed #30147 -- Simplified directory creation with os.makedirs(..., exist_ok=True).
2019-01-31 12:53:36 -05:00
Johannes Hoppe
b131f9c79f
Refs #29444 -- Renamed DatabaseFeatures.can_return_id* to be generic for other columns.
2019-01-30 15:31:56 -05:00
Joshua Cannon
16a5a2a2c8
Fixed #30076 -- Added Model.get_FOO_display() even if field's choices are empty.
2019-01-30 13:44:10 -05:00
Tim Graham
7e6b214ed3
Fixed #30116 -- Dropped support for Python 3.5.
2019-01-30 10:19:48 -05:00
Dan Tao
738faf9da2
Fixed #30108 -- Allowed adding foreign key constraints in the same statement that adds a field.
2019-01-29 15:42:57 -05:00
Tim Graham
9a0cc54524
Refs #30137 -- Fixed template test on Windows.
...
Broken in 7785e03ba8
2019-01-29 10:05:10 -05:00
rsiemens
a168e5616c
Fixed #29973 -- Added compilemessages --ignore option.
2019-01-28 18:23:41 -05:00
rsiemens
bc9f0b3203
Refs #29973 -- Extracted helper functions from makemessages.
2019-01-28 18:23:41 -05:00
Claude Paroz
16454ac35f
Fixed #29825 -- Fixed JS ngettext if the string is a non-plural msgid in the catalog.
2019-01-28 21:04:36 +01:00
Tom Forbes
1e92407f83
Fixed #25624 -- Fixed autoreload crash with jinja2.ModuleLoader.
2019-01-28 14:17:50 -05:00
Paveł Tyślacki
62b8596616
Made test table cleanup in OperationTestBase more robust.
...
Some non-unique constraint names were added in
b69f8eb04c
2019-01-28 11:51:23 -05:00
Jon Dufresne
7785e03ba8
Fixed #30137 -- Replaced OSError aliases with the canonical OSError.
...
Used more specific errors (e.g. FileExistsError) as appropriate.
2019-01-28 11:15:06 -05:00
Tim Graham
7444f32527
Refs #30055 -- Added a helpful error when SQLite is too old.
2019-01-28 11:14:45 -05:00
Jon Dufresne
7e3bf2662b
Removed default mode='r' argument from calls to open().
2019-01-27 17:41:43 -05:00
Jon Dufresne
ce7293bc91
Refs #23919 -- Replaced codecs.open() with open().
...
On Python 3, open() handles encodings.
2019-01-27 17:39:57 -05:00
Jon Dufresne
00b2e4b67c
Added missing assert in FileBasedCacheTests.test_creates_cache_dir_if_nonexistent().
2019-01-26 16:38:46 -05:00
Jon Dufresne
ac956dae1d
Fixed grammar in FakePayload exception message.
2019-01-25 08:43:21 -08:00
Hasan Ramezani
7e978fdc42
Completed test coverage for utils.text._replace_entity().
2019-01-23 19:33:21 -05:00
Nick Pope
0ef9979669
Fixed #30123 -- Removed tuple support in DatabaseIntrospection.get_field_type().
...
Support for returning tuples was undocumented and error prone.
2019-01-23 13:18:03 -05:00
Tim Graham
2de7eb6f4d
Refs #30111 -- Fixed test cleanup in postgres_tests/test_integration.py.
...
Fixed "ERROR: Step ‘Publish JUnit test result report’ failed: No test report
files were found. Configuration error?" on Jenkins because report files were
put in tests/postgres_tests.
2019-01-23 11:34:55 -05:00
Nasir Hussain
2804b8d215
Fixed #30111 -- Fixed AppRegistryNotReady error with django.contrib.postgres in INSTALLED_APPS.
...
Regression in e192223ed9
2019-01-22 17:49:30 -05:00
Vytis Banaitis
d02b2aa11e
Made assertOptimizesTo() more strict in migrations tests.
...
A recursive deconstruction is needed because comparing deconstructed
operations doesn't check field attributes. Fixed typo in failing test.
2019-01-21 17:29:46 -05:00
Tim Graham
2110b17924
Tested Model.set_FOO_order() with an unrelated object.
2019-01-21 17:02:15 -05:00
Jon Dufresne
d15c61cabb
Fixed #30121 -- Fixed assertURLEqual() crash with reverse_lazy() URLs.
...
Regression in 24959e48d9
2019-01-21 09:31:33 -05:00
Simon Charette
65858119d2
Fixed #30120 -- Fixed invalid SQL in distinct aggregate.
...
Regression in bc05547cd8#28658 ).
2019-01-21 09:24:32 -05:00
Hasan Ramezani
838e432e3e
Completed test coverage for utils.text.Truncator.chars().
2019-01-19 18:45:41 -05:00
Mariusz Felisiak
f05c02c4b8
Fixed #30117 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.4.0+.
2019-01-19 13:31:15 +01:00
Tim Graham
06670015f7
Increased the default PBKDF2 iterations for Django 3.0.
2019-01-17 11:15:27 -05:00
Tim Graham
f5060a1385
Advanced deprecation warnings for Django 3.0.
2019-01-17 11:15:27 -05:00
Tim Graham
da1de1615c
Refs #28750 -- Removed suppport for model Meta.manager_inheritance_from_future.
2019-01-17 11:15:27 -05:00
Tim Graham
6079ed82f4
Refs #27991 -- Made obj a required argument of InlineModelAdmin.has_add_permission().
...
Per deprecation timeline.
2019-01-17 11:14:07 -05:00
Tim Graham
92d4d0859a
Refs #21221 -- Removed staticfiles and admin_static template tag libraries.
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
958a7b4ca6
Refs #28965 -- Removed utils.http.cookie_date() per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
6f23996a59
Refs #28841 -- Removed ForceRHR function per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
1fecde6be9
Refs #11557 -- Removed the field_name keyword argument to QuerySet.earliest() and latest().
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
da5eb3d56c
Refs #28370 -- Removed support for the context arg of Field.from_db_value() and Expression.convert_value().
...
Per deprecation timeline.
2019-01-17 10:52:19 -05:00
Tim Graham
8045dff98c
Refs #27829 -- Removed settings.DEFAULT_CONTENT_TYPE per deprecation timeline.
2019-01-17 10:50:25 -05:00
Tim Graham
573ec714e5
Refs #25978 -- Removed shortcuts.render_to_response() per deprecation timeline.
2019-01-17 10:50:25 -05:00
Simon Charette
f84ad16ba4
Refs #17198 -- Detected existing total ordering in admin changelist.
...
Appending pk is not necessary when a subset of the ordering expressions is
contained in a non-nullable unique contraint.
Related field ordering through lookups and related ordering introspection is
omitted for simplicitly purpose.
2019-01-17 16:22:14 +01:00
Simon Charette
9e5e5a657b
Fixed #30044 -- Raised a FieldError on inherited field update attempts.
2019-01-16 14:09:51 -05:00
Santiago Basulto
4fc35a9c3e
Fixed #20147 -- Added HttpRequest.headers.
2019-01-16 13:38:47 -05:00
Simon Charette
aa5d0a5a90
Removed unnecessary transaction wrapping in expressions test.
2019-01-16 13:23:55 -05:00
Arthur Rio
181fb60159
Fixed #11154 , #22270 -- Made proxy model permissions use correct content type.
...
Co-Authored-By: Simon Charette <charette.s@gmail.com>
Co-Authored-By: Antoine Catton <acatton@fusionbox.com>
2019-01-16 10:07:28 -05:00
Collin Anderson
769355c765
Fixed #9475 -- Allowed RelatedManager.add(), create(), etc. for m2m with a through model.
2019-01-15 11:12:17 -05:00
Nasir Hussain
f021c110d0
Fixed #30099 -- Fixed invalid SQL when filtering a Subquery by an aggregate.
2019-01-15 07:22:59 -05:00
Mariusz Felisiak
1508e71c5b
Relaxed assertions to fix GIS test failures on Oracle 18c.
2019-01-14 18:32:42 -05:00
Simon Charette
b181aba7dd
Refs #28478 -- Prevented database feature based skipping on tests disallowing queries.
...
Database features may require a connection to be established to determine
whether or not they are enabled.
2019-01-14 16:16:30 -05:00
Simon Charette
f5b635086a
Refs #28478 -- Prevented connection attempts against disallowed databases in tests.
...
Mocking connect as well as cursor methods makes sure an appropriate error
message is surfaced when running a subset of test attempting to access a
a disallowed database.
2019-01-14 16:05:00 -05:00
Nick Pope
6d4efa8e6a
Refs #28643 -- Changed Variance() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:39:46 -05:00
Nick Pope
e85afa5943
Refs #28643 -- Changed StdDev() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:38:00 -05:00
Nick Pope
c690afb873
Refs #28643 -- Changed Avg() to use NumericOutputFieldMixin.
...
Keeps precision instead of forcing DecimalField to FloatField.
2019-01-14 14:35:41 -05:00
Sergey Fedoseev
b86bb47818
Fixed #30093 -- Fixed ordering of combined queryset ordered by F expressions.
2019-01-14 10:28:11 -05:00
Simon Charette
b2c598e30d
Removed unnecessary skipUnlessDBFeature.
...
None of the tests interact with the database.
2019-01-13 21:48:40 -05:00
Tom Forbes
c8720e7696
Fixed #27685 -- Added watchman support to the autoreloader.
...
Removed support for pyinotify (refs #9722 ).
2019-01-13 20:33:47 -05:00
Simon Charette
a02a6fd580
Refs #28478 -- Prevented connection creation in model_indexes tests.
...
Entering a SchemaEditor instance creates a connection but it isn't needed
for this test.
2019-01-13 13:47:08 -05:00
orlnub123
573f44d62f
Fixed #30057 -- Fixed diffsettings ignoring custom configured settings.
...
Regression in 49b679371f
2019-01-12 11:07:03 -05:00
Nick Pope
abf8e390a4
Refs #28643 -- Added Reverse database function.
...
Thanks Mariusz Felisiak for Oracle advice and review.
2019-01-12 10:45:48 -05:00
Paveł Tyślacki
b69f8eb04c
Fixed #30062 -- Added support for unique conditional constraints.
2019-01-12 09:50:20 -05:00
Paveł Tyślacki
f4c0c0b0aa
Added tests for Check/UniqueConstraint.__eq__().
2019-01-12 09:24:22 -05:00
can
e192223ed9
Fixed #29738 -- Allowed serializing psycopg2 range types in migrations.
2019-01-11 19:32:26 -05:00
can
7d3b3897c1
Refs #29738 -- Allowed registering serializers with MigrationWriter.
2019-01-11 18:13:16 -05:00
MaximZemskov
3c01fe30f3
Fixed #30097 -- Made 'obj' arg of InlineModelAdmin.has_add_permission() optional.
...
Restored backwards compatibility after refs #27991 .
Regression in be6ca89396
2019-01-11 18:02:43 -05:00
Tim Graham
8f4eee1777
Moved django.db.migrations.writer.SettingsReference to django.conf.
...
Reduces the possibility of circular imports.
2019-01-11 15:28:22 -05:00
Sanyam Khurana
76d31be2d0
Refs #23829 -- Made ping_google command/function use https for the sitemap URL.
2019-01-11 10:32:22 -05:00
Simon Charette
41e73de39d
Fixed #28478 -- Make DiscoverRunner skip creating unused test databases.
...
SimpleTestCase.databases makes it possible to determine the set of
databases required to run the discovered tests.
2019-01-10 19:11:21 -05:00
Simon Charette
8c775391b7
Refs #28478 -- Deprecated TestCase's allow_database_queries and multi_db in favor of databases.
2019-01-10 19:11:21 -05:00
Paveł Tyślacki
647be06538
Renamed variables after generalization of constraints.
...
Follow up to 8eae094638
2019-01-10 18:54:41 -05:00
Mads Jensen
4b9d72210f
Refs #28643 -- Added NullIf database function.
...
Thanks Nick Pope, Mariusz Felisiak, and Tim Graham for reviews.
2019-01-10 12:10:12 -05:00
Joshua Cannon
db1b10ef0d
Fixed #30037 -- Added request arg to RemoteUserBackend.configure_user().
2019-01-09 20:01:04 -05:00
Simon Charette
bc05547cd8
Fixed #28658 -- Added DISTINCT handling to the Aggregate class.
2019-01-09 17:52:36 -05:00
Benjy Weinberger
222caab68a
Fixed #30071 -- Fixed error message when a 'default' database isn't provided.
2019-01-09 10:58:37 -05:00
Benjy Weinberger
c2c85663e2
Fixed #30087 -- Tested error handling for empty 'default' database.
2019-01-09 10:58:25 -05:00
Nick Pope
a35d2a4510
Refs #23748 -- Added AutoField introspection for SQLite.
2019-01-09 09:59:15 -05:00
Tom Hacohen
1ecc0a395b
Fixed #30070 , CVE-2019-3498 -- Fixed content spoofing possiblity in the default 404 page.
...
Co-Authored-By: Tim Graham <timograham@gmail.com>
2019-01-03 21:21:55 -05:00
Mariusz Felisiak
e49ab72637
Refs #29851 -- Fixed test_subquery_row_range_rank() crash on MariaDB 10.2+.
...
Thanks Tom Forbes for the report.
2019-01-03 20:18:45 +01:00
Tim Graham
b5fe97a34e
Added __init__.py for db_utils tests.
2019-01-02 18:19:45 -05:00
Tim Graham
0004daa536
Used 4 space hanging indent for dictionaries.
...
Thanks Mariusz Felisiak for auditing.
2019-01-02 18:18:19 -05:00
Tim Graham
e4a714b259
Pinned Pillow != 5.4.0 in test requirements.
...
There's a bug that causes a test failure in forms_tests:
https://github.com/python-pillow/Pillow/pull/3501/files#r244651761 .
2019-01-02 17:15:39 -05:00
Patrik Sletmo
14e2b1b065
Fixed #29981 -- Fixed inline formsets with a OnetoOneField primary key that uses to_field.
2019-01-01 10:40:22 -05:00
Tim Graham
02c07be95c
Fixed #30050 -- Fixed InlineModelAdmin.has_change_permission() called with non-None obj during add.
...
Thanks andreage for the report and suggested fix.
2019-01-01 09:42:14 -05:00
Paveł Tyślacki
0123b67f6b
Fixed #30060 -- Moved SQL generation for indexes and constraints to SchemaEditor.
2019-01-01 09:39:58 -05:00
Tim Graham
043bd70942
Updated test URL patterns to use path() and re_path().
2018-12-31 10:47:32 -05:00
Tim Graham
1136d57f01
Updated a test to reflect the fact that "import *" isn't used in URLconfs anymore (refs #14675 ).
2018-12-31 10:24:28 -05:00
Matt Wiens
e817ae74da
Followed style guide for model attribute ordering.
2018-12-27 19:34:14 -05:00
Mariusz Felisiak
dd8ed64113
Fixed #29851 -- Fixed crash of annotations with window expressions in Subquery.
2018-12-27 20:21:57 +01:00
Jon Dufresne
6fe9c45b72
Fixed #30024 -- Made urlencode() and Client raise TypeError when None is passed as data.
2018-12-27 11:19:55 -05:00
CHI Cheng
b7dbd5ff68
Fixed broken links to PyYAML page.
2018-12-27 10:48:37 +01:00
Denis Stebunov
277de22984
Fixed #30058 -- Made SMTP EmailBackend.send_messages() return 0 for empty/error cases.
2018-12-26 13:33:08 -05:00
Tim Graham
0b54ab0675
Refs #30033 -- Fixed schema's test_m2m_rename_field_in_target_model test failure on SQLite < 3.20.
...
Mixing local test models with non-local models resulted in a referential
integrity error during tear down since the models are removed in separate
schema editor instances which each check constraints.
Failure appeared after 7289874adc
2018-12-26 11:26:51 -05:00
Tim Graham
b74b6736d0
Refs #29547 -- Skipped an unsupported partial index test on older versions of SQLite.
...
Follow up to e5b8626c0e
2018-12-26 11:20:11 -05:00
Simon Charette
64f9776bc4
Refs #29004 -- Prevented inspectdb tests from flushing all tables data.
...
This is a costly operation on most database backends.
2018-12-24 15:32:39 -05:00
Simon Charette
f6d8b0c47e
Refs #26840 -- Corrected SQLite connection mocking in a setup_databases() test.
...
The test was expecting connections used by DiscoverRunner.setup_databases()
to be the ones defined in django.test.runner but this doesn't hold true
since this method was made a proxy of django.test.utils.setup_databases.
This broke the TransactionTestCase.serialized_rollback feature in the test
suite because calls to create_db_test() cleared the test data persisted on
connections objects.
Added an assertions to prevent this from happening again.
2018-12-24 15:32:27 -05:00
Nick Pope
83677faf86
Fixed #30056 -- Added SQLite support for StdDev and Variance functions.
2018-12-24 11:14:58 -05:00
Sanyam Khurana
5d25804eaf
Fixed #20098 -- Added a check for model Meta.db_table collisions.
2018-12-24 10:40:11 -05:00
Nick Pope
e626a3f993
Renamed Sqlite and Sqlite3 references to SQLite.
2018-12-22 18:52:54 -05:00
Nick Pope
7534e43497
Refs #14204 -- Removed obsolete referential integrity comment for SQLite.
2018-12-22 18:44:21 -05:00
Sergey Fedoseev
a68ea23101
Fixed #29970 , #30041 -- Made ModelBase.__new__() pass attrs without contribute_to_class() to type.__new__().
2018-12-22 18:11:24 -05:00
Simon Charette
25a0781a16
Refs #29182 -- Corrected SQLite's supports_atomic_references_rename feature flag.
2018-12-22 14:58:08 -05:00
Simon Charette
e5b8626c0e
Refs #29547 -- Corrected SQLite's supports_partial_indexes feature flag.
2018-12-22 14:51:59 -05:00
Simon Charette
20f6f9eaa1
Renamed SQLite3 references to to SQLite.
...
The version suffix isn't part of the product name.
2018-12-22 14:20:43 -05:00
François Freitag
e671337e8b
Fixed #29750 -- Added View.setup() hook for class-based views.
2018-12-21 19:01:11 -05:00
jtiai
5a77190e66
Fixed #29792 -- Made GeometryField.deconstruct() handle 'extent' and 'tolerance' args.
2018-12-21 17:44:45 -05:00
jtiai
7b9f8e38bb
Added tests for GeometryField.deconstruct().
2018-12-21 17:41:39 -05:00
Tim Graham
194a4b526c
Added tests for ContentType/Group/Permission.__str__().
2018-12-21 12:45:02 -05:00
Dakota Hawkins
8d3147e130
Fixed #30031 -- Added --no-header option to makemigrations/squashmigrations.
2018-12-19 12:41:31 +01:00
Konstantin Alekseev
b514dc14f4
Fixed #30015 -- Ensured request body is properly consumed for keep-alive connections.
2018-12-19 11:27:08 +01:00
Simon Charette
894cb13779
Refs #29182 -- Stopped relying on legacy alter table semantic on SQLite 3.26+.
...
SQLite 3.26 changed the behavior of table and column renaming operations to
repoint foreign key references even if foreign key checks are disabled.
This makes the workarounds in place to simulate this behavior unnecessary on
SQLite 3.26+. Refs #30033 .
2018-12-17 10:44:05 +01:00
Simon Charette
315357ad25
Fixed #30023 -- Prevented SQLite schema alterations while foreign key checks are enabled.
...
Prior to this change foreign key constraint references could be left pointing
at tables dropped during operations simulating unsupported table alterations
because of an unexpected failure to disable foreign key constraint checks.
SQLite3 does not allow disabling such checks while in a transaction so they
must be disabled beforehand.
Thanks ezaquarii for the report and Carlton and Tim for the review.
2018-12-15 18:51:59 -05:00
Manan
3a4558b84f
Moved choices inside of test models per coding style.
2018-12-10 09:28:49 -05:00
Benjamin Wohlwend
79c196cfb2
Fixed #28766 -- Added ResolverMatch.route.
...
Co-Authored-By: Xavier Fernandez <xavier.fernandez@polyconseil.fr>
2018-12-06 18:05:40 -05:00
Mariusz Felisiak
f9a33e3c3f
Fixed #29932 -- Fixed combining compound queries with sub-compound queries on SQLite and Oracle.
2018-12-06 15:31:33 -05:00
Patrick Arminio
ae180fa4b7
Fixed #29986 -- Added .format() support to ngettext_lazy strings.
2018-12-06 15:12:34 -05:00
Simon Charette
53269bcaaf
Fixed #30011 -- Fixed queries that reuse filtered aggregates.
...
Thanks Taqi Abbas and Raphael Kimmig for the report.
2018-12-06 14:55:35 -05:00
Tim Graham
88619e6129
Bumped mysqlclient requirement to >= 1.3.13.
...
There are test failures with older versions.
2018-12-06 14:49:27 -05:00
Tim Graham
4c7c608a1d
Reverted "Fixed #25251 -- Made data migrations available in TransactionTestCase when using --keepdb."
...
This reverts commits b3b1d3d45f9fa0d3786f
2018-12-05 15:30:23 -05:00
Tim Graham
734ce71824
Refs #30013 -- Fixed SchemaEditor.quote_value() test for mysqlclient 1.3.14+.
2018-12-05 14:46:31 -05:00
François Freitag
fbc7e41389
Tested exception messages in generic_views tests.
2018-12-04 22:52:19 -05:00
Carlton Gibson
8245c99ee6
Fixed #29930 -- Allowed editing in admin with view-only inlines.
...
Co-authored-by: Tim Graham <timograham@gmail.com>
2018-12-03 07:44:18 -08:00
Xavier Fernandez
4d9f51f2b5
Added test for ResolverMatch.__repr__().
2018-11-30 17:43:55 -05:00
Xavier Fernandez
9d334e0a7a
Removed urlpatterns_reverse dependency in urlpatterns tests.
2018-11-30 17:39:34 -05:00
Tim Fiedler
b07273a0f7
Fixed #29987 -- Detected unmanaged model deletions.
2018-11-30 09:57:43 -05:00
Jaap Roes
8a1a919468
Fixed #29997 -- Allowed combining SearchQuerys with different configs.
...
Seems to be a needless restriction in
978a00e39f
2018-11-30 09:42:50 -05:00
Tim Graham
41db8cb252
Used assertCountEqual() in contrib.postgres.search tests.
2018-11-29 14:43:53 -05:00
romgar
9fa0d3786f
Refs #25251 -- Filtered out skipped tests when processing the test suite to set _next_serialized_rollback.
2018-11-29 11:20:27 -05:00
Basil Dubyk
7d1123e5ad
Fixed #29929 -- Fixed admin view-only change form crash when using ModelAdmin.prepopulated_fields.
2018-11-28 15:40:14 -05:00
dmytryi.striletskyi
dcd1025f4c
Fixed #28385 -- Fixed deserializing natural keys when primary key has a default value.
...
Co-Authored-By: Hasan Ramezani <hasan.r67@gmail.com>
2018-11-27 18:35:19 -05:00
Tim Graham
7056a4dd8e
Switched TestCase to SimpleTestCase in GIS tests.
2018-11-27 10:22:13 -05:00
Simon Charette
0f212db29d
Made reused RequestFactory instances class attributes.
2018-11-27 09:49:02 -05:00
Simon Charette
7f63b894c0
Adjusted code style of a few test data setup methods.
...
Thanks Mariusz for suggesting it.
2018-11-27 09:48:22 -05:00
Simon Charette
84e7a9f4a7
Switched setUp() to setUpTestData() where possible in Django's tests.
2018-11-27 09:35:17 -05:00
Tim Graham
193c109327
Switched TestCase to SimpleTestCase where possible in Django's tests.
2018-11-27 08:58:44 -05:00
Mariusz Felisiak
f091ea3515
Refs #29722 -- Added introspection of materialized views for Oracle.
...
Thanks Tim Graham for the review.
2018-11-26 19:45:05 +01:00
Simon Charette
26c2a6ff88
Removed empty setUp() in admindocs tests.
2018-11-26 10:24:01 -05:00
Simon Charette
b8763fc0a4
Used SimpleTestCase for template library tests.
2018-11-26 10:23:35 -05:00
Hasan Ramezani
11a9017179
Fixed #29966 -- Added tests for BaseHandler's "The view didn't return an HttpResponse object" error.
2018-11-23 19:19:02 -05:00
Nick Pope
c512912463
Refs #23801 -- Made integer field max_length warning show correct field type.
2018-11-23 14:40:46 -05:00
Claude Paroz
d7e18a509e
Fixed #29978 -- Catched GDALException in GeometryField.to_python
2018-11-23 09:39:02 +01:00
Tom Forbes
31408446b3
Fixed #29974 -- Fixed non-truthy primary key values for QuerySet.bulk_update().
2018-11-21 22:58:43 -05:00
Tim Graham
5a71bd7f9d
Removed unused views in middleware_exceptions tests.
...
Unused since d334f46b7a
2018-11-21 17:48:09 -05:00
Mariusz Felisiak
d5f4ce9849
Fixed #29949 -- Refactored db introspection identifier converters.
...
Removed DatabaseIntrospection.table_name_converter()/column_name_converter()
and use instead DatabaseIntrospection.identifier_converter().
Removed DatabaseFeatures.uppercases_column_names.
Thanks Tim Graham for the initial patch and review and Simon Charette
for the review.
2018-11-21 09:06:50 +01:00
redodo
2e4776196d
Fixed #29953 -- Added CSS class to column headers in tabular inlines.
...
The class name is the same as one given to the fields in the change list.
2018-11-20 18:17:53 -05:00
Sanyam Khurana
a7d6cab771
Fixed #29282 -- Prevented some admin checks from crashing with TypeError.
...
Co-authored-by: David Sanders <dsanders11@ucsbalum.com>
2018-11-20 17:19:13 -05:00
Tim Graham
ced0bdd923
Tested a middleware's process_template_response() returning None.
2018-11-20 11:35:01 -05:00
redodo
89a2216486
Fixed #29961 -- Made RelatedFieldWidgetWrapper hide related item links if wrapping a hidden widget.
2018-11-19 15:12:52 -05:00
Nick Pope
ebd270627c
Refs #29722 -- Added introspection of partitions for PostgreSQL.
2018-11-19 14:06:01 -05:00
Thomas Grainger
0607699902
Fixed #29478 -- Added support for mangled names to cached_property.
...
Co-Authored-By: Sergey Fedoseev <fedoseev.sergey@gmail.com>
2018-11-19 13:40:49 -05:00
Sergey Fedoseev
80ba7a881f
Fixed cached_properties that share a common property.
...
The aliases aren't cached and thus the old usage will be an error after
refs #29478 .
2018-11-19 08:59:46 -05:00
Tim Graham
9cac10eee4
Added BaseDatabaseSchemaEditor._effective_default() to allow testing without a connection.
2018-11-17 19:27:53 -05:00
Tim Graham
e62f6e0968
Fixed #29505 -- Removed SchemaEditor's calling of callable defaults.
...
Thanks Eugene Pakhomov for the suggested fix.
2018-11-17 19:27:53 -05:00
Hasan Ramezani
ec16588c27
Added test for Model._check_column_name_clashes().
2018-11-17 15:24:48 -05:00
Tim Graham
405ec5b9c6
Fixed typo in tests/admin_views/tests.py.
2018-11-16 15:09:22 -05:00
Mathew Payne
26bb2611a5
Fixed #29952 -- Lowercased all passwords in contrib.auth's auth/common-passwords.txt.gz.
2018-11-15 14:11:03 -05:00
Hasan Ramezani
cf915cb513
Added a test for a lookup in Model.refresh_from_db(fields=[...]).
2018-11-15 11:38:47 -05:00
Ian Foote
e1fc07c047
Fixed #17930 -- Allowed ORing (|) with sliced QuerySets.
2018-11-15 09:43:58 -05:00
Sarah Guermond
cd40306854
Fixed #25884 -- Fixed migrate --run-syncdb when specifying an app label.
2018-11-14 18:22:59 -05:00
Hasan Ramezani
6d4e5feb79
Fixed #29835 -- Made RelatedFieldListFilter respect ModelAdmin.ordering.
2018-11-14 14:29:39 -05:00
Basil Dubyk
35a08b8541
Fixed #17210 -- Made NullBooleanSelect use unknown/true/false as query data.
2018-11-14 13:43:34 -05:00
Mariusz Felisiak
ff8020ed49
Fixed #29788 -- Added support for Oracle Managed File (OMF) tablespaces.
2018-11-13 18:22:41 -05:00
Simon Charette
db13bca60a
Fixed #29641 -- Added support for unique constraints in Meta.constraints.
...
This constraint is similar to Meta.unique_together but also allows
specifying a name.
Co-authored-by: Ian Foote <python@ian.feete.org>
2018-11-13 17:57:27 -05:00
oliver
d0af5de122
Moved duplicate author declarations to setUpTestData() in DeleteViewTests.
2018-11-13 17:27:24 -05:00
Simon Charette
dba4a634ba
Refs #29641 -- Refactored database schema constraint creation.
...
Added a test for constraint names in the database.
Updated SQLite introspection to use sqlparse to allow reading the
constraint name for table check and unique constraints.
Co-authored-by: Ian Foote <python@ian.feete.org>
2018-11-13 15:25:44 -05:00
Simon Charette
2f120ac517
Fixed #29945 -- Moved contrib.postgres uninstallation logic to the app config.
2018-11-12 11:15:48 -05:00
Hasan Ramezani
c7cc7526d5
Completed test coverage of contrib.humanize.templatetags.humanize.
2018-11-10 19:09:37 -05:00
Florian Apolloner
934acf1126
Fixed keep-alive support in manage.py runserver.
...
Ticket #25619 changed the default protocol to HTTP/1.1 but did not
properly implement keep-alive. As a "fix" keep-alive was disabled in
ticket #28440 to prevent clients from hanging (they expect the server to
send more data if the connection is not closed and there is no content
length set).
The combination of those two fixes resulted in yet another problem:
HTTP/1.1 by default allows a client to assume that keep-alive is
supported unless the server disables it via 'Connection: close' -- see
RFC2616 8.1.2.1 for details on persistent connection negotiation. Now if
the client receives a response from Django without 'Connection: close'
and immediately sends a new request (on the same tcp connection) before
our server closes the tcp connection, it will error out at some point
because the connection does get closed a few milli seconds later.
This patch fixes the mentioned issues by always sending 'Connection:
close' if we cannot determine a content length. The code is inefficient
in the sense that it does not allow for persistent connections when
chunked responses are used, but that should not really cause any
problems (Django does not generate those) and it only affects the
development server anyways.
Refs #25619 , #28440 .
2018-11-10 13:54:45 +01:00
Tim Graham
f82be9ebc7
Fixed #29934 -- Added sqlparse as a require dependency.
2018-11-09 19:09:36 -05:00
Matthias Kestenholz
f9ff1df1da
Fixed #29917 -- Stopped collecting ModelAdmin.actions from base ModelAdmins.
2018-11-09 18:52:30 -05:00
Srinivas Thatiparthy (శ్రీనివాస్ తాటిపర్తి)
a7ef4a56e0
Fixed #29920 -- Added a test for smart_urlquote()'s UnicodeError branch.
2018-11-09 12:39:08 -05:00
oliver
9b110f0a84
Moved duplicate author declarations to setUpTestData() in UpdateViewTests.
2018-11-09 15:26:52 +01:00
Simon Charette
75dfa92a05
Fixed #29908 -- Fixed setting of foreign key after related set access if ForeignKey uses to_field.
...
Adjusted known related objects handling of target fields which relies on
from and to_fields and has the side effect of fixing a bug bug causing
N+1 queries when using reverse foreign objects.
Thanks Carsten Fuchs for the report.
2018-11-08 19:51:15 -05:00
oliver
0ce2ad9ca4
Used QuerySet.bulk_create() in a couple tests.
2018-11-06 19:32:40 -05:00
romgar
b3b1d3d45f
Fixed #25251 -- Made data migrations available in TransactionTestCase when using --keepdb.
...
Data loaded in migrations were restored at the beginning of each
TransactionTestCase and all the tables are truncated at the end of
these test cases. If there was a TransactionTestCase at the end of
the test suite, the migrated data weren't restored in the database
(especially unexpected when using --keepdb). Now data is restored
at the end of each TransactionTestCase.
2018-11-06 16:57:50 -05:00
Tom Forbes
ecac6d7a2a
Improved performance of runtests.py with os.scandir().
2018-11-04 18:56:46 -05:00
Hasan Ramezani
6b7f1c2530
Increased test coverage of django.utils.http.
2018-11-03 11:13:28 -04:00
Tom Forbes
d207ac1568
Fixed #29883 -- Added selenium hub support to runtests.py.
2018-11-03 09:56:14 -04:00
Jayantha Gumballi
dfcdc8992f
Fixed #29886 -- Fixed unaccent lookup when PostgreSQL's standard_conforming_strings option is off.
...
Thanks Tom McClure for the patch.
2018-11-01 11:14:34 -04:00
Tim Graham
98ef3829e9
Fixed #29890 -- Fixed FileSystemStorage crash if concurrent saves try to create the same directory.
...
Regression in 632c4ffd9c
2018-10-31 19:28:11 -04:00
Javier Matos Odut
3d4d0a25b2
Fixed #29901 -- Allowed overriding an autocomplete/raw_id_fields/radio_fields widget with ModelAdmin.get_formset().
2018-10-31 10:16:17 -04:00
Junyoung
df448bfd02
Fixed #29783 -- Added app label validation to showmigrations command.
2018-10-30 19:29:00 -04:00
Artur Juraszek
817c6cdf0e
Capitalized SecurityMiddleware headers for consistency with other headers.
...
(No behavior change since HTTP headers are case insensitive.)
2018-10-30 18:30:51 -04:00
Hasan Ramezani
c1c68d1ac0
Increased test coverage of django/views/generic/dates.py.
2018-10-30 14:27:48 -04:00
Jayden Kneller
916aecd29d
Fixed #29866 -- Made DiscoverRunner do tests tear down if running checks or tests raises an exception.
2018-10-30 12:01:48 -04:00
Simon Charette
630f3d8b46
Refs #29868 -- Prevented name collisions between test constraints on Oracle.
2018-10-30 09:26:03 -04:00
Mads Jensen
a906c98982
Fixed #29547 -- Added support for partial indexes.
...
Thanks to Ian Foote, Mariusz Felisiak, Simon Charettes, and
Markus Holtermann for comments and feedback.
2018-10-29 19:34:54 -04:00
Hasan Ramezani
4f8f1b2f24
Fixed #29903 -- Added error message for invalid WeekArchiveView week_format.
2018-10-29 14:22:42 -04:00
Simon Charette
d8e03fdeb9
Fixed #29897 -- Fixed autodetector's swappable MTI dependency resolution.
...
Thanks Steven Ganz for the detailed report.
2018-10-29 11:24:30 -04:00
Simon Charette
95bda03f2d
Fixed #29868 -- Retained database constraints on SQLite table rebuilds.
...
Refs #11964 .
Thanks Scott Stevens for testing this upcoming feature and the report.
2018-10-29 10:33:41 +01:00
Tim Graham
f77fc56c96
Fixed #29896 -- Fixed incorrect Model.save() cache relation clearing for foreign keys that use to_field.
...
Regression in ee49306176
2018-10-28 22:54:02 -04:00
Hasan Ramezani
4c13b90702
Added test coverage for views.generic.dates.MonthMixin.get_month() KeyError branch.
2018-10-27 18:37:44 -04:00
Tim Graham
f892781b95
Fixed #28606 -- Deprecated CachedStaticFilesStorage.
2018-10-27 11:58:29 -04:00
Hasan Ramezani
55b0b766fb
Completed test coverage of views.defaults.bad_request().
2018-10-25 20:03:58 -04:00
Mariusz Felisiak
c6525bea9e
Fixed #29534 -- Made dbshell use rlwrap on Oracle if available.
2018-10-25 19:39:42 -04:00
Sergey Fedoseev
9a88c6dd6a
Fixed #29827 -- Fixed reuse of test databases with --keepdb on MySQL.
...
Regression in e1253bc26f
2018-10-25 19:37:41 -04:00
Sanyam Khurana
83c7096f2a
Fixed #29869 -- Made UUIDField.to_python() convert integers.
2018-10-24 20:26:57 -04:00
Sanyam Khurana
c86a3d80a2
Fixed #29721 -- Ensured migrations are applied and recorded atomically.
2018-10-24 19:29:11 -04:00
Simon Charette
32da3cfdf9
Refs #11964 -- Removed raw SQL from and cleaned up constraint operation tests.
2018-10-24 19:18:41 -04:00
Tom Forbes
8f90593e6f
Removed obsolete and flaky GeoIP tests.
2018-10-23 20:46:49 -04:00
Hasan Ramezani
6a8b57df6a
Completed test coverage of views.static.directory_name().
2018-10-23 20:44:27 -04:00
Prabakaran Kumaresshan
10d82c85aa
Fixed #29831 -- Added validation for makemigrations --name.
2018-10-23 10:05:24 -04:00
jannschu
efc0f77f02
Fixed #29830 -- Fixed loss of custom utf-8 body encoding in mails.
2018-10-22 15:21:33 -04:00
buzzi
24cae0bedc
Fixed #29860 -- Allowed BaseValidator to accept a callable limit_value.
2018-10-22 10:26:54 -04:00
Simon Charette
5e3463f6bc
Fixed #27595 -- Made ForeignKey.get_col() follow target chains.
...
Previously, foreign relationships were followed only one level deep which
prevents foreign keys to foreign keys from being resolved appropriately.
This was causing issues such as improper database value conversion for
UUIDField on SQLite because the resolved expression's output field's
internal type wasn't correct. Added tests to make sure unlikely foreign
reference cycles don't cause recursion errors.
Refs #24343 .
Thanks oyooyo for the report and Wayne Merry for the investigation.
2018-10-22 09:49:34 -04:00
Florian Apolloner
c53af56613
Fixed #29847 -- Ensured proper ordering in queries.
...
Even though good databases tend to keep the result sorted by the/one
window expression and the planners are smart enough to not resort if not
required, it is not valid to rely on this.
MariaDB specifically did return whatever order it wanted, which is
completely okay. Now we sort towards the expected data for all databases.
2018-10-21 22:05:06 +02:00
Florian Apolloner
e127ef62de
Fixed a failing test when the source directory is on a readonly fs.
2018-10-21 19:37:58 +02:00
Mariusz Felisiak
328f5627dd
Fixed #29870 -- Added DurationField introspection for Oracle and PostgreSQL.
...
Thanks Tim Graham for the review.
2018-10-21 09:08:05 +02:00
aspalding
dc5e75d419
Fixed #29838 -- Fixed crash when combining Q objects with __in lookups and lists.
...
Regression in fc6528b25a
2018-10-17 11:34:49 -04:00
aspalding
217f82d713
Refs #29838 -- Fixed make_hashable() for values that have lists or dicts nested in tuples.
...
And for non-hashable values that are iterable, e.g. sets.
2018-10-17 11:17:50 -04:00
aspalding
834c4ec8e4
Moved make_hashable() to django.utils and added tests.
2018-10-17 11:17:23 -04:00
Florian Apolloner
bc7dd8490b
Fixed #21171 -- Avoided starting a transaction when a single (or atomic queries) are executed.
...
Checked the following locations:
* Model.save(): If there are parents involved, take the safe way and use
transactions since this should be an all or nothing operation.
If the model has no parents:
* Signals are executed before and after the previous existing
transaction -- they were never been part of the transaction.
* if `force_insert` is set then only one query is executed -> atomic
by definition and no transaction needed.
* same applies to `force_update`.
* If a primary key is set and no `force_*` is set Django will try an
UPDATE and if that returns zero rows it tries an INSERT. The first
case is completly save (single query). In the second case a
transaction should not produce different results since the update
query is basically a no-op then (might miss something though).
* QuerySet.update(): no signals issued, single query -> no transaction
needed.
* Model/Collector.delete(): This one is fun due to the fact that is
does many things at once.
Most importantly though: It does send signals as part of the
transaction, so for maximum backwards compatibility we need to be
conservative.
To ensure maximum compatibility the transaction here is removed only
if the following holds true:
* A single instance is being deleted.
* There are no signal handlers attached to that instance.
* There are no deletions/updates to cascade.
* There are no parents which also need deletion.
2018-10-17 12:19:02 +02:00
Mads Jensen
1c0bf95ff6
Refs #23919 -- Removed a stray object-inheritance.
...
Follow up to 081e787160
2018-10-16 09:58:53 -04:00
Jon Dufresne
0cd465b63a
Fixed #29817 -- Deprecated settings.FILE_CHARSET.
2018-10-15 17:15:41 -04:00
Jon Dufresne
99d4fc18bd
Refs #27829 -- Added warning for settings.DEFAULT_CONTENT_TYPE usage outside of Django.
2018-10-15 16:31:39 -04:00
oliver
1299421cad
Fixed #29725 -- Removed unnecessary join in QuerySet.count() and exists() on a many-to-many relation.
2018-10-15 11:01:57 -04:00
Mariusz Felisiak
f2e2a1bd4b
Fixed #29845 -- Fixed Cast crash on MySQL when casting to DecimalField.
2018-10-15 15:57:22 +02:00
Tim Graham
70a80ff1be
Added a urlize test for wrapping characters.
2018-10-12 08:13:52 +02:00
Patrik Sletmo
adfdb9f169
Fixed #29814 -- Added support for NoneType serialization in migrations.
2018-10-11 09:02:14 -04:00
Mariusz Felisiak
52fec5d18f
Fixed #29836 -- Bumped required cx_Oracle to 6.0.
2018-10-11 11:43:16 +02:00
Jon Dufresne
c82893cb8c
Refs #27795 -- Removed force_bytes() usage from django/utils/http.py.
...
django.utils.http.urlsafe_base64_encode() now returns a string, not a
bytestring. Since URLs are represented as strings,
urlsafe_base64_encode() should return a string. All uses immediately
decoded the bytestring to a string anyway.
As the inverse operation, urlsafe_base64_decode() accepts a string.
2018-10-10 14:38:22 -04:00
Hasan Ramezani
b5d7604cb0
Completed FixedOffset test coverage.
2018-10-09 20:32:08 -04:00
Jon Dufresne
e90af8bad4
Capitalized "Python" in docs and comments.
2018-10-09 09:26:07 -04:00
Jon Dufresne
31c0348687
Fixed postgres_tests.test_signals.OIDTests when run in isolation.
2018-10-09 09:23:36 -04:00
Eric Brandwein
b0b4aac555
Fixed #29775 -- Fixed URL converters in a nested namespaced path.
...
When using include() without namespaces of some urlpatterns that
have an include() with namespace, the converters of the parent
include() weren't being used to convert the arguments of reverse().
2018-10-04 11:42:27 -04:00
Jon Dufresne
5a23a285de
Used skip(If|Unless)DBFeature in transactions tests.
2018-10-04 10:09:06 -04:00
Jon Dufresne
9f6d0c11eb
Removed Jinja2 dependency from admin_checks tests.
2018-10-04 16:05:22 +02:00
Jon Dufresne
9b508bdb9b
Removed unnecessary skipUnless in HTTPSitemapTests.
...
contrib.sites is included in INSTALLED_APPS by SitemapTestsBase.
2018-10-04 08:50:18 -04:00
Jon Dufresne
bdae19cf63
Refs #27795 -- Removed force_bytes() usage in sessions.
...
SessionBase.decode() is the inverse operation to SessionBase.encode().
As SessionBase.encode() always returns a string, SessionBase.decode()
should always be passed a string argument. Fixed the file backend, which
was the only backend still passing a bytestring.
2018-10-03 11:11:42 +02:00
Stefano Chiodino
6de7f9ec60
Fixed #29598 -- Deprecated FloatRangeField in favor of DecimalRangeField.
2018-10-02 19:17:23 -04:00
Simon Charette
bc7e288ca9
Fixed #29745 -- Based Expression equality on detailed initialization signature.
...
The old implementation considered objects initialized with an equivalent
signature different if some arguments were provided positionally instead of
as keyword arguments.
Refs #11964 , #26167 .
2018-10-02 19:15:20 -04:00
Nick Pope
bf8b625a3b
Refs #29722 -- Added introspection of materialized views for PostgreSQL.
2018-10-02 14:02:04 -04:00
Nick Pope
45ef3df7d0
Fixed #29719 -- Added introspection of foreign tables for PostgreSQL.
...
Thanks infinite-l00p for the initial patch.
2018-10-02 14:01:24 -04:00
Simon Charette
24dc7d8940
Refs #29641 -- Extracted reusable CheckConstraint logic into a base class.
2018-10-02 13:11:18 -04:00
Simon Charette
9142bebff2
Refs #11964 -- Changed CheckConstraint() signature to use keyword-only arguments.
...
Also renamed the `constraint` argument to `check` to better represent which
part of the constraint the provided `Q` object represents.
2018-10-02 10:53:04 -04:00
Przemysław Buczkowski
70d0a1ca02
Fixed #29711 -- Added a system check for uniquness of admin actions' __name__.
2018-10-02 09:17:23 -04:00
Jon Dufresne
7598cd4748
Fixed #29813 -- Fixed DatabaseOperation test when run in isolation on MySQL.
2018-10-02 08:22:38 -04:00
Abhinav Patil
bf01994a5c
Fixed #29804 -- Added 'did you mean' suggestions for unsupported lookup error.
2018-10-01 19:03:10 -04:00
Jon Dufresne
b3b47bf515
Added tests for using bytearray with BinaryField and corrected docs.
2018-10-01 09:16:16 -04:00
Claude Paroz
fc3a463048
Fixed #29767 -- Made date-related casts work on SQLite
...
Thanks Rémy Hubscher for the report and Tim Graham and Simon Charette for the reviews.
2018-10-01 13:27:30 +02:00
Tim Graham
a7284cc0c3
Fixed #29809 -- Fixed a crash when a "view only" user POSTs to the admin user change form.
2018-10-01 10:09:50 +02:00
Carlton Gibson
bf39978a53
Fixed CVE-2018-16984 -- Fixed password hash disclosure to admin "view only" users.
...
Thanks Claude Paroz & Tim Graham for collaborating on the patch.
2018-10-01 10:05:01 +02:00
Claude Paroz
ddcb9e8062
Refs #21408 -- Updated naturaltime translation test.
...
Upcoming German translations will not differ for past and future naturaltime
translations. Using Czech language instead.
2018-09-29 15:06:11 +02:00
Sergey Fedoseev
8ef8bc0f64
Refs #28909 -- Simplifed code using unpacking generalizations.
2018-09-28 09:57:12 -04:00
Tim Graham
4fc8fb7dda
Tested showmigrations with apps without migrations.
2018-09-28 09:56:40 -04:00
Paweł Kołodziej
05c578bc1f
Fixed #29796 -- Added system check for STATICFILES_DIRS prefix ending with a slash.
2018-09-27 19:49:37 -04:00
Marten Kenbeek
40c8ffad72
Fixed #29768 -- Improved error message when an AppConfig has a typo in INSTALLED_APPS.
2018-09-26 16:12:21 -04:00
Ramon Saraiva
2349cbd909
Fixed #29782 -- Added better error message when filtering queryset with AnonymousUser.
2018-09-26 15:36:19 -04:00
Matthew Power
18098d261f
Fixed #29673 -- Reset the URLconf at the end of each request.
...
Co-authored-by: Ross Thorne <rmwthorne@googlemail.com>
2018-09-26 15:35:24 -04:00
Sergey Fedoseev
91841c77cd
Fixed loaddata error message when uncompressed fixture has a dot in its name.
2018-09-26 15:30:15 -04:00
Jon Dufresne
fb2964a410
Added test of filtering on BinaryField and corrected docs.
2018-09-26 14:38:12 -04:00
Mariusz Felisiak
024abe5b82
Fixed #29630 -- Fixed crash of sliced queries with multiple columns with the same name on Oracle 12.1.
...
Regression in 0899d583bd
2018-09-26 20:18:48 +02:00
Jon Dufresne
82f286cf6f
Refs #29784 -- Switched to https:// links where available.
2018-09-26 08:48:47 +02:00
Oleg
d1d5c97bc2
Fixed #29778 -- Fixed quoting of unique index names.
...
Regression in 3b429c9673
2018-09-25 16:00:20 -04:00
Alexey
8624459586
Added a test for password_changed() with a custom validator.
2018-09-25 11:58:05 -04:00
Jon Dufresne
bb81c22d90
Refs #27795 -- Removed force_bytes() usage in utils/_os.py.
2018-09-25 11:27:36 -04:00
Ian Foote
9a0e0d966a
Refs #11964 -- Renamed a database check constraint test.
2018-09-25 11:14:45 -04:00
Sergey Fedoseev
747db4018b
Simplified AdminFieldExtractionMixin.get_admin_form_fields().
2018-09-25 11:06:41 -04:00
Jon Dufresne
8c3e0eb1c1
Normalized spelling of "lowercase" and "lowercased".
2018-09-25 10:30:18 -04:00
Jon Dufresne
ad9a28ee38
Refs #29784 -- Normalized Python docs links to omit the version.
2018-09-25 10:19:42 +02:00
Tim Graham
495abe0095
Refs #29198 -- Fixed migrate --plan crash if RunSQL uses a list or tuple.
...
Also fixed test failures if sqlparse isn't installed.
2018-09-19 17:13:39 -04:00
Javier Buzzi
a0d63b02c3
Fixed #29772 -- Made LazyObject proxy __lt__() and __gt__().
2018-09-19 13:51:01 -04:00
Tom Forbes
9cbdb44014
Fixed #23646 -- Added QuerySet.bulk_update() to efficiently update many models.
2018-09-18 16:14:44 -04:00
Mariusz Felisiak
7b159df942
Fixed expressions tests when run in reverse.
...
Regression in e7a0a5c8b2
2018-09-18 15:58:20 -04:00
Claude Paroz
f5e347a640
Fixed #27899 -- Added support for phrase/raw searching in SearchQuery.
...
Thanks Tim Graham, Nick Pope, and Claude Paroz for contribution and review.
2018-09-17 12:03:52 -04:00
Sergey Fedoseev
c5e450ac95
Fixed #29761 -- Confirmed support for PROJ 5.x.
2018-09-17 12:03:30 -04:00
Adam Johnson
245c36d7b6
Fixed #29642 -- Added check for arguments of custom error handler views.
2018-09-14 11:59:56 -04:00
Simon Charette
a4495f4b98
Fixed #29755 -- Made migrations detect changes to Meta.default_related_name.
2018-09-14 09:09:17 -04:00
Mariusz Felisiak
e7a0a5c8b2
Simplified expressions.tests.
2018-09-13 22:12:21 +02:00
Ramiro Morales
1b1f64ee5a
Refs #14357 -- Deprecated Meta.ordering affecting GROUP BY queries.
...
Thanks Ramiro Morales for contributing to the patch.
2018-09-13 12:29:48 -04:00
Tim Graham
32fbccab40
Fixed #29749 -- Made the migrations loader ignore files starting with a tilde or underscore.
...
Regression in 29150d5da8
2018-09-11 12:51:11 -04:00
Tom Carrick
a43cfc23d4
Fixed #29746 -- Fixed misleading FlatpageForm URL help text if APPEND_SLASH is disabled.
2018-09-11 12:15:22 -04:00
Hasan Ramezani
5195b99e2c
Fixed #29560 -- Added --force-color management command option.
2018-09-11 11:15:42 -04:00
Tim Graham
de8eb07c7a
Reused a duplicated class in admin_scripts tests.
2018-09-11 10:50:51 -04:00
Srinivas Reddy Thatiparthy
34d6bceec4
Fixed #29500 -- Fixed SQLite function crashes on null values.
...
Co-authored-by: Srinivas Reddy Thatiparthy <thatiparthysreenivas@gmail.com>
Co-authored-by: Nick Pope <nick.pope@flightdataservices.com>
2018-09-10 15:08:55 -04:00
Krzysztof Gogolewski
db926a0048
Fixed #29243 -- Improved efficiency of migration graph algorithm.
2018-09-10 09:57:31 -04:00
Michal Čihař
22e8ab0286
Fixed #29728 -- Prevented session resaving if CSRF cookie is unchanged.
2018-09-08 11:46:13 -04:00
Alexander Holmbäck
f315d0423a
Fixed #29727 -- Made nonexistent joins in F() raise FieldError.
...
Regression in 2162f0983d
2018-09-08 09:40:33 -04:00
Alexander Holmbäck
aa16ec5474
Moved test for nonexistent field in F() to BasicExpressionsTest.
2018-09-08 09:21:57 -04:00
Nick Pope
570402ffd7
Refs #29713 -- Improved error message from translation system check.
2018-09-06 13:49:25 +02:00
David
5db8d617c0
Fixed #29713 -- Added check that LANGUAGE_CODE uses standard language id format.
2018-09-03 10:43:55 +02:00
James Aylett
ee52044a27
Refs #16470 -- Fixed typo in a FileResponse test.
2018-09-01 15:14:18 +02:00
Tim Graham
fd8a7a5313
Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
...
* Refs #27991 -- Added testing for ModelAdmin.get_inline_instances() if the inline's has_add_permission() doesn't accept 'obj'.
* Fixed #29723 -- Fixed crash if InlineModelAdmin.has_add_permission() doesn't accept the obj argument.
2018-08-30 11:22:50 +02:00
Mariusz Felisiak
39461a83c3
Fixed #29694 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining querysets with extra() with union(), difference(), or intersection().
...
Regression in 0b66c3b442
2018-08-29 10:00:15 +02:00
Nick Pope
ed4bfacb3c
Fixed #29703 -- Deprecated QuerySetPaginator alias.
...
Unused since 4406d283e1
2018-08-27 16:23:43 -04:00
Dan Palmer
e181666973
Fixed #29687 -- Allowed the test client to serialize list/tuple as JSON.
2018-08-25 10:57:05 -04:00
priyanshsaxena
83b04d4f88
Fixed #29048 -- Added **extra_context to database function as_vendor() methods.
2018-08-23 11:52:09 -04:00
Matthijs Kooijman
08f360355a
Fixed #29704 -- Fixed manage.py test --testrunner if it isn't followed by an equals sign.
2018-08-23 10:12:03 -04:00
Matthijs Kooijman
69071e7f51
Added manage.py test --testrunner tests.
2018-08-23 10:12:03 -04:00
Alejandro Dubrovsky
108c04f572
Fixed #29570 -- Added check that MEDIA_URL isn't in STATIC_URL.
2018-08-23 10:10:39 -04:00
winkidney
c69d40f943
Fixed #29705 -- Fixed ImageField RuntimeError crash for WebP files.
2018-08-23 09:04:25 -04:00
Simon Willison
586a9dc429
Fixed #26352 -- Made system check allow ManyToManyField to target the same model if through_fields differs.
2018-08-22 12:07:29 -04:00
Tim Graham
f2d5dafec9
Removed invalid Meta.ordering in a test model.
...
It never worked and was never used.
2018-08-22 10:05:12 -04:00
Franck Michea
7def8bed58
Fixed #29698 -- Fixed Field._check_choices() crash on invalid choices.
2018-08-22 09:15:19 -04:00
Claude Paroz
50b8493581
Refs #29654 -- Replaced three dots with ellipsis character in output strings.
2018-08-22 09:13:58 -04:00
Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి)
233c70f047
Fixed #29658 -- Registered model lookups in tests with a context manager.
2018-08-21 12:17:46 -04:00
Claude Paroz
201017df30
Fixed #29654 -- Made text truncation an ellipsis character instead of three dots.
...
Thanks Sudhanshu Mishra for the initial patch and Tim Graham for the review.
2018-08-21 17:46:45 +02:00
Jon Dufresne
ef87b38ef7
Fixed #29696 -- Prevented BaseModelFormSet.initial_form_count()'s from treating data={} as unbound.
2018-08-21 10:02:03 -04:00
Federico Bond
a0ca4b5694
Fixed #29689 -- Improved performance of FileSystemStorage.listdir() and FilePathField with os.scandir().
2018-08-20 17:58:00 -04:00
Rodrigo
371ece2f06
Fixed #29695 -- Added system checks for admin's app dependencies and TEMPLATES setting.
2018-08-20 17:57:46 -04:00
Hasan Ramezani
49b679371f
Fixed #29236 -- Fixed diffsettings crash if using settings.configure().
2018-08-20 12:59:27 -04:00
Ming Qin
cfb4845f06
Fixed #29625 -- Made Model.refresh_from_db() clear prefetch related caches.
2018-08-20 12:01:42 -04:00
Tim Graham
d311124be5
Fixed #29682 -- Fixed admin change form crash if a view-only model's form has an extra field.
2018-08-20 11:14:20 -04:00
Jon Dufresne
03a2c783e8
Fixed admin_checks tests to run in isolation.
2018-08-19 08:31:59 -07:00
Josh Schneier
3daac76cfb
Simplified how createsuperuser tests generate passwords.
2018-08-18 16:26:13 -04:00
Tom Forbes
8c70ba92dd
Refactored validators tests to use subtests.
2018-08-18 15:04:48 -04:00
Sigurd Ljødal
3e09b37f80
Fixed #28649 -- Added ExtractIsoYear database function and iso_year lookup.
2018-08-18 13:09:15 -04:00
mackong
c832885a3e
Fixed #29426 -- Made UUID inputs in the admin match the width of a UUID.
2018-08-18 10:16:22 -04:00
Tim Graham
838d6dcb86
Refs #29426 -- Made UUIDField render values with dashes.
2018-08-18 08:20:21 -04:00
Alexander Todorov
53ebd4cb13
Fixed #29686 -- Made UserAdmin.user_change_password() pass user to has_change_permission().
2018-08-17 17:43:00 -04:00
Kamil
3d4080f19c
Fixed #29024 -- Made TestContextDecorator call disable() if setUp() raises an exception.
2018-08-17 16:30:27 -04:00
oliver
abd0ad7681
Fixed #29626 , #29584 -- Added optimized versions of get_many() and delete_many() for the db cache backend.
2018-08-17 15:13:09 -04:00
Tom Forbes
c02d473781
Fixed #29612 -- Added GenericRelation prefetch_related() cache invalidation.
2018-08-17 14:58:45 -04:00
Jon Dufresne
bf17f5e884
Refs #29015 -- Added database name to PostgreSQL database name too long exception.
2018-08-17 12:43:56 -04:00
Jon Dufresne
09ee3b6fe3
Fixed #29663 -- Made admin change view redirect to changelist with view permission.
2018-08-17 11:13:06 -04:00
Nick Pope
b523d42561
Reorganized datetime db function tests.
2018-08-16 16:18:09 -04:00
Nick Pope
5c3db0ef6a
Reorganized comparison db function tests.
2018-08-16 16:04:39 -04:00
Nick Pope
3288985822
Reorganized text db function tests.
2018-08-16 15:44:31 -04:00
Nick Pope
dd3feb0891
Reorganized window db function tests.
2018-08-16 09:32:42 -04:00
KUAN Hsuan-Tso
9ec1a85c77
Removed obsolete TODO in proxy_model_inheritance test.
2018-08-16 09:20:31 -04:00
oliver
3ca24fd1c0
Optimized some cache tests with set_many().
2018-08-16 09:02:21 -04:00
Tom Forbes
a3df7574f9
Fixed #29644 -- Made SearchQuery.__str__() reflect negation and grouping.
2018-08-15 16:47:23 -04:00
Marnanel Thurman
7cc52250f0
Fixed #29662 -- Allowed test client to accept structured suffix JSON content types.
2018-08-15 10:27:45 -04:00
Jon Dufresne
f5e7506cff
Refs #27804 -- Used subTest in AdminViewPermissionsTest.
2018-08-12 21:27:19 -04:00
Ramiro Morales
b5c7cb4d33
Fixed #29653 -- Fixed missing related_query_name reverse accessor if GenericRelation is declared on an abstract base model.
...
Regression in 4ab027b944
2018-08-10 12:17:26 -04:00
Clément Mangin
64e1a271f5
Fixed #29637 -- Fixed admin change form crash if the user doesn’t have the add permission to a TabularInline.
...
Regression in 825f0beda8
2018-08-10 11:20:43 -04:00
Tim Graham
730173d1c5
Fixed #29623 -- Fixed translation failure of DurationField's "overflow" error message.
2018-08-08 06:24:52 -04:00
Mariusz Felisiak
9fee229874
Fixed #29643 -- Fixed crash when combining Q objects with __in lookups and lists.
...
Regression in fc6528b25a
2018-08-08 08:51:20 +02:00
Josh Schneier
3767c7ff39
Fixed #29244 -- Prevented Paginator.count() from silencing TypeError and AttributeError.
2018-08-07 17:41:18 -04:00
Josh Schneier
f1bf069ec1
Refs #29244 -- Fixed django.utils.inspect.method_has_no_args() for bound methods.
2018-08-07 17:37:35 -04:00
Josh Schneier
756b859576
Renamed django.utils.inspect.func_has_no_args() to method_has_no_args().
2018-08-07 17:37:35 -04:00
Raphael Michel
155b31d4ec
Fixed #29648 -- Fixed crash when using subqueries inside datetime truncation functions.
2018-08-07 16:47:54 -04:00
Hasan Ramezani
03e918d717
Added test for django.core.management.utils.get_random_secret_key().
2018-08-05 16:06:31 -04:00
Josh Schneier
8b43e9b1af
Fixed #29616 -- Fixed createsuperuser for user models that don't have a password field.
2018-08-05 14:26:03 -04:00
Tim Graham
ec594942cd
Removed unnecessary str() in mail tests.
...
Unnecessary since their introduction in
fa75b2cb51
2018-08-04 10:15:51 -04:00
Josh Schneier
793e9bb35a
Fixed #29628 -- Made createsuperuser validate password against username and required fields.
2018-08-04 08:44:25 -04:00
Tom
f1fbef6cd1
Fixed #28668 -- Allowed QuerySet.bulk_create() to ignore insert conflicts.
2018-08-03 17:40:46 -04:00
Calvin DeBoer
058d33f3ed
Fixed #29198 -- Added migrate --plan option.
2018-08-03 15:22:42 -04:00
Mariusz Felisiak
1a9cbf41a1
Fixed #29613 -- Fixed --keepdb on PostgreSQL if the database exists and the user can't create databases.
...
Regression in e776dd2db6
2018-08-03 10:31:55 +02:00
Tim Graham
d8e2be459f
Fixed #29627 -- Fixed QueryDict.urlencode() crash with non-string values.
...
Regression in 7d96f0c49a
2018-08-02 21:56:26 -04:00
Michael Sanders
271542dad1
Fixed #29499 -- Fixed race condition in QuerySet.update_or_create().
...
A race condition happened when the object didn't already exist and
another process/thread created the object before update_or_create()
did and then attempted to update the object, also before update_or_create()
saved the object. The update by the other process/thread could be lost.
2018-08-02 17:07:48 -04:00
Nick Pope
743d28f553
Refs #27869 -- Added PostgreSQL version check for GinIndex support.
2018-08-02 11:53:35 -04:00
Nick Pope
ff9543b351
Refs #25809 , #28990 -- Added PostgreSQL version check for BrinIndex support.
2018-08-02 11:50:40 -04:00
Nick Pope
6b4d1ec8ff
Fixed #29614 -- Added BTreeIndex to django.contrib.postres.
2018-08-02 11:42:57 -04:00
Nick Pope
d6381d3559
Fixed #28990 -- Added autosummarize parameter to BrinIndex.
2018-08-02 11:26:58 -04:00
Nick Pope
4c36e9e492
Fixed #28887 -- Added SpGistIndex to django.contrib.postgres.
2018-08-02 11:08:08 -04:00
Nick Pope
d526b07784
Fixed #26974 -- Added HashIndex to django.contrib.postgres.
...
Thanks Akshesh Doshi for the initial implementation.
2018-08-02 10:39:18 -04:00
Tim Graham
2092206bee
Refs #29600 -- Updated django.utils.datetime_safe now that Python 2 is unsupported.
2018-08-02 10:20:24 -04:00
Nick Pope
fa54ebc722
Simplified tests for PostgreSQL indexes.
...
- Added mixin to make tests more DRY.
- Removed redundant equality tests.
2018-08-02 10:07:10 -04:00
luz.paz
97e637a87f
Fixed typos in comments and docs.
2018-08-01 16:09:22 -04:00
Andreas Hug
a656a68127
Fixed CVE-2018-14574 -- Fixed open redirect possibility in CommonMiddleware.
2018-08-01 09:28:42 -04:00
Dražen Odobašić
9f3b9ffd51
Fixed #29617 -- Fixed Template crash if template_string is lazy.
...
Regression in 3a148f958d
2018-07-31 09:57:11 -04:00
Tom Forbes
4198445afc
Refs #29548 -- Fixed failing window tests on MariaDB 10.3.
2018-07-30 19:54:56 -04:00
Demur Nodia
06a11ef6ec
Fixed #26819 -- Fixed BaseModelFormSet.validate_unique() "unhashable type: list" crash.
2018-07-30 16:52:12 -04:00
Demur Nodia
c090ea97c1
Fixed nonexistent field reference in test model __str__() method.
2018-07-30 16:14:57 -04:00
Sławek Ehlert
c6238bf02b
Fixed #29467 -- Made override_settings handle errors in setting_changed signal receivers.
2018-07-30 15:59:37 -04:00
Hasan Ramezani
cebbcaa1ba
Moved yesno filter test to its file.
2018-07-27 17:15:00 -04:00
Melvyn Sopacua
e7a56eb4f0
Fixed #28659 -- Fixed LayerMapping crash with null geometry and unique.
2018-07-27 16:38:28 -04:00
Tim Graham
c72dde41e6
Fixed #29595 -- Allowed using timedelta in migrations questioner.
...
Refs #29600 -- Removed usage of django.utils.datetime_safe in migrations.
2018-07-27 11:53:49 -04:00
vinay karanam
3af695eda2
Fixed #28291 , #24726 -- Fixed ArrayField with JSONField and RangeFields.
2018-07-27 11:35:54 -04:00
Tim Graham
013d439ff0
Refs #29600 -- Added test for datetime_safe usage in localize_input().
2018-07-26 16:51:50 -04:00
Tim Graham
76852c3989
Refs #29600 -- Added test for datetime_safe usage in SelectDateWidget.value_from_datadict().
2018-07-26 16:51:40 -04:00
Carlton Gibson
1c05fe65f2
Refs #13091 -- Added test for commit=False idiom with partial unique_together validation.
2018-07-25 18:39:35 -04:00
Andrew Brown
55810d94d0
Refs #29563 -- Fixed SQLCompiler.execute_sql() to respect DatabaseFeatures.can_use_chunked_reads.
2018-07-25 18:08:57 -04:00
Simon Charette
dc1dcad0f5
Refs #24424 -- Added regression tests for MTI-inheritance model removal.
...
The issue was fixed as a side effect of implementing RemoveField's reduction
of DeleteModel to a DeleteModel in ad82900ad9
2018-07-25 12:07:41 -04:00
Mariusz Felisiak
ac25dd1f8d
Fixed #29569 -- Fixed Cast() with AutoField and BigAutoField.
2018-07-25 08:00:11 +02:00
Claude Paroz
2a74ceb5f3
Fixed #24336 -- Made django.conf.urls.static() ignore all absolute URLs
2018-07-24 09:32:33 +02:00
Tim Bell
cdcf4164be
Fixed #29528 -- Made URLValidator reject invalid characters in the username and password.
2018-07-23 10:30:01 -04:00
Mariusz Felisiak
5a017eef4c
Fixed test_migrate_syncdb_deferred_sql_executed_with_schemaeditor() on Oracle.
2018-07-22 08:47:55 +02:00
Simon Charette
1a28dc3887
Fixed #29582 -- Fixed a crash when using SearchVector with non text-fields.
...
The PostgreSQL concat() function handles nulls and non-text values better than
the || operator.
2018-07-21 21:32:21 -04:00
Thng Kai Yuan
71a739f3d7
Fixed #29576 -- Corrected the test client's HTTP_COOKIE header.
2018-07-21 18:14:39 -04:00
Tim Graham
8d4ab0c41f
Added tests for migrate logging and error messages.
2018-07-20 20:37:52 -04:00
Claude Paroz
b004bd62e8
Fixed #29412 -- Stopped marking slugify() result as HTML safe.
2018-07-20 10:44:30 -04:00
François Dupayrat
861638a307
Fixed #29568 -- Prevented unnecessary UPDATE queries creating child models.
2018-07-20 08:59:15 -04:00
Simon Charette
8e3f22f251
Fixed #27731 -- Implemented CreateModel/AlterFooOperation reduction.
...
This should alleviate the side effects of disabling the AlterFooOperation
reduction with RemoveField to fix refs #28862 during migration squashing
because CreateModel can perform a reduction with RemoveField.
Thanks Nick Pope for the review.
2018-07-19 17:06:01 -04:00
Simon Charette
ed7898e1b5
Fixed #28862 -- Disabled optimization of AlterFooTogether and RemoveField.
...
AlterFooTogether operations cannot be swapped with RemoveField operations on
the same model as they could be removing the the same field as well.
Since AlterFooTogether operations don't track what their previous value was,
it's impossible to determine whether or not the optimization is safe so the
only way to proceed is to disable the optimization.
Thanks Ramiro Morales for the in-depth analysis of the issue.
Refs #24828
2018-07-19 17:06:01 -04:00
Hasan Ramezani
55b6f7af0c
Completed test coverage for django.urls.utils.get_callable().
2018-07-19 16:48:23 -04:00
Claude Paroz
0adfba968e
Fixed #29578 -- Made numberformat.format() honor forced l10n usage.
...
Thanks Sassan Haradji for the report.
2018-07-19 16:44:40 -04:00
Viktor Danyliuk
6ae7aaa7d6
Fixed #29413 -- Prevented evaluation of QuerySet.get_or_create()/update_or_create() defaults unless needed.
...
Removed the logic added in 81e05a418ddbffffa7dc
2018-07-16 22:08:43 -04:00
Josh Schneier
4d48ddd8f9
Fixed #28917 -- Prevented Paginator's unordered warning on EmptyQuerySet.
...
Thanks carltongibson for the idea and weijunji for the initial patch.
2018-07-16 14:28:47 -04:00
Mariusz Felisiak
dd3b470719
Fixed #29542 -- Fixed invalid SQL if a Subquery from the HAVING clause is used in the GROUP BY clause.
...
Thanks Tim Graham for the review.
2018-07-14 12:03:22 +02:00
Peter Inglesby
312eb5cb11
Fixed #26291 -- Allowed loaddata to handle forward references in natural_key fixtures.
2018-07-13 17:54:47 -04:00
Daniel Wiesmann
8f75d21a2e
Fixed #28566 -- Added path matching to collectstatic ignore patterns.
2018-07-13 16:48:19 -04:00
Claude Paroz
c28bf990d7
Refs #29548 -- Fixed GIS tests on MariaDB
2018-07-13 18:27:30 +02:00
Oliver Sauder
a07a49ee32
Fixed #29559 -- Fixed TransactionTestCase.reset_sequences for auto-created m2m through models.
2018-07-11 17:20:29 -04:00
Tim Graham
4d98b9d729
Refs #9804 -- Fixed test for sequence reset of M2M with inherited through model.
2018-07-11 16:45:29 -04:00
Simon Charette
37cafbfb79
Fixed #27845 -- Allowed both right and left optimizations of operations.
...
Thanks Raphael Gaschignard for the suggestion.
2018-07-11 10:49:50 -04:00
Simon Charette
0025dd5eb4
Allowed RemoveField operations to be optimized through.
2018-07-11 10:49:50 -04:00
Simon Charette
50b8c98a0f
Relaxed FieldOperation.references_field remote field checking.
2018-07-11 10:49:50 -04:00
Simon Charette
ad82900ad9
Fixed #26720 -- Prevented invalid CreateModel optimizations of related fields.
2018-07-11 10:49:50 -04:00
Simon Charette
a97845a823
Fixed #27768 -- Allowed migration optimization of CreateModel order.
...
Thanks Ed Morley from Mozilla for the tests.
2018-07-11 10:49:50 -04:00
Simon Charette
d3a935f01f
Refs #27768 -- Reversed order of optimized and in-between operations.
...
Operations can only be optimized through if they don't reference any of the
state the operation they are compared against defines or alters, so it's
safe to reverse the order.
2018-07-11 10:49:50 -04:00
Jon Dufresne
e26b780a24
Silenced warnings in deprecation tests.
2018-07-11 09:10:31 -04:00
Simon Charette
e4c0878b30
Refs #22875 -- Fixed an optimizer test to use a valid scenario.
...
An explicit intermediary many-to-many relationship must declare forward and
reverse foreign keys. The original issue was in the autodetector as these
operations shouldn't have been generated in this order in the first place
which is tested by AutodetectorTests.test_create_with_through_model.
2018-07-10 16:47:57 -04:00
Ian Foote
952f05a6db
Fixed #11964 -- Added support for database check constraints.
2018-07-10 15:32:33 -04:00
Jon Dufresne
08ebed5e79
Fixed #29556 -- Made 'remove_stale_contenttypes --noinput' delete content types.
2018-07-10 10:14:34 -04:00
Tim Graham
178624855a
Simplified a couple test docstrings.
2018-07-10 09:43:12 -04:00
Jon Dufresne
e7d7d47b93
Fixed ResourceWarning from unclosed test files.
...
When running Django tests with Python warnings enabled.
2018-07-10 12:26:19 +02:00
Sergey Fedoseev
338f741c5e
Fixed #29546 -- Deprecated django.utils.timezone.FixedOffset.
2018-07-09 16:33:36 -04:00
Tom Forbes
45c035c823
Refs #29548 -- Fixed non-GIS test failures on MariaDB.
2018-07-09 14:59:42 -04:00
Tim Graham
5bea8d256d
Fixed #29553 -- Made test client set Content-Length header to a string rather than integer.
2018-07-09 11:44:49 -04:00
Sergey Fedoseev
c9088cfc7b
Fixed some assertTrue() that were intended to be assertEqual().
2018-07-09 11:13:40 -04:00
Sergey Fedoseev
3411c5551a
Refs #27472 -- Fixed crash during pickling of empty GEOS point.
2018-07-09 11:02:12 -04:00
Sergey Fedoseev
bdcde79c5f
Made test for memoryview handling in force_bytes() more strict.
2018-07-09 11:01:42 -04:00
Christian Barcenas
c9c6c16650
Fixed #20584 -- Fixed memcached's get_many() with single-use iterators.
...
Thanks Guyon Morée for the report.
2018-07-09 10:24:41 -04:00
Mushtaq Ali
66b6b68923
Fixed #29543 -- Fixed CPointerBase.__del__() ImportError crash.
2018-07-06 11:26:14 -04:00
Tom
f98e1c01ea
Refs #29451 -- Fixed test_isvalid_lookup on MySQL 8+.
2018-07-06 08:59:27 -04:00
Junyi Jiao
a0b19a0f5b
Refs #28643 -- Added math database functions.
...
Thanks Nick Pope for much review.
2018-07-05 11:02:12 -04:00
Tim Graham
f3fa86a89b
Fixed #29449 -- Reverted "Fixed #28757 -- Allowed using contrib.auth forms without installing contrib.auth."
...
This reverts commit 3333d935d2
2018-07-02 18:39:26 -04:00
Claude Paroz
eac9ab7ebb
Removed parser.add_arguments() arguments that match the defaults.
2018-07-02 17:54:57 -04:00
Mariusz Felisiak
0e64e046a4
Fixed #29530 -- Fixed aliases ordering when chaining annotate() and filter().
2018-07-02 21:09:29 +02:00
Ian Foote
38cada7c94
Fixed #28077 -- Added support for PostgreSQL opclasses in Index.
...
Thanks Vinay Karanam for the initial patch.
2018-06-29 17:00:28 -04:00
Jon Prindiville
b4cba4ed62
Fixed #28144 -- Added FileSystemStorage.OS_OPEN_FLAGS to allow customization.
2018-06-29 15:51:59 -04:00
Przemysław Suliga
d22b90b4ea
Fixed #29525 -- Allowed is_safe_url()'s allowed_hosts arg to be a string.
2018-06-29 10:17:52 -04:00
Floris den Hengst
96199e562d
Fixed #26067 -- Added ordering support to ArrayAgg and StringAgg.
2018-06-28 20:29:33 -04:00
Carlton Gibson
f4ef71c689
Refs #29514 -- Added test for get_default_timezone()/timezone.utc equality.
2018-06-28 11:14:26 -04:00
Tim Graham
9294110a57
Fixed #29520 -- Fixed test client crash when posting bytes.
...
Regression in b8a41a2872
2018-06-27 14:50:03 -04:00
Chris Jerdonek
f434f5b84f
Refs #29253 -- Fixed method_decorator() crash if decorator sets a new attribute.
...
Regression in fdc936c913
2018-06-27 11:46:07 -04:00
Alexandr Tatarinov
7410618528
Fixed #29447 -- Made RelatedManager.set() pass bulk argument to clear().
2018-06-25 13:04:46 -04:00
oliver
6b3e17bab6
Fixed #29518 -- Added validation for sqlmigrate's app_label argument.
2018-06-25 10:43:12 -04:00
Federico Bond
4c36414323
Fixed #29517 -- Rephrased error message when passing incorrect kwarg to model constructor
2018-06-25 09:30:58 +02:00
Tim Graham
7cdeb23ae7
Fixed #29511 -- Added charset to JavaScriptCatalog's Content-Type header.
2018-06-22 09:15:29 +02:00
Paulo
fa679db1ff
Refs #18620 -- Refactored ContentTypes view tests to group related field test cases.
2018-06-21 12:31:04 -04:00
Paulo
d14850e525
Fixed #18620 -- Made ContentTypes shortcut view prefer current site if available.
...
Thanks Mike Tigas (mtigas) for the initial patch.
2018-06-21 12:31:04 -04:00
Paulo
efbcd60a22
Added test for contenttype redirect with m2m objects.
...
Thanks carltongibson for the test logic.
2018-06-21 12:31:00 -04:00
Tim Graham
b49ed4be47
Corrected location of some contenttypes_tests.
2018-06-21 12:26:28 -04:00
Sergey Fedoseev
a799dc51b9
Fixed #29509 -- Added SpatiaLite support for covers and coveredby lookups.
2018-06-21 09:25:31 -04:00
Claude Paroz
fc26615164
Refs #29506 -- Added validation for squashmigrations' app_label option.
2018-06-20 15:46:43 -04:00
Claude Paroz
c723a1ff8e
Fixed #29506 -- Added validation for migrate's app_label option.
...
Thanks MyungSeKyo for the report and the initial patch.
2018-06-20 15:42:40 -04:00
Claude Paroz
c3c7d15c34
Refs #29469 -- Reused get_app_config() error message in makemigrations error.
2018-06-20 15:41:51 -04:00
Claude Paroz
abbc9cd71c
Moved makemigrations app_label validation tests.
2018-06-20 15:33:23 -04:00
Tim Graham
5d98d53fab
Refs #27398 -- Simplified some tests with assertRedirects().
2018-06-20 14:08:56 -04:00
Jan Pieter Waagmeester
24959e48d9
Fixed #27398 -- Added an assertion to compare URLs, ignoring the order of their query strings.
2018-06-20 13:26:12 -04:00
Nick Pope
b0fbfae093
Fixed #29503 -- Made __in lookup keep order of values in query.
...
Regression in 86eccdc8b6
2018-06-20 09:29:06 -04:00
Sergey Fedoseev
d8d21d3891
Made test for GIS Envelope function more strict.
2018-06-20 16:48:50 +05:00
Carlton Gibson
5b73317181
Fixed #29502 -- Allowed users with the view permission to use autocomplete_fields.
2018-06-18 15:36:20 -04:00
Carlton Gibson
958c7b301e
Fixed #29419 -- Allowed permissioning of admin actions.
2018-06-18 15:07:29 -04:00
Mariusz Felisiak
6dd4edb1b4
Fixed #29496 -- Fixed crash on Oracle when converting a non-unique field to primary key.
...
Thanks Tim Graham for the review.
2018-06-17 08:51:02 +02:00
humbertotm
e95008f241
Fixed #29152 -- Allowed passing kwargs to ArgumentParser initialization in management commands.
2018-06-16 15:54:59 -04:00
oliver
78972af367
Fixed #29469 -- Added a helpful makemigrations error if app_label contains dots.
2018-06-16 15:18:57 -04:00
Paulo
553617e613
Fixed #29487 -- Accounted for object level permissions when calculating change view's read-only fields.
...
Thanks Matthew Frazier for the report and fix.
2018-06-15 21:54:22 -04:00
Tim Graham
63f90f55f3
Fixed #29498 -- Fixed a missing pyc test file in source distribution.
2018-06-15 14:18:08 -04:00
Jeff
fcc4e251db
Fixed #29000 -- Fixed RenameModel's renaming of a M2M column when run after RenameField.
...
Regression in 45ded053b1
2018-06-15 11:51:09 -04:00
Henk Kahlfuß
3eb9127678
Fixed #23869 -- Made ModelAdmin.get_deleted_objects() use has_delete_permission() for permissions checking.
2018-06-15 10:31:08 -04:00
Tim Graham
ec2c9c3531
Refs #29428 -- Fixed admin check crash when using a query expression in ModelAdmin.ordering.
2018-06-14 21:04:43 -04:00
Tim Graham
0d8e3e608e
Fixed #29428 -- Fixed admin changelist crash when using a query expression without asc()/desc() in the ordering.
2018-06-14 14:22:04 -04:00
Claude Paroz
a77f21880d
Fixed #24384 -- Allowed compilemessages to continue running after nonfatal errors.
...
Thanks Aymeric Augustin for the report and Carlton Gibson and Tim Graham for
the reviews.
2018-06-13 21:09:02 +02:00
Carlton Gibson
b30f9b131c
Refs #29419 , #8936 -- Removed change permission requirement for admin actions.
...
Partially reverted 825f0beda8
2018-06-13 14:49:28 -04:00
Mads Jensen
4167959105
Added tests for incorrect content type and size in MultiPartParser.
2018-06-12 14:42:20 -04:00
Tim Graham
9e4f26bb40
Fixed #29483 -- Confirmed support for GDAL 2.3.
2018-06-12 13:34:58 -04:00
Bartosz Grabski
2bc014750a
Fixed #29452 -- Fixed makemessages setting charset of .pot files.
2018-06-11 21:34:13 -04:00
Arthur Silva
bc1435551c
Fixed #29464 -- Silenced post-process messages in collectstatic's default verbosity.
2018-06-11 20:21:58 -04:00
Tim Graham
860903b261
Dropped support for GDAL 1.9 and 1.10.
2018-06-11 08:33:09 -04:00
Claude Paroz
86988dd890
Refs #29483 -- Relaxed WGS 84 check regex
...
With GDAL 2.3, the exact string changed again.
2018-06-09 09:19:08 +02:00
Hasan Ramezani
6df3d36801
Added a missing test for createsuperuser management command.
2018-06-07 19:49:25 -04:00
Claude Paroz
ce3351b950
Fixed #29301 -- Added custom help formatter to BaseCommand class
...
This partially reverts c3055242c8
2018-06-06 19:16:10 +02:00
Tim Graham
13fe5a87f9
Fixed MySQL QuerySet.explain() test when running tests in reverse.
2018-06-06 11:31:06 -04:00
Carlton Gibson
c4f099de1d
Refs #29451 -- Used quote_name for column names in tests.
...
Regression in a253a580e6
2018-06-06 16:13:25 +02:00
Tom Forbes
a253a580e6
Refs #29451 -- Quoted MySQL column names in tests.
2018-06-05 12:13:29 +02:00
Claude Paroz
bec651a427
Fixed #10827 -- Ensured ContentTypes are created before permission creation.
2018-06-03 22:19:04 -04:00
humbertotm
747ff7a30b
Fixed #29385 -- Made admindocs ModelDetailView show model properties.
...
Original patch by bkaluza. Tests and docs by humbertotm.
2018-06-03 21:00:28 -04:00
Tim Graham
666be7b994
Fixed #29461 -- Fixed ogrinspect test_time_field failure on SpatiaLite.
2018-06-01 22:55:22 -04:00
Tim Graham
55f4eee75d
Fixed #29462 -- Fixed ogrinspect test failures with GDAL 2.2.
2018-06-01 22:31:46 -04:00
Adam Donaghy
b18650a263
Fixed #28462 -- Decreased memory usage with ModelAdmin.list_editable.
...
Regression in 917cc288a3
2018-06-01 10:41:05 -04:00
Mariusz Felisiak
d0ad03cded
Refs #29416 -- Fixed GeoExpressionsTests.test_multiple_annotation() on MySQL 5.7+.
...
Failure introduced in b6e48f514ebe4e31b76e1750e043d4f296e645dc.
2018-05-31 10:38:42 -04:00
Tim Graham
c03e41712b
Refs #28748 -- Reallowed lazy model field choices.
...
Regression in 3aa9ab39cc
2018-05-29 21:43:38 -04:00
Tim Graham
3dffcb5579
Relaxed a GDAL raster test.
...
The exact metadata depends on the GDAL version.
2018-05-29 21:39:31 -04:00
Dohyeon Kim
f1f4aeb22e
Fixed #28044 -- Unified the logic for createsuperuser's interactive and --noinput modes.
2018-05-29 08:41:32 -04:00
Paulo
6104875a2c
Fixed #29230 -- Fixed nested prefetches that clash with descriptors.
2018-05-27 21:45:51 -04:00
Hasan Ramezani
e0ff88be4f
Added test for createsuperuser's handling of KeyboardInterrupt.
2018-05-27 19:24:07 -04:00
Mariusz Felisiak
4ab1f559e8
Fixed #29416 -- Removed unnecesary subquery from GROUP BY clause on MySQL when using a RawSQL annotation.
...
Regression in 1d070d027c
2018-05-27 18:25:19 -04:00
Daniel Hepper
4e016d1372
Removed obsolete BaseHandler attributes.
...
Unused since d334f46b7a
2018-05-27 11:21:27 -04:00
Tim Graham
5cc81cd9eb
Reverted "Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set."
...
This reverts commit b3cffde555
2018-05-26 21:06:58 -04:00
ryabtsev
b4fd9b5ad4
Fixed #29432 -- Allowed passing an integer to the slice template filter.
2018-05-26 20:56:51 -04:00
Xaroth Brook
39283c8edb
Fixed #29415 -- Fixed detection of custom URL converters in included patterns.
2018-05-26 20:13:48 -04:00
Ryan Rubin
a8d12bc280
Fixed #29400 -- Fixed crash in custom template filters that use decorated functions.
...
Regression in 620e9dd31a
2018-05-25 11:11:46 -04:00
Ramiro Morales
f40e71a957
Fixed #29417 -- Corrected two admin page titles for view-only users.
2018-05-23 11:02:37 -04:00
Paulo Alvarado
ffb72a95bc
Fixed #29414 -- Restored form inputs on admin inlines when the user doesn't have the change permission.
...
Regression in 825f0beda8
2018-05-18 19:50:58 -04:00
bakabiko
a7bc1aea03
Fixed #29380 -- Added support for QuerySet.select_for_update()'s nowait and skip_locked options on MySQL 8+.
2018-05-18 19:37:36 -04:00
Tim Graham
9792af3648
Increased the default PBKDF2 iterations for Django 2.2.
2018-05-17 11:05:45 -04:00
Tim Graham
b9dd8512f2
Advanced deprecation warnings for Django 2.2.
2018-05-17 11:05:45 -04:00
olivierdalang
825f0beda8
Fixed #8936 -- Added a view permission and a read-only admin.
...
Co-authored-by: Petr Dlouhy <petr.dlouhy@email.cz>
Co-authored-by: Olivier Dalang <olivier.dalang@gmail.com>
2018-05-16 06:44:55 -04:00
Tim Graham
49a1736c2e
Added assertion for admin change form's "save and continue editing" message.
2018-05-15 20:17:02 -04:00
Claude Paroz
a177f854c3
Fixed #16470 -- Allowed FileResponse to auto-set some Content headers.
...
Thanks Simon Charette, Jon Dufresne, and Tim Graham for the reviews.
2018-05-15 18:12:11 +02:00
Ryan P Kilby
2dcc5d629a
Fixed #29392 -- Disallowed use of abbreviated forms of --settings and --pythonpath management command options.
2018-05-14 22:18:22 -04:00
Tim Graham
cae0107287
Increased the default PBKDF2 iterations for Django 2.1.
2018-05-13 20:06:20 -04:00
Claude Paroz
d65b0f72de
Fixed #17379 -- Removed management commands deactivation of the locale.
2018-05-13 10:21:53 +02:00
Tim Graham
1e0cbc72e5
Moved to_language() to django.utils.translation.
...
Follow up to 1b7d524cfa
2018-05-12 15:03:38 -04:00
Tim Graham
1b7d524cfa
Consolidated duplicate to_locale() implementations.
...
Follow up to ac59ec8f1a
2018-05-12 12:58:21 -04:00
Hasan Ramezani
305dee7bf9
Increased django.utils.translation.trans_null test coverage.
2018-05-12 11:23:44 -04:00
Hasan Ramezani
ac59ec8f1a
Aliased trans_null.to_locale() to trans_real.to_locale().
...
The implementations have unintentionally diverged.
2018-05-12 10:54:22 -04:00
Stefan R. Filipek
a5a2ceeb45
Fixed #27629 -- Added router.allow_relation() calls for assignments between unsaved model instances.
2018-05-10 20:42:44 -04:00
Claude Paroz
9c4ea63e87
Replaced TOKEN_* constants by TokenType enums.
...
Thanks Tim Graham for the review.
2018-05-10 17:51:51 +02:00
Maximilian Merz
78912ccd0e
Fixed #21408 — German Translation for “3 days ago”
...
The problem:
“3 days ago” should translate to “vor 3 Tagen” in German, while “3 days” translates to “3 Tage”. #21408 describes that django always translated to “Tage”, even when the dative “Tagen” was correct. The same applies to months (“Monate”/“Monaten”) and years (“Jahre”/“Jahren”).
The solution:
Let `timesince` caller provide the string dict to use for the time-related strings.
2018-05-10 15:53:33 +02:00
Morgan Aubert
704443acac
Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage().
2018-05-09 11:40:28 -04:00
Hasan Ramezani
7ba040de77
Added tests for trans_null.ngettext().
2018-05-09 09:54:41 -04:00
Nicolas Noé
c629d4e956
Fixed #29389 -- Made Paginator reject non-integer page numbers of type float.
2018-05-09 09:28:52 -04:00
Nicolas Noé
2134e7d439
Refs #29389 -- Added Paginator test for float page number.
2018-05-09 09:23:05 -04:00
Nicolas Noé
c4158d050f
Fixed #29370 -- Added choices to LogEntry.action_flag field.
2018-05-07 10:07:45 -04:00
Claude Paroz
523e04dfeb
Captured logging in tests with self.assertLogs().
2018-05-07 09:34:02 -04:00
Claude Paroz
607970f31c
Replaced django.test.utils.patch_logger() with assertLogs().
...
Thanks Tim Graham for the review.
2018-05-07 09:34:00 -04:00
Sanket Saurav
079f324357
Fixed #28913 -- Fixed error handling when MIGRATIONS_MODULES specifies a nonexistent top-level package.
2018-05-05 18:26:33 -04:00
Samir Shah
10b44e4525
Fixed #26688 -- Fixed HTTP request logging inconsistencies.
...
* Added logging of 500 responses for instantiated responses.
* Added logging of all 4xx and 5xx responses.
2018-05-04 20:55:03 -04:00
Carlton Gibson
21fd8041c1
Refs #29358 -- Corrected wording in primary key check message.
2018-05-03 15:28:37 +02:00
Hasan Ramezani
816b8d9518
Fixed #29358 -- Added a system check to prohibit models with more than one primary_key field.
2018-05-03 09:08:29 +02:00
CHI Cheng
98019df855
Used double quotation marks for csrf form element.
2018-05-03 08:57:18 +02:00
CHI Cheng
4660ce5a69
Fixed #29375 -- Removed empty action attribute on HTML forms.
2018-05-02 09:20:04 -04:00
Zackary Troop
30f8642f2e
Fixed #29350 -- Fix get_primary_key_column() method in sqlite3 backend
...
Thanks Tim Graham and Mariusz Felisiak for the reviews.
2018-04-28 12:01:45 +02:00
priyanshsaxena
6b3d292043
Fixed #29015 -- Added an exception if the PostgreSQL database name is too long.
2018-04-27 21:37:42 -04:00
Oscar Esgalha
6d1f576945
Fixed #29367 -- Fixed model state on objects with a primary key created with QuerySet.bulk_create().
2018-04-27 17:57:38 -04:00
Nicolas Noé
3246ad1065
Fixed #27480 -- Added cache.touch().
2018-04-27 17:48:35 -04:00
Claude Paroz
8e960c5aba
Removed urllib2 reference in file storage tests
2018-04-27 14:02:39 +02:00
Claude Paroz
a9189d27ef
Fixed #29353 -- Made StaticFilesHandler return a 404 response when settings.DEBUG is False
2018-04-25 10:38:13 +02:00
Tim Graham
c591bc3cce
Fixed "invalid escape sequence" warning in runtests.py.
2018-04-24 12:06:04 -04:00
Claude Paroz
3aae43d800
Fixed #28973 -- Silenced copying/linking messages in collectstatic's default verbosity.
2018-04-23 23:04:02 -04:00
François Freitag
d1413c5d70
Refs #28312 -- Added an optimized __bool__() to ModelChoiceIterator.
...
COUNT is more expensive than EXISTS; use the latter when possible.
2018-04-23 13:03:07 -04:00
François Freitag
3fca95e1ad
Fixed #28312 -- Made ModelChoiceIterator.__len__() more memory-efficient.
...
Instead of loading all QuerySet results in memory, count the number of
entries. This adds an extra query when list() or tuple() is called on the
choices (because both call __len__() then __iter__()) but uses less
memory since the QuerySet results won't be cached. In most cases, the
choices will only be iterated on, meaning that __len__() won't be called
and only one query will be executed.
2018-04-23 12:39:43 -04:00
Hasan Ramezani
b33f10d8cc
Refs #29131 -- Made ArrayField error messages index from 1 instead of 0.
2018-04-22 22:18:46 -04:00
Hasan Ramezani
dd68b51e1d
Fixed #29295 -- Fixed management command crash when using subparsers.
...
Thanks Tim Graham for the fix.
2018-04-21 17:33:17 -04:00
orlnub123
21420096c4
Fixed #29247 -- Allowed blank model field choice to be defined in nested choices.
2018-04-20 11:06:14 -04:00
Tim Graham
e35004966b
Moved tests for model Field.get_choices().
2018-04-20 11:05:25 -04:00
Adnan Umer
534d8d875e
Fixed #28600 -- Added prefetch_related() support to RawQuerySet.
2018-04-19 13:48:27 -04:00
Adnan Umer
f2026ca5e2
Fixed #29337 -- Added __len__() & __bool__() to RawQuerySet.
2018-04-19 12:46:31 -04:00
Adnan Umer
ec0319ff82
Fixed #29339 -- Added result caching to RawQuerySet.
2018-04-19 11:35:49 -04:00
Tom
c1c163b427
Fixed #28574 -- Added QuerySet.explain().
2018-04-19 10:52:19 -04:00
Nick Pope
df90e462d9
Fixed #29212 -- Doc'd redirect loop if @permission_required used with redirect_authenticated_user.
2018-04-19 10:21:24 -04:00
Tim Graham
a917a5601f
Refs #23890 -- Removed numpy deprecation warning silencing.
...
Obsolete since numpy 1.12.0.
2018-04-18 22:09:26 -04:00
Tim Graham
7a22d9f751
Fixed a test failure with the latest GeoIP2 database.
2018-04-17 21:30:05 -04:00
Brett Cannon
64b74804c5
Fixed #29334 -- Updated pypi.python.org URLs to pypi.org.
2018-04-17 20:24:27 -04:00
Jon Dufresne
b3cffde555
Fixed #29324 -- Made Settings raise ImproperlyConfigured if SECRET_KEY is accessed and not set.
2018-04-17 13:02:05 -04:00
Tim Graham
fff689ed98
Added a test for a settings error message.
2018-04-17 12:55:26 -04:00
Chris Jerdonek
fdc936c913
Fixed #29253 -- Made method_decorator(list) copy attributes.
2018-04-16 13:38:37 -04:00
Tim Graham
a480ef89ad
Fixed inconsistent formatting in tests/modeladmin/test_checks.py.
2018-04-16 13:35:40 -04:00
Chris Jerdonek
09f1f0387b
Updated decorators test to use subTest().
2018-04-16 12:48:01 -04:00
Daniel Miller
60156750f6
Fixed #29330 -- Fixed crash when pickling BaseExpression.
...
Regression in cfff2af02b
2018-04-16 10:15:13 -04:00
Alex Gaynor
9a56b4b13e
Fixed #27863 -- Added support for the SameSite cookie flag.
...
Thanks Alex Gaynor for contributing to the patch.
2018-04-13 20:58:31 -04:00
Matthias Kestenholz
13efbb233a
Fixed #29322 -- Made admin check all ModelAdmin fieldsets for duplicates.
2018-04-13 11:08:30 -04:00
Mariusz Felisiak
0b66c3b442
Fixed #29286 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining an annotated and unannotated queryset with union(), difference(), or intersection().
...
Regression in a0c03c62a8
2018-04-13 12:15:52 +02:00
Flávio Juvenal
e1f13f1551
Fixed #29320 -- Added an exception when an annotation alias matches a ForeignKey attname.
2018-04-12 21:15:40 -04:00
Tim Graham
78f8b80f9b
Fixed schema test failure when running tests in reverse.
...
Follow up to 003334f8af
2018-04-12 13:59:02 -04:00
Paul Donohue
33a0b7ac81
Fixed #29296 -- Fixed crashes in admindocs when a view is a callable object.
2018-04-12 13:11:08 -04:00
Jeremy Bowman
ee17bb8a67
Fixed #29193 -- Prevented unnecessary foreign key drops when altering a unique field.
...
Stopped dropping and recreating foreign key constraints on other fields
in the same table as the one which is actually being altered in an
AlterField operation.
Regression in c3e0adcad8
2018-04-11 23:17:11 -04:00
Jeremy Bowman
003334f8af
Tested altering a unique field when a reverse M2M relation exists.
2018-04-11 23:17:11 -04:00
David Foster
c3055242c8
Fixed #29301 -- Made management command --help display command-specific arguments before common arguments.
2018-04-11 13:52:20 -04:00
Alasdair Nicol
65c44a5c1d
Fixed #29307 -- Fixed inspectdb import paths for django.contrib.postgres fields.
...
Thanks erindy for the report.
2018-04-10 09:33:05 -04:00
Vinay Karanam
6a1957bb98
Fixed #28950 -- Fixed ArrayField.has_changed() for empty values.
2018-04-07 17:53:33 -04:00
Vinay Karanam
e67dc0fbb2
Added tests for ArrayField.has_changed().
2018-04-07 17:48:29 -04:00
Faheel Ahmad
5d4d62bf4f
Fixed #29248 -- Renamed admin CSS class field-box to fieldBox.
2018-04-05 10:55:36 -04:00
Jon Dufresne
be6ca89396
Fixed #27991 -- Added obj arg to InlineModelAdmin.has_add_permission().
...
Thanks Vladimir Ivanov for the initial patch.
2018-04-04 19:21:50 -04:00
Jirka Vejrazka
6148dda72f
Fixed #29288 -- Made {% widthratio %} assign to as var if an exception occurs.
2018-04-04 14:03:16 -04:00
safu9
9fd9f8bbb2
Fixed #29284 -- Made ImageField render with accept="image/*"' HTML attribute.
2018-04-04 13:16:03 -04:00
Mads Jensen
9c651641f1
Added additional AdminPasswordChangeForm tests.
2018-04-04 11:25:28 -04:00
Dmitry Dygalo
c979c0a2b8
Fixed #25718 -- Made a JSONField lookup value of None match keys that have a null value.
2018-04-04 10:53:46 -04:00
Mariusz Felisiak
816b386d41
Refs #24791 -- Made PostgreSQL's nodb connection use first PostgresSQL db when 'postgres' db isn't available.
...
Thanks Tim Graham and Claude Paroz for reviews.
2018-04-03 22:21:47 +02:00
Mariusz Felisiak
55cc26941a
Refs #28643 -- Added Repeat database function.
...
Thanks Tim Graham and Nick Pope for reviews.
2018-04-03 19:36:12 +02:00
Mariusz Felisiak
6141c752fe
Fixed #29251 -- Added bytes to str conversion in LPad/RPad database functions on MySQL.
...
Thanks Tim Graham for the review.
2018-04-03 18:24:04 +02:00
Tim Graham
4f7467b690
Refs #28577 -- Added check for HStoreField to prevent mutable default.
2018-04-03 11:12:56 -04:00
Jon Dufresne
167d98528a
Refs #27728 -- Fixed BytesWarning in admin_views tests.
2018-04-03 10:11:35 -04:00
Jon Dufresne
f3b1c3bd06
Refs #23406 -- Fixed "invalid escape sequence" warning in migrations test.
2018-04-02 22:54:05 -04:00
Claude Paroz
2a2ed0e70a
Fixed #29116 -- Fixed OpenLayersWidget deserialization ignoring the widget map's SRID.
...
Regression in 6ecccad711
2018-04-02 10:20:00 -04:00
Claude Paroz
f3b69f9757
Fixed #29273 -- Prevented initial selection of empty choice in multiple choice widgets.
...
Regression in b52c73008a
2018-04-02 08:52:53 -04:00
Dan Watson
e163effecc
Fixed #29279 -- Added renderer argument to ModelForm.
2018-03-31 20:45:59 -04:00
Chris Lamb
84ad721bd9
Fixed #29275 -- Made assertFormError() output "(actual errors: none)" instead of "(actual errors: )".
2018-03-31 18:35:45 -04:00
Malte Gerth
874977d388
Fixed #29270 -- Fixed UserChangeForm crash if password field is excluded.
2018-03-29 15:25:54 -04:00
Mads Jensen
c59aa9e6aa
Added test for combining Q objects with non-Q objects.
2018-03-29 13:58:55 -04:00
Simon Charette
2156565b5b
Fixed #29245 -- Made autodetector treat field renames + db_column addition as RenameField.
2018-03-28 12:43:43 -04:00
Abeer Upadhyay
1bf4646f91
Fixed #29258 -- Added type checking for login()'s backend argument.
2018-03-28 10:10:18 -04:00
Hasan Ramezani
76ae1e9a94
Increased test coverage for {% get_admin_log %} and {% static %}.
2018-03-26 13:34:23 -04:00
Mads Jensen
4554f9a783
Increased test coverage for various template tags.
2018-03-24 19:56:46 -04:00
Dan Watson
29150d5da8
Fixed #23406 -- Allowed migrations to be loaded from .pyc files.
2018-03-23 13:20:38 -04:00
Tim Graham
a4f0e9aec7
Fixed #28718 -- Allowed user to request a password reset if their password doesn't use an enabled hasher.
...
Regression in aeb1389442703c26668292f48680db
2018-03-22 10:03:43 -04:00
Tim Graham
623139b5d1
Refs #29147 --- Added JSONField serialization tests.
2018-03-21 20:11:06 -04:00
Michael Sinov
9aca67bea8
Fixed #27533 -- Fixed inspectdb crash if a unique constraint uses an unsupported type.
2018-03-21 12:28:16 -04:00
Tim Graham
a170dac887
Fixed too many parentheses in inspectdb Meta.unique_together output.
...
Regression in c76d87427d
2018-03-21 10:39:36 -04:00
Mads Jensen
bb79e480e1
Increased test coverage for i18n template tags.
2018-03-21 08:38:07 -04:00
Tim Graham
c76d87427d
Refs #23919 -- Removed obsolete comments about u'' prefixes.
2018-03-21 08:15:07 -04:00
Tim Graham
6421bd702f
Refs #29227 -- Made inspectdb generate BooleanField(null=True) rather than NullBooleanField.
2018-03-20 12:10:10 -04:00
Tim Graham
5fa4f40f45
Fixed #29227 -- Allowed BooleanField to be null=True.
...
Thanks Lynn Cyrin for contributing to the patch, and Nick Pope for review.
2018-03-20 12:10:10 -04:00
Astral
a0c03c62a8
Fixed #29229 -- Fixed column mismatch crash when combining two annotated values_list() querysets with union(), difference(), or intersection().
...
Regression in 7316720603821ebb64dfe8fa592ba6edcef5f3e.
2018-03-19 21:05:43 -04:00
Mariusz Felisiak
cede5111bb
Refs #28643 -- Added LPad and RPad database functions.
...
Thanks Tim Graham for the review.
2018-03-19 17:35:16 +01:00
Hasan Ramezani
274e3e27f3
Fixed #29184 -- Made TabularInline respect model form's Meta.labels and help_texts.
2018-03-17 20:51:24 -04:00
Claude Paroz
3c4ff21763
Fixed #29103 -- Removed bad 'b'-prefix added by MySQL's SchemaEditor.quote_value().
2018-03-17 16:36:54 -04:00
Claude Paroz
aa0ee372cd
Added tests for MySQL's SchemaEditor.quote_value().
2018-03-17 16:36:50 -04:00
Tim Graham
f8b98f0edc
Removed DatabaseFeatures.can_introspect_null.
...
The only known usage is in the unmaintained django-pymssql project.
2018-03-16 11:43:41 -04:00
Mariusz Felisiak
362813d628
Fixed hanging indentation in various code.
2018-03-16 10:54:34 +01:00
Mattia Procopio
aeb8c38178
Fixed #29206 -- Fixed PasswordResetConfirmView crash when the URL contains a non-UUID where one is expected.
2018-03-15 21:33:15 -04:00
Josh Schneier
b60e5fdbb7
Fixed #28959 -- Fixed 'No, take me back' button on admin's inline popup.
2018-03-15 20:47:18 -04:00
Mariusz Felisiak
9421aee35e
Refs #28643 -- Added LTrim, RTrim, and Trim database functions.
...
Thanks Tim Graham and Mads Jensen for reviews.
2018-03-15 20:57:23 +01:00
Artem Tabolin
a2f7433adc
Fixed #29221 -- Corrected admin's autocomplete widget to add a space after custom classes.
2018-03-15 10:55:34 -04:00
Mariusz Felisiak
ba3078c92d
Refs #29155 -- Fixed LookupTests.test_pattern_lookups_with_substr() crash on Oracle.
...
Test introduced in feb683c4c2
2018-03-15 09:54:24 -04:00
Tim Graham
87dc0844a6
Fixed #29200 -- Fixed label rendering when using RadioSelect and CheckboxSelectMultiple with MultiWidget.
2018-03-15 09:10:23 -04:00
Tim Graham
fb8fd535c0
Moved SchemaLoggingTest to tests/schema.
2018-03-14 10:24:34 -04:00
Mariusz Felisiak
feb683c4c2
Fixed #29155 -- Fixed crash when database functions are used with pattern lookups.
...
Thanks Tim Graham and Sergey Fedoseev for reviews.
2018-03-14 10:00:07 +01:00
Mariusz Felisiak
acfc650f2a
Fixed #29199 -- Fixed crash when database user password contains @ sign on Oracle.
...
Thanks Shane Allgeier for the report and Tim Graham for the review.
2018-03-13 19:06:40 +01:00
dzhuang
e17088a108
Fixed #29213 -- Fixed autocomplete widget's translations for zh-hans/zh-hant.
2018-03-13 10:58:34 -04:00
robwa
4ab027b944
Fixed #28988 -- Fixed queries when a GenericRelation is used with multi-table inheritance.
2018-03-12 22:42:48 -04:00
Sergey Fedoseev
d696fccae6
Fixed #29209 -- Fixed Cast() with TextField on MySQL and Oracle.
2018-03-12 21:57:14 -04:00
Mariusz Felisiak
c3a1337dfa
Refs #29004 -- Optimized InspectDBTransactionalTests.test_include_views() by limiting introspected tables.
2018-03-12 11:22:57 -04:00
Tim Graham
25b97ee170
Added functions for inspectdb table filtering in tests.
2018-03-12 11:15:13 -04:00
Carlton Gibson
5b083a824e
Fixed #29180 -- Fixed a regression where migrations already in the plan were readded.
...
Regression in a38ae914d8
2018-03-09 08:59:57 +01:00
Alex Stovbur
2d9ec4d735
Fixed #29188 -- Fixed ContentFile.size after a write().
2018-03-08 14:07:29 -05:00
Simon Charette
277ed07209
Fixed #29195 -- Fixed Exists.output_field resolution on single-valued queries.
...
The Subquery class which Exists inherits from defaulted to using single-valued
querie's field if no output_field was explicitly specified on initialization
which was bypassing the Exists.output_field defined at the class level.
Moving Subquery's dynamic output_field resolution to _resolve_output_field
should make sure the fallback logic is only performed if required.
Regression in 08654a99bb
2018-03-08 13:30:41 -05:00
Fabrizio Ettore Messina
10c0fe528a
Fixed #29178 -- Allowed Index.fields to accept a tuple.
2018-03-08 10:56:55 -05:00
Tim Graham
911af0d24b
Added more tests for django.utils.html.urlize().
2018-03-06 08:30:41 -05:00
Tim Graham
97b7dd59bb
Fixed CVE-2018-7537 -- Fixed catastrophic backtracking in django.utils.text.Truncator.
...
Thanks James Davis for suggesting the fix.
2018-03-06 08:30:40 -05:00
Tim Graham
8618271caa
Fixed CVE-2018-7536 -- Fixed catastrophic backtracking in urlize and urlizetrunc template filters.
...
Thanks Florian Apolloner for assisting with the patch.
2018-03-06 08:30:40 -05:00
Alex Stovbur
d171843f57
Fixed #28981 -- Added an exception if GeoIP database can't be loaded from the path.
2018-03-05 12:20:30 -05:00
Sergey Fedoseev
4ff29a53e6
Refs #17476 -- Removed obsolete simplification of timezone names in cache key generation.
2018-03-03 14:56:39 -05:00
Almad
3d8fadad0f
Added model name to AutoField error message.
2018-03-03 13:22:00 -05:00
Patryk Zawadzki
a20aae414e
Fixed #29144 -- Made untranslated strings for territorial language variants use translations from the generic language variant.
2018-03-03 12:08:24 -05:00
Alex Tomic
a1a3e51561
Fixed #29133 -- Fixed call_command() crash if a required option is passed in options.
2018-03-02 12:25:08 -05:00
Christophe Mehay
40bac28faa
Fixed #29176 -- Fixed AbstractBaseUser.normalize_username() crash if username isn't a string.
2018-03-02 11:32:53 -05:00
François Freitag
a2e97abd81
Fixed #29159 -- Made ModelChoiceIterator reuse QuerySet result cache.
...
When __len__() is called (e.g. when casting to list or tuple), the
QuerySet is evaluated and the result cache populated. iterator()
shouldn't be called on the QuerySet after that, as it would reset the
result cache and trigger a second query.
2018-03-01 14:17:56 -05:00
François Freitag
40f0aa9885
Fixed #29158 -- Fixed len(choices) crash if ModelChoiceField's queryset is a manager.
...
Removing all() in __iter__() prevents a duplicate query when choices are
cast to a list and there's a prefetch_related().
2018-03-01 14:12:14 -05:00
François Freitag
06172d7bc2
Consolidated ModelChoiceField tests.
2018-03-01 14:05:35 -05:00
Tim Graham
4c02e3cda3
Refs #27728 -- Made cosmetic edits to admin template tag template overriding.
2018-03-01 11:45:08 -05:00
Tomáš Ehrlich
fa352626c2
Fixed #29172 -- Fixed crash with Window expression in a subquery.
2018-03-01 10:24:14 -05:00
Mariusz Felisiak
54f80430be
Fixed #29166 -- Fixed crash in When() expression with a list argument.
...
Thanks Matthew Pava for the report and Tim Graham and Carlton Gibson for
reviews.
Regression in 19b2dfd1bf
2018-02-28 18:05:23 +01:00
Tim Graham
3fb718f17d
Eliminated the need to modify a model forms test when new test files are added.
2018-02-28 10:26:26 -05:00
Raffaele Salmaso
5cc28dc752
Fixed #27728 -- Allowed overriding admin templatetags templates.
2018-02-28 08:49:40 +01:00
Tim Graham
5b589a47b9
Fixed #29161 -- Removed BCryptPasswordHasher from PASSWORD_HASHERS.
2018-02-26 09:05:18 -05:00
Becky Smith
8116e588db
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
2018-02-24 20:41:43 -05:00
Tim Graham
0fa6ab8c18
Tested the admin's delete_selected action when it receives nonexistent pks.
2018-02-24 09:21:13 -05:00
a8568730
ba37ee9ef8
Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-ASCII characters.
2018-02-23 15:40:11 -05:00
Sebastian Sangervasi
7905815510
Fixed #27449 -- Added django.utils.translation.get_supported_language_variant().
2018-02-23 14:49:00 -05:00
Hasan Ramezani
5033999153
Fixed #29154 -- Corrected examples in pluralize docstring and added tests.
2018-02-23 14:20:00 -05:00
bobort
f82de6bfb1
Refs #28643 -- Added Ord, Chr, Left, and Right database functions.
2018-02-23 10:23:22 -05:00
Matthew Schinckel
c412926a2e
Fixed #29142 -- Fixed crash when OuterRef is used with an operator.
2018-02-23 09:38:16 -05:00
Mikhail Porokhovnichenko
14e34dcf8c
Fixed #29132 -- Avoided connecting update_last_login() handler if User.last_login isn't a field.
2018-02-21 10:36:31 -05:00
Sebastian Sangervasi
5c4c87e55c
Changed "language-code" to the more commonly used "language code".
2018-02-21 09:31:05 -05:00
Tom Forbes
33ac036a6b
Fixed #28398 -- Added suggestions for mistyped management commands.
2018-02-21 09:00:49 -05:00
Sebastian Sangervasi
f7b46f0b58
Removed unneeeded inner import in i18n tests.
2018-02-21 08:59:31 -05:00
Oliver Sauder
6f0b8c1c9e
Fixed #28442 -- Fixed crash with nested OuterRefs that reference AutoField.
2018-02-20 21:58:43 -05:00
Chillar Anand
e8e0cfa9e5
Fixed #28755 -- Made check_for_language() include apps' locale directories.
2018-02-20 21:34:40 -05:00
Williams Mendez
2691ed7ba1
Fixed #29140 -- Fixed EmailMessage crash when body is None.
2018-02-20 09:34:01 -05:00
Tim Graham
548f78ba46
Removed redundant lookup name in register_lookup() calls.
2018-02-19 13:12:13 -05:00
dizballanze
eb002e7892
Fixed #29135 -- Prevented get_object/list_or_404() from hiding AttributeError raised by QuerySet filtering.
2018-02-19 10:51:15 -05:00
Dylan Verheul
9b1125bfc7
Fixed #28379 -- Made AccessMixin raise Permissiondenied for authenticated users.
2018-02-16 13:58:55 -05:00
Andreas Pelme
e307ff29d2
Fixed #27810 -- Allowed query expressions in admin_order_field.
2018-02-15 21:00:31 -05:00
Herbert Parentes Fortes Neto
d368784bac
Fixed #28171 -- Added an exception if Form's empty_permitted and use_required_attribute arguments conflict.
2018-02-15 13:44:26 -05:00
Tim Graham
e917ea6bec
Fixed #29126 -- Doc'd the behavior of QuerySet.update_or_create() with manually specified pks.
2018-02-15 13:17:37 -05:00
Tomer Chachamu
7ec0fdf62a
Fixed #28693 -- Fixed crash in CsrfViewMiddleware when an HTTPS request has an invalid host.
2018-02-14 20:24:01 -05:00
Haki Benita
ff5517988a
Fixed #28933 -- Improved the efficiency of ModelAdmin.date_hierarchy queries.
2018-02-14 19:15:41 -05:00
Haki Benita
98dd943893
Added tests for the date_hierarchy template tag.
2018-02-14 13:36:10 -05:00
Sanyam Khurana
5a669ae2f4
Fixed #29106 -- Made DiscoverRunner display selected test tags.
2018-02-13 12:56:31 -05:00
Denys Duchier
cb7860cced
Fixed #24607 -- Serialized natural keys in multi-table inheritance models.
...
Thanks João Paulo Melo de Sampaio for the test.
2018-02-12 21:15:04 -05:00
Tim Graham
9ba3df8240
Refs #29125 -- Made Q.deconstruct() omit 'query_utils' in the path and _connector='AND' since it's a default value.
2018-02-12 15:23:41 -05:00
Tim Graham
b95c49c954
Fixed #29125 -- Made Q.deconstruct() deterministic with multiple keyword arguments.
2018-02-12 14:52:32 -05:00
Tim Graham
a6fb81750a
Added a test for Client.generic() data coercion.
...
The smart_str() call (now force_bytes()) added in
e73838b6dd
2018-02-12 12:53:02 -05:00
Tim Graham
4206765a5b
Refs #20530 -- Added a test for test client query string encoding.
...
7bb6279360
2018-02-12 10:20:53 -05:00
Snow_Poijio
7a715b3881
Fixed typo in tests/one_to_one/tests.py docstring.
2018-02-12 08:44:49 -05:00
Stanislav Karpov
6d794fb762
Fixed #28960 -- Added GEOSGeometry.buffer_with_style().
2018-02-10 19:45:58 -05:00
Matthew Wilkes
2162f0983d
Fixed #24747 -- Allowed transforms in QuerySet.order_by() and distinct(*fields).
2018-02-10 19:08:55 -05:00
Raphael Gaschignard
bf26f66029
Fixed #29118 -- Fixed crash with QuerySet.order_by(Exists(...)).
2018-02-10 18:35:57 -05:00
Manatsawin Hanmongkolchai
1a1264f149
Fixed #29109 -- Fixed the admin time picker widget for the Thai locale.
2018-02-10 16:05:41 -05:00
Tim Graham
b832de869e
Added tests for utils.html.urlize() (lazy string inputs were untested).
2018-02-10 15:45:57 -05:00
Tim Graham
d4373b6da4
Switched test requirement to new psycopg2-binary package.
2018-02-08 20:02:35 -05:00
Simon Charette
d61fe24601
Fixed #29108 -- Fixed crash in aggregation of distinct+ordered+sliced querysets.
...
Regression in 4acae21846
2018-02-08 09:59:25 -05:00
Jonas Haag
8c709d79cb
Fixed #17419 -- Added json_tag template filter.
2018-02-07 18:38:12 -05:00
Alexander Gaevsky
ef2512b2ff
Fixed #25790 -- Allowed disable column sorting in the admin changelist.
...
Thanks Ramiro Morales for completing the patch.
2018-02-07 17:46:28 -05:00
Tim Graham
fa75b2cb51
Refs #27795 -- Removed force_bytes/text() usage in tests.
2018-02-07 14:20:04 -05:00
Mariusz Felisiak
34b52f8572
Renamed the allow_sliced_subqueries database feature to allow_sliced_subqueries_with_in.
...
After 0899d583bd
2018-02-07 08:27:47 +01:00
Nick Sarbicki
47268242b0
Fixed #29082 -- Allowed the test client to encode JSON request data.
2018-02-06 18:29:04 -05:00
shanghui
d968788b57
Fixed #28833 -- Prevented CacheMiddleware from caching responses with "Cache-Control: private".
2018-02-06 09:42:05 -05:00
Tom
272f685794
Fixed #27999 -- Added test client support for HTTP 307 and 308 redirects.
2018-02-06 09:03:43 -05:00
Raymond Hettinger
aba9763b51
Refs #28814 -- Imported from collections.abc to fix Python 3.7 deprecation warnings.
...
https://bugs.python.org/issue25988
2018-02-05 11:42:47 -05:00
Jon Dufresne
8b21878357
Refs #28723 -- Fixed stale prefetch_related cache after add/remove.
...
Regression in 514b2c989a
2018-02-05 11:02:57 -05:00
Jon Dufresne
f0658ff818
Made prefetch_related tests use assertCountEqual() for unordered sequences.
2018-02-05 10:00:57 -05:00
Raffaele Salmaso
da3df5b878
Fixed #8500 -- Allowed overriding the default admin site instance.
2018-02-03 18:51:10 -05:00
Tim Graham
d0a42a14c0
Fixed imports per isort 4.3.1.
...
Partially reverted 9bcf73d788
2018-02-02 14:44:07 -05:00
Mariusz Felisiak
75e45a45e7
Simplified aggregation.tests.
2018-02-02 08:47:32 +01:00
Tim Graham
af33fb250e
Fixed CVE-2018-6188 -- Fixed information leakage in AuthenticationForm.
...
Reverted 359370a8b8#28645 ).
This is a security fix.
2018-02-01 09:05:14 -05:00
Tim Graham
552abffab1
Fixed #29094 -- Fixed crash when entering an invalid uuid in ModelAdmin.raw_id_fields.
...
Regression in 2f9861d823
2018-02-01 08:36:36 -05:00
Mariusz Felisiak
9bcf73d788
Fixed imports per isort 4.3.0.
2018-02-01 09:29:46 +01:00
priyanshsaxena
617d5f410f
Fixed #29066 -- Allowed negating query expressions.
2018-01-31 10:54:19 -05:00
Tim Graham
0a37ea56d0
Fixed #29091 -- Fixed makemigrations crash if migrations directory doesn't have __init__.py.
...
Regression in aadd3aeb2b
2018-01-31 09:36:36 -05:00
Vlastimil Zíma
fbc3c29e7c
Fixed #29036 -- Fixed HTML5 required validation on SelectDateWidget if the attribute is added by JavaScript.
...
Thanks Tim Graham for the initial patch.
2018-01-30 19:09:31 -05:00
Tim Graham
3a4b11873a
Added tests for SelectDateWidget.value_from_datadict().
2018-01-30 18:10:33 -05:00
Mads Jensen
1500573620
Added test for Apps.get_models() when models_ready=False.
2018-01-30 10:44:58 -05:00
Jon Dufresne
136bf5c214
Fixed #29076 -- Made Model.refresh_from_db() clear cached relationships even if the related id doesn't change.
2018-01-30 10:43:53 -05:00
bquinn
c2b969e124
Fixed #29004 -- Added inspectdb --include-views option.
2018-01-27 18:51:40 -05:00
Sigurd Ljødal
a455e732a0
Fixed #28650 -- Added TruncWeek database function.
2018-01-27 09:59:13 -05:00
François Freitag
3aa9ab39cc
Refs #28748 -- Reallowed lazy values in model field choices.
...
Regression in f9844f4841
2018-01-27 09:19:56 -05:00
Mariusz Felisiak
b002a032f9
Fixed #29054 -- Fixed a regression where a queryset that annotates with geometry objects crashes.
...
Made GEOSGeometryBase hashable.
Regression in 19b2dfd1bf
2018-01-27 11:12:11 +01:00
Jon Dufresne
3187c89d6f
Fixed #29067 -- Fixed regression in QuerySet.values_list(..., flat=True) followed by annotate().
2018-01-26 09:35:50 -05:00
Roger Gammans
d0b44c44ef
Fixed #29060 -- Made {% firstof %} assign '' to the asvar if all inputs are false.
2018-01-25 13:40:51 -05:00
shanghui
8dc675d90f
Fixed #28838 -- Fixed Model.save() crash if the base manager annotates with a related field.
2018-01-25 10:12:04 -05:00
Grant Jenks
d38a3169a4
Fixed #28977 -- Changed local-memory cache to use LRU culling.
...
LRU culling turns every read into a kind of write to the cache: cache keys
are moved to the first position in the OrderedDict when they are retrieved.
The RWLock which permitted multiple readers while prioritizing a single
writer is obsolete since all accesses are now writes.
2018-01-24 12:26:19 -05:00
François Freitag
f9844f4841
Fixed #28748 -- Made model field choices check more strict for named groups.
2018-01-24 10:34:24 -05:00
François Freitag
8cdeb8acfc
Added more tests for model field choices validation.
2018-01-24 10:27:27 -05:00
Daniel Hones
9d129b72ce
Fixed #29047 -- Corrected Substr test to use expressions.
...
Regression in e2d6e14662
2018-01-24 08:07:28 -05:00
Jon Dufresne
7d607127e3
Refs #21221 -- Deprecated staticfiles and admin_static template tag libraries.
2018-01-23 10:30:10 -05:00
Mariusz Felisiak
950171d7b2
Refs #11487 -- Removed redundant test_long_string() test.
...
Redundant with model_regress.tests.ModelTests.test_long_textfield
since 3ede430b9a
2018-01-23 08:53:45 -05:00
Jon Dufresne
ff05de760c
Fixed #29038 -- Removed closing slash from HTML void tags.
2018-01-21 02:09:10 -05:00
Mariusz Felisiak
aad1833fa0
Refs #20487 -- Added test for querying mixed case fields with common related model.
...
Thanks Shai Berger for the review.
2018-01-20 20:48:01 +01:00
Jon Dufresne
47d238b696
Fixed #29041 -- Changed SelectMultiple's multiple attribute to HTML5 boolean syntax.
2018-01-20 11:19:06 -05:00
Jon Dufresne
3c34452ab5
Refs #23668 -- Removed passing default argument of current TZ to make_aware()/naive.
2018-01-18 11:21:12 -05:00
Mads Jensen
65728550bd
Refs #28643 -- Added Replace database function.
2018-01-17 20:46:15 -05:00
Vincent Poulailleau
fcd431c6c3
Improved generic detail view error message for when pk or slug is missing.
2018-01-17 10:58:05 -05:00
hayashi
27557a7a99
Fixed #28857 -- Fixed invalid SQL when using Cast with complex expressions on PostgreSQL.
2018-01-17 09:28:03 -05:00
Mads Jensen
999fc0687d
Added a few tests for smtp EmailBackend.
2018-01-15 12:25:17 -05:00
Mads Jensen
59b1aaa5a5
Added a couple tests for collectstatic.
2018-01-15 11:15:14 -05:00
Tim Martin
02365d3f38
Fixed #28542 -- Fixed deletion of primary key constraint if the new field is unique.
2018-01-13 20:11:55 -05:00
Étienne Loks
9a621edf62
Fixed #29016 -- Fixed incorrect foreign key nullification on related instance deletion.
2018-01-13 10:31:00 -05:00
Tim Graham
b17c1d53fd
Removed unused query log clearing in bulk_create tests.
2018-01-12 18:44:36 -05:00
Дилян Палаузов
a38ae914d8
Fixed #28996 -- Simplified some boolean constructs and removed trivial continue statements.
2018-01-12 12:44:50 -05:00
Tim Graham
4bcec02368
Added tests for django.forms.formsets.all_valid().
2018-01-12 12:40:21 -05:00
Jon Dufresne
1e81a4b897
Fixed #28638 -- Made allowed_hosts a required argument of is_safe_url().
2018-01-11 07:03:50 -05:00
Fabio Bonelli
f636f0bb86
Fixed #29007 -- Fixed DecimalValidator crash on NaN, SNan, Inf, and Infinity values.
2018-01-10 21:43:32 -05:00
Fabio Bonelli
c886f3dee3
Fixed #29006 -- Fixed DecimalField.clean() crash on sNaN values.
2018-01-10 20:30:44 -05:00
Tim Graham
1c95737ebe
Reduced redundancy in DecimalField tests with subTest().
2018-01-10 20:30:24 -05:00
Mads Jensen
a613feb5d3
Completed test coverage for ModelDetailView.
2018-01-10 12:13:04 -05:00
George-Cristian Bîrzan
e2908ecb3e
Added more tests for HttpRequest.build_absolute_uri().
2018-01-10 11:32:19 -05:00
Tim Graham
366451880a
Updated HttpRequest.build_absolute_uri() tests to use subTest().
2018-01-10 11:32:15 -05:00
Tim Graham
66d74676e2
Fixed a GeoIP2 test failure with the latest GeoIP2 database.
2018-01-10 09:39:41 -05:00
Will Ayd
09530e61a0
Fixed #28869 -- Made tagged test classes and methods inherit tags from parents.
2018-01-08 20:57:33 -05:00
Alvin Lindstam
47a99d7012
Fixed #28989 -- Fixed HttpResponse.delete_cookie() for cookies that use __Secure/Host prefixes.
2018-01-08 12:32:47 -05:00
Tim Graham
8e94f9f7dd
Moved HttpResponse.set_cookie() tests to an appropriate location.
2018-01-08 12:01:59 -05:00
Mariusz Felisiak
8f8a93a9ae
Fixed #28859 -- Made Oracle backend raise DatabaseError if "no data found" exception is hidden by the Oracle OCI library.
...
Thanks Tim Graham for the review and Jani Tiainen for the report.
2018-01-06 18:50:54 +01:00
Vasilis Aggelou
777f216d55
Fixed #15522 -- Added ModelAdmin.delete_queryset() to customize "delete selected objects" deletion.
2018-01-05 18:28:45 -05:00
Tim Graham
ec2ce4517a
Fixed #28882 -- Fixed cleaning of disabled MultiValueFields.
...
Thanks avalanchy for the initial patch.
2018-01-05 15:49:54 -05:00
shanghui
3333d935d2
Fixed #28757 -- Allowed using contrib.auth forms without installing contrib.auth.
...
Also fixed #28608 -- Allowed UserCreationForm and UserChangeForm to
work with custom user models.
Thanks Sagar Chalise and Rômulo Collopy for reports, and Tim Graham
and Tim Martin for reviews.
2018-01-05 14:47:37 -05:00
Paulo
d1286a8a68
Fixed #28517 -- Fixed admin delete confirmation view crash when related models don't have a delete permission.
2018-01-04 19:07:46 -05:00
Tim Graham
8e1a7dab4b
Reorganized test_runner test apps.
2018-01-04 15:41:33 -05:00
Дилян Палаузов
d7b2aa24f7
Fixed #28982 -- Simplified code with and/or.
2018-01-03 20:12:23 -05:00
Jonas Haag
602481d0c9
Fixed #28986 -- Prevented boolean values in admin list display from being formatted with thousand separators.
2018-01-03 15:02:06 -05:00
Jonas Haag
ea10efebfa
Added display_for_value() tests for boolean values.
2018-01-03 15:02:00 -05:00
Tim Graham
acc8dd4142
Fixed #28984 -- Made assorted code simplifications.
2018-01-03 13:24:02 -05:00
Claude Paroz
b3cd9fb18b
Refs #15902 -- Made set_language() view always set the current language in a cookie.
...
The plan is to later deprecate/remove storing the language in the session.
2018-01-03 11:25:40 -05:00
я котик пур-пур
ccc25bfe4f
Refs #23919 -- Removed obsolete __init__.py files in management command directories.
2018-01-03 11:02:26 -05:00
shanghui
cc6bcc6ff5
Fixed #28867 -- Added system check for a model property that clashes with a related field accessor.
2018-01-03 10:34:31 -05:00
Robin Ramael
fbf647287e
Fixed #28811 -- Fixed crash when combining regular and group by annotations.
2018-01-03 08:24:16 -05:00
Alvin Lindstam
2cb6b7732d
Fixed #28902 -- Fixed password_validators_help_text_html() double escaping.
2018-01-02 19:51:06 -05:00
Tim Graham
ab7f4c3306
Refs #28965 -- Deprecated unused django.utils.http.cookie_date().
2018-01-02 11:23:04 -05:00
Alexey
0afffae4ec
Fixed #28965 -- Updated Set-Cookie's Expires date format to follow RFC 7231.
2018-01-02 11:22:59 -05:00
Tim Graham
5f456408a0
Refs #28930 -- Simplified schemas test with any().
2018-01-02 10:11:48 -05:00
Simon Charette
f5a989e603
Fixed #28974 -- Made refresh_from_db() hint routers about its instance.
2018-01-02 09:42:24 -05:00
Tim Graham
d065c92678
Fixed #28918 -- Fixed Model.refresh_from_db() for instances hidden by the default manager.
2017-12-30 18:00:36 -05:00
Simon Charette
dcdd219ee1
Fixed #25817 -- Made RenameField repoint to_field/to_fields references.
...
Also updated the autodetector to assume the RenameField operation will
perform the required repointing.
2017-12-30 14:59:22 -05:00
Sergey Fedoseev
1490611038
Fixed #28908 -- Allowed ArrayField lookups on ArrayAgg annotations.
2017-12-30 14:46:52 -05:00
Srinivas Reddy Thatiparthy (శ్రీనివాస్ రెడ్డి తాటిపర్తి)
58ec55b157
Fixed #28117 -- Added a helpful message in loaddata when psycopg2 can't load a fixture due to NUL characters.
2017-12-30 12:16:11 -05:00
Tomer Chachamu
9bc4d90d1a
Fixed #14642 -- Fixed generic inline formsets crash when using save_as_new=True.
2017-12-30 11:38:11 -05:00
Jon Dufresne
da82939e5a
Fixed #28912 -- Made EmailMessage.message() omit an empty To header.
2017-12-30 09:38:03 -05:00
Jon Dufresne
b03d500295
Fixed #28971 -- Made EmailMessage.message() set Cc from headers dict if it exists.
2017-12-30 09:37:59 -05:00
Jon Dufresne
6334939417
Tested passing To/Cc/Reply-To in EmailMessage(headers=...) without the corresponding argument.
2017-12-29 12:50:31 -05:00
shanghui
b0a2a2b07e
Made a few cleanups to invalid_models_tests.test_models.
2017-12-29 10:32:01 -05:00
Sergey Fedoseev
ae6fa914aa
Fixed #28926 -- Fixed loss of precision of big DurationField values on SQLite and MySQL.
2017-12-28 17:35:41 -05:00
Tim Graham
46d1af2e82
Moved generic_inlineformset_factory() tests to a separate file.
2017-12-28 17:17:47 -05:00
Mariusz Felisiak
83a36ac49a
Removed unnecessary trailing commas and spaces in various code.
2017-12-28 21:07:29 +01:00
Tim Graham
058d112ed2
Refs #27175 -- Removed an obsolete test comment and DEBUG=True.
...
As of e62165b898
2017-12-28 14:57:06 -05:00
Sergey Fedoseev
aefe624c62
Fixed #28841 -- Added ForcePolygonCW GIS function and deprecated ForceRHR.
2017-12-27 19:26:14 -05:00
Sergey Fedoseev
44908d4d93
Fixed #28967 -- Prevented Cast to FloatField from rounding to integer on MySQL.
2017-12-27 19:16:37 -05:00
hui shang
f1aa58479c
Fixed #28714 -- Added system checks for invalid model field names in Meta.indexes.
...
Thanks Gabriel for the report and Adam Johnson for the review.
2017-12-27 18:56:24 -05:00
Mariusz Felisiak
1d00923848
Refs #28958 -- Added a test for ModelAdmin with query expressions in ordering.
...
This provides additional test coverage but isn't a regression test for
the ticket's issue.
2017-12-27 19:47:14 +01:00
Mariusz Felisiak
c815213740
Fixed #28958 -- Fixed admin changelist crash when using a query expression in the page's ordering.
...
Thanks Tim Graham for the review.
2017-12-27 18:38:30 +01:00
Ran Benita
c21f158295
Fixed #28944 -- Fixed crash when chaining values()/values_list() after QuerySet.select_for_update(of=()).
2017-12-26 11:41:17 -05:00
Tim Martin
5778b5701d
Fixed #28731 -- Added an error message when using an empty Q() in a When expression.
...
Otherwise it generates invalid SQL.
2017-12-26 10:39:47 -05:00
Claude Paroz
23b21db31b
Fixed #28594 -- Removed Jython docs and specific code
...
Thanks Andrey Martyanov for the reporti, and Tim Graham for the review.
2017-12-23 10:26:32 +01:00
Cameron Curry
622ead6aaf
Fixed #28937 -- Allowed BinaryField to be editable=True.
2017-12-22 16:31:46 -05:00
Simon Charette
9f7772e098
Fixed #28884 -- Fixed crash on SQLite when renaming a field in a model referenced by a ManyToManyField.
...
Introspected database constraints instead of relying on _meta.related_objects
to determine whether or not a table or a column is referenced on rename
operations.
This has the side effect of ignoring both db_constraint=False and virtual
fields such as GenericRelation which aren't backend by database level
constraints and thus shouldn't prevent the rename operations from being
performed in a transaction.
Regression in 095c1aaa89
2017-12-22 15:19:05 -05:00
Sergey Fedoseev
ebc4ee3369
Refs #23941 -- Prevented incorrect rounding of DecimalField annotations on SQLite.
2017-12-21 19:50:56 -05:00
Tilmann Becker
01384ce36c
Fixed #28947 -- Fixed crash when coercing a translatable URL pattern to str.
...
Regression in df41b5a05d
2017-12-20 20:36:41 -05:00
Tim Graham
04d1454350
Moved unnecessary inner imports in admin_scripts tests.
2017-12-20 14:52:20 -05:00
Tim Graham
e7b804c060
Fixed #28941 -- Fixed crash in testserver command startup.
...
Regression in 2b09e4c88e
2017-12-20 14:38:06 -05:00
Mariusz Felisiak
fc9eec7bb7
Fixed #28934 -- Prevented Cast from truncating microseconds on Oracle.
2017-12-20 11:05:27 -05:00
Mariusz Felisiak
4420761ea9
Fixed #28727 -- Fixed Cast crash on SQLite when casting a Python date/datetime to Date/DateTimeField.
2017-12-19 19:54:58 +01:00
Tim Graham
770b9ea77f
Fixed #25277 -- Restored test dependency to the original python-memcached.
2017-12-18 10:37:43 -10:00
Sergey Fedoseev
6fd6d8383f
Fixed #28915 -- Prevented SQLite from truncating trailing zeros in the fractional part of DecimalField.
...
This reverts commit a146b65628
2017-12-12 21:57:41 -10:00
Rodrigo Pinheiro Marques de Araújo
30a389bd77
Fixed #28898 -- Corrected admin check to allow a OneToOneField in ModelAdmin.autocomplete_fields.
2017-12-13 02:39:27 -05:00
Sergey Fedoseev
da71e4bb08
Fixed #28896 -- Reallowed filtering a queryset with GeometryField=None.
...
Regression in 58da81a5a3
2017-12-12 17:12:04 -10:00
Sergey Fedoseev
10bfa876be
Refs #27985 -- Reallowed using __exact=None as an alias for __isnull=True if a custom lookup class with lookup_name != None is registered as the exact lookup.
...
Regression in 58da81a5a3#28896 .
2017-12-12 17:11:58 -10:00
Daniil
7c7bc6391a
Fixed #28874 -- Prevented double escaping of errors on hidden form fields.
2017-12-11 07:30:47 -05:00
Morgan Wahl
a9e5ac823d
Refs #28856 -- Added test for caching of a GenericForeignKey pointing to a model that uses more than one level of MTI.
...
Forwardport of test and release notes of
35222035029863f95769e2e59beeeb953d125689 from stable/1.11.x
2017-12-08 14:06:28 -05:00
Nick Pope
81abece192
Corrected type of MESSAGE_TAGS setting override in tests.
2017-12-08 13:18:31 -05:00
geekodour
c6864a01b2
Fixed #28791 -- Allowed commands that don't require settings to work if the DJANGO_SETTINGS_MODULE doesn't exist.
2017-12-07 14:19:18 -05:00
Tim Graham
a862af3839
Fixed #28893 -- Removed unnecessary dict.items() calls.
2017-12-06 17:17:59 -05:00
Sergey Fedoseev
183fb7b2b9
Fixed #28870 -- Added support for functools.partialmethod serialization in migrations.
2017-12-06 14:49:37 -05:00
Mariusz Felisiak
fc48047586
Refs #28876 -- Fixed incorrect foreign key constraint name for models with quoted db_table.
...
Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
Leite for the report.
2017-12-05 21:11:20 +01:00
Mariusz Felisiak
f79d9a322c
Refs #28876 -- Fixed incorrect class-based model index name generation for models with quoted db_table.
...
Thanks Simon Charette and Tim Graham for the review and Carlos E. C.
Leite for the report.
2017-12-05 21:05:10 +01:00
Nick Pope
e014f91a70
Fixed #28890 -- Removed newlines between MultiWidget's subwidgets.
...
Regression in b52c73008a
2017-12-05 11:22:36 -05:00
Дилян Палаузов
d2afa5eb23
Fixed #28860 -- Removed unnecessary len() calls.
2017-12-04 10:35:23 -05:00
Tim Graham
7664fe2759
Refs #28871 -- Fixed admin_views selenium test failure.
2017-12-02 09:54:31 -05:00
Tim Graham
81057645f6
Fixed #28871 -- Fixed initialization of autocomplete widgets in "Add another" inlines.
...
Also allowed autocomplete widgets to work on AdminSites with a name other
than 'admin'.
2017-12-01 22:14:32 -05:00
Simon Charette
095c1aaa89
Fixed #28849 -- Fixed referenced table and column rename on SQLite.
...
Thanks Ramiro for the input and Tim for the review.
2017-12-01 22:12:24 -05:00
Tim Graham
474bd7a5d4
Used a separate admin site for autocomplete tests.
2017-12-01 21:57:05 -05:00
Sergey Fedoseev
cf12257db2
Fixed #28863 -- Fixed filter on annotation that contains Q.
2017-12-01 21:48:49 -05:00
Tim Graham
c3e0adcad8
Fixed #28305 -- Fixed "Cannot change column 'x': used in a foreign key constraint" crash on MySQL with a sequence of AlterField or RenameField operations.
...
Regression in 45ded053b1
2017-12-01 19:07:46 -05:00
Vasiliy Bolshakov
03974d8122
Fixed #28866 -- Made InlineAdminFormSet include InlineModelAdmin's Media before its formset's Media.
...
This provides better backwards compatibility following refs #28377 .
2017-11-30 20:15:28 -05:00
Simon Charette
e50add6ca1
Fixed #28856 -- Fixed a regression in caching of a GenericForeignKey pointing to a MTI model.
...
Regression in b9f8635f58
2017-11-30 09:28:44 -05:00
Mads Jensen
f0a68c2511
Fixed #28702 -- Made query lookups for CIText fields use citext.
2017-11-29 10:35:37 -05:00
Simon Charette
78c5e7b90e
Fixed #28834 -- Followed ancestor links on field cache lookup failure.
...
Thanks Tim for the review.
2017-11-29 01:28:39 -05:00
Nicolas Delaby
746caf3ef8
Fixed #28837 -- Fixed test client crash if an exception with more than one arg is raised.
...
Also removed usage of the problematic pattern elsewhere.
Regression in 6e55e1d88a
2017-11-28 18:55:23 -05:00
Jon Dufresne
7a6fbf36b1
Fixed #28853 -- Updated connection.cursor() uses to use a context manager.
2017-11-28 11:28:09 -05:00
Raphael Michel
616f468760
Fixed #28848 -- Fixed SQLite/MySQL crash when ordering by a filtered subquery that uses nulls_first/nulls_last.
2017-11-27 11:35:44 -05:00
Sergey Fedoseev
93cdd07e8f
Used bytes.hex() and bytes.fromhex() to simplify.
2017-11-23 08:52:23 -05:00
Yan Mitrofanov
54e5c4a00e
Fixed #28820 -- Eliminated an extra query with QuerySet.update() on proxy models.
2017-11-21 12:11:47 -05:00
Dražen Odobašić
d97f026a7a
Fixed #28817 -- Made QuerySet.iterator() use server-side cursors after values() and values_list().
2017-11-21 10:33:56 -05:00
Tim Graham
6cb6382639
Added assertion helpers for PostgreSQL's server-side cursor tests.
2017-11-21 08:21:09 -05:00
Tim Graham
e3c852cbd6
Fixed #28804 -- Fixed "Unknown system variable 'transaction_isolation'" on MariaDB.
...
Regression in 967450a3bf
2017-11-20 10:08:34 -05:00
Krzysztof Nazarewski
244cc40155
Fixed #26184 -- Allowed using any lookups in ModelAdmin.search_fields.
...
Thanks Krzysztof Nazarewski for the initial patch.
2017-11-18 19:33:52 -05:00
Tim Graham
9d1d3b2d2f
Refs #28814 -- Fixed test_runner failure on Python 3.7.
...
Due to https://bugs.python.org/issue30399 .
2017-11-17 16:13:23 -05:00
Tim Graham
9bea555d06
Fixed test failures due to ordering differences on PostgreSQL 10.
2017-11-15 09:37:18 -05:00
Simon Charette
ee85ef8315
Fixed #28792 -- Fixed index name truncation of namespaced tables.
...
Refs #27458 , #27843 .
Thanks Tim and Mariusz for the review.
2017-11-14 21:36:25 -05:00
Tim Graham
532a4f22ad
Fixed invalid escape sequence warning in check_framework test.
2017-11-14 19:05:20 -05:00
Sergey Fedoseev
967450a3bf
Fixed #28794 -- Fixed tx_isolation deprecation warning on MySQL 5.7.20+.
2017-11-14 15:40:44 -05:00
Дилян Палаузов
23bf4ad87f
Fixed #28795 -- Removed 'not in' checks and used dict.setdefault().
2017-11-14 10:52:52 -05:00
Sergey Fedoseev
b5ecbf1e12
Simplified choices iterators in tests.model_fields.models.
2017-11-13 13:11:07 -05:00
Mariusz Felisiak
2d3cc94284
Fixed #28781 -- Added QuerySet.values()/values_list() support for union(), difference(), and intersection().
...
Thanks Tim Graham for the review.
2017-11-12 14:28:11 +01:00
shanghui
1907fc9b12
Fixed #28534 -- Made JSONField.has_changed() ignore key order and consider True/1 values as different.
2017-11-11 19:45:23 -05:00
Paulo
ee49306176
Fixed #27710 -- Made Model.save() invalidate cached, stale relations after a primary key assignment.
2017-11-09 11:40:34 -05:00
shanghui
ebb998976e
Fixed #28751 -- Corrected the error message for inactive users in AdminAuthenticationForm.
...
Thanks SeungWon Kang for the report and Tim Graham for the review.
2017-11-08 09:39:12 -05:00
shanghui
359370a8b8
Fixed #28645 -- Reallowed AuthenticationForm to raise the inactive user error when using ModelBackend.
...
Regression in e0a3d93730
2017-11-08 09:39:12 -05:00
Claude Paroz
0cf00769ad
Fixed #28585 -- Calculated admin's change form multipart context variable from forms and formsets
...
Thanks Tim Graham for the review.
2017-11-07 19:06:32 -05:00
Bjorn Kristinsson
ac6a4eb9f9
Fixed #28719 -- Added a helpful exception if MultipleObjectTemplateResponseMixin doesn't generate any template names.
2017-11-07 18:46:52 -05:00
Jonas Haag
a2851f204c
Fixed #28720 -- Added HttpRequest.get_full_path_info().
2017-11-07 15:58:05 -05:00
Imran Iqbal
3e7497a05e
Fixed #28758 -- Fixed RangeMax/MinValueValidators crash with unbound ranges.
2017-11-07 15:07:03 -05:00
Claude Paroz
1b7780ea08
Fixed #28544 -- Made unlocalize template filter behave like {% localize off %} tag
...
Thanks Beda Kosata for the report and Tim Graham for the review.
2017-11-07 20:48:15 +01:00
Chris Lamb
998c9dd599
Fixed #28663 -- Add a check for likely incorrectly migrated django.urls.path() routes.
2017-11-07 11:39:59 -05:00
Дилян Палаузов
6c0042430e
Fixed #28776 -- Fixed a/an/and typos in docs and comments.
2017-11-06 22:41:03 -05:00
Yusuke Miyazaki
278d66b94b
Fixed #28501 -- Fixed "python -m django runserver" crash.
2017-11-06 09:58:15 -05:00
Yusuke Miyazaki
ac21f2e391
Added RestartWithReloaderTests.
2017-11-06 09:54:31 -05:00
Sergey Fedoseev
69922d303d
Refs #17448 -- Fixed GeoModelTest.test_raw_sql_query.
...
The test was a false positive.
2017-11-04 10:08:26 -04:00
Tom
b81905bfd4
Fixed #28571 -- Added a prompt to bypass password validation in createsuperuser.
2017-11-03 20:00:08 -04:00
Tim Graham
872be5976d
Improved technique for matching input prompts in contrib.auth management tests.
2017-11-03 20:00:08 -04:00
Mike Hansen
514b2c989a
Fixed #28723 -- Fixed RelatedManager's prefetch_related() cache name.
2017-11-02 10:06:00 -04:00
Michał Pasternak
e554b72a2a
Fixed #28749 -- Added subquery support for ArrayField's __in lookup.
2017-11-01 15:12:18 -04:00
Charlie Denton
cbe334918a
Fixed #28750 -- Allowed models to define Meta.manager_inheritance_from_future for backwards compatibility.
...
Refs 631f4ab061
2017-10-31 13:22:27 -04:00
Adam Johnson
acc989f037
Fixed #28760 -- Removed DummyCache's unnecessary get/set/delete_many().
2017-10-31 12:16:09 -04:00
Rajesh Veeranki
5e1a356060
Fixed typo in tests/many_to_many/tests.py.
2017-10-31 10:21:02 -04:00
Paulo
fcfcf8aae4
Fixed #28742 -- Fixed AttributeError crash when assigning None to cached reverse relations.
2017-10-30 14:02:03 -04:00
Adam Johnson
abacd09f07
Refs #27318 -- Made DummyCache.set_many() return a list for consistency with other backends.
2017-10-30 12:13:17 -04:00
Ran Benita
03049fb8d9
Refs #28010 -- Allowed reverse related fields in SELECT FOR UPDATE .. OF.
...
Thanks Adam Chidlow for polishing the patch.
2017-10-28 20:33:42 -04:00
Srinivas Reddy Thatiparthy
55b5393bd2
Fixed #28474 -- Made DurationField raise ValidationError for inputs that raised OverflowError.
2017-10-25 18:05:13 -04:00
Mariusz Felisiak
81e357a7e1
Fixed #28689 -- Fixed unquoted table names in Subquery SQL when using OuterRef.
...
Regression in f48bc7c3db
2017-10-25 21:52:38 +02:00
Ryan Verner
9473a8481a
Fixed #28740 -- Added 'continent_code' and 'continent_name' in GeoIP2.city() dict.
2017-10-25 10:07:37 -04:00
medmunds
d1317edad0
Fixed #28739 -- Fixed get_fixed_timezone() for negative timedeltas.
2017-10-24 21:27:53 -04:00
Tim Graham
8b9a163afa
Refs #28688 -- Updated a selenium test for admin's URLify.js change.
...
English words aren't removed if non-ASCII chars are present.
2017-10-24 11:03:36 -04:00
Jon Dufresne
6ed347d851
Fixed #28706 -- Moved AuthenticationFormn invalid login ValidationError to a method for reuse.
2017-10-23 09:10:45 -04:00
Tomer Chachamu
21a3a29dc9
Fixed #28722 -- Made QuerySet.reverse() affect nulls_first/nulls_last.
2017-10-21 20:55:45 -04:00
Levi Payne
6c3104221b
Refs #28721 -- Added test for variations of 'inf'/'infinity' as a template variable names.
...
Fixed by 9ec7d8e514
2017-10-21 20:55:26 -04:00
Claude Paroz
9ec7d8e514
Fixed #28730 -- Fixed loss of precision for large integer literals in templates
...
Thanks Fraser Nevett for the report and Tim Graham for patch edits.
2017-10-21 17:20:29 +02:00
Mads Jensen
45d5d2dcaa
Removed unnecessary tuple()/list() calls.
2017-10-21 09:42:25 -04:00
Flávio Juvenal
f6e1789654
Fixed #28577 -- Added checks for ArrayField and JSONField to prevent mutable defaults.
2017-10-20 13:17:22 -04:00
Lucas Connors
5ceaf14686
Fixed #27515 -- Made AuthenticationForm's username field use the max_length from the model field.
...
Thanks Ramin Farajpour Cami for the report.
2017-10-20 11:13:26 -04:00
Lucas Connors
d233391208
Refs #19130 -- Added a test for AuthenticationForm.username max_length.
...
This will be a more useful regression test after refs #27515 .
2017-10-20 11:10:32 -04:00
Mads Jensen
5114669f72
Refs #24031 -- Added test for Case and When constructor arguments.
2017-10-20 10:15:11 -04:00
Mads Jensen
f7036b3e26
Fixed #28662 -- Silenced join template filter error if arg isn't iterable.
2017-10-20 09:46:31 -04:00
Simon Charette
d4fb742094
Refs #28575 -- Made RelatedObjectDoesNotExist classes pickable.
...
Thanks to Rachel Tobin for the initial __qualname__ work and tests.
2017-10-18 21:43:53 -04:00
Tim Graham
1399f8ae77
Refs #28711 -- Replaced ugettext_lazy() with gettext_lazy() in a test.
...
As per c651331b34
2017-10-18 20:07:36 -04:00
Jonas Haag
d997ab7764
Fixed #28711 -- Fixed unordered_list template filter with lazy translations.
2017-10-18 19:45:10 -04:00
Jonas Haag
b21b1b10af
Refs #23260 -- Tested nested generator input to unordered_list template filter.
2017-10-18 19:37:30 -04:00
Tim Graham
1b73ccc4bf
Fixed #28497 -- Restored the ability to use sliced QuerySets with __exact.
...
Regression in ec50937bcb
2017-10-16 13:56:38 -04:00
Yuri Kaszubowski Lopes
d98210c255
Fixed #28713 -- Prevented ModelBackend.get_all_permissions() from mutating get_user_permissions().
2017-10-14 20:47:49 -04:00
Claude Paroz
c1fa6672dd
Refs #28710 -- Simplified l10n format test
2017-10-14 21:07:51 +02:00
k
399a8db33b
Fixed #28695 -- Allowed models to use __init_subclass__().
2017-10-13 21:29:12 -04:00
Claude Paroz
8c538871bd
Fixed #28710 -- Fixed the Basque DATE_FORMAT string
...
Thanks Eneko Illarramendi for the report and initial patch.
2017-10-13 19:48:20 +02:00
Tom
32ade78c55
Refs #28440 -- Fixed server connection closing test on macOS.
2017-10-13 13:29:29 -04:00
Tim Graham
941b0a5b33
Fixed #28708 -- Added constants to detect the Python version.
2017-10-13 10:11:15 -04:00
Rachel Tobin
6c92f711ea
Refs #28575 -- Allowed pickling Model.DoesNotExist and MultipleObjectsReturned classes.
2017-10-13 09:16:09 -04:00
Paulo
a7b5ad8b19
Fixed #27846 -- Made Model.refresh_from_db() clear cached relations.
2017-10-12 17:04:10 -04:00
Mads Jensen
e8649ae368
Added test for FlatPage.__str__().
2017-10-12 09:45:49 -04:00
Mads Jensen
bd8deeccd5
Added setUp() method to FlatpageModelTests.
2017-10-12 09:45:26 -04:00
François Freitag
41be85862d
Fixed #28679 -- Fixed urlencode()'s handling of bytes.
...
Regression in fee42fd99e
2017-10-12 09:08:33 -04:00
Daniel Tao
4d60261b2a
Fixed #28601 -- Prevented cache.get_or_set() from caching None if default is a callable that returns None.
2017-10-10 09:20:34 -04:00
François Freitag
0e212a705e
Split django.utils.http tests into separate test classes.
2017-10-10 08:53:01 -04:00
Hasan Ramezani
6aec130a4c
Fixed #28591 -- Added an error message for createsuperuser --username= (blank).
2017-10-09 21:49:35 -04:00
Mads Jensen
81d5320db5
Added tests for Combinable's bitwise logical operation errors.
2017-10-09 11:49:19 -04:00
Simon Charette
9d93dff333
Fixed #28665 -- Change some database exceptions to NotImplementedError per PEP 249.
2017-10-06 12:47:08 -04:00
Mariusz Felisiak
1b823b8f18
Fixed #28596 -- Fixed QuerySet.bulk_create() and cascade deletion crash on Oracle when using more than 65535 parameters.
...
Thanks Tim Graham for the review.
2017-10-05 18:52:37 +02:00
Mads Jensen
86367a11d3
Added tests for invalid {% for %} usage and ForLoop.__repr__().
2017-10-05 11:33:14 -04:00
Tim Graham
d0c761d3f8
Refs #28584 -- Removed unused DatabaseFeatures.can_share_in_memory_db.
2017-10-03 20:17:12 -04:00
Tim Graham
27193aea00
Fixed #28584 -- Dropped support for SQLite < 3.7.15.
2017-10-03 10:42:18 -04:00
Tom
f1c007bbf2
Fixed #28642 -- Added caching to parse_accept_lang_header().
2017-10-02 14:07:28 -04:00
Tom
f04e6732c3
Refs #27804 -- Used subTest() in parse_accept_lang_header() test.
2017-10-02 14:04:52 -04:00
Mads Jensen
aba3467585
Added tests for invalid {% autoescape %} usage.
2017-10-02 11:02:58 -04:00
Mariusz Felisiak
3fb1ad9505
Fixed incorrect integer division in DeletionTests.test_large_delete_related.
2017-10-02 10:11:20 -04:00
Mariusz Felisiak
d896809a3a
Refs #23919 -- Removed unneeded float()/int() calls.
2017-10-02 08:49:26 -04:00
Mads Jensen
41406bf98e
Increased test coverage for db/backends/base/operations.py.
2017-09-30 19:48:55 -04:00
Mads Jensen
25307089bc
Completed test coverage for default template filters.
2017-09-30 18:34:51 -04:00
Tim Graham
dd82f33271
Fixed #27979 -- Made MySQL raise IntegrityError rather than OperationalError when saving negative numbers in PositiveInteger fields.
2017-09-29 15:20:32 -04:00
Mads Jensen
3e72f4b7b6
Completed test coverage for BasePasswordHasher.
2017-09-29 09:28:25 -04:00
Mads Jensen
776f6902d9
Moved BasePasswordHasher tests to its own test case.
2017-09-29 09:28:24 -04:00
Mads Jensen
d917c17a3b
Completed test coverage for AnonymousUser.
2017-09-28 13:11:23 -04:00
Mads Jensen
7fce4dc5ff
Moved AnonymousUser tests to its own test case.
2017-09-28 13:11:07 -04:00
Mariusz Felisiak
fc6528b25a
Fixed #28629 -- Made tree.Node instances hashable.
...
Regression in 508b5debfb
2017-09-28 12:07:19 -04:00
Mads Jensen
129f4900be
Added tests for RequestSite.__init__() and __str__().
2017-09-28 08:16:21 -04:00
Tim Graham
2015f5f134
Added a separate test class for RequestSite.
2017-09-28 08:14:17 -04:00
Tim Graham
1d8cfa3608
Fixed #28626 -- Dropped support for PostgreSQL 9.3.
...
Thanks Simon Charette for the introspection changes.
2017-09-27 11:00:04 -04:00
Mads Jensen
8ddbe01760
Added a test for pbkdf2()'s default digest algorithm.
2017-09-27 10:36:26 -04:00
Tim Graham
c7e9e22695
Added cleanup for an introspection test.
2017-09-27 09:51:49 -04:00
Josh Schneier
e8c4596329
Fixed #28562 -- Fixed DecimalValidator handling of positive exponent scientific notation.
2017-09-27 09:42:04 -04:00
Mads Jensen
4803834aaa
Added a test for PermWrapper.__iter__().
2017-09-26 19:42:50 -04:00
Tim Graham
cfff2af02b
Fixed #27857 -- Dropped support for Python 3.4.
2017-09-25 17:11:03 -04:00
Tim Graham
a80903b711
Removed DatabaseFeatures.supports_microsecond_precision.
...
MySQL 5.5 (refs #28552 ) was the last database to use it.
2017-09-25 14:48:15 -04:00
Tim Graham
8a1768432b
Fixed #28552 -- Dropped support for MySQL 5.5.
2017-09-25 14:48:11 -04:00
Mads Jensen
c0d968ea1f
Added a test for TranslatableFile.__eq__().
2017-09-25 10:22:38 -04:00
Tim Graham
67a6ba391b
Reverted "Fixed #28248 -- Fixed password reset tokens being valid for 1 day longer than PASSWORD_RESET_TIMEOUT_DAYS."
...
This reverts commit 95993a89ce
2017-09-25 09:05:00 -04:00
Tim Graham
4a461d49c7
Advanced deprecation warnings for Django 2.1.
2017-09-22 12:51:19 -04:00
Tim Graham
2bd207ada0
Refs #15667 -- Removed support for Widget.render() methods without the renderer argument.
...
Per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
ba42456c2e
Refs #27648 -- Removed support for (iLmsu) regex groups in url() patterns.
...
Per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
5bcca2a056
Refs #27532 -- Removed Model._meta.has_auto_field per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
48d57788ee
Refs #26447 -- Removed the USE_ETAGS setting per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
4502489a46
Refs #18974 -- Removed @models.permalink() decorator per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
5e31be1b96
Refs #25187 -- Required the authenticate() method of authentication backends to have request as the first positional argument.
...
Per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
578711c310
Refs #27098 -- Removed DatabaseIntrospection.get_indexes() per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
e62165b898
Refs #27175 -- Removed exception silencing from the {% include %} template tag.
...
Per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
96107e2844
Refs #26956 -- Removed the host parameter of django.utils.http.is_safe_url().
...
Per deprecation timeline.
2017-09-22 12:51:18 -04:00
Tim Graham
e47b56d791
Refs #20892 -- Removed support for passing pylibmc behavior settings as top-level attributes of CACHES['OPTIONS'].
...
Per deprecation timeline.
2017-09-22 12:51:17 -04:00
Tim Graham
87d2240e6c
Refs #27067 -- Removed django.utils.translation.string_concat() per deprecation timeline.
2017-09-22 12:51:17 -04:00
Tim Graham
6e40b70bf4
Refs #26929 -- Removed extra_context parameter of contrib.auth.views.logout_then_login().
...
Per deprecation timeline.
2017-09-22 12:51:17 -04:00
Tim Graham
4f313e284e
Refs #17209 -- Removed login/logout and password reset/change function-based views.
...
Per deprecation timeline.
2017-09-22 12:51:17 -04:00
Nicolas Delaby
01d440fa1e
Fixed #27332 -- Added FilteredRelation API for conditional join (ON clause) support.
...
Thanks Anssi Kääriäinen for contributing to the patch.
2017-09-22 11:53:17 -04:00
Anssi Kääriäinen
771e06af2a
Added a test for QuerySet.select_related() reverse caching.
2017-09-21 14:25:42 -04:00
Shai Berger
d612026c37
Refs #28595 -- Added a hook to add execute wrappers for database queries.
...
Thanks Adam Johnson, Carl Meyer, Anssi Kääriäinen, Mariusz Felisiak,
Michael Manfre, and Tim Graham for discussion and review.
2017-09-21 12:13:09 -04:00
Mads Jensen
41a7876991
Added test for too large input to django.utils.http.base36_to_int().
2017-09-21 10:21:02 -04:00
Niall Dalton
4fe6588da3
Fixed #28576 -- Added color interpretation method to GDALBand.
2017-09-21 09:42:38 -04:00
Thomas Schorr
52eb5b289e
Fixed #28617 -- Made ogrinspect output pep8 compliant.
2017-09-20 21:03:14 -04:00
Sjoerd Job Postmus
df41b5a05d
Fixed #28593 -- Added a simplified URL routing syntax per DEP 0201.
...
Thanks Aymeric Augustin for shepherding the DEP and patch review.
Thanks Marten Kenbeek and Tim Graham for contributing to the code.
Thanks Tom Christie, Shai Berger, and Tim Graham for the docs.
2017-09-20 18:04:42 -04:00
Florian Apolloner
c4c128d67c
Fixed #28488 -- Reallowed error handlers to access CSRF tokens.
...
Regression in eef95ea96f
2017-09-20 16:22:18 -04:00
Florian Apolloner
77f82c4bf1
Initialized CsrfViewMiddleware once in csrf_tests.
2017-09-20 16:22:12 -04:00
Tim Graham
46dcdf9a29
Added a checks test for valid i18n patterns.
2017-09-20 10:23:28 -04:00
Tim Graham
f7b0532ec0
Refs #28334 -- Fixed crash in hstore/citext oid caching during test db creation.
2017-09-19 07:04:31 -04:00
Mariusz Felisiak
fb02ebe889
Fixed #28597 -- Fixed crash with the name of a model's autogenerated primary key in an Index's fields.
2017-09-18 14:06:00 -04:00
Johannes Hoppe
94cd8efc50
Fixed #14370 -- Allowed using a Select2 widget for ForeignKey and ManyToManyField in the admin.
...
Thanks Florian Apolloner and Tim Graham for review and
contributing to the patch.
2017-09-18 13:48:02 -04:00
Claude Paroz
774f5548bd
Fixed #28610 -- Skipped test when serializer is not available
...
Thanks Tim Graham for the review.
2017-09-18 18:22:13 +02:00
Mads Jensen
d549b88050
Fixed #26608 -- Added support for window expressions (OVER clause).
...
Thanks Josh Smeaton, Mariusz Felisiak, Sergey Fedoseev, Simon Charettes,
Adam Chainz/Johnson and Tim Graham for comments and reviews and Jamie
Cockburn for initial patch.
2017-09-18 09:42:29 -04:00
Tim Graham
da1ba03f1d
Added test skipping for a PostgreSQL JSONField test.
2017-09-18 09:19:26 -04:00
Claude Paroz
256182c43d
Revert "Refs #21286 -- Enabled serializer tests with time pk model"
...
This reverts commit 01c6a3e227
2017-09-18 09:34:21 +02:00
Claude Paroz
01c6a3e227
Refs #21286 -- Enabled serializer tests with time pk model
2017-09-17 19:29:33 +02:00
Igor Gumenyuk
86a18dc46a
Fixed #28334 -- Added caching for hstore/citext OIDs.
2017-09-15 10:00:12 -04:00
Mads Jensen
1dafd8cb0b
Refs #24031 -- Added test for When.__repr__().
2017-09-15 06:13:38 -04:00
Tim Graham
116940e3ef
Fixed a Dutch translation in i18n tests.
2017-09-14 08:26:38 -04:00
Tim Graham
7cc8507d9c
Added a test for mixing args and kwargs in reverse().
2017-09-14 07:07:41 -04:00
Tim Graham
ee4043f735
Refs #28593 -- Moved django.conf.urls.include() to django.urls().
...
The old location remains for backwards compatibility. Documentation
will be updated separately along with the rest of the URL routing changes.
2017-09-13 16:32:03 -04:00
Mariusz Felisiak
c6a1faecc3
Refs #27090 -- Added real database sequence introspection.
...
Thanks Mariusz Felisiak for the Oracle part and Tim Graham for the
review.
2017-09-13 20:12:32 +02:00
Tom
ac756f16c5
Fixed #28440 -- Fixed WSGIServer hang on responses without a Content-Length.
...
Disabled keep-alive to fix the regression in
e6065c7b83
2017-09-12 10:41:28 -04:00
Tim Graham
f896eb30f6
Removed django.contrib.gis.geometry.backend.
...
The layer of indirection is unchanged and undocumented
since its introduction in ff60c5f9de
2017-09-12 09:51:02 -04:00
Josh Schneier
0dbcd0e87f
Added tests for DecimalValidator.
2017-09-11 14:18:02 -04:00
Simon Charette
c466ef3b34
Tested field deconstruction with DEFAULT_DB_TABLESPACE and db_tablespace.
2017-09-11 12:20:45 -04:00
Sergey Fedoseev
3905cfa1a5
Fixed #28353 -- Fixed some GIS functions when queryset is evaluated more than once.
...
Reverted test for refs #27603 in favor of using FuncTestMixin.
2017-09-11 11:56:39 -04:00
Sergey Fedoseev
a0b4ecce57
Fixed #28392 -- Fixed GIS's WKT regex to match large scientific notation numbers.
...
Thanks Greg Larmore for report and initial patch.
2017-09-11 09:13:02 -04:00
Claude Paroz
a599ae6018
Refs #24928 -- Added introspection support for PostgreSQL RangeField
2017-09-09 20:22:47 +02:00
Claude Paroz
0cbb6ac007
Refs #24928 -- Added introspection support for PostgreSQL JSONField
...
Thanks Adam Johnson and Tim Graham for the reviews.
2017-09-09 18:26:29 +02:00
Luoxzhg
ffbee67f8e
Fixed some comments referring to a nonexistent TestClient class.
2017-09-09 11:21:15 -04:00
Sergey Fedoseev
63d2472b10
Fixed capitalization of "Spherical Mercator."
2017-09-09 09:35:30 -04:00
Sergey Fedoseev
0ab1dc0a8b
Fixed deepcopy of AreaField and DistanceField.
2017-09-08 14:13:50 -04:00
Tim Graham
0c4ac12a7b
Fixed #28546 -- Fixed translation's to_locale() with langauge subtags.
...
Thanks Brent Hand for the initial patch.
2017-09-08 13:46:00 -04:00
Tim Graham
9829b75d5b
Added more tests for translation's to_locale().
2017-09-08 13:43:06 -04:00
Tim Graham
6e4c6281db
Reverted "Fixed #27818 -- Replaced try/except/pass with contextlib.suppress()."
...
This reverts commit 550cb3a365
2017-09-07 08:16:21 -04:00
Sergey Fedoseev
f3c9562143
Fixed #15648 -- Allowed QuerySet.values_list() to return a namedtuple.
2017-09-06 15:32:32 -04:00
Olivier Tabone
a027447f56
Fixed #27318 -- Made cache.set_many() return the list of failed keys.
2017-09-06 14:38:44 -04:00
Sami J. Lehtinen
407c1249c9
Fixed #28032 -- Added Paginator.get_page().
...
Moved boilerplate from docs to a method.
2017-09-06 14:17:19 -04:00
Sergey Fedoseev
5b1c389603
Refs #23919 -- Replaced usage of django.utils.functional.curry() with functools.partial()/partialmethod().
2017-09-06 13:11:18 -04:00
François Freitag
ad4a8acdb5
Fixed #11557 -- Added support for a list of fields in Meta.get_latest_by and QuerySet.earliest()/latest().
2017-09-05 20:14:54 -04:00
Dima Kudosh
093fd479d6
Fixed #28335 -- Allowed query expressions in Meta.ordering.
2017-09-05 19:10:20 -04:00
Josh Schneier
48c394a6fc
Fixed #28555 -- Made CharField convert whitespace-only values to the empty_value when strip is enabled.
2017-09-05 12:41:38 -04:00
Tim Graham
46e2b9e059
Fixed CVE-2017-12794 -- Fixed XSS possibility in traceback section of technical 500 debug page.
...
This is a security fix.
2017-09-05 10:58:38 -04:00
François Freitag
663946463d
Removed hardcoding from get_earliest_or_latest tests' tearDown().
2017-09-05 10:04:22 -04:00
Mariusz Felisiak
3ba4de59a2
Added tests for BooleanField/NullBooleanField's check constraints on Oracle.
2017-09-05 09:02:56 +02:00
Mads Jensen
f4135783ad
Fixed #28126 -- Added GistIndex to contrib.postgres.
...
Thanks to Marc Tamlyn for the initial patch.
2017-09-04 21:08:02 -04:00
Nick Pope
66657eb01f
Improved messages in IndexErrors raised by GDAL objects.
2017-09-04 19:00:32 -04:00
