fabric.js/CONTRIBUTING.md

73 lines
3.9 KiB
Markdown
Raw Permalink Normal View History

2013-09-14 11:32:44 +00:00
# Contributing to Fabric
1. [Questions?!?](#questions)
2. [Issue tracker](#issue-tracker)
3. [Issue tracker guidelines](#issue-tracker-guidelines)
4. [Pull requests](#pull-request)
5. [Pull request guidelines](#pull-request-guidelines)
## Questions?!?
2013-09-14 16:39:10 +00:00
To get your questions answered, please ask/search on [Fabric's google group], [StackOverflow] or on Fabric's IRC channel (irc://irc.freenode.net/#fabric.js).
Please do not open an issue if you're not sure it's a bug or if it's not a feature/suggestion.
2013-09-14 11:32:44 +00:00
2018-02-04 23:05:12 +00:00
For news about Fabric you can follow [@fabric.js], [@AndreaBogazzi], [@kangax], or [@kienzle_s] on Twitter.
2013-09-14 11:32:44 +00:00
Demos and examples can be found on [jsfiddle], [codepen.io] and [fabricjs.com].
## Issue tracker
2013-09-14 16:39:10 +00:00
If you are sure that it's a bug in Fabric.js or a suggestion, open a new [issue] and try to answer the following questions:
2013-09-14 11:32:44 +00:00
- What did you do?
- What did you expect to happen?
- What happened instead?
### Issue tracker guidelines
2013-09-14 16:39:10 +00:00
- **Search:** Before opening a new issue please [search](https://github.com/kangax/fabric.js/search?q=&ref=cmdform&type=Issues) Fabric's existing issues.
2013-09-14 11:32:44 +00:00
2013-09-14 16:39:10 +00:00
- **Title:** Choose an informative title.
2013-09-14 11:32:44 +00:00
- **Description:** Use the questions above to describe the issue. Add logs, screenshots or videos if that makes sense.
- **Test case:** Please post code to replicate the bug - best on [jsfiddle](http://jsfiddle.net). Ideally a failing test would be
2013-09-14 16:39:10 +00:00
perfect, but even a simple script demonstrating the error would suffice. You could use [this jsfiddle template](http://jsfiddle.net/fabricjs/Da7SP/) as a
2013-09-14 11:32:44 +00:00
starting point.
2013-12-14 11:10:42 +00:00
- **Fabric.js version:** Make sure to specify which version of Fabric.js you are using. The version can be found in [fabric.js file](https://github.com/kangax/fabric.js/blob/master/dist/fabric.js#L5) or just by executing `fabric.version` in the browser console.
2013-09-14 11:32:44 +00:00
## Pull requests
2013-09-14 16:39:10 +00:00
We are very grateful for your pull requests! This is your chance to improve Fabric for everyone else.
2013-09-14 11:32:44 +00:00
### Pull request guidelines
Here are a few notes you should take into account:
2013-09-14 16:39:10 +00:00
- **Code style, notes:** Make sure you have complied with the [guidelines](https://github.com/kangax/fabric.js/wiki/How-to-contribute-to-Fabric#code-style-notes)
2013-09-14 11:32:44 +00:00
- **Distribution files:** Do your changes only in the [source files](https://github.com/kangax/fabric.js/tree/master/src). Don't include the [distribution files](https://github.com/kangax/fabric.js/tree/master/dist) in your commit.
2013-09-14 16:39:10 +00:00
- **Add tests**: Tests are always a great addition - invest a little time and expand the [unit tests suite](https://github.com/kangax/fabric.js/tree/master/test/unit). More informations about [QUnit](http://qunitjs.com/) tests can be found in the [wiki](https://github.com/kangax/fabric.js/wiki/How-to-contribute-to-Fabric#testing-fabric).
2013-09-14 11:32:44 +00:00
2013-09-14 16:39:10 +00:00
- **Add documentation:** Fabric uses [JSDoc 3] for documentation. The generated documentation can be found at [fabricjs.com](http://fabricjs.com/docs).
2013-09-14 11:32:44 +00:00
- **Create topic branches.** Don't use your master branch for pull request. It's better to create a new branch for every pull request.
2013-09-14 16:39:10 +00:00
- **One pull request per feature/bug**. If you want to do more than one thing, send multiple pull requests.
2013-09-14 11:32:44 +00:00
2013-09-14 16:39:10 +00:00
- **And there you go!** If you still have questions we're always happy to help. Also feel free to consult [wiki](https://github.com/kangax/fabric.js/wiki/How-to-contribute-to-Fabric).
2013-09-14 11:32:44 +00:00
[Fabric's google group]: https://groups.google.com/forum/#!forum/fabricjs
[stackoverflow]: http://stackoverflow.com/questions/tagged/fabricjs
[@fabric.js]: https://twitter.com/fabricjs
2018-02-04 23:05:12 +00:00
[@AndreaBogazzi]: https://twitter.com/AndreaBogazzi
2013-09-14 11:32:44 +00:00
[@kangax]: https://twitter.com/kangax
2013-09-14 16:39:10 +00:00
[@kienzle_s]: https://twitter.com/kienzle_s
2013-09-14 11:32:44 +00:00
[jsfiddle]: http://jsfiddle.net/user/fabricjs/fiddles
[codepen.io]: http://codepen.io/tag/fabricjs
[fabricjs.com]: http://fabricjs.com/demos
2018-02-04 23:05:12 +00:00
[fabricjs.com/docs]: http://fabricjs.com/docs
2013-09-14 11:32:44 +00:00
[JSDoc 3]: http://usejsdoc.org/
2013-09-14 16:39:10 +00:00
[issue]: https://github.com/kangax/fabric.js/issues