From 160e7e5deda2b94c2c3320576deed15543bb8297 Mon Sep 17 00:00:00 2001 From: kangax Date: Mon, 11 Feb 2013 13:22:05 +0100 Subject: [PATCH] Alias `fabric.Observable.fire` to `trigger`, similar to jQuery, Backbone, etc. Closes #401 --- src/observable.mixin.js | 10 +++++++++- test/unit/observable.js | 13 +++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/observable.mixin.js b/src/observable.mixin.js index db052141..692024fa 100644 --- a/src/observable.mixin.js +++ b/src/observable.mixin.js @@ -51,6 +51,7 @@ fabric.Observable = { /** * Fires event with an optional options object + * @deprecated since 1.0.7 * @method fire * @param {String} eventName * @param {Object} [options] @@ -80,4 +81,11 @@ fabric.Observable.on = fabric.Observable.observe; * @method off * @type function */ -fabric.Observable.off = fabric.Observable.stopObserving; \ No newline at end of file +fabric.Observable.off = fabric.Observable.stopObserving; + +/** + * Alias for fire + * @method trigger + * @type function + */ +fabric.Observable.trigger = fabric.Observable.fire; \ No newline at end of file diff --git a/test/unit/observable.js b/test/unit/observable.js index 0e6e4a39..5781c7be 100644 --- a/test/unit/observable.js +++ b/test/unit/observable.js @@ -98,4 +98,17 @@ test('event options', function() { foo.fire('foo:bar', { value: 'sekret' }); equal('sekret', someValue); +}); + +test('trigger', function() { + var foo = { }; + fabric.util.object.extend(foo, fabric.Observable); + + var eventFired = false; + foo.on('bar:baz', function() { + eventFired = true; + }); + + foo.trigger('bar:baz'); + equal(true, eventFired); }); \ No newline at end of file