From 39618701c2af7cb0c0aa9c4566d2ed337e730f97 Mon Sep 17 00:00:00 2001 From: boonkerz Date: Sat, 26 Jul 2014 13:17:30 +0200 Subject: [PATCH 1/2] Update to Fix select text in itext last letter issue #1429 This fixes the select issue. Currently i have not understand why this line exists. After delete nothing happen except the issue is fixt :) --- src/mixins/itext_click_behavior.mixin.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/mixins/itext_click_behavior.mixin.js b/src/mixins/itext_click_behavior.mixin.js index 3449b847..b872cdd8 100644 --- a/src/mixins/itext_click_behavior.mixin.js +++ b/src/mixins/itext_click_behavior.mixin.js @@ -268,10 +268,6 @@ fabric.util.object.extend(fabric.IText.prototype, /** @lends fabric.IText.protot newSelectionStart = this.text.length; } - if (j === jlen) { - newSelectionStart--; - } - return newSelectionStart; } }); From c20a3b1482241f0b17b187ed9d03c0c3e28cb80c Mon Sep 17 00:00:00 2001 From: boonkerz Date: Sun, 27 Jul 2014 02:21:24 +0200 Subject: [PATCH 2/2] Fix for Linter Fix for Linter #1429 --- src/mixins/itext_click_behavior.mixin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mixins/itext_click_behavior.mixin.js b/src/mixins/itext_click_behavior.mixin.js index b872cdd8..b55fd814 100644 --- a/src/mixins/itext_click_behavior.mixin.js +++ b/src/mixins/itext_click_behavior.mixin.js @@ -239,7 +239,7 @@ fabric.util.object.extend(fabric.IText.prototype, /** @lends fabric.IText.protot if (mouseOffset.y < height) { return this._getNewSelectionStartFromOffset( - mouseOffset, prevWidth, width, charIndex + i, jlen, j); + mouseOffset, prevWidth, width, charIndex + i, jlen); } } @@ -252,7 +252,7 @@ fabric.util.object.extend(fabric.IText.prototype, /** @lends fabric.IText.protot /** * @private */ - _getNewSelectionStartFromOffset: function(mouseOffset, prevWidth, width, index, jlen, j) { + _getNewSelectionStartFromOffset: function(mouseOffset, prevWidth, width, index, jlen) { var distanceBtwLastCharAndCursor = mouseOffset.x - prevWidth, distanceBtwNextCharAndCursor = width - mouseOffset.x,