From fe4f988da0faff06e8b637bd0a308635ad79fe00 Mon Sep 17 00:00:00 2001
From: Andrea Bogazzi <andreabogazzi79@gmail.com>
Date: Sun, 17 Feb 2019 21:38:44 +0100
Subject: [PATCH] added a visual test

---
 src/shapes/object.class.js       |   4 +-
 test/visual/generic_rendering.js |  68 +++++++++++++++++++++++++++++++
 test/visual/golden/generic1.png  | Bin 0 -> 377 bytes
 3 files changed, 70 insertions(+), 2 deletions(-)
 create mode 100644 test/visual/generic_rendering.js
 create mode 100644 test/visual/golden/generic1.png

diff --git a/src/shapes/object.class.js b/src/shapes/object.class.js
index fe7c1504..1abeb320 100644
--- a/src/shapes/object.class.js
+++ b/src/shapes/object.class.js
@@ -607,7 +607,7 @@
       'top left width height scaleX scaleY flipX flipY originX originY transformMatrix ' +
       'stroke strokeWidth strokeDashArray strokeLineCap strokeDashOffset strokeLineJoin strokeMiterLimit ' +
       'angle opacity fill globalCompositeOperation shadow clipTo visible backgroundColor ' +
-      'skewX skewY fillRule paintFirst clipPath'
+      'skewX skewY fillRule paintFirst clipPath strokeUniform'
     ).split(' '),
 
     /**
@@ -618,7 +618,7 @@
      * @type Array
      */
     cacheProperties: (
-      'fill stroke strokeWidth strokeDashArray width height paintFirst' +
+      'fill stroke strokeWidth strokeDashArray width height paintFirst strokeUniform' +
       ' strokeLineCap strokeDashOffset strokeLineJoin strokeMiterLimit backgroundColor clipPath'
     ).split(' '),
 
diff --git a/test/visual/generic_rendering.js b/test/visual/generic_rendering.js
new file mode 100644
index 00000000..29988b57
--- /dev/null
+++ b/test/visual/generic_rendering.js
@@ -0,0 +1,68 @@
+(function() {
+  if (fabric.isLikelyNode) {
+    if (process.env.launcher === 'Firefox') {
+      fabric.browserShadowBlurConstant = 0.9;
+    }
+    if (process.env.launcher === 'Node') {
+      fabric.browserShadowBlurConstant = 1;
+    }
+    if (process.env.launcher === 'Chrome') {
+      fabric.browserShadowBlurConstant = 1.5;
+    }
+    if (process.env.launcher === 'Edge') {
+      fabric.browserShadowBlurConstant = 1.75;
+    }
+  }
+  else {
+    if (navigator.userAgent.indexOf('Firefox') !== -1) {
+      fabric.browserShadowBlurConstant = 0.9;
+    }
+    if (navigator.userAgent.indexOf('Chrome') !== -1) {
+      fabric.browserShadowBlurConstant = 1.5;
+    }
+    if (navigator.userAgent.indexOf('Edge') !== -1) {
+      fabric.browserShadowBlurConstant = 1.75;
+    }
+  }
+  fabric.enableGLFiltering = false;
+  fabric.isWebglSupported = false;
+  fabric.Object.prototype.objectCaching = true;
+  var visualTestLoop;
+  if (fabric.isLikelyNode) {
+    visualTestLoop = global.visualTestLoop;
+  }
+  else {
+    visualTestLoop = window.visualTestLoop;
+  }
+  var fabricCanvas = this.canvas = new fabric.Canvas(null, {
+    enableRetinaScaling: false, renderOnAddRemove: false, width: 200, height: 200,
+  });
+
+  var tests = [];
+
+  function generic1(canvas, callback) {
+    canvas.setDimensions({ width: 150, height: 60 });
+    var rect = new fabric.Rect({
+      width: 20, height: 40, strokeWidth: 2, scaleX: 6, scaleY: 0.5, strokeUniform: true,
+      fill: '', stroke: 'red'
+    });
+    var rect2 = new fabric.Rect({
+      width: 60, height: 60, top: 4, left: 4, strokeWidth: 2, scaleX: 2,
+      scaleY: 0.5, strokeUniform: false, fill: '', stroke: 'blue',
+    });
+    canvas.add(rect);
+    canvas.add(rect2);
+    canvas.renderAll();
+    callback(canvas.lowerCanvasEl);
+  }
+
+  tests.push({
+    test: 'Rect with strokeUniform: true',
+    code: generic1,
+    golden: 'generic1.png',
+    newModule: 'DataURL exports',
+    percentage: 0.09,
+  });
+
+  tests.forEach(visualTestLoop(fabricCanvas, QUnit));
+})();
diff --git a/test/visual/golden/generic1.png b/test/visual/golden/generic1.png
new file mode 100644
index 0000000000000000000000000000000000000000..34e131a1a2707bcafa9087c3265f9e143fa37689
GIT binary patch
literal 377
zcmeAS@N?(olHy`uVBq!ia0vp^(}389gAGWwv^i%1DYhhUcNd2LAh=-f^2rPgjC!6f
zjv*Cu-rm{h$K)u|cCo&vHNSc3zIw)`dwTCiH0)5+5WC|YbAF}5%{Mul;?taqZW>OG
z<(qd%YOnf9k2ouFS>u_<&*#tOzWmJ6)6K|AJhtuYt(^wB+dS(dW}b{Wa`e=l*Z=I|
zc8E+|dm?G}uV?%ECe3~06k*GK`El{~UsWRCa%A{ryFdKr=oUJ(sAYqOqK+4K=A32H
z&k9Sv)=Wt>>)%ooTt3?;(r>~${%|An)68kd_WfP8W2x__%Qt-P+FaXeA1v|b_wBOl
z{5$s+{#zkE^Y+v4GZV$?SdVFLm?!)CkY}~nv$(2v>*HIe2#Be+xN;^2Iz^x{>plhv
h<j-dW1{o5VRm<?E-pI{;&FKV?sHdx+%Q~loCIEoToI3yj

literal 0
HcmV?d00001