From 9cf3a60deeb8b79b483d74e1d4d4dc0e47ef7cf8 Mon Sep 17 00:00:00 2001 From: James Brady Date: Wed, 27 Jul 2011 12:24:41 +0100 Subject: [PATCH] Consider data-role when picking page transition. Re-use existing "isDialog" variable in changePage, instead of just looking at settings.role. --- js/jquery.mobile.navigation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/jquery.mobile.navigation.js b/js/jquery.mobile.navigation.js index 804349ab..b3407a08 100644 --- a/js/jquery.mobile.navigation.js +++ b/js/jquery.mobile.navigation.js @@ -911,7 +911,7 @@ // Make sure we have a transition defined. settings.transition = settings.transition || ( ( historyDir && !activeIsInitialPage ) ? active.transition : undefined ) - || ( settings.role === "dialog" ? $.mobile.defaultDialogTransition : $.mobile.defaultPageTransition ); + || ( isDialog ? $.mobile.defaultDialogTransition : $.mobile.defaultPageTransition ); // If we're navigating back in the URL history, set reverse accordingly. settings.reverse = settings.reverse || historyDir < 0;