From ab751c8bdc7aa4356cb446a568f534bf199aeefd Mon Sep 17 00:00:00 2001 From: Rick Waldron Date: Tue, 28 Jun 2011 19:15:42 -0400 Subject: [PATCH] jQuery core style guide conformance: jquery.mobile.core.js --- js/jquery.mobile.core.js | 90 ++++++++++++++++++++-------------------- 1 file changed, 46 insertions(+), 44 deletions(-) diff --git a/js/jquery.mobile.core.js b/js/jquery.mobile.core.js index f2107a00..4f4a5ad9 100644 --- a/js/jquery.mobile.core.js +++ b/js/jquery.mobile.core.js @@ -9,61 +9,61 @@ (function( $, window, undefined ) { - //jQuery.mobile configurable options + // jQuery.mobile configurable options $.extend( $.mobile, { - //namespace used framework-wide for data-attrs. Default is no namespace + // Namespace used framework-wide for data-attrs. Default is no namespace ns: "", - //define the url parameter used for referencing widget-generated sub-pages. - //Translates to to example.html&ui-page=subpageIdentifier - //hash segment before &ui-page= is used to make Ajax request + // Define the url parameter used for referencing widget-generated sub-pages. + // Translates to to example.html&ui-page=subpageIdentifier + // hash segment before &ui-page= is used to make Ajax request subPageUrlKey: "ui-page", - //anchor links with a data-rel, or pages with a data-role, that match these selectors will be untrackable in history - //(no change in URL, not bookmarkable) + // Anchor links with a data-rel, or pages with a data-role, that match these selectors will be untrackable in history + // (no change in URL, not bookmarkable) nonHistorySelectors: "dialog", - //class assigned to page currently in view, and during transitions + // Class assigned to page currently in view, and during transitions activePageClass: "ui-page-active", - //class used for "active" button state, from CSS framework + // Class used for "active" button state, from CSS framework activeBtnClass: "ui-btn-active", - //automatically handle clicks and form submissions through Ajax, when same-domain + // Automatically handle clicks and form submissions through Ajax, when same-domain ajaxEnabled: true, - //When enabled, clicks and taps that result in Ajax page changes will happen slightly sooner on touch devices. - //Also, it will prevent the address bar from appearing on platforms like iOS during page transitions. - //This option has no effect on non-touch devices, but enabling it may interfere with jQuery plugins that bind to click events + // When enabled, clicks and taps that result in Ajax page changes will happen slightly sooner on touch devices. + // Also, it will prevent the address bar from appearing on platforms like iOS during page transitions. + // This option has no effect on non-touch devices, but enabling it may interfere with jQuery plugins that bind to click events useFastClick: true, - //automatically load and show pages based on location.hash + // Automatically load and show pages based on location.hash hashListeningEnabled: true, - //set default page transition - 'none' for no transitions + // Set default page transition - 'none' for no transitions defaultPageTransition: "slide", - //minimum scroll distance that will be remembered when returning to a page + // Minimum scroll distance that will be remembered when returning to a page minScrollBack: screen.height / 2, - //set default dialog transition - 'none' for no transitions + // Set default dialog transition - 'none' for no transitions defaultDialogTransition: "pop", - //show loading message during Ajax requests - //if false, message will not appear, but loading classes will still be toggled on html el + // Show loading message during Ajax requests + // if false, message will not appear, but loading classes will still be toggled on html el loadingMessage: "loading", - //error response message - appears when an Ajax page request fails + // Error response message - appears when an Ajax page request fails pageLoadErrorMessage: "Error Loading Page", - //support conditions that must be met in order to proceed - //default enhanced qualifications are media query support OR IE 7+ + // Support conditions that must be met in order to proceed + // default enhanced qualifications are media query support OR IE 7+ gradeA: function(){ return $.support.mediaquery || $.mobile.browser.ie && $.mobile.browser.ie >= 7; }, - //TODO might be useful upstream in jquery itself ? + // TODO might be useful upstream in jquery itself ? keyCode: { ALT: 18, BACKSPACE: 8, @@ -99,9 +99,9 @@ WINDOWS: 91 // COMMAND }, - //scroll page vertically: scroll to 0 to hide iOS address bar, or pass a Y value + // Scroll page vertically: scroll to 0 to hide iOS address bar, or pass a Y value silentScroll: function( ypos ) { - if( $.type( ypos ) !== "number" ){ + if ( $.type( ypos ) !== "number" ) { ypos = $.mobile.defaultHomeScroll; } @@ -110,50 +110,52 @@ setTimeout(function() { window.scrollTo( 0, ypos ); - $(document).trigger( "silentscroll", { x: 0, y: ypos }); - }, 20); + $( document ).trigger( "silentscroll", { x: 0, y: ypos }); + }, 20 ); setTimeout(function() { $.event.special.scrollstart.enabled = true; }, 150 ); }, - // take a data attribute property, prepend the namespace + // Take a data attribute property, prepend the namespace // and then camel case the attribute string - nsNormalize: function(prop){ - if(!prop) return; + nsNormalize: function( prop ) { + if ( !prop ) { + return; + } return $.camelCase( $.mobile.ns + prop ); } }); - //mobile version of data and removeData and hasData methods - //ensures all data is set and retrieved using jQuery Mobile's data namespace - $.fn.jqmData = function( prop, value ){ - return this.data( prop ? $.mobile.nsNormalize(prop) : prop, value ); + // Mobile version of data and removeData and hasData methods + // ensures all data is set and retrieved using jQuery Mobile's data namespace + $.fn.jqmData = function( prop, value ) { + return this.data( prop ? $.mobile.nsNormalize( prop ) : prop, value ); }; - $.jqmData = function( elem, prop, value ){ - return $.data( elem, $.mobile.nsNormalize(prop), value ); + $.jqmData = function( elem, prop, value ) { + return $.data( elem, $.mobile.nsNormalize( prop ), value ); }; - $.fn.jqmRemoveData = function( prop ){ - return this.removeData( $.mobile.nsNormalize(prop) ); + $.fn.jqmRemoveData = function( prop ) { + return this.removeData( $.mobile.nsNormalize( prop ) ); }; - $.jqmRemoveData = function( elem, prop ){ - return $.removeData( elem, $.mobile.nsNormalize(prop) ); + $.jqmRemoveData = function( elem, prop ) { + return $.removeData( elem, $.mobile.nsNormalize( prop ) ); }; - $.jqmHasData = function( elem, prop ){ - return $.hasData( elem, $.mobile.nsNormalize(prop) ); + $.jqmHasData = function( elem, prop ) { + return $.hasData( elem, $.mobile.nsNormalize( prop ) ); }; // Monkey-patching Sizzle to filter the :jqmData selector var oldFind = $.find; $.find = function( selector, context, ret, extra ) { - selector = selector.replace(/:jqmData\(([^)]*)\)/g, "[data-" + ($.mobile.ns || "") + "$1]"); + selector = selector.replace(/:jqmData\(([^)]*)\)/g, "[data-" + ( $.mobile.ns || "" ) + "$1]"); return oldFind.call( this, selector, context, ret, extra ); }; @@ -165,6 +167,6 @@ }; $.find.matchesSelector = function( node, expr ) { - return $.find( expr, null, null, [node] ).length > 0; + return $.find( expr, null, null, [ node ] ).length > 0; }; })( jQuery, this );