Hopiu/jquery-mobile
1
0
Fork 0
mirror of https://github.com/Hopiu/jquery-mobile.git synced 2026-04-05 15:10:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

removed urlHistory references to (and use of) each entry's "page" property, which kept a reference to the DOM elements of each page that had been loaded. This fixes leaking memory on removed pages, and outsources page requests to the browser cache (for real this time :) ).

Browse source
This commit is contained in:
scottjehl 2011-07-29 19:51:17 -04:00
parent 5c01f3f1e5
commit bdba60efd5
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
js/jquery.mobile.navigation.js
View file

@ -257,13 +257,13 @@
},
// addNew is used whenever a new page is added
addNew: function( url, transition, title, storedTo ) {
addNew: function( url, transition, title ) {
//if there's forward history, wipe it
if( urlHistory.getNext() ) {
urlHistory.clearForward();
}
urlHistory.stack.push( {url : url, transition: transition, title: title, page: storedTo } );
urlHistory.stack.push( {url : url, transition: transition, title: title } );
urlHistory.activeIndex = urlHistory.stack.length - 1;
},
@ -916,7 +916,7 @@
//add page to history stack if it's not back or forward
if( !historyDir ) {
urlHistory.addNew( url, settings.transition, pageTitle, toPage );
urlHistory.addNew( url, settings.transition, pageTitle );
}
//set page title
@ -1191,7 +1191,7 @@
// prevent changepage
return;
} else {
var setTo = function() { to = $.mobile.urlHistory.getActive().page; };
var setTo = function() { to = $( ":jqmData(url='" + $.mobile.urlHistory.getActive().url + "')" ); };
// if the current active page is a dialog and we're navigating
// to a dialog use the dialog objected saved in the stack
urlHistory.directHashChange({ currentUrl: to, isBack: setTo, isForward: setTo });