Hopiu/jquery-mobile
1
0
Fork 0
mirror of https://github.com/Hopiu/jquery-mobile.git synced 2026-04-21 06:40:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix for issues:

Browse source 
470 - Multiple Footers when using data-position=fixed and data-id=[someid]

773 - The fixHeaderFooter pagebeforeshow live function is not triggered for the initial page shown

- Removed the findStickyFooter() function.

- Reworked the logic in the pagebeforeshow live function. We now add a ui-sticky-footer class to the sticky footer element. This will guarantee that we find the sticky footer if it already exists. We may at some point want to consider the use of ids on the sticky footers so that we don't have to crawl the entire document.

- Moved the live pagebeforeshow and pageshow calls outside of the DOMReady function so that they get registered as soon as the plugin is loaded. This guarantees that they will be triggered when the core plugin's DOMReady function fires.

- This fix makes issue/pull-request 765 obsolete.
This commit is contained in:
Kin Blas 2011-01-07 01:07:22 -08:00
parent 2065a1916b
commit c910f4b01f
1 changed files with 31 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

60
js/jquery.mobile.fixHeaderFooter.js
View file

@ -62,36 +62,38 @@ $.fixedToolbars = (function(){
}
stateBefore = null;
});
//function to return another footer already in the dom with the same data-id
function findStickyFooter(el){
var thisFooter = el.find('[data-role="footer"]');
return $( '.ui-footer[data-id="'+ thisFooter.data('id') +'"]:not(.ui-footer-duplicate)' ).not(thisFooter);
}
//before page is shown, check for duplicate footer
$('.ui-page').live('pagebeforeshow', function(event, ui){
stickyFooter = findStickyFooter( $(event.target) );
if( stickyFooter.length ){
//if the existing footer is the first of its kind, create a placeholder before stealing it
if( stickyFooter.parents('.ui-page:eq(0)').find('.ui-footer[data-id="'+ stickyFooter.data('id') +'"]').length == 1 ){
stickyFooter.before( stickyFooter.clone().addClass('ui-footer-duplicate') );
}
$(event.target).find('[data-role="footer"]').addClass('ui-footer-duplicate');
stickyFooter.appendTo($.pageContainer).css('top',0);
setTop(stickyFooter);
}
});
//after page is shown, append footer to new page
$('.ui-page').live('pageshow', function(event, ui){
if( stickyFooter && stickyFooter.length ){
stickyFooter.appendTo(event.target).css('top',0);
}
$.fixedToolbars.show(true, this);
});
});
//before page is shown, check for duplicate footer
$('.ui-page').live('pagebeforeshow', function(event, ui){
var page = $(event.target);
var footer = page.find('[data-role="footer"]:not(.ui-sticky-footer)');
var id = footer.data('id');
if (id)
{
stickyFooter = $('.ui-footer[data-id="' + id + '"].ui-sticky-footer');
if (stickyFooter.length == 0) {
// No sticky footer exists for this data-id. We'll use this
// footer as the sticky footer for the group and then create
// a placeholder footer for the page.
stickyFooter = footer;
footer = stickyFooter.clone(); // footer placeholder
stickyFooter.addClass('ui-sticky-footer').before(footer);
}
footer.addClass('ui-footer-duplicate');
stickyFooter.appendTo($.pageContainer).css('top',0);
setTop(stickyFooter);
}
});
//after page is shown, append footer to new page
$('.ui-page').live('pageshow', function(event, ui){
if( stickyFooter && stickyFooter.length ){
stickyFooter.appendTo(event.target).css('top',0);
}
$.fixedToolbars.show(true, this);
});
// element.getBoundingClientRect() is broken in iOS 3.2.1 on the iPad. The
// coordinates inside of the rect it returns don't have the page scroll position