From 79c7a225b39f754e2cf7cf23b8d52c37b6332c55 Mon Sep 17 00:00:00 2001
From: Matthew Leon Grinshpun <vertespain@gmail.com>
Date: Sat, 15 Oct 2011 14:49:10 -0400
Subject: [PATCH 1/5] failing button ui shadow tests

---
 tests/unit/buttonMarkup/buttonMarkup_core.js | 9 +++++++++
 tests/unit/buttonMarkup/index.html           | 5 +++++
 2 files changed, 14 insertions(+)

diff --git a/tests/unit/buttonMarkup/buttonMarkup_core.js b/tests/unit/buttonMarkup/buttonMarkup_core.js
index 88f36565..8e78e4d7 100644
--- a/tests/unit/buttonMarkup/buttonMarkup_core.js
+++ b/tests/unit/buttonMarkup/buttonMarkup_core.js
@@ -15,4 +15,13 @@
 		same( group.find("a > span.ui-corner-right").length, 1, "only 1 right cornered button");
 		same( group.find("a > span:not(.ui-corner-left):not(.ui-corner-right)").length, linkCount - 2, "only 2 buttons are cornered");
 	});
+
+        test( "control group buttons should respect theme-related data attributes", function(){
+                var group = $("#control-group-content");
+
+                ok(!group.find('[data-shadow=false]').hasClass("ui-shadow"),
+                    "buttons with data-shadow=false should not have the ui-shadow class");
+                ok(!group.find('[data-corners=false]').hasClass("ui-corners"),
+                    "buttons with data-corners=false should not have the ui-corner class");
+        });
 })(jQuery);
diff --git a/tests/unit/buttonMarkup/index.html b/tests/unit/buttonMarkup/index.html
index e3108a1e..0e987ee2 100644
--- a/tests/unit/buttonMarkup/index.html
+++ b/tests/unit/buttonMarkup/index.html
@@ -24,6 +24,11 @@
 </ol>
 
 <div data-nstest-role="page" id="default">
+        <div data-role="content" id="control-group-content">
+          <a href="index.html" data-role="button" data-shadow="false">No shadow</a>
+          <a href="index.html" data-role="button" data-corners="false">No corners</a>
+          <a href="index.html" data-role="button" data-shadow="false" data-corners="false">No shadow or corners</a>
+        </div>
 	<div data-role="footer" id="control-group-footer" class="ui-bar" data-position="inline">
 		<div data-role="controlgroup" data-type="horizontal">
 			<a href="index.html" data-icon="delete">Remove</a>

From b1c3de990b407b0098d51da349c1133a2d99f194 Mon Sep 17 00:00:00 2001
From: Matthew Leon Grinshpun <vertespain@gmail.com>
Date: Sat, 15 Oct 2011 14:56:55 -0400
Subject: [PATCH 2/5] git both tests to fail

---
 tests/unit/buttonMarkup/buttonMarkup_core.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/unit/buttonMarkup/buttonMarkup_core.js b/tests/unit/buttonMarkup/buttonMarkup_core.js
index 8e78e4d7..7f3acd9c 100644
--- a/tests/unit/buttonMarkup/buttonMarkup_core.js
+++ b/tests/unit/buttonMarkup/buttonMarkup_core.js
@@ -21,7 +21,7 @@
 
                 ok(!group.find('[data-shadow=false]').hasClass("ui-shadow"),
                     "buttons with data-shadow=false should not have the ui-shadow class");
-                ok(!group.find('[data-corners=false]').hasClass("ui-corners"),
-                    "buttons with data-corners=false should not have the ui-corner class");
+                ok(!group.find('[data-corners=false]').hasClass("ui-btn-corner-all"),
+                    "buttons with data-corners=false should not have the ui-btn-corner-all class");
         });
 })(jQuery);

From 6ef1d6ea6c33f752c77796292072d2865f956962 Mon Sep 17 00:00:00 2001
From: Matthew Leon Grinshpun <vertespain@gmail.com>
Date: Sat, 15 Oct 2011 15:00:37 -0400
Subject: [PATCH 3/5] fix for shadows and corners

---
 js/jquery.mobile.buttonMarkup.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/js/jquery.mobile.buttonMarkup.js b/js/jquery.mobile.buttonMarkup.js
index 4bb9e11f..0c5e54d9 100644
--- a/js/jquery.mobile.buttonMarkup.js
+++ b/js/jquery.mobile.buttonMarkup.js
@@ -13,7 +13,9 @@ $.fn.buttonMarkup = function( options ) {
 				icon: el.jqmData( "icon" ),
 				iconpos: el.jqmData( "iconpos" ),
 				theme: el.jqmData( "theme" ),
-				inline: el.jqmData( "inline" )
+				inline: el.jqmData( "inline" ),
+                                shadow: el.jqmData( "shadow" ),
+                                corners: el.jqmData( "corners" )
 			}, options ),
 
 			// Classes Defined

From 62459c7cca4d47c497605321af374e2410ad254b Mon Sep 17 00:00:00 2001
From: Matthew Leon Grinshpun <vertespain@gmail.com>
Date: Sat, 15 Oct 2011 15:09:45 -0400
Subject: [PATCH 4/5] fix for button iconshadow

---
 js/jquery.mobile.buttonMarkup.js             | 3 ++-
 tests/unit/buttonMarkup/buttonMarkup_core.js | 2 ++
 tests/unit/buttonMarkup/index.html           | 1 +
 3 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/js/jquery.mobile.buttonMarkup.js b/js/jquery.mobile.buttonMarkup.js
index 0c5e54d9..050d33cc 100644
--- a/js/jquery.mobile.buttonMarkup.js
+++ b/js/jquery.mobile.buttonMarkup.js
@@ -15,7 +15,8 @@ $.fn.buttonMarkup = function( options ) {
 				theme: el.jqmData( "theme" ),
 				inline: el.jqmData( "inline" ),
                                 shadow: el.jqmData( "shadow" ),
-                                corners: el.jqmData( "corners" )
+                                corners: el.jqmData( "corners" ),
+                                iconshadow: el.jqmData( "iconshadow" )
 			}, options ),
 
 			// Classes Defined
diff --git a/tests/unit/buttonMarkup/buttonMarkup_core.js b/tests/unit/buttonMarkup/buttonMarkup_core.js
index 7f3acd9c..58aba0ea 100644
--- a/tests/unit/buttonMarkup/buttonMarkup_core.js
+++ b/tests/unit/buttonMarkup/buttonMarkup_core.js
@@ -23,5 +23,7 @@
                     "buttons with data-shadow=false should not have the ui-shadow class");
                 ok(!group.find('[data-corners=false]').hasClass("ui-btn-corner-all"),
                     "buttons with data-corners=false should not have the ui-btn-corner-all class");
+                ok(!group.find('[data-iconshadow=false] .ui-icon').hasClass("ui-icon-shadow"),
+                    "buttons with data-iconshadow=false should not have the ui-icon-shadow class on their icons");
         });
 })(jQuery);
diff --git a/tests/unit/buttonMarkup/index.html b/tests/unit/buttonMarkup/index.html
index 0e987ee2..2263e2ba 100644
--- a/tests/unit/buttonMarkup/index.html
+++ b/tests/unit/buttonMarkup/index.html
@@ -28,6 +28,7 @@
           <a href="index.html" data-role="button" data-shadow="false">No shadow</a>
           <a href="index.html" data-role="button" data-corners="false">No corners</a>
           <a href="index.html" data-role="button" data-shadow="false" data-corners="false">No shadow or corners</a>
+          <a href="index.html" data-role="button" data-icon="delete" data-iconshadow="false">No iconshadow</a>
         </div>
 	<div data-role="footer" id="control-group-footer" class="ui-bar" data-position="inline">
 		<div data-role="controlgroup" data-type="horizontal">

From 8b713b26f3988a78a432f085d7152d8674a831ab Mon Sep 17 00:00:00 2001
From: Matthew Leon Grinshpun <vertespain@gmail.com>
Date: Sat, 15 Oct 2011 15:13:21 -0400
Subject: [PATCH 5/5] add button tag

---
 tests/unit/buttonMarkup/index.html | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/unit/buttonMarkup/index.html b/tests/unit/buttonMarkup/index.html
index 2263e2ba..20946213 100644
--- a/tests/unit/buttonMarkup/index.html
+++ b/tests/unit/buttonMarkup/index.html
@@ -29,6 +29,7 @@
           <a href="index.html" data-role="button" data-corners="false">No corners</a>
           <a href="index.html" data-role="button" data-shadow="false" data-corners="false">No shadow or corners</a>
           <a href="index.html" data-role="button" data-icon="delete" data-iconshadow="false">No iconshadow</a>
+          <button data-shadow="false" data-corners="false" data-icon="delete" data-iconshadow="false">None of the above</button>
         </div>
 	<div data-role="footer" id="control-group-footer" class="ui-bar" data-position="inline">
 		<div data-role="controlgroup" data-type="horizontal">