Hopiu/jquery-mobile
1
0
Fork 0
mirror of https://github.com/Hopiu/jquery-mobile.git synced 2026-03-16 22:10:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix for cached page removal breaking dialog sized select menus Fixes #2181

Browse source
This commit is contained in:
John Bender 2011-08-01 18:08:03 -07:00
parent f7d5d918ae
commit f1d964e9e9
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
js/jquery.mobile.forms.select.js
View file

@ -230,7 +230,6 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
})
.delegate( "li:not(.ui-disabled, .ui-li-divider)", "vclick", function( event ) {
var $this = $( this ),
// index of option tag to be selected
oldIndex = select[ 0 ].selectedIndex,
@ -484,6 +483,10 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
}
if ( menuHeight > screenHeight - 80 || !$.support.scrollTop ) {
// prevent the parent page from being removed from the DOM,
// otherwise the results of selecting a list item in the dialog
// fall into a black hole
self.thisPage.unbind( "pagehide.remove" );
//for webos (set lastscroll using button offset)
if ( scrollTop == 0 && btnOffset > screenHeight ) {
@ -577,6 +580,13 @@ $.widget( "mobile.selectmenu", $.mobile.widget, {
var self = this;
if ( self.menuType == "page" ) {
// rebind the page remove that was unbound in the open function
// to allow for the parent page removal from actions other than the use
// of a dialog sized custom select
self.thisPage.bind( "pagehide.remove", function(){
$(this).remove();
});
// doesn't solve the possible issue with calling change page
// where the objects don't define data urls which prevents dialog key
// stripping - changePage has incoming refactor