From ff8a1ceefa94e8a100fee0aefd715c32482db663 Mon Sep 17 00:00:00 2001 From: John Bender Date: Mon, 8 Aug 2011 13:53:53 -0700 Subject: [PATCH] .call on shared --- js/jquery.mobile.forms.select.custom.js | 4 +--- js/jquery.mobile.forms.select.js | 7 ++++--- js/jquery.mobile.forms.select.native.js | 11 +++-------- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/js/jquery.mobile.forms.select.custom.js b/js/jquery.mobile.forms.select.custom.js index a9a5463b..674dcbb5 100644 --- a/js/jquery.mobile.forms.select.custom.js +++ b/js/jquery.mobile.forms.select.custom.js @@ -8,10 +8,8 @@ (function( $, undefined ) { $.widget( "mobile.customselect", $.mobile.widget, { - _shared: $.mobile.selectShared, - _create: function() { - var widget = this, shared = this._shared(); + var widget = this, shared = $.mobile.selectShared.call(this); $.extend( widget, shared, { typeName: 'custom', diff --git a/js/jquery.mobile.forms.select.js b/js/jquery.mobile.forms.select.js index 37ccfc91..fcfb6f39 100644 --- a/js/jquery.mobile.forms.select.js +++ b/js/jquery.mobile.forms.select.js @@ -26,13 +26,14 @@ $.widget( "mobile.selectmenu", $.mobile.widget, { }, _create: function() { + var menu; if (this.options.nativeMenu ) { - var menu = $( this.element ).nativeselect().data( "nativeselect" ); + menu = $( this.element ).nativeselect().data( "nativeselect" ); } else { - var menu = $( this.element ).customselect().data( "customselect" ); + menu = $( this.element ).customselect().data( "customselect" ); } - + var self = this, o = this.options, diff --git a/js/jquery.mobile.forms.select.native.js b/js/jquery.mobile.forms.select.native.js index d821b4d1..1182b994 100644 --- a/js/jquery.mobile.forms.select.native.js +++ b/js/jquery.mobile.forms.select.native.js @@ -8,12 +8,10 @@ (function( $, undefined ) { $.widget( "mobile.nativeselect", $.mobile.widget, { - _shared: $.mobile.selectShared, - _create: function() { var widget = this; - $.extend( widget, widget._shared(), { + $.extend( widget, $.mobile.selectShared.call(this), { typgeName: 'native', button: $( "
" ) @@ -46,11 +44,8 @@ $.widget( "mobile.nativeselect", $.mobile.widget, { }, refresh: function() { - var self = this, - selected = this.selected(); - - self.setButtonText(); - self.setButtonCount(); + this.setButtonText(); + this.setButtonCount(); } }); })( jQuery );