Commit graph

190 commits

Author SHA1 Message Date
Kin Blas
b31825a1d7 Fixed issue 1767 - loadPage/changePage broken in trunk (latest build)
- Not sure how/why I added that extra absUrl, but its gone now.
2011-06-02 10:41:55 -07:00
Kin Blas
ef9d55f4b6 Hopefully the last set of fixes for issue 1712 - $.mobile.changePage broken in latest
- The test case calls changePage() with a hash ("#b"). In our normal processing of clicks/form submits we strip it before calling. The old code did a strip in changePage() just in case, so I added it back in to fix the last bug.
2011-05-27 10:53:19 -07:00
Kin Blas
6fdb90df17 Fixed a typo in $.mobile.loadPage.defaults. The default for the data property should be undefined, not the string "undefined". 2011-05-26 17:04:27 -07:00
Kin Blas
7befe9087a The signature of changePage() has changed but folks need some time to transition to using the new signature. I added code to changePage() that maps any old signature calls to changePage() into a new call. This should fix issue 1712 ($.mobile.changePage broken in latest). This code should be removed before shipping 1.0. 2011-05-26 16:39:09 -07:00
Kin Blas
bee8549a18 Fixed a bad typo caught by @johnbender and @gseguin.
- Replaced an un-intentional semi-colon with a comma.
2011-05-25 15:13:44 -07:00
scottjehl
8929ac33b9 Removed the ajaxLinksEnabled and ajaxFormsEnabled settings. These were deprecated in a4 and scheduled for removal. Automated link and form ajax handling can still be globally disabled via the ajaxEnabled option. 2011-05-24 16:08:30 -04:00
Kin Blas
786ef25e0a Changes to get the navigation unit tests green again.
- Modified changePage() to set isPageTransitioning earlier.
- Modified pageSequence() to allow the current changepage callback stack to unwind before firing off the next function in the sequence.
2011-05-23 14:30:40 -07:00
John Bender
dc530ea751 page sequence helper added, nav tests in a somewhat better state. the event trigger spot, namespace, and general setup are all up for debate 2011-05-21 22:15:12 -07:00
Kin Blas
5ba2cc975e Inverted the logic around ignoreNextHashChange so that it actually matches the name of the variable.
Modified the hashchange callback so that it specifies a "none" transition, instead of a false boolean, for the case where the hash changed and there is nothing on the urlHistory stack.
2011-05-20 15:19:54 -07:00
Kin Blas
edc94fb6ec The dialog "pop" unit test was failing because the active variable in changePage() was being dereferenced. The unit test clears the urlHistory.stack array manually so we just need to make sure we don't dereference active if it doesn't exist. 2011-05-19 17:01:26 -07:00
Kin Blas
59afbda49b Added a pageContainer option to changePage and loadPage. 2011-05-18 18:06:15 -07:00
Kin Blas
3a047112a0 Removed debug try/catch block I accidentally checked in.
Made lots of whitespace changes to bring file up to jquery core style guidelines.
2011-05-18 16:38:04 -07:00
Kin Blas
cafb6acef9 Separated changePage() into 2 functions:
- loadPage() now loads all pages into the DOM.
	- changePage() only functions on pages that are in the DOM. If you call it with a URL instead of an element, it will call loadPage() which will then trigger a call to changePage() with the resulting page at a later time.
2011-05-18 15:58:15 -07:00
Kin Blas
b96310eedf - Externalize some of the nested functions in changePage().
- Modified changePage() so that it can take an options object. Updated all references throughout the framework.
- Split $.mobile.pageLoading() into 2 functions $.mobile.show/hidePageLoadingMsg(). Updated docs accordingly.
- Renamed $.mobile.defaultTransition to $.mobie.defaultPageTransition. Updated docs accordingly.
- Added $.mobile.defaultDialogTransition so that it isn't hard coded in the changePage/transitionPages and select code.
- Hand integrated jquery.mobile.navigation.js checkins from master: 4b4ee54a, e775f5e8, e597ccb3, 084bbbd8.
2011-05-16 16:02:26 -07:00
Kin Blas
52a666d71f Check $from before dereferencing it. 2011-04-26 16:36:31 -07:00
Kin Blas
19c06952fd Changes to allow 3rd party transitions. Developers can now register a custom transition by adding their transition handler to the $.mobile.transitionHandlers dictionary. The name of the custom transition is used as the key within the transtionsHandlers dictionary, and should be the same name used within the @data-transtion attribute.
The expected prototype for a transitionHandler is as follows:

function handler(name, reverse, $to, $from)

The name parameter is the name of the transition as specified by @data-transition attribute, reverse is a boolean that is false for a normal transition, and true for a reverse transition. The $to param is a jQuery collection containing the page that is being transitioned "to", and $from is an optional collection that tells us what page we are transitioning "from". Because $from is optional, handler developers should take care and check $from to make sure it is not undefined before attempting to dereference it.

In addition to registering custom transition by name, developers can specify a handler to use in the case where a transition name is specified and does not exist within the $.mobile.transitionHanlders dictionary. Within jQuery Mobile, the default handler for unknown transition types is the $.mobile.css3Transition() handler. This handler always assumes that the transition name is to be used as a CSS class to be placed on the $to and $from elements. To change the default handler, simply set $.mobile.defaultTransitionHandler to you function handler:

$.mobile.defaultTransitionHandler = myTransitionHandler;

The changes to make all this necessary are as follows:

- Created $.mobile.noneTransitionHandler which is the default transitionHandler for the framework that simply adds and removes the page active class on the $from and $to pages with no animations.

- Moved class based transition code into a new plugin jquery.mobile.transition.js file. This plugin, when present, overrides the noneTransitionHandler as the defaultTranstionHandler for the framework so that CSS3 animation transitions are available.

- Removed code related to the setting/removal of the ui-mobile-viewport-perspective class. The css3TransitionHandler plugin takes care of automatically placing a "viewport-<transition name>" class on the viewport (body) element. This allows any other transition to specify properties on the viewport that are necessary to accomplish the transition.

- changed the CSS class ui-mobile-viewport-perspective to viewport-flip to match code changes. This makes it more apparent that setting -webkit-perspective is only used with the flip transition.

- Updated js/index.php, Makefile and build.xml to include the new jquery.mobile.transition.js file.
2011-04-26 14:06:10 -07:00
Kin Blas
f7749504b8 Modified the vclick handler code in navgation.js so that it doesn't place the ui-btn-active class on any links meant for interactivity.
Removed the return false in the vclick handler of collapsible and replaced it with a preventDefault(). The only reason we were returning false was to stopPropagation() so that the vclick handler in navigation.js  didn't place a ui-btn-active on it.
2011-04-22 10:53:24 -07:00
Kin Blas
2d2e6d7741 Fix for issue 1461 - Tops of pages missing after dialog click in Safari and iPhone.
- Delayed the setting of focus till *AFTER* the scroll position is restored.
2011-04-21 15:31:21 -07:00
John Bender
dbd68472b4 whitespace and comment fixes 2011-04-18 22:35:13 -07:00
John Bender
8e42b52767 beginning to move to absolute hashes in all cases, still some more work to do 2011-04-18 21:46:53 -07:00
Kin Blas
c31ee33a0f Fix for 1407 - Bad scroll performance since A4 on iPhone 3G
- Modified vmouse code so that it uses $.data() instead of $().data() which is significantly faster.

- Modified the navigation and buttonMarkup code so they stop using live(). The vmouse code triggers several events during the touch events, which in turn causes the underlying event code to call $.closest() with the selector used during the live() call to figure out if the event should be handled. This turns out to be very expensive, so instead, we now just bind directly to the document, and walk the DOM manually to figure out if we should handle it. This is much faster since we are avoid triggering multiple nested function calls.
2011-04-18 16:13:50 -07:00
scottjehl
472cbb1778 moved calls into one. #cleaning 2011-04-17 14:24:47 -07:00
scottjehl
b649f17d9d one call to $.type 2011-04-17 12:11:03 -07:00
John Bender
2242684e59 added support for query params with dialog hash keys 2011-04-14 21:49:50 -07:00
John Bender
59bd1400ad check the url saved on the page element in the history stack to avoid checking agains the dialog nonsense url Fixes #1433 2011-04-14 21:49:50 -07:00
John Bender
aee4c631da removed stripQuery helper to reduce confusion and complexity as striping the query param from a url is much more complex than a hash as it was originally intended for 2011-04-12 01:14:05 -07:00
John Bender
a5add9a974 added handling for identical query param href/action on the same page 2011-04-12 00:58:24 -07:00
John Bender
8d3dc2cbc2 query param href/actions require absolute path prefixes when no relative path information is contained in the hash 2011-04-12 00:22:42 -07:00
John Bender
681f2a2073 handle relative query param links and forms Fixes #1160 2011-04-11 23:40:53 -07:00
John Bender
d6439d235f removed duplicate current page check in favor of fixing the off by one bug 2011-04-11 22:59:51 -07:00
John Bender
09b736a399 minor refactor from Scott's original suggestion on the issue 2011-04-10 22:59:06 -07:00
John Bender
c5ba91f0b9 navigation whitespace 2011-04-10 22:58:21 -07:00
scottjehl
3da5f05f75 wrapped the else if/else in an else to prevent an unnecessary dom walk until we have to make it. 2011-04-07 16:50:10 -04:00
scottjehl
97f5a9565f To ensure focus and scrollTo don't conflict (when possible), I set the focus order on page show to 1) previously clicked item if revisiting that page 2) page title 3) first focusable item in the page. Fixes #1342 2011-04-07 16:27:32 -04:00
scottjehl
b4088b9422 don't add the class to a disabled button. Fixes the checkbox test 2011-04-07 15:34:17 -04:00
scottjehl
cd0ad522ba moved the active state vclick to navigation 2011-04-07 15:28:52 -04:00
scottjehl
982b7d4b15 Make navigation feel more responsive through feedback, even though it actually uses the click event again for actual page changes.
- set active state on all button vclick events
- cancelled vclick on slider switch handles so it's not too sticky.
- removed addClass in navigation.js as the first change handles it there.
2011-04-07 14:41:45 -04:00
scottjehl
9a1b2dcb3c changed name of interal function loadComplete to pageChangeComplete 2011-04-07 11:33:04 -04:00
John Bender
05cc415f0c fix for current page links 2011-04-04 23:41:05 -07:00
Kin Blas
d43bbfc52a Switch back to hijacking links on the click event. We'll focus on improving "percieved" visual performance since launching a page load and transitions on vclick opens us up to too many problems:
- Third party click handlers never called.
	- Touch and click target mismatches due markup changes before the click events are generated. (What looks like a double click event)
2011-04-04 10:00:24 -07:00
John Bender
5c37beaa29 activeElement conditional for windows support Fixes #1294 2011-04-02 00:03:37 -07:00
Kin Blas
58369ec943 Added missing comma in var declaration. 2011-04-01 14:05:46 -07:00
Kin Blas
8cd0d2c679 I'm not sure how this happened, but the dataType fix for Issue 991 disappeared between commits 61005944 and 7503f62a.
Adding it back in to fix Issue 1349 - File urls still not working in alpha 4 as shipped.
2011-04-01 13:37:18 -07:00
John Bender
f2525b06de moved attribute call to jqmData call 2011-04-01 02:09:05 -07:00
John Bender
fad90ca99a navigation white space 2011-04-01 01:48:38 -07:00
Kin Blas
ae06612eca Clear our preventClickDefault and stopClickPropagation locals in the live click handler. 2011-03-31 14:39:11 -07:00
Kin Blas
3c69215ed6 Temporary workaround to keep 3rd party onclick handlers functioning. This stuff really needs to be done within the vmouse plugin. 2011-03-31 12:38:36 -07:00
scottjehl
07d20d9991 Merge remote branch 'origin/master' 2011-03-31 13:20:44 -04:00
scottjehl
ae6c2d569f fixed a duplicate check for using markup for page titles when title isn't present. 2011-03-31 13:20:19 -04:00
scottjehl
854885e93d move the pageTitle setter to different function 2011-03-31 12:56:48 -04:00