scottjehl
722ed2cbbf
If ajax is disabled, exit the click handler early and avoid parsing the href at all. Thanks for the idea, @toddparker! Fixes #1846 .
2011-06-17 18:33:16 -04:00
Kin Blas
525543b06d
Merge pull request #1662 from gseguin/issue-1654
...
Issue 1654
2011-06-17 09:41:22 -07:00
Ghislain Seguin
ff8517c915
Merge remote-tracking branch 'upstream/master' into issue-1654
...
Conflicts:
tests/unit/listview/listview_core.js
2011-06-17 09:37:36 -07:00
scottjehl
1dd6608829
remove active button state on buttons that close dialogs. Fixes #1839
2011-06-17 02:11:59 -04:00
Scott Jehl
0cff6336bd
Merge pull request #1489 from bernharduw/master
...
Radio buttons in nested listviews don't work. Fixes #1486
2011-06-16 22:41:16 -07:00
scottjehl
d2a6397983
added list filterTheme option. Available as data attribute data-filter-theme on listviews with filters enabled. Fixes #1790 - List view filter can not be themed.
...
Thanks for the idea @adamvaughan! Docs update coming next.
2011-06-17 00:59:17 -04:00
Scott Jehl
004f67d384
Merge pull request #1817 from wtw/master
...
Fixes #1549 .
2011-06-16 21:29:12 -07:00
scottjehl
fd738c5b04
Modified the listview thumbail-finding logic to specifically find first children of the li or the primary button's inner anchor element. Fixes #1794 . Fixes #1458
2011-06-17 00:21:11 -04:00
Scott Jehl
cc809da95c
Merge pull request #1828 from eddiemonge/bug_1825
...
Code guideline styling changes for collapsible.js
2011-06-16 20:59:23 -07:00
scottjehl
e06ae4a5b9
rolled back the change to looking up list filter placeholders. Seems to work fine as it was originally. Added a custom placeholder to the listview filter with headings demo page.
2011-06-16 23:47:04 -04:00
Scott Jehl
60f80b9473
Merge pull request #1838 from adamvaughan/issue1836
...
Fix for issue 1836 - List view filter placeholder data attribute is not used. Edits coming after this commit.
2011-06-16 20:37:40 -07:00
Kin Blas
96b3e710d4
Added utility functions $.mobile.getDocumentBase() and $.mobile.getDocumentUrl() so that developers can retrieve the original base and url used when loading the document.
2011-06-16 15:43:40 -07:00
Kin Blas
8b6d14bb03
Fix for issue 1826 - Nightly build - dialog box no longer rounded corners
...
- Don't set a default value for the 'role' option to loadPage() and changePage(). Instead, rely on the role attribute that is on the element.
- Fixed an error that was happening when a hash change involves going from a dialog back to another dialog. I had recently made changes that assumed the 'to' variable was always going to be a url string, but it turns out in the dialog back to dialog case, it is an actual jQuery collection.
2011-06-16 13:36:39 -07:00
Adam Vaughan
d1a958d1d7
Fix for issue 1836 - List view filter placeholder data attribute is not used.
2011-06-16 11:46:04 -06:00
Kin Blas
d2f115349a
Fix for issue 1833 - No page transition used when hitting the browser forward button
...
- Don't use the transition of the initial page on the stack.
2011-06-15 15:28:52 -07:00
jblas@adobe.com
dd69372dd4
Adjusted the urlParserRE regexp to account for double slashes in the directory path to work around a phonegap 0.9.4.
2011-06-15 10:37:08 -07:00
Eddie Monge
0de386eda9
Code guideline styling changes for collapsible.js
2011-06-14 15:32:57 -07:00
Todd Parker
7e40ddff4e
Merge pull request #1803 from eddiemonge/combine
...
minor changes to combine.php
2011-06-14 11:42:40 -07:00
Kin Blas
c011f51f14
Removed unused path.isRelative() function. Replaced unit tests for isRelative() with tests for path.isRelativeUrl.
2011-06-13 16:45:10 -07:00
Wolfram Twelker
41c1116aa2
Fixed ticket 1549 - no change event triggered on deselecting first
...
option in multiple-select
2011-06-11 17:12:15 +02:00
Kin Blas
e286808391
Rule of thumb ... get your logic right and your code will behave as you expect.
...
- I should've been using !== instead === when figuring out docBaseDiffers.
2011-06-10 16:13:58 -07:00
Kin Blas
963a84cb18
IE7 returns an empty string for regexp submatches while all other browsers return undefined. Modified the parseUrl() function to normalize all non-matches to an empty string and replaced all strict checks for undefined to strict checks for an empty string.
2011-06-10 15:31:09 -07:00
Kin Blas
244385b9f9
Merge branch 'master' into path-fixes
2011-06-10 10:02:11 -07:00
Kin Blas
b7bcf93620
- We were missing a changepage notification in the case where we were transitioning to the same page.
...
- Added changepagefailed notification for the case where the load fails. Note we still need beforeloadpage/loadpage notifications.
- Misc fixes to stop the navigation unit tests from seemingly random failures. It seems that the hash resets in setup/teardown of the test modules sometimes interferes with the changePage() requests in the tests. Added code to the setup/teardown functions to wait for the reset to complete before moving on to the tests.
2011-06-10 10:00:25 -07:00
Ghislain Seguin
4572200107
Coding standards
2011-06-10 09:40:41 -07:00
Ghislain Seguin
c9abc368d8
Issue #1762 : Removed extra iteration on list items
2011-06-10 09:40:15 -07:00
frietsch
d99d096ab7
Bugfix: ":jqmData(ajax='false')" might also match forms, which have neither of "src" or "href". In that case, thisUrl is undefined, and the following replace results in an error.
2011-06-09 08:21:21 -07:00
Eddie Monge
3688e8fa92
minor changes to combine.php
2011-06-09 01:51:37 -07:00
Kin Blas
3d6bd402a2
- Changes to get the navigation_helpers.js unit tests green.
...
- Modified isExternal so that it returns true/false to help with unit tests.
2011-06-08 17:20:01 -07:00
scottjehl
5512c8af02
use prop instead of attr for enable/disable
2011-06-08 18:12:42 -04:00
Kin Blas
eb082c27e3
Merge branch 'master' into path-fixes
...
Fixed Conflicts:
js/jquery.mobile.navigation.js
2011-06-08 15:10:16 -07:00
Kin Blas
8e1e77badf
Get deep linking to internal pages working again. We can now also deep link to nested list sub-pages that are contained within internal pages.
2011-06-08 15:06:41 -07:00
scottjehl
93e7afd4b1
make sure nested collapsible sets don't toggle their parent collapsibles when expanded. Fixes #1387
2011-06-08 18:00:26 -04:00
Kin Blas
33b9ee8052
Changes to make sure the data-url are either an id, site relative path (for same domain), or absolute Url (for cross-domain Phone Gap).
2011-06-08 14:47:24 -07:00
Kin Blas
a99728d178
- Added addSearchParams() utility function.
...
- Removed unused path functions: setOrigin(), makeAbsolute(), and isQuery().
- Modified loadPage() so that it uses addSearchParams() instead of naively appending it to the URL.
- Switched the global "click" handler back to using the link @href attribute and manually converting it to an absolute URL. This was necessary because it turns out that the href property on a link is dynamically calculated at the time of access based on the *CURRENT* base tag setting. This means the same link can return a different href value if the the base tag is different each time you access it.
2011-06-06 15:58:21 -07:00
Kin Blas
19f1a775b9
Missed a couple of places I should've used hrefNoHash when I converted documentBase to an urlObject.
2011-06-04 10:51:41 -07:00
Kin Blas
f9dd767528
Switched form handler over to processing absolute urls.
2011-06-04 01:22:16 -07:00
Kin Blas
ba502f0aff
Changes to switch the global link click handler over to processing absolute urls.
2011-06-04 00:26:25 -07:00
Ghislain Seguin
9d3862c825
Whitespace change
2011-06-03 19:02:13 -07:00
Kin Blas
b148ee424a
Added isSameDomain() Utility function.
2011-06-03 13:57:25 -07:00
Ghislain Seguin
3ee2585cba
Fix for issue #1617 : Nested lists with same parent text resolve to the same sub-page.
2011-06-03 10:55:04 -07:00
Kin Blas
b31825a1d7
Fixed issue 1767 - loadPage/changePage broken in trunk (latest build)
...
- Not sure how/why I added that extra absUrl, but its gone now.
2011-06-02 10:41:55 -07:00
Kin Blas
a2182dafa9
- Added a getClosestBaseUrl() utility function for calculating the correct base URL to use for a given element.
...
- We should be using makeUrlAbsolute() instead of makePathAbsolute() when calculating the documentBase.
- Removed bogus code in pathname calculatino in makeUrlAbsolute().
- Reworked calculation of search in makeUrlAbsolute() to prevent an undefined in the case where rel and abs urls have no search.
2011-06-01 17:15:18 -07:00
Kin Blas
3ca5dd854a
- Added URL parsing and relative to absolute path and url utility methods.
...
- Switched the base tag management code over to using new utilities.
2011-06-01 11:59:13 -07:00
eddiemonge
244cda822a
add white space for code standard
2011-05-31 14:44:31 -07:00
eddiemonge
0438418175
merge changes
2011-05-31 14:41:54 -07:00
Kin Blas
a5d3c05e4b
Merge branch 'dialogToCodeStandards' of https://github.com/StevenBlack/jquery-mobile into StevenBlack
...
Fixed Conflicts:
js/jquery.mobile.dialog.js
2011-05-31 14:14:05 -07:00
eddiemonge
d3df858eea
missed an equal sign
2011-05-27 12:13:48 -07:00
Kin Blas
991db0de46
Merge branch 'master' of https://github.com/jquery/jquery-mobile
2011-05-27 10:55:20 -07:00
Kin Blas
ef9d55f4b6
Hopefully the last set of fixes for issue 1712 - $.mobile.changePage broken in latest
...
- The test case calls changePage() with a hash ("#b"). In our normal processing of clicks/form submits we strip it before calling. The old code did a strip in changePage() just in case, so I added it back in to fix the last bug.
2011-05-27 10:53:19 -07:00