From 0c59cd5c1e19dc0394b95e8826fcef4eb63483a1 Mon Sep 17 00:00:00 2001 From: Chris Mayo Date: Tue, 20 Sep 2022 19:36:42 +0100 Subject: [PATCH] Don't use default values in configuration tests --- tests/configuration/data/config0.ini | 2 +- tests/configuration/test_config.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/configuration/data/config0.ini b/tests/configuration/data/config0.ini index b39239d6..f2e0d3cc 100644 --- a/tests/configuration/data/config0.ini +++ b/tests/configuration/data/config0.ini @@ -15,7 +15,7 @@ maxnumurls=1000 maxrunseconds=1 maxfilesizeparse=100 maxfilesizedownload=100 -resultcachesize=100000 +resultcachesize=9999 [filtering] ignore= diff --git a/tests/configuration/test_config.py b/tests/configuration/test_config.py index d65d3586..15fe6806 100644 --- a/tests/configuration/test_config.py +++ b/tests/configuration/test_config.py @@ -34,6 +34,8 @@ class TestConfig(unittest.TestCase): """Test configuration parsing.""" def test_confparse(self): + # Tests must either cover every possiblity or + # use a value other than the default config = linkcheck.configuration.Configuration() files = [get_file("config0.ini")] config.read(files) @@ -55,7 +57,7 @@ class TestConfig(unittest.TestCase): self.assertEqual(config["maxrunseconds"], 1) self.assertEqual(config["maxfilesizeparse"], 100) self.assertEqual(config["maxfilesizedownload"], 100) - self.assertEqual(config["resultcachesize"], 100000) + self.assertEqual(config["resultcachesize"], 9999) # filtering section patterns = [x["pattern"].pattern for x in config["externlinks"]] for prefix in ("ignore_", "nofollow_"):