Warn user before closing changed editor window.

doc/changelog.txt

@@ -13,6 +13,8 @@ Changes:
   scrolling down.
 - gui: Display release date in about dialog.
   Closes: SF bug #3297255
+- gui: Warn before closing changed editor window.
+  Closes: SF bug #3297245
 - doc: Improved warningregex example in default configuration file.
   Closes: SF bug #3297254
 

doc/todo.txt

@@ -1,5 +1,3 @@
-- [6.9] Warn before closing changed editor window.
-  SF bug #3297245
 - [6.9] Test download of large binary files.
   SF bug #3297970
 - [7.0] Put status info into GUI main window, do not make a modal window

linkcheck/gui/editor.py

@@ -79,6 +79,36 @@ class EditorWindow (QtGui.QDialog, Ui_EditorDialog):
         if self.editor.isModified() or not self.filename:
             self.save()
 
+    def closeEvent (self, e=None):
+        """Save settings and remove registered logging handler"""
+        if self.editor.isModified():
+            # ask if user wants to save
+            if self.wants_save():
+                if self.save():
+                    e.accept()
+                else:
+                    # saving error or user canceled
+                    e.ignore()
+            else:
+                # discard changes
+                e.accept()
+        else:
+            # unchanged
+            e.accept()
+
+    def wants_save (self):
+        """Ask user if he wants to save changes. Return True if user
+        wants to save, else False."""
+        dialog = QtGui.QMessageBox(parent=self)
+        dialog.setIcon(QtGui.QMessageBox.Question)
+        dialog.setWindowTitle(_("Save file?"))
+        dialog.setText(_("The document has been modified."))
+        dialog.setInformativeText(_("Do you want to save your changes?"))
+        dialog.setStandardButtons(QtGui.QMessageBox.Save |
+                                  QtGui.QMessageBox.Discard)
+        dialog.setDefaultButton(QtGui.QMessageBox.Save)
+        return dialog.exec_() == QtGui.QMessageBox.Save
+
     def save (self):
         """Save editor contents to file."""
         if not self.filename:
@@ -115,6 +145,7 @@ class EditorWindow (QtGui.QDialog, Ui_EditorDialog):
                 fh.close()
         if saved:
             self.saved.emit(self.filename)
+        return saved
 
     def load (self, filename):
         """Load editor contents from file."""