Remove HttpUrl.getheader()

This commit is contained in:
Chris Mayo 2020-07-07 17:25:28 +01:00
parent 1018b8332b
commit 53bd5c4d21

View file

@ -110,7 +110,7 @@ class HttpUrl(internpaturl.InternPatternUrl, proxysupport.ProxySupport):
# Note that content-encoding causes size differences since
# the content data is always decoded.
try:
self.size = int(self.getheader("Content-Length"))
self.size = int(self.headers["Content-Length"])
except (ValueError, OverflowError):
pass
else:
@ -284,17 +284,6 @@ class HttpUrl(internpaturl.InternPatternUrl, proxysupport.ProxySupport):
# run connection plugins for old connection
self.aggregate.plugin_manager.run_connection_plugins(self)
def getheader(self, name, default=None):
"""Get header value.
@return: header value or default of not found
@rtype: str
"""
value = self.headers.get(name)
if value is None:
return default
return value
def check_response(self):
"""Check final result and log it."""
if (
@ -314,7 +303,8 @@ class HttpUrl(internpaturl.InternPatternUrl, proxysupport.ProxySupport):
if self.url_connection.status_code == 429:
self.add_warning(
"Rate limited (Retry-After: %s)" % self.getheader(_("Retry-After")),
"Rate limited (Retry-After: %s)"
% self.headers.get(_("Retry-After")),
tag=WARN_URL_RATE_LIMITED,
)