Hopiu/linkchecker
1
0
Fork 0
mirror of https://github.com/Hopiu/linkchecker.git synced 2026-03-22 17:00:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix TestFile results not always ordered as expected values

Browse source 
self = <tests.checker.test_file.TestFile testMethod=test_good_dir_space>

    def test_good_dir_space (self):
...
>       self.direct(url, resultlines, recursionlevel=2)

tests/checker/test_file.py:173:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
tests/checker/__init__.py:260: in direct
    self.fail_unicode(text(os.linesep).join(l))
tests/checker/__init__.py:237: in fail_unicode
    self.fail(msg)
E   AssertionError: Differences found testing
This commit is contained in:
Marius Gedminas 2019-04-16 20:25:16 +01:00 committed by Chris Mayo
parent e93d18d6e9
commit 85cee2138d
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tests/checker/__init__.py
View file

@ -65,6 +65,11 @@ class TestLogger (linkcheck.logger._Logger):
# diff between expected and real output
self.diff = []
def normalize(self, result_log):
# XXX we assume that each log entry has a URL key, maybe we should add an assert into log_url() to that effect?
sep = '\nurl '
return sep.join(sorted('\n'.join(result_log).split(sep))).splitlines()
def start_output (self):
"""
Nothing to do here.
@ -119,6 +124,8 @@ class TestLogger (linkcheck.logger._Logger):
"""
Stores differences between expected and result in self.diff.
"""
self.expected = self.normalize(self.expected)
self.result = self.normalize(self.result)
for line in difflib.unified_diff(self.expected, self.result):
if not isinstance(line, unicode):
# The ---, +++ and @@ lines from diff format are ascii encoded.