From bbb8096df52e3e9477a80cdece299fc29d6d7fa9 Mon Sep 17 00:00:00 2001 From: Chris Mayo Date: Wed, 5 Oct 2022 19:27:13 +0100 Subject: [PATCH 1/2] Add @need_network to test_no_error() in test_ignoreerrors.py Needs network access for DNS: warning No MX mail host for example.com found. --- tests/checker/test_ignoreerrors.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/checker/test_ignoreerrors.py b/tests/checker/test_ignoreerrors.py index 8b2d3420..96dd4fb1 100644 --- a/tests/checker/test_ignoreerrors.py +++ b/tests/checker/test_ignoreerrors.py @@ -43,6 +43,7 @@ class TestFile(LinkCheckTest): ] self.direct(url, resultlines, confargs=confargs) + @need_network def test_no_error(self): """ Test that unmatched errors are not ignored. """ self._test("mailto:good@example.com", "", "", True) From f2be98b8ad51377d448951a5d3b43f48f7331b96 Mon Sep 17 00:00:00 2001 From: Chris Mayo Date: Wed, 5 Oct 2022 19:27:13 +0100 Subject: [PATCH 2/2] Replace deprecated dns.resolver.query() Missed in: 26c15c5e ("Fix deprecation warning for resolver.query()", 2020-09-14) --- linkcheck/checker/mailtourl.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linkcheck/checker/mailtourl.py b/linkcheck/checker/mailtourl.py index c2452579..536f0baa 100644 --- a/linkcheck/checker/mailtourl.py +++ b/linkcheck/checker/mailtourl.py @@ -328,7 +328,7 @@ class MailtoUrl(urlbase.UrlBase): tag=WARN_MAIL_NO_MX_HOST, ) try: - answers = resolver.query(domain, 'A') + answers = resolver.resolve(domain, 'A', search=True) except DNSException: answers = [] if len(answers) == 0: