From d9dbcb54073b3a50e2fe5604fe62108ed3337bb0 Mon Sep 17 00:00:00 2001
From: Bastian Kleineidam <calvin@debian.org>
Date: Tue, 23 Nov 2010 23:23:14 +0100
Subject: [PATCH] Optimize GUI by disabling sorting while a check is running.

---
 linkcheck/gui/__init__.py            | 7 ++-----
 linkcheck/gui/linkchecker_ui_main.py | 4 ++--
 linkcheck/gui/ui/main.ui             | 2 +-
 3 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/linkcheck/gui/__init__.py b/linkcheck/gui/__init__.py
index afdd5d87..52b01943 100644
--- a/linkcheck/gui/__init__.py
+++ b/linkcheck/gui/__init__.py
@@ -118,8 +118,6 @@ class LinkCheckerMain (QtGui.QMainWindow, Ui_MainWindow):
         self.treeView.setColumnWidth(1, data["col1"])
         self.treeView.setColumnWidth(2, data["col2"])
         self.treeView.setColumnWidth(3, data["col3"])
-        self.treeView.setSortingEnabled(True)
-        self.treeView.sortByColumn(0, QtCore.Qt.AscendingOrder)
 
     def get_treeviewcols (self):
         return dict(
@@ -161,8 +159,10 @@ class LinkCheckerMain (QtGui.QMainWindow, Ui_MainWindow):
             self.progress.hide()
             self.aggregate = None
             self.controlButton.setEnabled(True)
+            self.treeView.setSortingEnabled(True)
         elif status == Status.checking:
             self.num = 0
+            self.treeView.setSortingEnabled(False)
             self.debug.reset()
             self.progress.reset()
             self.progress.show()
@@ -227,14 +227,12 @@ Version 2 or later.</p>
 
     def check (self):
         """Check given URL."""
-        self.controlButton.setEnabled(False)
         self.model.clear()
         self.set_config()
         aggregate = director.get_aggregate(self.config)
         url = unicode(self.urlinput.text()).strip()
         if not url:
             self.set_statusbar(_("Error, empty URL"))
-            self.status = Status.idle
             return
         if url.startswith(u"www."):
             url = u"http://%s" % url
@@ -247,7 +245,6 @@ Version 2 or later.</p>
         except UnicodeError:
             self.set_statusbar(_("Error, invalid URL `%s'.") %
                                   strformat.limit(url, 40))
-            self.status = Status.idle
             return
         aggregate.urlqueue.put(url_data)
         self.aggregate = aggregate
diff --git a/linkcheck/gui/linkchecker_ui_main.py b/linkcheck/gui/linkchecker_ui_main.py
index 2ca12a75..21bacdaf 100644
--- a/linkcheck/gui/linkchecker_ui_main.py
+++ b/linkcheck/gui/linkchecker_ui_main.py
@@ -2,7 +2,7 @@
 
 # Form implementation generated from reading ui file 'ui/main.ui'
 #
-# Created: Sun Nov 21 14:22:48 2010
+# Created: Tue Nov 23 23:03:33 2010
 #      by: PyQt4 UI code generator 4.7.3
 #
 # WARNING! All changes made in this file will be lost!
@@ -61,7 +61,7 @@ class Ui_MainWindow(object):
         self.treeView.setAlternatingRowColors(True)
         self.treeView.setUniformRowHeights(True)
         self.treeView.setItemsExpandable(False)
-        self.treeView.setSortingEnabled(True)
+        self.treeView.setSortingEnabled(False)
         self.treeView.setAllColumnsShowFocus(True)
         self.treeView.setExpandsOnDoubleClick(False)
         self.treeView.setObjectName("treeView")
diff --git a/linkcheck/gui/ui/main.ui b/linkcheck/gui/ui/main.ui
index 1fcfc3b5..6d3023bf 100644
--- a/linkcheck/gui/ui/main.ui
+++ b/linkcheck/gui/ui/main.ui
@@ -128,7 +128,7 @@
        <bool>false</bool>
       </property>
       <property name="sortingEnabled">
-       <bool>true</bool>
+       <bool>false</bool>
       </property>
       <property name="allColumnsShowFocus">
        <bool>true</bool>