From 14ce371007d2a97699905c1ac2a7a82c5e744d14 Mon Sep 17 00:00:00 2001 From: Simon Willison Date: Sat, 1 Jul 2023 11:06:28 -0700 Subject: [PATCH] Fix plugins tests to account for default plugins --- tests/test_plugins.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/test_plugins.py b/tests/test_plugins.py index 029608c..37ac3fc 100644 --- a/tests/test_plugins.py +++ b/tests/test_plugins.py @@ -7,7 +7,11 @@ import pytest def test_register_commands(): importlib.reload(cli) - assert plugins.get_plugins() == [] + + def plugin_names(): + return [plugin["name"] for plugin in plugins.get_plugins()] + + assert "HelloWorldPlugin" not in plugin_names() class HelloWorldPlugin: __name__ = "HelloWorldPlugin" @@ -23,9 +27,7 @@ def test_register_commands(): plugins.pm.register(HelloWorldPlugin(), name="HelloWorldPlugin") importlib.reload(cli) - assert plugins.get_plugins() == [ - {"name": "HelloWorldPlugin", "hooks": ["register_commands"]} - ] + assert "HelloWorldPlugin" in plugin_names() runner = CliRunner() result = runner.invoke(cli.cli, ["hello-world"]) @@ -35,4 +37,4 @@ def test_register_commands(): finally: plugins.pm.unregister(name="HelloWorldPlugin") importlib.reload(cli) - assert plugins.get_plugins() == [] + assert "HelloWorldPlugin" not in plugin_names()